WebKit-https.git
7 years agoGive a smaller viewport to webkit.org on devices
benjamin@webkit.org [Thu, 8 Aug 2013 22:46:05 +0000 (22:46 +0000)]
Give a smaller viewport to webkit.org on devices

Rubberstamped by Simon Fraser.

The CSS of WebKit.org layout the content on 615px + a right margin of
215px + a left margin of 20px. The total layout width is 850px.

The standard viewport size on mobile devices is 980px. This leaves a gap
on the right side of the content when opening the size on iPhone/iPad.

This patch changes the layout width to be 860 to display more content on devices
while keeping a little margin.

* header.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] loader/go-back-cached-main-resource.html fails
ap@apple.com [Thu, 8 Aug 2013 22:38:04 +0000 (22:38 +0000)]
    [WK2] loader/go-back-cached-main-resource.html fails
        https://bugs.webkit.org/show_bug.cgi?id=116491

        Reviewed by Tim Horton.

        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        Added FIXMEs about making path printing normalization more compatible.

        * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
        Return last path component in cases where we used to return a full path, which is
        never desirable. Added a null check to basePath to prevent potentially getting
        an Objective C exception.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
        for a currently loading one (which is different for tests that use multiple windows).
        Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
        last path component as last fallback.
        (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
        frame URL here, and it was potentially a wrong frame.
        (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
        (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
        (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
        (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
        (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EME] setMediaKeys function as defined in the EME specification does not work
jer.noble@apple.com [Thu, 8 Aug 2013 22:29:16 +0000 (22:29 +0000)]
[EME] setMediaKeys function as defined in the EME specification does not work
https://bugs.webkit.org/show_bug.cgi?id=119597

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests; updated media/encrypted-media/encrypted-media-v2-syntax.html

Rename the mediaKeys attribute 'keys' and make readonly, and add an explicit
setMediaKeys() method in HTMLMediaElement's IDL.

* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::keys):
* html/HTMLMediaElement.idl:

LayoutTests:

* media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
* media/encrypted-media/encrypted-media-v2-syntax.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHashing SecurityOrigin's can lead to trouble if you mutate them :(
weinig@apple.com [Thu, 8 Aug 2013 22:01:05 +0000 (22:01 +0000)]
Hashing SecurityOrigin's can lead to trouble if you mutate them :(
https://bugs.webkit.org/show_bug.cgi?id=119533
<rdar://problem/12978338>

Reviewed by Andreas Kling.

We are getting into trouble in the following circumstance:
- You have a HashMap<RefPtr<SecurityOrigin>, Value> map.
- You add security origin A (http, www.webkit.org, 80) to the map.
- You mutate security origin A by domain relaxation, so that it has the domain webkit.org.
- You add security origin B (http, www.webkit.org, 80) to the map.
- You mutate security origin B by domain relaxation, so that it has the domain webkit.org.
    You now have two identical keys in the map.
- Add few more items to the map causing a rehash.
- When you try to add A and B back into the map, you will have a collision, because they now equal each other.

We should probably stop using SecurityOrigins as keys in HashMaps (and move to using a non-mutable SecurityOriginTuple,
or something), but for now, we can just only use the scheme / host / port part for equality, which is what all the users
really want.

* page/SecurityOriginHash.h:
(WebCore::SecurityOriginHash::equal):
Switch to using isSameSchemeHostPort() for SecurityOriginHash::equal().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd logging to the primary plugin detection
dino@apple.com [Thu, 8 Aug 2013 21:33:37 +0000 (21:33 +0000)]
Add logging to the primary plugin detection
https://bugs.webkit.org/show_bug.cgi?id=119594

Reviewed by Tim Horton.

Add some simple logging to our primary plug-in detection.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes
rwlbuis@webkit.org [Thu, 8 Aug 2013 21:19:27 +0000 (21:19 +0000)]
ASSERT_NOT_REACHED() touched in WebCore::SVGAnimatedStringAnimator::addAnimatedTypes
https://bugs.webkit.org/show_bug.cgi?id=113224

Reviewed by Dirk Schulze.

Source/WebCore:

Do not perform from-by animations for non-additive attributes.

Test: svg/animations/non-additive-type-from-by-animation.html

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateFromAndByValues):

LayoutTests:

Add a test for animating non-additive attributes in from-by animations

* svg/animations/non-additive-type-from-by-animation-expected.txt: Added.
* svg/animations/non-additive-type-from-by-animation.html: Added.
* svg/animations/resources/non-additive-type-from-by-animation.svg: Added.
* svg/animations/script-tests/non-additive-type-from-by-animation.js: Added.
(sample):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofullscreen/exit-full-screen-iframe.html is failing
eric.carlson@apple.com [Thu, 8 Aug 2013 21:17:14 +0000 (21:17 +0000)]
fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

* platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Improper Caption Button Displayed to Users
bfulgham@apple.com [Thu, 8 Aug 2013 21:12:24 +0000 (21:12 +0000)]
[Windows] Improper Caption Button Displayed to Users
https://bugs.webkit.org/show_bug.cgi?id=119593

Reviewed by Eric Carlson.

Remove the custom drawing code for the Windows port, and
have it render using the CSS/SVG markup like we do on OS X.

* rendering/RenderThemeWin.cpp: Remove drawing code.
* rendering/RenderThemeWin.h: Remove declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/scroll-div-with-prevent-default-in-subframe.html is failing
eric.carlson@apple.com [Thu, 8 Aug 2013 21:05:41 +0000 (21:05 +0000)]
fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

* platform/mac/TestExpectations: Mark test as flakey, it doesn't always pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWork towards WebGL on AppleWin port.
achristensen@apple.com [Thu, 8 Aug 2013 20:19:27 +0000 (20:19 +0000)]
Work towards WebGL on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119562

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj:
Build GLContext.cpp and GraphicsContext3DPrivate.cpp on AppleWin port.
* WebCore.vcxproj/WebCore.vcxproj.filters:
Moved GLContext and GraphicsContext3DPrivate from Cairo filter to graphics.
* platform/graphics/GraphicsContext3D.h:
Added m_webGLLayer for AppleWin port.
* platform/graphics/GraphicsContext3DPrivate.cpp:
Protected inclusion of PlatformContextCairo.h in USE(CAIRO) macro for non-cairo ports.
* platform/graphics/win/GraphicsContext3DWin.cpp:
Removed stub GraphicsContext3DPrivate implementation in favor of GraphicsContext3DPrivate.cpp.
(WebCore::GraphicsContext3D::GraphicsContext3D):
Added GraphicsContext3DPrivate and PlatformCALayer initialization.
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::platformGraphicsContext3D):
Added implementation based on Cairo ports' to be refactored soon.
(WebCore::GraphicsContext3D::platformLayer):
Return PlatformCALayer's PlatformLayer instead of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttp/tests/navigation/back-twice-without-commit.html is flaky
eric.carlson@apple.com [Thu, 8 Aug 2013 19:53:05 +0000 (19:53 +0000)]
http/tests/navigation/back-twice-without-commit.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=82980

Unreviewed gardening.

* platform/mac/TestExpectations: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple...
eric.carlson@apple.com [Thu, 8 Aug 2013 19:48:44 +0000 (19:48 +0000)]
Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK.
https://bugs.webkit.org/show_bug.cgi?id=104104

Unreviewed gardening.

* platform/mac/TestExpectations: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnprefix use of transitions in Web Inspector code
dino@apple.com [Thu, 8 Aug 2013 19:22:34 +0000 (19:22 +0000)]
Unprefix use of transitions in Web Inspector code
https://bugs.webkit.org/show_bug.cgi?id=119588

Reviewed by Tim Hatcher.

Replace "-webkit-transition" with "transition".

* UserInterface/CSSCompletions.js:
(WebInspector.CSSCompletions.requestCSSNameCompletions.collectPropertyNameForCodeMirror):
* UserInterface/FindBanner.css:
(.find-banner):
(.find-banner.showing):
(.supports-find-banner.no-find-banner-transition):
(.supports-find-banner):
(.supports-find-banner.showing-find-banner):
* UserInterface/NetworkTimeline.css:
(.network-graph-side:hover .network-graph-label):
* UserInterface/Popover.css:
(.popover.fade-out):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
ap@apple.com [Thu, 8 Aug 2013 19:22:31 +0000 (19:22 +0000)]
    WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
        https://bugs.webkit.org/show_bug.cgi?id=119587

        Reviewed by Darin Adler.

        * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::provisionalURL): Added a null
        check, like we already have in WebFrame::url().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EME] Implement MediaKeys.isTypeSupported()
jer.noble@apple.com [Thu, 8 Aug 2013 19:17:47 +0000 (19:17 +0000)]
[EME] Implement MediaKeys.isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=119586

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/encrypted-media/encrypted-media-is-type-supported.html

The EME spec has removed the extra keySystem parameter from
HTMLMediaElement.canPlayType() in favor of a new isTypeSupported()
method on MediaKeys.

To implement this method, the CDMFactory needs to know whether the
registered CDM supports the specified mime type.  CDMs must register
this new factory method, which requires changes to CDMPrivateAVFoundation
and MockCDM.

Add the new MediaKeys.isTypeSupported() method:
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::isTypeSupported):
* Modules/encryptedmedia/MediaKeys.h:
* Modules/encryptedmedia/MediaKeys.idl:

Add the new factory CDMSupportsKeySystemAndMimeType method:
* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDMFactory::CDMFactory): Now takes a third parameter.
(WebCore::installedCDMFactories): When adding the AVFoundation CDM, pass its new method.
(WebCore::CDM::registerCDMFactory): Now takes a third parameter.
(WebCore::CDM::keySystemSupportsMimeType): Added.
* Modules/encryptedmedia/CDM.h:
* WebCore.exp.in:

Register this new method with the factory for all concrete CDMs:
* Modules/encryptedmedia/CDMPrivateAVFoundation.h:
* Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
(WebCore::CDMPrivateAVFoundation::supportsKeySystem):
(WebCore::CDMPrivateAVFoundation::supportsKeySystemAndMimeType):
* testing/Internals.cpp:
(WebCore::Internals::initializeMockCDM):
* testing/MockCDM.cpp:
(WebCore::MockCDM::supportsKeySystem):
(WebCore::MockCDM::supportsKeySystemAndMimeType):
* testing/MockCDM.h:

LayoutTests:

* media/encrypted-media/encrypted-media-is-type-supported-expected.txt: Added.
* media/encrypted-media/encrypted-media-is-type-supported.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/scroll-div-with-prevent-default-in-subframe.html is failing
eric.carlson@apple.com [Thu, 8 Aug 2013 18:47:50 +0000 (18:47 +0000)]
fast/events/scroll-div-with-prevent-default-in-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82747

Unreviewed gardening.

* platform/mac/TestExpectations: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r130839): fast/canvas/webgl/arraybuffer-transfer-of-control.html is failing
eric.carlson@apple.com [Thu, 8 Aug 2013 18:40:59 +0000 (18:40 +0000)]
REGRESSION(r130839): fast/canvas/webgl/arraybuffer-transfer-of-control.html is failing
https://bugs.webkit.org/show_bug.cgi?id=99096

Unreviewed gardening.

* platform/mac/TestExpectations: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator UnspecifiedBoolType
rwlbuis@webkit.org [Thu, 8 Aug 2013 18:38:53 +0000 (18:38 +0000)]
Crash in WTF::RefPtr<WebCore::SpaceSplitStringData>::operator UnspecifiedBoolType
https://bugs.webkit.org/show_bug.cgi?id=118839

Reviewed by Darin Adler.

Source/WebCore:

Take into account that elementData() can be null in classAttributeChanged.

Test: svg/animations/classAttributeSettingCrash.html

* dom/Element.cpp:
(WebCore::Element::classAttributeChanged):

LayoutTests:

Add testcase that showed up to cause a crash by the fuzzer.

* svg/animations/classAttributeSettingCrash-expected.txt: Added.
* svg/animations/classAttributeSettingCrash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofullscreen/exit-full-screen-iframe.html is failing
eric.carlson@apple.com [Thu, 8 Aug 2013 18:35:49 +0000 (18:35 +0000)]
fullscreen/exit-full-screen-iframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90708

Unreviewed gardening.

* platform/mac/TestExpectations: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosvg/custom/use-href-update-crash.svg failing on certain platforms
rwlbuis@webkit.org [Thu, 8 Aug 2013 18:17:36 +0000 (18:17 +0000)]
svg/custom/use-href-update-crash.svg failing on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=104054

Reviewed by Darin Adler.

Fix mistake in use-href-update-crash.svg which caused the gc() not found problem. Update the test expectations
that had this marked as failure, it passes after the test fix.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* svg/custom/use-href-update-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r147019): Page has extra space
robert@webkit.org [Thu, 8 Aug 2013 18:13:22 +0000 (18:13 +0000)]
REGRESSION(r147019): Page has extra space
https://bugs.webkit.org/show_bug.cgi?id=119424

Reviewed by David Hyatt.

Clear the overflow rect before recomputing it in table sections.

No new tests: the reduction uses jquery and I was unable to simulate the reduction without it.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::computeOverflowFromCells):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuit...
ap@apple.com [Thu, 8 Aug 2013 17:41:55 +0000 (17:41 +0000)]
    WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
        https://bugs.webkit.org/show_bug.cgi?id=116125

        Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::pathSuitableForTestResult):
        Changed string operations to match _drt_descriptionSuitableForTestResult.
        (WTR::dumpRequestDescriptionSuitableForTestResult):
        (WTR::dumpResponseDescriptionSuitableForTestResult):
        (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
        (WTR::InjectedBundlePage::didInitiateLoadForResource):
        (WTR::InjectedBundlePage::willSendRequestForFrame):
        (WTR::InjectedBundlePage::didReceiveResponseForResource):
        Pass the main frame's URL to pathSuitableForTestResult.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        Added WKBundlePageRef to willPerformClientRedirectForFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInserting multiple rules into an empty style sheet should avoid style recalc if possible.
akling@apple.com [Thu, 8 Aug 2013 17:41:11 +0000 (17:41 +0000)]
Inserting multiple rules into an empty style sheet should avoid style recalc if possible.
<http://webkit.org/b/119568>

Reviewed by Antti Koivisto.

As a follow-up to <http://webkit.org/b/119475>, where I added a hack for inserting
a single rule into an empty style sheet, this broadens the optimization to support
any number of rules.

This optimizes the scenario where a style sheet is added to the DOM and then populated
rule-by-rule via CSSOM insertRule()/addRule() calls. Previously we'd do a full style
recalc for this case, but now we'll treat it the same as a full sheet added at once.

* css/CSSStyleSheet.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::willMutateRules):

    Made willMutateRules() return whether the style sheet contents were cloned by the
    copy-on-write mechanism.

* dom/Document.h:
(WebCore::CSSStyleSheet::didMutateRules):
(WebCore::CSSStyleSheet::insertRule):

    Replaced the InsertionIntoEmptySheet mutation type by a general RuleInsertion.
    The mutation callback checks if we're inserting into a rule that's not (yet) part
    of the document's active sheet set. In that case, we defer doing the style sheet
    until all the insertions are done (or something forces us to style+layout.)

    Note that this optimization only happens if the style sheet had a single client.
    Shared style sheets that just got cloned before mutation may have pointers into
    them from the Document's StyleResolver, so we're forced to do an immediate sheet
    update in that case.

(WebCore::CSSStyleSheet::RuleMutationScope::RuleMutationScope):
(WebCore::CSSStyleSheet::RuleMutationScope::~RuleMutationScope):

    Moved these out-of-line.

(WebCore::CSSStyleSheet::didMutateRuleFromCSSStyleDeclaration):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):

    Made a separate mutation callback for CSSStyleDeclaration since its needs are
    so simple compared to the mutation callback from CSSStyleSheet. Seems better
    than adding yet another mode to the enum.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):

    Added mechanism to defer doing a RecalcStyleIfNeeded.

(WebCore::Document::updateStyleIfNeeded):

    Synchronize the optimized style sheet update if there's one scheduled.
    This ensures that stuff like layout-dependent property access won't operate
    on stale style.

* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::pendingUpdateType):
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType):
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

    Have DSSC track the kind of style sheet update it needs to do (instead of just
    a boolean "needs update.") This is used by Document::recalcStyle() to make sure
    the right kind of update happens if there's one scheduled.

(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains):

    Added helper to check if a CSSStyleSheet is part of the active set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK1] NPStream::headers not initialized
allan.jensen@digia.com [Thu, 8 Aug 2013 17:38:06 +0000 (17:38 +0000)]
[WK1] NPStream::headers not initialized
https://bugs.webkit.org/show_bug.cgi?id=119574

Reviewed by Alexey Proskuryakov.

Initialize the header field. According to user feedback that should solve some
cases of random crashes when loading plugins on Mac and Windows.

* plugins/PluginStream.cpp:
(WebCore::PluginStream::PluginStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOops, didn't mean to implicate Mark Lam in the ChangeLog there.
akling@apple.com [Thu, 8 Aug 2013 17:27:46 +0000 (17:27 +0000)]
Oops, didn't mean to implicate Mark Lam in the ChangeLog there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoElement: Modernize attribute storage accessor functions.
akling@apple.com [Thu, 8 Aug 2013 17:25:50 +0000 (17:25 +0000)]
Element: Modernize attribute storage accessor functions.
<http://webkit.org/b/119578>

Source/WebCore:

Patch by Mark Lam <mark.lam@apple.com> on 2013-08-08
Reviewed by Antti Koivisto.

Rename these functions to more WebKit-style names.

- const Attribute* attributeItem(index) => const Attribute& attributeAt(index)
- const Attribute* getAttributeItem(name) => const Attribute* findAttributeByName(name)
- unsigned getAttributeItemIndex(name) => unsigned findAttributeIndexByName(name)

Note that attributeAt() now returns a reference instead of a pointer. That's right.

* css/SelectorChecker.cpp:
(WebCore::attributeValueMatches):
(WebCore::anyAttributeMatches):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::checkExactAttribute):
* dom/Attr.cpp:
(WebCore::Attr::elementAttribute):
* dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::getNames):
(WebCore::DatasetDOMStringMap::item):
(WebCore::DatasetDOMStringMap::contains):
* dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::findAttributeIndexByNameSlowCase):
(WebCore::ElementData::findAttributeIndexByNameForAttributeNode):
(WebCore::UniqueElementData::findAttributeByName):
(WebCore::UniqueElementData::attributeAt):
* dom/Element.h:
(WebCore::Element::findAttributeIndexByName):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::attributeAt):
(WebCore::Element::findAttributeByName):
(WebCore::ElementData::findAttributeByName):
(WebCore::ElementData::findAttributeIndexByName):
(WebCore::ElementData::attributeAt):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::item):
* dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::Node::lookupNamespacePrefix):
(WebCore::Node::compareDocumentPosition):
* dom/StyledElement.cpp:
(WebCore::StyledElement::makePresentationAttributeCacheKey):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendElement):
* editing/markup.cpp:
(WebCore::completeURLs):
(WebCore::StyledMarkupAccumulator::appendElement):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parametersForPlugin):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parametersForPlugin):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::createDigest):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
* page/PageSerializer.cpp:
(WebCore::isCharsetSpecifyingNode):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunLang::evaluate):
* xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::traversalSort):
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):

Source/WebKit/blackberry:

Reviewed by Antti Koivisto.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):

Source/WebKit/qt:

Reviewed by Antti Koivisto.

* Api/qwebelement.cpp:
(QWebElement::attributeNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRestoring use of StackIterator instead of Interpreter::getStacktrace().
mark.lam@apple.com [Thu, 8 Aug 2013 16:57:07 +0000 (16:57 +0000)]
Restoring use of StackIterator instead of Interpreter::getStacktrace().
https://bugs.webkit.org/show_bug.cgi?id=119575.

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* interpreter/Interpreter.h:
- Made getStackTrace() private.
* interpreter/StackIterator.cpp:
(JSC::StackIterator::StackIterator):
(JSC::StackIterator::numberOfFrames):
- Computes the number of frames by iterating through the whole stack
  from the starting frame. The iterator will save its current frame
  position before counting the frames, and then restoring it after
  the counting.
(JSC::StackIterator::gotoFrameAtIndex):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::resetIterator):
- Points the iterator to the starting frame.
* interpreter/StackIteratorPrivate.h:

Source/WebCore:

No new tests.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
commit-queue@webkit.org [Thu, 8 Aug 2013 16:55:05 +0000 (16:55 +0000)]
SunSpider: Move the 3d-morph fix from version 1.0 to version 1.0.1
https://bugs.webkit.org/show_bug.cgi?id=117993

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-08-08
Reviewed by George Staikos.

PerformanceTests/SunSpider:

Bump the SunSpider version to 1.0.1.

Unroll r149548 in order to restore version 1.0 to its original,
and add the 3d-morph fix to version 1.0.1 instead.

* hosted/sunspider.html: Updated to version 1.0.1.
* hosted/versions.html: Updated to version 1.0.1.
* make-hosted: Added support for version 1.0.1.
* resources/driver-TEMPLATE.html: Updated to version 1.0.1.
* resources/results-TEMPLATE.html: Updated to version 1.0.1.
* sunspider: Updated to version 1.0.1.
* sunspider-compare-results: Updated to version 1.0.1.
* tests/sunspider-1.0/3d-morph.js: Rolled back to the original version.
* tests/sunspider-1.0.1/LIST: Added.
* tests/sunspider-1.0.1/3d-cube.js: Added.
* tests/sunspider-1.0.1/3d-morph.js: Added.
* tests/sunspider-1.0.1/3d-raytrace.js: Added.
* tests/sunspider-1.0.1/access-binary-trees.js: Added.
* tests/sunspider-1.0.1/access-fannkuch.js: Added.
* tests/sunspider-1.0.1/access-nbody.js: Added.
* tests/sunspider-1.0.1/access-nsieve.js: Added.
* tests/sunspider-1.0.1/bitops-3bit-bits-in-byte.js: Added.
* tests/sunspider-1.0.1/bitops-bits-in-byte.js: Added.
* tests/sunspider-1.0.1/bitops-bitwise-and.js: Added.
* tests/sunspider-1.0.1/bitops-nsieve-bits.js: Added.
* tests/sunspider-1.0.1/controlflow-recursive.js: Added.
* tests/sunspider-1.0.1/crypto-aes.js: Added.
* tests/sunspider-1.0.1/crypto-md5.js: Added.
* tests/sunspider-1.0.1/crypto-sha1.js: Added.
* tests/sunspider-1.0.1/date-format-tofte.js: Added.
* tests/sunspider-1.0.1/date-format-xparb.js: Added.
* tests/sunspider-1.0.1/math-cordic.js: Added.
* tests/sunspider-1.0.1/math-partial-sums.js: Added.
* tests/sunspider-1.0.1/math-spectral-norm.js: Added.
* tests/sunspider-1.0.1/regexp-dna.js: Added.
* tests/sunspider-1.0.1/string-base64.js: Added.
* tests/sunspider-1.0.1/string-fasta.js: Added.
* tests/sunspider-1.0.1/string-tagcloud.js: Added.
* tests/sunspider-1.0.1/string-unpack-code.js: Added.
* tests/sunspider-1.0.1/string-validate-input.js: Added.

Websites/webkit.org:

* perf/sunspider-1.0.1/json2.js: Added.
* perf/sunspider-1.0.1/sunspider-1.0.1/driver.html: Added.
* perf/sunspider-1.0.1/sunspider-1.0.1/results.html: Added.
* perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-contents.js: Added.
* perf/sunspider-1.0.1/sunspider-1.0.1/sunspider-test-prefix.js: Added.
* perf/sunspider-1.0.1/sunspider-analyze-results.js: Added.
* perf/sunspider-1.0.1/sunspider-compare-results.js: Added.
* perf/sunspider-1.0.1/sunspider.css: Added.
* perf/sunspider-1.0.1/sunspider.html: Added.
* perf/sunspider/sunspider.html: Updated to version 1.0.1.
* perf/sunspider/versions.html: Updated to version 1.0.1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoved ErrorConstructor and NativeErrorConstructor helper functions into
mark.lam@apple.com [Thu, 8 Aug 2013 16:38:31 +0000 (16:38 +0000)]
Moved ErrorConstructor and NativeErrorConstructor helper functions into
the Interpreter class.
https://bugs.webkit.org/show_bug.cgi?id=119576.

Reviewed by Oliver Hunt.

This change is needed to prepare for making Interpreter::getStackTrace()
private. It does not change the behavior of the code, only the lexical
scoping.

* interpreter/Interpreter.h:
- Added helper functions for ErrorConstructor and NativeErrorConstructor.
* runtime/ErrorConstructor.cpp:
(JSC::Interpreter::constructWithErrorConstructor):
(JSC::ErrorConstructor::getConstructData):
(JSC::Interpreter::callErrorConstructor):
(JSC::ErrorConstructor::getCallData):
- Don't want ErrorConstructor to call Interpreter::getStackTrace()
  directly. So, we moved the helper functions into the Interpreter
  class.
* runtime/NativeErrorConstructor.cpp:
(JSC::Interpreter::constructWithNativeErrorConstructor):
(JSC::NativeErrorConstructor::getConstructData):
(JSC::Interpreter::callNativeErrorConstructor):
(JSC::NativeErrorConstructor::getCallData):
- Don't want NativeErrorConstructor to call Interpreter::getStackTrace()
  directly. So, we moved the helper functions into the Interpreter
  class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r121551) Incorrect handling of invalid media query list.
zalan@apple.com [Thu, 8 Aug 2013 14:49:44 +0000 (14:49 +0000)]
REGRESSION (r121551) Incorrect handling of invalid media query list.
https://bugs.webkit.org/show_bug.cgi?id=119164

Reviewed by Antti Koivisto.

Differentiate between syntactically invalid media queries and media queries with empty expressions.

Introduce a dedicated function for valid, but empty expression queries, so that passing NULL MediaQuerySet
object to CSSParser::createMediaRule() can indicate invalid media query.

Source/WebCore:

Test: fast/media/invalid-media-query-list.html

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createEmptyMediaRule):
* css/CSSParser.h:

LayoutTests:

* fast/media/invalid-media-query-list-expected.html: Added.
* fast/media/invalid-media-query-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed rebaselining after r153647.
zarvai@inf.u-szeged.hu [Thu, 8 Aug 2013 13:30:15 +0000 (13:30 +0000)]
[Qt] Unreviewed rebaselining after r153647.

* platform/qt/fast/css/input-search-padding-expected.png:
* platform/qt/fast/css/input-search-padding-expected.txt:
* platform/qt/fast/css/text-overflow-input-expected.png:
* platform/qt/fast/css/text-overflow-input-expected.txt:
* platform/qt/fast/forms/box-shadow-override-expected.png:
* platform/qt/fast/forms/box-shadow-override-expected.txt:
* platform/qt/fast/forms/control-restrict-line-height-expected.png:
* platform/qt/fast/forms/control-restrict-line-height-expected.txt:
* platform/qt/fast/forms/placeholder-position-expected.png:
* platform/qt/fast/forms/placeholder-position-expected.txt:
* platform/qt/fast/forms/placeholder-pseudo-style-expected.png:
* platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.png:
* platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/qt/fast/forms/search-rtl-expected.png:
* platform/qt/fast/forms/search-rtl-expected.txt:
* platform/qt/fast/forms/search-styled-expected.png:
* platform/qt/fast/forms/search-styled-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.png:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/forms/search/search-size-with-decorations-expected.png: Added.
* platform/qt/fast/forms/search/search-size-with-decorations-expected.txt: Added.
* platform/qt/fast/repaint/search-field-cancel-expected.png:
* platform/qt/fast/repaint/search-field-cancel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce toSVGMPathElement(), and use it
gyuyoung.kim@samsung.com [Thu, 8 Aug 2013 11:00:29 +0000 (11:00 +0000)]
Introduce toSVGMPathElement(), and use it
https://bugs.webkit.org/show_bug.cgi?id=119566

Reviewed by Andreas Kling.

As a step to change static_cast with toSVGXXX, static_cast<SVGMPathElement*> can
be changed with toSVGMPathElement().

* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::updateAnimationPath):
* svg/SVGMPathElement.h:
(WebCore::toSVGMPathElement):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::invalidateMPathDependencies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/14680524> REGRESSION(153806): Crash @ yahoo.com when WebKit is built...
slewis@apple.com [Thu, 8 Aug 2013 10:25:45 +0000 (10:25 +0000)]
<rdar://problem/14680524> REGRESSION(153806): Crash @ yahoo.com when WebKit is built with a .order file

Unreviewed.

Ensure llint symbols are in source order.

* JavaScriptCore.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skip more tests depending on canvas blending.
allan.jensen@digia.com [Thu, 8 Aug 2013 09:54:57 +0000 (09:54 +0000)]
[Qt] Skip more tests depending on canvas blending.
https://bugs.webkit.org/show_bug.cgi?id=100072

Unreviewed gardening.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Use granular DOMStorage modification events to avoid complete DataGrid...
vivek.vg@samsung.com [Thu, 8 Aug 2013 07:58:01 +0000 (07:58 +0000)]
Web Inspector: Use granular DOMStorage modification events to avoid complete DataGrid update.
https://bugs.webkit.org/show_bug.cgi?id=119541

Reviewed by Joseph Pecoraro.

InspectorDOMStorageAgent sends more granular events about the storage modifications.
Using these would avoid the complete rebuilding of the DataGrid.

* UserInterface/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype.itemsCleared):
(WebInspector.DOMStorageContentView.prototype.itemRemoved):
(WebInspector.DOMStorageContentView.prototype.itemAdded):
(WebInspector.DOMStorageContentView.prototype.itemUpdated):
* UserInterface/DOMStorageObserver.js:
(WebInspector.DOMStorageObserver.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageObserver.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageObserver.prototype.domStorageItemAdded):
(WebInspector.DOMStorageObserver.prototype.domStorageItemUpdated):
* UserInterface/StorageManager.js:
(WebInspector.StorageManager.prototype.domStorageItemsCleared):
(WebInspector.StorageManager.prototype.domStorageItemRemoved):
(WebInspector.StorageManager.prototype.domStorageItemAdded):
(WebInspector.StorageManager.prototype.domStorageItemUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove more style recalc code to StyleResolveTree.cpp
antti@apple.com [Thu, 8 Aug 2013 07:18:36 +0000 (07:18 +0000)]
Move more style recalc code to StyleResolveTree.cpp
https://bugs.webkit.org/show_bug.cgi?id=119553

Reviewed by Andreas Kling.

* css/StyleResolver.cpp:
* css/StyleResolver.h:

    Remove now unused StyleResolver::styleForText.

* dom/ElementShadow.cpp:
* dom/ElementShadow.h:

    Remove ElementShadow::recalcStyle.

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::setResetStyleInheritance):

    Use Style::resolveTree instead of ElementShadow::recalcStyle.

* dom/ShadowRoot.h:

    Remove ShadowRoot::recalcStyle.

* dom/Text.cpp:
* dom/Text.h:

    Remove Text::recalcTextStyle.

* style/StyleResolveTree.cpp:
(WebCore::Style::updateTextStyle):

    Moved from Text::recalcTextStyle. Speed up by just setting the parent style on common case.

(WebCore::Style::resolveShadowTree):

    Moved from ShadowRoot::recalcStyle.
    Simplified to cover only cases that can occur with the current shadow DOM support.

(WebCore::Style::resolveTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r139282): Old caret sometimes gets "stuck" (not repainted) in contentedita...
akling@apple.com [Thu, 8 Aug 2013 07:16:51 +0000 (07:16 +0000)]
REGRESSION(r139282): Old caret sometimes gets "stuck" (not repainted) in contenteditable elements.
<http://webkit.org/b/119520>
<rdar://problem/14658929>

Reviewed by Simon Fraser.

Source/WebCore:

When computing a new caret rect, don't forget to repaint the old rect if the caret jumped
from one node to another.
We were being a little too clever, assuming that oldRect==newRect meant that no repaint was
necessary, but moving from (0,0) in one node to (0,0) in another would cause a ghost caret
in the old node.

Test: fast/repaint/caret-jump-between-nodes.html

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):

    Fall through all the way down to caret repaints if the selection's new anchor node is not
    the same as m_previousCaretNode.

LayoutTests:

* fast/repaint/caret-jump-between-nodes-expected.txt: Added.
* fast/repaint/caret-jump-between-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Propagate overflow from the flow thread to the first and last region
abucur@adobe.com [Thu, 8 Aug 2013 06:28:02 +0000 (06:28 +0000)]
[CSS Regions] Propagate overflow from the flow thread to the first and last region
https://bugs.webkit.org/show_bug.cgi?id=118526

Reviewed by David Hyatt.

Source/WebCore:

The patch implements layout overflow propagation for the first and last regions. The approach
taken is triggering a simple layout on the regions after the named flows are laid out
that extracts the layout overflow from the flow thread and adds it to the regions.

The process is based on adding two new layout phases: the overflow phase and the final phase.
The overflow phase is set after the flow threads are laid out and it marks the regions as
needing to extract the overflow from the flow thread. In case there are blocks with auto overflow
it's possible the overflow to create scrollbars that shrink the regions. In this case the flow
thread is relaid out and set in the final phase, forcing the regions to recollect the layout
overflow. In theory this would be an N-step layout because scrollbars can force content to change
regions and create overflow for other blocks (and thus creating more scrollbars). For now, we are
limiting this to the first pass by inserting this new final layout phase.

A short description of the processing model for a document:
- layout the document (all the flow threads should be in the constrained layout phase after this step)
- reverse iterate through the flow threads and mark the regions for simplified layout (we need to
reverse iterate so the overflow can correctly propagate with nested regions)
- if the layout changes the size of a region, invalidate the flow thread and when laying it out mark
it as needing a new pass
- make a secondary pass through the flow threads that changed after scrollbars have been added and
recompute the overflow for their regions; mark the flow threads in the final phase (flow threads can't
be invalidated in the final phase)
- after the overflow was propagated update all the flow threads in the normal layout phase

There are some issues with the patch:
- the simplified layout doesn't compute correct overflow values for inline blocks
- the layout overflow from the flow thread doesn't take the region size into account

The first issue is not related to regions and will be fixed in a future patch. The second issue
will be fixed when box overflow will be region bound.

Tests: fast/regions/overflow-scrollable-1.html
       fast/regions/overflow-scrollable-2.html
       fast/regions/overflow-scrollable-3.html
       fast/regions/overflow-scrollable-fit-complex.html
       fast/regions/overflow-scrollable-fit.html
       fast/regions/overflow-scrollable-nested.html

* rendering/FlowThreadController.cpp: Flow threads layout driver functions.
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):
* rendering/FlowThreadController.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::firstRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::lastRegion): This getter should work even though the region chain is invalid.
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded): If the flow thread has no overflow do nothing.
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::maxPageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion): Used to get the flow thread visual or layout overflow.
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::updateLogicalHeight):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::layoutContentToComputeOverflowInRegions):
(WebCore::RenderView::layout):
* rendering/RenderView.h:

LayoutTests:

Add tests for scrolling of regions in containers in different situations: regions with
transforms, nested regions, regions affected by scrollbars etc.

* fast/regions/overflow-scrollable-1-expected.html: Added.
* fast/regions/overflow-scrollable-1.html: Added.
* fast/regions/overflow-scrollable-2-expected.html: Added.
* fast/regions/overflow-scrollable-2.html: Added.
* fast/regions/overflow-scrollable-3-expected.html: Added.
* fast/regions/overflow-scrollable-3.html: Added.
* fast/regions/overflow-scrollable-fit-complex-expected.html: Added.
* fast/regions/overflow-scrollable-fit-complex.html: Added.
* fast/regions/overflow-scrollable-fit-expected.html: Added.
* fast/regions/overflow-scrollable-fit.html: Added.
* fast/regions/overflow-scrollable-nested-expected.txt: Added.
* fast/regions/overflow-scrollable-nested.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the images for the blog size-matters
benjamin@webkit.org [Thu, 8 Aug 2013 04:20:56 +0000 (04:20 +0000)]
Update the images for the blog size-matters

* blog-files/size-matters/JavaScriptCore-relative-binary-growth.png: Added.
* blog-files/size-matters/WebCore-relative-binary-growth.png: Added.
* blog-files/size-matters/WebKit-relative-binary-growth.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix on Efl port after r153785.
ryuan.choi@samsung.com [Thu, 8 Aug 2013 04:08:27 +0000 (04:08 +0000)]
Unreviewed build fix on Efl port after r153785.

* CMakeLists.txt: Added "${WEBCORE_DIR}/style" in include list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow the DumpRenderTree runloop to be idle while waiting for a test to complete
simon.fraser@apple.com [Thu, 8 Aug 2013 02:13:14 +0000 (02:13 +0000)]
Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
https://bugs.webkit.org/show_bug.cgi?id=119317

Reviewed by Tim Horton.

The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
the test to complete, which is not power friendly. Although DRT instances
are generally busy anyway, not sitting in a busy loop should free up some CPU
cycles for other instances of DRT.

Editing tests continue to pass. All Java tests are skipped and were not
tested, but when run fail similarly with and without the patch.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid spurious "all repaint" layouts when scrolling WebViews on Retina displays
simon.fraser@apple.com [Thu, 8 Aug 2013 02:00:07 +0000 (02:00 +0000)]
Avoid spurious "all repaint" layouts when scrolling WebViews on Retina displays
https://bugs.webkit.org/show_bug.cgi?id=119564

Reviewed by Beth Dakin.

When scrolling WebViews on Macs with Retina displays, AppKit uses
device pixels for the scroll offset, so [scrollView() documentVisibleRect]
can return a CGRect with non-integral origin. This rect is used by layout,
via layoutSize(), to decide whether the view size changed, which prompts
a full repaint. However, FrameView gets a value which has been rounded
by enclosingIntRect(), which increases the height or width by 1px if the
y or x offset is on a half-pixel, causing spurious full repaints.

Fix by plumbing through platformVisibleContentSize(), which just
gets the size of the -documentVisibleRect.

* page/FrameView.cpp:
(WebCore::FrameView::layout): Don't get layoutHeight and layoutWidth
separately, since that is two calls down into platformVisibleContentSize.
* platform/ScrollView.cpp:
(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::platformVisibleContentSize):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformVisibleContentSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBe more aggressive about sending fake mouse events less frequently
simon.fraser@apple.com [Thu, 8 Aug 2013 01:31:36 +0000 (01:31 +0000)]
Be more aggressive about sending fake mouse events less frequently
https://bugs.webkit.org/show_bug.cgi?id=119563
<rdar://problem/14669029>

Reviewed by Tim Horton.

r109151 added code that throttles back the fake mouse events that we
send during scrolling, but in such a way that a page could take up to
100ms to handle a single mousemove, and we'd still send fake mousemove
events every 100ms. This could cause serious scrolling stutter.

Fix by changing when we drop back to sending events every 250ms, rather than every
100ms: if the slowest mousemove takes 10ms or more (less than one frame), drop back
to a 250ms fake move interval.

* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove pointless const in InputHandler
commit-queue@webkit.org [Thu, 8 Aug 2013 00:51:36 +0000 (00:51 +0000)]
[BlackBerry] Remove pointless const in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=119550

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-07
Reviewed by Rob Buis.
Internally reviewed by Leo Yang and Mike Fenton.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
(BlackBerry::WebKit::InputHandler::redrawSpellCheckDialogIfRequired):
* WebKitSupport/InputHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[rendering] Implement PaintInfo interfaces
cavalcantii@gmail.com [Wed, 7 Aug 2013 23:05:31 +0000 (23:05 +0000)]
[rendering] Implement PaintInfo interfaces
https://bugs.webkit.org/show_bug.cgi?id=119388

Reviewed by Benjamin Poulain.

In discussion in IRC, it was decided to remove this comment since implementing such change
would have a vast impact on rendering classes.

* rendering/PaintInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't remove contents layer from its parent unless necessary
dino@apple.com [Wed, 7 Aug 2013 22:16:09 +0000 (22:16 +0000)]
Don't remove contents layer from its parent unless necessary
https://bugs.webkit.org/show_bug.cgi?id=119560

Reviewed by Simon Fraser.

RenderLayerBacking::updateInternalHierarchy() is called in some
instances where there doesn't need to be a complete reparenting of the
the m_graphicsLayer. For example, on OS X when the user changes the
scrollbar styles to/from always visible. We don't need to always
remove the graphics layer from its parent - any reparenting does that
automatically.

Unfortunately we can't trigger this situation in an automated test.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateInternalHierarchy): Don't call removeFromParent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
dbates@webkit.org [Wed, 7 Aug 2013 22:00:42 +0000 (22:00 +0000)]
Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
<https://bugs.webkit.org/show_bug.cgi?id=119558>

Reviewed by Martin Robinson.

Currently we build the command line to execute jsDriver.pl twice so as to both
print it to standard output and actually execute it. We should only build up
this command line once. Moreover, we should print to standard output the actual
command line that we are going to use including the GTK- and EFL-specific call
to /Tools/jhbuild/jhbuild-wrapper.

* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed wrong definition for AppleWin port's WebGL after r153768.
achristensen@apple.com [Wed, 7 Aug 2013 21:38:45 +0000 (21:38 +0000)]
Fixed wrong definition for AppleWin port's WebGL after r153768.

Rubberstamped by Benjamin Poulain.

* wtf/Platform.h: Replaced WTF_USE_SURFACE with WTF_USE_GRAPHICS_SURFACE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] REGRESSION after r153432: some accessibility tests crash.
commit-queue@webkit.org [Wed, 7 Aug 2013 21:13:41 +0000 (21:13 +0000)]
[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-08-07
Reviewed by Darin Adler.

Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFall out of simple image layer optimization if the image has EXIF rotation
timothy_horton@apple.com [Wed, 7 Aug 2013 19:52:37 +0000 (19:52 +0000)]
Fall out of simple image layer optimization if the image has EXIF rotation
https://bugs.webkit.org/show_bug.cgi?id=119535
<rdar://problem/14071174>

Reviewed by Simon Fraser.

Test: fast/images/exif-orientation-composited.html

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameOrientationAtIndex):
Ensure that the frame is cached if we're requesting the orientation,
so we can acquire orientation information at any given time.

* platform/mac/DragImageMac.mm:
(WebCore::createDragImageFromImage):
* platform/graphics/BitmapImage.h:
Rename currentFrameOrientation to frameOrientationForCurrentFrame to match
the similarly-behaving nativeImageForCurrentFrame.

* platform/graphics/Image.h:
(WebCore::Image::orientationForCurrentFrame): Added. Virtual, overriden by BitmapImage.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
If the given image has a non-default image orientation, don't use direct compositing.

Add a test that ensures that composited images with EXIF orientation paint correctly.

* fast/images/exif-orientation-composited-expected.txt: Added.
* fast/images/exif-orientation-composited.html: Added.
* platform/mac/fast/images/exif-orientation-composited-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/frames/seamless/seamless-custom-font-pruning-crash.html asserts
antti@apple.com [Wed, 7 Aug 2013 19:13:29 +0000 (19:13 +0000)]
fast/frames/seamless/seamless-custom-font-pruning-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=119557

Rubber-stamped by Eric Carlson.

Pass Style::Detach style change to seamless document as Style::Force. Style::resolveTree does not expect to be called with Detach.

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::didRecalcStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable HTTP request "Accept-Encoding:" header field on gstreamer source element...
commit-queue@webkit.org [Wed, 7 Aug 2013 18:40:31 +0000 (18:40 +0000)]
Disable HTTP request "Accept-Encoding:" header field on gstreamer source element to avoid receiving the wrong size when retrieving data
https://bugs.webkit.org/show_bug.cgi?id=115354

Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-08-07
Reviewed by Philippe Normand.

The default value for the HTTP "Accept-Encoding:" header field in the request allows
compressed data to be received on requests.
While this works fine for most cases, it can break the webkit source that needs to rely on the
the proper data size when receiving the response (even though the received data is already
uncompressed the size reported in ResourceResponse::expectedContentLength() is the same
represented by the HTTP header field "Content-Length" which is the size of the compressed data).

This patch disables the HTTP "Accept-Encoding:" header field when using the request
as we don't want the received response to be encoded in any way, as we need to rely on the proper
size of the returned data on ResourceHandle::didReceiveResponse().

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart):
* platform/network/soup/ResourceRequest.h:
(ResourceRequestBase):
(WebCore::ResourceRequest::acceptEncoding):
(WebCore::ResourceRequest::setAcceptEncoding):
(WebCore::ResourceRequest::ResourceRequestBase):
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::toSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix Win WK1 build.
antti@apple.com [Wed, 7 Aug 2013 18:40:17 +0000 (18:40 +0000)]
Try to fix Win WK1 build.

Not reviewed.

* WebFrame.cpp:
(WebFrame::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
mhahnenberg@apple.com [Wed, 7 Aug 2013 18:36:31 +0000 (18:36 +0000)]
32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
https://bugs.webkit.org/show_bug.cgi?id=119555

Reviewed by Geoffrey Garen.

It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
This was causing crashes on maps.google.com in 32-bit debug builds.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add myself as a committer.
ctruta@gmail.com [Wed, 7 Aug 2013 18:30:13 +0000 (18:30 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Skip background-blending-mode tests
allan.jensen@digia.com [Wed, 7 Aug 2013 16:56:18 +0000 (16:56 +0000)]
[Qt] Skip background-blending-mode tests

Unreviewed gardening.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(r) Two pixel result fail after r153522
allan.jensen@digia.com [Wed, 7 Aug 2013 16:34:17 +0000 (16:34 +0000)]
[Qt] REGRESSION(r) Two pixel result fail after r153522
https://bugs.webkit.org/show_bug.cgi?id=119392

Reviewed by Jocelyn Turcotte.

Consider scaling transform on the painter to determine final destination size.

Covered by existing tests.

* platform/graphics/qt/ImageQt.cpp:
(WebCore::prescaleImageIfRequired):
(WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT
msaboff@apple.com [Wed, 7 Aug 2013 16:17:33 +0000 (16:17 +0000)]
REGRESSION(FTL merge): Assertion fail on 32 bit with enabled DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=119405

Reviewed by Geoffrey Garen.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString): For X86 32 bit, construct an indexed address
ourselves to save a register and then load from it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2.5% regression on page cycler moz
antti@apple.com [Wed, 7 Aug 2013 15:02:39 +0000 (15:02 +0000)]
2.5% regression on page cycler moz
https://bugs.webkit.org/show_bug.cgi?id=102822

Source/WebCore:

Reviewed by Andreas Kling.

DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache() triggers a style recalc for quirks mode
documents in the beginning of document parsing via Document::setCompatibilityMode. This often coalesces
with style recalc triggered by stylesheet loading. However on very simple documents it can generate genuinely
unnecessary work.

* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):

    Check that we actually have cached injected stylesheets before triggering style recalc.

* page/PageGroup.cpp:
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
(WebCore::PageGroup::removeAllUserContent):

    Fix a misspelling.

(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):

    Always invalidate style when user sheets change since we don't do that in
    DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache anymore.

* page/PageGroup.h:

LayoutTests:

Reviewed by Andreas Kling.

This is a progression.

* inspector/timeline/timeline-script-tag-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo no check seek offset against internal size on gstreamer source element
commit-queue@webkit.org [Wed, 7 Aug 2013 15:00:42 +0000 (15:00 +0000)]
Do no check seek offset against internal size on gstreamer source element
https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSeekDataCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix EFL build.
antti@apple.com [Wed, 7 Aug 2013 14:31:03 +0000 (14:31 +0000)]
Try to fix EFL build.

Not reviewed.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreate WebCore/style and move StyleResolveTree there
antti@apple.com [Wed, 7 Aug 2013 14:22:49 +0000 (14:22 +0000)]
Create WebCore/style and move StyleResolveTree there
https://bugs.webkit.org/show_bug.cgi?id=119543

Reviewed by Andreas Kling.

WebCore/css is bloated. We should move the internal style representation and the style resolver
related code to a directory of their own. CSS language related code including parser and
CSSOM stays under css.

Things named StyleFoo should generally move under WebCore/style. They should also be moved to
the Style namespace at the same time.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.pri:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCoreCommon.props:
* WebCore.vcxproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* css/StyleResolveTree.cpp: Removed.
* css/StyleResolveTree.h: Removed.
* style: Added.
* style/StyleResolveTree.cpp: Copied from Source/WebCore/css/StyleResolveTree.cpp.
* style/StyleResolveTree.h: Copied from Source/WebCore/css/StyleResolveTree.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Blending] Add test suite to validate background blending with different properties
commit-queue@webkit.org [Wed, 7 Aug 2013 13:42:54 +0000 (13:42 +0000)]
[CSS Blending] Add test suite to validate background blending with different properties
https://bugs.webkit.org/show_bug.cgi?id=118243

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-08-07
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-background-attachement-fixed-expected.html: Added.
* css3/compositing/background-blend-mode-background-attachement-fixed.html: Added.
* css3/compositing/background-blend-mode-background-clip-content-box-expected.html: Added.
* css3/compositing/background-blend-mode-background-clip-content-box.html: Added.
* css3/compositing/background-blend-mode-background-clip-padding-box-expected.html: Added.
* css3/compositing/background-blend-mode-background-clip-padding-box.html: Added.
* css3/compositing/background-blend-mode-background-origin-border-box-expected.html: Added.
* css3/compositing/background-blend-mode-background-origin-border-box.html: Added.
* css3/compositing/background-blend-mode-background-position-percentage-expected.html: Added.
* css3/compositing/background-blend-mode-background-position-percentage.html: Added.
* css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html: Added.
* css3/compositing/background-blend-mode-background-repeat-no-repeat.html: Added.
* css3/compositing/background-blend-mode-background-size-contain-expected.html: Added.
* css3/compositing/background-blend-mode-background-size-contain.html: Added.
* css3/compositing/background-blend-mode-background-size-cover-expected.html: Added.
* css3/compositing/background-blend-mode-background-size-cover.html: Added.
* css3/compositing/resources/white_square.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove style recalculation out from Element
antti@apple.com [Wed, 7 Aug 2013 12:02:04 +0000 (12:02 +0000)]
Move style recalculation out from Element
https://bugs.webkit.org/show_bug.cgi?id=119497

Reviewed by Andreas Kling.

Element currently does too much. Element::recalcStyle() and the related functions can be turned into
standalone functions that operate on DOM tree. This will also give more freedom for future refactoring,
for example making style recalculation non-recursive.

* WebCore.xcodeproj/project.pbxproj:
* css/StyleResolveTree.cpp: Added.
(WebCore::Style::determineChange):

    - moved and renamed from Node::diff
    - factored to use early return style
    - simplifield the null input logic

(WebCore::Style::pseudoStyleCacheIsInvalid):

    - moved from Element::pseudoStyleCacheIsInvalid
    - narrowed to take RenderObject rather than operate on Element

(WebCore::Style::resolveLocal):

    - split from Element::recalcStyle
    - factored to use early return style

(WebCore::Style::resolveTree):

    - moved and renamed from Element::recalcStyle

* css/StyleResolveTree.h: Added.

    - introcuduce Style namespace for style related classes and functions
    - move and rename Node::StyleChange -> Style::Change

* css/StyleResolver.h:
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):
(WebCore::StyleResolverParentPusher::push):
(WebCore::StyleResolverParentPusher::~StyleResolverParentPusher):

    Moved this stack helper to StyleResolver.h for now since it is needed by both
    StyleRecalculation and Element.

* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
(WebCore::Document::attach):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::webkitWillEnterFullScreenForElement):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::shouldIgnoreAttributeCase):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::resetComputedStyle):
(WebCore::Element::willRecalcStyle):
(WebCore::Element::didRecalcStyle):
* dom/Element.h:

    - remove Element::recalcStyle
    - make a few private functions needed by StyleRecalculation public

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::recalcStyle):
* dom/ElementShadow.h:
* dom/Node.cpp:
* dom/Node.h:

    - remove Node::StyleChange
    - remove Node::diff

* dom/PseudoElement.cpp:
(WebCore::PseudoElement::didRecalcStyle):
* dom/PseudoElement.h:
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::recalcStyle):
(WebCore::ShadowRoot::setResetStyleInheritance):
* dom/ShadowRoot.h:
* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
* dom/Text.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::didRecalcStyle):
* html/HTMLFormControlElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::willRecalcStyle):
* html/HTMLFrameSetElement.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::didRecalcStyle):
* html/HTMLIFrameElement.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didRecalcStyle):
* html/HTMLMediaElement.h:
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::didRecalcStyle):
* html/HTMLOptionElement.h:
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
* html/HTMLPlugInImageElement.h:
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::reportDataReceived):
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
* page/Page.cpp:
(WebCore::Page::setPageScaleFactor):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
* svg/SVGElement.cpp:
(WebCore::SVGElement::willRecalcStyle):
* svg/SVGElement.h:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::willRecalcStyle):
* svg/SVGUseElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix after r153751
allan.jensen@digia.com [Wed, 7 Aug 2013 11:41:19 +0000 (11:41 +0000)]
[Qt] Build fix after r153751

Unreviewed build fix.

Fix build when PAGE_VISIBILITY_API is disabled.

* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::visibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] Wrong auto-height region computation for nested named flows
mihnea@adobe.com [Wed, 7 Aug 2013 09:11:04 +0000 (09:11 +0000)]
[CSSRegions] Wrong auto-height region computation for nested named flows
https://bugs.webkit.org/show_bug.cgi?id=119517

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/abspos-autoheight-nested-region.html

In the case of an (inner) auto-height region that is absolutely positioned in a named flow that is displayed in an (outer) auto-height region,
when we are doing the layout for the named flow we need to add a "forced region break" also for the case of simplified layout, otherwise
the outer auto-height region will not get the chance to compute its auto-height, ending up with a huge value that was used to initialize
the auto-height computed value before the start of the layout algorithm.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):

LayoutTests:

* fast/regions/abspos-autoheight-nested-region-expected.txt: Added.
* fast/regions/abspos-autoheight-nested-region.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] REGRESSION after r153432: marking crashing tests.
commit-queue@webkit.org [Wed, 7 Aug 2013 09:09:32 +0000 (09:09 +0000)]
[EFL] REGRESSION after r153432: marking crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=119539

Unreviewed EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-08-07

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove dependency on CoreFoundation from WebURLResponse
paroga@webkit.org [Wed, 7 Aug 2013 07:19:47 +0000 (07:19 +0000)]
Remove dependency on CoreFoundation from WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=119390

Reviewed by Brent Fulgham.

* WebURLResponse.cpp:
(localizedShortDescriptionForStatusCode):
(WebURLResponse::localizedStringForStatusCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and...
fpizlo@apple.com [Wed, 7 Aug 2013 04:04:50 +0000 (04:04 +0000)]
DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants
https://bugs.webkit.org/show_bug.cgi?id=119528

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Either of the two fixes would solve the crash I saw. Basically, for best performance, we want the DFG register allocator to track double uses and non-double
uses of a node separately, and we accomplish this by inserting Int32ToDouble nodes in the FixupPhase. But even if FixupPhase fails to do this, we still want
the DFG register allocator to do the right thing: if it encounters a double use of an integer, it should perform a conversion and preserve the original
format of the value (namely, that it was an integer). For constants, the best format to preserve is None, so that future integer uses rematerialize the int
from scratch. This only affects the 64-bit backend; the 32-bit backend was already doing the right thing.

This also fixes some more debug dumping code, and adds some stronger assertions for integer arrays.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* runtime/JSObject.h:
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly):

LayoutTests:

* fast/js/dfg-new-array-double-const-then-int-const.html: Added.
* fast/js/dfg-new-array-double-const-then-int-const-expected.txt: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-new-array-double-const-then-int-const.js: Added.
(bar):
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate Order Files for Safari
slewis@apple.com [Wed, 7 Aug 2013 02:41:27 +0000 (02:41 +0000)]
Update Order Files for Safari
<rdar://problem/14517392>

Unreviewed.

Source/JavaScriptCore:

* JavaScriptCore.order:

Source/WebCore:

No change in functionality.

* WebCore.order:

Source/WebKit/mac:

* WebKit.order:

Source/WebKit2:

* mac/WebKit2.order:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAssertion failure in emitExpressionInfo when reloading with Web Inspector open.
mark.lam@apple.com [Wed, 7 Aug 2013 00:19:28 +0000 (00:19 +0000)]
Assertion failure in emitExpressionInfo when reloading with Web Inspector open.
https://bugs.webkit.org/show_bug.cgi?id=119532.

Reviewed by Oliver Hunt.

* parser/Parser.cpp:
(JSC::::Parser):
- Just need to initialize the Parser's JSTokenLocation's initial line and
  startOffset as well during Parser construction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when entering fullscreen video playback from a WebView using WebKit2
jer.noble@apple.com [Wed, 7 Aug 2013 00:13:32 +0000 (00:13 +0000)]
Crash when entering fullscreen video playback from a WebView using WebKit2
https://bugs.webkit.org/show_bug.cgi?id=119531

Reviewed by Tim Horton.

Initialize wkWindowSetScaledFrame and wkWindowSetAlpha when initializing WebCoreSystemInterface.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: Remove support for HTML5 MicroData
weinig@apple.com [Tue, 6 Aug 2013 23:22:53 +0000 (23:22 +0000)]
.: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* Source/autotools/SetupWebKitFeatures.m4:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore: Remove support for HTML5 Microdata
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/GNUmakefile.am:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::JSHTMLCollection::nameGetter):
* bindings/js/JSHTMLElementCustom.cpp:
* bindings/js/JSMicroDataItemValueCustom.cpp: Removed.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* dom/Document.cpp:
* dom/Document.h:
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::ensureCachedHTMLCollection):
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::rootNode):
(WebCore::LiveNodeListBase::invalidateCache):
(WebCore::LiveNodeList::namedItem):
* dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::shouldInvalidateTypeOnAttributeChange):
* dom/MicroDataItemList.cpp: Removed.
* dom/MicroDataItemList.h: Removed.
* dom/Node.cpp:
* dom/Node.h:
* dom/NodeRareData.cpp:
* dom/NodeRareData.h:
* dom/PropertyNodeList.cpp: Removed.
* dom/PropertyNodeList.h: Removed.
* dom/PropertyNodeList.idl: Removed.
* html/CollectionType.h:
* html/HTMLAnchorElement.cpp:
* html/HTMLAnchorElement.h:
* html/HTMLAreaElement.cpp:
* html/HTMLAreaElement.h:
* html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::item):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
(WebCore::HTMLElement::isURLAttribute):
* html/HTMLElement.h:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.cpp:
* html/HTMLEmbedElement.h:
* html/HTMLIFrameElement.cpp:
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
* html/HTMLImageElement.h:
* html/HTMLLinkElement.cpp:
* html/HTMLLinkElement.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:
* html/HTMLMetaElement.cpp:
* html/HTMLMetaElement.h:
* html/HTMLObjectElement.cpp:
* html/HTMLObjectElement.h:
* html/HTMLPropertiesCollection.cpp: Removed.
* html/HTMLPropertiesCollection.h: Removed.
* html/HTMLPropertiesCollection.idl: Removed.
* html/HTMLSourceElement.cpp:
* html/HTMLSourceElement.h:
* html/HTMLTrackElement.cpp:
* html/HTMLTrackElement.h:
* html/MicroDataAttributeTokenList.cpp: Removed.
* html/MicroDataAttributeTokenList.h: Removed.
* html/MicroDataItemValue.cpp: Removed.
* html/MicroDataItemValue.h: Removed.
* html/MicroDataItemValue.idl: Removed.

Source/WebKit/blackberry: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/mac: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* Configurations/FeatureDefines.xcconfig:

Source/WTF: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* wtf/FeatureDefines.h:

Tools: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

LayoutTests: Remove support for HTML5 MicroData
https://bugs.webkit.org/show_bug.cgi?id=119480

Reviewed by Anders Carlsson.

* fast/dom/MicroData: Removed.
* fast/dom/MicroData/001-expected.txt: Removed.
* fast/dom/MicroData/001.html: Removed.
* fast/dom/MicroData/002-expected.txt: Removed.
* fast/dom/MicroData/002.html: Removed.
* fast/dom/MicroData/003-expected.txt: Removed.
* fast/dom/MicroData/003.html: Removed.
* fast/dom/MicroData/004-expected.txt: Removed.
* fast/dom/MicroData/004.html: Removed.
* fast/dom/MicroData/005-expected.txt: Removed.
* fast/dom/MicroData/005.html: Removed.
* fast/dom/MicroData/006-expected.txt: Removed.
* fast/dom/MicroData/006.html: Removed.
* fast/dom/MicroData/007-expected.txt: Removed.
* fast/dom/MicroData/007.html: Removed.
* fast/dom/MicroData/008-expected.txt: Removed.
* fast/dom/MicroData/008.html: Removed.
* fast/dom/MicroData/009-expected.txt: Removed.
* fast/dom/MicroData/009.html: Removed.
* fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree-expected.txt: Removed.
* fast/dom/MicroData/add-remove-property-to-item-which-is-not-attached-to-domtree.html: Removed.
* fast/dom/MicroData/domsettabletokenlist-attributes-add-token-expected.txt: Removed.
* fast/dom/MicroData/domsettabletokenlist-attributes-add-token.html: Removed.
* fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index-expected.txt: Removed.
* fast/dom/MicroData/domsettabletokenlist-attributes-out-of-range-index.html: Removed.
* fast/dom/MicroData/element-with-empty-itemprop-expected.txt: Removed.
* fast/dom/MicroData/element-with-empty-itemprop.html: Removed.
* fast/dom/MicroData/getitems-empty-string-as-arg-expected.txt: Removed.
* fast/dom/MicroData/getitems-empty-string-as-arg.html: Removed.
* fast/dom/MicroData/getitems-multiple-itemtypes-expected.txt: Removed.
* fast/dom/MicroData/getitems-multiple-itemtypes.html: Removed.
* fast/dom/MicroData/item-not-attached-to-domtree-expected.txt: Removed.
* fast/dom/MicroData/item-not-attached-to-domtree.html: Removed.
* fast/dom/MicroData/item-with-itemprop-attr-expected.txt: Removed.
* fast/dom/MicroData/item-with-itemprop-attr.html: Removed.
* fast/dom/MicroData/item-with-itemref-pointing-to-itself-expected.txt: Removed.
* fast/dom/MicroData/item-with-itemref-pointing-to-itself.html: Removed.
* fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Removed.
* fast/dom/MicroData/itemid-attribute-test-001.html: Removed.
* fast/dom/MicroData/itemid-attribute-test-expected.txt: Removed.
* fast/dom/MicroData/itemid-attribute-test.html: Removed.
* fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Removed.
* fast/dom/MicroData/itemid-must-see-resolved-url.html: Removed.
* fast/dom/MicroData/itemprop-add-remove-tokens-expected.txt: Removed.
* fast/dom/MicroData/itemprop-add-remove-tokens.html: Removed.
* fast/dom/MicroData/itemprop-for-an-element-must-be-correct-expected.txt: Removed.
* fast/dom/MicroData/itemprop-for-an-element-must-be-correct.html: Removed.
* fast/dom/MicroData/itemprop-must-be-read-only-expected.txt: Removed.
* fast/dom/MicroData/itemprop-must-be-read-only.html: Removed.
* fast/dom/MicroData/itemprop-names-override-builtin-properties-expected.txt: Removed.
* fast/dom/MicroData/itemprop-names-override-builtin-properties.html: Removed.
* fast/dom/MicroData/itemprop-reflected-by-itemProp-property-expected.txt: Removed.
* fast/dom/MicroData/itemprop-reflected-by-itemProp-property.html: Removed.
* fast/dom/MicroData/itemref-add-remove-tokens-expected.txt: Removed.
* fast/dom/MicroData/itemref-add-remove-tokens.html: Removed.
* fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property-expected.txt: Removed.
* fast/dom/MicroData/itemref-attribute-reflected-by-itemRef-property.html: Removed.
* fast/dom/MicroData/itemref-for-an-element-must-be-correct-expected.txt: Removed.
* fast/dom/MicroData/itemref-for-an-element-must-be-correct.html: Removed.
* fast/dom/MicroData/itemref-must-be-read-only-expected.txt: Removed.
* fast/dom/MicroData/itemref-must-be-read-only.html: Removed.
* fast/dom/MicroData/itemref-pointing-to-root-node-expected.txt: Removed.
* fast/dom/MicroData/itemref-pointing-to-root-node.html: Removed.
* fast/dom/MicroData/itemref-refers-first-element-with-given-id-expected.txt: Removed.
* fast/dom/MicroData/itemref-refers-first-element-with-given-id.html: Removed.
* fast/dom/MicroData/itemscope-attribute-test-expected.txt: Removed.
* fast/dom/MicroData/itemscope-attribute-test.html: Removed.
* fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Removed.
* fast/dom/MicroData/itemscope-must-be-read-write.html: Removed.
* fast/dom/MicroData/itemtype-add-remove-tokens-expected.txt: Removed.
* fast/dom/MicroData/itemtype-add-remove-tokens.html: Removed.
* fast/dom/MicroData/itemtype-attribute-test-expected.txt: Removed.
* fast/dom/MicroData/itemtype-attribute-test.html: Removed.
* fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-reflects-data-attr-on-object-element.html: Removed.
* fast/dom/MicroData/itemvalue-reflects-href-attr-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-reflects-href-attr.html: Removed.
* fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-reflects-src-attribute-on-img-element.html: Removed.
* fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-reflects-the-content-attr-on-meta-element.html: Removed.
* fast/dom/MicroData/itemvalue-reflects-the-src-attr-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-reflects-the-src-attr.html: Removed.
* fast/dom/MicroData/itemvalue-returns-element-itself-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-returns-element-itself.html: Removed.
* fast/dom/MicroData/itemvalue-returns-null-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-returns-null.html: Removed.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-001.html: Removed.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002-expected.txt: Removed.
* fast/dom/MicroData/itemvalue-throws-excpetion-onsetting-002.html: Removed.
* fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens-expected.txt: Removed.
* fast/dom/MicroData/microdata-domtokenlist-attribute-add-remove-tokens.html: Removed.
* fast/dom/MicroData/nameditem-must-be-case-sensitive-expected.txt: Removed.
* fast/dom/MicroData/nameditem-must-be-case-sensitive.html: Removed.
* fast/dom/MicroData/nameditem-must-return-correct-item-properties-expected.txt: Removed.
* fast/dom/MicroData/nameditem-must-return-correct-item-properties.html: Removed.
* fast/dom/MicroData/nameditem-returns-propertynodelist-expected.txt: Removed.
* fast/dom/MicroData/nameditem-returns-propertynodelist.html: Removed.
* fast/dom/MicroData/names-item-out-of-range-index-expected.txt: Removed.
* fast/dom/MicroData/names-item-out-of-range-index.html: Removed.
* fast/dom/MicroData/names-property-must-be-correct-expected.txt: Removed.
* fast/dom/MicroData/names-property-must-be-correct.html: Removed.
* fast/dom/MicroData/names-property-test-expected.txt: Removed.
* fast/dom/MicroData/names-property-test.html: Removed.
* fast/dom/MicroData/properties-collection-add-remove-itemref-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-add-remove-itemref.html: Removed.
* fast/dom/MicroData/properties-collection-add-remove-property-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-add-remove-property.html: Removed.
* fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-behavior-add-remove-itemscope-attr.html: Removed.
* fast/dom/MicroData/properties-collection-must-be-correct-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-must-be-correct.html: Removed.
* fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-must-ignore-properties-of-nested-items.html: Removed.
* fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-must-see-the-properties-added-in-itemref.html: Removed.
* fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-namedgetter-with-invalid-name.html: Removed.
* fast/dom/MicroData/properties-collection-nameditem-test-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-nameditem-test.html: Removed.
* fast/dom/MicroData/properties-collection-test-expected.txt: Removed.
* fast/dom/MicroData/properties-collection-test.html: Removed.
* fast/dom/MicroData/propertiescollection-crash-expected.txt: Removed.
* fast/dom/MicroData/propertiescollection-crash.html: Removed.
* fast/dom/MicroData/propertiescollection-on-changing-id-attr-expected.txt: Removed.
* fast/dom/MicroData/propertiescollection-on-changing-id-attr.html: Removed.
* fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-add-remove-itemprop-tokens.html: Removed.
* fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-add-remove-itemref-tokens.html: Removed.
* fast/dom/MicroData/propertynodelist-crash-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-crash.html: Removed.
* fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-getvalues-array-values-obtained-from-itemvalue-of-each-element.html: Removed.
* fast/dom/MicroData/propertynodelist-getvalues-test-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-getvalues-test.html: Removed.
* fast/dom/MicroData/propertynodelist-test-add-remove-element-expected.txt: Removed.
* fast/dom/MicroData/propertynodelist-test-add-remove-element.html: Removed.
* fast/dom/MicroData/resources: Removed.
* fast/dom/MicroData/resources/microdata-common.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove PlatformCALayer::contentsTransform and ::setContentsTransform
timothy_horton@apple.com [Tue, 6 Aug 2013 23:21:32 +0000 (23:21 +0000)]
Remove PlatformCALayer::contentsTransform and ::setContentsTransform
https://bugs.webkit.org/show_bug.cgi?id=119529

Reviewed by Sam Weinig.

No new tests, removing dead code.

These methods are not used and are currently unimplemented.

* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
* platform/graphics/ca/win/PlatformCALayerWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement gesture recognizer.
commit-queue@webkit.org [Tue, 6 Aug 2013 23:01:33 +0000 (23:01 +0000)]
[EFL][WK2] Implement gesture recognizer.
https://bugs.webkit.org/show_bug.cgi?id=102643

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-08-06
Reviewed by Gyuyoung Kim.

Recognize tap, pan and pinch gestures using touch events.
The tap gesture is separated into single tap, double tap and
'tap and hold'.

This patch references the webkit NIX port.
https://github.com/WebKitNix/webkitnix

* PlatformEfl.cmake:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::doneWithTouchEvent):
* UIProcess/API/efl/EwkView.h:
* UIProcess/API/efl/GestureRecognizer.cpp: Added.
(WebKit::GestureHandler::create):
(WebKit::GestureHandler::GestureHandler):
(WebKit::GestureHandler::handleSingleTap):
(WebKit::GestureHandler::handleDoubleTap):
(WebKit::GestureHandler::handleTapAndHold):
(WebKit::GestureHandler::handlePanStarted):
(WebKit::GestureHandler::handlePan):
(WebKit::GestureHandler::handlePanFinished):
(WebKit::GestureHandler::handlePinchStarted):
(WebKit::GestureHandler::handlePinch):
(WebKit::GestureHandler::handlePinchFinished):
(WebKit::GestureRecognizer::GestureRecognizer):
(WebKit::GestureRecognizer::~GestureRecognizer):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::doubleTapTimerCallback):
(WebKit::GestureRecognizer::tapAndHoldTimerCallback):
(WebKit::GestureRecognizer::exceedsPanThreshold):
(WebKit::GestureRecognizer::exceedsDoubleTapThreshold):
(WebKit::getPointAtIndex):
(WebKit::createVectorWithWKArray):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
(WebKit::GestureRecognizer::reset):
(WebKit::GestureRecognizer::stopTapTimers):
* UIProcess/API/efl/GestureRecognizer.h: Added.
(WebKit::GestureRecognizer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] New positioning model: scripted shape-margin tests
hmuller@adobe.com [Tue, 6 Aug 2013 22:16:18 +0000 (22:16 +0000)]
[CSS Shapes] New positioning model: scripted shape-margin tests
https://bugs.webkit.org/show_bug.cgi?id=119491

Update some of the shape-margin tests to work with the new positioning model. Floats
that specify shape-outside are now positioned according to their margin box, not the
bounding box of the shape-outside shape. The tests have been revised to reflect the
change.

Reviewed by Alexandru Chiculita.

* TestExpectations:
* fast/shapes/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html:
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
* fast/shapes/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnabled WebGL on WinCairo port.
achristensen@apple.com [Tue, 6 Aug 2013 22:11:57 +0000 (22:11 +0000)]
Enabled WebGL on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=119502

Reviewed by Benjamin Poulain.

Source/WebKit:

* WebKit.vcxproj/WebKit.sln: Build ANGLE libraries.
* WebKit.vcxproj/WebKit/WebKitCFLite.props: Link to ANGLE libraries.

Source/WTF:

* wtf/FeatureDefines.h: Enabled WebGL.
* wtf/Platform.h: Added definitions required for WebGL on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/5927399> FastMalloc should support MallocStackLogging
mrowe@apple.com [Tue, 6 Aug 2013 22:10:02 +0000 (22:10 +0000)]
<rdar://problem/5927399> FastMalloc should support MallocStackLogging

Call the malloc stack logging function from within the various entry points to FastMalloc
when stack logging is enabled.

Reviewed by Oliver Hunt and Geoff Garen.

* wtf/FastMalloc.cpp:
Call in to MallocHook::InvokeNewHook / MallocHook::InvokeDeleteHook at the appropriate entry
points to FastMalloc. The naming comes from TCMalloc's existing, unused concept of malloc hooks.
(WTF::MallocHook::record): Call the stack logging function with appropriate argument types.
(WTF::MallocHook::recordAllocation): Out-of-line slow path for when stack logging is enabled
that calls record with the values in the right arguments.
(WTF::MallocHook::recordDeallocation): Ditto.
(WTF::MallocHook::init): Stack logging is enabled if the system allocator has enabled stack logging.
(WTF::MallocHook::InvokeNewHook): Call recordAllocation in the unlikely event that stack logging is
enabled.
(WTF::MallocHook::InvokeDeleteHook): Ditto for recordDeallocation.
(WTF::TCMalloc_ThreadCache::InitModule): Initialize the malloc hook.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoved GraphicsContext3DPrivate out of cairo directory to be used by the AppleWin...
achristensen@apple.com [Tue, 6 Aug 2013 21:55:42 +0000 (21:55 +0000)]
Moved GraphicsContext3DPrivate out of cairo directory to be used by the AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=119525

Reviewed by Dean Jackson.

* GNUmakefile.list.am:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Changed location of GraphicsContext3DPrivate.cpp and GraphicsContext3DPrivate.h.
* platform/graphics/GraphicsContext3DPrivate.cpp: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.cpp.
* platform/graphics/GraphicsContext3DPrivate.h: Copied from WebCore/platform/graphics/cairo/GraphicsContext3DPrivate.h.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Removed.
* platform/graphics/cairo/GraphicsContext3DPrivate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove stale code in ResourceContentView
commit-queue@webkit.org [Tue, 6 Aug 2013 21:38:26 +0000 (21:38 +0000)]
Web Inspector: Remove stale code in ResourceContentView
https://bugs.webkit.org/show_bug.cgi?id=119527

The handling of Resource Type changes moved to ResourceClusterContentView,
this removeEventListener is stale and doesn't do anything anymore.

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-06
Reviewed by Timothy Hatcher.

* UserInterface/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype.closed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed build correction after r153754 and r153757.
bfulgham@apple.com [Tue, 6 Aug 2013 21:31:46 +0000 (21:31 +0000)]
[Windows] Unreviewed build correction after r153754 and r153757.

Source/WebCore:

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Don't force std::remainder, since we are using our own
custom implementation on Windows.

Source/WTF:

* wtf/MathExtras.h:
(remainder): Provide implementation of C99 remainder for VS2010 (and earlier).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelay Arguments creation in strict mode
oliver@apple.com [Tue, 6 Aug 2013 21:20:10 +0000 (21:20 +0000)]
Delay Arguments creation in strict mode
https://bugs.webkit.org/show_bug.cgi?id=119505

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Make use of the write tracking performed by the parser to
allow us to know if we're modifying the parameters to a function.
Then use that information to make strict mode function opt out
of eager arguments creation.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::createArgumentsIfNecessary):
(JSC::BytecodeGenerator::emitReturn):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::shouldTearOffArgumentsEagerly):
* parser/Nodes.h:
(JSC::ScopeNode::modifiesParameter):
* parser/Parser.cpp:
(JSC::::parseInner):
* parser/Parser.h:
(JSC::Scope::declareParameter):
(JSC::Scope::getCapturedVariables):
(JSC::Parser::declareWrite):
* parser/ParserModes.h:

LayoutTests:

Add performance testcase for lazy creation of arguments in strict mode

* fast/js/regress/delay-tear-off-arguments-strictmode-expected.txt: Added.
* fast/js/regress/delay-tear-off-arguments-strictmode.html: Added.
* fast/js/regress/script-tests/delay-tear-off-arguments-strictmode.js: Added.
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove useless code from COMPILER(RVCT) JITStubs
paroga@webkit.org [Tue, 6 Aug 2013 20:51:22 +0000 (20:51 +0000)]
Remove useless code from COMPILER(RVCT) JITStubs
https://bugs.webkit.org/show_bug.cgi?id=119521

Reviewed by Geoffrey Garen.

* jit/JITStubsARMv7.h:
(JSC::ctiVMThrowTrampoline): "ldr r6, [sp, #PRESERVED_R6_OFFSET]" was called twice.
(JSC::ctiOpThrowNotCaught): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert all Web Inspector PDFs to SVGs.
timothy@apple.com [Tue, 6 Aug 2013 20:37:13 +0000 (20:37 +0000)]
Convert all Web Inspector PDFs to SVGs.

Some PDFs need to stay around until bug 119492 is fixed. But the SVGs are there for when they are needed.
Updated some of the existing SVGs to be consistent with the format of the new SVGs.

https://bugs.webkit.org/show_bug.cgi?id=118677

Rubber-stamped by Joseph Pecoraro.

* UserInterface/BreakpointIcons.css:
* UserInterface/BreakpointTreeElement.css:
* UserInterface/CallFrameIcons.css:
* UserInterface/DatabaseContentView.css:
* UserInterface/FilterBar.css:
* UserInterface/HierarchicalPathComponent.css:
* UserInterface/Images/BackArrow.svg: Added.
* UserInterface/Images/BottomUpTree.svg: Added.
* UserInterface/Images/BreakpointButton.pdf: Removed.
* UserInterface/Images/BreakpointButton.svg: Added.
* UserInterface/Images/BreakpointInactiveButton.pdf: Removed.
* UserInterface/Images/BreakpointInactiveButton.svg: Added.
* UserInterface/Images/Breakpoints.svg: Added.
* UserInterface/Images/Close.svg: Added.
* UserInterface/Images/Crosshair.svg: Added.
* UserInterface/Images/DOMCharacterData.pdf: Removed.
* UserInterface/Images/DOMCharacterData.svg: Added.
* UserInterface/Images/DOMComment.pdf: Removed.
* UserInterface/Images/DOMComment.svg: Added.
* UserInterface/Images/DOMDocument.pdf: Removed.
* UserInterface/Images/DOMDocument.svg: Added.
* UserInterface/Images/DOMDocumentType.pdf: Removed.
* UserInterface/Images/DOMDocumentType.svg: Added.
* UserInterface/Images/DOMElement.pdf: Removed.
* UserInterface/Images/DOMElement.svg: Added.
* UserInterface/Images/DOMNode.pdf: Removed.
* UserInterface/Images/DOMNode.svg: Added.
* UserInterface/Images/DOMTextNode.pdf: Removed.
* UserInterface/Images/DOMTextNode.svg: Added.
* UserInterface/Images/DOMTree.pdf: Removed.
* UserInterface/Images/DOMTree.svg: Added.
* UserInterface/Images/DisclosureTriangleSmallClosed.svg: Added.
* UserInterface/Images/DisclosureTriangleSmallOpen.svg: Added.
* UserInterface/Images/DisclosureTriangleTinyClosed.svg: Added.
* UserInterface/Images/DisclosureTriangleTinyOpen.svg: Added.
* UserInterface/Images/DockBottom.svg: Added.
* UserInterface/Images/DockRight.svg: Added.
* UserInterface/Images/Error.pdf: Removed.
* UserInterface/Images/Error.svg: Added.
* UserInterface/Images/ErrorSmall.pdf: Removed.
* UserInterface/Images/Errors.svg:
* UserInterface/Images/ErrorsEnabled.svg:
* UserInterface/Images/EventListener.pdf: Removed.
* UserInterface/Images/EventListener.svg: Added.
* UserInterface/Images/Exception.pdf: Removed.
* UserInterface/Images/Exception.svg: Added.
* UserInterface/Images/FilterFieldGlyph.pdf: Removed.
* UserInterface/Images/FilterFieldGlyph.svg: Added.
* UserInterface/Images/ForwardArrow.svg: Added.
* UserInterface/Images/Function.pdf: Removed.
* UserInterface/Images/Function.svg: Added.
* UserInterface/Images/GoToArrow.svg: Added.
* UserInterface/Images/HierarchicalNavigationItemChevron.pdf: Removed.
* UserInterface/Images/HierarchicalNavigationItemChevron.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner1.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner1.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner10.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner10.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner11.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner11.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner12.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner12.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner2.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner2.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner3.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner3.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner4.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner4.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner5.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner5.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner6.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner6.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner7.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner7.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner8.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner8.svg: Added.
* UserInterface/Images/IndeterminateProgressSpinner9.pdf: Removed.
* UserInterface/Images/IndeterminateProgressSpinner9.svg: Added.
* UserInterface/Images/Issues.svg:
* UserInterface/Images/IssuesEnabled.svg:
* UserInterface/Images/LayerBorders.svg: Added.
* UserInterface/Images/LessColumns.svg: Added.
* UserInterface/Images/Locked.svg: Added.
* UserInterface/Images/Logs.svg:
* UserInterface/Images/Memory.svg:
* UserInterface/Images/MoreColumns.svg: Added.
* UserInterface/Images/Native.pdf: Removed.
* UserInterface/Images/Native.svg: Added.
* UserInterface/Images/NavigationItemAngleBrackets.svg: Added.
* UserInterface/Images/NavigationItemBrushAndRuler.svg: Added.
* UserInterface/Images/NavigationItemBug.svg: Added.
* UserInterface/Images/NavigationItemCurleyBraces.svg: Added.
* UserInterface/Images/NavigationItemFile.svg: Added.
* UserInterface/Images/NavigationItemLayers.svg: Added.
* UserInterface/Images/NavigationItemLog.svg: Added.
* UserInterface/Images/NavigationItemMagnifyingGlass.svg: Added.
* UserInterface/Images/NavigationItemStopwatch.svg: Added.
* UserInterface/Images/NavigationItemStorage.svg: Added.
* UserInterface/Images/NavigationItemTrash.svg: Added.
* UserInterface/Images/NavigationItemVariable.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutLeft.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutLeft.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutRight.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutRight.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutWhiteLeft.svg: Added.
* UserInterface/Images/NetworkBarLabelCalloutWhiteRight.pdf: Removed.
* UserInterface/Images/NetworkBarLabelCalloutWhiteRight.svg: Added.
* UserInterface/Images/Pause.svg: Added.
* UserInterface/Images/Percent.svg: Added.
* UserInterface/Images/Plus.svg: Added.
* UserInterface/Images/PseudoElement.pdf: Removed.
* UserInterface/Images/PseudoElement.svg: Added.
* UserInterface/Images/Reflection.pdf: Removed.
* UserInterface/Images/Reflection.svg: Added.
* UserInterface/Images/Reload.svg:
* UserInterface/Images/ReloadSelected.svg:
* UserInterface/Images/Request.pdf: Removed.
* UserInterface/Images/Request.svg: Added.
* UserInterface/Images/Resources.svg:
* UserInterface/Images/Response.pdf: Removed.
* UserInterface/Images/Response.svg: Added.
* UserInterface/Images/ResultLine.pdf: Removed.
* UserInterface/Images/ResultLine.svg: Added.
* UserInterface/Images/Resume.svg: Added.
* UserInterface/Images/ShadowDOM.svg: Added.
* UserInterface/Images/SortIndicatorDownArrow.svg: Added.
* UserInterface/Images/SortIndicatorUpArrow.svg: Added.
* UserInterface/Images/SourceCode.pdf: Removed.
* UserInterface/Images/SourceCode.svg: Added.
* UserInterface/Images/SplitToggleDown.svg: Added.
* UserInterface/Images/SplitToggleUp.svg: Added.
* UserInterface/Images/StepInto.svg: Added.
* UserInterface/Images/StepOut.svg: Added.
* UserInterface/Images/StepOver.svg: Added.
* UserInterface/Images/StyleRuleAuthor.pdf: Removed.
* UserInterface/Images/StyleRuleAuthor.svg: Added.
* UserInterface/Images/StyleRuleInherited.pdf: Removed.
* UserInterface/Images/StyleRuleInherited.svg: Added.
* UserInterface/Images/StyleRuleInheritedElement.pdf: Removed.
* UserInterface/Images/StyleRuleInheritedElement.svg: Added.
* UserInterface/Images/StyleRuleInspector.pdf: Removed.
* UserInterface/Images/StyleRuleInspector.svg: Added.
* UserInterface/Images/StyleRuleUser.pdf: Removed.
* UserInterface/Images/StyleRuleUser.svg: Added.
* UserInterface/Images/StyleRuleUserAgent.pdf: Removed.
* UserInterface/Images/StyleRuleUserAgent.svg: Added.
* UserInterface/Images/Time.svg:
* UserInterface/Images/Undock.svg: Added.
* UserInterface/Images/UpDownArrows.svg:
* UserInterface/Images/UserInputPrompt.pdf: Removed.
* UserInterface/Images/UserInputPrompt.svg: Added.
* UserInterface/Images/UserInputPromptPrevious.pdf: Removed.
* UserInterface/Images/UserInputPromptPrevious.svg: Added.
* UserInterface/Images/UserInputPromptPreviousSelected.pdf: Removed.
* UserInterface/Images/UserInputPromptPreviousSelected.svg: Added.
* UserInterface/Images/UserInputResult.pdf: Removed.
* UserInterface/Images/UserInputResult.svg: Added.
* UserInterface/Images/UserInputResultSelected.pdf: Removed.
* UserInterface/Images/UserInputResultSelected.svg: Added.
* UserInterface/Images/Warning.pdf: Removed.
* UserInterface/Images/Warning.svg: Added.
* UserInterface/Images/WarningSmall.pdf: Removed.
* UserInterface/Images/Weight.svg:
* UserInterface/IndeterminateProgressSpinner.css:
* UserInterface/LayerTreeSidebarPanel.css:
* UserInterface/LogContentView.css:
* UserInterface/Main.css:
* UserInterface/NetworkTimeline.css:
* UserInterface/PathComponentIcons.css:
* UserInterface/QuickConsole.css:
* UserInterface/RulesStyleDetailsPanel.css:
* UserInterface/SearchIcons.css:
* UserInterface/StyleRuleIcons.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] New positioning model: support for shape-margin
bjonesbe@adobe.com [Tue, 6 Aug 2013 18:53:06 +0000 (18:53 +0000)]
[CSS Shapes] New positioning model: support for shape-margin
https://bugs.webkit.org/show_bug.cgi?id=118088

Reviewed by Alexandru Chiculita.

Update simple shape-margin tests to work with new positioning model.
Also move them to the CSSWG's repo.

* TestExpectations: Remove replaced tests.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-left-margin-polygon.html.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-shape-margin-001.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-right-margin-polygon.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImproper Calculation of In-band Cue Colors
bfulgham@apple.com [Tue, 6 Aug 2013 18:39:52 +0000 (18:39 +0000)]
Improper Calculation of In-band Cue Colors
https://bugs.webkit.org/show_bug.cgi?id=119523

Reviewed by Eric Carlson.

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::makeRGBA32FromARGBCFArray): Remove redundant multiplication by
255.  The internal conversion logic already converts to bytes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative build fix after r153754.
rwlbuis@webkit.org [Tue, 6 Aug 2013 18:11:35 +0000 (18:11 +0000)]
Speculative build fix after r153754.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building...
dfarler@apple.com [Tue, 6 Aug 2013 17:43:57 +0000 (17:43 +0000)]
Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
https://bugs.webkit.org/show_bug.cgi?id=117762

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* Configurations/JavaScriptCore.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* Configurations/ToolExecutable.xcconfig:
Don't use ASAN for build tools.

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* gtest/xcode/Config/StaticLibraryTarget.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/ThirdParty/ANGLE:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Source/WebCore:

No new tests necessary.

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* Configurations/WebCore.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* Configurations/WebCoreTestShim.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* Configurations/WebCoreTestSupport.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* WebCore.xcodeproj/project.pbxproj:
Don't use ASAN for build tools.

Source/WebInspectorUI:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.

Source/WebKit/mac:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* Configurations/WebKit.xcconfig:
Add ASAN_OTHER_LDFLAGS.

Source/WebKit2:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* Configurations/WebContentProcess.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* Configurations/WebKit2.xcconfig:
Add ASAN_OTHER_LDFLAGS.

Source/WTF:

* Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS.

Tools:

* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* MiniBrowser/Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* Scripts/check-for-weak-vtables-and-externals:
Ignore ___asan externals, these are populated by compiler-rt.
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* WebKitLauncher/Configurations/Base.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
* WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
Add ASAN_OTHER_LDFLAGS.
* asan/asan.xcconfig: Added.
* asan/webkit-asan-ignore.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG stroke-dasharray is not animatable
rwlbuis@webkit.org [Tue, 6 Aug 2013 15:54:23 +0000 (15:54 +0000)]
SVG stroke-dasharray is not animatable
https://bugs.webkit.org/show_bug.cgi?id=118574

Reviewed by Dirk Schulze.

Source/WebCore:

Make stroke-dasharray a property that can be animated using CSS transitions.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):
* rendering/style/RenderStyle.h:

LayoutTests:

Add test for animating stroke-dasharray in addition to the original SVG tests.

* transitions/svg-transitions-expected.txt:
* transitions/svg-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r151403): Resizing is extremely laggy on many sites when plugins are disal...
akling@apple.com [Tue, 6 Aug 2013 15:40:50 +0000 (15:40 +0000)]
REGRESSION(r151403): Resizing is extremely laggy on many sites when plugins are disallowed.
<http://webkit.org/b/119516>
<rdar://problem/14648086>

Reviewed by Simon Fraser.

The web process relies on the WindowAndViewFramesChanged mechanism for caching a copy
of the window rect for fast access from DOMWindow APIs.

We retain part of the optimization introduced in r151403, namely not computing the
viewFrameInWindowCoordinates and accessibilityPosition unless the web process needs them.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Allow defining named grid lines on the grid element
sergio@webkit.org [Tue, 6 Aug 2013 15:08:21 +0000 (15:08 +0000)]
[CSS Grid Layout] Allow defining named grid lines on the grid element
https://bugs.webkit.org/show_bug.cgi?id=118255

Reviewed by Andreas Kling.

From Blink r149798 by <jchaffraix@chromium.org>

Source/WebCore:

This change adds parsing, style resolution and getComputedStyle
support for named grid lines at the grid element level
(i.e. extends our <track-list> support). Per the specification, we
allow multiple grid lines with the same name.

To fully support resolving the grid lines to a position on our
grid, we need to add the parsing at the grid item's level (which
means extending our <grid-line> support). This will be done in a
follow-up change.

Test: fast/css-grid-layout/named-grid-line-get-set.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList):
* css/StyleResolver.cpp:
(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):

LayoutTests:

* fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
* fast/css-grid-layout/named-grid-line-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add Page Visibility API support
commit-queue@webkit.org [Tue, 6 Aug 2013 13:58:39 +0000 (13:58 +0000)]
[Qt] Add Page Visibility API support
https://bugs.webkit.org/show_bug.cgi?id=109422

Patch by Benjamin Dupont <bdupont@nds.com> on 2013-08-06
Reviewed by Simon Hausmann.

* WebCoreSupport/QWebPageAdapter.cpp:
(webPageVisibilityStateToWebCoreVisibilityState):
(webCoreVisibilityStateToWebPageVisibilityState):
(QWebPageAdapter::setVisibilityState):
(QWebPageAdapter::visibilityState):
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebpage.cpp:
(QWebPage::setVisibilityState):
(QWebPage::visibilityState):
* WidgetApi/qwebpage.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::changeVisibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix minimal build.
allan.jensen@digia.com [Tue, 6 Aug 2013 12:52:36 +0000 (12:52 +0000)]
[Qt] Fix minimal build.

Unreviewed build fix.

Fix build witt XSLT disabled

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::hasNoStyleInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-gtk fails to build with bison-3.0
zandobersek@gmail.com [Tue, 6 Aug 2013 12:45:10 +0000 (12:45 +0000)]
webkit-gtk fails to build with bison-3.0
https://bugs.webkit.org/show_bug.cgi?id=119373

Reviewed by Gustavo Noronha Silva.

Source/ThirdParty/ANGLE:

* GNUmakefile.am: Stop relying on generated glslang_tab.(cpp|h) and glslang.cpp sources as Bison 3.0
produces non-compilable source code. Instead, compile these pregenerated files as they're included in
the tree. Originally, the ANGLE source tree provides these files as generated by Bison 2.7, but they're
at the moment regenerated with Bison 2.3 when the third-party ANGLE source is being updated.

Source/WebCore:

* GNUmakefile.am: Remove rules for generating ANGLE's glslang source files with Bison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
sergio@webkit.org [Tue, 6 Aug 2013 11:45:58 +0000 (11:45 +0000)]
[CSS Grid Layout] Add support for parsing <grid-line> that includes a 'span'
https://bugs.webkit.org/show_bug.cgi?id=118051

Reviewed by Andreas Kling.

From Blink r148766 by <jchaffraix@chromium.org>

Source/WebCore:

This adds the parsing, style resolution and getComputedStyle bits
to our code. The rendering code was not made aware of the new type
of GridPosition yet.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForGridPosition):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):
* css/CSSParser.h:
* css/CSSValueKeywords.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):
* css/StyleResolver.h:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionFromStyle):
* rendering/style/GridPosition.h:
(WebCore::GridPosition::isInteger):
(WebCore::GridPosition::isSpan):
(WebCore::GridPosition::setSpanPosition):
(WebCore::GridPosition::spanPosition):

LayoutTests:

Added several test cases to check that we properly parse the
keyword 'span' in <grid-line>.

* fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
* fast/css-grid-layout/grid-item-start-before-get-set.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for GTK 32-bit after r153736
simon.pena@samsung.com [Tue, 6 Aug 2013 11:08:03 +0000 (11:08 +0000)]
Build fix for GTK 32-bit after r153736

* Source/autotools/symbols.filter: expose WebCore::SerializedScriptValue::create.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Rename grid placement properties
sergio@webkit.org [Tue, 6 Aug 2013 10:33:32 +0000 (10:33 +0000)]
[CSS Grid Layout] Rename grid placement properties
https://bugs.webkit.org/show_bug.cgi?id=117878

Reviewed by Andreas Kling.

Renamed the grid placement properties to match the latest version
of the spec. The new names are -webkit-grid-column-{start|end} and
-webkit-grid-row-{start|end}.

Source/WebCore:

No new tests needed as we're just renaming some properties,
functionality already covered by existing tests in
fast/css-grid-layout.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StylePropertyShorthand.cpp:
(WebCore::webkitGridColumnShorthand):
(WebCore::webkitGridRowShorthand):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridItemData.cpp:
(WebCore::StyleGridItemData::StyleGridItemData):
* rendering/style/StyleGridItemData.h:
(WebCore::StyleGridItemData::operator==):

LayoutTests:

* fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
* fast/css-grid-layout/grid-item-end-after-get-set.html:
* fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
* fast/css-grid-layout/grid-item-start-before-get-set.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for ARM MSVC after r153222 and r153648.
paroga@webkit.org [Tue, 6 Aug 2013 10:04:18 +0000 (10:04 +0000)]
Build fix for ARM MSVC after r153222 and r153648.

* jit/JITStubsARM.h: Added ctiVMThrowTrampolineSlowpath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for ARM MSVC after r150109.
paroga@webkit.org [Tue, 6 Aug 2013 10:03:30 +0000 (10:03 +0000)]
Build fix for ARM MSVC after r150109.

Read the stub template from a header files instead of the JITStubs.cpp.

* CMakeLists.txt:
* DerivedSources.pri:
* create_jit_stubs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for GTK after r153736
simon.pena@samsung.com [Tue, 6 Aug 2013 09:36:04 +0000 (09:36 +0000)]
Build fix for GTK after r153736

* Source/autotools/symbols.filter: expose missing symbols
WebCore::SerializedScriptValue::create and WebCore::toJS to Internals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@153743 268f45cc-cd09-0410-ab3c-d52691b4dbfc