WebKit-https.git
13 years ago2007-02-27 Mitz Pettel <mitz@webkit.org>
ap [Tue, 27 Feb 2007 18:00:44 +0000 (18:00 +0000)]
2007-02-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=12906
          REGRESSION: Canvas is pixelated when the page is opened in a background tab

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scaleFactor): If the view is not in a window, use the main
        screen's scale factor as a best guess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
ap [Tue, 27 Feb 2007 17:48:35 +0000 (17:48 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12594
        REGRESSION: Strange highlight in active input area

        No automated test possible.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint): Restore a check lost in r12792.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Small tweak to run-webkit-tests.
ggaren [Tue, 27 Feb 2007 16:18:54 +0000 (16:18 +0000)]
    Small tweak to run-webkit-tests.

        * Scripts/run-webkit-tests: Allow people with lots of RAM to run more than
        1000 MallocStackLogging tests at a time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
darin [Tue, 27 Feb 2007 14:08:52 +0000 (14:08 +0000)]
    Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12908
          crash in http/tests/incremental/frame-focus-before-load.html

        * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView):
        Add null checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alexey.
darin [Tue, 27 Feb 2007 14:05:50 +0000 (14:05 +0000)]
    Reviewed by Alexey.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12909
          should use ICU, not TEC, for MacRoman decoding

        * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
        Add "macroman" as an alias for "macintosh". We have seen that in use in mail,
        although I'm not sure it's used on the web.

        * platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back
        as part of the patch for bug 4971226. But by adding it to the this file rather
        than the ICU codec, we get it only on Mac OS X. And long term we are trying to
        get rid of the use of TEC entirely, so we want this file to be as empty as
        possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - test for MacRoman encoding name alias
darin [Tue, 27 Feb 2007 14:05:39 +0000 (14:05 +0000)]
    - test for MacRoman encoding name alias

        * fast/encoding/charset-names-expected.txt: Added.
        * fast/encoding/charset-names.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * fast/css/computed-style-expected.txt: Updated test result for
darin [Tue, 27 Feb 2007 13:02:55 +0000 (13:02 +0000)]
    * fast/css/computed-style-expected.txt: Updated test result for
        Hyatt's addition of -webkit-border-fit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis [Tue, 27 Feb 2007 10:12:21 +0000 (10:12 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12905
        Not all svg shapes should support markers

        Restrict marker usage to svg shapes polyline, polygon, line and path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 27 Feb 2007 08:44:40 +0000 (08:44 +0000)]
LayoutTests:

        Reviewed by Lars.

        Updated test for http://bugs.webkit.org/show_bug.cgi?id=12902
        <rdar://problem/5012679> REGRESSION: Pressing return key doesn't
        move caret to next line after applying a font color in GMail

        * fast/frames/iframe-window-focus-expected.txt:
        * fast/frames/iframe-window-focus.html: Updated test to include insertion of newlines.

WebCore:

        Reviewed by Lars.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12902
        <rdar://problem/5012679> REGRESSION: Pressing return key doesn't
        move caret to next line after applying a font color in GMail

        Test: fast/frames/iframe-window-focus-2.html

        * page/EventHandler.h: Make focusDocumentView public.
        * page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame,
          we should set also focus the document view.  The bug here was that since the subframe view
          wasn't the first responder, the key down event was going to the wrong frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
mjs [Tue, 27 Feb 2007 07:19:11 +0000 (07:19 +0000)]
LayoutTests:

        Reviewed by Oliver.

        - test cases for <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244)
        http://bugs.webkit.org/show_bug.cgi?id=11244

        * svg/custom/circular-marker-reference-1-expected.checksum: Added.
        * svg/custom/circular-marker-reference-1-expected.png: Added.
        * svg/custom/circular-marker-reference-1-expected.txt: Added.
        * svg/custom/circular-marker-reference-1.svg: Added.
        * svg/custom/circular-marker-reference-2-expected.checksum: Added.
        * svg/custom/circular-marker-reference-2-expected.png: Added.
        * svg/custom/circular-marker-reference-2-expected.txt: Added.
        * svg/custom/circular-marker-reference-2.svg: Added.
        * svg/custom/circular-marker-reference-3-expected.checksum: Added.
        * svg/custom/circular-marker-reference-3-expected.png: Added.
        * svg/custom/circular-marker-reference-3-expected.txt: Added.
        * svg/custom/circular-marker-reference-3.svg: Added.
        * svg/custom/circular-marker-reference-4-expected.checksum: Added.
        * svg/custom/circular-marker-reference-4-expected.png: Added.
        * svg/custom/circular-marker-reference-4-expected.txt: Added.
        * svg/custom/circular-marker-reference-4.svg: Added.
        * svg/custom/non-circular-marker-reference-expected.checksum: Added.
        * svg/custom/non-circular-marker-reference-expected.png: Added.
        * svg/custom/non-circular-marker-reference-expected.txt: Added.
        * svg/custom/non-circular-marker-reference.svg: Added.

WebCore:

        Reviewed by Oliver.

        - fixed <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244)
        http://bugs.webkit.org/show_bug.cgi?id=11244

        * platform/graphics/svg/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against
        reference cycles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mjs [Tue, 27 Feb 2007 05:30:48 +0000 (05:30 +0000)]
WebCore:

        Reviewed by Kevin McCullough.

        - fix Qt build for earlier SVG changes.

        * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

WebKitQt:

        Reviewed by Kevin McCullough.

        - fix Qt build for earlier SVG changes.

        * WebCoreSupport/EditCommandQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-26 Oliver Hunt <oliver@apple.com>
oliver [Tue, 27 Feb 2007 05:23:22 +0000 (05:23 +0000)]
2007-02-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Fix for <rdar://problem/4827378>: Canvas with large height
        uses lots of memory, computer almost stops responding

        Put cap on maximum area of canvas, size is similar too the
        maximum size allowed by firefox (firefox seems to to cut off
        at area == 32767 * 9358).

        Also protect renderer against the possibility of a null context
        (this was triggering a CG warning)

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createDrawingContext):
           Apply maximum canvas area
        (WebCore::HTMLCanvasElement::createPlatformImage):
           Protect against null CG Context

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-26 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 27 Feb 2007 05:13:49 +0000 (05:13 +0000)]
2007-02-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Antti Koivisto.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12899
          Ordered lists not updating dynamically with new styles
  <rdar://problem/4889356>

        Test: fast/lists/list-style-type-dynamic-change.html

        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger
        updating of the marker.

2007-02-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Antti Koivisto.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12899
          Ordered lists not updating dynamically with new styles

        * fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
        * fast/lists/list-style-type-dynamic-change-expected.png: Added.
        * fast/lists/list-style-type-dynamic-change-expected.txt: Added.
        * fast/lists/list-style-type-dynamic-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Lars.
mjs [Tue, 27 Feb 2007 04:04:24 +0000 (04:04 +0000)]
    Reviewed by Lars.

        - set ENABLE_XSLT even when compiling without SVG support, since that is no
        longer hardcoded into config.h.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago JavaScriptCore:
kjk [Tue, 27 Feb 2007 01:56:16 +0000 (01:56 +0000)]
  JavaScriptCore:

        Reviewed by Adam Roben.

        Rename *_SUPPORT defines to ENABLE_*.

        * jscore.bkl:

  WebKitTools:

        Reviewed by Adam Roben.

        Rename *_SUPPORT defines to ENABLE_*.

        * GdkLauncher/gdklauncher.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 27 Feb 2007 01:36:17 +0000 (01:36 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

        * fast/events/submit-reset-nested-bubble-expected.txt: Added.
        * fast/events/submit-reset-nested-bubble.html: Added.

WebCore:

        Reviewed by Maciej.

        Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

        Test: fast/events/submit-reset-nested-bubble.html

        * dom/EventTargetNode.h: Made handleLocalEvents virtual.
        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're
          not in the capture phase, and the target is a different form, and we're handling
          the submitEvent or the resetEvent, then stop propagation of the event.  This matches
          Firefox behavior.  You can only get in this situation if misnested tags cause
          forms to be nested.
        * html/HTMLFormElement.h: Added handleLocalEvents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
darin [Tue, 27 Feb 2007 01:32:54 +0000 (01:32 +0000)]
    Reviewed by Oliver Hunt.

        - <rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should

        * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter):
        Added a call to ucnv_setFallback(TRUE).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-26 Oliver Hunt <oliver@apple.com>
oliver [Tue, 27 Feb 2007 01:16:05 +0000 (01:16 +0000)]
2007-02-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for rdar://problem/5021127

        Need to add null check to node -- original Obj-C didn't need
        the null check due to the Obj-C null messaging semantics

        * editing/Editor.cpp:
        (WebCore::Editor::shouldInsertFragment):

Layout tests:
        Layout test for rdar://problem/5021127

        * fast/events/standalone-image-drag-to-editable-expected.checksum: Added.
        * fast/events/standalone-image-drag-to-editable-expected.png: Added.
        * fast/events/standalone-image-drag-to-editable-expected.txt: Added.
        * fast/events/standalone-image-drag-to-editable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin and Geoff
sullivan [Tue, 27 Feb 2007 00:33:57 +0000 (00:33 +0000)]
    Reviewed by Darin and Geoff

        * WebView/WebHTMLView.mm:
        (coreGraphicsScreenPointForAppKitScreenPoint):
        This method was copied from WebBrowser, and it was wrong. Fixed it. This only
        affects the Dictionary pop-up panel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make text files render using white-space: pre-wrap instead of white-space...
hyatt [Tue, 27 Feb 2007 00:09:20 +0000 (00:09 +0000)]
    Make text files render using white-space: pre-wrap instead of white-space: pre.

        Reviewed by aroben

        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate expected results for overflow test.
hyatt [Mon, 26 Feb 2007 23:24:36 +0000 (23:24 +0000)]
Update expected results for overflow test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Back out the change to add fullyClippedContentRect. The layout test
hyatt [Mon, 26 Feb 2007 23:22:37 +0000 (23:22 +0000)]
    Back out the change to add fullyClippedContentRect.  The layout test
        was actually showing more correct results.

        * page/Frame.cpp:
        (WebCore::Frame::visibleSelectionRect):
        (WebCore::Frame::setIsActive):
        (WebCore::Frame::markAllMatchesForText):
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Update web inspector to account for border-fit.
hyatt [Mon, 26 Feb 2007 22:55:04 +0000 (22:55 +0000)]
    Update web inspector to account for border-fit.

        Reviewed by darin

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Mon, 26 Feb 2007 22:43:06 +0000 (22:43 +0000)]
    Reviewed by Darin Adler.

        Re-arranged things to put deprecated methods at the bottom.

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        (+[WebCoreStatistics javaScriptRootObjectClasses]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Land layout test demonstrating border-fit.
hyatt [Mon, 26 Feb 2007 22:42:58 +0000 (22:42 +0000)]
    Land layout test demonstrating border-fit.

        Reviewed by darin

        * fast/borders/border-fit-expected.checksum: Added.
        * fast/borders/border-fit-expected.png: Added.
        * fast/borders/border-fit-expected.txt: Added.
        * fast/borders/border-fit.html: Added.
        * fast/borders/resources/Balloon_12641896.tiff: Added.
        * fast/borders/resources/Balloon_8107502.tiff: Added.
        * fast/borders/resources/largePerson.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add support for a new property called -webkit-border-fit. This property
hyatt [Mon, 26 Feb 2007 22:36:14 +0000 (22:36 +0000)]
    Add support for a new property called -webkit-border-fit.  This property
        has two values: border and lines.  The "border" value means the border and
        background paint normally at the border box level.  The "lines" value indicates
        that the border and background should shrink dynamically to snugly hug the
        line boxes of normal flow descendants.

        Reviewed by darin

        fast/borders/border-fit.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::adjustForBorderFit):
        (WebCore::RenderBlock::borderFitAdjust):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::borderFitAdjust):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::):
        (WebCore::RenderStyle::borderFit):
        (WebCore::RenderStyle::setBorderFit):
        (WebCore::RenderStyle::initialBorderFit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Mitz.
mjs [Mon, 26 Feb 2007 22:32:17 +0000 (22:32 +0000)]
    Rubber stamped by Mitz.

        - fix layout tests by fixing discrepancy in feature macros.

        * WebInspector/WebInspector.m:
        (-[WebInspector _highlightNode:]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
aroben [Mon, 26 Feb 2007 22:30:18 +0000 (22:30 +0000)]
    Reviewed by Darin.

        Build fix.

        * rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Mon, 26 Feb 2007 21:49:48 +0000 (21:49 +0000)]
LayoutTests:

        Reviewed by Adam.

        Test for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
        Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

        * fast/forms/select-out-of-bounds-index-expected.txt: Added.
        * fast/forms/select-out-of-bounds-index.html: Added.

WebCore:

        Reviewed by Adam.

        Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
        Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

        Test: fast/forms/select-out-of-bounds-index.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1.
        (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable.  Rewrote using a simpler for-loop to prevent out-of-bounds errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Mon, 26 Feb 2007 21:11:42 +0000 (21:11 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4816376>
        REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::reload):
        Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs [Mon, 26 Feb 2007 19:29:04 +0000 (19:29 +0000)]
JavaScriptCore:

        Reviewed by Lars.

        - <rdar://problem/5021698> Disable experimental SVG features (12883)

        * wtf/Platform.h: Add ENABLE() macro similar to HAVE() and USE(), to
        allow nicer handling of optional WebKit features.

WebCore:

        Reviewed by Lars.

        - fixed <rdar://problem/5021698> Disable experimental SVG features (12883)

        I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
        features, and used it to guard relevant tag names, elements, JS bindings and renderers.

        I also converted all the existing optional feature defines to
        ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
        way to do it in open source projects and works with the handy new
        ENABLE() macro.

        * CMakeLists.txt:
        * DerivedSources.make:
        * Projects/gdk/webcore-gdk.bkl:
        * WebCore.pro:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSCustomXPathNSResolver.h:
        * bindings/js/JSSVGElementWrapperFactory.cpp:
        * bindings/js/JSSVGElementWrapperFactory.h:
        * bindings/js/JSSVGMatrixCustom.cpp:
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/JSSVGPathSegCustom.cpp:
        * bindings/js/JSSVGPathSegListCustom.cpp:
        * bindings/js/JSSVGPointListCustom.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_binding.cpp:
        (KJS::setDOMException):
        * bindings/js/kjs_css.cpp:
        (KJS::toJS):
        * bindings/js/kjs_dom.cpp:
        (KJS::toJS):
        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap):
        (+[DOMNode _nodeWith:WebCore::]):
        * bindings/objc/DOMCSS.mm:
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMCustomXPathNSResolver.h:
        * bindings/objc/DOMCustomXPathNSResolver.mm:
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVGPathSegInternal.mm:
        * bindings/objc/DOMXPath.mm:
        * bindings/objc/ExceptionHandlers.mm:
        (WebCore::raiseDOMException):
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * config.h:
        * css/CSSGrammar.y:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::propertyID):
        * css/StyleBase.h:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::checkPseudoState):
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * css/cssstyleselector.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::hasFeature):
        (WebCore::DOMImplementation::createDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::createElement):
        (WebCore::Document::implicitClose):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::createEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Event.cpp:
        * dom/Event.h:
        * dom/EventTarget.cpp:
        * dom/EventTarget.h:
        * dom/MappedAttributeEntry.h:
        (WebCore::):
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        (WebCore::Node::shadowAncestorNode):
        * dom/Node.h:
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:
        * dom/Text.cpp:
        (WebCore::Text::createRenderer):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::XMLTokenizer::end):
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * dom/XMLTokenizer.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLObjectElement.h:
        * ksvg2/css/SVGCSSParser.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/css/SVGRenderStyle.cpp:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.cpp:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/events/JSSVGLazyEventListener.cpp:
        * ksvg2/events/JSSVGLazyEventListener.h:
        * ksvg2/events/SVGZoomEvent.cpp:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/misc/PointerEventsHitRules.cpp:
        * ksvg2/misc/PointerEventsHitRules.h:
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/misc/SVGImageLoader.h:
        * ksvg2/misc/SVGTimer.cpp:
        * ksvg2/misc/SVGTimer.h:
        * ksvg2/misc/TimeScheduler.cpp:
        * ksvg2/misc/TimeScheduler.h:
        * ksvg2/scripts/make_names.pl:
        * ksvg2/svg/ColorDistance.cpp:
        * ksvg2/svg/ColorDistance.h:
        * ksvg2/svg/GradientAttributes.h:
        * ksvg2/svg/LinearGradientAttributes.h:
        * ksvg2/svg/PatternAttributes.h:
        * ksvg2/svg/RadialGradientAttributes.h:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAngle.cpp:
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.cpp:
        * ksvg2/svg/SVGAnimateElement.h:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.cpp:
        * ksvg2/svg/SVGAnimatedPathData.h:
        * ksvg2/svg/SVGAnimatedPoints.cpp:
        * ksvg2/svg/SVGAnimatedPoints.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGColor.cpp:
        * ksvg2/svg/SVGColor.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDefsElement.cpp:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGDescElement.cpp:
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::dispatchEvent):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstance.cpp:
        * ksvg2/svg/SVGElementInstance.h:
        * ksvg2/svg/SVGElementInstance.idl:
        * ksvg2/svg/SVGElementInstanceList.cpp:
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGElementInstanceList.idl:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGException.h:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEBlendElement.idl:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.idl:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.idl:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFECompositeElement.idl:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.idl:
        * ksvg2/svg/SVGFEDistantLightElement.cpp:
        * ksvg2/svg/SVGFEDistantLightElement.h:
        * ksvg2/svg/SVGFEDistantLightElement.idl:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEFloodElement.idl:
        * ksvg2/svg/SVGFEFuncAElement.cpp:
        * ksvg2/svg/SVGFEFuncAElement.h:
        * ksvg2/svg/SVGFEFuncAElement.idl:
        * ksvg2/svg/SVGFEFuncBElement.cpp:
        * ksvg2/svg/SVGFEFuncBElement.h:
        * ksvg2/svg/SVGFEFuncBElement.idl:
        * ksvg2/svg/SVGFEFuncGElement.cpp:
        * ksvg2/svg/SVGFEFuncGElement.h:
        * ksvg2/svg/SVGFEFuncGElement.idl:
        * ksvg2/svg/SVGFEFuncRElement.cpp:
        * ksvg2/svg/SVGFEFuncRElement.h:
        * ksvg2/svg/SVGFEFuncRElement.idl:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.idl:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFEImageElement.idl:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.h:
        * ksvg2/svg/SVGFEMergeElement.idl:
        * ksvg2/svg/SVGFEMergeNodeElement.cpp:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.idl:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFEOffsetElement.idl:
        * ksvg2/svg/SVGFEPointLightElement.cpp:
        * ksvg2/svg/SVGFEPointLightElement.h:
        * ksvg2/svg/SVGFEPointLightElement.idl:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.idl:
        * ksvg2/svg/SVGFESpotLightElement.cpp:
        * ksvg2/svg/SVGFESpotLightElement.h:
        * ksvg2/svg/SVGFESpotLightElement.idl:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETileElement.idl:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.idl:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterElement.idl:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.cpp:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGForeignObjectElement.idl:
        * ksvg2/svg/SVGGElement.cpp:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLangSpace.h:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.cpp:
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGListTraits.h:
        * ksvg2/svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::nearestViewportElement):
        (WebCore::SVGLocatable::farthestViewportElement):
        * ksvg2/svg/SVGLocatable.h:
        * ksvg2/svg/SVGMPathElement.cpp:
        * ksvg2/svg/SVGMPathElement.h:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMetadataElement.cpp:
        * ksvg2/svg/SVGMetadataElement.h:
        * ksvg2/svg/SVGNumberList.cpp:
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPaint.cpp:
        * ksvg2/svg/SVGPaint.h:
        * ksvg2/svg/SVGParserUtilities.cpp:
        * ksvg2/svg/SVGParserUtilities.h:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSeg.h:
        * ksvg2/svg/SVGPathSegArc.cpp:
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegClosePath.cpp:
        * ksvg2/svg/SVGPathSegClosePath.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.cpp:
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegList.cpp:
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPathSegMoveto.cpp:
        * ksvg2/svg/SVGPathSegMoveto.h:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPointList.cpp:
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.cpp:
        * ksvg2/svg/SVGPolygonElement.h:
        * ksvg2/svg/SVGPolylineElement.cpp:
        * ksvg2/svg/SVGPolylineElement.h:
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGRenderingIntent.h:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.cpp:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        * ksvg2/svg/SVGSetElement.h:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.cpp:
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStylable.cpp:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyleElement.h:
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::notifyAttributeChange):
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.h:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.cpp:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.cpp:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.cpp:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.cpp:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTests.h:
        * ksvg2/svg/SVGTextContentElement.cpp:
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.cpp:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTitleElement.cpp:
        * ksvg2/svg/SVGTitleElement.h:
        * ksvg2/svg/SVGTransform.cpp:
        * ksvg2/svg/SVGTransform.h:
        * ksvg2/svg/SVGTransformDistance.cpp:
        * ksvg2/svg/SVGTransformDistance.h:
        * ksvg2/svg/SVGTransformList.cpp:
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGURIReference.cpp:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUnitTypes.h:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGUseElement.idl:
        * ksvg2/svg/SVGViewElement.cpp:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        * ksvg2/svg/SVGZoomAndPan.h:
        * ksvg2/svg/svgtags.in:
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * page/DOMWindow.idl:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::selectCursor):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * page/PageState.cpp:
        (WebCore::PageState::PageState):
        (WebCore::PageState::restore):
        * platform/MimeTypeRegistry.cpp:
        (WebCore::initialiseSupportedNonImageMimeTypes):
        * platform/graphics/FloatPoint3D.cpp:
        * platform/graphics/FloatPoint3D.h:
        * platform/graphics/ImageBuffer.cpp:
        (WebCore::ImageBuffer::renderSubtreeToImage):
        * platform/graphics/svg/SVGImage.cpp:
        * platform/graphics/svg/SVGImage.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * platform/graphics/svg/SVGPaintServer.cpp:
        * platform/graphics/svg/SVGPaintServer.h:
        * platform/graphics/svg/SVGPaintServerGradient.cpp:
        * platform/graphics/svg/SVGPaintServerGradient.h:
        * platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
        * platform/graphics/svg/SVGPaintServerLinearGradient.h:
        * platform/graphics/svg/SVGPaintServerPattern.cpp:
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
        * platform/graphics/svg/SVGPaintServerRadialGradient.h:
        * platform/graphics/svg/SVGPaintServerSolid.cpp:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/SVGResource.cpp:
        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/SVGResourceClipper.cpp:
        * platform/graphics/svg/SVGResourceClipper.h:
        * platform/graphics/svg/SVGResourceFilter.cpp:
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/SVGResourceMarker.cpp:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.cpp:
        * platform/graphics/svg/SVGResourceMasker.h:
        * platform/graphics/svg/cg/CgSupport.cpp:
        * platform/graphics/svg/cg/CgSupport.h:
        * platform/graphics/svg/cg/RenderPathCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
        * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
        * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
        * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
        * platform/graphics/svg/filters/SVGDistantLightSource.h:
        * platform/graphics/svg/filters/SVGFEBlend.cpp:
        * platform/graphics/svg/filters/SVGFEBlend.h:
        * platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
        * platform/graphics/svg/filters/SVGFEColorMatrix.h:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
        * platform/graphics/svg/filters/SVGFEComposite.cpp:
        * platform/graphics/svg/filters/SVGFEComposite.h:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
        * platform/graphics/svg/filters/SVGFEFlood.cpp:
        * platform/graphics/svg/filters/SVGFEFlood.h:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
        * platform/graphics/svg/filters/SVGFEImage.cpp:
        * platform/graphics/svg/filters/SVGFEImage.h:
        * platform/graphics/svg/filters/SVGFEMerge.cpp:
        * platform/graphics/svg/filters/SVGFEMerge.h:
        * platform/graphics/svg/filters/SVGFEMorphology.cpp:
        * platform/graphics/svg/filters/SVGFEMorphology.h:
        * platform/graphics/svg/filters/SVGFEOffset.cpp:
        * platform/graphics/svg/filters/SVGFEOffset.h:
        * platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
        * platform/graphics/svg/filters/SVGFESpecularLighting.h:
        * platform/graphics/svg/filters/SVGFETile.h:
        * platform/graphics/svg/filters/SVGFETurbulence.cpp:
        * platform/graphics/svg/filters/SVGFETurbulence.h:
        * platform/graphics/svg/filters/SVGFilterEffect.cpp:
        * platform/graphics/svg/filters/SVGFilterEffect.h:
        * platform/graphics/svg/filters/SVGLightSource.cpp:
        * platform/graphics/svg/filters/SVGLightSource.h:
        * platform/graphics/svg/filters/SVGPointLightSource.h:
        * platform/graphics/svg/filters/SVGSpotLightSource.h:
        * platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
        * platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
        * platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
        * platform/graphics/svg/filters/cg/SVGFETileCg.mm:
        * platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
        * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
        * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
        * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
        * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteImageURL):
        (WebCore::HitTestResult::absoluteLinkURL):
        (WebCore::HitTestResult::isLiveLink):
        * rendering/RenderForeignObject.cpp:
        * rendering/RenderForeignObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isTransparent):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        * rendering/RenderSVGBlock.cpp:
        * rendering/RenderSVGBlock.h:
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGGradientStop.cpp:
        * rendering/RenderSVGGradientStop.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.cpp:
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGInlineText.cpp:
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGTSpan.cpp:
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.cpp:
        * rendering/RenderSVGText.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::inheritFrom):
        (WebCore::RenderStyle::operator==):
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setStyle):
        (WebCore::RenderText::setTextInternal):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::externalRepresentation):
        * rendering/SVGInlineFlowBox.cpp:
        * rendering/SVGInlineFlowBox.h:
        * rendering/SVGRenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.h:
        * rendering/SVGRootInlineBox.cpp:
        * rendering/SVGRootInlineBox.h:
        * rendering/bidi.cpp:
        (WebCore::shouldPreserveNewline):
        (WebCore::RenderBlock::findNextLineBreak):
        * webcore-base.bkl:
        * xml/NativeXPathNSResolver.cpp:
        * xml/NativeXPathNSResolver.h:
        * xml/XPathEvaluator.cpp:
        * xml/XPathEvaluator.h:
        * xml/XPathExpression.cpp:
        * xml/XPathExpression.h:
        * xml/XPathExpressionNode.cpp:
        * xml/XPathExpressionNode.h:
        * xml/XPathFunctions.cpp:
        * xml/XPathFunctions.h:
        * xml/XPathGrammar.y:
        * xml/XPathNSResolver.cpp:
        * xml/XPathNSResolver.h:
        * xml/XPathNamespace.cpp:
        * xml/XPathNamespace.h:
        * xml/XPathParser.cpp:
        * xml/XPathParser.h:
        * xml/XPathPath.cpp:
        * xml/XPathPath.h:
        * xml/XPathPredicate.cpp:
        * xml/XPathPredicate.h:
        * xml/XPathResult.cpp:
        * xml/XPathResult.h:
        * xml/XPathStep.cpp:
        * xml/XPathStep.h:
        * xml/XPathUtil.cpp:
        * xml/XPathUtil.h:
        * xml/XPathValue.cpp:
        * xml/XPathValue.h:
        * xml/XPathVariableReference.cpp:
        * xml/XPathVariableReference.h:
        * xml/XSLImportRule.cpp:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.cpp:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-25 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 26 Feb 2007 05:31:03 +0000 (05:31 +0000)]
2007-02-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by David Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12886
          Crash with Scriptalicious javascript library

        Test: fast/dynamic/float-withdrawal.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had
        intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by David Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12886
          Crash with Scriptalicious javascript library

        * fast/dynamic/float-withdrawal-expected.checksum: Added.
        * fast/dynamic/float-withdrawal-expected.png: Added.
        * fast/dynamic/float-withdrawal-expected.txt: Added.
        * fast/dynamic/float-withdrawal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Revert my change to the default fill color. Just set the color to transparen...
hyatt [Mon, 26 Feb 2007 03:00:24 +0000 (03:00 +0000)]
    Revert my change to the default fill color.  Just set the color to transparent explicitly when
        drawing textarea resizer frames.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintOverflowControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Update forgotten files.
weinig [Mon, 26 Feb 2007 02:28:16 +0000 (02:28 +0000)]
    Update forgotten files.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to land FrameView.cpp in previous commit.
hyatt [Mon, 26 Feb 2007 02:07:56 +0000 (02:07 +0000)]
Forgot to land FrameView.cpp in previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for regression caused by changing the containing block of positioned...
hyatt [Mon, 26 Feb 2007 01:29:46 +0000 (01:29 +0000)]
    Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
        to be the initial containing block (represented in our tree by the RenderView).  Rework RenderView's layout
        to have very few special cases.   Now it will just relayout its children when the width/height of the
        view actually changes.  Positioned elements no longer get a special additional layout, since width/height
        adjustments are caught by the base class already anyway.

        Reviewed by mjs, darin

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::layout):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, build fix.
mjs [Mon, 26 Feb 2007 00:41:21 +0000 (00:41 +0000)]
    Not reviewed, build fix.

        - fix build breakage

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::fullyClippedContentRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::fullyClippedContentRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
mjs [Sun, 25 Feb 2007 23:44:04 +0000 (23:44 +0000)]
    Reviewed by Adam.

        - fixed layout test failure in fast/overflow/scrollRevealButton

        I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
        as clipped by all ancestor scroll views, not just this one. Currently it only works
        correctly on mac however. visibleContentRect, only accounting for the clipping from
        this particular scroll view, is sufficient for most purposes.

        * page/Frame.cpp:
        (WebCore::Frame::visibleSelectionRect):
        (WebCore::Frame::setIsActive):
        (WebCore::Frame::markAllMatchesForText):
        * platform/ScrollView.h:
        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrolView::fullyClippedContentRect):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::fullyClippedContentRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrolView::fullyClippedContentRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
andersca [Sun, 25 Feb 2007 22:23:11 +0000 (22:23 +0000)]
    Reviewed by Maciej.

        * building/checkout.html:
        Add Trac link to our SVN repository,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Steve.
aroben [Sun, 25 Feb 2007 07:12:37 +0000 (07:12 +0000)]
    Reviewed by Steve.

        "Look Up in Dictionary" context menu item should be Mac-only for now,
        since it's only implemented on that platform (<rdar://problem/5021468>)

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate): Wrap all instances of the dictionary
        menu item in #if PLATFORM(MAC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Sun, 25 Feb 2007 02:14:54 +0000 (02:14 +0000)]
LayoutTests:

        Reviewed by Darin Adler.

        Layout tests for BidiRun leaks.

        * fast/leaks/001-expected.txt: Added.
        * fast/leaks/001.html: Added.
        * fast/leaks/002-expected.txt: Added.
        * fast/leaks/002.html: Added.

WebCore:

        Reviewed by Darin Adler.

        Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
        running WebKit unit tests

        In bidi.cpp, some functions allocate BidiRuns and put them in a global data
        structure, while others uses the BidiRuns in the global data structure.
        The caller is responsible for knowing which functions may allocate runs
        and which may use them, and calling deleteBidiRuns() at the appropriate time.

        The fix is to add some calls to deleteBidiRuns() where they were missing.

        I also added a BidiRun counter because these two leaks were introduced by
        our two bidi.cpp experts, so the odds that leaks will creep in again
        in the future seem pretty high.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::bidiReorderCharacters): Added  missing call to
        deleteBidiRuns().
        (WebCore::BidiRunCounter::~BidiRunCounter):
        (WebCore::BidiRun::operator delete):
        (WebCore::RenderBlock::layoutInlineChildren): Added missing call to
        deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to
        bidiReorderLine(), to emphasize that they go together like new/delete.
        In theory, the old code was just as good, but I didn't want to rely on
        theory.

WebKitTools:

        Reviewed by Darin Adler.

        * Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're
        fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin.
harrison [Sat, 24 Feb 2007 14:35:12 +0000 (14:35 +0000)]
    Reviewed by Kevin.

        <rdar://problem/4961431> Image with empty string alt tag should be ignored

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):
        Ignore img element that has an alt attribute, but that string is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdjust the animation a little bit to make it more natural.
zack [Sat, 24 Feb 2007 13:14:01 +0000 (13:14 +0000)]
Adjust the animation a little bit to make it more natural.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ap [Sat, 24 Feb 2007 11:14:29 +0000 (11:14 +0000)]
    Reviewed by Anders.

        Fix the test not to include any custom content in its auto-generated HTML wrapper.

        * fast/js/resources/select-options-add.js:
        * fast/js/select-options-add-expected.txt:
        * fast/js/select-options-add.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago WebCore:
kjk [Sat, 24 Feb 2007 08:45:04 +0000 (08:45 +0000)]
  WebCore:

        Reviewed by Adam Roben.

        Gdk improvements.

        * platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup.
        (WebCore::FrameGdk::keyPress):
        (WebCore::FrameGdk::handleGdkEvent):
        (WebCore::Frame::print):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::respondToChangedSelection):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        (WebCore::Frame::dragImageForSelection):
        * platform/network/gdk/ResourceHandleManager.cpp: don't free memory that
        doesn't belong to us.
        (WebCore::ResourceHandleManager::downloadTimerCallback):

  WebKitTools:

        Reviewed by Adam Roben.

        Improve gdklauncher: add text field for entering url.

        * GdkLauncher/gdklauncher.bkl:
        * GdkLauncher/main.cpp:
        (strEmpty):
        (strEq):
        (handleGdkEvent):
        (goToUrlBarText):
        (goButtonClickedCb):
        (urlBarEnterCb):
        (registerRenderingAreaEvents):
        (frameResizeCb):
        (frameDestroyCb):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
kdecker [Sat, 24 Feb 2007 07:42:07 +0000 (07:42 +0000)]
    Reviewed by Anders.

        Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)

        There were two problems here:

        * page/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said  "if there is no text encoding name than
         assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback
         case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
        * platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Sat, 24 Feb 2007 02:55:24 +0000 (02:55 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - updated test result for http://bugs.webkit.org/show_bug.cgi?id=12856
          REGRESSION (r13685): Canceling the suggestion popup does not revert the change

        * editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12856
          REGRESSION (r13685): Canceling the suggestion popup does not revert the change

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted
        is empty, first delete the selection, and only then bail out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Sat, 24 Feb 2007 02:52:23 +0000 (02:52 +0000)]
    Reviewed by Adam.

        <rdar://problem/5001923>
        REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

        Fix an error that was introduced in revision r18541. We should check if the provisional document loader
        has an unreachable URL, not the actual document loader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Sat, 24 Feb 2007 02:35:13 +0000 (02:35 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12823
          REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

        * fast/events/selectstart-during-autoscroll-expected.txt: Added.
        * fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12823
          REGRESSION(r16968-16977): unable to prevent selection by cancelling "selectstart" event

        Test: fast/events/selectstart-during-autoscroll.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() --
        which dispatches the selection DOM event and gives it a chance to cancel
        the selection -- before updating the selection during autoscroll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
weinig [Sat, 24 Feb 2007 02:22:55 +0000 (02:22 +0000)]
    Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11573
          REGRESSION: pressing option-left arrow while in suggestion popup moves the insertion point to the left

        * WebView/WebHTMLView.mm:
        (-[WebTextCompleteController endRevertingChange:moveLeft:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCorrecting ChangeLog
oliver [Sat, 24 Feb 2007 01:25:43 +0000 (01:25 +0000)]
Correcting ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-23 Oliver Hunt <oliver@apple.com>
oliver [Sat, 24 Feb 2007 01:22:30 +0000 (01:22 +0000)]
2007-02-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12870

        It turns out short circuiting DragData::containsURL() was bad

        * ChangeLog:
        * WebCore.xcodeproj/project.pbxproj:
        * manual-tests/directory-drop-on-view.html: Added.
        * platform/mac/DragDataMac.mm:
        (WebCore::DragData::containsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
thatcher [Fri, 23 Feb 2007 19:13:48 +0000 (19:13 +0000)]
    Reviewed by Brady.

        <rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

        * WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
        * WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
        * WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdded missing bug numbers.
mjs [Fri, 23 Feb 2007 16:43:30 +0000 (16:43 +0000)]
Added missing bug numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
mjs [Fri, 23 Feb 2007 16:32:35 +0000 (16:32 +0000)]
    Reviewed by Mitz.

        - 12.5% speedup on BenchJS test 6

        It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
        and calling visibleRect even more so. Take measures to call them less often.

        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible.
        (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use
        documentVisibleRect when possible.
        * rendering/RenderView.cpp:
        (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect
        if we don't have a parent frame, since the ScrollView will do that anyway. Also,
        don't get contentX and contentY separately since they are in the viewRect already.
        (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each
        coordinate individually, to avoid calling documentVisibleRect repeatedly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
mjs [Fri, 23 Feb 2007 16:25:43 +0000 (16:25 +0000)]
    Reviewed by Mitz.

        - 2% speedup on BenchJS test 6

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText): Use format() instead of
        number() followed by append of a constant string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoadd return values (!!)
staikos [Fri, 23 Feb 2007 15:34:01 +0000 (15:34 +0000)]
add return values (!!)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build.
staikos [Fri, 23 Feb 2007 15:26:56 +0000 (15:26 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding a little bit of eye-candy to the last
zack [Fri, 23 Feb 2007 15:08:00 +0000 (15:08 +0000)]
Adding a little bit of eye-candy to the last
commit (animations on hover events)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding API and code for notification of when the
zack [Fri, 23 Feb 2007 14:21:53 +0000 (14:21 +0000)]
Adding API and code for notification of when the
mouse is hovering over a link and adding code to
the sample app to showcase it.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben, who never sleeps.
kjk [Fri, 23 Feb 2007 06:48:54 +0000 (06:48 +0000)]
    Reviewed by Adam Roben, who never sleeps.

        To avoid code duplication, move notImplementedGdk() macro to a separate
        header file. Remove existing notImplementedGdk() macros and replace
        remaining notImplemented() to notImplementedGdk() in gdk code.

        * loader/gdk/DocumentLoaderGdk.cpp:
        (WebCore::DocumentLoader::getResponseModifiedHeader):
        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::hasWebView):
        (WebCore::FrameLoaderClientGdk::hasFrameView):
        * page/gdk/ContextMenuClientGdk.cpp:
        (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
        (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
        (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
        (WebCore::ContextMenuClientGdk::downloadURL):
        (WebCore::ContextMenuClientGdk::copyImageToClipboard):
        (WebCore::ContextMenuClientGdk::searchWithGoogle):
        (WebCore::ContextMenuClientGdk::lookUpInDictionary):
        (WebCore::ContextMenuClientGdk::speak):
        (WebCore::ContextMenuClientGdk::stopSpeaking):
        * page/gdk/EventHandlerGdk.cpp:
        * platform/gdk/CursorGdk.cpp:
        (WebCore::Cursor::Cursor):
        * platform/gdk/EditorClientGdk.cpp:
        * platform/gdk/NotImplementedGdk.h: Added.
        * platform/gdk/PopupMenuGdk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::updateFromElement):
        * platform/gdk/RenderThemeGdk.cpp:
        * platform/gdk/ScreenGdk.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/graphics/gdk/ImageGdk.cpp:
        (WebCore::Image::drawPattern):
        * platform/network/gdk/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::setDefersLoading):
        * platform/network/gdk/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::setupPUT):
        (WebCore::ResourceHandleManager::setupPOST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Fri, 23 Feb 2007 04:32:06 +0000 (04:32 +0000)]
    Reviewed by Tim H.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=12852
        Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up
        * Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Fri, 23 Feb 2007 03:48:56 +0000 (03:48 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - Test for http://bugs.webkit.org/show_bug.cgi?id=12850
          Leaks >10k objects

        * fast/events/remove-event-listener-expected.txt: Added.
        * fast/events/remove-event-listener.html: Added.

WebCore:

        Reviewed by Maciej.

        - Patch for http://bugs.webkit.org/show_bug.cgi?id=12850
          Leaks >10k objects

        and

        - http://bugs.webkit.org/show_bug.cgi?id=12853
          add a EventListener leak counter

        Problem: RemoveEventListener leaks memory if the listener is not
        registered.
        Fix: Added Window::findJSEventListener function w/o creating a
        JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;

        As an enhancement, added a leak counter for EventListeners.

        Added a test case, LayoutTests/fast/events/remove-event-listener.html.

        * WebCore/bindings/js/kjs_dom.cpp:
        * WebCore/bindings/js/kjs_window.h:
        * WebCore/bindings/js/kjs_window.cpp:
        * WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
        * WebCore/bindings/js/JSXMLHttpRequest.cpp:
        * LayoutTests/fast/events/remove-event-listener.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Fri, 23 Feb 2007 03:38:00 +0000 (03:38 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4998203>
        REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before
        calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.

        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        Check if the unreachable URL is equal to the document loader's request.

        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        Check the provisional document loader's unreachable URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
bdash [Fri, 23 Feb 2007 01:13:19 +0000 (01:13 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Fri, 23 Feb 2007 00:03:23 +0000 (00:03 +0000)]
    Reviewed by John.

        Updating this image to match the one in WebCore.

        * WebKit.vcproj/textAreaResizeCorner.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 22 Feb 2007 23:51:47 +0000 (23:51 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5007143>
        REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

        Added, tests the removal of the use of the
        recalc bool from xPosForVerticalArrowNavigation(...):
        * editing/selection/5007143-2-expected.checksum: Added.
        * editing/selection/5007143-2-expected.png: Added.
        * editing/selection/5007143-2-expected.txt: Added.
        * editing/selection/5007143-2.html: Added.
        Added, demonstrate the changes to modify:
        * editing/selection/5007143-expected.checksum: Added.
        * editing/selection/5007143-expected.png: Added.
        * editing/selection/5007143-expected.txt: Added.
        * editing/selection/5007143.html: Added.
        Demonstrates a bug (filed 5017312):
        * editing/style/block-style-004-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/block-style-006-expected.txt:
        Fixed:
        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/style/create-block-for-style-009-expected.checksum:
        * editing/style/create-block-for-style-009-expected.png:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-011-expected.checksum:
        * editing/style/create-block-for-style-011-expected.png:
        * editing/style/create-block-for-style-011-expected.txt:

WebCore:

        Reviewed by darin

        <rdar://problem/5007143>
        REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController): Initialize
        m_xPosForVerticalArrowNavigation.
        (WebCore::SelectionController::setSelection): Call the new setter.
        (WebCore::SelectionController::modifyMovingRightForward): For line
        and paragraph granularities, use the saved xPosForVerticalArrowNavigation
        even if the old selection was a range. Use the x position of the
        *start*, not the end of the selection if there is no saved
        xPosForVerticalArrowNavigation.  This matches TextEdit's behavior.
        (WebCore::SelectionController::modifyMovingLeftBackward): For line
        and paragraph granularities, use the saved xPosForVerticalArrowNavigation
        even if the old selection was a range.
        (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation
        for line and paragraph granularities.
        (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed
        the recalc bool because it is now always false.
        (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
        * editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation
        from Frame.
        * page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
        * page/Frame.h: Ditto.
        * page/FramePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Thu, 22 Feb 2007 23:49:13 +0000 (23:49 +0000)]
WebCore:
        Reviewed by Adam. Manual test added.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
        Unable to prevent default context menu from appearing. <rdar://
        problem/5017416>

        This problem appeared because of two facets of the current context
        menu design. First, all context menu events are now considered to
        be "swallowed" since we take care of building up the regular
        context menu through the defaultEventHandler(). Second, the context
        menu controller holds onto it's context menu until a new one is
        created. There would be logistical problems changing this since
        AppKit relies on the menu being around for as long as it is
        visible on the screen and we don't get any notification once the
        menu is popped-down.

        This patch fixes the problem by giving WebKit a way to clear the
        controller's context menu. WebKit now clears the menu before it
        propagates a new context menu event through the DOM.

        * WebCore.exp:
        * manual-tests/DOMContextMenuEvent.html: Added.
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::clearContextMenu):
        * page/ContextMenuController.h:

WebKit:
        Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
        Unable to prevent default context menu from appearing. <rdar://
        problem/5017416>

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView menuForEvent:]): Clear the controller's context menu
        before propagating a new context menu event through the DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin and Adele
sullivan [Thu, 22 Feb 2007 23:42:30 +0000 (23:42 +0000)]
    Reviewed by Kevin and Adele

        - fixed <rdar://problem/4129417> Need final art for textarea's resize corner

        This probably broke some layout pixel tests since the image changed. I'm going to
        track those down in a moment (non-trivial since there are a bunch failing for other
        reasons).

        * Resources/textAreaResizeCorner.tiff:
        new art

        * Resources/deleteButton.tiff:
        * Resources/deleteButtonPressed.tiff:
        these got smaller when I ran compress-tiffs on this directory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-02-22 Oliver Hunt <oliver@apple.com>
oliver [Thu, 22 Feb 2007 23:40:30 +0000 (23:40 +0000)]
2007-02-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Ada, Lou and Steve.

        Moving basic components of ClipboardMac to Clipboard,
        last of the basic common code merge will come later (namely setting the
        drag element/image).

        Tidying up in DragController including a few bad PassRefPtr uses and
        removing unnecessary accessors.  Also initialise fields properly to
        fix <rdar:/problems/5014889>

        * dom/Clipboard.cpp:
        (WebCore::Clipboard::Clipboard):
          New constructor

        * dom/Clipboard.h:
        (WebCore::Clipboard::isForDragging):
        (WebCore::Clipboard::dragLocation):
        (WebCore::Clipboard::dragImage):
        (WebCore::Clipboard::dragImageElement):
          Exposing common data

        * page/DragController.cpp:
        (WebCore::DragController::DragController):
          Initialise m_isHandlingDrag (oops)
        (WebCore::documentFragmentFromDragData):
        (WebCore::DragController::tryDocumentDrag):
          Fixing PassRefPtr misuse
        (WebCore::DragController::canProcessDrag):
        (WebCore::DragController::startDrag):
        (WebCore::DragController::doSystemDrag):
          Make sure we're using the correct coordinate space

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag):
          Reset drag source correctly

        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::ClipboardMac):
          update constructor to use new Clipboard constructor

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Thu, 22 Feb 2007 22:20:24 +0000 (22:20 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        * fast/events/keypress-insert-tab-expected.txt: Added.
        * fast/events/keypress-insert-tab.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        Test: fast/events/keypress-insert-tab.html

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
          If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

        Reviewed by Darin.

        Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
        can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setTabKeyCyclesThroughElements:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Thu, 22 Feb 2007 22:10:38 +0000 (22:10 +0000)]
    Reviewed by Darin Adler.

        Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
        volumes..."

        The problem was that JavaScriptGlue held a JSObject in a static pointer
        without protecting it from garbage collection.

            sUserObjectPrototypeImp  = new UserObjectPrototypeImp();
            static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; // valiant, brave, but useless

        Through an interesting comedy of errors, this object would be collected
        and then assigned as the prototype of another object allocated at the
        same address, thus becoming its own prototype. (See http://www.ziplo.com/grandpa.htm
        for further explanation of this phenomenon.) Hence the infinte loop in
        property lookup.

        The solution is equally humorous: all of this code was completely useless --
        it only served to create an empty object in the prototype chain -- so
        I just removed it.

        * UserObjectImp.cpp:
        (UserObjectImp::UserObjectImp):
        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Thu, 22 Feb 2007 21:00:58 +0000 (21:00 +0000)]
    Reviewed by Darin.

        <rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

        * bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
        * bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
        * dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
        * html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
        * html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
        * html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
adele [Thu, 22 Feb 2007 20:50:13 +0000 (20:50 +0000)]
    Reviewed by John.

        Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

        * platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 22 Feb 2007 20:19:26 +0000 (20:19 +0000)]
LayoutTests:

        Used svn merge -r19786:19785 to roll out previous SVG results produced by
        hack to work around SVG painting issue in DRT.

        The new work-around preserves the old SVG results -- both text and pixel.
        This should fix the ~400 new pixel failures introduced in r19786.

        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/carto.net/button-expected.txt:
        * svg/carto.net/colourpicker-expected.txt:
        * svg/carto.net/combobox-expected.txt:
        * svg/carto.net/scrollbar-expected.txt:
        * svg/carto.net/selectionlist-expected.txt:
        * svg/carto.net/slider-expected.txt:
        * svg/carto.net/tabgroup-expected.txt:
        * svg/carto.net/textbox-expected.txt:
        * svg/carto.net/window-expected.txt:
        * svg/custom/gradient-stop-style-change-expected.txt:
        * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * svg/custom/js-late-clipPath-creation-expected.txt:
        * svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/pointer-events-text-expected.txt:
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/text-repaint-including-stroke-expected.txt:
        * svg/custom/use-elementInstance-event-target-expected.txt:
        * svg/custom/use-on-text-expected.txt:

WebKitTools:

        Used svn merge -r19786:19785 to roll out previous hack to work around
        SVG painting issue in DRT.

        Implemented new work-around, which makes --paint paint *after* dumping
        the render tree instead of before, so that painting doesn't influence
        the SVG render tree.

        This should fix the ~400 new pixel failures introduced in r19786.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Thu, 22 Feb 2007 19:57:49 +0000 (19:57 +0000)]
LayoutTests:

        Reviewed by Darin.

        - tests for http://bugs.webkit.org/show_bug.cgi?id=11447
        REGRESSION(NativeListBox): List not scrolled to preselected option
        <rdar://problem/4957463>

        * fast/forms/select-initial-position-expected.checksum: Added.
        * fast/forms/select-initial-position-expected.png: Added.
        * fast/forms/select-initial-position-expected.txt: Added.
        * fast/forms/select-initial-position.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11447
        REGRESSION(NativeListBox): List not scrolled to preselected option
        <rdar://problem/4957463>

        Initiate scroll when selected <option> is added to <select>.

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::insertedIntoDocument):
        * html/HTMLOptionElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::updateListBoxSelection):
        (WebCore::HTMLSelectElement::scrollToSelection):
        * html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix sites with fixed positioned backgrounds. (my blog =) )
zack [Thu, 22 Feb 2007 19:32:33 +0000 (19:32 +0000)]
Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Resetting --leaks mode default to run 1000 tests at a time because setting it
ggaren [Thu, 22 Feb 2007 19:18:46 +0000 (19:18 +0000)]
    Resetting --leaks mode default to run 1000 tests at a time because setting it
        to 750 didn't stop the stack logging related crashes, and running more tests
        at a time is faster. The crashes seem to be a real bug in stack logging,
        not an out of memory condition.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Thu, 22 Feb 2007 17:38:57 +0000 (17:38 +0000)]
    Reviewed by Darin

        Removed some unused keyView-related code that I happened to run across.
        Replacement code is now in WebChromeClient.

        * WebCoreSupport/WebFrameBridge.h:
        * WebCoreSupport/WebFrameBridge.mm:
        removed unused stuff

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing the default scroll offset, cleaning
zack [Thu, 22 Feb 2007 16:52:15 +0000 (16:52 +0000)]
Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoProperly implement canvas/scrollview's. Get
zack [Thu, 22 Feb 2007 16:17:41 +0000 (16:17 +0000)]
Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
weinig [Thu, 22 Feb 2007 15:59:10 +0000 (15:59 +0000)]
    Reviewed by Maciej.

        Fix ARM-specific alignment problem in FastMalloc
        http://bugs.webkit.org/show_bug.cgi?id=12841

        * wtf/FastMalloc.cpp:
        Modify how pageheap_memory is declared to ensure proper alignment
        on architectures such as ARM

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
weinig [Thu, 22 Feb 2007 15:45:40 +0000 (15:45 +0000)]
    Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12804
          REGRESSION (r19043-r19063): suggestion popup doesn't work after pressing Option+Esc

        This patch also fixes a bug where using the arrow keys while
        the suggestion popup is open moves the caret instead of changing the
        selection in the popup (for up/down) or accepting the selection and
        closing the popup (for left/right).

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open
        before the current event, so that the Option-Esc that opens the popup will
        not close it immediately.
        (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a
        chance to intercept keydown events.
        (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the
        suggestion popup is open.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark (age 21).
weinig [Thu, 22 Feb 2007 15:34:00 +0000 (15:34 +0000)]
    Reviewed by Mark (age 21).

        - fix http://bugs.webkit.org/show_bug.cgi?id=12805
          REGRESSION: suggestion popup has a disabled scroll bar

        * WebView/WebHTMLView.mm:
        (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow
        SPI that forces the scroll bar to look active. Also replaced a call to
        the deprecated NSTableView method setAutoresizesAllColumnsToFit: with
        the new method setColumnAutoresizingStyle: to eliminate console spew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
kjk [Thu, 22 Feb 2007 07:20:31 +0000 (07:20 +0000)]
    Reviewed by Adam Roben.

        Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
        give it a unique name (so that it doesn't clash with notImplemented()
        for other platforms).
        Make it print a given warning only once, so that frequently called
        functions don't clutter the output.
        Don't print the warning if DISABLE_NI_WARNING env variable is set.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
        (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientGdk::createPlugin):
        (WebCore::FrameLoaderClientGdk::createFrame):
        (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
        (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
        (WebCore::FrameLoaderClientGdk::objectContentType):
        (WebCore::FrameLoaderClientGdk::overrideMediaType):
        (WebCore::FrameLoaderClientGdk::windowObjectCleared):
        (WebCore::FrameLoaderClientGdk::hasWebView):
        (WebCore::FrameLoaderClientGdk::hasFrameView):
        (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
        (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
        (WebCore::FrameLoaderClientGdk::restoreViewState):
        (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
        (WebCore::FrameLoaderClientGdk::makeDocumentView):
        (WebCore::FrameLoaderClientGdk::makeRepresentation):
        (WebCore::FrameLoaderClientGdk::forceLayout):
        (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
        (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
        (WebCore::FrameLoaderClientGdk::detachedFromParent1):
        (WebCore::FrameLoaderClientGdk::detachedFromParent2):
        (WebCore::FrameLoaderClientGdk::detachedFromParent3):
        (WebCore::FrameLoaderClientGdk::detachedFromParent4):
        (WebCore::FrameLoaderClientGdk::loadedFromPageCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
        (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoaderClientGdk::dispatchWillClose):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
        (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
        (WebCore::FrameLoaderClientGdk::dispatchShow):
        (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
        (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
        (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
        (WebCore::FrameLoaderClientGdk::willChangeTitle):
        (WebCore::FrameLoaderClientGdk::finishedLoading):
        (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
        (WebCore::FrameLoaderClientGdk::setDefersLoading):
        (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
        (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
        (WebCore::FrameLoaderClientGdk::clearArchivedResources):
        (WebCore::FrameLoaderClientGdk::canHandleRequest):
        (WebCore::FrameLoaderClientGdk::canShowMIMEType):
        (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
        (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
        (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
        (WebCore::FrameLoaderClientGdk::didFinishLoad):
        (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
        (WebCore::FrameLoaderClientGdk::setTitle):
        (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
        (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
        (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
        (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
        (WebCore::FrameLoaderClientGdk::download):
        (WebCore::FrameLoaderClientGdk::cancelledError):
        (WebCore::FrameLoaderClientGdk::cannotShowURLError):
        (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
        (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
        (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
        (WebCore::FrameLoaderClientGdk::shouldFallBack):
        (WebCore::FrameLoaderClientGdk::willUseArchive):
        (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache):
        (WebCore::FrameLoaderClientGdk::canCachePage):
        (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
        (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
        (WebCore::FrameLoaderClientGdk::setMainDocumentError):
        (WebCore::FrameLoaderClientGdk::startDownload):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
        (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
        (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
        * page/gdk/EventHandlerGdk.cpp:
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::passSubframeEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/gdk/EditorClientGdk.cpp:
        (WebCore::EditorClientGdk::shouldDeleteRange):
        (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
        (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
        (WebCore::EditorClientGdk::spellCheckerDocumentTag):
        (WebCore::EditorClientGdk::shouldBeginEditing):
        (WebCore::EditorClientGdk::shouldEndEditing):
        (WebCore::EditorClientGdk::shouldInsertText):
        (WebCore::EditorClientGdk::shouldChangeSelectedRange):
        (WebCore::EditorClientGdk::shouldApplyStyle):
        (WebCore::EditorClientGdk::didBeginEditing):
        (WebCore::EditorClientGdk::respondToChangedContents):
        (WebCore::EditorClientGdk::didEndEditing):
        (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
        (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
        (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
        (WebCore::EditorClientGdk::isEditable):
        (WebCore::EditorClientGdk::registerCommandForUndo):
        (WebCore::EditorClientGdk::registerCommandForRedo):
        (WebCore::EditorClientGdk::clearUndoRedoOperations):
        (WebCore::EditorClientGdk::canUndo):
        (WebCore::EditorClientGdk::canRedo):
        (WebCore::EditorClientGdk::undo):
        (WebCore::EditorClientGdk::redo):
        (WebCore::EditorClientGdk::shouldInsertNode):
        (WebCore::EditorClientGdk::pageDestroyed):
        (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
        (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
        (WebCore::EditorClientGdk::textFieldDidBeginEditing):
        (WebCore::EditorClientGdk::textFieldDidEndEditing):
        (WebCore::EditorClientGdk::textDidChangeInTextField):
        (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
        (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
        (WebCore::EditorClientGdk::textDidChangeInTextArea):
        * platform/gdk/RenderThemeGdk.cpp:
        (WebCore::RenderThemeGdk::setCheckboxSize):
        (WebCore::RenderThemeGdk::setRadioSize):
        (WebCore::RenderThemeGdk::adjustTextFieldStyle):
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameView::updateBorder):
        (Widget::setEnabled):
        (Widget::isEnabled):
        (Widget::focusPolicy):
        (Widget::enableFlushDrawing):
        (Widget::disableFlushDrawing):
        (Widget::lockDrawingFocus):
        (Widget::unlockDrawingFocus):
        (Widget::removeFromParent):
        (Widget::paint):
        (Widget::setIsSelected):
        (Widget::invalidate):
        (Widget::invalidateRect):
        (PlatformMouseEvent::PlatformMouseEvent):
        (WebCore::findNextSentenceFromIndex):
        (WebCore::findSentenceBoundary):
        (WebCore::findNextWordFromIndex):
        (ChromeClientGdk::chromeDestroyed):
        (ChromeClientGdk::windowRect):
        (ChromeClientGdk::setWindowRect):
        (ChromeClientGdk::pageRect):
        (ChromeClientGdk::scaleFactor):
        (ChromeClientGdk::focus):
        (ChromeClientGdk::unfocus):
        (ChromeClientGdk::createWindow):
        (ChromeClientGdk::createModalDialog):
        (ChromeClientGdk::show):
        (ChromeClientGdk::canRunModal):
        (ChromeClientGdk::runModal):
        (ChromeClientGdk::setToolbarsVisible):
        (ChromeClientGdk::toolbarsVisible):
        (ChromeClientGdk::setStatusbarVisible):
        (ChromeClientGdk::statusbarVisible):
        (ChromeClientGdk::setScrollbarsVisible):
        (ChromeClientGdk::scrollbarsVisible):
        (ChromeClientGdk::setMenubarVisible):
        (ChromeClientGdk::menubarVisible):
        (ChromeClientGdk::setResizable):
        (ChromeClientGdk::closeWindowSoon):
        (ChromeClientGdk::canTakeFocus):
        (ChromeClientGdk::takeFocus):
        (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
        (ChromeClientGdk::addMessageToConsole):
        (ChromeClientGdk::runBeforeUnloadConfirmPanel):
        (ChromeClientGdk::runJavaScriptAlert):
        (ChromeClientGdk::runJavaScriptConfirm):
        (ChromeClientGdk::runJavaScriptPrompt):
        (ChromeClientGdk::setStatusbarText):
        (ChromeClientGdk::shouldInterruptJavaScript):
        (ChromeClientGdk::tabsToLinks):
        (ChromeClientGdk::windowResizerRect):
        (ChromeClientGdk::addToDirtyRegion):
        (ChromeClientGdk::scrollBackingStore):
        (ChromeClientGdk::updateBackingStore):
        (PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (PlugInInfoStore::pluginCount):
        (WebCore::PlugInInfoStore::supportsMIMEType):
        (WebCore::refreshPlugins):
        (SearchPopupMenu::saveRecentSearches):
        (SearchPopupMenu::loadRecentSearches):
        (SearchPopupMenu::SearchPopupMenu):
        (PlatformScrollbar::PlatformScrollbar):
        (PlatformScrollbar::~PlatformScrollbar):
        (PlatformScrollbar::setEnabled):
        (PlatformScrollbar::paint):
        (PlatformScrollbar::updateThumbPosition):
        (PlatformScrollbar::updateThumbProportion):
        (PlatformScrollbar::setRect):
        (FileChooser::FileChooser):
        (FileChooser::~FileChooser):
        (FileChooser::openFileChooser):
        (FileChooser::basenameForWidth):
        (ResourceHandle::willLoadFromCache):
        (ResourceHandle::loadsBlocked):
        (ResourceHandle::loadResourceSynchronously):
        (Icon::Icon):
        (Icon::~Icon):
        (Icon::newIconForFile):
        (Icon::paint):
        (Font::drawComplexText):
        (Font::floatWidthForComplexText):
        (Font::offsetForPositionForComplexText):
        (PageCache::close):
        (Editor::ignoreSpelling):
        (Editor::learnSpelling):
        (Editor::isSelectionUngrammatical):
        (Editor::isSelectionMisspelled):
        (Editor::guessesForMisspelledSelection):
        (Editor::guessesForUngrammaticalSelection):
        (Editor::markMisspellingsAfterTypingToPosition):
        (Editor::newGeneralClipboard):
        (Pasteboard::generalPasteboard):
        (Pasteboard::writeSelection):
        (Pasteboard::writeURL):
        (Pasteboard::writeImage):
        (Pasteboard::clear):
        (Pasteboard::canSmartReplace):
        (Pasteboard::documentFragment):
        (Pasteboard::plainText):
        (Pasteboard::Pasteboard):
        (Pasteboard::~Pasteboard):
        (ContextMenu::ContextMenu):
        (ContextMenu::~ContextMenu):
        (ContextMenu::appendItem):
        (ContextMenuItem::ContextMenuItem):
        (ContextMenuItem::~ContextMenuItem):
        (ContextMenuItem::releasePlatformDescription):
        (ContextMenuItem::type):
        (ContextMenuItem::setType):
        (ContextMenuItem::action):
        (ContextMenuItem::setAction):
        (ContextMenuItem::title):
        (ContextMenuItem::setTitle):
        (ContextMenuItem::platformSubMenu):
        (ContextMenuItem::setSubMenu):
        (ContextMenuItem::setChecked):
        (ContextMenuItem::setEnabled):
        (WebCore::supportedKeySizes):
        (WebCore::systemBeep):
        (WebCore::userIdleTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd missing files from last commit
staikos [Thu, 22 Feb 2007 06:40:01 +0000 (06:40 +0000)]
Add missing files from last commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 22 Feb 2007 06:17:34 +0000 (06:17 +0000)]
LayoutTests:

        Reviewed by Adam Roben.

        Updated results to new, more correct values produced by painting SVGs
        before dumping their render trees.

        * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
        * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
        * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
        * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
        * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
        * svg/carto.net/button-expected.txt:
        * svg/carto.net/colourpicker-expected.txt:
        * svg/carto.net/combobox-expected.txt:
        * svg/carto.net/scrollbar-expected.txt:
        * svg/carto.net/selectionlist-expected.txt:
        * svg/carto.net/slider-expected.txt:
        * svg/carto.net/tabgroup-expected.txt:
        * svg/carto.net/textbox-expected.txt:
        * svg/carto.net/window-expected.txt:
        * svg/custom/gradient-stop-style-change-expected.txt:
        * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
        * svg/custom/js-late-clipPath-creation-expected.txt:
        * svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * svg/custom/non-opaque-filters-expected.txt:
        * svg/custom/pointer-events-text-expected.txt:
        * svg/custom/text-clip-expected.txt:
        * svg/custom/text-filter-expected.txt:
        * svg/custom/text-image-opacity-expected.txt:
        * svg/custom/text-repaint-including-stroke-expected.txt:
        * svg/custom/use-elementInstance-event-target-expected.txt:
        * svg/custom/use-on-text-expected.txt:

WebKitTools:

        Reviewed by Adam Roben.

        Added hack to force painting when running an SVG test. This is a work-around
        for http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
        paint time instead of style resolution time.

        We need this so that --leaks mode, which always paints, doesn't appear to
        fail SVG tests. We also need this if we ever want to test style application
        in SVG, since many SVGs don't apply style to their renderers until they paint.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 22 Feb 2007 03:12:51 +0000 (03:12 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=12820
        REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

        add test for caret before <select> case too

        * editing/selection/caret-before-select-expected.checksum: Added.
        * editing/selection/caret-before-select-expected.png: Added.
        * editing/selection/caret-before-select-expected.txt: Added.
        * editing/selection/caret-before-select.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12820
        REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

        Yet another attempt to figure out exactly who should paint the caret.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::isInsideNode):
        * editing/SelectionController.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Thu, 22 Feb 2007 02:58:27 +0000 (02:58 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12818
          REGRESSION (r19148): shacknews.com does not render completely

        * fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
        * fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
        * fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
        * fast/dynamic/staticY-marking-parents-regression.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12818
          REGRESSION (r19148): shacknews.com does not render completely

        Test: fast/dynamic/staticY-marking-parents-regression.html

        Changed calls to setChildNeedsLayout(true) during layout to
        setChildNeedsLayout(true, false). Prior to r19148, the default behavior
        of marking containers did not matter because the caller was the container
        and was already marked, but r19148 added marking of the parent of
        objects with static Y, which can be different from the caller and not
        necessarily marked already.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::collapseMargins):
        (WebCore::RenderBlock::clearFloatsIfNeeded):
        (WebCore::RenderBlock::layoutBlockChildren):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStaticY):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutVerticalBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Dave Harrison
beidson [Thu, 22 Feb 2007 02:54:49 +0000 (02:54 +0000)]
    Reviewed by Dave Harrison

        <rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
        after regaining network connection

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::restoreScrollPositionAndViewState):  Leave an assertion for debug
        build exploration, but gracefully handle the release build case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Darin.
thatcher [Thu, 22 Feb 2007 01:14:30 +0000 (01:14 +0000)]
    Rubber-stamped by Darin.

        * bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public.
        Also adds the deprecated selector for getComputedStyle: on DOMDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Add new version with WKCGContextIsBitmapContext.
andersca [Thu, 22 Feb 2007 00:30:31 +0000 (00:30 +0000)]
    Add new version with WKCGContextIsBitmapContext.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 22 Feb 2007 00:10:16 +0000 (00:10 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/5012665>
        Removing indent from list moves the caret to the line below

        No new layout tests needed because the new results
        for these tests and the removed FIXMEs cover the bug fix:
        * editing/execCommand/indent-list-item.html:
        * editing/execCommand/indent-list-item-expected.checksum:
        * editing/execCommand/indent-list-item-expected.png:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/remove-list-1.html:
        * editing/execCommand/remove-list-1-expected.checksum:
        * editing/execCommand/remove-list-1-expected.png:
        * editing/execCommand/remove-list-1-expected.txt:

WebCore:

        Reviewed by john

        <rdar://problem/5012665>
        Removing indent from list moves the caret to the line below

        Selection preservation during indent, outdent and list
        operations uses rangeFromLocationAndLength.  Ranges returned
        by rangeFromLocationAndLength were incorrect for locations
        just before the line breaks that are emitted after blocks.
        This is because TextIterator emitted bad ranges for these line
        breaks (ranges that started and ended *after* the block).
        The fix corrects the start but not the end.  This is acceptible
        because there is code in rangeFromLocationAndLength that corrects
        the ends of runs using the start of the run and VisiblePosition
        creation.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::exitNode): Emit a position *inside*
        the block, after its contents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reduced --leaks mode to running only 750 tests at a time, in the hopes
ggaren [Wed, 21 Feb 2007 22:56:33 +0000 (22:56 +0000)]
    Reduced --leaks mode to running only 750 tests at a time, in the hopes
        of fixing intermittent crasher that may be caused by out of memory
        conditions.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
ggaren [Wed, 21 Feb 2007 22:32:32 +0000 (22:32 +0000)]
    Reviewed by Darin Adler.

        Made DRT paint when running run-webkit-tests in --leaks mode, to check
        for painting leaks.

        * DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since
        that's the default for statics.
        (dumpRenderTree): Added --paint command line option, which specifies that
        DRT should paint at the end of every test.
        (displayWebView): New function, called by dump() and -[LayoutTestController display].
        * Scripts/run-webkit-tests: Use the --paint command line option when checking
        for leaks.

        * Scripts/run-webkit-tests: Added a new, painting leak to the ignore list.
        Removed stale comment about THRD leaks -- we now ignore them reliably.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Wed, 21 Feb 2007 21:49:56 +0000 (21:49 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

        * fast/forms/select-index-setter-expected.txt: Added.
        * fast/forms/select-index-setter.html: Added.

WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

        Test: fast/forms/select-index-setter.html

        Added indexSetter for HTMLSelectElement.

        * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h

        * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter):
          Moved code to selectIndexSetter so it can be shared between these classes.
        * bindings/js/JSHTMLSelectElementCustom.cpp:
        (WebCore::selectIndexSetter): Added.  Moved from JSHTMLOptionsCollection::indexSetter.
        (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
        * bindings/js/JSHTMLSelectElementCustom.h: Added.
        * html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.

        * bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first,
          and then call the version of lookupPut that will also try to use the parent's lookup table.  This matches the order of our
          old code, before we autogenerated the JSHTMLSelectElement class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tools tweak. No review necessary.
ggaren [Wed, 21 Feb 2007 20:48:13 +0000 (20:48 +0000)]
    Tools tweak. No review necessary.

        * Scripts/parse-malloc-history: Enabled multiple merge-regexp command line
        arguments. Changed command line argument variables from special implicit
        no-op values to specific empty values that we test explicitly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 21 Feb 2007 20:00:12 +0000 (20:00 +0000)]
    Reviewed by Tim H.

        Bug 12834: Drosera should remember scroll position of open files like Xcode
        http://bugs.webkit.org/show_bug.cgi?id=12834

        * Drosera/debugger.js: Implemented scrolling memory

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd undo/redo support and more editing commands.
staikos [Wed, 21 Feb 2007 16:55:34 +0000 (16:55 +0000)]
Add undo/redo support and more editing commands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoImplementing popups for the Qt platform.
zack [Wed, 21 Feb 2007 13:59:55 +0000 (13:59 +0000)]
Implementing popups for the Qt platform.
r=Lars

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19772 268f45cc-cd09-0410-ab3c-d52691b4dbfc