WebKit-https.git
9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 06:45:15 +0000 (06:45 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        r79285 removes too much lines. recover failed one.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Benjamin Kalman <kalman@chromium.org>
kalman@chromium.org [Tue, 22 Feb 2011 06:24:36 +0000 (06:24 +0000)]
2011-02-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
        start/end of selection for RTL
        https://bugs.webkit.org/show_bug.cgi?id=54724

        Augment extend-left-by-lineboundary test to extend the selection twice, which triggered the bug.

        * editing/selection/extend-left-right-by-lineboundary-expected.txt:
        * editing/selection/extend-left-right-by-lineboundary.html:
2011-02-21  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Extending selection by a boundary granularity (LineBoundary/ParagraphBoundary/DocumentBoundary) sets incorrect
        start/end of selection for RTL
        https://bugs.webkit.org/show_bug.cgi?id=54724

        On mac, the selection should always grow when extending by a boundary granularity (line/paragraph/document).
        This is achieved by extending from the start for the "left" direction (e.g. pressing left arrow key), or
        extending from the end when for the "right" direction (e.g. pressing right arrow key).

        However, this has a bug for RTL text, which should actually extend from the *end* when extending left (since
        direction is obviously reversed) and likewise extend from the start when extending right.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::modify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 06:19:39 +0000 (06:19 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation rebaseline for r79284.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png:
        * platform/chromium-linux/fast/forms/search-styled-expected.checksum:
        * platform/chromium-linux/fast/forms/search-styled-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.checksum:
        * platform/chromium-win/fast/forms/placeholder-position-expected.png:
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt:
        * platform/chromium-win/fast/forms/search-styled-expected.checksum:
        * platform/chromium-win/fast/forms/search-styled-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 06:10:29 +0000 (06:10 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        ImageDocument::imageChanged() confuses clang's -Woverride-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54924

        Rename ImageDocument::imageChanged() to imageUpdated() to make clear
        that it's not an override of CachedResourceClient::imageChanged().

        * html/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::appendBytes):
        (WebCore::ImageDocumentParser::finish):
        (WebCore::ImageDocument::imageUpdated):
        * html/ImageDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 22 Feb 2011 05:58:49 +0000 (05:58 +0000)]
2011-02-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 54934 - Sort the WebCore project file(s)
        https://bugs.webkit.org/show_bug.cgi?id=54934

        No new tests. (no code affected)

        * GNUmakefile.am:
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 05:51:51 +0000 (05:51 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Adam Barth.

        canAccommodateEllipsis() confuses clang's -Woverloaded-virtual
        https://bugs.webkit.org/show_bug.cgi?id=54909

        Rename the overload in RootInlineBox to lineCanAccomodateEllipsis() to
        unconfuse clang. No intended functionality change.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::checkLinesForTextOverflow):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::applyLineClamp):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::lineCanAccommodateEllipsis):
        * rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 05:14:59 +0000 (05:14 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        Removed BUGWK54736 lines which are no longer failed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
adele@apple.com [Tue, 22 Feb 2011 04:56:14 +0000 (04:56 +0000)]
Source/WebCore: Fix for for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Test: updated fast/forms/placeholder-position.html and tested manually

Consider padding and margin for the results and cancel buttons.  This is important for the Windows
theme which uses padding to correctly position those buttons.  This change fixes the placeholder
position, and also better aligns the results popup list with the actual text you type.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=54402
REGRESSION (r72052): Placeholder text doesn't have the right padding for search fields on Windows

Reviewed by Dan Bernstein.

Unfortunately, this doesn't test the Windows theme, since DRT uses the Safari theme, but I also tested this change manually on Windows and Mac.

* fast/forms/placeholder-position.html: Added a case for a search field with the results button.
* platform/mac/fast/forms/placeholder-position-expected.checksum:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 22 Feb 2011 03:59:52 +0000 (03:59 +0000)]
2011-02-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] focus comment on accept
        https://bugs.webkit.org/show_bug.cgi?id=54930

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 03:57:28 +0000 (03:57 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Kent Tamura.

        GIFImageDecoder::setSize() tries to override the superclass method but fails
        https://bugs.webkit.org/show_bug.cgi?id=54305

        The superclass uses unsigned instead of int for its parameters, so
        GIFImageDecoder::setSize() was an overload, not an override.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::setSize):
        * platform/image-decoders/gif/GIFImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 22 Feb 2011 03:44:54 +0000 (03:44 +0000)]
2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This patch changes a test to work around a bug in PrettyPatch where
        it will crash if lines starting with "--" are missing from the actual
        output. The actual fix needed to PrettyPatch is described in the
        bug.

        https://bugs.webkit.org/show_bug.cgi?id=54918

        * platform/mac/fast/objc/dom-html-select-activate-expected.txt:
        * platform/mac/fast/objc/dom-html-select-activate.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 22 Feb 2011 03:38:28 +0000 (03:38 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] avoid overriding ctrl/cmd + r
        https://bugs.webkit.org/show_bug.cgi?id=54852

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 22 Feb 2011 03:31:35 +0000 (03:31 +0000)]
2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kent Tamura.

        nrwt: revert behavior on 10.5 to "old-threads". It's possible
        that r79062 has introduced a bunch of flakiness, although I
        can't explain why right now. This change should restore the
        old behavior, and then we can look at the build logs to see
        if the tests stop timing out or being flaky.

        https://bugs.webkit.org/show_bug.cgi?id=54925

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 22 Feb 2011 02:28:19 +0000 (02:28 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Deploy EditingStyle more in ApplyStyleCommand and do some cleanup
        https://bugs.webkit.org/show_bug.cgi?id=54528

        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init): Allows style to be a null pointer.
        (WebCore::ApplyStyleCommand::applyInlineStyle): Overrides the value of text-decoration property by that of
        -webkit-text-decorations-in-effect and remove the latter property when present. This allows removeImplicitlyStyledElement
        to ignore -webkit-text-decorations-in-effect. Also uses the return value of EditingStyle::textDirection to determine
        whether or not we need to apply unicode-bidi / direction instead of directly checking the value of unicode-bidi property.
        (WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Takes EditingStyle* instead of CSSMutableStyleDeclaration*.
        (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Ditto.
        (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Ditto.
        (WebCore::ApplyStyleCommand::removeCSSStyle): Ditto.
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Ditto.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Ditto.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto; no longer collapse text decoration properties because
        ApplyStyleCommand::applyInlineStyle already does it.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::textDirection): Exits early when m_mutableStyle is null.
        (WebCore::EditingStyle::collapseTextDecorationProperties): Extracted from ApplyStyleCommand::removeInlineStyle.
        * editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclam...
mrowe@apple.com [Tue, 22 Feb 2011 02:14:10 +0000 (02:14 +0000)]
<webkit.org/b/54919> / <rdar://problem/7689300> WebCore should retrieve unclamped frame delays from ImageIO

Reviewed by Darin Adler and Alexey Proskuryakov.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex): Look for the unclamped frame delay in the
frame properties dictionary and use that if it exists. If it does not exist in the
dictionary then fall back to using the clamped frame delay.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Tue, 22 Feb 2011 02:08:08 +0000 (02:08 +0000)]
2011-02-21  Nico Weber  <thakis@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] ChromePluginPrintContext::begin() fails to override superclass method
        https://bugs.webkit.org/show_bug.cgi?id=54914

        Update subclass method signature to match superclass again. This
        regressed in http://trac.webkit.org/changeset/71964

        * src/WebFrameImpl.cpp:
        (WebKit::ChromePluginPrintContext::begin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 02:07:26 +0000 (02:07 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt update.

        Disabled "BUGWK54322 MAC SNOWLEOPARD" lines, which sesms no longer needed.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
timothy@apple.com [Tue, 22 Feb 2011 02:01:26 +0000 (02:01 +0000)]
Fix Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet and update the window title for the Web Inspector in WebKit2.
timothy@apple.com [Tue, 22 Feb 2011 01:43:39 +0000 (01:43 +0000)]
Set and update the window title for the Web Inspector in WebKit2.

https://webkit.org/b/50945
rdar://problem/8762410

Reviewed by Adam Roben.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectedURLChanged): Added. Call platformInspectedURLChanged.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added InspectedURLChanged.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Set the window title.
* UIProcess/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Added. Not implemented.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::inspectedURLChanged): Call WebInspector::inspectedURLChanged.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::inspectedURLChanged): Added. Send the InspectedURLChanged message.
* WebProcess/WebPage/WebInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 22 Feb 2011 01:40:17 +0000 (01:40 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed test_expectation.txt clenaup.
        Removed disabled lines which I commented out.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 James Kozianski <koz@chromium.org>
commit-queue@webkit.org [Tue, 22 Feb 2011 01:27:09 +0000 (01:27 +0000)]
2011-02-21  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        Causes elements to be unfocusable after tabindex property is removed.
        https://bugs.webkit.org/show_bug.cgi?id=54727

        * fast/html/tabindex-removal-expected.txt: Added.
        * fast/html/tabindex-removal.html: Added.
2011-02-21  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        Causes elements to be unfocusable after tabindex property is removed.
        https://bugs.webkit.org/show_bug.cgi?id=54727

        Test: fast/html/tabindex-removal.html

        * dom/Node.cpp:
        (WebCore::Node::clearTabIndexExplicitly):
        * dom/Node.h:
        * dom/NodeRareData.h:
        (WebCore::NodeRareData::clearTabIndexExplicitly):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Mark Rowe.
ap@apple.com [Tue, 22 Feb 2011 01:23:04 +0000 (01:23 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/8995483> Remove stubs of unneeded NSURLAuthenticationChallengeSender methods

        * platform/network/mac/AuthenticationMac.mm: Remove the stubs that are no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 22 Feb 2011 01:22:18 +0000 (01:22 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations update.

        Removed fast/js/kde/math.html because it has been passing since r79246.
        Removed fast/text/capitalize-boundaries.html on Mac and Windows because it has been steadily passing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 22 Feb 2011 01:18:23 +0000 (01:18 +0000)]
2011-02-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Overhang areas need to be invalidated on scroll
        <rdar://problem/9032194>
        https://bugs.webkit.org/show_bug.cgi?id=54917

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollContents):
        We need to explicitly invalidate the overhang areas when we scroll the contents
        of a ScrollView, since they could contain arbitrary content that cannot be blitted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@79263 268f45cc-cd09-0410...
lforschler@apple.com [Tue, 22 Feb 2011 01:01:33 +0000 (01:01 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp
lforschler@apple.com [Tue, 22 Feb 2011 00:56:44 +0000 (00:56 +0000)]
Fix the Leopard Debug build by incorporating the RenderSVGAllInOne.cpp

Reviewed by Stephanie Lewis.

No new tests required.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove global initializer in CookieStorageCFNet.cpp
psolanki@apple.com [Tue, 22 Feb 2011 00:13:58 +0000 (00:13 +0000)]
Remove global initializer in CookieStorageCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54905

Reviewed by Darin Adler.

* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCan't paste from 3rd party text editor into WebKit2 window.
weinig@apple.com [Mon, 21 Feb 2011 23:57:25 +0000 (23:57 +0000)]
Can't paste from 3rd party text editor into WebKit2 window.
<rdar://problem/8978624>

Reviewed by Anders Carlsson.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-18 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 21 Feb 2011 23:47:22 +0000 (23:47 +0000)]
2011-02-18  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        WebKit2: Media document videos play only sound, no video (affects trailers.apple.com)
        https://bugs.webkit.org/show_bug.cgi?id=54771

        Now that video is accelerated, we no longer need to special case
        video playing within a media document.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
        (WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix linker warning on Windows
aroben@apple.com [Mon, 21 Feb 2011 23:42:59 +0000 (23:42 +0000)]
Fix linker warning on Windows

r79135 tried to export JSObject::s_info by adding it to JavaScriptCore.def. This is the
obvious way (since it's how we export functions), but unfortunately it doesn't work correct.
r79222 made us export it the right way (using the JS_EXPORTDATA macro), but forgot to remove
it from JavaScriptCore.def. This caused us to get linker warnings about exporting the symbol
multiple times.

Rubber-stamped by Anders Carlsson.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Removed JSObject::s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ami Fischman <fischman@chromium.org>
commit-queue@webkit.org [Mon, 21 Feb 2011 23:34:03 +0000 (23:34 +0000)]
2011-02-21  Ami Fischman  <fischman@chromium.org>

        Reviewed by Eric Carlson.

        Add regression test for clean shutdown during video playback.
        DumpRenderTree used to crash if the test was ended while a video
        was still playing.  (http://crbug.com/72730).
        https://bugs.webkit.org/show_bug.cgi?id=54888

        * media/video-plays-past-end-of-test-expected.txt: Added.
        * media/video-plays-past-end-of-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Feb 2011 23:29:37 +0000 (23:29 +0000)]
2011-02-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Initialize DrawingAreaProxy::m_size
        https://bugs.webkit.org/show_bug.cgi?id=54913

        This was removed in r76962 since it caused flashes when switching drawing areas due to
        entering and exiting composited mode, but since we no longer switch drawing areas we can
        put it back.

        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some assertions about the state IDs we receive from the web process
aroben@apple.com [Mon, 21 Feb 2011 23:21:06 +0000 (23:21 +0000)]
Add some assertions about the state IDs we receive from the web process

Rubber-stamped by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::update):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode):
Assert that the state ID the web process sent us is no newer than our own state ID.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".
aroben@apple.com [Mon, 21 Feb 2011 23:20:35 +0000 (23:20 +0000)]
Rename DrawingArea[Proxy]Impl's "sequence number" concept to "state ID".

As explained in r79251, DrawingAreaProxyImpl has some state that, when it changes, causes
all operations performed before that state change to become invalid. Currently, this state
consists of a single piece of data: the view's size. Eventually it will encompass more data
(e.g., the backing store we're drawing into; when we start throwing away the backing store
to save memory, our state will have changed, and any operations that were intended for the
old backing store will have become invalid). r79251 effectively transformed
DrawingArea[Proxy]Impl's "sequence number," which incremented every time DrawingAreaImpl
sent DrawingAreaProxyImpl a message, to a "state ID," which only increments when the view's
size changes.

This patch is just a set of simple renames to reflect the transformation that r79251
effected. It should not introduce any changes in behavior. The renames are:
  - Messages::DrawingArea::SetSize -> UpdateState
  - Messages::DrawingAreaProxy::DidSetSize -> DidUpdateState
  - DrawingAreaProxyImpl::m_lastDidSetSizeSequenceNumber -> m_currentStateID
  - DrawingAreaProxyImpl::m_isWaitingForDidSetSize -> m_isWaitingForDidUpdateState
  - DrawingAreaProxyImpl::waitForAndDispatchDidSetSize -> waitForAndDispatchDidUpdateState
  - DrawingAreaImpl::m_inSetSize -> m_inUpdateState
  - generateSequenceNumber -> generateStateID
  - sequenceNumber -> stateID

Fixes <http://webkit.org/b/54911> DrawingArea[Proxy]Impl's "sequence number" concept should
be renamed to "state ID"

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxy.messages.in:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/DrawingAreaProxyImpl.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/DrawingAreaImpl.h:
Performed the renames described above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Adam Roben.
ap@apple.com [Mon, 21 Feb 2011 22:47:03 +0000 (22:47 +0000)]
    Reviewed by Adam Roben.

        REGRESSION (WebKit2): HTTP requests time out after 60 seconds
        https://bugs.webkit.org/show_bug.cgi?id=54755
        <rdar://problem/9006592>

WebCore:
        It's now possible to set a default timeout to be used at ResourceRequest creation. If one
        hasn't been set, ResourceRequest will behave as before (use NSURLRequest default on Mac,
        or use INT_MAX on other platforms).

        * WebCore.exp.in:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::ResourceRequestBase::defaultTimeoutInterval): Get the ResourceRequest notion of
        default timeout interval (may be 0 if using NSURLRequest default).
        (WebCore::ResourceRequestBase::setDefaultTimeoutInterval): Set the static member variable.
        (WebCore::ResourceRequestBase::updatePlatformRequest): Added an assertion that resource
        request is updated. Plaform code often calls updateResourceRequest() indirectly from this
        function, and that must obviously be a no-op.
        (WebCore::ResourceRequestBase::updateResourceRequest): Added an assertion in the opposite
        direction.
        * platform/network/ResourceRequestBase.h: Changed "unspecifiedTimeoutInterval" to
        "defaultTimeoutInterval". It has been used as default by most platforms anyway.
        (WebCore::ResourceRequestBase::ResourceRequestBase):

        * platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
        Now zero is the magic value, not INT_MAX. We'll use NSURLRequest default if neither
        setTimeoutInterval() nor setDefaultTimeoutInterval() has been called.

WebKit2:
        * Shared/API/c/WKURLRequest.cpp:
        (WKURLRequestSetDefaultTimeoutInterval):
        * Shared/API/c/WKURLRequest.h:
        Added an API to set a default timeout interval for requests created from URLs. The API
        affects both the UI process and requests created internally by the Web process. Requests
        created from NSURLRequest or CFURLRequest take timeout from those.

        * Shared/WebURLRequest.cpp: (WebKit::WebURLRequest::setDefaultTimeoutInterval):
        * Shared/WebURLRequest.h:
        Pipe the default timeout interval from WKURLRequest down to actual implementation. Since
        WebURLRequest is currently implemented with WebCore::ResourceRequest, it automatically respects
        NSURLRequest default timeout interval.

        * UIProcess/WebProcessManager.cpp: (WebKit::WebProcessManager::getAllWebProcessContexts):
        * UIProcess/WebProcessManager.h:
        Added a way to enumerate all contexts running in separate processes.

        * Shared/WebProcessCreationParameters.cpp:
        (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
        (WebKit::WebProcessCreationParameters::encode):
        (WebKit::WebProcessCreationParameters::decode):
        * Shared/WebProcessCreationParameters.h:
        (WebKit::WebContext::ensureWebProcess):
        (WebKit::WebContext::setDefaultRequestTimeoutInterval):
        * UIProcess/WebContext.h:
        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initializeWebProcess):
        (WebKit::WebProcess::setDefaultRequestTimeoutInterval):
        * WebProcess/WebProcess.h:
        * WebProcess/WebProcess.messages.in:
        Use UI process default timeout interval in separate process contexts, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: WebResourceCacheManager should be responsible for managing...
bweinstein@apple.com [Mon, 21 Feb 2011 22:26:56 +0000 (22:26 +0000)]
Source/JavaScriptCore: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Add a new use flag for using the CFURLCache.

* wtf/Platform.h:

Source/WebKit2: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::getCacheOrigins): Call through to cFURLCacheHostNames, and add
    create SecurityOrigin's for them and add them to the set of SecurityOrigins with cache.
(WebKit::WebResourceCacheManager::clearCacheForOrigin): Call through to clear the CFURLCache for
    the origin's hostname.
* WebProcess/ResourceCache/WebResourceCacheManager.h:

* WebProcess/ResourceCache/cf: Added.
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Added.
(WebKit::WebResourceCacheManager::cfURLCacheHostNames): Call through to WebKitSystemInterface.
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames): Ditto.

* win/WebKit2.vcproj: Added new file.
* WebKit2.xcodeproj/project.pbxproj: Ditto.

WebKitLibraries: WebResourceCacheManager should be responsible for managing the CFURLCache as well
as the WebCore memory cache.
https://bugs.webkit.org/show_bug.cgi?id=54886
Part of <rdar://problem/8971738>

Reviewed by Adam Roben.

Update WebKitSystemInterface headers and libraries with new functions.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl
aroben@apple.com [Mon, 21 Feb 2011 22:21:13 +0000 (22:21 +0000)]
Move control of the sequence number from DrawingAreaImpl to DrawingAreaProxyImpl

DrawingAreaProxyImpl has some state that, when it changes, causes all operations performed
before that state change to become invalid. When painting, we need to have performed at
least one Update for the most recent state; otherwise, we'll be painting old/incorrect bits
into the view.

Currently, this state consists of a single piece of data: the view's size. Whenever the
state (i.e., size) changes, we tell the web process via the SetSize message, and the web
process lets us know that it has updated to match the new state (i.e., size) via the
DidSetSize message.

When it's time to paint, if we're waiting for the web process to update to match our current
state (i.e., size), we block for a little while hoping to receive a DidSetSize message so
that we can paint up-to-date bits into the window. This can cause us to receive messages
out-of-order; the DidSetSize message will be processed immediately, and any messages that
were sent before the DidSetSize message will be processed later. Since the messages from
before the DidSetSize message correspond to an old state (i.e., size), they are no longer
useful (e.g., they contain bits of the page that are drawn at the wrong size/location), so
we discard them.

The way we identify and discard these messages is by keeping track of a sequence number.
Currently, DrawingAreaImpl sends a monotonically-increasing sequence number to
DrawingAreaProxyImpl with every message. Whenever DrawingAreaProxyImpl receives a DidSetSize
message, it records the sequence number that came along with it. If we then later receive
any messages that have a lower sequence number, we know they correspond to an old state
(i.e., size) and can discard them.

This patch moves control of the sequence number to DrawingAreaProxyImpl.
DrawingAreaProxyImpl now sends a monotonically-increasing sequence number in the SetSize
message. DrawingAreaImpl records this sequence number when it receives the SetSize message,
and sends it back to DrawingAreaProxyImpl in every message. Otherwise the logic is the same
as before.

This should cause no changes in behavior, but will allow DrawingAreaProxyImpl to request a
full backing store update (by incrementing the sequence number) at times other than when the
view's size changes (e.g., after it has thrown away its backing store in order to save
memory).

Fixes <http://webkit.org/b/54907> DrawingAreaProxyImpl should tell DrawingAreaImpl what
sequence number to use

Reviewed by Anders Carlsson.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::generateSequenceNumber): Moved here from DrawingAreaImpl.cpp.
(WebKit::DrawingAreaProxyImpl::sendSetSize): Changed to pass a new sequence number in the
SetSize message.
(WebKit::DrawingAreaProxyImpl::waitForAndDispatchDidSetSize): Added a FIXME about a
potential improvement.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setSize): Updated to match the message's new parameters.

* WebProcess/WebPage/DrawingArea.messages.in: Added a sequenceNumber parameter to SetSize.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize m_sequenceNumber.
(WebKit::DrawingAreaImpl::setSize): Record the new sequence number from the UI process.

(WebKit::DrawingAreaImpl::layerHostDidFlushLayers):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
Send m_sequenceNumber, instead of a new sequence number, back to the UI process.

* WebProcess/WebPage/DrawingAreaImpl.h: Added m_sequenceNumber, updated setSize function to
match the base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKitSystemInterface.h on Mac. The header that was in the tree didn't
bweinstein@apple.com [Mon, 21 Feb 2011 22:02:31 +0000 (22:02 +0000)]
Update WebKitSystemInterface.h on Mac. The header that was in the tree didn't
match the current WebKitSystemInterface.h.

Rubber-stamped by Dan Bernstein.

* WebKitSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 21 Feb 2011 21:35:26 +0000 (21:35 +0000)]
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54895

        Update the results for this test which now includes a few more passing
        lines. We maintain separate results, because we seem to pass more tests
        than other platforms.

        * platform/gtk/Skipped: Unskip a test which is now passing.
        * platform/gtk/editing/pasteboard/dataTransfer-setData-getData-expected.txt:
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] editing/pasteboard/dataTransfer-setData-getData.html fails
        https://bugs.webkit.org/show_bug.cgi?id=54895

        Correct the GTK+ clipboard implementation to know that "text" is an alias
        for "text/html" data. This corrects the failing test.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::dataObjectTypeFromHTMLClipboardType): Accept "text" as well as "Text".
        (WebCore::ClipboardGtk::types): Advertise "text" as well as "Text".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 21 Feb 2011 21:23:57 +0000 (21:23 +0000)]
2011-02-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        nrwt: fix typo causing us to try and repeatedly shut down the servers
        https://bugs.webkit.org/show_bug.cgi?id=54904

        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 21 Feb 2011 21:14:57 +0000 (21:14 +0000)]
2011-02-21  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gavin Barraclough.

        Use ASSERT_JIT_OFFSET in JITPropertyAccess32_64.cpp
        https://bugs.webkit.org/show_bug.cgi?id=54901

        * jit/JIT.h: swap actual and expected values in message, they were
        reversed.
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCall): use ASSERT_JIT_OFFSET instead of
        a simple ASSERT.
        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_method_check): ditto.
        (JSC::JIT::compileGetByIdHotPath): ditto.
        (JSC::JIT::compileGetByIdSlowCase): ditto.
        (JSC::JIT::emit_op_put_by_id): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRuber stamped by Sam Weinig
barraclough@apple.com [Mon, 21 Feb 2011 20:46:50 +0000 (20:46 +0000)]
Ruber stamped by Sam Weinig

Bug 54899 - Math.LOG10E should be 0.4342944819032518
This value is quoted in section 15.8.1.5 of the spec.

Source/JavaScriptCore:

* runtime/MathObject.cpp:
(JSC::MathObject::MathObject):

LayoutTests:

* fast/js/kde/math-expected.txt:
* fast/js/kde/script-tests/math.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Anna Cavender <annacc@timberline.sea.corp.google.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 20:30:51 +0000 (20:30 +0000)]
2011-02-21  Anna Cavender  <annacc@timberline.sea.corp.google.com>

        Reviewed by Eric Carlson.

        new baselines for video-transformed.html on mac
        https://bugs.webkit.org/show_bug.cgi?id=54765

        * platform/chromium-mac-leopard/media/video-transformed-expected.checksum: Added.
        * platform/chromium-mac-leopard/media/video-transformed-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-transformed-expected.png.
        * platform/chromium-mac-snowleopard/media/video-transformed-expected.checksum: Added.
        * platform/chromium-mac-snowleopard/media/video-transformed-expected.png: Added.
        * platform/chromium-mac/media/video-transformed-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Mon, 21 Feb 2011 19:58:59 +0000 (19:58 +0000)]
2011-02-21  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        ProcessingInstruction should provide a way to know if it is of CSS type.
        https://bugs.webkit.org/show_bug.cgi?id=54868

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:
        (WebCore::ProcessingInstruction::isCSS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 21 Feb 2011 19:55:31 +0000 (19:55 +0000)]
2011-02-21  Simon Fraser  <simon.fraser@apple.com>

        Put JSDOMImplementationCustom.cpp where it belongs in the project.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 19:49:03 +0000 (19:49 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip
        editing/pasteboard/dataTransfer-setData-getData.html. Added bug:
        https://bugs.webkit.org/show_bug.cgi?id=54895

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 19:33:23 +0000 (19:33 +0000)]
Unreviewed.

[Qt] Add Qt specific expected results for passing tables/mozilla tests.

* platform/qt/Skipped: Unskip passing tests.
* platform/qt/tables/mozilla [...] : Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.
barraclough@apple.com [Mon, 21 Feb 2011 19:31:42 +0000 (19:31 +0000)]
Bug 54894 - Make inheritance structure described by ClassInfo match C++ class hierarchy.

Reviewed by Sam Weinig.

The ClassInfo objects describe an inheritance hierarchy, with each ClassInfo instance
containing a pointer to its parent class. These links should reflect the inheritance
hierarchy of C++ classes below JSObject. For the large part it does, but in some cases
entries in the C++ hierarchy are skipped over. This presently likely doesn't matter,
since intervening C++ classes may not have ClassInfo - but would be a potential bug
were ClassInfo were to be added.

Source/JavaScriptCore:

* API/JSCallbackConstructor.cpp:
* API/JSCallbackFunction.cpp:
* API/JSCallbackObjectFunctions.h:
* runtime/Arguments.h:
* runtime/ArrayPrototype.cpp:
* runtime/BooleanObject.cpp:
* runtime/DateInstance.cpp:
* runtime/DatePrototype.cpp:
* runtime/ErrorInstance.cpp:
* runtime/InternalFunction.cpp:
* runtime/JSActivation.cpp:
* runtime/JSArray.cpp:
* runtime/JSFunction.cpp:
* runtime/JSONObject.cpp:
* runtime/JSObject.h:
* runtime/JSZombie.h:
* runtime/MathObject.cpp:
* runtime/NativeErrorConstructor.cpp:
* runtime/NumberConstructor.cpp:
* runtime/NumberObject.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpObject.cpp:
* runtime/StringObject.cpp:
* runtime/StringPrototype.cpp:

Source/WebCore:

* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_object.cpp:

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 19:16:36 +0000 (19:16 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skip new inspector test on wk2.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix radar url.
andersca@apple.com [Mon, 21 Feb 2011 19:07:56 +0000 (19:07 +0000)]
Fix radar url.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 19:06:54 +0000 (19:06 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Csaba Osztrogon√°c.

        REGRESSION(r79157):
        plugins/get-url-with-javascript-destroying-plugin.html make the
        next test crash
        https://bugs.webkit.org/show_bug.cgi?id=54863

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 21 Feb 2011 18:45:37 +0000 (18:45 +0000)]
2011-02-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Skip WebKit2 tests that need EventSender
        https://bugs.webkit.org/show_bug.cgi?id=54890

        These tests fail because EventSender is missing.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 18:40:16 +0000 (18:40 +0000)]
Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

Bug was fixed by http://trac.webkit.org/changeset/79231.

* platform/qt/Skipped: Unskip plugins/get-url-with-javascript-destroying-plugin.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 18:29:27 +0000 (18:29 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: navigation does not work after reopening frontend.
        https://bugs.webkit.org/show_bug.cgi?id=54879

        Test: http/tests/inspector-enabled/open-close-open.html

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::unmute):
        * inspector/InspectorState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 21 Feb 2011 18:03:36 +0000 (18:03 +0000)]
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Add results for tests missing results and unskip a test that
        is passing locally and when run manually on the bots.

        * platform/gtk/Skipped: Unskip tests that are now passing.
        * platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
        * platform/gtk/fast/runin/generated2-expected.checksum: Added.
        * platform/gtk/fast/runin/generated2-expected.png: Added.
        * platform/gtk/fast/runin/generated2-expected.txt: Added.
        * platform/gtk/fast/runin/generated3-expected.checksum: Added.
        * platform/gtk/fast/runin/generated3-expected.png: Added.
        * platform/gtk/fast/runin/generated3-expected.txt: Added.
        * platform/gtk/fast/runin/generated4-expected.checksum: Added.
        * platform/gtk/fast/runin/generated4-expected.png: Added.
        * platform/gtk/fast/runin/generated4-expected.txt: Added.
        * platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
        * platform/gtk/media/video-aspect-ratio-expected.png: Added.
        * platform/gtk/media/video-aspect-ratio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 18:01:36 +0000 (18:01 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed added more tests with pixel differences between bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProtect the PluginView when evaluating javascript: URLs
aroben@apple.com [Mon, 21 Feb 2011 17:48:50 +0000 (17:48 +0000)]
Protect the PluginView when evaluating javascript: URLs

Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 21 Feb 2011 17:44:40 +0000 (17:44 +0000)]
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Fix GTK+ build after r79223.

        * GNUmakefile.am: Add file missing from the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-14 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 21 Feb 2011 17:35:47 +0000 (17:35 +0000)]
2011-02-14  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: audits should not warn about gzip compression for 304s
        https://bugs.webkit.org/show_bug.cgi?id=54343

        Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.GzipRule.prototype._isCompressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations change to mark tests as timing out.
atwilson@chromium.org [Mon, 21 Feb 2011 17:25:37 +0000 (17:25 +0000)]
Unreviewed expectations change to mark tests as timing out.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations change - ignore styles-update-from-js.html failures on chromi...
atwilson@chromium.org [Mon, 21 Feb 2011 16:36:45 +0000 (16:36 +0000)]
Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.

Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother followup to 79223: correct QT project file
antonm@chromium.org [Mon, 21 Feb 2011 16:36:39 +0000 (16:36 +0000)]
Another followup to 79223: correct QT project file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollowup to 79223: forgotten file
antonm@chromium.org [Mon, 21 Feb 2011 16:18:05 +0000 (16:18 +0000)]
Followup to 79223: forgotten file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 21 Feb 2011 16:13:35 +0000 (16:13 +0000)]
2011-02-21  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement WorkQueue::sheduleWorkAfterDelay
        https://bugs.webkit.org/show_bug.cgi?id=54878

        * Platform/qt/WorkQueueQt.cpp:
        (WorkQueue::scheduleWorkAfterDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Mon, 21 Feb 2011 16:01:41 +0000 (16:01 +0000)]
2011-02-08  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       This restores invariant that JS wrappers residing in the same JS context should come
       from the same security origin.

       Absence of regressions is covered by the current tests.  Different security origin of
       DOMImplementation is difficult to check with layout tests as DOMImplementation
       resides in the same JS context as parent document and therefore there are no security origin checks.
       This is observable however in C++.

       * Android.jscbindings.mk:
       * CMakeLists.txt:
       * WebCore.gypi:
       * WebCore.pro:
       * WebCore.vcproj/WebCore.vcproj:
       * WebCore.xcodeproj/project.pbxproj:
       * bindings/v8/V8GCController.cpp:
       (WebCore::NodeGrouperVisitor::visitDOMWrapper):
       * dom/DOMImplementation.cpp:
       (WebCore::DOMImplementation::DOMImplementation):
       (WebCore::DOMImplementation::createDocument):
       * dom/DOMImplementation.h:
       (WebCore::DOMImplementation::create):
       (WebCore::DOMImplementation::documentDestroyed):
       (WebCore::DOMImplementation::parentDocument):
       * dom/DOMImplementation.idl:
       * dom/Document.cpp:
       (WebCore::Document::~Document):
       (WebCore::Document::implementation):
       * dom/Document.h:
2011-02-21  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       Additional test which checks case when parent document can be collected while
       its implementation is alive.

       * fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport JSObject::s_info from JavaScriptCore.dll
aroben@apple.com [Mon, 21 Feb 2011 15:55:45 +0000 (15:55 +0000)]
Export JSObject::s_info from JavaScriptCore.dll

This matches what we do for all other ClassInfo objects that WebCore needs access to.

Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows

Reviewed by Sam Weinig.

* runtime/JSObject.h: Added JS_EXPORTDATA to s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 21 Feb 2011 15:03:28 +0000 (15:03 +0000)]
2011-02-21  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Optimize editing updates in gutter panel
        https://bugs.webkit.org/show_bug.cgi?id=54866

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.set startEditingListener):
        (WebInspector.TextViewer.prototype.set endEditingListener):
        (WebInspector.TextViewer.prototype.endUpdates):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed the change log entry for r79219.
rniwa@webkit.org [Mon, 21 Feb 2011 14:44:38 +0000 (14:44 +0000)]
Fixed the change log entry for r79219.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alexander Pavlov <apavlov@chromium.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:42:10 +0000 (14:42 +0000)]
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 21 Feb 2011 14:40:30 +0000 (14:40 +0000)]
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 21 Feb 2011 14:38:24 +0000 (14:38 +0000)]
2011-02-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: create and destroy DOM agent along with InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54875

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
        on this object.
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::~InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorConsoleAgent):
        (WebCore::InstrumentingAgents::setInspectorConsoleAgent):
        (WebCore::InstrumentingAgents::inspectorDOMAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMAgent):
        (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorProfilerAgent):
        (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
        (WebCore::InstrumentingAgents::inspectorResourceAgent):
        (WebCore::InstrumentingAgents::setInspectorResourceAgent):
        (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::inspectorStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorStorageAgent):
        (WebCore::InstrumentingAgents::inspectorTimelineAgent):
        (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        (WebCore::InspectorAgent::loadEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::InspectorCSSAgent):
        (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::clearFrontend):
        (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached.
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end
        is attached.
        (WebCore::InspectorDOMAgent::clearFrontend):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 14:33:24 +0000 (14:33 +0000)]
2011-02-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79029.
        http://trac.webkit.org/changeset/79029
        https://bugs.webkit.org/show_bug.cgi?id=54869

        Revert unnecessary Chromium rebaseline (Requested by apavlov
        on #webkit).

        * platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 14:29:44 +0000 (14:29 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] After r79130, spell tests did not work
        https://bugs.webkit.org/show_bug.cgi?id=54860

        * WebCoreSupport/TextCheckerClientEnchant.cpp:
        (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided
        freeing the default PangoLanguage.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Initialized list of dictionaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:16:18 +0000 (14:16 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:07:24 +0000 (14:07 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Remove incorrect Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 13:27:42 +0000 (13:27 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 13:10:15 +0000 (13:10 +0000)]
2011-02-21  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Switched to compiler based detection, where the error actually is.

        It is not the platform that needs the workaround, it is the compiler.

        QtWebKit fails to compile on Windows XP with msvc-2008
        https://bugs.webkit.org/show_bug.cgi?id=54746

        * bytecode/CodeBlock.h:
        * runtime/RegExpObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8]REGRESSION(r79157): Fix build
ossy@webkit.org [Mon, 21 Feb 2011 13:05:15 +0000 (13:05 +0000)]
[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871

Reviewed by Andreas Kling.

* bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 21 Feb 2011 11:49:41 +0000 (11:49 +0000)]
2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added checks for exceptions and empty handles:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::Serializer::Serializer):
        (WebCore::Serializer::serialize):
        (WebCore::Serializer::checkException):
        (WebCore::Serializer::reportFailure):
        (WebCore::Serializer::ArrayState::advance):
        (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::Serializer::AbstractObjectState::advance):
        (WebCore::Serializer::push):
        (WebCore::Serializer::handleError):
        (WebCore::Serializer::newObjectState):
        (WebCore::Serializer::doSerialize):
        (WebCore::SerializedScriptValue::SerializedScriptValue):

2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added an exception throwing test case:
        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 11:24:41 +0000 (11:24 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added a test to ensure WebKit fires selectionchange event for the correct document
        when the document has an iframe, and a test to ensure selectionchange events are fired
        on user-initiated events.

        * fast/events/selectionchange-iframe-expected.txt: Added.
        * fast/events/selectionchange-iframe.html: Added.
        * fast/events/selectionchange-user-initiated-expected.txt: Added.
        * fast/events/selectionchange-user-initiated.html: Added.
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
        This event is not cancelable and does not bubble. An event listener can be attached to a document by
        body element's onselectionchange attribute or via document's onselectionchange property.

        Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
        fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
        will not observe the event before the control returns to JavaScript.

        See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx

        Tests: fast/events/selectionchange-iframe.html
               fast/events/selectionchange-user-initiated.html

        * dom/Document.cpp:
        (WebCore::Document::enqueueDocumentEvent): Added.
        * dom/Document.h: Added selectionchange event listener.
        * dom/Document.idl: Added onselectionchagne attribute.
        * dom/EventNames.h: Added selectionchange
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Fires selectionchange event.
        * html/HTMLAttributeNames.in: Added onselectionchange.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 11:20:48 +0000 (11:20 +0000)]
Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

* platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html
and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 21 Feb 2011 11:16:36 +0000 (11:16 +0000)]
2011-02-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=54859

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 11:12:51 +0000 (11:12 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
        https://bugs.webkit.org/show_bug.cgi?id=54638

        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
        (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack):
        (initialize_DebuggerTest.InspectorTest.waitUntilResumed):
        (initialize_DebuggerTest.InspectorTest.resumeExecution):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath):
        (initialize_DebuggerTest.InspectorTest.expandProperties):
        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
        (initialize_ElementTest.InspectorTest.nodeWithId):
        (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback):
        (initialize_ElementTest.InspectorTest.selectNodeWithId):
        (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback):
        (initialize_ElementTest.InspectorTest.expandElementsTree):
        (initialize_ElementTest):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
        (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
        (initialize_InspectorTest.InspectorTest.reloadPage):
        (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):
        (initialize_InspectorTest.InspectorTest.runTestSuite.runner):
        (initialize_InspectorTest.InspectorTest.runTestSuite):
        (initialize_InspectorTest.InspectorTest.safeWrap):
        * http/tests/inspector/resource-parameters.html:
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/debugger/dom-breakpoints-expected.txt:
        * inspector/debugger/dom-breakpoints.html:
        * inspector/extensions/extensions-audits-tests.js:
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 11:03:19 +0000 (11:03 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: generate protocol documentation based on IDL.
        https://bugs.webkit.org/show_bug.cgi?id=54822

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 10:55:52 +0000 (10:55 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Fixed typo in gtk Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 10:40:45 +0000 (10:40 +0000)]
Unreviewed.

[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863

Paper over one more regression to make Qt buildbot happy and green.

* platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 21 Feb 2011 10:19:43 +0000 (10:19 +0000)]
2011-02-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
        https://bugs.webkit.org/show_bug.cgi?id=54747

        * media/audio-delete-while-slider-thumb-clicked.html: Autoplay the
        media element and trigger the seek after playback started.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
philn@webkit.org [Mon, 21 Feb 2011 10:12:29 +0000 (10:12 +0000)]
2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add URI queries support in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54627

        This allow replying to URI queries from downstream elements
        with the uri currently set in the source element.

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 10:11:15 +0000 (10:11 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 09:58:54 +0000 (09:58 +0000)]
Unreviewed.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.

* platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
* platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
philn@webkit.org [Mon, 21 Feb 2011 09:33:16 +0000 (09:33 +0000)]
2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add 'location' property in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54628

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_class_init):
        (webKitWebSrcSetProperty):
        (webKitWebSrcGetProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 09:28:48 +0000 (09:28 +0000)]
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node().
        (WebKit::WebViewImpl::confirmComposition): Ditto.
        (WebKit::WebViewImpl::textInputType):
        (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * webkit/webkitwebview.cpp:
        (webkit_web_view_popup_menu_handler):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
        calls were of the form node()->document() and node()->inDocument() in which case they were
        replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.

        * WebCore.exp.in: Added Position::containerNode.

        The rest abbreviated for simplicity. Please see svn log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 09:00:14 +0000 (09:00 +0000)]
2011-02-21 MORITA Hajime  <morrita@google.com>

        Another unreviewed attempt to expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 08:16:40 +0000 (08:16 +0000)]
2011-02-20  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add WebResourceCacheDataManager to the compilation after r78848
        https://bugs.webkit.org/show_bug.cgi?id=54732

        Added resource cache manager API to GTK+ compilation after r78848.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 08:12:08 +0000 (08:12 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update. (Removes invalid lines.)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 07:26:45 +0000 (07:26 +0000)]
2011-02-20 MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-16 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:21:32 +0000 (07:21 +0000)]
2011-02-16  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        keyboard support for extending/shrinking comment context
        https://bugs.webkit.org/show_bug.cgi?id=54612

        ctrl+shift+up/down will extend/shrink the comment context when
        a comment is focused or when one is being edited.

        Also, switch over to using keydown instead of keypress events.
        This lets us share code for handling escape and other key events.
        Also, keypress is evil and should die.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:09:28 +0000 (07:09 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Recommit accidental revert.
        r79180 accidentally revereted r79178.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:04:03 +0000 (07:04 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] add more help information
        https://bugs.webkit.org/show_bug.cgi?id=54847

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 06:46:05 +0000 (06:46 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use 'r' to focus the review select element
        https://bugs.webkit.org/show_bug.cgi?id=54845

        This allows for quick keyboard access to the toolbar items.
        Hit r to get to the review select element. Then you can
        tab to the cq/preview/publish elements.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79186 268f45cc-cd09-0410-ab3c-d52691b4dbfc