adamk@chromium.org [Fri, 2 Mar 2012 23:49:11 +0000 (23:49 +0000)]
Unreviewed gardening, widen flaky crash expectations for FileWriter test.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 23:42:44 +0000 (23:42 +0000)]
Unreviewed rebaselining, update a bunch of old results for Snow Leopard.
* platform/chromium-linux/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/text_transform-expected.txt: Added.
* platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/canvas/arc360-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/transform-default-parameter-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.txt.
* platform/chromium-mac-snowleopard/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
* platform/chromium-mac-snowleopard/fonts/monospace-expected.png: Added.
* platform/chromium-mac-snowleopard/transitions/move-after-transition-expected.png: Added.
* platform/chromium-mac/fast/dom/scroll-reveal-left-overflow-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 2 Mar 2012 23:34:36 +0000 (23:34 +0000)]
Unreviewed test fix. Don't add an event listener for interactive debugging
when the test is ran inside a DumpRenderTree / WebKitTestRunner.
* editing/selection/select-line-break-with-opposite-directionality.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109623
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 2 Mar 2012 23:24:17 +0000 (23:24 +0000)]
Fix a ChangeLog typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109622
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 2 Mar 2012 23:23:28 +0000 (23:23 +0000)]
Remove com.apple.WebKit.PluginProcess.sb from WebKit2.xcodeproj's Headers build phase
https://bugs.webkit.org/show_bug.cgi?id=80197
Reviewed by Alexey Proskuryakov.
It doesn't belong there, and it makes the Xcode consider the project to
be invalid, triggering assertions in some builds of Xcode.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109621
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 23:10:32 +0000 (23:10 +0000)]
Make webkit-gtk translations respect LINGUAS
https://bugs.webkit.org/show_bug.cgi?id=79605
Patch by Alexandre Rostovtsev <tetromino@gentoo.org> on 2012-03-02
Reviewed by Martin Robinson.
.:
PO_LINGUAS, USER_LINGUAS, and USE_LINGUAS added to root
GNUmakefile.am to ensure that they can be used in the definition of
MOFILES that will be generated by automake.
* GNUmakefile.am:
Source/WebKit/gtk/po:
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109620
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Fri, 2 Mar 2012 22:48:03 +0000 (22:48 +0000)]
Implement NamedNodeMap::setNamedItem() in terms of Element::setAttributeNode() instead of the other way round
https://bugs.webkit.org/show_bug.cgi?id=80188
Reviewed by Ryosuke Niwa.
Using setNamedItem() in setAttributeNode() implementation made us do unnecessary
checks like whether the element existed or whether the given node was an
attribute. So now setAttributeNode() do less work.
No new tests were added, functionality should be unchanged.
* dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::setAttributeNodeNS):
* dom/Element.h:
(Element):
(WebCore::Element::attributes): We got rid of ensureUpdatedAttributes(), next in
line will be updatedAttributes().
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109619
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 22:44:46 +0000 (22:44 +0000)]
Expected results updated for checking type conversion
https://bugs.webkit.org/show_bug.cgi?id=80138
Patch by Han Hojong <hojong.han@samsung.com> on 2012-03-02
Reviewed by Gavin Barraclough.
* tests/mozilla/ecma/TypeConversion/9.3.1-3.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109618
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 22:41:35 +0000 (22:41 +0000)]
Unreviewed, rolling out r109602.
http://trac.webkit.org/changeset/109602
https://bugs.webkit.org/show_bug.cgi?id=80194
some TEXT baselines were wrong and some baselines were wrongly
removed (Requested by jchaffraix on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-02
* platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Removed.
* platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Removed.
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
* platform/chromium-mac/fast/clip/008-expected.png: Added.
* platform/chromium-mac/fast/clip/011-expected.png: Added.
* platform/chromium-mac/fast/clip/012-expected.png: Added.
* platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Removed.
* platform/chromium-win/fast/clip/008-expected.txt:
* platform/chromium-win/fast/clip/011-expected.txt:
* platform/chromium-win/fast/clip/012-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/mac/fast/repaint/subtree-root-clip-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt.
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt.
* platform/qt/fast/repaint/subtree-root-clip-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109617
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 22:34:48 +0000 (22:34 +0000)]
Unreviewed gardening. Widen/correct a few chromium expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109616
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 2 Mar 2012 22:25:27 +0000 (22:25 +0000)]
DOM tests take too long to run
https://bugs.webkit.org/show_bug.cgi?id=80082
Reviewed by Eric Seidel.
Reduce benchmark.timeToRun from 500ms to 100ms. Doesn't seem to affect test results much
(except DOM/DOMTable.html) but significantly reduces the runtime of tests.
* DOM/resources/dom-perf.js:
(BenchmarkSuite.prototype.RunSingle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109615
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 22:16:36 +0000 (22:16 +0000)]
Rebaseline an inspector test after r109599.
"evt" was changed to "event", lengthening it by two characters.
Unreviewed gardening.
* platform/chromium/inspector/debugger/debugger-scripts-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109614
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 2 Mar 2012 22:00:13 +0000 (22:00 +0000)]
Add the Chromium Lion canary bot to the flakiness dashboard.
* TestResultServer/static-dashboards/builders.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109613
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 2 Mar 2012 21:59:06 +0000 (21:59 +0000)]
Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684
Patch by SravanKumar Sandela <ssandela@innominds.com> on 2012-03-02
Reviewed by Dirk Pranke.
Source/WebCore:
The clipping logic for legend element was incorrect and now it has been corrected by taking correct offset in to consideration.
Test: fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
LayoutTests:
* fast/forms/fieldset-legend-padding-unclipped-fieldset-border.html: Added.
Test case to check un-clipped border logic
* platform/chromium/test_expectations.txt:
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added.
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109612
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Fri, 2 Mar 2012 21:45:10 +0000 (21:45 +0000)]
[V8] Bindings for node always check if they are a Document.
https://bugs.webkit.org/show_bug.cgi?id=79947
Reviewed by Adam Barth.
This changes the generated bindings code to only generate the Document code for the Document wrappers.
No new tests. Covered by existing tests.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateToV8Converters):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109611
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
igor.o@sisa.samsung.com [Fri, 2 Mar 2012 21:40:54 +0000 (21:40 +0000)]
animation-timing-function falls back to ease when overriding animation-name
https://bugs.webkit.org/show_bug.cgi?id=71623
Source/WebCore:
In this patch the animation name needs to be the first value declared, if
a different value is found, we do not check for the animation name again.
Reviewed by Dean Jackson.
Test: animations/animation-shorthand-overriding.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseAnimationShorthand):
LayoutTests:
Add a test to verify if the override the animation-name property works when the parent
animation did not set the animation name.
Reviewed by Dean Jackson.
* animations/animation-shorthand-overriding-expected.txt: Added.
* animations/animation-shorthand-overriding.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109610
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 2 Mar 2012 21:37:11 +0000 (21:37 +0000)]
[GTK] [AC] Connect WebGL to the TextureMapperGL code
https://bugs.webkit.org/show_bug.cgi?id=78968
Reviewed by Gustavo Noronha Silva.
No new tests. This is covered by existing accelerated compositing and
WebGL tests.
Rely on the shared version of GL acquisition from GLContext. This reduces
a lot of code and now allows us to connect WebGL into the accelerated compositing
rendering path.
* GNUmakefile.list.am: GLContext should be included for all X11 builds now.
There are no longer GTK+ specific versions of GraphicsContext3D.
* platform/graphics/GraphicsContext3D.h: Add a default argument for
resolveMultisamplingIfNecessary. This will resolve the entire texture.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: GraphicsContext3D is
now responsible for creating GraphicsContext3DPrivate in the constructor.
(WebCore::GraphicsContext3D::platformLayer): Now return m_private.
* platform/graphics/cairo/GraphicsContext3DPrivate.cpp: Added.
* platform/graphics/cairo/GraphicsContext3DPrivate.h: Renamed from Source/WebCore/platform/graphics/glx/GraphicsContext3DPrivate.h.
* platform/graphics/glx/GraphicsContext3DPrivate.cpp: Removed.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Properly
handle the default argument.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Use the new default argument now.
(WebCore::GraphicsContext3D::readRenderingResults): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109609
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 2 Mar 2012 21:33:14 +0000 (21:33 +0000)]
[Qt] Fix spelling mistake in header guard
Reviewed by Noam Rosenthal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109608
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 2 Mar 2012 21:32:59 +0000 (21:32 +0000)]
[Qt] Remove deleted file from api.pro
Reviewed by Noam Rosenthal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109607
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 2 Mar 2012 21:13:19 +0000 (21:13 +0000)]
links for virtual tests are broken in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=80180
Reviewed by Ojan Vafai.
* TestResultServer/static-dashboards/flakiness_dashboard.html:
(linkHTMLToOpenWindow):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testLinkHTMLToOpenWindow): added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109606
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 2 Mar 2012 21:08:08 +0000 (21:08 +0000)]
[GTK] [AC] Generalize WindowContextGL
https://bugs.webkit.org/show_bug.cgi?id=78969
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
No new tests. This should not change functionality.
* GNUmakefile.list.am: Added new files to source list.
* platform/graphics/cairo/GLContext.h: Added. An abstraction for all GL contexts.
* platform/graphics/glx/GLContextGLX.cpp: Added. This file is composed of very little
new code, as the logic for instantiating offscreen GL contexts is copied from
GraphicsContext3DPrivate. The code duplication will be removed in a followup patch.
(WebCore::GLContext::platformContext):
* platform/graphics/gtk/GLContextGtk.cpp: Added. This includes some helper factories
for creating and caching GL contexts for GTK+ widgets.
Source/WebKit/gtk:
Use GLContext instead of WindowContextGL. Remove a few unnecessary
namespace specifiers in the implementation of AcceleratedCompositingContext.
* WebCoreSupport/AcceleratedCompositingContext.h: Now we find the GLContext
of our widget, which is cached in WebCore. Remove m_initialized as it isn't needed.
(AcceleratedCompositingContext):
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::AcceleratedCompositingContext): No longer initialize
m_initialized.
(WebKit::AcceleratedCompositingContext::glContext): Added.
(WebKit::AcceleratedCompositingContext::renderLayersToWindow): Use glContext() now.
(WebKit::AcceleratedCompositingContext::attachRootGraphicsLayer): Ditto.
(WebKit::AcceleratedCompositingContext::notifyAnimationStarted): Remove unnecessary namespace specifier.
(WebKit::AcceleratedCompositingContext::notifySyncRequired): Ditto.
(WebKit::AcceleratedCompositingContext::paintContents): Ditto.
(WebKit::AcceleratedCompositingContext::showDebugBorders): Ditto.
(WebKit::AcceleratedCompositingContext::showRepaintCounter): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109605
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Fri, 2 Mar 2012 20:58:54 +0000 (20:58 +0000)]
new baselines for Skia shadows
Unreviewed rebaselining.
* platform/chromium-win-vista/svg/css/group-with-shadow-expected.png:
* platform/chromium-win-xp/svg/css: Added.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
* platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/svg/css/group-with-shadow-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109604
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 20:54:03 +0000 (20:54 +0000)]
Unreviewed gardening. Suppress an inspector test timing out after r109561.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109603
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 2 Mar 2012 20:45:20 +0000 (20:45 +0000)]
Unreviewed Chromium rebaselining.
Those tests have consistent results with other platforms and with the expected
result so unmark and rebaseline them.
* platform/chromium-linux-x86/fast/box-shadow: Added.
* platform/chromium-linux-x86/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-linux/fast/forms/input-text-double-click-expected.txt:
* platform/chromium-mac-leopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-mac-leopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/overflow-delete-line-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/textIteratorNilRenderer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/inline-relative-positioned-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/overflow-delete-line-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-resized-overflow-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-layoutstate-transform-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/subtree-root-skipped-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.txt: Added.
* platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png: Removed.
* platform/chromium-mac/fast/clip/008-expected.png: Removed.
* platform/chromium-mac/fast/clip/011-expected.png: Removed.
* platform/chromium-mac/fast/clip/012-expected.png: Removed.
* platform/chromium-win-vista/fast/box-shadow: Added.
* platform/chromium-win-vista/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-win-xp/fast/box-shadow: Added.
* platform/chromium-win-xp/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
* platform/chromium-win/fast/clip/008-expected.txt:
* platform/chromium-win/fast/clip/011-expected.txt:
* platform/chromium-win/fast/clip/012-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/mac/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/mac/fast/repaint/subtree-root-clip-expected.txt: Removed.
* platform/qt/fast/layers/add-layer-with-nested-stacking-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-2-expected.txt: Removed.
* platform/qt/fast/repaint/subtree-root-clip-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109602
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 20:39:27 +0000 (20:39 +0000)]
Rebaselining SVG foreignObject tests after r108494.
Unreviewed gardening.
* platform/chromium-linux/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
* platform/chromium-mac-leopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.png: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-display-changes-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-display-none-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Added.
* platform/chromium-win/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109601
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Fri, 2 Mar 2012 20:34:42 +0000 (20:34 +0000)]
[chromium] Remove TRACE_EVENT from CCQuadCuller::cullOccludedQuads.
https://bugs.webkit.org/show_bug.cgi?id=80174
Reviewed by James Robinson.
Covered by existing chromium unit tests.
Firing TRACE_EVENT once per draw quad is overwhelming.
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109600
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Fri, 2 Mar 2012 20:30:59 +0000 (20:30 +0000)]
[V8] Make inline event attributes use evt for SVG and event otherwise
https://bugs.webkit.org/show_bug.cgi?id=80167
Reviewed by Ojan Vafai.
Source/WebCore:
Test: fast/dom/inline-event-attributes-event-param-name.html
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
LayoutTests:
* fast/dom/inline-event-attributes-event-param-name-expected.txt: Added.
* fast/dom/inline-event-attributes-event-param-name.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109599
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gavinp@chromium.org [Fri, 2 Mar 2012 20:11:16 +0000 (20:11 +0000)]
Sync PageCache debugging with PageCache behaviour
https://bugs.webkit.org/show_bug.cgi?id=79943
Sync up the debug printing code in PageCache with the actual logic,
and clean up the debug printing at the same time.
Reviewed by Brady Eidson.
No new tests, as this is a refactor of debug only code.
* history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109598
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 2 Mar 2012 20:07:26 +0000 (20:07 +0000)]
Fix expectation for svg/foreignObject/fO-parent-display-changes.svg.
Unreviewed, expectations change.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109597
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 20:05:29 +0000 (20:05 +0000)]
Unreviewed gardening, suppress some failures in shadow tests due to the skia roll.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109596
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 2 Mar 2012 20:01:10 +0000 (20:01 +0000)]
[chromium] Layout test fast/events/overflow-events.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=52064
Reviewed by Simon Fraser.
Try to make the test less flaky.
* fast/events/overflow-events.html:
Ensure that the 'overflow' events arrive one at a time in order (there is no guarantee that they *do* dispatch
though). Also added a clearer message if we fail the test. That should help us if the test is still flaky.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109595
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 2 Mar 2012 19:58:36 +0000 (19:58 +0000)]
Source/WebCore: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
<rdar://problem/
10432233>
Reviewed by Antti Koivisto.
Test: fast/dom/Window/navigated-window-properties.html
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore): Remove custom getters for window.location and window.history; they
were unnecessary and did the wrong thing when DOMWindow returned null values
for these.
* page/DOMWindow.idl: ditto
* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException): Remove assert about null values and update comment,
since this is now an expected state for navigated inner windows.
LayoutTests: REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
https://bugs.webkit.org/show_bug.cgi?id=80133
Reviewed by Antti Koivisto.
* fast/dom/Window/navigated-window-properties-expected.txt: Added.
* fast/dom/Window/navigated-window-properties.html: Added.
* fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
* fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109594
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 2 Mar 2012 19:54:39 +0000 (19:54 +0000)]
REGRESSION(r74971): Can't select a line of RTL text on Facebook
https://bugs.webkit.org/show_bug.cgi?id=59435
Reviewed by Eric Seidel.
Source/WebCore:
The bug was caused by inline text boxes created by BRs being placed at the end of the line
according to the block's direction regardless of its unicode bidi-level. e.g. if we have
<div dir="rtl"><span dir="ltr">hello<br>world</span></div>
the inline box generated by the br has the bidi-level of 2 like the rest of text in the span.
This inline text box gives an illusion of having text on the left of "hello" to hit testing
and editing code and causes all sorts of problems.
Fixed the bug by replacing calls to nextLeafChild and prevLeafChild by newly introduced
nextLeafChildIgnoringLineBreak and prevLeafChildIgnoringLineBreak. These two functions will
return 0 when they hit the end of a line or inline text box that's a line break. In effect,
hit testing and editing code can ignore inline boxes generated by br's.
In the long term, we should move these two functions into RenderedPosition along with the rest
of code that converts a Position and an inline box, offset pair.
Test: editing/selection/select-line-break-with-opposite-directionality.html
* dom/Position.cpp:
(WebCore::Position::getInlineBoxAndOffset):
* editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::prevLeafChild):
(WebCore::RenderedPosition::nextLeafChild):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nextLeafChildIgnoringLineBreak):
(WebCore::InlineBox::prevLeafChildIgnoringLineBreak):
* rendering/InlineBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
* rendering/RenderText.cpp:
(WebCore::lineDirectionPointFitsInBox): If we're on the left of a RTL line, we should stay at
upstream position since we're at the end of a line.
(WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi): Merge the two special cases into
the general loop as the comment suggests. Skip an inline text box for a line break at the left
edge when there are more line boxes on the line.
(WebCore::RenderText::positionForPoint):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition): Ignore line boxes created for
line boxes when there are other boxes on the line.
LayoutTests:
Add a regression test for selecting multiline bidirectional text.
* editing/selection/select-line-break-with-opposite-directionality-expected.txt: Added.
* editing/selection/select-line-break-with-opposite-directionality.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109593
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 19:48:17 +0000 (19:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=80161
PR: 141157
BlackBerryPlatformScreen.h API has been updated. Reflect those
changes in our usage.
Source/WebCore:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenAvailableRect):
(WebCore::screenRect):
Source/WebKit/blackberry:
Patch by Adam Treat <atreat@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Internally reviewed by Jakob Petsovits.
* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::tileWidth):
(BlackBerry::WebKit::BackingStorePrivate::tileHeight):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::transformedViewportSize):
(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::defaultMaxLayoutSize):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::createCompositingSurface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109592
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 19:47:59 +0000 (19:47 +0000)]
Chromium rebaselines after r109512.
Unreviewed gardening.
* platform/chromium-linux/fast/block/float/026-expected.png:
* platform/chromium-linux/fast/block/float/028-expected.png:
* platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
* platform/chromium-mac-leopard/fast/block/float/026-expected.png:
* platform/chromium-mac-leopard/fast/block/float/028-expected.png:
* platform/chromium-mac-leopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/026-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/026-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/028-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/028-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Renamed from LayoutTests/platform/chromium/fast/events/offsetX-offsetY-expected.txt.
* platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Added.
* platform/chromium-mac/fast/block/float/026-expected.png: Removed.
* platform/chromium-mac/fast/block/float/028-expected.png: Removed.
* platform/chromium-win/fast/block/float/026-expected.png:
* platform/chromium-win/fast/block/float/026-expected.txt:
* platform/chromium-win/fast/block/float/028-expected.png:
* platform/chromium-win/fast/block/float/028-expected.txt:
* platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
* platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
* platform/chromium-win/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 19:44:57 +0000 (19:44 +0000)]
[Chromium] Allow plugins to set opaque() on their platform layer
https://bugs.webkit.org/show_bug.cgi?id=80171
Patch by Dana Jansens <danakj@chromium.org> on 2012-03-02
Reviewed by James Robinson.
* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit):
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109590
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 2 Mar 2012 19:41:32 +0000 (19:41 +0000)]
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Unreviewed build fix.
* rendering/RenderBlock.cpp:
(OverflowEventDispatcher): Removed the unused function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caryclark@google.com [Fri, 2 Mar 2012 19:28:53 +0000 (19:28 +0000)]
Unreviewed rebaselining of images affected by these changes:
https://bugs.webkit.org/show_bug.cgi?id=76556 ('Match style of platform error underline for misspellings')
https://bugs.webkit.org/show_bug.cgi?id=78117 ('[Skia Mac] Make misspelling underline dots unclipped')
* platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png:
[139 lines deleted]
* platform/chromium-mac-snowleopard/fast/dom/blur-contenteditable-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 2 Mar 2012 19:24:18 +0000 (19:24 +0000)]
Move the 'overflow' event dispatching logic out of RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=80090
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/events/overflow-events-writing-mode.html
This moves the 'overflow' event dispatch from RenderLayer to an helper class
OverflowEventDispatcher. For now, the class lives in RenderBlock as it matches
the existing code but it may be moved later to its own class as FrameView could
benefit from it too or if we need to support 'overflow' events on RenderBoxes.
* rendering/RenderBlock.cpp:
(WebCore):
(OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
(WebCore::OverflowEventDispatcher::computeOverflowStatus):
RAII dispatcher class that stores the information before layout and compare
them after to dispatch the right information.
(WebCore::RenderBlock::layout): Added an instance of OverflowEventDispatcher.
* rendering/RenderBox.h:
(WebCore::RenderBox::hasHorizontalLayoutOverflow):
(WebCore::RenderBox::hasVerticalLayoutOverflow):
Helper method to know if we have an horizontal / vertical layout overflow.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
Removed the scroll tracking logic as we don't need it anymore. This removes
3 booleans from RenderLayer.
LayoutTests:
* fast/events/overflow-events-writing-mode.html: Added.
* fast/events/overflow-events-writing-mode-expected.txt: Added.
Added a test for overflow events in a vertical writing mode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Fri, 2 Mar 2012 19:05:52 +0000 (19:05 +0000)]
Rebaseline a test on Leopard after expectation was removed in r109516.
Unreviewed gardening.
* platform/chromium-mac-leopard/fast/repaint/transform-absolute-in-positioned-container-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Fri, 2 Mar 2012 19:02:04 +0000 (19:02 +0000)]
Create a method in Element to compare attributes with other Element
https://bugs.webkit.org/show_bug.cgi?id=80169
Reviewed by Ryosuke Niwa.
Avoid manually peeking at attribute storage to get this information. This
simplify the callsites. The actual implementation of comparison was moved to
ElementAttributeData. The mapsEquivalent() function still exists for the sake
of DocumentType nodes.
* dom/Element.cpp:
(WebCore::Element::hasEquivalentAttributes):
(WebCore):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::isEquivalent):
(WebCore):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::mapsEquivalent):
* dom/Node.cpp:
(WebCore::Node::isEqualNode):
* editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Use Element::hasTagName() instead of matching
directly to make code a bit clearer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 18:03:59 +0000 (18:03 +0000)]
[GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-03-02
Reviewed by Martin Robinson.
Source/WebCore:
No new tests - no new functionality.
Add the ScrollAnimatorNone class to compilation and enable
the smooth scrolling feature by default at compilation time.
* GNUmakefile.am:
* GNUmakefile.list.am:
Source/WebKit/gtk:
Add a new settings option to enable smooth scrolling.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 17:40:16 +0000 (17:40 +0000)]
[BlackBerry] Set the devicePixelRatio from the results of computeViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=80160
Patch by Konrad Piascik <kpiascik@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Tested by going to layout test fast/viewport/viewport-95.html and viewport-93.html
Previously when executing window.devicePixelRatio these two pages returned 1 now
they report the devicePixelRatio returned by computeViewportAttributes.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 16:55:52 +0000 (16:55 +0000)]
Unreviewed, GTK rebaseline after r109581.
* platform/gtk/security/block-test-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 16:45:36 +0000 (16:45 +0000)]
[GTK] security/block-test.html baselines differ from mac
https://bugs.webkit.org/show_bug.cgi?id=78343
Reviewed by Martin Robinson.
Tools:
Improved the FrameLoader error heuristics to match mac behavior a
bit more.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(pathFromSoupURI): Handle ftp urls the same as http urls.
(descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
LayoutTests:
GTK baselines updates for two security tests. They're closer to
the mac baselines now.
* platform/gtk/security/block-test-expected.txt: Added.
* platform/gtk/security/block-test-no-port-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 16:38:31 +0000 (16:38 +0000)]
[GStreamer] media/media-can-play-flac-audio.html fails
https://bugs.webkit.org/show_bug.cgi?id=80124
Reviewed by Martin Robinson.
Handle audio/x-flac in the mimeTypeCache() function so that we
advertize both audio/flac and audio/x-flac.
No new tests, this is covered already by media/media-can-play-flac-audio.html.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 2 Mar 2012 16:30:52 +0000 (16:30 +0000)]
[GTK] Invalid check in webkit_web_view_set_zoom_level() when zoom-text-only is enabled
https://bugs.webkit.org/show_bug.cgi?id=80150
Reviewed by Philippe Normand.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_zoom_level() instead of
WKPageGetPageZoomFactor() to get the current effective zoom level
depending on zoom-text-only setting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 2 Mar 2012 16:21:24 +0000 (16:21 +0000)]
Web Inspector: fix fronted compilation.
https://bugs.webkit.org/show_bug.cgi?id=80154
Reviewed by Yury Semikhatsky.
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.scriptForSourceID):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 2 Mar 2012 15:36:23 +0000 (15:36 +0000)]
[Qt][WK2] Fix typo in patch committed in r109575
Unreviewed typo fix.
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify): Cache the position
in floating point coordinates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 2 Mar 2012 15:27:33 +0000 (15:27 +0000)]
[Qt][WK2] Infinite loop on history navigation, when panning
https://bugs.webkit.org/show_bug.cgi?id=79119
Reviewed by Simon Hausmann.
Make the touch mocking more robust by creating touch events
directly and sending them synchronously to the browser window.
If the sent touch event was not accepted we propagate the
original mouse event to its target.
This way we make sure we only send either a touch or a mouse
event and do not end up in an infinite loop between our mocking
code and the Qt5 automatic mouse event synthesizing.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(touchRectForPosition):
(MiniBrowserApplication::notify):
(MiniBrowserApplication::sendTouchEvent):
* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 15:14:47 +0000 (15:14 +0000)]
Rename DOMURL to URL in the bindings
https://bugs.webkit.org/show_bug.cgi?id=78214
Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-03-02
Reviewed by Kentaro Hara.
Source/WebCore:
No new tests. Interface name change.
* html/DOMURL.idl: Added InterfaceName attribute to DOMURL.
LayoutTests:
* fast/files/domurl-script-execution-context-crash-expected.txt:
* fast/files/domurl-script-execution-context-crash.html:
* fast/js/constructor-length.html:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 2 Mar 2012 14:26:12 +0000 (14:26 +0000)]
Add :scope pseudo-class
https://bugs.webkit.org/show_bug.cgi?id=79077
Source/WebCore:
Add :scope pseudo class name & pseudoId
Add selector check for the new pseudo-class
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/scope-pseudo.html
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
LayoutTests:
Test new :scope pseudo-class
Reviewed by Antti Koivisto.
* fast/css/style-scoped/scope-pseudo-expected.txt: Added.
* fast/css/style-scoped/scope-pseudo.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 14:25:38 +0000 (14:25 +0000)]
[Qt] Documentation cleanup
https://bugs.webkit.org/show_bug.cgi?id=80131
Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-03-02
Reviewed by Simon Hausmann.
QDoc uses different commands to do bold, lists, and italics.
This change updates the documentation accordingly.
QTBUG-24578
* Api/qwebframe.cpp:
* Api/qwebhistory.cpp:
* Api/qwebinspector.cpp:
* Api/qwebpage.cpp:
* Api/qwebpluginfactory.cpp:
* Api/qwebsettings.cpp:
* declarative/qdeclarativewebview.cpp:
* docs/qtwebkit-bridge.qdoc:
* docs/qtwebkit.qdoc:
* docs/qtwebkit.qdocconf:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 2 Mar 2012 14:16:13 +0000 (14:16 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Fri, 2 Mar 2012 14:07:59 +0000 (14:07 +0000)]
Make parser code not depend on NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=79963
Reviewed by Adam Barth.
Source/WebCore:
Instead of creating Element-less NamedNodeMaps, the parsing code now creates
AttributeVectors, that are used to fill Element via the parserSetAttributes()
method. This allows us to remove even more methods from the NamedNodeMap.
The AttributeVector class contains convenience methods that take the attribute's
QualifiedName as parameter. This class is also used inside ElementAttributeData.
* dom/Attr.h:
(Attr):
* dom/Element.cpp:
(WebCore::Element::getAttribute):
(WebCore::Element::parserSetAttributes): Now we have to create the attribute
storage, and fill it (by Vector::swap()) with the passed attributes. Also use an
early return to reduce indentation.
(WebCore::Element::insertedIntoDocument):
(WebCore::Element::removedFromDocument):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
* dom/Element.h:
(Element):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
* dom/ElementAttributeData.cpp:
(WebCore::AttributeVector::removeAttribute):
(WebCore):
* dom/ElementAttributeData.h:
(AttributeVector):
(WebCore::AttributeVector::create):
(WebCore::AttributeVector::attributeItem):
(WebCore::AttributeVector::AttributeVector):
(WebCore):
(WebCore::AttributeVector::getAttributeItem):
(WebCore::AttributeVector::getAttributeItemIndex):
(WebCore::AttributeVector::insertAttribute): Boolean parameter isn't necessary
since all the callers used 'false', indicating that duplicates were not allowed.
(WebCore::ElementAttributeData::attributeItem):
(WebCore::ElementAttributeData::getAttributeItem):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::mapsEquivalent):
* dom/NamedNodeMap.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
(WebCore):
* html/parser/HTMLTreeBuilder.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::attributes):
(WebCore::AtomicMarkupTokenBase::takeAttributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processNamespaces):
(WebCore::XMLTreeBuilder::processAttributes):
Source/WebKit/chromium:
* src/WebNamedNodeMap.cpp:
(WebKit::WebNamedNodeMap::attributeItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 2 Mar 2012 13:53:27 +0000 (13:53 +0000)]
[Qt] Use 'all' as default target when debug_and_release is in effect
When debug_and_release is enabled, in combination with build_all,
qmake will generate an aggregate makefile that calls make on both
the debug and the release makefiles, but with the 'all' target.
In this case we can't use 'first' as the default target, as the
extra targets would then not be run, so we append extra targets
to 'all' instead.
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 2 Mar 2012 13:48:58 +0000 (13:48 +0000)]
Web Inspector: assertion failure in JSMainThreadExecState::instrumentedCall
https://bugs.webkit.org/show_bug.cgi?id=80152
Extracted common code of JS call instrumentation into instrumentFunctionCall method
and call it directly where the instrumentation is needed instead of calling
JSMainThreadExecState::instrumentedCall which works on the main thread only.
Reviewed by Pavel Feldman.
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::instrumentFunctionCall):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 2 Mar 2012 13:46:48 +0000 (13:46 +0000)]
[Qt] Make sure activeBuildConfig() returns the right config
Using isActiveConfig fails, as that only checks if the given
argument is in CONFIG, not the order.
Reviewed by Simon Hausmann.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 2 Mar 2012 13:35:20 +0000 (13:35 +0000)]
[Qt] Unreviewed gardening, update expected files.
* platform/qt/Skipped: Unskip non-existent files.
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.png:
* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.png:
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 13:31:39 +0000 (13:31 +0000)]
[Forms] Make order of attribute/method in HTMLTextAreaElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80101
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
* html/HTMLTextAreaElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Fri, 2 Mar 2012 13:30:24 +0000 (13:30 +0000)]
Build fix after r109538.
* CMakeLists.txt:
* Modules/websockets/WebSocketDeflater.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 2 Mar 2012 13:27:22 +0000 (13:27 +0000)]
Scoped stylesheets don't appear to work in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=79549
Source/WebCore:
Make the scope stack in CSSStyleSelector use ContainerNode* instead of Element*.
Adapt using sites accordingly.
Push the ShadowRoot to the scope stack in the same way that elements are pushed.
Fix an issue with removedFromDocument() on destruction.
Reviewed by Antti Koivisto.
Test: fast/css/style-scoped/style-scoped-in-shadow.html
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::determineScope):
(WebCore::CSSStyleSelector::ruleSetForScope):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::CSSStyleSelector::setupScopeStack):
(WebCore::CSSStyleSelector::pushScope):
(WebCore):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::pushParentElement):
(WebCore::CSSStyleSelector::popParentElement):
(WebCore::CSSStyleSelector::pushParentShadowRoot):
(WebCore::CSSStyleSelector::popParentShadowRoot):
(WebCore::CSSStyleSelector::matchScopedAuthorRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
(WebCore::CSSStyleSelector::pushScope):
(WebCore::CSSStyleSelector::popScope):
(WebCore::CSSStyleSelector::MatchOptions::MatchOptions):
(MatchOptions):
(WebCore::CSSStyleSelector::scopeStackIsConsistent):
(WebCore::CSSStyleSelector::ScopeStackFrame::ScopeStackFrame):
(ScopeStackFrame):
* css/SelectorChecker.h:
(SelectorCheckingContext):
* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::push):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
(WebCore):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Test that <style scoped> works in shadow DOM as direct child of the ShadowRoot
Reviewed by Antti Koivisto.
* fast/css/style-scoped/style-scoped-in-shadow-expected.txt: Added.
* fast/css/style-scoped/style-scoped-in-shadow.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 13:24:36 +0000 (13:24 +0000)]
[Forms] Make order of attribute/method in HTMLSelectElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80097
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kent Tamura.
No new tests. No behavior changes.
* html/HTMLSelectElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 2 Mar 2012 13:22:12 +0000 (13:22 +0000)]
Web Inspector: limit RawSourceCode usages to DebuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=80146
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.uiLocationToRawLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchResultsPane.prototype.createAnchor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 2 Mar 2012 13:15:09 +0000 (13:15 +0000)]
Web Inspector: update execution line using LiveLocation.
https://bugs.webkit.org/show_bug.cgi?id=80143
Reviewed by Vsevolod Vlasov.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeListChanged):
(WebInspector.DebuggerPresentationModel.prototype._debuggerResumed):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame.updateExecutionLine):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Fri, 2 Mar 2012 12:59:36 +0000 (12:59 +0000)]
[BlackBerry] Build fix for LocalizedStringsBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=80099
Unreviewed build fix.
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 2 Mar 2012 12:58:24 +0000 (12:58 +0000)]
Fix build on AppleWebKit after 109548.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Source/WebCore:
* WebCore.exp.in:
Source/WebKit2:
* mac/WebKit2.order:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 12:47:58 +0000 (12:47 +0000)]
[Forms] Make order of attribute/method in HTMLOptionElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80095
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
* html/HTMLOptionElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 2 Mar 2012 12:45:46 +0000 (12:45 +0000)]
WorkerContext shouldn't know about IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=80094
Reviewed by Kentaro Hara.
There are still a couple IndexedDB stragglers we should clean up in
WebCore proper. This patch moves some IndexedDB logic from
WorkerContext into the indexeddb module.
In the process of writing this patch, I noticed that some IndexedDB
files were missing from various build systems, so I added them. I
suspect that means IndexedDB is only enabled by default on Chromium.
* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/indexeddb/WorkerContextIndexedDatabase.cpp: Added.
(WebCore):
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::~WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
(WebCore::WorkerContextIndexedDatabase::webkitIndexedDB):
* Modules/indexeddb/WorkerContextIndexedDatabase.h: Added.
(WebCore):
(WorkerContextIndexedDatabase):
* Modules/indexeddb/WorkerContextIndexedDatabase.idl: Added.
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WebCore):
(WorkerContext):
* workers/WorkerContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 2 Mar 2012 12:45:05 +0000 (12:45 +0000)]
[Qt] Fix tests run with WTR not using QStyle theme
https://bugs.webkit.org/show_bug.cgi?id=80147
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
Use an environment variable (set by WTR) to select the QStyle theme.
This is a temporary kludge until we rebase the layout tests to use the
QStyle independent "mobile" theme. This also temporarily breaks the
force_static_libs_as_shared build.
* Target.pri:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
Tools:
* WebKitTestRunner/qt/main.cpp:
(main): Set environment variable for web process to use QStyle theme.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 12:29:06 +0000 (12:29 +0000)]
Tools: Unreviewed, remove debug print call.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(descriptionSuitableForTestResult):
LayoutTests: Unreviewed, unskip security/block-test.html and remove its GTK
baseline, the platform-agnostic baseline match.
* platform/gtk/Skipped:
* platform/gtk/security/block-test-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 2 Mar 2012 12:23:20 +0000 (12:23 +0000)]
[Qt] Unreviewed gardening, update expected files.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 2 Mar 2012 12:16:39 +0000 (12:16 +0000)]
[Qt] Compile WebCore without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=80141
Reviewed by Tor Arne Vestbø.
.:
* Source/api.pri: Use QT += opengl for the WebKit1 bits, such as the QGLWidget
usage in PageClientQt.cpp. Previously this dependency came implicitly through WebCore.pri.
Source/WebCore:
* Target.pri: Don't add widgets to QT.
* WebCore.pri: Use QT += opengl only with Qt 4, because it has an implicit QtWidgets
dependency. With Qt 5 all necessary OpenGL API is part of QtGui (with a QOpenGL* prefix).
Source/WebKit2:
* Shared/qt/WebEventFactoryQt.cpp: Removed unnecessary include.
* Target.pri: Require widgets for WK2 for the moment, until bug #79458
is fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 11:57:06 +0000 (11:57 +0000)]
[Forms] Make order of attribute/method in HTMLFormElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80093
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes
* html/HTMLFormElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 11:54:28 +0000 (11:54 +0000)]
[Forms] Make order of attribute/method in HTMLButtonElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80091
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
* html/HTMLButtonElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 2 Mar 2012 11:43:27 +0000 (11:43 +0000)]
[Qt] Build system cleanup
Rubber-stamped by Antti Koivisto.
* tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now
that the symbols are properly exported with export macros from the DLL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Fri, 2 Mar 2012 11:40:03 +0000 (11:40 +0000)]
Suspend/Resume API for pausing timers and animations.
https://bugs.webkit.org/show_bug.cgi?id=76063
Source/WebCore:
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
* dom/ActiveDOMObject.h:
New ReasonForSuspension: PageWillBePaused.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspend): Handle new ReasonForSuspension.
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::setDocument):
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
* page/Frame.h:
(WebCore::Frame::activeDOMObjectsAndAnimationsSuspended):
Frame now maintains a state of suspending animation and ActiveDOMObjects,
which is inherited to all child-frames.
* page/Page.cpp:
(WebCore::Page::suspendActiveDOMObjectsAndAnimations):
(WebCore::Page::resumeActiveDOMObjectsAndAnimations):
* page/Page.h:
Functions for suspending and resuming active DOM objects and animations in all frames.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::willRenderImage):
WillRenderImage now checks for suspension. This causes animated images to pause
together with all other types of animations.
Source/WebKit2:
Based on the initial work of Zalan Bujtas <zalan.bujtas@nokia.com>,
Adds suspend and resume API for WebKit2 and uses it in Qt to
suspend animations and DOM timers during panning and zoom.
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-02
Reviewed by Kenneth Rohde Christiansen.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::_q_suspend):
(QQuickWebViewFlickablePrivate::_q_resume):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 11:33:04 +0000 (11:33 +0000)]
[Forms] Make order of attribute/method in HTMLFieldSetElement.idl as same as specification
https://bugs.webkit.org/show_bug.cgi?id=80092
Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-02
Reviewed by Kentaro Hara.
No new tests. No behavior changes.
* html/HTMLFieldSetElement.idl: Reorder attribute/method position.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 2 Mar 2012 11:28:14 +0000 (11:28 +0000)]
possible regression: r104060 maybe causing crashes
https://bugs.webkit.org/show_bug.cgi?id=75676
Rubber-stamped by Simon Hausmann.
Remove the speculative fix (the problem was elsewhere, http://trac.webkit.org/changeset/104845).
Also remove the debugging code added for this bug.
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::clearStyleSelector):
(WebCore::Document::updateActiveStylesheets):
* dom/Document.h:
(Document):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 2 Mar 2012 11:16:55 +0000 (11:16 +0000)]
Web Inspector: Implement suggestions in Watch Expressions
https://bugs.webkit.org/show_bug.cgi?id=79912
Source/WebCore:
Drive-by: make subproperties in ObjectPropertySections editable
Reviewed by Pavel Feldman.
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.completionsForTextPrompt):
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.renderPromptAsBlock):
(WebInspector.ObjectPropertyTreeElement.prototype.elementAndValueToEdit):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing.blurListener):
(WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
(WebInspector.ObjectPropertyTreeElement.prototype.editingEnded):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCancelled):
(WebInspector.ObjectPropertyTreeElement.prototype.editingCommitted):
(WebInspector.ObjectPropertyTreeElement.prototype._promptKeyDown):
(WebInspector.ObjectPropertyPrompt):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionTreeElement.prototype.renderPromptAsBlock):
(WebInspector.WatchExpressionTreeElement.prototype.elementAndValueToEdit):
(WebInspector.WatchExpressionTreeElement.prototype.editingCancelled):
* inspector/front-end/inspector.css:
(.watch-expressions > li.editing-sub-part .text-prompt):
LayoutTests:
Reviewed by Pavel Feldman.
* http/tests/inspector/console-cd-completions.html:
* inspector/debugger/debugger-completions-on-call-frame.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 10:55:35 +0000 (10:55 +0000)]
[EFL] Build warning : comparison between signed and unsigned integer expressions.
https://bugs.webkit.org/show_bug.cgi?id=79860
Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-03-02
Reviewed by Hajime Morita.
Fixed build warnings which are getting generated when comparing signed
and unsigned integer expressions.
* Source/WebCore/bindings/js/JSDocumentCustom.cpp:
* Source/WebCore/platform/ContextMenu.cpp:
* Source/WebKit/efl/ewk/ewk_view_single.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 2 Mar 2012 10:46:55 +0000 (10:46 +0000)]
REGRESSION (r104060): Page contents not painted if inserting a new stylesheet and temporary body node
https://bugs.webkit.org/show_bug.cgi?id=76590
Reviewed by Maciej Stachowiak.
Source/WebCore:
Test: fast/css/pending-stylesheet-repaint.html
If there has been a style recalc with a pending stylesheet, the forced repaint will need to be triggered even
if the stylesheet doesn't affect the rendering. Otherwise we may end up never painting at all.
* dom/Document.cpp:
(WebCore::Document::styleSelectorChanged):
LayoutTests:
* fast/css/pending-stylesheet-repaint-expected.png: Added.
* fast/css/pending-stylesheet-repaint-expected.txt: Added.
* fast/css/pending-stylesheet-repaint.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 2 Mar 2012 10:43:22 +0000 (10:43 +0000)]
[Qt] Move QStyle theming code out of WebCore into WebKit1
https://bugs.webkit.org/show_bug.cgi?id=80128
Reviewed by Kenneth Rohde Christiansen.
.:
* Source/api.pri: Adjust to moving source files.
Source/WebCore:
Moved QStyle dependant code into WebKit1, where it's okay to depend on
QtWidgets/QStyle. Added factory hooks into RenderThemeQt to allow changing
the default "mobile" style to QStyle on start-up.
* Target.pri:
* platform/qt/RenderThemeQt.cpp:
(WebCore):
(WebCore::RenderThemeQt::setCustomTheme):
(WebCore::RenderThemeQt::customScrollbarTheme):
(WebCore::createTheme):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
* platform/qt/RenderThemeQt.h:
(WebCore):
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
Source/WebKit/qt:
Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
Install the QStyle factory functions in initWebCoreQt.cpp.
* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
* WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
(WebCore):
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
(WebCore):
(RenderThemeQStyle):
(StylePainterQStyle):
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
* WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.
(WebCore):
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
(WebCore::scPart):
(WebCore::scrollbarPart):
(WebCore::styleOptionSlider):
(WebCore::ScrollbarThemeQStyle::paint):
(WebCore::ScrollbarThemeQStyle::hitTest):
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
(WebCore::ScrollbarThemeQStyle::invalidatePart):
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
(WebCore::ScrollbarThemeQStyle::thumbPosition):
(WebCore::ScrollbarThemeQStyle::thumbLength):
(WebCore::ScrollbarThemeQStyle::trackPosition):
(WebCore::ScrollbarThemeQStyle::trackLength):
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
(WebCore::ScrollbarThemeQStyle::style):
* WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.
(WebCore):
(ScrollbarThemeQStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Fri, 2 Mar 2012 10:40:42 +0000 (10:40 +0000)]
Handle CSSPropertyWebkitColumnRuleStyle in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80085
Reviewed by Eric Seidel.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 2 Mar 2012 10:39:04 +0000 (10:39 +0000)]
Web Inspector: enable Timeline panel for workers
https://bugs.webkit.org/show_bug.cgi?id=80130
Enabled Timeline panel for worker inspector. Refactored
JS function calls instrumentation to work for both
worker contexts and documents.
Reviewed by Pavel Feldman.
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSMainThreadExecState.h:
(WebCore):
(WebCore::JSMainThreadExecState::instrumentedCall):
* bindings/js/ScriptState.cpp:
(WebCore::scriptExecutionContextFromScriptState):
(WebCore):
* bindings/js/ScriptState.h:
(WebCore):
* bindings/v8/ScriptState.cpp:
(WebCore::ScriptState::scriptExecutionContext):
(WebCore):
(WebCore::scriptExecutionContextFromScriptState):
* bindings/v8/ScriptState.h:
(WebCore):
(ScriptState):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::instrumentedCallFunction):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::callListenerFunction):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::callFunctionWithEvalEnabled):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForNonDocumentContext):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore):
(WebCore::InspectorInstrumentation::instrumentingAgentsForContext):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
(WebCore::WorkerInspectorController::restoreInspectorStateFromCookie):
* inspector/WorkerInspectorController.h:
(WebCore):
(WorkerInspectorController):
* inspector/front-end/inspector.js:
(WebInspector._createPanels):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 10:37:16 +0000 (10:37 +0000)]
Unreviewed, GTK tests expectations update.
* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bashi@chromium.org [Fri, 2 Mar 2012 10:24:43 +0000 (10:24 +0000)]
Adding WebSocket per-frame DEFLATE extension
https://bugs.webkit.org/show_bug.cgi?id=77522
Source/JavaScriptCore:
Added USE(ZLIB) flag.
Reviewed by Kent Tamura.
* wtf/Platform.h:
Source/WebCore:
Add WebSocketDeflateFramer class which handles deflate-frame extension.
This class encapsulates WebSocketDeflater and WebSocketInflater classes,
which depend on zlib, so that WebSocketChannel is not necessary to aware
zlib dependency.
Reviewed by Kent Tamura.
Tests: http/tests/websocket/tests/hybi/compressed-control-frame.html
http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html
http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html
http/tests/websocket/tests/hybi/deflate-frame-parameter.html
* CMakeLists.txt: Added WebSocketDeflateFramer.(cpp|h)
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.gyp/WebCore.gyp: Added zlib dependency.
* WebCore.vcproj/WebCore.vcproj: Added WebSocketDeflateFramer.(cpp|h)
* WebCore.xcodeproj/project.pbxproj: Ditto.
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didConnect): Set m_extensions.
* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect): Add deflate-frame extension processor to WebSocketHanshake if deflate can use.
(WebCore::WebSocketChannel::fail): Call m_deflateFramer.didFail().
(WebCore::WebSocketChannel::processFrame): Decompress frames if needed.
(WebCore::WebSocketChannel::sendFrame): Compress frames if possible.
* websockets/WebSocketChannel.h:
* websockets/WebSocketDeflateFramer.cpp: Added.
(WebCore):
(WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::create):
(WebCore::WebSocketExtensionDeflateFrame::~WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::WebSocketExtensionDeflateFrame):
(WebCore::WebSocketExtensionDeflateFrame::handshakeString):
(WebCore::WebSocketExtensionDeflateFrame::processResponse):
(WebCore::DeflateResultHolder::DeflateResultHolder):
(WebCore::DeflateResultHolder::~DeflateResultHolder):
(WebCore::DeflateResultHolder::fail):
(WebCore::InflateResultHolder::InflateResultHolder):
(WebCore::InflateResultHolder::~InflateResultHolder):
(WebCore::InflateResultHolder::fail):
(WebCore::WebSocketDeflateFramer::WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::createExtensionProcessor):
(WebCore::WebSocketDeflateFramer::canDeflate):
(WebCore::WebSocketDeflateFramer::enableDeflate):
(WebCore::WebSocketDeflateFramer::deflate):
(WebCore::WebSocketDeflateFramer::resetDeflateContext):
(WebCore::WebSocketDeflateFramer::inflate):
(WebCore::WebSocketDeflateFramer::resetInflateContext):
(WebCore::WebSocketDeflateFramer::didFail):
* websockets/WebSocketDeflateFramer.h: Added.
(WebCore):
(DeflateResultHolder):
(WebCore::DeflateResultHolder::succeeded):
(WebCore::DeflateResultHolder::failureReason):
(InflateResultHolder):
(WebCore::InflateResultHolder::succeeded):
(WebCore::InflateResultHolder::failureReason):
(WebSocketDeflateFramer):
(WebCore::WebSocketDeflateFramer::enabled):
LayoutTests:
Added tests for WebSocket deflate-frame extension. Also updated some
tests to follow the change.
Reviewed by Kent Tamura.
* http/tests/websocket/tests/hybi/compressed-control-frame-expected.txt: Added.
* http/tests/websocket/tests/hybi/compressed-control-frame.html: Added.
* http/tests/websocket/tests/hybi/compressed-control-frame_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff-expected.txt: Added.
* http/tests/websocket/tests/hybi/deflate-frame-comp-bit-onoff.html: Added.
* http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter-expected.txt: Added.
* http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter.html: Added.
* http/tests/websocket/tests/hybi/deflate-frame-invalid-parameter_wsh.py: Added.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/deflate-frame-parameter-expected.txt: Added.
* http/tests/websocket/tests/hybi/deflate-frame-parameter.html: Added.
* http/tests/websocket/tests/hybi/deflate-frame_wsh.py: Added.
(_get_deflate_frame_extension_processor):
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
* http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header-expected.txt:
* http/tests/websocket/tests/hybi/send-file-blob_wsh.py:
(_retrieve_frame):
(web_socket_transfer_data):
* platform/efl/Skipped: Skips tests rely on zlib
* platform/qt/Skipped: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 2 Mar 2012 10:21:23 +0000 (10:21 +0000)]
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 2 Mar 2012 09:59:55 +0000 (09:59 +0000)]
Web Inspector: [InspectorIndexedDB] Show meaningful description for object store items values.
https://bugs.webkit.org/show_bug.cgi?id=79691
Reviewed by Pavel Feldman.
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyFromKey):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataGridNode.prototype.createCell):
(WebInspector.IDBDataGridNode.prototype._formatValue):
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
* inspector/front-end/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype.get subtype):
* inspector/front-end/indexedDBViews.css:
(.indexed-db-data-view .data-grid .data-container td):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column):
(.indexed-db-data-view .data-grid .data-container td.primaryKey-column div.primitive-value):
(.indexed-db-data-view .data-grid .data-container td .section .header .title):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 2 Mar 2012 09:57:25 +0000 (09:57 +0000)]
Unreviewed, mark
fast/frames/flattening/frameset-flattening-advanced.html as flaky in GTK.
* platform/gtk/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 09:50:47 +0000 (09:50 +0000)]
Updated EventSender to send complete gesture events.
https://bugs.webkit.org/show_bug.cgi?id=80075
Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-02
Reviewed by Adam Barth.
* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::gestureEvent): set additional parameters in sent events.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joone.hur@collabora.co.uk [Fri, 2 Mar 2012 09:35:49 +0000 (09:35 +0000)]
Unreviewed. Fix WebKit2 GTK+ build.
* GNUmakefile.am: allow WebKitWebProcess to link with zlib properly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 09:32:05 +0000 (09:32 +0000)]
[Chromium] Layout Test webaudio/audiobuffersource-channels.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79765
Patch by Wei James <james.wei@intel.com> on 2012-03-02
Reviewed by Chris Rogers.
Source/WebCore:
* webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::create):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
* webaudio/AudioContext.h:
(WebCore):
(AudioContext):
(WebCore::AudioContext::maxNumberOfChannels):
* webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 2 Mar 2012 09:30:00 +0000 (09:30 +0000)]
Unreviewed, gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Fri, 2 Mar 2012 09:22:37 +0000 (09:22 +0000)]
Handle CSSPropertyWebkitRegionBreakAfter, CSSPropertyWebkitRegionBreakBefore and CSSPropertyWebkitRegionBreakInside in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80066
Reviewed by Eric Seidel.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 09:20:39 +0000 (09:20 +0000)]
Implement DefaultParagraphSeparator execCommand, to let authors choose the default block element
https://bugs.webkit.org/show_bug.cgi?id=59961
Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-02
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-defaultparagraphseparator-command
Test: editing/execCommand/default-paragraph-separator.html
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(WebCore::Editor::defaultParagraphSeparator):
(WebCore::Editor::setDefaultParagraphSeparator):
(Editor):
* editing/EditorCommand.cpp:
(WebCore::executeDefaultParagraphSeparator):
(WebCore):
(WebCore::valueDefaultParagraphSeparator):
(WebCore::createCommandMap):
* editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
* html/HTMLParagraphElement.cpp:
(WebCore::HTMLParagraphElement::create):
(WebCore):
* html/HTMLParagraphElement.h:
(HTMLParagraphElement):
Added create(Document*) method that defaults to pTag as the QualifiedName.
LayoutTests:
* editing/execCommand/default-paragraph-separator-expected.txt: Added.
* editing/execCommand/default-paragraph-separator.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 2 Mar 2012 09:12:43 +0000 (09:12 +0000)]
[chromium] Fix errors in LayerRendererChromium cleanup
https://bugs.webkit.org/show_bug.cgi?id=80064
Reviewed by James Robinson.
Tested manually by forcing lost context while rendering Flash on
Mac OS in a Debug build.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::cleanupSharedObjects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 2 Mar 2012 09:05:09 +0000 (09:05 +0000)]
Fix errors found when building the Mac port with ICONDATABASE disabled.
https://bugs.webkit.org/show_bug.cgi?id=80059
Reviewed by Brady Eidson.
* WebCore.exp.in: Only export IconDatabase symbols when the feature is
enabled.
* loader/icon/IconDatabase.h:
(WebCore::IconDatabase::create): WebKit calls this static method, so it
should be defined on the stub class.
(WebCore::IconDatabase::allowDatabaseCleanup): Ditto.
(WebCore::IconDatabase::checkIntegrityBeforeOpening): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 2 Mar 2012 08:55:03 +0000 (08:55 +0000)]
Fix a warning in InputHandler::learnText()
https://bugs.webkit.org/show_bug.cgi?id=80049
Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-02
Reviewed by Antonio Gomes.
Fix a warning of the comparison "textInField.length() <=
MaxLearnTextDataSize" in InputHandler::learnText().
Rubber-stamped internally by Mike Fenton.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::learnText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Fri, 2 Mar 2012 08:50:08 +0000 (08:50 +0000)]
Handle CSSPropertyWebkitColorCorrection in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=80056
Reviewed by Eric Seidel.
No new tests / refactoring only.
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc