WebKit-https.git
5 years ago[GTK] Remove last reference to GTK+ WK1 EWS
rego@igalia.com [Tue, 1 Apr 2014 21:21:41 +0000 (21:21 +0000)]
[GTK] Remove last reference to GTK+ WK1 EWS
https://bugs.webkit.org/show_bug.cgi?id=131058

Reviewed by Martin Robinson.

In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.

* QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a 32bit JSC builder/tester.
lforschler@apple.com [Tue, 1 Apr 2014 21:09:04 +0000 (21:09 +0000)]
Add a 32bit JSC builder/tester.
https://bugs.webkit.org/show_bug.cgi?id=131054

Reviewed by Michael Saboff.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Compile32bitJSC):
(Run32bitJSCTests):
(Run32bitJSCTests.countFailures):
(BuildAndTest32bitJSCFactory):
(BuildAndTest32bitJSCFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WebKit2] Partial repaint is broken
timothy_horton@apple.com [Tue, 1 Apr 2014 20:47:18 +0000 (20:47 +0000)]
[iOS WebKit2] Partial repaint is broken
https://bugs.webkit.org/show_bug.cgi?id=131056

Reviewed by Dean Jackson.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
We need to check if the repaint rects themselves cover the whole
layer's surface, not just their bounds. Otherwise, we'll optimize
out the back->front copy and end up not painting the whole layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPass a WKNavigationAction to the create UIDelegate method
andersca@apple.com [Tue, 1 Apr 2014 20:35:47 +0000 (20:35 +0000)]
Pass a WKNavigationAction to the create UIDelegate method
https://bugs.webkit.org/show_bug.cgi?id=131053

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKUIDelegate.h:
* UIProcess/Cocoa/UIClient.h:
* UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::createNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
benjamin@webkit.org [Tue, 1 Apr 2014 20:33:13 +0000 (20:33 +0000)]
[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
https://bugs.webkit.org/show_bug.cgi?id=131009

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-01
Reviewed by Sam Weinig.

The two finger pan should not block the pinch gesture recognizer.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _twoFingerPanRecognized:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove a couple of useless static strings
benjamin@webkit.org [Tue, 1 Apr 2014 20:32:33 +0000 (20:32 +0000)]
Remove a couple of useless static strings
https://bugs.webkit.org/show_bug.cgi?id=131003

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-04-01
Reviewed by David Kilzer.

There is zero value in keeping those strings alive.

* css/StyleProperties.cpp:
(WebCore::isInitialOrInherit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agosvg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face...
mmaxfield@apple.com [Tue, 1 Apr 2014 20:05:08 +0000 (20:05 +0000)]
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition
https://bugs.webkit.org/show_bug.cgi?id=119747

Reviewed by Simon Fraser.

Source/WebCore:

Even though kerning and ligatures currently don't work with the
simple text path, messing those up is better than creating null
CTRun and CTLine objects.

Rather than calling the badly-named renderingContext() function on TextRun objects
to determine if they are drawn with an SVG font, this patch creates a wrapper function
with a better name and uses that instead.

Test: svg/text/svg-font-hittest.html

* platform/graphics/Font.cpp:
(WebCore::isDrawnWithSVGFont): Wrapper around renderingContext()
(WebCore::Font::drawText): Use wrapper function
(WebCore::Font::drawEmphasisMarks): Use wrapper function
(WebCore::Font::width): Use wrapper function
(WebCore::Font::selectionRectForText): Use wrapper function
(WebCore::Font::offsetForPosition): If we are using an SVG font, use the simple path
instead of the complex one
(WebCore::Font::codePath): Use wrapper function
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::ctFont):

LayoutTests:

Clicking on SVG text used to cause a ComplexTextController to be built
around the SVG text (which is incorrect and would crash). This test
does just that and makes sure there is no crash.

* svg/text/resources/Litherum.svg: Added.
* svg/text/svg-font-hittest-expected.txt: Added.
* svg/text/svg-font-hittest.html: Added.
* LayoutTests/platform/mac/TestExpectations: Unskipped tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove limits from WKBackForwardList getters
andersca@apple.com [Tue, 1 Apr 2014 19:53:04 +0000 (19:53 +0000)]
Remove limits from WKBackForwardList getters
https://bugs.webkit.org/show_bug.cgi?id=131052

Reviewed by Beth Dakin.

* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backList]):
(-[WKBackForwardList forwardList]):
(-[WKBackForwardList backListCount]): Deleted.
(-[WKBackForwardList forwardListCount]): Deleted.
(-[WKBackForwardList backListWithLimit:]): Deleted.
(-[WKBackForwardList forwardListWithLimit:]): Deleted.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backList):
(WebKit::WebBackForwardList::forwardList):
* UIProcess/WebBackForwardList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRenderQuote must destroy remaining text renderer before first letter renderer
dbates@webkit.org [Tue, 1 Apr 2014 19:38:13 +0000 (19:38 +0000)]
RenderQuote must destroy remaining text renderer before first letter renderer
https://bugs.webkit.org/show_bug.cgi?id=78023
<rdar://problem/10830009>

Reviewed by Brent Fulgham.

Merged from Blink (patch by Abhishek Arya):
https://src.chromium.org/viewvc/blink?view=rev&revision=151270

Source/WebCore:

Following the fix for <https://bugs.webkit.org/show_bug.cgi?id=114586>, a
RenderQuote may have child render objects for the first letter of its text
and everything following the first letter so as to support the CSS first-
letter property. The latter renderer is responsible for destroying the former
on destruction. It's sufficient to reverse the destruction of the children of
RenderQuote to ensure that we destroy the remaining text renderer before we
destroy the first letter renderer.

Test: fast/css-generated-content/quote-first-letter-crash.html

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText):

LayoutTests:

* fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
* fast/css-generated-content/quote-first-letter-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDo not allow HTTP refresh headers to refresh to javascript: URLs
ddkilzer@apple.com [Tue, 1 Apr 2014 19:21:34 +0000 (19:21 +0000)]
Do not allow HTTP refresh headers to refresh to javascript: URLs
<http://webkit.org/b/119051>
<rdar://problem/14536453>

Reviewed by Alexey Proskuryakov.

Merged from Blink (patch by tsepez@chromium.org):
https://src.chromium.org/viewvc/blink?revision=153912&view=revision
http://crbug.com/258151

    This behaviour has been standard in IE since IE7.  This makes us both
    more compatible and less vulnerable to XSS.

Source/WebCore:

Tests: http/tests/security/no-javascript-location-percent-escaped.html
       http/tests/security/no-javascript-location.html
       http/tests/security/no-javascript-refresh-percent-escaped.php
       http/tests/security/no-javascript-refresh-spaces.php
       http/tests/security/no-javascript-refresh-static-percent-escaped.html
       http/tests/security/no-javascript-refresh-static-spaces.html
       http/tests/security/no-javascript-refresh-static.html
       http/tests/security/no-javascript-refresh.php

* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
- Do not fire meta http refresh for a javascript: URL protocol.

LayoutTests:

* http/tests/security/no-javascript-refresh-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static.html: Added.
* http/tests/security/no-javascript-refresh.php: Added.
- Original Blink layout tests with typos fixed and 'PASS:' text
  added.

* http/tests/security/no-javascript-location.html: Added.
* http/tests/security/no-javascript-location-expected.txt: Added.
* http/tests/security/resources/no-javascript-location.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-location-percent-escaped.html: Added.
* http/tests/security/no-javascript-location-percent-escaped-expected.txt: Added.
* http/tests/security/resources/no-javascript-location-percent-escaped.php: Added.
- Add tests using a javascript: URL in a Location: header.

* http/tests/security/no-javascript-refresh-percent-escaped.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-refresh-percent-escaped-expected.txt: Added.
* http/tests/security/no-javascript-refresh-spaces.php: Copied from LayoutTests/http/tests/security/no-javascript-refresh.php.
* http/tests/security/no-javascript-refresh-spaces-expected.txt: Added.
- Add tests using a percent-escaped javascript: URL and a
  javascript: URL with leading spaces in a Refresh: header from
  a web server.

* http/tests/security/no-javascript-refresh-static-percent-escaped.html: Added.
* http/tests/security/no-javascript-refresh-static-percent-escaped-expected.txt: Added.
* http/tests/security/no-javascript-refresh-static-spaces.html: Added.
* http/tests/security/no-javascript-refresh-static-spaces-expected.txt: Added.
- Add tests using a percent-escaped javascript: URL and a
  javascript: URL with leading spaces in a meta http-equiv tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix. Remove duplicate file entries.
psolanki@apple.com [Tue, 1 Apr 2014 19:07:58 +0000 (19:07 +0000)]
Unreviewed build fix. Remove duplicate file entries.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStub out the web process -> UI process message SPI
andersca@apple.com [Tue, 1 Apr 2014 18:48:31 +0000 (18:48 +0000)]
Stub out the web process -> UI process message SPI
https://bugs.webkit.org/show_bug.cgi?id=131048

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _userContentController]):
(-[WKWebViewConfiguration _setUserContentController:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
* UIProcess/API/Cocoa/_WKScriptMessage.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKScriptMessage.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
(-[_WKScriptMessage body]):
(-[_WKScriptMessage originatingWebView]):
* UIProcess/API/Cocoa/_WKScriptMessageHandler.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKScriptWorld.h:
* UIProcess/API/Cocoa/_WKUserContentController.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h.
* UIProcess/API/Cocoa/_WKUserContentController.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h.
(-[_WKUserContentController addScriptMessageHandler:name:world:]):
(-[_WKUserContentController removeScriptMessageHandler:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInvalidate CFNetwork connection cache on memory pressure.
akling@apple.com [Tue, 1 Apr 2014 17:45:02 +0000 (17:45 +0000)]
Invalidate CFNetwork connection cache on memory pressure.
<https://webkit.org/b/131038>

Stop holding on to cached HTTP connections if we come under memory pressure.

Reviewed by Geoff Malloc-Garen.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTweak WKPreferences API
andersca@apple.com [Tue, 1 Apr 2014 17:39:11 +0000 (17:39 +0000)]
Tweak WKPreferences API
https://bugs.webkit.org/show_bug.cgi?id=131047

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences initWithUserDefaultsKeyPrefix:]):
(-[WKPreferences userDefaultsKeyPrefix]):
(-[WKPreferences initWithUserDefaultsPrefixKey:]): Deleted.
(-[WKPreferences userDefaultsPrefixKey]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoEnable WEB_TIMING on Mac and iOS
simon.fraser@apple.com [Tue, 1 Apr 2014 17:08:54 +0000 (17:08 +0000)]
Enable WEB_TIMING on Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=128064

Source/JavaScriptCore:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING. Add PerformanceTiming.cpp and JSPerformanceTiming.cpp
to the project.

* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Sam Weinig, Brent Fulgham.

Enable WEB_TIMING.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if
commit-queue@webkit.org [Tue, 1 Apr 2014 16:36:45 +0000 (16:36 +0000)]
AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if
roleValue is ApplicationAlertRole || ApplicationStatusRole
https://bugs.webkit.org/show_bug.cgi?id=130907

Patch by James Craig <jcraig@apple.com> on 2014-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html:
       platform/mac/accessibility/aria-liveregions-attributes.html:

Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic):

LayoutTests:

Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec.

* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html:
* platform/mac/accessibility/aria-liveregions-attributes-expected.txt:
* platform/mac/accessibility/aria-liveregions-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html...
ossy@webkit.org [Tue, 1 Apr 2014 16:32:41 +0000 (16:32 +0000)]
[EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html and Dromaeo performance tests crash
https://bugs.webkit.org/show_bug.cgi?id=131039

Patch by Zsolt Borbely <zsborbely.u-szeged@partner.samsung.com> on 2014-04-01
Reviewed by Csaba Osztrogon√°c.

* wtf/Platform.h: Disable CSS JIT on EFL until proper fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the !ENABLE(BATTERY_STATUS) build
dbatyai.u-szeged@partner.samsung.com [Tue, 1 Apr 2014 16:18:38 +0000 (16:18 +0000)]
Fix the !ENABLE(BATTERY_STATUS) build
https://bugs.webkit.org/show_bug.cgi?id=130183

Reviewed by Anders Carlsson.

* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r166583.
commit-queue@webkit.org [Tue, 1 Apr 2014 16:04:46 +0000 (16:04 +0000)]
Unreviewed, rolling out r166583.
https://bugs.webkit.org/show_bug.cgi?id=131040

It's causing frequent crashes when running Layout Tests
(Requested by svillar on #webkit).

Reverted changeset:

"[GTK][Cmake] Enable CSS JIT"
https://bugs.webkit.org/show_bug.cgi?id=131022
http://trac.webkit.org/changeset/166583

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fixing debug builds after r166586.
zandobersek@gmail.com [Tue, 1 Apr 2014 15:47:47 +0000 (15:47 +0000)]
Unreviewed. Fixing debug builds after r166586.

* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener): Fix the ASSERT.
(WebCore::SVGElement::removeEventListener): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPrevent unnecessary copies in compareEqual template
zandobersek@gmail.com [Tue, 1 Apr 2014 15:35:46 +0000 (15:35 +0000)]
Prevent unnecessary copies in compareEqual template
https://bugs.webkit.org/show_bug.cgi?id=131014

Reviewed by Antti Koivisto.

* rendering/style/RenderStyle.h:
(compareEqual): Casting the second parameter to a non-const, non-reference type
causes an extra copy of that object. Casting to the const reference type of the
first parameter avoids that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[UI-side compositing] Fix animations, and add logging
simon.fraser@apple.com [Tue, 1 Apr 2014 15:29:16 +0000 (15:29 +0000)]
[UI-side compositing] Fix animations, and add logging
https://bugs.webkit.org/show_bug.cgi?id=131011

Reviewed by Tim Horton.

UI-side animations were broken because GraphicsLayerCARemote::addAnimation()
never called the superclass, so fix.

Add logging for animations to the layer tree commit output.

* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpProperty):
(WebKit::RemoteLayerTreeTextStream::operator<<):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::addAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix after r166582.
zalan@apple.com [Tue, 1 Apr 2014 15:28:36 +0000 (15:28 +0000)]
Build fix after r166582.

* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAvoid unnecessary HashSet copies when calling collectInstancesForSVGElement
zandobersek@gmail.com [Tue, 1 Apr 2014 15:22:36 +0000 (15:22 +0000)]
Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement
https://bugs.webkit.org/show_bug.cgi?id=131020

Reviewed by Andreas Kling.

Remove collectInstancesForSVGElement() to avoid HashSet copies when assigning a const
HashSet reference to a non-const HashSet reference. Instead, range-based for-loops are
deployed to iterate directly over the const reference to HashSet that's returned by
SVGElement::instancesForElement(). SVGElement::containingShadowRoot() return value
is checked to see if the iteration should be performed in the first place, preserving
the behavior of collectInstancesForSVGElement().

* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
(WebCore::collectInstancesForSVGElement): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove the attributes HashMap out of the parseAttributes function
zandobersek@gmail.com [Tue, 1 Apr 2014 15:20:40 +0000 (15:20 +0000)]
Move the attributes HashMap out of the parseAttributes function
https://bugs.webkit.org/show_bug.cgi?id=131019

Reviewed by Andreas Kling.

* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::parseAttributes): Avoid copying the HashMap object that's being returned by
converting it to an xvalue through using std::move() in the return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] No longer build WebKit1 gtkdoc
mrobinson@webkit.org [Tue, 1 Apr 2014 15:13:40 +0000 (15:13 +0000)]
[GTK] No longer build WebKit1 gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=130970

Reviewed by Anders Carlsson.

* gtk/common.py:
(gtk_version_of_pkg_config_file): Deleted.
* gtk/generate-gtkdoc:
(get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
was only applicable for WebKit1.
(get_generator_for_config): No longer look for the WebKit1 configuration file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK][Cmake] Enable CSS JIT
commit-queue@webkit.org [Tue, 1 Apr 2014 14:32:44 +0000 (14:32 +0000)]
[GTK][Cmake] Enable CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=131022

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-04-01
Reviewed by Martin Robinson.

* wtf/Platform.h: Enable CSS JIT for GTK port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSubpixel rendering: Transition class Image (and its dependencies) from int to float...
zalan@apple.com [Tue, 1 Apr 2014 14:17:58 +0000 (14:17 +0000)]
Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images.
https://bugs.webkit.org/show_bug.cgi?id=130643

Reviewed by Simon Fraser.

This is in preparation to support subpixel positioned/sized background images. While 1x bitmap images can't take
subpixel sizing on hidpi resolutions, both generated and hidpi images can.
This patch does not change Image behavior in general as both position and size are still snapped to integral values.

No change in behavior.

Source/WebCore:

* WebCore.exp.in:
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::fixedSize):
* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::fixedSize):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::drawImageIntoBuffer):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer):
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
* platform/Cursor.cpp:
(WebCore::determineHotSpot):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::size):
(WebCore::BitmapImage::currentFrameSize):
* platform/graphics/BitmapImage.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/GeneratedImage.h:
* platform/graphics/Gradient.cpp:
(WebCore::Gradient::adjustParametersForTiledDrawing):
* platform/graphics/Gradient.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::drawPattern):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/Image.cpp:
(WebCore::Image::adjustSourceRectForDownSampling):
* platform/graphics/Image.h:
(WebCore::Image::setContainerSize):
(WebCore::Image::rect):
(WebCore::Image::width):
(WebCore::Image::height):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
* platform/graphics/IntPoint.cpp:
(WebCore::IntPoint::IntPoint):
* platform/graphics/IntPoint.h:
* platform/graphics/IntSize.cpp:
(WebCore::IntSize::IntSize):
* platform/graphics/IntSize.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/cg/ImageBufferDataCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::size):
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
(WebCore::applyRotationForPainting):
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cg/PatternCG.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/mac/GraphicsContextMac.mm:
* platform/graphics/mac/IconMac.mm:
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
(WebCore::CoordinatedImageBacking::update):
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageFromImage):
* platform/win/DragImageCGWin.cpp:
(WebCore::createDragImageFromImage):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::drawPlatformResizerImage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
* svg/graphics/SVGImageCache.h:
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::size):
* svg/graphics/SVGImageForContainer.h:
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::externalRepresentation):
* testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeImage):
* UIProcess/API/efl/EwkView.cpp:
(EwkView::updateCursor):

LayoutTests:

* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
* svg/custom/feDisplacementMap-01-expected.txt:
* svg/filters/feImage-change-target-id-expected.txt:
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt:
* svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt:
* svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt:
* svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt:
* svg/filters/feImage-late-indirect-update-expected.txt:
* svg/filters/feImage-multiple-targets-id-change-expected.txt:
* svg/filters/feImage-position-expected.txt:
* svg/filters/feImage-preserveAspectRatio-all-expected.txt:
* svg/filters/feImage-preserveAspectratio-expected.txt:
* svg/filters/feImage-reference-invalidation-expected.txt:
* svg/filters/feImage-reference-svg-primitive-expected.txt:
* svg/filters/feImage-remove-target-expected.txt:
* svg/filters/feImage-subregions-expected.txt:
* svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt:
* svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt:
* svg/filters/feImage-target-add-to-document-expected.txt:
* svg/filters/feImage-target-attribute-change-expected.txt:
* svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt:
* svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt:
* svg/filters/feImage-target-changes-id-expected.txt:
* svg/filters/feImage-target-id-change-expected.txt:
* svg/filters/feImage-target-inline-style-change-expected.txt:
* svg/filters/feImage-target-property-change-expected.txt:
* svg/filters/feImage-target-reappend-to-document-expected.txt:
* svg/filters/feImage-target-remove-from-document-expected.txt:
* svg/filters/feImage-target-style-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Running minibrowser with url crashes in debug build
mario.prada@samsung.com [Tue, 1 Apr 2014 12:36:48 +0000 (12:36 +0000)]
[GTK] Running minibrowser with url crashes in debug build
https://bugs.webkit.org/show_bug.cgi?id=130492

Reviewed by Martin Robinson.

Update "uri-scheme" test not to use invalid URIs in it, so we
don't get a mistmatch when comparing the original URI stored in
the test class with the one returned by the WebKitWebView.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextURIScheme): Update the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_asy...
commit-queue@webkit.org [Tue, 1 Apr 2014 11:38:37 +0000 (11:38 +0000)]
[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API
https://bugs.webkit.org/show_bug.cgi?id=131017

Patch by Joonghun Park <jh718.park@samsung.com> on 2014-04-01
Reviewed by Gyuyoung Kim.

* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
Fix memory leaks and errors caused by duplication of Ecore_Timer deletion
as well as update a naming style of local variable.
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDon't copy the children map in webkitWebViewBaseContainerForall
zandobersek@gmail.com [Tue, 1 Apr 2014 09:11:14 +0000 (09:11 +0000)]
Don't copy the children map in webkitWebViewBaseContainerForall
https://bugs.webkit.org/show_bug.cgi?id=131016

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object
by transforming the iteration to a range-based for-loop over that HashMap's keys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
zandobersek@gmail.com [Tue, 1 Apr 2014 09:07:25 +0000 (09:07 +0000)]
[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015

Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd myself as a commiter.
mitica@adobe.com [Tue, 1 Apr 2014 09:04:45 +0000 (09:04 +0000)]
Add myself as a commiter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CoordinatedGraphics] Content scale factor should not be applied to draw contents...
eunmi15.lee@samsung.com [Tue, 1 Apr 2014 08:34:12 +0000 (08:34 +0000)]
[CoordinatedGraphics] Content scale factor should not be applied to draw contents when fixed layout is not used.
https://bugs.webkit.org/show_bug.cgi?id=130962

Reviewed by Gyuyoung Kim.

Delegating scaling is turned off when fixed layout is not used in the
coordinated graphics, so page scale factor is applied to the contents
directly.
In that case, we should not apply page scale factor to coordinated
graphics to draw contents and calculate visible content rect.

Currently, page scale factor is applied twice to the coordinated
graphics and contents, so result of scaling is abnormal.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::transformToScene):
(WebKit::WebView::visibleContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
ryuan.choi@samsung.com [Tue, 1 Apr 2014 08:01:26 +0000 (08:01 +0000)]
[EFL][WK2] Rename ewk_application_cache_manager_delete{_all}
https://bugs.webkit.org/show_bug.cgi?id=131012

Reviewed by Gyuyoung Kim.

While discussing Bug 130577, we resulted that _clear and _xxx_del is better name for the EFL.
This patch will rename similar API in ewk_application_cache_manager.

In addition, fixed some typos in doxygen.

* UIProcess/API/efl/ewk_application_cache_manager.cpp:
(ewk_application_cache_manager_clear): Renamed from ewk_application_cache_manager_delete_all
(ewk_application_cache_manager_entries_for_origin_del): Renamed from ewk_application_cache_manager_delete
(ewk_application_cache_manager_delete_all): Deleted.
(ewk_application_cache_manager_delete): Deleted.
* UIProcess/API/efl/ewk_application_cache_manager.h:
* UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix when disabled ACCESSIBILITY
ryuan.choi@samsung.com [Tue, 1 Apr 2014 07:41:42 +0000 (07:41 +0000)]
Unreviewed build fix when disabled ACCESSIBILITY

* accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:
Separated macros not to check ATK version when disabled ACCESSIBILITY

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake][EFL] Enable CSS JIT
gyuyoung.kim@samsung.com [Tue, 1 Apr 2014 07:38:06 +0000 (07:38 +0000)]
[CMake][EFL] Enable CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=131010

Reviewed by Benjamin Poulain.

Source/WebCore:

Add an inclusion path for enabling CSS JIT on EFL and GTK ports.
This patch only enables it for EFL port.

* CMakeLists.txt:

Source/WTF:

* wtf/Platform.h: Enable CSS JIT for EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
mrobinson@webkit.org [Tue, 1 Apr 2014 07:28:14 +0000 (07:28 +0000)]
[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=130978

Reviewed by Carlos Garcia Campos.

Unify how we decide if an attribute is readable or writeable and improve the code.
This results in some attributes now being marked as read-only which didn't have
corresponding case statements in the set_property switch statements and also correctly
installs set_property support for some more POD types.

* bindings/scripts/CodeGeneratorGObject.pm:
(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
update the list of types to reflect the full list of types we can generate setters for.
(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
(GenerateProperties): Use grep and the new helpers to simplify the code.
(GetReadableProperties): Deleted.
(GetWriteableProperties): Deleted.
* bindings/scripts/test/GObject: Update results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed GTK build fix after r166553.
zandobersek@gmail.com [Tue, 1 Apr 2014 06:34:18 +0000 (06:34 +0000)]
Unreviewed GTK build fix after r166553.

* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Pass 'WebKit2.' as the second argument to WebPreferences::create().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Extract the control of page background out of color_set
ryuan.choi@samsung.com [Tue, 1 Apr 2014 06:09:55 +0000 (06:09 +0000)]
[EFL][WK2] Extract the control of page background out of color_set
https://bugs.webkit.org/show_bug.cgi?id=127539

Reviewed by Gyuyoung Kim.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
Added m_viewBackgroundColor to clear when m_setDrawsBackground is false.
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(WebCore::CoordinatedGraphicsScene::setViewBackgroundColor):
(WebCore::CoordinatedGraphicsScene::viewBackgroundColor):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
Added EFL guard not to set opaque as a default for MainFrameRenderViewLayer.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::ensureRootLayer):
Added EFL guard to apply page scale on RenderView like IOS.

Source/WebKit2:

EFL have a way to change the color using evas_object_color_set and we used it to change background.
But, We should not use it because the alpha value of color_set is used
for the transparancy of object itself including background and contents.

This patch added ewk_view_bg_color_{get|set} to change the background color.

* UIProcess/API/C/efl/WKViewEfl.cpp:
Extracted controls of page background out of color_set.
color_set will be only used for the opacity of whole contents.
(WKViewSetBackgroundColor): Added to share page background color.
(WKViewGetBackgroundColor):
* UIProcess/API/C/efl/WKViewEfl.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::handleEvasObjectColorSet):
* UIProcess/API/efl/ewk_view.cpp:
Removed ewk_view_draws_page_background_set which just control whether to draw background.
ewk_view_bg_color_set will conver it.
(ewk_view_bg_color_set):
(ewk_view_bg_color_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp: Added simple test case.
* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::setViewBackgroundColor):
(WebKit::WebViewEfl::viewBackgroundColor):
* UIProcess/efl/WebViewEfl.h:

Tools:

Added an option(C) to change background color.

* MiniBrowser/efl/main.c:
(window_create):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of...
commit-queue@webkit.org [Tue, 1 Apr 2014 06:01:28 +0000 (06:01 +0000)]
[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of the local storage entries
https://bugs.webkit.org/show_bug.cgi?id=130577

Patch by Joonghun Park <jh718.park@samsung.com> on 2014-03-31
Reviewed by Gyuyoung Kim.

* UIProcess/API/efl/ewk_storage_manager.cpp:
(ewk_storage_manager_entries_clear):
(ewk_storage_manager_entries_for_origin_del):
* UIProcess/API/efl/ewk_storage_manager.h:
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::wkStorageManager):
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
adding and updating API unittest and fixing memory leak of the existing test case
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::checkOrigin):
(EWK2StorageManagerTest::getOrigin):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix on the EFL port with latest EFL libraries since r166149
ryuan.choi@samsung.com [Tue, 1 Apr 2014 05:44:38 +0000 (05:44 +0000)]
Unreviewed build fix on the EFL port with latest EFL libraries since r166149

* ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
commit-queue@webkit.org [Tue, 1 Apr 2014 05:37:12 +0000 (05:37 +0000)]
[WebGL][OpenGLES] Enable MSAA support for WebGL Canvas
https://bugs.webkit.org/show_bug.cgi?id=130955

Patch by Byungseon Shin <sun.shin@lge.com> on 2014-03-31
Reviewed by Dean Jackson.

To avoid aliasing issues when we render content to WebGL canvas,
 we need to implement MSAA support.
- Imagination OpenGLES GPU Driver already support MSAA, so we
 need a separate code path to enable it.

* platform/graphics/Extensions3D.h:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
(WebCore::Extensions3DOpenGLCommon::isImagination):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename policy enums to match the delegate methods
andersca@apple.com [Tue, 1 Apr 2014 02:13:27 +0000 (02:13 +0000)]
Rename policy enums to match the delegate methods
https://bugs.webkit.org/show_bug.cgi?id=131002

Reviewed by Tim Horton.

* UIProcess/API/Cocoa/WKNavigationDelegate.h:
(NS_ENUM):
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd more preferences
andersca@apple.com [Tue, 1 Apr 2014 02:03:54 +0000 (02:03 +0000)]
Add more preferences
https://bugs.webkit.org/show_bug.cgi?id=131001

Reviewed by Simon Fraser.

* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences isJavaScriptEnabled]):
(-[WKPreferences setJavaScriptEnabled:]):
(-[WKPreferences javaScriptCanOpenWindowsAutomatically]):
(-[WKPreferences setJavaScriptCanOpenWindowsAutomatically:]):
(-[WKPreferences suppressesIncrementalRendering]):
(-[WKPreferences setSuppressesIncrementalRendering:]):
(-[WKPreferences isJavaEnabled]):
(-[WKPreferences setJavaEnabled:]):
(-[WKPreferences arePlugInsEnabled]):
(-[WKPreferences setPlugInsEnabled:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Unreviewed build fix after r166496.
alex.christensen@flexsim.com [Tue, 1 Apr 2014 01:52:47 +0000 (01:52 +0000)]
[WinCairo] Unreviewed build fix after r166496.

* win/tools/vsprops/GStreamerCommon.props:
Added gio-2.0.lib to list of GStreamer includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 01:46:22 +0000 (01:46 +0000)]
Fix the build.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build.
simon.fraser@apple.com [Tue, 1 Apr 2014 01:34:02 +0000 (01:34 +0000)]
Fix the iOS build.

* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
* UIProcess/mac/RemoteLayerTreeHost.h:
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::setLayerID):
(WebKit::RemoteLayerTreeHost::layerID):
(WebKit::RemoteLayerTreeHost::createLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a couple of iOS specific preferences
andersca@apple.com [Tue, 1 Apr 2014 01:23:25 +0000 (01:23 +0000)]
Add a couple of iOS specific preferences
https://bugs.webkit.org/show_bug.cgi?id=130999

Reviewed by Simon Fraser.

* Shared/WebPreferencesStore.h:
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences allowsInlineMediaPlayback]):
(-[WKPreferences setAllowsInlineMediaPlayback:]):
(-[WKPreferences mediaPlaybackRequiresUserAction]):
(-[WKPreferences setMediaPlaybackRequiresUserAction:]):
(-[WKPreferences mediaPlaybackAllowsAirPlay]):
(-[WKPreferences setMediaPlaybackAllowsAirPlay:]):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
msaboff@apple.com [Tue, 1 Apr 2014 01:10:35 +0000 (01:10 +0000)]
REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
https://bugs.webkit.org/show_bug.cgi?id=130992

Reviewed by Mark Hahnenberg.

Forward JSObjectGetPrivate() and JSObjectSetPrivate() to the wrapped object.

* API/JSObjectRef.cpp:
(JSObjectGetPrivate):
(JSObjectSetPrivate):
* API/tests/testapi.c:
(main): Added new test case to validate we are properly foarwarding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a new -[WKPreferences initWithUserDefaultsPrefixKey:] initializer
andersca@apple.com [Tue, 1 Apr 2014 01:02:09 +0000 (01:02 +0000)]
Add a new -[WKPreferences initWithUserDefaultsPrefixKey:] initializer
https://bugs.webkit.org/show_bug.cgi?id=130996

Reviewed by Simon Fraser.

Add a "key prefix" to the WebKit::WebPreferences create function, so we can use a different
key prefix ("WebKit") for the modern API and not pollute the user defaults namespace with
the old key prefix ("WebKit2.").

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences initWithUserDefaultsPrefixKey:]):
(-[WKPreferences userDefaultsPrefixKey]):
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences):
* UIProcess/WebPreferences.h:
(WebKit::WebPreferences::create):
* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove duplicate entries in Derived Sources.
psolanki@apple.com [Tue, 1 Apr 2014 00:53:29 +0000 (00:53 +0000)]
Remove duplicate entries in Derived Sources.

Rubber-stamped by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCrashes in PageConsole::addMessage
ap@apple.com [Tue, 1 Apr 2014 00:19:14 +0000 (00:19 +0000)]
Crashes in PageConsole::addMessage
https://bugs.webkit.org/show_bug.cgi?id=130991
<rdar://problem/14795232>

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/tests/misc/detached-frame-console.html

* page/DOMWindow.cpp: (WebCore::DOMWindow::printErrorMessage): Added a null check.
It's legitimate for this to be called for a window that is not currently displayed
in a frame.

LayoutTests:

* http/tests/misc/detached-frame-console-expected.txt: Added.
* http/tests/misc/detached-frame-console.html: Added.
* http/tests/misc/resources/detached-frame-console-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 00:12:40 +0000 (00:12 +0000)]
Fix the build.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Tue, 1 Apr 2014 00:08:00 +0000 (00:08 +0000)]
Fix the build.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r166144?): fast/preloader/document-write.html is very flaky
ap@apple.com [Tue, 1 Apr 2014 00:00:32 +0000 (00:00 +0000)]
REGRESSION (r166144?): fast/preloader/document-write.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=130942

* platform/mac/TestExpectations: Marking as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed test correction after r166530.
bfulgham@apple.com [Mon, 31 Mar 2014 23:50:17 +0000 (23:50 +0000)]
Unreviewed test correction after r166530.

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
fine-grained setting for swipe tests. This prevents existing tests from breaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename -[WKNavigationAction destinationFrame] to -[WKNavigationAction targetFrame]
andersca@apple.com [Mon, 31 Mar 2014 23:49:47 +0000 (23:49 +0000)]
Rename -[WKNavigationAction destinationFrame] to -[WKNavigationAction targetFrame]
https://bugs.webkit.org/show_bug.cgi?id=130994

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKNavigationAction.h:
* UIProcess/API/Cocoa/WKNavigationAction.mm:
(-[WKNavigationAction description]):
(-[WKNavigationAction targetFrame]):
(-[WKNavigationAction setTargetFrame:]):
(-[WKNavigationAction destinationFrame]): Deleted.
(-[WKNavigationAction setDestinationFrame:]): Deleted.
* UIProcess/API/Cocoa/WKNavigationActionInternal.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after...
timothy_horton@apple.com [Mon, 31 Mar 2014 23:30:43 +0000 (23:30 +0000)]
[iOS WebKit2] Flush all surfaces after painting into all of them, instead of after painting into each one
https://bugs.webkit.org/show_bug.cgi?id=130768
<rdar://problem/16421471>

Reviewed by Benjamin Poulain.

* Shared/mac/RemoteLayerBackingStore.h:
Make RemoteLayerBackingStore noncopyable.
Add flush(), which synchronously flushes painting operations on the underlying backing store.
Add storage for the CGContext that needs to be flushed, and ensure that it is flushed before we paint again.

* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):

(RemoteLayerBackingStore::drawInContext):
Don't flush the context immediately after painting.

(RemoteLayerBackingStore::flush):
Flush the current front surface/buffer's context.
Clear the new pending-flush members.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::flushBackingStoreChangesInTransaction):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Crawl through all of the valid changed backing stores in the transaction and flush them.
Reset changed properties after encoding the commit.

* Shared/mac/RemoteLayerTreeTransaction.h:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::resetChangedProperties):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::changedLayerProperties):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
(WebKit::dumpChangedLayers):
Instead of storing a copy of the LayerProperties struct for each changed layer
while building the transaction in the Web process, store a list of changed layers,
and directly encode the commit from those layers' LayerProperties. This provides a few benefits:
        - We avoid copying LayerProperties for every changed layer, every commit
        - We can make RemoteLayerBackingStore noncopyable
        - We can walk the changed layers after building the transaction
        in order to flush backing store, and actually affect the layers'
        own RemoteLayerBackingStore instead of a copy.
The UI process will still generate a LayerPropertiesMap at decode time.

* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::updateLayerTree):
Don't copy the LayerProperties struct for the debug overlay. Instead,
adjust the properties which the debug overlay whacks directly on the layer,
after applying the normal LayerProperties.

* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::recursiveBuildTransaction):
Don't reset changed layer properties in the middle of building a transaction. Instead,
RemoteLayerTreeDrawingArea::flushLayers() will reset all the flags on all changed layers
after the commit is encoded.

* WebProcess/WebPage/mac/PlatformCALayerRemote.h:
(WebKit::PlatformCALayerRemote::properties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImprove GC_LOGGING
mhahnenberg@apple.com [Mon, 31 Mar 2014 23:27:29 +0000 (23:27 +0000)]
Improve GC_LOGGING
https://bugs.webkit.org/show_bug.cgi?id=130988

Reviewed by Geoffrey Garen.

GC_LOGGING can be useful for diagnosing where we're spending our time during collection,
but it doesn't distinguish between Eden and Full collections in the data it gathers. This
patch updates it so that it can. It also adds the process ID to the beginning of each line
of input to be able to distinguish between the output of multiple processes exiting at the
same time.

* heap/Heap.cpp:
(JSC::Heap::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r166536.
commit-queue@webkit.org [Mon, 31 Mar 2014 23:23:43 +0000 (23:23 +0000)]
Unreviewed, rolling out r166536.
https://bugs.webkit.org/show_bug.cgi?id=130993

This is not the correct fix. (Requested by bfulgham on
#webkit).

Reverted changeset:

"Unreviewed test fix after r166530."
http://trac.webkit.org/changeset/166536

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[UI-side compositing] Proxy animations to the UI process
simon.fraser@apple.com [Mon, 31 Mar 2014 23:15:58 +0000 (23:15 +0000)]
[UI-side compositing] Proxy animations to the UI process
https://bugs.webkit.org/show_bug.cgi?id=130946

Source/WebCore:

Reviewed by Tim Horton.

To proxy CA animations, make PlatformCAAnimation a pure virtual base class
and subclass for Mac, Windows, and Remote (just like PlatformCALayer).

Add coding support for TimingFunctions.

Do some minor #include tidyup.

Minor refactor in GraphicsLayerCA to share some animations code.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/animation/TimingFunction.h: Add setters need for encode/decode.
(WebCore::CubicBezierTimingFunction::setValues):
(WebCore::CubicBezierTimingFunction::setTimingFunctionPreset):
(WebCore::StepsTimingFunction::create):
(WebCore::StepsTimingFunction::setNumberOfSteps):
(WebCore::StepsTimingFunction::setStepAtStart):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createPlatformCAAnimation):
(WebCore::GraphicsLayerCA::animationCanBeAccelerated): Minor refactor so we can share
code with GraphicsLayerCARemote.
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::PassRefPtr<PlatformCAAnimation>GraphicsLayerCA::createKeyframeAnimation):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCAAnimation.h:
(WebCore::PlatformCAAnimation::~PlatformCAAnimation):
(WebCore::PlatformCAAnimation::isPlatformCAAnimationMac):
(WebCore::PlatformCAAnimation::isPlatformCAAnimationWin):
(WebCore::PlatformCAAnimation::isPlatformCAAnimationRemote):
(WebCore::PlatformCAAnimation::PlatformCAAnimation):
(WebCore::PlatformCAAnimation::setType):
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCAAnimationMac.h: Added.
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::addAnimationForKey):
(PlatformCALayerMac::animationForKey):
* platform/graphics/ca/mac/TileController.mm:
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
* platform/graphics/ca/win/PlatformCAAnimationWin.h: Added.

Source/WebKit2:

Reviewed by Tim Horton.

Add encoding/decoding of TimingFunctions. Add encoding support
for HashSet.

Add PlatformCAAnimationRemote and have PlatformCALayerRemote allow
animations now. PlatformCALayerRemote's properties are defined in the class,
as is the encoding/decoding (much cleaner than having them in the transaction
class I think).

Add support for the "animationDidStart" callback and sending this back to the
web process. This involves a HashMap of layerID->WKAnimationDelegate stored
on the RemoteLayerTreeHost, and a message send via the DrawingArea. On the
other side, RemoteLayerTreeContext stores a HashMap of layerID->PlatformCALayerRemote*
for layers which have just started animations, which is used to get the
PlatformCALayer* to call animationDidStart() on.

This requires that the RemoteLayerTreeHost* be passed down into property application,
and that the RemoteLayerTreeHost have a reference to the drawing area.

To every CALayer in the UI process we -setValue:forKey: to track the PlatformLayerID,
so we can get back to it in order to dispatch "animationDidStart".

Replace some "using namespace WebKit" with "namespace WebKit { }".

* Platform/IPC/ArgumentCoders.h:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<LinearTimingFunction>::encode):
(IPC::ArgumentCoder<LinearTimingFunction>::decode):
(IPC::ArgumentCoder<CubicBezierTimingFunction>::encode):
(IPC::ArgumentCoder<CubicBezierTimingFunction>::decode):
(IPC::ArgumentCoder<StepsTimingFunction>::encode):
(IPC::ArgumentCoder<StepsTimingFunction>::decode):
* Shared/WebCoreArgumentCoders.h:
* Shared/mac/RemoteLayerBackingStore.mm:
* Shared/mac/RemoteLayerTreePropertyApplier.h:
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):
* Shared/mac/RemoteLayerTreeTransaction.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::layerID):
(WebKit::RemoteLayerTreeHost::createLayer):
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::acceleratedAnimationDidStart):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator):
* UIProcess/mac/RemoteLayerTreeHost.h:
(WebKit::RemoteLayerTreeHost::animationDelegates):
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::layerWillBeRemoved):
(WebKit::RemoteLayerTreeHost::animationDidStart):
(WebKit::RemoteLayerTreeHost::layerID):
(WebKit::RemoteLayerTreeHost::createLayer):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::acceleratedAnimationDidStart):
* WebProcess/WebPage/DrawingArea.messages.in:
* WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCAAnimation):
* WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.h: Added.
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm: Added.
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::animationStarted):
(WebKit::PlatformCALayerRemote::addAnimationForKey):
(WebKit::PlatformCALayerRemote::removeAnimationForKey):
(WebKit::PlatformCALayerRemote::animationForKey):
(PlatformCALayerRemote::recursiveBuildTransaction): Deleted.
(PlatformCALayerRemote::addAnimationForKey): Deleted.
(PlatformCALayerRemote::removeAnimationForKey): Deleted.
(PlatformCALayerRemote::animationForKey): Deleted.
* WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
* WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
* WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::willStartAnimationOnLayer):
(WebKit::RemoteLayerTreeContext::animationDidStart):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::acceleratedAnimationDidStart):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDouble-buffer RemoteLayerBackingStore
timothy_horton@apple.com [Mon, 31 Mar 2014 23:00:30 +0000 (23:00 +0000)]
Double-buffer RemoteLayerBackingStore
https://bugs.webkit.org/show_bug.cgi?id=130990

Reviewed by Simon Fraser.

We'll keep a front and back buffer for each surface; the front is generally currently
being displayed in the UI process, and the back is the one we'll paint into.

Swap the two surfaces each time we paint; since we synchronize with the UI process,
the old front surface will generally be out-of-use by the render server by the time
we paint again. However, since render server commits are asynchronous and we have
no way to syncronize with them yet, we have to check if the (swapped to front) back buffer is in use,
and create a new front buffer if it is.

Triple-buffering would solve this problem, as would synchronization with the render server,
as would a pool of surfaces - we will revisit these solutions in future patches.

* Shared/mac/RemoteLayerBackingStore.h:
* Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::ensureBackingStore):
(RemoteLayerBackingStore::clearBackingStore):
Factor clearBackingStore() out of ensureBackingStore() and display().

(RemoteLayerBackingStore::display):
Swap buffers. Since m_backSurface will hold on to the back surface's CGContext,
we don't need to worry about tearing down the image first anymore.
Don't worry about creating a back image (nor copying it into the front image)
if we're going to paint the whole layer.

(RemoteLayerBackingStore::drawInContext):
Fix some names.

(RemoteLayerBackingStore::applyBackingStoreToLayer):
Reduce duplication.

(RemoteLayerBackingStore::createImageForFrontBuffer): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSynchronize Web process remote layer tree commits with CoreAnimation commits in the...
timothy_horton@apple.com [Mon, 31 Mar 2014 22:52:31 +0000 (22:52 +0000)]
Synchronize Web process remote layer tree commits with CoreAnimation commits in the UI process
https://bugs.webkit.org/show_bug.cgi?id=130984

Reviewed by Simon Fraser.

There's no reason for the Web process to paint faster than the UI process
can apply to and commit the CoreAnimation layer tree.

Also, once we get proper double-buffering and purgeable back buffers, we
will need the ability to make some assumptions about in-use surfaces.

Unfortunately, we can't actually tell when the render server commits,
as this is an asynchronous operation in a process we don't control, so
for now, this is only an approximation.

This also means that the assumptions we would like to make won't be
strong guarantees yet.

* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
* UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
When we commit, install a run loop observer to fire immediately after CoreAnimation commits.

(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator):
Fix a typo ('cmponents').

(WebKit::coreAnimationDidCommitLayersCallback):
(WebKit::RemoteLayerTreeDrawingAreaProxy::scheduleCoreAnimationLayerCommitObserver):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers):
When CA commits, send a message to the Web process letting it know that we
swapped to the new backing store.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
Defer remote layer tree commits until we get didUpdate() from the UI process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the trigger for webkit1 tests on the gtk-linux-64-release bot
commit-queue@webkit.org [Mon, 31 Mar 2014 22:28:35 +0000 (22:28 +0000)]
Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
https://bugs.webkit.org/show_bug.cgi?id=130987

r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
trigger the webkit1 bot tests on the gtk-linux-64-release bot.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-03-31
Reviewed by Martin Robinson.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: compile the first-child pseudo class
benjamin@webkit.org [Mon, 31 Mar 2014 22:19:04 +0000 (22:19 +0000)]
CSS JIT: compile the first-child pseudo class
https://bugs.webkit.org/show_bug.cgi?id=130954

Reviewed by Andreas Kling.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
The compiler use the context's style directly when resolving style. An error introduced
in the rule collector would cause a crash in the compiled code which would be hard to debug.
Add an assertion early in the stack to catch errors where it is easier to debug them.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initForStyleResolve):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToPreviousAdjacentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToPreviousAdjacent):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateDirectAdjacentTreeWalker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateIndirectAdjacentTreeWalker):
Refactor those to be able to reuse the code getting a sibling element preceding the current element.

(WebCore::SelectorCompiler::SelectorCodeGenerator::jumpIfNotResolvingStyle):
Extract the code checking the current mode from SelectorCodeGenerator::markParentElementIfResolvingStyle()
in a separate function. This will be useful for all the pseudo class with marking.

(WebCore::SelectorCompiler::SelectorCodeGenerator::markParentElementIfResolvingStyle):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::setFirstChildState):
This is the slow path for when the first-child pseudo class is on a fragment that is not
the rightmost.
The reason to use a slow path is accessing renderStyle() is not trivial and this case isn't not
as common. We should improve this later.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
This is just implementing the test for first-child plus the tree marking. Nothing fancy,
this is basically the same thing as SelectorChecker.

* dom/Element.cpp:
(WebCore::Element::setChildrenAffectedByFirstChildRules):
* dom/Element.h:
C++ fallback to set the flag, to be improved later with the other flags.

* rendering/style/RenderStyle.h:
I accidentaly put noninheritedFlagsMemoryOffset() as private in the RenderStyle refactoring.

Also update the flags accessor to make them easier to work with from the compiler. In particular,
setFirstChildStateFlags() sets both isUnique and firstChild. Currently the JIT does not need to access
the value so individual flags are made private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed test fix after r166530.
bfulgham@apple.com [Mon, 31 Mar 2014 22:17:55 +0000 (22:17 +0000)]
Unreviewed test fix after r166530.

After switching to high-resolution continuous scroll output, forgot to update one test case.

* fast/events/platform-wheelevent-in-scrolling-div-expected.txt:
* fast/events/platform-wheelevent-in-scrolling-div.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove WEB_ANIMATIONS
dino@apple.com [Mon, 31 Mar 2014 22:16:37 +0000 (22:16 +0000)]
Remove WEB_ANIMATIONS
https://bugs.webkit.org/show_bug.cgi?id=130989

Reviewed by Simon Fraser.

Remove this feature flag until we plan to implement.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Mon, 31 Mar 2014 22:14:42 +0000 (22:14 +0000)]
Fix iOS build.

* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
(WebCore::ScrollingTreeScrollingNodeIOS::updateLayersAfterDelegatedScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. iOS build fix after r166532. Add missing comma.
psolanki@apple.com [Mon, 31 Mar 2014 22:04:27 +0000 (22:04 +0000)]
Unreviewed. iOS build fix after r166532. Add missing comma.

* dom/DocumentMarker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd variant of phone number parsing that use DocumentMarker in the current selection
beidson@apple.com [Mon, 31 Mar 2014 21:53:42 +0000 (21:53 +0000)]
Add variant of phone number parsing that use DocumentMarker in the current selection
<rdar://problem/16379566> and https://bugs.webkit.org/show_bug.cgi?id=130917

Reviewed by Darin Adler.

* dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers): Add a new TelephoneNumber document marker type.

* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::scanSelectionForTelephoneNumbers): TextIterate over the selected range looking for numbers.
(WebCore::Editor::scanRangeForTelephoneNumbers): Scan the given range for a telephone number,
  adding the DocumentMarker to any that are found.
(WebCore::Editor::clearDataDetectedTelephoneNumbers):
* editing/Editor.h:

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody): Only linkify on iOS.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintTelephoneNumberMarker): Placeholder UI while the feature is developed.
(WebCore::InlineTextBox::paintDocumentMarkers):
* rendering/InlineTextBox.h:

* testing/Internals.cpp:
(WebCore::markerTypesFrom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WK2] Hook up scroll events for accelerated overflow:scroll
simon.fraser@apple.com [Mon, 31 Mar 2014 21:23:27 +0000 (21:23 +0000)]
[iOS WK2] Hook up scroll events for accelerated overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=130976

Source/WebCore:

Reviewed by Tim Horton.

When an accelerated overflow:scroll is scrolled in the UI process,
tell the WebProcess that the scroll happened to update RenderLayer
state and fire events.

In the WebProcess, RemoteScrollingCoordinator gets a message from the
UI process and calls AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll().
Fixed that function to handle scrolling nodes other than the root, which
required storing a map of ScrollingNodeID->RenderLayer* on RenderLayerCompositor,
accessible through FrameView::scrollableAreaForScrollLayerID().

* WebCore.exp.in:
* page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaForScrollLayerID):
* page/FrameView.h:
* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): Handle
overflow as well as main frame scrolling nodes.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling): Use isScrollingNode().
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling): When an overflow
scroll node was scrolled externally, we have to update layers in decendant nodes,
and then call scrollingTreeNodeDidScroll() which tells the ScrollingCoordinator that
we scrolled.
* page/scrolling/ScrollingTree.h: Try to reduce confusion between the roles played
by these various functions, some of which happen in the UI process with UI-side
compositing.
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h: Need some functions to be
callable by subclasses.
* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
(WebCore::ScrollingTreeScrollingNodeIOS::updateLayersAfterDelegatedScroll):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): Add
scrolling layers to the m_scrollingNodeToLayerMap
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer): Remove
layer from the m_scrollingNodeToLayerMap.
(WebCore::RenderLayerCompositor::scrollableAreaForScrollLayerID):
* rendering/RenderLayerCompositor.h:

Source/WebKit2:

Reviewed by Tim Horton.

When an accelerated overflow:scroll is scrolled in the UI process,
tell the WebProcess that the scroll happened to update RenderLayer
state and fire events.

Add a WKOverflowScrollViewDelegate which is set as the delegate of
UIScrollViews, owned by ScrollingTreeOverflowScrollingNodeIOS, and propagates
-scrollViewDidScroll: messages to ScrollingTree::scrollPositionChangedViaDelegatedScrolling(),
which updates child layers and then, via RemoteScrollingTree::scrollingTreeNodeDidScroll,
tells the RemoteScrollingCoordinator which sends a message to the WebProcess.

* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll): Name change
to try to reduce confusion.
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChanged): Deleted.
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
* UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::scrollingTreeNodeDidScroll):
* UIProcess/Scrolling/RemoteScrollingTree.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
* UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:WebKit::]):
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]):
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]):
(-[WKOverflowScrollViewDelegate scrollViewDidEndScrollingAnimation:]):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateBeforeChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):
* WebProcess/Scrolling/RemoteScrollingCoordinator.mm:
(WebKit::RemoteScrollingCoordinator::scrollPositionChangedForNode): No need for
rounding.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReduced Latched Scroll Test Flakiness
bfulgham@apple.com [Mon, 31 Mar 2014 21:22:42 +0000 (21:22 +0000)]
Reduced Latched Scroll Test Flakiness
https://bugs.webkit.org/show_bug.cgi?id=130983

Reviewed by Darin Adler.

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
* DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
with high resolution flags turned on.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.

LayoutTests:

Rebaseline test output for 'hasPreciseScrollingDeltas' behavior.

* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt:
* platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt:
* platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
* platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename TileCache to LegacyTileCache
antti@apple.com [Mon, 31 Mar 2014 21:18:23 +0000 (21:18 +0000)]
Rename TileCache to LegacyTileCache
https://bugs.webkit.org/show_bug.cgi?id=130986

Reviewed by Simon Fraser.

../WebCore:

Rename iOS WebKit1 tile cache classes to reflect its status.
This also frees some good type names.

TileCache -> LegacyTileCache
TileGrid -> LegacyTileGrid
TileGridTile -> LegacyTileGridTile
etc.

../WebKit/mac:

* WebView/WebView.mm:
(+[WebView drainLayerPool]):
(+[WebView _setTileCacheLayerPoolCapacity:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSmall adjustments to WebCore::IOSurface
timothy_horton@apple.com [Mon, 31 Mar 2014 21:10:44 +0000 (21:10 +0000)]
Small adjustments to WebCore::IOSurface
https://bugs.webkit.org/show_bug.cgi?id=130981

Reviewed by Simon Fraser.

* WebCore.exp.in:
Export some more things.

* platform/graphics/cocoa/IOSurface.h:
createImage() can't be const because it calls ensurePlatformContext().

* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createImage):
We should be able to create an image even if the CGContext has been cleared (or never created).

(IOSurface::isInUse):
Rename inUse() to isInUse().

(IOSurface::clearGraphicsContext):
Add clearGraphicsContext().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAllocate IOSurfaces with the same cache mode that CoreAnimation uses
timothy_horton@apple.com [Mon, 31 Mar 2014 21:08:13 +0000 (21:08 +0000)]
Allocate IOSurfaces with the same cache mode that CoreAnimation uses
https://bugs.webkit.org/show_bug.cgi?id=130982

Reviewed by Simon Fraser.

* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::IOSurface):
CA uses kIOMapWriteCombineCache for IOSurfaces allocated on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Blending] Blend mode property is propagated to multiple GraphicLayers
commit-queue@webkit.org [Mon, 31 Mar 2014 21:07:39 +0000 (21:07 +0000)]
[CSS Blending] Blend mode property is propagated to multiple GraphicLayers
https://bugs.webkit.org/show_bug.cgi?id=130337

Patch by Ion Rosca <rosca@adobe.com> on 2014-03-31
Reviewed by Dean Jackson.

Source/WebCore:

Resets the blend mode for graphicsLayer when it has an ancestorClippingLayer.

Test: css3/compositing/blend-mode-ancestor-clipping-layer.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateBlendMode):
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateBlendMode):
* rendering/RenderLayerBacking.h:

LayoutTests:

* css3/compositing/blend-mode-ancestor-clipping-layer-expected.txt: Added.
* css3/compositing/blend-mode-ancestor-clipping-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Blending] showLayerTree should dump layer's blend mode and isolation properties
commit-queue@webkit.org [Mon, 31 Mar 2014 21:06:48 +0000 (21:06 +0000)]
[CSS Blending] showLayerTree should dump layer's blend mode and isolation properties
https://bugs.webkit.org/show_bug.cgi?id=130922

Patch by Ion Rosca <rosca@adobe.com> on 2014-03-31
Reviewed by Simon Fraser.

Source/WebCore:

This change only updates existing tests involving blending. No new test required,
as there is no new or changed functionality.

* rendering/RenderLayer.h: adding blendMode() getter.
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
adding blendMode property and layer's isolation status (does layer isolate blending descendants or not?).

LayoutTests:

Tests are adapted after adding blending information to RenderTreeAsText.

* platform/mac/css3/compositing/blend-mode-background-expected.txt:
* platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.txt:
* platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.txt:
* platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.txt:
* platform/mac/css3/compositing/blend-mode-layers-expected.txt:
* platform/mac/css3/compositing/blend-mode-reflection-expected.txt:
* platform/mac/css3/compositing/blend-mode-simple-composited-expected.txt:
* platform/mac/css3/compositing/blend-mode-simple-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: clean up the functions ending when generating a checker with context
benjamin@webkit.org [Mon, 31 Mar 2014 21:04:03 +0000 (21:04 +0000)]
CSS JIT: clean up the functions ending when generating a checker with context
https://bugs.webkit.org/show_bug.cgi?id=130959

Reviewed by Andreas Kling.

This code got refactored over time and now both branches do the exact same action
on the stack.
This patch removes the stack split and move the stack cleanup in the common ending
just before restoring the callee saved registers.

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThemeMac should use std::array instead of IntSize* for control sizes
bdakin@apple.com [Mon, 31 Mar 2014 21:00:31 +0000 (21:00 +0000)]
ThemeMac should use std::array instead of IntSize* for control sizes
https://bugs.webkit.org/show_bug.cgi?id=130985

Reviewed by Darin Adler.

Replace uses of const IntSize* with const std::array<IntSize, 3>
* platform/mac/ThemeMac.mm:
(WebCore::sizeFromNSControlSize):
(WebCore::sizeFromFont):
(WebCore::controlSizeFromPixelSize):
(WebCore::setControlSize):
(WebCore::checkboxSizes):
(WebCore::radioSizes):
(WebCore::buttonSizes):
(WebCore::setUpButtonCell):
(WebCore::stepperSizes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Shapes] Simplify RasterShape implementation
hmuller@adobe.com [Mon, 31 Mar 2014 20:55:12 +0000 (20:55 +0000)]
[CSS Shapes] Simplify RasterShape implementation
https://bugs.webkit.org/show_bug.cgi?id=130916

Reviewed by Dean Jackson.

Since only floats can specify shape-outside, the RasterShapeIntervals
class only needs to track the first and last above threshold pixel column
(x1 and x2 in the implementation) for each row. Removed code for dealing with
multiple "runs" per row as well as shape-inside internals.

No new tests, since functionality was only removed.

* rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
(WebCore::RasterShapeIntervals::initializeBounds):
(WebCore::RasterShapeIntervals::buildBoundsPath):
(WebCore::RasterShape::getExcludedIntervals):
* rendering/shapes/RasterShape.h:
(WebCore::RasterShapeIntervals::RasterShapeIntervals):
(WebCore::RasterShapeIntervals::intervalAt):
(WebCore::RasterShape::RasterShape):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createRasterShape):
* rendering/shapes/ShapeInterval.h:
(WebCore::ShapeInterval::unite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBlind Windows build fix. Check my mangle-fu.
akling@apple.com [Mon, 31 Mar 2014 20:48:15 +0000 (20:48 +0000)]
Blind Windows build fix. Check my mangle-fu.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAlways inline toJS() for NodeList.
akling@apple.com [Mon, 31 Mar 2014 20:23:21 +0000 (20:23 +0000)]
Always inline toJS() for NodeList.
<https://webkit.org/b/130974>

This is a pretty cheesy optimization, but it's a 3% progression on
Dromaeo/dom-query.html on my MBP.

Reviewed by Benjamin Poulain.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSNodeListCustom.h: Added.
(WebCore::toJS):
* dom/NodeList.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix the 32bits debug builds
benjamin@webkit.org [Mon, 31 Mar 2014 20:03:26 +0000 (20:03 +0000)]
Attempt to fix the 32bits debug builds

The additional debug flags in RefCounted cause the structure to have different alignment
with the 64bits flags.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-31

* rendering/style/RenderStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix scrolling on OS X with UI-side compositing
simon.fraser@apple.com [Mon, 31 Mar 2014 19:42:04 +0000 (19:42 +0000)]
Fix scrolling on OS X with UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=130930

Reviewed by Tim Horton.

On iOS, we rely on visible rect updates to propagate scroll offset
changes to the WebProcess. RemoteScrollingCoordinatorProxy was thus hardcoded
to bail from scrollPositionChanged() when the scrolled node was the root node,
but this broke OS X. Fix by adding a behavior flag to RemoteScrollingCoordinatorProxy.

* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::RemoteScrollingCoordinatorProxy):
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChanged):
* UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
(WebKit::RemoteScrollingCoordinatorProxy::setPropagatesMainFrameScrolls):
(WebKit::RemoteScrollingCoordinatorProxy::propagatesMainFrameScrolls):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClarify some scrolling tree terminology
simon.fraser@apple.com [Mon, 31 Mar 2014 19:42:02 +0000 (19:42 +0000)]
Clarify some scrolling tree terminology
https://bugs.webkit.org/show_bug.cgi?id=130929

Reviewed by Tim Horton.

Attempt to reduce some ambiguity in scrolling tree terminology.
When async scrolling occurs, there are two tasks we have to perform:
1. Layers need to be updated to reflect the scroll
2. WebCore state has to be updated.
The "updateForViewport" name didn't clearly reflect which of these
tasks was being performed, so rename it to updateLayersAfterViewportChange()
to reflect the fact that it only does the first.

Remove the Mac implementation of updateLayersAfterViewportChange(), since
it was confsued about this, and was never called anyway.

* WebCore.exp.in:
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::viewportChangedViaDelegatedScrolling):
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
* page/scrolling/ios/ScrollingTreeScrollingNodeIOS.mm:
(WebCore::ScrollingTreeScrollingNodeIOS::updateLayersAfterViewportChange):
(WebCore::ScrollingTreeScrollingNodeIOS::updateForViewport): Deleted.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::updateLayersAfterViewportChange):
(WebCore::ScrollingTreeScrollingNodeMac::updateForViewport): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS WebKit2] Disable tile cohort retention for now
timothy_horton@apple.com [Mon, 31 Mar 2014 19:37:30 +0000 (19:37 +0000)]
[iOS WebKit2] Disable tile cohort retention for now
https://bugs.webkit.org/show_bug.cgi?id=130926
<rdar://problem/16465413>

Reviewed by Simon Fraser.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setScrollingPerformanceLoggingEnabled):
(WebCore::Settings::setAggressiveTileRetentionEnabled): Deleted.
* page/Settings.h:
(WebCore::Settings::aggressiveTileRetentionEnabled): Deleted.
* page/Settings.in:
Use Settings.in for these simple settings.

* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::shouldAggressivelyRetainTiles):
(WebCore::GraphicsLayerClient::shouldTemporarilyRetainTileCohorts):
* platform/graphics/TiledBacking.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerShouldAggressivelyRetainTiles):
(WebCore::GraphicsLayerCA::platformCALayerShouldTemporarilyRetainTileCohorts):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerShouldAggressivelyRetainTiles):
(WebCore::PlatformCALayerClient::platformCALayerShouldTemporarilyRetainTileCohorts):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldAggressivelyRetainTiles):
(WebCore::RenderLayerBacking::shouldTemporarilyRetainTileCohorts):
* rendering/RenderLayerBacking.h:
Plumb the two tile-retention settings through to TileController in a pull manner
instead of a push manner, as there were some cases (especially on iOS) where
the settings weren't always getting pushed down.

* platform/graphics/ca/mac/TileController.h:
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tileRevalidationTimerFired):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::drawTileMapContents):
Aggressive tile retention wins over temporary retention. If we aren't
using temporary (cohort) retention, throw away the cohort as soon as it
is created.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add a preference for temporary tile cohort retention (essentially, provide a setting
that means that we will never retain tiles at all once they leave the tile coverage rect).
Defaults to true to maintain existing behavior, except for iOS WebKit2, where
it defaults to false because we don't have the requisite support for purgeable tiles yet.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agorun-webkit-tests should have a --no-timeout option
commit-queue@webkit.org [Mon, 31 Mar 2014 18:15:27 +0000 (18:15 +0000)]
run-webkit-tests should have a --no-timeout option
https://bugs.webkit.org/show_bug.cgi?id=128286

Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-03-31
Reviewed by Joseph Pecoraro.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_test): Renaming _run_test_with_timeout()
(Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
(Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
(Worker._run_test_in_this_thread):
(Worker._run_test_with_timeout): Deleted.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Added the --no-timeout option

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRadio buttons and checkboxes should share code
bdakin@apple.com [Mon, 31 Mar 2014 18:10:37 +0000 (18:10 +0000)]
Radio buttons and checkboxes should share code
https://bugs.webkit.org/show_bug.cgi?id=130915

Reviewed by Sam Weinig.

Radio buttons and checkboxes now share a lot of code. The common term for both is
toggle buttons.

Move these radio-sizing functions up in the file to be next to the checkbox sizing
functions.
* platform/mac/ThemeMac.mm:
(WebCore::radioSizes):
(WebCore::radioMargins):
(WebCore::radioSize):

Configures a radio button or a checkbox.
(WebCore::configureToggleButton):

Creates a radio button or a checkbox.
(WebCore::createToggleButtonCell):

Still have a shared cell for each.
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):

Does the work of the old paintRadio() and paintCheckbox().
(WebCore::paintToggleButton):

Use sharedRadioCell() here.
(WebCore::ThemeMac::inflateControlPaintRect):

Call paintToggleButton() for radio buttons and checkboxes.
(WebCore::ThemeMac::paint):

All gone.
(WebCore::configureCheckbox): Deleted.
(WebCore::createCheckboxCell): Deleted.
(WebCore::paintCheckbox): Deleted.
(WebCore::radio): Deleted.
(WebCore::paintRadio): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Need ability to get line range for text marker.
samuel_white@apple.com [Mon, 31 Mar 2014 18:02:51 +0000 (18:02 +0000)]
AX: Need ability to get line range for text marker.
https://bugs.webkit.org/show_bug.cgi?id=130906

Reviewed by Chris Fleizach.

LayoutTests:

Added test to ensure we can get the correct range of a line from a given marker.
Also updated existing bounds-for-range test to include new attribute.

* platform/mac/accessibility/bounds-for-range-expected.txt:
* platform/mac/accessibility/line-range-for-text-marker-expected.txt: Added.
* platform/mac/accessibility/line-range-for-text-marker.html: Added.

Source/WebCore:

Added ability to get line range from any marker on that line. This matches the functionality of existing
attributes such as AXParagraphTextMarkerRangeForTextMarker and AXSentenceTextMarkerRangeForTextMarker.

Test: platform/mac/accessibility/line-range-for-text-marker.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::visiblePositionRangeForRange):
(WebCore::AccessibilityObject::lineRangeForPosition):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.

* DumpRenderTree/AccessibilityUIElement.cpp:
(lineTextMarkerRangeForTextMarkerCallback):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
andersca@apple.com [Mon, 31 Mar 2014 17:32:32 +0000 (17:32 +0000)]
Fix iOS build.

Source/WebCore:

* page/ChromeClient.h:
(WebCore::ChromeClient::updateViewportConstrainedLayers):

Source/WebKit/ios:

* WebCoreSupport/WebChromeClientIOS.h:
* WebCoreSupport/WebChromeClientIOS.mm:
* WebCoreSupport/WebFixedPositionContent.mm:
* WebCoreSupport/WebFixedPositionContentInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agotransitions/3d/interrupted-transition.html is flaky
ap@apple.com [Mon, 31 Mar 2014 17:13:43 +0000 (17:13 +0000)]
transitions/3d/interrupted-transition.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=130972

* platform/mac/TestExpectations: Marked as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore validation for FTL inline caches
fpizlo@apple.com [Mon, 31 Mar 2014 16:50:15 +0000 (16:50 +0000)]
More validation for FTL inline caches
https://bugs.webkit.org/show_bug.cgi?id=130948

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
* runtime/Options.h:

Tools:

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[MSE][Mac] Support lease-renewal.
jer.noble@apple.com [Mon, 31 Mar 2014 16:43:32 +0000 (16:43 +0000)]
[MSE][Mac] Support lease-renewal.
https://bugs.webkit.org/show_bug.cgi?id=130919

Reviewed by Eric Carlson.

Trigger a new key request when receiving an update message containting "renew".

* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest): Drive-by fix; generate a UTF-8
    based array.
(WebCore::CDMSessionMediaSourceAVFObjC::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomedia/track/track-remove-track.html is flaky, crashing and failing
ap@apple.com [Mon, 31 Mar 2014 16:41:00 +0000 (16:41 +0000)]
media/track/track-remove-track.html is flaky, crashing and failing
https://bugs.webkit.org/show_bug.cgi?id=130971

* platform/mac/TestExpectations: Marked as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove special handling of soft hyphens in search code
ap@apple.com [Mon, 31 Mar 2014 16:32:25 +0000 (16:32 +0000)]
Remove special handling of soft hyphens in search code
https://bugs.webkit.org/show_bug.cgi?id=130940

Reviewed by Anders Carlsson.

ICU knows to ignore soft hyphens, so we don't need to replace them before searching.

Covered by existing tests.

* editing/TextIterator.cpp:
(WebCore::foldQuoteMark):
(WebCore::foldQuoteMarks):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::append):
(WebCore::foldQuoteMarkOrSoftHyphen): Deleted.
(WebCore::foldQuoteMarksAndSoftHyphens): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPreparation for using Soup on Windows.
commit-queue@webkit.org [Mon, 31 Mar 2014 16:30:00 +0000 (16:30 +0000)]
Preparation for using Soup on Windows.
https://bugs.webkit.org/show_bug.cgi?id=130615

Patch by Alex Christensen <achristensen@webkit.org> on 2014-03-31
Reviewed by Carlos Garcia Campos.

Source/WebCore:

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Added Soup source files in WinCairo build.
* loader/soup/CachedRawResourceSoup.cpp:
* loader/soup/SubresourceLoaderSoup.cpp:
* platform/soup/SharedBufferSoup.cpp:
* platform/soup/URLSoup.cpp:
* platform/network/NetworkStorageSessionStub.cpp:
Only build if USE(SOUP) to prevent building when USE(CURL) is true.
* platform/network/soup/ResourceHandleSoup.cpp:
Only include unistd.h in non-Visual Studio builds.
This would normally be done with a HAVE_UNISTD_H macro when compiling glib and Soup,
but that would need to be left undefined for Visual Studio.

Source/WTF:

* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
Add all gobject source files in WinCairo build.
* wtf/gobject/GRefPtr.h:
Export refGPtr and derefGPtr overloads in WTF.dll to fix linker errors with WebKit.dll when using soup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoLLVM IR for store barriers should be nicely arranged and they don't need exception...
fpizlo@apple.com [Mon, 31 Mar 2014 16:21:04 +0000 (16:21 +0000)]
LLVM IR for store barriers should be nicely arranged and they don't need exception checks
https://bugs.webkit.org/show_bug.cgi?id=130950

Reviewed by Mark Hahnenberg.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Do not run WebKit1 unit tests by default
carlosgc@webkit.org [Mon, 31 Mar 2014 15:16:10 +0000 (15:16 +0000)]
[GTK] Do not run WebKit1 unit tests by default
https://bugs.webkit.org/show_bug.cgi?id=130968

Reviewed by Martin Robinson.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CMake] Stop checking for WTF_USE_ICU_UNICODE.
rakuco@webkit.org [Mon, 31 Mar 2014 15:05:36 +0000 (15:05 +0000)]
[CMake] Stop checking for WTF_USE_ICU_UNICODE.
https://bugs.webkit.org/show_bug.cgi?id=130965

Reviewed by Martin Robinson.

This is somewhat of a follow-up to r162782, which got rid of
WTF_USE_ICU_UNICODE in CMake but did not remove the check in JSC's
CMakeLists.txt. This meant the includes and libraries were not
being properly included since then.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166503 268f45cc-cd09-0410-ab3c-d52691b4dbfc