WebKit-https.git
9 years ago2011-06-22 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 23 Jun 2011 01:05:17 +0000 (01:05 +0000)]
2011-06-22  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
        https://bugs.webkit.org/show_bug.cgi?id=63204

        * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
          with similar code for the parameter checking.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
          those done for single lines since they don't make sense in that case (variable decls look like function decls).
          Removed some redundant comments (one of which was slightly wrong).
          Added checks for the new functionality and minor other test changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 01:05:09 +0000 (01:05 +0000)]
2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>

        Build fix after r89472.

        * css/CSSStyleDeclaration.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Thu, 23 Jun 2011 00:57:42 +0000 (00:57 +0000)]
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB open (database) should NOT throw if name is null
        https://bugs.webkit.org/show_bug.cgi?id=63110

        * storage/indexeddb/database-name-undefined-expected.txt:
        * storage/indexeddb/database-name-undefined.html: removed some code here
        because it's duplicated in the mozilla/open-database-null-name test
        * storage/indexeddb/mozilla/open-database-null-name-expected.txt:
        * storage/indexeddb/mozilla/open-database-null-name.html: fixed expected
        behavior (db.name ends up as four-character string "null")
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB open (database) should NOT throw if name is null
        https://bugs.webkit.org/show_bug.cgi?id=63110

        * storage/IDBFactory.idl: remove ConvertNullToNullString flag on
        name argument, let IDL code generator stringify null value to "null"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 00:45:26 +0000 (00:45 +0000)]
2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Add a Position constructor that takes (Text*, unsigned offset)
        https://bugs.webkit.org/show_bug.cgi?id=63181

        Added Position::Position(PassRefPtr<Text*>, unsigned offset) and deployed in a couple of places
        by replacing the calls to the old constructor.

        * dom/Position.cpp:
        (WebCore::Position::Position): Added.
        * dom/Position.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::replaceSelectedTextInNode): Calls new constructor; extracted
        from InsertTextCommand::performTrivialReplace and ReplaceSelectionCommand::performTrivialReplace.
        (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Calls new constructor
        * editing/CompositeEditCommand.h:
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
        (WebCore::InsertTextCommand::input): Calls new constructor.
        (WebCore::InsertTextCommand::insertTab): Use RefPtr instead of a raw pointer.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::performTrivialReplace): Calls replaceSelectedTextInNode.
        * editing/visible_units.cpp:
        (WebCore::startPositionForLine): Calls new constructor.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::visiblePositionForIndex): Calls new constructor; calls endPosition
        on Range instead of avoid manually constructing a VisiblePosition out of endContainer and endOffset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 23 Jun 2011 00:39:10 +0000 (00:39 +0000)]
2011-06-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        [Chromium] Add WebDocument APIs for the functions moving from WebFrame
        https://bugs.webkit.org/show_bug.cgi?id=62831

        * dom/Document.cpp:
        (WebCore::Document::openSearchDescriptionURL):
            - This function exists to service a Chromium WebKit API, but it's
              generally purpose and might be useful to other ports.  The
              algorithm has some strange early exits, which I've marked with
              FIXME comments.
        * dom/Document.h:
2011-06-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Fisher.

        [Chromium] Add WebDocument APIs for the functions moving from WebFrame
        https://bugs.webkit.org/show_bug.cgi?id=62831

        The next phase will be to change all the callers and then remove all
        the code inside the ifdef.

        * public/WebDocument.h:
            - Add new APIs.
        * public/WebFrame.h:
            - These two APIs were too disgusting.  I could not, in good
              conscience, touch them.
        * public/WebSecurityOrigin.h:
            - Turns out this API is supposed to be on WebSecurityOrigin, not
              WebDocument.
        * src/WebDocument.cpp:
            - Implement the APIs.
        (WebKit::WebDocument::url):
        (WebKit::WebDocument::securityOrigin):
        (WebKit::WebDocument::encoding):
        (WebKit::WebDocument::openSearchDescriptionURL):
        (WebKit::WebDocument::forms):
        (WebKit::WebDocument::insertStyleText):
        * src/WebFrameImpl.cpp:
            - Change these implements to just be stubs that call into the real
              implementations in WebDocument.
        (WebKit::WebFrameImpl::url):
        (WebKit::WebFrameImpl::openSearchDescriptionURL):
        (WebKit::WebFrameImpl::encoding):
        (WebKit::WebFrameImpl::forms):
        (WebKit::WebFrameImpl::securityOrigin):
        (WebKit::WebFrameImpl::grantUniversalAccess):
        (WebKit::WebFrameImpl::insertStyleText):
        (WebKit::WebFrameImpl::contentAsMarkup):
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::grantUniversalAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 23 Jun 2011 00:28:56 +0000 (00:28 +0000)]
2011-06-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Add symbols required for window.internals.
        https://bugs.webkit.org/show_bug.cgi?id=62066

        * Source/autotools/symbols.filter:
2011-06-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Test updates for https://bugs.webkit.org/show_bug.cgi?id=62066.

        * fast/preloader/scan-body-from-head-import.html: Use window.internals.
        * fast/preloader/scan-body-from-head-script.html: Use window.internals.
        * http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:
        * http/tests/loading/cross-origin-XHR-willLoadRequest.html:
        * http/tests/loading/preload-append-scan-expected.txt:
        * http/tests/loading/preload-append-scan.php: Use window.internals.
        * http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt:
        * http/tests/misc/link-rel-icon-beforeload-expected.txt:
        * platform/chromium-linux/fast/preloader/scan-body-from-head-script-expected.txt:  Removed.
2011-06-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Don't let all subresources keep isLoadingInAPISense() from
        returning false, only requests that affect
        CachedResourceRequest::requestCount().

        Also, add a callback to Internals to determine whether
        a resource has been preloaded.

        https://bugs.webkit.org/show_bug.cgi?id=62066

        * WebCore.exp.in:
        * dom/Document.cpp: Add m_loadEventFinished.
        * dom/Document.h:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::isLoadingInAPISense):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::isPreloaded):
        * loader/cache/CachedResourceLoader.h:
        * testing/Internals.cpp:
        (WebCore::Internals::isPreloaded):
        * testing/Internals.h:
        * testing/Internals.idl:
2011-06-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Add win symbols for new window.internals functionality.
        https://bugs.webkit.org/show_bug.cgi?id=62066

        * win/WebKit2.def:
2011-06-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Add libsoup to libWebCoreInternals build.
        https://bugs.webkit.org/show_bug.cgi?id=62066

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 23 Jun 2011 00:18:39 +0000 (00:18 +0000)]
2011-06-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: handle missing httpd cleanly
        https://bugs.webkit.org/show_bug.cgi?id=62027

        We had reverted the change in r89414, so this adds it back in
        (modifying check_sys_deps() in port/base.py to check for an
        installed web server).

        This change then fixes the change in r89414 to stub out the
        check_sys_deps() in the test port so that the unit tests run correctly.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out r89469 (Add preference for setting the html parser depth limit)
weinig@apple.com [Thu, 23 Jun 2011 00:17:08 +0000 (00:17 +0000)]
Roll out r89469 (Add preference for setting the html parser depth limit)

The preference is not needed at this time, so there is no reason to expose it.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduc...
jberlin@webkit.org [Thu, 23 Jun 2011 00:16:03 +0000 (00:16 +0000)]
[WebKit2 Tests] plugins/npruntime/embed-property-equality.html failing since introduction in
r88679.
https://bugs.webkit.org/show_bug.cgi?id=63205

Add expected failing result in order to get the bots green.

* platform/mac-wk2/plugins: Added.
* platform/mac-wk2/plugins/npruntime: Added.
* platform/mac-wk2/plugins/npruntime/embed-property-equality-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 23 Jun 2011 00:01:53 +0000 (00:01 +0000)]
2011-06-22  Chris Rogers  <crogers@google.com>

        Reviewed by David Levin.

        Use create() method for AsyncAudioDecoder::DecodingTask
        https://bugs.webkit.org/show_bug.cgi?id=63198

        No new tests.  This doesn't change any JS API.

        * webaudio/AsyncAudioDecoder.cpp:
        (WebCore::AsyncAudioDecoder::decodeAsync):
        (WebCore::AsyncAudioDecoder::DecodingTask::create):
        * webaudio/AsyncAudioDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 22 Jun 2011 23:57:14 +0000 (23:57 +0000)]
2011-06-22  Ojan Vafai  <ojan@chromium.org>

        Update listing for perf tests to list each individual test.
        A number of the tests in this directory are not flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 22 Jun 2011 23:56:22 +0000 (23:56 +0000)]
2011-06-22  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
        https://bugs.webkit.org/show_bug.cgi?id=63188

        * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 23:55:53 +0000 (23:55 +0000)]
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89489.
        http://trac.webkit.org/changeset/89489
        https://bugs.webkit.org/show_bug.cgi?id=63203

        Broke chromium mac build on build.webkit.org (Requested by
        abarth on #webkit).

        * wtf/Platform.h:
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89489.
        http://trac.webkit.org/changeset/89489
        https://bugs.webkit.org/show_bug.cgi?id=63203

        Broke chromium mac build on build.webkit.org (Requested by
        abarth on #webkit).

        * WebCore.gyp/WebCore.gyp:
        * loader/cache/CachedFont.cpp:
        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89489.
        http://trac.webkit.org/changeset/89489
        https://bugs.webkit.org/show_bug.cgi?id=63203

        Broke chromium mac build on build.webkit.org (Requested by
        abarth on #webkit).

        * WebKit.gyp:
        * features.gypi:
        * public/WebCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Wed, 22 Jun 2011 23:53:17 +0000 (23:53 +0000)]
2011-06-22  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by James Robinson.

        Remove comment that snuck in via copy & paste.
        https://bugs.webkit.org/show_bug.cgi?id=63177

        No new tests / no code changes.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::operator short):
        Removed incorrect comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, baseline for a new test added in http://trac.webkit.org/change...
dimich@chromium.org [Wed, 22 Jun 2011 23:51:24 +0000 (23:51 +0000)]
[Chromium] Unreviewed, baseline for a new test added in trac.webkit.org/changeset/89490

* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, rebaseline tests after http://trac.webkit.org/changeset/89475/
dimich@chromium.org [Wed, 22 Jun 2011 23:43:01 +0000 (23:43 +0000)]
[Chromium] Unreviewed, rebaseline tests after trac.webkit.org/changeset/89475/

* platform/chromium-mac-leopard/fast/gradients/gradient-after-transparent-border-expected.png:
* platform/chromium-mac/fast/borders/border-radius-wide-border-01-expected.png: Added.
* platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
* platform/chromium-mac/fast/gradients/gradient-after-transparent-border-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 22 Jun 2011 23:18:57 +0000 (23:18 +0000)]
2011-06-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
        https://bugs.webkit.org/show_bug.cgi?id=61594

        Adds two layout tests to verify that hitting enter in the middle of the span splits the span correctly
        and places the cursor in the correct position.

        * editing/inserting/return-key-before-br-in-span-expected.txt: Added.
        * editing/inserting/return-key-before-br-in-span.html: Added.
        * editing/inserting/return-key-middle-of-span-expected.txt: Added.
        * editing/inserting/return-key-middle-of-span.html: Added.
2011-06-22  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        REGRESSION: Hitting enter in the middle of this span causes the cursor to go to the end of the span
        https://bugs.webkit.org/show_bug.cgi?id=61594

        When the tree is split at the cursor in InsertParagraphSeparatorCommand, it is possible for the position
        split at to be at the end of a text node. The code assumes the position is at the start of the node, so
        pass the correct node into splitTreeToNode() in that case.

        Tests: editing/inserting/return-key-before-br-in-span.html
               editing/inserting/return-key-middle-of-span.html

        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2
jberlin@webkit.org [Wed, 22 Jun 2011 23:09:17 +0000 (23:09 +0000)]
Add more "CONSOLE MESSAGE: line 0: SVG animation pause API missing!" tests to the WK2
Skipped list to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Wed, 22 Jun 2011 22:42:01 +0000 (22:42 +0000)]
2011-06-22  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test with pointer-events and invalid gradient fill fails
        https://bugs.webkit.org/show_bug.cgi?id=63109

        * platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
        * svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg: Added.
        * svg/custom/pointer-events-invalid-fill-expected.txt: Added.
        * svg/custom/pointer-events-invalid-fill.svg: Added.
2011-06-22  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test with pointer-events and invalid gradient fill fails
        https://bugs.webkit.org/show_bug.cgi?id=63109

        Properly detect fill/stroke properties of type SVG_PAINTTYPE_URI_NONE, store it in SVGPaint
        and don't apply the paint if the uri lookup fails.

        Tests: svg/W3C-SVG-1.1-SE/interact-pointer-03-t.svg
               svg/custom/pointer-events-invalid-fill.svg

        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):
        * rendering/svg/RenderSVGResource.cpp:
        (WebCore::requestPaintingResource):
        * svg/SVGPaint.h:
        (WebCore::SVGPaint::createURIAndNone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 22:35:38 +0000 (22:35 +0000)]
2011-06-22  Cary Clark  <caryclark@google.com>

        Reviewed by Darin Fisher.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * wtf/Platform.h:
        Add switch to use Skia if, externally,
        Skia has been enabled by a gyp define.
2011-06-22  Cary Clark  <caryclark@google.com>

        Reviewed by Darin Fisher.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        No new tests. This does not affect existing
        functionality.

        * WebCore.gyp/WebCore.gyp:
        Include Skia and related files and exclude CG
        and related files when building Chromium for Skia
        on the Mac.

        * loader/cache/CachedFont.cpp:
        Rename CHROME to CHROMIUM.

        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        Ditto.
2011-06-22  Cary Clark  <caryclark@google.com>

        Reviewed by Darin Fisher.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * WebKit.gyp:
        If building for Skia, exclude CG files.
        If not, exclude Skia files.

        * features.gypi:
        Enable Skia on Chromium Mac if so instructed by the gyp define.
        Allow Skia to be hardware accelerated on the Mac.

        * public/WebCommon.h:
        If Skia is defined on the Mac, define it in the WebXXX
        interfaces as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 22 Jun 2011 22:28:43 +0000 (22:28 +0000)]
2011-06-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Adam Roben.

        Setting expected results for platform/win
        https://bugs.webkit.org/show_bug.cgi?id=63190

        * platform/win/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected results for some new tests from r87779
aroben@apple.com [Wed, 22 Jun 2011 22:27:50 +0000 (22:27 +0000)]
Add Windows expected results for some new tests from r87779

These differ from Mac due to some small rounding differences in a path.

* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
* platform/win/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 22 Jun 2011 22:12:56 +0000 (22:12 +0000)]
2011-06-22  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62891

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some flaky animation tests on Windows
aroben@apple.com [Wed, 22 Jun 2011 22:07:15 +0000 (22:07 +0000)]
Skip some flaky animation tests on Windows

See <http://webkit.org/b/62561> and <http://webkit.org/b/62569>.

* platform/win/Skipped: Added animations/animation-direction-normal.html and
animations/play-state-paused.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable zoom-svg-through-object-with-*.xhtml
aroben@apple.com [Wed, 22 Jun 2011 22:02:06 +0000 (22:02 +0000)]
Disable zoom-svg-through-object-with-*.xhtml

These tests are flaky. See <http://webkit.org/b/63186>.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
Removed mentions of these tests.

* svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml.
* svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml.
* svg/zoom/page/zoom-svg-through-object-with-auto-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-auto-size.html.
* svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml.
* svg/zoom/page/zoom-svg-through-object-with-override-size.html-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-override-size.html.
* svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml.
* svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Jun 2011 21:52:30 +0000 (21:52 +0000)]
2011-06-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt: don't look for http lock when running the test port
        https://bugs.webkit.org/show_bug.cgi?id=63158

        * Scripts/webkitpy/layout_tests/port/mock_drt.py:
        * Scripts/webkitpy/layout_tests/port/test.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Wed, 22 Jun 2011 21:40:58 +0000 (21:40 +0000)]
2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Set up plugin tests
        https://bugs.webkit.org/show_bug.cgi?id=63066

        * platform/qt-wk2/Skipped:
        Unskip passing plugin tests and create a new group for those
        that still fail for some reason.
2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Set up plugin tests
        https://bugs.webkit.org/show_bug.cgi?id=63066

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createPlugin):
        Force windowless mode for the test plugin because we
        don't support windowed plugins yet.
2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Set up plugin tests
        https://bugs.webkit.org/show_bug.cgi?id=63066

        * WebKitTestRunner/qt/TestControllerQt.cpp:
        (WTR::TestController::initializeTestPluginDirectory):
        Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
        of the test plugin like DRT does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 needs layoutTestController.overridePreference.
jberlin@webkit.org [Wed, 22 Jun 2011 21:38:46 +0000 (21:38 +0000)]
WebKit2 needs layoutTestController.overridePreference.
https://bugs.webkit.org/show_bug.cgi?id=42197

Add more tests that use layoutTestController.overridePreference to the WK2 Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 22 Jun 2011 21:33:35 +0000 (21:33 +0000)]
2011-06-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        Make sheriff-bot rollout messages a little nicer
        https://bugs.webkit.org/show_bug.cgi?id=63107

        It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
        into urls myself.  So I have now fixed its "preparing" message to include a url.

        I also figured that I should make the messages mention all of the responsible parties
        so that rollouts are never surprises.  If you're in the channel and were involved
        in a patch, you will see if someone is using sheriff-bot to rollout a patch.

        As part of doing this I also changed (and tested) _parse_args to fail-fast
        when given invalid args.

        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 22 Jun 2011 21:23:16 +0000 (21:23 +0000)]
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB createIndex should NOT throw if name arg is null
        https://bugs.webkit.org/show_bug.cgi?id=63114

        * storage/indexeddb/mozilla/create-index-null-name-expected.txt:
        * storage/indexeddb/mozilla/create-index-null-name.html:
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB createIndex should NOT throw if name arg is null
        https://bugs.webkit.org/show_bug.cgi?id=63114

        * storage/IDBObjectStore.idl: remove ConvertNullToNullString flag
        so null values will be stringified as "null", as per WebIDL spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Jun 2011 21:14:38 +0000 (21:14 +0000)]
2011-06-22  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        AudioContext needs non-blocking call to create AudioBuffer from audio file data
        https://bugs.webkit.org/show_bug.cgi?id=61947

        No new tests since audio API is not yet implemented.

        * DerivedSources.make:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * webaudio/AsyncAudioDecoder.cpp: Added.
        (WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
        (WebCore::AsyncAudioDecoder::~AsyncAudioDecoder):
        (WebCore::AsyncAudioDecoder::decodeAsync):
        (WebCore::AsyncAudioDecoder::threadEntry):
        (WebCore::AsyncAudioDecoder::runLoop):
        (WebCore::AsyncAudioDecoder::DecodingTask::DecodingTask):
        (WebCore::AsyncAudioDecoder::DecodingTask::decode):
        (WebCore::AsyncAudioDecoder::DecodingTask::notifyCompleteDispatch):
        (WebCore::AsyncAudioDecoder::DecodingTask::notifyComplete):
        * webaudio/AsyncAudioDecoder.h: Added.
        (WebCore::AsyncAudioDecoder::DecodingTask::audioData):
        (WebCore::AsyncAudioDecoder::DecodingTask::sampleRate):
        (WebCore::AsyncAudioDecoder::DecodingTask::successCallback):
        (WebCore::AsyncAudioDecoder::DecodingTask::errorCallback):
        (WebCore::AsyncAudioDecoder::DecodingTask::audioBuffer):
        * webaudio/AudioBufferCallback.h: Added.
        (WebCore::AudioBufferCallback::~AudioBufferCallback):
        * webaudio/AudioBufferCallback.idl: Added.
        * webaudio/AudioContext.cpp:
        (WebCore::AudioContext::decodeAudioData):
        * webaudio/AudioContext.h:
        * webaudio/AudioContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
jberlin@webkit.org [Wed, 22 Jun 2011 20:55:48 +0000 (20:55 +0000)]
REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on
SnowLeopard Intel Release (Tests), Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63178

Add failing expected results in order to get the bots green.

* platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 22 Jun 2011 20:44:42 +0000 (20:44 +0000)]
2011-06-22  Tony Chang  <tony@chromium.org>

        Add test that got renamed.  Should have been included with r89466.

        * storage/indexeddb/keypath-basics.html: Renamed from LayoutTests/storage/indexeddb/keypath-as-array.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63174
bdakin@apple.com [Wed, 22 Jun 2011 20:43:11 +0000 (20:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63174
Don't draw the borders as one path unless there really are 4 borders
-and corresponding-
<rdar://problem/9457997>

Reviewed by Simon Fraser.

Source/WebCore:

If any of the border edges have no width, then allEdgesVisible should be set to
false since borders without width will not be visible.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

* fast/borders/only-one-border-with-width.html: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.png: Added.
* platform/mac/fast/borders/only-one-border-with-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 22 Jun 2011 20:39:01 +0000 (20:39 +0000)]
2011-06-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Oliver Hunt.

        Canvas in layer obscures overlapping span
        https://bugs.webkit.org/show_bug.cgi?id=63161

        Test: compositing/layer-creation/spanOverlapsCanvas.html

        * rendering/RenderLayer.cpp: Added checks for canvas to be layered properly.
        (WebCore::RenderLayer::shouldBeNormalFlowOnly):
        (WebCore::RenderLayer::isSelfPaintingLayer):
2011-06-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Oliver Hunt.

        Canvas in layer obscures overlapping span
        https://bugs.webkit.org/show_bug.cgi?id=63161

        * compositing/layer-creation/spanOverlapsCanvas.html: Added.
        * platform/mac/compositing/layer-creation: Added.
        * platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
        * platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
jberlin@webkit.org [Wed, 22 Jun 2011 20:35:27 +0000 (20:35 +0000)]
REGRESSION (r89426-r89428): inspector/console/console-trace-in-eval.html failing on
SnowLeopard Intel Release (Tests) and Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63175

Add platform-specific results to in order to get the bots green.

* platform/mac/inspector/console: Added.
* platform/mac/inspector/console/console-trace-in-eval-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/JavaScriptCore: * interpreter/RegisterFile.h: Removed unnecessary #include...
ggaren@apple.com [Wed, 22 Jun 2011 20:29:58 +0000 (20:29 +0000)]
Source/JavaScriptCore: * interpreter/RegisterFile.h: Removed unnecessary #include <stdio.h>.

Reviewed by Oliver Hunt.

Source/WebKit2: Removed unnecessary #include <stdio.h>.

Reviewed by Oliver Hunt.

* PluginProcess/mac/PluginProcessMainMac.mm:
* Shared/WebMemorySampler.cpp:
* UIProcess/WebFrameProxy.cpp:
* UIProcess/WebProcessProxy.cpp:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
* WebProcess/mac/WebProcessMac.mm: Added #include back to places where it
was needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 22 Jun 2011 20:17:16 +0000 (20:17 +0000)]
2011-06-22  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        AudioContext noteGrainOn() method should not apply explicit windowing
        https://bugs.webkit.org/show_bug.cgi?id=63005

        No new tests since audio API is not yet implemented.

        * webaudio/AudioBufferSourceNode.cpp:
        (WebCore::AudioBufferSourceNode::readFromBuffer):
        * webaudio/AudioBufferSourceNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jun 2011 20:13:53 +0000 (20:13 +0000)]
2011-06-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        Add preference for setting the html parser depth limit
        https://bugs.webkit.org/show_bug.cgi?id=63163

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setMaximumHTMLParserDOMTreeDepth:]):
        (-[WebPreferences maximumHTMLParserDOMTreeDepth]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChanged:]):
        Add private preference for setting the parser depth limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks.
jberlin@webkit.org [Wed, 22 Jun 2011 20:12:01 +0000 (20:12 +0000)]
WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks.
https://bugs.webkit.org/show_bug.cgi?id=42331

Add another test that uses dumpFrameLoadCallbacks to the WK2 Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r89461.
kbalazs@webkit.org [Wed, 22 Jun 2011 20:11:00 +0000 (20:11 +0000)]
Unreviewed build fix after r89461.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformSetFocus):
Forgot to name the parameter, fix it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Kentaro Hara <haraken@google.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 20:09:05 +0000 (20:09 +0000)]
2011-06-22  Kentaro Hara  <haraken@google.com>

        Reviewed by Tony Chang.

        Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
        https://bugs.webkit.org/show_bug.cgi?id=63054

        At the head of createObjectStore(), we parse |keypath| argument and throw an exception
        if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
        the current keypath parser does not support an array of keypath and (more importantly)
        the current implementation of ObjectStore does not support multiple keypaths.
        We added keypath-basics.html that demonstrates that we do not support an array of keypaths.

        * storage/indexeddb/keypath-as-array-expected.txt: Removed.
        * storage/indexeddb/keypath-as-array.html: Removed.
        * storage/indexeddb/keypath-basics-expected.txt: Added.
        * storage/indexeddb/keypath-basics.html: Added.
2011-06-22  Kentaro Hara  <haraken@google.com>

        Reviewed by Tony Chang.

        Check |keypath| argument of createObjectStore(). Remove storage/indexeddb/keypath-as-array.html.
        https://bugs.webkit.org/show_bug.cgi?id=63054

        At the head of createObjectStore(), we parse |keypath| argument and throw an exception
        if the |keypath| is invalid. With this parsing, we remove keypath-as-array.html because
        the current keypath parser does not support an array of keypath and (more importantly)
        the current implementation of ObjectStore does not support multiple keypaths.
        We added keypath-basics.html that demonstrates that we do not support an array of keypaths.

        Tests: storage/indexeddb/keypath-basics.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        * storage/IDBKeyPath.cpp:
        (WebCore::IDBIsValidKeyPath):
        * storage/IDBKeyPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoved the conceit that global variables are local variables when running global...
ggaren@apple.com [Wed, 22 Jun 2011 20:07:37 +0000 (20:07 +0000)]
Removed the conceit that global variables are local variables when running global code
https://bugs.webkit.org/show_bug.cgi?id=63106

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This is required for write barrier correctness.

SunSpider reports about a 0.5% regression, mostly from bitops-bitwise-and.js.
I was able to reduce the regression with a tiny peephole optimization in
the bytecompiler, but not eliminate it. I'm committing this assuming
that turning on generational GC will win back at least 0.5%.

(FWIW, the DFG JIT can easily eliminate any regression by sharing loads of
the global object's var storage. I considered doing the same kind of
optimization in the existing JIT, but it seemed like moving in the wrong
direction.)

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator): Don't give global variables
negative indices, since they're no longer negatively offset from the
current stack frame.

Do give global variables monotonically increasing positive indices, since
that's much easier to work with.

Don't limit the number of optimizable global variables, since it's no
longer limited by the register file, since they're no longer stored in
the register file.

(JSC::BytecodeGenerator::registerFor): Global code never has any local
registers because a var in global code is actually a property of the
global object.

(JSC::BytecodeGenerator::constRegisterFor): Ditto.

(JSC::BytecodeGenerator::emitResolve): Did a tiny bit of constant
propagation and dead code elimination to speed up our compiles and
reduce WTFs / minute.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor): Removed special handling of globals.

(JSC::BytecodeGenerator::shouldOptimizeLocals): Don't optimize locals in
global code, since there are none.

(JSC::BytecodeGenerator::canOptimizeNonLocals): Do optimize non-locals
in global code (i.e., global vars), since there are some.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::callEval):
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::execute):
* interpreter/Interpreter.h: Updated for deleted / renamed code.

* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::gatherConservativeRoots):
(JSC::RegisterFile::releaseExcessCapacity): Updated for deleted / renamed
data members.

* interpreter/RegisterFile.h:
(JSC::RegisterFile::begin):
(JSC::RegisterFile::size):
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::shrink): Removed all code and comments dealing with
global variables stored in the register file.

(JSC::RegisterFile::grow): Updated for same.

Also, a slight correctness fix: Test the VM commit end, and not just the
in-use end, when checking for stack overflow. In theory, it's invalid to
commit past the end of your allocation, even if you never touch that
memory. This makes the usable size of the stack slightly smaller. No test
because we don't know of any case in practice where this crashes.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData): Updated for changes above.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::resizeRegisters):
(JSC::JSGlobalObject::addStaticGlobals):
* runtime/JSGlobalObject.h: Simplified globals to have monotonically
increasing indexes, always located in our external storage.

LayoutTests:

* fast/js/recursion-limit-equal-expected.txt: Updated to reflect slightly
changed recursion limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html...
jberlin@webkit.org [Wed, 22 Jun 2011 20:06:42 +0000 (20:06 +0000)]
REGRESSION (r89305-r89312): webarchive/loading/mainresource-null-mimetype-crash.html failing
on SnowLeopard Intel Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=63169

Add (failing?) expected results to get the bots green.

* platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed update of test expectations.
dimich@chromium.org [Wed, 22 Jun 2011 20:04:09 +0000 (20:04 +0000)]
[Chromium] Unreviewed update of test expectations.

* platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Added.
* platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Young Han Lee <joybro@company100.net>
commit-queue@webkit.org [Wed, 22 Jun 2011 19:57:13 +0000 (19:57 +0000)]
2011-06-22  Young Han Lee  <joybro@company100.net>

        Reviewed by Simon Fraser.

        animation-timing-function property with a list uses first item for all animations
        https://bugs.webkit.org/show_bug.cgi?id=60303

        When an element has multiple animations that have different timingFunctions,
        the progress of each animation should be calculated using its respective timingFunction.
        But at this point, the timingFunction of the first animation is only used for the
        calculation, regardless of how many animations the element has.

        The code for getting a timingFunction is changed by this patch
        so that the timingFunction of the correct animation searched by its name will be used.

        * animations/multiple-animations-timing-function-expected.txt: Added.
        * animations/multiple-animations-timing-function.html: Added.
2011-06-22  Young Han Lee  <joybro@company100.net>

        Reviewed by Simon Fraser.

        animation-timing-function property with a list uses first item for all animations
        https://bugs.webkit.org/show_bug.cgi?id=60303

        When an element has multiple animations that have different timingFunctions,
        the progress of each animation should be calculated using its respective timingFunction.
        But at this point, the timingFunction of the first animation is only used for the
        calculation, regardless of how many animations the element has.

        The code for getting a timingFunction is changed by this patch
        so that the timingFunction of the correct animation searched by its name will be used.

        Test: animations/multiple-animations-timing-function.html

        * page/animation/KeyframeAnimation.cpp:
        (WebCore::getAnimationFromStyleByName):
        (WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Wed, 22 Jun 2011 19:55:35 +0000 (19:55 +0000)]
2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Darin Adler.

        [X11][WK2] Implement NetscapePlugin::platformSetFocus
        https://bugs.webkit.org/show_bug.cgi?id=63154

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        (WebKit::NetscapePlugin::platformSetFocus):
        Implement focus setting based on the WebKit1 path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 19:55:23 +0000 (19:55 +0000)]
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89407, r89409, r89410, and r89411.
        http://trac.webkit.org/changeset/89407
        http://trac.webkit.org/changeset/89409
        http://trac.webkit.org/changeset/89410
        http://trac.webkit.org/changeset/89411
        https://bugs.webkit.org/show_bug.cgi?id=63168

        Broke Chromium tests for Forms and Autofill (Requested by
        dimich on #webkit).

        * fast/css/text-input-with-webkit-border-radius-expected.txt:
        * fast/forms/search-abs-pos-cancel-button.html:
        * fast/forms/search-cancel-button-mouseup.html:
        * platform/chromium/test_expectations.txt:
        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/gtk/fast/forms/placeholder-position-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/search-transformed-expected.txt:
        * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
        * platform/gtk/fast/forms/search-zoomed-expected.txt:
        * platform/gtk/fast/forms/searchfield-heights-expected.txt:
        * platform/gtk/fast/forms/textfield-overflow-expected.txt:
        * platform/gtk/fast/repaint/search-field-cancel-expected.txt:
        * platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/mac/fast/css/input-search-padding-expected.png:
        * platform/mac/fast/css/input-search-padding-expected.txt:
        * platform/mac/fast/css/pseudo-cache-stale-expected.txt:
        * platform/mac/fast/forms/box-shadow-override-expected.txt:
        * platform/mac/fast/forms/control-restrict-line-height-expected.txt:
        * platform/mac/fast/forms/input-appearance-height-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/mac/fast/forms/placeholder-position-expected.txt:
        * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/mac/fast/forms/placeholder-set-value-expected.txt:
        * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/mac/fast/forms/search-rtl-expected.txt:
        * platform/mac/fast/forms/search-styled-expected.txt:
        * platform/mac/fast/forms/search-transformed-expected.txt:
        * platform/mac/fast/forms/search-vertical-alignment-expected.png:
        * platform/mac/fast/forms/search-vertical-alignment-expected.txt:
        * platform/mac/fast/forms/search-zoomed-expected.txt:
        * platform/mac/fast/forms/searchfield-heights-expected.txt:
        * platform/mac/fast/repaint/search-field-cancel-expected.png:
        * platform/mac/fast/repaint/search-field-cancel-expected.txt:
        * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/qt/fast/css/pseudo-cache-stale-expected.txt:
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/qt/fast/forms/control-restrict-line-height-expected.txt:
        * platform/qt/fast/forms/placeholder-set-value-expected.txt:
        * platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/qt/fast/forms/search-rtl-expected.txt:
        * platform/qt/fast/forms/search-styled-expected.txt:
        * platform/qt/fast/forms/search-transformed-expected.txt:
        * platform/qt/fast/forms/search-vertical-alignment-expected.txt:
        * platform/qt/fast/forms/search-zoomed-expected.txt:
        * platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/win/media/media-controls-clone-expected.txt: Removed.
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89407, r89409, r89410, and r89411.
        http://trac.webkit.org/changeset/89407
        http://trac.webkit.org/changeset/89409
        http://trac.webkit.org/changeset/89410
        http://trac.webkit.org/changeset/89411
        https://bugs.webkit.org/show_bug.cgi?id=63168

        Broke Chromium tests for Forms and Autofill (Requested by
        dimich on #webkit).

        * css/html.css:
        (input[type="search"]::-webkit-search-cancel-button):
        (input[type="search"]::-webkit-search-decoration):
        (input[type="search"]::-webkit-search-results-decoration):
        (input[type="search"]::-webkit-search-results-button):
        (input::-webkit-inner-spin-button):
        (input::-webkit-input-speech-button):
        * html/HTMLInputElement.cpp:
        * html/HTMLInputElement.h:
        * html/InputType.h:
        * html/SearchInputType.cpp:
        (WebCore::SearchInputType::SearchInputType):
        (WebCore::SearchInputType::createShadowSubtree):
        (WebCore::SearchInputType::destroyShadowSubtree):
        * html/SearchInputType.h:
        (WebCore::SearchInputType::innerBlockElement):
        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::TextFieldInputType):
        (WebCore::TextFieldInputType::createShadowSubtree):
        (WebCore::TextFieldInputType::destroyShadowSubtree):
        * html/TextFieldInputType.h:
        (WebCore::TextFieldInputType::innerTextElement):
        (WebCore::TextFieldInputType::innerSpinButtonElement):
        (WebCore::TextFieldInputType::speechButtonElement):
        (WebCore::TextFieldInputType::setInnerTextElement):
        (WebCore::TextFieldInputType::setSpeechButtonElement):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::innerTextElement):
        (WebCore::RenderTextControlSingleLine::layout):
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
        (WebCore::RenderTextControlSingleLine::forwardEvent):
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::hasControlClip):
        (WebCore::RenderTextControlSingleLine::controlClipRect):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
        (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Jun 2011 19:52:25 +0000 (19:52 +0000)]
2011-06-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        run-webkit-websocketserver fails to stop websocket server
        https://bugs.webkit.org/show_bug.cgi?id=63123

        There's a ten-character change in new-run-webkit-websocketserver
        that fixes the actual bug, and then we update the code in
        new-run-webkit-httpd to do the actual stop call, and add more tests
        (refactoring the existing test code so that it is shared).

        * Scripts/new-run-webkit-httpd:
        * Scripts/new-run-webkit-websocketserver:
        * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 19:47:07 +0000 (19:47 +0000)]
2011-06-22  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Add DeviceOrientationClientEfl and DeviceMotionClientEfl.
        https://bugs.webkit.org/show_bug.cgi?id=63125

        Add dummy files to build with ENABLE_DEVICE_ORIENTATION.

        * WebCoreSupport/DeviceMotionClientEfl.cpp: Added.
        (WebCore::DeviceMotionClientEfl::DeviceMotionClientEfl):
        (WebCore::DeviceMotionClientEfl::~DeviceMotionClientEfl):
        (WebCore::DeviceMotionClientEfl::deviceMotionControllerDestroyed):
        (WebCore::DeviceMotionClientEfl::setController):
        (WebCore::DeviceMotionClientEfl::startUpdating):
        (WebCore::DeviceMotionClientEfl::stopUpdating):
        (WebCore::DeviceMotionClientEfl::currentDeviceMotion):
        * WebCoreSupport/DeviceMotionClientEfl.h: Added.
        * WebCoreSupport/DeviceOrientationClientEfl.cpp: Added.
        (WebCore::DeviceOrientationClientEfl::DeviceOrientationClientEfl):
        (WebCore::DeviceOrientationClientEfl::~DeviceOrientationClientEfl):
        (WebCore::DeviceOrientationClientEfl::deviceOrientationControllerDestroyed):
        (WebCore::DeviceOrientationClientEfl::setController):
        (WebCore::DeviceOrientationClientEfl::startUpdating):
        (WebCore::DeviceOrientationClientEfl::stopUpdating):
        (WebCore::DeviceOrientationClientEfl::lastOrientation):
        * WebCoreSupport/DeviceOrientationClientEfl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-20 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 22 Jun 2011 19:39:41 +0000 (19:39 +0000)]
2011-06-20  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Improve speed of heap profiles dominators view.
        https://bugs.webkit.org/show_bug.cgi?id=62979

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotArraySlice.prototype.item):
        (WebInspector.HeapSnapshotArraySlice.prototype.slice):
        (WebInspector.HeapSnapshot.prototype.dispose):
        (WebInspector.HeapSnapshot.prototype._dominatedNodesOfNode):
        (WebInspector.HeapSnapshot.prototype._buildReverseIndex.var):
        (WebInspector.HeapSnapshot.prototype._buildReverseIndex):
        (WebInspector.HeapSnapshot.prototype._buildRetainers):
        (WebInspector.HeapSnapshot.prototype._buildNodeIndex):
        (WebInspector.HeapSnapshot.prototype._buildDominatedNodes):
        (WebInspector.HeapSnapshot.prototype._getDominatedIndex):
        (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass):
        (WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
        (WebInspector.HeapSnapshotFilteredOrderedIterator):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype._createIterationOrder):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get length):
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.serializeNextItems):
        (WebInspector.HeapSnapshotNodesProvider):
        * inspector/front-end/HeapSnapshotProxy.js:
        (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sreeram Ramachandran <sreeram@chromium.org>
commit-queue@webkit.org [Wed, 22 Jun 2011 19:26:46 +0000 (19:26 +0000)]
2011-06-22  Sreeram Ramachandran  <sreeram@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Restore console messages when restoring inspector state
        https://bugs.webkit.org/show_bug.cgi?id=63146

        No new tests (no change in functionality, only in display).

        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::restore):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 22 Jun 2011 19:02:24 +0000 (19:02 +0000)]
2011-06-22  Adam Barth  <abarth@webkit.org>

        Attempt to fix the GTK build after my incomplete rollout of 88332.

        * GNUmakefile.list.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
ademar.reis@openbossa.org [Wed, 22 Jun 2011 18:57:04 +0000 (18:57 +0000)]
2011-06-22  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>

        Reviewed by Holger Freyther.

        [Qt] Fix Qt namespace on QDeclarativeWebView autotest
        https://bugs.webkit.org/show_bug.cgi?id=63147

        Applications (such as the test runner) are not supposed to be wrapped
        by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
        QtWebKit) with a specific namespace won't work (will result in main
        being undefined).

        This was the only test wrapped by these macros, all others are fine.

        * tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
        namespace macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 22 Jun 2011 18:26:03 +0000 (18:26 +0000)]
2011-06-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        HTML parser should limit element depth of produced tree
        https://bugs.webkit.org/show_bug.cgi?id=63082

        Test by:
            fast/parser/block-nesting-cap.html
            fast/parser/element-nesting-cap.html

        * html/parser/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::attach):
        (WebCore::HTMLConstructionSite::HTMLConstructionSite):
        * html/parser/HTMLConstructionSite.h:
        Limit the DOM tree depth by turning attempts to add a child passed a certain
        threshold (configurable by Settings::maximumDOMTreeDepth) into a sibling.

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::maximumDOMTreeDepth):
        * html/parser/HTMLDocumentParser.h:
        Pass the maximumDOMTreeDepth to the TreeBuilder.

        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLElementStack::HTMLElementStack):
        (WebCore::HTMLElementStack::popAll):
        (WebCore::HTMLElementStack::insertAbove):
        (WebCore::HTMLElementStack::pushCommon):
        (WebCore::HTMLElementStack::popCommon):
        (WebCore::HTMLElementStack::removeNonTopCommon):
        * html/parser/HTMLElementStack.h:
        (WebCore::HTMLElementStack::size):
        Keep track of the size of the element stack.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        * html/parser/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::create):
        Pass the maximumDOMTreeDepth to the construction site.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setMaximumHTMLParserDOMTreeDepth):
        (WebCore::Settings::maximumHTMLParserDOMTreeDepth):
        Add a setting to control the maximum DOM tree depth that the parser will produce.
2011-06-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Barth.

        HTML parser should limit element depth of produced tree
        https://bugs.webkit.org/show_bug.cgi?id=63082

        * fast/parser/block-nesting-cap-expected.txt:
        * fast/parser/element-nesting-cap-expected.txt:
        Update expectations for new parser depth limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 22 Jun 2011 18:12:43 +0000 (18:12 +0000)]
2011-06-22  Adam Barth  <abarth@webkit.org>

        Rollout 88332.

        * features.gypi:
        * public/WebRuntimeFeatures.h:
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/WebRuntimeFeatures.cpp:
2011-06-22  Adam Barth  <abarth@webkit.org>

        Rollout 88332.  As discussed on webkit-dev, we'd like to iterate on
        both the API and it's implementation a bit.

        * WebCore.gypi:
        * bindings/generic/RuntimeEnabledFeatures.cpp:
        * bindings/generic/RuntimeEnabledFeatures.h:
        * dom/DocumentMarker.h:
        (WebCore::DocumentMarker::activeMatch):
        * dom/DocumentMarkerController.cpp:
        * dom/DocumentMarkerController.h:
        * html/HTMLDivElement.cpp:
        * html/HTMLDivElement.h:
        * html/HTMLDivElement.idl:
        * html/HTMLInputElement.cpp:
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/HTMLTextAreaElement.cpp:
        * html/HTMLTextAreaElement.h:
        * html/HTMLTextAreaElement.idl:
        * html/SpellcheckRange.cpp: Removed.
        * html/SpellcheckRange.h: Removed.
        * html/SpellcheckRange.idl: Removed.
        * html/SpellcheckRangeList.cpp: Removed.
        * html/SpellcheckRangeList.h: Removed.
        * html/SpellcheckRangeList.idl: Removed.
        * rendering/InlineTextBox.cpp:
        (WebCore::textCheckingLineStyleForMarkerType):
        (WebCore::InlineTextBox::paintDocumentMarkers):
2011-06-22  Adam Barth  <abarth@webkit.org>

        Rollout 88332.

        * editing/spelling/spellcheck-api-expected.txt: Removed.
        * editing/spelling/spellcheck-api-pixel.html: Removed.
        * editing/spelling/spellcheck-api.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Wed, 22 Jun 2011 18:03:33 +0000 (18:03 +0000)]
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB: fix multiple issues in IDBDatabase.idl
        https://bugs.webkit.org/show_bug.cgi?id=63140

        * storage/indexeddb/createObjectStore-name-argument-required-expected.txt: Added.
        * storage/indexeddb/createObjectStore-name-argument-required.html: Added.
        * storage/indexeddb/createObjectStore-null-name-expected.txt: Added.
        * storage/indexeddb/createObjectStore-null-name.html: Added.
        * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt: Added.
        * storage/indexeddb/deleteObjectStore-name-argument-required.html: Added.
        * storage/indexeddb/deleteObjectStore-null-name-expected.txt: Added.
        * storage/indexeddb/deleteObjectStore-null-name.html: Added.
        * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
        * storage/indexeddb/mozilla/create-objectstore-null-name.html:
        * storage/indexeddb/setVersion-null-expected.txt: Added.
        * storage/indexeddb/setVersion-null.html: Added.
        * storage/indexeddb/setVersion-undefined-expected.txt:
        * storage/indexeddb/setVersion-undefined.html:
        * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
        * storage/indexeddb/transaction-and-objectstore-calls.html:
        * storage/indexeddb/transaction-crash-on-abort-expected.txt:
        * storage/indexeddb/transaction-crash-on-abort.html:
        * storage/indexeddb/transaction-read-only-expected.txt:
        * storage/indexeddb/transaction-read-only.html:
        * storage/indexeddb/transaction-storeNames-required-expected.txt: Added.
        * storage/indexeddb/transaction-storeNames-required.html: Added.
2011-06-22  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Adam Barth.

        IndexedDB: fix multiple issues in IDBDatabase.idl
        https://bugs.webkit.org/show_bug.cgi?id=63140

        Tests: storage/indexeddb/createObjectStore-name-argument-required.html
               storage/indexeddb/createObjectStore-null-name.html
               storage/indexeddb/deleteObjectStore-name-argument-required.html
               storage/indexeddb/deleteObjectStore-null-name.html
               storage/indexeddb/setVersion-null.html
               storage/indexeddb/transaction-storeNames-required.html

        * storage/IDBDatabase.idl: remove LegacyDefaultOptionalArguments so
        all functions will throw TypeError when called with too few arguments,
        as per WebIDL spec. Also remove ConvertNullToNullString flags so null
        values are stringified as "null" (also as per WebIDL spec).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Adding a mac platform expected result for webgl test to help fix burning...
mdelaney@apple.com [Wed, 22 Jun 2011 17:53:18 +0000 (17:53 +0000)]
    Adding a mac platform expected result for webgl test to help fix burning bot.
        Filed https://bugs.webkit.org/show_bug.cgi?id=63151 for a real fix

        * platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Wed, 22 Jun 2011 17:51:59 +0000 (17:51 +0000)]
2011-06-22  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Move logic for deciding whether resource content should be base64 encoded on backend.
        https://bugs.webkit.org/show_bug.cgi?id=63069

        * inspector/Inspector.json:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::cachedResourceContent):
        (WebCore::InspectorPageAgent::resourceContent):
        (WebCore::InspectorPageAgent::getResourceContent):
        (WebCore::InspectorPageAgent::searchInResources):
        * inspector/InspectorPageAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.requestContent):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
        (WebInspector.Resource.prototype._innerRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Wed, 22 Jun 2011 17:42:28 +0000 (17:42 +0000)]
2011-06-22  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Support cast from CSSPrimitiveValue to short and use for CSSPropertyWidows and CSSPropertyOrphans.
        https://bugs.webkit.org/show_bug.cgi?id=62964

        No new tests / refactoring only.

        * css/CSSPrimitiveValueMappings.h:
        Support cast to/from short.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Use cast to short to allow CSSPropertWidows and CSSPropertyOrphans to use existing macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd links to existing bugs related to failing tests on TestFailures page
aroben@apple.com [Wed, 22 Jun 2011 17:27:22 +0000 (17:27 +0000)]
Add links to existing bugs related to failing tests on TestFailures page

I changed the layout of the page a little to make it easier to read with all the new
information. Passing/failing revisions have been moved down below the list of tests to be
closer to the existing bugs and the new bug link. And each set of tests and its relevant
information is in a light gray box.

Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
possible

Reviewed by Darin Adler.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
(Bugzilla): This new class represents a single Bugzilla instance.
(Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
passing the resulting bug titles and URLs to the callback when complete. If called multiple
times with the same query before the query returns, caches the callbacks so that only one
query is sent over the wire. When the query completes, all pending callbacks are called.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history): Reduce the margin/padding on the top-level list a bit.
(#failure-history > li): Put each set of tests in a gray box, and indent most information
inside the box.
(.test-list): Unindent the list of failing tests so it is visually at the top level.
(.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
each box isn't a big empty space.
(.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
quite long.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(addQueryParametersToURL): New function extracted from
ViewController.prototype._domForNewAndExistingBugs.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Take and store an optional Bugzilla instance.
(ViewController.prototype._displayBuilder): Give the top-level list an id for styling
purposes and move the list of failing tests above all other information. Only show bug
information once we've determined the most-recent passing revision for a set of tests. It's
not that useful to file a new bug before this information has been determined, and searching
for existing bugs before we've figured out which tests started failing at the same time
would end up giving you information about a bunch of unrelated tests.
(ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
failing tests, and adds links to the bugs when the search completes.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
Bugzilla instance for bugs.webkit.org to the ViewController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Wed, 22 Jun 2011 17:19:10 +0000 (17:19 +0000)]
2011-06-22  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Assertion failure in RenderBlock::createLineBoxes() when a legend has display: inline
        https://bugs.webkit.org/show_bug.cgi?id=23753

        The bug got fixed, so landing the test case.

        * fast/dom/legend-display-inline-expected.txt: Added.
        * fast/dom/legend-display-inline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUndoing possibly incorrect rebaseline from r89434 for webgl test. Filed follow up...
mdelaney@apple.com [Wed, 22 Jun 2011 17:14:49 +0000 (17:14 +0000)]
Undoing possibly incorrect rebaseline from r89434 for webgl test. Filed follow up bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Eunmi Lee <eunmi15.lee@samsung.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 16:57:08 +0000 (16:57 +0000)]
2011-06-22  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Martin Robinson.

        Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
        https://bugs.webkit.org/show_bug.cgi?id=62848

        This patch will make GtkWidgetBackingStore shareable with EFL port.
        It is a preparation to integrate WebKit2's BackingStoreGtk.cpp and
        BackingStoreEfl.cpp as a BackingStoreCairo.cpp.

        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * platform/graphics/cairo/CairoUtilities.cpp:
        (WebCore::copyRectFromOneSurfaceToAnother):
        * platform/graphics/cairo/CairoUtilities.h:
        * platform/cairo/WidgetBackingStore.h: Added.
        * platform/gtk/GtkWidgetBackingStore.h: Removed.
        * platform/gtk/GtkWidgetBackingStoreCairo.cpp:
        (WebCore::createSurfaceForBackingStore):
        (WebCore::WidgetBackingStorePrivate::create):
        (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate):
        (WebCore::WidgetBackingStore::create):
        (WebCore::WidgetBackingStore::WidgetBackingStore):
        (WebCore::WidgetBackingStore::~WidgetBackingStore):
        (WebCore::WidgetBackingStore::cairoSurface):
        (WebCore::WidgetBackingStore::scroll):
        * platform/gtk/GtkWidgetBackingStoreX11.cpp:
        (WebCore::WidgetBackingStorePrivate::create):
        (WebCore::WidgetBackingStorePrivate::~WidgetBackingStorePrivate):
        (WebCore::WidgetBackingStorePrivate::WidgetBackingStorePrivate):
        (WebCore::WidgetBackingStore::create):
        (WebCore::WidgetBackingStore::WidgetBackingStore):
        (WebCore::WidgetBackingStore::~WidgetBackingStore):
        (WebCore::WidgetBackingStore::cairoSurface):
        (WebCore::WidgetBackingStore::scroll):
2011-06-22  Eunmi Lee  <eunmi15.lee@samsung.com>

        Reviewed by Martin Robinson.

        Change GtkWidgetBackingStore.h to WidgetBackingStore.h in order to use in the EFL port.
        https://bugs.webkit.org/show_bug.cgi?id=62848

        Change GtkWidgetBackingStore to WidgetBackingStore in the BackingStore.h and
        gtk/BackingStoreGtk.cpp.

        * UIProcess/BackingStore.h:
        * UIProcess/gtk/BackingStoreGtk.cpp:
        (WebKit::BackingStore::incorporateUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 22 Jun 2011 16:46:33 +0000 (16:46 +0000)]
2011-06-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Update position, bounds and anchor point in GraphicsLayerCA all at once
        https://bugs.webkit.org/show_bug.cgi?id=63148

        Since position, bounds and anchor point are inter-dependent, avoid
        redundant work by simply updating them all at the same time.

        No behavior changes, so no new tests.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setPosition):
        (WebCore::GraphicsLayerCA::setAnchorPoint):
        (WebCore::GraphicsLayerCA::setSize):
        (WebCore::GraphicsLayerCA::setBoundsOrigin):
        (WebCore::GraphicsLayerCA::setAllowTiledLayer):
        (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
        (WebCore::GraphicsLayerCA::updateGeometry):
        (WebCore::GraphicsLayerCA::ensureStructuralLayer):
        (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
        * platform/graphics/ca/GraphicsLayerCA.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 22 Jun 2011 16:45:47 +0000 (16:45 +0000)]
2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Make instantiation of legacy editing position more explicit
        https://bugs.webkit.org/show_bug.cgi?id=63037

        Create new positions since we can't create a legacy editing position outside of WebCore anymore.

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]): Calls createLegacyEditingPosition.
        (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
2011-06-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Make instantiation of legacy editing position more explicit
        https://bugs.webkit.org/show_bug.cgi?id=63037

        Replaced the constructor of Position class that used to instantiate a legacy editing position
        by a function called createLegacyEditingPosition.

        * WebCore.exp.in: Removed the constructor from the list.
        * accessibility/AXObjectCache.cpp:
        (WebCore::AXObjectCache::visiblePositionForTextMarkerData): Calls createLegacyEditingPosition.
        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::nodeTextChangePlatformNotification): No longer uses Positions to instantiate a range.
        * dom/Position.cpp:
        (WebCore::Position::Position): New constructor takes LegacyEditingOffset, which can only be instantiated
        by createLegacyEditingPosition.
        (WebCore::Position::previous): Calls createLegacyEditingPosition.
        (WebCore::Position::next): Ditto.
        (WebCore::Position::upstream): Ditto.
        (WebCore::Position::downstream): Ditto.
        * dom/Position.h: Added new Position::LegacyEditingOffset class to hide the legacy constructor from the world.
        (WebCore::Position::LegacyEditingOffset::value): Added.
        (WebCore::Position::LegacyEditingOffset::LegacyEditingOffset): Added.
        (WebCore::createLegacyEditingPosition): Added.
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position): Calls createLegacyEditingPosition.
        * dom/RangeBoundaryPoint.h:
        (WebCore::RangeBoundaryPoint::toPosition): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::performTrivialReplace): Instantiates new Position instead of old one; this is always
        safe since the anchor node is always a text node.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Calls createLegacyEditingPosition.
        (WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Ditto.
        * editing/markup.cpp:
        (WebCore::StyledMarkupAccumulator::renderedText): Ditto.
        * editing/visible_units.cpp:
        (WebCore::previousBoundary): Ditto.
        (WebCore::previousLinePosition): Ditto.
        (WebCore::nextLinePosition): Ditto.
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::collapse): Ditto.
        (WebCore::DOMSelection::setBaseAndExtent): Ditto.
        (WebCore::DOMSelection::setPosition): Ditto.
        (WebCore::DOMSelection::extend): Ditto.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForBox): Ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::positionForPoint): Calls Position() instead of Position(0, 0).
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition): Calls createLegacyEditingPosition.s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 22 Jun 2011 16:24:52 +0000 (16:24 +0000)]
2011-06-22  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: split setAttributes and setAttributeValue.
        https://bugs.webkit.org/show_bug.cgi?id=63138

        * inspector/elements/set-attribute.html:
        * inspector/elements/set-attribute-expected.txt:
2011-06-22  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: split setAttributes and setAttributeValue.
        https://bugs.webkit.org/show_bug.cgi?id=63138

        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setAttributeValue):
        (WebCore::InspectorDOMAgent::setAttributesText):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode.prototype.setAttribute):
        (WebInspector.DOMNode.prototype.setAttributeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 22 Jun 2011 16:21:33 +0000 (16:21 +0000)]
2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Apply current view settings to newly created views in GtkLauncher
        https://bugs.webkit.org/show_bug.cgi?id=63142

        * GtkLauncher/main.c:
        (createWebViewCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded rev to ChangeLog for tree burning fix.
mdelaney@apple.com [Wed, 22 Jun 2011 16:20:07 +0000 (16:20 +0000)]
Added rev to ChangeLog for tree burning fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use an alpha channel when drawing the web page on Windows
aroben@apple.com [Wed, 22 Jun 2011 16:11:54 +0000 (16:11 +0000)]
Don't use an alpha channel when drawing the web page on Windows

We never use the alpha channel in the end anyway (because we never render into a layered
window, which is the only kind of window that supports alpha). And using an alpha channel is
tricky to get right since GDI doesn't support alpha (and often writes 0x0 into the alpha
channel).

Fixes <http://webkit.org/b/63075> <rdar://problem/9648113> REGRESSION (r88978): Text inside
form controls looks really awful on Windows XP

Reviewed by Anders Carlsson.

* WebProcess/WebPage/win/DrawingAreaImplWin.cpp:
(WebKit::DrawingAreaImpl::createGraphicsContext): Specify false for the hasAlpha parameter
to the GraphicsContext constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 22 Jun 2011 16:03:55 +0000 (16:03 +0000)]
2011-06-22  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        video-loop.html sometimes fails on slow system
        https://bugs.webkit.org/show_bug.cgi?id=63143

        * media/video-loop.html: Don't seek if an exception will be generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fixing burning mac SL trees. These tests's expected results needed
mdelaney@apple.com [Wed, 22 Jun 2011 15:57:33 +0000 (15:57 +0000)]
    Fixing burning mac SL trees. These tests's expected results needed
        updating after parts of them were fixed recently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 22 Jun 2011 15:44:04 +0000 (15:44 +0000)]
2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination()
        https://bugs.webkit.org/show_bug.cgi?id=61627

        Don't use Connection::setShouldCloseConnectionOnProcessTermination() for the
        GTK port, when the process finishes the connection is closed and
        the other process is already notified. We still need to monitor
        the child process so that it doesn't become a zombie when it dntabi

        * Platform/CoreIPC/Connection.h:
        * Platform/CoreIPC/unix/ConnectionUnix.cpp:
        * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
        (WebKit::childFinishedFunction):
        (WebKit::ProcessLauncher::launchProcess):
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::didFinishLaunching):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 22 Jun 2011 15:27:54 +0000 (15:27 +0000)]
2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use GOption to parse main arguments in GtkLauncher
        https://bugs.webkit.org/show_bug.cgi?id=63060

        Instead of getting the settings from the view, create a new
        settings object not associated with any view so that we can parse
        the command line arguments before creating the view. It will also
        allows to use the same settings for more than one view if we
        eventually support passing more than one uri from the command
        line.

        * GtkLauncher/main.c:
        (parseOptionEntryCallback): Make this function static. Also use
        g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
        of atoi/atof to provide better error messages. And always fill the
        error struct when the function fails.
        (getOptionEntriesFromWebKitWebSettings): Use an array of
        GOptionEntry structs instead of a GArray, since that is what
        g_option_group_add_entries() expects and the array size doesn't
        change.
        (addWebSettingsGroupToContext): Helper function to add the
        websettings group to the option context.
        (main): Create the option context to parse command line arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 22 Jun 2011 15:24:53 +0000 (15:24 +0000)]
2011-06-22  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Animate viewBox attribute in SVG
        https://bugs.webkit.org/show_bug.cgi?id=20057

        Test SVGRect animation with from-to and from-by animations.

        * svg/animations/script-tests/svgrect-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/svgrect-animation-2.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgrect-animation-1-expected.txt: Added.
        * svg/animations/svgrect-animation-1.html: Added.
        * svg/animations/svgrect-animation-2-expected.txt: Added.
        * svg/animations/svgrect-animation-2.html: Added.
2011-06-22  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Animate viewBox attribute in SVG
        https://bugs.webkit.org/show_bug.cgi?id=20057

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGRect. With the new animator we support
        interpolation between SVGRects. A feature that can be used to get smooth zooming animations for SVGs.

        Added parseRect() to SVGParserUtilities for parsing Strings to FloatRects.

        Tests: svg/animations/svgrect-animation-1.html
               svg/animations/svgrect-animation-2.html

        * CMakeLists.txt: Added new file SVGAnimatedRect.cpp to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/FloatRect.h: Added new operators + and +=.
        (WebCore::operator+=):
        (WebCore::operator+):
        * svg/SVGAllInOne.cpp: Added SVGAnimatedRect.cpp for Win build.
        * svg/SVGAnimateElement.cpp: Handle AnimatedRect explicitly.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType): Ditto.
        (WebCore::SVGAnimateElement::calculateAnimatedValue): Ditto.
        (WebCore::SVGAnimateElement::calculateFromAndToValues): Ditto.
        (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
        (WebCore::SVGAnimateElement::resetToBaseValue): Ditto.
        (WebCore::SVGAnimateElement::applyResultsToTarget): Ditto.
        (WebCore::SVGAnimateElement::calculateDistance): Ditto.
        * svg/SVGAnimatedRect.cpp: Added. The new Animator for SVGRect.
        (WebCore::SVGAnimatedRectAnimator::SVGAnimatedRectAnimator):
        (WebCore::SVGAnimatedRectAnimator::constructFromString):
        (WebCore::SVGAnimatedRectAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedRectAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedRectAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedRectAnimator::calculateDistance):
        * svg/SVGAnimatedRect.h:
        (WebCore::SVGAnimatedRectAnimator::~SVGAnimatedRectAnimator):
        * svg/SVGAnimatedType.cpp: Support for FloatRect.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createRect):
        (WebCore::SVGAnimatedType::rect):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):
        * svg/SVGParserUtilities.cpp: Parse String as FloatRect.
        (WebCore::parseRect):
        * svg/SVGParserUtilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 22 Jun 2011 14:38:56 +0000 (14:38 +0000)]
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        1) Introduce FileChooserSettings to decouple setting querying from
        FileChooser. It's a simple copyable settings object, which allows us
        to capture the settings atomically and treat them as discardable data.

        2) Encapsulate lifetime management of FileChooser entirely in
        FileChooserClient. It's now a "smart" client, and allows us to
        completely remove FileChooser management concerns from a FileChooserClient
        implementor.

        3) Change creation of FileChooser to be on-demand, only when we actually
        need to choose file.

        4) Rearrange calling of dispatchFormControlChangeEvent to be at the end
        of a function and remove "am-I-dead" checks that are now unnecessary.

        5) Clean up directory upload code a bit, and make use of FileChooserSettings
        to pass directory name.

        Refactoring, covered by existing tests.

        * WebCore.exp.in: Removed unneeded export.
        * loader/EmptyClients.h: Removed now-unneded param.
        (WebCore::EmptyChromeClient::enumerateChosenDirectory): Ditto.
        * page/Chrome.cpp:
        (WebCore::Chrome::enumerateChosenDirectory): Ditto.
        * page/Chrome.h: Ditto.
        * page/ChromeClient.h: Ditto.
        * platform/FileChooser.cpp:
        (WebCore::FileChooserClient::~FileChooserClient): Added discarding of chooser.
        (WebCore::FileChooserClient::newFileChooser): Added.
        (WebCore::FileChooserClient::discardChooser): Added.
        (WebCore::FileChooser::FileChooser): Changed to use FileChooserSettings.
        (WebCore::FileChooser::create): Ditto.
        (WebCore::FileChooser::~FileChooser): Removed unneeded code.
        (WebCore::FileChooser::chooseFiles): Changed to pass results to the client.
        * platform/FileChooser.h:
        (WebCore::FileChooser::settings): Added.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::filenamesFromFileList): Added a helper.
        (WebCore::RenderFileUploadControl::RenderFileUploadControl): Changed to use the helper, removed
            chooser initialization code.
        (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed disconnection code, now
            handled in FileChooserClient.
        (WebCore::RenderFileUploadControl::filesChosen): Renamed from valueChanged, rearranged to
            fire dispatchFormControlChangeEvent last.
        (WebCore::RenderFileUploadControl::receiveDropForDirectoryUpload): Changed to use settings.
        (WebCore::RenderFileUploadControl::click): Ditto.
        (WebCore::RenderFileUploadControl::updateFromElement): Removed now-unneeded check.
        (WebCore::RenderFileUploadControl::receiveDroppedFiles): Changed to avoid using the chooser, since
            it is not necessary.
        (WebCore::RenderFileUploadControl::fileTextValue): Changed to use input data, not chooser data.
        * rendering/RenderFileUploadControl.h: Updated decls.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::runOpenPanel): Changed to use settings.
        (WebKit::ChromeClientImpl::enumerateChosenDirectory): Updated decls.
        * src/ChromeClientImpl.h:
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::runOpenPanel): Changed to use settings.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::runOpenPanel): Changed to use settings.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::runOpenPanel): Changed to use settings.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::runOpenPanel): Changed to use settings.
2011-06-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        FileChooser should be only created when we need to choose files.
        https://bugs.webkit.org/show_bug.cgi?id=63039

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::runOpenPanel): Changed to use settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 22 Jun 2011 14:13:27 +0000 (14:13 +0000)]
2011-06-22  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: DOMAgent.resolveNode should receive objectGroup.
        https://bugs.webkit.org/show_bug.cgi?id=63137

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::wrapNode):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::resolveNode):
        (WebCore::InspectorDOMAgent::buildObjectForEventListener):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDOMDebuggerAgent.cpp:
        (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::resume):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype.update.callback):
        (WebInspector.EventListenersSidebarPane.prototype.update):
        (.):
        ():
        * inspector/front-end/PropertiesSidebarPane.js:
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.resolveNode):
        (WebInspector.RemoteObjectProperty.fromPrimitiveValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Jun 2011 14:08:34 +0000 (14:08 +0000)]
2011-06-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: fix exceptions in scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=62865

        Resource.requestContent callback may be fired after navigation when scripts panel
        is already reset.

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._addScript.contentChanged):
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory):
        (WebInspector.ScriptsPanel.prototype._filesSelectChanged):
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile.prototype.reload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 22 Jun 2011 14:01:12 +0000 (14:01 +0000)]
2011-06-22  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, apply a couple of Chromium test expectation changes to test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 13:49:45 +0000 (13:49 +0000)]
2011-06-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] Implement pixel dump support for WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=58242

        * GNUmakefile.am: Reference the new ImageDiff GNUmakefile.
2011-06-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] Implement pixel dump support for WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=58242

        * GNUmakefile.am: Added new Cairo specific image handling files to the build.
        * Shared/API/c/cairo/WKImageCairo.cpp: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp.
        (WKImageCreateCairoSurface): Added
        (WKImageCreateFromCairoSurface): Added
        * Shared/API/c/cairo/WKImageCairo.h: Copied from Source/WebKit2/Shared/cairo/ShareableBitmapCairo.cpp.
2011-06-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] Implement pixel dump support for WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=58242

        * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
        * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
        * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
        * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
        * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
        file so that we can share it across platforms.
        (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
        * WebKitTestRunner/TestInvocation.h: Updated method list.
        * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
        * WebKitTestRunner/cg/TestInvocationCG.cpp:
        (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Wed, 22 Jun 2011 13:34:59 +0000 (13:34 +0000)]
2011-06-21  Michael Saboff  <msaboff@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (r88260): Assertion failure in FontCache::getCachedFontData when typing in Safari's address field
        https://bugs.webkit.org/show_bug.cgi?id=63078

        Added FontCachePurgePreventer in WebCore::WebCoreTextFloatWidth to handle
        assertion failure when typing in address field on windows.  Investigated
        other possible code paths that need purge prevention.  Added
        FontCachePurgeProtection to WebCore::createDragImageForLink and
        WebCore::doDrawTextAtPoint.

        No change to functionality, therefore no new tests.

        * platform/win/DragImageWin.cpp:
        (WebCore::createDragImageForLink):
        * platform/win/WebCoreTextRenderer.cpp:
        (WebCore::doDrawTextAtPoint):
        (WebCore::WebCoreTextFloatWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 22 Jun 2011 12:31:49 +0000 (12:31 +0000)]
2011-06-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        A couple setTextAsOfLastFormControlChangeEvent tweaks
        https://bugs.webkit.org/show_bug.cgi?id=63108

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::insertedIntoDocument): Use
        emptyString() instead of String("") because it is better style and faster.

        * html/HTMLFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent
        non-virtual so it actually gets inlined, since there are no overrides of it.
        Also make it take a const String& to avoid unnecessary reference count churn.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Update platform specific exprected results after r89367 and r89381.
ossy@webkit.org [Wed, 22 Jun 2011 11:47:54 +0000 (11:47 +0000)]
[Qt] Unreviewed. Update platform specific exprected results after r89367 and r89381.

* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
* platform/qt/svg/custom/pointer-events-text-expected.png:
* platform/qt/svg/custom/pointer-events-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 22 Jun 2011 11:25:38 +0000 (11:25 +0000)]
2011-06-22  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, fix a syntax error in the last change in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 11:22:16 +0000 (11:22 +0000)]
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89414.
        http://trac.webkit.org/changeset/89414
        https://bugs.webkit.org/show_bug.cgi?id=63130

        It broke webkitpy tests (Requested by Ossy on #webkit).

        * Scripts/webkitpy/layout_tests/port/base.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 11:15:11 +0000 (11:15 +0000)]
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89402.
        http://trac.webkit.org/changeset/89402
        https://bugs.webkit.org/show_bug.cgi?id=63129

        It made 6 tests crash (Requested by Ossy on #webkit).

        * dom/DataTransferItem.cpp:
        (WebCore::DataTransferItem::DataTransferItem):
        * dom/DataTransferItem.h:
        * dom/DataTransferItems.cpp:
        (WebCore::DataTransferItems::DataTransferItems):
        * dom/DataTransferItems.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
        * editing/CompositeEditCommand.h:
        * page/WebKitAnimationList.cpp:
        (WebCore::WebKitAnimationList::append):
        (WebCore::WebKitAnimationList::insertAnimation):
        * page/WebKitAnimationList.h:
        (WebCore::WebKitAnimationList::create):
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::FEImage):
        (WebCore::FEImage::create):
        * svg/graphics/filters/SVGFEImage.h:
        * svg/graphics/filters/SVGFilterBuilder.cpp:
        (WebCore::SVGFilterBuilder::SVGFilterBuilder):
        (WebCore::SVGFilterBuilder::add):
        (WebCore::SVGFilterBuilder::appendEffectToEffectReferences):
        * svg/graphics/filters/SVGFilterBuilder.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didConnectCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        (WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::setWebSocketChannel):
        (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadCreateWebSocketChannel):
        * websockets/WorkerThreadableWebSocketChannel.h:
        (WebCore::WorkerThreadableWebSocketChannel::Peer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 22 Jun 2011 11:10:49 +0000 (11:10 +0000)]
2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89368.
        http://trac.webkit.org/changeset/89368
        https://bugs.webkit.org/show_bug.cgi?id=63128

        It made http/tests/inspector/extensions-resources-
        redirect.html crash (Requested by Ossy on #webkit).

        * inspector/Inspector.json:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::cachedResourceContent):
        (WebCore::InspectorPageAgent::resourceContent):
        (WebCore::InspectorPageAgent::getResourceContent):
        (WebCore::InspectorPageAgent::searchInResources):
        * inspector/InspectorPageAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::getResourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkManager.prototype.requestContent):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._innerRequestContent.onResourceContent):
        (WebInspector.Resource.prototype._innerRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 22 Jun 2011 10:52:14 +0000 (10:52 +0000)]
2011-06-22  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, add Chromium test expectations for tests started to fail since V8 3.4.5.1 roll.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 22 Jun 2011 10:22:15 +0000 (10:22 +0000)]
2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Make sure libsoup password manager macro is defined before including libsoup in webkitsoupauthdialog
        https://bugs.webkit.org/show_bug.cgi?id=63124

        Fixes a crash when building with --enable-debug.

        * webkit/webkitsoupauthdialog.h: Define
        LIBSOUP_I_HAVE_READ_BUG_594377_AND_KNOW_SOUP_PASSWORD_MANAGER_MIGHT_GO_AWAY
        before including libsoup.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Wed, 22 Jun 2011 10:16:09 +0000 (10:16 +0000)]
2011-06-22  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed, check in new Chromium-Leopard baselines.

        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/custom/pointer-events-text-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 22 Jun 2011 09:35:35 +0000 (09:35 +0000)]
2011-06-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use stack trace to create anchors for console messages.
        https://bugs.webkit.org/show_bug.cgi?id=62856

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._completions.reportCompletions):
        (WebInspector.ConsoleView.prototype._completions):
        (WebInspector.ConsoleMessage.prototype._formatMessage):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._updateAnchor):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.createAnchor):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.createAnchor):
        (WebInspector.ScriptsPanel.prototype.showAnchorLocation):
        (WebInspector.ScriptsPanel.prototype._updateAnchor):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyResourceAsNode):
        (WebInspector.linkifyCallFrameAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
commit-queue@webkit.org [Wed, 22 Jun 2011 08:22:33 +0000 (08:22 +0000)]
2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Dirk Pranke.

        [NRWT] Print error message when there is no httpd present on the system
        https://bugs.webkit.org/show_bug.cgi?id=62027

        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Jun 2011 07:12:36 +0000 (07:12 +0000)]
2011-06-22  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, whitespace expectations change to trigger a round of
        builds.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 22 Jun 2011 06:37:05 +0000 (06:37 +0000)]
2011-06-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.
        Fix crashes in new-run-webkit-tests resulting from the
        change to the http_server logic in r89400. Python 2.5
        on Mac 10.5 has some weird error paths.

        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/common/system/executive.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Jun 2011 06:07:08 +0000 (06:07 +0000)]
2011-06-21  Kent Tamura  <tkent@chromium.org>

        [Win][Mac] Correct an accidental change in r89410.

        * platform/mac/media/media-controls-clone-expected.txt:
        * platform/win/media/media-controls-clone-expected.txt: Copied from LayoutTests/platform/mac/media/media-controls-clone-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Jun 2011 05:43:58 +0000 (05:43 +0000)]
2011-06-21  Kent Tamura  <tkent@chromium.org>

        [Win][GTK] Test expectation update for r89407.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/pseudo-cache-stale-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/gtk/fast/forms/placeholder-position-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/search-transformed-expected.txt:
        * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
        * platform/gtk/fast/forms/search-zoomed-expected.txt:
        * platform/gtk/fast/forms/searchfield-heights-expected.txt:
        * platform/gtk/fast/forms/textfield-overflow-expected.txt:
        * platform/gtk/fast/repaint/search-field-cancel-expected.txt:
        * platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
        * platform/mac/media/media-controls-clone-expected.txt:
        * platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/win/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/win/fast/forms/search-placeholder-value-changed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Jun 2011 05:08:59 +0000 (05:08 +0000)]
2011-06-21  Kent Tamura  <tkent@chromium.org>

        [Qt] Test expectation update for r89407.

        * platform/qt/fast/css/pseudo-cache-stale-expected.txt:
        * platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/qt/fast/forms/control-restrict-line-height-expected.txt:
        * platform/qt/fast/forms/placeholder-set-value-expected.txt:
        * platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/qt/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/qt/fast/forms/search-rtl-expected.txt:
        * platform/qt/fast/forms/search-styled-expected.txt:
        * platform/qt/fast/forms/search-transformed-expected.txt:
        * platform/qt/fast/forms/search-vertical-alignment-expected.txt:
        * platform/qt/fast/forms/search-zoomed-expected.txt:
        * platform/qt/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Jun 2011 05:03:48 +0000 (05:03 +0000)]
2011-06-21  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectation for some speech tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 22 Jun 2011 04:36:29 +0000 (04:36 +0000)]
2011-06-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Avoid custom layout code of RenderTextControlSingleLine
        https://bugs.webkit.org/show_bug.cgi?id=61415

        Update tests including <input type=search> or <input type=number>. Their
        internal structures are changed.
        Slight position changes for search result buttons and search cancel
        buttons are expected.

        * fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/css/input-search-padding-expected.png:
        * platform/mac/fast/css/input-search-padding-expected.txt:
        * platform/mac/fast/css/pseudo-cache-stale-expected.txt:
        * platform/mac/fast/forms/box-shadow-override-expected.txt:
        * platform/mac/fast/forms/control-restrict-line-height-expected.txt:
        * platform/mac/fast/forms/input-appearance-height-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
        * platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
        * platform/mac/fast/forms/placeholder-position-expected.txt:
        * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/mac/fast/forms/placeholder-set-value-expected.txt:
        * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
        * platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/mac/fast/forms/search-rtl-expected.txt:
        * platform/mac/fast/forms/search-styled-expected.txt:
        * platform/mac/fast/forms/search-transformed-expected.txt:
        * platform/mac/fast/forms/search-vertical-alignment-expected.png:
        * platform/mac/fast/forms/search-vertical-alignment-expected.txt:
        * platform/mac/fast/forms/search-zoomed-expected.txt:
        * platform/mac/fast/forms/searchfield-heights-expected.txt:
        * platform/mac/fast/repaint/search-field-cancel-expected.png:
        * platform/mac/fast/repaint/search-field-cancel-expected.txt:
        * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
        * platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
        * platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
        * fast/forms/search-cancel-button-mouseup.html: Adjust click position for the cancel button.
        * fast/forms/search-abs-pos-cancel-button.html: ditto.
2011-06-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Avoid custom layout code of RenderTextControlSingleLine
        https://bugs.webkit.org/show_bug.cgi?id=61415

        If a text field has a search results button, a search cancel
        button, a speech button, or a spin button, the editable inner text
        element and they are wrapped by a flexible box container, and the
        editable inner text element has flexibility.
        As the result of applying the flexible box, we don't need any
        horizontal layout code in RenderTextControlSingleLine except the
        inner spin button.

        Also, we remove custom hit-testing code in nodeAtPoint(). If a
        user clicks on a position left of the inner editable text but not
        on the search results button, the search results button doesn't
        work though it worked.

        * css/html.css:
        (input::-webkit-textfield-decoration-container):
          New style definition for the "container" element.
        (input[type="search"]::-webkit-search-cancel-button):
          It should be a block element because it's a child of the flexible box.
          Also, this doesn't have flexibility.
        (input[type="search"]::-webkit-search-decoration): ditto.
        (input[type="search"]::-webkit-search-results-decoration): ditto.
        (input[type="search"]::-webkit-search-results-button): ditto.
        (input::-webkit-inner-spin-button): ditto.
        (input::-webkit-input-speech-button): ditto.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::containerElement):
          Add an accessor of the flexible box container.
          It just calls InputType::containerElement().
        * html/HTMLInputElement.h: Declare it.
        * html/InputType.h:
        (WebCore::InputType::containerElement): New accessor for a shadow element.
        * html/SearchInputType.cpp:
        (WebCore::SearchInputType::SearchInputType):
          m_innerBlock is moved to TextFieldInputType.
        (WebCore::SearchInputType::needsContainer):
          A search field always needs the flexible box container because
          of the results button and the cancel button.
        (WebCore::SearchInputType::createShadowSubtree):
          Use TextFieldInputType::createShadowSubtree(), then modify the tree.
        (WebCore::SearchInputType::destroyShadowSubtree):
          m_innerBlock is moved to TextFieldInputType.
        * html/SearchInputType.h:
        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::TextFieldInputType):
          Initialize the new members.
        (WebCore::TextFieldInputType::needsContainer):
          Returns true if x-webkit-speech. We check a spin button separately.
        (WebCore::TextFieldInputType::createShadowSubtree):
          Wrap everything with the flexible box container if needsContainer() or we need a spin button.
        (WebCore::TextFieldInputType::containerElement): Added an accessor.
        (WebCore::TextFieldInputType::innerBlockElement): ditto.
        (WebCore::TextFieldInputType::innerTextElement): ditto.
        (WebCore::TextFieldInputType::innerSpinButtonElement): ditto.
        (WebCore::TextFieldInputType::speechButtonElement): ditto.
        (WebCore::TextFieldInputType::destroyShadowSubtree):
          Clear references to new shadow nodes.
        * html/TextFieldInputType.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::containerElement): Added an accessor.
        (WebCore::RenderTextControlSingleLine::innerTextElement):
        (WebCore::RenderTextControlSingleLine::layout):
         - Correct heights check
          Comparing with height(), not contentHeigth(), was incorrect.
         - Adjust the container height like the editable inner text.
         - Remove width adjustment
         - Remove the speech button layout code
          The flexible box layout is enough.
        (WebCore::RenderTextControlSingleLine::nodeAtPoint):
          Remove custom code for results/cancel/speech buttons, and
          Simplify comments.
        (WebCore::RenderTextControlSingleLine::forwardEvent):
          Remove custom forwarding code for results/cancel buttons.
        (WebCore::RenderTextControlSingleLine::styleDidChange):
          Clear the style of the container because we update it in layout().
        (WebCore::RenderTextControlSingleLine::hasControlClip):
          Decoration buttons should be clipped by the container.
        (WebCore::RenderTextControlSingleLine::controlClipRect): ditto.
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
          We don't need to use display:inline-block any more.
        (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
          The text wrapper element should have flexibility.
        (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
          Updated for the tree structure change.
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 22 Jun 2011 04:15:14 +0000 (04:15 +0000)]
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * configure.ac:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * Configurations/FeatureDefines.xcconfig:
        * JavaScriptCore.xcodeproj/project.pbxproj:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * CMakeLists.txt:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * features.pri:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * Configurations/FeatureDefines.xcconfig:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * Configurations/FeatureDefines.xcconfig:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * Scripts/build-webkit:
        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2011-06-21  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r89401 and r89403.
        http://trac.webkit.org/changeset/89401
        http://trac.webkit.org/changeset/89403
        https://bugs.webkit.org/show_bug.cgi?id=62970

        Breaks mac build and mistakenly enables the spellcheck API

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89406 268f45cc-cd09-0410-ab3c-d52691b4dbfc