WebKit-https.git
10 years ago2009-10-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 10:36:44 +0000 (10:36 +0000)]
2009-10-07  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        getChildrenWithRange expects as last parameter the end index, not
        the length of the range. Correct this and clarify the variable
        names to reflect how the code works.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::getChildrenWithRange):
        (AccessibilityUIElement::getChildAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 7 Oct 2009 09:32:06 +0000 (09:32 +0000)]
2009-10-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Migrate database inspection to the injected script-based schema.

        https://bugs.webkit.org/show_bug.cgi?id=29788

        * bindings/js/JSInspectorBackendCustom.cpp:
        (WebCore::JSInspectorBackend::databaseForId):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8InspectorBackendCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::dispatchOnInjectedScript):
        (WebCore::InspectorBackend::databaseForId):
        (WebCore::InspectorBackend::selectDatabase):
        (WebCore::InspectorBackend::getDatabaseTableNames):
        (WebCore::InspectorBackend::reportDidDispatchOnInjectedScript):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::selectDatabase):
        (WebCore::InspectorController::databaseForId):
        (WebCore::InspectorController::didOpenDatabase):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::selectDOMStorage):
        (WebCore::InspectorController::getDOMStorageResourceForId):
        * inspector/InspectorController.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorDatabaseResource.h:
        (WebCore::InspectorDatabaseResource::database):
        (WebCore::InspectorDatabaseResource::id):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::selectDatabase):
        (WebCore::InspectorFrontend::didGetDatabaseTableNames):
        (WebCore::InspectorFrontend::addDOMStorage):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/Database.js:
        (WebInspector.Database):
        (WebInspector.Database.prototype.get id):
        (WebInspector.Database.prototype.set name):
        (WebInspector.Database.prototype.set version):
        (WebInspector.Database.prototype.set domain):
        (WebInspector.Database.prototype.getTableNames):
        (WebInspector.Database.prototype.executeSql):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.dispatch):
        (InjectedScript.executeSql):
        (InjectedScript.executeSql.errorCallback):
        (InjectedScript.executeSql.queryTransaction):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.selectDatabase):
        (WebInspector.StoragePanel.prototype.dataGridForResult):
        * inspector/front-end/inspector.js:
        (WebInspector.addDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Wed, 7 Oct 2009 08:23:34 +0000 (08:23 +0000)]
2009-10-07  Martin Robinson  <martin.james.robinson@gmail.com>

        [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
        https://bugs.webkit.org/show_bug.cgi?id=30121

        Clear previous preedit or pending composition before storing new ones.
        This can happen when a WebView receives a native keydown event without
        a matching keyup event or when preventDefault() is called on DOM keydown
        events.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::setPendingComposition):
        (WebKit::setPendingPreedit):
        (WebKit::clearPendingIMData):
        (WebKit::imContextCommitted):
        (WebKit::imContextPreeditChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 7 Oct 2009 07:42:23 +0000 (07:42 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: default to an attached inspector window on Windows (as on Mac).

        https://bugs.webkit.org/show_bug.cgi?id=30134

WebKit/mac:
        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController showWindow:]):
WebKit/win:
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::showWindowWithoutNotifications):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Girish Ramakrishnan <girish@forwardbias.in>
eric@webkit.org [Wed, 7 Oct 2009 07:40:05 +0000 (07:40 +0000)]
2009-10-07  Girish Ramakrishnan  <girish@forwardbias.in>

        Reviewed by Simon Hausmann.

        [Qt] Windowless Plugins: Disable content propagation for QGraphicsView items

        We cannot support content propagation for items in QGraphicsView because
        the contents of the backing store might be transformed. So turn it off
        if we are not painting on QWidget.

        Note that this check will not work for a QWebView in a
        QGraphicsProxyWidget, but I guess it's fine. Alternative is to do an
        even uglier cast: static_cast painter's paintDevice() to QWidget and
        check if it is the viewport() of QGraphicsView.

        https://bugs.webkit.org/show_bug.cgi?id=30149

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 07:38:17 +0000 (07:38 +0000)]
2009-10-07  Xan Lopez  <xlopez@igalia.com>

        Skip two new tests for which we are missing results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTidy up postMessage testcase
oliver@apple.com [Wed, 7 Oct 2009 07:17:47 +0000 (07:17 +0000)]
Tidy up postMessage testcase

Reviewed by Gavin Barraclough.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt build by adding the missing files to the build.
hausmann@webkit.org [Wed, 7 Oct 2009 07:15:21 +0000 (07:15 +0000)]
Fix the Qt build by adding the missing files to the build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-07
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 7 Oct 2009 07:10:59 +0000 (07:10 +0000)]
2009-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Fix incorrect convertion of double into int while assigning it to
        a float.

        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 7 Oct 2009 07:10:03 +0000 (07:10 +0000)]
2009-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Fix rounding error issues in height calculation in 64 bits.

        Already covered by existing tests.

        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::platformInit):
        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-07 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 7 Oct 2009 06:20:02 +0000 (06:20 +0000)]
2009-10-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Dual lines in css2.1 layout tests do not match:
        https://bugs.webkit.org/show_bug.cgi?id=23262

        Now we can put a counter node as the next sibling of a reset node.
        Re-layout the counter content when the count is updated.

        Tests: fast/css/counters/t1204-increment-00-c-o.html
               fast/css/counters/t1204-increment-01-c-o.html

        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::recount):
        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
2009-10-07  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Dual lines in css2.1 layout tests do not match:
        https://bugs.webkit.org/show_bug.cgi?id=23262

        Now we can put a counter node as the next sibling of a reset node.
        Re-layout the counter content when the count is updated.

        * fast/css/counters/t1204-increment-00-c-o.html: Added.
        * fast/css/counters/t1204-increment-01-c-o.html: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.checksum: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.png: Added.
        * platform/mac/fast/css/counters/t1204-increment-00-c-o-expected.txt: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.checksum: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.png: Added.
        * platform/mac/fast/css/counters/t1204-increment-01-c-o-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Priit Laes <plaes@plaes.org>
eric@webkit.org [Wed, 7 Oct 2009 05:44:47 +0000 (05:44 +0000)]
2009-10-06  Priit Laes  <plaes@plaes.org>

        Reviewed by Gavin Barraclough.

        Linking fails with "relocation R_X86_64_PC32 against symbol
        `cti_vm_throw'"
        https://bugs.webkit.org/show_bug.cgi?id=28422

        * jit/JITStubs.cpp:
        Mark cti_vm_throw symbol as PLT-indirect symbol, so it doesn't end up
        in text segment causing relocation errors on amd64 architecture.
        Introduced new define SYMBOL_STRING_RELOCATION for such symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 7 Oct 2009 05:15:04 +0000 (05:15 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Try to fix the GTK+ build.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 03:56:10 +0000 (03:56 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Adam Barth.

        Removed unused member variable from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30146

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA few small/trivial tweaks to the last build fix.
levin@chromium.org [Wed, 7 Oct 2009 03:45:52 +0000 (03:45 +0000)]
A few small/trivial tweaks to the last build fix.

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (build fix).

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows linking fix
oliver@apple.com [Wed, 7 Oct 2009 03:16:59 +0000 (03:16 +0000)]
Windows linking fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
levin@chromium.org [Wed, 7 Oct 2009 03:07:19 +0000 (03:07 +0000)]
[Chromium] Need to adjust MessagePort, etc. code for the post clone work done.
https://bugs.webkit.org/show_bug.cgi?id=30147

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Dimitri Glazkov.

No change in functionality so no new tests.

* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/SerializedScriptValue.h: Added.
 A very simple implementation of SerializedScriptValue
 that only works for strings.
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/7271202>
weinig@apple.com [Wed, 7 Oct 2009 02:48:12 +0000 (02:48 +0000)]
Fix for <rdar://problem/7271202>
Dispatch resource load delegate functions for the media element.
Since we don't get the required callbacks from the media engine,
just fake the parameters to the delegate functions as best as possible.

Reviewed by Brady Eidson.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL):
* loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
oliver@apple.com [Wed, 7 Oct 2009 02:39:30 +0000 (02:39 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
oliver@apple.com [Wed, 7 Oct 2009 02:29:15 +0000 (02:29 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild and formatting fix.
oliver@apple.com [Wed, 7 Oct 2009 02:21:49 +0000 (02:21 +0000)]
Build and formatting fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIt should be possible to post (clone) built-in JS objects to Workers
oliver@apple.com [Wed, 7 Oct 2009 02:06:03 +0000 (02:06 +0000)]
It should be possible to post (clone) built-in JS objects to Workers
https://bugs.webkit.org/show_bug.cgi?id=22878

Reviewed by Gavin Barraclough.

Implement object cloning semantics for postMessage.  Currently only
a partial implementation of the spec -- cloning of File, FileList,
ImageData, and RegExp were left out as they would have significantly
increased patch size.

Cloning requires multiple tree walks so we use a templated tree
walk function, allowing us to share a single implementation for
serialization, deserialization, and eventual destruction of the
serialized object tree.

Test: fast/dom/Window/window-postmessage-clone.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 7 Oct 2009 01:28:55 +0000 (01:28 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix for Windows.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 01:14:23 +0000 (01:14 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * WebCore.base.exp:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::isSafeToLoadURL):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadSubframe):
        (WebCore::FrameLoader::loadPlugin):
        (WebCore::FrameLoader::loadFrameRequest):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::createJavaAppletWidget):
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canLoad):
        (WebCore::SecurityOrigin::shouldHideReferrer):
        * page/SecurityOrigin.h:
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::WebNetscapePluginStream):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebFrame.mm:
        (-[WebFrame _allowsFollowingLink:]):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move FrameLoader::canLoad to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30111

        * WebFrame.cpp:
        (WebFrame::allowsFollowingLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Wed, 7 Oct 2009 01:05:05 +0000 (01:05 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        These have more to do with security policies than with loading frames.

        * WebCore.base.exp:
        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * loader/Cache.cpp:
        (WebCore::Cache::requestResource):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::setLocalLoadPolicy):
        (WebCore::SecurityOrigin::restrictAccessToLocal):
        (WebCore::SecurityOrigin::allowSubstituteDataAccessToLocal):
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        Call the new API.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move setLocalLoadPolicy and friends to SecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=30110

        Call the new API.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Tue, 6 Oct 2009 22:48:58 +0000 (22:48 +0000)]
2009-10-06  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Brady Eidson.

        Preparation for <http://webkit.org/b/30104>.
        Inspector should show cookies of sub-resources on the page.

        Implement getRawCookies for CFNetwork for Windows, so we can see more
        than just a key/value pair for Cookies when we are on Windows.

        * platform/network/win/CookieJarCFNetWin.cpp:
        (WebCore::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 22:26:36 +0000 (22:26 +0000)]
2009-10-06  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Diagram needs to be linked from the home page
        https://bugs.webkit.org/show_bug.cgi?id=30142

        http://webkit.org/coding/major-objects.html was never linked from the home
        page.

        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with...
hyatt@apple.com [Tue, 6 Oct 2009 22:26:08 +0000 (22:26 +0000)]
WebCore: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with <link> elements and
XML processing instructions.

Reviewed by Adam Roben.

Fix up ProcessingInstruction's setData call so that it actually updates a stylesheet when the
data gets changed.

Move dispatchBeforeLoadedEvent to ContainerNode so all Elements (and ProcessingInstruction) can
access it.

Added fast/dom/beforeload/link-before-load.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::dispatchBeforeLoadEvent):
* dom/ContainerNode.h:
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::setData):
* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
* dom/ScriptElement.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::process):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::forAttributeValue):
* html/HTMLScriptElement.h:
* svg/SVGScriptElement.cpp:
* svg/SVGScriptElement.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=30132, make beforeload work with CSS stylesheets loaded from
<link> elements and XML processing instructions.

Reviewed by Adam Roben.

* fast/dom/beforeload/link-before-load-expected.txt: Added.
* fast/dom/beforeload/link-before-load.html: Added.
* fast/dom/beforeload/pi-before-load-expected.txt: Added.
* fast/dom/beforeload/pi-before-load.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTool...
mrowe@apple.com [Tue, 6 Oct 2009 21:08:23 +0000 (21:08 +0000)]
<webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH

Reviewed by Simon Fraser.

* Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
the fact we have already changed the working directory to the top of the open source tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 20:47:58 +0000 (20:47 +0000)]
2009-10-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        accessibility/media-element.html crashes (and has incorrect result)
        https://bugs.webkit.org/show_bug.cgi?id=30108

        Fix up the accessibilty label for the newly added fullscreen button,
        and update the test result accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
jparent@chromium.org [Tue, 6 Oct 2009 20:10:11 +0000 (20:10 +0000)]
Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
rather than my committer email.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-06
* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Kelly Norton <knorton@google.com>
eric@webkit.org [Tue, 6 Oct 2009 19:56:59 +0000 (19:56 +0000)]
2009-10-06  Kelly Norton  <knorton@google.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30028>
        Multiple calls to SetFrontendProxyObject can leave an InspectorTimelineAgent with an invalid
        InspectorFrontend.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontendProxyObject): Adds a check for an existing timeline agent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 6 Oct 2009 19:14:39 +0000 (19:14 +0000)]
2009-10-06  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30107

        Fixes an issue where the Mac build does return the correct drop effect
        with respect to the HTML 5 specification when effectAllowed == "none".

        Currently, when effectAllowed == "none" and dropEffect == "copy" or
        dropEffect == "move" the resulting drop effect is "copy" and "move",
        respectively. However, the HTML 5 specification states that regardless
        of the specified dropEffect, when effectAllowed == "none" the resulting
        drop effect should be "none".

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView draggingSourceOperationMaskForLocal:]):
2009-10-06  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=30107

        Tests that drag-and-drop returns dropEffect = "none" when
        effectAllowed == "none", regardless of the user-specified
        drop effect.

        * fast/events/drag-and-drop-none-expected.txt: Added.
        * fast/events/drag-and-drop-none.html: Added.
        * platform/win/Skipped: This test does not work under
        Windows. We need the fix for bug #24731.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that...
antti@apple.com [Tue, 6 Oct 2009 19:13:55 +0000 (19:13 +0000)]
Move textRects to the right category in DOM.mm. Include DOMPrivate.h to ensure that the interfaces match.

Reviewed by Dave Kilzer.

* bindings/objc/DOM.mm:
(-[DOMNode textRects]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
eric@webkit.org [Tue, 6 Oct 2009 19:02:44 +0000 (19:02 +0000)]
2009-10-06  Benjamin C Meyer  <bmeyer@rim.com>

        Reviewed by Ariya Hidayat.

        Match the behavior of other WebKit browser and have the first url of the drag data be the url passed in declareAndWriteDragImage and set the text of the drag data to be the title argument.

        Manual test: Drag the readability js link from http://lab.arc90.com/experiments/readability/

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::declareAndWriteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Benjamin C Meyer <bmeyer@rim.com>
eric@webkit.org [Tue, 6 Oct 2009 18:55:17 +0000 (18:55 +0000)]
2009-10-06  Benjamin C Meyer  <bmeyer@rim.com>

        Reviewed by Ariya Hidayat.

        When the drag data contains an image set it on the QDrag so it will be visible to the user.

        * WebCoreSupport/DragClientQt.cpp:
        (WebCore::DragClientQt::startDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 18:47:21 +0000 (18:47 +0000)]
2009-10-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        * fast/forms/ValidityState-rangeOverflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-number.html: Added.
        * fast/forms/ValidityState-rangeOverflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeOverflow-range.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-number-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-number.html: Added.
        * fast/forms/ValidityState-rangeUnderflow-range-expected.txt: Added.
        * fast/forms/ValidityState-rangeUnderflow-range.html: Added.
        * fast/forms/input-minmax-expected.txt: Added.
        * fast/forms/input-minmax.html: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeOverflow-range.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-number.js: Added.
        * fast/forms/script-tests/ValidityState-rangeUnderflow-range.js: Added.
        * fast/forms/script-tests/input-minmax.js: Added.
2009-10-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement min/max attributes, ValidityState.rangeUnderflow and
        ValidityState.rangeOverflow for <input type=number> and <input type=range>
        https://bugs.webkit.org/show_bug.cgi?id=29069

        HTMLInputElement::max and min are not defined for COM because they
        conflict with the standard min() and max() macros.

        Tests: fast/forms/ValidityState-rangeOverflow-number.html
               fast/forms/ValidityState-rangeOverflow-range.html
               fast/forms/ValidityState-rangeUnderflow-number.html
               fast/forms/ValidityState-rangeUnderflow-range.html
               fast/forms/input-minmax.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::rangeUnderflow):
        (WebCore::HTMLInputElement::rangeOverflow):
        (WebCore::HTMLInputElement::rangeMinimum):
        (WebCore::HTMLInputElement::rangeMaximum):
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl:
        * html/ValidityState.cpp:
        (WebCore::ValidityState::rangeUnderflow):
        (WebCore::ValidityState::rangeOverflow):
        * html/ValidityState.h:
        * rendering/RenderSlider.cpp:
        (WebCore::SliderRange::SliderRange):
        (WebCore::SliderRange::valueFromElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 6 Oct 2009 18:29:24 +0000 (18:29 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Skip new tests for which we are missing expected results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 18:27:59 +0000 (18:27 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().

        r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
        it after each layout test as it should do, making the DRT dump additional output
        for all of the subsequent layout tests.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Adam Barth <abarth@webkit.org>
eric@webkit.org [Tue, 6 Oct 2009 18:20:33 +0000 (18:20 +0000)]
2009-10-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move m_openedByDOM to Page
        https://bugs.webkit.org/show_bug.cgi?id=30109

        We only need one instance of m_openedByDOM per page, we should move it
        to a page-scoped object.  Notice that it's only ever touched for the
        main frame.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::createWindow):
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::close):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::openedByDOM):
        (WebCore::Page::setOpenedByDOM):
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Carol Szabo <carol.szabo@nokia.com>
eric@webkit.org [Tue, 6 Oct 2009 17:49:39 +0000 (17:49 +0000)]
2009-10-06  Carol Szabo  <carol.szabo@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Some functions in GraphicsContext do not work
        as expected if the associated painter has no clipping.
        https://bugs.webkit.org/show_bug.cgi?id=29691

        No new tests are associated with this because DumpRenderTree
        always sets clipping on the painter, thus it would never hit
        the test case, but fast/box-shadow/basic-shadows.html is a
        good example of what happens if the clipping is not set by
        the user of QtWebKit.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        Fixed to handle the case that there is no clipping
        before the call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.
hyatt@apple.com [Tue, 6 Oct 2009 17:37:48 +0000 (17:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=30131, make beforeload fire on script elements.

Reviewed by Adam Roben.

WebCore:

Added tests in fast/dom/beforeload/.

* dom/ScriptElement.cpp:
(WebCore::ScriptElementData::requestScript):
* dom/ScriptElement.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::endElementNs):
* html/HTMLAttributeNames.in:
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseMappedAttribute):
(WebCore::HTMLScriptElement::dispatchBeforeLoadEvent):
* html/HTMLScriptElement.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::scriptHandler):
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::dispatchBeforeLoadEvent):
* svg/SVGScriptElement.h:

LayoutTests:

* fast/dom/beforeload: Added.
* fast/dom/beforeload/resources: Added.
* fast/dom/beforeload/script-before-load-dynamic-expected.txt: Added.
* fast/dom/beforeload/script-before-load-dynamic.html: Added.
* fast/dom/beforeload/script-before-load-expected.txt: Added.
* fast/dom/beforeload/script-before-load-xhtml-expected.txt: Added.
* fast/dom/beforeload/script-before-load-xhtml.xhtml: Added.
* fast/dom/beforeload/script-before-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore:
xan@webkit.org [Tue, 6 Oct 2009 17:24:37 +0000 (17:24 +0000)]
WebCore:

2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Enable caret movement commands also when caret browsing setting is
        enabled.

        * editing/EditorCommand.cpp:
        (WebCore::caretBrowsingEnabled):
        (WebCore::enabledVisibleSelectionOrCaretBrowsing):
        (WebCore::enabledInEditableTextOrCaretBrowsing):
        (WebCore::CommandEntry::):
        * manual-tests/gtk/caret-browsing.html: Added.

WebKit/gtk:

2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25526
        [Gtk] Additional support is needed for caret browsing

        Remove special cases for caret browsing, they are now handled in
        cross-platform code.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Zan Dobersek <zandobersek@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 17:24:26 +0000 (17:24 +0000)]
2009-10-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk][Layout tests] Generate results for editing tests
        https://bugs.webkit.org/show_bug.cgi?id=30061

        Add results for editing tests and enable these tests in the Skipped.
        Also moves some improperly placed tests to the 'failing' section.

        * platform/gtk/Skipped:
        * platform/gtk/editing/deleting/4922367-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-1-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5026848-3-expected.txt: Added.
        * platform/gtk/editing/deleting/5032066-expected.txt: Added.
        * platform/gtk/editing/deleting/5091898-expected.txt: Added.
        * platform/gtk/editing/deleting/5099303-expected.txt: Added.
        * platform/gtk/editing/deleting/5115601-expected.txt: Added.
        * platform/gtk/editing/deleting/5126166-expected.txt: Added.
        * platform/gtk/editing/deleting/5156801-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5206311-1-expected.txt: Added.
        * platform/gtk/editing/deleting/5206311-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5272440-expected.txt: Added.
        * platform/gtk/editing/deleting/5369009-expected.txt: Added.
        * platform/gtk/editing/deleting/5390681-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5390681-expected.txt: Added.
        * platform/gtk/editing/deleting/5433862-2-expected.txt: Added.
        * platform/gtk/editing/deleting/5483370-expected.txt: Added.
        * platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608445-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3775172-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3800834-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-and-undo-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-contents-003-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-003-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-005-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-006-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-007-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-br-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-by-word-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-image-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-005-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-006-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-007-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-008-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-009-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-010-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-011-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-012-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-013-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-014-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-listitem-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-listitem-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-select-all-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-tab-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-tab-004-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
        * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
        * platform/gtk/editing/deleting/forward-delete-expected.txt: Added.
        * platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt: Added.
        * platform/gtk/editing/deleting/move-nodes-001-expected.txt: Added.
        * platform/gtk/editing/deleting/type-delete-after-quote-expected.txt: Added.
        * platform/gtk/editing/execCommand/4580583-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4580583-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/4747450-expected.txt: Added.
        * platform/gtk/editing/execCommand/4786404-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4786404-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/4916402-expected.txt: Added.
        * platform/gtk/editing/execCommand/4916541-expected.txt: Added.
        * platform/gtk/editing/execCommand/4920488-expected.txt: Added.
        * platform/gtk/editing/execCommand/4920742-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/4924441-expected.txt: Added.
        * platform/gtk/editing/execCommand/5049671-expected.txt: Added.
        * platform/gtk/editing/execCommand/5080333-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/5080333-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/5136770-expected.txt: Added.
        * platform/gtk/editing/execCommand/5138441-expected.txt: Added.
        * platform/gtk/editing/execCommand/5142012-1-expected.txt: Added.
        * platform/gtk/editing/execCommand/5142012-2-expected.txt: Added.
        * platform/gtk/editing/execCommand/5190926-expected.txt: Added.
        * platform/gtk/editing/execCommand/5481523-expected.txt: Added.
        * platform/gtk/editing/execCommand/5482023-expected.txt: Added.
        * platform/gtk/editing/execCommand/5569741-expected.txt: Added.
        * platform/gtk/editing/execCommand/5573879-expected.txt: Added.
        * platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Added.
        * platform/gtk/editing/inserting/12882-expected.txt: Added.
        * platform/gtk/editing/inserting/4840662-expected.txt: Added.
        * platform/gtk/editing/inserting/4875189-1-expected.txt: Added.
        * platform/gtk/editing/inserting/4875189-2-expected.txt: Added.
        * platform/gtk/editing/inserting/4959067-expected.txt: Added.
        * platform/gtk/editing/inserting/4960120-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5002441-expected.txt: Added.
        * platform/gtk/editing/inserting/5058163-1-expected.txt: Added.
        * platform/gtk/editing/inserting/5058163-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5156401-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5418891-expected.txt: Added.
        * platform/gtk/editing/inserting/5510537-expected.txt: Added.
        * platform/gtk/editing/inserting/5549929-2-expected.txt: Added.
        * platform/gtk/editing/inserting/5549929-3-expected.txt: Added.
        * platform/gtk/editing/inserting/6633727-expected.txt: Added.
        * platform/gtk/editing/inserting/6703873-expected.txt: Added.
        * platform/gtk/editing/inserting/editable-inline-element-expected.txt: Added.
        * platform/gtk/editing/inserting/edited-whitespace-1-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3659587-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3775316-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3800346-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3851164-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-after-delete-001-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-bg-font-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/insert-bg-font-expected.txt.
        * platform/gtk/editing/inserting/insert-br-005-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-001-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-002-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-003-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-004-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-005-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-009-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-div-024-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt: Added.
        * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt: Added.
        * platform/gtk/editing/inserting/redo-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-001-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-002-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-003-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-around-br-001-expected.txt: Added.
        * platform/gtk/editing/inserting/typing-around-image-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/4076267-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5032095-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5071074-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5075944-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5089327-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5134759-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5156401-1-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5387578-expected.txt: Added.
        * platform/gtk/editing/pasteboard/5483567-expected.txt: Added.
        * platform/gtk/editing/pasteboard/7955-expected.txt: Added.
        * platform/gtk/editing/pasteboard/cut-text-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-table-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-002-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-003-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-004-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-005-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-006-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-007-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-008-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-009-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-010-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-text-015-expected.txt: Added.
        * platform/gtk/editing/pasteboard/paste-xml-expected.txt: Added.
        * platform/gtk/editing/pasteboard/select-element-1-expected.txt: Added.
        * platform/gtk/editing/selection/13804-expected.txt: Added.
        * platform/gtk/editing/selection/14971-expected.txt: Added.
        * platform/gtk/editing/selection/4818145-expected.txt: Added.
        * platform/gtk/editing/selection/4866671-expected.txt: Added.
        * platform/gtk/editing/selection/4889598-expected.txt: Added.
        * platform/gtk/editing/selection/4895428-2-expected.txt: Added.
        * platform/gtk/editing/selection/4960116-expected.txt: Added.
        * platform/gtk/editing/selection/4960137-expected.txt: Added.
        * platform/gtk/editing/selection/4983858-expected.txt: Added.
        * platform/gtk/editing/selection/5007143-2-expected.txt: Added.
        * platform/gtk/editing/selection/5007143-expected.txt: Added.
        * platform/gtk/editing/selection/5057506-2-expected.txt: Added.
        * platform/gtk/editing/selection/5057506-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-1-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-2-expected.txt: Added.
        * platform/gtk/editing/selection/5076323-3-expected.txt: Added.
        * platform/gtk/editing/selection/5081257-1-expected.txt: Added.
        * platform/gtk/editing/selection/5081257-2-expected.txt: Added.
        * platform/gtk/editing/selection/5099303-expected.txt: Added.
        * platform/gtk/editing/selection/5109817-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-1-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-2-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-3-expected.txt: Added.
        * platform/gtk/editing/selection/5131716-4-expected.txt: Added.
        * platform/gtk/editing/selection/5232159-expected.txt: Added.
        * platform/gtk/editing/selection/5234383-1-expected.txt: Added.
        * platform/gtk/editing/selection/5234383-2-expected.txt: Added.
        * platform/gtk/editing/selection/5333725-expected.txt: Added.
        * platform/gtk/editing/selection/5354455-1-expected.txt: Added.
        * platform/gtk/editing/selection/5354455-2-expected.txt: Added.
        * platform/gtk/editing/selection/addRange-expected.txt: Added.
        * platform/gtk/editing/selection/drag-in-iframe-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-002-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-003-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-004-expected.txt: Added.
        * platform/gtk/editing/selection/extend-by-character-005-expected.txt: Added.
        * platform/gtk/editing/selection/fake-drag-expected.txt: Added.
        * platform/gtk/editing/selection/iframe-expected.txt: Added.
        * platform/gtk/editing/selection/inline-closest-leaf-child-expected.txt: Added.
        * platform/gtk/editing/selection/inline-table-expected.txt: Added.
        * platform/gtk/editing/selection/mixed-editability-6-expected.txt: Added.
        * platform/gtk/editing/selection/mixed-editability-7-expected.txt: Added.
        * platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-002-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-003-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-004-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-character-005-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-sentence-001-expected.txt: Added.
        * platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt: Added.
        * platform/gtk/editing/selection/move-past-trailing-space-expected.txt: Added.
        * platform/gtk/editing/selection/select-box-expected.txt: Added.
        * platform/gtk/editing/selection/selectNode-expected.txt: Added.
        * platform/gtk/editing/selection/selectNodeContents-expected.txt: Added.
        * platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt: Added.
        * platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt: Added.
        * platform/gtk/editing/spelling/spelling-expected.txt: Added.
        * platform/gtk/editing/spelling/spelling-linebreak-expected.txt: Added.
        * platform/gtk/editing/style/4916887-expected.txt: Added.
        * platform/gtk/editing/style/5017613-1-expected.txt: Added.
        * platform/gtk/editing/style/5017613-2-expected.txt: Added.
        * platform/gtk/editing/style/5046875-1-expected.txt: Added.
        * platform/gtk/editing/style/5046875-2-expected.txt: Added.
        * platform/gtk/editing/style/5084241-expected.txt: Added.
        * platform/gtk/editing/style/5228141-expected.txt: Added.
        * platform/gtk/editing/style/5279521-expected.txt: Added.
        * platform/gtk/editing/style/block-style-003-expected.txt: Added.
        * platform/gtk/editing/style/fontsize-1-expected.txt: Added.
        * platform/gtk/editing/style/highlight-expected.txt: Added.
        * platform/gtk/editing/style/relative-font-size-change-001-expected.txt: Added.
        * platform/gtk/editing/style/style-3681552-fix-001-expected.txt: Added.
        * platform/gtk/editing/style/style-3681552-fix-002-expected.txt: Added.
        * platform/gtk/editing/style/style-3690704-fix-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-001-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-002-expected.txt: Added.
        * platform/gtk/editing/style/typing-style-003-expected.txt: Added.
        * platform/gtk/editing/style/unbold-in-bold-expected.txt: Added.
        * platform/gtk/editing/undo/4063751-expected.txt: Added.
        * platform/gtk/editing/undo/5378473-expected.txt: Added.
        * platform/gtk/editing/undo/redo-typing-001-expected.txt: Added.
        * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-combined-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt: Added.
        * platform/gtk/editing/undo/undo-forward-delete-expected.txt: Added.
        * platform/gtk/editing/undo/undo-misspellings-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Anton Muhin <antonm@chromium>
eric@webkit.org [Tue, 6 Oct 2009 17:15:22 +0000 (17:15 +0000)]
2009-10-06  Anton Muhin  <antonm@chromium>

        Reviewed by Dimitri Glazkov.

        Non standard, but popular exetension allows automagically
        turn a function into a namespace resolver.  Support that in
        Chromium as well.

        This adds new layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=30128

        * fast/xpath/xpath-namespaces-expected.txt:
        * fast/xpath/xpath-namespaces.html:
2009-10-06  Anton Muhin  <antonm@chromium>

        Reviewed by Dimitri Glazkov.

        Non standard, but popular exetension allows automagically
        turn a function into a namespace resolver.  Support that in
        Chromium as well.

        Adjust CodeGeneratorV8 to treat XPathNSResolver in a special way.
        https://bugs.webkit.org/show_bug.cgi?id=30128

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.h:
        (WebCore::V8DOMWrapper::getXPathNSResolver):
        * bindings/v8/custom/V8DocumentCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 6 Oct 2009 15:48:52 +0000 (15:48 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: close inspector client view on
        InspectorController::close API call.

        In order to run batch web inspector layout tests (and not affect
        subsequent tests) we should close inspector client's view upon
        InspectorController::close API call.

        https://bugs.webkit.org/show_bug.cgi?id=30009

WebCore:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::inspectedPageDestroyed):
        (WebCore::InspectorController::close):
WebKit/gtk:
        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::createPage):
WebKit/mac:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::createPage):
WebKit/qt:
        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientQt::createPage):
WebKit/win:
        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::createPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 15:34:54 +0000 (15:34 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
        fast/dom/assign-to-window-status.html test, which is passing as a result.

        https://bugs.webkit.org/show_bug.cgi?id=30127

        * platform/qt/Skipped:
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
        fast/dom/assign-to-window-status.html test, which is passing as a result.

        https://bugs.webkit.org/show_bug.cgi?id=30127

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::statusBarMessage):
        * DumpRenderTree/qt/DumpRenderTree.h:
        * DumpRenderTree/qt/jsobjects.h:
        (LayoutTestController::shouldDumpStatusCallbacks):
        (LayoutTestController::dumpStatusCallbacks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 6 Oct 2009 15:27:30 +0000 (15:27 +0000)]
2009-10-06  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Simon Hausmann.

        [Qt] don't enable input methods on Symbian by default.
        https://bugs.webkit.org/show_bug.cgi?id=30117

        If input methods are enabled Symbian FEP will be launched on every
        pointer event making webpage navigation impossible with QWebView.

        * Api/qwebview.cpp:
        (QWebView::QWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt/Windows build by stubbing out the still image
hausmann@webkit.org [Tue, 6 Oct 2009 15:06:28 +0000 (15:06 +0000)]
Fix the Qt/Windows build by stubbing out the still image
support for halted plugins for the Qt build.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-06
Reviewed by Tor Arne Vestbø.

Bugzilla entry https://bugs.webkit.org/show_bug.cgi?id=30130
tracks removing this by implementing Frame::nodeImage().

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::halt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Change QImageReader usage in ImageDecoderQt
hausmann@webkit.org [Tue, 6 Oct 2009 14:15:17 +0000 (14:15 +0000)]
[Qt] Change QImageReader usage in ImageDecoderQt

https://bugs.webkit.org/show_bug.cgi?id=27538

Replace the ReadContext with another appoach to
reading the image. Attempt to only read meta information
like the image size and number of frames (for animations)
first and then when the page is getting drawn decode
the image with the QImageReader.

This is a huge benefit on pages with many images and saves
~2GB of memory on the szeged image test page.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::~ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
(WebCore::ImageDecoderQt::internalDecodeSize):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::forceLoadEverything):
(WebCore::ImageDecoderQt::failRead):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make use of RGBA32Buffer in ImageDecoderQt
hausmann@webkit.org [Tue, 6 Oct 2009 14:14:10 +0000 (14:14 +0000)]
[Qt] Make use of RGBA32Buffer in ImageDecoderQt

https://bugs.webkit.org/show_bug.cgi?id=27538

Use the RGBA32Buffer instead of the internal ImageData
to be able to use support of the base class, optionally
support WebCore decoders for Qt and most importantly
separate metadata and image data for better cache control.

Remove ImageSourceQt as everything is now shared with
the normal ImageSource.

Change the ownership of the NativeImagePtr/QPixmap in
ImageQt.cpp to delete the m_frame to be subject to cache
control.

* WebCore.pro:
* platform/graphics/ImageSource.cpp:
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::ImageDecoderQt):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::clearFrameBufferCache):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/qt/ImageSourceQt.cpp: Removed.
* platform/image-decoders/ImageDecoder.h:
(WebCore::RGBA32Buffer::decodedImage):
(WebCore::RGBA32Buffer::getAddr):
* platform/image-decoders/qt/RGBA32BufferQt.cpp: Added.
(WebCore::RGBA32Buffer::RGBA32Buffer):
(WebCore::RGBA32Buffer::setDecodedImage):
(WebCore::RGBA32Buffer::clear):
(WebCore::RGBA32Buffer::zeroFill):
(WebCore::RGBA32Buffer::copyBitmapData):
(WebCore::RGBA32Buffer::setSize):
(WebCore::RGBA32Buffer::asNewNativeImage):
(WebCore::RGBA32Buffer::hasAlpha):
(WebCore::RGBA32Buffer::setHasAlpha):
(WebCore::RGBA32Buffer::setStatus):
(WebCore::RGBA32Buffer::operator=):
(WebCore::RGBA32Buffer::width):
(WebCore::RGBA32Buffer::height):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 6 Oct 2009 13:54:19 +0000 (13:54 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Skip another failing test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] ImageDecoderQt avoid QString creation.
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:51 +0000 (13:46 +0000)]
[Qt] ImageDecoderQt avoid QString creation.

https://bugs.webkit.org/show_bug.cgi?id=27538

Avoid going from CString to QString to String
and go directly from CString to String. Also
avoid going to lower case to avoid an extra
memory allocation.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
(WebCore::ImageDecoderQt::ImageDecoderQt):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Cleanup the ImageDecoder of Qt.
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:42 +0000 (13:46 +0000)]
[Qt] Cleanup the ImageDecoder of Qt.

https://bugs.webkit.org/show_bug.cgi?id=27538

Remove the various enums for partial load. The fact is
that this image decoder will decode everything that is
in the file at once. Make it look like it behaves to
ease fixing this core problem.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ImageData::ImageData):
(WebCore::ImageDecoderQt::ReadContext::ReadContext):
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::hasFirstImageHeader):
(WebCore::ImageDecoderQt::setData):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Reimplement instead of overload frameCount in ImageDecoderQt.cpp
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:33 +0000 (13:46 +0000)]
[Qt] Reimplement instead of overload frameCount in ImageDecoderQt.cpp

https://bugs.webkit.org/show_bug.cgi?id=27538

Reimplement frameCount instead of overloading it.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameCount):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QImageReader does not support progressive reading
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:24 +0000 (13:46 +0000)]
[Qt] QImageReader does not support progressive reading

https://bugs.webkit.org/show_bug.cgi?id=27538

Change the ImageDecoderQt::setData to store the encoded
data in ImageDecoder.

Only call ReadContext when the whole Resource has been
loaded to avoid needless calls to reset and the
ReadContext as progressive loading is not supported.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
* platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove dead code from ImageDecoderQt.
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:14 +0000 (13:46 +0000)]
[Qt] Remove dead code from ImageDecoderQt.

https://bugs.webkit.org/show_bug.cgi?id=27538

Remove unused variables and debugging code. The debug
code has never been used and does not provide anything
useful.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::ReadContext::read):
(WebCore::ImageDecoderQt::ReadContext::readImageLines):
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::isSizeAvailable):
(WebCore::ImageDecoderQt::frameCount):
(WebCore::ImageDecoderQt::repetitionCount):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::imageAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQtLauncher: print the number of loaded urls
hausmann@webkit.org [Tue, 6 Oct 2009 13:46:05 +0000 (13:46 +0000)]
QtLauncher: print the number of loaded urls

When using the -r mode print the number of URLs loaded so far. This
is extremly useful when opening the same URL over and over again and
one wants to see the progress.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 13:38:53 +0000 (13:38 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Update the Skipped list.
        Remove some tests that are passing now, mostly due to the recent DRT fixes.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Tue, 6 Oct 2009 12:50:59 +0000 (12:50 +0000)]
2009-10-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] segfault when calling gst_video_format_parse_caps in the video sink
        https://bugs.webkit.org/show_bug.cgi?id=30120

        Fix use of gst_video_format_parse_caps()

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update mediaControls CSS
vestbo@webkit.org [Tue, 6 Oct 2009 12:34:40 +0000 (12:34 +0000)]
[Qt] Update mediaControls CSS

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 6 Oct 2009 12:29:37 +0000 (12:29 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Get rid of Preferences.ignoreWhitespace.

        https://bugs.webkit.org/show_bug.cgi?id=30092

        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent):
        (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.update):
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype.onpopulate):
        (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):
        (WebInspector.ElementsTreeElement.prototype._updateChildren):
        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
        * inspector/front-end/inspector.js:
        * inspector/front-end/utilities.js:
        (Node.prototype.rangeOfWord):
        (traverseNextNode):
        (traversePreviousNode):
        (onlyTextChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 6 Oct 2009 12:03:29 +0000 (12:03 +0000)]
2009-10-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Do not call nodeTitleInfo twice +
        followup fixes for r49101.

        https://bugs.webkit.org/show_bug.cgi?id=30087

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Alejandro G. Castro <alex@igalia.com>
eric@webkit.org [Tue, 6 Oct 2009 11:57:17 +0000 (11:57 +0000)]
2009-10-06  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        ASSERT executing the webhistory unittest in a debug build
        https://bugs.webkit.org/show_bug.cgi?id=28947

        We have to call g_object_new first to initialize webkit threading
        before creating the KURL.

        * WebKit/gtk/webkit/webkitwebhistoryitem.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Windowless plugins: Enable painting on printer.
hausmann@webkit.org [Tue, 6 Oct 2009 11:53:06 +0000 (11:53 +0000)]
[Qt] Windowless plugins: Enable painting on printer.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

The print preview dialog crashed because the depth of the drawable
changed owing to a bug in Qt - if you draw onto a 32-bit pixmap,
and set a 24-bit pixmap as source, it will convert the source to
32-bit.

1210fa5b2d65895ad2be1f9ca7cae586e3b29dc1 is the bug fix in Qt.

https://bugs.webkit.org/show_bug.cgi?id=20081

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Windowless plugins: Make painting and events work when page is zoomed.
hausmann@webkit.org [Tue, 6 Oct 2009 11:52:58 +0000 (11:52 +0000)]
[Qt] Windowless plugins: Make painting and events work when page is zoomed.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

The element gets resized when zoomed. So, we have to make sure that we resize
the drawable and do a setwindow call. Multiple calls to setwindow do not
crash plugin in windowless mode (unlike in windowed mode).

For mouse events we have to convert the pos to post-zoom position.

https://bugs.webkit.org/show_bug.cgi?id=20081

* plugins/qt/PluginViewQt.cpp:
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Windowless plugins: Add PluginQuirkRequiresDefaultScreenDepth quirk for Flash.
hausmann@webkit.org [Tue, 6 Oct 2009 11:52:42 +0000 (11:52 +0000)]
[Qt] Windowless plugins: Add PluginQuirkRequiresDefaultScreenDepth quirk for Flash.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

Flash does not use the visual provided by us to draw into the drawable.
It instead uses the system default visual (as returned by XDefaultVisual).
This means that if the screen default visual is 24-bit, Flash won't be
able to draw on 32-bit drawable created by us. This is a bug in Flash
and for the moment, the above quirk is only set for Flash.

Our strategy to create the drawable:
1. Create a 32-bit drawable if the default screen depth is 32 or the
quirk is not set (i.e not flash)
2. If we didn't create a 32-bit drawable (maybe the Display has no such
visual), we create a drawable with default screen depth.

As a result of the above changes, content propagation behavior changes as:
1. Content propagation is possible only if the drawable we create and
Qt's backing store are of the same depth.
2. If we created a 32-bit drawable, there is no need for content
propagation (Qt will take care of it).

https://bugs.webkit.org/show_bug.cgi?id=20081

* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
* plugins/PluginQuirkSet.h:
(WebCore::):
* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::getVisualAndColormap):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 José Millán Soto <fid@gpul.org>
eric@webkit.org [Tue, 6 Oct 2009 11:49:55 +0000 (11:49 +0000)]
2009-10-06  José Millán Soto  <fid@gpul.org>

        Reviewed by Xan Lopez.

        Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
        https://bugs.webkit.org/show_bug.cgi?id=30076

        Solves various issues in header files.

        * WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards"
        * webkit/webkitdefines.h:
        * webkit/webkitdownload.h:
        * webkit/webkiterror.h:
        * webkit/webkithittestresult.h:
        * webkit/webkitnetworkrequest.h:
        * webkit/webkitnetworkresponse.h:
        * webkit/webkitprivate.h:
        * webkit/webkitsecurityorigin.h:
        * webkit/webkitsoupauthdialog.h:
        * webkit/webkitversion.h.in:
        * webkit/webkitwebbackforwardlist.h:
        * webkit/webkitwebdatabase.h:
        * webkit/webkitwebdatasource.h:
        * webkit/webkitwebframe.h:
        * webkit/webkitwebhistoryitem.h:
        * webkit/webkitwebinspector.h:
        * webkit/webkitwebnavigationaction.h:
        * webkit/webkitwebpolicydecision.h:
        * webkit/webkitwebresource.h:
        * webkit/webkitwebsettings.h:
        * webkit/webkitwebview.h:
        * webkit/webkitwebwindowfeatures.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 11:42:29 +0000 (11:42 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
        ignores the argument indicating which mouse button to trigger.
        https://bugs.webkit.org/show_bug.cgi?id=30048

        This affects the fast/events/mouse-click-events.html layout test.

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::mouseDown):
        (EventSender::mouseUp):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 6 Oct 2009 11:35:08 +0000 (11:35 +0000)]
2009-10-06  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix the EventSender::keyDown() implementation
        https://bugs.webkit.org/show_bug.cgi?id=30043

        It should post both a key press event and a key release event,
        just like other ports do.

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Fumitoshi Ukai <ukai@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 11:27:47 +0000 (11:27 +0000)]
2009-10-06  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Ariya Hidayat.

        Qt build fix.
        https://bugs.webkit.org/show_bug.cgi?id=29362.

        In Qt 4.5, a new function QPainter::fillRect(QRect, QColor) is
        introduced to avoid the expensive construction of QBrush.
        By casting WebCore::Color to QColor, we can compile on Qt 4.4
        and use optimization for solid color fill in Qt 4.5.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::drawBorderlessRectShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow the platform media player to know the <video> poster URL.
benm@google.com [Tue, 6 Oct 2009 11:08:54 +0000 (11:08 +0000)]
Allow the platform media player to know the <video> poster URL.
Add MediaPlayerPrivate::prepareToPlay() to support media engines
that do not buffer video data automatically. This method allows
such media engines to start the buffering just before starting
playback.
https://bugs.webkit.org/show_bug.cgi?id=29133

Patch by Andrei Popescu <andreip@google.com> on 2009-10-05
Reviewed by Eric Carlson.

All platforms that currently implement <video> return false
in MediaPlayerPrivate::canLoadPoster() and do nothing in
MediaPlayerPrivate::prepareToPlay() their behavior is
unchanged. The current set of media test should then be
sufficient to guarantee that this patch does not break anything.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
After the MediaPlayer is created, inform it what the poster URL is.
(WebCore::HTMLMediaElement::updatePlayState):
Add another case where prepareToPlay is called for the platforms
that do not buffer video content automatically.
(WebCore::HTMLMediaElement::couldPlayIfEnoughData)
Same as potentiallyPlaying, except that we don't check for
the readyState being at least HAVE_FUTURE_DATA.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::canLoadPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::NullMediaPlayerPrivate::setPoster):
Empty implementation for the NullMediaPlayerPrivate.
(WebCore::MediaPlayer::canLoadPoster):
Proxy to the m_private.
(WebCore::MediaPlayer::setPoster):
Proxy to m_private.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::canLoadPoster):
(WebCore::MediaPlayerPrivateInterface::setPoster):
Add new methods that allow the platform player to receive the poster URL.
(WebCore::MediaPlayerPrivateInterface::prepareToPlay):
Notifies the media engine that playback should start. The media engine
should start preparing (e.g. by initializing the player and starting to buffer)
and call back when the state is changed to HAVE_FUTURE_DATA.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 6 Oct 2009 10:45:24 +0000 (10:45 +0000)]
2009-10-06  Dirk Schulze  <krit@webkit.org>

        Previous SourceAlpha test were made with an filters enabled build.
        This is the result of a filters disabled build (default).

        * platform/mac/svg/filters/sourceAlpha-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSpeculative build fix for windows (due to r49160).
levin@chromium.org [Tue, 6 Oct 2009 08:11:55 +0000 (08:11 +0000)]
Speculative build fix for windows (due to r49160).

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by NOBODY (windows build fix).

* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::dispatchDidAddIconForPageURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-06 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 6 Oct 2009 08:08:31 +0000 (08:08 +0000)]
2009-10-06  Xan Lopez  <xlopez@igalia.com>

        Update the skipped list to recent changes in tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStringImpl needs a method to get an instance for another thread which doesn't copy...
levin@chromium.org [Tue, 6 Oct 2009 07:45:09 +0000 (07:45 +0000)]
StringImpl needs a method to get an instance for another thread which doesn't copy the underlying buffer.
https://bugs.webkit.org/show_bug.cgi?id=30095

Patch by David Levin <levin@chromium.org> on 2009-10-06
Reviewed by Oliver Hunt.

JavaScriptCore:

* wtf/CrossThreadRefCounted.h:
Removed an unused function and assert improvement.
(WTF::CrossThreadRefCounted::isOwnedByCurrentThread): Moved out common code from asserts.
(WTF::CrossThreadRefCounted::ref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::deref): Changed assert to use the common method.
(WTF::CrossThreadRefCounted::crossThreadCopy): Since this includes a potentially
non-threadsafe operation, add an assert that the class is owned by the current thread.

WebCore:

All String::copy methods were changed to call either threadsafeCopy or crossThreadString. The method
call was made threadsafeCopy unless I could show that threadsafety wasn't needed.

No visible change in functionality so no new tests.

* dom/MessagePortChannel.cpp:
(WebCore::MessagePortChannel::EventData::EventData):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::iconForPageURL):
(WebCore::IconDatabase::iconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::defaultDatabaseFilename):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin): Since this is used by SecurityOrigin::threadsafeCopy,
it makes threadsafe calls.
(WebCore::SecurityOrigin::threadsafeCopy): The only place that called this
needed a threadsafe method.
* page/SecurityOrigin.h:
* platform/CrossThreadCopier.cpp:
(WebCore::::copy):
* platform/KURL.cpp:
(WebCore::KURL::copy):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
* platform/network/ResourceErrorBase.cpp:
(WebCore::ResourceErrorBase::copy):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::copyData):
* platform/sql/SQLValue.cpp:
(WebCore::SQLValue::SQLValue):
(WebCore::SQLValue::string):
* platform/sql/SQLValue.h:
(WebCore::SQLValue::SQLValue):
All constructors now initialize the m_number which is a double. Failure to
do so can result in unexpected crashes when it is copied in the copy constructor.
See http://blogs.msdn.com/oldnewthing/archive/2008/07/02/8679191.aspx, I was that colleague.
* platform/text/PlatformString.h:
* platform/text/String.cpp:
(WebCore::String::threadsafeCopy):
(WebCore::String::crossThreadString):
* platform/text/StringImpl.cpp:
Removed StringImpl::substringCopy which was no longer being used anywhere.
(WebCore::StringImpl::threadsafeCopy): Changed the name to indicate that
it is threadsafe.
(WebCore::StringImpl::crossThreadString): The way to get strings for
another thread which is not threadsafe. This shares the underlying buffer
with both strings and gives them a way to do threadsafe refcounting for it.
* platform/text/StringImpl.h:
* storage/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
* storage/Database.cpp:
(WebCore::updateGuidVersionMap):
(WebCore::Database::Database):
(WebCore::Database::getVersionFromDatabase):
(WebCore::Database::setVersionInDatabase):
(WebCore::Database::version):
(WebCore::Database::setExpectedVersion):
(WebCore::Database::securityOriginCopy):
(WebCore::Database::stringIdentifier):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
* storage/OriginQuotaManager.cpp:
(WebCore::OriginQuotaManager::addDatabase):
* storage/SQLError.h:
(WebCore::SQLError::message):
(WebCore::SQLError::SQLError):
* storage/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::syncTimerFired):
* storage/StorageMap.cpp:
(WebCore::StorageMap::importItem):
* storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::StorageSyncManager):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::url): Do the copy of the url in a way that is threadsafe.
(WebCore::SharedWorkerProxy::name):
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::DefaultSharedWorkerRepository::getProxy): Do the copy of the url in a way that is threadsafe.
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::MessageWorkerContextTask::MessageWorkerContextTask):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::Task::Task):
(WebCore::WorkerRunLoop::postTaskForMode):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Windowless plugins: Use X Pixmap instead of QPixmap.
hausmann@webkit.org [Tue, 6 Oct 2009 07:35:37 +0000 (07:35 +0000)]
[Qt] Windowless plugins: Use X Pixmap instead of QPixmap.

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

This has the following advantages:
1. Allows more sharing of code between gtk and Qt ports in the future
2. QPixmap creates 24-bit by default. We have to later 'upgrade' it to 32-bit.
3. QPixmap may sometime change depth behind our back! This will require us to
update the plugin about the new visual and colormap.
4. We cannot ensure that QPixmap is backed by a X Drawable. For example, with
-graphicssystem raster, QPixmap uses the raster (image) backend.

https://bugs.webkit.org/show_bug.cgi?id=20081

* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add support for windowless NPAPI plugins
hausmann@webkit.org [Tue, 6 Oct 2009 07:31:22 +0000 (07:31 +0000)]
[Qt] Add support for windowless NPAPI plugins

Patch by Girish Ramakrishnan <girish@forwardbias.in> on 2009-10-06
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=20081

* plugins/PluginView.cpp:
(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::PluginView):
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::dispatchNPEvent):
(WebCore::setSharedXEventFields):
(WebCore::PluginView::initXEvent):
(WebCore::setXKeyEventSpecificFields):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::inputEventState):
(WebCore::setXButtonEventSpecificFields):
(WebCore::setXMotionEventSpecificFields):
(WebCore::setXCrossingEventSpecificFields):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleFocusInEvent):
(WebCore::PluginView::handleFocusOutEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::forceRedraw):
(WebCore::getPluginDisplay):
(WebCore::PluginView::platformStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 6 Oct 2009 07:02:35 +0000 (07:02 +0000)]
2009-10-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Convert DOM Storage's "remove-item" test into the new format.
        https://bugs.webkit.org/show_bug.cgi?id=30099

        Convert DOM Storage's "remove-item" test into the new format and add it for
        session storage.  Make it a (tiny bit) more robust as well.

        * storage/domstorage/localstorage/remove-item-expected.txt:
        * storage/domstorage/localstorage/remove-item.html:
        * storage/domstorage/script-tests/remove-item.js: Added.
        (runTest):
        * storage/domstorage/sessionstorage/remove-item-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/remove-item-expected.txt.
        * storage/domstorage/sessionstorage/remove-item.html: Copied from LayoutTests/storage/domstorage/localstorage/remove-item.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 6 Oct 2009 07:01:12 +0000 (07:01 +0000)]
2009-10-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Add a test to verify session storage does not have a quota
        https://bugs.webkit.org/show_bug.cgi?id=30093

        * storage/domstorage/script-tests/no-quota.js: Added.
        (runTest):
        * storage/domstorage/sessionstorage/no-quota-expected.txt: Added.
        * storage/domstorage/sessionstorage/no-quota.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 6 Oct 2009 06:58:08 +0000 (06:58 +0000)]
2009-10-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Convert DOM Storage's "complex-values" test into the new format.
        https://bugs.webkit.org/show_bug.cgi?id=30097

        Convert DOM Storage's "complex-values" test into the new format and add it for
        session storage.  This also increases the coverage of these tests a bit.

        * storage/domstorage/localstorage/complex-values-expected.txt:
        * storage/domstorage/localstorage/complex-values.html:
        * storage/domstorage/script-tests/complex-values.js: Added.
        (handleStorageEvent):
        (testKeyValue):
        (runTest):
        * storage/domstorage/sessionstorage/complex-values-expected.txt: Copied from LayoutTests/storage/domstorage/localstorage/complex-values-expected.txt.
        * storage/domstorage/sessionstorage/complex-values.html: Copied from LayoutTests/storage/domstorage/localstorage/complex-values.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 6 Oct 2009 06:56:20 +0000 (06:56 +0000)]
2009-10-05  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Convert DOM Storage's "complex-keys" test into the new format
        https://bugs.webkit.org/show_bug.cgi?id=30089

        Convert DOM Storage's "complex-keys" test into the new format and add it for
        session storage.  This test should be a bit more thorough than the old
        version as well.

        * storage/domstorage/localstorage/complex-keys-expected.txt:
        * storage/domstorage/localstorage/complex-keys.html:
        * storage/domstorage/script-tests/complex-keys.js: Added.
        (runTest):
        * storage/domstorage/sessionstorage/complex-keys-expected.txt: Added.
        * storage/domstorage/sessionstorage/complex-keys.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 6 Oct 2009 05:58:44 +0000 (05:58 +0000)]
2009-10-05  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Filters do not support source images besides "sourceGraphic"
        [https://bugs.webkit.org/show_bug.cgi?id=6022]

        Add support for SourceAlpha to SVG filters.

        Test: svg/filters/sourceAlpha.svg

        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::calculateEffectRect):
        (WebCore::SourceAlpha::apply):
        * platform/graphics/filters/SourceAlpha.h:

        Test for SVG's SourceAlpha support for Filters.

        * platform/mac/svg/filters/sourceAlpha-expected.checksum: Added.
        * platform/mac/svg/filters/sourceAlpha-expected.png: Added.
        * platform/mac/svg/filters/sourceAlpha-expected.txt: Added.
        * svg/filters/sourceAlpha.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Mark Rowe.
mitz@apple.com [Tue, 6 Oct 2009 05:13:19 +0000 (05:13 +0000)]
Rubber-stamped by Mark Rowe.

Moved a WebPluginHalterClient out of the WebCore namesapce.

* WebCoreSupport/WebPluginHalterClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowx libjpeg link fix and JSC build fix.
kevino@webkit.org [Tue, 6 Oct 2009 05:07:01 +0000 (05:07 +0000)]
wx libjpeg link fix and JSC build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 04:58:55 +0000 (04:58 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        Updated results for media tests after controller change to add the fullscreen button.

        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/controls-after-reload-expected.checksum: Added.
        * platform/mac/media/controls-after-reload-expected.png: Added.
        * platform/mac/media/controls-after-reload-expected.txt:
        * platform/mac/media/controls-styling-expected.checksum:
        * platform/mac/media/controls-styling-expected.png:
        * platform/mac/media/controls-styling-expected.txt:
        * platform/mac/media/video-aspect-ratio-expected.checksum:
        * platform/mac/media/video-aspect-ratio-expected.png:
        * platform/mac/media/video-empty-source-expected.checksum:
        * platform/mac/media/video-empty-source-expected.png:
        * platform/mac/media/video-empty-source-expected.txt:
        * platform/mac/media/video-no-audio-expected.checksum:
        * platform/mac/media/video-no-audio-expected.png:
        * platform/mac/media/video-no-audio-expected.txt:
        * platform/mac/media/video-transformed-expected.checksum:
        * platform/mac/media/video-transformed-expected.png:
        * platform/mac/media/video-zoom-controls-expected.checksum: Added.
        * platform/mac/media/video-zoom-controls-expected.png: Added.
        * platform/mac/media/video-zoom-controls-expected.txt:
        * platform/mac/media/video-zoom-expected.checksum:
        * platform/mac/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Dan Bernstein.
kdecker@apple.com [Tue, 6 Oct 2009 04:58:54 +0000 (04:58 +0000)]
    Reviewed by Dan Bernstein.

        Added new PluginHalter client, delegate and few more WebPreferences keys.

        * WebView/WebPreferenceKeysPrivate.h: Added two new keys.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Initialize newly added key.
        (-[WebPreferences pluginAllowedRunTime]): Added.
        (-[WebPreferences setPluginAllowedRunTime:]): Added.
        * WebView/WebPreferencesPrivate.h: Added above two methods.
        * WebView/WebUIDelegatePrivate.h: Added shouldHaltPlugin delegate.
        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        Setup a new WebPluginHalterClient.
        (-[WebView _preferencesChangedNotification:]): Update WebCore settings accordingly.
        * WebCoreSupport/WebPluginHalterClient.h: Added.
        * WebCoreSupport/WebPluginHalterClient.mm: Added.
        (WebPluginHalterClient::WebPluginHalterClient):
        (WebPluginHalterClient::shouldHaltPlugin): Added, invoke the delegate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 John Abd-El-Malek <jam@chromium.org>
abarth@webkit.org [Tue, 6 Oct 2009 04:55:14 +0000 (04:55 +0000)]
2009-10-05  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Adam Barth.

        Fix reliablity bot crash in DateExtension.
        https://bugs.webkit.org/show_bug.cgi?id=30033

        There were a few problems using the weak persistent pointers because no one else had a
        handle to them.  The new approach stores them as a hidden value on the Date constructor.

        * bindings/v8/DateExtension.cpp:
        (WebCore::DateExtension::setAllowSleep):
        (WebCore::DateExtension::GetNativeFunction):
        (WebCore::DateExtension::Setup):
        (WebCore::DateExtension::OnSleepDetected):
        * bindings/v8/DateExtension.h:
        * bindings/v8/V8HiddenPropertyName.cpp:
        (WebCore::V8HiddenPropertyName::sleepFunction):
        * bindings/v8/V8HiddenPropertyName.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 04:40:44 +0000 (04:40 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        More build fixes for Tiger.

        * WebView/WebVideoFullscreenController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 04:17:55 +0000 (04:17 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        More build fixes for Tiger.

        * WebView/WebVideoFullscreenController.mm:
        (-[WebVideoFullscreenWindow animationDidEnd:]):
        * WebView/WebWindowAnimation.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash when trying to load a null stylesheet for a site specific hack.
slewis@apple.com [Tue, 6 Oct 2009 04:17:31 +0000 (04:17 +0000)]
Crash when trying to load a null stylesheet for a site specific hack.
https://bugs.webkit.org/show_bug.cgi?id=30105

Reviewed by Dan Bernstein.

Created a testcase and tested in browser.  DRT doesn't test
site specific hacks.

* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 James Robinson <jamesr@google.com>
eric@webkit.org [Tue, 6 Oct 2009 04:12:41 +0000 (04:12 +0000)]
2009-10-05  James Robinson  <jamesr@google.com>

        Reviewed by Darin Adler.

        Fix forward declaration (struct vs class mismatch)

        https://bugs.webkit.org/show_bug.cgi?id=30094

        * loader/RedirectScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 03:58:43 +0000 (03:58 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        More build fixes for Tiger.

        * WebView/WebVideoFullscreenController.mm:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
        (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
        (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
        (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
        (-[WebVideoFullscreenHUDWindowController closeWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, last Chromium build fix corresponding to revision 49113.
jparent@chromium.org [Tue, 6 Oct 2009 01:53:04 +0000 (01:53 +0000)]
Unreviewed, last Chromium build fix corresponding to revision 49113.
Add include for BeforeLoadEvent to DOMObjectsInclude.h.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-05
* bindings/v8/DOMObjectsInclude.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Tue, 6 Oct 2009 01:47:20 +0000 (01:47 +0000)]
2009-10-05  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        One of the dependencies' SVN url was missing a @ before the revision number.

        https://bugs.webkit.org/show_bug.cgi?id=30101

        * chromium/DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 01:21:04 +0000 (01:21 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        Build fixes for Tiger.

        * WebView/WebVideoFullscreenHUDWindowController.h:
        * WebView/WebVideoFullscreenHUDWindowController.mm:
        (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
        (-[WebVideoFullscreenHUDWindowController dealloc]):
        (-[WebVideoFullscreenHUDWindowController closeWindow]):
        (-[WebVideoFullscreenHUDWindowController windowDidLoad]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 01:05:34 +0000 (01:05 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        Build fix. If you call Node::hasTagName(), you also have to include Element.h.

        * WebCoreSupport/WebChromeClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 00:43:21 +0000 (00:43 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        Fix Windows build.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 6 Oct 2009 00:40:02 +0000 (00:40 +0000)]
2009-10-05  Simon Fraser  <simon.fraser@apple.com>

        Fix the build: MediaControllerThemeQT was renamed to MediaControllerThemeQuickTime.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::shouldRenderMediaControlPart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-05 Pierre d'Herbemont <pdherbemont@webkit.org>
simon.fraser@apple.com [Tue, 6 Oct 2009 00:24:47 +0000 (00:24 +0000)]
2009-10-05  Pierre d'Herbemont  <pdherbemont@webkit.org>

        Reviewed by Simon Fraser

        Support fullscreen in MediaPlayer (Mac)
        https://bugs.webkit.org/show_bug.cgi?id=26742

        Add a fullscreen button to the <video> controller if the media engine,
        and the theme have support for fullscreen, and can show appropriate controls.
        Clicking the button calls through the ChromeClient to the WebVideoFullscreenController
        in WebKit to do a nice animation to fullscreen, with a custom controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49136 268f45cc-cd09-0410-ab3c-d52691b4dbfc