WebKit-https.git
7 years agoSimplify hitTestResultAtPoint and nodesFromRect APIs
allan.jensen@nokia.com [Fri, 7 Sep 2012 16:09:16 +0000 (16:09 +0000)]
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720

Reviewed by Antonio Gomes.

.:

Update exported symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.

* WebCore.exp.in:
* WebCore.order:
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* dom/Document.h:
(Document):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
* page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::updateAutoscrollRenderer):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):
* page/EventHandler.h:
(EventHandler):
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
* rendering/HitTestRequest.h:
(HitTestRequest):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Update calls to new API.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtPoint):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
(BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

Update calls to new API.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseUp):
(WebKit::WebViewImpl::computeBlockBounds):

Source/WebKit/efl:

Update calls to new API.

* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):

Source/WebKit/mac:

Update calls to new API.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
* WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

Update calls to new API.

* Api/qwebframe.cpp:
(QWebFrame::hitTestContent):
* Api/qwebpage.cpp:
(QWebPagePrivate::handleSoftwareInputPanel):
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
(QWebPage::updatePositionDependentActions):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):

Source/WebKit/win:

Update calls to new API.

* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
* WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):

Source/WebKit/wx:

Update calls to new API.

* WebFrame.cpp:
(WebKit::WebFrame::HitTest):

Source/WebKit2:

Update calls to new API and update exported symbols.

* WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation): Corrects the misplaced arguments while converting them.
(WebKit::WebPage::findZoomableAreaForPoint):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the google-android-tests build slave to the master's config
peter@chromium.org [Fri, 7 Sep 2012 16:06:23 +0000 (16:06 +0000)]
Add the google-android-tests build slave to the master's config
https://bugs.webkit.org/show_bug.cgi?id=96113

Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild of OpenGLShims.cpp against EGL/GLES2 platforms is broken
hausmann@webkit.org [Fri, 7 Sep 2012 16:05:12 +0000 (16:05 +0000)]
Build of OpenGLShims.cpp against EGL/GLES2 platforms is broken
https://bugs.webkit.org/show_bug.cgi?id=95556

Reviewed by Jocelyn Turcotte.

There were a few problems:

1) GL_ANGLE_framebuffer_blit is the name of the macro indicating the
availability of the _declaration_ of that ANGLE extension. It is not the
name of the actual function, which is glBlitFramebufferANGLE.

2) The presence of the preprocessor macros indicating the availability
of the declaration of the extension does not imply presence of the extension
prototypes at link time. Instead extensions need to be looked up dynamically
at run-time.

3) dlfcn.h was unconditionally included. We do not need it when building against
Qt (and there it breaks the Windows build)

This patch implements the dynamic lookup of glBlitFramebufferANGLE
(used in GraphicsContext3DOpenGLES.cpp) as well as the dynamic lookup of the
Angle and Apple renderbuffer multisampling extensions.

* platform/graphics/OpenGLShims.cpp:
(WebCore):
(WebCore::initializeOpenGLShims):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [EFL] Set theme for WebKit2 API test runner
commit-queue@webkit.org [Fri, 7 Sep 2012 16:03:25 +0000 (16:03 +0000)]
[WK2] [EFL] Set theme for WebKit2 API test runner
https://bugs.webkit.org/show_bug.cgi?id=96100

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

Set the theme generated by the build for the WebKit2 API test runner.

* TestWebKitAPI/PlatformEfl.cmake:
* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Multiple feature defines in webcore_cppflags can occur
zandobersek@gmail.com [Fri, 7 Sep 2012 16:01:56 +0000 (16:01 +0000)]
[GTK] Multiple feature defines in webcore_cppflags can occur
https://bugs.webkit.org/show_bug.cgi?id=95942

Reviewed by Martin Robinson.

.:

Add the feature_defines_unstable variable that should control values of feature
defines for unstable features when unstable features are not enabled (e.g. release builds).

* GNUmakefile.am:

Source/WebCore:

Any feature define that guards a feature deemed currently unstable (is intended
to be enabled in developer builds but not in release builds) should be added to the
newly-added feature_defines_unstable variable.

This moves away from adding such feature defines to the feature_defines_overrides variable
as this can cause duplicates in the later-generated feature_defines and webcore_cppflags
variables and further warnings of duplicate macros when generating bindings.

The feature_defines generation is now done by first checking if the bare feature define
is present in feature_defines_unstable, if not then feature_defines_overrides is also
checked before using the value from feature_defines_defaults.

No new tests - no new functionality.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening.
fsamuel@chromium.org [Fri, 7 Sep 2012 16:01:37 +0000 (16:01 +0000)]
Unreviewed Chromium gardening.

Disabled test paste-global-selection on Chromium Linux that was failing.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rendering issue after rotation
commit-queue@webkit.org [Fri, 7 Sep 2012 15:53:14 +0000 (15:53 +0000)]
[BlackBerry] Rendering issue after rotation
https://bugs.webkit.org/show_bug.cgi?id=96094
PR #201930

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-07
Reviewed by George Staikos.

The cause of the rendering issue is that the BackingStore tiles
are not reset after layout. This is a regression of r125680, which
overwrites a local variable that are used later in the function.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: move WebCore specific code to separate header
loislo@chromium.org [Fri, 7 Sep 2012 15:36:43 +0000 (15:36 +0000)]
Web Inspector: NMI: move WebCore specific code to separate header
https://bugs.webkit.org/show_bug.cgi?id=96101

Reviewed by Yury Semikhatsky.

I extracted WebCore related code from MemoryInstrumentation.h to WebCoreMemoryInstrumentation.h

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptWrappable.h:
* bindings/v8/DOMDataStore.cpp:
* bindings/v8/IntrusiveDOMWrapperMap.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/ScriptWrappable.h:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8DOMMap.h:
* css/CSSAspectRatioValue.cpp:
* css/CSSBorderImageSliceValue.cpp:
* css/CSSCalculationValue.cpp:
* css/CSSCanvasValue.cpp:
* css/CSSCharsetRule.cpp:
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSCrossfadeValue.cpp:
* css/CSSCursorImageValue.cpp:
* css/CSSFontFaceRule.cpp:
* css/CSSFontFaceSrcValue.cpp:
* css/CSSFunctionValue.cpp:
* css/CSSGradientValue.cpp:
* css/CSSImageGeneratorValue.cpp:
* css/CSSImageSetValue.cpp:
* css/CSSImageValue.cpp:
* css/CSSImportRule.cpp:
* css/CSSInheritedValue.cpp:
* css/CSSInitialValue.cpp:
* css/CSSLineBoxContainValue.cpp:
* css/CSSMediaRule.cpp:
* css/CSSPrimitiveValue.cpp:
* css/CSSProperty.cpp:
* css/CSSReflectValue.cpp:
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
* css/CSSStyleRule.cpp:
* css/CSSStyleSheet.cpp:
* css/CSSTimingFunctionValue.cpp:
* css/CSSUnicodeRangeValue.cpp:
* css/CSSUnknownRule.h:
* css/CSSValue.cpp:
* css/CSSValueList.cpp:
* css/CSSVariableValue.h:
* css/FontFeatureValue.cpp:
* css/FontValue.cpp:
* css/MediaList.cpp:
* css/MediaQuery.cpp:
* css/MediaQueryExp.cpp:
* css/PropertySetCSSStyleDeclaration.cpp:
* css/ShadowValue.cpp:
* css/StyleResolver.cpp:
* css/StyleRule.cpp:
* css/StyleSheetContents.cpp:
* css/WebKitCSSArrayFunctionValue.cpp:
* css/WebKitCSSFilterValue.cpp:
* css/WebKitCSSKeyframeRule.cpp:
* css/WebKitCSSKeyframesRule.cpp:
* css/WebKitCSSMixFunctionValue.cpp:
* css/WebKitCSSSVGDocumentValue.cpp:
* css/WebKitCSSShaderValue.cpp:
* css/WebKitCSSTransformValue.cpp:
* dom/CharacterData.cpp:
* dom/Document.cpp:
* dom/DocumentEventQueue.cpp:
* dom/ElementAttributeData.cpp:
* dom/Event.cpp:
* dom/MemoryInstrumentation.h:
* dom/Node.cpp:
* dom/QualifiedName.h:
* dom/WebCoreMemoryInstrumentation.cpp: Renamed from Source/WebCore/dom/MemoryInstrumentation.cpp.
(WebCore):
(WebCore::String):
(WebCore::StringImpl):
(WebCore::KURL):
(WebCore::AtomicString):
* dom/WebCoreMemoryInstrumentation.h: Added.
(WebCore):
(WebCoreMemoryTypes):
* loader/DocumentLoader.cpp:
* loader/FrameLoader.cpp:
* loader/SubresourceLoader.cpp:
* loader/SubstituteData.cpp:
* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedRawResource.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResourceHandle.cpp:
* loader/cache/CachedScript.cpp:
* loader/cache/CachedShader.cpp:
* loader/cache/CachedXSLStyleSheet.cpp:
* loader/cache/MemoryCache.cpp:
* platform/SharedBuffer.cpp:
* platform/graphics/BitmapImage.cpp:
* platform/graphics/CrossfadeGeneratedImage.cpp:
* platform/graphics/GeneratedImage.cpp:
* platform/graphics/GeneratorGeneratedImage.h:
* platform/graphics/Image.cpp:
* platform/network/FormData.cpp:
* platform/network/ResourceRequestBase.cpp:
* platform/network/ResourceResponseBase.cpp:
* rendering/style/RenderStyle.cpp:
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareNonInheritedData.cpp:
* svg/SVGColor.cpp:
* svg/SVGPaint.cpp:

Source/WebKit/chromium:

* tests/MemoryInstrumentationTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] We should accelerate all transformations, except when we must blend matric...
vollick@chromium.org [Fri, 7 Sep 2012 15:32:40 +0000 (15:32 +0000)]
[chromium] We should accelerate all transformations, except when we must blend matrices that cannot be decomposed.
https://bugs.webkit.org/show_bug.cgi?id=95855

Reviewed by James Robinson.

Source/Platform:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

* chromium/public/WebTransformOperations.h:
(WebTransformOperations):
* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

Source/WebCore:

WebTransformOperations are now able to report if they can successfully blend.
WebTransformationMatrix::blend now returns a bool if blending would fail.

Unit tests:
  AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
  AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

* platform/chromium/support/WebTransformOperations.cpp:
(WebKit::blendTransformOperations):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::canBlendWith):
(WebKit):
(WebKit::WebTransformOperations::blendInternal):
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::blend):
* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::WebTransformAnimationCurve):

Source/WebKit/chromium:

Added the following unit tests:
  AnimationTranslationUtilTest.createTransformAnimationWithNonDecomposableMatrix
  AnimationTranslationUtilTest.createTransformAnimationWithNonInvertibleTransform

* tests/AnimationTranslationUtilTest.cpp:
(WebKit::TEST):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127780 and r127859.
apavlov@chromium.org [Fri, 7 Sep 2012 14:00:11 +0000 (14:00 +0000)]
Unreviewed, rolling out r127780 and r127859.
http://trac.webkit.org/changeset/127780
http://trac.webkit.org/changeset/127859
https://bugs.webkit.org/show_bug.cgi?id=96102

"inspector/styles/protocol-css-regions-commands.html crashing
on Chromium Linux Debug and timing out flakily on Release"
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-07

Source/WebCore:

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 7 Sep 2012 13:50:25 +0000 (13:50 +0000)]
Unreviewed GTK gardening.

Add passing expectations for a few specific sub-pixel and various input type
tests. These features are not yet supported by the GTK port but we're willing
to watch and monitor these tests' behavior.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Dynamically removing preserve-3d from a layer has no effect
commit-queue@webkit.org [Fri, 7 Sep 2012 13:37:32 +0000 (13:37 +0000)]
[chromium] Dynamically removing preserve-3d from a layer has no effect
https://bugs.webkit.org/show_bug.cgi?id=95732

Patch by Sami Kyostila <skyostil@google.com> on 2012-09-07
Reviewed by James Robinson.

Source/WebCore:

Fix removal of preserve-3d CSS attribute from a GraphicsLayerChromium.
It was broken by a refactor in http://trac.webkit.org/changeset/126378.

Test: platform/chromium/compositing/preserve-3d-toggle.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

LayoutTests:

Add test to verify dynamic removal of preserve-3d CSS attribute.

* platform/chromium/compositing/preserve-3d-toggle-expected.png: Added.
* platform/chromium/compositing/preserve-3d-toggle-expected.txt: Added.
* platform/chromium/compositing/preserve-3d-toggle.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Implement SCSS source highlighter
apavlov@chromium.org [Fri, 7 Sep 2012 13:24:43 +0000 (13:24 +0000)]
Web Inspector: Implement SCSS source highlighter
https://bugs.webkit.org/show_bug.cgi?id=95585

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change modifies the existing CSS highlighter to support SCSS as well. The "text/x-scss" mime-type is assigned to SASSSource.

* inspector/front-end/CSSCompletions.js:
(WebInspector.CSSCompletions.cssPropertiesMetainfoKeySet):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider): Enabled clients to supply the content mime-type.
(WebInspector.StaticContentProvider.prototype.mimeType):
(WebInspector.StaticContentProvider.prototype.requestContent): Use client-supplied content mime-type, if any.
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSource): Construct StaticContentProvider with the "text/x-scss" mime-type.
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer):
(WebInspector.SourceCSSTokenizer.prototype.nextToken):
* inspector/front-end/SourceCSSTokenizer.re2js: Extended with the SCSS syntax.
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer.Registry):
* inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-css-bang-keyword):

LayoutTests:

Test modified to cover the SCSS syntax as well.

* inspector/syntax-highlight-css-expected.txt:
* inspector/syntax-highlight-css.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test touchadjustment/iframe-boundary.html is failing
allan.jensen@nokia.com [Fri, 7 Sep 2012 12:59:19 +0000 (12:59 +0000)]
Layout Test touchadjustment/iframe-boundary.html is failing
https://bugs.webkit.org/show_bug.cgi?id=95799

Unreviewed, fudge the test so it has a larger margin of error.

* platform/chromium/TestExpectations:
* touchadjustment/iframe-boundary.html:
* touchadjustment/resources/inner-content-page.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoX11 Global Selection
allan.jensen@nokia.com [Fri, 7 Sep 2012 12:51:44 +0000 (12:51 +0000)]
X11 Global Selection
https://bugs.webkit.org/show_bug.cgi?id=88238

Reviewed by Tony Chang.

Source/WebCore:

In X11 global selection is the ability to share the active selection
between applications and pasting with middle mouse-button.

This patch moves the implementations of global selection from the
separate implementations in Qt WebKit, Chromium and GTK to WebCore,
by implementing a new EditorCommand for pasting the global selection.

Test: editing/pasteboard/paste-global-selection.html

* editing/EditorCommand.cpp:
(WebCore::executePasteGlobalSelection):
(WebCore::createCommandMap):
* page/EditorClient.h:
(EditorClient):
(WebCore::EditorClient::supportsGlobalSelection):
* platform/Pasteboard.h:
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writeURL):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):

Source/WebKit/chromium:

Use new editor command for pasting global selection.

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::supportsGlobalSelection):
* src/EditorClientImpl.h:
(EditorClientImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseUp):

Source/WebKit/qt:

Use new editor command for pasting global selection, and update it using
the respondToChangedSelection callback.

* Api/qwebpage.cpp:
(QWebPagePrivate::handleClipboard):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::supportsGlobalSelection):
* WebCoreSupport/EditorClientQt.h:
(EditorClientQt):

Source/WebKit2:

Implements the hooks for supporting global selections in Qt WebKit2.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
(WebKit::WebEditorClient::updateGlobalSelection):
(WebKit::WebEditorClient::supportsGlobalSelection):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::updateGlobalSelection):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleMouseEvent):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::handleMouseReleaseEvent):

LayoutTests:

Adds a test for the new editor-command, and disables it an all platforms where it is not supported.

* editing/pasteboard/paste-global-selection-expected.txt: Added.
* editing/pasteboard/paste-global-selection.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt-mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Migrate Database to async protocol commands
vsevik@chromium.org [Fri, 7 Sep 2012 12:32:51 +0000 (12:32 +0000)]
Web Inspector: Migrate Database to async protocol commands
https://bugs.webkit.org/show_bug.cgi?id=95983

Reviewed by Alexander Pavlov.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorDatabaseAgent.cpp:
(WebCore):
(WebCore::InspectorDatabaseAgent::didOpenDatabase):
(WebCore::InspectorDatabaseAgent::setFrontend):
(WebCore::InspectorDatabaseAgent::clearFrontend):
(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::executeSQL):
* inspector/InspectorDatabaseAgent.h:
(InspectorDatabaseAgent):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed single line follow-up change for r127856.
loislo@chromium.org [Fri, 7 Sep 2012 12:29:55 +0000 (12:29 +0000)]
Unreviewed single line follow-up change for r127856.

* dom/MemoryInstrumentation.h:
(WebCore::MemoryClassInfo::MemoryClassInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed inspector closure compilation errors fix.
vsevik@chromium.org [Fri, 7 Sep 2012 12:26:45 +0000 (12:26 +0000)]
Unreviewed inspector closure compilation errors fix.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.NamedFlowCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Migrate FileSystem to async protocol commands.
vsevik@chromium.org [Fri, 7 Sep 2012 12:23:52 +0000 (12:23 +0000)]
Web Inspector: Migrate FileSystem to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95985

Reviewed by Alexander Pavlov.

Source/WebCore:

Migrated FileSystem domain to async protocol commands and removed boilerplate code.

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::~InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
(WebCore::InspectorFileSystemAgent::requestFileContent):
(WebCore::InspectorFileSystemAgent::deleteEntry):
(WebCore::InspectorFileSystemAgent::clearFrontend):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
(WebCore::InspectorFileSystemAgent::assertEnabled):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel):
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype.requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._requestDirectoryContent):
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.prototype.requestFileContent):
(WebInspector.FileSystemModel.prototype._requestFileContent):
(WebInspector.FileSystemModel.prototype._deleteEntry):

LayoutTests:

* http/tests/inspector/filesystem/delete-entry.html:
* http/tests/inspector/filesystem/directory-tree.html:
* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.MockEntry):
* http/tests/inspector/filesystem/request-directory-content.html:
* http/tests/inspector/filesystem/request-file-content.html:
* http/tests/inspector/filesystem/request-filesystem-root.html:
* http/tests/inspector/filesystem/request-metadata.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Update TextExpectations for http/tests/appcache/load-from-appcache-defer...
commit-queue@webkit.org [Fri, 7 Sep 2012 12:17:40 +0000 (12:17 +0000)]
[EFL][WK2] Update TextExpectations for http/tests/appcache/load-from-appcache-defer-resume-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96091

Unreviewed EFL gardening.

Add bug number of http/tests/appcache/load-from-appcache-defer-resume-crash.html
in TestExpectations file.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-07

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: remove DataRef instrumentation from the core NMI code.
loislo@chromium.org [Fri, 7 Sep 2012 12:10:22 +0000 (12:10 +0000)]
Web Inspector: NMI: remove DataRef instrumentation from the core NMI code.
https://bugs.webkit.org/show_bug.cgi?id=96086

Reviewed by Yury Semikhatsky.

This patch is removing the last WebCore specific methods from core memory instrumentation code.

It is covered by webkit_unit_tests.

* dom/MemoryInstrumentation.h:
(WebCore):
(MemoryObjectInfo):
(WebCore::MemoryClassInfo::MemoryClassInfo):
* rendering/style/DataRef.h:
(DataRef):
(WebCore::DataRef::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip passing tests on EFL build bot
commit-queue@webkit.org [Fri, 7 Sep 2012 12:05:30 +0000 (12:05 +0000)]
[EFL] Unskip passing tests on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=96089

Unreviewed EFL gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-07

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Migrate IndexedDB to async protocol commands.
vsevik@chromium.org [Fri, 7 Sep 2012 11:57:07 +0000 (11:57 +0000)]
Web Inspector: Migrate IndexedDB to async protocol commands.
https://bugs.webkit.org/show_bug.cgi?id=95978

Reviewed by Alexander Pavlov.

Source/WebCore:

IndexedDB is now implemented using async protocol commands.
Removed boilerplate code used to emulate async commands before.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::clearFrontend):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.loadObjectStoreData):
(WebInspector.IndexedDBModel.prototype.loadIndexData):
(WebInspector.IndexedDBModel.prototype._requestData.innerCallback):
(WebInspector.IndexedDBModel.prototype._requestData):

LayoutTests:

* http/tests/inspector/indexeddb/database-data.html:
* http/tests/inspector/indexeddb/database-names.html:
* http/tests/inspector/indexeddb/database-structure.html:
* http/tests/inspector/indexeddb/resources-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Add Gábor Ballabás as contributor.
ossy@webkit.org [Fri, 7 Sep 2012 11:45:24 +0000 (11:45 +0000)]
Unreviewed. Add Gábor Ballabás as contributor.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd *explicit* keyword to constructors in WebCore/xml
gyuyoung.kim@samsung.com [Fri, 7 Sep 2012 11:04:06 +0000 (11:04 +0000)]
Add *explicit* keyword to constructors in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=96071

Reviewed by Kentaro Hara.

As a step to let *explicit* add to constructors which have only one parameter,
*explicit* is added to Source/WebCore/xml in order to avoid implicit type conversion.

No new tests. Covered by existing tests.

* xml/NativeXPathNSResolver.h:
(NativeXPathNSResolver):
* xml/XMLHttpRequestException.h:
(WebCore::XMLHttpRequestException::XMLHttpRequestException):
* xml/XMLHttpRequestProgressEventThrottle.h:
(XMLHttpRequestProgressEventThrottle):
* xml/XMLHttpRequestUpload.h:
(XMLHttpRequestUpload):
* xml/XPathException.h:
(WebCore::XPathException::XPathException):
* xml/XPathPredicate.h:
(Number):
(StringExpression):
(Predicate):
* xml/XPathValue.h:
(WebCore::XPath::ValueData::ValueData):
* xml/XPathVariableReference.h:
(VariableReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
commit-queue@webkit.org [Fri, 7 Sep 2012 10:44:57 +0000 (10:44 +0000)]
[Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
https://bugs.webkit.org/show_bug.cgi?id=96078

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-07
Reviewed by Tor Arne Vestbø.

Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add TestExpectations file for efl-wk1
commit-queue@webkit.org [Fri, 7 Sep 2012 10:26:02 +0000 (10:26 +0000)]
[EFL] Add TestExpectations file for efl-wk1
https://bugs.webkit.org/show_bug.cgi?id=96019

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

Tools:

Update TestExpectations cascading for EFL port
so that we use efl-wk1 -> efl search paths
for WebKit1 EFL.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._search_paths):

LayoutTests:

Add TestExpectations file for WebKit1 EFL.

* platform/efl-wk1/TestExpectations: Added.
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] XvfbDriver should stop the Xvfb more aggressively
zandobersek@gmail.com [Fri, 7 Sep 2012 10:01:13 +0000 (10:01 +0000)]
[NRWT] XvfbDriver should stop the Xvfb more aggressively
https://bugs.webkit.org/show_bug.cgi?id=95097

Reviewed by Dirk Pranke.

The Xvfb process is now killed when the XvfbDriver is stopping. Simply
terminating the process does not always work as expected, leading to timeouts
in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
as it's not removed by the killed Xvfb process.

Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
is tested in different circumstances - whether pixel tests are enabled or not,
with an arbitrary worker number or with an Xorg process already running on the system.
The stopping of the driver is tested by checking that the Xvfb process is truly killed
and then set to None.

* BuildSlaveSupport/kill-old-processes:
Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
is left running, potentially clogging up a display at a certain position.
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.__init__):
The _running_pids is now a dictionary with process names as keys and pids
as values.
(MockExecutive.check_running_pid):
Check whether the passed-in pid is in the _running_pids dictionary's values.
(MockExecutive):
(MockExecutive.running_pids):
This method returns the list of all the process pids of which the name passes
through the process_name_filter.
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
Use the Executive object of the port's host to check for running pids and open
new subprocesses or kill them throughout the class.
(XvfbDriver._start):
Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
start the server process after it's created.
(XvfbDriver.stop):
Now kills the Xvfb process instead of terminating it and waiting for it to close.
* Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
(XvfbDriverTest):
(XvfbDriverTest.make_driver):
(XvfbDriverTest.assertDriverStartSuccessful):
(XvfbDriverTest.test_start_no_pixel_tests):
(XvfbDriverTest.test_start_pixel_tests):
(XvfbDriverTest.test_start_arbitrary_worker_number):
(XvfbDriverTest.test_start_existing_xorg_process):
(XvfbDriverTest.test_stop):
(XvfbDriverTest.test_stop.FakeXvfbProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127839.
gyuyoung.kim@samsung.com [Fri, 7 Sep 2012 09:59:59 +0000 (09:59 +0000)]
Unreviewed, rolling out r127839.
http://trac.webkit.org/changeset/127839
https://bugs.webkit.org/show_bug.cgi?id=90603

This patch was landed with wrong implementation and policy.

* WebCoreSupport/NotificationPresenterClientEfl.cpp:
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h:
(NotificationPresenterClientEfl):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce the Chromium Android Release (Tests) bot
peter@chromium.org [Fri, 7 Sep 2012 09:20:07 +0000 (09:20 +0000)]
Introduce the Chromium Android Release (Tests) bot
https://bugs.webkit.org/show_bug.cgi?id=95980

Reviewed by Adam Barth.

This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
which will be running layout tests on actual Android devices. Right now,
four Galaxy Nexus phones are attached.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Allow enumeration of WebRenderingStats structure
nduca@chromium.org [Fri, 7 Sep 2012 08:58:36 +0000 (08:58 +0000)]
[chromium] Allow enumeration of WebRenderingStats structure
https://bugs.webkit.org/show_bug.cgi?id=94565

Reviewed by James Robinson.

* chromium/public/WebRenderingStats.h:
(WebRenderingStats):
(Enumerator):
(WebKit::WebRenderingStats::Enumerator::~Enumerator):
(WebKit::WebRenderingStats::enumerateFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] APIClientTraits<WKPageLoaderClient> and APIClientTraits<WKBundlePageLoaderClien...
commit-queue@webkit.org [Fri, 7 Sep 2012 08:52:26 +0000 (08:52 +0000)]
[WK2] APIClientTraits<WKPageLoaderClient> and APIClientTraits<WKBundlePageLoaderClient> are not initialized properly
https://bugs.webkit.org/show_bug.cgi?id=96079

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-07
Reviewed by Kenneth Rohde Christiansen.

APIClientTraits<WKPageLoaderClient> was missing offset for version number 2 and
APIClientTraits<WKBundlePageLoaderClient> was missing offset for version number 3.

* Shared/APIClientTraits.cpp:
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines for windows due to r127831.
annacc@chromium.org [Fri, 7 Sep 2012 08:47:38 +0000 (08:47 +0000)]
Rebaselines for windows due to r127831.

Unreviewed gardening.

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Removed.
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWe should have a localized string of empty for date time field
yosin@chromium.org [Fri, 7 Sep 2012 08:46:03 +0000 (08:46 +0000)]
We should have a localized string of empty for date time field
https://bugs.webkit.org/show_bug.cgi?id=96081

Reviewed by Kent Tamura.

Source/Platform:

This patch adds a localized string enum field for empty field value
description text for accessibility support in multiple fields date
time related input types for Chromium ports.

* chromium/public/WebLocalizedString.h: Added AXDateTimeFieldEmptyValueText
enum field.

Source/WebCore:

This patch add a declaration of function for getting localized string
of empty field value date time field for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

* platform/LocalizedStrings.h:
(WebCore): Added a declaration of AXDateTimeFieldEmptyValueText().

Source/WebKit/chromium:

This patch add a function for getting localized string of empty field
value of date time fields for accessibility inside
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

* src/LocalizedStrings.cpp:
(WebCore::AXDateTimeFieldEmptyValueText): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add APIs to enable or disable the mouse events of the ewk_view.
commit-queue@webkit.org [Fri, 7 Sep 2012 08:28:09 +0000 (08:28 +0000)]
[EFL][WK2] Add APIs to enable or disable the mouse events of the ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=88631

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

We can turn on/off the mouse events of the ewk_view using the mouse
events enabling API. This API can be used when we want to turn off the
mouse events on the touchscreen device to process the touch events
instead of the mouse events.

* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_smart_add):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use ASCIILiteral for cursorStringMap.
ryuan.choi@samsung.com [Fri, 7 Sep 2012 08:19:10 +0000 (08:19 +0000)]
[EFL] Use ASCIILiteral for cursorStringMap.
https://bugs.webkit.org/show_bug.cgi?id=96072

Reviewed by Gyuyoung Kim.

This patch converts static strings of cursorStringMap to use ASCIILiteral
as recommended by http://trac.webkit.org/wiki/EfficientStrings.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::CursorMap::CursorMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrolling performance logging should use WTFLogAlways instead of printf
timothy_horton@apple.com [Fri, 7 Sep 2012 08:08:37 +0000 (08:08 +0000)]
Scrolling performance logging should use WTFLogAlways instead of printf
https://bugs.webkit.org/show_bug.cgi?id=96080

Reviewed by Dan Bernstein.

Use WTF logging facilities instead of printf() for scrolling performance logging.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::logExposedUnfilledArea):
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer logFilledFreshTile]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Support the permission function of the Web Notification.
commit-queue@webkit.org [Fri, 7 Sep 2012 07:56:07 +0000 (07:56 +0000)]
[EFL] Support the permission function of the Web Notification.
https://bugs.webkit.org/show_bug.cgi?id=90603

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-07
Reviewed by Gyuyoung Kim.

Implement permission related functions of Web Notifications.
checkPermission for Notification.permissionLevel().
requestPermission for Notification.requestPermission().
In addition, if the application(like a browser) has permitted domains already,
it can be cached using ewk_view_notification_permissions_store.

* WebCoreSupport/NotificationPresenterClientEfl.cpp:
(WebCore::NotificationPresenterClientEfl::NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::checkPermission):
(WebCore::NotificationPresenterClientEfl::addToPermissionCache):
(WebCore):
(WebCore::NotificationPresenterClientEfl::setPermission):
* WebCoreSupport/NotificationPresenterClientEfl.h:
(WebCore):
(NotificationPresenterClientEfl):
(WebCore::NotificationPresenterClientEfl::requestPermission):
(WebCore::NotificationPresenterClientEfl::cancelRequestsForPermission):
* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_notification_permission_store):
(ewk_view_notification_permissions_set):
(ewk_view_notification_permission_request):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the...
macpherson@chromium.org [Fri, 7 Sep 2012 07:48:18 +0000 (07:48 +0000)]
Make CSSPrimitiveValue::cleanup() handle all UnitTypes, fixing memory leak in the process.
https://bugs.webkit.org/show_bug.cgi?id=95938

Reviewed by Andreas Kling.

Several unit types have been added without updating the cleanup function, including CSS_VARIABLE_NAME.
I've added all the existing unit types back in and cast m_primitiveUnitType (a bitfield in CSSValue)
to the enum type to ensure the compiler catches any future errors.

No test added, but switch made to use enum type so we can't accidentally fail to update this function again.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cleanup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd optional debug logging when we fall into/out of threaded scrolling
timothy_horton@apple.com [Fri, 7 Sep 2012 07:45:49 +0000 (07:45 +0000)]
Add optional debug logging when we fall into/out of threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898
<rdar://problem/12089098>

Reviewed by Simon Fraser.

Add logging when we enter and exit the threaded scrolling mode, and logs the reasons we
fall into main-thread scrolling.

The logging output looks like this:
    SCROLLING: Switching to main-thread scrolling mode. Time: 15843.554718 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15844.550866
    SCROLLING: Switching to main-thread scrolling mode. Time: 15845.551214 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15846.552619
    SCROLLING: Switching to main-thread scrolling mode. Time: 15847.553587 Reason(s): viewport-constrained objects
    SCROLLING: Switching to threaded scrolling mode. Time: 15848.554084

No new tests, as this is just debugging logging.

* WebCore.xcodeproj/project.pbxproj:
Expose ScrollingTreeState.h as a private header.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::setForceMainThreadScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
* page/scrolling/ScrollingCoordinatorNone.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
* page/scrolling/ScrollingTreeNode.cpp:
(WebCore::ScrollingTreeNode::ScrollingTreeNode):
(WebCore::ScrollingTreeNode::update):
* page/scrolling/ScrollingTreeNode.h:
(WebCore::ScrollingTreeNode::shouldUpdateScrollLayerPositionOnMainThreadReason):
(ScrollingTreeNode):
* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::ScrollingTreeState):
(WebCore::ScrollingTreeState::setShouldUpdateScrollLayerPositionOnMainThreadReason):
* page/scrolling/ScrollingTreeState.h:
(WebCore::ScrollingTreeState::shouldUpdateScrollLayerPositionOnMainThreadReason):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThreadReason):
Rename updateShouldUpdateScrollLayerPositionOnMainThread to updateShouldUpdateScrollLayerPositionOnMainThreadReason (and related).

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasNonLayerViewportConstrainedObjects):
Renamed from hasNonLayerFixedObjects to match the rest of the renames going on.
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThreadReason):
Construct a bitfield describing the reasons we fall into main-thread scrolling mode.

* page/scrolling/ScrollingTreeState.h:
(ScrollingTreeState):
Add ReasonsForUpdatingScrollLayerPositionOnMainThread enum, with the current reasons that we might fallback to main-thread scrolling.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore):
(WebCore::ScrollingTreeNodeMac::update): Log every time scrolling mode changes.
(WebCore::ScrollingTreeNodeMac::scrollPosition):
(WebCore::ScrollingTreeNodeMac::setScrollPositionWithoutContentEdgeConstraints):
(WebCore::ScrollingTreeNodeMac::setScrollLayerPosition):
(WebCore::logThreadedScrollingMode): Pretty-print the scrolling mode and shouldUpdateScrollLayerPositionOnMainThreadReason.

Update the scrolling tree's scrollingPerformanceLoggingEnabled preference
before the early-return if we don't have layer debugging borders on.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaselines due to r127831.
annacc@chromium.org [Fri, 7 Sep 2012 07:04:46 +0000 (07:04 +0000)]
Rebaselines due to r127831.

Unreviewed gardening.

* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.txt: Added.
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.txt:
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.txt:
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r127801.
paroga@webkit.org [Fri, 7 Sep 2012 07:03:34 +0000 (07:03 +0000)]
Build fix for WinCE after r127801.

* platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 7 Sep 2012 06:29:36 +0000 (06:29 +0000)]
Unreviewed GTK gardening.

Updating baselines for two MathML tests after r127769.

Removing failure expectations for tests fixed by changes in r127798,
rollout in r127774 and rebaseline in r127825.

* platform/gtk/TestExpectations:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Regression: Web Inspector tool-tips pixellated with --force-device-scale...
apavlov@chromium.org [Fri, 7 Sep 2012 06:26:12 +0000 (06:26 +0000)]
[Chromium] Regression: Web Inspector tool-tips pixellated with --force-device-scale-factor=2
https://bugs.webkit.org/show_bug.cgi?id=95875

Reviewed by Vsevolod Vlasov.

The overlay canvas is scaled according to the actual devicePixelRatio of the inspected page, while retaining its original CSS size.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reset):
* inspector/InspectorOverlayPage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127822.
loislo@chromium.org [Fri, 7 Sep 2012 06:15:34 +0000 (06:15 +0000)]
Unreviewed, rolling out r127822.
http://trac.webkit.org/changeset/127822
https://bugs.webkit.org/show_bug.cgi?id=96073

It broke compilation on chromium debug bots (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

* platform/graphics/chromium/cc/CCDirectRenderer.cpp:
(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):
* platform/graphics/chromium/cc/CCDirectRenderer.h:
(CCDirectRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
(WebCore::CCRenderPass::copy):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::copy):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(WebCore):
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

* tests/CCDrawQuadTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCRenderPassTest.cpp:
(WebCore::TEST):
* tests/CCRenderSurfaceTest.cpp:
* tests/CCRendererGLTest.cpp:
(FakeCCRendererClient::FakeCCRendererClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe CC button should have chrome-specific rendering for Mac.
annacc@chromium.org [Fri, 7 Sep 2012 05:59:40 +0000 (05:59 +0000)]
The CC button should have chrome-specific rendering for Mac.
https://bugs.webkit.org/show_bug.cgi?id=95981

Reviewed by Eric Carlson.

This patch allows RenderThemeChromiumMac to define its own behavior for the CC button.

No new tests.  Button should display graphics from chromium resources.

* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
Adjust styling for the chromium graphics.
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaClosedCaptionsButton):
Check whether closed captions are visible to decide how to draw the button.
* rendering/RenderThemeChromiumMac.h:
(RenderThemeChromiumMac):
Override the paint function for the CC button.
* rendering/RenderThemeChromiumMac.mm:
(WebCore):
(WebCore::RenderThemeChromiumMac::paintMediaToggleClosedCaptionsButton):
Call the chromium-specific painting function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] Skip Dialog element tests on Win
commit-queue@webkit.org [Fri, 7 Sep 2012 05:54:12 +0000 (05:54 +0000)]
[Tests] Skip Dialog element tests on Win
https://bugs.webkit.org/show_bug.cgi?id=96051

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-09-06
Reviewed by Hajime Morita.

Dialog is not yet enabled except on Chromium. Dialog tests should have
been added to the Win port's skipped list as part of r122420.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC should have a zombie mode
mhahnenberg@apple.com [Fri, 7 Sep 2012 05:53:25 +0000 (05:53 +0000)]
JSC should have a zombie mode
https://bugs.webkit.org/show_bug.cgi?id=96047

Reviewed by Geoffrey Garen.

To aid clients of JSC while they are debugging memory issues, we should add a zombie
mode that scribbles into objects in the MarkedSpace after they are found to be dead
to prevent a sort of "use after free" situation. As a first cut we should support a
mode that just scribbles on objects prior to their being reused (i.e. while they are
"zombies") and a mode in which, in addition to scribbling on zombies, once an object
has been marked its mark bit will never be cleared, thus giving us "immortal" zombies.

These two modes will be enabled through the use of environment variables. For now these
will be "JSZombieEnabled" and "JSImmortalZombieEnabled". Setting them to any value will
result in the use of the appropriate mode.

* heap/Heap.cpp:
(JSC::Heap::collect): Zombifies dead objects at the end of collection if zombie mode is enabled.
(ZombifyCellFunctor):
(JSC::ZombifyCellFunctor::ZombifyCellFunctor): Sets marked bits for dead objects if in immortal mode and writes 0xbbadbeef into them.
(JSC::ZombifyCellFunctor::operator()):
(JSC):
(ZombifyBlockFunctor):
(JSC::ZombifyBlockFunctor::operator()):
(JSC::Heap::zombifyDeadObjects): Eagerly sweeps so that we don't write garbage into an object before it
is finalized/destroyed.
* heap/Heap.h:
(Heap):
* heap/MarkedBlock.h:
(MarkedBlock):
(JSC::MarkedBlock::forEachDeadCell): Used to iterate over dead cells at the end of collection if zombie mode is enabled.
(JSC):
* runtime/Options.cpp:
(JSC::Options::initialize):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDeploy StringBuilder in more places in WebKit2
commit-queue@webkit.org [Fri, 7 Sep 2012 05:34:33 +0000 (05:34 +0000)]
Deploy StringBuilder in more places in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=95924

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-06
Reviewed by Benjamin Poulain.

Deploy StringBuilder to concatenate strings more efficiently.

* Shared/WebMemorySampler.cpp:
(WebKit):
(WebKit::WebMemorySampler::WebMemorySampler):
(WebKit::WebMemorySampler::stop):
(WebKit::WebMemorySampler::writeHeaders):
(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
* Shared/WebMemorySampler.h:
(WebMemorySampler):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::capitalizeRFC822HeaderFieldName):
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html
ossy@webkit.org [Fri, 7 Sep 2012 05:32:04 +0000 (05:32 +0000)]
REGRESSION(127810): It broke inspector/debugger/debugger-expand-scope.html
https://bugs.webkit.org/show_bug.cgi?id=96065

Unreviewed, reverting the expected file change.

* inspector/debugger/debugger-expand-scope-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd methods to CounterDirectives to clean up StyleBuilder and RenderCounter.
commit-queue@webkit.org [Fri, 7 Sep 2012 05:22:09 +0000 (05:22 +0000)]
Add methods to CounterDirectives to clean up StyleBuilder and RenderCounter.
https://bugs.webkit.org/show_bug.cgi?id=94587

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Julien Chaffraix.

Source/WebCore:

Adds several methods to CounterDirectives and an accessor method to RenderStyle for
getting the CounterDirectives by idenfitier and uses those methods to clean up
the code in StyleBuilder and RenderCounter. This also switches to using AtomicString
directly instead of AtomicStringImpl and calling get() everywhere.

The refactor fixes the unitialized read in WKBug 94642.

Test: fast/css/counters/counter-reset-inherit-bug-94642.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::counterToCSSValue): Use new accessors.
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyCounter::applyInheritValue): Use new inherit methods.
(WebCore::ApplyPropertyCounter::applyValue): Use new setters.
* rendering/RenderCounter.cpp:
(WebCore):
(WebCore::planCounter):
(WebCore::makeCounterNode):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):
* rendering/style/CounterDirectives.cpp:
(WebCore::operator==):
* rendering/style/CounterDirectives.h: Added new accessors and switched to using AtomicString directly.
(CounterDirectives):
(WebCore::CounterDirectives::CounterDirectives):
(WebCore::CounterDirectives::isReset):
(WebCore::CounterDirectives::resetValue):
(WebCore::CounterDirectives::setResetValue):
(WebCore::CounterDirectives::clearReset):
(WebCore::CounterDirectives::inheritReset):
(WebCore::CounterDirectives::isIncrement):
(WebCore::CounterDirectives::incrementValue):
(WebCore::CounterDirectives::addIncrementValue):
(WebCore::CounterDirectives::clearIncrement):
(WebCore::CounterDirectives::inheritIncrement):
(WebCore::CounterDirectives::isDefined): If either reset or increment is used.
(WebCore::CounterDirectives::combinedValue): Combined local value of the counter.
(WebCore):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getCounterDirectives): New method which always returns a CounterDirectives instance by identifier.
(WebCore):
* rendering/style/RenderStyle.h:

LayoutTests:

Tests for bug 94642 exposing an unitialized read when using counter-reset and
counter-increment: inherit.

* fast/css/counters/counter-reset-inherit-bug-94642-expected.html: Added.
* fast/css/counters/counter-reset-inherit-bug-94642.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] accessibility/canvas-description-and-role expected results needed
commit-queue@webkit.org [Fri, 7 Sep 2012 05:09:04 +0000 (05:09 +0000)]
[Gtk] accessibility/canvas-description-and-role expected results needed
https://bugs.webkit.org/show_bug.cgi?id=95644

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-06
Reviewed by Martin Robinson.

Source/WebCore:

The new accessibility CanvasRole should be mapped to ATK_ROLE_CANVAS
rather than ATK_ROLE_IMAGE.

No new test because the CanvasRole came with a new layout test lacking
expected results for Gtk. The generated expected results for that test
reflect the revised mapping to ATK_ROLE_CANVAS.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

LayoutTests:

Generated expected results for Gtk. These results reflect the revised
mapping of CanvasRole to ATK_ROLE_CANVAS rather than ATK_ROLE_IMAGE.

* platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoA build fix for Chromium Windows
hbono@chromium.org [Fri, 7 Sep 2012 05:03:29 +0000 (05:03 +0000)]
A build fix for Chromium Windows
https://bugs.webkit.org/show_bug.cgi?id=96062

Reviewed by James Robinson.

Source/Platform:

This change fixes a build break on Chromium Windows (debug) caused by r127796
<http://trac.webkit.org/changeset/127796>. It removes a redundant WEBKIT_EXPORT.

* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

Source/WebCore:

This change fixes a build break on Chromium Windows caused by r127801
<http://trac.webkit.org/changeset/127801>. It replaces characters() with
characters16().

No new tests because this change is a build fix.

* platform/graphics/chromium/UniscribeHelperTextRun.cpp:
(WebCore::UniscribeHelperTextRun::UniscribeHelperTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add API unit tests for ewk_view_theme_set.
ryuan.choi@samsung.com [Fri, 7 Sep 2012 05:00:12 +0000 (05:00 +0000)]
[EFL][WK2] Add API unit tests for ewk_view_theme_set.
https://bugs.webkit.org/show_bug.cgi?id=94670

Reviewed by Gyuyoung Kim.

Added unit tests for ewk_view_theme_set.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::pathForResource):
Added to get path of resource.
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
Ditto.
* UIProcess/API/efl/tests/resources/big_button_theme.edj:
Added test theme file which has text_confinement of button as
rel1 { ... offset : 150 8; } rel2 { ... offset : -150 -11; }.
* UIProcess/API/efl/tests/resources/empty_theme.edj:
Added test theme file which includes nothing.
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
Added unit test for ewk_view_theme_set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make RenderPass ids hold both generating layer id and an index
danakj@chromium.org [Fri, 7 Sep 2012 04:49:16 +0000 (04:49 +0000)]
[chromium] Make RenderPass ids hold both generating layer id and an index
https://bugs.webkit.org/show_bug.cgi?id=95500

Reviewed by Adrienne Walker.

Source/WebCore:

This change allows us to avoid complex renderPassId mappings between
compositors for ubercomp. The ubercomp layer needs to add a number
of RenderPasses to the frame, and these must not conflict with other
RenderPasses in the frame. By using its layer id along with an extra
value it determines, the layer can create a unique id without needing
access to any global state or id generator.

Covered by existing tests.

* platform/graphics/chromium/cc/CCDirectRenderer.cpp:
(WebCore::CCDirectRenderer::decideRenderPassAllocationsForFrame):
(WebCore::CCDirectRenderer::haveCachedResourcesForRenderPassId):
* platform/graphics/chromium/cc/CCDirectRenderer.h:
(CCDirectRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore::removeRenderPassesRecursive):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::create):
(WebCore::CCRenderPass::CCRenderPass):
* platform/graphics/chromium/cc/CCRenderPass.h:
(Id):
(WebCore::CCRenderPass::Id::Id):
(WebCore::CCRenderPass::Id::operator==):
(WebCore::CCRenderPass::Id::operator!=):
(WebCore::CCRenderPass::Id::operator<):
(CCRenderPass):
(WebCore::CCRenderPass::id):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
(WebCore::CCRenderPassDrawQuad::renderPassId):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::renderPassId):
(WebCore):
(WebCore::CCRenderSurface::appendRenderPasses):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderer.h:
(WebCore::CCRenderer::haveCachedResourcesForRenderPassId):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
* tests/CCRenderSurfaceTest.cpp:
* tests/CCRendererGLTest.cpp:
(FakeCCRendererClient::FakeCCRendererClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
msaboff@apple.com [Fri, 7 Sep 2012 04:48:23 +0000 (04:48 +0000)]
StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents
https://bugs.webkit.org/show_bug.cgi?id=96029

Reviewed by Benjamin Poulain.

Added 8 bit path when creating an AtomicString from a partial 8 bit buffer.

* wtf/text/StringBuilder.h:
(WTF::StringBuilder::toAtomicString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Do not delete texture backing structures on the main thread
commit-queue@webkit.org [Fri, 7 Sep 2012 04:39:50 +0000 (04:39 +0000)]
[chromium] Do not delete texture backing structures on the main thread
https://bugs.webkit.org/show_bug.cgi?id=96018

Patch by Christopher Cameron <ccameron@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Do not delete CCPrioritizedTexture::Backing structures on the main
thread.  Instead, unlink them from their owning CCPrioritizedTexture
in the main thread, and have the impl thread then delete all unlinked
textures.

This is towards having the main thread not access the m_backings set,
which will allow the impl thread to traverse that set when deleting
resources in response to GPU memory management events.

Tested by existing eviction tests (CCLayerTreeHostTest's
TestEvictTextures, LostContextAfterEvictTextures)

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::unlinkAllContentTextures):
(WebCore):
(WebCore::CCLayerTreeHost::deleteUnlinkedTextures):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::clearAllMemory):
(WebCore::CCPrioritizedTextureManager::unlinkAllBackings):
(WebCore):
(WebCore::CCPrioritizedTextureManager::deleteAllUnlinkedBackings):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(CCPrioritizedTextureManager):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::commitAndComposite):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix debug Windows build
hausmann@webkit.org [Fri, 7 Sep 2012 04:37:55 +0000 (04:37 +0000)]
[Qt] Fix debug Windows build
https://bugs.webkit.org/show_bug.cgi?id=96008

Reviewed by Tor Arne Vestbø.

Add a few more files to the AllInOne configuration to reduce the number of object files
and their total size, allowing a debug build with MSVC again.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix text encoding detecting
commit-queue@webkit.org [Fri, 7 Sep 2012 04:21:28 +0000 (04:21 +0000)]
[Qt] Fix text encoding detecting
https://bugs.webkit.org/show_bug.cgi?id=96014

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Since we rely on ICU now, we might as well use the actually implemented text encoding
detector instead of the dummy "none" one.

I could not locate any layout tests that actually cover this :(

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement a color picker
commit-queue@webkit.org [Fri, 7 Sep 2012 04:18:53 +0000 (04:18 +0000)]
[BlackBerry]  Implement a color picker
https://bugs.webkit.org/show_bug.cgi?id=96001

Patch by Crystal Zhang <haizhang@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Source/WebKit:

Add color picker files into building system.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Add files for color picker, replace old hook to AIR color picker.

* WebCoreSupport/ColorPickerClient.cpp: Added.
(WebCore):
(WebCore::ColorPickerClient::ColorPickerClient):
(WebCore::ColorPickerClient::~ColorPickerClient):
(WebCore::ColorPickerClient::generateHTML):
(WebCore::ColorPickerClient::closePopup):
(WebCore::ColorPickerClient::contentSize):
(WebCore::ColorPickerClient::htmlSource):
(WebCore::ColorPickerClient::setValueAndClosePopup):
(WebCore::ColorPickerClient::didClosePopup):
(WebCore::ColorPickerClient::writeDocument):
* WebCoreSupport/ColorPickerClient.h: Added.
(WebKit):
(WebCore):
(ColorPickerClient):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openColorPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove RenderView::setFixedPositionedObjectsNeedLayout to FrameView
ossy@webkit.org [Fri, 7 Sep 2012 04:14:57 +0000 (04:14 +0000)]
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Unreviewed Qt-WK2 buildfix after r127783.

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::syncFixedLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWe should have localized strings of date time fields for accessibility
yosin@chromium.org [Fri, 7 Sep 2012 03:35:36 +0000 (03:35 +0000)]
We should have localized strings of date time fields for accessibility
https://bugs.webkit.org/show_bug.cgi?id=96050

Reviewed by Kent Tamura.

Source/Platform:

This patch adds localized string enum fields for accessibility support
in multiple fields date time related input types for Chromium ports.

* chromium/public/WebLocalizedString.h: Adds AXAMPMFieldText, AXDayOfMonthField,
AXHourFieldText, AXMillisecondFieldText, AXMinuteFieldText, AXMonthField,
AXSecondFieldText, AXWeekOfYearFieldText, and AXYearFieldText.

Source/WebCore:

This patch adds declarations of function for getting localized string
of date time field for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

No new tests. This patch doesn't change behavior.

* platform/LocalizedStrings.h:
(WebCore): Added declarations of AXAMPMFieldText(), AXDayOfMonthFieldText(),
AXHourFieldText(), AXMillisecondFieldText(), AXMinuteFieldText(), AXMonthFieldText(),
AXSecondFieldText(), AXWeekOfYearFieldText(), and AXYearFieldText().

Source/WebKit/chromium:

This patch adds functions for getting localized strings of date time
fields for accessibility inside ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

These functions will be used by derived classes of DateTimeFieldElement.

Note: We'll rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to generic name
to support "date", "datetime", "month" and "week" multiple fields input
UI.

* src/LocalizedStrings.cpp:
(WebCore::AXAMPMFieldText): Added.
(WebCore::AXDayOfMonthFieldText): Added.
(WebCore::AXHourFieldText): Added.
(WebCore::AXMillisecondFieldText): Added.
(WebCore::AXMinuteFieldText): Added.
(WebCore::AXMonthFieldText): Added.
(WebCore::AXSecondFieldText): Added.
(WebCore::AXWeekOfYearFieldText): Added.
(WebCore::AXYearFieldText): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127808.
commit-queue@webkit.org [Fri, 7 Sep 2012 03:17:29 +0000 (03:17 +0000)]
Unreviewed, rolling out r127808.
http://trac.webkit.org/changeset/127808
https://bugs.webkit.org/show_bug.cgi?id=96057

geoff rolled back in his change, but not this part (Requested
by thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

* inspector/debugger/debugger-expand-scope-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be...
commit-queue@webkit.org [Fri, 7 Sep 2012 02:45:23 +0000 (02:45 +0000)]
fast/table/empty-row-crash.html and fast/table/inline-form-assert.html should be dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=95613

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-09-06
Reviewed by Julien Chaffraix.

Modified the test cases empty-row-crash.html and inline-form-assert.html to dumpAsText tests.
As the testcases check for crash/assert and not for the correctness of content layout or painting
they can be safely modified to dumpAsText tests.

* fast/table/empty-row-crash-expected.txt: Added.
 New expected file.
* fast/table/empty-row-crash.html:
 Added a short description about the testcase.

* fast/table/inline-form-assert-expected.txt: Added.
 New expected file.
* fast/table/inline-form-assert.html:

* platform/chromium-linux/fast/table/empty-row-crash-expected.png: Removed.
* platform/chromium-linux/fast/table/inline-form-assert-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/table/empty-row-crash-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/table/inline-form-assert-expected.png: Removed.
* platform/chromium-mac/fast/table/empty-row-crash-expected.png: Removed.
* platform/chromium-mac/fast/table/inline-form-assert-expected.png: Removed.
* platform/chromium-win/fast/table/empty-row-crash-expected.png: Removed.
* platform/chromium-win/fast/table/empty-row-crash-expected.txt: Removed.
* platform/chromium-win/fast/table/inline-form-assert-expected.png: Removed.
* platform/chromium-win/fast/table/inline-form-assert-expected.txt: Removed.
* platform/efl/fast/table/empty-row-crash-expected.png: Removed.
* platform/efl/fast/table/empty-row-crash-expected.txt: Removed.
* platform/efl/fast/table/inline-form-assert-expected.png: Removed.
* platform/efl/fast/table/inline-form-assert-expected.txt: Removed.
* platform/gtk/fast/table/empty-row-crash-expected.png: Removed.
* platform/gtk/fast/table/empty-row-crash-expected.txt: Removed.
* platform/gtk/fast/table/inline-form-assert-expected.png: Removed.
* platform/gtk/fast/table/inline-form-assert-expected.txt: Removed.
* platform/mac/fast/table/empty-row-crash-expected.png: Removed.
* platform/mac/fast/table/empty-row-crash-expected.txt: Removed.
* platform/mac/fast/table/inline-form-assert-expected.png: Removed.
* platform/mac/fast/table/inline-form-assert-expected.txt: Removed.
* platform/qt/fast/table/empty-row-crash-expected.png: Removed.
* platform/qt/fast/table/empty-row-crash-expected.txt: Removed.
* platform/qt/fast/table/inline-form-assert-expected.png: Removed.
* platform/qt/fast/table/inline-form-assert-expected.txt: Removed.
 Removed obsolete baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
tony@chromium.org [Fri, 7 Sep 2012 02:43:17 +0000 (02:43 +0000)]
Make computePositionedLogicalWidth and computePositionedLogicalWidthReplaced const
https://bugs.webkit.org/show_bug.cgi?id=95907

Reviewed by Ojan Vafai.

This is refactoring to make RenderBox::computeLogicalWidth const. Make some methods that
get called by computeLogicalWidth const. We path in a struct that we populate with values.

No new tests, this is just a refactoring.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion): Make a LogicalExtentComputedValues to
hold results.
(WebCore::RenderBox::computePositionedLogicalWidth): Make const.
(WebCore::RenderBox::computePositionedLogicalWidthUsing): Change output to use LogicalExtentComputedValues
instead of 4 separate params.
(WebCore::RenderBox::computePositionedLogicalWidthReplaced): Make const.
* rendering/RenderBox.h:
(RenderBox): Add const and change out params to LogicalExtentComputedValues.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Make a LogicalExtentComputedValues to
hold results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
morrita@google.com [Fri, 7 Sep 2012 02:25:36 +0000 (02:25 +0000)]
[Shadow DOM][Refactoring] Element subclasses should have a way to reject author shadows.
https://bugs.webkit.org/show_bug.cgi?id=95831

Reviewed by Dimitri Glazkov.

Originally, the availability of author shadows was decided by ShadowRoot class.
This change moves that responsibility to each Element subclasses to make future
author shadow support improvement local to each replaced elements, rather than
touching ShadowRoot.cpp for reach.

No new tests. Should have no behavioral change.

* dom/Element.h:
* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot):
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):
* svg/SVGElement.h:
(SVGElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: Rolled back in <http://trac.webkit.org/changeset/127698> with...
ggaren@apple.com [Fri, 7 Sep 2012 01:42:53 +0000 (01:42 +0000)]
Source/JavaScriptCore: Rolled back in <trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html, which
is to make sure that function declarations don't put their names in scope.

Reviewed by Gavin Barraclough.

    Named functions should not allocate scope objects for their names
    https://bugs.webkit.org/show_bug.cgi?id=95659

    Reviewed by Oliver Hunt.

LayoutTests: Rolled back in <http://trac.webkit.org/changeset/127698> with a fix for
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Added a more explicit test for the feature I broke in
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html.

Reviewed by Gavin Barraclough.

    Named functions should not allocate scope objects for their names
    https://bugs.webkit.org/show_bug.cgi?id=95659

    Reviewed by Oliver Hunt.

* fast/dom/HTMLScriptElement/script-reexecution.html:
* fast/js/function-name-is-in-scope-expected.txt: Added.
* fast/js/function-name-is-in-scope.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
msaboff@apple.com [Fri, 7 Sep 2012 01:29:12 +0000 (01:29 +0000)]
16 bit JSRopeString up converts an 8 bit fibers to 16 bits during resolution
https://bugs.webkit.org/show_bug.cgi?id=95810

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Added 8 bit path that copies the contents of an 8 bit fiber to the 16 bit buffer
when resolving a 16 bit rope.

* runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeSlowCase):

Source/WTF:

New copy routine that takes an 8 bit source and a 16 bit destination.  Used when copying
the contents of an 8 bit fiber to the 16 bit buffer when resolving a 16 bit rope.

* wtf/text/StringImpl.h:
(WTF::StringImpl::copyChars):
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, revert part of http://trac.webkit.org/changeset/127698
timothy_horton@apple.com [Fri, 7 Sep 2012 01:29:12 +0000 (01:29 +0000)]
Unreviewed, revert part of trac.webkit.org/changeset/127698
which accidentally didn't get reverted in
http://trac.webkit.org/changeset/127774.

* inspector/debugger/debugger-expand-scope-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unskip two encoding tests that pass now
commit-queue@webkit.org [Fri, 7 Sep 2012 01:16:46 +0000 (01:16 +0000)]
[Qt] Unskip two encoding tests that pass now
https://bugs.webkit.org/show_bug.cgi?id=96013

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

The result for frame-default-enc was incorrect and we succeed in
producing the existing cross-platform result. The other test passes
just fine.

* platform/qt/Skipped:
* platform/qt/fast/encoding/frame-default-enc-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Weave creationContext through toV8 and related functions
abarth@webkit.org [Fri, 7 Sep 2012 00:57:27 +0000 (00:57 +0000)]
[V8] Weave creationContext through toV8 and related functions
https://bugs.webkit.org/show_bug.cgi?id=96039

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Eric Seidel.

In order to give DOM wrappers the correct prototype chain, we need to
know what the creationContext ought to be for each wrapper. This patch
weaves that information through toV8 and related functions.

This patch doesn't yet use the information. That will take place in a
separate patch. For that reason, this patch should not have any
behavior change.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
(GenerateFunctionCallString):
(NativeToJSValue):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooCallback):
* bindings/v8/DOMTransaction.cpp:
(WebCore::DOMTransaction::callFunction):
* bindings/v8/IDBCustomBindings.cpp:
(WebCore::V8IDBCursorWithValue::valueAccessorGetter):
* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/V8Binding.h:
(WebCore::V8ValueTraits::arrayV8Value):
* bindings/v8/V8Collection.h:
(WebCore::getV8Object):
(WebCore::getNamedPropertyOfCollection):
(WebCore::collectionNamedPropertyGetter):
(WebCore::getIndexedPropertyOfCollection):
(WebCore::collectionIndexedPropertyGetter):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
(V8DOMWrapper):
* bindings/v8/V8ThrowException.cpp:
(WebCore):
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
(WebCore::V8Blob::constructorCallback):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CSSValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorGetter):
(WebCore::V8CanvasRenderingContext2D::fillStyleAccessorGetter):
* bindings/v8/custom/V8ConsoleCustom.cpp:
(WebCore::V8Console::memoryAccessorGetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):
(WebCore::toV8):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateCallback):
(WebCore::V8Document::getCSSCanvasContextCallback):
(WebCore::toV8):
(WebCore::V8Document::createTouchListCallback):
* bindings/v8/custom/V8DocumentLocationCustom.cpp:
(WebCore::V8Document::locationAccessorGetter):
* bindings/v8/custom/V8EntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EntrySyncCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):
(WebCore):
(WebCore::toV8):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
(WebCore::V8HTMLCollection::namedPropertyGetter):
(WebCore::V8HTMLCollection::namedItemCallback):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::getNamedProperty):
(WebCore::V8HTMLDocument::allAccessorGetter):
(WebCore::toV8):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8):
(WebCore::V8HTMLElement::itemValueAccessorGetter):
* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8HTMLLinkElementCustom.cpp:
(WebCore::V8HTMLLinkElement::sizesAccessorGetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):
* bindings/v8/custom/V8HTMLOutputElementCustom.cpp:
(WebCore::V8HTMLOutputElement::htmlForAccessorGetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertyGetter):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8MessageChannelConstructor.cpp:
(WebCore::V8MessageChannel::constructorCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):
* bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::toV8Slow):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::namedPropertyGetter):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
* bindings/v8/custom/V8PerformanceCustom.cpp:
(WebCore):
(WebCore::V8Performance::memoryAccessorGetter):
* bindings/v8/custom/V8PerformanceEntryCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGElementCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8SVGPathSegCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8StyleSheetListCustom.cpp:
(WebCore::V8StyleSheetList::namedPropertyGetter):
* bindings/v8/custom/V8TrackEventCustom.cpp:
(WebCore::V8TrackEvent::trackAccessorGetter):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):
* dom/make_names.pl:
(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix to r127799.
msaboff@apple.com [Fri, 7 Sep 2012 00:43:42 +0000 (00:43 +0000)]
Unreviewed fix to r127799.
https://bugs.webkit.org/show_bug.cgi?id=95807

Unreviewed fix.

Removed extraneous "static".  This code is hidden behind STRING_STATS define and
therefore is not enabled by default.

* wtf/text/StringImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] 2 mathml tests need rebaseline after r127769
commit-queue@webkit.org [Fri, 7 Sep 2012 00:36:29 +0000 (00:36 +0000)]
[EFL] 2 mathml tests need rebaseline after r127769
https://bugs.webkit.org/show_bug.cgi?id=96009

Unreviewed EFL gardening.

Update baselines for 2 mathml test cases needed after
r127769.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06

* platform/efl/mathml/presentation/roots-expected.png:
* platform/efl/mathml/presentation/roots-expected.txt:
* platform/efl/mathml/presentation/sup-expected.png:
* platform/efl/mathml/presentation/sup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium Linux EWS bots and CQ bots are flaky
tony@chromium.org [Fri, 7 Sep 2012 00:21:17 +0000 (00:21 +0000)]
Chromium Linux EWS bots and CQ bots are flaky
https://bugs.webkit.org/show_bug.cgi?id=96041

Reviewed by Adam Barth.

Skip platform/chromium-linux/compositing/gestures tests on the
Chromium Linux EWS and CQ bots. By marking them as flaky, they won't
be run (the bots use --skip-failing-tests which causes them to skip
these tests).  These will still run on the waterfall bots.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Deprecate String += operator
commit-queue@webkit.org [Thu, 6 Sep 2012 23:54:49 +0000 (23:54 +0000)]
[Qt] Deprecate String += operator
https://bugs.webkit.org/show_bug.cgi?id=95895

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Source/WebCore:

Replaced String +=() with append.

* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):

Source/WTF:

Remove Qt from WTF_DEPRECATED_STRING_OPERATORS guard.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd 8 bit string data path to TextRun
msaboff@apple.com [Thu, 6 Sep 2012 23:52:46 +0000 (23:52 +0000)]
Add 8 bit string data path to TextRun
https://bugs.webkit.org/show_bug.cgi?id=95812

Reviewed by Dan Bernstein.

Added 8 bit string path to TextRun.  Refactored TextRun::data() and ::characters into
8 and 16 bit versions.  Made corresponding changes to users of TextRun.
For efl, gtk, qt and win platform specific code using TextRun, only the methods have
been renamed and the creation of 8 bit TextRuns has been disabled via compilation
flags.  Someone knowledgeable in those platforms will need to make corresponding changes
to enable 8 bit processing of TextRuns.

No changes to functionality - behavior covered by existing tests.

* platform/graphics/Font.cpp:
(WebCore::normalizeSpacesInternal):
(WebCore::Font::normalizeSpaces):
(WebCore::Font:normalizeSpaces):
(WebCore::Font::codePath):
(WebCore::Font::expansionOpportunityCount):
* platform/graphics/Font.h:
(WebCore::Font::characterRangeCodePath):
(WebCore::Font::normalizeSpaces):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawBidiText):
* platform/graphics/TextRun.cpp:
(ExpectedTextRunSize):
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::subRun):
(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):
(WebCore::TextRun::characters8):
(WebCore::TextRun::characters16):
(WebCore::TextRun::is8Bit):
(WebCore::TextRun::setText):
(WebCore::TextRun::setCharactersLength):
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advance):
* platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp:
(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::collectComplexTextRuns):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
* platform/graphics/pango/FontPango.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/win/UniscribeController.cpp:
(WebCore::UniscribeController::advance):
(WebCore::UniscribeController::shapeAndPlaceItem):
* rendering/RenderText.cpp:
(WebCore::RenderText::computeCanUseSimpleFontCodePath):
* rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::SVGTextMetricsBuilder):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
jamesr@google.com [Thu, 6 Sep 2012 23:50:59 +0000 (23:50 +0000)]
[chromium] Don't link cc in to WebKit.dll when use_libcc_for_compositor=1
https://bugs.webkit.org/show_bug.cgi?id=96024

Reviewed by Adam Barth.

When use_libcc_for_compositor=1, the implementation of the compositor guts are provided through PlatformSupport.
We don't need to link anything in to WebKit.dll.

Source/WebCore:

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoENH: Add Logging to StringImpl to track String Types
msaboff@apple.com [Thu, 6 Sep 2012 23:41:29 +0000 (23:41 +0000)]
ENH: Add Logging to StringImpl to track String Types
https://bugs.webkit.org/show_bug.cgi?id=95807

Reviewed by Benjamin Poulain.

Added StringsStats class that keeps track of the number of strings, number of 8 and 16 bit
strings as well as the number of 8 bit strings up converted to 16 bits. The number of characrters
for each type is also accumulated. These statistics are output via DataLog every 5000
calls to StringImpl destructor. The 5000 can be adjusted via s_printStringStatsFrequency.
This StringStats code is disabled by default and enabled by defining STRING_STATS in
wtf/text/StringImpl.h.

* wtf/text/StringImpl.cpp:
(WTF::StringStats::removeString):
(WTF::StringStats::printStats):
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):
* wtf/text/StringImpl.h:
(WTF::StringStats::add8BitString):
(StringStats):
(WTF::StringStats::add16BitString):
(WTF::StringStats::addUpconvertedString):
(WTF::StringImpl::StringImpl):
(StringImpl):
(WTF::StringImpl::isSubString):
(WTF::StringImpl::stringStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew tests introduced in r127704 fail
abarth@webkit.org [Thu, 6 Sep 2012 23:40:56 +0000 (23:40 +0000)]
New tests introduced in r127704 fail
https://bugs.webkit.org/show_bug.cgi?id=95952

Reviewed by Dan Bernstein.

Use the testRunner rather than layoutTestController because
layoutTestControler doesn't exist anymore.

* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:
* fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJS test suite puts incorrect limitations on Function.toString()
barraclough@apple.com [Thu, 6 Sep 2012 23:23:50 +0000 (23:23 +0000)]
JS test suite puts incorrect limitations on Function.toString()
https://bugs.webkit.org/show_bug.cgi?id=3975

Reviewed by Geoff Garen.

The result of function toString is implementation defined;
these test cases were looking for specific whitespace formatting
that matches mozilla's, and for redundant braces to be inserted
around if/else blocks. Stop that.

* tests/mozilla/expected.html:
* tests/mozilla/js1_2/function/tostring-1.js:
(simplify):
    - reduce whitespace differences
* tests/mozilla/js1_2/function/tostring-2.js:
(simplify):
    - reduce whitespace differences
(TestOr):
(TestAnd):
    - added braces to match expected output

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Export public functions on WebTransformationMatrix so they can be used...
jamesr@google.com [Thu, 6 Sep 2012 23:21:22 +0000 (23:21 +0000)]
[chromium] Export public functions on WebTransformationMatrix so they can be used outside of WebKit.dll
https://bugs.webkit.org/show_bug.cgi?id=96025

Reviewed by Adrienne Walker.

* chromium/public/WebTransformationMatrix.h:
(WebTransformationMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParcel up logic related to sticky positioning into a Constraints class that will...
simon.fraser@apple.com [Thu, 6 Sep 2012 23:21:09 +0000 (23:21 +0000)]
Parcel up logic related to sticky positioning into a Constraints class that will later be used for threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=96026

Reviewed by James Robinson.

Lay some groundwork for threaded scrolling with fixed position and sticky
position objects, by packaging up logic related to how to reposition
fixed and sticky things on viewport changes into "constraints" classes.

ScrollingConstraints contains a 'ViewportConstraints' base class
that is subclassed for sticky position. These classes store
data about the constraints that govern the position of an object outside
of the render tree, and know how to compute a new position when the
viewport changes using only data in the class.

This patch changes RenderBoxModelObject to use the StickyPositionViewportConstraints
class for computing stick offsets at layout time. In the future, we'll have
the scrolling tree store copies of the constraint data for threaded scrolling.

* CMakeLists.txt: Add ScrollingConstraints.* to the build.
* GNUmakefile.list.am: Ditto
* Target.pri: Ditto
* WebCore.gypi: Ditto
* WebCore.vcproj/WebCore.vcproj: Ditto
* WebCore.xcodeproj/project.pbxproj: Ditto
* page/scrolling/ScrollingConstraints.cpp: Added.
(WebCore::StickyPositionViewportConstraints::computeStickyOffset):
(WebCore::StickyPositionViewportConstraints::layerPositionForViewportRect):
* page/scrolling/ScrollingConstraints.h: Added.
(WebCore::ViewportConstraints::ViewportConstraints):
(WebCore::ViewportConstraints::~ViewportConstraints):
(WebCore::ViewportConstraints::anchorEdges):
(WebCore::ViewportConstraints::hasAnchorEdge):
(WebCore::ViewportConstraints::addAnchorEdge):
(WebCore::ViewportConstraints::alignmentOffset):
(WebCore::ViewportConstraints::setAlignmentOffset):
(StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::stickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setStickyOffsetAtLastLayout):
(WebCore::StickyPositionViewportConstraints::layerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::setLayerPositionAtLastLayout):
(WebCore::StickyPositionViewportConstraints::leftOffset):
(WebCore::StickyPositionViewportConstraints::rightOffset):
(WebCore::StickyPositionViewportConstraints::topOffset):
(WebCore::StickyPositionViewportConstraints::bottomOffset):
(WebCore::StickyPositionViewportConstraints::setLeftOffset):
(WebCore::StickyPositionViewportConstraints::setRightOffset):
(WebCore::StickyPositionViewportConstraints::setTopOffset):
(WebCore::StickyPositionViewportConstraints::setBottomOffset):
(WebCore::StickyPositionViewportConstraints::setAbsoluteContainingBlockRect):
(WebCore::StickyPositionViewportConstraints::setAbsoluteStickyBoxRect):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Fill out
data in the supplied StickyPositionViewportConstraints instance.
(WebCore::RenderBoxModelObject::stickyPositionOffset): Create a
StickyPositionViewportConstraints object on the stack and use it to
compute the sticky offset.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
jamesr@google.com [Thu, 6 Sep 2012 23:17:48 +0000 (23:17 +0000)]
[chromium] Use WebCompositorSupport functions instead of WebCompositor statics
https://bugs.webkit.org/show_bug.cgi?id=96007

Reviewed by Adrienne Walker.

Source/Platform:

Updates comment to reference WebCompositorSupport instead of WebCompositor.

* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

Calls WebCompositorSupport functions instead of WebCompositor statics.

* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):

Source/WebKit/chromium:

Updates many tests to initialize / shutdown compositing with WebCompositorSupport. Adds a
WebCompositorInitializer RAII class to simplify this somewhat tedious process.

* WebKit.gypi:
* public/WebCompositorInputHandlerClient.h:
(WebCompositorInputHandlerClient):
* src/WebCompositorInputHandlerImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::composite):
(WebKit::WebViewImpl::scheduleAnimation):
(WebKit::WebViewImpl::scheduleComposite):
* tests/CCPrioritizedTextureTest.cpp:
(WTF::CCPrioritizedTextureTest::CCPrioritizedTextureTest):
(WTF::CCPrioritizedTextureTest::~CCPrioritizedTextureTest):
(CCPrioritizedTextureTest):
* tests/CCRendererGLTest.cpp:
(CCRendererGLTest::CCRendererGLTest):
(CCRendererGLTest::SetUp):
(CCRendererGLTest):
* tests/CCTextureUpdateControllerTest.cpp:
* tests/CCThreadedTest.cpp:
(WebKitTests::CCThreadedTest::runTest):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
(WebKit::GraphicsLayerChromiumTest::~GraphicsLayerChromiumTest):
* tests/LayerChromiumTest.cpp:
* tests/LinkHighlightTest.cpp:
(WebCore::TEST):
* tests/TextureLayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
* tests/WebCompositorInitializer.h: Added.
(WebKit):
(WebKitTests):
(WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::WebCompositorInitializer):
(WebKitTests::WebCompositorInitializer::~WebCompositorInitializer):
* tests/WebCompositorInputHandlerImplTest.cpp:
(WebKit::TEST):
(WebKit::WebCompositorInputHandlerImplTest::WebCompositorInputHandlerImplTest):
(WebCompositorInputHandlerImplTest):
* tests/WebLayerTest.cpp:
* tests/WebLayerTreeViewTest.cpp:

Tools:

Fixes initialization / settings code to use WebCompositorSupport.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::setPerTilePaintingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
commit-queue@webkit.org [Thu, 6 Sep 2012 23:17:05 +0000 (23:17 +0000)]
[EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
https://bugs.webkit.org/show_bug.cgi?id=95995

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Provide proper implementation for PlatformWebView::windowFrame()
in EFL's WebKitTestRunner.

* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::windowFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
jamesr@google.com [Thu, 6 Sep 2012 23:16:14 +0000 (23:16 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: make IDBKeyPath's string and array constructors explicit
commit-queue@webkit.org [Thu, 6 Sep 2012 23:14:08 +0000 (23:14 +0000)]
IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Source/WebCore:

Making these explicit to avoid accidental implicit conversions.

No new tests, existing tests cover correctness.

* Modules/indexeddb/IDBKeyPath.h:
(IDBKeyPath):

Source/WebKit/chromium:

Fix test to use explicit constructor for IDBKeyPath.

* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
enne@google.com [Thu, 6 Sep 2012 22:48:43 +0000 (22:48 +0000)]
[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96002

Reviewed by James Robinson.

This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.

* tests/ContentLayerChromiumTest.cpp:
(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
commit-queue@webkit.org [Thu, 6 Sep 2012 22:23:29 +0000 (22:23 +0000)]
[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=95094

Patch by Jeff Timanus <twiz@chromium.org> on 2012-09-06
Reviewed by Adrienne Walker.

Source/Platform:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.

* chromium/public/WebContentLayer.h:
(WebContentLayer):
    Export setBoundsContainPageScale() family of routines.

Source/WebCore:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.

Testing covered by existing compositor layout and unit tests.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setAppliesPageScale):
(WebCore::GraphicsLayer::appliesPageScale):
    These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in
    LayerChromium.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore):
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):
    Now forwards the appliesPageScaleStatus to the owned layer.
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
(WebCore):
(WebCore::LayerChromium::setBoundsContainPageScale):
    setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium.
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::boundsContainPageScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore):
(WebCore::setScale):
(WebCore::updateLayerScale):
(WebCore::CCLayerTreeHost::updateLayers):
    The contents scale of a layer is now applied in this routine.

Source/WebKit/chromium:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.
This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
    Inform the layer associated with the NCCH that it is to disregard the page scale factor.
    Also remove now unused m_deviceScaleFactor and associated routines.
(WebKit::NonCompositedContentHost::setViewport):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::setBoundsContainPageScale):
(WebKit):
(WebKit::WebContentLayerImpl::boundsContainPageScale):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
* tests/CCLayerTreeHostTest.cpp:
(NoScaleContentLayerChromium):
(WebKitTests::NoScaleContentLayerChromium::create):
(WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
(WebKitTests):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
    Rebaselined to correspond to the new behaviour.  Because the layers are now assigned a contentsScale, the
    scale on the draw transforms remain identity.
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit): Remove now obsolete unit-test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove failures for acceletared-drawing tests.
alokp@chromium.org [Thu, 6 Sep 2012 22:07:34 +0000 (22:07 +0000)]
[chromium] Remove failures for acceletared-drawing tests.

Unreviewed.

Update chromium TestExpectations to remove failures for accelerated-painting.
They were fixed in r127294.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Split platform geometry types into separate static target
jamesr@google.com [Thu, 6 Sep 2012 21:44:59 +0000 (21:44 +0000)]
[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fuzzy load the Edje theme for HTML forms
kenneth@webkit.org [Thu, 6 Sep 2012 21:41:34 +0000 (21:41 +0000)]
[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Antonio Gomes.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

* platform/efl/RenderThemeEfl.cpp:
(WebCore):

    Add some convenience macros.

       (WebCore::applyColorCallback):

    Use just one callback from the edje theme, which just calls
    setColorFromThemeClass.

(WebCore::fillColorsFromEdjeClass):

    Add convenience method for receiving colors from Edje and
    storing them in Color's.

(WebCore::RenderThemeEfl::setColorFromThemeClass):

    Set the class Color variabled with the values from the theme
    color class.

(WebCore::RenderThemeEfl::setThemePath):

    Don't apply the theme immediately.

(WebCore::RenderThemeEfl::loadTheme):

    Load the new theme and free the current one. If it fails,
    it will continue using the old one, if exists.

(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformFocusRingColor):

    Ensure the theme is loaded.

(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

    Ensure the theme is loaded.

* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(WebCore::RenderThemeEfl::loadThemeIfNeeded):

    Remove unneeded methods and add a method for loading a theme
    in the case it is not loaded yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Classify several test cases in TestExpectations
commit-queue@webkit.org [Thu, 6 Sep 2012 21:24:51 +0000 (21:24 +0000)]
[EFL][WK2] Classify several test cases in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=95947

Unreviewed EFL gardening.

Update TestExpectations to classify a few test case failures
as being caused by lack on undo/redo stack implementation
in EFL WK2.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
enne@google.com [Thu, 6 Sep 2012 21:23:48 +0000 (21:23 +0000)]
[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=95994

Reviewed by James Robinson.

This compositor test shouldn't depend on code outside the compositor.

* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove RenderView::setFixedPositionedObjectsNeedLayout to FrameView
simon.fraser@apple.com [Thu, 6 Sep 2012 21:04:34 +0000 (21:04 +0000)]
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Reviewed by James Robinson.

FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.

Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.

* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
* page/FrameView.h:
(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderView.cpp:
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd data-blackberry-webworks-context attribute and set the custom context when
commit-queue@webkit.org [Thu, 6 Sep 2012 21:00:43 +0000 (21:00 +0000)]
Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
https://bugs.webkit.org/show_bug.cgi?id=95993

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-06
Reviewed by Antonio Gomes.

PR #193726
Reviewed Internally by Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
    - Check for custom WebWorks context and add it if there.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
    - Add a method that checks a given element for the data-webworks-context
      attribute and returns its value if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Put chromium implementations of WTF symbols in separate static library
jamesr@google.com [Thu, 6 Sep 2012 20:55:13 +0000 (20:55 +0000)]
[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Protocol Extension: Add "regionLayoutUpdate" event
commit-queue@webkit.org [Thu, 6 Sep 2012 20:19:40 +0000 (20:19 +0000)]
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-06
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT reached when TextTrack.mode is set to DISABLED.
annacc@chromium.org [Thu, 6 Sep 2012 20:06:00 +0000 (20:06 +0000)]
ASSERT reached when TextTrack.mode is set to DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=94651

Reviewed by Eric Carlson.

This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.

Source/WebCore:

Test: media/track/track-mode-disabled-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.

LayoutTests:

* media/track/track-mode-disabled-crash-expected.txt: Added.
* media/track/track-mode-disabled-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerformance regressions on 32-bit platforms with revisions 125637 and 126387
yuqiang.xian@intel.com [Thu, 6 Sep 2012 19:54:14 +0000 (19:54 +0000)]
Performance regressions on 32-bit platforms with revisions 125637 and 126387
https://bugs.webkit.org/show_bug.cgi?id=95953

Reviewed by Filip Pizlo.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val): Fix the typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
ggaren@apple.com [Thu, 6 Sep 2012 19:53:01 +0000 (19:53 +0000)]
Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
because I rolled out the patch that broke it.

* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127777 268f45cc-cd09-0410-ab3c-d52691b4dbfc