WebKit-https.git
9 years ago[chromium] Fix crash in DragImageTest caused by r122996
tony@chromium.org [Wed, 18 Jul 2012 19:51:12 +0000 (19:51 +0000)]
[chromium] Fix crash in DragImageTest caused by r122996
https://bugs.webkit.org/show_bug.cgi?id=91653

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Tony Chang.

Covered by existing DragImageTest.

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::deleteDragImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Set a theme for EFL WebKit2 unit test fixture
commit-queue@webkit.org [Wed, 18 Jul 2012 19:31:24 +0000 (19:31 +0000)]
[EFL] Set a theme for EFL WebKit2 unit test fixture
https://bugs.webkit.org/show_bug.cgi?id=91618

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

The test fixture should load the theme generated by the build
instead of trying to load the system theme.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTheme):
(EWK2UnitTest):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
(EWK2UnitTestEnvironment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement putIndexKeys in WebIDBObjectStoreImpl
commit-queue@webkit.org [Wed, 18 Jul 2012 19:26:56 +0000 (19:26 +0000)]
Implement putIndexKeys in WebIDBObjectStoreImpl
https://bugs.webkit.org/show_bug.cgi?id=91546

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-18
Reviewed by Darin Fisher.

Implement putIndexKeys in the chromium API, so it is callable
from chromium.

* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::putWithIndexKeys):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed compile fix for Android.
tony@chromium.org [Wed, 18 Jul 2012 19:23:19 +0000 (19:23 +0000)]
[chromium] Unreviewed compile fix for Android.

More sqrt fixes.

* tests/CCLayerTreeHostCommonTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed compile fix for Android.
tony@chromium.org [Wed, 18 Jul 2012 18:55:32 +0000 (18:55 +0000)]
[chromium] Unreviewed compile fix for Android.

Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp: In member function 'virtual void<unnamed>::CCDamageTrackerTest_verifyDamageForTransformedLayer_Test::TestBody()':
Source/WebKit/chromium/tests/CCDamageTrackerTest.cpp:332: error: call of overloaded 'sqrt(int)' is ambiguous

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Drag image for image elements should be scaled with device scale factor.
commit-queue@webkit.org [Wed, 18 Jul 2012 18:43:13 +0000 (18:43 +0000)]
[chromium] Drag image for image elements should be scaled with device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=89688

Patch by Varun Jain <varunjain@chromium.org> on 2012-07-18
Reviewed by Adam Barth.

.:

* ManualTests/chromium/drag-image-accounts-for-device-scale.html:

Source/WebCore:

Modified ManualTest: ManualTests/chromium/drag-image-accounts-for-device-scale.html

* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
* platform/chromium/DragImageRef.h:
(DragImageChromium):
(WebCore):
* platform/graphics/skia/BitmapImageSingleFrameSkia.h:
(BitmapImageSingleFrameSkia):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImageSingleFrameSkia::BitmapImageSingleFrameSkia):
(WebCore::BitmapImageSingleFrameSkia::create):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
* platform/graphics/skia/NativeImageSkia.h:
(NativeImageSkia):
(WebCore::NativeImageSkia::resolutionScale):

Source/WebKit/chromium:

* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
* tests/DragImageTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platfo...
tommyw@google.com [Wed, 18 Jul 2012 18:34:16 +0000 (18:34 +0000)]
[chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
https://bugs.webkit.org/show_bug.cgi?id=86215

Reviewed by Adam Barth.

Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
instead create mock objects. No actual mock objects created yet.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport::create):
(MockWebKitPlatformSupport::MockWebKitPlatformSupport):
(MockWebKitPlatformSupport::cryptographicallyRandomValues):
(MockWebKitPlatformSupport::createMediaStreamCenter):
* DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
(MockWebKitPlatformSupport):
* DumpRenderTree/chromium/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.
tony@chromium.org [Wed, 18 Jul 2012 18:32:24 +0000 (18:32 +0000)]
[chromium] Unreviewed gardening. Rebaseline 2 tests due to minor changes from r122980.

* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix style for numeric literals in chromium unit test code
shawnsingh@chromium.org [Wed, 18 Jul 2012 18:25:54 +0000 (18:25 +0000)]
[chromium] Fix style for numeric literals in chromium unit test code
https://bugs.webkit.org/show_bug.cgi?id=91635

Reviewed by Adrienne Walker.

Where possible, removed ".0" and "f" suffixes on numeric literals,
to be more consistent with WebKit style rules.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerQuadTest.cpp:
(WebCore::TEST):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCQuadCullerTest.cpp:
* tests/LayerChromiumTest.cpp:
* tests/WebTransformationMatrixTest.cpp:
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Move about: URL handling out of WebCore
commit-queue@webkit.org [Wed, 18 Jul 2012 18:25:07 +0000 (18:25 +0000)]
[BlackBerry] Move about: URL handling out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91541

Patch by Yong Li <yoli@rim.com> on 2012-07-18
Reviewed by Rob Buis.

Source/WebCore:

Remove about URL handling from our NetworkJob.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::cancelJob):
(WebCore::NetworkJob::sendResponseIfNeeded):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):

Source/WebKit:

AboutData.cpp is moved from WebCoreSupport to WebKitSupport.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Move about URL handling code to WebKit/blackberry. Now when WebPage is asked to load an about URL,
it directly calls loadString() with the generated source.

Also move AboutData.h/cpp from WebCoreSupport to WebKitSupport and change their namespace from WebCore
to BlackBerry::WebKit.

The change is very mechanical except "procss total memory usage" in about:memory now only accounts used
bytes and ignore free spaces in malloc.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::loadAbout):
(WebKit):
(BlackBerry::WebKit::WebPage::load):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/AboutData.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.cpp.
(WebKit):
(BlackBerry::WebKit::writeFeatures):
(BlackBerry::WebKit::numberToHTMLTr):
(BlackBerry::WebKit::bool):
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::cacheTypeStatisticToHTMLTr):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::memoryPage):
* WebKitSupport/AboutData.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/AboutData.h.
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r122984.
tony@chromium.org [Wed, 18 Jul 2012 18:21:33 +0000 (18:21 +0000)]
Unreviewed, rolling out r122984.
http://trac.webkit.org/changeset/122984
https://bugs.webkit.org/show_bug.cgi?id=91171

Broken the shared build, need to export a SkData in skia

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Alignment crash in MIMESniffer
rwlbuis@webkit.org [Wed, 18 Jul 2012 18:09:56 +0000 (18:09 +0000)]
Source/WebCore: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Prevent ASSERT on unaligned data. Special-case handling of unaligned data
to maskedCompareSlowCase.

No test, too hard to reproduce.

* platform/network/MIMESniffing.cpp:
(std::maskedCompareSlowCase):
(std):
(std::maskedCompare):

Source/WTF: Alignment crash in MIMESniffer
https://bugs.webkit.org/show_bug.cgi?id=89787

Reviewed by Yong Li.

PR 169064

Change isPointerTypeAlignmentOkay so calling it does not require ifdefs.

* wtf/StdLibExtras.h:
(isPointerTypeAlignmentOkay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert svg/css/scientific-numbers.html to a text only test
tony@chromium.org [Wed, 18 Jul 2012 17:58:59 +0000 (17:58 +0000)]
Convert svg/css/scientific-numbers.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=91641

Reviewed by Dirk Schulze.

This is a JS test so we don't need the pixel dump.

* svg/css/script-tests/scientific-numbers.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] platform/qt/http tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 17:57:21 +0000 (17:57 +0000)]
[Qt] platform/qt/http tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91119

Patch by Alex Bravo <alex.bravo@nokia.com> on 2012-07-18
Reviewed by Noam Rosenthal.

Rebased platform/qt/http tests and unskipped them from qt-5.0

* platform/qt/http/tests/loading/simple-subframe-expected.png: Added.
* platform/qt/http/tests/loading/simple-subframe-expected.txt:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/qt/http/tests/misc/acid2-expected.png:
* platform/qt/http/tests/misc/acid2-expected.txt:
* platform/qt/http/tests/misc/acid2-pixel-expected.png:
* platform/qt/http/tests/misc/acid2-pixel-expected.txt:
* platform/qt/http/tests/misc/error404-expected.png:
* platform/qt/http/tests/misc/error404-expected.txt:
* platform/qt/http/tests/misc/favicon-as-image-expected.png:
* platform/qt/http/tests/misc/favicon-as-image-expected.txt:
* platform/qt/http/tests/misc/frame-access-during-load-expected.png:
* platform/qt/http/tests/misc/frame-access-during-load-expected.txt:
* platform/qt/http/tests/misc/generated-content-inside-table-expected.png:
* platform/qt/http/tests/misc/generated-content-inside-table-expected.txt:
* platform/qt/http/tests/misc/iframe404-expected.png:
* platform/qt/http/tests/misc/iframe404-expected.txt:
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.png:
* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
* platform/qt/http/tests/misc/slow-loading-mask-expected.png:
* platform/qt/http/tests/misc/slow-loading-mask-expected.txt:
* platform/qt/http/tests/navigation/error404-basic-expected.png: Added.
* platform/qt/http/tests/navigation/error404-basic-expected.txt:
* platform/qt/http/tests/navigation/error404-goback-expected.png: Added.
* platform/qt/http/tests/navigation/error404-goback-expected.txt:
* platform/qt/http/tests/navigation/error404-subframeload-expected.png: Added.
* platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/http/tests/navigation/postredirect-basic-expected.png: Added.
* platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
* platform/qt/http/tests/navigation/postredirect-goback1-expected.png: Added.
* platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
* platform/qt/http/tests/uri/css-href-expected.png:
* platform/qt/http/tests/uri/css-href-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active
pierre.rossi@gmail.com [Wed, 18 Jul 2012 17:43:36 +0000 (17:43 +0000)]
[Qt] QQuickWebView shouldn't recieve mouse events while dialogs are active
https://bugs.webkit.org/show_bug.cgi?id=91634

Reviewed by Alexis Menard.

One side-effect of reimplementing childMouseEventFilter() in r122438 is that it can end up
bypassing the mouseArea mechanism used in QML dialogs and still forward some mouse events
over to the web process. We can rely on the same m_dialogActive mechanism already used for
touch events in there as well.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::childMouseEventFilter): ignore events and return early if a dialog is active.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Build fix for ENABLE_TOUCH_EVENTS=0
pierre.rossi@gmail.com [Wed, 18 Jul 2012 17:37:29 +0000 (17:37 +0000)]
[Qt] Build fix for ENABLE_TOUCH_EVENTS=0

Rubber-stamped by No'am Rosenthal.

Add the appropriate ENABLE(TOUCH_EVENTS) where they're needed.

* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p.h: include Platform.h so we can use the ENABLE macro.
* UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp: Also add the missing QFile include.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::deactivateTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/table tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 17:22:40 +0000 (17:22 +0000)]
[Qt] fast/table tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91621

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-18
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/table tests directory needs to be updated.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/table/003-expected.png:
* platform/qt-5.0/fast/table/003-expected.txt:
* platform/qt-5.0/fast/table/border-collapsing/004-expected.txt:
* platform/qt/fast/table/001-expected.png:
* platform/qt/fast/table/001-expected.txt:
* platform/qt/fast/table/002-expected.png:
* platform/qt/fast/table/002-expected.txt:
* platform/qt/fast/table/004-expected.png:
* platform/qt/fast/table/004-expected.txt:
* platform/qt/fast/table/005-expected.png:
* platform/qt/fast/table/005-expected.txt:
* platform/qt/fast/table/006-expected.png:
* platform/qt/fast/table/006-expected.txt:
* platform/qt/fast/table/007-expected.png:
* platform/qt/fast/table/007-expected.txt:
* platform/qt/fast/table/009-expected.png:
* platform/qt/fast/table/009-expected.txt:
* platform/qt/fast/table/010-expected.png:
* platform/qt/fast/table/010-expected.txt:
* platform/qt/fast/table/011-expected.png:
* platform/qt/fast/table/011-expected.txt:
* platform/qt/fast/table/012-expected.png:
* platform/qt/fast/table/012-expected.txt:
* platform/qt/fast/table/013-expected.png:
* platform/qt/fast/table/013-expected.txt:
* platform/qt/fast/table/014-expected.png:
* platform/qt/fast/table/014-expected.txt:
* platform/qt/fast/table/015-expected.png:
* platform/qt/fast/table/015-expected.txt:
* platform/qt/fast/table/016-expected.png:
* platform/qt/fast/table/016-expected.txt:
* platform/qt/fast/table/017-expected.png:
* platform/qt/fast/table/017-expected.txt:
* platform/qt/fast/table/018-expected.png:
* platform/qt/fast/table/018-expected.txt:
* platform/qt/fast/table/020-expected.png:
* platform/qt/fast/table/020-expected.txt:
* platform/qt/fast/table/021-expected.png:
* platform/qt/fast/table/021-expected.txt:
* platform/qt/fast/table/022-expected.png:
* platform/qt/fast/table/022-expected.txt:
* platform/qt/fast/table/023-expected.png:
* platform/qt/fast/table/023-expected.txt:
* platform/qt/fast/table/025-expected.png:
* platform/qt/fast/table/025-expected.txt:
* platform/qt/fast/table/026-expected.png:
* platform/qt/fast/table/026-expected.txt:
* platform/qt/fast/table/027-expected.png:
* platform/qt/fast/table/027-expected.txt:
* platform/qt/fast/table/027-vertical-expected.png:
* platform/qt/fast/table/027-vertical-expected.txt:
* platform/qt/fast/table/028-expected.png:
* platform/qt/fast/table/028-expected.txt:
* platform/qt/fast/table/028-vertical-expected.png:
* platform/qt/fast/table/028-vertical-expected.txt:
* platform/qt/fast/table/029-expected.png:
* platform/qt/fast/table/029-expected.txt:
* platform/qt/fast/table/030-expected.png:
* platform/qt/fast/table/030-expected.txt:
* platform/qt/fast/table/033-expected.png:
* platform/qt/fast/table/033-expected.txt:
* platform/qt/fast/table/034-expected.png:
* platform/qt/fast/table/034-expected.txt:
* platform/qt/fast/table/035-expected.png:
* platform/qt/fast/table/035-expected.txt:
* platform/qt/fast/table/035-vertical-expected.png:
* platform/qt/fast/table/035-vertical-expected.txt:
* platform/qt/fast/table/036-expected.png:
* platform/qt/fast/table/036-expected.txt:
* platform/qt/fast/table/037-expected.png:
* platform/qt/fast/table/037-expected.txt:
* platform/qt/fast/table/038-expected.png:
* platform/qt/fast/table/038-expected.txt:
* platform/qt/fast/table/038-vertical-expected.png:
* platform/qt/fast/table/038-vertical-expected.txt:
* platform/qt/fast/table/039-expected.png:
* platform/qt/fast/table/039-expected.txt:
* platform/qt/fast/table/040-expected.png:
* platform/qt/fast/table/040-expected.txt:
* platform/qt/fast/table/040-vertical-expected.png:
* platform/qt/fast/table/040-vertical-expected.txt:
* platform/qt/fast/table/041-expected.png:
* platform/qt/fast/table/041-expected.txt:
* platform/qt/fast/table/100-percent-cell-width-expected.png:
* platform/qt/fast/table/100-percent-cell-width-expected.txt:
* platform/qt/fast/table/absolute-table-at-bottom-expected.png:
* platform/qt/fast/table/absolute-table-at-bottom-expected.txt:
* platform/qt/fast/table/add-before-anonymous-child-expected.png:
* platform/qt/fast/table/add-before-anonymous-child-expected.txt:
* platform/qt/fast/table/align-right-within-left-aligned-div-expected.txt:
* platform/qt/fast/table/append-cells-expected.png:
* platform/qt/fast/table/append-cells-expected.txt:
* platform/qt/fast/table/append-cells2-expected.png:
* platform/qt/fast/table/append-cells2-expected.txt:
* platform/qt/fast/table/auto-with-percent-height-expected.png:
* platform/qt/fast/table/auto-with-percent-height-expected.txt:
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.png:
* platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/001-expected.png:
* platform/qt/fast/table/border-collapsing/001-expected.txt:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/001-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/002-expected.png:
* platform/qt/fast/table/border-collapsing/002-expected.txt:
* platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/002-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/003-expected.png:
* platform/qt/fast/table/border-collapsing/003-expected.txt:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/003-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png:
* platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
* platform/qt/fast/table/cell-absolute-child-expected.png:
* platform/qt/fast/table/cell-absolute-child-expected.txt:
* platform/qt/fast/table/cell-coalescing-expected.png:
* platform/qt/fast/table/cell-coalescing-expected.txt:
* platform/qt/fast/table/cell-pref-width-invalidation-expected.png:
* platform/qt/fast/table/cell-pref-width-invalidation-expected.txt:
* platform/qt/fast/table/cell-width-auto-expected.png:
* platform/qt/fast/table/cell-width-auto-expected.txt:
* platform/qt/fast/table/cellindex-expected.png:
* platform/qt/fast/table/cellindex-expected.txt:
* platform/qt/fast/table/click-near-anonymous-table-expected.png:
* platform/qt/fast/table/click-near-anonymous-table-expected.txt:
* platform/qt/fast/table/colgroup-preceded-by-caption-expected.png:
* platform/qt/fast/table/colgroup-preceded-by-caption-expected.txt:
* platform/qt/fast/table/colgroup-spanning-groups-rules-expected.png:
* platform/qt/fast/table/colgroup-spanning-groups-rules-expected.txt:
* platform/qt/fast/table/colspanMinWidth-expected.png:
* platform/qt/fast/table/colspanMinWidth-expected.txt:
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.png:
* platform/qt/fast/table/dynamic-caption-add-before-child-expected.txt:
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.png:
* platform/qt/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
* platform/qt/fast/table/dynamic-cellpadding-expected.png:
* platform/qt/fast/table/dynamic-cellpadding-expected.txt:
* platform/qt/fast/table/dynamic-descendant-percentage-height-expected.png:
* platform/qt/fast/table/dynamic-descendant-percentage-height-expected.txt:
* platform/qt/fast/table/early-table-layout-expected.png:
* platform/qt/fast/table/early-table-layout-expected.txt:
* platform/qt/fast/table/edge-offsets-expected.png:
* platform/qt/fast/table/edge-offsets-expected.txt:
* platform/qt/fast/table/empty-cells-expected.png:
* platform/qt/fast/table/empty-cells-expected.txt:
* platform/qt/fast/table/empty-row-crash-expected.png:
* platform/qt/fast/table/empty-row-crash-expected.txt:
* platform/qt/fast/table/empty-table-percent-height-expected.png:
* platform/qt/fast/table/empty-table-percent-height-expected.txt:
* platform/qt/fast/table/fixed-nested-expected.png:
* platform/qt/fast/table/fixed-nested-expected.txt:
* platform/qt/fast/table/fixed-table-non-cell-in-row-expected.png:
* platform/qt/fast/table/fixed-table-non-cell-in-row-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
* platform/qt/fast/table/floating-th-expected.png:
* platform/qt/fast/table/floating-th-expected.txt:
* platform/qt/fast/table/floatingTablePaintBackground-expected.png:
* platform/qt/fast/table/floatingTablePaintBackground-expected.txt:
* platform/qt/fast/table/form-with-table-style-expected.png:
* platform/qt/fast/table/form-with-table-style-expected.txt:
* platform/qt/fast/table/frame-and-rules-expected.png:
* platform/qt/fast/table/frame-and-rules-expected.txt:
* platform/qt/fast/table/generated-caption-expected.png:
* platform/qt/fast/table/generated-caption-expected.txt:
* platform/qt/fast/table/giantRowspan2-expected.png:
* platform/qt/fast/table/giantRowspan2-expected.txt:
* platform/qt/fast/table/inline-form-assert-expected.png:
* platform/qt/fast/table/inline-form-assert-expected.txt:
* platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
* platform/qt/fast/table/insert-before-anonymous-ancestors-expected.txt:
* platform/qt/fast/table/insert-cell-before-form-expected.png:
* platform/qt/fast/table/insert-cell-before-form-expected.txt:
* platform/qt/fast/table/insert-row-before-form-expected.png:
* platform/qt/fast/table/insert-row-before-form-expected.txt:
* platform/qt/fast/table/invisible-cell-background-expected.png:
* platform/qt/fast/table/invisible-cell-background-expected.txt:
* platform/qt/fast/table/large-width-expected.png:
* platform/qt/fast/table/large-width-expected.txt:
* platform/qt/fast/table/multiple-captions-display-expected.png:
* platform/qt/fast/table/multiple-captions-display-expected.txt:
* platform/qt/fast/table/multiple-percent-height-rows-expected.png:
* platform/qt/fast/table/multiple-percent-height-rows-expected.txt:
* platform/qt/fast/table/nested-percent-height-table-expected.png:
* platform/qt/fast/table/nested-percent-height-table-expected.txt:
* platform/qt/fast/table/nobr-expected.png:
* platform/qt/fast/table/nobr-expected.txt:
* platform/qt/fast/table/overflowHidden-expected.png:
* platform/qt/fast/table/overflowHidden-expected.txt:
* platform/qt/fast/table/percent-heights-expected.png:
* platform/qt/fast/table/percent-heights-expected.txt:
* platform/qt/fast/table/prepend-in-anonymous-table-expected.png:
* platform/qt/fast/table/prepend-in-anonymous-table-expected.txt:
* platform/qt/fast/table/quote-text-around-iframe-expected.png:
* platform/qt/fast/table/quote-text-around-iframe-expected.txt:
* platform/qt/fast/table/relative-position-containment-expected.png:
* platform/qt/fast/table/relative-position-containment-expected.txt:
* platform/qt/fast/table/relative-position-offsets-expected.png:
* platform/qt/fast/table/relative-position-offsets-expected.txt:
* platform/qt/fast/table/relative-position-stacking-expected.png:
* platform/qt/fast/table/relative-position-stacking-expected.txt:
* platform/qt/fast/table/remove-td-display-none-expected.png:
* platform/qt/fast/table/remove-td-display-none-expected.txt:
* platform/qt/fast/table/replaced-percent-height-expected.png:
* platform/qt/fast/table/replaced-percent-height-expected.txt:
* platform/qt/fast/table/row-height-recalc-expected.png:
* platform/qt/fast/table/row-height-recalc-expected.txt:
* platform/qt/fast/table/rowindex-expected.png:
* platform/qt/fast/table/rowindex-expected.txt:
* platform/qt/fast/table/rowspan-paint-order-expected.png:
* platform/qt/fast/table/rowspan-paint-order-expected.txt:
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.png:
* platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt:
* platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
* platform/qt/fast/table/rtl-cell-display-none-assert-expected.txt:
* platform/qt/fast/table/rules-attr-dynchange1-expected.png:
* platform/qt/fast/table/rules-attr-dynchange1-expected.txt:
* platform/qt/fast/table/rules-attr-dynchange2-expected.png:
* platform/qt/fast/table/rules-attr-dynchange2-expected.txt:
* platform/qt/fast/table/spanOverlapRepaint-expected.png:
* platform/qt/fast/table/spanOverlapRepaint-expected.txt:
* platform/qt/fast/table/stale-grid-crash-expected.png:
* platform/qt/fast/table/stale-grid-crash-expected.txt:
* platform/qt/fast/table/table-after-child-in-table-expected.png:
* platform/qt/fast/table/table-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-and-parts-outline-expected.png:
* platform/qt/fast/table/table-and-parts-outline-expected.txt:
* platform/qt/fast/table/table-before-child-in-table-expected.png:
* platform/qt/fast/table/table-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-block-expected.png:
* platform/qt/fast/table/table-cell-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.png:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-block-expected.png:
* platform/qt/fast/table/table-cell-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.png:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-continuation-outline-paint-crash-expected.png:
* platform/qt/fast/table/table-continuation-outline-paint-crash-expected.txt:
* platform/qt/fast/table/table-display-types-expected.png:
* platform/qt/fast/table/table-display-types-expected.txt:
* platform/qt/fast/table/table-display-types-strict-expected.png:
* platform/qt/fast/table/table-display-types-strict-expected.txt:
* platform/qt/fast/table/table-display-types-vertical-expected.png:
* platform/qt/fast/table/table-display-types-vertical-expected.txt:
* platform/qt/fast/table/table-hspace-align-center-expected.png:
* platform/qt/fast/table/table-hspace-align-center-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-block-expected.png:
* platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-table-expected.png:
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-block-expected.png:
* platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-table-expected.png:
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
* platform/qt/fast/table/tableInsideCaption-expected.png:
* platform/qt/fast/table/tableInsideCaption-expected.txt:
* platform/qt/fast/table/text-field-baseline-expected.png:
* platform/qt/fast/table/text-field-baseline-expected.txt:
* platform/qt/fast/table/unbreakable-images-quirk-expected.png:
* platform/qt/fast/table/unbreakable-images-quirk-expected.txt:
* platform/qt/fast/table/unused-percent-heights-expected.png:
* platform/qt/fast/table/unused-percent-heights-expected.txt:
* platform/qt/fast/table/vertical-align-baseline-expected.png:
* platform/qt/fast/table/vertical-align-baseline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChrome/Skia: PDF print output does not have clickable links.
commit-queue@webkit.org [Wed, 18 Jul 2012 17:10:40 +0000 (17:10 +0000)]
Chrome/Skia: PDF print output does not have clickable links.
https://bugs.webkit.org/show_bug.cgi?id=91171

Patch by Steve VanDeBogart <vandebo@chromium.org> on 2012-07-18
Reviewed by Stephen White.

Connect GraphicsContext::setURLForRect to Skia's new API for annotations.

Printing is not generally testable.

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::setURLForRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] 0.11 build broken
commit-queue@webkit.org [Wed, 18 Jul 2012 16:51:13 +0000 (16:51 +0000)]
[GStreamer] 0.11 build broken
https://bugs.webkit.org/show_bug.cgi?id=91629

Patch by Philippe Normand <pnormand@igalia.com> on 2012-07-18
Reviewed by Alexis Menard.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkProposeAllocation): Pass null GstStructure to
gst_query_add_allocation_meta(). Our propose-allocation method
is simple enough to not need to set it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed TestExpectations update for WK90469.
jsbell@chromium.org [Wed, 18 Jul 2012 16:46:12 +0000 (16:46 +0000)]
[chromium] Unreviewed TestExpectations update for WK90469.
Coalesce entries for windows flaky crashes related to 90469, and try
skipping a particularly impacted test to see if fails shift elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=90469

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: <input type="submit"> unlabelled.
cfleizach@apple.com [Wed, 18 Jul 2012 16:36:47 +0000 (16:36 +0000)]
AX: <input type="submit"> unlabelled.
https://bugs.webkit.org/show_bug.cgi?id=91563

Reviewed by Adele Peterson.

Source/WebCore:

Make sure the default value is returned if there is no other value specified.

Test: platform/mac/accessibility/submit-button-default-value.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::title):

LayoutTests:

* platform/mac/accessibility/submit-button-default-value-expected.txt: Added.
* platform/mac/accessibility/submit-button-default-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove awkward anchorPoint usage that implicity affects layer position
shawnsingh@chromium.org [Wed, 18 Jul 2012 16:34:11 +0000 (16:34 +0000)]
[chromium] Remove awkward anchorPoint usage that implicity affects layer position
https://bugs.webkit.org/show_bug.cgi?id=91472

Reviewed by Adrienne Walker.

Source/WebCore:

Covered by existing layout tests and unit tests, several existing unit tests updated.

In GraphicsLayerChromium, anchorPoint() implicity affects
position(). Therefore, unit tests needed to remember to set
anchorPoint correctly when trying to position layers for
testing. However, it's easy to forget that initialization, and
probably shouldn't be necessary anyway since conceptually
anchorPoint does not affect layer position.

This patch removes the "actualPosition + anchorPoint" quirk in
GraphicsLayerChromium, so that this problem is avoided.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPosition): No longer computes position + anchorPoint. Instead this is done in calcDrawTransformsInternal.
(WebCore::GraphicsLayerChromium::updateLayerSize): No longer affects computation of position.
(WebCore::GraphicsLayerChromium::updateAnchorPoint): No longer affects computation of position
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D): Position is initialized to zero instead of relative to anchorPoint
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal): explicitly use position + anchorPoint in this code, for both layer and replica.
    Note that replicaLayer now uses its own anchorPoint, which seems to be more consistent with Safari behavior.

Source/WebKit/chromium:

Unit tests were updated to account for the fact that anchorPoint
and position are now separated.

* tests/CCDamageTrackerTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

LayoutTests:

* platform/chromium/TestExpectations: marked compositing/reflections/nested-reflection-anchor-point.html as needing
                                      rebaselining.  Its behavior should now be similar to Safari.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] Save as file is missing in Network panel preview/response...
pfeldman@chromium.org [Wed, 18 Jul 2012 16:10:35 +0000 (16:10 +0000)]
Web Inspector: [Regression] Save as file is missing in Network panel preview/response tabs.
https://bugs.webkit.org/show_bug.cgi?id=91625

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HandlerRegistry.js:
* inspector/front-end/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG CSS property types with <number> don't support exponents
krit@webkit.org [Wed, 18 Jul 2012 15:42:40 +0000 (15:42 +0000)]
SVG CSS property types with <number> don't support exponents
https://bugs.webkit.org/show_bug.cgi?id=52542

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Parse numbers in SVG presentation attributes with SVG parser to support scientific notations.
The SVG parser is already well tested and has some extra checks for edge like protection from
overflow.

The patch is based upon a patch of Bear Travis.

Test: svg/css/scientific-numbers.html

* css/CSSParser.cpp:
(WebCore::CSSParser::lex): Use SVG parser to parse numbers of SVG attributes.
* svg/SVGParserUtilities.cpp:
(WebCore::parseSVGNumber): Added accessor to call from CSSParser with double value.
(WebCore):
* svg/SVGParserUtilities.h:
(WebCore):

LayoutTests:

Test scientific number values on SVG presentation attributes.

* svg/css/scientific-numbers-expected.txt: Added.
* svg/css/scientific-numbers.html: Added.
* svg/css/script-tests/scientific-numbers.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: beautify the paused in debugger message, make it configurable from...
pfeldman@chromium.org [Wed, 18 Jul 2012 15:39:19 +0000 (15:39 +0000)]
Web Inspector: beautify the paused in debugger message, make it configurable from the front-end.
https://bugs.webkit.org/show_bug.cgi?id=91628

Reviewed by Vsevolod Vlasov.

Made message smaller, using consistent font;
Made message configurable from the front-end.

* English.lproj/localizedStrings.js:
* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::setPausedInDebuggerMessage):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(InspectorOverlay):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setOverlayMessage):
(WebCore):
(WebCore::InspectorDebuggerAgent::clear):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::setOverlayMessage):
* inspector/PageDebuggerAgent.h:
(PageDebuggerAgent):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype._setDebuggerPausedDetails):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore::StylePropertySet::addParsedProperties - crash
commit-queue@webkit.org [Wed, 18 Jul 2012 15:15:22 +0000 (15:15 +0000)]
WebCore::StylePropertySet::addParsedProperties - crash
https://bugs.webkit.org/show_bug.cgi?id=91153

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebCore:

WebKitCSSKeyframeRule::style exposed an immutable StylePropertySet.
Modified to create a mutable copy on demand.

Test: fast/css/css-keyframe-style-mutate-crash.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::mutableProperties): Added, creates a mutable copy of properties as required.
(WebCore::WebKitCSSKeyframeRule::style):
* css/WebKitCSSKeyframeRule.h:
(WebCore::StyleKeyframe::properties): Made const, use mutableProperties to mutate.

LayoutTests:

* fast/css/css-keyframe-style-mutate-crash-expected.txt: Added.
* fast/css/css-keyframe-style-mutate-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
kseo@webkit.org [Wed, 18 Jul 2012 15:13:34 +0000 (15:13 +0000)]
[Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect.
https://bugs.webkit.org/show_bug.cgi?id=91595

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-18
Reviewed by Noam Rosenthal.

Internal review by Kwang Yul Seo.

Currently, TextureMapperLayer creates an ImageBuffer as big as
m_state.needsDisplayRect if m_state.needsDispaly is false. The size of
m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may
consume more memory than the size of the layerRect. It even can cause crash if
m_state.needsDisplayRect is too big.

No new tests, covered by existing tests.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening.
kbalazs@webkit.org [Wed, 18 Jul 2012 15:12:26 +0000 (15:12 +0000)]
Unreviewed gardening.
More pixel rebaseline in compositing for qt-5.0-wk2.

Added baselines, mark failing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/qt-5.0-wk2/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Added.
* platform/qt-5.0-wk2/compositing/images/content-image-change-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake][EFL] Build and run TestWebKitAPI unit tests
commit-queue@webkit.org [Wed, 18 Jul 2012 15:07:34 +0000 (15:07 +0000)]
[CMake][EFL] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=90671

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

This patch enables almost for free a significant amount of test for the
WebKit C API, WTF and KURL. It makes easy for CMake based ports to
enable TestWebKitAPI since the missing bits to implement are
relatively simple.

* CMakeLists.txt:
* TestWebKitAPI/CMakeLists.txt: Added.
* TestWebKitAPI/PlatformEfl.cmake: Added.
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/config.h:
* TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
(TestWebKitAPI):
(Util):
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::URLForNonExistentResource):
* TestWebKitAPI/efl/PlatformWebView.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::initEcoreEvas):
(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::page):
* TestWebKitAPI/efl/main.cpp: Added.
(checkForUseX11WindowArgument):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] We should update the status in NetworkJob if there is a new one from...
jason.liu@torchmobile.com.cn [Wed, 18 Jul 2012 15:04:17 +0000 (15:04 +0000)]
[BlackBerry] We should update the status in NetworkJob if there is a new one from libcurl.
https://bugs.webkit.org/show_bug.cgi?id=91475

Reviewed by Yong Li.

Libcurl sometimes sends multiple status messages, we need to keep the last
one in NetworkJob.
We originally had the m_statusReceived check, then we found out that libcurl
sometimes sent additional 401 codes and added the 401 exception to the check,
and now we're removing the whole check(so we don't need the exception either).

RIM PR# 163172
Reviewed internally by Joe Mason.

No new tests. This is caused by libcurl's multiple status messages.
So we don't need to write a test case for webkit.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyStatusReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] fast/text tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Wed, 18 Jul 2012 14:52:05 +0000 (14:52 +0000)]
[Qt] fast/text tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91570

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-18
Reviewed by Simon Hausmann.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, fast/text tests directory needs to be updated.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/qt-5.0/fast/text/backslash-to-yen-sign-expected.txt:
* platform/qt-5.0/fast/text/basic/003-expected.png:
* platform/qt-5.0/fast/text/basic/003-expected.txt:
* platform/qt-5.0/fast/text/fallback-traits-fixup-expected.txt:
* platform/qt-5.0/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.png:
* platform/qt-5.0/fast/text/international/text-spliced-font-expected.txt:
* platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.png:
* platform/qt-5.0/fast/text/large-text-composed-char-expected.txt:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.png:
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.txt:
* platform/qt-5.0/fast/text/softHyphen-expected.txt:
* platform/qt-5.0/fast/text/text-letter-spacing-expected.txt:
* platform/qt/fast/text/atsui-kerning-and-ligatures-expected.txt:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.png:
* platform/qt/fast/text/atsui-small-caps-punctuation-size-expected.txt:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.png:
* platform/qt/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
* platform/qt/fast/text/basic/001-expected.png:
* platform/qt/fast/text/basic/001-expected.txt:
* platform/qt/fast/text/basic/002-expected.txt:
* platform/qt/fast/text/basic/004-expected.txt:
* platform/qt/fast/text/basic/005-expected.txt:
* platform/qt/fast/text/basic/006-expected.txt:
* platform/qt/fast/text/basic/007-expected.txt:
* platform/qt/fast/text/basic/008-expected.txt:
* platform/qt/fast/text/basic/009-expected.png:
* platform/qt/fast/text/basic/009-expected.txt:
* platform/qt/fast/text/basic/011-expected.txt:
* platform/qt/fast/text/basic/012-expected.txt:
* platform/qt/fast/text/basic/generic-family-changes-expected.png:
* platform/qt/fast/text/basic/generic-family-changes-expected.txt:
* platform/qt/fast/text/basic/generic-family-reset-expected.png:
* platform/qt/fast/text/basic/generic-family-reset-expected.txt:
* platform/qt/fast/text/break-word-expected.png:
* platform/qt/fast/text/break-word-expected.txt:
* platform/qt/fast/text/capitalize-empty-generated-string-expected.txt:
* platform/qt/fast/text/capitalize-preserve-nbsp-expected.txt:
* platform/qt/fast/text/cg-vs-atsui-expected.png:
* platform/qt/fast/text/cg-vs-atsui-expected.txt:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.png:
* platform/qt/fast/text/complex-preferred-logical-widths-expected.txt:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png:
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt:
* platform/qt/fast/text/delete-hard-break-character-expected.txt:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.png:
* platform/qt/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
* platform/qt/fast/text/fake-italic-expected.txt:
* platform/qt/fast/text/firstline/001-expected.txt:
* platform/qt/fast/text/firstline/002-expected.txt:
* platform/qt/fast/text/firstline/003-expected.txt:
* platform/qt/fast/text/font-initial-expected.txt:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
* platform/qt/fast/text/hyphenate-limit-before-after-expected.txt:
* platform/qt/fast/text/hyphenate-limit-lines-expected.png:
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt:
* platform/qt/fast/text/justified-selection-at-edge-expected.txt:
* platform/qt/fast/text/justified-selection-expected.txt:
* platform/qt/fast/text/line-breaks-after-white-space-expected.png:
* platform/qt/fast/text/line-breaks-after-white-space-expected.txt:
* platform/qt/fast/text/midword-break-before-surrogate-pair-2-expected.txt:
* platform/qt/fast/text/midword-break-hang-expected.txt:
* platform/qt/fast/text/reset-emptyRun-expected.txt:
* platform/qt/fast/text/selection-hard-linebreak-expected.png:
* platform/qt/fast/text/selection-hard-linebreak-expected.txt:
* platform/qt/fast/text/shadow-no-blur-expected.png:
* platform/qt/fast/text/shadow-no-blur-expected.txt:
* platform/qt/fast/text/shadow-translucent-fill-expected.txt:
* platform/qt/fast/text/should-use-atsui-expected.txt:
* platform/qt/fast/text/stroking-decorations-expected.txt:
* platform/qt/fast/text/stroking-expected.txt:
* platform/qt/fast/text/text-shadow-no-default-color-expected.txt:
* platform/qt/fast/text/textIteratorNilRenderer-expected.png:
* platform/qt/fast/text/textIteratorNilRenderer-expected.txt:
* platform/qt/fast/text/unicode-variation-selector-expected.png:
* platform/qt/fast/text/unicode-variation-selector-expected.txt:
* platform/qt/fast/text/updateNewFont-expected.txt:
* platform/qt/fast/text/wbr-expected.txt:
* platform/qt/fast/text/wbr-in-pre-crash-expected.txt:
* platform/qt/fast/text/wbr-pre-expected.png:
* platform/qt/fast/text/wbr-pre-expected.txt:
* platform/qt/fast/text/wbr-styled-expected.png:
* platform/qt/fast/text/wbr-styled-expected.txt:
* platform/qt/fast/text/whitespace/002-expected.png:
* platform/qt/fast/text/whitespace/002-expected.txt:
* platform/qt/fast/text/whitespace/003-expected.png:
* platform/qt/fast/text/whitespace/003-expected.txt:
* platform/qt/fast/text/whitespace/006-expected.txt:
* platform/qt/fast/text/whitespace/007-expected.txt:
* platform/qt/fast/text/whitespace/008-expected.txt:
* platform/qt/fast/text/whitespace/009-expected.txt:
* platform/qt/fast/text/whitespace/012-expected.png:
* platform/qt/fast/text/whitespace/012-expected.txt:
* platform/qt/fast/text/whitespace/013-expected.txt:
* platform/qt/fast/text/whitespace/014-expected.txt:
* platform/qt/fast/text/whitespace/018-expected.txt:
* platform/qt/fast/text/whitespace/019-expected.png:
* platform/qt/fast/text/whitespace/019-expected.txt:
* platform/qt/fast/text/whitespace/020-expected.txt:
* platform/qt/fast/text/whitespace/021-expected.txt:
* platform/qt/fast/text/whitespace/022-expected.png:
* platform/qt/fast/text/whitespace/022-expected.txt:
* platform/qt/fast/text/whitespace/023-expected.png:
* platform/qt/fast/text/whitespace/023-expected.txt:
* platform/qt/fast/text/whitespace/025-expected.txt:
* platform/qt/fast/text/whitespace/026-expected.txt:
* platform/qt/fast/text/whitespace/027-expected.txt:
* platform/qt/fast/text/whitespace/029-expected.png:
* platform/qt/fast/text/whitespace/029-expected.txt:
* platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/qt/fast/text/whitespace/nowrap-clear-float-expected.txt:
* platform/qt/fast/text/whitespace/pre-break-word-expected.png:
* platform/qt/fast/text/whitespace/pre-break-word-expected.txt:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.png:
* platform/qt/fast/text/whitespace/pre-newline-box-test-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.txt:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
* platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.txt:
* platform/qt/fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
commit-queue@webkit.org [Wed, 18 Jul 2012 14:47:40 +0000 (14:47 +0000)]
TOUCH_ADJUSTMENT is too aggressive when snapping to large elements.
https://bugs.webkit.org/show_bug.cgi?id=91262

Patch by Kevin Ellis <kevers@chromium.org> on 2012-07-18
Reviewed by Antonio Gomes.

Source/WebCore:

Constrains the extent to which the touch point can be adjusted when
generating synthetic mouse events when TOUCH_ADJUSTEMNT is enabled.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch position when tapping
on or near a large element.  The refined strategy is to leave the
adjusted position unchanged if tapping within the element or to snap
to the center of the overlap region if the touch point lies outside the
bounds of the element, but the touch area and element bounds overlap.
For non-rectilineary bounds, a point lying outside the element boundary
is pulled towards the center of the element, by an amount limited by
the radius of the touch area.

Tests: touchadjustment/big-div.html
       touchadjustment/rotated-node.html

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::contentsToWindow):
(TouchAdjustment):
(WebCore::TouchAdjustment::snapTo):
(WebCore::TouchAdjustment::findNodeWithLowestDistanceMetric):

LayoutTests:

Adding a test case to ensure that the adjusted touch position is
within the bounds of the target element and the touch area.
Previously, the target position snapped to the center of the target
element, which can be far removed from the touch area.

The second test is for non-rectilinear elements, and verifies that
the touch area must overlap the true bounds of the element for an
adjustment to occur.

* touchadjustment/big-div-expected.txt: Added.
* touchadjustment/big-div.html: Added.
* touchadjustment/rotated-node-expected.txt: Added.
* touchadjustment/rotated-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add Ewk class for cookie manager
commit-queue@webkit.org [Wed, 18 Jul 2012 14:41:22 +0000 (14:41 +0000)]
[EFL][WK2] Add Ewk class for cookie manager
https://bugs.webkit.org/show_bug.cgi?id=91053

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-18
Reviewed by Gustavo Noronha Silva.

Add new Ewk_Cookie_Manager class to allow the client
to set/get the cookie acceptance policy, support
persistent cookie storage and clear cookies.

The Ewk_Cookie_Manager instance can be retrieved
from the Ewk_Context API.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context):
(_Ewk_Context::_Ewk_Context):
(_Ewk_Context::~_Ewk_Context):
(ewk_context_cookie_manager_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_cookie_manager.cpp: Added.
(_Ewk_Cookie_Manager):
(_Ewk_Cookie_Manager::_Ewk_Cookie_Manager):
(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):
(Get_Policy_Async_Data):
(getAcceptPolicyCallback):
(ewk_cookie_manager_async_accept_policy_get):
(Get_Hostnames_Async_Data):
(getHostnamesWithCookiesCallback):
(ewk_cookie_manager_async_hostnames_with_cookies_get):
(ewk_cookie_manager_hostname_cookies_clear):
(ewk_cookie_manager_cookies_clear):
(ewk_cookie_manager_free):
(ewk_cookie_manager_new):
* UIProcess/API/efl/ewk_cookie_manager.h: Added.
* UIProcess/API/efl/ewk_cookie_manager_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 14:38:32 +0000 (14:38 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] editing/input and editing/unsupported-content tests needs update after rebaselin...
kbalazs@webkit.org [Wed, 18 Jul 2012 14:06:11 +0000 (14:06 +0000)]
[Qt] editing/input and editing/unsupported-content tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91400

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.png: Added.
* platform/qt/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
* platform/qt/editing/input/emacs-ctrl-o-expected.png:
* platform/qt/editing/input/emacs-ctrl-o-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/qt/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
* platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/qt/editing/unsupported-content/list-delete-001-expected.png:
* platform/qt/editing/unsupported-content/list-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/list-delete-003-expected.png:
* platform/qt/editing/unsupported-content/list-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/list-type-after-expected.png:
* platform/qt/editing/unsupported-content/list-type-after-expected.txt:
* platform/qt/editing/unsupported-content/list-type-before-expected.png:
* platform/qt/editing/unsupported-content/list-type-before-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-001-expected.png:
* platform/qt/editing/unsupported-content/table-delete-001-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-002-expected.png:
* platform/qt/editing/unsupported-content/table-delete-002-expected.txt:
* platform/qt/editing/unsupported-content/table-delete-003-expected.png:
* platform/qt/editing/unsupported-content/table-delete-003-expected.txt:
* platform/qt/editing/unsupported-content/table-type-after-expected.png:
* platform/qt/editing/unsupported-content/table-type-after-expected.txt:
* platform/qt/editing/unsupported-content/table-type-before-expected.png:
* platform/qt/editing/unsupported-content/table-type-before-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: adding pause icon for JavaScript debugging
caseq@chromium.org [Wed, 18 Jul 2012 14:04:58 +0000 (14:04 +0000)]
Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Patch by Sergey Rogulenko <rogulenko@google.com> on 2012-07-18
Reviewed by Pavel Feldman.

Refactored DOMNodeHighlighter into InspectorOverlay class and added a feature to show a "pause" screen when
the Javascript debugger is paused.

* inspector/DOMNodeHighlighter.cpp:
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::drawOutline):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::setPausedInDebugger):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::setHighlightData):
(WebCore::InspectorOverlay::clearHighlightData):
(WebCore::InspectorOverlay::highlightedNode):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawHighlight):
(WebCore::InspectorOverlay::drawPausedInDebugger):
* inspector/DOMNodeHighlighter.h:
(WebCore):
(InspectorOverlay):
(WebCore::InspectorOverlay::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::drawHighlight):
(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::highlightedNode):
* inspector/InspectorController.h:
(WebCore):
(InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::handleMousePress):
(WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::setHighlightDataFromConfig):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightFrame):
(WebCore::InspectorDOMAgent::hideHighlight):
* inspector/InspectorDOMAgent.h:
(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::didPaint):
* inspector/InspectorPageAgent.h:
(WebCore):
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::disable):
(WebCore):
(WebCore::PageDebuggerAgent::didPause):
(WebCore::PageDebuggerAgent::didContinue):
* inspector/PageDebuggerAgent.h:
(WebCore):
(PageDebuggerAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 13:51:45 +0000 (13:51 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: intern strings when processing timeline records
caseq@chromium.org [Wed, 18 Jul 2012 13:46:22 +0000 (13:46 +0000)]
Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Reviewed by Pavel Feldman.

- added StringPool that is capable of interning strings;
- used it in TimelineModel to process all incoming records;

* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel):
(WebInspector.TimelineModel.prototype._addRecord):
(WebInspector.TimelineModel.prototype.reset):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
commit-queue@webkit.org [Wed, 18 Jul 2012 13:42:57 +0000 (13:42 +0000)]
Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency
https://bugs.webkit.org/show_bug.cgi?id=91548

Patch by Scott Graham <scottmg@chromium.org> on 2012-07-18
Reviewed by Kentaro Hara.

Use cl.exe as preprocessor for IDL files rather than cygwin gcc. Cuts
two minute execution time on Windows by a bit better than 50%.

No new tests.

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: remove search replace from behind experiment, polish the behavior
pfeldman@chromium.org [Wed, 18 Jul 2012 13:41:07 +0000 (13:41 +0000)]
Web Inspector: remove search replace from behind experiment, polish the behavior
https://bugs.webkit.org/show_bug.cgi?id=91519

Reviewed by Vsevolod Vlasov.

- This change makes replace loop with no boundary, removes the loop parameter
  from jumpToNext/Previous;
- Lays out replace as a second row
- Fixes replace all with no search matches
- Splits Search and Search and Replace
- Introduces explicit Next / Previous buttons in the search mode
- Introduces editRange on the TextEditor so that it was preserving the undo stack
  (we'll need to fix editor so that it does not require it).

* English.lproj/localizedStrings.js:
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.performSearch):
(WebInspector.ConsolePanel.prototype.jumpToNextSearchResult):
(WebInspector.ConsolePanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.performSearch):
(WebInspector.ExtensionPanel.prototype.jumpToNextSearchResult):
(WebInspector.ExtensionPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkLogView.prototype.jumpToNextSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.NetworkPanel.prototype.jumpToNextSearchResult):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.performSearch):
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ProfilesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.jumpToNextSearchResult):
(WebInspector.ResourcesPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.cancelSearch):
(WebInspector.SearchController.prototype.resetSearch):
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateReplaceVisibility):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
(WebInspector.SearchController.prototype._updateReplaceDetailsVisibility):
(WebInspector.SearchController.prototype._replace):
(WebInspector.SearchController.prototype._replaceAll):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.replaceSearchMatchWith):
(WebInspector.SourceFrame.prototype.replaceAllWith):
(WebInspector.TextEditorDelegateForSourceFrame.prototype.beforeTextChanged):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.editRange):
* inspector/front-end/inspector.css:
(.toolbar-search-replace .search-replace):
(.toolbar-search):
(.toolbar-search-replace):
(.toolbar-search-close-button):
(.toolbar-search-close-button:hover):
(.toolbar-search-close-button:active):
(.toolbar-search input[type="checkbox"]):
(.toolbar-search-replace .toolbar-replace-control):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 18 Jul 2012 13:39:26 +0000 (13:39 +0000)]
[GTK] Add WebKitWebView::submit-form signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=91605

Reviewed by Gustavo Noronha Silva.

The signal is emitted when a form is about to submitted, with a
form submission request that can be used to get the text fields
and to continue the form submission wheh done.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitFormClient.cpp: Added.
(willSubmitForm): Create a WebKitFormSubmissionRequest and call
webkitWebViewSubmitFormRequest() with the request.
(attachFormClientToView): Add impementation for willSubmitForm
callback.
* UIProcess/API/gtk/WebKitFormClient.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp: Added.
(webkit_form_submission_request_init):
(webkitFormSubmissionRequestFinalize):
(webkit_form_submission_request_class_init):
(webkitFormSubmissionRequestCreate): Create a new
WebKitFormSubmissionRequest for the given values dictionary and
submission listener.
(webkit_form_submission_request_get_text_fields): Create a
GHashTable with the text fields values and return it.
(webkit_form_submission_request_submit): Continue the form
submission.
* UIProcess/API/gtk/WebKitFormSubmissionRequest.h: Added.
* UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Attach web view to form client.
(webkit_web_view_class_init): Add WebKitWebView::submit-form
signal.
(webkitWebViewSubmitFormRequest): Emit WebKitWebView::submit-form
signal.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitFormSubmissionRequest.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSubmitForm):
(beforeAll):
* UIProcess/API/gtk/webkit2.h: Include
WebKitFormSubmissionRequest.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] No main resource in WebView when page has been loaded from history cache
carlosgc@webkit.org [Wed, 18 Jul 2012 13:27:12 +0000 (13:27 +0000)]
[GTK] No main resource in WebView when page has been loaded from history cache
https://bugs.webkit.org/show_bug.cgi?id=91478

Reviewed by Gustavo Noronha Silva.

We are assuming that a resource loaded for the main frame that is
provisionally loading is the main resource of the web view. However
that's not true for pages loaded from history cache, so when you
go back/forward webkit_web_view_get_main_resource() always returns
NULL. We can assume that the first resource loaded for the main
frame is the main resource of the web view when
pageIsProvisionallyLoading is false.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted): Make sure we always have a
main resource for the web view.
* UIProcess/API/gtk/tests/TestResources.cpp:
(testWebViewResourcesHistoryCache): Test we always have a main
resource even after going back/forward.
(beforeAll): Add new test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
kbalazs@webkit.org [Wed, 18 Jul 2012 13:19:21 +0000 (13:19 +0000)]
[Qt] editing/style and editing/undo tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91385

Unreviewed rebaseline.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-18

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/editing/style/4916887-expected.png:
* platform/qt/editing/style/4916887-expected.txt:
* platform/qt/editing/style/5017613-1-expected.png:
* platform/qt/editing/style/5017613-1-expected.txt:
* platform/qt/editing/style/5017613-2-expected.png:
* platform/qt/editing/style/5017613-2-expected.txt:
* platform/qt/editing/style/5046875-1-expected.png:
* platform/qt/editing/style/5046875-1-expected.txt:
* platform/qt/editing/style/5046875-2-expected.png:
* platform/qt/editing/style/5046875-2-expected.txt:
* platform/qt/editing/style/5065910-expected.png:
* platform/qt/editing/style/5065910-expected.txt:
* platform/qt/editing/style/5084241-expected.png:
* platform/qt/editing/style/5084241-expected.txt:
* platform/qt/editing/style/5228141-expected.png:
* platform/qt/editing/style/5228141-expected.txt:
* platform/qt/editing/style/5279521-expected.png:
* platform/qt/editing/style/5279521-expected.txt:
* platform/qt/editing/style/apple-style-editable-mix-expected.png:
* platform/qt/editing/style/apple-style-editable-mix-expected.txt:
* platform/qt/editing/style/block-style-001-expected.png:
* platform/qt/editing/style/block-style-001-expected.txt:
* platform/qt/editing/style/block-style-002-expected.png:
* platform/qt/editing/style/block-style-002-expected.txt:
* platform/qt/editing/style/block-style-003-expected.png:
* platform/qt/editing/style/block-style-003-expected.txt:
* platform/qt/editing/style/block-styles-007-expected.png:
* platform/qt/editing/style/block-styles-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-001-expected.png:
* platform/qt/editing/style/create-block-for-style-001-expected.txt:
* platform/qt/editing/style/create-block-for-style-002-expected.png:
* platform/qt/editing/style/create-block-for-style-002-expected.txt:
* platform/qt/editing/style/create-block-for-style-003-expected.png:
* platform/qt/editing/style/create-block-for-style-003-expected.txt:
* platform/qt/editing/style/create-block-for-style-004-expected.png:
* platform/qt/editing/style/create-block-for-style-004-expected.txt:
* platform/qt/editing/style/create-block-for-style-005-expected.png:
* platform/qt/editing/style/create-block-for-style-005-expected.txt:
* platform/qt/editing/style/create-block-for-style-006-expected.png:
* platform/qt/editing/style/create-block-for-style-006-expected.txt:
* platform/qt/editing/style/create-block-for-style-007-expected.png:
* platform/qt/editing/style/create-block-for-style-007-expected.txt:
* platform/qt/editing/style/create-block-for-style-008-expected.png:
* platform/qt/editing/style/create-block-for-style-008-expected.txt:
* platform/qt/editing/style/create-block-for-style-009-expected.png:
* platform/qt/editing/style/create-block-for-style-009-expected.txt:
* platform/qt/editing/style/create-block-for-style-010-expected.png:
* platform/qt/editing/style/create-block-for-style-010-expected.txt:
* platform/qt/editing/style/create-block-for-style-011-expected.png:
* platform/qt/editing/style/create-block-for-style-011-expected.txt:
* platform/qt/editing/style/create-block-for-style-012-expected.png:
* platform/qt/editing/style/create-block-for-style-012-expected.txt:
* platform/qt/editing/style/create-block-for-style-013-expected.png:
* platform/qt/editing/style/create-block-for-style-013-expected.txt:
* platform/qt/editing/style/designmode-expected.png:
* platform/qt/editing/style/designmode-expected.txt:
* platform/qt/editing/style/font-family-with-space-expected.png:
* platform/qt/editing/style/font-family-with-space-expected.txt:
* platform/qt/editing/style/highlight-expected.png:
* platform/qt/editing/style/highlight-expected.txt:
* platform/qt/editing/style/relative-font-size-change-001-expected.png:
* platform/qt/editing/style/relative-font-size-change-001-expected.txt:
* platform/qt/editing/style/relative-font-size-change-002-expected.png:
* platform/qt/editing/style/relative-font-size-change-002-expected.txt:
* platform/qt/editing/style/relative-font-size-change-003-expected.png:
* platform/qt/editing/style/relative-font-size-change-003-expected.txt:
* platform/qt/editing/style/relative-font-size-change-004-expected.png:
* platform/qt/editing/style/relative-font-size-change-004-expected.txt:
* platform/qt/editing/style/smoosh-styles-001-expected.png:
* platform/qt/editing/style/smoosh-styles-001-expected.txt:
* platform/qt/editing/style/smoosh-styles-003-expected.png:
* platform/qt/editing/style/smoosh-styles-003-expected.txt:
* platform/qt/editing/style/style-3681552-fix-001-expected.png:
* platform/qt/editing/style/style-3681552-fix-001-expected.txt:
* platform/qt/editing/style/style-3681552-fix-002-expected.png:
* platform/qt/editing/style/style-3681552-fix-002-expected.txt:
* platform/qt/editing/style/style-3998892-fix-expected.png:
* platform/qt/editing/style/style-3998892-fix-expected.txt:
* platform/qt/editing/style/style-boundary-001-expected.png:
* platform/qt/editing/style/style-boundary-001-expected.txt:
* platform/qt/editing/style/style-boundary-002-expected.png:
* platform/qt/editing/style/style-boundary-002-expected.txt:
* platform/qt/editing/style/style-boundary-003-expected.png:
* platform/qt/editing/style/style-boundary-003-expected.txt:
* platform/qt/editing/style/style-boundary-004-expected.png:
* platform/qt/editing/style/style-boundary-004-expected.txt:
* platform/qt/editing/style/style-boundary-005-expected.png:
* platform/qt/editing/style/style-boundary-005-expected.txt:
* platform/qt/editing/style/table-selection-expected.png:
* platform/qt/editing/style/table-selection-expected.txt:
* platform/qt/editing/style/typing-style-001-expected.png:
* platform/qt/editing/style/typing-style-001-expected.txt:
* platform/qt/editing/style/typing-style-002-expected.png:
* platform/qt/editing/style/typing-style-002-expected.txt:
* platform/qt/editing/style/unbold-in-bold-expected.png:
* platform/qt/editing/style/unbold-in-bold-expected.txt:
* platform/qt/editing/undo/4063751-expected.png:
* platform/qt/editing/undo/4063751-expected.txt:
* platform/qt/editing/undo/redo-typing-001-expected.png:
* platform/qt/editing/undo/redo-typing-001-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-combined-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-combined-delete-expected.png:
* platform/qt/editing/undo/undo-combined-delete-expected.txt:
* platform/qt/editing/undo/undo-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-delete-expected.png:
* platform/qt/editing/undo/undo-delete-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.png:
* platform/qt/editing/undo/undo-forward-delete-boundary-expected.txt:
* platform/qt/editing/undo/undo-forward-delete-expected.png:
* platform/qt/editing/undo/undo-forward-delete-expected.txt:
* platform/qt/editing/undo/undo-typing-001-expected.png:
* platform/qt/editing/undo/undo-typing-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
commit-queue@webkit.org [Wed, 18 Jul 2012 13:19:13 +0000 (13:19 +0000)]
[WK2][EFL] Divide ENABLE(WEBGL) into ENABLE(WEBGL) and USE(3D_GRAPHICS) in CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=91584

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Noam Rosenthal.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
Modified CMakeLists.txt so that the basic 3D-graphics sources can be compiled even when WebGL is disabled.

* CMakeLists.txt:
* PlatformEfl.cmake:
* platform/graphics/GraphicsContext3D.h:
(GraphicsContext3D):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::platformGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaseline of compositing tests on Qt-WebKit2.
kbalazs@webkit.org [Wed, 18 Jul 2012 13:11:01 +0000 (13:11 +0000)]
Unreviewed rebaseline of compositing tests on Qt-WebKit2.

Mark pixel tests with wrong output as failing (IMAGE) Rebaseline some pixel
results where only scrollbar theme or antialiasing was the difference
between actual and expected.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png: Added.
* platform/qt-5.0-wk2/compositing/culling/clear-fixed-iframe-expected.png: Added.
* platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/fixed-in-composited-expected.png: Added.
* platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png: Added.
* platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png: Added.
* platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
* platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake][EFL] Building jsc causes reconfiguration
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:23 +0000 (12:59 +0000)]
[CMake][EFL] Building jsc causes reconfiguration
https://bugs.webkit.org/show_bug.cgi?id=91387

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

We should remove CMakeCache only when running build-webkit script,
otherwise it will cause a reconfiguration every time someone calls
generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
not running WebKit2 unit tests on the bots because the project was
reconfigured with default values by the scripts that run these tests.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(removeCMakeCache):
(generateBuildSystemFromCMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
commit-queue@webkit.org [Wed, 18 Jul 2012 12:59:21 +0000 (12:59 +0000)]
[EFL] Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=91585

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Rename WebInspectorEfl.cpp as WebInspectorProxyEfl.cpp
since it implements the platform specific methods of WebInspectorProxy.

* PlatformEfl.cmake:
* UIProcess/efl/WebInspectorProxyEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp.
(WebKit):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformIsFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 12:53:02 +0000 (12:53 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Modify the using of the QImage::Format enum to the appropriate functions from...
zoltan@webkit.org [Wed, 18 Jul 2012 12:50:36 +0000 (12:50 +0000)]
[Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt
https://bugs.webkit.org/show_bug.cgi?id=91600

Reviewed by Andreas Kling.

Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages()
instead of the direct imagetypes at the appropriate places.

Source/WebCore:

Covered by existing tests.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/qt/PathQt.cpp:
(WebCore::scratchContext):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawRepaintCounter):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::updateContents):

Source/WebKit2:

* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createQImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
commit-queue@webkit.org [Wed, 18 Jul 2012 12:50:15 +0000 (12:50 +0000)]
[EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
https://bugs.webkit.org/show_bug.cgi?id=87935

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-18
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add implementation of DumpRenderTreeSupportEfl::evaluateInWebInspector().
Some scripts for test should be evaluated in frontend.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateInWebInspector):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Web Inspector will be shown when path or url contains "inspector/".
Dumprendertree should wait util web inspector resources are loaded totally
and handle the signals for creating or removing a view of web inspector.
("inspector,view,create" and "inspector,view,close")

* DumpRenderTree/efl/DumpRenderTree.cpp:
(shouldOpenWebInspector):
(createLayoutTestController):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createWebInspectorView):
(DumpRenderTreeChrome::removeWebInspectorView):
(DumpRenderTreeChrome::waitInspectorLoadFinished):
(DumpRenderTreeChrome::onInspectorViewCreate):
(DumpRenderTreeChrome::onInspectorViewClose):
(DumpRenderTreeChrome::onInspectorFrameLoadFinished):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onConsoleMessage):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::showWebInspector):
(LayoutTestController::closeWebInspector):
(LayoutTestController::evaluateInWebInspector):

LayoutTests:

Remove the following tests from Skipped list.
LayoutTests/inspector
LayoutTests/http/test/inspector
LayoutTests/http/test/inspector-enabled
LayoutTests/http/tests/inspector/network/ping.html

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:43:45 +0000 (12:43 +0000)]
Unreviewed chromium gardening, unskipped tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: create timeline detail records lazily
caseq@chromium.org [Wed, 18 Jul 2012 12:38:44 +0000 (12:38 +0000)]
Web Inspector: create timeline detail records lazily
https://bugs.webkit.org/show_bug.cgi?id=91513

Reviewed by Pavel Feldman.

- only create timeline record details when these are used;

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineRecordListRow.prototype.update):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):
(WebInspector.TimelinePresentationModel.Record.prototype._refreshDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.details):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped tests.
vsevik@chromium.org [Wed, 18 Jul 2012 12:16:05 +0000 (12:16 +0000)]
Unreviewed chromium gardening, unskipped tests.
https://bugs.webkit.org/show_bug.cgi?id=84764
https://bugs.webkit.org/show_bug.cgi?id=84767
https://bugs.webkit.org/show_bug.cgi?id=84768
https://bugs.webkit.org/show_bug.cgi?id=84769
https://bugs.webkit.org/show_bug.cgi?id=84775
https://bugs.webkit.org/show_bug.cgi?id=84776

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
zeno.albisser@nokia.com [Wed, 18 Jul 2012 11:53:47 +0000 (11:53 +0000)]
[Qt][WK2] Caching of ShareableSurfaces breaks tiling.
https://bugs.webkit.org/show_bug.cgi?id=91609

A ShareableSurface should only be cached,
when it is GraphicsSurface based.

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
* UIProcess/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[ANGLE] On QT, use Bison and Flex during ANGLE build
hausmann@webkit.org [Wed, 18 Jul 2012 11:41:33 +0000 (11:41 +0000)]
[ANGLE] On QT, use Bison and Flex during ANGLE build
https://bugs.webkit.org/show_bug.cgi?id=91108

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add derived source generators for the two angle bison parsers and flex based lexers.

* DerivedSources.pri:
* Target.pri:

Tools:

* qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
generating not only for SOURCES but also ANGLE_SOURCES (in this bug)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Too early assertion failure if default theme is not available
commit-queue@webkit.org [Wed, 18 Jul 2012 11:30:37 +0000 (11:30 +0000)]
[EFL][WK2] Too early assertion failure if default theme is not available
https://bugs.webkit.org/show_bug.cgi?id=91608

Patch by Dominik R√∂ttsches <dominik.rottsches@intel.com> on 2012-07-18
Reviewed by Kenneth Rohde Christiansen.

After bug 90107 we're setting a default theme path, which leads to a
themeChanged() call initializing edje in createEdje() - if that theme
path is not available we run into a premature assertion failure.
We need to give the embedder a chance to override the default theme path
before failing - so only the usages of m_edje should be guarded with assertions.

No new tests, no change in rendering behavior.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::themePartCacheEntryReset): Adding an assertion to ensure m_edje is present - so that all usages of m_edje are now guarded.
(WebCore::RenderThemeEfl::createEdje): Not hitting assertion if theme path doesn't contain the theme object file, allowing the embedder to override with a new path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Fix a crash due to an invalid assert
carlosgc@webkit.org [Wed, 18 Jul 2012 11:30:31 +0000 (11:30 +0000)]
[GTK] Fix a crash due to an invalid assert
https://bugs.webkit.org/show_bug.cgi?id=91614

Reviewed by Xan Lopez.

In webkitWebViewBaseContainerAdd() there's
ASSERT(priv->inspectorView); that should be the opposite, since we
shoulnd't have an inspector view when the inspector view is added.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseContainerAdd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] plugin tests should not be disabled for WebKit1
hausmann@webkit.org [Wed, 18 Jul 2012 11:25:54 +0000 (11:25 +0000)]
[Qt] plugin tests should not be disabled for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=91604

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2012-07-18
Reviewed by Simon Hausmann.

Instead of not building TestNetscapePlugIn, we could programatically
disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
has been solved, so we can still test plugins on WebKit1.

* Tools.pro:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::initializeTestPluginDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMake] Make gtest a shared library
commit-queue@webkit.org [Wed, 18 Jul 2012 11:15:41 +0000 (11:15 +0000)]
[CMake] Make gtest a shared library
https://bugs.webkit.org/show_bug.cgi?id=90973

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-18
Reviewed by Daniel Bates.

.:

It's nicer to make it a shared library because it might improve
linking time and we don't need to force gtest users to link with gtest
dependencies like pthreads (which causes linking errors when it is not
available).

* Source/cmake/gtest/CMakeLists.txt:

Source/WebKit:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

Source/WebKit2:

No need to link with gtest dependencies now since it is a shared library.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
vsevik@chromium.org [Wed, 18 Jul 2012 10:54:21 +0000 (10:54 +0000)]
IndexedDB: IDBLevelDBBackingStore compilation fails because of unused variable.
https://bugs.webkit.org/show_bug.cgi?id=91612

Reviewed by Pavel Feldman.

Replaced ASSERT with ASSERT_UNUSED.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Add a common code using Color instead of QColor
commit-queue@webkit.org [Wed, 18 Jul 2012 10:31:12 +0000 (10:31 +0000)]
[WK2][EFL] Add a common code using Color instead of QColor
https://bugs.webkit.org/show_bug.cgi?id=91580

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-07-18
Reviewed by Simon Hausmann.

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
drawBorder's argument is QColor. So add a common code using Color to be used by Efl.

* UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
mario@webkit.org [Wed, 18 Jul 2012 10:20:19 +0000 (10:20 +0000)]
[WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
https://bugs.webkit.org/show_bug.cgi?id=89223

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement in WKTR for GTK, based in the
implementation present in DumpRenderTree.

Added new files in gtk/ and updated the cross-platform ones.

* WebKitTestRunner/GNUmakefile.am:
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
(WTR):
(WTR::attributeSetToString):
(WTR::checkElementState):
(WTR::indexRangeInTable):
(WTR::alterCurrentValue):
(WTR::AccessibilityUIElement::AccessibilityUIElement):
(WTR::AccessibilityUIElement::~AccessibilityUIElement):
(WTR::AccessibilityUIElement::isEqual):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::elementAtPoint):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
(WTR::AccessibilityUIElement::attributesOfDocumentLinks):
(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::numberAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::boolAttributeValue):
(WTR::AccessibilityUIElement::isAttributeSettable):
(WTR::AccessibilityUIElement::isAttributeSupported):
(WTR::AccessibilityUIElement::parameterizedAttributeNames):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::clickPointX):
(WTR::AccessibilityUIElement::clickPointY):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::insertionPointLineNumber):
(WTR::AccessibilityUIElement::isActionSupported):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isRequired):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::hierarchicalLevel):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaIsGrabbed):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::lineForIndex):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::indexInTable):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::setSelectedTextRange):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::showMenu):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):
(WTR::AccessibilityUIElement::accessibilityValue):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::addNotificationListener):
(WTR::AccessibilityUIElement::removeNotificationListener):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
(WTR::AccessibilityUIElement::isOffScreen):
(WTR::AccessibilityUIElement::isCollapsed):
(WTR::AccessibilityUIElement::isIgnored):
(WTR::AccessibilityUIElement::hasPopup):
(WTR::AccessibilityUIElement::takeFocus):
(WTR::AccessibilityUIElement::takeSelection):
(WTR::AccessibilityUIElement::addSelection):
(WTR::AccessibilityUIElement::removeSelection):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(WTR::AccessibilityUIElement::indexForTextMarker):
(WTR::AccessibilityUIElement::isTextMarkerValid):
(WTR::AccessibilityUIElement::textMarkerForIndex):

Add documentEncoding and documentURI to AccessibilityUIElement.idl.

* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:

LayoutTests:

Removed lines skipping all the accessibility tests and replace
them with the specific ones that are still not passing, which
are just a few now, and will hopefully get fixed later on.

* platform/gtk-wk2/Skipped: Reduce the list of skipped tests.

Updated two layout tests to consider nulls, something that didn't
happen with DumpRenderTree, but that we need to check now.

* accessibility/table-cell-spans.html: Update test.
* accessibility/table-cells.html: Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 09:55:35 +0000 (09:55 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 09:49:32 +0000 (09:49 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type...
yosin@chromium.org [Wed, 18 Jul 2012 09:47:28 +0000 (09:47 +0000)]
REGRESSION(r117738) [Forms] Default step base should be 0 (=1970-01) for input type month
https://bugs.webkit.org/show_bug.cgi?id=91603

Reviewed by Kent Tamura.

This patch restores default step base value to 0 (=1970-01) as before
r117738.

No new tests. Existing test(fast/forms/month/month-stepup-stepdown-from-renderer.html)
covers this case, although it is disabled.

* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed default value of
step base to defaultMonthStepBase instead of DateComponents::minimumMonth().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Build fix in WebKitTestRunner.
alexis.menard@openbossa.org [Wed, 18 Jul 2012 08:57:47 +0000 (08:57 +0000)]
[EFL] Build fix in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=91567

Reviewed by Kentaro Hara.

sleep() is defined in unistd.h, we need to include it.

* WebKitTestRunner/efl/TestControllerEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, updated test expectations.
vsevik@chromium.org [Wed, 18 Jul 2012 08:51:53 +0000 (08:51 +0000)]
Unreviewed chromium gardening, updated test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
ryuan.choi@samsung.com [Wed, 18 Jul 2012 08:37:32 +0000 (08:37 +0000)]
[EFL] Cursor is not drawn when opengl_x11 backend is choosen.
https://bugs.webkit.org/show_bug.cgi?id=89142

Reviewed by Simon Hausmann.

If theme based cursor is not given, WebKit/Efl only uses Ecore_X based
cursor as a fallback after checked whether current engine is using EcoreX.
This patch adds opengl_x11 which is one of Ecore_X based engine in check
lists to draw fallback cursor.

* platform/efl/EflScreenUtilities.cpp:
(WebCore::isUsingEcoreX):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 08:28:17 +0000 (08:28 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] Unreviewed gardening after r122913
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 08:20:13 +0000 (08:20 +0000)]
[NRWT] Unreviewed gardening after r122913
https://bugs.webkit.org/show_bug.cgi?id=91601

* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.process_kill_time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, unskipped test.
vsevik@chromium.org [Wed, 18 Jul 2012 08:19:41 +0000 (08:19 +0000)]
Unreviewed chromium gardening, unskipped test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
rniwa@webkit.org [Wed, 18 Jul 2012 08:16:31 +0000 (08:16 +0000)]
REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value
https://bugs.webkit.org/show_bug.cgi?id=91587

Reviewed by Benjamin Poulain.

Source/WebCore:

The bug was caused by my douchey code that set the length cache to be the *offset*
of the last item in a HTMLCollection. Clearly, the length of a collection that contains
the last item at offset n is n + 1. Fixed that.

Also removed the call to setLengthCache in HTMLCollection::length since it must have set
by previous calls to itemBeforeOrAfterCachedItem already. This will allow us to catch
regressions like this in ports that use JSC bindings as well.

Test: fast/dom/htmlcollection-length-after-item.html

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::itemBeforeOrAfterCachedItem):

LayoutTests:

Add a regression test. It only fails on Chromium port before the patch is applied because JSC binding code
has a bug (?) that it always checks index > length() to throw an exception before accessing an item in HTMLCollection.

* fast/dom/htmlcollection-length-after-item-expected.txt: Added.
* fast/dom/htmlcollection-length-after-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium gardening, rebaselined tests.
vsevik@chromium.org [Wed, 18 Jul 2012 08:14:32 +0000 (08:14 +0000)]
Unreviewed chromium gardening, rebaselined tests.

* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Removed.
* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Removed.
* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
* platform/chromium-win-xp/fast/inline/002-expected.png: Removed.
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-win/fast/inline-block/inline-block-vertical-align-expected.png:
* platform/chromium-win/fast/inline/002-expected.png:
* platform/chromium-win/fast/table/table-display-types-strict-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDecimal::toString should not round integer value.
yosin@chromium.org [Wed, 18 Jul 2012 08:09:45 +0000 (08:09 +0000)]
Decimal::toString should not round integer value.
https://bugs.webkit.org/show_bug.cgi?id=91481

Reviewed by Kent Tamura.

Source/WebCore:

This patch makes Decimal::toString not to round an integer value
before converting string.

Tests: WebKit/chromium/tests/DecimalTest.cpp: DecimalTest.toString

* platform/Decimal.cpp:
(WebCore::Decimal::toString): When the value is an integer, we don't
round coefficient to be DBL_DIG(15) digits because double can
represent an integer without rounding error.

Source/WebKit/chromium:

This patch adds a new test cases for Decimal::toString() for failed
value and maximum coefficient value with various exponent.

* tests/DecimalTest.cpp:
(TEST_F): DecimalTest.toString: Add test cases for big coefficient values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd copy constructor to WebSpeechGrammar.h
hans@chromium.org [Wed, 18 Jul 2012 08:08:50 +0000 (08:08 +0000)]
Add copy constructor to WebSpeechGrammar.h
https://bugs.webkit.org/show_bug.cgi?id=91484

Reviewed by Adam Barth.

Provide user-defined copy constructor (and assign function) for WebSpeechGrammar.
Without this, we were hitting the implicit copy constructor, which in
turn used the implicit copy constructor of WebPrivatePtr. This was bad,
because the implicit copy constructor wouldn't increace the reference
count on the wrapped object, causing us to crash.

Also add one for WebSpeechRecognitionResult; haven't seen any problems
here, but I noticed it was missing.

* public/WebSpeechGrammar.h:
(WebKit::WebSpeechGrammar::WebSpeechGrammar):
(WebSpeechGrammar):
* public/WebSpeechRecognitionResult.h:
(WebKit::WebSpeechRecognitionResult::WebSpeechRecognitionResult):
(WebSpeechRecognitionResult):
* src/WebSpeechGrammar.cpp:
(WebKit::WebSpeechGrammar::assign):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
ossy@webkit.org [Wed, 18 Jul 2012 08:02:19 +0000 (08:02 +0000)]
[Qt][WK2] REGRESSION(r122376): It made 68 tests flakey (TEXT PASS)
https://bugs.webkit.org/show_bug.cgi?id=91063

* platform/qt-5.0-wk2/Skipped: Skip one more test.
* platform/qt/Skipped: Move a skipped test to the proper Skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Buildfix after r122870.
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 07:51:41 +0000 (07:51 +0000)]
[Qt] Buildfix after r122870.
https://bugs.webkit.org/show_bug.cgi?id=89039

Reviewed by Csaba Osztrogon√°c

* src/compiler/preprocessor/new/MacroExpander.cpp:
(pp::MacroExpander::ungetToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Skip the new failing tests.
kkristof@inf.u-szeged.hu [Wed, 18 Jul 2012 07:10:26 +0000 (07:10 +0000)]
[Qt] Unreviewed gardening. Skip the new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix null pointer dereference introduced by Changeset 121874.
macpherson@chromium.org [Wed, 18 Jul 2012 07:09:21 +0000 (07:09 +0000)]
Fix null pointer dereference introduced by Changeset 121874.
https://bugs.webkit.org/show_bug.cgi?id=91578

Reviewed by Pavel Feldman.

In http://trac.webkit.org/changeset/121874/trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp I introduced code that
dereferences the return value of ownerDocument() without doing a null check. This was a bad idea.

No new tests. I don't have a repro case, but it is clear from reading the code for ownerDocument() that it can return null.

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureSourceData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDecimal constructor with 99999999999999999 loses last digit
yosin@chromium.org [Wed, 18 Jul 2012 06:50:25 +0000 (06:50 +0000)]
Decimal constructor with 99999999999999999 loses last digit
https://bugs.webkit.org/show_bug.cgi?id=91579

Reviewed by Kent Tamura.

Source/WebCore:

This patch changes maximum coefficient value handling in Decimal::EncodedData
constructor not to lose the last digit. It was used ">=" operator for
comparison instead of ">" operator.

Tests: WebKit/chromium/tests/DecimalTest.cpp

* platform/Decimal.cpp:
(WebCore::Decimal::EncodedData::EncodedData): Replace ">=" to ">" for
not getting rid of the last digit for maximum coefficient value.

Source/WebKit/chromium:

This patch adds test cases for Decimal::EncodedData constructors for
testing edge cases in addition to common cases which they aren't
covered by other test cases.

* tests/DecimalTest.cpp:
(EXPECT_DECIMAL_ENCODED_DATA_EQ): Introduce a new macro for ease of
writing test cases for verifying components of Decimal::EncodedData.
(TEST_F): Added a new test entry DecimalTest.Constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Web Inspector: followup fix for r122920.
loislo@chromium.org [Wed, 18 Jul 2012 06:31:53 +0000 (06:31 +0000)]
Unreviewed Web Inspector: followup fix for r122920.

Add collected Loaders size to InspectorMemoryBlock

* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: show loaders memory consumption on the memory chart.
loislo@chromium.org [Wed, 18 Jul 2012 05:58:49 +0000 (05:58 +0000)]
Web Inspector: show loaders memory consumption on the memory chart.
https://bugs.webkit.org/show_bug.cgi?id=90686

Reviewed by Pavel Feldman.

Size of FrameLoader, DocumentLoader, ResourceLoader and their resources should be shown on the memory pie chart.

It is covered by existing WebInspector performance tests infrastructure.

* WebCore.exp.in:
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryInstrumentation::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedMemberImpl):
(WebCore):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addRawBuffer):
(WebCore::MemoryInstrumentation::addInstrumentedHashSet):
(WebCore::MemoryInstrumentation::addVector):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::domTreeInfo):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore):
* loader/DocumentLoader.h:
(WebCore):
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
(WebCore):
* loader/FrameLoader.h:
(WebCore):
(FrameLoader):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
(WebCore):
* loader/ResourceLoader.h:
(WebCore):
(ResourceLoader):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
(WebCore):
* page/Frame.h:
(WebCore):
(Frame):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
(WebCore):
* platform/SharedBuffer.h:
(WebCore):
(SharedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operatio...
fpizlo@apple.com [Wed, 18 Jul 2012 04:42:55 +0000 (04:42 +0000)]
DFG 32-bit PutById transition stub passes the payload/tag arguments to a DFG operation in the wrong order
https://bugs.webkit.org/show_bug.cgi?id=91576

Reviewed by Gavin Barraclough.

* dfg/DFGRepatch.cpp:
(JSC::DFG::emitPutTransitionStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an assertion failure in CalendarPickerElement::hostInput().
tkent@chromium.org [Wed, 18 Jul 2012 04:18:19 +0000 (04:18 +0000)]
Fix an assertion failure in CalendarPickerElement::hostInput().
https://bugs.webkit.org/show_bug.cgi?id=91568

Reviewed by Hajime Morita.

Source/WebCore:

Test: fast/forms/date/calendar-picker-type-change-onclick.html

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::defaultEventHandler):
It's possible that this function is called when the element is detached
from the document tree.

LayoutTests:

* fast/forms/date/calendar-picker-type-change-onclick-expected.txt: Added.
* fast/forms/date/calendar-picker-type-change-onclick.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoForm state: Make a new class handling HashMap<FormElementKey, Deque<>>
tkent@chromium.org [Wed, 18 Jul 2012 04:16:13 +0000 (04:16 +0000)]
Form state: Make a new class handling HashMap<FormElementKey, Deque<>>
https://bugs.webkit.org/show_bug.cgi?id=91480

Reviewed by Hajime Morita.

This is a preparation of Bug 91209, "Form state restore: Need to
identify a from by its content."

Make a new class which is responsible to handle "HashMap<FormElementKey,
Deque<FormControlState>, FormElementKeyHash, FormElementKeyHashTraits>."
Also, move the FormElementKey class declaration and related structs from
FormController.h to FormController.cpp because FormElementKey is used
only in FormController.cpp.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormElementKey): Moeved from FormController.h.
(WebCore::FormElementKey::FormElementKey):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKey::~FormElementKey): ditto.
(WebCore::FormElementKey::operator=): ditto.
(WebCore::FormElementKey::ref): ditto.
(WebCore::FormElementKey::deref): ditto.
(WebCore::operator==): Moved from FormController.h
(FormElementKeyHash): ditto.
(WebCore::FormElementKeyHash::equal): ditto.
(WebCore::FormElementKeyHash::hash):
Moved from the bottom of FormController.cpp
(WebCore::FormElementKeyHashTraits::constructDeletedValue):
Moved from FormController.h
(WebCore::FormElementKeyHashTraits::isDeletedValue): ditto.

(WebCore::SavedFormState): Added.
(WebCore::SavedFormState::isEmpty):
(WebCore::SavedFormState::SavedFormState): Added. The constructor.
(WebCore::SavedFormState::create): Added. A factory function.
(WebCore::SavedFormState::appendControlState):
Moved some code from FormController::setStateForNewFormElements.
(WebCore::SavedFormState::takeControlState):
Moved some code from FormController::takeStateForFormElement.

(WebCore::FormController::setStateForNewFormElements):
- Creates SavedFormState if needed.
- Uses SavedFormState::appendControlState.
(WebCore::FormController::takeStateForFormElement):
Uses SavedFormState.
* html/FormController.h:
(FormController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTest cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
yosin@chromium.org [Wed, 18 Jul 2012 04:09:04 +0000 (04:09 +0000)]
Test cases in DecimalTest should use EXPECT_STREQ for ease of debugging test case
https://bugs.webkit.org/show_bug.cgi?id=91572

Reviewed by Kent Tamura.

This patch introduces EXPECT_DECIMAL_STREQ macro to replace EXPECT_EQ
with String class for displaying text string rather than object dump
for ease of debugging test cases.

* tests/DecimalTest.cpp:
(DecimalTest::stepDown): Changed to return Decimal instead of String
to use EXPECT_DECIMAL_STREQ.
(DecimalTest::stepUp): ditto.
(TEST_F): Replaced EXPECT_EQ + String class to EXPECT_DECIMAL_STREQ.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
morrita@google.com [Wed, 18 Jul 2012 04:05:24 +0000 (04:05 +0000)]
[Shadow DOM] Some distribution invalidation can drop necessary reattachment.
https://bugs.webkit.org/show_bug.cgi?id=88843

Reviewed by Dimitri Glazkov.

Source/WebCore:

Following scenario caused this problem:

- Inserting a Text node as a shadow child triggers invalidateDistribution(),
  which doen't reattach the shadow's host element.
- Then inserting a <content> element after that triggers another invalidateDistribution(),
  which should reattach its host because <content> can affect not only distribution of new nodes,
  but also existing distribution.
- Since the first invalidateDistribution() has marked the distribution as invalidated,
  the second invalidateDistribution() call returns early without any reattachment,
  even though it needs one.

This change adds InvalidationType parameter to invalidateDistribution(), which asks ElementShadow to
reattach the host regardless of its validity state. InsertionPoint::insertedInto() uses
this flag to ensure that its insertion always results a reattachment.

Test: fast/dom/shadow/content-after-style.html

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Passes InvalidationType.
(WebCore::ElementShadow::removeAllShadowRoots): Passes InvalidationType.
(WebCore::ElementShadow::invalidateDistribution): Added a InvalidationType parameter.
* dom/ElementShadow.h:
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Passes InvalidationType.

LayoutTests:

* fast/dom/shadow/content-after-style-expected.html: Added.
* fast/dom/shadow/content-after-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium-Android] Run ref tests together to avoid expensive driver restarts
wangxianzhu@chromium.org [Wed, 18 Jul 2012 02:45:46 +0000 (02:45 +0000)]
[Chromium-Android] Run ref tests together to avoid expensive driver restarts
https://bugs.webkit.org/show_bug.cgi?id=91533

Reviewed by Dirk Pranke.

Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
chromium-android uses another way because it can't support multiple drivers.
It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
a normal test in --no-pixel-tests mode). However restarting driver is expensive on
Android (several seconds each time). To reduce the cost, a command line option
'--shard-ref-tests' is added to group ref tests in dedicated shards.
The option is by default enabled on Android.

Will remove the option once DRT supports switching pixel test mode during one run.
(https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._shard_tests):
(Manager._shard_in_two):
(Manager._shard_by_directory):
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNRWT The time before server_process kills DRT should be variable
commit-queue@webkit.org [Wed, 18 Jul 2012 01:26:24 +0000 (01:26 +0000)]
NRWT The time before server_process kills DRT should be variable
https://bugs.webkit.org/show_bug.cgi?id=91542

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-07-17
Reviewed by Dirk Pranke.

Added the ability to configure the amount of time
server_process waits before killing the DRT process
during the call to stop.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.variable.process_kill_time):
* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach CodeGenerator to support for static, readonly, attributes
jonlee@apple.com [Wed, 18 Jul 2012 01:16:14 +0000 (01:16 +0000)]
Teach CodeGenerator to support for static, readonly, attributes
https://bugs.webkit.org/show_bug.cgi?id=88920
<rdar://problem/11650330>

Reviewed by Oliver Hunt.

Update the parser to be able to accept the static keyword for attribute. We will treat static attributes
like custom static functions. They call the implementing class directly, and pass in the ExecState as a script context.

* bindings/scripts/CodeGeneratorJS.pm:
(GetAttributeGetterName): Factor out the construction of the attribute getter function name.
(GetAttributeSetterName): Factor out the construction of the attribute setter function name.
(GenerateHeader): Determine that a class has read-write properties only if there is a read-write attribute that
is not static.
(GenerateAttributesHashTable): Skip static attributes in the object hash table. They will be added to the constructor
hash table.
(GenerateImplementation): Look for static attributes to add to the constructor hash table. Make a call to the static
function in the class.
* bindings/scripts/IDLParser.pm:
(ParseInterface): Update the processing because of the regex change.
* bindings/scripts/IDLStructure.pm: Update the attribute regex.
* bindings/scripts/test/JS/JSTestObj.cpp: Update test results.
* bindings/scripts/test/JS/JSTestObj.h: Update test results.
* bindings/scripts/test/TestObj.idl: Add test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
bashi@chromium.org [Wed, 18 Jul 2012 01:12:10 +0000 (01:12 +0000)]
[Chromium] Rename HarfBuzzFace to HarfBuzzNGFace
https://bugs.webkit.org/show_bug.cgi?id=91458

Reviewed by Tony Chang.

There are HarfbuzzFace class (for old-harfbuzz) and HarfBuzzFace (for harfbuzz-ng) class. The difference is too subtle. Make them more distinct.

No new tests. No changes in behavior.

* WebCore.gyp/WebCore.gyp: Rename HarfBuzzFace to HarfBuzzNGFace.
* WebCore.gypi: Ditto.
* platform/graphics/FontPlatformData.h: Ditto.
(FontPlatformData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp: Ditto.
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h: Ditto.
(FontPlatformData):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceCoreText.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFaceSkia.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFaceSkia.cpp.
(WebCore):
(WebCore::SkiaScalarToHarfbuzzPosition):
(WebCore::SkiaGetGlyphWidthAndExtents):
(WebCore::harfbuzzGetGlyph):
(WebCore::harfbuzzGetGlyphHorizontalAdvance):
(WebCore::harfbuzzGetGlyphHorizontalOrigin):
(WebCore::harfbuzzGetGlyphExtents):
(WebCore::harfbuzzSkiaGetFontFuncs):
(WebCore::harfbuzzSkiaGetTable):
(WebCore::destroyPaint):
(WebCore::HarfBuzzNGFace::createFace):
(WebCore::HarfBuzzNGFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.cpp: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp.
(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzNGFace::HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::~HarfBuzzNGFace):
* platform/graphics/harfbuzz/ng/HarfBuzzNGFace.h: Renamed from Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzFace.h.
(WebCore):
(HarfBuzzNGFace):
(WebCore::HarfBuzzNGFace::create):
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRecord metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
kinuko@chromium.org [Wed, 18 Jul 2012 01:08:39 +0000 (01:08 +0000)]
Record metrics to measure the usage of Blob([ArrayBuffer]) to eventually deprecate it
https://bugs.webkit.org/show_bug.cgi?id=90534

Reviewed by Jian Li.

We are removing ArrayBuffer support in Blob constructor (in favor of
ArrayBufferView) but before doing that we should record its use relative to ArrayBufferView.
http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob

No new tests as this has no functional changes.

* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Key generator state not maintained across connections
jsbell@chromium.org [Wed, 18 Jul 2012 01:07:27 +0000 (01:07 +0000)]
IndexedDB: Key generator state not maintained across connections
https://bugs.webkit.org/show_bug.cgi?id=91456

Reviewed by Tony Chang.

Source/WebCore:

Explicitly store key generator state for each object store in the backing store,
rather than deriving it from the maximum key in the data (which violates the spec
if data is deleted).

This change eliminates a (fragile) per-store cache of the value to simplify the
code. A cache could be re-introduced, requiring an "onbeforecommit" hook for
object stores, but it seems cleaner to save that for a follow-up patch.

Test: storage/indexeddb/key-generator.html

* Modules/indexeddb/IDBBackingStore.h: New APIs for getting/setting generator states.
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::getObjectStores): Read generator state (but currently ignored).
(WebCore::IDBLevelDBBackingStore::createObjectStore): Write generator state.
(WebCore):
(WebCore::IDBLevelDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBLevelDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber): Update, optionally
checking to see if the new value is greater than the old. (If caller got the value via
getKeyGeneratorCurrentNumber it is safe to skip the check.)
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBLevelDBCoding.cpp:
* Modules/indexeddb/IDBLevelDBCoding.h:
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): Ditch the cache.
(WebCore::IDBObjectStoreBackendImpl::put): No need for abort task.
(WebCore::IDBObjectStoreBackendImpl::putWithIndexKeys): Ditto.
(WebCore::IDBObjectStoreBackendImpl::putInternal): Use the newfangled APIs below.
(WebCore::IDBObjectStoreBackendImpl::generateKey):
(WebCore::IDBObjectStoreBackendImpl::updateKeyGenerator):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

Source/WebKit/chromium:

Add stub method implementations to test class.

* tests/IDBFakeBackingStore.h:

LayoutTests:

Added key generator test case that spans database connections.

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(testAcrossConnections.request.onsuccess.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess.request.onsuccess):
(testAcrossConnections.request.onsuccess):
(testAcrossConnections.doFirstWrite.request.onsuccess):
(testAcrossConnections.doFirstWrite):
(testAcrossConnections.closeAndReopen.request.onsuccess):
(testAcrossConnections.closeAndReopen):
(testAcrossConnections.doSecondWrite.request.onsuccess):
(testAcrossConnections.doSecondWrite.trans.oncomplete):
(testAcrossConnections.doSecondWrite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitdirs.pm should fallback to uname -m if arch is not present.
alexis.menard@openbossa.org [Wed, 18 Jul 2012 00:58:47 +0000 (00:58 +0000)]
webkitdirs.pm should fallback to uname -m if arch is not present.
https://bugs.webkit.org/show_bug.cgi?id=91543

Reviewed by Martin Robinson.

It seems that coreutils is moving away from the 'arch' command. Archlinux
for example doesn't ship it anymore (coreutils 8.17). We can then fallback
to 'uname -m' to find out the architecture.

* Scripts/webkitdirs.pm:
(determineArchitecture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium windows rebaseline for r122883.
eae@chromium.org [Wed, 18 Jul 2012 00:49:59 +0000 (00:49 +0000)]
Unreviewed chromium windows rebaseline for r122883.

* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-win-xp/css2.1/t100801-c544-valgn-03-d-agi-expected.txt: Added.
* platform/chromium-win-xp/fast/inline-block/inline-block-vertical-align-expected.png: Added.
* platform/chromium-win-xp/fast/inline/002-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
commit-queue@webkit.org [Wed, 18 Jul 2012 00:35:25 +0000 (00:35 +0000)]
IndexedDB: createIndex should throw INVALID_ACCESS_ERR instead of NOT_SUPPORTED_ERR
https://bugs.webkit.org/show_bug.cgi?id=91553

Patch by Alec Flett <alecflett@chromium.org> on 2012-07-17
Reviewed by Tony Chang.

Source/WebCore:

Update createIndex to throw an INVALID_ACCESS_ERR
as per the IndexedDB spec.

No new tests: existing tests have been updated

* Modules/indexeddb/IDBDatabaseException.cpp:
(WebCore):
* Modules/indexeddb/IDBDatabaseException.h:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):

LayoutTests:

Update to match IndexedDB spec.

* storage/indexeddb/keypath-arrays-expected.txt:
* storage/indexeddb/resources/keypath-arrays.js:
(openSuccess.request.onsuccess):
(openSuccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: rename printer.print_update to printer.write_update to match metered_stream
dpranke@chromium.org [Wed, 18 Jul 2012 00:32:12 +0000 (00:32 +0000)]
nrwt: rename printer.print_update to printer.write_update to match metered_stream
https://bugs.webkit.org/show_bug.cgi?id=91557

Reviewed by Ojan Vafai.

Now that all of the printing logic is in printer.py, I want the
public interface to printer to follow the meteredstream
interface where possible. renaming write_update() gets us close.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
(Manager._set_up_run):
(Manager.start_servers_with_lock):
(Manager.stop_servers_with_lock):
(Manager._clobber_old_results):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.write_update):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_write_update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
pdr@google.com [Wed, 18 Jul 2012 00:30:39 +0000 (00:30 +0000)]
Remove entries in TestExpectations for passing non-scaling-stroke-pattern.svg
https://bugs.webkit.org/show_bug.cgi?id=88230

Unreviewed update of test expecatations.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a bug where optimize-baselines would incorrectly fail to optimize
tony@chromium.org [Wed, 18 Jul 2012 00:26:25 +0000 (00:26 +0000)]
Fix a bug where optimize-baselines would incorrectly fail to optimize
https://bugs.webkit.org/show_bug.cgi?id=91551

Reviewed by Adam Barth.

In some cases, optimize-baseline would correctly optimize the results, but because
we weren't filtering the virtual ports out of _results_by_port_name, we thought
that we had failed to optimize.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
(BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
(BaselineOptimizer.optimize): Filter out virtual ports.
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
(TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
(BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
(BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
(BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
(BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add --encode-binary command line option for DRT
wangxianzhu@chromium.org [Wed, 18 Jul 2012 00:21:45 +0000 (00:21 +0000)]
[Chromium] Add --encode-binary command line option for DRT
https://bugs.webkit.org/show_bug.cgi?id=91532

Reviewed by Adam Barth.

When the option presents, DRT will encode binary output data in base64.
ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
binary data output.

This change is a refactoring to replace the original hard-coded code for Android.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(TestEventPrinter::TestEventPrinter):
(TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
(TestEventPrinter::handleImage):
(TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
* DumpRenderTree/chromium/TestEventPrinter.h:
(TestEventPrinter):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::initialize):
(TestShell::dump):
* DumpRenderTree/chromium/TestShell.h:
(TestShell):
(TestShell::setEncodeBinary):
* Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
(ChromiumAndroidPort.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@122901 268f45cc-cd09-0410-ab3c-d52691b4dbfc