WebKit-https.git
7 years agoCleanup: Move flatten-trie to loader.
jparent@chromium.org [Wed, 13 Mar 2013 04:14:17 +0000 (04:14 +0000)]
Cleanup: Move flatten-trie to loader.
https://bugs.webkit.org/show_bug.cgi?id=112196

Reviewed by Dirk Pranke.

flatten-trie is used only by the loader, so move it there and make it
private, rather than global in dashbaord_base. Moved the corresponding
unit test from flakiness_dashboard_unittests to loader_unittests.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.
ggaren@apple.com [Wed, 13 Mar 2013 03:59:32 +0000 (03:59 +0000)]
Unreviewed attempted Windows build fix after trac.webkit.org/changeset/145592.

* wtf/SchedulePair.cpp:
* wtf/SchedulePair.h:
(WTF::SchedulePair::SchedulePair): Since linking is failing,
try inlining this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Crash] Touch Events retargeting causes crashes on chrome on android.
hayato@chromium.org [Wed, 13 Mar 2013 03:51:39 +0000 (03:51 +0000)]
[Crash] Touch Events retargeting causes crashes on chrome on android.
https://bugs.webkit.org/show_bug.cgi?id=112210

Reviewed by Dimitri Glazkov.

Added null-check for TouchEvent's touches(), targetTouches() and changedTouches().

No new tests - no new functionality.

* dom/EventRetargeter.cpp:
(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustTouchList):
* dom/EventRetargeter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] ewk_popup_menu_close() does not work as intended
ch.dumez@sisa.samsung.com [Wed, 13 Mar 2013 03:46:58 +0000 (03:46 +0000)]
[EFL][WK2] ewk_popup_menu_close() does not work as intended
https://bugs.webkit.org/show_bug.cgi?id=110209

Reviewed by Laszlo Gombos.

ewk_popup_menu_close() is called by the browser to notify WebKit that
the popup menu was closed. However, the implementation was calling
EwkView::closePopupMenu() which was asking the browser to close the
popup menu via an Evas smart function. This patch fixes the behavior
and ewk_popup_menu_close() now calls WKPopupMenuListenerSetSelection()
C API so that the WebProcess is notified that the popup menu was
hidden.

* UIProcess/API/efl/ewk_popup_menu.cpp:
(EwkPopupMenu::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r187688. Requested by
commit-queue@webkit.org [Wed, 13 Mar 2013 03:07:47 +0000 (03:07 +0000)]
Unreviewed.  Rolled Chromium DEPS to r187688.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2013-03-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 13 Mar 2013 02:59:08 +0000 (02:59 +0000)]
2013-03-12  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.

        * platform/RunLoopTimer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate test expectation for the bug 111521.
rniwa@webkit.org [Wed, 13 Mar 2013 02:14:31 +0000 (02:14 +0000)]
Update test expectation for the bug 111521.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer().
commit-queue@webkit.org [Wed, 13 Mar 2013 01:51:16 +0000 (01:51 +0000)]
Coordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer().
https://bugs.webkit.org/show_bug.cgi?id=111835

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-12
Reviewed by Luiz Agostini.

Source/WebCore:

This patch removes CoordinatedGraphicsLayer::setRootLayer() because
CoordinatedGraphicsScene already knows which layer is root.

No new tests, no behavior change.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

Source/WebKit2:

Amend CoordinatedLayerTreeHost because
CoordinatedGraphicsLayer::setRootLayer() is removed.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelera...
commit-queue@webkit.org [Wed, 13 Mar 2013 01:47:39 +0000 (01:47 +0000)]
Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use
https://bugs.webkit.org/show_bug.cgi?id=111126

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

In texImage2D() for HTMLVideoElement in WebGL, it is possible to do a GPU-GPU texture copy instead of CPU readback
and upload when videoFrame is in the form of textures. Each platform port needs to implement the interface
copyVideoTextureToPlatformTexture() defined in MediaPlayer.h to make it work.

Already covered by current tests.

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture):
* html/HTMLVideoElement.h:
(HTMLVideoElement):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::videoFrameToImage): Move some security check to upper level.
(WebCore::WebGLRenderingContext::texImage2D): Add the fast GPU-GPU textures copy path for HTMLVideoElement and some security check.
(WebCore::WebGLRenderingContext::texSubImage2D): Add some security check.
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::isValid): Added to check if the texture is defined at the given level.
* html/canvas/WebGLTexture.h:
(WebGLTexture):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::copyVideoTextureToPlatformTexture): Added to do the GPU-GPU textures copy.
* platform/graphics/MediaPlayer.h:
(MediaPlayer):
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::copyVideoTextureToPlatformTexture):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::copyVideoTextureToPlatformTexture):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::copyVideoTextureToPlatformTexture): do a GPU-GPU textures copy if possible.
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate a few chromium test expectations.
jamesr@google.com [Wed, 13 Mar 2013 01:46:27 +0000 (01:46 +0000)]
Update a few chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTypo in earlier Windows build fix. Unreviewed.
timothy_horton@apple.com [Wed, 13 Mar 2013 01:25:00 +0000 (01:25 +0000)]
Typo in earlier Windows build fix. Unreviewed.

* WTF.vcproj/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF uses macros for exports. Try to fix the Windows build. Unreviewed.
timothy_horton@apple.com [Wed, 13 Mar 2013 01:20:51 +0000 (01:20 +0000)]
WTF uses macros for exports. Try to fix the Windows build. Unreviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] WebFrame event listener APIs are unused and can be removed
abarth@webkit.org [Wed, 13 Mar 2013 01:19:05 +0000 (01:19 +0000)]
[Chromium] WebFrame event listener APIs are unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=112189

Reviewed by Darin Fisher.

As far as I can tell, there are no callers for these APIs. They appear
to have been added for out-of-process postMessages, but those are now
implemented using a different mechanism.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
* src/WebFrameImpl.h:
(WebFrameImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145280.
commit-queue@webkit.org [Wed, 13 Mar 2013 01:14:34 +0000 (01:14 +0000)]
Unreviewed, rolling out r145280.
http://trac.webkit.org/changeset/145280
https://bugs.webkit.org/show_bug.cgi?id=112217

This patch broke chromium WebGL conformance tests (Requested
by shawnsingh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnbreak api tests
oliver@apple.com [Wed, 13 Mar 2013 01:06:15 +0000 (01:06 +0000)]
Unbreak api tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't send events to plugins that are being snapshotted
dino@apple.com [Wed, 13 Mar 2013 00:56:52 +0000 (00:56 +0000)]
Don't send events to plugins that are being snapshotted
https://bugs.webkit.org/show_bug.cgi?id=112215
<rdar://problem/13386224>

Reviewed by Tim Horton.

If a plugin is in the process of being snapshotted, do not forward it
any events. This avoids the case where we can accidentally capture some
custom mouse pointers, as well as trigger a plugin menu.

The next step will be to detect if the event should stop the snapshotting
(restart the plugin).

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Return early if the plugin is snapshotting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrimary plugin hit detection needs to run after plugin creation
dino@apple.com [Wed, 13 Mar 2013 00:56:32 +0000 (00:56 +0000)]
Primary plugin hit detection needs to run after plugin creation
https://bugs.webkit.org/show_bug.cgi?id=112206

Reviewed by Tim Horton.

On some pages, the plugins are created after the page has loaded, and
thus our heuristic to determine the primary plugin fails. Run this
heuristic more often: after each PluginView is created. It already exits
early if it has found a primary. But we also need to make sure that it
doesn't run before load.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addPluginView): Run detection when view is added.
(WebKit::WebPage::didFinishLoad): Remember that we have loaded.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Look at the PluginViews to see if we have a plugin.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn): Reset both flags.
* WebProcess/WebPage/WebPage.h:
(WebPage): New member variable, m_readyToFindPrimarySnapshottedPlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.
timothy_horton@apple.com [Wed, 13 Mar 2013 00:43:44 +0000 (00:43 +0000)]
Unreviewed attempted Windows build fix after trac.webkit.org/changeset/145592.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

* WTF.vcproj/WTF.vcproj:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
commit-queue@webkit.org [Wed, 13 Mar 2013 00:25:45 +0000 (00:25 +0000)]
Fix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
https://bugs.webkit.org/show_bug.cgi?id=89510

Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

WTF::Vector::begin() returns 0 when the vector has length zero. On windows, the debug implementation of
std::copy() is unhappy with 0 as a third parameter even when the first and second parameters are equal.

Covered by gamepad/gamepad-polling-access.html

* Modules/gamepad/Gamepad.cpp:
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):

LayoutTests:

Remove expectation now that test passes.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray.prototype.sort should at least try to be PTIME even when the array is in some...
fpizlo@apple.com [Wed, 13 Mar 2013 00:17:38 +0000 (00:17 +0000)]
Array.prototype.sort should at least try to be PTIME even when the array is in some bizarre mode
https://bugs.webkit.org/show_bug.cgi?id=112187
<rdar://problem/13393550>

Source/JavaScriptCore:

Reviewed by Michael Saboff and Gavin Barraclough.

If we have an array-like object in crazy mode passed into Array.prototype.sort, and its length is large,
then first copy all elements into a separate, compact, un-holy array and sort that. Then copy back.
This means that sorting will be at works O(n^2) in the actual number of things in the array, rather than
O(n^2) in the array's length.

* runtime/ArrayPrototype.cpp:
(JSC::attemptFastSort):
(JSC::performSlowSort):
(JSC):
(JSC::arrayProtoFuncSort):

LayoutTests:

Reviewed by Michael Saboff and Gavin Barraclough.

If your Array.prototype.sort is not sufficiently smart, this test will never complete.
But if it is, it'll complete instantly.

* fast/js/array-sort-small-sparse-array-with-large-length-expected.txt: Added.
* fast/js/array-sort-small-sparse-array-with-large-length.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/array-sort-small-sparse-array-with-large-length.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is
bdakin@apple.com [Wed, 13 Mar 2013 00:09:55 +0000 (00:09 +0000)]
WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is
passed in
https://bugs.webkit.org/show_bug.cgi?id=112212
-and corresponding-
<rdar://problem/12994883>

Reviewed by Anders Carlsson.

We should call [NSPrintOperation printOperationWithView: printInfo:] to use the
printInfo parameter instead of [NSPrintOperation printOperationWithView:] which
will just use the sharedPrintInfo.
* UIProcess/API/mac/WKView.mm:
(-[WKView printOperationWithPrintInfo:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove last vestigates of WEBKIT_USING_V8
abarth@webkit.org [Wed, 13 Mar 2013 00:03:42 +0000 (00:03 +0000)]
[Chromium] Remove last vestigates of WEBKIT_USING_V8
https://bugs.webkit.org/show_bug.cgi?id=112203

Reviewed by James Robinson.

These macros are no longer referenced anywhere and can be removed.

* chromium/public/WebCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate chromium pixel baselines for mesa blend fix in chromium r187688
jamesr@google.com [Wed, 13 Mar 2013 00:02:54 +0000 (00:02 +0000)]
Update chromium pixel baselines for mesa blend fix in chromium r187688

* platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Removed.
* platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Removed.
* platform/chromium-linux/compositing/direct-image-compositing-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-linux/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-linux/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-linux/compositing/self-painting-layers-expected.png:
* platform/chromium-linux/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Removed.
* platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Removed.
* platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
* platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
* platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Removed.
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
* platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png:
* platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
* platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
* platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
* platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac-lion/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac-lion/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac-lion/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac-lion/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-lion/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac-lion/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-lion/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png:
* platform/chromium-mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
* platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
* platform/chromium-mac/compositing/direct-image-compositing-expected.png:
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png:
* platform/chromium-mac/compositing/self-painting-layers-expected.png:
* platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
* platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png:
* platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
* platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
* platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
* platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
* platform/chromium-mac/css3/filters/filter-change-repaint-composited-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-change-repaint-expected.png: Added.
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
* platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png:
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
* platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
* platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
* platform/chromium/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
* platform/efl-wk2/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the Windows build.
timothy_horton@apple.com [Tue, 12 Mar 2013 23:49:12 +0000 (23:49 +0000)]
Try to fix the Windows build.

Not reviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove TextIterator.cpp's isAllCollapsibleWhitespace
esprehn@chromium.org [Tue, 12 Mar 2013 23:43:47 +0000 (23:43 +0000)]
Remove TextIterator.cpp's isAllCollapsibleWhitespace
https://bugs.webkit.org/show_bug.cgi?id=112200

Reviewed by Ryosuke Niwa.

Remove isAllCollapsibleWhitespace since nothing uses it.

* editing/TextIterator.cpp: Remove isAllCollapsibleWhitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
betravis@adobe.com [Tue, 12 Mar 2013 23:27:35 +0000 (23:27 +0000)]
[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.
* rendering/RenderBlock.h:
(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member. Move the struct
declaration to be public, so that the OwnPtr reference can properly delete it.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, disabling tests for Win EWS.
timothy_horton@apple.com [Tue, 12 Mar 2013 23:15:04 +0000 (23:15 +0000)]
Unreviewed, disabling tests for Win EWS.

win-ews obviously cannot keep up with running tests, it's >300 behind.
Probably doesn't help that its (likely) running tests serially.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the Windows build.
ggaren@apple.com [Tue, 12 Mar 2013 23:14:51 +0000 (23:14 +0000)]
Try to fix the Windows build.

Not reviewed.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Export a thing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for r145592 - update gyp files to refer to new file locations.
jamesr@google.com [Tue, 12 Mar 2013 22:49:56 +0000 (22:49 +0000)]
Build fix for r145592 - update gyp files to refer to new file locations.

Source/WebCore:

* WebCore.gypi:

Source/WTF:

* WTF.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a single character cache to WidthCache
benjamin@webkit.org [Tue, 12 Mar 2013 22:39:02 +0000 (22:39 +0000)]
Add a single character cache to WidthCache
https://bugs.webkit.org/show_bug.cgi?id=112084

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-12
Reviewed by Geoffrey Garen.

More than half of the values stored in WidthCache are values
for a single character.

Previously, we were creating a new SmallStringKey for each one of
them, causing a lot of extra memory operations even for the simple
cases.

This patch adds a second map, m_singleCharMap, to simplify the
computation for the common case of a single char TextRun.

* platform/graphics/WidthCache.h:
(WebCore::WidthCache::clear):
(WidthCache):
(WebCore::WidthCache::addSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a --build-directory argument to delete-stale-build-files
timothy_horton@apple.com [Tue, 12 Mar 2013 22:38:45 +0000 (22:38 +0000)]
Add a --build-directory argument to delete-stale-build-files
https://bugs.webkit.org/show_bug.cgi?id=112198

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/delete-stale-build-files:
(main): Add --build-directory argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace static_casts for SVG transformable and locatable elements
pdr@google.com [Tue, 12 Mar 2013 22:26:07 +0000 (22:26 +0000)]
Replace static_casts for SVG transformable and locatable elements
https://bugs.webkit.org/show_bug.cgi?id=111651

Reviewed by Abhishek Arya.

toSVGStyledTransformableElement and toSVGStyledLocatableElement are preferred over
static_casts because bad casts can be caught on our testing infrastructure. This patch
replaces all static_casts for SVGStyledTransformableElement and SVGStyledLocatableElement
with toSVGStyledTransformableElement and toSVGStyledLocatableElement, respectively.

No new tests as this is covered with existing tests.

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
* rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::calculateDistance):

    This was an unnecessary cast and has been removed.

* svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
* svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
* svg/SVGStyledLocatableElement.h:
(WebCore):
(WebCore::toSVGStyledLocatableElement):
* svg/SVGStyledTransformableElement.h:
(WebCore):
(WebCore::toSVGStyledTransformableElement):

    It makes the code cleaner to pass Node* in here, rather than converting the Node*
    to an SVGElement* before calling this function. The same was not necessary for
    SVGStyledLocatable.

* svg/SVGSVGElement.h:
(WebCore):
(WebCore::toSVGSVGElement):

    This code has been cleaned up. During the review of this patch, a similar cleanup
    was done in toSVGStyledTransformableElement.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled Chromium DEPS to r187660. Requested by
abarth@webkit.org [Tue, 12 Mar 2013 22:21:38 +0000 (22:21 +0000)]
Unreviewed.  Rolled Chromium DEPS to r187660.  Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace static_casts with to* helper functions.
inferno@chromium.org [Tue, 12 Mar 2013 22:21:28 +0000 (22:21 +0000)]
Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112164

Reviewed by Philip Rogers.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
(WebCore::Pasteboard::writeImage):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::checkMultiple):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::title):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::hitTest):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::valueChanged):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addPDFURLRect):
* rendering/RenderPart.cpp:
(WebCore::RenderPart::requiresAcceleratedCompositing):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::checkRegionStyle):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computePreferredLogicalWidths):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isEnabled):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isHovered):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
(WebCore::RenderTheme::paintSliderTicks):
* rendering/RenderThemeWinCE.cpp:
(WebCore::mediaElementParent):
* rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAppease MSVC
oliver@apple.com [Tue, 12 Mar 2013 22:17:28 +0000 (22:17 +0000)]
Appease MSVC

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHarden JSStringJoiner
oliver@apple.com [Tue, 12 Mar 2013 22:15:54 +0000 (22:15 +0000)]
Harden JSStringJoiner
https://bugs.webkit.org/show_bug.cgi?id=112093

Reviewed by Filip Pizlo.

Harden JSStringJoiner, make it use our CheckedArithmetic
class to simplify everything.

* runtime/JSStringJoiner.cpp:
(JSC::JSStringJoiner::build):
* runtime/JSStringJoiner.h:
(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd one more test expectation per bug 112176.
rniwa@webkit.org [Tue, 12 Mar 2013 22:04:22 +0000 (22:04 +0000)]
Add one more test expectation per bug 112176.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoved RunLoopTimer and SchedulePair to WTF
ggaren@apple.com [Tue, 12 Mar 2013 22:04:06 +0000 (22:04 +0000)]
Moved RunLoopTimer and SchedulePair to WTF
https://bugs.webkit.org/show_bug.cgi?id=112171

Reviewed by Oliver Hunt.

This will allow us to use timers in lower level primitives without
duplicating all the code.

../WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.h:
(WTF):
(WebCore):
(DocumentLoader):
* loader/MainResourceLoader.h:
* page/Page.h:
* platform/AutodrainedPool.h: Removed.
* platform/cf/RunLoopTimerCF.cpp: Removed.
* platform/cf/SchedulePair.cpp: Removed.
* platform/cf/SchedulePair.h: Removed.
* platform/mac/AutodrainedPool.mm: Removed.
* platform/mac/SchedulePairMac.mm: Removed.
* platform/network/NetworkingContext.h:
* platform/network/ResourceHandle.h:
(WTF):
(WebCore):
(ResourceHandle):
* platform/network/cf/FormDataStreamCFNet.cpp:
* platform/network/mac/ResourceHandleMac.mm:

../WebKit/mac:

* WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):

../WebKit2:

* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):

../WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/AutodrainedPool.h: Copied from Source/WebCore/platform/AutodrainedPool.h.
(AutodrainedPool):
* wtf/AutodrainedPoolMac.mm: Copied from Source/WebCore/platform/mac/AutodrainedPool.mm.
* wtf/RunLoopTimer.h: Copied from Source/WebCore/platform/RunLoopTimer.h.
* wtf/RunLoopTimerCF.cpp: Copied from Source/WebCore/platform/cf/RunLoopTimerCF.cpp.
* wtf/SchedulePair.cpp: Copied from Source/WebCore/platform/cf/SchedulePair.cpp.
* wtf/SchedulePair.h: Copied from Source/WebCore/platform/cf/SchedulePair.h.
(SchedulePair):
* wtf/SchedulePairMac.mm: Copied from Source/WebCore/platform/mac/SchedulePairMac.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove stray .gitmodules file
abarth@webkit.org [Tue, 12 Mar 2013 21:58:01 +0000 (21:58 +0000)]
Remove stray .gitmodules file
https://bugs.webkit.org/show_bug.cgi?id=112186

Reviewed by Tony Chang.

Apparently I imported this together with the jquery tests by mistake.

* jquery/resources/src/sizzle/.gitmodules: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
abarth@webkit.org [Tue, 12 Mar 2013 21:54:11 +0000 (21:54 +0000)]
[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112120

Reviewed by Tony Chang.

Chromium always uses V8. This macro has outlived it's usefulness. It's
now just noise.

* README:
* public/WebArrayBuffer.h:
(WebArrayBuffer):
* public/WebArrayBufferView.h:
(WebArrayBufferView):
* public/WebBindings.h:
(WebBindings):
* public/WebBlob.h:
(WebBlob):
* public/WebFrame.h:
(WebFrame):
* public/WebFrameClient.h:
* public/WebSerializedScriptValue.h:
(WebSerializedScriptValue):
* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):
* src/WebBindings.cpp:
(WebKit::WebBindings::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
* src/WebFrameImpl.cpp:
(WebKit::WebFrame::frameForContext):
* src/WebFrameImpl.h:
(WebFrameImpl):
* src/WebSerializedScriptValue.cpp:
(WebKit::WebSerializedScriptValue::serialize):
(WebKit::WebSerializedScriptValue::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac: Incorrect rendering of <audio> controls
commit-queue@webkit.org [Tue, 12 Mar 2013 21:53:19 +0000 (21:53 +0000)]
Mac: Incorrect rendering of <audio> controls
https://bugs.webkit.org/show_bug.cgi?id=110913

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-12
Reviewed by Tony Chang.

Source/WebCore:

Covered by existing tests under media/.

* css/mediaControls.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
The timeline container and the timeline need min-width: 0 so that they can shrink if needed.
* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
The timeline container also needs flex-start to ensure that it never overlaps
the play/rewind buttons. The current-time and remaining-time displays need min-width: 0 so that the hack
in RenderMediaControls.cpp works correctly - otherwise, RenderFlexibleBox tries to use the preferred width
of the time displays, which is wrong when they try to hide themselves.

LayoutTests:

* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/controls-without-preload-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd more Checked<> tests
oliver@apple.com [Tue, 12 Mar 2013 21:51:39 +0000 (21:51 +0000)]
Add more Checked<> tests
https://bugs.webkit.org/show_bug.cgi?id=112190

Reviewed by Geoffrey Garen.

Source/WTF:

Export the CheckedState enum type

* wtf/CheckedArithmetic.h:

Tools:

Tests!

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup: Move loading complete function into callback, rather than global.
jparent@chromium.org [Tue, 12 Mar 2013 21:47:23 +0000 (21:47 +0000)]
Cleanup: Move loading complete function into callback, rather than global.
https://bugs.webkit.org/show_bug.cgi?id=112167

Reviewed by Dirk Pranke.

Stop calling global functions, pass in proper handler to Loader
constructor. Note that the callback is optional, as tests, and
some potential dashboards, do not need one.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/loader.js:
(.):
* TestResultServer/static-dashboards/loader_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Improve logging in ResourceHandleMac.mm
ap@apple.com [Tue, 12 Mar 2013 21:10:45 +0000 (21:10 +0000)]
    Improve logging in ResourceHandleMac.mm
        https://bugs.webkit.org/show_bug.cgi?id=112185

        Reviewed by Brady Eidson.

        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Removed an obsolete #if.
        (WebCore::ResourceHandle::receivedCredential):
        (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
        (WebCore::ResourceHandle::receivedCancellation):
        (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Added a FIXME.
        (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):

        * platform/network/mac/ResourceResponseMac.mm: Removed an unneeded include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CheckedArithmetic slightly more sane
oliver@apple.com [Tue, 12 Mar 2013 21:05:37 +0000 (21:05 +0000)]
Make CheckedArithmetic slightly more sane
https://bugs.webkit.org/show_bug.cgi?id=112178

Reviewed by Geoffrey Garen.

Add an enum type for safeGet rather than using a bool,
and correctly handle unsigned * unsigned, when one value
is 0.

* wtf/CheckedArithmetic.h:
(WTF::ENUM_CLASS):
(WTF):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG generic array access cases should not be guarded by CheckStructure even of the...
fpizlo@apple.com [Tue, 12 Mar 2013 20:38:26 +0000 (20:38 +0000)]
DFG generic array access cases should not be guarded by CheckStructure even of the profiling tells us that it could be
https://bugs.webkit.org/show_bug.cgi?id=112183

Reviewed by Oliver Hunt.

Slight speed-up on string-unpack-code.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::findAndRemoveUnnecessaryStructureCheck):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome canvas tests only fail on Mac EWS
rniwa@webkit.org [Tue, 12 Mar 2013 20:27:53 +0000 (20:27 +0000)]
Some canvas tests only fail on Mac EWS
https://bugs.webkit.org/show_bug.cgi?id=112176

Reviewed by Simon Fraser.

Add Failure / Pass test expectations on tests that only fail on Mac EWS bots.

Ideally, we can figure out the root cause of this failure and fix that problem but we haven't been able
to do so. We also don't have a way of adding test expectations only on EWS bots we're out of luck here.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145554.
commit-queue@webkit.org [Tue, 12 Mar 2013 20:11:58 +0000 (20:11 +0000)]
Unreviewed, rolling out r145554.
http://trac.webkit.org/changeset/145554
https://bugs.webkit.org/show_bug.cgi?id=112182

Breaks several extension browser tests (see bug for details)
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):
* bindings/v8/WrapperTypeInfo.h:
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):
* bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use lipo(1) rather than file(1) to list library architectures.
gavinp@chromium.org [Tue, 12 Mar 2013 19:43:41 +0000 (19:43 +0000)]
[chromium] Use lipo(1) rather than file(1) to list library architectures.
https://bugs.webkit.org/show_bug.cgi?id=111147

Parsing file(1) output can be fragile; this patch replaces a use of file(1) to get
the architecture list of a library with an invocation of lipo(1), which should be more
stable.

Reviewed by Nico Weber.

No new tests, since adjust_visibility.sh doesn't have a test.

* WebCore.gyp/mac/adjust_visibility.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
mifenton@rim.com [Tue, 12 Mar 2013 18:38:33 +0000 (18:38 +0000)]
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733

Reviewed by Rob Buis.

PR 305194.

Skip rendering of selection if it is in a popup driven
input field.  This covers situations where EditorClientBlackBerry::shouldChangeSelectedRange
is either not called or focus is not complete when called.

Informally reviewed by Gen Mak.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline.
rniwa@webkit.org [Tue, 12 Mar 2013 18:28:32 +0000 (18:28 +0000)]
Mac rebaseline.

Rubber-stamped by Simon Fraser.

* platform/mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebkit unable to show gifs with applcation extension string shorter than 11 bytes
commit-queue@webkit.org [Tue, 12 Mar 2013 18:27:07 +0000 (18:27 +0000)]
Webkit unable to show gifs with applcation extension string shorter than 11 bytes
https://bugs.webkit.org/show_bug.cgi?id=110620

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-03-12
Reviewed by Laszlo Gombos.

Source/WebCore:

Use actual block size for gifs application extension string even if it is below 11 bytes
to be able to decode this kind of gifs.

Test: fast/images/gif-short-app-extension-string.html

* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::decodeInternal):

LayoutTests:

Test that webkit is able to decode gifs with short application extension string.

* fast/images/gif-short-app-extension-string-expected.png: Added.
* fast/images/gif-short-app-extension-string-expected.txt: Added.
* fast/images/gif-short-app-extension-string.html: Added.
* fast/images/resources/short-app-extension-string.gif: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove unused WebIOSurfaceLayer type
commit-queue@webkit.org [Tue, 12 Mar 2013 18:26:51 +0000 (18:26 +0000)]
[chromium] Remove unused WebIOSurfaceLayer type
https://bugs.webkit.org/show_bug.cgi?id=111796

Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
Reviewed by Adrienne Walker.

This has been dead code since http://trac.webkit.org/changeset/138223

* Platform.gypi:
* chromium/public/WebCompositorSupport.h:
(WebKit):
* chromium/public/WebIOSurfaceLayer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145277.
commit-queue@webkit.org [Tue, 12 Mar 2013 18:20:02 +0000 (18:20 +0000)]
Unreviewed, rolling out r145277.
http://trac.webkit.org/changeset/145277
https://bugs.webkit.org/show_bug.cgi?id=112170

chromium-gpu and android testers are seeing failures/crashes
relating to this code (Requested by eseidel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::rewindTo):
* html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
(Checkpoint):
* html/parser/BackgroundHTMLParser.cpp:
* html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add popup menu support to MiniBrowser
ch.dumez@sisa.samsung.com [Tue, 12 Mar 2013 18:02:05 +0000 (18:02 +0000)]
[EFL][WK2] Add popup menu support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108934

Reviewed by Kenneth Rohde Christiansen.

Implement popup menu support in MiniBrowser by handling popup_menu_show
and popup_menu_hide smart functions on the view and using the Ewk popup
menu API.

* MiniBrowser/efl/main.c:
(_Browser_Window):
(on_popup_menu_discarded):
(on_popup_menu_item_clicked):
(popup_menu_populate):
(on_popup_menu_show):
(on_popup_menu_hide):
(window_create): Use calloc() instead of malloc() to allocate memory for
Browser_Window. This makes sure all the structs members are initialized
to 0 (such as the new elm_popup_menu pointer).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKeep track of the number of GraphicsLayers with tiled backing in RenderLayerCompositor
simon.fraser@apple.com [Tue, 12 Mar 2013 17:54:44 +0000 (17:54 +0000)]
Keep track of the number of GraphicsLayers with tiled backing in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=112083

Reviewed by Dean Jackson.

Have RenderLayerCompositor keep track of how many of its GraphicsLayers use TiledBacking.
This is useful for platforms to decide whether it's necessary to force GraphicsLayer flushes
to update the visibleRect of those TiledBackings.

GraphicsLayers are always created without TiledBacking. There are two
ways the count can change:
1. A GraphicsLayerCA toggles into or out of tiled mode. It notifies its
   client via a new tiledBackingUsageChanged() callback on GraphicsLayerClient.
2. A tiled GraphicsLayerCA is destroyed. Added a new bottleneck function to
   RenderLayerBacking::willDestroyLayer() that is called everywhere we destroy layers.

The main page TiledBacking is not counted as part of this.

Also renamed uses of "tiledLayer" to "tiledBacking" in GraphicsLayer[CA].

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::getDebugBorderInfo):
(WebCore::GraphicsLayer::dumpProperties):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::usingTiledBacking):
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::tiledBackingUsageChanged):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::willDestroyLayer):
(WebCore::RenderLayerBacking::tiledBackingUsageChanged):
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateBackgroundLayer):
(WebCore::RenderLayerBacking::updateMaskLayer):
(WebCore::RenderLayerBacking::updateScrollingLayers):
(WebCore::RenderLayerBacking::compositingLayerType):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::layerTiledBackingUsageChanged):
* rendering/RenderLayerCompositor.h:
(WebCore::RenderLayerCompositor::haveNonMainLayersWithTiledBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace static_casts with to* functions.
inferno@chromium.org [Tue, 12 Mar 2013 17:44:37 +0000 (17:44 +0000)]
Replace static_casts with to* functions.
https://bugs.webkit.org/show_bug.cgi?id=112072

Reviewed by Philip Rogers.

to* functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
* bindings/objc/DOM.mm:
(kitClass):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/FormatBlockCommand.cpp:
(WebCore::isElementForFormatBlock):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isMailPasteAsQuotationNode):
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestions):
* html/HTMLTableRowsCollection.cpp:
(WebCore::isInHead):
(WebCore::isInBody):
(WebCore::isInFoot):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
* page/PageSerializer.cpp:
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
* plugins/PluginView.cpp:
(WebCore::PluginView::getValue):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::mediaElement):
* rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::autosaveName):
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement):
(WebCore::updateUserModifyProperty):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::updateFromElement):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::focusedNodeChanged):
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/DOMUtilitiesPrivate.cpp:
(WebCore::toHTMLElement):
* src/WebSearchableFormData.cpp:
(HTMLNames::IsSelectInDefaultState):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _enterFullscreenForNode:WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove HILDON_CPPFLAGS and HILDON_CFLAGS references from GNUmakefiles
zandobersek@gmail.com [Tue, 12 Mar 2013 17:42:28 +0000 (17:42 +0000)]
[GTK] Remove HILDON_CPPFLAGS and HILDON_CFLAGS references from GNUmakefiles
https://bugs.webkit.org/show_bug.cgi?id=112163

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - no new functionality, merely a cleanup.

* GNUmakefile.am: The Hildon dependency doesn't exist anymore so there's no need for
references to HILDON_CPPFLAGS and HILDON_CFLAGS.

Source/WebKit2:

* GNUmakefile.am: The Hildon dependency doesn't exist anymore so there's no need for
references to HILDON_CPPFLAGS and HILDON_CFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] 'unrecognized command line option "-Wno-c++11-extensions"' warning reported...
zandobersek@gmail.com [Tue, 12 Mar 2013 17:40:40 +0000 (17:40 +0000)]
[GTK] 'unrecognized command line option "-Wno-c++11-extensions"' warning reported when using gcc
https://bugs.webkit.org/show_bug.cgi?id=111936

Reviewed by Martin Robinson.

* Source/autotools/SetupCompilerFlags.m4: Only use the -Wno-c++11-extensions warning when building
with Clang as GCC does not support the warning just yet. Also enhance the comment about using libstdc++
as the standard C++ library when compiling with Clang.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: removing GtkVersioning from chromium targets.
pfeldman@chromium.org [Tue, 12 Mar 2013 17:26:13 +0000 (17:26 +0000)]
Not reviewed: removing GtkVersioning from chromium targets.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Tue, 12 Mar 2013 17:00:13 +0000 (17:00 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for two crashers and a flaky test.
* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145526.
* platform/gtk/http/tests/security/xssAuditor: Added. Adding baselines for tests introduced in r145503.
* platform/gtk/http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt: Added.
* platform/gtk/http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Store main world and non-main world templates separately.
commit-queue@webkit.org [Tue, 12 Mar 2013 16:44:18 +0000 (16:44 +0000)]
[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

No new tests (updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):
* bindings/v8/V8GCController.cpp:
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):
* bindings/v8/WrapperTypeInfo.h:
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Notify client if the selection is in a subframe when started.
commit-queue@webkit.org [Tue, 12 Mar 2013 15:57:01 +0000 (15:57 +0000)]
[BlackBerry] Notify client if the selection is in a subframe when started.
https://bugs.webkit.org/show_bug.cgi?id=112065

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-12
Reviewed by Rob Buis.

PR #278490
Internally Reviewed by Mike Fenton.

* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
(WebKit):
* Api/InRegionScroller_p.h:
(InRegionScrollerPrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateSelectionScrollView):
(WebKit):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Set up the libPlatformGtk.la library
zandobersek@gmail.com [Tue, 12 Mar 2013 15:54:34 +0000 (15:54 +0000)]
[GTK] Set up the libPlatformGtk.la library
https://bugs.webkit.org/show_bug.cgi?id=111738

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Define the two variables that will hold sources list and cppflags as required for the new library.
Include the new GNUmakefile.am that's now available under Source/Platform.

Source/Platform:

* GNUmakefile.am: Added. Set up the rules for building the new libPlatformGtk.la. For now it will be built in
the same way as libWebCoreGtk.la and in parallel with it while the sources are moved from Source/WebCore/platform
to Source/Platform/gtk and each migrated source file moves to be built in libPlatformGtk.la instead of libWebCoreGtk.la.
* GNUmakefile.list.am: Added. Lists the build targets for the libPlatformGtk.la.
* gtk/GtkVersioning.c: Renamed from Source/WebCore/platform/gtk/GtkVersioning.c. This file is independent of WebCore and can be moved
and changed to be built into libPlatformGtk.la right away.
* gtk/GtkVersioning.h: Renamed from Source/WebCore/platform/gtk/GtkVersioning.h. Ditto.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.am: Reference platformgtk_cppflags, platformgtk_sources variables along with webcoregtk_cppflags, webcoregtk_sources variables.
* GNUmakefile.list.am: Removing GtkVersioning.c and GtkVersioning.h from the sources list, these files have been moved under Source/Platform.
* bindings/gobject/GNUmakefile.am: Ditto on the platformgtk_* variables.

Source/WebKit/gtk:

* GNUmakefile.am: Reference platformgtk_cppflags variable, libPlatformGtk.la along with webcoregtk_cppflags variable, libWebCoreGtk.la.
Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.

Source/WebKit2:

* GNUmakefile.am: Reference platformgtk_cppflags variable, libPlatformGtk.la along with webcoregtk_cppflags variable, libWebCoreGtk.la.
Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.

Tools:

* GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
* TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=112141
rgabor@webkit.org [Tue, 12 Mar 2013 15:28:10 +0000 (15:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=112141
LLInt CLoop backend misses Double2Ints() on 32bit architectures

Reviewed by Filip Pizlo.

Implement Double2Ints() in CLoop backend of LLInt on 32bit architectures.

* llint/LowLevelInterpreter.cpp:
(LLInt):
(JSC::LLInt::Double2Ints):
* offlineasm/cloop.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Image,ImageBuffer: add missing parameters to methods
commit-queue@webkit.org [Tue, 12 Mar 2013 15:23:08 +0000 (15:23 +0000)]
[BlackBerry] Image,ImageBuffer: add missing parameters to methods
https://bugs.webkit.org/show_bug.cgi?id=112148

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

BitmapImage::draw(), Image::drawPattern() and ImageBuffer::draw()
have a BlendMode parameter since r137011.

ImageBuffer::copyImage() has a ScaleBehavior parameter since r134100.

* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] MediaPlayerPrivate: fix call to MediaStreamDescriptor::label()
commit-queue@webkit.org [Tue, 12 Mar 2013 15:21:16 +0000 (15:21 +0000)]
[BlackBerry] MediaPlayerPrivate: fix call to MediaStreamDescriptor::label()
https://bugs.webkit.org/show_bug.cgi?id=112140

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

MediaStreamDescriptor::id() was renamed to MediaStreamDescriptor::label() in r139352.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::toWebMediaStreamDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle...
eustas@chromium.org [Tue, 12 Mar 2013 15:19:37 +0000 (15:19 +0000)]
Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state
https://bugs.webkit.org/show_bug.cgi?id=112113

Reviewed by Alexander Pavlov.

Updated handlers missed in first patch. Added JSDocs to all handlers.

* inspector/front-end/Panel.js: Fixed JSDocs.
* inspector/front-end/CallStackSidebarPane.js:
Added return values. Added JSDocs.
* inspector/front-end/ScriptsPanel.js: Ditto.
* inspector/front-end/GoToLineDialog.js: Added JSDocs.
* inspector/front-end/TimelinePanel.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] DisplayRefreshMonitor: rename m_timestamp back to m_monotonicAnimationSt...
commit-queue@webkit.org [Tue, 12 Mar 2013 15:17:58 +0000 (15:17 +0000)]
[BlackBerry] DisplayRefreshMonitor: rename m_timestamp back to m_monotonicAnimationStartTime
https://bugs.webkit.org/show_bug.cgi?id=112139

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

This changed in r131131, but it was accidentally renamed back in r144465.

* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FontPlatformData: HarfBuzz renaming
commit-queue@webkit.org [Tue, 12 Mar 2013 15:16:03 +0000 (15:16 +0000)]
[BlackBerry] FontPlatformData: HarfBuzz renaming
https://bugs.webkit.org/show_bug.cgi?id=112142

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

When the old HarfBuzz code was removed in r141291,
HarfBuzzNGFace.h was renamed to HarfBuzzFace.h and m_harfbuzzFace
was renamed to m_harfBuzzFace.

These changes need to be reflected in the BlackBerry port.

* platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::harfBuzzFace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Tue, 12 Mar 2013 15:06:41 +0000 (15:06 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/TestExpectations: Skipped two fullscreen tests after r144837 and r145214.
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Updated after r145422.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Updated after r145422.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Updated after r145422.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Updated after r145422.
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Updated after r145422.
* platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Updated after r145422.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] FontCacheBlackBerry: return PassRefPtr<SimpleFontData>
commit-queue@webkit.org [Tue, 12 Mar 2013 15:00:04 +0000 (15:00 +0000)]
[BlackBerry] FontCacheBlackBerry: return PassRefPtr<SimpleFontData>
https://bugs.webkit.org/show_bug.cgi?id=112022

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

FontData functions return PassRefPtr since r130160.

* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
* platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::createScaledFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix checkContentUpdated behavior in UISourceCode.
vsevik@chromium.org [Tue, 12 Mar 2013 14:53:30 +0000 (14:53 +0000)]
Web Inspector: Fix checkContentUpdated behavior in UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=112037

Reviewed by Alexander Pavlov.

UISourceCode.checkContentUpdated now saves last updated content that was loaded and rejected
by user on the per-file basis (only the last one was saved currently).

* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.canSetFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.canSetFileContent):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.checkContentUpdated.contentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.addRevision):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
* inspector/front-end/Workspace.js:
(WebInspector.ProjectDelegate.prototype.canSetFileContent):
(WebInspector.Project.prototype.canSetFileContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] NBSP are not replaced when using X clipboard
commit-queue@webkit.org [Tue, 12 Mar 2013 14:51:19 +0000 (14:51 +0000)]
[Gtk] NBSP are not replaced when using X clipboard
https://bugs.webkit.org/show_bug.cgi?id=112118

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-12
Reviewed by Martin Robinson.

We're not replacing nbsp with spaces when using X clipboard
(Shift+Insert or middle mouse button).

* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSVG Pattern pixelated on inline SVG with CSS transforms
fmalita@chromium.org [Tue, 12 Mar 2013 14:38:48 +0000 (14:38 +0000)]
SVG Pattern pixelated on inline SVG with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=111587

Reviewed by Dirk Schulze.

Source/WebCore:

When calculating the resolution for resource image buffers, we need to also consider CSS
transforms. This patch updates calculateTransformationToOutermostSVGCoordinateSystem()
(renamed to calculateTransformationToOutermostCoordinateSystem) to include the affine
component from CSS transforms by walking the parent layer tree.

Test: svg/custom/resources-css-scaled.html

* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor):
(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):
* rendering/svg/SVGRenderingContext.h:
(SVGRenderingContext):

LayoutTests:

* svg/custom/resources-css-scaled-expected.html: Added.
* svg/custom/resources-css-scaled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add html canvas memory details to the native memory overview
yurys@chromium.org [Tue, 12 Mar 2013 14:35:33 +0000 (14:35 +0000)]
Web Inspector: add html canvas memory details to the native memory overview
https://bugs.webkit.org/show_bug.cgi?id=112123

Reviewed by Alexander Pavlov.

Show memory occupied vby HTMLCanvasElements under Image category
in the native memory overview.

* inspector/front-end/NativeHeapSnapshot.js:
(WebInspector.NativeHeapSnapshot.prototype.images.getImageName):
(WebInspector.NativeHeapSnapshot.prototype.images.getCanvasName):
(WebInspector.NativeHeapSnapshot.prototype.images):
(WebInspector.NativeHeapSnapshot.prototype._addNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: ResourceScriptFile diverged state should be correctly reset after...
vsevik@chromium.org [Tue, 12 Mar 2013 13:10:40 +0000 (13:10 +0000)]
Web Inspector: ResourceScriptFile diverged state should be correctly reset after debugger reset.
https://bugs.webkit.org/show_bug.cgi?id=112036

Reviewed by Alexander Pavlov.

Source/WebCore:

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._maybeDirtyChanged):

LayoutTests:

* inspector/debugger/file-system-project-mapping-expected.txt:
* inspector/debugger/file-system-project-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Move the GetRawTemplate and HasInstance logic from generated bindings to V8PerIs...
commit-queue@webkit.org [Tue, 12 Mar 2013 13:02:05 +0000 (13:02 +0000)]
[V8] Move the GetRawTemplate and HasInstance logic from generated bindings to V8PerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=112136

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Kentaro Hara.

When templates for main world and non-main worlds will be separated (bug
111724), HasInstance logic will be a bit ugly: We cannot determine the
world type on the fly, because during GC there is no entered context,
and HasInstance is called during GC. So we need to check against
templates from all the worlds. It's cleaner if that logic is in
V8PerIsolateData.

No new tests (Updated existing bindings tests).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
* bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore):
(WebCore::V8PerIsolateData::hasInstance):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix JSDocs in TimelinePanel.js
eustas@chromium.org [Tue, 12 Mar 2013 12:45:30 +0000 (12:45 +0000)]
Web Inspector: Fix JSDocs in TimelinePanel.js
https://bugs.webkit.org/show_bug.cgi?id=112137

Reviewed by Vsevolod Vlasov.

Fix parameter type annotation of _loadFromFile.

* inspector/front-end/TimelinePanel.js: Fixed JSDoc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add a test for Workspace add/removeMapping methods.
vsevik@chromium.org [Tue, 12 Mar 2013 12:42:14 +0000 (12:42 +0000)]
Web Inspector: Add a test for Workspace add/removeMapping methods.
https://bugs.webkit.org/show_bug.cgi?id=112035

Reviewed by Alexander Pavlov.

Source/WebCore:

Test: inspector/debugger/file-system-project-mapping.html

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork.mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem.mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem):
* inspector/front-end/Workspace.js:
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Workspace.prototype.addMapping):

LayoutTests:

* http/tests/inspector/isolated-filesystem-test.js: Added.
(initialize_IsolatedFileSystemTest.InspectorTest.createIsolatedFileSystemManager):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.path):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.requestFileContent):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.setFileContent):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.requestFilesRecursive):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager.prototype.addMockFileSystem):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager.prototype.removeMockFileSystem):
(initialize_IsolatedFileSystemTest):
* inspector/debugger/file-system-project-mapping-expected.txt: Added.
* inspector/debugger/file-system-project-mapping.html: Added.
* inspector/debugger/resource-script-mapping.html:
* inspector/file-system-project.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Fix EwkContext class API
mikhail.pozdnyakov@intel.com [Tue, 12 Mar 2013 12:32:37 +0000 (12:32 +0000)]
[WK2][EFL] Fix EwkContext class API
https://bugs.webkit.org/show_bug.cgi?id=111706

Reviewed by Alexey Proskuryakov.

* UIProcess/API/C/efl/WKView.cpp:
(createWKView):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::findOrCreateWrapper):

    Renamed from create() as it returns the same instance of EwkContext
    for the given WKContextRef if present.

(EwkContext::create):
(EwkContext::defaultContext):

    Returns raw pointer rather than PassRefPtr<EwkContext> as ownership
    is not transferred.

(ewk_context_default_get):
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] SelectionHandler: fix truncated line
commit-queue@webkit.org [Tue, 12 Mar 2013 12:29:32 +0000 (12:29 +0000)]
[BlackBerry] SelectionHandler: fix truncated line
https://bugs.webkit.org/show_bug.cgi?id=112133

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Carlos Garcia Campos.

One of the calls to fatFingersResult.nodeAsElementIfApplicable()
was somehow truncated when the selection start animation was
upstreamed in r144640.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: SourceFrames are leaking on reload.
vsevik@chromium.org [Tue, 12 Mar 2013 12:29:03 +0000 (12:29 +0000)]
Web Inspector: SourceFrames are leaking on reload.
https://bugs.webkit.org/show_bug.cgi?id=111961

Reviewed by Alexander Pavlov.

Source/WebCore:

Added dispose method on UISourceCodeFrame.
Scripts panel now calls dispose when SourceFrame is removed and JavaScriptSourceFrame
could remove breakpoint manager listeners in it.
TabbedEditorContainer does not call viewForFile other than in appendFileTab methods to
avoid recreating SourceFrame for uiSourceCode when it was already removed.

Test: inspector/debugger/breakpoint-manager-listeners-count.html

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.dispose):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._addScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._removeScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.dispose):

LayoutTests:

* inspector/debugger/breakpoint-manager-listeners-count-expected.txt: Added.
* inspector/debugger/breakpoint-manager-listeners-count.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Elements] Unable to undo "Edit as HTML" changes in the editor
apavlov@chromium.org [Tue, 12 Mar 2013 12:23:41 +0000 (12:23 +0000)]
Web Inspector: [Elements] Unable to undo "Edit as HTML" changes in the editor
https://bugs.webkit.org/show_bug.cgi?id=112119

Reviewed by Vsevolod Vlasov.

No new tests, a UI change.

* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleShortcut): Do not undo/redo DOM/CSS changes if editing DOM text.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline.prototype.editing): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] there are bugs in TokenHighlight feature
commit-queue@webkit.org [Tue, 12 Mar 2013 12:15:21 +0000 (12:15 +0000)]
Web Inspector: [CodeMirror] there are bugs in TokenHighlight feature
https://bugs.webkit.org/show_bug.cgi?id=112039

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-12
Reviewed by Vsevolod Vlasov.

Fix token highlight in codeMirror experiment
- rewrite token highlight overlay mode to highlight words, not
substrings
- add workaround to avoid selection of already selected word

No new tests.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._cursorChange):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._removeHighlight):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype.nextToken):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._addHighlight):
* inspector/front-end/cm/cmdevtools.css:
(.line-with-selection .cm-column-with-selection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix visible_units.h includes
commit-queue@webkit.org [Tue, 12 Mar 2013 12:11:58 +0000 (12:11 +0000)]
[BlackBerry] Fix visible_units.h includes
https://bugs.webkit.org/show_bug.cgi?id=112131

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Carlos Garcia Campos.

This file was renamed to VisibleUnits.h in r144911.

* WebKitSupport/DOMSupport.cpp:
* WebKitSupport/InputHandler.cpp:
* WebKitSupport/SelectionHandler.cpp:
* WebKitSupport/SpellingHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable Web Audio in development builds
zandobersek@gmail.com [Tue, 12 Mar 2013 11:56:13 +0000 (11:56 +0000)]
[GTK] Enable Web Audio in development builds
https://bugs.webkit.org/show_bug.cgi?id=111831

Reviewed by Philippe Normand.

Source/WebKit2:

* GNUmakefile.am: Link the plugin process against libWebCoreModules.la as well.

Tools:

Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r145514.
falken@chromium.org [Tue, 12 Mar 2013 11:38:57 +0000 (11:38 +0000)]
Unreviewed, rolling out r145514.
http://trac.webkit.org/changeset/145514
https://bugs.webkit.org/show_bug.cgi?id=112134

breaks Mac build (Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

* dom/Element.cpp:
* dom/Element.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
* dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/Node.cpp:
(WebCore):
(WebCore::Node::isInert):
(WebCore::Node::handleLocalEvents):
(WebCore::Node::disabled):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
* dom/Node.h:
(Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
commit-queue@webkit.org [Tue, 12 Mar 2013 11:26:44 +0000 (11:26 +0000)]
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=112130

Gardening; assigning bug numbers to failure accessibility tests.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-12

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [CodeMirror] highlight matching braces
commit-queue@webkit.org [Tue, 12 Mar 2013 11:18:54 +0000 (11:18 +0000)]
Web Inspector: [CodeMirror] highlight matching braces
https://bugs.webkit.org/show_bug.cgi?id=112041

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-12
Reviewed by Vsevolod Vlasov.

Add "matchbrackets" add-on to CodeMirror text editor add override
default styles for matched and unmatched braces.

No new tests.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/cm/cmdevtools.css:
(.CodeMirror-matchingbracket):
(.CodeMirror-nonmatchingbracket):
* inspector/front-end/cm/matchbrackets.js: Added.
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Layer QtDownloadManager on the C API
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:18:29 +0000 (11:18 +0000)]
[Qt][WK2] Layer QtDownloadManager on the C API
https://bugs.webkit.org/show_bug.cgi?id=109562

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

* UIProcess/API/cpp/qt/WKURLQt.cpp:
(WebKit::adoptToQString):
(WebKit):
(WebKit::adoptToQUrl):
* UIProcess/API/cpp/qt/WKURLQt.h:
(WebKit):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::handleDownloadRequest):
* UIProcess/qt/QtDownloadManager.cpp:
(WebKit::toQtDownloadManager):
(WebKit):
(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload):
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):
* UIProcess/qt/QtDownloadManager.h:
(WebKit):
(QtDownloadManager):
* UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::QtWebContext):
* UIProcess/qt/QtWebError.cpp:
(WebKit::QtWebError::url):
(WebKit::QtWebError::description):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Layer QtWebIconDatabaseClient on the C API
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:17:19 +0000 (11:17 +0000)]
[Qt][WK2] Layer QtWebIconDatabaseClient on the C API
https://bugs.webkit.org/show_bug.cgi?id=109564

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

* Target.pri:
* UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Added.
(WKIconDatabaseTryGetQImageForURL):
  - New API added to get a QImage from the IconDatabase.
    Based on WKIconDatabaseCG.h/cpp
* UIProcess/API/C/qt/WKIconDatabaseQt.h: Added.
* UIProcess/API/cpp/qt/WKURLQt.cpp:
(WKURLCreateWithQString):
(WKURLCopyQString):
(WKURLCreateWithQUrl):
(WKURLCopyQUrl):
  - The WKUrlRef behind the scene is a WTF::String and encoding it back and forth to
    a QUrl can slightly change its string representation. Allow converting a WKUrlRef
    to and from a QString to ensure this.
* UIProcess/API/cpp/qt/WKURLQt.h:
* UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::iconURLForPageURLInContext):
  - The icon URL isn't accessible form the C API and shouldn't need to be.
    Use an ID incremented on each update to trigger an update of the QML Image component.
(QWebIconImageProvider::requestImage):
  - The IconDatabase was previously assumed to resize the image to the requested size,
    but this parameter is ignored, as stated in a comment in WebIconDatabase::imageForPageURL.
    Explicitely do the resize after fetching the original icon to also be able to report
    the original size properly to QtQuick.
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
  - Set the image to load asynchronously to further test the possibility of threading issues
    in QtWebIconDatabaseClient::iconImageForPageURL
  - Add a few barriers to fix some issues where the load succeeded signal would be wrongly
    catched by init() before the next test.
* UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::QtWebContext):
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit):
(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(WebKit::QtWebIconDatabaseClient::~QtWebIconDatabaseClient):
(WebKit::QtWebIconDatabaseClient::updateID):
(WebKit::QtWebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):
  - Remove the Mutex. This mutex was useless given that it would only
    be locked from a single thread. Since the IconDatabase runs in its own thread,
    it already is thread-safe to access.
(WebKit::QtWebIconDatabaseClient::retainIconForPageURL):
(WebKit::QtWebIconDatabaseClient::releaseIconForPageURL):
* UIProcess/qt/QtWebIconDatabaseClient.h:
(QtWebIconDatabaseClient):
* WebKit2.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Specify storage paths through the C API
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:16:01 +0000 (11:16 +0000)]
[Qt][WK2] Specify storage paths through the C API
https://bugs.webkit.org/show_bug.cgi?id=111435

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

The WKIconDatabase should be opened through a call to
WKContextSetIconDatabasePath. To avoid having some paths
returned through WebContext::platformDefault* and some others
through the C API, make sure that all those paths are set
through the C API.

* Shared/qt/QtDefaultDataLocation.cpp: Removed.
* Shared/qt/QtDefaultDataLocation.h: Removed.
* Target.pri:
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::cacheFile):
  - This part is left alone behind the C API.
    Since PluginProcessProxy have no knowledge of the WebContext
    it is rather difficult to fetch a configured directory that
    could be used for this purpose (like the disk cache storage).
    Hard-code a compatible logic to keep the current behavior.
(WebKit::removeCacheFile):
(WebKit):
(WebKit::readMetaDataFromCacheFile):
(WebKit::writeToCacheFile):
(WebKit::tryReadPluginMetaDataFromCacheFile):
  - Update the code to better handle an empty cache file path.
* UIProcess/qt/QtWebContext.cpp:
(WebKit::QtWebContext::defaultContext):
(WebKit::defaultLocation):
(WebKit):
(WebKit::QtWebContext::preparedStoragePath):
* UIProcess/qt/QtWebContext.h:
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Properly layer QtWebContext on top of the C API
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:14:42 +0000 (11:14 +0000)]
[Qt] Properly layer QtWebContext on top of the C API
https://bugs.webkit.org/show_bug.cgi?id=108475

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
* UIProcess/qt/QtWebContext.cpp:
(WebKit::initializeContextInjectedBundleClient):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
* UIProcess/qt/QtWebContext.h:
(WebKit):
(QtWebContext):
(WebKit::QtWebContext::context):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Allow QtWebContext to call directly to QQuickWebView with a WKPageRef
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:13:31 +0000 (11:13 +0000)]
[Qt][WK2] Allow QtWebContext to call directly to QQuickWebView with a WKPageRef
https://bugs.webkit.org/show_bug.cgi?id=109829

Reviewed by Allan Sandfeld Jensen.
Signed off for WebKit2 by Benjamin Poulain.

Instead of going through WebPageProxy and PageClient to forward
injected bundle messages received by the context, maintain a static map
of WKPageRef to QQuickWebViewPrivate.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::get):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didReceiveMessageFromNavigatorQtObject):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
* UIProcess/PageClient.h:
(PageClient):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/qt/QtPageClient.cpp:
* UIProcess/qt/QtPageClient.h:
(QtPageClient):
* UIProcess/qt/QtWebContext.cpp:
(WebKit::didReceiveMessageFromInjectedBundle):
* UIProcess/qt/WebPageProxyQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Pull Node::disabled() and Node::isInert() down to Element.
falken@chromium.org [Tue, 12 Mar 2013 11:13:02 +0000 (11:13 +0000)]
Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods.

No new tests, just refactoring.

* dom/Element.cpp:
(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):
* dom/Element.h:
(Element):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
* dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
* dom/Node.h:
(Node):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Keep the WebContext alive during the whole application's lifetime
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:12:28 +0000 (11:12 +0000)]
[Qt][WK2] Keep the WebContext alive during the whole application's lifetime
https://bugs.webkit.org/show_bug.cgi?id=109827

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

The lifetime of the WebContext is difficult to manage because of a circular
reference kept with the WebProcessProxy until it shuts itself down, 60
seconds after the last page is closed. There was some notification
in place to handle this in the upper layer, but having to go through the
C API (done in a following patch) makes this quite awkward.

Keeping the WebContext alive also includes the icon database which is
quite heavy, in the future we should only enable it once the
QQuickWebView::icon property is read.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleDownloadRequest):
(QQuickWebViewPrivate::updateIcon):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::requestImage):
* UIProcess/qt/QtWebContext.cpp:
(WebKit):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):
* UIProcess/qt/QtWebContext.h:
(QtWebContext):
(WebKit::QtWebContext::downloadManager):
(WebKit::QtWebContext::iconDatabase):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInvalidateContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Favor QUrl and QString over WTF::String in the Qt API layer
jocelyn.turcotte@digia.com [Tue, 12 Mar 2013 11:11:14 +0000 (11:11 +0000)]
[Qt][WK2] Favor QUrl and QString over WTF::String in the Qt API layer
https://bugs.webkit.org/show_bug.cgi?id=109468

Reviewed by Allan Sandfeld Jensen.
Signed off for WebKit2 by Benjamin Poulain.

In preparation for patches using the C API types in some areas, remove the
usage of WTF::String on the affected line.

Use a QUrl for icon URL to avoid unnecessary conversion.
Use a QString for the page URL to keep it compatible with WebPageProxy and
WebIconDatabase and avoid QUrl parsing.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::_q_onIconChangedForPageURL):
(QQuickWebViewPrivate::updateIcon):
(QQuickWebView::emitUrlChangeIfNeeded):
(QQuickWebView::icon):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebiconimageprovider.cpp:
(QWebIconImageProvider::iconURLForPageURLInContext):
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/qt/QtWebIconDatabaseClient.cpp:
(WebKit::QtWebIconDatabaseClient::iconForPageURL):
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):
(WebKit::QtWebIconDatabaseClient::retainIconForPageURL):
(WebKit::QtWebIconDatabaseClient::releaseIconForPageURL):
* UIProcess/qt/QtWebIconDatabaseClient.h:
(QtWebIconDatabaseClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Get rid of function-level static FunctionTemplates in generated bindings code
commit-queue@webkit.org [Tue, 12 Mar 2013 10:47:11 +0000 (10:47 +0000)]
[V8] Get rid of function-level static FunctionTemplates in generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=111971

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Jochen Eisinger.

In the future we'll create and store function templates for main world
and non-main worlds separately (see bug 111724), having function
templates as static variables inside functions will break the
functionality.

No new tests (updated the bindings test expectations).

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Implement RuleCollector
tasak@google.com [Tue, 12 Mar 2013 10:14:53 +0000 (10:14 +0000)]
[Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916

Reviewed by Antti Koivisto.

Implemented rule collector for an element and collector for a page.
Not all members in class State are required entire while resolving
a style.

No new tests, because just refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
Added ElementRuleCollector and PageRuleCollector.
* css/DocumentRuleSets.cpp:
(WebCore::ShadowDistributedRules::collectMatchRequests):
Since behaviorAtBoundary is a state owned by ElementRuleCollector,
removed from here.
* css/DocumentRuleSets.h:
(WebCore::ShadowDistributedRules::isEmpty):
Added to quickly check whether there exist any ShadowDistributedRules
or not.
* css/ElementRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore):
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::ensureRuleList):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
(WebCore::ElementRuleCollector::matchHostRules):
(WebCore::ElementRuleCollector::matchShadowDistributedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
Moved these methods from StyleResolver to this class.
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
This method is used for checking whether a given element can share
a cache.
* css/ElementRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::ElementRuleCollector::ElementRuleCollector):
Use styleResolver instance to initialize its member variables, i.e.
SelectorFilter, RuleSets, InspectorCSSOMWrappers, and
StyleScopedResolver.
(ElementRuleCollector):
(WebCore::ElementRuleCollector::setMode):
(WebCore::ElementRuleCollector::setPseudoStyleRequest):
(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling):
Mode, SameOriginOnly, RegionForStyling are only used while collecting
matched rules.
(WebCore::ElementRuleCollector::setMedium):
Need to know which default stylesheet should be looked up.
(WebCore::ElementRuleCollector::document):
* css/PageRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.
(WebCore::comparePageRules):
(WebCore::PageRuleCollector::isLeftPage):
(WebCore::PageRuleCollector::isFirstPage):
(WebCore::PageRuleCollector::pageName):
(WebCore::PageRuleCollector::matchAllPageRules):
(WebCore::PageRuleCollector::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::PageRuleCollector::matchPageRulesForList):
Moved from StyleResolver.
* css/PageRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.
(WebCore):
(WebCore::PageRuleCollector::PageRuleCollector):
(PageRuleCollector):
(WebCore::PageRuleCollector::matchedResult):
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):
* css/StyleResolver.h:
(WebCore::MatchRequest::MatchRequest):
Removed behaviorAtBoundary. Instead, ElementRuleCollector have the
state.
(MatchRequest):
(WebCore::StyleResolver::selectorFilter):
Added to obtain SelectorFilter in ElementRuleCollector's constructor.
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
To pass ASSERT in StyleResolver::applyProperties, need to keep
m_regionForStyling.
(State):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::hasSelectorForId):
(WebCore):
(WebCore::checkRegionSelector):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
Removed StyleResolver from its parameter list. Instead, added
InspectorCSSOMWrappers and DocumentStyleSheetCollection.
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145510 268f45cc-cd09-0410-ab3c-d52691b4dbfc