2009-08-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Remove keyring optional features
        https://bugs.webkit.org/show_bug.cgi?id=28173

        Remove keyring support, we now do authentication storage through
        libsoup. We depend on libsoup master now, will bump the dependency
        when there's a new release.

        * GNUmakefile.am:
        * configure.ac:

WebKit/gtk:

2009-08-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        [GTK] Remove keyring optional features
        https://bugs.webkit.org/show_bug.cgi?id=28173

        Remove keyring support from our code and rely on libsoup to store
        the authentication data if the user requests that support in their
        application/library.

        * webkit/webkitsoupauthdialog.c:
        (response_callback):
        (show_auth_dialog):
        (session_authenticate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Eric Seidel  <eric@webkit.org>

        No review, just skipping tests to make the bots green.

        REGRESSION (r47110): 4 media regressions on the bots
        https://bugs.webkit.org/show_bug.cgi?id=28221

        Skipping these until Eric Carlson has a fix.

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27965
Merge wx/ImageSourceWx.cpp into ImageSource.cpp.  No changes to
ImageSource.cpp were needed, so this just deletes ImageSourceWx.cpp.

Reviewed by Adam Treat.

* WebCore.gypi:
* WebCoreSources.bkl:
* platform/graphics/wx/ImageSourceWx.cpp: Removed.
* webcore-wx.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27933
Build fix after r47099.

Reviewed by Dave Levin.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::getImageData):
(WebCore::putImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

wx waf build fix, add new directories to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

wxPython build fix, the SWIG defines must also be available when compiling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Bug 28219: platform/mac/accessibility/string-range-contains-listmarker.html fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=28219

Reviewed by Eric Seidel.

* platform/mac-snowleopard/Skipped:
* platform/mac/accessibility/string-range-contains-listmarker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove support for a window resizer within the WebView

WebKit/win:

Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.

Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView

Reviewed by Dave Hyatt.

* Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::windowResizerRect): Now always returns an empty
rect.

* WebView.cpp:
(WebView::paint):
(WebView::handleMouseEvent):
* WebView.h:
Removed window-resizer-related code.

WebKitTools:

Update DumpRenderTree for IWebUIDelegatePrivate changes

Reviewed by Dave Hyatt.

* DumpRenderTree/win/UIDelegate.h: Updated to match
IWebUIDelegatePrivate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Don't try to seek to the end of stdin on Cygwin

Doing so seems to always cause an exception (for unknown reasons).

Fixes <http://webkit.org/b/28159> create-bug throws an exception in
Cygwin

Reviewed by Dave Kilzer.

* Scripts/bugzilla-tool:
(CreateBug.prompt_for_bug_title_and_comments): Ignore IOErrors
generated by calling sys.stdin.seek, since these seem to be generated
for no good reason on Cygwin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Don't raise an exception when --cc is not passed to create-bug

Fixes <http://webkit.org/b/28158> create-bug throws an exception if
--cc is not specified

Reviewed by Dave Kilzer.

* Scripts/modules/bugzilla.py:
(Bugzilla.create_bug_with_patch): Only set the "cc" field if a CC
string was specified. Otherwise we'll generate an exception about the
"cc" variable not being a string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Reviewed by Eric Seidel.

Have ObjC delegate methods match C++ method names in the ChromeClient.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::formDidFocus):
(WebChromeClient::formDidBlur):
* WebView/WebUIDelegatePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WINCE PORT: Implement Path for WINCE. Most code can be
reused for other ports that don't have native path support
https://bugs.webkit.org/show_bug.cgi?id=28188

Patch by Yong Li <yong.li@torchmobile.com> on 2009-08-08
Reviewed by Adam Treat.

Written also by George Staikos (including quadCurve() and bezier())

* platform/graphics/wince/PathWince.cpp: Added.
* platform/graphics/wince/PlatformPathWince.cpp: Added.
* platform/graphics/wince/PlatformPathWince.h: Added.
* platform/graphics/wince/WinceGraphicsExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Windows build fix.

        * WebCoreLocalizedStrings.cpp:
        (WebCore::localizedMediaTimeDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Joseph Pecoraro  <joepeck02@gmail.com>

        "Double-click to add" new style button does not always show up [quick fix]
        https://bugs.webkit.org/show_bug.cgi?id=28187

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Crystal Zhang <crystal.zhang@torchmobile.com>

        Reviewed by George Staikos.

        WINCE PORT: MediaPlayerProxy and MediaPlayerPrivate
        https://bugs.webkit.org/show_bug.cgi?id=28178

        * platform/graphics/wince/MediaPlayerPrivateWince.h: Added.
        * platform/graphics/wince/MediaPlayerProxy.cpp: Added.
        * platform/graphics/wince/MediaPlayerProxy.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        HTML 5 database and LocalStorage is not persistent on the Symbian port of QtWebKit
        https://bugs.webkit.org/show_bug.cgi?id=28175

        Call QDir::toNativeSeparators() before the path is passed to the OS.

        Based on work by David Leong.

        * platform/qt/FileSystemQt.cpp:
        (WebCore::pathByAppendingComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Tiger build fix.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
            Define NSAccessibilityTimelineSubrole for Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Ariya Hidayat.

        Minor build-fix for SVG Filter. Use getUnmultipliedImageData instead
        of getImageData. This changed since r47099.

        * platform/graphics/filters/FEColorMatrix.cpp:
        (WebCore::FEColorMatrix::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool : various improvements for running the commit-queue
        https://bugs.webkit.org/show_bug.cgi?id=28199

        Make run_and_throw_if_fail silence STDERR as well as STDIN.
        I also changed run_and_throw_if_fail to use the /dev/null trick instead of .communicate() to avoid ever buffering the out
        Change a few "print" statements to "log" so they appear in the output.
        Changed all string + uses to use string formatting instead (this is less error prone as it will automatically convert non
        Added a little more logging so that --quiet mode is easier to understand.
        Changed clear_attachment_review_flag to clear_attachment_flags and made it clear the commit-queue flag as well.
        Added the ability for bugzilla-tool to reject patches from the commit-queue when they fail to compile/apply/etc.
        Added _find_select_element_for_flag to make the code for finding flag <select> elements clearer.
        Made curl call (downloading patch files) quieter.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        Test: accessibility/media-element.html

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
            Add AccessibilityMediaControls.cpp/.h

        * accessibility/AXObjectCache.cpp:
        * accessibility/AXObjectCache.h:
        (WebCore::AXObjectCache::getOrCreate):
            Create AccessibilityMediaControl. Update Copyright

        * accessibility/AccessibilityMediaControls.cpp:
        * accessibility/AccessibilityMediaControls.h:
            Added.

        * accessibility/AccessibilityObject.cpp:
        * accessibility/AccessibilityObject.h:
            Add isMediaTimeline. Update Copyright.

        * accessibility/AccessibilitySlider.h:
            Make constructor protected instead of private so AccessibilityMediaTimeline can
            call it.

        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
            Add NSAccessibilityValueDescriptionAttribute to range attributes.
        (-[AccessibilityObjectWrapper subrole]):
            Return NSAccessibilityTimelineSubrole for AccessibilityMediaTimeline.

        * dom/Node.h:
            add isMediaControlElement.

        * page/mac/WebCoreViewFactory.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
            New, return localized media controller strings.

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlElement::MediaControlElement):
            Initialize m_displayType.
        (WebCore::MediaControlElement::MediaControlElement):
        (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
            Fix style.
        (WebCore::MediaControlInputElement::MediaControlInputElement):
            Set m_displayType based on pseudo style ID.
        (WebCore::MediaControlInputElement::MediaControlInputElement):
            rename local "o" to "object".
        (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement):
        (WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
        (WebCore::MediaControlSeekButtonElement::MediaControlSeekButtonElement):
        (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
        (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
        (WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
            Update for MediaControlInputElement constructor change.
        (WebCore::MediaControlTimeDisplayElement::formatTime):
            New, moved here from RenderMedia so AccessibilityMediaTimeDisplay can use it.
        (WebCore::MediaControlTimeDisplayElement::setCurrentValue):
            New, set text to current time.
        * rendering/MediaControlElements.h:

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateControls):
            Create controls in tab order.
        (WebCore::RenderMedia::formatTime):
            Moved to MediaControlTimeDisplayElement::formatTime.
        (WebCore::RenderMedia::updateTimeDisplay):
            Call MediaControlTimeDisplayElement::setCurrentValue.
        * rendering/RenderMedia.h:

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        Add localized strings for media controller accessiblility.

        * English.lproj/Localizable.strings:

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory localizedMediaControlElementString:]):
        (-[WebViewFactory localizedMediaControlElementHelpText:]):
        (-[WebViewFactory localizedMediaTimeDescription:]):
            New.

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * WebCoreLocalizedStrings.cpp:
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
            New.

2009-08-12  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        <video> and <audio> controller should be accessible
        https://bugs.webkit.org/show_bug.cgi?id=28081

        * accessibility/media-element.html: Added.
        * platform/mac-leopard/accessibility/media-element-expected.txt:
        * platform/mac-leopard/media/controls-strict-expected.txt:
        * platform/mac/accessibility/media-element-expected.txt:
            Added.

        * platform/mac-leopard/media/controls-after-reload-expected.txt:
        * platform/mac-leopard/media/controls-styling-expected.txt:
        * platform/mac-leopard/media/video-empty-source-expected.txt:
        * platform/mac-leopard/media/video-zoom-controls-expected.txt:
        * media/video-controls-visible-audio-only.html:
        * platform/mac-leopard/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/audio-controls-rendering-expected.txt:
        * platform/mac/media/controls-after-reload-expected.txt:
        * platform/mac/media/controls-styling-expected.txt:
        * platform/mac/media/video-controls-rendering-expected.txt:
        * platform/mac/media/video-display-toggle-expected.txt:
        * platform/mac/media/video-empty-source-expected.txt:
        * platform/mac/media/video-zoom-controls-expected.txt:
            Update for controller element tab order change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Eric Seidel  <eric@webkit.org>

        No review, script regression fix only.

        run-webkit-tests --quiet hangs
        https://bugs.webkit.org/show_bug.cgi?id=28202

        Do a huge dance to get open3 to pipe to /dev/null w/o blocking.
        This was what I came up with after discussions in #perl.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Viet-Trung Luu  <viettrungluu@gmail.com>

        Reviewed by Dimitri Glazkov.

        Explicitly set control tints for Chromium/Mac, since the controls'
        NSCell(s) lack an NSView and hence their tint isn't updated
        automatically when the application is activated/deactivated.
        https://bugs.webkit.org/show_bug.cgi?id=28108
        http://crbug.com/18199

        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::updateNSCellControlTint):
        (WebCore::RenderThemeChromiumMac::paintCheckbox):
        (WebCore::RenderThemeChromiumMac::paintRadio):
        (WebCore::RenderThemeChromiumMac::paintButton):
        (WebCore::RenderThemeChromiumMac::paintMenuList):
        (WebCore::RenderThemeChromiumMac::paintSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintSearchField):
        (WebCore::RenderThemeChromiumMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

(no review) Disabling a failing test.

<rdar://problem/7136851> platform/mac/accessibility/string-range-contains-listmarker.html fails.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Christian Plesner Hansen  <christian.plesner.hansen@gmail.com>

        Reviewed by Dimitri Glazkov.

        [V8] Fix atomic string externalization crash.
        Atomic string externalization assumes that all non-empty strings
        can be externalized which is untrue on 64-bit.  This change fixed
        that.

        https://bugs.webkit.org/show_bug.cgi?id=28215

        This bug causes loads of test crashes, no need to add new tests
        specifically for this.

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8StringToAtomicWebCoreString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog:

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Freyther.

        [Qt] Fix box-shadow painting in r47103. The edge should not be blurry.
        Also optimize by not having to save and restore painter state.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Holger Hans Peter Freyther.

        [Qt] Update the pixel tests for shadow edge fix.

        * platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
        * platform/qt/fast/box-shadow/basic-shadows-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Adam Treat.

        [Qt] Fix coding style in GraphicsContextQt.cpp

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::toQtCompositionMode):
        (WebCore::toQtLineCap):
        (WebCore::toQtLineJoin):
        (WebCore::GraphicsContextPlatformPrivate::p):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::pen):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::drawFocusRing):
        (WebCore::GraphicsContext::beginTransparencyLayer):
        (WebCore::GraphicsContext::endTransparencyLayer):
        (WebCore::GraphicsContext::clearRect):
        (WebCore::GraphicsContext::setLineCap):
        (WebCore::GraphicsContext::setLineJoin):
        (WebCore::GraphicsContext::setMiterLimit):
        (WebCore::GraphicsContext::setAlpha):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        (WebCore::GraphicsContext::addInnerRoundedRectClip):
        (WebCore::GraphicsContext::setPlatformStrokeColor):
        (WebCore::GraphicsContext::setPlatformStrokeStyle):
        (WebCore::GraphicsContext::setPlatformStrokeThickness):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog:

2009-08-12  Szabo Carol  <carol.szabo@nokia.com>

        Reviewed by Simon Hausmann and Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=23291

        [Qt] Partial support for -webkit-box-shadow. Blur is not support and
        the shadow still does not go well with border radius.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::fillRect):

LayoutTests/ChangeLog:

2009-08-12  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Pixel tests for (partial) -webkit-box-shadow support.

        * platform/qt/Skipped: Include basic-shadows.
        * platform/qt/fast/box-shadow/basic-shadows-expected.checksum: Added.
        * platform/qt/fast/box-shadow/basic-shadows-expected.png: Added.
        * platform/qt/fast/box-shadow/basic-shadows-expected.txt: Adjusted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Balazs Kelemen  <kelemen.balazs.3@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        Build fix: use std::numeric_limits<long long>::min() instead of LLONG_MIN
        since LLONG_MIN is not defined in standard c++.

        * runtime/UString.cpp:
        (JSC::UString::from):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

QtWebKit compile fix for Windows CE

Patch by Joerg Bornemann <joerg.bornemann@trolltech.com> on 2009-08-12
Reviewed by Simon Hausmann.

There's no getenv on Windows CE, use qgetenv instead.

* Api/qwebpage.cpp:
(qt_drt_overwritePluginDirectories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Use AM_V_GEN in a few more places, for less noisy builds.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        SVG Filter premultiplied color support for getImageDate/putImageData
        [https://bugs.webkit.org/show_bug.cgi?id=27933]

        Some SVG Filters need premultiplied ImageData for the calculation. Therefore getImageData
        and putImageData of ImageBuffer need support for premultiplied colors.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::getImageData):
        (WebCore::CanvasRenderingContext2D::putImageData):
        * platform/graphics/ImageBuffer.h:
        (WebCore::):
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::getImageData):
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::putImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * platform/graphics/wx/ImageBufferWx.cpp:
        (WebCore::ImageBuffer::getUnmultipliedImageData):
        (WebCore::ImageBuffer::getPremultipliedImageData):
        (WebCore::ImageBuffer::putUnmultipliedImageData):
        (WebCore::ImageBuffer::putPremultipliedImageData):
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::applyMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Benjamin Otte  <otte@gnome.org>

        Reviewed by Jan Alonzo.

        Buildfix for Gtk platforms debug builds.

        * GNUmakefile.am: Choose MarkStackPosix.cpp or MarkStackWin.cpp
        depending on platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Prospective build fix for Mac and 32-bit Windows.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-12
* runtime/UString.cpp: Include wtf/StringExtras.h for snprintf.
(JSC::UString::from): Use %lld instead of %I64d for snprintf
on non-windows platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix compile error on 64Bit Windows, when UString::from
is called with an intptr_t.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Added new UString::From overload with long long parameter.

Thanks to Holger for the long long idea.

* runtime/UString.cpp:
(JSC::UString::from):
* runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Changed Number.bytesToString to support low-resolution output.

        https://bugs.webkit.org/show_bug.cgi?id=28146

        * inspector/front-end/utilities.js:
        (Number.bytesToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add support for hooking BeginPaint/EndPaint on 64Bit Windows

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-08-12
Reviewed by Simon Hausmann.

Webkit uses the runtime patching trick explained by "Feng Yuan" for
hooking these paint functions. It currently supports only 32bit assembly
code. This patch adds support for 64Bit version. Since inline-assemblies
are not supported for 64Bit, we have use a seperate .asm file.

* WebCore.pro:
* plugins/win/PaintHooks.asm: Added.
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Minor style fixes in previous patch and changelog correction.

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Reviewed by Gavin Barraclough

Jump through a few hoops to make it much harder to accidentally
miss null-checking of values returned by the try-* allocation
routines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

Reviewed by NOBODY (build fix part deux).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209

Reviewed by Oliver Hunt.

These objects were also being referenced from the CodeBlock.  By changing this
to just retain pointers to FunctionBodyNodes these classes can be restricted to
use during parsing.

No performance impact (or sub-percent progression).

* JavaScriptCore.exp:
    Update symbols.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::mark):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunction):
(JSC::CodeBlock::function):
    Unify m_functions & m_functionExpressions into a single Vector<RefPtr<FuncExprNode> >.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::addConstant):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
* bytecompiler/BytecodeGenerator.h:
    FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
    Update to reflect chnages in CodeBlock.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func_exp):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::):
    Update to reflect chnages in CodeBlock.

* parser/Grammar.y:
    FunctionStacks now contain FunctionBodyNodes not FuncDeclNodes.

* parser/NodeConstructors.h:
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
* parser/Nodes.cpp:
(JSC::ScopeNodeData::mark):
(JSC::FunctionBodyNode::finishParsing):
* parser/Nodes.h:
(JSC::FunctionBodyNode::ident):
    Move m_ident & make methods from FuncDeclNode & FuncExprNode to FunctionBodyNode.

* runtime/JSFunction.h:
(JSC::FunctionBodyNode::make):
    Make this method inline (was FuncDeclNode::makeFunction).

WebCore: Restrict use of FuncDeclNode & FuncExprNode to the parser.
https://bugs.webkit.org/show_bug.cgi?id=28209

Reviewed by Oliver Hunt.

* inspector/JavaScriptDebugServer.cpp:
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
    Function signature change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Hopefully the last tweak to major-objects.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Unreviewed.

Patch by Adam Barth <abarth@webkit.org> on 2009-08-11
Remove a few characters from the ASCII art to make it fit better in the
template.

* coding/major-objects.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Native JSON.stringify does not omit functions
https://bugs.webkit.org/show_bug.cgi?id=28117

Reviewed by Gavin Barraclough

Objects that are callable should be treated as undefined when
serialising to JSON.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Oliver Hunt.

        Document relation between major objects in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=28210

        Added a diagram showing the relation between major objects.

        * coding/major-objects.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  John Gregg  <johnnyg@google.com>

Reviewed by Maciej Stachowiak.

WebCore:
Move the accessor for notifications presenter from WebUIDelegate
to WebUIDelegate2 which extends it.  When making this call from
WebCoreSupport, check using QueryInterface before calling.

https://bugs.webkit.org/show_bug.cgi?id=28198

* Interfaces/IWebUIDelegate.idl:
* Interfaces/IWebUIDelegate2.idl: Added.
* Interfaces/WebKit.idl:
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:

DumpRenderTree:
Switch DumpRenderTree to contain a WebUIDelegate2, which extends
WebUIDelegate, so that the notifications tests will still work.
https://bugs.webkit.org/show_bug.cgi?id=28198

* DumpRenderTree/win/UIDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubberstamped by Mark Rowe.

<rdar://problem/7135864> fast/dom/frame-loading-via-document-write.html fails intermittently.

* platform/mac-snowleopard/Skipped: Skip for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Not reviewed: repair email address

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27965
Merge skia/ImageSourceSkia.cpp into ImageSource.cpp.

Reviewed by Adam Treat.

* WebCore.gypi: Remove deleted file, plus a file that was deleted a while back.
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::setData): Use slightly shorter syntax.
(WebCore::ImageSource::filenameExtension): Use shorter syntax.
(WebCore::ImageSource::createFrameAtIndex): Remove redundant call, clarify comments, reject all empty images.
(WebCore::ImageSource::frameHasAlphaAtIndex): Clarify comments, use shorter syntax.
* platform/graphics/skia/ImageSourceSkia.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Try to fix GTK build.

Patch by Darin Adler <darin@apple.com> on 2009-08-11
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::stringForRange): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove tests from Skipped that now pass correctly after the addition
of keyDown named event handling to Qt's DumpRenderTree.

Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-11
Reviewed by Adam Treat.

https://bugs.webkit.org/show_bug.cgi?id=28161

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore: SharedWorkers do not exit when the last parent document exits
https://bugs.webkit.org/show_bug.cgi?id=28170

Reviewed by David Levin.

Prevents Documents from being suspended/placed in the page cache if they are associated with shared workers.

Added vector cache instead of nested hash tables for SharedWorker repository.

Added SharedWorkerRepository::documentDetached API.

* dom/Document.cpp:
(WebCore::Document::detach):
Notifies SharedWorkerRepository when the document is closing.
* loader/FrameLoader.cpp:
Updated FrameLoader to not cache the Document if it is associated with a SharedWorker (since we can't suspend workers yet, we need to shut them down).
(WebCore::FrameLoader::canCachePageContainingThisFrame):
(WebCore::FrameLoader::logCanCacheFrameDecision):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::create):
(WebCore::SharedWorkerProxy::isClosing):
Renamed from closing().
(WebCore::SharedWorkerProxy::matches):
Added manual equality function to replace old hash lookup.
(WebCore::SharedWorkerProxy::isDocumentInWorkerDocuments):
Checks to see if a document is in the worker's list of documents. Used to determine if page is suspendable.
(WebCore::SharedWorkerProxy::SharedWorkerProxy):
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
Added tracking of the worker's list of documents for lifecycle purposes.
(WebCore::SharedWorkerProxy::documentDetached):
Shuts down the proxy when the last associated document is detached.
(WebCore::SharedWorkerProxy::close):
Marks the proxy as closed so it is no longer shared with new instances.
(WebCore::SharedWorkerProxy::workerContextDestroyed):
Removes the proxy from the repository/frees the proxy when the associated SharedWorkerContext is destroyed.
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
closing()->isClosing()
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):
Used by FrameLoader to determine if a page has shared workers and so cannot be suspended/cached.
(WebCore::DefaultSharedWorkerRepository::hasSharedWorkers):
(WebCore::DefaultSharedWorkerRepository::removeProxy):
Invoked by workerContextDestroyed() to remove a SharedWorkerProxy from the repository.
(WebCore::DefaultSharedWorkerRepository::documentDetached):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):
(WebCore::DefaultSharedWorkerRepository::getProxy):
* workers/DefaultSharedWorkerRepository.h:
* workers/SharedWorkerRepository.h:

LayoutTests: SharedWorkers do not exit when the last parent document exits.
https://bugs.webkit.org/show_bug.cgi?id=28170

Reviewed by David Levin.

Added more tests to check that previous incarnations of the SharedWorker "name" are shut down.

* fast/workers/shared-worker-replace-global-constructor.html-disabled:
Fixed incorrect path to common script.
* fast/workers/shared-worker-shared-expected.txt:
* fast/workers/shared-worker-shared.html-disabled:
Added more tests for sharing, including initial test to make sure previous incarnations of shared worker were closed.
* fast/workers/worker-replace-global-constructor.html:
Removed extraneous closing HTML tag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Add processing for string constants used by the tests to trigger
common actions like up, down, left, right, etc. for the Qt
implementation of DumpRenderTree.

Patch by Mike Fenton <mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.

Note this allows fast/forms/textarea-arrow-navigation.html to pass
correctly.

https://bugs.webkit.org/show_bug.cgi?id=28161

* DumpRenderTree/qt/jsobjects.cpp:
(EventSender::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

When returning text through the marker range attributes, the list marker text should
also be included. It isn't included by default because a TextIterator is used which
only looks at Nodes for text. A list marker does not have a corresponding node,
so its text is not returned through accessibility. That is, until now.

Test: platform/mac/accessibility/string-range-contains-listmarker.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForRange):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
* accessibility/AccessibilityObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
(-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
* rendering/RenderListItem.h:

Make markerText() public so that accessibility code can access it.

WebKitTools: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

Add the ability to retrieve a string given a plain NSRange.

* DumpRenderTree/AccessibilityUIElement.cpp:
(stringForRangeCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::stringForRange):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::stringForRange):

LayoutTests: Bug 28200 - ListMarker should be included as part of the text value to parse
https://bugs.webkit.org/show_bug.cgi?id=28200

Reviewed by Darin Adler.

Tests for checking that the list marker text is included when asking for text
through accessibility.

* platform/mac/accessibility/bounds-for-range-expected.txt.
* platform/mac/accessibility/string-range-contains-listmarker-expected.txt: Added.
* platform/mac/accessibility/string-range-contains-listmarker.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubberstamped by Mark Rowe.

<rdar://problem/7135553> plugins/root-object-premature-delete-crash.html crashes intermittently.

* platform/mac-snowleopard/Skipped: Skip for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix fast/dom/prototype-inheritance.html
and fast/dom/prototype-inheritance-2.html
broken on Windows by http://trac.webkit.org/changeset/47018

Reviewed by NOBODY (Speculative fix for the layout test failure).

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): enable app cache in Windows DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27965
Move cairo/ImageSourceCairo.cpp to ImageSource.cpp in preparation for
merging most of the other ImageSource*.cpp files with it.

Reviewed by Adam Treat.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/ImageSource.cpp: Copied from WebCore/platform/graphics/cairo/ImageSourceCairo.cpp.
* platform/graphics/cairo/ImageSourceCairo.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

    Updated data/params parameter

        * data/params: Updated 'loginnetmask' parameter to allow users
        to choose whether their cookies are restricted to a single IP
        address or not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Cairo-based Windows port does not handle the https protocol.
https://bugs.webkit.org/show_bug.cgi?id=28171.

Reviewed by Adam Roben.

No new tests needed.  Existing https tests show this failure
for WinCairo builds.

* WebCore.vcproj/WebCoreCURL.vsprops: Add a few preprocessor
  definitions for SSL support in cURL.
* platform/network/curl/ResourceHandleManager.h: Add new
  certificate path member variable.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificateBundlePath): New method to retrieve the
  proper certificate resource bundle path.
(WebCore::ResourceHandleManager::initializeHandle): Check for
  the resource bundle and use if available to activate SSL
  support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Eric Seidel  <eric@webkit.org>

        No review, just adding results.

        Cross-platform ICO decoder gets wrong bit depth for icons w/o color count
        https://bugs.webkit.org/show_bug.cgi?id=28073

        Land test results (as pkasting asked me to do hours ago, sorry).

        * fast/images/icon-0colors-expected.checksum: Added.
        * fast/images/icon-0colors-expected.png: Added.
        * fast/images/icon-0colors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool: Re-factor shared landing logic into helper class to share more code
        https://bugs.webkit.org/show_bug.cgi?id=28193

        Added new WebKitLandingScripts class to hold this shared logic.
        Also added a view_source_url function to move more webkit-specific urls out of bugzilla-tool core.

        * Scripts/bugzilla-tool:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        [Haiku] Use Clipboard::create() instead of the constructor of Clipboard.
        https://bugs.webkit.org/show_bug.cgi?id=28127

        * editing/haiku/EditorHaiku.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * page/haiku/EventHandlerHaiku.cpp:
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::createDraggingClipboard):
        * platform/haiku/ClipboardHaiku.cpp: Style cleanup. There were many whitespace end of lines.
        (WebCore::ClipboardHaiku::ClipboardHaiku):
        (WebCore::ClipboardHaiku::clearAllData):
        (WebCore::ClipboardHaiku::getData):
        (WebCore::ClipboardHaiku::setData):
        (WebCore::ClipboardHaiku::types):
        (WebCore::ClipboardHaiku::dragLocation):
        (WebCore::ClipboardHaiku::dragImage):
        (WebCore::ClipboardHaiku::setDragImage):
        (WebCore::ClipboardHaiku::dragImageElement):
        (WebCore::ClipboardHaiku::createDragImage):
        (WebCore::ClipboardHaiku::declareAndWriteDragImage):
        (WebCore::ClipboardHaiku::writeURL):
        (WebCore::ClipboardHaiku::writeRange):
        (WebCore::ClipboardHaiku::hasData):
        * platform/haiku/DragDataHaiku.cpp:
        (WebCore::DragData::createClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative fix for GTK build break.

Reviewed by NOBODY (Build break).

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Fix the current failures on the buildbot.

        As Qt hooks up the maybeDump to loadFinished, we need to make
        sure that calling dump() will not call maybeDump on loadFinished.

        As dump is called my emitting done() which calls dump() and then
        setting m_isLoading to false. So in the case m_isLoading is false,
        do not dump again.

        The current code is confusing, and should be made more clear
        in another commit.

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::maybeDump):
        (LayoutTestController::notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the current failures on the buildbot.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-08-11
Reviewed by Adam Treat.

As Qt hooks up the maybeDump to loadFinished, we need to make
sure that calling dump() will not call maybeDump on loadFinished.

As dump is called my emitting done() which calls dump() and then
setting m_isLoading to false. So in the case m_isLoading is false,
do not dump again.

The current code is confusing, and should be made more clear
in another commit.

* DumpRenderTree/qt/jsobjects.cpp:
(LayoutTestController::maybeDump):
(LayoutTestController::notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore: Speculative Windows build fix

Reviewed by NOBODY (build break).

* WebCore.vcproj/WebCore.vcproj:
Added missing build steps for non-debug targets.

WebKit/win: Speculative Windows build fix - undo previous unnecessary change.

Reviewed by NOBODY (build break).

* WebCoreSupport/WebDesktopNotificationsDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative build fix for Qt build.

Reviewed by NOBODY (build break)

* WebCore.pro: Added /notifications to include path

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

REGRESSION: Hang/crash in BytecodeGenerator::constRegisterFor loading simple page
https://bugs.webkit.org/show_bug.cgi?id=28169

Reviewed by Geoff Garen.

Handle the case where someone has attempted to shadow a property
on the global object with a constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=27323
Handle arbitrary line endings when manufacturing patches for additions
with history.

Reviewed by Darin Adler.

* Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Steve Falkenburg.

        Refactored MIMETypeforExtension to be a member of IWebViewPrivate
        instead of IWebView.

        * Interfaces/IWebView.idl:
        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::MIMETypeForExtension):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative build fix for Qt build.

Reviewed by NOBODY (build break)

* WebCore.pro: Added /notifications to include path

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative fix for windows build break.

Reviewed by NOBODY (build break)

* WebKitSupport/WebDesktopNotificationsDelegate.h:
WebCore/Notification*.h => WebCore/notifications/Notification*.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Speculative fix for GTK build break.

Reviewed by NOBODY (Build break).

* WebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds ENABLE_NOTIFICATION flag.

* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:

WebCore: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds an implementation of desktop notifications, behind the compile-time
flag ENABLE(NOTIFICATIONS).  This code simply relays calls on the JavaScript
API through a NotificationProvider interface, which must provide the services
to actually notify the user and manage the desktop.  This provider is injected
into WebKit through the ChromeClient for normal page contexts and through the
WorkerThread for worker contexts.

A permissions API is defined on a per-origin basis, which allows a web page
to check if its origin is allowed to show desktop notifications, and to request
permission for its origin.

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSDesktopNotificationsCustom.cpp: Added.
(WebCore::JSNotificationCenter::requestPermission):
(WebCore::JSNotification::addEventListener):
(WebCore::JSNotification::removeEventListener):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
(WebCore::toEventTarget):
* dom/EventTarget.cpp:
(WebCore::EventTarget::toNotification):
* dom/EventTarget.h:
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::notificationPresenter):
* notifications: Added.
* notifications/Notification.cpp: Added.
(WebCore::Notification::Notification):
(WebCore::Notification::~Notification):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::ondisplay):
(WebCore::Notification::setOndisplay):
(WebCore::Notification::onerror):
(WebCore::Notification::setOnerror):
(WebCore::Notification::onclose):
(WebCore::Notification::setOnclose):
(WebCore::Notification::getAttributeEventListener):
(WebCore::Notification::setAttributeEventListener):
(WebCore::Notification::clearAttributeEventListener):
(WebCore::Notification::dispatchDisplayEvent):
(WebCore::Notification::dispatchErrorEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::addEventListener):
(WebCore::Notification::removeEventListener):
(WebCore::Notification::handleEvent):
(WebCore::Notification::dispatchEvent):
* notifications/Notification.h: Added.
(WebCore::Notification::create):
(WebCore::Notification::isHTML):
(WebCore::Notification::url):
(WebCore::Notification::contents):
(WebCore::Notification::scriptExecutionContext):
(WebCore::Notification::toNotification):
(WebCore::Notification::refEventTarget):
(WebCore::Notification::derefEventTarget):
* notifications/Notification.idl: Added.
* notifications/NotificationCenter.cpp: Added.
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
* notifications/NotificationCenter.h: Added.
(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
(WebCore::NotificationCenter::context):
(WebCore::NotificationCenter::presenter):
* notifications/NotificationCenter.idl: Added.
* notifications/NotificationContents.h: Added.
(WebCore::NotificationContents::NotificationContents):
(WebCore::NotificationContents::icon):
(WebCore::NotificationContents::title):
(WebCore::NotificationContents::body):
* notifications/NotificationPresenter.h: Added.
(WebCore::NotificationPresenter::):
(WebCore::NotificationPresenter::~NotificationPresenter):
* page/Chrome.cpp:
(WebCore::Chrome::notificationPresenter):
* page/Chrome.h:
* page/ChromeClient.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::webkitNotifications):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* page/Page.h:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
(WebCore::WorkerContext::webkitNotifications):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
* workers/WorkerThread.h:
(WebCore::WorkerThread::getNotificationPresenter):
(WebCore::WorkerThread::setNotificationPresenter):

WebKit/mac: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds ENABLE_NOTIFICATION flag.

* Configurations/FeatureDefines.xcconfig:

WebKit/win: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adds test hooks for notification features to WebCoreSupport for
use in DumpRenderTree.

* Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
* Interfaces/IWebUIDelegate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::notificationPresenter):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
(NotificationCOMWrapper::create):
(NotificationCOMWrapper::NotificationCOMWrapper):
(NotificationCOMWrapper::QueryInterface):
(NotificationCOMWrapper::AddRef):
(NotificationCOMWrapper::Release):
(NotificationCOMWrapper::isHTML):
(NotificationCOMWrapper::contentsURL):
(NotificationCOMWrapper::iconURL):
(NotificationCOMWrapper::title):
(NotificationCOMWrapper::text):
(NotificationCOMWrapper::notifyDisplay):
(NotificationCOMWrapper::notifyError):
(NotificationCOMWrapper::notifyClose):
(WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::notificationDelegate):
* WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
* WebCoreSupport/WebInspectorDelegate.h:
(WebInspectorDelegate::desktopNotificationsDelegate):
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:

WebKitTools: Add support for desktop notifications API to DumpRenderTree,
and support for ENABLE_NOTIFICATIONS flag to build-webkit.

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

* DumpRenderTree/LayoutTestController.cpp:
(grantDesktopNotificationPermissionCallback):
(LayoutTestController::staticFunctions):
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::checkDesktopNotificationPermission):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp: Added.
(DRTDesktopNotificationPresenter::DRTDesktopNotificationPresenter):
(DRTDesktopNotificationPresenter::QueryInterface):
(DRTDesktopNotificationPresenter::AddRef):
(DRTDesktopNotificationPresenter::Release):
(DRTDesktopNotificationPresenter::showDesktopNotification):
(DRTDesktopNotificationPresenter::cancelDesktopNotification):
(DRTDesktopNotificationPresenter::notificationDestroyed):
(DRTDesktopNotificationPresenter::checkNotificationPermission):
(DRTDesktopNotificationPresenter::requestNotificationPermission):
* DumpRenderTree/win/DRTDesktopNotificationPresenter.h: Added.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::UIDelegate):
(UIDelegate::desktopNotificationsDelegate):
* DumpRenderTree/win/UIDelegate.h:
* Scripts/build-webkit:

LayoutTests: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Patch by John Gregg <johnnyg@google.com> on 2009-08-11
Reviewed by Maciej Stachowiak.

Adding layout tests for desktop notifications.  Currently these
are all disabled because the flag for this feature is set to 0.

* fast/notifications: Added.
* fast/notifications/notifications-check-permission-expected.txt: Added.
* fast/notifications/notifications-check-permission.html-disabled: Added.
 - Validates that checking permission for notifications works correctly.
* fast/notifications/notifications-display-close-events-expected.txt: Added.
* fast/notifications/notifications-display-close-events.html-disabled: Added.
 - Validates that the display and close events are fired correctly.
* fast/notifications/notifications-double-show-expected.txt: Added.
* fast/notifications/notifications-double-show.html-disabled: Added.
 - Validates that the same notification object cannot be shown twice.
* fast/notifications/notifications-request-permission-expected.txt: Added.
* fast/notifications/notifications-request-permission.html-disabled: Added.
 - Validates that requesting permission works correctly.
* fast/notifications/notifications-with-permission-expected.txt: Added.
* fast/notifications/notifications-with-permission.html-disabled: Added.
 - Validates that, with permission, showing a notification works correctly.
* fast/notifications/notifications-without-permission-expected.txt: Added.
* fast/notifications/notifications-without-permission.html-disabled: Added.
 - Validates that, without permission, showing a notification fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Remove dead declarations.

Reviewed by Sam Weinig.

* WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubberstamped by Mark Rowe.

-Stop skipping platform/mac/fast/text/myanmar-shaping.html on SnowLeopard.
-Move the previous results aside for Tiger and Leopard only.
-Generate new results for SnowLeopard.

* platform/mac-snowleopard/Skipped: Remove platform/mac/fast/text/myanmar-shaping.html
* platform/mac-leopard/fast/text/myanmar-shaping-expected.checksum: Copied from platform/mac/fast/text/myanmar-shaping-expected.checksum.
* platform/mac-leopard/fast/text/myanmar-shaping-expected.png: Copied from platform/mac/fast/text/myanmar-shaping-expected.png.
* platform/mac-leopard/fast/text/myanmar-shaping-expected.txt: Copied from platform/mac/fast/text/myanmar-shaping-expected.txt.
* platform/mac/fast/text/myanmar-shaping-expected.checksum: Replaced.
* platform/mac/fast/text/myanmar-shaping-expected.png: Replaced.
* platform/mac/fast/text/myanmar-shaping-expected.txt: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Anders Carlsson.

Resolve <rdar://problem/6733642>.

* platform/mac-snowleopard/Skipped: Re-enable plugins/netscape-plugin-setwindow-size.html and
  plugins/netscape-plugin-setwindow-size-2.html, as they now reliably pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Maxime Simon  <simon.maxime@gmail.com>

        Reviewed by Eric Seidel.

        Modifications on JavaScriptCore to allow Haiku port.
        https://bugs.webkit.org/show_bug.cgi?id=28121

        * runtime/Collector.cpp: Haiku doesn't have sys/mman.h, using OS.h instead.
        (JSC::currentThreadStackBase): Haiku uses its own threading system.
        * wtf/Platform.h: Defining all Haiku platform values.
        * wtf/haiku/MainThreadHaiku.cpp: Adding a missing header (NotImplemented.h).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Console Drawer is Toggling instead of Staying Open
        https://bugs.webkit.org/show_bug.cgi?id=28115

        * inspector/front-end/Drawer.js:
        (WebInspector.Drawer.prototype.showView): ensures the drawer will be open and showing the provided view
        * inspector/front-end/inspector.js:
        (WebInspector.showConsole): usees the new showView to guarantee the Drawer will be open
        (WebInspector.showChanges): uses the new showView guarantee the Drawer will be open

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        [WML] WMLPageState is not allowed to store the active card, it needs to be done per document
        https://bugs.webkit.org/show_bug.cgi?id=28180

        Don't store the active WMLCardElement in WMLPageState, but in WMLDocument.
        Otherwhise this may lead to crashes related to intrinsic event exeuction.

        Unfortunately select elements aren't testable by the layout tests, so adding
        a new manual test reproducing the crash.

        * manual-tests/wml/select-onpick-event-crash.wml: Added.
        * wml/WMLCardElement.cpp:
        (WebCore::WMLCardElement::determineActiveCard):
        * wml/WMLDoElement.cpp:
        (WebCore::WMLDoElement::defaultEventHandler):
        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::finishedParsing):
        * wml/WMLDocument.h:
        (WebCore::WMLDocument::activeCard):
        * wml/WMLGoElement.cpp:
        (WebCore::WMLGoElement::executeTask):
        * wml/WMLPageState.cpp:
        (WebCore::WMLPageState::WMLPageState):
        * wml/WMLPageState.h:
        * wml/WMLPrevElement.cpp:
        (WebCore::WMLPrevElement::executeTask):
        * wml/WMLRefreshElement.cpp:
        (WebCore::WMLRefreshElement::executeTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubber-stamped by Mark Rowe.

Resolve <rdar://problem/6877291>.

* platform/mac-snowleopard/Skipped: media/video-size-intrinsic-scale.html no longer fails - stop skipping it!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Rubberstamped by Mark Rowe.

* platform/mac-snowleopard/Skipped: Remove http/tests/navigation/post-goback-repost-policy.html,
  as it has already been disabled globally, and re-enabling is tracked by <rdar://problem/6778137>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=28183
Support VS2008 as well as VS2005 in a few scripts.

Reviewed by Darin Adler.

* Scripts/pdevenv: Check both $VS80COMNTOOLS and $VS90COMNTOOLS.
* Scripts/webkitdirs.pm: Use $VSINSTALLDIR if available instead of hardcoding the VS2005 dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Fix of <rdar://5016504> SVG file cannot be dragged to webview,
        but can be opened via Open File.

        Added a new function to IWebView that gets the MIME type for a given
        extension from the MIMETypeRegistry.

        * Interfaces/IWebView.idl:
        * WebView.cpp:
        (WebView::MIMETypeForExtension):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix for layout tests failures. Need to initialize some preferences early
because WebView on Windows uses them during create time.

Reviewed by NOBODY (Windows layout tests fix).

* DumpRenderTree/win/DumpRenderTree.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking.  Also fix a couple cases of a style
violation.

Reviewed by Eric Seidel.

Test: fast/images/icon-0colors.html

* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::readDirectoryEntry):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=28073
Treat icons with no bit count and no color count as 256-color for
purposes of quality ranking.

Reviewed by Eric Seidel.

* fast/images/icon-0colors.html: Added.
* fast/images/resources/0colors.ico: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Benjamin Otte  <otte@gnome.org>

        Reviewed by Xan Lopez.

        When instructed to print an out-of-range page, print an empty page
        instead of crashing.

        * webkit/webkitwebframe.cpp:
        (draw_page_callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Exception in land-patches
        https://bugs.webkit.org/show_bug.cgi?id=27962

        Use ("%s" % object) instead of ("" + object).
        Added unit tests for logging.py.

        * Scripts/modules/logging.py:
        * Scripts/modules/logging_unittest.py: Added.
        * Scripts/run-webkit-unittests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Re-land the patch for https://bugs.webkit.org/show_bug.cgi?id=20534.
Previously reverted since incorrect merge on landing has caused Layout Tests failures on Windows.

WebKit/mac: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
See https://bugs.webkit.org/show_bug.cgi?id=20534

* WebView/WebPreferences.mm:
(-[WebPreferences _setPreferenceForTestWithValue:withKey:]): added.
* WebView/WebPreferencesPrivate.h: same.

WebKit/win: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson  <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

* Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
* WebPreferences.cpp: same.
* WebPreferences.h: same.

WebKitTools: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson  <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

* DumpRenderTree/LayoutTestController.cpp:
(overridePreferenceCallback): add wiring for layoutTestController.overridePreference.
(LayoutTestController::staticFunctions): same.
* DumpRenderTree/LayoutTestController.h: same.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): added empty overridePreference method.
* DumpRenderTree/mac/DumpRenderTree.mm: implemented preference override.
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(setDefaultsToConsistentValuesForTesting): new method, sets other details of testing environment, every time  DRT starts.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::overridePreference):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): new method, resets preferences to same set of value before every test.
(resetWebViewToConsistentStateBeforeTesting): move some preference setting from here to new resetDefaultsToConsistentValues().
(createWebViewAndOffscreenWindow): same.
(main): same.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::overridePreference):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::overridePreference):

LayoutTests: Added support for overriding default preferences per-test.
Originally implemented by Glenn Wilson  <gwilson@chromium.org>.
Reviewed by Adam Roben.
Added tests to verify that default preferences can be overridden per-test
and that overridden values are reset between each test.
See https://bugs.webkit.org/show_bug.cgi?id=20534

* fast/harness/override-preferences-2-expected.txt: Added.
* fast/harness/override-preferences-2.html: Added. Verifies overridePreverence("WebKitDefaultFontSize", "24").
* fast/harness/override-preferences-expected.txt: Added.
* fast/harness/override-preferences.html: Added. Verifies overridePreference("WebKitJavaScriptEnabled", false).
* fast/harness/override-zzz-reset-expected.txt: Added.
* fast/harness/override-zzz-reset.html: Added. Because of 'zzz' this test will run after the tests above and
verify that override of preferences does not 'spill' to the subsequent tests in a batch.
* platform/gtk/Skipped: Tests above disabled for GTK until GTK DRT implements preference override.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Sam Weinig.

        Added support for DRT to support arguments for eventSender.mouseDown and eventSender.mouseUp for Windows.
        https://bugs.webkit.org/show_bug.cgi?id=28166.

        This is a step towards fixing fast/events/mouse-click-events.html on Windows.

        * DumpRenderTree/win/EventSender.cpp:
        (mouseDownCallback):
        (mouseUpCallback):
        (replaySavedEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Jessie Berlin  <jberlin@apple.com>

        Fix windows build.

        Reviewed by Adam Roben.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Need to refactor WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=28136

Reviewed by David Levin.

Added WorkerReportingProxy for reporting worker state (exceptions, console messages, thread exited) to the parent.

Existing tests are sufficient, as this is only a refactoring.

* GNUmakefile.am:
Added WorkerReportingProxy.h to build.
* WebCore.gypi:
Added WorkerReportingProxy.h to build.
* WebCore.vcproj/WebCore.vcproj:
Added WorkerReportingProxy.h to build.
* WebCore.xcodeproj/project.pbxproj:
Added WorkerReportingProxy.h to build.
* workers/DedicatedWorkerContext.cpp:
* workers/DedicatedWorkerContext.h:
Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
Changed constructor to pass WorkerReportingProxy to base class.
* workers/DefaultSharedWorkerRepository.cpp:
Updated SharedWorkerProxy to implement WorkerReportingProxy interface.
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::SharedWorkerProxy::workerContextClosed):
(WebCore::SharedWorkerProxy::workerContextDestroyed):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
Now passes in WorkerReportingProxy when creating SharedWorkerThread.
* workers/SharedWorkerContext.cpp:
* workers/SharedWorkerContext.h:
Removed addMessage/forwardException() APIs - now handled by WorkerReportingProxy.
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
Passes WorkerReportingProxy to base class constructor.
* workers/SharedWorkerThread.h:
Constructor now takes a WorkerReportingProxy.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::~WorkerContext):
Moved code that calls workerContextDestroyed() into base class so shared workers share this functionality.
(WebCore::WorkerContext::close):
Now notifies WorkerReportingProxy when the thread is closing.
(WebCore::WorkerContext::reportException):
Reports exceptions via WorkerReportingProxy.
(WebCore::WorkerContext::addMessage):
Reports console messages via WorkerReportingProxy.
* workers/WorkerContext.h:
* workers/WorkerObjectProxy.h:
(WebCore::WorkerObjectProxy::workerContextClosed):
Default empty implementation for dedicated workers.
* workers/WorkerReportingProxy.h: Added.
Base interface that contains APIs moved from WorkerObjectProxy.
(WebCore::WorkerReportingProxy::~WorkerReportingProxy):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
Updated constructor to accept a WorkerReportingProxy.
* workers/WorkerThread.h:
(WebCore::WorkerThread::workerReportingProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Buildfix for Qt-win platforms.

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-08-11
Reviewed by Tor Arne Vestbø.

* JavaScriptCore.pri: Choose MarkStackPosix.cpp or MarkStackWin.cpp depend on platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Adam Treat.

        Add results for fast/borders/border-radius-split-inline and remove from platform/qt/Skipped
        Note: Results will wrap to 4 lines even though it indicates 3 lines.  This is due to font
        size differences in Qt, and matches the output of FireFox.

        https://bugs.webkit.org/show_bug.cgi?id=28147

        * platform/qt/Skipped:
        * platform/qt/fast/borders/border-radius-split-inline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Build the TestNetscapePlugin on Qt/Mac

Reviewed by Simon Hausmann.

* WebKit.pro:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix a bunch of build warnings in TestNetscapePlugin

Reviewed by Simon Hausmann.

* DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
* DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Prefix lengthy commands with AM_V_GEN so that they produce an
        output like 'GEN <filename>' when in silent mode.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the Qt build after r47022.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by NOBODY (build fix).

Use the new markChildren() pattern for marking aggregate/child objects.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObjectImp::markChildren):
(JSC::Bindings::QtInstance::markAggregate):
* bridge/qt/qt_instance.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::markChildren):
* bridge/qt/qt_runtime.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-08-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by NOBODY (build fix).

        Attempt to fix the Windows test bot. Reverted r47015 caused one of the Windows
        bots that runs Layout Tests to save "JS disabled" and "default font 24pt"
        preferences permanently. Since these preferences are not initialized explicitly in DRT,
        almost all Layout tests are failing. Attempt to fix by explicit
        initialization of these into defaults (enabled, 16pt) at the beginning of the DRT.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):  see above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Fix the build on the Qt build bot by making the generated JS bindings
files depend on the code generator itself.

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-08-11
Reviewed by Holger Freyther.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@47028 268f45cc-cd09-0410-ab3c-d52691b4dbfc