WebKit-https.git
9 years ago2010-08-11 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 12 Aug 2010 16:33:19 +0000 (16:33 +0000)]
2010-08-11  Tony Chang  <tony@chromium.org>

        Reviewed by David Levin.

        [chromium] add google-chrome layout test result directories
        https://bugs.webkit.org/show_bug.cgi?id=43889

        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Hui Huang <hui.2.huang@nokia.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 15:58:32 +0000 (15:58 +0000)]
2010-08-12  Hui Huang  <hui.2.huang@nokia.com>

        Reviewed by Eric Seidel.

        m_windowRect is not updated because parent of PluginView is not
        set when updatePluginWidget is called. plugin gets wrong window
        size on setwindow.
        https://bugs.webkit.org/show_bug.cgi?id=43635

        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::setParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 15:37:31 +0000 (15:37 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed, re-apply r65241 and 65243.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 12 Aug 2010 15:26:51 +0000 (15:26 +0000)]
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  The DefaultImpl returns false, since it does not yet
        implement the TexImage2D internalFormat quirks.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::supportsBGRA):
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
        * src/WebGraphicsContext3DDefaultImpl.h:
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  Since they differ on semantics (GL ES 2.0 requires
        TexImage2D()'s format and internalFormat to match, while desktop GL
        will not accept BGRA as an internalFormat), the stub implementation
        returns false until these quirks have been implemented and tested on
        each port.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::supportsBGRA):
        Add implementation for non-chromium platforms which returns false.
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
        Add query function (supportsBGRA()) and the BGRA_EXT token.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 15:11:54 +0000 (15:11 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65225.
        http://trac.webkit.org/changeset/65225
        https://bugs.webkit.org/show_bug.cgi?id=43918

        Broke EFL port build (Requested by acidx on #webkit).

        * cmake/WebKitGenerators.cmake:
        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 15:04:51 +0000 (15:04 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out r65241 and 65243 for breaking inspector tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 12 Aug 2010 13:40:38 +0000 (13:40 +0000)]
2010-08-12  Nate Chapin  <japhet@chromium.org>

        Update chromium's test_expectations.txt and provide new baselines for
        http://trac.webkit.org/changeset/65229.

        (Text-only baseline for win/linux because there are real regressions in the
        image results.  See https://bugs.webkit.org/show_bug.cgi?id=43912)

        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 13:38:32 +0000 (13:38 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Adding the file missing in r65241.

        * inspector/front-end/RemoteObject.js: Added.
        (WebInspector.RemoteObjectId):
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPrimitiveValue):
        (WebInspector.RemoteObject.fromNode):
        (WebInspector.RemoteObject.fromPayload):
        (WebInspector.RemoteObject.type):
        (WebInspector.RemoteObject.prototype.get objectId):
        (WebInspector.RemoteObject.prototype.get type):
        (WebInspector.RemoteObject.prototype.get description):
        (WebInspector.RemoteObject.prototype.get hasChildren):
        (WebInspector.RemoteObject.prototype.isError):
        (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions):
        (WebInspector.RemoteObject.prototype.getOwnProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe scratch register should be saved in YARR with ARM JIT
loki@webkit.org [Thu, 12 Aug 2010 13:37:55 +0000 (13:37 +0000)]
The scratch register should be saved in YARR with ARM JIT
https://bugs.webkit.org/show_bug.cgi?id=43910

Reviewed by Simon Hausmann.

Reported by Jocelyn Turcotte.

* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::generateEnter):
(JSC::Yarr::RegexGenerator::generateReturn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 12 Aug 2010 13:31:30 +0000 (13:31 +0000)]
2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.StylesScriptsOrderRule.prototype.doRun):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        (WebInspector.ConsoleView.prototype._format):
        (WebInspector.ConsoleView.prototype._formatnode):
        (WebInspector.ConsoleView.prototype._formatarray):
        (WebInspector.ConsoleView.prototype._formatAsArrayEntry):
        (WebInspector.ConsoleMessage.prototype._format):
        (WebInspector.ConsoleCommandResult):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertiesSection.prototype.update):
        (WebInspector.ObjectPropertiesSection.prototype.updateProperties):
        (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate):
        (WebInspector.ObjectPropertyTreeElement.prototype.update):
        (WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
        * inspector/front-end/ObjectProxy.js: Removed.
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        * inspector/front-end/RemoteObject.js: Added.
        (WebInspector.RemoteObjectId):
        (WebInspector.RemoteObject):
        (WebInspector.RemoteObject.fromPrimitiveValue):
        (WebInspector.RemoteObject.fromErrorMessage):
        (WebInspector.RemoteObject.fromNode):
        (WebInspector.RemoteObject.fromPayload):
        (WebInspector.RemoteObject.type):
        (WebInspector.RemoteObject.prototype.get objectId):
        (WebInspector.RemoteObject.prototype.get type):
        (WebInspector.RemoteObject.prototype.get description):
        (WebInspector.RemoteObject.prototype.get hasChildren):
        (WebInspector.RemoteObject.prototype.isError):
        (WebInspector.RemoteObject.prototype.getPropertyValueDescriptions):
        (WebInspector.RemoteObject.prototype.getOwnProperties):
        (WebInspector.RemoteObject.prototype.getProperties.remoteObjectBinder):
        (WebInspector.RemoteObjectProperty):
        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame.updatingCallbackWrapper):
        (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._showPopup.evaluateCallback):
        (WebInspector.SourceFrame.prototype._showPopup):
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSection.prototype.update):
        (WebInspector.WatchExpressionTreeElement.prototype.update):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.log.logMessage):
        (WebInspector.log):
        * inspector/front-end/utilities.js:

2010-08-12  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up object proxies, introduce remote object model.
        https://bugs.webkit.org/show_bug.cgi?id=43847

        * inspector/console-dir-expected.txt:
        * inspector/console-dir-global.html:
        * inspector/console-dir.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Ben Murdoch <benm@google.com>
benm@google.com [Thu, 12 Aug 2010 13:27:53 +0000 (13:27 +0000)]
2010-08-12  Ben Murdoch  <benm@google.com>

        Reviewed by Steve Block.

        V8 code generator does not add V8BindingMacros.h include in all places it is needed
        https://bugs.webkit.org/show_bug.cgi?id=43907

        Adds the V8BindingMacros.h header before using the STRING_TO_V8PARAMETER_EXCEPTION_BLOCK
        macro.

        Build fix so no new tests.

        * bindings/scripts/CodeGeneratorV8.pm: include the header at the right time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 12 Aug 2010 13:09:30 +0000 (13:09 +0000)]
2010-08-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed.

        Media test baseline forgotten in r65224.

        * platform/gtk/media/audio-no-installed-engines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
hamaji@chromium.org [Thu, 12 Aug 2010 12:36:52 +0000 (12:36 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65181.
        http://trac.webkit.org/changeset/65181
        https://bugs.webkit.org/show_bug.cgi?id=43909

        It broke 35 layout tests fail on chromium-win (Requested by
        hamaji on #webkit).

        * public/WebFrameClient.h:
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 12:04:26 +0000 (12:04 +0000)]
2010-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Update chromium's test_expectations.txt

        * platform/chromium/test_expectations.txt: Two failing video related tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 12 Aug 2010 12:00:06 +0000 (12:00 +0000)]
Unreviewed.

[Qt] animations/suspend-resume-animation.html fails
https://bugs.webkit.org/show_bug.cgi?id=43905

* platform/qt/Skipped: animations/suspend-resume-animation.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 11:52:40 +0000 (11:52 +0000)]
2010-08-12  Shinichiro Hamaji  <hamaji@chromium.org>

        Update chromium's test_expectations.txt

        * platform/chromium/test_expectations.txt: animations/play-state is flaky on Mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 11:10:47 +0000 (11:10 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/GroupSettings.cpp: Removed.
        * page/GroupSettings.h: Removed.
        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):
        (WebCore::PageGroup::localStorage):
        * page/PageGroup.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setLocalStorageQuota):
        (WebCore::Settings::setLocalStorageDatabasePath):
        * page/Settings.h:
        (WebCore::Settings::localStorageQuota):
        (WebCore::Settings::localStorageDatabasePath):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _preferencesChangedNotification:]):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Revert for now
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView.cpp:
        (WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:37:07 +0000 (10:37 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Delete a test that slipped in by accident.

        * svg/zoom/page/zoom-mask.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:30:31 +0000 (10:30 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Follow up to Jeremys fix, just remove the context parameter, it's not needed anymore.

        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::createMaskAndSwapContextForTextGradient):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::createImageBuffer):
        * rendering/SVGImageBufferTools.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:27:51 +0000 (10:27 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.

        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::createImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:21:09 +0000 (10:21 +0000)]
2010-08-12  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.  Matches solutions in qt and mac ports for
        https://bugs.webkit.org/show_bug.cgi?id=43794

        * WebView.cpp:
        (WebView::initWithFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 12 Aug 2010 10:11:08 +0000 (10:11 +0000)]
2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG masking performance very slow
        https://bugs.webkit.org/show_bug.cgi?id=43622

        Create ImageBuffers only as large as the final rendered size on screen. Only gradient on text on CG handled this correctly so far.
        Refactored the code into a new SVGImageBufferTools class, and use the code from RenderSVGResourceMasker -> makes the IE9 demo SVG dice usable.
        Clippers, Patterns and Filters remain to be converted.

        Test: svg/zoom/page/zoom-mask-with-percentages.svg

        * Android.mk: Add SVGImageBufferTools.* to build.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/RenderSVGAllInOne.cpp: Ditto.
        * rendering/RenderSVGResourceGradient.cpp: Refactored CG gradient specific "create image buffer in absolute coordinates" code into SVGImageBufferTools class.
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceMasker.cpp: Use new SVGImageBufferTools class, to avoid pixelation when zooming and to create image buffers as big as the final rendered size on screen, not more.
        (WebCore::RenderSVGResourceMasker::invalidateClients):
        (WebCore::RenderSVGResourceMasker::applyResource):
        (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
        (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/RenderSVGResourceMasker.h:
        * rendering/SVGImageBufferTools.cpp: Added.
        (WebCore::SVGImageBufferTools::absoluteTransformFromContext):
        (WebCore::SVGImageBufferTools::createImageBuffer):
        (WebCore::SVGImageBufferTools::clipToImageBuffer):
        * rendering/SVGImageBufferTools.h: Added.
        (WebCore::SVGImageBufferTools::SVGImageBufferTools):
        (WebCore::SVGImageBufferTools::~SVGImageBufferTools):

2010-08-12  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVG masking performance very slow
        https://bugs.webkit.org/show_bug.cgi?id=43622

        Update mask results, now that mask image buffers are as big as the finaled rendered size on screen.
        Add new test covering zooming into masks, to show that it doesn't pixelate anymore.

        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
        * platform/mac/svg/batik/masking/maskRegions-expected.checksum:
        * platform/mac/svg/batik/masking/maskRegions-expected.png:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.checksum: Added.
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
        * svg/zoom/page/zoom-mask-with-percentages.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-10 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 12 Aug 2010 10:03:23 +0000 (10:03 +0000)]
2010-08-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Since persistient storage is shared between pages, there's no way to modify
        some settings related to it on a per page basis.  As such, it's not technically
        correct for these settings to be on the Page's settings.  Create a new class
        called GroupSettings, move the 2 group-wide local storage settings there, and
        add a new setting for IndexedDB's path (which is prompting this change).

        No behavior has changed, so no tests.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * page/PageGroup.cpp:
        (WebCore::PageGroup::PageGroup):
        (WebCore::PageGroup::localStorage):
        * page/PageGroup.h:
        (WebCore::PageGroup::groupSettings):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setSessionStorageQuota):
        * page/Settings.h:
2010-08-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Change WebView to use the new GroupSettings class rather than Settings for the
        settings that moved.  This is sub-optimal since the settings aren't really
        per-view, but we can't really change the API at this point.

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _preferencesChangedNotification:]):
2010-08-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        Some settings are linked to the PageGroup not the Page.  Create a new class for those.
        https://bugs.webkit.org/show_bug.cgi?id=43794

        Change WebSettings to use the new GroupSettings class rather than Settings for the
        settings that moved.  This is sub-optimal since the settings aren't really
        per-view, but I don't see how we can change the API at this point.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Decode images directly to QPixmap
hausmann@webkit.org [Thu, 12 Aug 2010 09:43:50 +0000 (09:43 +0000)]
[Qt] Decode images directly to QPixmap
https://bugs.webkit.org/show_bug.cgi?id=40797

Patch by Benjamin Poulain <benjamin.poulain@nokia.com> on 2010-08-12
Reviewed by Simon Hausmann.

Use the new API of Qt 4.7 to decode data from the image
reader directly to QPixmap.

This allow us to use JDCT_IFAST when decoding jpeg images
to pixmap, and to decode animated GIF images, while still
using in-place conversion of color space.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::setData):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-14 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Thu, 12 Aug 2010 09:41:14 +0000 (09:41 +0000)]
2010-07-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by darin@apple.com.

        Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
        https://bugs.webkit.org/show_bug.cgi?id=42278

        This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

        * fast/events/init-events-expected.txt:
        * fast/events/script-tests/init-events.js:
        (createEventHelper): splits event creation so that we can test without init.
        (testInitEvent): adds test for OverflowEvent creation.
2010-07-14  Marcus Bulach  <bulach@chromium.org>

        Reviewed by darin@apple.com.

        Removes DontCheckEnums from some IDLs and fixes the corresponding enums.
        https://bugs.webkit.org/show_bug.cgi?id=42278

        This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=42250: it fixes some IDL/.h and enables generating compile-time checks for enums.

        Tests: idls should generate valid code.

        * dom/Node.h:
        (WebCore::Node::):
        * dom/Node.idl:
        * dom/OverflowEvent.h:
        (WebCore::OverflowEvent::):
        * dom/OverflowEvent.idl:
        * html/FileReader.cpp:
        (WebCore::FileReader::readyState):
        * html/FileReader.h:
        (WebCore::FileReader::):
        * html/FileReader.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 08:50:54 +0000 (08:50 +0000)]
2010-08-12  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Nikolas Zimmermann.

        [CMake] Cleanup generator code.
        https://bugs.webkit.org/show_bug.cgi?id=39164

        * cmake/WebKitGenerators.cmake:
        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 12 Aug 2010 08:24:07 +0000 (08:24 +0000)]
2010-08-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] new media tests baselines needed
        https://bugs.webkit.org/show_bug.cgi?id=42444

        Visually check those tests, they seemed fine to me so I added
        their baselines.

        * platform/gtk/Skipped:
        * platform/gtk/media/audio-controls-rendering-expected.txt: Added.
        * platform/gtk/media/video-display-toggle-expected.txt: Added.
        * platform/gtk/media/video-empty-source-expected.txt: Added.
        * platform/gtk/media/video-layer-crash-expected.txt: Added.
        * platform/gtk/media/video-no-audio-expected.txt: Added.
        * platform/gtk/media/video-transformed-expected.txt: Added.
        * platform/gtk/media/video-zoom-controls-expected.txt: Added.
        * platform/gtk/media/video-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 12 Aug 2010 08:06:57 +0000 (08:06 +0000)]
2010-08-12  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by David Levin.

        The #if clause enabling a feature should avoid the all includes of
        the feature
        https://bugs.webkit.org/show_bug.cgi?id=43866

        Modified the position of the guard to avoid including all the
        headers if the feature controlling the guard is not enabled.

        * dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 07:18:31 +0000 (07:18 +0000)]
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65221.
        http://trac.webkit.org/changeset/65221
        https://bugs.webkit.org/show_bug.cgi?id=43896

        Broke snow leopard build. (Requested by dave_levin on
        #webkit).

        * platform/graphics/GraphicsContext3D.cpp:
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
2010-08-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65221.
        http://trac.webkit.org/changeset/65221
        https://bugs.webkit.org/show_bug.cgi?id=43896

        Broke snow leopard build. (Requested by dave_levin on
        #webkit).

        * public/WebGraphicsContext3D.h:
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 12 Aug 2010 07:00:33 +0000 (07:00 +0000)]
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  Since they differ on semantics (GL ES 2.0 requires
        TexImage2D()'s format and internalFormat to match, while desktop GL
        will not accept BGRA as an internalFormat), the stub implementation
        returns false until these quirks have been implemented and tested on
        each port.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::supportsBGRA):
        Add implementation for non-chromium platforms which returns false.
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
        Add query function (supportsBGRA()) and the BGRA_EXT token.
2010-08-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by David Levin.

        Add support for BGRA pixel format to GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=43858

        Although this has been standard in desktop GL since 1.2, it's an
        extension in GL ES 2.0, so a query function is provided to check
        for support.  The DefaultImpl returns false, since it does not yet
        implement the TexImage2D internalFormat quirks.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::supportsBGRA):
        * src/GraphicsContext3D.cpp:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsBGRA):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Satish Sampath <satish@chromium.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 06:42:44 +0000 (06:42 +0000)]
2010-08-11  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Handle clicks and recognition events for the speech input button
        https://bugs.webkit.org/show_bug.cgi?id=43857

        * rendering/RenderInputSpeech.cpp:
        (WebCore::RenderInputSpeech::paintInputFieldSpeechButton): Selects the image based on current state.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::set_state): Switch to a new state and update the UI.
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecording):
        (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition):
        * rendering/TextControlInnerElements.h:
        (WebCore::InputFieldSpeechButtonElement::):
        (WebCore::InputFieldSpeechButtonElement::state):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 12 Aug 2010 06:31:30 +0000 (06:31 +0000)]
2010-08-11  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        REGRESSION(65135): format specifier warnings
        https://bugs.webkit.org/show_bug.cgi?id=43876

        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::appendToBuffer): cast size_t to unsigned long for %lu.
        (WebCore::WebSocketChannel::processBuffer): cast size_t to unsigned long for %lu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in binding...
kevino@webkit.org [Thu, 12 Aug 2010 06:02:51 +0000 (06:02 +0000)]
[wx] Build fix, don't generate WebDOMEventTarget.h/.cpp as we use the ones in bindings/cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 12 Aug 2010 05:50:10 +0000 (05:50 +0000)]
2010-08-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Make PendingScript copyable so that it can be stored in containers
        https://bugs.webkit.org/show_bug.cgi?id=43875

        This will be useful for storing PendingScripts in a Vector or Deque for
        async and defer scripts.

        No new tests because no functional changes.

        * dom/PendingScript.h:
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 12 Aug 2010 04:35:42 +0000 (04:35 +0000)]
2010-08-11  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Disable accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=43894

        Disable accelerated compositing because DRT is not ready for
        it. This change fixes hundreds of test crashes on Windows and
        Linux.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Thu, 12 Aug 2010 03:56:40 +0000 (03:56 +0000)]
2010-08-11  Victoria Kirst  <vrk@google.com>

        Reviewed by David Levin.

        Fixing a regression in the UI for Mac default audio/video controls.
        https://bugs.webkit.org/show_bug.cgi?id=43750

        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderContainer):
        (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
        (WebCore::RenderThemeChromiumMac::volumeSliderOffsetFromMuteButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd more files to the WebKit2 skipped list.
weinig@apple.com [Thu, 12 Aug 2010 03:53:16 +0000 (03:53 +0000)]
Add more files to the WebKit2 skipped list.

Rubber-stamped by Jon Honeycutt.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 03:13:11 +0000 (03:13 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
        https://bugs.webkit.org/show_bug.cgi?id=43758

        * html5lib/runner-expected-html5.txt:
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTML TreeBuilder hits ASSERT in fragment case with insertAdjacentHTML and colgroup
        https://bugs.webkit.org/show_bug.cgi?id=43758

        This patch conditionalizes some LegacyHTMLTreeBuilder-specific code in
        HTMLElement::createContextualFragment that interferes with the new
        HTMLTreeBuilder.  Doing that exposes the above ASSERT, which I've fixed
        in this patch too.  Fixing that ASSERT involved a small refactoring in
        ExternalCharacterTokenBuffer.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::createContextualFragment):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeadingNonWhitespace):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading):
        (WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading):
        (WebCore::HTMLTreeBuilder::processCharacterBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 02:55:27 +0000 (02:55 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Conditionalize wrong fragment parsing code to pass more HTML5lib tests
        https://bugs.webkit.org/show_bug.cgi?id=43877

        Test progression.

        * html5lib/runner-expected-html5.txt:
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Conditionalize wrong fragment parsing code to pass more HTML5lib tests
        https://bugs.webkit.org/show_bug.cgi?id=43877

        This code exists to support the LegacyHTMLTreeBuilder.  Unfortunately,
        it causes problems for the new HTMLTreeBuilder (which is more
        self-contained).

        * dom/Element.cpp:
        (WebCore::Element::createContextualFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 12 Aug 2010 02:37:44 +0000 (02:37 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer
        https://bugs.webkit.org/show_bug.cgi?id=40725

        Qt and Tiger seem to have encoding problems that swallow the --
        characters that terminate the comment.  We can avoid those problems by
        inserting a space before the -->.  We're losing coverage of these
        issues, but I'm not sure we should be in the business of debugging
        these encoders unless there's a security problem.

        Thanks to ap for investigating and finding this workaround.

        * fast/encoding/japanese-encoding-mix.html:
        * platform/mac-tiger/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd SPI to stop loading from the InjectedBundle.
weinig@apple.com [Thu, 12 Aug 2010 02:36:45 +0000 (02:36 +0000)]
Add SPI to stop loading from the InjectedBundle.

Reviewed by Gavin Barraclough.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageStopLoading):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 02:09:17 +0000 (02:09 +0000)]
2010-08-11  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Last Hangul letter is typed again when a composition is finished with mouse press
        https://bugs.webkit.org/show_bug.cgi?id=40518

        When a mouse press fires during a IME composition, the current composition character
        can be entered twice at the previous editing position and a new editing position.
        Because the IME commit signal is emitted after the mouse press event.
        This patch allows to prevent the commit signal during a composition when a mouse press fires.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::imContextCommitted):
        (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit.
        (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires.
        (WebKit::EditorClient::EditorClient):  Initialize m_preventNextCompositionCommit
        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_button_press_event): Call handleInputMethodMousePress()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 12 Aug 2010 02:05:11 +0000 (02:05 +0000)]
2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Can't unbold text in div in font-weight span
        https://bugs.webkit.org/show_bug.cgi?id=26871

        The bug was caused by removeInlineStyle not being able to include styled inline nodes around the start.
        Solved this problem by pushing down all inline styles instead of just text-decorations.
        This approach allows removeInlineStyle to remove styled ancestors properly and generates compact markups.

        Test: editing/style/push-down-inline-styles.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeCSSStyle): No longer removes attributes or node when mode == RemoveNone.
        (WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle): Calls shouldRemoveInlineStyleFromElement
        to determine the highest ancestor whose style needs to be pushed down.
        (WebCore::ApplyStyleCommand::extractInlineStyleToPushDown): Renamed from extractTextDecorationStyle.
        Extracts all inline CSS properties specified instead of just text decorations.
        (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Renamed from applyTextDecorationStyle.
        Applies inline styles using addInlineStyleIfNeeded or adds inline CSS values.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Renamed from pushDownTextDecorationStyleAroundNode.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode.
        * editing/ApplyStyleCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Prevents moveParagraph from preserving
        the style of an empty paragraph when merged with the previous paragraph because we don't use that style anyways.
2010-08-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        Can't unbold text in div in font-weight span
        https://bugs.webkit.org/show_bug.cgi?id=26871

        Added a test to push down inline styles to the leaves of DOM tree.

        * editing/deleting/delete-br-011-expected.txt: Removed redundant style spans.
        * editing/execCommand/empty-span-removal-expected.txt: Removed a span without any attributes.
        * editing/style/push-down-inline-styles-expected.txt: Added.
        * editing/style/push-down-inline-styles.html: Added.
        * editing/style/script-tests/push-down-inline-styles.js: Added.
        (testSingleToggle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
barraclough@apple.com [Thu, 12 Aug 2010 01:56:29 +0000 (01:56 +0000)]
Windows build fix.

* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Forward.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 01:50:08 +0000 (01:50 +0000)]
2010-08-11  Shinichiro Hamaji  <hamaji@chromium.org>

        Chromium test_expectations update.

        * platform/chromium/test_expectations.txt: http/tests/storage/callbacks-are-called-in-correct-context.html is SLOW, not PASS TIMEOUT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Thu, 12 Aug 2010 01:27:11 +0000 (01:27 +0000)]
2010-08-11  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Ariya Hidayat.

        Remove dead code in CSSStyleSelector.
        https://bugs.webkit.org/show_bug.cgi?id=43805

        * css/CSSStyleSelector.cpp: Remove some debugging code that
        was compiled out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: isNativeCheckbox does not work as advertised
cfleizach@apple.com [Thu, 12 Aug 2010 01:24:10 +0000 (01:24 +0000)]
AX: isNativeCheckbox does not work as advertised
https://bugs.webkit.org/show_bug.cgi?id=43872

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isInputImage):
    Only say it's an input image if its role has not been overriden
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
* dom/InputElement.h:
    Add methods to query if it's a checkbox or radio button type element.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::isCheckbox):

LayoutTests:

* platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added.
* platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Thu, 12 Aug 2010 00:45:00 +0000 (00:45 +0000)]
2010-08-11  Shinichiro Hamaji  <hamaji@chromium.org>

        Chromium test_expectations update.

        * platform/chromium/test_expectations.txt: Mark http/tests/storage/callbacks-are-called-in-correct-context.html as flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKPageStopLoading always asserts
weinig@apple.com [Thu, 12 Aug 2010 00:39:56 +0000 (00:39 +0000)]
WKPageStopLoading always asserts

Reviewed by Gavin Barraclough.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Switch break to return, break made us
hit the ASSERT_NOT_REACHED at the end of the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Leo Yang <leo.yang@torchmobile.com.cn>
commit-queue@webkit.org [Thu, 12 Aug 2010 00:31:12 +0000 (00:31 +0000)]
2010-08-11  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Geoffrey Garen.

        Date("") should be an invalid date. For IE, Firefox and Chrome, Date("") is invalid date,
        which means isNaN(new Date("")) should return true.
        https://bugs.webkit.org/show_bug.cgi?id=43793
        Tests: fast/js/date-constructor.html

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::resetDateCache):
2010-08-11  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Geoffrey Garen.

        Add isNaN(new Date("")) test to fast/js/script-tests/date-constructor.js.
        https://bugs.webkit.org/show_bug.cgi?id=43793

        * fast/js/date-constructor-expected.txt:
        * fast/js/script-tests/date-constructor.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 12 Aug 2010 00:12:26 +0000 (00:12 +0000)]
2010-08-11  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Remove obsolete WebGLArray type names
        https://bugs.webkit.org/show_bug.cgi?id=43885

        Deleted aliases to obsolete WebGLArray type names. Updated
        affected layout tests, synchronizing them with the versions in the
        Khronos repository where appropriate. Ran all layout tests.

        * bindings/js/JSDOMWindowCustom.cpp:
        * page/DOMWindow.idl:
2010-08-11  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Remove obsolete WebGLArray type names
        https://bugs.webkit.org/show_bug.cgi?id=43885

        Deleted aliases to obsolete WebGLArray type names. Updated
        affected layout tests, synchronizing them with the versions in the
        Khronos repository where appropriate. Ran all layout tests.

        * compositing/webgl/webgl-reflection.html:
        * fast/canvas/webgl/array-get-and-set-method-removal.html:
        * fast/canvas/webgl/array-get-out-of-bounds.html:
        * fast/canvas/webgl/array-set-out-of-bounds-expected.txt:
        * fast/canvas/webgl/array-set-out-of-bounds.html:
        * fast/canvas/webgl/array-setters-expected.txt:
        * fast/canvas/webgl/array-setters.html:
        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
        * fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html:
        * fast/canvas/webgl/null-uniform-location.html:
        * fast/canvas/webgl/point-size.html:
        * fast/canvas/webgl/resources/webgl-test-utils.js:
        (WebGLTestUtils):
        (WebGLTestUtils.):
        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
        * fast/canvas/webgl/tex-image-with-format-and-type.html:
        * fast/canvas/webgl/tex-input-validation.html:
        * fast/canvas/webgl/tex-sub-image-2d-expected.txt:
        * fast/canvas/webgl/tex-sub-image-2d.html:
        * fast/canvas/webgl/texImage2DImageDataTest.html:
        * fast/canvas/webgl/viewport-unchanged-upon-resize.html:
        * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
        * fast/canvas/webgl/webgl-array-invalid-ranges.html:
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/js/script-tests/global-constructors.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 11 Aug 2010 23:46:33 +0000 (23:46 +0000)]
2010-08-11  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        [chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0
        https://bugs.webkit.org/show_bug.cgi?id=43753

        This change guards the entire contents of the V8 custom bindings files
        with ENABLE(GEOLOCATION) to match JSC.

        No new tests, build fix only.

        * bindings/v8/custom/V8CustomPositionCallback.cpp:
        * bindings/v8/custom/V8CustomPositionErrorCallback.cpp:
        * bindings/v8/custom/V8GeolocationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 11 Aug 2010 23:35:28 +0000 (23:35 +0000)]
2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Unreviewed. Adding my Collabora personality to the list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Wed, 11 Aug 2010 23:30:39 +0000 (23:30 +0000)]
2010-08-11  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by David Levin.

        Include <wtf/UnusedParam.h> in GraphicsContextSkia.cpp
        https://bugs.webkit.org/show_bug.cgi?id=43843

        wtf/UnusedParam.h must be included because UNUSED_PARAM macro is used.

        * platform/graphics/skia/GraphicsContextSkia.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 11 Aug 2010 23:25:59 +0000 (23:25 +0000)]
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        Small improvement to the documentation of the geolocation-policy-decision-requested
        signal, stating more clearly what is expected from the handler.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 11 Aug 2010 23:25:46 +0000 (23:25 +0000)]
2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Geolocation policy decision object leaking
        https://bugs.webkit.org/show_bug.cgi?id=43884

        Use GRefPtr on the policy decision object to fix the leak.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::requestGeolocationPermissionForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Wed, 11 Aug 2010 23:14:43 +0000 (23:14 +0000)]
2010-08-11  Nico Weber  <thakis@chromium.org>

        Reviewed by David Levin.

        [chromium/mac]: Fix colors in compositing mode
        https://bugs.webkit.org/show_bug.cgi?id=43823

        The textures are drawn by opengl, which doesn't do any color space
        correction -- it assumes everything is in the device color space
        already. Hence, when drawing into the memory that will be uploaded
        as opengl texture, use the device color space.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateTextureContents):
        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::updateTextureContents):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::setRootLayerCanvasSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Kenneth Russell <kbr@google.com>
aa@chromium.org [Wed, 11 Aug 2010 22:54:35 +0000 (22:54 +0000)]
2010-08-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Remove obsolete texImage2D and texSubImage2D entry points
        https://bugs.webkit.org/show_bug.cgi?id=40320

        No new tests; covered by existing WebGL tests.

        * html/canvas/WebGLRenderingContext.cpp:
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
2010-08-11  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Dmitry Titov.

        [Chromium] Notify the WebFrameClient when the frame is detached from
        the view. This is used to clear the cached frame in the FormManager.
        Eventually this will be removed once handling forms is moved into
        WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=43648

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::frameDetached):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 11 Aug 2010 22:44:11 +0000 (22:44 +0000)]
2010-08-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Remove obsolete texImage2D and texSubImage2D entry points
        https://bugs.webkit.org/show_bug.cgi?id=40320

        No new tests; covered by existing WebGL tests.

        * html/canvas/WebGLRenderingContext.cpp:
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 11 Aug 2010 22:28:38 +0000 (22:28 +0000)]
2010-08-11  Martin Robinson  <mrobinson@igalia.com>

        Adding myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
barraclough@apple.com [Wed, 11 Aug 2010 22:16:50 +0000 (22:16 +0000)]
Windows build fix.

* platform/win/BString.cpp:
(WebCore::BString::BString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix II.
barraclough@apple.com [Wed, 11 Aug 2010 22:02:26 +0000 (22:02 +0000)]
Qt build fix II.

* WebCore.xcodeproj/project.pbxproj:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows & !JIT build fix.
barraclough@apple.com [Wed, 11 Aug 2010 21:52:13 +0000 (21:52 +0000)]
Windows & !JIT build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/RegExp.cpp:
(JSC::RegExp::match):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix.
barraclough@apple.com [Wed, 11 Aug 2010 21:48:35 +0000 (21:48 +0000)]
Qt build fix.

* WebCore.xcodeproj/project.pbxproj:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber stamp by sam weinig
barraclough@apple.com [Wed, 11 Aug 2010 21:45:39 +0000 (21:45 +0000)]
Rubber stamp by sam weinig

Touch a file to stop the bot rolling a bit change out!

* runtime/UString.cpp:
(JSC::UString::ascii):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Steve Block <steveblock@google.com>
steveblock@google.com [Wed, 11 Aug 2010 21:35:12 +0000 (21:35 +0000)]
2010-08-11  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Need EmptyDeviceOrientationClient and EmptyDeviceMotionClient for use with SVGImage
        https://bugs.webkit.org/show_bug.cgi?id=43848

        Tested by existing DeviceOrientation tests.

        * loader/EmptyClients.h:
        (WebCore::EmptyDeviceMotionClient::setController):
        (WebCore::EmptyDeviceMotionClient::startUpdating):
        (WebCore::EmptyDeviceMotionClient::stopUpdating):
        (WebCore::EmptyDeviceMotionClient::currentDeviceMotion):
        (WebCore::EmptyDeviceOrientationClient::setController):
        (WebCore::EmptyDeviceOrientationClient::startUpdating):
        (WebCore::EmptyDeviceOrientationClient::stopUpdating):
        (WebCore::EmptyDeviceOrientationClient::lastOrientation):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Aug 2010 21:23:10 +0000 (21:23 +0000)]
2010-08-11  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations tweak.

        Mark websocket/tests/frame-length-overflow.html as flaky.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-10 Aaron Boodman <aa@chromium.org>
aa@chromium.org [Wed, 11 Aug 2010 20:38:00 +0000 (20:38 +0000)]
2010-08-10  Aaron Boodman  <aa@chromium.org>

        Reviewed by David Hyatt.

        Make the cascade level of "user" styles configurable
        https://bugs.webkit.org/show_bug.cgi?id=43457

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector): Handle the case where user styles might have author level. Minor refactor.
        * dom/Document.cpp:
        (WebCore::Document::pageGroupUserSheets): Set isUserStyle on created stylesheet objects appropriately.
        * page/PageGroup.cpp:
        (WebCore::PageGroup::addUserStyleSheetToWorld): Add new optional "level" argument.
        * page/PageGroup.h: Ditto.
        * page/UserStyleSheet.h: Add level property.
        (WebCore::UserStyleSheet::):
        (WebCore::UserStyleSheet::UserStyleSheet):
        (WebCore::UserStyleSheet::setLevel):
        (WebCore::UserStyleSheet::level):
2010-08-10  Aaron Boodman  <aa@chromium.org>

        Reviewed by David Hyatt.

        Make the cascade level of "user" styles configurable
        https://bugs.webkit.org/show_bug.cgi?id=43457

        * src/WebViewImpl.cpp:
        (WebKit::WebView::addUserStyleSheet): Send "author" for the css level of user styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Rob Buis <rwlbuis@gmail.com>
rwlbuis@webkit.org [Wed, 11 Aug 2010 20:24:27 +0000 (20:24 +0000)]
2010-08-11  Rob Buis  <rwlbuis@gmail.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=42042
        An empty value for xml:lang isn't considered

        Revert last line change of my patch ; it happens to
        behave correctly and same as before, but makes the
        use case of empty values unneededly slower.

        No new tests. (No change in behavior)

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Wed, 11 Aug 2010 20:10:55 +0000 (20:10 +0000)]
2010-08-11  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Dmitry Titov.

        [Chromium] Notify the WebFrameClient when the frame is detached from
        the view. This is used to clear the cached frame in the FormManager.
        Eventually this will be removed once handling forms is moved into
        WebCore.
        https://bugs.webkit.org/show_bug.cgi?id=43648

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::frameDetached):
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::detachedFromParent3):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx, WebDOM] Build fix. Fix handling of callbacks and WebCore::String -> WTF::String...
kevino@webkit.org [Wed, 11 Aug 2010 20:09:26 +0000 (20:09 +0000)]
[wx, WebDOM] Build fix. Fix handling of callbacks and WebCore::String -> WTF::String fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Wed, 11 Aug 2010 19:55:37 +0000 (19:55 +0000)]
2010-08-11  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        Perl warnings when running commit-log-editor
        https://bugs.webkit.org/show_bug.cgi?id=43856

        Fixes Perl warnings introduced by the patch for Bug #40548.

        Perl doesn't have symbolic names for True/False. Instead, we
        should use boolean values. Moreover, the variable installedEditorApplication
        is not be used and should be renamed builtEditorApplication so that it
        uses the existing machinery to set the commit log editor application.

        * Scripts/commit-log-editor:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Aug 2010 19:53:52 +0000 (19:53 +0000)]
2010-08-11  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Remove consistently passing tests
        from test_expectations.txt.

        https://bugs.webkit.org/show_bug.cgi?id=43868

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber stamps by Darin Adler & Sam Weinig.
barraclough@apple.com [Wed, 11 Aug 2010 19:52:41 +0000 (19:52 +0000)]
Rubber stamps by Darin Adler & Sam Weinig.

Bug 43867 - Some UString cleanup

Change JSC::UString data(), size(), and from(), to characters(), length(), and number() to match WTF::String.
Move string concatenation methods to a new header to simplify down UString.h.  Remove is8Bit().

JavaScriptCore:

* API/JSClassRef.cpp:
(OpaqueJSClass::~OpaqueJSClass):
(OpaqueJSClass::className):
* API/OpaqueJSString.cpp:
(OpaqueJSString::create):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpName):
* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::get):
* bytecompiler/NodesCodegen.cpp:
(JSC::ResolveNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::processClauseList):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createRegex):
* parser/ParserArena.h:
(JSC::IdentifierArena::makeNumericIdentifier):
* parser/SourceProvider.h:
(JSC::UStringSourceProvider::data):
(JSC::UStringSourceProvider::length):
* profiler/Profiler.cpp:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate):
* runtime/ExceptionHelpers.cpp:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionPrototype.cpp:
(JSC::insertSemicolonIfNeeded):
* runtime/Identifier.h:
(JSC::Identifier::characters):
(JSC::Identifier::length):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::decode):
(JSC::parseInt):
(JSC::parseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):
* runtime/JSNumberCell.cpp:
(JSC::JSNumberCell::toString):
* runtime/JSONObject.cpp:
(JSC::gap):
(JSC::Stringifier::appendQuotedString):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::indent):
(JSC::Stringifier::unindent):
(JSC::Walker::walk):
* runtime/JSString.cpp:
(JSC::JSString::replaceCharacter):
(JSC::JSString::getIndexSlowCase):
* runtime/JSString.h:
(JSC::RopeBuilder::JSString):
(JSC::RopeBuilder::appendValueInConstructAndIncrementLength):
(JSC::RopeBuilder::fiberCount):
(JSC::jsSingleCharacterSubstring):
(JSC::jsNontrivialString):
(JSC::JSString::getIndex):
(JSC::jsString):
(JSC::jsStringWithFinalizer):
(JSC::jsSubstring):
(JSC::jsOwnedString):
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append):
* runtime/LiteralParser.h:
(JSC::LiteralParser::Lexer::Lexer):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToPrecision):
* runtime/NumericStrings.h:
(JSC::NumericStrings::add):
(JSC::NumericStrings::lookupSmallString):
* runtime/Operations.h:
(JSC::jsString):
* runtime/RegExp.cpp:
(JSC::RegExp::match):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getRightContext):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::match):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringBuilder.h:
(JSC::StringBuilder::append):
* runtime/StringConcatenate.h: Copied from JavaScriptCore/runtime/UString.h.
(JSC::):
(JSC::sumWithOverflow):
(JSC::tryMakeString):
(JSC::makeString):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::localeCompare):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplit):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncSubstring):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
(JSC::trimString):
* runtime/UString.cpp:
(JSC::UString::number):
(JSC::UString::ascii):
(JSC::UString::operator[]):
(JSC::UString::toDouble):
(JSC::UString::find):
(JSC::UString::rfind):
(JSC::UString::substr):
(JSC::operator==):
(JSC::operator<):
(JSC::operator>):
(JSC::UString::UTF8String):
* runtime/UString.h:
(JSC::UString::UString):
(JSC::UString::adopt):
(JSC::UString::length):
(JSC::UString::characters):
(JSC::UString::isNull):
(JSC::UString::isEmpty):
(JSC::UString::impl):
(JSC::UString::cost):
(JSC::operator==):
(JSC::operator!=):
(JSC::codePointCompare):
(JSC::UString::toArrayIndex):
(JSC::IdentifierRepHash::hash):
(WTF::):
* yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
* yarr/RegexParser.h:
(JSC::Yarr::Parser::Parser):

JavaScriptGlue:

* JSUtils.cpp:
(UStringToCFString):
(KJSValueToCFTypeInternal):
* JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::hasCSSPropertyNamePrefix):
(WebCore::cssPropertyName):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::setPort):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/js/ScriptString.h:
(WebCore::ScriptString::size):
* bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::convertValueToJObject):
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):

WebKit/mac:

* WebView/WebScriptDebugger.mm:
(toNSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 Aug 2010 19:49:31 +0000 (19:49 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Trying waiting for httpd lock in the EWS
        https://bugs.webkit.org/show_bug.cgi?id=43833

        If this works, we can probably run the tests on the mac-ews, which
        would be very exciting.  :)

        * Scripts/webkitpy/tool/steps/runtests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.
hyatt@apple.com [Wed, 11 Aug 2010 19:48:07 +0000 (19:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=43806, add ability to paginate screen content.

Reviewed by Dan Bernstein.

WebCore:

Add a new boolean to Document to indicate that content should be paginated.  This is checked when doing page breaks
and in a couple of other cases.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::paginatedForScreen):
(WebCore::Document::setPaginatedForScreen):
(WebCore::Document::paginated):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::calcColumnWidth):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::calcHeight):
* rendering/RenderView.cpp:
(WebCore::RenderView::paint):

WebKit/mac:

Add SPI for entering and exiting screen pagination mode.  This is similar to printing mode but it can be done for on-screen
content.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _isInScreenPaginationMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView _setPrinting:minimumPageWidth:height:maximumPageWidth:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):
* WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Fady Samuel <fsamuel@chromium.org>
commit-queue@webkit.org [Wed, 11 Aug 2010 19:33:55 +0000 (19:33 +0000)]
2010-08-11  Fady Samuel  <fsamuel@chromium.org>

        Reviewed by Nikolas Zimmermann.

        RenderSVGRoot::nodeAtPoint truncates translated mouse coordinates
        https://bugs.webkit.org/show_bug.cgi?id=41968

        New layout test checks for proper hit region.

        * platform/chromium-mac/svg/hittest/svg-rect-hit-expected.txt:
        * platform/chromium/test_expectations.txt:
        * svg/hittest/svg-rect-hit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 Aug 2010 18:59:28 +0000 (18:59 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Windows build fix.  Turns out we need to unconditionally include
        HTMLEntityNames.cpp now that LegacyHTMLDocumentParser doesn't exist.

        * html/HTMLEntityParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 11 Aug 2010 18:56:50 +0000 (18:56 +0000)]
2010-08-11  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
        https://bugs.webkit.org/show_bug.cgi?id=42897

        A <source> element inserted as a child of a media element with a networkState of NETWORK_EMPTY
        should cause the networkState to immediately change to NETWORK_NO_SOURCE.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Remove unused variable m_processingLoad.
        (WebCore::HTMLMediaElement::prepareForLoad): Set m_networkState to NETWORK_NO_SOURCE.
        (WebCore::HTMLMediaElement::loadInternal): Remove unused variable m_processingLoad.
        (WebCore::HTMLMediaElement::selectMediaResource): No need to change m_networkState, it was done in prepareForLoad.
        * html/HTMLMediaElement.h:

        * html/HTMLSourceElement.cpp:
        (WebCore::HTMLSourceElement::insertedIntoTree): Renamed from insertedIntoDocument because we want
        to do this setup whether or not the parent media element is in the document.
        * html/HTMLSourceElement.h:

2010-08-11  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Inserting a <source> element should immediately set networkState to NETWORK_NO_SOURCE.
        https://bugs.webkit.org/show_bug.cgi?id=42897

        * media/remove-from-document-no-load-expected.txt:
        * media/remove-from-document-no-load.html:
        * media/video-pause-empty-events-expected.txt:
        * media/video-pause-empty-events.html:
        * media/video-source-inserted-expected.txt: Added.
        * media/video-source-inserted.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Rafael Antognolli <antognolli@profusion.mobi>
commit-queue@webkit.org [Wed, 11 Aug 2010 18:49:38 +0000 (18:49 +0000)]
2010-08-11  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add setting for enabling spatial navigation.
        https://bugs.webkit.org/show_bug.cgi?id=43569

        Adding api for enabling/disabling spatial navigation.

        * ewk/ewk_view.cpp: Both functions below added.
        (ewk_view_setting_spatial_navigation_get):
        (ewk_view_setting_spatial_navigation_set):
        * ewk/ewk_view.h: same as ewk_view.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 11 Aug 2010 18:48:42 +0000 (18:48 +0000)]
2010-08-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Build fix, turn off yet-unbaked DEVICE_ORIENTATION stuff.

        * features.gypi: Turned it off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 11 Aug 2010 18:31:09 +0000 (18:31 +0000)]
2010-08-11  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Delete LegacyHTMLDocumentParser and LegacyPreloadScanner
        https://bugs.webkit.org/show_bug.cgi?id=43836

        These classes are bit-rotting disturbingly quickly.  We removed the
        last dependencies on these classes and so we can remove them.

        We might need to preserve some of their particular quirks to handle
        some legacy applications, but our current thinking is to do that with
        individual settings that affect the new parser.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        * dom/DocumentFragment.cpp:
        (WebCore::DocumentFragment::parseHTML):
        * dom/DocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        * dom/XMLDocumentParserQt.cpp:
        * html/HTMLConstructionSite.cpp:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createParser):
        * html/HTMLEntityParser.cpp:
        (WebCore::decodeNamedEntity):
        * html/HTMLEntityParser.h:
        * html/HTMLFormControlElement.cpp:
        * html/HTMLTreeBuilder.cpp:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createParser):
        * html/LegacyHTMLDocumentParser.cpp: Removed.
        * html/LegacyHTMLDocumentParser.h: Removed.
        * html/LegacyHTMLTreeBuilder.cpp:
        * html/LegacyPreloadScanner.cpp: Removed.
        * html/LegacyPreloadScanner.h: Removed.
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
        (WebCore::FTPDirectoryDocumentParser::appendEntry):
        (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
        (WebCore::processFilesizeString):
        (WebCore::wasLastDayOfMonth):
        (WebCore::processFileDateString):
        (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):
        (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
        (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
        (WebCore::FTPDirectoryDocumentParser::append):
        (WebCore::FTPDirectoryDocumentParser::finish):
        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::decodeHTMLEntities):
        * page/XSSAuditor.h:
        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::prepend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Wed, 11 Aug 2010 18:31:00 +0000 (18:31 +0000)]
2010-08-11  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Eric Seidel.

        Check in a script to list redundant test outputs.
        https://bugs.webkit.org/show_bug.cgi?id=37630

        If e.g. platform/mac-leopard is missing an expected test output, we
        fall back on platform/mac.  This means it's possible to grow redundant
        test outputs, where we have the same expected data in both a platform
        directory and another platform it falls back on.
        (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)

        * Scripts/deduplicate-tests: Added.
        * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 11 Aug 2010 18:01:57 +0000 (18:01 +0000)]
2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
        https://bugs.webkit.org/show_bug.cgi?id=43853

        LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
        It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
        QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
        to slots at all.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):
        (LauncherWindow::animatedFlip):
        (LauncherWindow::animatedYFlip):
        * QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Wed, 11 Aug 2010 17:40:23 +0000 (17:40 +0000)]
2010-08-11  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        Refactored FrameLoader::createWindow() out of the FrameLoader class
        since FrameLoader should not be responsible for creating windows.

        https://bugs.webkit.org/show_bug.cgi?id=39156

        No new functionality, so no new tests.

        * bindings/generic/BindingDOMWindow.h:
        (WebCore::::createWindow):
          - Updated the call to FrameLoader's createWindow().
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
          - Updated the call to FrameLoader's createWindow().
        * loader/FrameLoader.cpp:
        (WebCore::createWindowFromFrameLoader):
          - Made FrameLoader::createWindow() non-member, non-friend and changed it
            to accept Frame* parameters instead of FrameLoader*.
        * loader/FrameLoader.h:
          - Updated the header file to reflect the above change to FrameLoader.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Wed, 11 Aug 2010 17:14:54 +0000 (17:14 +0000)]
2010-08-11  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        Implementation dispatchDecidePolicyForNavigationAction
        https://bugs.webkit.org/show_bug.cgi?id=43544

        Add ewk_view_navigation_policy_decision to decide whether url which
        user clicked will be loaded or not.

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (ewk_view_navigation_policy_decision):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Aug 2010 16:55:10 +0000 (16:55 +0000)]
2010-08-11  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium rebaseline.

        Tweak win pixel results for svg/batik/text/textFeatures.svg.

        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.checksum:
        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-win-vista/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.checksum:
        * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 11 Aug 2010 16:31:03 +0000 (16:31 +0000)]
2010-08-11  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed.

        New baselines for the mathml tests.

        * platform/gtk/mathml/presentation/sub-expected.txt:
        * platform/gtk/mathml/presentation/sup-expected.txt:
        * platform/gtk/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 11 Aug 2010 15:57:13 +0000 (15:57 +0000)]
2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
        https://bugs.webkit.org/show_bug.cgi?id=43851

        All window options data (including the bool holding if the view is either QWebView or
        QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
        When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
        not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
        getting broken.

        Patch addresses this issue.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):
        (LauncherWindow::toggleWebView):
        (LauncherWindow::toggleAcceleratedCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-10 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Wed, 11 Aug 2010 15:56:40 +0000 (15:56 +0000)]
2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
        https://bugs.webkit.org/show_bug.cgi?id=43831

        Only instantiate QStateMachine and friends associated to the YRotation action on demand.

        * QtTestBrowser/webview.cpp:
        (WebViewGraphicsBased::WebViewGraphicsBased):
        (WebViewGraphicsBased::animatedYFlip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Wed, 11 Aug 2010 15:33:54 +0000 (15:33 +0000)]
2010-08-11  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Unreviewed build fix.

        [Qt] Update WebKit2 build environment, add stub implementation of SharedMemory.

        * DerivedSources.pro:
        * Platform/qt/SharedMemoryQt.cpp: Added.
        (WebKit::SharedMemory::Handle::Handle):
        (WebKit::SharedMemory::Handle::~Handle):
        (WebKit::SharedMemory::Handle::encode):
        (WebKit::SharedMemory::Handle::decode):
        (WebKit::SharedMemory::create):
        (WebKit::SharedMemory::~SharedMemory):
        (WebKit::SharedMemory::createHandle):
        (WebKit::SharedMemory::systemPageSize):
        * WebKit2.pro:
        * WebKit2Prefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Aug 2010 15:08:35 +0000 (15:08 +0000)]
2010-08-11  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium rebaseline.

        New results and expectations tweak for http://trac.webkit.org/changeset/65138.

        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect-expected.png:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-linux/svg/batik/text/textProperties-expected.checksum:
        * platform/chromium-linux/svg/batik/text/textProperties-expected.png:
        * platform/chromium-linux/svg/custom/non-opaque-filters-expected.checksum:
        * platform/chromium-linux/svg/custom/non-opaque-filters-expected.png:
        * platform/chromium-linux/svg/custom/recursive-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/recursive-filter-expected.png:
        * platform/chromium-linux/svg/custom/text-filter-expected.checksum:
        * platform/chromium-linux/svg/custom/text-filter-expected.png: Added.
        * platform/chromium-linux/svg/filters/feGaussianBlur-expected.checksum: Removed.
        * platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.checksum:
        * platform/chromium-linux/svg/filters/filter-on-filter-for-text-expected.png: Added.
        * platform/chromium-linux/svg/filters/shadow-on-filter-expected.checksum: Removed.
        * platform/chromium-linux/svg/filters/shadow-on-filter-expected.png: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
        * platform/chromium-win/svg/batik/text/textEffect-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect-expected.png:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.checksum:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.png:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.checksum:
        * platform/chromium-win/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-win/svg/batik/text/textProperties-expected.checksum:
        * platform/chromium-win/svg/batik/text/textProperties-expected.png:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.checksum:
        * platform/chromium-win/svg/custom/non-opaque-filters-expected.png:
        * platform/chromium-win/svg/custom/recursive-filter-expected.checksum:
        * platform/chromium-win/svg/custom/recursive-filter-expected.png:
        * platform/chromium-win/svg/custom/text-filter-expected.checksum:
        * platform/chromium-win/svg/custom/text-filter-expected.png:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.checksum:
        * platform/chromium-win/svg/filters/feGaussianBlur-expected.png:
        * platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.checksum:
        * platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.png:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.checksum:
        * platform/chromium-win/svg/filters/shadow-on-filter-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 11 Aug 2010 14:56:11 +0000 (14:56 +0000)]
2010-08-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: small refactoring for CodeGeneratorInspector.
        all "notify" methods are generating in InspectorFrontend
        the other methods are generating in InspectorBackend.
        https://bugs.webkit.org/show_bug.cgi?id=43849

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
commit-queue@webkit.org [Wed, 11 Aug 2010 14:43:42 +0000 (14:43 +0000)]
2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] Misc improvements to the scrolling code
        https://bugs.webkit.org/show_bug.cgi?id=41926

        Refactor code that uses deprecated ways of dealing with the
        adjustments to use the GtkVersioning infrastructure.

        * GNUmakefile.am:
        * platform/gtk/GtkVersioning.cpp: Added.
        * platform/gtk/GtkVersioning.h:
        * platform/gtk/ScrollViewGtk.cpp:
        * platform/gtk/ScrollbarGtk.cpp:
        (ScrollbarGtk::detachAdjustment):
        (ScrollbarGtk::updateThumbPosition):
        (ScrollbarGtk::updateThumbProportion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update the Symbian def files
hausmann@webkit.org [Wed, 11 Aug 2010 14:37:40 +0000 (14:37 +0000)]
[Qt] Update the Symbian def files

Re-freeze with various QGraphicsWebView and DRT updates.
The uppper part of the diff is just whitespace, so
diff -w will show the real diff.

* symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 11 Aug 2010 13:51:02 +0000 (13:51 +0000)]
2010-08-11  Nate Chapin  <japhet@chromium.org>

        Chromium mac build fix (variables weren't being initialized).

        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::apply): Initalize dxLeft, dxRight, dyLeft, dyRight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Evan Stade <estade@chromium.org>
estade@chromium.org [Wed, 11 Aug 2010 13:45:01 +0000 (13:45 +0000)]
2010-08-11  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        [chromium] linux chromium sends double clicks too often
        https://bugs.webkit.org/show_bug.cgi?id=43096

        * WebKit.gyp: add the test
        * src/gtk/WebInputEventFactory.cpp:
        (WebKit::WebInputEventFactory::mouseEvent): check the x/y coordinates of the
        potential double click event
        * tests/WebInputEventFactoryTestGtk.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Wed, 11 Aug 2010 13:27:33 +0000 (13:27 +0000)]
2010-08-11  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Rebaseline Chromium test.

        * platform/chromium-win/http/tests/loading/bad-scheme-subframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 11 Aug 2010 13:27:04 +0000 (13:27 +0000)]
2010-08-11  Gabor Loki  <loki@webkit.org>

        Qt build fix (ARMv7).

        Fix invalid conversion from int to Condition.
        Add ARMv7Assembler.cpp to JavaScriptCore.pro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 11 Aug 2010 13:12:08 +0000 (13:12 +0000)]
2010-08-11  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: apply correct fix to storage panel status bar buttons.

        https://bugs.webkit.org/show_bug.cgi?id=43846

        * inspector/front-end/DatabaseTableView.js:
        (WebInspector.DatabaseTableView.prototype.get statusBarItems):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype._genericViewSetup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65149 268f45cc-cd09-0410-ab3c-d52691b4dbfc