WebKit-https.git
11 years ago2010-02-02 Jessie Berlin <jberlin@webkit.org>
jberlin@webkit.org [Tue, 2 Feb 2010 15:35:41 +0000 (15:35 +0000)]
2010-02-02  Jessie Berlin  <jberlin@webkit.org>

        Rubber Stamped by Holger Freyther.

        [Qt] Fix style issue identified in bug:
        https://bugs.webkit.org/show_bug.cgi?id=34329

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientWebPage::InspectorClientWebPage):
        Fix indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Tue, 2 Feb 2010 15:29:32 +0000 (15:29 +0000)]
2010-02-02  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Symbian plugins include a wrong header file for QPixmap
        https://bugs.webkit.org/show_bug.cgi?id=34475

        * plugins/symbian/PluginViewSymbian.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Tue, 2 Feb 2010 15:28:11 +0000 (15:28 +0000)]
2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Moved filter-related check-webkit-style code into a separate
        filter module.

        https://bugs.webkit.org/show_bug.cgi?id=34408

        This is preparatory refactoring for Bug 33684, which will allow
        file and folder-specific filter rules.

        * Scripts/webkitpy/style/checker.py:
          - Removed CategoryFilter class (moved to filter.py).

        * Scripts/webkitpy/style/checker_unittest.py:
          - Removed CategoryFilter unit tests (moved to filter_unittest.py).

        * Scripts/webkitpy/style/filter.py: Added.
          - Added CategoryFilter class (moved from checker.py).

        * Scripts/webkitpy/style/filter_unittest.py: Added.
          - Added CategoryFilter unit tests (moved from checker_unittest.py).

        * Scripts/webkitpy/style/unittests.py:
          - Added reference to filter_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Jessie Berlin <jberlin@webkit.org>
jberlin@webkit.org [Tue, 2 Feb 2010 15:25:18 +0000 (15:25 +0000)]
2010-02-01  Jessie Berlin  <jberlin@webkit.org>

        Reviewed by Holger Freyther.

        [Qt] Enable inspecting the Web Inspector in QtLauncher

        https://bugs.webkit.org/show_bug.cgi?id=34329

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientWebPage::InspectorClientWebPage):
        Allow the DeveloperExtrasEnabled setting to default to true for the page containing the Web Inspector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 2 Feb 2010 14:22:32 +0000 (14:22 +0000)]
2010-02-02  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Upstream DevTools code.

        https://bugs.webkit.org/show_bug.cgi?id=34326

        * WebKit.gyp:
        * src/APUAgentDelegate.h: Added.
        * src/BoundObject.cpp: Added.
        (WebKit::BoundObject::BoundObject):
        (WebKit::BoundObject::~BoundObject):
        (WebKit::BoundObject::addProtoFunction):
        (WebKit::BoundObject::build):
        * src/BoundObject.h: Added.
        * src/DebuggerAgent.h: Added.
        * src/DebuggerAgentImpl.cpp: Added.
        (WebKit::DebuggerAgentImpl::DebuggerAgentImpl):
        (WebKit::DebuggerAgentImpl::~DebuggerAgentImpl):
        (WebKit::DebuggerAgentImpl::getContextId):
        (WebKit::DebuggerAgentImpl::debuggerOutput):
        (WebKit::DebuggerAgentImpl::createUtilityContext):
        (WebKit::DebuggerAgentImpl::executeUtilityFunction):
        (WebKit::DebuggerAgentImpl::executeVoidJavaScript):
        (WebKit::DebuggerAgentImpl::page):
        * src/DebuggerAgentImpl.h: Added.
        (WebKit::DebuggerAgentImpl::setAutoContinueOnException):
        (WebKit::DebuggerAgentImpl::autoContinueOnException):
        (WebKit::DebuggerAgentImpl::webdevtoolsAgent):
        (WebKit::DebuggerAgentImpl::webView):
        * src/DebuggerAgentManager.cpp: Added.
        (WebKit::DebuggerAgentManager::debugHostDispatchHandler):
        (WebKit::DebuggerAgentManager::debugAttach):
        (WebKit::DebuggerAgentManager::debugDetach):
        (WebKit::DebuggerAgentManager::onV8DebugMessage):
        (WebKit::DebuggerAgentManager::pauseScript):
        (WebKit::DebuggerAgentManager::executeDebuggerCommand):
        (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
        (WebKit::DebuggerAgentManager::setHostId):
        (WebKit::DebuggerAgentManager::onWebViewClosed):
        (WebKit::DebuggerAgentManager::onNavigate):
        (WebKit::DebuggerAgentManager::sendCommandToV8):
        (WebKit::DebuggerAgentManager::sendContinueCommandToV8):
        (WebKit::DebuggerAgentManager::findAgentForCurrentV8Context):
        (WebKit::DebuggerAgentManager::debuggerAgentForHostId):
        * src/DebuggerAgentManager.h: Added.
        (WebKit::DebuggerAgentManager::UtilityContextScope::UtilityContextScope):
        (WebKit::DebuggerAgentManager::UtilityContextScope::~UtilityContextScope):
        * src/DevToolsRPC.h: Added.
        (WebKit::):
        (WebKit::DevToolsRPC::Delegate::Delegate):
        (WebKit::DevToolsRPC::Delegate::~Delegate):
        (WebKit::DevToolsRPC::DevToolsRPC):
        (WebKit::DevToolsRPC::~DevToolsRPC):
        (WebKit::DevToolsRPC::sendRpcMessage):
        * src/DevToolsRPCJS.h: Added.
        * src/ProfilerAgent.h: Added.
        * src/ProfilerAgentImpl.cpp: Added.
        (WebKit::ProfilerAgentImpl::getActiveProfilerModules):
        (WebKit::ProfilerAgentImpl::getLogLines):
        * src/ProfilerAgentImpl.h: Added.
        (WebKit::ProfilerAgentImpl::ProfilerAgentImpl):
        (WebKit::ProfilerAgentImpl::~ProfilerAgentImpl):
        * src/ToolsAgent.h: Added.
        * src/WebDevToolsAgentImpl.cpp: Added.
        (WebKit::):
        (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
        (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
        (WebKit::WebDevToolsAgentImpl::disposeUtilityContext):
        (WebKit::WebDevToolsAgentImpl::unhideResourcesPanelIfNecessary):
        (WebKit::WebDevToolsAgentImpl::attach):
        (WebKit::WebDevToolsAgentImpl::detach):
        (WebKit::WebDevToolsAgentImpl::didNavigate):
        (WebKit::WebDevToolsAgentImpl::didCommitProvisionalLoad):
        (WebKit::WebDevToolsAgentImpl::didClearWindowObject):
        (WebKit::WebDevToolsAgentImpl::forceRepaint):
        (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
        (WebKit::WebDevToolsAgentImpl::dispatchOnInjectedScript):
        (WebKit::WebDevToolsAgentImpl::executeVoidJavaScript):
        (WebKit::WebDevToolsAgentImpl::dispatchMessageFromFrontend):
        (WebKit::WebDevToolsAgentImpl::inspectElementAt):
        (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
        (WebKit::WebDevToolsAgentImpl::sendRpcMessage):
        (WebKit::WebDevToolsAgentImpl::compileUtilityScripts):
        (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost):
        (WebKit::WebDevToolsAgentImpl::createInspectorBackendV8Wrapper):
        (WebKit::WebDevToolsAgentImpl::resetInspectorFrontendProxy):
        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):
        (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient):
        (WebKit::WebDevToolsAgentImpl::jsDispatchToApu):
        (WebKit::WebDevToolsAgentImpl::jsEvaluateOnSelf):
        (WebKit::WebDevToolsAgentImpl::jsOnRuntimeFeatureStateChanged):
        (WebKit::WebDevToolsAgentImpl::inspectorController):
        (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
        (WebKit::WebDevToolsAgentImpl::willSendRequest):
        (WebKit::WebDevToolsAgentImpl::didReceiveData):
        (WebKit::WebDevToolsAgentImpl::didReceiveResponse):
        (WebKit::WebDevToolsAgentImpl::didFinishLoading):
        (WebKit::WebDevToolsAgentImpl::didFailLoading):
        (WebKit::WebDevToolsAgentImpl::evaluateInWebInspector):
        (WebKit::WebDevToolsAgentImpl::setTimelineProfilingEnabled):
        (WebKit::WebDevToolsAgent::create):
        (WebKit::WebDevToolsAgent::executeDebuggerCommand):
        (WebKit::WebDevToolsAgent::debuggerPauseScript):
        (WebKit::WebDevToolsAgent::setMessageLoopDispatchHandler):
        (WebKit::WebDevToolsAgent::dispatchMessageFromFrontendOnIOThread):
        * src/WebDevToolsAgentImpl.h: Added.
        (WebKit::WebDevToolsAgentImpl::hostId):
        * src/WebDevToolsFrontendImpl.cpp: Added.
        (WebKit::ToV8String):
        (WebKit::WebDevToolsFrontend::create):
        (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::dispatchMessageFromAgent):
        (WebKit::WebDevToolsFrontendImpl::executeScript):
        (WebKit::WebDevToolsFrontendImpl::dispatchOnWebInspector):
        (WebKit::WebDevToolsFrontendImpl::sendRpcMessage):
        (WebKit::WebDevToolsFrontendImpl::contextMenuItemSelected):
        (WebKit::WebDevToolsFrontendImpl::contextMenuCleared):
        (WebKit::WebDevToolsFrontendImpl::jsLoaded):
        (WebKit::WebDevToolsFrontendImpl::jsPlatform):
        (WebKit::WebDevToolsFrontendImpl::jsPort):
        (WebKit::WebDevToolsFrontendImpl::jsCopyText):
        (WebKit::WebDevToolsFrontendImpl::jsActivateWindow):
        (WebKit::WebDevToolsFrontendImpl::jsCloseWindow):
        (WebKit::WebDevToolsFrontendImpl::jsDockWindow):
        (WebKit::WebDevToolsFrontendImpl::jsUndockWindow):
        (WebKit::WebDevToolsFrontendImpl::jsLocalizedStringsURL):
        (WebKit::WebDevToolsFrontendImpl::jsHiddenPanels):
        (WebKit::WebDevToolsFrontendImpl::jsDebuggerCommand):
        (WebKit::WebDevToolsFrontendImpl::jsSetting):
        (WebKit::WebDevToolsFrontendImpl::jsSetSetting):
        (WebKit::WebDevToolsFrontendImpl::jsDebuggerPauseScript):
        (WebKit::WebDevToolsFrontendImpl::jsWindowUnloading):
        (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):
        * src/WebDevToolsFrontendImpl.h: Added.
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::create):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::~MenuProvider):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::disconnect):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::populateContextMenu):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuItemSelected):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::contextMenuCleared):
        (WebKit::WebDevToolsFrontendImpl::MenuProvider::MenuProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 2 Feb 2010 13:59:20 +0000 (13:59 +0000)]
2010-02-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: URLs are not syntax-higlighted as links in source view.

        This change enables linkifier in the NativeTextViewer. It adds
        "linkify" and "a_node" parse states into the highlighter in order
        to detect links and distinguish between resource and external ones.
        Contains drive-by fix for the webkit-html-* styles and moves them to the
        common location.

        https://bugs.webkit.org/show_bug.cgi?id=34364

        * inspector/front-end/NativeTextViewer.js:
        (WebInspector.NativeTextViewer):
        (WebInspector.NativeTextViewer.prototype._createSpan):
        (WebInspector.NativeTextViewer.prototype._createLink):
        (WebInspector.NativeTextViewer.prototype._rewriteHref):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.setContent):
        (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute):
        (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue):
        (WebInspector.SourceHTMLTokenizer.prototype._stringToken):
        (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._contentLoaded):
        * inspector/front-end/TextEditorHighlighter.js:
        (WebInspector.TextEditorHighlighter):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspectorSyntaxHighlight.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Tue, 2 Feb 2010 13:32:31 +0000 (13:32 +0000)]
2010-02-02  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] When selection changes selections in other WebView are not collapsed
        https://bugs.webkit.org/show_bug.cgi?id=34043

        Collapse the selection of a WebView even when the new selection owner is
        a new WebView.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting
        is not the same as the one referenced in this callback. Use the same behavior for
        collapsing the selection.
        (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean
        record the actual data used while writing to the clipboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Simon Hausmann <simon.hausmann@nokia.com>
eric@webkit.org [Tue, 2 Feb 2010 13:16:13 +0000 (13:16 +0000)]
2010-02-02  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Install libraries and headers in package builds
        https://bugs.webkit.org/show_bug.cgi?id=34325

        Add the QtWebKit libraries to the installable items, except on
        Symbian where the libraries are always linked in their final
        destination.

        Also include the headers generated by syncqt in the installation.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Tue, 2 Feb 2010 12:59:58 +0000 (12:59 +0000)]
2010-02-02  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Display HTML tags verbatim in JS alert/confirm/prompt boxes

        https://bugs.webkit.org/show_bug.cgi?id=34429

        * Api/qwebpage.cpp:
        (QWebPage::javaScriptAlert):
        (QWebPage::javaScriptConfirm):
        (QWebPage::javaScriptPrompt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kavita Kanetkar <kkanetkar@chromium.org>
eric@webkit.org [Tue, 2 Feb 2010 12:43:40 +0000 (12:43 +0000)]
2010-02-02  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Dmitry Titov.

        [V8] Raising an exception while setting timeout/interval from a detached frame
        https://bugs.webkit.org/show_bug.cgi?id=34453
        This fixes the issue/failing test mentioned in Chromium bug:
        http://code.google.com/p/chromium/issues/detail?id=32671

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::WindowSetTimeoutImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 12:27:19 +0000 (12:27 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port Screen
        https://bugs.webkit.org/show_bug.cgi?id=34299

        Get the screen size and depth from the main display bitmap.

        * platform/brew/ScreenBrew.cpp: Added.
        (WebCore::getDisplayInfo):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 12:10:54 +0000 (12:10 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port LocalizedStrings
        https://bugs.webkit.org/show_bug.cgi?id=34257

        Port LocalizedStrings to BREWMP.

        * platform/brew/LocalizedStringsBrew.cpp: Added.
        (WebCore::submitButtonDefaultLabel):
        (WebCore::inputElementAltText):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::defaultLanguage):
        (WebCore::searchableIndexIntroduction):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
        (WebCore::contextMenuItemTagDownloadLinkToDisk):
        (WebCore::contextMenuItemTagCopyLinkToClipboard):
        (WebCore::contextMenuItemTagOpenImageInNewWindow):
        (WebCore::contextMenuItemTagDownloadImageToDisk):
        (WebCore::contextMenuItemTagCopyImageToClipboard):
        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
        (WebCore::contextMenuItemTagCopy):
        (WebCore::contextMenuItemTagGoBack):
        (WebCore::contextMenuItemTagGoForward):
        (WebCore::contextMenuItemTagStop):
        (WebCore::contextMenuItemTagReload):
        (WebCore::contextMenuItemTagCut):
        (WebCore::contextMenuItemTagPaste):
        (WebCore::contextMenuItemTagNoGuessesFound):
        (WebCore::contextMenuItemTagIgnoreSpelling):
        (WebCore::contextMenuItemTagLearnSpelling):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        (WebCore::contextMenuItemTagOpenLink):
        (WebCore::contextMenuItemTagIgnoreGrammar):
        (WebCore::contextMenuItemTagSpellingMenu):
        (WebCore::contextMenuItemTagShowSpellingPanel):
        (WebCore::contextMenuItemTagCheckSpelling):
        (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
        (WebCore::contextMenuItemTagFontMenu):
        (WebCore::contextMenuItemTagBold):
        (WebCore::contextMenuItemTagItalic):
        (WebCore::contextMenuItemTagUnderline):
        (WebCore::contextMenuItemTagOutline):
        (WebCore::contextMenuItemTagWritingDirectionMenu):
        (WebCore::contextMenuItemTagDefaultDirection):
        (WebCore::contextMenuItemTagLeftToRight):
        (WebCore::contextMenuItemTagRightToLeft):
        (WebCore::contextMenuItemTagInspectElement):
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::unknownFileSizeText):
        (WebCore::AXWebAreaText):
        (WebCore::AXLinkText):
        (WebCore::AXListMarkerText):
        (WebCore::AXImageMapText):
        (WebCore::AXHeadingText):
        (WebCore::imageTitle):
        (WebCore::contextMenuItemTagTextDirectionMenu):
        (WebCore::AXButtonActionVerb):
        (WebCore::AXTextFieldActionVerb):
        (WebCore::AXRadioButtonActionVerb):
        (WebCore::AXCheckedCheckBoxActionVerb):
        (WebCore::AXUncheckedCheckBoxActionVerb):
        (WebCore::AXLinkActionVerb):
        (WebCore::AXMenuListPopupActionVerb):
        (WebCore::AXMenuListActionVerb):
        (WebCore::AXDefinitionListTermText):
        (WebCore::AXDefinitionListDefinitionText):
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageTypeMismatchText):
        (WebCore::validationMessagePatternMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
ossy@webkit.org [Tue, 2 Feb 2010 11:56:09 +0000 (11:56 +0000)]
[Qt] fast/frames/set-unloaded-frame-location.html timed out on Qt Linux Release Build Bot
https://bugs.webkit.org/show_bug.cgi?id=33303

fast/frames/sandboxed-iframe-navigation-windowopen.html made fast/frames/set-unloaded-frame-location.html
time out, but now it works correctly, so we can unskip the test.

* platform/qt/Skipped: fast/frames/sandboxed-iframe-navigation-windowopen.html unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 11:54:39 +0000 (11:54 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port systemBeep
        https://bugs.webkit.org/show_bug.cgi?id=33601

        Implement systemBeep with IShell_Beep.

        * platform/brew/SoundBrew.cpp: Added.
        (WebCore::systemBeep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Tue, 2 Feb 2010 11:38:21 +0000 (11:38 +0000)]
2010-02-02  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable a way to measure FPS in QGVLauncher
        run QGVLauncher with --show-fps to see ongoing fps measurements
        This is not meant as accurate FPS, but rather as a way to find
        improvements/regressions
        https://bugs.webkit.org/show_bug.cgi?id=34450

        * QGVLauncher/main.cpp:
        (MainView::MainView): initialize FPS values
        (MainView::paintEvent): count a painted frame here
        (MainView::printFps): we print the fps with qDebug every 5 seconds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 11:07:19 +0000 (11:07 +0000)]
2010-02-02  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        [Win] Utilize PrintContext to share the printing code with other ports
        https://bugs.webkit.org/show_bug.cgi?id=34312

        No new tests as this is just a small refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 10:54:14 +0000 (10:54 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add HAVE_XXX definitions
        https://bugs.webkit.org/show_bug.cgi?id=34414

        Add HAVE_ERRNO_H=1

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 10:27:21 +0000 (10:27 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add conversions between IntPoint and AEEPoint
        https://bugs.webkit.org/show_bug.cgi?id=34194

        Make it easy to convert between IntPoint and AEEPoint.

        * platform/graphics/IntPoint.h:
        * platform/graphics/brew/IntPointBrew.cpp: Added.
        (WebCore::IntPoint::IntPoint):
        (WebCore::IntPoint::operator AEEPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap...
steveblock@google.com [Tue, 2 Feb 2010 09:58:28 +0000 (09:58 +0000)]
Adds virtual destructors for AbstractWeakReferenceMap and AbstractWeakReferenceMap::Visitor
https://bugs.webkit.org/show_bug.cgi?id=34434

Reviewed by Adam Barth.

No new tests, build fix only.

* bindings/v8/V8DOMMap.h: Modified.
(WebCore::AbstractWeakReferenceMap::~AbstractWeakReferenceMap): Added.
(WebCore::AbstractWeakReferenceMap::Visitor::~Visitor): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 09:46:11 +0000 (09:46 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Don't define HAVE_TM_GMTOFF, HAVE_TM_ZONE and HAVE_TIMEGM
        https://bugs.webkit.org/show_bug.cgi?id=34388

        BREWMP does not have these features.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 09:18:47 +0000 (09:18 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Define WTF_PLATFORM_BREWMP=1 when BUILDING_BREWMP is defined
        https://bugs.webkit.org/show_bug.cgi?id=34386

        Define WTF_PLATFORM_BREWMP=1 so that PLATFORM(BREWMP) guard can be used.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Avi Drissman <avi@chromium.org>
eric@webkit.org [Tue, 2 Feb 2010 08:52:18 +0000 (08:52 +0000)]
2010-02-02  Avi Drissman  <avi@chromium.org>

        Reviewed by Eric Seidel.

        Sync up Chromium Mac render theme to Mac render theme
        https://bugs.webkit.org/show_bug.cgi?id=34340

        Covered by existing layout tests.

        * platform/chromium/ThemeChromiumMac.mm:
        (WebCore::updateStates):
        (WebCore::checkbox):
        (WebCore::paintCheckbox):
        (WebCore::radio):
        (WebCore::paintRadio):
        (WebCore::listButtonSizes):
        (WebCore::setupButtonCell):
        (WebCore::button):
        (WebCore::paintButton):
        (WebCore::ThemeChromiumMac::controlSize):
        (WebCore::ThemeChromiumMac::minimumControlSize):
        (WebCore::ThemeChromiumMac::controlBorder):
        (WebCore::ThemeChromiumMac::paint):
        * rendering/RenderThemeChromiumMac.h:
        * rendering/RenderThemeChromiumMac.mm:
        (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
        (WebCore::convertNSColorToColor):
        (WebCore::RenderThemeChromiumMac::systemColor):
        (WebCore::RenderThemeChromiumMac::isControlStyled):
        (WebCore::RenderThemeChromiumMac::adjustRepaintRect):
        (WebCore::RenderThemeChromiumMac::convertToPaintingRect):
        (WebCore::RenderThemeChromiumMac::paintCapsLockIndicator):
        (WebCore::RenderThemeChromiumMac::paintMenuList):
        (WebCore::RenderThemeChromiumMac::paintMenuListButton):
        (WebCore::RenderThemeChromiumMac::adjustMenuListStyle):
        (WebCore::RenderThemeChromiumMac::adjustMenuListButtonStyle):
        (WebCore::RenderThemeChromiumMac::paintSliderTrack):
        (WebCore::RenderThemeChromiumMac::paintSliderThumb):
        (WebCore::RenderThemeChromiumMac::paintSearchField):
        (WebCore::RenderThemeChromiumMac::setSearchFieldSize):
        (WebCore::RenderThemeChromiumMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeChromiumMac::paintSearchFieldResultsButton):
        (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
        (WebCore::RenderThemeChromiumMac::popupButton):
        (WebCore::RenderThemeChromiumMac::sliderThumbHorizontal):
        (WebCore::RenderThemeChromiumMac::sliderThumbVertical):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 2 Feb 2010 08:52:11 +0000 (08:52 +0000)]
2010-02-01  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add WebSecurityOrigin::createFromString factory
        https://bugs.webkit.org/show_bug.cgi?id=34460

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::createFromString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 08:35:53 +0000 (08:35 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port Logging
        https://bugs.webkit.org/show_bug.cgi?id=34300

        Log calls to notImplemented() by default.

        * platform/brew/LoggingBrew.cpp: Added.
        (WebCore::InitializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 2 Feb 2010 08:25:30 +0000 (08:25 +0000)]
2010-02-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Should not select a word on right-click.
        https://bugs.webkit.org/show_bug.cgi?id=33364

        For non-Mac platforms, do not select a word around the caret when
        a context menu is opening. This behavior is not common in non-Mac
        platforms, and it prevents pasting with a context menu.

        In order that the spell checker works without the selection, we
        introduce WebFrame::selectWordAroundCaret(). We can replace a word
        around the caret with selectWordAroundCaret() + replaceSelection().

        * public/WebFrame.h: Add pure selectWordAroundCaret() declaration.
        * src/ContextMenuClientImpl.cpp:
        (WebKit::selectMisspelledWord): Move word-selection code to
        WebFrameImpl::selectWordAroundPosition(), and clear the selection
        on non-Mac.
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::selectWordAroundPosition):
        (WebKit::WebFrameImpl::selectWordAroundCaret):
        * src/WebFrameImpl.h: Add selectWordAroundCaret() declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-02 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 08:19:22 +0000 (08:19 +0000)]
2010-02-02  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port FileChooser
        https://bugs.webkit.org/show_bug.cgi?id=34261

        Port FileChooser to BREWMP.

        * platform/brew/FileChooserBrew.cpp: Added.
        (WebCore::FileChooser::basenameForWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Tue, 2 Feb 2010 07:56:07 +0000 (07:56 +0000)]
2010-02-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        Allow custom memory allocation control for IconDatabaseClient class
        https://bugs.webkit.org/show_bug.cgi?id=33252

        Inherits the following struct from Noncopyable because it is
        instantiated by 'new' and no need to be copyable:

        class name               - instantiated at: WebCore/'location'
        class IconDatabaseClient - loader/icon/IconDatabase.cpp:89

        * loader/icon/IconDatabaseClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCheck in new expected results for a test that has been failing on Windows
bweinstein@apple.com [Tue, 2 Feb 2010 07:51:26 +0000 (07:51 +0000)]
Check in new expected results for a test that has been failing on Windows
since it was originally landed. This appears to be a font issue, but commenting
on bug <https://bugs.webkit.org/show_bug.cgi?id=34234> to make sure.

* platform/win/fast/text/international/hebrew-vowels-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 07:46:06 +0000 (07:46 +0000)]
2010-02-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port MIMETypeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=34220

        Port MIMETypeRegistry with an extension map as other ports do.

        * platform/brew: Added.
        * platform/brew/MIMETypeRegistryBrew.cpp: Added.
        (WebCore::):
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert r54194 that fails new test on Qt and Chromium.
dimich@chromium.org [Tue, 2 Feb 2010 06:53:34 +0000 (06:53 +0000)]
Revert r54194 that fails new test on Qt and Chromium.
https://bugs.webkit.org/show_bug.cgi?id=34382

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAddressed FIXME in check-webkit-style so that the carriage-return
cjerdonek@webkit.org [Tue, 2 Feb 2010 06:41:28 +0000 (06:41 +0000)]
Addressed FIXME in check-webkit-style so that the carriage-return
check will work for patches.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34260

Also added support for limiting the number of errors reported
per category, per file.

* Scripts/webkitpy/style/checker.py:
  - Added new "whitespace/carriage_return" category from common.py.
  - Added MAX_REPORTS_PER_CATEGORY dictionary.
  - Added max_reports_per_category attribute to ProcessorOptions class.
  - Refactored StyleChecker._process_file().

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated ProcessorOptionsTest tests.
  - Added test to check MAX_REPORTS_PER_CATEGORY.

* Scripts/webkitpy/style/error_handlers.py:
  - Added support for suppressing the display of errors after
    reaching a per-category maximum (from max_reports_per_category).

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Added test for suppressing error display.

* Scripts/webkitpy/style/processors/common.py: Added.
  - Moved carriage-return check to new file.

* Scripts/webkitpy/style/processors/common_unittest.py: Added.
  - Added unit tests for carriage-return check.

* Scripts/webkitpy/style/unittests.py:
  - Added reference to common_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 06:28:19 +0000 (06:28 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Provide a way to get page number with layoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33840

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * printing/page-break-always-expected.txt: Added.
        * printing/page-break-always.html: Added.
        * printing/pageNumerForElementById-expected.txt: Added.
        * printing/pageNumerForElementById.html: Added.
        * printing/script-tests/TEMPLATE.html: Added.
        * printing/script-tests/page-break-always.js: Added.
        (createParagraph):
        * printing/script-tests/pageNumerForElementById.js: Added.
        (createParagraph):
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Provide a way to get page number with layoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33840

        Test: printing/page-break-always.html

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageRect): Added a getter function.
        (WebCore::PrintContext::computePageRects): Move its logic into computePageRectsWithPageSize.
        (WebCore::PrintContext::computePageRectsWithPageSize): Factored out from computePageRects for pageNumberForElement.
        (WebCore::enclosingBoxModelObject): Added for pageNumberForElement.
        (WebCore::PrintContext::pageNumberForElement): Added for testing.
        * page/PrintContext.h:
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Provide a way to get page number with layoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33840

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame pageNumberForElement:element:pageWidth:]):
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Provide a way to get page number with layoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=33840

        * DumpRenderTree/LayoutTestController.cpp:
        (pageNumberForElementByIdCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::pageNumberForElementById):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 06:19:37 +0000 (06:19 +0000)]
2010-02-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add conversions between IntSize and AEESize
        https://bugs.webkit.org/show_bug.cgi?id=34197

        Make it easy to convert between IntSize and AEESize.

        * platform/graphics/IntSize.h:
        * platform/graphics/brew/IntSizeBrew.cpp: Added.
        (WebCore::IntSize::IntSize):
        (WebCore::IntSize::operator AEESize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Stephen White <senorblanco@chromium.org>
eric@webkit.org [Tue, 2 Feb 2010 05:36:40 +0000 (05:36 +0000)]
2010-02-01  Stephen White  <senorblanco@chromium.org>

        Reviewed by Eric Seidel.

        Fix for Pattern transformations in Chromium/Skia.  This required
        reworking Pattern a bit to be more like the Gradient implementation.
        In particular, it now holds an m_pattern reference to the
        platform-specific implementation, and passes along changes to the
        m_patternSpaceTransformation, in the same way that Gradient does for
        m_gradientSpaceTransformation.  This is necessary since Skia creates the
        platform-specific pattern (SkShader) once, rather than recreating it
        on each draw.
        For platforms other than Skia, m_pattern is unused, they will
        continue to use the static createPlatformPattern(), and the new
        notification functions are stubbed out.  Other platforms can switch to
        the new implementation if they so choose.

        https://bugs.webkit.org/show_bug.cgi?id=24534

        Covered by svg/custom/pattern-y-offset.svg,
        svg/custom/pattern-cycle-detection.svg, and many more.

        * platform/graphics/Pattern.cpp:
        (WebCore::Pattern::Pattern):
        Initializer for m_pattern.
        (WebCore::Pattern::~Pattern):
        call platformDestroy().
        (WebCore::Pattern::setPatternSpaceTransform):
        Pass along the transform via setPlatformPatternSpaceTransform().
        (WebCore::Pattern::platformDestroy):
        (WebCore::Pattern::setPlatformPatternSpaceTransform):
        Stub implementations for non-skia platforms.
        * platform/graphics/Pattern.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformFillPattern):
        (WebCore::GraphicsContext::setPlatformStrokePattern):
        Call platformPattern() instead of static version.
        Since Pattern now owns its SkShader, no need to unref here.
        * platform/graphics/skia/PatternSkia.cpp:
        (WebCore::Pattern::platformDestroy):
        Unref the SkShader on destroy.
        (WebCore::Pattern::platformPattern):
        Create the platform pattern (SkShader) once, and cache it.
        (WebCore::Pattern::setPlatformPatternSpaceTransform):
        Set the shader's local matrix from the m_patternSpaceTransformation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 2 Feb 2010 05:13:33 +0000 (05:13 +0000)]
2010-02-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27312

        Implements support for full page blocking via the X-XSS-Protection header.

        Tests: http/tests/security/xssAuditor/full-block-base-href.html
               http/tests/security/xssAuditor/full-block-get-from-iframe.html
               http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
               http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
               http/tests/security/xssAuditor/full-block-javascript-link.html
               http/tests/security/xssAuditor/full-block-link-onclick.html
               http/tests/security/xssAuditor/full-block-object-tag.html
               http/tests/security/xssAuditor/full-block-post-from-iframe.html
               http/tests/security/xssAuditor/full-block-script-tag-with-source.html
               http/tests/security/xssAuditor/full-block-script-tag.html
               http/tests/security/xssAuditor/malformed-xss-protection-header.html

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added.
        (WebCore::XSSAuditor::findInRequest): Modified to call method
        XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
        * page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader
        and fixed misspelled words in large comment block.
2010-02-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=27312

        Tests that the header "X-XSS-Protection: full-block" leads to a full page block
        when an XSS attack is detected.

        * http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-base-href.html: Added.
        * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
        * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
        * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
        * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
        * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
        * http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-object-tag.html: Added.
        * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
        * http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
        * http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
        * http/tests/security/xssAuditor/full-block-script-tag.html: Added.
        * http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
        * http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
        * http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally
        enable full page blocking.
        * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
        * http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
        * http/tests/security/xssAuditor/resources/utilities.js:
        (checkIfFrameLocationMatchesURLAndCallDone): Added.
        (sendRequestFromIFrame): Modified to optionally call callback function when done.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 05:10:43 +0000 (05:10 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dmitry Titov.

        Convert textarea-rows-cols.html to dumpAsText()
        https://bugs.webkit.org/show_bug.cgi?id=34074

        Remove checks for the size of scrollbar as scrollbar doesn't
        appear on Windows.

        * fast/forms/script-tests/textarea-rows-cols.js:
        * fast/forms/textarea-rows-cols-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 05:01:53 +0000 (05:01 +0000)]
2010-02-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port SharedTimer with IShell_SetTimerEx.
        https://bugs.webkit.org/show_bug.cgi?id=33599

        As fireTime passed in setSharedTimerFireTime is the absolute time,
        we must calcalute the interval by subtracting currentTime() from
        fireTime and pass the result to ISHELL_SetTimerEx.

        * platform/brew/SharedTimerBrew.cpp: Added.
        (WebCore::invokeCallback):
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 2 Feb 2010 04:56:28 +0000 (04:56 +0000)]
2010-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Date.UTC() should apply TimeClip operation.
        https://bugs.webkit.org/show_bug.cgi?id=34461

        ECMAScript 5 15.9.4.3:
        > 9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).

        * runtime/DateConstructor.cpp:
        (JSC::dateUTC): Calls WTF::timeClip().

2010-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Date.UTC() should apply TimeClip operation.
        https://bugs.webkit.org/show_bug.cgi?id=34461

        Add tests for corner cases of Date.UTC().

        * fast/js/date-utc-timeclip-expected.txt: Added.
        * fast/js/date-utc-timeclip.html: Added.
        * fast/js/script-tests/date-utc-timeclip.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 2 Feb 2010 04:48:52 +0000 (04:48 +0000)]
2010-02-01  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Add two more test cases which I forgot to add in r54197.
        https://bugs.webkit.org/show_bug.cgi?id=34462

        * fast/js/math-expected.txt:
        * fast/js/script-tests/math.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 2 Feb 2010 04:42:43 +0000 (04:42 +0000)]
2010-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that Math.round() retunrs incorrect results for huge integers
        https://bugs.webkit.org/show_bug.cgi?id=34462

        * runtime/MathObject.cpp:
        (JSC::mathProtoFuncRound): Avoid "arg + 0.5".

2010-02-01  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that Math.round() retunrs incorrect results for huge integers
        https://bugs.webkit.org/show_bug.cgi?id=34462

        * fast/js/math-expected.txt:
        * fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 04:13:58 +0000 (04:13 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        [Chromium] Unreviewed attempt to fix the chromium build.

        Corresponding change: http://trac.webkit.org/changeset/54182

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::processingUserGesture):
        * bindings/v8/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 03:19:09 +0000 (03:19 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed attempt to fix the broken build.

        This was introduced in http://trac.webkit.org/changeset/54182

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::performMediaPlayerAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWhen a live iframe element is moved between pages, it still depends on the old page.
dimich@chromium.org [Tue, 2 Feb 2010 03:14:14 +0000 (03:14 +0000)]
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382

Reviewed by David Levin.

WebCore:

Test: fast/frames/iframe-reparenting-new-page.html

* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::setName):
Move the code setting the frame name into a separate function.

(WebCore::HTMLFrameElementBase::setNameAndOpenURL):
(WebCore::HTMLFrameElementBase::updateLiveFrame):
Update frame tree, reset page in the contentFrame and re-set the name.

(WebCore::HTMLFrameElementBase::insertedIntoDocument):
* html/HTMLFrameElementBase.h:

* page/Frame.cpp:
(WebCore::Frame::setPage):
* page/Frame.h: Add setPage method. It is only currently used when iframe is
                moved between pages (so the ASSERT(m_ownerElement).

LayoutTests:

* fast/frames/iframe-reparenting-new-page-expected.txt: Added.
* fast/frames/iframe-reparenting-new-page.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
* fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Add common IRC ports to port blocking.
beidson@apple.com [Tue, 2 Feb 2010 03:06:31 +0000 (03:06 +0000)]
WebCore: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451

Reviewed by Tim Hatcher.

* platform/KURL.cpp:
(WebCore::portAllowed):

LayoutTests: Add common IRC ports to port blocking.
<rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
* platform/mac-tiger/security/block-test-expected.txt:
* platform/mac/security/block-test-expected.txt:
* security/block-test.html:

Reviewed by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 02:45:36 +0000 (02:45 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed fix for an invalid function call.

        check-webkit-style: Remove filename parameter from all functions where no longer used
        https://bugs.webkit.org/show_bug.cgi?id=34249

        * Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-27 Matt Perry <mpcomplete@chromium.org>
jorlow@chromium.org [Tue, 2 Feb 2010 02:43:01 +0000 (02:43 +0000)]
2010-01-27  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Eric Seidel.

        Add support for addUserScript to chromium port.

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::addUserScript):
        (WebKit::WebViewImpl::removeAllUserContent):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 2 Feb 2010 02:42:14 +0000 (02:42 +0000)]
2010-01-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Add compile time guards for IndexedDB custom functions
        https://bugs.webkit.org/show_bug.cgi?id=34368

        * bindings/v8/custom/V8IDBRequestCustom.cpp:
        * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 2 Feb 2010 01:33:52 +0000 (01:33 +0000)]
2010-02-01  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port WTF's currentTime
        https://bugs.webkit.org/show_bug.cgi?id=33567

        Combine GETUTCSECONDS and GETTIMEMS to calculate the number
        of milliseconds since 1970/01/01 00:00:00 UTC.

        * wtf/CurrentTime.cpp:
        (WTF::currentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 34346 - With JSC bindings, make processingUserGesture work with events in Isolate...
barraclough@apple.com [Tue, 2 Feb 2010 01:20:12 +0000 (01:20 +0000)]
Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds

WebCore:

Reviewed by Sam Weinig + Oliver Hunt.

Change HTMLMediaElement methods that require checking whether the event is a user gesture to
be passed a boolean.  This may be passed from the JSC bindings (where we have an exec state),
or read from the event.  Add a Flag to the IDL to mark this information is required.

* WebCore.Video.exp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::processingUserGesture):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::domWindowAllowPopUp):
(WebCore::JSDOMWindow::open):
(WebCore::JSDOMWindow::showModalDialog):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGesture):
(WebCore::ScriptController::processingUserGestureEvent):
(WebCore::ScriptController::anyPageIsProcessingUserGesture):
* bindings/js/ScriptController.h:
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Event.cpp:
(WebCore::Event::isUserEvent):
* dom/Event.h:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromDocument):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::documentDidBecomeActive):
(WebCore::HTMLMediaElement::webkitEnterFullScreen):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isProcessingUserGesture):
* loader/MediaDocument.cpp:
(WebCore::MediaDocument::defaultEventHandler):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlSeekButtonElement::defaultEventHandler):

WebKit/mac:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

* WebView/WebVideoFullscreenHUDWindowController.mm:
(-[WebVideoFullscreenHUDWindowController setPlaying:]):

WebKit/win:

Reviewed by Sam Weinig + Oliver Hunt.

Pass processeing user gensture flag to media play/pause methods.

* FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):

LayoutTests:

Reviewed by Sam Weinig.

* http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
* http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
* http/tests/security/isolatedWorld/userGestureEvents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Tue, 2 Feb 2010 01:16:48 +0000 (01:16 +0000)]
2010-02-01  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Use the fallback style on Maemo 5

        https://bugs.webkit.org/show_bug.cgi?id=34376

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::RenderThemeQt):
        (WebCore::RenderThemeQt::fallbackStyle):
        (WebCore::RenderThemeQt::qStyle):
        (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org>
eric@webkit.org [Tue, 2 Feb 2010 01:00:20 +0000 (01:00 +0000)]
2010-02-01  Kavita Kanetkar  <kkanetkar@chromium.org>

        Reviewed by Nate Chapin.

        [V8] Making V8 generated classes' GetTemplate() function public
        https://bugs.webkit.org/show_bug.cgi?id=34026

        * bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
mitz@apple.com [Tue, 2 Feb 2010 00:56:58 +0000 (00:56 +0000)]
<rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()

Reviewed by Anders Carlsson.

The crash was caused by having two streams with a streamID of 1.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
correctly increments m_currentURLRequestID to account for the manual stream.
(WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
null it out instead of trying to remove it from the map. Added an assertion.
(WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Tue, 2 Feb 2010 00:39:29 +0000 (00:39 +0000)]
2010-02-01  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        [Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
        https://bugs.webkit.org/show_bug.cgi?id=34378

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds V8-specific JNI bridge classes
steveblock@google.com [Tue, 2 Feb 2010 00:35:18 +0000 (00:35 +0000)]
Adds V8-specific JNI bridge classes
https://bugs.webkit.org/show_bug.cgi?id=34166

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.

No new tests, build fix only.

* Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
* bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
* bridge/jni/v8/JNIBridgeV8.cpp: Added.
(JavaField::JavaField):
* bridge/jni/v8/JNIBridgeV8.h: Added.
(JSC::Bindings::JavaField::name):
(JSC::Bindings::JavaField::type):
(JSC::Bindings::JavaField::getJNIType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds V8-specific JNI utility functions.
steveblock@google.com [Tue, 2 Feb 2010 00:25:50 +0000 (00:25 +0000)]
Adds V8-specific JNI utility functions.
https://bugs.webkit.org/show_bug.cgi?id=33901

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.

No new tests, build fix only.

* Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
* bridge/jni/v8/JNIUtilityPrivate.cpp: Added.
(JSC::Bindings::convertNPVariantToJValue):
(JSC::Bindings::convertJValueToNPVariant):
* bridge/jni/v8/JNIUtilityPrivate.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds V8 version of JavaClass
steveblock@google.com [Tue, 2 Feb 2010 00:15:29 +0000 (00:15 +0000)]
Adds V8 version of JavaClass
https://bugs.webkit.org/show_bug.cgi?id=33898

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC

No new tests, build fix only.

* Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
* bridge/jni/v8/JavaClassV8.cpp: Added.
(JavaClass::JavaClass):
(JavaClass::~JavaClass):
(JavaClass::methodsNamed):
(JavaClass::fieldNamed):
* bridge/jni/v8/JavaClassV8.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 2 Feb 2010 00:08:32 +0000 (00:08 +0000)]
2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
        https://bugs.webkit.org/show_bug.cgi?id=34069

        Make the sleep time shorter as this test timed out on Windows bot.

        * editing/selection/doubleclick-beside-cr-span.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds V8 version of JavaInstance
steveblock@google.com [Tue, 2 Feb 2010 00:03:37 +0000 (00:03 +0000)]
Adds V8 version of JavaInstance
https://bugs.webkit.org/show_bug.cgi?id=33951

Reviewed by Ariya Hidayat.

This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
Also fixes a typo in a comment in JavaInstanceJSC.cpp.

No new tests, build fix only.

* Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
* bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.
(JavaInstance::invokeMethod): Modified. Fixed comment
* bridge/jni/v8/JavaInstanceV8.cpp: Added.
(JavaInstance::JavaInstance):
(JavaInstance::~JavaInstance):
(JavaInstance::getClass):
(JavaInstance::invokeMethod):
(JObjectWrapper::JObjectWrapper):
(JObjectWrapper::~JObjectWrapper):
* bridge/jni/v8/JavaInstanceV8.h: Added.
(JSC::Bindings::JObjectWrapper::instance):
(JSC::Bindings::JObjectWrapper::setInstance):
(JSC::Bindings::JObjectWrapper::ref):
(JSC::Bindings::JObjectWrapper::deref):
(JSC::Bindings::JavaInstance::javaInstance):
(JSC::Bindings::JavaInstance::begin):
(JSC::Bindings::JavaInstance::end):
(JSC::Bindings::JavaInstance::virtualBegin):
(JSC::Bindings::JavaInstance::virtualEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMaking sure that all in-progress transactions are rolled back on
dumi@chromium.org [Mon, 1 Feb 2010 23:32:44 +0000 (23:32 +0000)]
Making sure that all in-progress transactions are rolled back on
the database thread before they're destroyed. Otherwise,
SQLiteTransaction's destructor will try to do a rollback and that
would cause an assertion failure, if the object is not destroyed
on the DB thread.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34152

* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::stop):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
* storage/SQLTransaction.h:
* storage/SQLTransactionCoordinator.cpp:
(WebCore::SQLTransactionCoordinator::shutdown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix EXPERIMENTAL_SINGLE_VIEW_MODE build.
weinig@apple.com [Mon, 1 Feb 2010 23:23:25 +0000 (23:23 +0000)]
Fix EXPERIMENTAL_SINGLE_VIEW_MODE build.

Reviewed by Beth Dakin.

* page/EventHandler.h:
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::currentNSEvent):
(WebCore::EventHandler::currentKeyboardEvent):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseDragged):
(WebCore::EventHandler::mouseUp):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::wheelEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Mon, 1 Feb 2010 23:19:03 +0000 (23:19 +0000)]
2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide global flag ability
        https://bugs.webkit.org/show_bug.cgi?id=34418

        Add the globalFlag property to the Qt LayoutTestController to allow
        cross-domain indications.

        * platform/qt/Skipped:
2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] DRT Provide global flag ability
        https://bugs.webkit.org/show_bug.cgi?id=34418

        Add the globalFlag property to the Qt LayoutTestController to allow
        cross-domain indications.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::reset):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::globalFlag):
        (LayoutTestController::setGlobalFlag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 1 Feb 2010 22:39:24 +0000 (22:39 +0000)]
2010-02-01  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium build fix.

        Failed to properly add new files for http://trac.webkit.org/changeset/54150.

        * bindings/v8/custom/V8BarInfoCustom.cpp: Added.
        * bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
        * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
        * bindings/v8/custom/V8CSSValueCustom.cpp: Added.
        * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
        * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
        * bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
        * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
        * bindings/v8/custom/V8SVGElementCustom.cpp: Added.
        * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
        * bindings/v8/custom/V8ScreenCustom.cpp: Added.
        * bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
        * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd support for addUserScript to chromium port.
mpcomplete@chromium.org [Mon, 1 Feb 2010 22:29:06 +0000 (22:29 +0000)]
Add support for addUserScript to chromium port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 1 Feb 2010 22:20:58 +0000 (22:20 +0000)]
2010-02-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=34448
        <rdar://problem/7598130>

        RenderVideo::intrinsicSizeChanged infinite recursion

        * rendering/RenderImage.h:
        (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can
            be called by RenderVideo.
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not
            RenderVideo::intrinsicSizeChanged.
        (WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of
            RenderImage::imageChanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 1 Feb 2010 22:12:14 +0000 (22:12 +0000)]
2010-02-01  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Generate toV8() converter for most WebCore->V8 conversions,
        and defined custom converters in their respective V8<class>Custom.cpp.

        Old converters in V8DOMWrapper will be deleted in a later patch.

        https://bugs.webkit.org/show_bug.cgi?id=32563

        * Android.v8bindings.mk:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Collection.h:
        * bindings/v8/V8DOMWrapper.cpp:
        * bindings/v8/V8DOMWrapper.h:
        * bindings/v8/V8Proxy.h:
        * bindings/v8/custom/V8BarInfoCustom.cpp: Added.
        * bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
        * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
        * bindings/v8/custom/V8CSSValueCustom.cpp: Added.
        * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8DocumentCustom.cpp:
        * bindings/v8/custom/V8ElementCustom.cpp:
        * bindings/v8/custom/V8EventCustom.cpp:
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        * bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
        * bindings/v8/custom/V8HistoryCustom.cpp:
        * bindings/v8/custom/V8LocationCustom.cpp:
        * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
        * bindings/v8/custom/V8NavigatorCustom.cpp:
        * bindings/v8/custom/V8NodeCustom.cpp:
        * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
        * bindings/v8/custom/V8SVGElementCustom.cpp: Added.
        * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
        * bindings/v8/custom/V8ScreenCustom.cpp: Added.
        * bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
        * bindings/v8/custom/V8TreeWalkerCustom.cpp:
        * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
        * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
        * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
        * dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Oliver Hunt.
bweinstein@apple.com [Mon, 1 Feb 2010 22:06:05 +0000 (22:06 +0000)]
Rubber-stamped by Oliver Hunt.

Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.

* platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Mon, 1 Feb 2010 22:02:59 +0000 (22:02 +0000)]
2010-02-01  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: lazy-load textual resources to avoid UI hangup
        https://bugs.webkit.org/show_bug.cgi?id=34332

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._innerSelectContentTab):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype.show):
        (WebInspector.SourceView.prototype.contentTabSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 1 Feb 2010 21:53:23 +0000 (21:53 +0000)]
2010-02-01  Eric Carlson  <eric.carlson@apple.com>

        No review, build fix.

        https://bugs.webkit.org/show_bug.cgi?id=34447
        http/tests/media/video-referer.html fails on Windows

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Unreviewed trivial fix.
ossy@webkit.org [Mon, 1 Feb 2010 21:35:47 +0000 (21:35 +0000)]
[Qt] Unreviewed trivial fix.
Platform dependent expected file updated after r54143.

* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash in Safari opening new tabs to "same page"
beidson@apple.com [Mon, 1 Feb 2010 21:21:43 +0000 (21:21 +0000)]
Crash in Safari opening new tabs to "same page"
<rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444

Reviewed by Adele Peterson.

WebCore:

Test: fast/loader/crash-copying-backforwardlist.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Null check currentItem().

* page/Page.cpp:
(WebCore::Page::goToItem): Ditto.

WebKitTools:

Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(setNewWindowsCopyBackForwardListCallback):
(LayoutTestController::staticFunctions):

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::newWindowsCopyBackForwardList):
(LayoutTestController::setNewWindowsCopyBackForwardList):

* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:createWebViewWithRequest:]):

LayoutTests:

* fast/loader/crash-copying-backforwardlist-expected.txt: Added.
* fast/loader/crash-copying-backforwardlist.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Mon, 1 Feb 2010 21:09:39 +0000 (21:09 +0000)]
Reviewed by Kevin Ollivier.

[wx] Remove unused file that doesn't seem to belong to the port.

https://bugs.webkit.org/show_bug.cgi?id=34445

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 1 Feb 2010 20:48:11 +0000 (20:48 +0000)]
2010-02-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Fullscreen API should be on HTMLVideoElement
        https://bugs.webkit.org/show_bug.cgi?id=34438

        Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.

        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * html/HTMLMediaElement.idl:
        * html/HTMLVideoElement.cpp:
        (WebCore::HTMLVideoElement::paint): Removed outdated FIXME.
        (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto.
        (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement.
        (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto.
        (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto.
        (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
        * html/HTMLVideoElement.h:
        * html/HTMLVideoElement.idl:

2010-02-01  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Fullscreen API should be on HTMLVideoElement
        https://bugs.webkit.org/show_bug.cgi?id=34438

        Update fullscreen tests now that <audio> doesn't have fullscreen API.

        * fast/dom/Window/window-properties-expected.txt:
        * media/media-fullscreen-inline-expected.txt:
        * media/media-fullscreen-not-in-document-expected.txt:
        * media/media-fullscreen.js:
        (buttonClickHandler):
        (canplaythrough):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Carol Szabo <carol.szabo@nokia.com>
carol.szabo@nokia.com [Mon, 1 Feb 2010 20:05:31 +0000 (20:05 +0000)]
2010-02-01  Carol Szabo  <carol.szabo@nokia.com>

        Unreviewed.

        Add myself to list of committers.

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 1 Feb 2010 20:04:34 +0000 (20:04 +0000)]
2010-02-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Structure not accounting for anonymous slots when computing property storage size
        https://bugs.webkit.org/show_bug.cgi?id=34441

        Previously any Structure with anonymous storage would have a property map, so we
        were only including anonymous slot size if there was a property map.  Given this
        is no longer the case we should always include the anonymous slot count in the
        property storage size.

        * runtime/Structure.h:
        (JSC::Structure::propertyStorageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 1 Feb 2010 18:59:36 +0000 (18:59 +0000)]
2010-02-01  Nate Chapin  <japhet@chromium.org>

        Rubber-stamped by David Levin.

        Add myself to reviewer list.

        * Scripts/webkitpy/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 1 Feb 2010 18:44:48 +0000 (18:44 +0000)]
2010-02-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Syntax highlighting in source view of
        Resources pane stops half-way.

        There were two problems here: (1) styles for html highlighter were not
        added into the css file (they used to be injected manually in the
        SourceFrame before). (2) 'Tag' needed to be lexer's state, not parser's.
        Otherwise unbalanced quotes in the text nodes were matching too match
        into the string tokens.

        https://bugs.webkit.org/show_bug.cgi?id=34359

        * inspector/front-end/NativeTextViewer.js:
        (WebInspector.NativeTextViewer.prototype._createLineDivs):
        (WebInspector.NativeTextViewer.prototype._lineHeight):
        (WebInspector.NativeTextViewer.prototype.initFontMetrics):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createEditorIfNeeded):
        * inspector/front-end/SourceHTMLTokenizer.js:
        (WebInspector.SourceHTMLTokenizer):
        (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
        * inspector/front-end/SourceHTMLTokenizer.re2js:
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor.prototype.initFontMetrics):
        (WebInspector.TextEditor.prototype._registerShortcuts):
        * inspector/front-end/inspectorSyntaxHighlight.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
benm@google.com [Mon, 1 Feb 2010 18:35:32 +0000 (18:35 +0000)]
ScriptCallFrame's do not get line numbers/source id's if the caller is unkown.
https://bugs.webkit.org/show_bug.cgi?id=34335

Reviewed by Darin Adler.

WebCore:

* bindings/js/ScriptCallStack.cpp:
(WebCore::ScriptCallStack::ScriptCallStack): If the caller is unknown, the line number and source information is still availble so pass it to the ScriptCallFrame being constructed.

LayoutTests:

Update layout tests that did not have source and line number information for their console messages, as this information is now available to the ScriptCallFrame and thus can be passed to the inspector, for example.

* fast/js/console-non-string-values-expected.txt: Add console line number/source.
* userscripts/script-not-run-for-fragments-expected.txt: ditto.
* userscripts/script-run-at-start-expected.txt: ditto.
* platform/gtk/inspector/console-log-before-inspector-open-expected.txt: Removed as platform workarounds no longer necessary.
* platform/mac/inspector/console-log-before-inspector-open-expected.txt: ditto.
* platform/win/inspector/console-log-before-inspector-open-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 1 Feb 2010 18:07:24 +0000 (18:07 +0000)]
2010-02-01  Dirk Schulze  <krit@webkit.org>

        Reviewed by Simon Fraser.

        Add back an AffineTransform class for use by SVG
        https://bugs.webkit.org/show_bug.cgi?id=33750

        These are the first steps on reimplementing AffineTransform. Unlike
        the old affine code, this one is platform independent like TransformationMatrix.
        AffineTransform has the benefit, that it stores just 6 doubles instead of
        16 in TransformationMatrix. The calculations of transformations are not that
        complex and can improve the memory usage and speed of SVG.
        AffineTransform can be used by HTML Canvas3D or SVG, since they are 2D related (at
        least for the moment).
        HTML Canvas is the first that makes use of the new AffineTransform. Next patches
        will introduce the affine code to SVG.

        No new tests. The new AffineTransformation code is tested by fast/canvas.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::scale):
        (WebCore::CanvasRenderingContext2D::rotate):
        (WebCore::CanvasRenderingContext2D::translate):
        (WebCore::CanvasRenderingContext2D::transform):
        (WebCore::CanvasRenderingContext2D::setTransform):
        (WebCore::CanvasRenderingContext2D::isPointInPath):
        (WebCore::CanvasRenderingContext2D::willDraw):
        * html/canvas/CanvasRenderingContext2D.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/Path.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::getAffineCTM):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::transform):
        * platform/graphics/cairo/TransformationMatrixCairo.cpp:
        (WebCore::AffineTransform::operator cairo_matrix_t):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::concatCTM):
        (WebCore::GraphicsContext::getAffineCTM):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::transform):
        * platform/graphics/cg/TransformationMatrixCG.cpp:
        (WebCore::AffineTransform::operator CGAffineTransform):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::getAffineCTM):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/haiku/PathHaiku.cpp:
        (WebCore::Path::transform):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getAffineCTM):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::transform):
        * platform/graphics/qt/TransformationMatrixQt.cpp:
        (WebCore::AffineTransform::operator QTransform):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::concatCTM):
        (WebCore::GraphicsContext::getAffineCTM):
        * platform/graphics/skia/PathSkia.cpp:
        (WebCore::Path::transform):
        * platform/graphics/skia/TransformationMatrixSkia.cpp:
        (WebCore::AffineTransform::operator SkMatrix):
        * platform/graphics/transforms/AffineTransform.cpp: Added.
        (WebCore::affineTransformDecompose):
        (WebCore::affineTransformCompose):
        (WebCore::AffineTransform::AffineTransform):
        (WebCore::AffineTransform::reset):
        (WebCore::AffineTransform::setMatrix):
        (WebCore::AffineTransform::isIdentity):
        (WebCore::AffineTransform::det):
        (WebCore::AffineTransform::isInvertible):
        (WebCore::AffineTransform::inverse):
        (WebCore::AffineTransform::multiply):
        (WebCore::AffineTransform::multLeft):
        (WebCore::AffineTransform::rotate):
        (WebCore::AffineTransform::scale):
        (WebCore::AffineTransform::translate):
        (WebCore::AffineTransform::scaleNonUniform):
        (WebCore::AffineTransform::rotateFromVector):
        (WebCore::AffineTransform::flipX):
        (WebCore::AffineTransform::flipY):
        (WebCore::AffineTransform::shear):
        (WebCore::AffineTransform::skew):
        (WebCore::AffineTransform::skewX):
        (WebCore::AffineTransform::skewY):
        (WebCore::makeMapBetweenRects):
        (WebCore::AffineTransform::map):
        (WebCore::AffineTransform::mapPoint):
        (WebCore::AffineTransform::mapRect):
        (WebCore::AffineTransform::blend):
        (WebCore::AffineTransform::toTransformationMatrix):
        * platform/graphics/transforms/AffineTransform.h: Added.
        (WebCore::AffineTransform::a):
        (WebCore::AffineTransform::setA):
        (WebCore::AffineTransform::b):
        (WebCore::AffineTransform::setB):
        (WebCore::AffineTransform::c):
        (WebCore::AffineTransform::setC):
        (WebCore::AffineTransform::d):
        (WebCore::AffineTransform::setD):
        (WebCore::AffineTransform::e):
        (WebCore::AffineTransform::setE):
        (WebCore::AffineTransform::f):
        (WebCore::AffineTransform::setF):
        (WebCore::AffineTransform::operator== ):
        (WebCore::AffineTransform::operator!=):
        (WebCore::AffineTransform::operator*=):
        (WebCore::AffineTransform::operator*):
        (WebCore::AffineTransform::setMatrix):
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContext::concatCTM):
        (WebCore::GraphicsContext::getAffineCTM):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::getAffineCTM):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/wx/PathWx.cpp:
        (WebCore::Path::transform):
        * platform/graphics/wx/TransformationMatrixWx.cpp:
        (WebCore::AffineTransform::operator wxGraphicsMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-29 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 1 Feb 2010 16:22:39 +0000 (16:22 +0000)]
2010-01-29  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] set playbin mute property depending on volume value
        https://bugs.webkit.org/show_bug.cgi?id=31586

        New API in MediaPlayer for mute control. 3 new methods are
        introduced:

        - bool supportsMuting() const;
        - bool muted() const;
        - void setMuted(bool);

        Platform MediaPlayer implementations can support it easily if the
        underlying sound daemon/API supports muting (eg. not only setting
        volume to 0) like PulseAudio for instance on Linux. At the moment
        the only player supporting this new API is the
        MediaPlayerPrivateGStreamer.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setMuted):
        (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged):
        (WebCore::HTMLMediaElement::mediaPlayerMuteChanged):
        * html/HTMLMediaElement.h:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::supportsMuting):
        (WebCore::NullMediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayer::MediaPlayer):
        (WebCore::MediaPlayer::muted):
        (WebCore::MediaPlayer::supportsMuting):
        (WebCore::MediaPlayer::setMuted):
        (WebCore::MediaPlayer::volumeChanged):
        (WebCore::MediaPlayer::muteChanged):
        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayerClient::mediaPlayerMuteChanged):
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::supportsMuting):
        (WebCore::MediaPlayerPrivateInterface::setMuted):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateVolumeChangedCallback):
        (WebCore::notifyVolumeIdleCallback):
        (WebCore::mediaPlayerPrivateMuteChangedCallback):
        (WebCore::notifyMuteIdleCallback):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::volumeChangedCallback):
        (WebCore::MediaPlayerPrivate::volumeChanged):
        (WebCore::MediaPlayerPrivate::supportsMuting):
        (WebCore::MediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayerPrivate::muteChangedCallback):
        (WebCore::MediaPlayerPrivate::muteChanged):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:

2010-01-29  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] set playbin mute property depending on volume value
        https://bugs.webkit.org/show_bug.cgi?id=31586

        New API in MediaPlayer for mute control

        * public/WebMediaPlayerClient.h:
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::volumeChanged):
        (WebKit::WebMediaPlayerClientImpl::muteChanged):
        * src/WebMediaPlayerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Mon, 1 Feb 2010 15:30:48 +0000 (15:30 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Platform dependent expected file added for test introduced in r53868,
because this test passes. Compared to png file and Mac expected file.

* platform/qt/fast/lists/anonymous-items-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build without SSL support is broken
hausmann@webkit.org [Mon, 1 Feb 2010 15:03:26 +0000 (15:03 +0000)]
[Qt] Build without SSL support is broken

Patch by Henry Haverinen <henry.haverinen@nokia.com> on 2010-02-01
Reviewed by Simon Hausmann.

Added missing #ifdefs for OpenSSL support and one null-pointer
check for the socket.

https://bugs.webkit.org/show_bug.cgi?id=34416

* platform/network/qt/SocketStreamHandlePrivate.h:
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 1 Feb 2010 14:05:54 +0000 (14:05 +0000)]
2010-02-01  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fix rest of the NativeTextViewer (line numbers,
        conditional breakpoints, selection).

        * inspector/front-end/NativeTextViewer.js:
        (WebInspector.NativeTextViewer):
        (WebInspector.NativeTextViewer.prototype._updatePreferredSize):
        (WebInspector.NativeTextViewer.prototype._registerMouseListeners):
        (WebInspector.NativeTextViewer.prototype._mouseDown):
        (WebInspector.NativeTextViewer.prototype._contextMenu):
        (WebInspector.NativeTextViewer.prototype._lineForMouseEvent):
        (WebInspector.NativeTextViewer.prototype._lineHeight):
        * inspector/front-end/TextEditor.js:
        (WebInspector.TextEditor):
        (WebInspector.TextEditor.prototype._registerMouseListeners):
        (WebInspector.TextEditor.prototype._offsetToLine):
        (WebInspector.TextEditor.prototype._lineHeight):
        (WebInspector.TextEditor.prototype.reveal):
        (WebInspector.TextEditor.prototype._paint):
        (WebInspector.TextEditor.prototype._updateDivDecorations):
        (WebInspector.TextEditor.prototype._paintSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdds implementation of JavaString for V8.
steveblock@google.com [Mon, 1 Feb 2010 10:50:32 +0000 (10:50 +0000)]
Adds implementation of JavaString for V8.
https://bugs.webkit.org/show_bug.cgi?id=33953

Reviewed by Ariya Hidayat.

No new tests, build fix only.

* bridge/jni/JNIBridge.h: Modified. Include JavaStringV8.h for V8
* bridge/jni/v8: Added.
* bridge/jni/v8/JavaStringV8.h: Added.
(JSC::Bindings::JavaStringImpl::init):
(JSC::Bindings::JavaStringImpl::UTF8String):
(JSC::Bindings::JavaStringImpl::uchars):
(JSC::Bindings::JavaStringImpl::length):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 1 Feb 2010 10:05:48 +0000 (10:05 +0000)]
2010-02-01  Oliver Hunt  <oliver@apple.com>

        Windows build fix, update exports file (again)

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 1 Feb 2010 09:56:07 +0000 (09:56 +0000)]
2010-02-01  Oliver Hunt  <oliver@apple.com>

        Windows build fix, update exports file

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 1 Feb 2010 09:43:01 +0000 (09:43 +0000)]
2010-01-31  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        JSC is failing to propagate anonymous slot count on some transitions
        https://bugs.webkit.org/show_bug.cgi?id=34321

        Remove secondary Structure constructor, and make Structure store a copy
        of the number of anonymous slots directly so saving an immediate allocation
        of a property map for all structures with anonymous storage, which also
        avoids the leaked property map on new property transition in the original
        version of this patch.

        We need to propagate the the anonymous slot count otherwise we can end up
        with a structure recording incorrect information about the available and
        needed space for property storage, or alternatively incorrectly reusing
        some slots.

        * JavaScriptCore.exp:
        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::materializePropertyMap):
        (JSC::Structure::addPropertyTransition):
        (JSC::Structure::changePrototypeTransition):
        (JSC::Structure::despecifyFunctionTransition):
        (JSC::Structure::getterSetterTransition):
        (JSC::Structure::toDictionaryTransition):
        (JSC::Structure::flattenDictionaryStructure):
        (JSC::Structure::copyPropertyTable):
        (JSC::Structure::put):
        (JSC::Structure::remove):
        (JSC::Structure::insertIntoPropertyMapHashTable):
        (JSC::Structure::createPropertyMapHashTable):
        * runtime/Structure.h:
        (JSC::Structure::create):
        (JSC::Structure::hasAnonymousSlots):
        (JSC::Structure::anonymousSlotCount):
2010-02-01  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej Stachowiak.

        JSC is failing to propagate anonymous slot count on some transitions
        https://bugs.webkit.org/show_bug.cgi?id=34321

        Add test case for modifying DOM objects with anonymous storage.

        * fast/dom/Window/anonymous-slot-with-changes-expected.txt: Added.
        * fast/dom/Window/anonymous-slot-with-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Alex Milowski <alex@milowski.com>
eric@webkit.org [Mon, 1 Feb 2010 09:27:44 +0000 (09:27 +0000)]
2010-02-01  Alex Milowski  <alex@milowski.com>

        Reviewed by Darin Adler.

        Added compile time debug support for mathml layout (block boundary & baseline)

        * mathml/RenderMathMLBlock.cpp:
        (WebCore::RenderMathMLBlock::stretchToHeight):
        (WebCore::RenderMathMLBlock::paint):
        * mathml/RenderMathMLBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-01 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 1 Feb 2010 08:50:12 +0000 (08:50 +0000)]
2010-02-01  Philippe Normand  <pnormand@igalia.com>

        Rubber stamped by Xan Lopez.

        Fixed compilation warning about unsigned vs signed comparison.

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Mon, 1 Feb 2010 07:05:45 +0000 (07:05 +0000)]
2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Moved style error handler code to their own classes, and
        related refactoring. Increased unit test code coverage of
        style error handling.

        https://bugs.webkit.org/show_bug.cgi?id=34379

        * Scripts/check-webkit-style:
          - Minor change: added error_count variable.

        * Scripts/webkitpy/style/checker.py:
          - Renamed ProcessorOptions.should_report_error() to is_reportable().
          - In the StyleChecker class--
            - Removed _default_style_error_handler().
            - Added _increment_error_count().
            - Refactored to use DefaultStyleErrorHandler and
              PatchStyleErrorHandler constructors.

        * Scripts/webkitpy/style/checker_unittest.py:
          - In the StyleStyleCheckerTest class--
            - Removed write_sample_error().
            - Removed test_default_style_error_handler().

        * Scripts/webkitpy/style/error_handlers.py: Added.
          - Added DefaultStyleErrorHandler class.
          - Added PatchStyleErrorHandler class.

        * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
          - Added unit tests for DefaultStyleErrorHandler and
            PatchStyleErrorHandler.

        * Scripts/webkitpy/style/unittests.py:
          - Added error_handlers unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 1 Feb 2010 06:21:00 +0000 (06:21 +0000)]
2010-01-31  Kent Tamura  <tkent@chromium.org>

        Unreviewed. Revert r54112 and r54124 because of Windows build error.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::scale):
        (WebCore::CanvasRenderingContext2D::rotate):
        (WebCore::CanvasRenderingContext2D::translate):
        (WebCore::CanvasRenderingContext2D::transform):
        (WebCore::CanvasRenderingContext2D::setTransform):
        (WebCore::CanvasRenderingContext2D::isPointInPath):
        (WebCore::CanvasRenderingContext2D::willDraw):
        * html/canvas/CanvasRenderingContext2D.h:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/Path.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/cairo/PathCairo.cpp:
        * platform/graphics/cairo/TransformationMatrixCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        * platform/graphics/cg/PathCG.cpp:
        * platform/graphics/cg/TransformationMatrixCG.cpp:
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        * platform/graphics/haiku/PathHaiku.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/graphics/qt/PathQt.cpp:
        * platform/graphics/qt/TransformationMatrixQt.cpp:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        * platform/graphics/skia/PathSkia.cpp:
        * platform/graphics/skia/TransformationMatrixSkia.cpp:
        * platform/graphics/transforms/AffineTransform.cpp: Removed.
        * platform/graphics/transforms/AffineTransform.h: Removed.
        * platform/graphics/wince/GraphicsContextWince.cpp:
        * platform/graphics/wx/GraphicsContextWx.cpp:
        * platform/graphics/wx/PathWx.cpp:
        * platform/graphics/wx/TransformationMatrixWx.cpp:
        (WebCore::TransformationMatrix::operator wxGraphicsMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewd. Windows build fix.
tkent@chromium.org [Mon, 1 Feb 2010 05:04:49 +0000 (05:04 +0000)]
Unreviewd.  Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 1 Feb 2010 04:23:04 +0000 (04:23 +0000)]
2010-01-31  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Buildfix for WinCE + style fixes (TLS_OUT_OF_INDEXES is not defined).
        https://bugs.webkit.org/show_bug.cgi?id=34380

        * wtf/ThreadSpecific.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Mon, 1 Feb 2010 02:37:49 +0000 (02:37 +0000)]
2010-01-31  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        Limit the scope of packing alignment to avoid MSVC C4103 warning.
        https://bugs.webkit.org/show_bug.cgi?id=34390

        Use pack(push, 16) and pack(pop) to limit the scope of packing
        alignment change.

        * bindings/js/JSSVGPODTypeWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 1 Feb 2010 02:33:14 +0000 (02:33 +0000)]
2010-01-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        [Windows] Fix a bug of round() with huge integral numbers
        https://bugs.webkit.org/show_bug.cgi?id=34297

        Fix a bug that round() for huge integral numbers returns incorrect
        results. For example, round(8639999913600001) returns
        8639999913600002 without this change though the double type can
        represent 8639999913600001 precisely.

        Math.round() of JavaScript has a similar problem. But this change
        doesn't fix it because Math.round() doesn't use round() of
        MathExtra.h.

        * wtf/MathExtras.h:
        (round): Avoid to do "num + 0.5" or "num - 0.5".
        (roundf): Fixed similarly.
        (llround): Calls round().
        (llroundf): Calls roundf().
        (lround): Calls round().
        (lroundf): Calls roundf().

2010-01-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        [Win] Fix a bug of round() with huge integral numbers
        https://bugs.webkit.org/show_bug.cgi?id=34297

        Add a test case to call round(8639999913600001).

        * fast/forms/input-valueasnumber-datetime-expected.txt:
        * fast/forms/script-tests/input-valueasnumber-datetime.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 1 Feb 2010 01:56:12 +0000 (01:56 +0000)]
2010-01-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix valueAsNumber calculation for type=month.
        https://bugs.webkit.org/show_bug.cgi?id=34304

        valueAsNumber calculation for type=month which was checked in as
        r53893 was the number of milliseconds since UNIX epoch, and it was
        wrong. The correct way is the number months since UNIX epoch.

        * fast/forms/input-valueasnumber-month-expected.txt:
        * fast/forms/script-tests/input-valueasnumber-month.js:

2010-01-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix valueAsNumber calculation for type=month.
        https://bugs.webkit.org/show_bug.cgi?id=34304

        valueAsNumber calculation for type=month which was checked in as
        r53893 was the number of milliseconds since UNIX epoch, and it was
        wrong. The correct way is the number months since UNIX epoch.

        * html/DateComponents.cpp:
        (WebCore::DateComponents::setMonthsSinceEpoch):
        (WebCore::DateComponents::monthsSinceEpoch):
        * html/DateComponents.h: Declare setMonthsSinceEpoch() and monthsSinceEpoch().
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseToDouble):
          Switch to monthsSinceEpoch() for type=MONTH.
        (WebCore::HTMLInputElement::valueAsDate):
          Add code with millisecondsSinceEpoch() for MONTH because
          parseToDouble() changed its behavior.
        (WebCore::HTMLInputElement::setValueAsNumber):
          Use setMonthsSinceEpoch() for MONTH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-31 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 1 Feb 2010 01:43:29 +0000 (01:43 +0000)]
2010-01-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Fix a bug that a selected word is not recognized as a
        spell-check source.
        https://bugs.webkit.org/show_bug.cgi?id=33660

        * src/ContextMenuClientImpl.cpp:
        (WebKit::isASingleWord): Use wordBreakIterator(), and correctly check
        the return value of textBreakNext().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: REGRESSION: Numbers in bubbles are vertically off-center
mitz@apple.com [Mon, 1 Feb 2010 01:42:26 +0000 (01:42 +0000)]
Web Inspector: REGRESSION: Numbers in bubbles are vertically off-center
https://bugs.webkit.org/show_bug.cgi?id=34398

Reviewed by Timothy Hatcher.

* inspector/front-end/inspector.css: Specify line-height: normal for
".console-message .bubble" and ".sidebar-tree-item .status .bubble".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-01-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 1 Feb 2010 00:54:49 +0000 (00:54 +0000)]
2010-01-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        Implement CSSOM Range.getClientRects for collapsed selections
        https://bugs.webkit.org/show_bug.cgi?id=34239

        Adds two cases to getClientRects test.

        * fast/dom/Range/getClientRects-expected.txt:
        * fast/dom/Range/getClientRects.html:
2010-01-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Adler.

        Implement CSSOM Range.getClientRects for collapsed selections
        https://bugs.webkit.org/show_bug.cgi?id=34239

        When getting the quads for a range on a text node, allow returning
        zero width quads. This leaves the case of collapsed selections inside
        elements still not fixed, but no worse.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::absoluteQuadsForRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll r54095 out again without making a mess of the ChangeLog.
mrowe@apple.com [Sun, 31 Jan 2010 23:59:19 +0000 (23:59 +0000)]
Roll r54095 out again without making a mess of the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert r54114 since it made a mess of the ChangeLog.
mrowe@apple.com [Sun, 31 Jan 2010 23:59:12 +0000 (23:59 +0000)]
Revert r54114 since it made a mess of the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54115 268f45cc-cd09-0410-ab3c-d52691b4dbfc