WebKit-https.git
8 years agoUse bump allocator for initial property storage
oliver@apple.com [Thu, 8 Sep 2011 22:52:04 +0000 (22:52 +0000)]
Use bump allocator for initial property storage
https://bugs.webkit.org/show_bug.cgi?id=67494

Reviewed by Geoffrey Garen.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Use a bump allocator for initial allocation of property storage,
and promote to fastMalloc memory only if it survives a GC pass.

Comes out as a 1% win on v8, and is a useful step on the way to
GC allocation of all property storage.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
(JSC::Heap::allocatePropertyStorage):
(JSC::Heap::inPropertyStorageNursery):
* heap/MarkedBlock.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
(JSC::NewSpace::resetPropertyStorageNursery):
(JSC::NewSpace::allocatePropertyStorage):
(JSC::NewSpace::inPropertyStorageNursery):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
(JSC::JSObject::propertyStorage):
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):
* runtime/StorageBarrier.h: Added.
(JSC::StorageBarrier::StorageBarrier):
(JSC::StorageBarrier::set):
(JSC::StorageBarrier::operator->):
(JSC::StorageBarrier::operator*):
(JSC::StorageBarrier::operator[]):
(JSC::StorageBarrier::get):

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header.

* ForwardingHeaders/runtime/StorageBarrier.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94809.
rolandsteiner@chromium.org [Thu, 8 Sep 2011 22:45:23 +0000 (22:45 +0000)]
Unreviewed, rolling out r94809.
http://trac.webkit.org/changeset/94809
https://bugs.webkit.org/show_bug.cgi?id=67718

commit _still_ premature, despite CQ eagerness

Source/WebCore:

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
* fast/css/style-scoped/basic-attribute.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: WebKit2: Assertion when calling didPerform*Redirect on null source...
bweinstein@apple.com [Thu, 8 Sep 2011 22:45:12 +0000 (22:45 +0000)]
Source/WebKit2: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
https://bugs.webkit.org/show_bug.cgi?id=67794
<rdar://problem/9892024>

Don't call didPerformClientRedirect or didPerformServerRedirect when source or destination URL string
is empty or null.

If we call didPerformClientRedirect or didPerformServerRedirect when the source or destination is null,
it causes an assert in WKURLCF::WKURLCopyCFURL when we try to convert the WKURLRef into a CFURLRef.

Reviewed by Brady Eidson.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::didPerformClientRedirect): Return early if the source or destination URL string is empty or null.
(WebKit::WebContext::didPerformServerRedirect): Ditto.

Tools: WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
https://bugs.webkit.org/show_bug.cgi?id=67794
<rdar://problem/9892024>

Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.

Reviewed by Brady Eidson.

* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
(TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
(TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
(TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
    Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
    didPerformServerRedirect.

* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
    our InjectedBundleTest.
(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
    from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
    the request.
(TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.

* TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
* TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
* TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
* TestWebKitAPI/win/copy-resources.cmd: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the Completion object from JSC, I have never liked it
weinig@apple.com [Thu, 8 Sep 2011 22:38:44 +0000 (22:38 +0000)]
Remove the Completion object from JSC, I have never liked it
https://bugs.webkit.org/show_bug.cgi?id=67755

Reviewed by Gavin Barraclough.

../JavaScriptCore:

- Removes the Completion object and replaces its use with out parameter exceptions.
- Remove ComplType and virtual exceptionType() function on JSObject. Replace with
  ClassInfo for InterruptedExecutionError and TerminatedExecutionError.

* API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
* jsc.cpp:
(functionLoad):
(functionCheckSyntax):
(runWithScripts):
(runInteractive):
* runtime/Completion.cpp:
(JSC::checkSyntax):
(JSC::evaluate):
* runtime/Completion.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::toString):
(JSC::TerminatedExecutionError::toString):
(JSC::createInterruptedExecutionException):
* runtime/ExceptionHelpers.h:
(JSC::InterruptedExecutionError::InterruptedExecutionError):
(JSC::InterruptedExecutionError::create):
(JSC::InterruptedExecutionError::createStructure):
(JSC::TerminatedExecutionError::TerminatedExecutionError):
(JSC::TerminatedExecutionError::create):
(JSC::TerminatedExecutionError::createStructure):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSObject.h:

../JavaScriptGlue:

* JSRun.cpp:
(JSRun::Evaluate):
(JSRun::CheckSyntax):
* JSRun.h:
* JavaScriptGlue.cpp:
(JSRunEvaluate):

../WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createInjectedScript):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::evaluate):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::evaluateInWorld):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::evaluate):
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject evaluateWebScript:]):
* bridge/NP_jsobject.cpp:
(_NPN_Evaluate):
* bridge/jni/jni_jsobject.mm:
(JavaJSObject::eval):

../WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):

../WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::evaluateJavaScript):

../WebKit2:

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInline DocumentWriter::encoding() into it's only caller: deprecatedFrameEncoding()
abarth@webkit.org [Thu, 8 Sep 2011 22:20:39 +0000 (22:20 +0000)]
Inline DocumentWriter::encoding() into it's only caller: deprecatedFrameEncoding()
https://bugs.webkit.org/show_bug.cgi?id=67807

Reviewed by Eric Seidel.

This function is super nutty.  We don't want any more folks to call it
thinking that it does something sane.

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::deprecatedFrameEncoding):
* loader/DocumentWriter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<style scoped>: Add 'scoped' attribute
rolandsteiner@chromium.org [Thu, 8 Sep 2011 22:17:34 +0000 (22:17 +0000)]
<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/basic-attribute.html

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.

Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/basic-attribute-expected.txt: Added.
* fast/css/style-scoped/basic-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoremove fast/exclusions/triangle-exclusion.html which was originally added as a placeh...
tony@chromium.org [Thu, 8 Sep 2011 22:10:42 +0000 (22:10 +0000)]
remove fast/exclusions/triangle-exclusion.html which was originally added as a placeholder
https://bugs.webkit.org/show_bug.cgi?id=67795

* fast/exclusions/triangle-exclusion.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 22:04:55 +0000 (22:04 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Chromium rebaseline zoom-animator-scale-test.html and mark a couple
        svg-as-background tests flaky on chromium-win.

        * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Removed.
        * platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed.
        * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
rniwa@webkit.org [Thu, 8 Sep 2011 21:53:33 +0000 (21:53 +0000)]
Build fix.

* dfg/DFGCapabilities.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94781.
commit-queue@webkit.org [Thu, 8 Sep 2011 21:52:10 +0000 (21:52 +0000)]
Unreviewed, rolling out r94781.
http://trac.webkit.org/changeset/94781
https://bugs.webkit.org/show_bug.cgi?id=67806

Broke Objective-C binding on Mac (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

* dom/Element.idl:
* dom/Node.cpp:
(WebCore::Node::contains):
* dom/Node.idl:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

* fast/dom/Element/contains-method-expected.txt: Added.
* fast/dom/Element/contains-method.html: Renamed from LayoutTests/fast/dom/Node/contains-method.html.
* fast/dom/Element/script-tests/contains-method.js: Added.
* fast/dom/Node/contains-method-expected.txt: Removed.
* fast/dom/Node/script-tests/contains-method.js: Removed.
* fast/dom/Window/window-properties-expected.txt:
* perf/document-contains-expected.txt: Removed.
* perf/document-contains.html: Removed.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't release the modal placeholder window if it's closed
andersca@apple.com [Thu, 8 Sep 2011 21:51:58 +0000 (21:51 +0000)]
Don't release the modal placeholder window if it's closed
https://bugs.webkit.org/show_bug.cgi?id=67801
<rdar://problem/10088059>

Reviewed by Adam Roben.

This is a speculative fix - nothing should really be able to close the modal placeholder window.

* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::beginModal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
levin@chromium.org [Thu, 8 Sep 2011 21:50:48 +0000 (21:50 +0000)]
check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
https://bugs.webkit.org/show_bug.cgi?id=67797

Reviewed by Eric Seidel.

* Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValue profling and execution count profiling is performed even for
fpizlo@apple.com [Thu, 8 Sep 2011 21:38:04 +0000 (21:38 +0000)]
Value profling and execution count profiling is performed even for
code that cannot be optimized
https://bugs.webkit.org/show_bug.cgi?id=67694

Reviewed by Gavin Barraclough.

This is a 2% speed-up on V8 when tiered compilation is enabled.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::canCompileWithDFG):
(JSC::EvalCodeBlock::canCompileWithDFG):
(JSC::FunctionCodeBlock::canCompileWithDFG):
* bytecode/CodeBlock.h:
* dfg/DFGCapabilities.cpp: Added.
(JSC::DFG::canCompileOpcodes):
* dfg/DFGCapabilities.h: Added.
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::canCompileOpcode):
(JSC::DFG::canCompileEval):
(JSC::DFG::canCompileProgram):
(JSC::DFG::canCompileFunctionForCall):
(JSC::DFG::canCompileFunctionForConstruct):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::privateCompile):
* jit/JIT.h:
(JSC::JIT::shouldEmitProfiling):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG speculative JIT does not initialize integer tags for PredictInt32 temporaries
fpizlo@apple.com [Thu, 8 Sep 2011 21:36:35 +0000 (21:36 +0000)]
DFG speculative JIT does not initialize integer tags for PredictInt32 temporaries
https://bugs.webkit.org/show_bug.cgi?id=67840

Reviewed by Gavin Barraclough.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove DocumentWriter::setDecoder as a grep of WebKit shows no callers
eric@webkit.org [Thu, 8 Sep 2011 21:31:36 +0000 (21:31 +0000)]
Remove DocumentWriter::setDecoder as a grep of WebKit shows no callers
https://bugs.webkit.org/show_bug.cgi?id=67803

Reviewed by Adam Barth.

Smells like dead code.

* loader/DocumentWriter.cpp:
* loader/DocumentWriter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] evetSender.keyDown is unimplemented
ossy@webkit.org [Thu, 8 Sep 2011 21:30:02 +0000 (21:30 +0000)]
[WK2] evetSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

* platform/wk2/Skipped: Skip fast/dom/shadow/access-key.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium shadow-buffer-partial test change.
commit-queue@webkit.org [Thu, 8 Sep 2011 21:16:31 +0000 (21:16 +0000)]
Chromium shadow-buffer-partial test change.
Part1: Update and disable test.
https://bugs.webkit.org/show_bug.cgi?id=67724

Patch by Ben Wagner <bungeman@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

* platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement double tap detection in GestureRecognizerChromium
commit-queue@webkit.org [Thu, 8 Sep 2011 21:11:44 +0000 (21:11 +0000)]
Implement double tap detection in GestureRecognizerChromium
https://bugs.webkit.org/show_bug.cgi?id=67709

Patch by Varun Jain <varunjain@google.com> on 2011-09-08
Reviewed by Dimitri Glazkov.

*  Source/WebCore/page/EventHandler.cpp:
*  Source/WebCore/platform/PlatformGestureEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoframe-loading-via-document-write.html test cases have extra slash in path
commit-queue@webkit.org [Thu, 8 Sep 2011 21:00:05 +0000 (21:00 +0000)]
frame-loading-via-document-write.html test cases have extra slash in path
https://bugs.webkit.org/show_bug.cgi?id=67784

Removing extra slash in path: file:////tmp/... => file:///tmp/...

Patch by Jarred Nicholls <jarred@sencha.com> on 2011-09-08
Reviewed by Andreas Kling.

* fast/dom/frame-loading-via-document-write.html:
* http/tests/security/frame-loading-via-document-write.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67771
commit-queue@webkit.org [Thu, 8 Sep 2011 20:54:10 +0000 (20:54 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67771

Fix sequenceGetByIdSlowCaseInstructionSpace, sequenceGetByIdSlowCaseConstantSpace
and patchOffsetGetByIdSlowCaseCall
and enables DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS flag for SH4 platforms.

Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-09-08
Reviewed by Gavin Barraclough.

* jit/JIT.h:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Some file-url-mimetypes subtests fail on rare extensions
ap@apple.com [Thu, 8 Sep 2011 20:53:29 +0000 (20:53 +0000)]
    Some file-url-mimetypes subtests fail on rare extensions
        https://bugs.webkit.org/show_bug.cgi?id=67679

        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
        * platform/mac-leopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
        * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
        * platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
        Update platform specific results, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrashes in WebCore::ReplaceSelectionCommand::doApply
commit-queue@webkit.org [Thu, 8 Sep 2011 20:50:24 +0000 (20:50 +0000)]
Crashes in WebCore::ReplaceSelectionCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=67762

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::enclosingBlock may return null, but its return value was not checked. This patch checks it.

Tests: editing/inserting/insert-without-enclosing-block.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Added null check.

LayoutTests:

WebCore::enclosingBlock may return NULL, but its return value was not checked. This patch checks it.

* editing/inserting/insert-without-enclosing-block-expected.txt: Added.
* editing/inserting/insert-without-enclosing-block.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 20:48:34 +0000 (20:48 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Chromium baselines for new tests added in r94775 and r94779.

        * platform/chromium-cg-mac/platform/chromium/fast/repaint: Added.
        * platform/chromium-cg-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
        * platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Added.
        * platform/chromium-linux/css3/unicode-bidi-isolate-basic-expected.png: Added.
        * platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Added.
        * platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
        * platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.png: Added.
        * platform/chromium-win/css3/unicode-bidi-isolate-basic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r94771.
ossy@webkit.org [Thu, 8 Sep 2011 20:46:55 +0000 (20:46 +0000)]
[Qt] Unreviewed gardening after r94771.

* fast/dom/constructed-objects-prototypes-expected.txt: Update, it will pass on Qt, GTK, SL, Win.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94784.
commit-queue@webkit.org [Thu, 8 Sep 2011 20:33:45 +0000 (20:33 +0000)]
Unreviewed, rolling out r94784.
http://trac.webkit.org/changeset/94784
https://bugs.webkit.org/show_bug.cgi?id=67796

Commit was premature (Requested by rolandsteiner on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

* fast/css/style-scoped/basic-attribute-expected.txt: Removed.
* fast/css/style-scoped/basic-attribute.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add backend compositor support for rescaling (zooming) textures during...
wjmaclean@chromium.org [Thu, 8 Sep 2011 20:31:02 +0000 (20:31 +0000)]
[chromium] Add backend compositor support for rescaling (zooming) textures during zoom animation.
https://bugs.webkit.org/show_bug.cgi?id=66472

Source/WebCore:

This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.

Reviewed by James Robinson.

Test: platform/chromium/compositing/zoom-animator-scale-test.html

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setZoomAnimatorScale):
(WebCore::Settings::zoomAnimatorScale):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setZoomAnimatorScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setZoomAnimatorScale):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setZoomAnimatorScale):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* testing/Internals.cpp:
(WebCore::Internals::setZoomAnimatorScale):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

This patch contains plumbing from Internals to WebViewImpl that can be removed
at a later time when the zoom animator code is complete.

Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setZoomLevel):
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

Initial tests for zoomAnimatorChromium backend.

Reviewed by James Robinson.

* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
* platform/chromium/compositing/zoom-animator-scale-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Thu, 8 Sep 2011 20:23:53 +0000 (20:23 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip tests introduced in r94775 because of missing test fonts.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Added. (test introduced in r94147)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHTMLMediaElement is missing initialTime attribute
eric.carlson@apple.com [Thu, 8 Sep 2011 20:19:34 +0000 (20:19 +0000)]
HTMLMediaElement is missing initialTime attribute
https://bugs.webkit.org/show_bug.cgi?id=67791

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-initialTime.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::initialTime):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::initialTime):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::initialTime):

LayoutTests:

* media/media-initialTime-expected.txt: Added.
* media/media-initialTime.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCompile in ScrollAnimator for Chromium on all platforms by default.
commit-queue@webkit.org [Thu, 8 Sep 2011 20:03:54 +0000 (20:03 +0000)]
Compile in ScrollAnimator for Chromium on all platforms by default.
https://bugs.webkit.org/show_bug.cgi?id=67650

Patch by Scott Byer <scottbyer@chromium.org> on 2011-09-08
Reviewed by Adam Barth.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElements with position:absolute don't move to correct position after images load
robert@webkit.org [Thu, 8 Sep 2011 19:58:32 +0000 (19:58 +0000)]
Elements with position:absolute don't move to correct position after images load
https://bugs.webkit.org/show_bug.cgi?id=54611

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/block/positioning/absolute-layout-after-image-load.html

In the test the 'label' block is an absolutely positioned child of an inline flow. So during layout,
this RenderBlock::layoutPositionedObjects fails to dirty it for rendering because it requires
the parent to be a BlockFlow. The code to do this was introduced in http://trac.webkit.org/changeset/8284.
There doesn't seem to be a good reason for requiring a BlockFlow, so remove the check.

Note: Although the issue is encountered only on first load without a fragment identifier, it
happens reliably when you include the fragment identifier in the url (#Footnote_1). This is so
because scrolling to the fragment always happens before the image has loaded, rendering the page
and clearing the initial dirty bits in the positioned element's renderer. When the image finally
loads in this scenario, the positioned element is otherwise clean and relies on the above code to get
re-rendered.

Note: This was originally landed in r94755 but positioned-float-layout-after-image-load.html exposed
      an ASSERT bug, unrelated to this change, and was rolled out. That issue is tracked separately
      in bug 67759.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects): remove the check for r->parent()->isBlockFlow() when
                                                 deciding whether to mark children for layout

LayoutTests:

* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Added.
* fast/block/positioning/absolute-layout-after-image-load.html: Added.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<style scoped>: Add 'scoped' attribute
rolandsteiner@chromium.org [Thu, 8 Sep 2011 19:56:38 +0000 (19:56 +0000)]
<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/basic-attribute.html

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.

Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/basic-attribute-expected.txt: Added.
* fast/css/style-scoped/basic-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] Improve performance of typed array set() taking Array
commit-queue@webkit.org [Thu, 8 Sep 2011 19:55:20 +0000 (19:55 +0000)]
[v8] Improve performance of typed array set() taking Array
https://bugs.webkit.org/show_bug.cgi?id=63644

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

Overwrite the native 'set' method of the type arrays with JS
implementation after initialization of the global context.

Add tests for invalid and boundary offsets. No performance tests.

* LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt:
* LayoutTests/fast/canvas/webgl/array-unit-tests.html:
* Source/WebCore/WebCore.gyp/WebCore.gyp:
* Source/WebCore/WebCore.gypi:
* Source/WebCore/bindings/v8/V8BindingScripts.cpp: Added.
* Source/WebCore/bindings/v8/V8BindingScripts.h: Added.
* Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
* Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for bug 65583 (path based border radius drawing on skia) part 2
commit-queue@webkit.org [Thu, 8 Sep 2011 19:44:57 +0000 (19:44 +0000)]
Rebaseline for bug 65583 (path based border radius drawing on skia) part 2
https://bugs.webkit.org/show_bug.cgi?id=67751

Patch by Ben Wells <benwells@chromium.org> on 2011-09-08
Reviewed by Kenneth Russell.

* fast/borders/border-radius-circle-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-circle-expected.txt.
* fast/borders/border-radius-groove-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-01-expected.txt.
* fast/borders/border-radius-groove-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-02-expected.txt.
* fast/borders/border-radius-groove-03-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-groove-03-expected.txt.
* fast/borders/border-radius-wide-border-01-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-01-expected.txt.
* fast/borders/border-radius-wide-border-02-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-wide-border-02-expected.txt.
* fast/css/text-input-with-webkit-border-radius-expected.png: Removed.
* fast/gradients/background-clipped-expected.txt: Renamed from LayoutTests/platform/gtk/fast/gradients/background-clipped-expected.txt.
* fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt.
* fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt.
* fast/transforms/shadows-expected.txt: Renamed from LayoutTests/platform/gtk/fast/transforms/shadows-expected.txt.
* platform/chromium-linux/fast/: 20 changes.
* platform/chromium-win/fast/: 19 changes.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/: 9 changes.
* platform/qt/fast/: 10 removals.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove Element.contains to Node
arv@chromium.org [Thu, 8 Sep 2011 19:38:18 +0000 (19:38 +0000)]
Move Element.contains to Node
https://bugs.webkit.org/show_bug.cgi?id=67651

Reviewed by Darin Adler.

This moves the contains method from Element to Node as in the DOM4 working draft:
http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-node-contains

This also special cases Document contains to make it O(1) instead of O(depth).

Source/WebCore:

Tests: fast/dom/Node/contains-method.html
       perf/document-contains.html

* dom/Element.idl:
* dom/Node.cpp:
(WebCore::Node::contains): Added document special case.
* dom/Node.idl:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs): Added a null check.

LayoutTests:

* fast/dom/Element/contains-method-expected.txt: Removed.
* fast/dom/Element/script-tests/contains-method.js: Removed.
* fast/dom/Node/contains-method-expected.txt: Added.
* fast/dom/Node/contains-method.html: Renamed from LayoutTests/fast/dom/Element/contains-method.html.
* fast/dom/Node/script-tests/contains-method.js: Added. Expanded tests.
* fast/dom/Window/window-properties-expected.txt:
* perf/document-contains-expected.txt: Added.
* perf/document-contains.html: Added.
                               Perf test to ensure that document.contains is O(1).
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCheck AudioContext createChannelMerger() for thread safety
crogers@google.com [Thu, 8 Sep 2011 19:22:59 +0000 (19:22 +0000)]
Check AudioContext createChannelMerger() for thread safety
https://bugs.webkit.org/show_bug.cgi?id=67247

Reviewed by Kenneth Russell.

Source/WebCore:

Test: webaudio/audiochannelmerger-stereo.html

* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::process):
(WebCore::AudioChannelMerger::checkNumberOfChannelsForInput):
* webaudio/AudioChannelMerger.h:

LayoutTests:

* webaudio/audiochannelmerger-stereo-expected.txt: Added.
* webaudio/audiochannelmerger-stereo.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixed Layout Mode should be adjustable from layoutTestController for testing on Chrom...
fsamuel@chromium.org [Thu, 8 Sep 2011 19:20:27 +0000 (19:20 +0000)]
Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=67723

Reviewed by Adam Barth.

Tools:

* DumpRenderTree/chromium/EventSender.h:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::enableFixedLayoutMode):
(LayoutTestController::setFixedLayoutSize):
* DumpRenderTree/chromium/LayoutTestController.h:

LayoutTests:

* platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
* platform/chromium/fast/repaint/fixed-layout-360x240-expected.txt: Added.
* platform/chromium/fast/repaint/fixed-layout-360x240.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor hyphen measurement
commit-queue@webkit.org [Thu, 8 Sep 2011 19:18:43 +0000 (19:18 +0000)]
Refactor hyphen measurement
https://bugs.webkit.org/show_bug.cgi?id=67728

Patch by Ned Holbrook <nholbrook@apple.com> on 2011-09-08
Reviewed by Darin Adler.

No new tests, purely refactoring.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::measureHyphenWidth): Added.
(WebCore::setLogicalWidthForTextRun): Use measureHyphenWidth().
(WebCore::tryHyphenating): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove LayoutStateDisabler instances from RenderLayer
jchaffraix@webkit.org [Thu, 8 Sep 2011 18:54:33 +0000 (18:54 +0000)]
Remove LayoutStateDisabler instances from RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=66896

Reviewed by Simon Fraser.

As part of r93614, scrollTo does not call updateLayerPositions anymore.
This means that we don't need to disable LayoutState from the scrolling code
in RenderLayer.

This change is covered by the existing tests.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Updated the comment
that was not accurate anymore. Also explained what is wrong with
LayoutState vs RenderLayer now. Note that the ASSERT is still
valid and will not trigger as the remaining calls to updateLayerPositions
are done *outside* layout() where LayoutState is not set (thus disabled).

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed
2 LayoutStateDisabler surrounding scrollToOffset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFactor out the code to get the first non-null RenderTableSection in RenderTable
jchaffraix@webkit.org [Thu, 8 Sep 2011 18:53:02 +0000 (18:53 +0000)]
Factor out the code to get the first non-null RenderTableSection in RenderTable
https://bugs.webkit.org/show_bug.cgi?id=66972

Reviewed by Darin Adler.

Refactoring only, covered by existing tests.

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::rowIndexRange):
Updated those for the signature change in sectionBelow. Also added
a FIXME where topSection should be used instead of iterating
over the section (and likely missing some corner cases).

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::sectionAbove):
(WebCore::RenderTable::sectionBelow):
(WebCore::RenderTable::firstLineBoxBaseline):
Updated all those functions to use the newly added functions. Also changed
the variable names to match the functions.

(WebCore::RenderTable::layout):
(WebCore::RenderTable::topNonEmptySection): Newly added function
that returns the top non null section of the table that has at least a
row.

(WebCore::RenderTable::cellAbove):
(WebCore::RenderTable::cellBelow):
Update the signature of those 2 functions to take an enum as it makes the
rest of the code more readable.

* rendering/RenderTable.h:
(WebCore::RenderTable::topSection): Newly added function to return
the top non null section in the table.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Ryosuke Niwa.
eric@webkit.org [Thu, 8 Sep 2011 18:46:01 +0000 (18:46 +0000)]
Reviewed by Ryosuke Niwa.

[BiDi] [CSS3] MASTER: Add support for the unicode-bidi:isolate CSS property
https://bugs.webkit.org/show_bug.cgi?id=50912

Source/WebCore:

This patch adds support for CSS3 unicode-bidi: isolate property, under the -webkit- vendor prefix.
Parsing support was added in a previous patch, this wires up the RenderStyle values
to code changes in the BidiResolver.

The effect of this patch is that it makes it possible to "isolate" runs of text
so that their RTL-ness or LTR-ness does not bleed out into the rest of your text
and effect layout.  This is important because many unicode characters (like parenthesis, ':', '-', etc.)
do not have intrinsic directionality and are affected by whatever characters come before/after.
If you have usernames which include RTL text, if you inject those usernames in your page
you might end up with nearby characters moving!
(like 'RTL USERNAME - my awesome site' as a title, could end up as
'my awesome site - USERNAME RTL' when correct would be 'USERNAME RTL - my awesome site'.)
This patch makes it possible to wrap sections of text in isolated spans, so that
they correctly order all their RTL/LTR contents, but also correctly participate in the
larger RTL/LTR ordering without affecting nearby characters.

Because much of this code is old and rarely touched, I've included extra background
information in hopes of expanding my set of potential reviewers:

WebKit uses the standard "Unicode Bidi Algorithm" henceforth known as the UBA.
The UBA is defined at http://unicode.org/reports/tr9/ for those not faint of heart.

Text layout is done per-block (<div>, <p>, etc), and begins with a string of text
(which in our case comes from the rendering tree) and a specified width.
First:  Text is measured and wrapped into lines.
Second: The UBA is run over the lines of text.
Third:  WebKit builds InlineBoxes (its linebox tree) and eventually render the text.

This patch modifies our UBA to ignore all text content inside "isolated" inlines (treating them as neutral characters)
and then adds another step after running the UBA, where we run the UBA recursively on any
previously identified "isolated" content.

The result of the UBA is an ordered list of "runs" of text with the RTL runs
correctly RTL and the LTR runs LTR.

The UBA does three things:
1.  It assigns a "class" to each character in a text stream (like neutral, strongly-RTL, strongly-LTR, etc.)
2.  Divides the text stream up into "runs" of characters of the same directionality (all RTL, all LTR).
3.  Re-orders those runs.

The UBA in WebKit is implemented by BidiResolver<T> in BidiResolver.h

The InlineBidiResolver (BidiResolver specialization which knows about the rendering tree)
walks along its InlineIterators, looking at each character and running the
Unicode Bidi Algorithm (UBA).  It walks through the rendering tree subtree under
a block, using a (poorly named) bidiNext function which returns the next inline object.
Each inline object (or text character there-in) has a corresponding meaning in the UBA
such as a "strong RTL" character or a "neutral" character.  The UBA reads these sequence
of characters, and figures out what direction (RTL or LTR) to assign to any neutral
characters it encounters, based on surrounding characters.

As the InlineBidiResolver is walking the rendering tree, the InlineIterator::advance()
function calls bidiNext(), which in turn can call notifyObserverEnteredObject/notifyObserverWillExitObject
notifying InlineBidiResolver that it is entering or exiting an "isolated"
span, at which point it will either start or stop ignoring the stream of characters
from the InlineIterator.  When the InlineBidiResolver is ignoring the stream of
characters, instead of creating separate BidiRuns at each RTL/LTR boundary
as it normally would, it instead creates one "fake" run for the entire
isolated span.  These fake runs participate in the normal UBA run ordering process,
but after the main UBA, a second pass is made where we examine
the list of isolatedRuns() and run the UBA on each of them, replacing the fake
run we previously inserted, with the resulting list of runs from that inner UBA run.
The way it "ignores" characters is by treating them all as neutral when inside an isolate.
Thus all the characters end up grouped in a single run, but their directionality (as a group)
is correctly affected by any surrounding strong characters.

If you understood that last paragraph, than the rest of the change is just plumbing.

I added a huge number of FIXMEs to this code, because this code has a variety of
design choices (or lack there of) which make some of this very difficult.

For example the bidiNext iterator function has two sets of mutually exclusive
parameters and can be used optionally with or without an observer.  Prior to this
change there was only ever one object which cared about observing a walk over inlines
and that was InlineBidiResolver.  This patch (regretfully) templatizes bidiNext
to support a new Observer type.  The correct fix would be to rip bidiNext into
multiple functions and rip need for observation out of InlineBidiResolver.
Unfortunately I've tried both in separate bugs and failed.  This code is very very
old and very poorly understood.  We're slowly moving forward, this is another tiny step.

This is my fourth iteration of this patch (I'm happy to do more!), but I believe
it's a good compromise between fixing all of the design gotcha's of our bidi
system and doing the minimum amount to add this killer CSS feature.

I ran the PLT.  (It averaged 0.2% faster with this change, but I attribute that to noise).

Test: css3/unicode-bidi-isolate-basic.html and css3/unicode-bidi-isolate-aharon.html

* platform/text/BidiResolver.h:
(WebCore::BidiCharacterRun::setNext):
 - Needed by the new replaceRunWithRuns function.
(WebCore::BidiResolver::BidiResolver):
(WebCore::BidiResolver::~BidiResolver):
(WebCore::BidiResolver::enterIsolate):
(WebCore::BidiResolver::exitIsolate):
(WebCore::BidiResolver::inIsolate):
(WebCore::BidiResolver::isolatedRuns):
 - Used to track isolated spans of text as they're encoutered.
   They're stuffed away here to be processed recursively
   after the main UBA has done its thang.
(WebCore::::appendRun):
(WebCore::::embed):
(WebCore::::commitExplicitEmbedding):
(WebCore::::createBidiRunsForLine):
* platform/text/BidiRunList.h:
(WebCore::::replaceRunWithRuns):
 - This effectively takes all the runs from one runlist and adds them to
   this one, replacing the fake run we inserted during a previous pass of the UBA.
 - This RunList now owns the runs, so we call clear() on the other RunList
   so that we don't end up double-freeing the runs.
(WebCore::::clear):
 - This allows us to "take" runs from another run list and then clear it.
* rendering/BidiRun.h:
(WebCore::BidiRun::object):
* rendering/InlineIterator.h:
(WebCore::InlineIterator::object):
(WebCore::InlineIterator::offset):
(WebCore::notifyObserverEnteredObject): Mostly just renaming and adding a FIXME about plaintext.
(WebCore::notifyObserverWillExitObject): Mostly just renaming.
(WebCore::addPlaceholderRunForIsolatedInline):
(WebCore::isIsolatedInline):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::statusWithDirection):
(WebCore::constructBidiRuns):
 - This is the heavy-lifting of this change.  This function
   runs the UBA recursively on all the previously identified isolated spans.
 - If we encounter more isolated spans in our run, we just add them to the
   main list an keep going.  Because the runs are linked lists and we have
   direct pointers to our placeholder objects, we don't care what order
   we process the placeholders in, so long as when we're done, they're all processed.
(WebCore::RenderBlock::layoutInlineChildren):

LayoutTests:

Two new tests for testing unicode-bidi: isolate behavior.
Note that the test from Aharon Lanin has one failing subtest
I've asked him if the test might have a typo in:
https://bugs.webkit.org/show_bug.cgi?id=50912#c30

* css3/unicode-bidi-isolate-aharon.html: Added.
 - Some various unicode-bidi: isolate tests from Aharon.
* css3/unicode-bidi-isolate-basic.html: Added.
 - This test tries all possible orderings of strong-LTR, strong-RTL and neutral characters
   across unicode-bidi: isolate spans to make sure that we match expected rendering.
 - A little red bleeds through the test, but that appears to be from anti-aliasing
   and possible automatic font kerning, not layout failures.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Added.
* platform/mac/css3/unicode-bidi-isolate-basic-expected.png: Added.
* platform/mac/css3/unicode-bidi-isolate-basic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove getUInt32 from JSCell
commit-queue@webkit.org [Thu, 8 Sep 2011 18:41:55 +0000 (18:41 +0000)]
Remove getUInt32 from JSCell
https://bugs.webkit.org/show_bug.cgi?id=67691

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Oliver Hunt.

 We don't use JSCell::getUInt32 anymore, so it has been removed.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/JSCell.cpp:
* runtime/JSCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate tests for inherit and initial values for -webkit-columns and related CSS prope...
macpherson@chromium.org [Thu, 8 Sep 2011 18:38:13 +0000 (18:38 +0000)]
Update tests for inherit and initial values for -webkit-columns and related CSS properties.
https://bugs.webkit.org/show_bug.cgi?id=67685

Reviewed by Eric Seidel.

* fast/multicol/inherit-column-values-expected.txt:
* fast/multicol/inherit-column-values.html:
* fast/multicol/initial-column-values-expected.txt:
* fast/multicol/initial-column-values.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit Tap gesture detection into TapDown and Tap.
commit-queue@webkit.org [Thu, 8 Sep 2011 18:30:40 +0000 (18:30 +0000)]
Split Tap gesture detection into TapDown and Tap.
We need this distinction to highlight links when they are first touched. The link is
followed only if the tap is completed, otherwise, if a scroll is detected, the highlight
goes away.
https://bugs.webkit.org/show_bug.cgi?id=67645

Patch by Varun Jain <varunjain@google.com> on 2011-09-08
Reviewed by Dimitri Glazkov.

*  Source/WebCore/page/EventHandler.cpp:
*  Source/WebCore/platform/PlatformGestureEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement a ProgressEvent constructor for JSC
commit-queue@webkit.org [Thu, 8 Sep 2011 18:28:42 +0000 (18:28 +0000)]
Implement a ProgressEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=67537

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ProgressEvent constructor is here:
http://www.w3.org/TR/progress-events/#interface-progressevent

Test: fast/events/constructors/progress-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the ProgressEvent constructor.
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Converts an ECMA-262 Number into an IDL unsigned long long value. Spec: http://www.w3.org/TR/WebIDL/#es-unsigned-long-long
* bindings/js/JSEventConstructors.cpp: Added #includes for ProgressEvent.
* dom/ProgressEvent.cpp:
(WebCore::ProgressEventInit::ProgressEventInit):
(WebCore::ProgressEvent::ProgressEvent):
* dom/ProgressEvent.h: Added a definition for ProgressEventInit.
(WebCore::ProgressEvent::create):
* dom/ProgressEvent.idl: Makes ProgressEvent constructible.

LayoutTests:

* fast/events/constructors/progress-event-constructor-expected.txt: Added.
* fast/events/constructors/progress-event-constructor.html: Added. Checks the behavior of the ProgressEvent constructor.
* platform/chromium/test_expectations.txt: Skipped progress-event-constructor.html, since V8 does not yet have the ProgressEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 18:22:11 +0000 (18:22 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Rebaseline svg/W3C-SVG-1.1-SE/filters-image-05-f.svg text for chromium win/linux.

        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
        * platform/chromium-linux-x86/svg/W3C-SVG-1.1-SE: Removed.
        * platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest how animation methods react to too few arguments
commit-queue@webkit.org [Thu, 8 Sep 2011 18:18:57 +0000 (18:18 +0000)]
Test how animation methods react to too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66539

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-08
Reviewed by Darin Adler.

* fast/animation/request-animation-frame-missing-arguments-expected.txt: Added.
* fast/animation/request-animation-frame-missing-arguments.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a layout test for the case where an accesskey is defined in shadow DOM.
hayato@chromium.org [Thu, 8 Sep 2011 18:14:59 +0000 (18:14 +0000)]
Add a layout test for the case where an accesskey is defined in shadow DOM.

https://bugs.webkit.org/show_bug.cgi?id=67096

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/access-key-expected.txt: Added.
* fast/dom/shadow/access-key.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome file-url-mimetypes subtests fail on rare extensions
ap@apple.com [Thu, 8 Sep 2011 18:05:05 +0000 (18:05 +0000)]
Some file-url-mimetypes subtests fail on rare extensions
https://bugs.webkit.org/show_bug.cgi?id=67679

Reviewed by Darin Adler.

* platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes-2.html:
* platform/mac/fast/loader/file-url-mimetypes-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes.html:
It doesn't appear important to investigate why a few subtests fail on some machines, so
just removing those.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake bindings tests quiet after r94701.
rniwa@webkit.org [Thu, 8 Sep 2011 17:41:48 +0000 (17:41 +0000)]
Make bindings tests quiet after r94701.

* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Some cookie related tests fail on Lion
ap@apple.com [Thu, 8 Sep 2011 17:18:32 +0000 (17:18 +0000)]
    Some cookie related tests fail on Lion
        https://bugs.webkit.org/show_bug.cgi?id=67674

        Reviewed by Mark Rowe.

        Use private browsing mode to work around a CFNetwork issue where these tests can affect each
        other's results. This should not affect their behavior in any other way.

        * http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
        * http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
        * http/tests/security/cookies/third-party-cookie-blocking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
rniwa@webkit.org [Thu, 8 Sep 2011 17:09:31 +0000 (17:09 +0000)]
Rebaseline filters-image-05-f.svg expected output (text) for SnowLeopard.
https://bugs.webkit.org/show_bug.cgi?id=67781

Unreviewed rebaseline for Mac.

* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 8 Sep 2011 16:56:06 +0000 (16:56 +0000)]
2011-09-08  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium expectations tweaks.

        * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
podivilov@chromium.org [Thu, 8 Sep 2011 16:38:22 +0000 (16:38 +0000)]
Web Inspector: get rid of RawSourceCode.createSourceMappingIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=67717

Source/WebCore:

Listen to SourceMappingUpdated event instead of using createSourceMappingIfNeeded.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreConsoleMessages):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleMessageAdded):
(WebInspector.DebuggerPresentationModel.prototype._createPresentationMessage):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.PresentationCallFrame.prototype.sourceLine.sourceMappingUpdated):
(WebInspector.PresentationCallFrame.prototype.sourceLine):
* inspector/front-end/SourceFile.js:

LayoutTests:

Merge source-file.html into raw-source-code.html.

Reviewed by Yury Semikhatsky.

* inspector/debugger/raw-source-code.html:
* inspector/debugger/source-file.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; removed one erroneous baseline (Skia on Mac)
caryclark@google.com [Thu, 8 Sep 2011 16:03:40 +0000 (16:03 +0000)]
Unreviewed; removed one erroneous baseline (Skia on Mac)

* platform/chromium-mac/fast/frames/lots-of-objects-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
podivilov@chromium.org [Thu, 8 Sep 2011 15:05:35 +0000 (15:05 +0000)]
Web Inspector: do not re-create RawSourceCode when toggling pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=67647

1) Implement RawSourceCode.setFormatted that allows toggling pretty-print mode on the fly without resetting everything.
2) Add RawSourceCode unit tests.
3) Remove source mapping listeners and console messages from presentation model (they live in RawSourceCode now).

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/raw-source-code.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.setFormatted):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Added.
* inspector/debugger/raw-source-code.html: Added.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, next chunk of files)
caryclark@google.com [Thu, 8 Sep 2011 14:46:01 +0000 (14:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of files)
Updated newer tests with reference images.
Deleted images with correct fallbacks.

* platform/chromium-mac/http/tests/eventsource: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
apavlov@chromium.org [Thu, 8 Sep 2011 13:58:27 +0000 (13:58 +0000)]
Web Inspector: [REGRESSION] Clear console shortcut Ctrl + L broken
https://bugs.webkit.org/show_bug.cgi?id=67711

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._registerShortcuts):
(WebInspector.ConsoleView.prototype._promptKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fails with strict compiler
abecsi@webkit.org [Thu, 8 Sep 2011 13:52:04 +0000 (13:52 +0000)]
[Qt] Build fails with strict compiler
https://bugs.webkit.org/show_bug.cgi?id=67778

Reviewed by Csaba Osztrogon√°c.

Source/ThirdParty/ANGLE:

* src/compiler/glslang_lex.cpp: Regenerate with generate_glslang_lexer.sh using a newer flex
to suppress warning and fix the build when using [-Werror=unused-result]

Source/WebCore:

No new tests needed.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::resizeEdgeTiles): Remove unused contentsRect variable
which's usage was removed in r94681 to fix the build with [-Werror=unused-but-set-variable].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Thu, 8 Sep 2011 13:44:19 +0000 (13:44 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip a new failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94695.
commit-queue@webkit.org [Thu, 8 Sep 2011 12:58:17 +0000 (12:58 +0000)]
Unreviewed, rolling out r94695.
http://trac.webkit.org/changeset/94695
https://bugs.webkit.org/show_bug.cgi?id=67776

Hitting an assertion on Snow Leopard, Qt, GTK (Requested by
Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-08

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionedFloatsNeedRelayout):
(WebCore::RenderBlock::layoutPositionedObjects):

LayoutTests:

* fast/block/positioning/absolute-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/absolute-layout-after-image-load.html: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load-expected.txt: Removed.
* fast/block/positioning/positioned-float-layout-after-image-load.html: Removed.
* fast/block/positioning/resources/absolute-layout-after-image-load-2.html: Removed.
* fast/block/positioning/resources/positioned-float-layout-after-image-load-2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, strip trailing whitespace in the Web Inspector frontend (*.js and *.css).
apavlov@chromium.org [Thu, 8 Sep 2011 12:15:53 +0000 (12:15 +0000)]
Unreviewed, strip trailing whitespace in the Web Inspector frontend (*.js and *.css).

* inspector/front-end/ApplicationCacheItemsView.js:
* inspector/front-end/AuditResultView.js:
* inspector/front-end/BinarySearch.js:
* inspector/front-end/CSSStyleModel.js:
* inspector/front-end/ConsoleMessage.js:
* inspector/front-end/ConsoleModel.js:
* inspector/front-end/ConsoleView.js:
* inspector/front-end/CookieItemsView.js:
* inspector/front-end/CookieParser.js:
* inspector/front-end/DOMAgent.js:
* inspector/front-end/DOMStorage.js:
* inspector/front-end/DOMStorageItemsView.js:
* inspector/front-end/DataGrid.js:
* inspector/front-end/Database.js:
* inspector/front-end/DatabaseQueryView.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
* inspector/front-end/DetailedHeapshotView.js:
* inspector/front-end/ElementsTreeOutline.js:
* inspector/front-end/EmptyView.js:
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/ExtensionCommon.js:
* inspector/front-end/GoToLineDialog.js:
* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotProxy.js:
* inspector/front-end/HeapSnapshotWorkerDispatcher.js:
* inspector/front-end/ImageView.js:
* inspector/front-end/InjectedFakeWorker.js:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/MetricsSidebarPane.js:
* inspector/front-end/NetworkManager.js:
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/ObjectPropertiesSection.js:
* inspector/front-end/PartialQuickSort.js:
* inspector/front-end/ProfileView.js:
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/RemoteObject.js:
* inspector/front-end/Resource.js:
* inspector/front-end/ResourceCategory.js:
* inspector/front-end/ResourceHTMLView.js:
* inspector/front-end/ResourceHeadersView.js:
* inspector/front-end/ResourceJSONView.js:
* inspector/front-end/ResourceTimingView.js:
* inspector/front-end/ResourceTreeModel.js:
* inspector/front-end/ResourceView.js:
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/SearchController.js:
* inspector/front-end/SettingsScreen.js:
* inspector/front-end/ShortcutsScreen.js:
* inspector/front-end/SourceCSSTokenizer.js:
* inspector/front-end/SourceHTMLTokenizer.js:
* inspector/front-end/SourceJavaScriptTokenizer.js:
* inspector/front-end/StatusBarButton.js:
* inspector/front-end/TextEditorModel.js:
* inspector/front-end/TimelineGrid.js:
* inspector/front-end/View.js:
* inspector/front-end/heapProfiler.css:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.js:
* inspector/front-end/inspectorSyntaxHighlight.css:
* inspector/front-end/networkPanel.css:
* inspector/front-end/treeoutline.js:
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared...
ossy@webkit.org [Thu, 8 Sep 2011 12:07:06 +0000 (12:07 +0000)]
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip svg/W3C-SVG-1.1-SE/filters-image-05-f.svg, because it fails on 64 bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 8 Sep 2011 11:36:55 +0000 (11:36 +0000)]
2011-09-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for chromium.

        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Table-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Table-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] fast/css/line-after-floating-div.html fails
ossy@webkit.org [Thu, 8 Sep 2011 10:16:49 +0000 (10:16 +0000)]
[Qt] fast/css/line-after-floating-div.html fails
https://bugs.webkit.org/show_bug.cgi?id=67772

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Csaba Osztrogon√°c.

* platform/qt/Skipped: Skip it until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGardening: add missing result after: r94710.
ossy@webkit.org [Thu, 8 Sep 2011 10:11:26 +0000 (10:11 +0000)]
Gardening: add missing result after: r94710.
https://bugs.webkit.org/show_bug.cgi?id=67768

Patch by Oliver Varga <voliver@inf.u-szeged.hu> on 2011-09-08
Reviewed by Zoltan Herczeg.

* platform/qt/fast/text/hyphenate-limit-lines-expected.png: Added.
* platform/qt/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-07 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 8 Sep 2011 08:55:43 +0000 (08:55 +0000)]
2011-09-07  Andrey Kosyakov  <caseq@chromium.org>

        Web Inspector: trying to scroll mouse wheel when in TextViewer's gutter pane causes EventException::DISPATCH_REQUEST_ERR
        https://bugs.webkit.org/show_bug.cgi?id=67715

        Reviewed by Yury Semikhatsky.

        - avoid exception on attempt to dispatch an event that is being dispatched by cloning the event.

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.forwardWheelEvent):
        (WebInspector.TextViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 8 Sep 2011 08:55:32 +0000 (08:55 +0000)]
2011-09-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Rebaselines for chromium.

        * platform/chromium-cg-mac-leopard/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Removed.
        * platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-linux/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-win/fast/css/line-after-floating-div-expected.png:
        * platform/chromium-win/fast/css/line-after-floating-div-expected.txt:
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added.
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Added.
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd standalone script that filters the output of build-webkit to be more human-readable
mdelaney@apple.com [Thu, 8 Sep 2011 07:05:15 +0000 (07:05 +0000)]
Add standalone script that filters the output of build-webkit to be more human-readable
https://bugs.webkit.org/show_bug.cgi?id=44081

Reviewed by Daniel Bates.

* Scripts/filter-build-webkit: Added. Just need to feed it the output of
a build script (e.g. build-webkit) and it spits out a prettier version.
* Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
* Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd myself to committers.py
noel.gordon@gmail.com [Thu, 8 Sep 2011 04:31:48 +0000 (04:31 +0000)]
Add myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=67696

Reviewed by Kent Tamura.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo in test_expectations introduced with r94725
rniwa@webkit.org [Thu, 8 Sep 2011 04:03:13 +0000 (04:03 +0000)]
Fix typo in test_expectations introduced with r94725
https://bugs.webkit.org/show_bug.cgi?id=67758

image-makering.html -> image-color-matching.html

Patch by Ben Wells <benwells@chromium.org> on 2011-09-07
Reviewed by Ryosuke Niwa.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded Snow Leopard results for this new test.
mitz@apple.com [Thu, 8 Sep 2011 03:39:35 +0000 (03:39 +0000)]
Added Snow Leopard results for this new test.

* platform/mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94674 and r94689.
commit-queue@webkit.org [Thu, 8 Sep 2011 03:00:31 +0000 (03:00 +0000)]
Unreviewed, rolling out r94674 and r94689.
http://trac.webkit.org/changeset/94674
http://trac.webkit.org/changeset/94689
https://bugs.webkit.org/show_bug.cgi?id=67754

Broke inspector/debugger/script-formatter.html (Requested by
rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._createRawSourceCodeId):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.get uiSourceCode):
(WebInspector.RawSourceCode.prototype.get rawSourceCode):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):

LayoutTests:

* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/script-formatter.html:
* inspector/debugger/source-file.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agooffsetFromRoot optimization is disabled after r93837
jchaffraix@webkit.org [Thu, 8 Sep 2011 01:38:22 +0000 (01:38 +0000)]
offsetFromRoot optimization is disabled after r93837
https://bugs.webkit.org/show_bug.cgi?id=67677

Reviewed by Simon Fraser.

Unfortunately not covered by any test as it does not change updateLayerPosition complexity (it is still O(n^2)
because of clippedOverflowRectForRepaint). However it is a noticeable slowdown on some use cases but we don't
have a good test harness to cover such slowdown.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions): Pass offsetFromRoot as not doing so means that we miss
the optimization altogether.

(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
* rendering/RenderLayer.h:
Renamed |cachedOffset| to |offsetFromRoot| to be consistent with our latest renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix my commit per darin's suggestion.
rniwa@webkit.org [Thu, 8 Sep 2011 01:31:26 +0000 (01:31 +0000)]
Fix my commit per darin's suggestion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix after r94737.
rniwa@webkit.org [Thu, 8 Sep 2011 01:27:06 +0000 (01:27 +0000)]
Windows build fix after r94737.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved hyphenation function implementations for an usupported build configuration.
mitz@apple.com [Thu, 8 Sep 2011 00:55:20 +0000 (00:55 +0000)]
Removed hyphenation function implementations for an usupported build configuration.

Reviewed by Sam Weinig.

* platform/text/cf/HyphenationCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67739
hyatt@apple.com [Thu, 8 Sep 2011 00:50:24 +0000 (00:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67739

adjustRectForColumns is O(# of columns) when it can be O(1). Fix the slow performance of this
function by removing the loop and just computing the start and end column for a repaint rect
and uniting everything in between.

Reviewed by Dan Bernstein.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustRectForColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate baselines for svg/as-background-image. These results all appear
abarth@webkit.org [Thu, 8 Sep 2011 00:26:51 +0000 (00:26 +0000)]
Update baselines for svg/as-background-image.  These results all appear
correct and test_expectations indicates that they just need new
baselines.

* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-5-expected.png:
* platform/chromium-win-vista/svg/as-background-image: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-win-vista/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
* platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
* svg/as-background-image/animated-svg-as-background-expected.txt: Added.
* svg/as-background-image/svg-as-background-1-expected.txt: Added.
* svg/as-background-image/svg-as-background-3-expected.txt: Added.
* svg/as-background-image/svg-as-background-5-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThese tests just differ in how JSC and V8 report error messages.
abarth@webkit.org [Thu, 8 Sep 2011 00:18:52 +0000 (00:18 +0000)]
These tests just differ in how JSC and V8 report error messages.

* platform/chromium-cg-mac-leopard/http/tests/security: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Added.
* platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOur results here reflect an intentional difference between GURL and
abarth@webkit.org [Thu, 8 Sep 2011 00:13:28 +0000 (00:13 +0000)]
Our results here reflect an intentional difference between GURL and
KURL.  KURL doesn't handle non-ASCII characters in the fragment in the
same was as IE whereas GURL does.

* platform/chromium/http/tests/uri: Added.
* platform/chromium/http/tests/uri/resolve-encoding-relative-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOur behavior is correct with respect to the new cookie RFC. I'm told
abarth@webkit.org [Thu, 8 Sep 2011 00:01:47 +0000 (00:01 +0000)]
Our behavior is correct with respect to the new cookie RFC.  I'm told
that CFNetwork is going to change this behavior to match every other
browser.

* platform/chromium/http/tests/cookies: Added.
* platform/chromium/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94714 and r94723.
commit-queue@webkit.org [Wed, 7 Sep 2011 23:51:15 +0000 (23:51 +0000)]
Unreviewed, rolling out r94714 and r94723.
http://trac.webkit.org/changeset/94714
http://trac.webkit.org/changeset/94723
https://bugs.webkit.org/show_bug.cgi?id=67746

breaks gtk-linux tests with assertion failure (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-07

Source/WebCore:

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
* platform/graphics/GraphicsContext.h:
(WebCore::GraphicsContext::inTransparencyLayer):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
* rendering/RenderThemeWin.cpp:
(WebCore::drawControl):

LayoutTests:

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Removed.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Removed.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Removed.
* svg/custom/simple-text-double-shadow.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPPC build fix.
fpizlo@apple.com [Wed, 7 Sep 2011 23:48:54 +0000 (23:48 +0000)]
PPC build fix.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results. The actual results are only off by a fraction of a
abarth@webkit.org [Wed, 7 Sep 2011 23:48:13 +0000 (23:48 +0000)]
Update results.  The actual results are only off by a fraction of a
pixel around the curve in the zero.

* platform/chromium-cg-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-mac/media/audio-repaint-expected.txt: Removed.
* platform/chromium-win-xp/media: Removed.
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium/media/audio-repaint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThese results are also off by just factional pixels.
abarth@webkit.org [Wed, 7 Sep 2011 23:43:25 +0000 (23:43 +0000)]
These results are also off by just factional pixels.

* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThese results all differ only in less than one pixel border or text rendering.
abarth@webkit.org [Wed, 7 Sep 2011 23:38:03 +0000 (23:38 +0000)]
These results all differ only in less than one pixel border or text rendering.

* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug6674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug22019-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2886-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2947-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug6674-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Mac baseline for the test added by r94331.
rniwa@webkit.org [Wed, 7 Sep 2011 23:35:07 +0000 (23:35 +0000)]
Add Mac baseline for the test added by r94331.

* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
* platform/mac/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for r94710.
rniwa@webkit.org [Wed, 7 Sep 2011 23:26:58 +0000 (23:26 +0000)]
Rebaseline for r94710.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 23:25:28 +0000 (23:25 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium svg/ rebaselines.

        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac-leopard/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac-leopard/svg/filters/filterRes-expected.png:
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
        * platform/chromium-cg-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-cg-mac/svg/batik/filters/feTile-expected.png:
        * platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png:
        * platform/chromium-cg-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Discrete-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Gamma-expected.png:
        * platform/chromium-cg-mac/svg/custom/feComponentTransfer-Linear-expected.png:
        * platform/chromium-cg-mac/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-cg-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-cg-mac/svg/filters/filterRes-expected.png:
        * platform/chromium-linux/svg/batik/text/textFeatures-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win-vista/svg/filters: Removed.
        * platform/chromium-win-xp/svg/css: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.png: Added.
        * platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
        * platform/chromium-win/svg/filters/filterRes-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocss2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
rniwa@webkit.org [Wed, 7 Sep 2011 23:16:08 +0000 (23:16 +0000)]
css2.1/t090204-display-change-01-b-ao.html is not attaching event listener properly
https://bugs.webkit.org/show_bug.cgi?id=67725

Reviewed by Dan Bernstein.

Revert the script fix in t090204-display-change-01-b-ao.html and css2.1 test suite and
replace line-after-floating-div.html by the fixed version.

Also move the expected result for line-after-floating-div.html from fast/css as it is platform dependent.

* css2.1/t090204-display-change-01-b-ao.html:
* fast/css/line-after-floating-div-expected.png: Removed.
* fast/css/line-after-floating-div-expected.txt: Removed.
* fast/css/line-after-floating-div.html:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.png:
* platform/mac/css2.1/t090204-display-change-01-b-ao-expected.txt:
* platform/mac/fast/css/line-after-floating-div-expected.png: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.png.
* platform/mac/fast/css/line-after-floating-div-expected.txt: Copied from
LayoutTests/fast/css/line-after-floating-div-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium baselines for svg/custom/simple-text-double-shadow
timothy_horton@apple.com [Wed, 7 Sep 2011 23:10:21 +0000 (23:10 +0000)]
Unreviewed, Chromium baselines for svg/custom/simple-text-double-shadow

* platform/chromium-linux/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-mac/svg/custom/simple-text-double-shadow.png: Added.
* platform/chromium-win/svg/custom/simple-text-double-shadow.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agorebaseline button in garden-o-matic details view should work
abarth@webkit.org [Wed, 7 Sep 2011 23:08:18 +0000 (23:08 +0000)]
rebaseline button in garden-o-matic details view should work
https://bugs.webkit.org/show_bug.cgi?id=67738

Reviewed by Dimitri Glazkov.

This patch wires up the rebaseline button in garden-o-matic results
details view.  The button is current per-test, so there isn't a way to
rebaseline individual bots.  This is a place to start.  If we decide we
want per-bot rebaselining, we'll need to think of some better UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader...
abarth@webkit.org [Wed, 7 Sep 2011 22:54:48 +0000 (22:54 +0000)]
FrameLoader::addExtraFieldsToRequest can crash when called from or after FrameLoader::detachFromParent
https://bugs.webkit.org/show_bug.cgi?id=61810

Reviewed by Eric Seidel.

Fix this crash as suggested by Darin Fisher in
https://bugs.webkit.org/show_bug.cgi?id=61810#c21.  This patch does not
include the test requested by Alexey Proskuryakov in
https://bugs.webkit.org/show_bug.cgi?id=61810#c6.  I would really much
rather include a test with this patch, but my attempts to write a test
have failed.  :(

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::loadFrameRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:49:37 +0000 (22:49 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium fast/css/ rebaslines.

        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-cg-mac/fast/css/line-after-floating-div-expected.txt: Added.
        * platform/chromium-linux/fast/css/getComputedStyle: Removed.
        * platform/chromium-linux/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win-vista/fast/css/getComputedStyle: Removed.
        * platform/chromium-win-xp/fast/css/getComputedStyle: Removed.
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/chromium-win/fast/css/line-after-floating-div-expected.png: Added.
        * platform/chromium-win/fast/css/line-after-floating-div-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 22:23:19 +0000 (22:23 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, patch up some chromium gpu expectations
        that are failing on the cg mac builds.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTeach the PortFactory object how to pass along executive/user/filesystem to port...
eric@webkit.org [Wed, 7 Sep 2011 22:19:14 +0000 (22:19 +0000)]
Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
https://bugs.webkit.org/show_bug.cgi?id=67737

Reviewed by Adam Barth.

I got a little over-eager when deprecating host.port_factory in the previous commit.
Turns out that Host.port_factory was already the "modern" port/factory.py
it was just the Module object.  I un-deprecated the variable, and changed it from
being the module to being an actual PortFactory, passing it a host object.
I also taught PortFactory how to set user/executive/filesystem in the kwargs
when instantiating a new Port object.
This magically fixed the test_rebaseline test, since its now no longer talking
to the real filesystem.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a new PortFactory class for creating new-style ports and deprecate the old PortFa...
eric@webkit.org [Wed, 7 Sep 2011 21:44:49 +0000 (21:44 +0000)]
Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
https://bugs.webkit.org/show_bug.cgi?id=67734

Reviewed by Adam Barth.

Right now every place that creates a Port object has to be very careful
to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
The correct fix is for port/factory.py (which creates most port objects)
to know how to pass these in automatically.  However, currently all port/factory.py
functions are free functions instead of being on an object.  This patch
adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.

In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
pass along the proper scm/user/filesystem to the Port object.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanges to aria-hidden don't change VO navigation
cfleizach@apple.com [Wed, 7 Sep 2011 21:42:02 +0000 (21:42 +0000)]
Changes to aria-hidden don't change VO navigation
https://bugs.webkit.org/show_bug.cgi?id=67722

Reviewed by Darin Adler.

Source/WebCore:

When altering aria-hidden, WebCore needs to update the children caches of
affected elements. However, for elements that were children, but ignored, their
caches did not get updated, and stale information would be propagated.

The fix is to always clearChildren() when a parent is asking for children. This
ensures information is always up to date when the parent itself is asking for new data.

Test: accessibility/aria-hidden-updates-alldescendants.html

* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaIsHidden):
(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

LayoutTests:

* accessibility/aria-hidden-updates-alldescendants-expected.txt: Added.
* accessibility/aria-hidden-updates-alldescendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-07 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 7 Sep 2011 21:39:32 +0000 (21:39 +0000)]
2011-09-07  Nate Chapin  <japhet@chromium.org>

        Unreviewed, upstream some chromium expected failure after skia roll,
        and rebaseline 2 tests for leopard cg.

        * platform/chromium-cg-mac-leopard/fast/borders/border-image-scaled-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/borders/border-image-side-reduction-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoText rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has...
timothy_horton@apple.com [Wed, 7 Sep 2011 21:35:03 +0000 (21:35 +0000)]
Text rendered with a simple (i.e. 0px blur) shadow inside a transparency layer has a double shadow
https://bugs.webkit.org/show_bug.cgi?id=67543
<rdar://problem/10070536>

Reviewed by Simon Fraser.

Generalize (begin|end)TransparencyLayer, which now forward
through to (begin|end)PlatformTransparencyLayer, so that
isInTransparencyLayer can exist on every platform.

Make use of isInTransparencyLayer in FontMac to disable
"simple" shadow drawing when the text is being rendered
into a transparency layer.

Test: svg/custom/simple-text-double-shadow.svg

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::~GraphicsContext):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::isInTransparencyLayer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/openvg/GraphicsContextOpenVG.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::isInTransparencyLayer):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/win/FontCGWin.cpp:
(WebCore::drawGDIGlyphs):
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextCairoWin.cpp:
(WebCore::GraphicsContext::releaseWindowsContext):
* platform/graphics/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::getWindowsContext):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
* platform/win/ScrollbarThemeWin.cpp:
* plugins/win/PluginViewWin.cpp:
* rendering/RenderThemeWin.cpp:

Add a test ensuring that text with 0px blur CSS shadow doesn't get rendered
with a second shadow when inside a transparency layer.

* platform/mac/svg/custom/simple-text-double-shadow-expected.png: Added.
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
* svg/custom/simple-text-double-shadow.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94714 268f45cc-cd09-0410-ab3c-d52691b4dbfc