WebKit-https.git
11 years ago2009-07-24 Jian Li <jianli@chromium.org>
jianli@chromium.org [Fri, 24 Jul 2009 17:30:10 +0000 (17:30 +0000)]
2009-07-24  Jian Li  <jianli@chromium.org>

        Reviewed by Eric Seidel.

        [V8] More V8 bindings changes to use ErrorEvent.
        https://bugs.webkit.org/show_bug.cgi?id=27630

        * bindings/v8/DOMObjectsInclude.h:
        * bindings/v8/DerivedSourcesAllInOne.cpp:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::convertEventToV8Object):
        * bindings/v8/V8Index.cpp:
        * bindings/v8/V8Index.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Fri, 24 Jul 2009 16:53:21 +0000 (16:53 +0000)]
WebCore:

2009-07-24  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Dave Hyatt.

        Clean up dependencies on Apple support libraries for non-Apple build.
        http://bugs.webkit.org/show_bug.cgi?id=27532.

        * platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references
          to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-24  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Dave Hyatt.

        Clean up dependencies on Apple support libraries for non-Apple build.
        http://bugs.webkit.org/show_bug.cgi?id=27532.

        * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
        * WebDownload.h: Conditionalize include of CFNetwork.h
        * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Another attempted build fix
mitz@apple.com [Fri, 24 Jul 2009 16:28:56 +0000 (16:28 +0000)]
    Another attempted build fix

        * bindings/js/JSAbstractWorkerCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 24 Jul 2009 16:28:12 +0000 (16:28 +0000)]
2009-07-24  David Levin  <levin@chromium.org>

        Reviewed by Adam Treat.

        cpplint crash when there is a duplicate header followed by another header.
        https://bugs.webkit.org/show_bug.cgi?id=27625

        * Scripts/modules/cpplint.py: Ensure that include_state.header_types is updated even
          there is a duplicate header, which resulted in some code rearrangement.  Also,
          changed some if's in this function to return early.  This avoids having nearly the
          whole function content being indented.
        * Scripts/modules/cpplint_unittest.py: Added a test which would have exposed the crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
mitz@apple.com [Fri, 24 Jul 2009 16:27:21 +0000 (16:27 +0000)]
    Build fix.

        * bindings/js/JSAbstractWorkerCustom.cpp:
        (WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Fri, 24 Jul 2009 15:37:39 +0000 (15:37 +0000)]
2009-07-24  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Filetype support changes for cpplint and check_webkit_style
         https://bugs.webkit.org/show_bug.cgi?id=27653

         Introduce .c support for check_webkit_style, and remove support for
         .cc files in favor of .cpp.

         * Scripts/check-webkit-style:
         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 24 Jul 2009 14:26:45 +0000 (14:26 +0000)]
2009-07-24  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Remove unneeded commas from PKG_CHECK_MODULES.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Fri, 24 Jul 2009 13:44:43 +0000 (13:44 +0000)]
2009-07-24  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Build fix for 64 bit Linux.

        int64_t is long on Linux 64 bit and not long long, thus
        getFileSize with a int64_t out value fails to build.

        Use a temporary to work around the problem.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::spaceNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Fri, 24 Jul 2009 13:44:21 +0000 (13:44 +0000)]
2009-07-24  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Build fix for Qt.

        Fix build issue introduced in 46344
        ([Bug 22700] ApplicationCache should have size limit)

        Remove method only added to the Qt ChromeClient.

        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Jul 2009 12:55:00 +0000 (12:55 +0000)]
2009-07-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        ApplicationCache Layout test failing on GTK
        https://bugs.webkit.org/show_bug.cgi?id=27648

        Add http/tests/appcache/max-size.html to the Skipped file for now.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Priit Laes <plaes@plaes.org>
xan@webkit.org [Fri, 24 Jul 2009 12:31:47 +0000 (12:31 +0000)]
2009-07-24  Priit Laes  <plaes@plaes.org>

        Reviewed by Xan Lopez.

        [Gtk] Password is saved into gnome-keyring even if auth. fails
        https://bugs.webkit.org/show_bug.cgi?id=27560

        Check authentication result and save password only when authentication
        succeeds.

        * webkit/webkitsoupauthdialog.c:
        (free_authData):
        (response_callback):
        (save_password_callback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Eli Fidler <eli.fidler@torchmobile.com>
levin@chromium.org [Fri, 24 Jul 2009 10:50:27 +0000 (10:50 +0000)]
2009-07-24  Eli Fidler  <eli.fidler@torchmobile.com>

        Reviewed by David Levin.

        Improve git workflow by populating commit messages with ChangeLog entries.
        https://bugs.webkit.org/show_bug.cgi?id=27605

        add --[no-]write prepare-ChangeLog options to bash completion

        * Scripts/webkit-tools-completion.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Jul 2009 10:03:34 +0000 (10:03 +0000)]
2009-07-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
        https://bugs.webkit.org/show_bug.cgi?id=27644

        Make a bunch more tests pass.  Still not all of them.
        The rest will pass when the last bits of bug 27634 land.

        * fast/dom/constructed-objects-prototypes-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:

2009-07-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
        https://bugs.webkit.org/show_bug.cgi?id=27644

        This is another attempt at making the change for bug 27634 smaller.
        I included the changes to make_names.pl as well as any file which
        used CREATE_DOM_*_WRAPPER macros.

        The changes to the construct* functions are what fix the cases in
        fast/dom/constructed-objects-prototypes.html

        The changes to passing globalObject through CREATE_* are what fix
        fast/dom/prototype-inheritance-2.html

        * bindings/js/JSCDATASectionCustom.cpp:
        (WebCore::toJSNewlyCreated): pass globalObject.
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSDOMBinding.h: updated macros to pass globalObject.
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::setAttributeNode): use globalObject() for wrapping return value.
        (WebCore::JSElement::setAttributeNodeNS): use globalObject() for wrapping return value.
        (WebCore::toJSNewlyCreated): pass globalObject.
        * bindings/js/JSEventCustom.cpp:
        (WebCore::JSEvent::clipboardData): pass globalObject.
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::getNamedItems): use globalObject() for wrapping returned collection items.
        (WebCore::callHTMLCollection): use globalObject() for wrapping returned collection items.
        (WebCore::JSHTMLCollection::item): use globalObject() for wrapping returned collection items.
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapper): pass globalObject.
        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS): pass globalObject.
        * bindings/js/JSTextCustom.cpp:
        (WebCore::toJSNewlyCreated): pass globalObject.
        * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
        (WebCore::constructWebKitCSSMatrix): use constructors globalObject when constructing
        * bindings/js/JSXMLHttpRequestConstructor.cpp:
        (WebCore::constructXMLHttpRequest): use constructors globalObject when constructing
        * bindings/js/JSXSLTProcessorConstructor.cpp:
        (WebCore::constructXSLTProcessor): use constructors globalObject when constructing
        * dom/make_names.pl:
            Pass globalObject through CREATE_* macros and various support functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
abarth@webkit.org [Fri, 24 Jul 2009 09:50:34 +0000 (09:50 +0000)]
2009-07-24  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin Adler and Adam Barth.

        Build fix for x86 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=27602

        * jit/JIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Andrei Popescu <andreip@google.com>
eric@webkit.org [Fri, 24 Jul 2009 09:15:48 +0000 (09:15 +0000)]
2009-07-24  Andrei Popescu  <andreip@google.com>

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Adds a unit test that ensures that the mechanism that
        enforces the maximum size of the application cache is
        working correctly.

        * http/tests/appcache/max-size-expected.txt: Added.
        * http/tests/appcache/max-size.html: Added.
        * http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls
        https://bugs.webkit.org/show_bug.cgi?id=27643

        This is an attempt to make this change as small as possible.
        I started by including all changes to CodeGeneratorJS.pm from bug 27634,
        and then made the minimal amount of other changes needed to support that change.

        Most toJS implementations ignore their passed JSDOMGlobalObject.
        There are stub 2-argument toJS, toJSNewlyCreated implementations to help compiling.
        All places where it is not clear what we should pass as the global object
        (or where the global object is simply not available, like for some SVG bindings)
        we pass deprecatedGlobalObjectForPrototype instead.

        * bindings/js/JSCDATASectionCustom.cpp:
        (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::setDOMException): pass the wrong globalObject for now
        * bindings/js/JSDOMBinding.h:
            Pass the wrong global object to the CREATE_ macros for now.
            In the next change we'll come back and pass the correct one.
            That will require changes to make_names.pl.
        (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
        (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
        (WebCore::DOMObjectWithGlobalPointer::~DOMObjectWithGlobalPointer):
        (WebCore::createDOMObjectWrapper):
        (WebCore::getDOMObjectWrapper):
        (WebCore::createDOMNodeWrapper):
        (WebCore::getDOMNodeWrapper):
        (WebCore::toJS): added to convert 2 arg calls to 3 arg calls to limit the scope of this change.
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::toJS): DOMWindow always uses its own prototype chain.
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSEventTarget.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSEventTarget.h:
        * bindings/js/JSHTMLCollectionCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSImageDataCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapper): pass globalObject to toJS(Document*) to avoid recursion
        (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::toJS): pass globalObject along
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::inverse): pass wrong globalObject for now.
        (WebCore::JSSVGMatrix::rotateFromVector): pass wrong globalObject for now.
        * bindings/js/JSSVGPathSegCustom.cpp:
        (WebCore::toJS):
        * bindings/js/JSSVGPathSegListCustom.cpp:
            All of these methods need a globalObject, but most SVG binding don't have
            space for one, so we just pass the lexicalGlobalObject for now.
        (WebCore::JSSVGPathSegList::initialize):
        (WebCore::JSSVGPathSegList::getItem):
        (WebCore::JSSVGPathSegList::insertItemBefore):
        (WebCore::JSSVGPathSegList::replaceItem):
        (WebCore::JSSVGPathSegList::removeItem):
        (WebCore::JSSVGPathSegList::appendItem):
        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::finishGetter): pass wrong globalObject for now.
        (WebCore::finishSetter):
        (WebCore::finishSetterReadOnlyResult):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::finishGetter): pass wrong globalObject for now.
        (WebCore::finishSetter):
        (WebCore::finishSetterReadOnlyResult):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::toJS): add ignored JSDOMGlobalObject*
        * bindings/js/JSTextCustom.cpp:
        (WebCore::toJSNewlyCreated): add ignored JSDOMGlobalObject*
        * bindings/js/JSWorkerContextBase.cpp:
        (WebCore::toJS): WorkerContext always uses its own prototype chain since it's a GlobalObject subclass.
        * bindings/js/JSWorkerContextBase.h:
        * bindings/scripts/CodeGeneratorJS.pm:
            All generated toJS calls now pass a globalObject.
            All generated toJS implementations now expect a globalObject.
            Simplified all the slot casts by using a "castedThis" local.
            SVG bindings which don't have a globalObject() accessor pass the deprecated lexicalGlobalObject instead.
            Simplified printing of constructor objects using a $constructorClassName variable.
            All generated constructor functions follow the construct$className form to match the custom constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 09:14:46 +0000 (09:14 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        typing "document.__proto__" in inspector throws exception
        https://bugs.webkit.org/show_bug.cgi?id=27169

        * inspector/front-end/utilities.js:
        (Object.type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Andrei Popescu <andreip@google.com>
abarth@webkit.org [Fri, 24 Jul 2009 09:12:30 +0000 (09:12 +0000)]
2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Adds the WebApplicationCache class that is
        used by the DumpRenderTree test application to
        configure the Application Cache maximum size.

        * WebCoreSupport/WebApplicationCache.h: Added.
        * WebCoreSupport/WebApplicationCache.mm: Added.
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::reachedMaxAppCacheSize):
        Adds empty implementation of the reachedMaxAppCacheSize callback.
        * WebKit.exp:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::reachedMaxAppCacheSize):
        Adds empty implementation of the reachedMaxAppCacheSize callback.
        * WebCoreSupport/ChromeClientQt.h:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::reachedMaxAppCacheSize):
        Adds empty implementation of reachedMaxAppCacheSize.
        * WebCoreSupport/ChromeClientGtk.h:

2009-07-24  Andrei Popescu  <andreip@google.com>

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Updated the project after adding WebApplicationCache.h/mm

        * WebKit.xcodeproj/project.pbxproj:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        * WebCoreSupport/WebChromeClient.cpp:
        (WebChromeClient::reachedMaxAppCacheSize):
        Adds empty implementation of the reachedMaxAppCacheSize callback.
        * WebCoreSupport/WebChromeClient.h:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        * WebKitSupport/ChromeClientWx.cpp:
        (WebCore::ChromeClientWx::reachedMaxAppCacheSize):
        Adds empty implementation of the reachedMaxAppCacheSize callback.
        * WebKitSupport/ChromeClientWx.h:

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        https://lists.webkit.org/pipermail/webkit-dev/2009-May/007560.html

        This change implements a mechanism for limiting the maximum size of
        the application cache file. When this size is reached, a ChromeClient
        callback is invoked asynchronously and the saving of the last (failed)
        cache is retried automatically.

        This change also extends the ApplicationCacheStorage API by allowing
        a client to query or modify the application cache without having to
        load any resources into memory.

        Test: http/tests/appcache/max-size.html

        * WebCore.base.exp:
        Exports the symbols required by the DumpRenderTree test application.
        * loader/EmptyClients.h:
        Adds empty implementation of the new ChromeClient methods.
        * loader/appcache/ApplicationCache.cpp:
        * loader/appcache/ApplicationCache.h:
        Adds the ability to calculate the approximate size of an ApplicationCache object.
        * loader/appcache/ApplicationCacheGroup.cpp:
        * loader/appcache/ApplicationCacheGroup.h:
        Invokes the ChromeClient callback when the storage layer runs out of space.
        After the callback is invoked, we re-attempt to store the newest cache,
        in case the ChromeClient has freed some space.
        * loader/appcache/ApplicationCacheResource.cpp:
        * loader/appcache/ApplicationCacheResource.h:
        Adds the ability to calculate the approximate size of an ApplicationCacheResource object.
        * loader/appcache/ApplicationCacheStorage.cpp:
        * loader/appcache/ApplicationCacheStorage.h:
        Enforces a maximum size for the application cache file.
        * page/ChromeClient.h:
        Adds a new callback, invoked when the ApplicationCacheStorage reports that it has
        reached the maximum size for its database file.
        * platform/sql/SQLiteDatabase.cpp:
        * platform/sql/SQLiteDatabase.h:
        Adds a new method that allows querying for the amount of unused space inside the
        application cache database file.

2009-07-24  Andrei Popescu  <andreip@google.com>

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Adds a unit test that ensures that the mechanism that
        enforces the maximum size of the application cache is
        working correctly.

        * http/tests/appcache/max-size-expected.txt: Added.
        * http/tests/appcache/max-size.html: Added.
        * http/tests/appcache/resources/maxsize.manifest: Added.

2009-07-24  Andrei Popescu  <andreip@google.com>

        Reviewed by Anders Carlsson.

        ApplicationCache should have size limit
        https://bugs.webkit.org/show_bug.cgi?id=22700

        Adds a new method on the LayoutTestController that
        allows a JS unit test to configure the maximum size
        of the Application Cache.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAppCacheMaximumSizeCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAppCacheMaximumSize):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setAppCacheMaximumSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 24 Jul 2009 08:42:49 +0000 (08:42 +0000)]
2009-07-24  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Use TextEncoding facilities to convert between UTF16 and UTF8
        instead of rolling our own solution.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (convertUniCharToUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 24 Jul 2009 08:42:35 +0000 (08:42 +0000)]
2009-07-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25415
        [GTK][ATK] Please implement support for get_text_at_offset

        Fix confusion in g_substr between length in bytes and length in
        characters. Was causing crashes in some situations when dealing
        with non-ASCII text encoded as UTF8.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (g_substr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 24 Jul 2009 08:39:09 +0000 (08:39 +0000)]
2009-07-24  Adam Barth  <abarth@webkit.org>

        Rubber stamped by Eric Seidel.

        Added andersca to list of reviewers.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix dozens of "Deallocation of a pointer not malloced" messages seen while running...
mrowe@apple.com [Fri, 24 Jul 2009 08:33:09 +0000 (08:33 +0000)]
Fix dozens of "Deallocation of a pointer not malloced" messages seen while running layout tests on the build bot.

Reviewed by Xan Lopez.

Memory allocated via FastMalloc was being deleted via the system memory allocator
due to an inconsistent including of FastMalloc.h.  We address this by including it
from config.h and including config.h from every implementation file, as in our other
projects.

* DumpRenderTree/ForwardingHeaders/wtf/FastMalloc.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/FastMalloc.h.
* DumpRenderTree/config.h:
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/mac/AppleScriptController.m:
* DumpRenderTree/mac/CheckedMalloc.cpp:
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* DumpRenderTree/mac/EditingDelegate.mm:
* DumpRenderTree/mac/EventSendingController.mm:
* DumpRenderTree/mac/FrameLoadDelegate.mm:
* DumpRenderTree/mac/GCControllerMac.mm:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/mac/NavigationController.m:
* DumpRenderTree/mac/ObjCController.m:
* DumpRenderTree/mac/ObjCPlugin.m:
* DumpRenderTree/mac/ObjCPluginFunction.m:
* DumpRenderTree/mac/PixelDumpSupportMac.mm:
* DumpRenderTree/mac/PlainTextController.mm:
* DumpRenderTree/mac/PolicyDelegate.mm:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
* DumpRenderTree/mac/TextInputController.m:
* DumpRenderTree/mac/UIDelegate.mm:
* DumpRenderTree/mac/WorkQueueItemMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 08:33:04 +0000 (08:33 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Impossible to add an attribute to a node without attributes
        https://bugs.webkit.org/show_bug.cgi?id=21108

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype.set hovered):
        (WebInspector.ElementsTreeElement.prototype.toggleNewButton):
        (WebInspector.ElementsTreeElement.prototype.ondblclick):
        (WebInspector.ElementsTreeElement.prototype._startEditing):
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Keishi Hattori <casey.hattori@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 08:31:33 +0000 (08:31 +0000)]
2009-07-24  Keishi Hattori  <casey.hattori@gmail.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: Adds support for Firebug's magic $0 variable to access inspected node
        https://bugs.webkit.org/show_bug.cgi?id=17907

        * inspector/front-end/Console.js:
        (WebInspector.Console.prototype._ensureCommandLineAPIInstalled): Added _inspectorCommandLineAPI.{
            _inspectedNodes, _addInspectedNode, $0, $1, $n}
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): Stores the inspected node history
            in _inspectorCommandLineAPI._inspectedNodes
        (WebInspector.ElementsPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 08:22:48 +0000 (08:22 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Dragging a resource in the sidebar should drag it's URL
        https://bugs.webkit.org/show_bug.cgi?id=14410

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.onattach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 08:21:16 +0000 (08:21 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Double click on a resource in the sidebar should open that resource in Safari
        https://bugs.webkit.org/show_bug.cgi?id=14409

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick): open a resource url

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert "2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>"
abarth@webkit.org [Fri, 24 Jul 2009 08:05:14 +0000 (08:05 +0000)]
Revert "2009-07-24  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>"

This reverts commit 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
abarth@webkit.org [Fri, 24 Jul 2009 07:59:14 +0000 (07:59 +0000)]
2009-07-24  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Build fix for x86 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=27602

        * jit/JIT.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Jul 2009 07:55:00 +0000 (07:55 +0000)]
2009-07-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        Bump pango version requirement to 1.12 and remove unnecessary #ifdefs.

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::getDefaultPangoLayout):
        * platform/graphics/gtk/FontPlatformDataPango.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/gtk/Language.cpp:

        Bump pango version requirement to 1.12 which is the version that
        came with Gtk 2.10.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:52:21 +0000 (07:52 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Missing UIString and other localizedString.js fixes
        https://bugs.webkit.org/show_bug.cgi?id=27288

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Joseph Pecoraro <joepeck02@gmail.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:51:39 +0000 (07:51 +0000)]
2009-07-24  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Timothy Hatcher.

        Inspector: Should Syntax Highlight JSON
        https://bugs.webkit.org/show_bug.cgi?id=27503

        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:44:59 +0000 (07:44 +0000)]
2009-07-24  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27624

        * page/DragController.cpp:
        (WebCore::DragController::~DragController):
        (WebCore::documentFragmentFromDragData):
        (WebCore::DragController::dragEnded):
        (WebCore::DragController::dragEntered):
        (WebCore::DragController::dragExited):
        (WebCore::DragController::dragUpdated):
        (WebCore::DragController::performDrag):
        (WebCore::asFileInput):
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::delegateDragSourceAction):
        (WebCore::DragController::concludeEditDrag):
        (WebCore::DragController::canProcessDrag):
        (WebCore::DragController::tryDHTMLDrag):
        (WebCore::DragController::mayStartDragAtEventLocation):
        (WebCore::getCachedImage):
        (WebCore::getImage):
        (WebCore::prepareClipboardForImageDrag):
        (WebCore::dragLocForDHTMLDrag):
        (WebCore::DragController::startDrag):
        (WebCore::DragController::doImageDrag):
        (WebCore::DragController::doSystemDrag):
        (WebCore::DragController::placeDragCaret):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:44:13 +0000 (07:44 +0000)]
2009-07-24  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Update WebCore/page/Chrome.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27608

        * page/Chrome.cpp:
        (WebCore::Chrome::runBeforeUnloadConfirmPanel):
        (WebCore::Chrome::runJavaScriptAlert):
        (WebCore::Chrome::runJavaScriptConfirm):
        (WebCore::Chrome::runJavaScriptPrompt):
        (WebCore::Chrome::shouldInterruptJavaScript):
        (WebCore::Chrome::setToolTip):
        (WebCore::Chrome::requestGeolocationPermissionForFrame):
        (WebCore::ChromeClient::generateReplacementFile):
        (WebCore::ChromeClient::paintCustomScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:43:28 +0000 (07:43 +0000)]
2009-07-24  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Update WebCore/page/Coordinates.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27614

        * page/Coordinates.cpp:
        (WebCore::Coordinates::toString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:42:38 +0000 (07:42 +0000)]
2009-07-24  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Update WebCore/page/DOMSelection.cpp/h to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27614

        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::setBaseAndExtent):
        (WebCore::DOMSelection::modify):
        (WebCore::DOMSelection::addRange):
        (WebCore::DOMSelection::deleteFromDocument):
        * page/DOMSelection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Jul 2009 07:42:09 +0000 (07:42 +0000)]
2009-07-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        x-frame constructor calls are instantiated with the wrong prototype chain
        https://bugs.webkit.org/show_bug.cgi?id=27566

        Add the test.  Soon to be fixed by bug 27634.

        * fast/dom/constructed-objects-prototypes-expected.txt: Added.
        * fast/dom/constructed-objects-prototypes.html: Added.
        * fast/dom/resources/constructed-objects-prototypes.js: Added.
        (classNameForObject):
        (constructorPropertiesOnWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out r46321 as it broke the Windows build.
mrowe@apple.com [Fri, 24 Jul 2009 07:31:33 +0000 (07:31 +0000)]
Roll out r46321 as it broke the Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Mike Fenton <mike.fenton@torchmobile.com>
abarth@webkit.org [Fri, 24 Jul 2009 07:28:44 +0000 (07:28 +0000)]
2009-07-24  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by Eric Seidel.

        Update WebCore/page/DOMTimer.cpp/h to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27618

        * page/DOMTimer.cpp:
        (WebCore::DOMTimer::DOMTimer):
        (WebCore::DOMTimer::~DOMTimer):
        (WebCore::DOMTimer::fired):
        (WebCore::DOMTimer::suspend):
        (WebCore::DOMTimer::resume):
        (WebCore::DOMTimer::canSuspend):
        * page/DOMTimer.h:
        (WebCore::DOMTimer::minTimerInterval):
        (WebCore::DOMTimer::setMinTimerInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a command line option to run-javascriptcore-tests to explicitly opt out of attemp...
mrowe@apple.com [Fri, 24 Jul 2009 07:15:46 +0000 (07:15 +0000)]
Add a command line option to run-javascriptcore-tests to explicitly opt out of attempting to rebuild JavaScriptCore.

Reviewed by Simon Hausmann.

This is primarily useful to speed up the build bots where one machine builds JavaScriptCore and a second runs the tests,
leading to situations where the build system unnecessarily feels that the need to recompile.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Jul 2009 07:14:34 +0000 (07:14 +0000)]
2009-07-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Classes call DOMObject::mark() explicitly, should call DOMObjectWithGlobal::mark() instead
        https://bugs.webkit.org/show_bug.cgi?id=27641

        Nothing uses globalObject() yet, but this was causing crashes
        in the patch for bug 27634.  This is covered by fast/dom/gc-6.html.

        I decided to change these to Base:: instead of DOMObjectWithGlobal::
        for future-proofing.  All autogenerated classes use a typedef Base
        to avoid bugs like these.  Sadly C++ does not have a built-in super:: we could use.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSAbstractWorkerCustom.cpp:
        (WebCore::JSAbstractWorker::mark):
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        (WebCore::JSDOMApplicationCache::mark):
        * bindings/js/JSMessageChannelCustom.cpp:
        (WebCore::JSMessageChannel::mark):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::mark):
        * bindings/js/JSNamedNodesCollection.cpp:
        (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::mark):
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::mark):
        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::mark):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::mark):
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::mark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Fri, 24 Jul 2009 07:04:21 +0000 (07:04 +0000)]
WebCore:

2009-07-23  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        Clean up dependencies on Apple support libraries for non-Apple build.
        http://bugs.webkit.org/show_bug.cgi?id=27532.

        * platform/graphics/win/SimpleFontDataWin.cpp: Conditionalize references
          to ApplicationServices.h and WebKitSystemInterface.h

WebKit/win:

2009-07-23  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        Clean up dependencies on Apple support libraries for non-Apple build.
        http://bugs.webkit.org/show_bug.cgi?id=27532.

        * DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
        * WebDownload.h: Conditionalize include of CFNetwork.h
        * WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Jul 2009 06:58:10 +0000 (06:58 +0000)]
2009-07-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make most DOMObjects hold onto a JSDOMGlobalObject*
        https://bugs.webkit.org/show_bug.cgi?id=27588

        inner.document.constructor is fixed because all properties on the window
        object are created with the correct globalObject (instead of the lexical one).
        Since all objects now carry a globalObject pointer, when document creates
        HTMLDocumentConstructor it now has the right globalObject to use.

        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:

2009-07-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make most DOMObjects hold onto a JSDOMGlobalObject*
        https://bugs.webkit.org/show_bug.cgi?id=27588

        This change is almost entirely plumbing.  Only one functional
        change as part of this all (window.document.constructor has the correct prototype)
        Changes are detailed below.

        inner.document.constructor is fixed because all properties on the window
        object are created with the correct globalObject (instead of the lexical one).
        Since all objects now carry a globalObject pointer, when document creates
        HTMLDocumentConstructor it now has the right globalObject to use.

        Tests:
          fast/dom/prototype-inheritance.html
          fast/dom/prototype-inheritance-2.html

        * bindings/js/DOMObjectWithSVGContext.h:
        (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
            Update the comment and add an ignored globalObject argument.
        * bindings/js/JSDOMBinding.h:
            Pass a globalObject to all DOMObjects during creation.  Currently it's the wrong global object.
            Once toJS is passed a globalObject it will be the right one.
        (WebCore::createDOMObjectWrapper):
        (WebCore::createDOMNodeWrapper):
        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::JSDOMGlobalObject::globalObject): Makes binding generation easier.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::history): JSHistory is now passed a globalObject, but since it has no custom constructor it doesn't use it.
        (WebCore::JSDOMWindow::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::location): JSLocation is now passed a globalObject, but since it has no custom constructor it doesn't use it.
        * bindings/js/JSHTMLAllCollection.h:
        (WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
        * bindings/js/JSHTMLCollectionCustom.cpp: Re-factoring needed to pass globalObject to JSNamedNodesCollection constructor.
        (WebCore::getNamedItems):
        (WebCore::callHTMLCollection):
        (WebCore::JSHTMLCollection::canGetItemsForName):
        (WebCore::JSHTMLCollection::nameGetter):
        (WebCore::JSHTMLCollection::item):
        (WebCore::JSHTMLCollection::namedItem):
        * bindings/js/JSHTMLFormElementCustom.cpp:
        (WebCore::JSHTMLFormElement::nameGetter):
        * bindings/js/JSNamedNodesCollection.cpp:
             Now passed globalObject.  This is tested by inner.document.forms.testForm.
             The passed globalObject is still wrong until toJS is fixed.
        (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
        * bindings/js/JSNamedNodesCollection.h:
        * bindings/js/JSSharedWorkerConstructor.cpp:
             Add DOMConstructorObject missed by http://trac.webkit.org/changeset/45938
             This class is not compiled by default, so not testable.
        (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):
        * bindings/js/JSSharedWorkerConstructor.h:
        * bindings/scripts/CodeGeneratorJS.pm:
             Make all bindings objects carry a globalObject pointer using DOMObjectWithGlobalPointer.
             SVG bindings which need a context() pointer do not have enough space for globalObject() too.
             WorkerContext does not need a globalObject (it is one), so special case it.
             Make all .constructor calls use the stored globalObject().  This is what fixes window.document.constructor.
             Make all constructors inherit from DOMConstructorObject for consistency.  Since the auto-bound constructors
             override createStructure anyway, there is no functional change here.  Just completing work started in r45938.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Jul 2009 06:50:31 +0000 (06:50 +0000)]
2009-07-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Eric Seidel.

        [Gtk] Add implementation of GCController for DRT
        https://bugs.webkit.org/show_bug.cgi?id=27636

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewWindowObjectCleared):
        (main):
        * DumpRenderTree/gtk/GCControllerGtk.cpp:
        (GCController::collect):
        (GCController::collectOnAlternateThread):

        Enable tests that are now passing.

        * platform/gtk/Skipped:

        Add SPI for GCController to use.

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_gc_collect_javascript_objects):
        (webkit_gc_collect_javascript_objects_on_alternate_thread):
        (webkit_gc_count_javascript_objects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 24 Jul 2009 06:37:59 +0000 (06:37 +0000)]
2009-07-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        Add new test to cover more prototype/constructor inheritance cases
        https://bugs.webkit.org/show_bug.cgi?id=27622

        This new test tries hard not to duplicate testing done
        by other tests and instead test new objects and prototype chains
        which will be fixed as soon as toJS is passed through the globalObject.

        This test crawls the object tree under the inner window, finding
        one of each type of JavaScript object.  It depends on all objects having
        a valid prototype chain with a unique name (which is not always the case).
        The test tries to stress the cases where the objects would be lazily
        creating other objects or their prototypes or constructors which would
        require these objects to have a back-pointer to the globalObject to be
        able to correctly wire up the prototype chains.

        * fast/dom/prototype-inheritance-2-expected.txt: Added.
        * fast/dom/prototype-inheritance-2.html: Added.
        * fast/dom/resources/prototype-inheritance-2.js: Added.
        (propertiesOnObject):
        ():
        (constructorNamesForWindow):
        (makeCrawlObject):
        (evalToCrawlObject):
        (pushPropertyValuesWithUnseenTypes):
        (crawl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Jul 2009 06:03:59 +0000 (06:03 +0000)]
2009-07-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Skip transitions/change-values-during-transition.html which
        pass/fails intermittently

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 24 Jul 2009 05:49:22 +0000 (05:49 +0000)]
2009-07-23  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Skip tests that require expected outputs. Also skip failing tests,
        with bugs raised against the failures.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip two new tests for GTK that use eventSender.
mrowe@apple.com [Fri, 24 Jul 2009 05:26:37 +0000 (05:26 +0000)]
Skip two new tests for GTK that use eventSender.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix layout tests that incorrectly attempt to detect whether they're running inside...
mrowe@apple.com [Fri, 24 Jul 2009 05:10:28 +0000 (05:10 +0000)]
Fix layout tests that incorrectly attempt to detect whether they're running inside DumpRenderTree using "if (layoutTestController)".

Rubber-stamped by Brady Eidson.

* editing/execCommand/25256.html:
* editing/execCommand/25320.html:
* fast/canvas/arc-crash.html:
* fast/css/emptyStyleTag.html:
* fast/events/js-keyboard-event-creation.html:
* fast/events/scrollbar-double-click.html:
* fast/forms/select-no-name.html:
* fast/history/window-open.html:
* platform/mac/fast/events/objc-event-api.html:
* platform/mac/fast/events/objc-keyboard-event-creation.html:
* scrollbars/scrollbar-miss-mousemove-disabled.html:
* scrollbars/scrollbar-miss-mousemove.html:
* storage/domstorage/localstorage/clear.html:
* storage/domstorage/localstorage/delete-removal.html:
* storage/domstorage/localstorage/enumerate-storage.html:
* storage/domstorage/localstorage/index-get-and-set.html:
* storage/domstorage/localstorage/onstorage-attribute-markup.html:
* storage/domstorage/localstorage/onstorage-attribute-setattribute.html:
* storage/domstorage/localstorage/private-browsing-affects-storage.html:
* storage/domstorage/localstorage/resources/window-open-second.html:
* storage/domstorage/localstorage/simple-events.html:
* storage/domstorage/localstorage/simple-usage.html:
* storage/domstorage/localstorage/string-conversion.html:
* storage/domstorage/localstorage/window-open.html:
* storage/domstorage/sessionstorage/clear.html:
* storage/domstorage/sessionstorage/delete-removal.html:
* storage/domstorage/sessionstorage/enumerate-storage.html:
* storage/domstorage/sessionstorage/index-get-and-set.html:
* storage/domstorage/sessionstorage/onstorage-attribute-markup.html:
* storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html:
* storage/domstorage/sessionstorage/private-browsing-affects-storage.html:
* storage/domstorage/sessionstorage/resources/window-open-second.html:
* storage/domstorage/sessionstorage/simple-events.html:
* storage/domstorage/sessionstorage/simple-usage.html:
* storage/domstorage/sessionstorage/string-conversion.html:
* storage/domstorage/sessionstorage/window-open.html:
* storage/domstorage/window-attributes-exist.html:
* svg/custom/stop-crash.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAnd now with some valid JavaScript syntax!
mrowe@apple.com [Fri, 24 Jul 2009 04:59:01 +0000 (04:59 +0000)]
And now with some valid JavaScript syntax!

* http/tests/misc/redirect-to-about-blank.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove unnecessary check for eventSender in an attempt to please the GTK build bot.
mrowe@apple.com [Fri, 24 Jul 2009 04:51:25 +0000 (04:51 +0000)]
Remove unnecessary check for eventSender in an attempt to please the GTK build bot.

* fast/css/getComputedStyle/getComputedStyle-text-overflow.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate build.webkit.org config for new machine.
mrowe@apple.com [Fri, 24 Jul 2009 04:35:24 +0000 (04:35 +0000)]
Update build.webkit.org config for new machine.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a workaround for <rdar://problem/6925892> to the test that it affects.
mrowe@apple.com [Fri, 24 Jul 2009 04:32:03 +0000 (04:32 +0000)]
Add a workaround for <rdar://problem/6925892> to the test that it affects.

Reviewed by Brady Eidson.

* http/tests/misc/redirect-to-about-blank.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 24 Jul 2009 03:56:02 +0000 (03:56 +0000)]
2009-07-23  Brady Eidson  <beidson@apple.com>

        Remove accidentally checked in code.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (waitUntilDoneWatchdogFired):
        (LayoutTestController::setWaitToDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Fri, 24 Jul 2009 03:00:54 +0000 (03:00 +0000)]
WebCore:

2009-07-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoff Garen.

        WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
        https://bugs.webkit.org/show_bug.cgi?id=27595

        Test: http/tests/misc/will-send-request-returns-null-on-redirect.html

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::removeResource): Null-check the request URL.

        * platform/network/cf/ResourceHandleCFNet.cpp: Ditto, and return null instead of creating an empty one.
        (WebCore::willSendRequest):

WebKit/win:

2009-07-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoff Garen.

        WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
        https://bugs.webkit.org/show_bug.cgi?id=27595

        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::dispatchWillSendRequest):

WebKitTools:

2009-07-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoff Garen.

        WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
        https://bugs.webkit.org/show_bug.cgi?id=27595

        Add the ability to tell the LayoutTestController to return a null request for willSendRequest
        redirect callbacks.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setWillSendRequestReturnsNullOnRedirectCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::willSendRequestReturnsNullOnRedirect):
        (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::willSendRequest):

LayoutTests:

2009-07-23  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoff Garen.

        WebCore has a few places that don't gracefully handle a null request returned from willSendRequest.
        https://bugs.webkit.org/show_bug.cgi?id=27595

        * http/tests/misc/resources/redirect-to-http-url.php: Added.
        * http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
        * http/tests/misc/will-send-request-returns-null-on-redirect.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 24 Jul 2009 02:54:55 +0000 (02:54 +0000)]
2009-07-23  Pierre d'Herbemont  <pdherbemont@apple.com>

        Fix layout tests, no review.

        Actually add the video-layer tests results for leopard, that were
        forgotten in r46302. Also add test results for windows.

        * platform/mac-leopard/fast/layers/video-layer-expected.png: Added.
        * platform/mac-leopard/fast/layers/video-layer-expected.txt: Added.
        * platform/win/fast/layers/video-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix DumpRenderTree to not fail an assertion on launch on a new machine.
mrowe@apple.com [Fri, 24 Jul 2009 02:14:42 +0000 (02:14 +0000)]
Fix DumpRenderTree to not fail an assertion on launch on a new machine.

Reviewed Oliver Hunt.

* DumpRenderTree/mac/DumpRenderTree.mm:
(setDefaultsToConsistentValuesForTesting): Disable the XSS auditor.  It being enabled
breaks all of the JavaScript tests within testStringByEvaluatingJavaScriptFromString,
which causes us to exit due to an assertion failure.  It's not clear why the XSS auditor
decides to interfere with these tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Fri, 24 Jul 2009 00:55:11 +0000 (00:55 +0000)]
2009-07-23  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Following changes on the video controls, video-layer tests results need to
        be updated in order to fix the layout tests.

        * platform/mac-leopard/fast/layers/video-layer-expected.checksum: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.checksum.
        * platform/mac-leopard/fast/layers/video-layer-expected.png: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.png.
        * platform/mac-leopard/fast/layers/video-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/layers/video-layer-expected.txt.
        * platform/mac/fast/layers/video-layer-expected.checksum: Removed.
        * platform/mac/fast/layers/video-layer-expected.png: Removed.
        * platform/mac/fast/layers/video-layer-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 27633 - AXLoadComplete can be fired off to frequently
cfleizach@apple.com [Fri, 24 Jul 2009 00:35:28 +0000 (00:35 +0000)]
Bug 27633 - AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 24 Jul 2009 00:11:03 +0000 (00:11 +0000)]
2009-07-23  Darin Adler  <darin@apple.com>

        * WebView/WebDataSource.mm:
        (-[WebDataSource _makeRepresentation]): Landed a comment I forgot last time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for three tests related to text fields as their metrics
mrowe@apple.com [Fri, 24 Jul 2009 00:09:42 +0000 (00:09 +0000)]
Update layout test results for three tests related to text fields as their metrics
have changed slightly since the results were last updated.

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/fast/forms/text-control-intrinsic-widths-expected.txt: Copied from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.
* platform/mac/fast/forms/input-text-maxlength-expected.txt:
* platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:
* platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt: Renamed from LayoutTests/fast/forms/text-control-intrinsic-widths-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Fri, 24 Jul 2009 00:09:17 +0000 (00:09 +0000)]
WebCore:

2009-07-23  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        URL appears in back/forward button menu instead of title for items with custom representation
        https://bugs.webkit.org/show_bug.cgi?id=27586
        rdar://problem/5060337

        * WebCore.base.exp: Exported DocumentLoader::setTitle for use by Mac WebKit.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didChangeTitle): Tightened code to check if the document
        loader is the correct one; previously this would never happen because we'd
        commit the load before any title changes could be registered, but now we can
        encounter a case where we get a title during a provisional load.

WebKit/mac:

2009-07-23  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        URL appears in back/forward button menu instead of title for items with custom representation
        https://bugs.webkit.org/show_bug.cgi?id=27586
        rdar://problem/5060337

        The problem is that DocumentLoader expects to store a title, but for custom representations
        it is never passed to the document loader.

        * WebView/WebDataSource.mm:
        (-[WebDataSource _makeRepresentation]): Added a call to DocumentLoader::setTitle.
        Works as long as the title does not change during the document's lifetime, which
        is good enough for the simple cases in Safari.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
mrowe@apple.com [Thu, 23 Jul 2009 23:44:03 +0000 (23:44 +0000)]
Update default state of the XSS auditor in GTK DumpRenderTree to match Mac and Windows
in hopes of fixing some layout test failures seen on the build bot.

Reviewed by Oliver Hunt.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows appears to match the Leopard results for the CSS 2.1 counter tests that were...
mrowe@apple.com [Thu, 23 Jul 2009 23:08:35 +0000 (23:08 +0000)]
Windows appears to match the Leopard results for the CSS 2.1 counter tests that were failing.

* platform/win/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt.
* platform/win/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 23 Jul 2009 23:00:41 +0000 (23:00 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        [CSS3 Backgrounds and Borders] Add support for inset box shadows
        https://bugs.webkit.org/show_bug.cgi?id=27582

        Test: fast/box-shadow/inset.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForShadow): Set the ShadowValue’s shadow style to 'inset'
            as needed.

        * css/CSSParser.cpp:
        (WebCore::ShadowParseContext::ShadowParseContext): Added style and allowStyle
            members. Initialize the allowStyle member.
        (WebCore::ShadowParseContext::commitValue): Pass the style value to the
            ShadowValue constructor. Reset allowStyle.
        (WebCore::ShadowParseContext::commitLength): Update allowStyle.
        (WebCore::ShadowParseContext::commitColor): Ditto.
        (WebCore::ShadowParseContext::commitStyle): Added. Sets the style member and
            updates the state.
        (WebCore::CSSParser::parseShadow): Parse the 'inset' keyword.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Get the style value from the
            shadow value and pass it to the ShadowData constructor.

        * css/ShadowValue.cpp:
        (WebCore::ShadowValue::ShadowValue): Added style.
        (WebCore::ShadowValue::cssText): Added style.

        * css/ShadowValue.h:
        (WebCore::ShadowValue::create): Added style.

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc): Added a blend function for shadow styles. When blending
            between normal and inset shadows, all intermediate values map to normal.
        (WebCore::PropertyWrapperShadow::blend): Added normal style to the default
            shadow.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBoxShadow): Added a shadow style parameter,
            which is passed through to RenderBoxModelObject::paintBoxShadow().

        (WebCore::InlineFlowBox::paintBoxDecorations): Paint inset shadows on top of
            the background.

        * rendering/InlineFlowBox.h:

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations): Paint inset shadows on top of the
            background.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow): Added a shadow style
            parameter, and code to paint inset shadows.

        * rendering/RenderBoxModelObject.h:

        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations): Paint inset shadows on top of
            the background.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintBoxDecorations): Ditto.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBoxDecorations): Ditto.

        * rendering/style/ShadowData.h:
        Added a ShadowStyle enum.
        (WebCore::ShadowData::ShadowData): Add and initialize a style member.

LayoutTests:

        Reviewed by Dave Hyatt.

        [CSS3 Backgrounds and Borders] Add support for inset box shadows
        https://bugs.webkit.org/show_bug.cgi?id=27582

        * fast/box-shadow/inset.html: Added.
        * platform/mac/fast/box-shadow/inset-expected.checksum: Added.
        * platform/mac/fast/box-shadow/inset-expected.png: Added.
        * platform/mac/fast/box-shadow/inset-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 22:53:47 +0000 (22:53 +0000)]
2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Fix false positives for switch statement indentation check in cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27615

         Makes one-line case statements (e.g. "case foo: bar();") work.
         Also a few general improvements to the robustness and readability of
         the check, and more test cases.

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Jul 2009 22:52:30 +0000 (22:52 +0000)]
2009-07-23  Simon Fraser  <simon.fraser@apple.com>

        Fix the build with UNUSED_PARAM(frame) for when ENABLE(3D_RENDERING) is not defined.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::transform_3dMediaFeatureEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 22:49:49 +0000 (22:49 +0000)]
2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

         Reviewed by Adam Treat.

         Add check for line-breaking rule #3 to cpplint.
         https://bugs.webkit.org/show_bug.cgi?id=27610

         "An else if statement should be written as an if statement when
         the prior if concludes with a return statement."

         Implemented by a multi-line (kind of back-tracking) algorithm.
         Comes with loads of unit tests. Fixes the check for label indentation
         to be not so overzealous, as it didn't allow for completely unindented
         goto labels (at the very start of a line).

         * Scripts/modules/cpplint.py:
         * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Jul 2009 22:37:44 +0000 (22:37 +0000)]
2009-07-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        3d-transforms media query needs to look check that accelerated compositing is enabled
        https://bugs.webkit.org/show_bug.cgi?id=27621

        When evaluating a media query with '-webkit-transform-3d', we need to check the
        runtime switch that toggles accererated compositing, and therefore 3D.

        No test because we can't disable the pref dynamically in DRT.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::transform_3dMediaFeatureEval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for two international text tests that are failing due...
mrowe@apple.com [Thu, 23 Jul 2009 22:31:34 +0000 (22:31 +0000)]
Update layout test results for two international text tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/fast/text/international/thai-baht-space-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.checksum.
* platform/mac-leopard/fast/text/international/thai-baht-space-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.png.
* platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/thai-baht-space-expected.txt.
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
* platform/mac/fast/text/international/thai-baht-space-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for two CSS 2.1 counter tests that are failing due to...
mrowe@apple.com [Thu, 23 Jul 2009 22:13:16 +0000 (22:13 +0000)]
Update layout test results for two CSS 2.1 counter tests that are failing due to font differences.

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counter-04-b-expected.txt.
* platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1202-counters-04-b-expected.txt.
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Pierre d'Herbemont <pdherbemont@apple.com>
pdherbemont@apple.com [Thu, 23 Jul 2009 22:03:10 +0000 (22:03 +0000)]
2009-07-23  Pierre d'Herbemont  <pdherbemont@apple.com>

        Layout test fix so no review.

        Add audio-controls-rendering layout test results for windows and leopard.

        * platform/mac-leopard/media/audio-controls-rendering-expected.txt: Added.
        * platform/win/media/audio-controls-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for the addition of a new computed style property in r46285.
mrowe@apple.com [Thu, 23 Jul 2009 21:40:56 +0000 (21:40 +0000)]
Update layout test results for the addition of a new computed style property in r46285.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
rniwa@webkit.org [Thu, 23 Jul 2009 21:17:00 +0000 (21:17 +0000)]
WebCore:

2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand('underline') can't remove <U> underlines
        https://bugs.webkit.org/show_bug.cgi?id=20215

        This patch adds support for u, s, and strike to implicitlyStyledElementShouldBeRemovedWhenApplyingStyle so that
        WebKit can remove those presentational tags when necessary.
        It also modifies StyleChange::init not to add "text-decoration: none".  Not only is this style meaningless
        (does not override inherited styles) but it was also causing WebKit to generate extra spans with this style.

        * css/CSSValueList.cpp:
        (WebCore::CSSValueList::hasValue): True if the property contains the specified value
        * css/CSSValueList.h: Updated prototype
        * editing/ApplyStyleCommand.cpp:
        (WebCore::StyleChange::init): No longer adds "text-decoration: none"
        (WebCore::ApplyStyleCommand::implicitlyStyledElementShouldBeRemovedWhenApplyingStyle): Supports text-decoration-related elements

LayoutTests:

2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        execCommand('underline') can't remove <U> underlines
        https://bugs.webkit.org/show_bug.cgi?id=20215

        This patch rebaselines toggle-styles.html because WebKit now passes three tests it used to fail.
        toggle-style-2.html is added to test cases in which multiple styles are specified with tags.
        We still fail some tests because WebKit doesn't properly support non-CSS mode but they are visually correct.

        * editing/execCommand/resources/toggle-style-2.js: Added.
        (testSingleToggle):
        (testDoubleToggle):
        * editing/execCommand/toggle-style-2-expected.txt: Added.
        * editing/execCommand/toggle-style-2.html: Added.
        * editing/execCommand/toggle-styles-expected.txt: Passes all the tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Thu, 23 Jul 2009 21:03:42 +0000 (21:03 +0000)]
2009-07-23  Jessie Berlin  <jberlin@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=27554
        Expose the value of text-overflow in getComputedStyle.

        Reviewed by Dan Bernstein.

        Test: fast/css/getComputedStyle/getComputedStyle-text-overflow.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        Add text-overflow to the list of computedProperties.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        Return the value of the text-overflow property.

        * fast/css/getComputedStyle/getComputedStyle-text-overflow-expected.txt: Added.
        * fast/css/getComputedStyle/getComputedStyle-text-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Yongjun Zhang <yongjun.zhang@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 20:48:16 +0000 (20:48 +0000)]
2009-07-23  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=27510

        [S60 QtWebKit] Don't put some intermediate generated files into the final mmp project
        file for linking. This is a temporary workaround for qmake bug in Symbian port, should
        be reverted after qmake is fixed.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jian Li <jianli@chromium.org>
jianli@chromium.org [Thu, 23 Jul 2009 20:37:02 +0000 (20:37 +0000)]
2009-07-23  Jian Li  <jianli@chromium.org>

        Reviewed by David Levin.

        [V8] Fix an assert in running workers in Chrome.
        https://bugs.webkit.org/show_bug.cgi?id=27620

        The fix is to change V8DOMMap::removeAllDOMObjectsInCurrentThreadHelper
        to do not call removeObjectsFromWrapperMap for certain types of DOM
        objects that exist only in main thread.

        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jul 2009 19:24:52 +0000 (19:24 +0000)]
2009-07-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by David Hyatt.

        Rebaseline for http://trac.webkit.org/changeset/46274
        (The changeset rebaselined the expected results for mac but not for windows)

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 23 Jul 2009 19:06:33 +0000 (19:06 +0000)]
WebCore:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27572
        Implement support for background-attachment:local.

        Added new test fast/overflow/overflow-with-local-attachment.html.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFillProperty):
        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator EFillAttachment):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::mapFillAttachment):
        * css/CSSValueKeywords.in:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
        * rendering/style/FillLayer.h:
        (WebCore::FillLayer::attachment):
        (WebCore::FillLayer::setAttachment):
        (WebCore::FillLayer::hasFixedImage):
        (WebCore::FillLayer::initialFillAttachment):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::backgroundAttachment):
        (WebCore::InheritedFlags::maskAttachment):
        * rendering/style/RenderStyleConstants.h:
        (WebCore::):

LayoutTests:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27572
        Implement support for background-attachment:local.

        Added new test fast/overflow/overflow-with-local-attachment.html.

        * fast/overflow/overflow-with-local-background-attachment.html: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.checksum: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
        * platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jul 2009 18:55:48 +0000 (18:55 +0000)]
2009-07-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        copyInheritableProperties and removeComputedInheritablePropertiesFrom should be deprecated
        https://bugs.webkit.org/show_bug.cgi?id=27325

        This patch deprecates copyInheritableProperties because it has been used for two different purposes:
        1.  Calculating the typing style.
        2.  Moving HTML subtrees and seeking to remove redundant styles.
        These tasks should be broken out into two separate functions.  New code should not use this function.

        It deletes removeComputedInheritablePropertiesFrom because it hasn't been used anywhere.

        There is no test since the patch does not change any behavior.

        * css/CSSComputedStyleDeclaration.cpp: removeComputedInheritablePropertiesFrom has been removed
        (WebCore::CSSComputedStyleDeclaration::deprecatedCopyInheritableProperties): has been renamed from copyInheritableProperties
        * css/CSSComputedStyleDeclaration.h: ditto
        * editing/DeleteSelectionCommand.cpp: ditto
        (WebCore::removeEnclosingAnchorStyle): ditto
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): ditto
        * editing/EditCommand.cpp: ditto
        (WebCore::EditCommand::styleAtPosition): ditto
        * editing/RemoveFormatCommand.cpp: ditto
        (WebCore::RemoveFormatCommand::doApply): ditto
        * editing/ReplaceSelectionCommand.cpp: ditto
        (WebCore::handleStyleSpansBeforeInsertion): ditto
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): ditto
        * editing/markup.cpp: ditto
        (WebCore::removeEnclosingMailBlockquoteStyle): ditto
        (WebCore::removeDefaultStyles): ditto
        (WebCore::createMarkup): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
pdherbemont@apple.com [Thu, 23 Jul 2009 18:42:23 +0000 (18:42 +0000)]
WebCore:

    2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Audio element at default width shouldn't have time field.
        https://bugs.webkit.org/show_bug.cgi?id=27589

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't
        forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        Audio element at default width shouldn't have time field.
        https://bugs.webkit.org/show_bug.cgi?id=27589

        * platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
        * platform/mac/media/audio-controls-rendering-expected.checksum:
        * platform/mac/media/audio-controls-rendering-expected.png:
        * platform/mac/media/audio-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Thu, 23 Jul 2009 18:29:39 +0000 (18:29 +0000)]
2009-07-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Adam Treat.

        Added expected results for tests that we pass.

        * platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt: Added.
        * platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
        * platform/qt/fast/box-shadow/transform-fringing-expected.txt: Added.
        * platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt: Added.
        * platform/qt/fast/css/attribute-selector-dynamic-expected.txt: Added.
        * platform/qt/fast/css/nth-child-dynamic-expected.txt: Added.
        * platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
        * platform/qt/fast/dynamic/anchor-lock-expected.txt: Added.
        * platform/qt/fast/frames/frameset-style-recalc-expected.txt: Added.
        * platform/qt/fast/frames/iframe-text-contents-expected.txt: Added, equal to mac.
        * platform/qt/fast/frames/viewsource-on-image-file-expected.txt: Added.
        * platform/qt/fast/repaint/background-generated-expected.txt: Added, equal to mac.
        * platform/qt/fast/repaint/background-misaligned-expected.txt: Added, equal to mac.
        * platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Added, equal to mac.
        * platform/qt/fast/text/international/hindi-whitespace-expected.txt: Added.
        * platform/qt/fast/transforms/bounding-rect-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, adding missing header.
kevino@webkit.org [Thu, 23 Jul 2009 18:21:30 +0000 (18:21 +0000)]
wx build fix, adding missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Thu, 23 Jul 2009 18:10:40 +0000 (18:10 +0000)]
2009-07-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=27598 Clean up the
        AccessibilityObject class

        Mostly this is just moving empty stubs into the header rather than
        muddying the cpp file with them. A few functions were made pure
        virtual.

        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::isARIAControl):
        (WebCore::AccessibilityObject::clickPoint):
        (WebCore::AccessibilityObject::documentFrameView):
        (WebCore::AccessibilityObject::actionVerb):
        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::intValue):
        (WebCore::AccessibilityObject::layoutCount):
        (WebCore::AccessibilityObject::doAccessibilityHitTest):
        (WebCore::AccessibilityObject::focusedUIElement):
        (WebCore::AccessibilityObject::firstChild):
        (WebCore::AccessibilityObject::lastChild):
        (WebCore::AccessibilityObject::previousSibling):
        (WebCore::AccessibilityObject::nextSibling):
        (WebCore::AccessibilityObject::parentObjectIfExists):
        (WebCore::AccessibilityObject::observableObject):
        (WebCore::AccessibilityObject::linkedUIElements):
        (WebCore::AccessibilityObject::titleUIElement):
        (WebCore::AccessibilityObject::ariaRoleAttribute):
        (WebCore::AccessibilityObject::isPresentationalChildOfAriaRole):
        (WebCore::AccessibilityObject::ariaRoleHasPresentationalChildren):
        (WebCore::AccessibilityObject::roleValue):
        (WebCore::AccessibilityObject::ariaAccessiblityName):
        (WebCore::AccessibilityObject::ariaLabeledByAttribute):
        (WebCore::AccessibilityObject::ariaDescribedByAttribute):
        (WebCore::AccessibilityObject::accessibilityDescription):
        (WebCore::AccessibilityObject::ariaSelectedTextDOMRange):
        (WebCore::AccessibilityObject::axObjectCache):
        (WebCore::AccessibilityObject::axObjectID):
        (WebCore::AccessibilityObject::setAXObjectID):
        (WebCore::AccessibilityObject::anchorElement):
        (WebCore::AccessibilityObject::actionElement):
        (WebCore::AccessibilityObject::boundingBoxRect):
        (WebCore::AccessibilityObject::selectedTextRange):
        (WebCore::AccessibilityObject::selectionStart):
        (WebCore::AccessibilityObject::selectionEnd):
        (WebCore::AccessibilityObject::url):
        (WebCore::AccessibilityObject::selection):
        (WebCore::AccessibilityObject::stringValue):
        (WebCore::AccessibilityObject::title):
        (WebCore::AccessibilityObject::helpText):
        (WebCore::AccessibilityObject::textUnderElement):
        (WebCore::AccessibilityObject::text):
        (WebCore::AccessibilityObject::textLength):
        (WebCore::AccessibilityObject::selectedText):
        (WebCore::AccessibilityObject::accessKey):
        (WebCore::AccessibilityObject::widget):
        (WebCore::AccessibilityObject::widgetForAttachmentView):
        (WebCore::AccessibilityObject::setFocused):
        (WebCore::AccessibilityObject::setSelectedText):
        (WebCore::AccessibilityObject::setSelectedTextRange):
        (WebCore::AccessibilityObject::setValue):
        (WebCore::AccessibilityObject::setSelected):
        (WebCore::AccessibilityObject::makeRangeVisible):
        (WebCore::AccessibilityObject::childrenChanged):
        (WebCore::AccessibilityObject::addChildren):
        (WebCore::AccessibilityObject::hasChildren):
        (WebCore::AccessibilityObject::selectedChildren):
        (WebCore::AccessibilityObject::visibleChildren):
        (WebCore::AccessibilityObject::visiblePositionRange):
        (WebCore::AccessibilityObject::visiblePositionRangeForLine):
        (WebCore::AccessibilityObject::boundsForVisiblePositionRange):
        (WebCore::AccessibilityObject::setSelectedVisiblePositionRange):
        (WebCore::AccessibilityObject::visiblePositionForPoint):
        (WebCore::AccessibilityObject::nextVisiblePosition):
        (WebCore::AccessibilityObject::previousVisiblePosition):
        (WebCore::AccessibilityObject::visiblePositionForIndex):
        (WebCore::AccessibilityObject::indexForVisiblePosition):
        (WebCore::AccessibilityObject::index):
        (WebCore::AccessibilityObject::doAXRangeForLine):
        (WebCore::AccessibilityObject::doAXRangeForIndex):
        (WebCore::AccessibilityObject::doAXStringForRange):
        (WebCore::AccessibilityObject::doAXBoundsForRange):
        (WebCore::AccessibilityObject::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix of <rdar://4877658> Dragging from the area between the horizontal/vertical scroll...
bweinstein@apple.com [Thu, 23 Jul 2009 18:05:21 +0000 (18:05 +0000)]
Fix of <rdar://4877658> Dragging from the area between the horizontal/vertical scrollbars when status bar is showing starts a selection and autoscroll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Thu, 23 Jul 2009 17:20:13 +0000 (17:20 +0000)]
WebCore:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27581
        Drop the prefix from the box-shadow property.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        (WebCore::ShadowParseContext::commitLength):
        (WebCore::cssPropertyID):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/animation/AnimationBase.cpp:
        (WebCore::ensurePropertyMap):

LayoutTests:

2009-07-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=27581
        Drop the prefix from the box-shadow property.

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
treat@webkit.org [Thu, 23 Jul 2009 16:55:55 +0000 (16:55 +0000)]
WebCore:
2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27289
        When a mouse click occurs on a scrollbar without a preceding mouse move
        onto it, the release isn't handled correctly (since
        EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
        only on mouse move). (Side comment: That scrollbar-handling code
        in EventHandler is ugly. It should be fixed properly.)

        Tests: scrollbars/scrollbar-miss-mousemove.html
               scrollbars/scrollbar-miss-mousemove-disabled.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::EventHandler::updateLastScrollbarUnderMouse):
        * page/EventHandler.h:

LayoutTests:
2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=27289
        Tests that mouse clicks/releases are handled properly on scrollbars
        even when there is no mouse move onto the scrollbar (two cases: enabled
        and disabled controls).

        * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
        * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
        * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
        * scrollbars/scrollbar-miss-mousemove.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
levin@chromium.org [Thu, 23 Jul 2009 16:52:55 +0000 (16:52 +0000)]
2009-07-23  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Update WebCore/page/BarInfo.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27606

        * page/BarInfo.cpp:
        (WebCore::BarInfo::visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Mike Fenton <mike.fenton@torchmobile.com>
levin@chromium.org [Thu, 23 Jul 2009 16:52:50 +0000 (16:52 +0000)]
2009-07-23  Mike Fenton  <mike.fenton@torchmobile.com>

        Reviewed by David Levin.

        Update WebCore/page/Console.cpp to conform to WebKit
        Style Guidelines as identified by cpplint.py.
        https://bugs.webkit.org/show_bug.cgi?id=27606

        * page/Console.cpp:
        (WebCore::printMessageSourceAndLevelPrefix):
        (WebCore::Console::profile):
        (WebCore::Console::time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Eli Fidler <eli.fidler@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 16:32:44 +0000 (16:32 +0000)]
2009-07-23  Eli Fidler  <eli.fidler@torchmobile.com>

         Reviewed by Adam Treat.

         Improve git workflow by populating commit messages with ChangeLog entries.
         https://bugs.webkit.org/show_bug.cgi?id=27605

         add --[no-]write option to optionally output new ChangeLog entries to
         stdout instead of modifying ChangeLog files

         fix Torch Mobile copyright

         * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Jakob Petsovits <jakob.petsovits@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 16:13:50 +0000 (16:13 +0000)]
2009-07-23  Jakob Petsovits  <jakob.petsovits@torchmobile.com>

        Reviewed by Adam Treat.

        Enable cpplint for .c files.
        https://bugs.webkit.org/show_bug.cgi?id=27604

        Also make sure that the check for NULL does not apply to .c files.

        * Scripts/modules/cpplint.py:
        * Scripts/modules/cpplint_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Thu, 23 Jul 2009 15:51:25 +0000 (15:51 +0000)]
2009-07-22  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        Add wince specific memory files into wtf/wince
        https://bugs.webkit.org/show_bug.cgi?id=27550

        * wtf/wince/FastMallocWince.h: Added.
        * wtf/wince/MemoryManager.cpp: Added.
        * wtf/wince/MemoryManager.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 14:31:10 +0000 (14:31 +0000)]
2009-07-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add simple proxy support for QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=27495

        Picks up proxy settings from the http_proxy environment
        variable.

        * QtLauncher/QtLauncher.pro: Add QtNetwork dependency for all
        platforms.
        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Norbert Leser <norbert.leser@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 14:28:47 +0000 (14:28 +0000)]
2009-07-23  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Fix for missing mmap features in Symbian
        https://bugs.webkit.org/show_bug.cgi?id=24540

        Fix, conditionally for PLATFORM(SYMBIAN), as an alternative
        to missing support for the MAP_ANON property flag in mmap.
        It utilizes Symbian specific memory allocation features.

        * runtime/Collector.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Thu, 23 Jul 2009 13:34:34 +0000 (13:34 +0000)]
WebCore:

2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        Fix crashes with the QObject bindings after garbage collection.

        There is one QtInstance per wrapped QObject, and that QtInstance keeps
        references to cached JSObjects for slots. When those objects get
        deleted due to GC, then they becoming dangling pointers.

        When a cached member dies, it is now removed from the QtInstance's
        cache.

        As we cannot track the lifetime of the children, we have to remove
        them from QtInstance alltogether. They are not cached and were
        only used for mark(), but we _want_ them to be subject to gc.

        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup,
        use qDeleteAll().
        (JSC::Bindings::QtInstance::removeCachedMethod): New function, to
        clean m_methods and m_defaultMethod.
        (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects.
        (JSC::Bindings::QtField::valueFromInstance): Don't save children for
        marking.
        * bridge/qt/qt_instance.h: Declare removeCachedMethod.
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod
        with this on the instance.

WebKit/qt:

2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Holger Freyther.

        Added a testcase to verify that cached methods in the QOBject bindings
        remain alife even after garbage collection.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
hausmann@webkit.org [Thu, 23 Jul 2009 10:24:12 +0000 (10:24 +0000)]
2009-07-23  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>

        Reviewed by Simon Hausmann.

        Fixing two issues related to QtLauncher
          - MainWindow objects are not always freed after close
          - JavaScript window.close() sometimes crashes
        https://bugs.webkit.org/show_bug.cgi?id=27601

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 23 Jul 2009 10:20:51 +0000 (10:20 +0000)]
2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Rebaseline the Qt results for computed-style.html and
        computed-style-without-rendered.html after r46240, similar to r46252.

        * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 09:57:15 +0000 (09:57 +0000)]
2009-07-23  David Levin  <levin@chromium.org>

         Rubber-stamped by Oliver Hunt.

        Improve keyboard navigation of Select elements.
        Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
        on non-Mac platforms.
        https://bugs.webkit.org/show_bug.cgi?id=22784

        One more round of speculative fixes:
         - Really fix the general and win expected results.  (They were missing a return.)
         - Disable the test for gtk (and remove the attempted workaround for that platform).

        * fast/forms/select-popup-pagekeys-expected.txt:
        * fast/forms/select-popup-pagekeys.html:
        * platform/gtk/Skipped:
        * platform/win/fast/forms/select-popup-pagekeys-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 09:09:55 +0000 (09:09 +0000)]
2009-07-23  David Levin  <levin@chromium.org>

        Rubber-stamped by Oliver Hunt.

        3 (speculative) fixes for the new layout test: select-popup-pagekeys
         - Help Windows to pass by adding platform results.
         - Fix the general expected results.
         - Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.

        * fast/forms/select-popup-pagekeys-expected.txt:
        * fast/forms/select-popup-pagekeys.html:
        * platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 23 Jul 2009 08:01:08 +0000 (08:01 +0000)]
2009-07-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=27599
        'const unsigned' in return value

        Remove const modifier from unsigned return value, as it does not
        make sense.

        * dom/ErrorEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-22 Jens Alfke <snej@chromium.org>
levin@chromium.org [Thu, 23 Jul 2009 07:52:31 +0000 (07:52 +0000)]
2009-07-22  Jens Alfke  <snej@chromium.org>

        Reviewed by David Levin.

        Bug 22784: Improve keyboard navigation of Select elements.
        Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
        on non-Mac platforms.
        https://bugs.webkit.org/show_bug.cgi?id=22784
        http://code.google.com/p/chromium/issues/detail?id=4576

WebCore:

        New test: LayoutTests/fast/forms/select-popup-pagekeys.html

        * dom/SelectElement.cpp:
        (WebCore::nextValidIndex):
        New utility fn for traversing items of a select's list.
        (WebCore::SelectElement::menuListDefaultEventHandler):
        Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.

LayoutTests:

        * LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
        * LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
        * LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-07-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 23 Jul 2009 07:36:00 +0000 (07:36 +0000)]
2009-07-23  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Mark Rowe.

        Fix a couple of compiler warnings.

        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (copySurface):
        * platform/graphics/gtk/SimpleFontDataGtk.cpp:
        (WebCore::SimpleFontData::containsCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@46258 268f45cc-cd09-0410-ab3c-d52691b4dbfc