leandro@webkit.org [Mon, 23 Aug 2010 17:58:06 +0000 (17:58 +0000)]
2010-08-23 Leandro Pereira <leandro@profusion.mobi>
[EFL] Build fix for platforms that do not require linking with "dl".
CMake includes the variable CMAKE_DL_LIBS that evaluates to the
platform-specific libraries.
* CMakeListsEfl.txt: Use ${CMAKE_DL_LIBS} instead of dl.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 23 Aug 2010 16:56:36 +0000 (16:56 +0000)]
2010-08-23 Daniel Bates <dbates@rim.com>
Rubber-stamped by Adam Roben.
Substitute "sizeof("javascript:") - 1" for the hardcoded constant 11 when
extracting the JavaScript code portion of a JavaScript URL so as to make
it clearer that the 11 represents the length of the scheme portion of
a JavaScript URL.
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performJavaScriptURLRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 23 Aug 2010 16:54:14 +0000 (16:54 +0000)]
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: Context menu in Scripts panel was broken.
https://bugs.webkit.org/show_bug.cgi?id=44431
* inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
(WebCore::FrontendMenuProvider::contextMenuCleared):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 16:37:01 +0000 (16:37 +0000)]
2010-08-23 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Remove obsolete public/API methods in chromium port
https://bugs.webkit.org/show_bug.cgi?id=44421
* public/WebSpeechInputController.h:
(WebKit::WebSpeechInputController::startRecognition):
(WebKit::WebSpeechInputController::cancelRecognition):
(WebKit::WebSpeechInputController::stopRecording):
* public/WebSpeechInputListener.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 23 Aug 2010 16:34:54 +0000 (16:34 +0000)]
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
https://bugs.webkit.org/show_bug.cgi?id=44432
Test: fast/dom/setAttributeNS-prefix-and-null-namespace.html
* dom/Element.cpp:
(WebCore::Element::setAttributeNS): Throw NAMESPACE_ERR if namespace is null
and the qualifiedName has a prefix.
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Tor Arne Vestbø.
setAttributeNS() should throw NAMESPACE_ERR for prefixed qualifiedName with null namespace
https://bugs.webkit.org/show_bug.cgi?id=44432
* fast/dom/script-tests/setAttributeNS-prefix-and-null-namespace.js: Added.
* fast/dom/setAttributeNS-prefix-and-null-namespace-expected.txt: Added.
* fast/dom/setAttributeNS-prefix-and-null-namespace.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 16:18:44 +0000 (16:18 +0000)]
2010-08-23 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] rendering was broken when missing plugin.
https://bugs.webkit.org/show_bug.cgi?id=43395
Implement RenderThemeEfl::systemFont to render "Missing plugin" when we
don't have proper plugin.
In this case, RenderEmbeddedObject::paintReplaced call systemFont and
pass returned font to GraphicsContext.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::setDefaultFontSize):
(WebCore::RenderThemeEfl::systemFont):
* platform/efl/RenderThemeEfl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 15:30:34 +0000 (15:30 +0000)]
2010-08-23 Hironori Bono <hbono@chromium.org>
Reviewed by Kent Tamura.
Removes the rebaselined results for special-key-events-in-input-text.html
because my test_shell change fixes it and produces the expected output.
https://bugs.webkit.org/show_bug.cgi?id=44156
* platform/chromium-mac/fast/events/special-key-events-in-input-text-expected.txt: Removed.
* platform/chromium-win/fast/events/special-key-events-in-input-text-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Mon, 23 Aug 2010 15:20:36 +0000 (15:20 +0000)]
2010-08-23 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
[GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
https://bugs.webkit.org/show_bug.cgi?id=42026
If a GTK+ 3.x build is present return that as the library to use,
otherwise fallback to the GTK+ 2.x build.
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 14:40:57 +0000 (14:40 +0000)]
2010-08-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=44327
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype.restoredBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpoint):
(WebInspector.BreakpointManager.prototype._removeBreakpoint):
(WebInspector.BreakpointManager.prototype._setBreakpointOnBackend):
(WebInspector.Breakpoint):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane):
(WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.BreakpointsSidebarPane.prototype._breakpointRemoved):
(WebInspector.JSBreakpointItem):
(WebInspector.JSBreakpointItem.prototype.compareTo):
(WebInspector.JSBreakpointItem.prototype.element):
(WebInspector.JSBreakpointItem.prototype._breakpointClicked):
(WebInspector.JSBreakpointItem.prototype._checkboxClicked):
(WebInspector.JSBreakpointItem.prototype._enableChanged):
(WebInspector.JSBreakpointItem.prototype._textChanged):
(WebInspector.JSBreakpointItem.prototype._removed):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype._addBreakpointToSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 23 Aug 2010 14:07:09 +0000 (14:07 +0000)]
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: inspector protocol should be switched from array based
message format to object based message format.
Almost all the protocol related things is generated by CodeGeneratorInspector.pm
It was changed a bit. As result InspectorBackendStub.js wraps the
calls into Request objects. InspectorBackendDispatcher.cpp unwraps
these objects and calls corresponding agents. These two files and
RemoteInspectorFrontend are generated by CodeGeneratorInspector.pm
Dispatching part of WebInspector also was adjusted for handling Event
objects produced by RemoteInspectorFrontend.cpp and Response objects
produced by InspectorBackendDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=44338
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setAttachedWindow):
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::find):
* inspector/front-end/Callback.js:
(WebInspector.Callback.prototype.processResponse):
* inspector/front-end/inspector.js:
(WebInspector.dispatch):
(WebInspector_syncDispatch):
(WebInspector.dispatchMessageFromBackend):
(WebInspector.reportProtocolError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 23 Aug 2010 13:58:51 +0000 (13:58 +0000)]
2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Find needed forwarding headers for WebKit2 automatically
https://bugs.webkit.org/show_bug.cgi?id=44336
* MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
The new script does not satisfy the needs of this file however using normal includes
is generally better here.
* MiniBrowser/qt/MiniBrowser.pro: Added include paths.
* Scripts/enumerate-included-framework-headers: Enumerates headers included from the
given frameworks by files in the current directory (and subdirectories).
In the future this needs to be rewritten in perl for being able to use on Windows.
2010-08-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Ariya Hidayat.
[Qt] Find needed forwarding headers for WebKit2 automatically
https://bugs.webkit.org/show_bug.cgi?id=44336
* DerivedSources.pro: Use the new enumerate-included-framework-headers script for generating
the list of forwarding headers we want to create.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Mon, 23 Aug 2010 13:23:05 +0000 (13:23 +0000)]
2010-08-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Remove IDBDatabase.description per spec changes
https://bugs.webkit.org/show_bug.cgi?id=44264
Update layout tests to match changes. One layout test is now
obsolete.
* storage/indexeddb/database-basics-expected.txt:
* storage/indexeddb/database-description-expected.txt: Removed.
* storage/indexeddb/database-description.html: Removed.
* storage/indexeddb/script-tests/database-basics.js:
(openSuccess):
* storage/indexeddb/script-tests/database-description.js: Removed.
2010-08-19 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Steve Block.
Remove IDBDatabase.description per spec changes
https://bugs.webkit.org/show_bug.cgi?id=44264
There's now no longer any way to access the description from JS.
The main premise of the manual test is now obsolete. Over time we'll
be able to add to it again. While I'm at it, I cleaned up the format
of the manual test to be easier to follow (code and usage wise).
* manual-tests/indexed-database.html:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::IDBDatabase):
* storage/IDBDatabase.h:
* storage/IDBDatabase.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 23 Aug 2010 12:49:37 +0000 (12:49 +0000)]
2010-08-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: element's css: pseudo-class locations
https://bugs.webkit.org/show_bug.cgi?id=44344
Also contains a drive-by fix for 44301 (gray out read-only).
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.update.computedStyleCallback):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
(WebInspector.StylePropertiesSection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 23 Aug 2010 12:34:50 +0000 (12:34 +0000)]
[Qt] Build fix.
* DerivedSources.pro:
* WebKit2.pro:
* WebProcess/Plugins/Netscape/qt: Added.
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Added.
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::toNP):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 23 Aug 2010 12:28:01 +0000 (12:28 +0000)]
2010-08-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65803.
http://trac.webkit.org/changeset/65803
https://bugs.webkit.org/show_bug.cgi?id=44416
windows build failed (Requested by loislo on #webkit).
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
* inspector/InspectorValues.h:
* inspector/front-end/Callback.js:
(WebInspector.Callback.prototype.processResponse):
* inspector/front-end/inspector.js:
(WebInspector.dispatch.delayDispatch):
(WebInspector.dispatch):
(WebInspector_syncDispatch):
(WebInspector.dispatchMessageFromBackend):
(WebInspector.reportProtocolError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 23 Aug 2010 12:14:15 +0000 (12:14 +0000)]
2010-08-23 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: inspector protocol should be switched from array based
message format to object based message format.
Almost all the protocol related things is generated by CodeGeneratorInspector.pm
It was changed a bit. As result InspectorBackendStub.js wraps the
calls into Request objects. InspectorBackendDispatcher.cpp unwraps
these objects and calls corresponding agents. These two files and
RemoteInspectorFrontend are generated by CodeGeneratorInspector.pm
Dispatching part of WebInspector also was adjusted for handling Event
objects produced by RemoteInspectorFrontend.cpp and Response objects
produced by InspectorBackendDispatcher.cpp
https://bugs.webkit.org/show_bug.cgi?id=44338
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setAttachedWindow):
* inspector/InspectorController.h:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::find):
* inspector/front-end/Callback.js:
(WebInspector.Callback.prototype.processResponse):
* inspector/front-end/inspector.js:
(WebInspector.dispatch):
(WebInspector_syncDispatch):
(WebInspector.dispatchMessageFromBackend):
(WebInspector.reportProtocolError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 23 Aug 2010 12:09:49 +0000 (12:09 +0000)]
2010-08-23 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
Make the copy of the inspector files silent.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 23 Aug 2010 11:44:41 +0000 (11:44 +0000)]
2010-08-23 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] -webkit-text-stroke is broken due to Qt::TextBypassShaping
https://bugs.webkit.org/show_bug.cgi?id=44403
Don't bypass the Harfbuzz shaping if we're drawing text with a stroke.
For canvas, always use complex text shaping since stroke and fill are decoupled.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::measureText):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* platform/graphics/qt/FontQt.cpp:
(WebCore::drawTextCommon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Mon, 23 Aug 2010 11:35:01 +0000 (11:35 +0000)]
2010-08-23 Roland Steiner <rolandsteiner@chromium.org>
Unreviewed change to drt_expectations.txt.
Add new entry to platform/chromium/drt_expectations.txt
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 09:49:29 +0000 (09:49 +0000)]
2010-08-23 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: add DOM breakpoints test
https://bugs.webkit.org/show_bug.cgi?id=44251
* http/tests/inspector/debugger-test2.js: Added.
(initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
(initialize_DebuggerTest.InspectorTest.startDebuggerTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest):
(initialize_DebuggerTest.InspectorTest.waitUntilPaused):
(initialize_DebuggerTest.InspectorTest.resumeExecution):
(initialize_DebuggerTest.InspectorTest.showScriptSource):
(initialize_DebuggerTest.InspectorTest._scriptsAreParsed):
(initialize_DebuggerTest.InspectorTest._showScriptSource):
(initialize_DebuggerTest):
* http/tests/inspector/inspector-test2.js:
(initialize_InspectorTest):
(initialize_InspectorTest.):
(runTest.runTestInFrontend):
(runTest):
* inspector/debugger-breakpoints-not-activated-on-reload.html:
* inspector/dom-breakpoints-expected.txt: Added.
* inspector/dom-breakpoints.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 23 Aug 2010 09:38:40 +0000 (09:38 +0000)]
2010-08-23 Philippe Normand <pnormand@igalia.com>
Unreviewed, skipping more media tests
[GStreamer] multiple <video> elements + PulseAudio are crash-prone
https://bugs.webkit.org/show_bug.cgi?id=44235
* platform/gtk/Skipped: Skip media/video-zoom-controls.html and media/adopt-node-crash.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Mon, 23 Aug 2010 09:35:21 +0000 (09:35 +0000)]
2010-08-23 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Extract profiler-related code and data from InspectorController into
InspectorProfilerAgent.
https://bugs.webkit.org/show_bug.cgi?id=44174
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
girish@forwardbias.in [Mon, 23 Aug 2010 08:10:30 +0000 (08:10 +0000)]
[Qt] Allow wmode=transparent in QWebView on Maemo5 after r65775.
https://bugs.webkit.org/show_bug.cgi?id=44043
Reviewed by Ariya Hidayat.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Mon, 23 Aug 2010 07:59:48 +0000 (07:59 +0000)]
[Qt] Crash when purging the scratch buffer for the shadow
https://bugs.webkit.org/show_bug.cgi?id=44384
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-23
Reviewed by Kenneth Rohde Christiansen.
WebCore::Timer can't be used in a static object bcause it relies on
thread global data, which is invalid once the application instance is
destroyed. To overcome the problem, use QObject's timer support for
the ShadowBuffer class.
* platform/graphics/qt/ContextShadow.cpp:
(WebCore::):
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::schedulePurge):
(WebCore::ShadowBuffer::timerEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 23 Aug 2010 06:27:49 +0000 (06:27 +0000)]
2010-08-22 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
* platform/chromium/drt_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 23 Aug 2010 06:11:47 +0000 (06:11 +0000)]
2010-08-23 Philippe Normand <pnormand@igalia.com>
Reviewed by Xan Lopez.
[GStreamer] don't expose the private player in GStreamerGWorld
https://bugs.webkit.org/show_bug.cgi?id=44332
Only a pointer to our playbin2 element instance is required
instead of the whole MediaPlayerPrivateGStreamer instance.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::createGWorld):
(WebCore::GStreamerGWorld::GStreamerGWorld):
(WebCore::GStreamerGWorld::~GStreamerGWorld):
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/GStreamerGWorld.h:
(WebCore::GStreamerGWorld::pipeline):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 23 Aug 2010 03:50:26 +0000 (03:50 +0000)]
2010-08-22 No'am Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
https://bugs.webkit.org/show_bug.cgi?id=43010
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::applyPrefs):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 23 Aug 2010 00:52:13 +0000 (00:52 +0000)]
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext: Simplify getting the clip bounding rect
https://bugs.webkit.org/show_bug.cgi?id=44396
Move the Qt 4.8 version check for QPainter::clipBoundingRect()
into a GraphicsContextPlatformPrivate method.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::clipBoundingRect):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 00:30:20 +0000 (00:30 +0000)]
2010-08-22 Rafael Antognolli <antognolli@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Remove duplicated include entry from default theme.
https://bugs.webkit.org/show_bug.cgi?id=44345
This used to create the group webkit/widget/entry twice in
the theme. It's leading to a bug with the newer versions of
EFL.
* DefaultTheme/default.edc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 23 Aug 2010 00:14:00 +0000 (00:14 +0000)]
2010-08-22 Marc Mutz <marc.mutz@kdab.com>
Reviewed by Antonio Gomes.
[Qt] Actually emit the QWebView::selectionChanged() signal
https://bugs.webkit.org/show_bug.cgi?id=44252
* Api/qwebview.cpp:
(QWebView::setPage): Connect QWebPage::selectionChanged() to QWebView::selectionChanged()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 22 Aug 2010 22:42:41 +0000 (22:42 +0000)]
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
* platform/PlatformTouchPoint.h:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-08-22 Juha Savolainen <juha.savolainen@weego.fi>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add QTouchEvents support for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44330
This patch adds support for QTouchEvents in WebKit2. A new WebEvent-class
is created for touchevents, WebTouchEvent. Also touchpoints needed a new
class, WebPlatformTouchPoint. This is similar solution like in other
events(like MouseEvent) on WebKit2. These classes are introduced in WebEvent.h
Also there was a need to create an empty constructor to PlatformTouchPoint-class.
* DerivedSources.pro:
* Shared/CoreIPCSupport/WebPageMessageKinds.h:
(WebPageMessage::):
* Shared/WebEvent.h:
(WebKit::WebEvent::):
(WebKit::WebTouchPoint::):
(WebKit::WebTouchPoint::WebTouchPoint):
(WebKit::WebTouchPoint::id):
(WebKit::WebTouchPoint::state):
(WebKit::WebTouchPoint::screenPosX):
(WebKit::WebTouchPoint::screenPosY):
(WebKit::WebTouchPoint::posX):
(WebKit::WebTouchPoint::posY):
(WebKit::WebTouchPoint::setState):
(WebKit::WebTouchPoint::encode):
(WebKit::WebTouchPoint::decode):
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::type):
(WebKit::WebTouchEvent::touchPoints):
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
(WebKit::WebTouchEvent::isTouchEventType):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
(WebKit::platform):
* Shared/WebEventConversion.h:
* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::webEventTypeForEvent):
(WebKit::WebEventFactory::createWebTouchEvent):
* Shared/qt/WebEventFactoryQt.h:
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::event):
(QGraphicsWKView::touchEvent):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::touchEvent):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::touchEvent):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::touchEvent):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sun, 22 Aug 2010 21:41:37 +0000 (21:41 +0000)]
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Chromium port to use DocumentMarkerController.
No functionality was changed, so no new tests.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::stopFinding):
(WebKit::WebFrameImpl::addMarker):
(WebKit::WebFrameImpl::setMarkerActive):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Windows port to use DocumentMarkerController.
No functionality was changed, so no new tests.
* WebFrame.cpp:
(WebFrame::unmarkAllMisspellings):
(WebFrame::unmarkAllBadGrammar):
* WebView.cpp:
(WebView::rectsForTextMatches):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Mac port to use DocumentMarkerController.
No functionality was changed, so no new tests.
* WebView/WebFrame.mm:
(-[WebFrame _unmarkAllBadGrammar]):
(-[WebFrame _unmarkAllMisspellings]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView unmarkAllTextMatches]):
(-[WebHTMLView rectsForTextMatches]):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the EFL port to use DocumentMarkerController.
No functionality was changed, so no new tests.
* ewk/ewk_frame.cpp:
(ewk_frame_text_matches_unmark_all):
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Moves the document marker management code in Document.cpp into its own
class called DocumentMarkerController.
No functionality was changed, so no new tests.
* Android.mk: Added DocumentMarkerController.cpp
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
* WebCore.exp.in: Substituted symbols __ZN7WebCore24DocumentMarkerController13removeMarkersENS_14DocumentMarker10MarkerTypeE
and __ZN7WebCore24DocumentMarkerController23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE for
__ZN7WebCore8Document13removeMarkersENS_14DocumentMarker10MarkerTypeE and
__ZN7WebCore8Document23renderedRectsForMarkersENS_14DocumentMarker10MarkerTypeE, respectively.
* WebCore.gypi: Added DocumentMarkerController.cpp and DocumentMarkerController.h.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/Document.cpp:
(WebCore::Document::removedLastRef): Modified to call DocumentMarkerController::detach().
(WebCore::Document::~Document): Removed "deleteAllValues(m_markers)" as DocumentMarkerController
is stored in OwnPtr; so it will be destroyed automatically on Document destruction.
(WebCore::Document::textInserted): Modified to use marker controller.
(WebCore::Document::textRemoved): Ditto.
* dom/Document.h:
(WebCore::Document::markers): Added.
* dom/DocumentMarkerController.cpp: Added.
(WebCore::placeholderRectForMarker):
(WebCore::DocumentMarkerController::detach):
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::removeMarkers):
(WebCore::DocumentMarkerController::copyMarkers):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersForNode):
(WebCore::DocumentMarkerController::renderedRectsForMarkers):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::setRenderedRectForMarker):
(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):
(WebCore::DocumentMarkerController::shiftMarkers):
(WebCore::DocumentMarkerController::setMarkersActive):
* dom/DocumentMarkerController.h: Added.
(WebCore::DocumentMarkerController::~DocumentMarkerController):
* editing/Editor.cpp:
(WebCore::Editor::ignoreSpelling): Modified to use marker controller.
(WebCore::findFirstMisspellingInRange): Ditto.
(WebCore::findFirstGrammarDetailInRange): Ditto.
(WebCore::Editor::advanceToNextMisspelling): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::changeBackToReplacedString): Ditto.
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply): Ditto.
(WebCore::SplitTextNodeCommand::doUnapply): Ditto.
* page/Frame.cpp:
(WebCore::Frame::markAllMatchesForText): Ditto.
(WebCore::Frame::setMarkedTextMatchesAreHighlighted): Ditto.
(WebCore::Frame::respondToChangedSelection): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::getTickmarks): Ditto.
(WebCore::FrameView::paintContents): Ditto.
* page/Page.cpp:
(WebCore::Page::unmarkAllTextMatches): Ditto.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::spellingToolTip): Ditto.
(WebCore::HitTestResult::replacedString): Ditto.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto.
(WebCore::InlineTextBox::paintTextMatchMarker): Ditto.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Ditto.
(WebCore::InlineTextBox::paintDocumentMarkers): Ditto.
* rendering/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::computeTextMatchMarkerRect): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sun, 22 Aug 2010 21:32:33 +0000 (21:32 +0000)]
Add the blob URL member to FormData.
https://bugs.webkit.org/show_bug.cgi?id=44387
Reviewed by Darin Fisher.
WebCore:
This is in preparation to switch blob implementation to using BlobData
model. When a blob is added to a FormData, it is represented as a blob
URL in the list.
* platform/network/FormData.cpp:
(WebCore::FormData::appendBlob):
* platform/network/FormData.h:
(WebCore::FormDataElement::FormDataElement):
(WebCore::FormDataElement::):
(WebCore::operator==):
WebKit/chromium:
As the result of adding the blob URL member to the FormData, we need
to update the corresponding WebKit API for chromium.
* public/WebHTTPBody.h:
(WebKit::WebHTTPBody::Element::):
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendBlob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 22 Aug 2010 18:38:38 +0000 (18:38 +0000)]
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
* html5lib/resources/adoption01.dat:
2010-08-22 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
HTML5 TreeBuilder builds wrong DOM for <a><svg><tr><input></a>
https://bugs.webkit.org/show_bug.cgi?id=44390
The HTML5 spec has changed since Adam and I original wrote
the HTMLTreeBuilder. Most important for this change was resolution of:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=9580
I also removed our "phrasing" tag support since that was also removed
from the spec as part of other bug fixes.
This is tested by tonyg's <a><svg><tr><input></a> test in adoption01.dat.
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::furthestBlockForFormattingElement):
(WebCore::HTMLTreeBuilder::processEndTag):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 22 Aug 2010 12:12:33 +0000 (12:12 +0000)]
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] TransparencyLayer: Always use anti-aliasing and smooth pixmap transform
https://bugs.webkit.org/show_bug.cgi?id=44394
* platform/graphics/qt/TransparencyLayer.h:
(WebCore::TransparencyLayer::TransparencyLayer): Set the Antialiasing
and SmoothPixmapTransforms render hints for all TransparencyLayers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sun, 22 Aug 2010 08:38:25 +0000 (08:38 +0000)]
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
* platform/graphics/qt/GradientQt.cpp:
(WebCore::Gradient::platformGradient): Reverse the (radial) gradient if r0 > r1.
2010-08-22 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392
Unskip two tests that now pass:
- canvas/philip/tests/2d.gradient.radial.outside2.html
- canvas/philip/tests/2d.gradient.radial.outside3.html
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Sun, 22 Aug 2010 07:30:48 +0000 (07:30 +0000)]
[Qt] Layer approach to support generic shadow handling
https://bugs.webkit.org/show_bug.cgi?id=44380
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-22
Reviewed by Dirk Schulze.
The pair beginShadowLayer and endShadowLayer creates a temporary image
where the caller can draw onto, using the returned QPainter. When
endShadowLayer is called, the temporary image will be filtered, using
the specified shadow color and blur radius, and drawn to the graphics
context.
* platform/graphics/GraphicsContext.h:
* platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::beginShadowLayer):
(WebCore::ContextShadow::endShadowLayer):
* platform/graphics/qt/ContextShadow.h:
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::contextShadow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 22 Aug 2010 03:01:50 +0000 (03:01 +0000)]
Check in missing files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 22 Aug 2010 01:58:28 +0000 (01:58 +0000)]
Remove specialized retain/release functions in favor of a single one for WKTypeRefs
https://bugs.webkit.org/show_bug.cgi?id=44386
Reviewed by Dan Bernstein.
WebKit2:
* UIProcess/API/C/WKArray.cpp:
(WKArrayGetSize):
* UIProcess/API/C/WKArray.h:
* UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListCopyForwardListWithLimit):
* UIProcess/API/C/WKBackForwardList.h:
* UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyTitle):
* UIProcess/API/C/WKBackForwardListItem.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKData.cpp:
(WKDataGetSize):
* UIProcess/API/C/WKData.h:
* UIProcess/API/C/WKDictionary.cpp:
(WKDictionaryCopyKeys):
* UIProcess/API/C/WKDictionary.h:
* UIProcess/API/C/WKError.h:
* UIProcess/API/C/WKFormSubmissionListener.cpp:
(WKFormSubmissionListenerContinue):
* UIProcess/API/C/WKFormSubmissionListener.h:
* UIProcess/API/C/WKFrame.cpp:
(WKFrameGetPage):
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerIgnore):
* UIProcess/API/C/WKFramePolicyListener.h:
* UIProcess/API/C/WKNavigationData.cpp:
(WKNavigationDataCopyURL):
* UIProcess/API/C/WKNavigationData.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageNamespace.cpp:
(WKPageNamespaceGetContext):
* UIProcess/API/C/WKPageNamespace.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesGetLocalStorageEnabled):
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/C/WKString.cpp:
* UIProcess/API/C/WKString.h:
* UIProcess/API/C/WKType.cpp:
(WKRetain):
(WKRelease):
* UIProcess/API/C/WKType.h:
* UIProcess/API/C/WKURL.cpp:
(WKURLGetTypeID):
* UIProcess/API/C/WKURL.h:
* UIProcess/API/cpp/WKRetainPtr.h:
* UIProcess/API/win/WKView.cpp:
* UIProcess/API/win/WKView.h:
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::shared):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleGetTypeID):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldNormalWorld):
* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h:
WebKitTools:
* MiniBrowser/mac/AppDelegate.m:
(didRecieveMessageFromInjectedBundle):
(didNavigateWithNavigationData):
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate applicationWillTerminate:]):
* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
(-[BrowserStatisticsWindowController dealloc]):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithPageNamespace:]):
(-[BrowserWindowController fetch:]):
(-[BrowserWindowController windowWillClose:]):
(-[BrowserWindowController applicationTerminating]):
(closePage):
(runJavaScriptAlert):
(runJavaScriptConfirm):
(runJavaScriptPrompt):
(-[BrowserWindowController updateProvisionalURLForFrame:]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::goToURL):
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::~PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 21 Aug 2010 18:40:01 +0000 (18:40 +0000)]
2010-08-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media engine should not be asked to open all urls
https://bugs.webkit.org/show_bug.cgi?id=44370
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load): Do nothing with urls with a type attribute that would be
rejected by canPlayType().
2010-08-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media engine should not be asked to open all urls
https://bugs.webkit.org/show_bug.cgi?id=44370
* media/video-source-none-supported-expected.txt:
* media/video-source-none-supported.html:
* media/video-source-type.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 21 Aug 2010 10:11:19 +0000 (10:11 +0000)]
2010-08-21 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] http/tests/incremental should be enabled
https://bugs.webkit.org/show_bug.cgi?id=44284
* platform/qt/Skipped: Enable http/tests/incremental, disabling only one failing test (#44282)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 21 Aug 2010 09:23:56 +0000 (09:23 +0000)]
2010-08-21 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] All sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/ tests can be re-enabled
https://bugs.webkit.org/show_bug.cgi?id=44192
Tested on several scenarios, including qt-4.7 and qt-4.6
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ariya@webkit.org [Sat, 21 Aug 2010 08:33:25 +0000 (08:33 +0000)]
[Qt] Faster bounding rect for the shadow clip region
https://bugs.webkit.org/show_bug.cgi?id=44369
Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-21
Reviewed by Kenneth Rohde Christiansen.
Like in r65650, we should use the faster QPainter::clipBoundingRect
when it is available.
* platform/graphics/qt/ContextShadow.cpp:
(WebCore::ContextShadow::drawShadowRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
girish@forwardbias.in [Sat, 21 Aug 2010 05:14:18 +0000 (05:14 +0000)]
[Qt] When using the raster graphics system on Maemo5, allow
Flash to render directly into the raster window surface.
wmode=transparent is now supported as a result of this change.
Reviewed by Ariya Hidayat.
https://bugs.webkit.org/show_bug.cgi?id=44043
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::paintUsingImageSurfaceExtension):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 21 Aug 2010 05:06:10 +0000 (05:06 +0000)]
2010-08-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources
* http/tests/misc/resources/script-500.php: Added.
* http/tests/misc/script-500-expected.txt: Added.
* http/tests/misc/script-500.html: Added.
2010-08-20 Alexey Proskuryakov <ap@apple.com>
Reviewed by Brady Eidson.
https://bugs.webkit.org/show_bug.cgi?id=38428
HTTP code 500 (and other non-4xx codes) wrongfully treated as success for subresources
Test: http/tests/misc/script-500.html
* loader/loader.cpp: (WebCore::Loader::Host::didReceiveData): Treat all HTTP codes >= 400 as
error ones, since they are.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Sat, 21 Aug 2010 03:39:12 +0000 (03:39 +0000)]
2010-08-20 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
WebKit does not build with Python 2.3
https://bugs.webkit.org/show_bug.cgi?id=44373
Replaced the function sorted() by a call to sort()
on the entry list.
The function sorted() has been added to Python 2.4.
The function method sort() of List works with older
versions of Python.
* Scripts/create-html-entity-table:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 21 Aug 2010 01:18:50 +0000 (01:18 +0000)]
2010-08-20 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] Enable some http/ tests which are passing for some time
https://bugs.webkit.org/show_bug.cgi?id=44366
These are reported as "passing, require confirmation on bot". Some of them
fail on my machines, so I'm enabling only the ones which pass.
* platform/qt/Skipped: enable several http tests
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 21 Aug 2010 01:01:56 +0000 (01:01 +0000)]
2010-08-20 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
Reviewed by Ariya Hidayat.
[Qt] constify core() and kit() parameters
https://bugs.webkit.org/show_bug.cgi?id=44347
* Api/qwebframe.cpp:
(QWebFrame::evaluateJavaScript):
* Api/qwebframe_p.h:
* Api/qwebhistory.cpp:
(QWebHistoryItemPrivate::core):
* Api/qwebhistory_p.h:
* Api/qwebpage.cpp:
(QWebPagePrivate::core):
* Api/qwebpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Sat, 21 Aug 2010 00:35:50 +0000 (00:35 +0000)]
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix for chromium (and remove duplicated ChangeLog entry).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Sat, 21 Aug 2010 00:25:43 +0000 (00:25 +0000)]
2010-08-20 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::Node::createRendererIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=44129
* html5lib/resources/adoption02.dat: A crazy DOM from https://bugs.webkig.org/show_bug.cgi?id=44170 which previously crashed. The expectation doesn't appear to be correct, but it behaves the same in Firefox 4, so I'm going to file a spec bug.
* fast/parser/remove-misnested-iframe-in-beforeload-expected.txt:
* fast/parser/remove-misnested-iframe-in-beforeload.html: Misnest a node in a table and remove it during its beforeload handler. The node should not be in the tree.
* fast/parser/remove-misnested-iframe-parent-in-beforeload-expected.txt:
* fast/parser/remove-misnested-iframe-parent-in-beforeload.html: Misnest a node in a table and remove its parent during its beforeload handler. The adoption agency should have already changed its parent to the one before the table and it and its parent should be removed.
2010-08-20 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Crash in WebCore::Node::createRendererIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=44129
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore): Factor out core bit to insertBetween.
(WebCore::ContainerNode::insertBetween): Factored out of insertBefore.
(WebCore::ContainerNode::parserInsertBefore): Similar to insertBefore, but doesn't handle reparenting or dispatch DOM mutation events.
(WebCore::ContainerNode::removeChild): Factor out core bit to removeBetween.
(WebCore::ContainerNode::removeBetween): Facotred out of removeChild.
(WebCore::ContainerNode::parserRemoveChild): Similar to removeChild, but doesn't handle reparenting or dispatch DOM mutation events.
(WebCore::ContainerNode::addChildCommon):
(WebCore::ContainerNode::parserAddChild):
(WebCore::ContainerNode::legacyParserAddChild):
* dom/ContainerNode.h:
* dom/Node.cpp:
(WebCore::Node::parserRemoveChild):
(WebCore::Node::parserInsertBefore):
* dom/Node.h:
* html/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach):
(WebCore::HTMLConstructionSite::attachAtSite): Use new parserInsertBefore.
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
(WebCore::HTMLTreeBuilder::reparentChildren):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Was missing a key bit from the spec about removing the old parent if it exists.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Sat, 21 Aug 2010 00:18:30 +0000 (00:18 +0000)]
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix. Had included wrong version of build file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Sat, 21 Aug 2010 00:13:06 +0000 (00:13 +0000)]
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Joseph Pecoraro.
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
* platform/gtk/Skipped: Unskip tests which are now passing.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Joseph Pecoraro.
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
* GNUmakefile.am: Fix dependency tracking for copied web inspector files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 21 Aug 2010 00:04:20 +0000 (00:04 +0000)]
2010-08-20 James Robinson <jamesr@chromium.org>
Synchronize default of use_accelerated_compositing gyp variable with downstream. Unreviewed.
* features.gypi:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Sat, 21 Aug 2010 00:02:08 +0000 (00:02 +0000)]
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add chromium-side callback implementation for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44350
Add WebFileSystemCallbacks that calls back the WebCore's implementation.
* WebKit.gyp:
* src/WebFileSystemCallbacksImpl.cpp: Added.
* src/WebFileSystemCallbacksImpl.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 20 Aug 2010 23:49:01 +0000 (23:49 +0000)]
2010-08-20 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add Callback implementation for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=44349
No new tests; tests will be added later.
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/FileSystemCallbacks.cpp: Added.
* storage/FileSystemCallbacks.h: Added.
* storage/EntryCallback.h: Nits fix
* storage/FileSystemCallback.h: Nits fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 20 Aug 2010 23:48:42 +0000 (23:48 +0000)]
2010-08-20 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r65757.
http://trac.webkit.org/changeset/65757
https://bugs.webkit.org/show_bug.cgi?id=44371
"fails on chromium windows and there is also a bug in the test
script." (Requested by rniwa on #webkit).
* editing/style/make-text-writing-direction-inline-expected.txt: Removed.
* editing/style/make-text-writing-direction-inline.html: Removed.
* editing/style/script-tests/make-text-writing-direction-inline.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 20 Aug 2010 23:23:25 +0000 (23:23 +0000)]
2010-08-20 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] WebKit does not compile with --3d-canvas
https://bugs.webkit.org/show_bug.cgi?id=44335
- PlatformGLObject => Platform3DObject
- Implemented getAttachedShaders()
- Implemented bufferData() and bufferSubData() for ArrayBuffer*
- Removed reference to nonexistent variable in getImageData()
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3D::attachShader):
(WebCore::GraphicsContext3D::getAttachedShaders):
(WebCore::GraphicsContext3D::bindAttribLocation):
(WebCore::GraphicsContext3D::bindBuffer):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::bindRenderbuffer):
(WebCore::GraphicsContext3D::bindTexture):
(WebCore::GraphicsContext3D::bufferData):
(WebCore::GraphicsContext3D::bufferSubData):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::detachShader):
(WebCore::GraphicsContext3D::framebufferRenderbuffer):
(WebCore::GraphicsContext3D::framebufferTexture2D):
(WebCore::GraphicsContext3D::getActiveAttrib):
(WebCore::GraphicsContext3D::getActiveUniform):
(WebCore::GraphicsContext3D::getAttribLocation):
(WebCore::GraphicsContext3D::isBuffer):
(WebCore::GraphicsContext3D::isFramebuffer):
(WebCore::GraphicsContext3D::isProgram):
(WebCore::GraphicsContext3D::isRenderbuffer):
(WebCore::GraphicsContext3D::isShader):
(WebCore::GraphicsContext3D::isTexture):
(WebCore::GraphicsContext3D::linkProgram):
(WebCore::GraphicsContext3D::shaderSource):
(WebCore::GraphicsContext3D::useProgram):
(WebCore::GraphicsContext3D::validateProgram):
(WebCore::GraphicsContext3D::getProgramiv):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderiv):
(WebCore::GraphicsContext3D::getShaderInfoLog):
(WebCore::GraphicsContext3D::getShaderSource):
(WebCore::GraphicsContext3D::getUniformfv):
(WebCore::GraphicsContext3D::getUniformiv):
(WebCore::GraphicsContext3D::getUniformLocation):
(WebCore::GraphicsContext3D::getImageData):
* platform/graphics/qt/GraphicsLayerQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 20 Aug 2010 23:03:17 +0000 (23:03 +0000)]
#ifdef-out some Leopard-and-earlier code.
Reviewed by Dave Kilzer.
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 20 Aug 2010 22:43:24 +0000 (22:43 +0000)]
2010-08-20 Kenneth Russell <kbr@google.com>
Unreviewed, speculative Chromium build fix. Forward declare
IntSize in WebGLRenderingContext.h and include IntSize.h in .cpp.
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 20 Aug 2010 22:19:39 +0000 (22:19 +0000)]
2010-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element canPlayType("application/octet-stream") not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=44343
Test: media/media-can-play-octet-stream.html
* platform/graphics/MediaPlayer.cpp:
(WebCore::applicationOctetStream): New, accessor for static string used more than once.
(WebCore::textPlain): Ditto.
(WebCore::codecs): Ditto.
(WebCore::chooseBestEngineForTypeAndCodecs): Special case "application/octet-stream".
(WebCore::MediaPlayer::load): Use static static string methods.
(WebCore::MediaPlayer::supportsType): Special case "application/octet-stream".
2010-08-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
Media element canPlayType("application/octet-stream") not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=44343
* media/media-can-play-octet-stream-expected.txt: Added.
* media/media-can-play-octet-stream.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 20 Aug 2010 22:14:37 +0000 (22:14 +0000)]
2010-08-20 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
There is no test for unicode-bidi / direction support in ApplyStyleCommand::applyInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=43989
Added a test for MakeTextWritingDirectionNatural, MakeTextWritingDirectionLeftToRight,
and MakeTextWritingDirectionRightToLeft commands.
* editing/style/make-text-writing-direction-inline.html: Added.
* editing/style/script-tests/make-text-writing-direction-inline.js: Added.
(modifyWritingDirection):
(selectFirstWord):
(selectSecondAndThirdWords):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Fri, 20 Aug 2010 22:12:01 +0000 (22:12 +0000)]
2010-08-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Implement HTMLVideoElement support for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=33852
Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::videoFrameToImage):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::bubbleToFront):
* html/canvas/WebGLRenderingContext.h:
2010-08-20 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
Implement HTMLVideoElement support for texImage2D and texSubImage2D
https://bugs.webkit.org/show_bug.cgi?id=33852
* fast/canvas/webgl/resources/quadrants.mp4: Added.
* fast/canvas/webgl/resources/quadrants.ogv: Added.
* fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
* fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 20 Aug 2010 21:54:16 +0000 (21:54 +0000)]
WebCore: Removing an incorrect ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=44151
Reviewed by Adam Barth.
A failure in the preflight step of a transaction wrapper does not
guarantee that the transaction is rolled back (and it shouldn't).
Test: storage/change-version-no-crash-on-preflight-failure.html
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::openTransactionAndPreflight):
LayoutTests: Check that a failure in the preflight step of a transaction wrapper does not trigger any assertion.
https://bugs.webkit.org/show_bug.cgi?id=44151
Reviewed by Adam Barth.
* storage/change-version-no-crash-on-preflight-failure-expected.txt: Added.
* storage/change-version-no-crash-on-preflight-failure.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 21:44:21 +0000 (21:44 +0000)]
2010-08-20 David Leong <david.leong@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Update Symbian capabilities to remove AllFiles and DRM
Add CONFIG(production) variation for set of DLL capabilities.
DRM and AllFiles capabilities need to be audited for the sis
package to be signed.
No new tests.
* WebCore.pro: Updated Symbian Capabilities.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Aug 2010 21:14:45 +0000 (21:14 +0000)]
2010-08-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Do Not Copy Subversion Related Files in Inspector Build Phase
https://bugs.webkit.org/show_bug.cgi?id=44353
* WebCore.xcodeproj/project.pbxproj: remove .svn directories in the "Copy Inspector Resources" build phase.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 20 Aug 2010 21:03:17 +0000 (21:03 +0000)]
2010-08-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/8245719> backface-visibility and reflections don't play nicely together.
On elements with a reflection and backface-visibility: hidden, set the doubleSided property on the
reflection flattening layer so that backface-visibility works in all configurations.
Test: compositing/reflections/backface-hidden-reflection.html
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::GraphicsLayerCA::updateBackfaceVisibility): Call setDoubleSided: on the structural
layer for reflections.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Fix a comment typo, and call updateBackfaceVisibility()
when we gain a structural layer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 20:37:58 +0000 (20:37 +0000)]
2010-08-20 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Implement cursor change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44263
Implemented PageClient::setCursor.
* UIProcess/API/qt/qgraphicswkview.cpp: Added updateCursor slot to be connected to the QWKPage::setCursor signal.
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::updateCursor): Sets the cursor of the widget.
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::setCursor): Added implementation for PageClient::setCursor. Emitting singal through the QWKPage.
* UIProcess/API/qt/qwkpage.h: Added setCursor signal.
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Fri, 20 Aug 2010 20:19:14 +0000 (20:19 +0000)]
2010-08-20 John Gregg <johnnyg@google.com>
Unreviewed, chromium rebaseline.
New test was added in r65746, it requires a new chromium-linux baseline.
* platform/chromium-linux/fast/repaint/multicol-repaint-expected.checksum: Added.
* platform/chromium-linux/fast/repaint/multicol-repaint-expected.png: Added.
* platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 20 Aug 2010 19:44:50 +0000 (19:44 +0000)]
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
style correction in markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=44318
Make markup.cpp pass check-webkit-style.
No new tests are added since this is a cleanup.
* editing/markup.cpp:
(WebCore::MarkupAccumulator::appendAttributeValue):
(WebCore::appendEscapedContent):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::completeURLs):
(WebCore::isElementPresentational):
(WebCore::isSpecialAncestorBlock):
(WebCore::shouldIncludeWrapperForFullySelectedRoot):
(WebCore::createMarkup):
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
(WebCore::createFragmentFromNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 20 Aug 2010 19:23:56 +0000 (19:23 +0000)]
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
crash when trying to access a stale Node pointer in FocusController::setFocusedNode
https://bugs.webkit.org/show_bug.cgi?id=44226
* fast/events/focus-change-crash2-expected.txt: Added.
* fast/events/focus-change-crash2.html: Added.
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
crash when trying to access a stale Node pointer in FocusController::setFocusedNode
https://bugs.webkit.org/show_bug.cgi?id=44226
Test: fast/events/focus-change-crash2.html
* page/FocusController.cpp:
(WebCore::FocusController::setFocusedNode): add a ref to prevent the focused node from being deleted
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 20 Aug 2010 19:02:38 +0000 (19:02 +0000)]
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix a null pointer crash when dispatching JS keyboard events
https://bugs.webkit.org/show_bug.cgi?id=44313
* fast/events/initkeyboardevent-crash-expected.txt: Added.
* fast/events/initkeyboardevent-crash.html: Added.
2010-08-20 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix a null pointer crash when dispatching JS keyboard events
https://bugs.webkit.org/show_bug.cgi?id=44313
* src/WebInputEventConversion.cpp:
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 20 Aug 2010 18:49:51 +0000 (18:49 +0000)]
2010-08-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Slider labels do not update as you move the sliders on this page
https://bugs.webkit.org/show_bug.cgi?id=41020
When repainting after layout in a multicol element, we need to adjust the
repaint rect for the columns.
Test: fast/repaint/multicol-repaint.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Fri, 20 Aug 2010 18:33:10 +0000 (18:33 +0000)]
Move FileStreamClient to platform and add AsyncFileStream interface.
https://bugs.webkit.org/show_bug.cgi?id=44224
Reviewed by David Levin.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/FileStreamProxy.cpp: Account for the change.
(WebCore::FileStreamProxy::FileStreamProxy):
(WebCore::FileStreamProxy::stop):
* html/FileStreamProxy.h: Make it derive from AsyncFileStream.h.
* platform/AsyncFileStream.h: Added.
* platform/FileStreamClient.h: Renamed from WebCore/html/FileStreamClient.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Fri, 20 Aug 2010 18:24:18 +0000 (18:24 +0000)]
2010-08-20 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.
* CMakeListsEfl.txt: Depend on Fontconfig, PNG, JPEG and dl
libraries.
2010-08-20 Leandro Pereira <leandro@profusion.mobi>
[EFL] Unreviewed. Fix build when using GNU gold.
When linking with GNU gold, some symbols are not found: explicitly
link with the required libraries.
* cmake/FindFontconfig.cmake: Added.
* cmake/OptionsEfl.cmake: Find Fontconfig, JPEG, and PNG libraries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jcivelli@chromium.org [Fri, 20 Aug 2010 18:12:01 +0000 (18:12 +0000)]
2010-08-20 Jay Civelli <jcivelli@chromium.org>
Reviewed by Darin Fisher.
Removing the deprecated class WebEvent and friends.
https://bugs.webkit.org/show_bug.cgi?id=44296
* WebKit.gyp:
* public/WebEvent.h: Removed.
* public/WebEventListener.h: Removed.
* public/WebMutationEvent.h: Removed.
* public/WebNode.h:
* src/EventListenerWrapper.cpp:
(WebKit::EventListenerWrapper::webDOMEventListenerDeleted):
* src/EventListenerWrapper.h:
* src/WebEvent.cpp: Removed.
* src/WebEventListener.cpp: Removed.
* src/WebEventListenerPrivate.cpp: Removed.
* src/WebEventListenerPrivate.h: Removed.
* src/WebNode.cpp:
(WebKit::WebNode::removeEventListener):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 20 Aug 2010 18:00:21 +0000 (18:00 +0000)]
2010-08-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Prevent use of stale notification presenter pointer in notifications by instead using
a notification center pointer and deriving the presenter from it. Notification presenter
gets properly destroyed using disconnectFrame function inside notification center. Add
null checks for notification presenter.
https://bugs.webkit.org/show_bug.cgi?id=43645
Test: fast/notifications/notifications-window-close-crash.html
* notifications/Notification.cpp:
(WebCore::Notification::Notification):
(WebCore::Notification::create):
(WebCore::Notification::show):
(WebCore::Notification::cancel):
(WebCore::Notification::contextDestroyed):
(WebCore::Notification::finishLoading):
* notifications/Notification.h:
(WebCore::Notification::detachPresenter):
* notifications/NotificationCenter.h:
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
2010-08-20 Abhishek Arya <inferno@chromium.org>
Reviewed by Darin Fisher.
Manual test to check that canceling the notification on a closed window does
not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=43645
* fast/notifications/notifications-window-close-crash-expected.txt: Added.
* fast/notifications/notifications-window-close-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Aug 2010 17:50:05 +0000 (17:50 +0000)]
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
r64526 broke the GTK+-3 build
https://bugs.webkit.org/show_bug.cgi?id=44254
No new tests, as this is covered by manual-tests/cursor.html.
* platform/gtk/CursorGtk.cpp:
(WebCore::createPixmapFromBits): Added this method which turns the inline data
structures into GdkPixmaps using Cairo and GDK-Cairo.
(WebCore::createNamedCursor): Modified this method to use the new helper.
* platform/gtk/CursorGtk.h: Changed all inline data structures to be unsigned
char arrays (which Cairo requires). The progress cursor is known in X11 icon themes
as "left_ptr_watch." This change to the name preserves the old behavior of taking this
icon from the theme when available. It seems that this worked in the past due to a fluke
or failure of the previous code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Fri, 20 Aug 2010 17:24:31 +0000 (17:24 +0000)]
2010-08-19 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Fix failing WebGL tests in Chromium in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44305
* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): Add implementation.
2010-08-19 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Fix failing WebGL tests in Chromium in-process-webgl port
https://bugs.webkit.org/show_bug.cgi?id=44305
* fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html: Add "#ifdef GLES" around precision keywords.
* fast/canvas/webgl/gl-bind-attrib-location-test-expected.txt: Re-enable the failing tests.
* fast/canvas/webgl/gl-bind-attrib-location-test.html: Add "#ifdef GLES" around precision keywords.
* fast/canvas/webgl/read-pixels-pack-alignment-expected.txt: Ditto.
* fast/canvas/webgl/read-pixels-pack-alignment.html: Ditto.
* fast/canvas/webgl/resources/fragmentShader.frag: Ditto.
* fast/canvas/webgl/texImage2DImageDataTest.html: Ditto.
* fast/canvas/webgl/texture-active-bind.html: Ditto.
* fast/canvas/webgl/texture-complete.html: Ditto.
* fast/canvas/webgl/texture-transparent-pixels-initialized.html: Ditto.
* platform/chromium/test_expectations.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Aug 2010 17:13:57 +0000 (17:13 +0000)]
2010-08-20 Martin Robinson <mrobinson@igalia.com>
[GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing
https://bugs.webkit.org/show_bug.cgi?id=44342
* platform/gtk/Skipped: Skip failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Fri, 20 Aug 2010 17:07:43 +0000 (17:07 +0000)]
2010-08-20 John Gregg <johnnyg@google.com>
Unreviewed, test expectations.
Add fail expectations for some SVG tests after r65729. See bug 44341.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Aug 2010 16:32:24 +0000 (16:32 +0000)]
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
* platform/gtk/Skipped: Unskip tests which should now be passing.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
Allow setting the inspector resources path via an environment variables
and add a method, inspectorFilesPath, to the WebKit InspectorClient that
encapsulates this logic.
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to
get the path to the resource.
(WebKit::InspectorClient::inspectorFilesPath): Added.
(WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method.
* WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result.
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Pavel Feldman.
Web Inspector: Inspector tests were disabled for GTK.
https://bugs.webkit.org/show_bug.cgi?id=43977
* Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
path before running tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Aug 2010 16:01:06 +0000 (16:01 +0000)]
2010-08-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Dirk Schulze.
[Cairo] Eliminate full-surface copy from canvas.drawImage(...)
https://bugs.webkit.org/show_bug.cgi?id=44190
Covered by canvas layout tests.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::drawsUsingCopy): Return false now.
(WebCore::ImageBuffer::clip): Add a link to the bug which tracks this feature.
(WebCore::ImageBuffer::draw): Construct the bitmap image without the full-surface copy.
(WebCore::ImageBuffer::drawPattern): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Fri, 20 Aug 2010 15:13:55 +0000 (15:13 +0000)]
2010-08-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[REGRESSION] r65608 broke gtk distcheck
https://bugs.webkit.org/show_bug.cgi?id=44333
Define the inspector.html as a noinst_DATA intead of using the dir
suffix, which is used for installation.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Fri, 20 Aug 2010 15:07:32 +0000 (15:07 +0000)]
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Part 2 of 2
Add unit tests that were not landed in the first commit.
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases:
"SVN: binary file (isBinary true) using Windows line endings"
"SVN: property diff, followed by file change diff using Windows line endings"
"SVN: two consecutive property diffs using Windows line endings"
"SVN: binary file with executable bit change usng Windows line endings"
"SVN: binary file followed by property change on different file using Windows line endings"
"SVN: binary file followed by file change on different file using Windows line endings"
"SVN: file change diff with property change, followed by property change diff using Windows line endings"
"SVN: file change diff with property change, followed by file change diff using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases:
"add svn:executable, followed by empty line and start of next diff using Windows line endings"
"add svn:executable, followed by empty line and start of next property diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
"add svn:executable, followed by empty line and start of binary patch using Windows line endings"
"multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
"multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
"single-line '+' with trailing new line using Windows line endings"
"single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
"single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
"multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases:
"single-line '-' change followed by empty line with Windows line endings"
"multi-line '+' change and start of binary patch with Windows line endings"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
demarchi@webkit.org [Fri, 20 Aug 2010 14:48:31 +0000 (14:48 +0000)]
2010-08-20 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Unreviewed build fix.
As opposed to WebCore, JavascriptCore and wtf, webkit is always a
shared library. After r65366, libewebkit.so was not being installed
anymore when building with SHARED_CORE=0 (which is the default). This
partially reverts that revision in order to fix this issue.
* CMakeLists.txt: always install webkit library.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 14:45:03 +0000 (14:45 +0000)]
2010-08-20 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
svn-apply doesn't detect empty line with Windows line endings
after property value
https://bugs.webkit.org/show_bug.cgi?id=43981
Fixes an issue where an empty line following the property value
in an SVN property change diff would not be detected if it had
Windows line endings (i.e. ended in CRLF). Hence it was consumed
as if it was part of a multi-line property value.
* Scripts/VCSUtils.pm:
- Modified parseSvnPropertyValue() to detect empty line
with Windows line endings.
- Added toWindowsLineEndings().
* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
- Added the following test cases:
"SVN: binary file (isBinary true) using Windows line endings"
"SVN: property diff, followed by file change diff using Windows line endings"
"SVN: two consecutive property diffs using Windows line endings"
"SVN: binary file with executable bit change usng Windows line endings"
"SVN: binary file followed by property change on different file using Windows line endings"
"SVN: binary file followed by file change on different file using Windows line endings"
"SVN: file change diff with property change, followed by property change diff using Windows line endings"
"SVN: file change diff with property change, followed by file change diff using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
- Added the following test cases:
"add svn:executable, followed by empty line and start of next diff using Windows line endings"
"add svn:executable, followed by empty line and start of next property diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
"multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
"add svn:executable, followed by empty line and start of binary patch using Windows line endings"
"multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
"multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
"single-line '+' with trailing new line using Windows line endings"
"single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
"single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
"multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
* Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
- Added the following test cases:
"single-line '-' change followed by empty line with Windows line endings"
"multi-line '+' change and start of binary patch with Windows line endings"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 20 Aug 2010 13:38:14 +0000 (13:38 +0000)]
2010-08-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement breaking on DOM node subtree mutations.
https://bugs.webkit.org/show_bug.cgi?id=42886
Add two entries to Web Inspector DOM element context menu:
1. "Stop on subtree modifications": will break on adding/removing of any element which is a child of the DOM element
2. "Remove breakpoints": will remove all breakpoints associated with the DOM element
* English.lproj/localizedStrings.js:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::breakProgramCallback):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::~InspectorDOMAgent):
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::hasBreakpoint):
(WebCore::InspectorDOMAgent::pauseOnBreakpoint):
(WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
* inspector/front-end/Settings.js:
2010-08-19 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: enable DOM breakpoints for chromium
https://bugs.webkit.org/show_bug.cgi?id=42886
* src/js/DevTools.js:
(WebInspector.loaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 20 Aug 2010 11:34:16 +0000 (11:34 +0000)]
2010-08-20 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: discard InjectedScript reference on ScriptState when clearing injected scripts
https://bugs.webkit.org/show_bug.cgi?id=44328
Otherwise if the reference is not cleared we may remove InjectedScript from the
map on InjectedScriptHost but keep it on ScriptState and try to reuse it later.
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::discardInjectedScript):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::discardInjectedScript):
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScript.h:
(WebCore::InjectedScript::scriptState):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::discardInjectedScripts):
* inspector/InjectedScriptHost.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 20 Aug 2010 09:13:49 +0000 (09:13 +0000)]
2010-08-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Clippers are rasterized, when applied to scaled target object
https://bugs.webkit.org/show_bug.cgi?id=44325
Use SVGImageBufferTools logic for RenderSVGResourceClipper, just like RenderSVGResourceMasker/Gradient,
to avoid pixelation, when the clipper is applied to a scaled target object, or when the document is scaled.
Test: svg/clip-path/clip-path-pixelation.svg
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
(WebCore::RenderSVGResourceClipper::createClipData):
* rendering/RenderSVGResourceClipper.h:
2010-08-20 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Clippers are rasterized, when applied to scaled target object
https://bugs.webkit.org/show_bug.cgi?id=44325
* platform/mac/svg/clip-path/clip-path-pixelation-expected.checksum: Added.
* platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Added.
* platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Added.
* svg/clip-path/clip-path-pixelation.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Fri, 20 Aug 2010 08:12:08 +0000 (08:12 +0000)]
2010-08-20 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Initialize GDK before loading plugins
https://bugs.webkit.org/show_bug.cgi?id=44324
Attempt to call gdk_init_check() before loading any plugins.
This prevents various crashes and freezes in Adobe's Flash plugin.
* plugins/qt/PluginPackageQt.cpp:
(WebCore::initializeGdkIfPossible):
(WebCore::PluginPackage::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 20 Aug 2010 07:58:04 +0000 (07:58 +0000)]
Follow-up to r41020.
Reviewed by Mark Rowe.
No change in behavior, thus no new tests.
* platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Asserted that the NSFont parameter is not nil,
and removed nil check.
(WebCore::FontPlatformData::setFont): Asserted that the NSFont parameter is not nil and that
this is not the deleted value, and removed code to handle those cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 04:51:40 +0000 (04:51 +0000)]
2010-08-19 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
[chromium] TilingData::tilePositionY has typo of X where Y should be used
https://bugs.webkit.org/show_bug.cgi?id=44195
Corrected error, and rewrote functions to use for loop instead of recursion.
Unit Tests added to WebKit/chromium/tests/TilingDataTest.cpp
* platform/graphics/chromium/TilingData.cpp:
(WebCore::TilingData::tilePositionX):
(WebCore::TilingData::tilePositionY):
2010-08-19 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
[chromium] TilingData::tilePositionY has typo of X where Y should be used
https://bugs.webkit.org/show_bug.cgi?id=44195
Unit tests added for tileSize and tilePosition.
* tests/TilingDataTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 20 Aug 2010 04:28:39 +0000 (04:28 +0000)]
2010-08-19 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Update for r65723.
* platform/chromium-win/fast/forms/listbox-selection-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 03:57:13 +0000 (03:57 +0000)]
2010-08-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
Assertion failure when going back inside frame during onload
https://bugs.webkit.org/show_bug.cgi?id=44217
Adds a test that does a history.back() within the main frame during
onload of a child frame. If HISTORY_ALWAYS_ASYNC was set to 0, this
would crash the DRT with an assertion failure, since we hadn't called
updateForFrameLoadCompleted in the main frame yet.
(renames history-back-within-subframe to history-back-within-subframe-hash
to differentiate between the two otherwise similar tests)
* fast/history/history-back-within-subframe-hash-expected.txt: Renamed from LayoutTests/fast/history/history-back-within-subframe-expected.txt.
* fast/history/history-back-within-subframe-hash.html: Renamed from LayoutTests/fast/history/history-back-within-subframe.html.
* fast/history/history-back-within-subframe-url-expected.txt: Added
* fast/history/history-back-within-subframe-url.html: Added.
* fast/history/resources/history-back-within-subframe-hash-2.html: Renamed from LayoutTests/fast/history/resources/history-back-within-subframe-2.html.
* fast/history/resources/history-back-within-subframe-url-2.html: Added.
* fast/history/resources/history-back-within-subframe-url-3.html: Added.
2010-08-19 Mihai Parparita <mihaip@chromium.org>
Reviewed by Brady Eidson.
Assertion failure when going back inside frame during onload
https://bugs.webkit.org/show_bug.cgi?id=44217
Fix assertion failure when doing a history.back() within the main frame
during onload of a child frame. This would happen when
HISTORY_ALWAYS_ASYNC was set to 0, because we would only compare the
current frame document sequence numbers when determining if we're in the
same document, instead of also recursing over child frames.
Test: fast/history/history-back-within-subframe-hash.html
* history/HistoryItem.cpp:
(WebCore::HistoryItem::hasSameDocuments):
* history/HistoryItem.h:
* loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleHistoryNavigation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 03:37:28 +0000 (03:37 +0000)]
2010-08-19 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Improve portability of fast/forms/listbox-selection.html
https://bugs.webkit.org/show_bug.cgi?id=35786
Changed to use script-tests style for improving portability.
- For sending mouse events to the target element, calculating the
item height at runtime instead using Mac-specific metrics.
- Using mouseDown(), mouseUp(), and keyDown() to send events with
modifier keys in a platform-independent way.
* fast/forms/listbox-selection-expected.txt: Updated to match with new test.
* fast/forms/listbox-selection.html: Modified to use script-tests style.
* fast/forms/script-tests/listbox-selection.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 20 Aug 2010 02:51:57 +0000 (02:51 +0000)]
2010-08-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Fix cursor change propagation
https://bugs.webkit.org/show_bug.cgi?id=44250
No functional change so new tests.
Propagate the setCursor callback to the PageClient via the HostWindow instead of preassuming
the concrete type of the ChromeClient (what was generally wrong and actually incompatible with WebKit2).
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::setCursor):
2010-08-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
[Qt] Fix cursor change propagation
https://bugs.webkit.org/show_bug.cgi?id=44250
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setCursor): Implemented. Propagete the callback forward to the PageClient.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 20 Aug 2010 01:22:32 +0000 (01:22 +0000)]
2010-08-19 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dumpAsMarkup conversion: editing/pasteboard/4242293-1.html and editing/pasteboard/copy-paste-bidi.html
https://bugs.webkit.org/show_bug.cgi?id=44220
Converted the tests.
* editing/pasteboard/4242293-1-expected.txt: Added.
* editing/pasteboard/4242293-1.html:
* editing/pasteboard/copy-paste-bidi-expected.txt: Added.
* editing/pasteboard/copy-paste-bidi.html:
* platform/chromium-linux/editing/pasteboard/4242293-1-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/4242293-1-expected.png: Removed.
* platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
* platform/chromium-linux/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4242293-1-expected.checksum: Removed.
* platform/chromium-win/editing/pasteboard/4242293-1-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/4242293-1-expected.txt: Removed.
* platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
* platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
* platform/mac-leopard/editing/pasteboard/4242293-1-expected.checksum: Removed.
* platform/mac-leopard/editing/pasteboard/4242293-1-expected.png: Removed.
* platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
* platform/mac-leopard/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
* platform/mac/editing/pasteboard/4242293-1-expected.checksum: Removed.
* platform/mac/editing/pasteboard/4242293-1-expected.png: Removed.
* platform/mac/editing/pasteboard/4242293-1-expected.txt: Removed.
* platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum: Removed.
* platform/mac/editing/pasteboard/copy-paste-bidi-expected.png: Removed.
* platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
* platform/qt/editing/pasteboard/4242293-1-expected.txt: Removed.
* platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 20 Aug 2010 01:05:21 +0000 (01:05 +0000)]
2010-08-19 Martin Robinson <mrobinson@igalia.com>
[GTK] r65681 broke a couple GTK+ a11y tests
https://bugs.webkit.org/show_bug.cgi?id=44316
* platform/gtk/Skipped: Skip some newly failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 20 Aug 2010 00:58:06 +0000 (00:58 +0000)]
2010-08-19 James Robinson <jamesr@chromium.org>
Unreviewed. Clean up test_expectations now that tables/hittesting/filltable-* pass on Chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 20 Aug 2010 00:47:31 +0000 (00:47 +0000)]
2010-08-19 Kinuko Yasuda <kinuko@chromium.org>
Reviewed by Darin Fisher.
Add WebKit API for FileSystem API
https://bugs.webkit.org/show_bug.cgi?id=43151
Add asynchronous FileSystem interface to WebKit API for
FileSystem API.
http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
* WebKit.gyp:
* public/WebFileError.h: Added.
* public/WebFileSystem.h: Added.
* public/WebFileSystemEntry.h: Added.
* public/WebFileSystemCallbacks.h: Added.
* public/WebKitClient.h:
(WebKit::WebKitClient::fileSystem):
* public/WebFrameClient.h:
(WebKit::WebFrameClient::openFileSystem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc