WebKit-https.git
7 years ago[chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.
tony@chromium.org [Fri, 21 Sep 2012 18:13:47 +0000 (18:13 +0000)]
[chromium] Unreviewed, remove duplicate section of WebKit.gyp pointed out by Nico.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGlobal Math object should be configurable but isn't
barraclough@apple.com [Fri, 21 Sep 2012 18:09:09 +0000 (18:09 +0000)]
Global Math object should be configurable but isn't
https://bugs.webkit.org/show_bug.cgi?id=55343

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This has no performance impact.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
    - Make 'Math' a regular property.

LayoutTests:

Added test case.

* fast/js/math-expected.txt:
* fast/js/script-tests/math.js:
    - Added test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 21 Sep 2012 17:43:35 +0000 (17:43 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebSocket] Receiving a large message is really slow
commit-queue@webkit.org [Fri, 21 Sep 2012 17:28:24 +0000 (17:28 +0000)]
[WebSocket] Receiving a large message is really slow
https://bugs.webkit.org/show_bug.cgi?id=97237

Patch by Evan Wallace <evan.exe@gmail.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

WebSocketChannel always reallocates its internal buffer when it receives
and appends new data which causes dramatic slowdowns for messages over
2 MB in size. This patch changes the internal buffer of WebSocketChannel
from a raw char array to a Vector<char> and uses its amortized append()
method. This brings the time to receive a 5 MB message from 5.2 seconds
to 0.25 seconds.

This patch is only for optimization. No new tests are needed.

* Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::resume):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::skipBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::processFrame):
* Modules/websockets/WebSocketChannel.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Implement ViewState methods in PageClientImpl in WebKit2
carlosgc@webkit.org [Fri, 21 Sep 2012 16:50:41 +0000 (16:50 +0000)]
[GTK] Implement ViewState methods in PageClientImpl in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=97202

Reviewed by Martin Robinson.

Source/WebKit2:

Implement isViewWindowActive(), isViewFocused(), isViewVisible()
and isViewInWindow() in PageClientImpl.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/C/gtk/WKView.cpp:
(WKViewSetFocus): New private method used by WTR to focus the
WebView.
* UIProcess/API/C/gtk/WKViewPrivate.h: Added.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isViewWindowActive): Return
webkitWebViewBaseIsInWindowActive().
(WebKit::PageClientImpl::isViewFocused): Return
webkitWebViewBaseIsFocused().
(WebKit::PageClientImpl::isViewVisible): Return
webkitWebViewBaseIsVisible().
(WebKit::PageClientImpl::isViewInWindow): Return
webkitWebViewBaseIsInWindow().
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseNotifyResizerSize): Updated to not receive the
window as parameter since it's now saved in the instance struct.
(toplevelWindowResizeGripVisibilityChanged): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(toplevelWindowFocusInEvent): Update ViewWindowIsActive flag and
notify the WebPageProxy if it changed.
(toplevelWindowFocusOutEvent): Ditto.
(webkitWebViewBaseSetToplevelOnScreenWindow): Set the toplevel
on-screen window where the view is currently added and notify
WebPageProxy if it changed.
(webkitWebViewBaseRealize): Call
webkitWebViewBaseSetToplevelOnScreenWindow() if the view has been
added to an on-screen window.
(webkitWebViewBaseFinalize): Reset the toplevel on-screen window
to make sure all signals are disconnected when the view is
destroyed.
(webkit_web_view_base_init): Remove unneeded initialization.
(resizeWebKitWebViewBaseFromAllocation): Update to
webkitWebViewBaseNotifyResizerSize() API change.
(webkitWebViewBaseMap): Update ViewIsVisible flag and notify
WebPageProxy if it changed.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseFocusInEvent): Call webkitWebViewBaseSetFocus()
passing true to focus the view.
(webkitWebViewBaseFocusOutEvent): Call webkitWebViewBaseSetFocus()
passing false to unfocus the view.
(webkitWebViewBaseParentSet): Reset the toplevel on-screen window
if the view is re-parented.
(webkit_web_view_base_class_init): Add implementations for map and
parent-set virtual functions.
(webkitWebViewBaseSetFocus): Update the ViewIsFocused and notify
WebPageProxy if it changed.
(webkitWebViewBaseIsInWindowActive):
(webkitWebViewBaseIsFocused):
(webkitWebViewBaseIsVisible):
(webkitWebViewBaseIsInWindow):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewMouseTarget): Use a GTK_WINDOW_TOPLEVEL instead of
POPUP for this test to make sure the view receives focus change
events.

Tools:

* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::focus): Focus the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build with ENABLE_WEBGL=false
commit-queue@webkit.org [Fri, 21 Sep 2012 16:41:53 +0000 (16:41 +0000)]
Fix build with ENABLE_WEBGL=false
https://bugs.webkit.org/show_bug.cgi?id=97309

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Eric Seidel.

WebKit no longer builds when WEBGL is not enabled.

* rendering/FilterEffectRenderer.h:
(FilterEffectRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Media player won't resize for the following source when first source...
commit-queue@webkit.org [Fri, 21 Sep 2012 16:32:03 +0000 (16:32 +0000)]
[BlackBerry] Media player won't resize for the following source when first source fail to load
https://bugs.webkit.org/show_bug.cgi?id=97342

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-09-21
Reviewed by Yong Li.

As platformPlayer will notify MediaPlayerPrivate for size change
when loading metadata failed (in this case hasVideo() is false),
we should prevent MediaPlayerPrivate to set width and height
attribute of media element, otherwise we won't get the correct
dimension for the following media sources.

Internally reviewed by Max Feil.

Test case: media/video-size.html

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION: 5 tests started to fail with newer Qt5
commit-queue@webkit.org [Fri, 21 Sep 2012 16:26:44 +0000 (16:26 +0000)]
[Qt] REGRESSION: 5 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=90687

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

When sending null data via POST method in  XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.

The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.

* platform/qt-5.0/Skipped:
* platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r126763): Incorrect line breaking when both kerning and word spacing...
mitz@apple.com [Fri, 21 Sep 2012 16:21:08 +0000 (16:21 +0000)]
REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled
https://bugs.webkit.org/show_bug.cgi?id=97280

Reviewed by Adele Peterson.

Source/WebCore:

Font::width() never applies word spacing to the first character in the TextRun. The
TextLayout optimization tried to achieve this behavior by not applying word spacing to
any character, which led to this bug.

Test: fast/text/word-space-with-kerning-2.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::TextLayout::TextLayout): Changed to use the given font rather than a version
without word spacing.
(WebCore::TextLayout::width): Added a check if the run starts with a space at a non-zero
offset. If that is the case, then the ComplexTextController has added word spacing to that
space, so subtract it here in order to maintain the behavior described above.

LayoutTests:

* fast/text/word-space-with-kerning-2-expected.html: Added.
* fast/text/word-space-with-kerning-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WTR] Memory leaks in InjectedBundleController::initialize()
commit-queue@webkit.org [Fri, 21 Sep 2012 16:14:01 +0000 (16:14 +0000)]
[WTR] Memory leaks in InjectedBundleController::initialize()
https://bugs.webkit.org/show_bug.cgi?id=97329

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21
Reviewed by Alexey Proskuryakov.

Fix leaks in InjectedBundleController::initialize() by adopting
strings created with WKStringCreateWithUTF8CString().

* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
commit-queue@webkit.org [Fri, 21 Sep 2012 16:11:41 +0000 (16:11 +0000)]
[Qt][WK2] Removed duplicated code from EventSenderProxy::keyDown
https://bugs.webkit.org/show_bug.cgi?id=97235

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::keyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip flaky tests to make the bots green
commit-queue@webkit.org [Fri, 21 Sep 2012 15:37:14 +0000 (15:37 +0000)]
[EFL] Skip flaky tests to make the bots green
https://bugs.webkit.org/show_bug.cgi?id=97340

Unreviewed EFL gardening. Skip flaky tests
in order to make the bots green.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd MIPS build slave to build.webkit.org
ossy@webkit.org [Fri, 21 Sep 2012 15:33:06 +0000 (15:33 +0000)]
Add MIPS build slave to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=96713

Patch by Gergely Kis <gergely@homejinni.com> on 2012-09-21
Reviewed by Csaba Osztrogonác.

Added a build slave for MIPS, and enabled a builder for
Qt Linux MIPS32R2 little-endian release build.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWrong seperator for viewport meta in Popup scripts
charles.wei@torchmobile.com.cn [Fri, 21 Sep 2012 14:59:49 +0000 (14:59 +0000)]
Wrong seperator for viewport meta in Popup scripts
https://bugs.webkit.org/show_bug.cgi?id=97313

Reviewed by Yong Li.

The valid seperator for viewport meta is ',' instead of ';'.

* WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::PagePopupBlackBerry::generateHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129219.
yurys@chromium.org [Fri, 21 Sep 2012 14:32:36 +0000 (14:32 +0000)]
Unreviewed, rolling out r129219.
http://trac.webkit.org/changeset/129219
https://bugs.webkit.org/show_bug.cgi?id=97338

Presumably broke Apple Mac compilation (Requested by yurys_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InspectorCanvasAgent.cpp:
* inspector/InspectorCanvasAgent.h:
* inspector/InspectorCanvasInstrumentation.h:
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Switch back to a fixed fifo path for Android
peter@chromium.org [Fri, 21 Sep 2012 14:25:23 +0000 (14:25 +0000)]
[Chromium] Switch back to a fixed fifo path for Android
https://bugs.webkit.org/show_bug.cgi?id=97230

Reviewed by Tony Chang.

Because not all external storage cards will be formated using a file
system that supports named pipes, Chromium has been changed to creating
the pipes in a temporary folder on the internal storage. Adapt this in
WebKit so we can continue to run layout tests.

This also includes an *unreviewed* fix for a breakage in the webkitpy
tests I made in r129221. Two lines and related to this code, so I decided
to include it in this change.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._update_version):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add test for ScrollingCoordinatorChromium
commit-queue@webkit.org [Fri, 21 Sep 2012 14:11:27 +0000 (14:11 +0000)]
[chromium] Add test for ScrollingCoordinatorChromium
https://bugs.webkit.org/show_bug.cgi?id=96657

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-09-21
Reviewed by James Robinson.

Add tests for ScrollingCoordinatorChromium. These tests mainly verify that
fast (non-main thread) scrolling is enabled when necessary and that a proper
compositing layer structure is created for fixed position and accelerated
scrolling layers.

Tests: ScrollingCoordinatorChromiumTest.fastScrollingByDefault
       ScrollingCoordinatorChromiumTest.fastScrollingForFixedPosition
       ScrollingCoordinatorChromiumTest.nonFastScrollableRegion
       ScrollingCoordinatorChromiumTest.wheelEventHandler
       ScrollingCoordinatorChromiumTest.touchOverflowScrolling

* WebKit.gypi:
* tests/ScrollingCoordinatorChromiumTest.cpp: Added.
(WebKit):
(MockWebViewClient):
(ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::ScrollingCoordinatorChromiumTest::createCompositedWebViewImpl):
(WebKit::ScrollingCoordinatorChromiumTest::registerMockedHttpURLLoad):
(WebKit::ScrollingCoordinatorChromiumTest::getRootScrollLayer):
(WebKit::TEST_F):
* tests/data/fixed_position.html: Added.
* tests/data/non_fast_scrollable.html: Added.
* tests/data/touch_overflow_scrolling.html: Added.
* tests/data/wheel_event_handler.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zherczeg@webkit.org [Fri, 21 Sep 2012 14:05:36 +0000 (14:05 +0000)]
[Qt] Unreviewed gardening.

Skip a test because layoutTestController.setBackingScaleFactor() is missing
on Qt. This test timeouts at the moment, which considerably increase the testing time.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
carlosgc@webkit.org [Fri, 21 Sep 2012 13:51:35 +0000 (13:51 +0000)]
[GTK] Add WebKitWebView:is-loading property to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=97330

Reviewed by Xan Lopez.

WebKitWebView:is-loading property allows to monitor when the view
is loading something without having to deal with load-changed
signal and all the details of the load status. This also allows to
know when a new load is started before it goes to STARTED status.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetProperty): Implement getter for is-loading
property.
(webkit_web_view_class_init): Add is-loading property.
(webkitWebViewSetIsLoading): Set whether web view is loading a
page and emit notify signal if the is-loading property has
changed. Also update the active URI when a new load operation has
started.
(webkitWebViewEmitLoadChanged): Set is-loading to FALSE when load
finishes.
(webkitWebViewLoadFailed): Set is-loading to FALSE when load fails.
(webkit_web_view_load_uri): Set is-loading to TRUE.
(webkit_web_view_load_html): Ditto.
(webkit_web_view_load_alternate_html): Ditto.
(webkit_web_view_load_plain_text): Ditto.
(webkit_web_view_load_request): Ditto.
(webkit_web_view_reload): Ditto.
(webkit_web_view_reload_bypass_cache): Ditto.
(webkit_web_view_is_loading): Return whether the view is loading a
page.
(webkit_web_view_go_back): Set is-loading to TRUE.
(webkit_web_view_go_forward): Ditto.
(webkit_web_view_go_to_back_forward_list_item): Ditto.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(loadChangedCallback):
(loadFailedCallback):
* UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebViewIsLoading):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove obsolete compositing surface code
anilsson@rim.com [Fri, 21 Sep 2012 13:38:28 +0000 (13:38 +0000)]
[BlackBerry] Remove obsolete compositing surface code
https://bugs.webkit.org/show_bug.cgi?id=97314

Reviewed by Antonio Gomes.

Source/WebKit:

Remove compositing surface code from build system.

PR 208038.

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

The removed code allowed rendering of sublayers to a separate offscreen
surface.

Now that we composite root layer and all sublayers to the window
surface, this code is not needed anymore. In addition, we save some
memory by not allocating the unused offscreen surface.

PR 208038.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::suspendScreenAndBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::suspendBackingStore):
(BlackBerry::WebKit::WebPagePrivate::resizeSurfaceIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerCompositingThread):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/BackingStoreCompositingSurface.cpp: Removed.
* WebKitSupport/BackingStoreCompositingSurface.h: Removed.
* WebKitSupport/GLES2Context.cpp:
(BlackBerry::WebKit::GLES2Context::buffer):
(BlackBerry::WebKit::GLES2Context::surfaceSize):
(BlackBerry::WebKit::GLES2Context::swapBuffers):
* WebKitSupport/GLES2Context.h:
(GLES2Context):
* WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
* WebKitSupport/SurfacePool.h:
(SurfacePool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLeverage Chromium's code to set up FIFOs for Chromium Android layout tests
peter@chromium.org [Fri, 21 Sep 2012 13:36:14 +0000 (13:36 +0000)]
Leverage Chromium's code to set up FIFOs for Chromium Android layout tests
https://bugs.webkit.org/show_bug.cgi?id=97227

Reviewed by Tony Chang.

Source/WebKit/chromium:

Remove all fifo-related code together with the io_stream_forwarder_android
target defined in WebKitUnitTests.gyp.

* WebKitUnitTests.gyp:
* tests/ForwardIOStreamsAndroid.cpp: Removed.
* tests/ForwardIOStreamsAndroid.h: Removed.
* tests/RunAllTests.cpp:
(main):

Tools:

We switched Chromium to using FIFOs in order to achieve better consistency,
which was done by Marcus in r157541. Remove all custom WebKit code in
favor of Chromium's implementation.

Remove more FIFO code in the test runner itself, including the code in
DumpRenderTree that invoked it. We can now switch to Chromium's brand
new FIFO-creating code, which is being set-up for all test targets build
for Android, including DumpRenderTree, TestWebKitAPI and webkit_unit_tests.

This also changes the ChromiumAndroidDriver._remove_all_pipes method to
delete the files individually. "rm" would fail if one of the earlier files
does not exist, and the "-f" argument doesn't seem to be reliable.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestShellAndroid.cpp:
(platformInit):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidDriver.__init__):
(ChromiumAndroidDriver._setup_test):
(ChromiumAndroidDriver._get_external_storage):
(ChromiumAndroidDriver._drt_cmd_line):
(ChromiumAndroidDriver._remove_all_pipes):
(ChromiumAndroidDriver.stop):
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
commit-queue@webkit.org [Fri, 21 Sep 2012 13:16:17 +0000 (13:16 +0000)]
[WK2][WKTR] EventSender needs to implement scheduleAsynchronousClick
https://bugs.webkit.org/show_bug.cgi?id=97326

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Implement scheduleAsynchronousClick() in WebKitTestRunner's
EventSender by sending a "MouseDown" and a "MouseUp" message
asynchronously to the WebProcess.

* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createMouseMessageBody):
(WTR):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::scheduleAsynchronousClick):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unskip fast/events/popup-blocking-click-in-iframe.html for
WebKit2 now that WKTR's EventSender implements
scheduleAsynchronousClick.

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/Skipped:
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++...
commit-queue@webkit.org [Fri, 21 Sep 2012 12:52:17 +0000 (12:52 +0000)]
Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code
https://bugs.webkit.org/show_bug.cgi?id=97203

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-21
Reviewed by Yury Semikhatsky.

Implements wrapping a 2D canvas context through the injected canvas module script facility.

* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::getContext):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::getContextCallback):
* inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::wrapCanvas2DContext):
(WebCore):
(WebCore::InjectedScriptCanvasModule::wrapWebGLContext):
(WebCore::InjectedScriptCanvasModule::callWrapContextFunction):
* inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
* inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
* inspector/InspectorCanvasInstrumentation.h:
(WebCore::InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [refactoring] simplify interface to FileOutputStream
caseq@chromium.org [Fri, 21 Sep 2012 12:49:13 +0000 (12:49 +0000)]
Web Inspector: [refactoring] simplify interface to FileOutputStream
https://bugs.webkit.org/show_bug.cgi?id=97226

Reviewed by Yury Semikhatsky.

Source/WebCore:

- change OutputStream interface to match that of stream;
- fix OutputStream implementations (FileOutputStream and those in heap profiler);
- fix usages in Timeline and HeapProfiler.

* inspector/front-end/FileUtils.js:
(WebInspector.OutputStream.prototype.write):
(WebInspector.OutputStream.prototype.close):
(WebInspector.ChunkedFileReader.prototype.start):
(WebInspector.ChunkedFileReader.prototype._onChunkLoaded):
(WebInspector.ChunkedXHRReader.prototype.start):
(WebInspector.ChunkedXHRReader.prototype._onProgress):
(WebInspector.ChunkedXHRReader.prototype._onLoad):
(WebInspector.FileOutputStream):
(WebInspector.FileOutputStream.prototype.open.callbackWrapper):
(WebInspector.FileOutputStream.prototype.open):
(WebInspector.FileOutputStream.prototype.write):
(WebInspector.FileOutputStream.prototype.close):
(WebInspector.FileOutputStream.prototype._onAppendDone):
* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.close):
(WebInspector.HeapSnapshotLoader.prototype.write):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotLoaderProxy.prototype.startTransfer):
(WebInspector.HeapSnapshotLoaderProxy.prototype.write):
(WebInspector.HeapSnapshotLoaderProxy.prototype.close):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapProfileHeader):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype.transferChunk.callback):
(WebInspector.HeapProfileHeader.prototype.transferChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.saveToFile.onOpen):
(WebInspector.HeapProfileHeader.prototype.saveToFile):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModel.prototype._createFileWriter):
(WebInspector.TimelineModel.prototype.saveToFile.callback):
(WebInspector.TimelineModel.prototype.saveToFile):
(WebInspector.TimelineModelLoader):
(WebInspector.TimelineModelLoader.prototype.write):
(WebInspector.TimelineModelLoader.prototype.close):
(WebInspector.TimelineSaver):
(WebInspector.TimelineSaver.prototype.save):
(WebInspector.TimelineSaver.prototype._writeNextChunk):

LayoutTests:

- adjust tests to new FileOutputStream interface;

* inspector/profiler/heap-snapshot-loader.html:
* inspector/timeline/timeline-load.html:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.StringOutputStream):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.write):
(initialize_Timeline.InspectorTest.StringOutputStream.prototype.close):
(initialize_Timeline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Error out early if we don't have ICU available
hausmann@webkit.org [Fri, 21 Sep 2012 12:49:02 +0000 (12:49 +0000)]
[Qt] Error out early if we don't have ICU available

Reviewed by Tor Arne Vestbø.

Source/WTF:

* WTF.pri:

Tools:

* qmake/mkspecs/features/configure.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Fri, 21 Sep 2012 12:16:30 +0000 (12:16 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-webkit-clip-path is applied on elements that are not descendant of the container
achicu@adobe.com [Fri, 21 Sep 2012 12:08:06 +0000 (12:08 +0000)]
-webkit-clip-path is applied on elements that are not descendant of the container
https://bugs.webkit.org/show_bug.cgi?id=97217

Reviewed by Dirk Schulze.

Source/WebCore:

The clip-path was set on the GraphicsContext, but was never restored, thus making all the layers
rendered in the same "group" of save/restore state use the same clip-path.

Test: css3/masking/clip-path-restore.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
clip-path property should create a stacking-context, otherwise the RenderLayers will not be nested,
meaning that the clip-path of the parent is not going to apply correctly.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

Added a test to check that the clip-path is removed from the GraphicsContext in the second paint call.
clip-path-circle-relative-overflow had incorrect result before, so I've udpated the results on Mac
and added test expectations for the others.

* css3/masking/clip-path-restore-expected.html: Added.
* css3/masking/clip-path-restore.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
* platform/qt/TestExpectations:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Bail out when trying to build WebKit with Qt != 5
hausmann@webkit.org [Fri, 21 Sep 2012 12:05:41 +0000 (12:05 +0000)]
[Qt] Bail out when trying to build WebKit with Qt != 5

Reviewed by Tor Arne Vestbø.

Moved check for Qt version out of default_pre into top-level WebKit.pro,
because we never reach default_pre.prf due to the lack of .qmake.conf support
in older versions of Qt/QMake.

.:

* WebKit.pro:

Tools:

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs to print frame load delegate information
commit-queue@webkit.org [Fri, 21 Sep 2012 12:00:20 +0000 (12:00 +0000)]
WebKitTestRunner needs to print frame load delegate information
https://bugs.webkit.org/show_bug.cgi?id=42705

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added missing dumping from WTR::InjectedBundlePage::didFailLoadWithErrorForFrame.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):

LayoutTests:

Unskipped corresponding test cases from wk2/Skipped, put those which still fail to an appropriate
group in wk2/Skipped.
Moved couple of http/tests/loading tests from platform/efl-wk1/TestExpectations to
platform/efl/TestExpectations as they actually fail for both WK1 EFL and WK2 EFL.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EventSender should mimic CTRL+o emacs shortcut
commit-queue@webkit.org [Fri, 21 Sep 2012 11:35:42 +0000 (11:35 +0000)]
[EFL] EventSender should mimic CTRL+o emacs shortcut
https://bugs.webkit.org/show_bug.cgi?id=97224

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl:

Fix bad use of temporary object causing wrong editing
callback dumping.

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldInsertText):

Tools:

Add support for mimicking CTRL+o emacs shortcut in EFL's
EventSender in DumpRenderTree and WebKitTestRunner.

* DumpRenderTree/efl/EventSender.cpp:
(sendKeyDown):
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Rebaseline editing/input/emacs-ctrl-o.html test now
that EFL's EventSender supports mimicking CTRL+o
emacs keyboard shortcut and unskip the test for
EFL WK2 now that the output matches the one for
EFL WK1.

* platform/efl-wk2/TestExpectations:
* platform/efl/editing/input/emacs-ctrl-o-expected.png:
* platform/efl/editing/input/emacs-ctrl-o-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of failing tests
commit-queue@webkit.org [Fri, 21 Sep 2012 10:31:38 +0000 (10:31 +0000)]
[EFL] Gardening of failing tests
https://bugs.webkit.org/show_bug.cgi?id=97317

Unreviewed EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-09-21

* platform/efl/TestExpectations:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.png:
* platform/efl/fast/text/atsui-rtl-override-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Re-fix clean builds
hausmann@webkit.org [Fri, 21 Sep 2012 10:23:26 +0000 (10:23 +0000)]
[Qt] Re-fix clean builds

Reviewed by Tor Arne Vestbø.

Re-introduce the sanitization for LIBS when creating a module to use
LIBS_PRIVATE and otherwise do _not_ use LIBS_PRIVATE. We decided to
continue to use QT, LIBS and PKGCONFIG instead of their _PRIVATE variants
throughout the code base, so just using LIBS_PRIVATE in linkAgainstLibrary()
causes build issues when depending system libraries end up in LIBS before
LIBS_PRIVATE.

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move frame flattening tests to WK1 specific TestExpectations
commit-queue@webkit.org [Fri, 21 Sep 2012 10:17:48 +0000 (10:17 +0000)]
[EFL] Move frame flattening tests to WK1 specific TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=97315

Unreviewed EFL gardening.

Generate baselines for frame flattening tests using WK2 since the tests
are passing with it, and move the tests to WebKit1-specific
TestExpectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-21

* platform/efl-wk1/TestExpectations:
* platform/efl/Skipped:
* platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-grid-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
* platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
* platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused functions of LocalizedDate.h
tkent@chromium.org [Fri, 21 Sep 2012 10:13:13 +0000 (10:13 +0000)]
Remove unused functions of LocalizedDate.h
https://bugs.webkit.org/show_bug.cgi?id=97311

Reviewed by Kentaro Hara.

WebCore::localizedTimeFormatText, WebCore::localizedShortTimeFormatText,
and WebCore::timeAMPMLabels are not used any more because we switched to
the corresponding functions of Localizer.

No new tests because of no behavior changes.

* platform/text/Localizer.h:
(Localizer): Moved comments from LocalizedDate.h.
* platform/text/LocalizedDate.h:
(WebCore): Removed localizedTimeFormatText,
localizedShortTimeFormatText, and timeAMPMLabels.
* platform/text/LocalizedDateICU.cpp:
(WebCore): ditto.
* platform/text/LocalizedDateWin.cpp:
(WebCore): ditto.
* platform/text/mac/LocalizedDateMac.cpp:
(WebCore): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd datalist suggestions into DateTimeChooserParameters
keishi@webkit.org [Fri, 21 Sep 2012 10:08:31 +0000 (10:08 +0000)]
Add datalist suggestions into DateTimeChooserParameters
https://bugs.webkit.org/show_bug.cgi?id=97292

Reviewed by Kent Tamura.

Source/WebCore:

We read datalist suggestions, add them to DateTimeChooserParameters,
and pass them to the page popup.

No new tests. No behavior change yet.

* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup): Read datalist suggestions and add them to DateTimeChooserParameters
* platform/DateTimeChooser.h:
(DateTimeChooserParameters): Added localizedSuggestionValues so we can show localized values inside the page popup.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Add the necessary parameters for SuggestionPicker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] DateTimeEditElement::layout() should take date time format as a parameter
yosin@chromium.org [Fri, 21 Sep 2012 10:06:10 +0000 (10:06 +0000)]
[Forms] DateTimeEditElement::layout() should take date time format as a parameter
https://bugs.webkit.org/show_bug.cgi?id=97300

Reviewed by Kent Tamura.

This patch introduces DateTimeEditElement::LayoutParameters struct for
passing four parameters to DateTimeEditElement::layout() for passing
date time format from client of DateTimeEditElement instead of
DateTimeEditElement::layout() takes time or short time format.

This patch is a part of preparation of introducing multiple fields
date/datetime/month/week input UI.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. This patch doesn't change behavior.

* html/TimeInputType.cpp:
(WebCore::TimeInputType::updateInnerTextValue): Changed to use LayoutParmeters.
* html/shadow/DateTimeEditElement.cpp:  Removed unused include files, LocalizedDate.h and LocalizedNumber.h.
(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Changed parameters to LayoutParmeters.
(WebCore::DateTimeEditElement::LayoutParameters::shouldHaveSecondField): Moved from DateTimeEditBuilder::needSecondField().
(WebCore::DateTimeEditElement::layout): Changed to take LayoutParameters.
(WebCore::DateTimeEditElement::setValueAsDate): ditto
(WebCore::DateTimeEditElement::setEmptyValue): ditto
* html/shadow/DateTimeEditElement.h: Removed unused classe declarations DateComponents and DateTimeEditLayouter.
(LayoutParameters):  Added to bundle parameters for layout().
(WebCore::DateTimeEditElement::LayoutParameters::LayoutParameters): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: render grid scale to the right / at bottom in case box is close to...
pfeldman@chromium.org [Fri, 21 Sep 2012 09:44:19 +0000 (09:44 +0000)]
Web Inspector: render grid scale to the right / at bottom in case box is close to 0 on that axis.
https://bugs.webkit.org/show_bug.cgi?id=97219

Reviewed by Vsevolod Vlasov.

Otherwise, it is hard to inspect objects close to (0, 0)

* inspector/InspectorOverlayPage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129086.
commit-queue@webkit.org [Fri, 21 Sep 2012 09:22:51 +0000 (09:22 +0000)]
Unreviewed, rolling out r129086.
http://trac.webkit.org/changeset/129086
https://bugs.webkit.org/show_bug.cgi?id=97312

Broke input rendering (Requested by shinyak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-21

* html/BaseButtonInputType.cpp:
(WebCore):
* html/BaseButtonInputType.h:
(WebCore::BaseButtonInputType::BaseButtonInputType):
(BaseButtonInputType):
* html/FileInputType.cpp:
(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
(WebCore::RenderButton::styleDidChange):
(WebCore::RenderButton::updateFromElement):
(WebCore):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::text):
* rendering/RenderButton.h:
(RenderButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove useless class prototypes from Vibration.h
commit-queue@webkit.org [Fri, 21 Sep 2012 09:16:38 +0000 (09:16 +0000)]
Remove useless class prototypes from Vibration.h
https://bugs.webkit.org/show_bug.cgi?id=97304

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-21
Reviewed by Kentaro Hara.

Remove two useless class prototype statements in the Vibration.h

* Modules/vibration/Vibration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Changed fast/text/international/hebrew-selection.html expectation
yurys@chromium.org [Fri, 21 Sep 2012 08:01:54 +0000 (08:01 +0000)]
Unreviewed. Changed fast/text/international/hebrew-selection.html expectation
from Failure to ImageOnlyFailure to match the actual results.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd MIPS or32 function
commit-queue@webkit.org [Fri, 21 Sep 2012 07:58:03 +0000 (07:58 +0000)]
Add MIPS or32 function
https://bugs.webkit.org/show_bug.cgi?id=97157

Patch by Chao-ying Fu <fu@mips.com> on 2012-09-21
Reviewed by Gavin Barraclough.

Add a missing or32 function.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::or32): New function.
(MacroAssemblerMIPS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark accessibility/loading-iframe-updates-axtree.html as crashing
yurys@chromium.org [Fri, 21 Sep 2012 07:45:10 +0000 (07:45 +0000)]
Unreviewed. Mark accessibility/loading-iframe-updates-axtree.html as crashing
intermittently on Linux in addition to Win and Mac.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 21 Sep 2012 07:31:46 +0000 (07:31 +0000)]
Unreviewed GTK gardening.

Rebaselining MathML tests after r129146.

* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/attributes-expected.txt:
* platform/gtk/mathml/presentation/fenced-expected.png:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/fenced-mi-expected.png:
* platform/gtk/mathml/presentation/fenced-mi-expected.txt:
* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.png:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.txt:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/roots-expected.txt:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.png:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.png:
* platform/gtk/mathml/presentation/style-expected.txt:
* platform/gtk/mathml/presentation/sub-expected.txt:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/sup-expected.png:
* platform/gtk/mathml/presentation/sup-expected.txt:
* platform/gtk/mathml/presentation/tokenElements-expected.png:
* platform/gtk/mathml/presentation/tokenElements-expected.txt:
* platform/gtk/mathml/presentation/under-expected.txt:
* platform/gtk/mathml/presentation/underover-expected.png:
* platform/gtk/mathml/presentation/underover-expected.txt:
* platform/gtk/mathml/xHeight-expected.png:
* platform/gtk/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrepare CalendarPicker so we can add another picker, SuggetionPicker
keishi@webkit.org [Fri, 21 Sep 2012 07:02:20 +0000 (07:02 +0000)]
Prepare CalendarPicker so we can add another picker, SuggetionPicker
https://bugs.webkit.org/show_bug.cgi?id=97193

Reviewed by Kent Tamura.

Preparation so we can add another picker to CalendarPicker and switch
between them.

No new tests. No behavior change.

* Resources/pagepopups/calendarPicker.css:
(.calendar-picker): Added so we can apply these styles just to calendar picker.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.validateConfig): Renamed so each picker can validate the config object.
(initialize):
(closePicker): Call Picker.cleanup().
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype.cleanup): Cleanup event listener on document.body.
* Resources/pagepopups/pickerCommon.js:
(Picker.prototype.cleanup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectation update.
bashi@chromium.org [Fri, 21 Sep 2012 06:32:40 +0000 (06:32 +0000)]
[Chromium] Unreviewed test expectation update.

* platform/chromium/TestExpectations: Assigned new bug entry for
fast/text/international/hebrew-selection.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add API to feed touch event.
commit-queue@webkit.org [Fri, 21 Sep 2012 06:23:33 +0000 (06:23 +0000)]
[EFL][WK2] Add API to feed touch event.
https://bugs.webkit.org/show_bug.cgi?id=96903

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2012-09-20
Reviewed by Kenneth Rohde Christiansen.

The applications will use this API to feed touch event to the view
when they want to generate touch event from their own event processor.
WTR also will use this API to generate touch event with multiple touch
points for passing test cases of touch event in the WebKit2/EFL.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_feed_touch_event):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Cluster text at flow roots, for consistency and to avoid autosizing...
commit-queue@webkit.org [Fri, 21 Sep 2012 06:20:57 +0000 (06:20 +0000)]
Text Autosizing: Cluster text at flow roots, for consistency and to avoid autosizing headers/footers.
https://bugs.webkit.org/show_bug.cgi?id=97025

Patch by John Mellor <johnme@chromium.org> on 2012-09-20
Reviewed by Julien Chaffraix.

Source/WebCore:

This patch has 3 main changes:

1. All text within a "cluster" (roughly equivalent to a CSS flow root /
   block formatting context) must have a uniform textAutosizingMultiplier,
   except for subtrees which are themselves clusters. This improves the
   consistency of the final output, since sibling blocks are now more
   likely to have the same multiplier (hence grow in proportion).

2. Clusters must contain a minimum amount of text in order to be
   autosized (4 lines of text, assuming each char is 1em wide, so about
   2 lines of text in practice). This is to reduce the likelihood of
   autosizing things like headers and footers, which can be quite
   visually distracting. The rationale is that if a cluster contains
   very few lines of text then it's ok to have to zoom in and pan from
   side to side to read each line, since if there are very few lines of
   text you'll only need to pan across once or twice.

3. To avoid adding a 3rd tree traversal, processSubtree/processBox were
   refactored such that all of Text Autosizing now happens as a single
   tree traversal (hence halving the number of tree traversals done).

Tests: fast/text-autosizing/cluster-narrow-in-wide.html
       fast/text-autosizing/cluster-wide-in-narrow.html
       fast/text-autosizing/clusters-insufficient-text.html
       fast/text-autosizing/clusters-insufficient-width.html
       fast/text-autosizing/clusters-sufficient-text-except-in-root.html
       fast/text-autosizing/clusters-sufficient-width.html

* rendering/TextAutosizer.cpp:
(TextAutosizingWindowInfo):

    Added this struct to bundle together the various sizes that
    processSubtree needs to pass to every recursive call to
    processCluster and processContainer.

(WebCore::TextAutosizer::processSubtree):

    - Bundle windowSize and minLayoutSize together as a single struct,
      TextAutosizingWindowInfo, rather than passing them separately.
    - Walk up the tree to find the current cluster and container, rather
      than (incorrectly) assuming that the layoutRoot is always a
      container.
    - Call processCluster instead of traversing the tree.

(WebCore::TextAutosizer::processCluster):

    Calculates the multiplier based on the width of the cluster (moved
    the calculation here from processBox, since now the multiplier is
    fixed per cluster), and delegates to processContainer for the actual
    tree traversal (since clusters are also containers).

(WebCore::contentHeightIsConstrained):

    Changed parameter to RenderBlock.

(WebCore::TextAutosizer::processContainer):

    This now takes care of the whole tree traversal, recursively calling
    processCluster/processContainer when it encounters such an object,
    and setMultiplier on RenderText objects (as processBox used to).
    Also added a check that the RenderText's multiplier is not already
    equal to the target multiplier (to save needlessly setting it).

(WebCore::TextAutosizer::isContainer):

    - Changed to be a positive (is) instead of negative (isNot) check.
    - Require objects to be RenderBlocks so it's easier to find them
      using containingBlock, and there don't seem to be many interesting
      RenderBoxes that aren't RenderBlocks.

(WebCore::TextAutosizer::isAutosizingCluster):

    A container that is also a flow root / block formatting context
    (approximately), hence demarcates an independent region of the page,
    within which we want consistent autosizing.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

    Uses measureDescendantTextWidth and to check whether the cluster
    contains enough text to be worth autosizing.

(WebCore::TextAutosizer::measureDescendantTextWidth):

    Recursively traverse the cluster, skipping constrained height
    containers as processContainer does, to measure how much autosizable
    text it contains. Early out as soon as the minimum text width is
    reached.

(WebCore::TextAutosizer::nextInPreOrderSkippingDescendantsOfContainers):

    Replaces nextInPreOrderMatchingFilter. The filter is now fixed to
    isContainer (we no longer need an isAutosizingCluster filter, since
    I consolidated the tree traversal), and filtered objects are
    actually returned (so they can in turn be recursively traversed),
    it's just their descendants that get skipped.

* rendering/TextAutosizer.h:
(TextAutosizer):

    - Deleted RenderObjectFilterFunctor, since the filter of
      nextInPreOrderSkippingDescendantsOfContainers is now fixed.

LayoutTests:

Added 6 tests (cluster*.html). Updated various other tests to have
enough text so that they continue to pass, or that if they fail, it's
for the reason that was being tested, not just because clustering
decided they had insufficient text.

* fast/text-autosizing/cluster-narrow-in-wide-expected.html: Added.
* fast/text-autosizing/cluster-narrow-in-wide.html: Copied from LayoutTests/fast/text-autosizing/em-margin-border-padding.html.
* fast/text-autosizing/cluster-wide-in-narrow-expected.html: Added.
* fast/text-autosizing/cluster-wide-in-narrow.html: Added.
* fast/text-autosizing/clusters-insufficient-text-expected.html: Added.
* fast/text-autosizing/clusters-insufficient-text.html: Added.
* fast/text-autosizing/clusters-insufficient-width-expected.html: Added.
* fast/text-autosizing/clusters-insufficient-width.html: Added.
* fast/text-autosizing/clusters-sufficient-text-except-in-root-expected.html: Added.
* fast/text-autosizing/clusters-sufficient-text-except-in-root.html: Added.
* fast/text-autosizing/clusters-sufficient-width-expected.html: Added.
* fast/text-autosizing/clusters-sufficient-width.html: Added.
* fast/text-autosizing/constrained-and-overflow-auto-ancestor-expected.html:
* fast/text-autosizing/constrained-and-overflow-auto-ancestor.html:
* fast/text-autosizing/constrained-and-overflow-hidden-ancestor-expected.html:
* fast/text-autosizing/constrained-and-overflow-hidden-ancestor.html:
* fast/text-autosizing/constrained-and-overflow-paged-x-ancestor-expected.html:
* fast/text-autosizing/constrained-and-overflow-paged-x-ancestor.html:
* fast/text-autosizing/constrained-and-overflow-scroll-ancestor-expected.html:
* fast/text-autosizing/constrained-and-overflow-scroll-ancestor.html:
* fast/text-autosizing/constrained-height-ancestor-expected.html:
* fast/text-autosizing/constrained-height-ancestor.html:
* fast/text-autosizing/constrained-maxheight-ancestor-expected.html:
* fast/text-autosizing/constrained-maxheight-ancestor.html:
* fast/text-autosizing/constrained-maxheight-expected.html:
* fast/text-autosizing/constrained-maxheight.html:
* fast/text-autosizing/constrained-percent-maxheight-expected.html:
* fast/text-autosizing/constrained-percent-maxheight.html:
* fast/text-autosizing/constrained-percent-of-viewport-maxheight-expected.html:
* fast/text-autosizing/constrained-percent-of-viewport-maxheight.html:
* fast/text-autosizing/constrained-then-overflow-ancestors-expected.html:
* fast/text-autosizing/constrained-then-overflow-ancestors.html:
* fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors-expected.html:
* fast/text-autosizing/constrained-then-overflow-then-positioned-ancestors.html:
* fast/text-autosizing/constrained-then-position-absolute-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-absolute-ancestors.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
* fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
* fast/text-autosizing/constrained-within-overflow-ancestor-expected.html:
* fast/text-autosizing/constrained-within-overflow-ancestor.html:
* fast/text-autosizing/em-margin-border-padding-expected.html:
* fast/text-autosizing/em-margin-border-padding.html:
* fast/text-autosizing/narrow-child-expected.html:
* fast/text-autosizing/narrow-child.html:
* fast/text-autosizing/wide-child-expected.html:
* fast/text-autosizing/wide-child.html:
* fast/text-autosizing/wide-iframe-expected.html:
* fast/text-autosizing/wide-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark fast/text/international/hebrew-selection.html as failing
yurys@chromium.org [Fri, 21 Sep 2012 06:16:05 +0000 (06:16 +0000)]
Unreviewed. Mark fast/text/international/hebrew-selection.html as failing
on Windows in addition to Linux. The test was introduced in r129175 and
marked as failing on Linux from the very beginning.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Several MathML tests need rebaseline after r129146
commit-queue@webkit.org [Fri, 21 Sep 2012 06:14:27 +0000 (06:14 +0000)]
[EFL] Several MathML tests need rebaseline after r129146
https://bugs.webkit.org/show_bug.cgi?id=97293

Unreviewed EFL gardening.

Rebaseline several MathML tests due to r129146.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-20

* platform/efl/mathml/presentation/attributes-expected.png:
* platform/efl/mathml/presentation/attributes-expected.txt:
* platform/efl/mathml/presentation/fenced-expected.png:
* platform/efl/mathml/presentation/fenced-expected.txt:
* platform/efl/mathml/presentation/fenced-mi-expected.png:
* platform/efl/mathml/presentation/fenced-mi-expected.txt:
* platform/efl/mathml/presentation/fractions-expected.png:
* platform/efl/mathml/presentation/fractions-expected.txt:
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/efl/mathml/presentation/mo-stretch-expected.png:
* platform/efl/mathml/presentation/mo-stretch-expected.txt:
* platform/efl/mathml/presentation/mroot-pref-width-expected.png:
* platform/efl/mathml/presentation/mroot-pref-width-expected.txt:
* platform/efl/mathml/presentation/roots-expected.png:
* platform/efl/mathml/presentation/roots-expected.txt:
* platform/efl/mathml/presentation/row-alignment-expected.png:
* platform/efl/mathml/presentation/row-alignment-expected.txt:
* platform/efl/mathml/presentation/style-expected.png:
* platform/efl/mathml/presentation/style-expected.txt:
* platform/efl/mathml/presentation/sub-expected.png:
* platform/efl/mathml/presentation/sub-expected.txt:
* platform/efl/mathml/presentation/subsup-expected.png:
* platform/efl/mathml/presentation/subsup-expected.txt:
* platform/efl/mathml/presentation/sup-expected.png:
* platform/efl/mathml/presentation/sup-expected.txt:
* platform/efl/mathml/presentation/tokenElements-expected.png:
* platform/efl/mathml/presentation/tokenElements-expected.txt:
* platform/efl/mathml/presentation/under-expected.png:
* platform/efl/mathml/presentation/under-expected.txt:
* platform/efl/mathml/presentation/underover-expected.png:
* platform/efl/mathml/presentation/underover-expected.txt:
* platform/efl/mathml/xHeight-expected.png:
* platform/efl/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Provided Chromium-specific test expectations after r129176.
yurys@chromium.org [Fri, 21 Sep 2012 06:02:55 +0000 (06:02 +0000)]
Unreviewed. Provided Chromium-specific test expectations after r129176.

* platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
* platform/chromium-mac/fast/text/emphasis-expected.png:
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] There are memory leak in LocaleICU
yosin@chromium.org [Fri, 21 Sep 2012 04:44:21 +0000 (04:44 +0000)]
[Platform] There are memory leak in LocaleICU
https://bugs.webkit.org/show_bug.cgi?id=97289

Reviewed by Kent Tamura.

This patch adds udt_close() calls for medium time format and short
time format data used in LocaleICU class to avoid memory leak.

This memory leak is found by external tool Valgrind and reported in
Chromium bug repositry(http://crbug.com/151006) with stack trace of
call path of leaked memory.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. External tool such as Valgrind will check this memory leak.

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::~LocaleICU): Added to call udt_close() for m_mediumTimeFormat
and m_shortTimeFormat which have UDateFormat objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium mac cannot display AppleColorEmoji
bashi@chromium.org [Fri, 21 Sep 2012 04:42:44 +0000 (04:42 +0000)]
Chromium mac cannot display AppleColorEmoji
https://bugs.webkit.org/show_bug.cgi?id=97286

Reviewed by Kent Tamura.

Disable AppleColorEmoji for now. We will re-enable it after Skia supports CTFontDrawGlyphs().

No new tests. Fallback fonts should be used for emoji codepoints.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Fix use-after free when using a variable to specify a -webkit-filter.
macpherson@chromium.org [Fri, 21 Sep 2012 04:15:18 +0000 (04:15 +0000)]
Source/WebCore: Fix use-after free when using a variable to specify a -webkit-filter.
https://bugs.webkit.org/show_bug.cgi?id=97153

Reviewed by Abhishek Arya.

Make StyleResolver's m_pendingSVGDocuments a hashmap of RefPtr instead of raw pointers such that the document values cannot be freed prematurely.
Present assumption is that storing raw pointers is ok because CSSValues will live as long as the StyleResolver instance, however that it no longer
true when variables are used, so we must ensure we increment the reference counter to ensure the CSSValues are not freed prematurely.

Test: fast/css/variables/var-filter.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):

LayoutTests: Fix bug when using a variable to specify a -webkit-filter.
https://bugs.webkit.org/show_bug.cgi?id=97153

Reviewed by Abhishek Arya.

Use a variable in a -webkit-filter css property.

* fast/css/variables/var-filter-expected.txt: Added.
* fast/css/variables/var-filter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoComment out a failing webkitpy unit test until Dirk can fix it.
simon.fraser@apple.com [Fri, 21 Sep 2012 04:00:21 +0000 (04:00 +0000)]
Comment out a failing webkitpy unit test until Dirk can fix it.

* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SemanticTests.test_skip_and_wontfix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test expectations edit.
noel.gordon@gmail.com [Fri, 21 Sep 2012 02:58:48 +0000 (02:58 +0000)]
Unreviewed test expectations edit.

* platform/mac/TestExpectations: Expectations format change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent reading stale data from InlineTextBoxes
leviw@chromium.org [Fri, 21 Sep 2012 01:38:05 +0000 (01:38 +0000)]
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Abhishek Arya.

Text from dirty InlineTextBoxes should never be read or used. This change
enforces this design goal by forcefully zero-ing out the start and length
of InlineTextBoxes when they're being marked dirty. Ideally, we'd also
add asserts to the accessors for this data, but there are still several
places in editing that cause this. https://bugs.webkit.org/show_bug.cgi?id=97264
tracks these cases.

This change involves making markDirty virtual. Running the line-layout
performance test as well as profiling resizing the html5 spec showed
negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* dom/Position.cpp:
(WebCore::Position::downstream): Adding a FIXME.
* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Marking virtual to allow InlineTextBox to
overload and zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out the start and length when
we mark the box dirty.
* rendering/InlineTextBox.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::setTextWithOffset): Adding a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdated Lion-specific results after r129176.
mitz@apple.com [Fri, 21 Sep 2012 01:35:17 +0000 (01:35 +0000)]
Updated Lion-specific results after r129176.

* platform/mac-lion/fast/writing-mode/text-orientation-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomake Skip, WontFix be the only expectations on a line
dpranke@chromium.org [Fri, 21 Sep 2012 01:33:38 +0000 (01:33 +0000)]
make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225

Reviewed by Ojan Vafai.

It is now incorrect in the new syntax to have a line like:

    foo.html [ WontFix Crash ]

This will generate a lint warning and be treated as an invalid
line. Fixing this caused a whole bunch of unit tests to need updating
to no longer be marked as WontFix :). Also, this patch adjusts
the warnings so that missing Bug() identifiers will cause lint
warnings but will *not* cause the line to be treated as invalid.
Fixing these issues also revealed that test_hung_thread was no
longer testing the right logic, so I adjusted the timeouts in
test.py to make that test work again.

* Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(Worker._run_test_in_another_thread):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_summarized_results_wontfix):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser._parse_modifiers):
(TestExpectationParser._tokenize_line_using_new_format):
(TestExpectationLine.is_invalid):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(BasicTests.test_basic):
(test_get_test_set):
(test_parse_warning):
(test_pixel_tests_flag):
(SemanticTests.test_missing_bugid):
(SemanticTests):
(SemanticTests.test_skip_and_wontfix):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestDriver.run_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_hung_thread):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_basic):
(PrintExpectationsTest.test_multiple):
(PrintExpectationsTest.test_full):
(PrintExpectationsTest.test_exclude):
(PrintExpectationsTest.test_csv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Update test expectation
tkent@chromium.org [Fri, 21 Sep 2012 01:24:03 +0000 (01:24 +0000)]
[Win] Update test expectation
https://bugs.webkit.org/show_bug.cgi?id=97274

* platform/win/Skipped:
Add fast/forms/number/number-spinbutton-click-in-iframe.html because
Apple Win port doesn't have spin button in testing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMeasure how often web pages use Worker and SharedWorker
abarth@webkit.org [Fri, 21 Sep 2012 01:20:15 +0000 (01:20 +0000)]
Measure how often web pages use Worker and SharedWorker
https://bugs.webkit.org/show_bug.cgi?id=97273

Reviewed by Ojan Vafai.

We're not considering removing these features, but it will give us a
baseline idea of how often they're used.

* page/FeatureObserver.h:
* workers/SharedWorker.cpp:
(WebCore::SharedWorker::create):
* workers/Worker.cpp:
(WebCore::Worker::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Start running tests on the mac-ews.
lforschler@apple.com [Fri, 21 Sep 2012 01:04:24 +0000 (01:04 +0000)]
Unreviewed.  Start running tests on the mac-ews.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed build fix. webkit_unit_tests have global constructors.
tony@chromium.org [Thu, 20 Sep 2012 23:52:19 +0000 (23:52 +0000)]
[chromium] Unreviewed build fix. webkit_unit_tests have global constructors.

* WebKitUnitTests.gyp: Remove -Wglobal-constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
fpizlo@apple.com [Thu, 20 Sep 2012 23:38:48 +0000 (23:38 +0000)]
CHECK_ARRAY_CONSISTENCY isn't being used or tested, so we should remove it
https://bugs.webkit.org/show_bug.cgi?id=97260

Rubber stamped by Geoffrey Garen.

Supporting it will become difficult as we add more indexing types. It makes more
sense to kill, especially since we don't appear to use it or test it, ever.

* runtime/ArrayConventions.h:
(JSC):
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
* runtime/ArrayStorage.h:
(JSC::ArrayStorage::copyHeaderFromDuringGC):
(ArrayStorage):
* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncBind):
* runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sortNumeric):
(JSC::JSArray::sort):
(JSC::JSArray::compactForSorting):
* runtime/JSArray.h:
(JSArray):
(JSC::createArrayButterfly):
(JSC::JSArray::tryCreateUninitialized):
(JSC::constructArray):
* runtime/JSObject.cpp:
(JSC::JSObject::putByIndex):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::deletePropertyByIndex):
(JSC):
* runtime/JSObject.h:
(JSC::JSObject::initializeIndex):
(JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable more clang warnings
tony@chromium.org [Thu, 20 Sep 2012 23:38:21 +0000 (23:38 +0000)]
[chromium] Enable more clang warnings
https://bugs.webkit.org/show_bug.cgi?id=97257

Reviewed by James Robinson.

Source/WebCore:

Add -Wunused-parameter to WebCore targets. Apple's Mac compile already
warns on this and it's a common source of error for Chromium patches.

No new tests, should compile cleanly.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

* WebKit.gyp: Add -Wglobal-constructors. Don't add -Wunused-parameter because many of our API interfaces have named parameters with empty implementations.
* WebKitUnitTests.gyp: Add -Wglobal-constructors and -Wunused-parameter.

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add -Wunused-parameter. Don't add -Wglobal-constructors because
there are lots of violations in these files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKerning never occurs between a space and the following glyph
mitz@apple.com [Thu, 20 Sep 2012 23:19:43 +0000 (23:19 +0000)]
Kerning never occurs between a space and the following glyph
https://bugs.webkit.org/show_bug.cgi?id=97269

Reviewed by Tim Horton.

Source/WebCore:

Covered by several existing tests.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to not reset the advance
of a space, and added a comment about how this also needs to be fixed for other characters
that are treated as spaces.

LayoutTests:

* platform/mac/fast/text/emphasis-expected.png:
* platform/mac/fast/text/emphasis-expected.txt:
* platform/mac/fast/text/sticky-typesetting-features-expected.png:
* platform/mac/fast/text/sticky-typesetting-features-expected.txt:
* platform/mac/fast/text/thai-combining-mark-positioning-expected.png:
* platform/mac/fast/text/thai-combining-mark-positioning-expected.txt:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.png:
* platform/mac/fast/writing-mode/text-orientation-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Improve glyph selection of HarfBuzzShaper
bashi@chromium.org [Thu, 20 Sep 2012 23:16:16 +0000 (23:16 +0000)]
[Chromium] Improve glyph selection of HarfBuzzShaper
https://bugs.webkit.org/show_bug.cgi?id=97164

Reviewed by Tony Chang.

Source/WebCore:

Take into account clusters for selection.

Test: fast/text/international/hebrew-selection.html

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::applyShapeResult): Removed m_logClusters.
m_logCluster is no longer used.
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
- If targetX is in the left side of the first cluster, return the leftmost character index.
- If targetX is in the right side of the last cluster, return the rightmost character index.
- If targetX is between the right side of the cluster N and the left side of the cluster N+1, then:
  - return N+1 for LTR.
  - return N for RTL.
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
Find the cluster of index in question, then:
- return the left side boundary of the cluster for LTR.
- return the right side boundary of the cluster for RTL.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):

LayoutTests:

Added a test for complex text selection.

* fast/text/international/hebrew-selection-expected.html: Added.
* fast/text/international/hebrew-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight
tony@chromium.org [Thu, 20 Sep 2012 23:11:16 +0000 (23:11 +0000)]
Replace RenderListBox::updateLogicalHeight with RenderListBox::computeLogicalHeight
https://bugs.webkit.org/show_bug.cgi?id=97263

Reviewed by Ojan Vafai.

This is part of making computeLogicalHeight virtual so with any RenderBox pointer, one
can compute the logical height without mutating the RenderBox.

No new tests, this is a refactor and existing list box tests should pass.

* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::layout): Move layout related logic here.
(WebCore::RenderListBox::computeLogicalHeight): Use const version and remove layout related code.
* rendering/RenderListBox.h:
(RenderListBox): Override computeLogicalHeight.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning
lforschler@apple.com [Thu, 20 Sep 2012 22:30:04 +0000 (22:30 +0000)]
Versioning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomake Skip, WontFix be the only expectations on a line
dpranke@chromium.org [Thu, 20 Sep 2012 22:00:00 +0000 (22:00 +0000)]
make Skip, WontFix be the only expectations on a line
https://bugs.webkit.org/show_bug.cgi?id=97225

Unreviewed, expectations change.

This change updates all of the expectations files, but doesn't
actually change the code to issue warnings in this case (that
will come in a subsequent patch).

* platform/chromium-android/TestExpectations:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt-4.8/TestExpectations:
* platform/qt-arm/TestExpectations:
* platform/qt-mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix IndexedDB unit tests
dgrogan@chromium.org [Thu, 20 Sep 2012 21:45:57 +0000 (21:45 +0000)]
Fix IndexedDB unit tests
https://bugs.webkit.org/show_bug.cgi?id=97149

Reviewed by Tony Chang.

* tests/IDBDatabaseBackendTest.cpp:
Specify a desired version of -1 so that no version change transaction
is run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove entries for deleted tests from Skipped list
commit-queue@webkit.org [Thu, 20 Sep 2012 21:36:08 +0000 (21:36 +0000)]
[Qt] Remove entries for deleted tests from Skipped list
https://bugs.webkit.org/show_bug.cgi?id=97213

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-20
Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP reports should send an empty "blocked-uri" rather than nothing.
commit-queue@webkit.org [Thu, 20 Sep 2012 21:25:09 +0000 (21:25 +0000)]
CSP reports should send an empty "blocked-uri" rather than nothing.
https://bugs.webkit.org/show_bug.cgi?id=97256

Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.

Source/WebCore:

In cases where a Content Security Policy violation report is generated
without blocking a resource at a particular URI (inline scripts, for
example), we currently leave the "blocked-uri" attribute out of the
report entirely. For the same reason that we included the "referrer"
attribute in webkit.org/b/97233, we should include an explicitly empty
"blocked-uri" in these cases.

This new behavior is covered by updates to existing test expectations
around the reporting functionality.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
    If the 'blocked-uri' is invalid, add a "blocked-uri" attribute that
    is explicitly empty.

LayoutTests:

* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
    Updating test expectations to include an explicitly empty
    "blocked-uri" as opposed to leaving it off entirely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoroll Chromium to r157829.
dpranke@chromium.org [Thu, 20 Sep 2012 21:16:54 +0000 (21:16 +0000)]
roll Chromium to r157829.

Unreviewed, deps change.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-09-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 20 Sep 2012 21:14:09 +0000 (21:14 +0000)]
2012-09-20  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium win build fix.
        Remove spurious reference to the non-existent
        tests/LayerPainterChromium.h in WebKit.gypi.

        * WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Add String::numberToFixedPrecisionString()
paroga@webkit.org [Thu, 20 Sep 2012 21:03:56 +0000 (21:03 +0000)]
Source/WebCore: Add String::numberToFixedPrecisionString()
https://bugs.webkit.org/show_bug.cgi?id=96330

Reviewed by Benjamin Poulain.

* platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<): Use the new function instead of String::number() with flags.

Source/WebKit2: Add String::numberToStringFixedWidth()
https://bugs.webkit.org/show_bug.cgi?id=96330

Reviewed by Benjamin Poulain.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

Source/WTF: Add String::numberToStringFixedWidth()
https://bugs.webkit.org/show_bug.cgi?id=96330

Reviewed by Benjamin Poulain.

Add this new function as replacement for the ShouldRoundDecimalPlaces flag of String::number()
and remove the now unnecessary branch in String::number() for the old flags.

* wtf/text/WTFString.cpp:
(WTF::String::number):
(WTF::String::numberToStringFixedWidth):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename ContainerNode::parserAddChild "parserAppendChild" for consistency
adamk@chromium.org [Thu, 20 Sep 2012 20:47:41 +0000 (20:47 +0000)]
Rename ContainerNode::parserAddChild "parserAppendChild" for consistency
https://bugs.webkit.org/show_bug.cgi?id=97254

Reviewed by Adam Barth.

No functional change, all the below changes are simple renames.

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::parserAppendChild):
* dom/ContainerNode.h:
(ContainerNode):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
* editing/markup.cpp:
(WebCore::createFragmentForTransformToFragment):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::createContainingTable):
(WebCore::HTMLViewSourceDocument::addSpanWithClassName):
(WebCore::HTMLViewSourceDocument::addLine):
(WebCore::HTMLViewSourceDocument::finishLine):
(WebCore::HTMLViewSourceDocument::addText):
(WebCore::HTMLViewSourceDocument::addBase):
(WebCore::HTMLViewSourceDocument::addLink):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::executeTask):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::enterText):
(WebCore::XMLDocumentParser::parseDocumentFragment):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::internalSubset):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseProcessingInstruction):
(WebCore::XMLDocumentParser::parseCdata):
(WebCore::XMLDocumentParser::parseComment):
(WebCore::XMLDocumentParser::parseDtd):
* xml/parser/XMLTreeBuilder.cpp:
(WebCore::XMLTreeBuilder::processDOCTYPE):
(WebCore::XMLTreeBuilder::processStartTag):
(WebCore::XMLTreeBuilder::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomedia/track/track-cue-rendering-inner-timestamps.html times out.
simon.fraser@apple.com [Thu, 20 Sep 2012 20:46:09 +0000 (20:46 +0000)]
media/track/track-cue-rendering-inner-timestamps.html times out.
https://bugs.webkit.org/show_bug.cgi?id=97259

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove empty directory.
abarth@webkit.org [Thu, 20 Sep 2012 20:40:23 +0000 (20:40 +0000)]
Remove empty directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoResults page should show indivisual value
rniwa@webkit.org [Thu, 20 Sep 2012 20:35:28 +0000 (20:35 +0000)]
Results page should show indivisual value
https://bugs.webkit.org/show_bug.cgi?id=97178

Reviewed by Tony Chang.

Show indivisual values instead of statistics (min, max, stdev).

* resources/results-template.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove unused copy of chromium compositor implementation files
jamesr@google.com [Thu, 20 Sep 2012 20:34:34 +0000 (20:34 +0000)]
[chromium] Remove unused copy of chromium compositor implementation files
https://bugs.webkit.org/show_bug.cgi?id=97255

Reviewed by Adam Barth.

Source/WebCore:

Now that use_libcc_for_compositor is set to 1 these files aren't used anywhere.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/chromium/support/CCThreadImpl.cpp: Removed.
* platform/chromium/support/CCThreadImpl.h: Removed.
* platform/chromium/support/WebCompositorImpl.cpp: Removed.
* platform/chromium/support/WebCompositorImpl.h: Removed.
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/Canvas2DLayerBridge.cpp:
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
* platform/graphics/chromium/CanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/CanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/ContentLayerChromium.cpp: Removed.
* platform/graphics/chromium/ContentLayerChromium.h: Removed.
* platform/graphics/chromium/ContentLayerChromiumClient.h: Removed.
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/GeometryBinding.cpp: Removed.
* platform/graphics/chromium/GeometryBinding.h: Removed.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.cpp: Removed.
* platform/graphics/chromium/HeadsUpDisplayLayerChromium.h: Removed.
* platform/graphics/chromium/IOSurfaceLayerChromium.cpp: Removed.
* platform/graphics/chromium/IOSurfaceLayerChromium.h: Removed.
* platform/graphics/chromium/ImageLayerChromium.cpp: Removed.
* platform/graphics/chromium/ImageLayerChromium.h: Removed.
* platform/graphics/chromium/LayerChromium.cpp: Removed.
* platform/graphics/chromium/LayerChromium.h: Removed.
* platform/graphics/chromium/LayerTextureSubImage.cpp: Removed.
* platform/graphics/chromium/LayerTextureSubImage.h: Removed.
* platform/graphics/chromium/LayerTextureUpdater.h: Removed.
* platform/graphics/chromium/PlatformColor.h: Removed.
* platform/graphics/chromium/ProgramBinding.cpp: Removed.
* platform/graphics/chromium/ProgramBinding.h: Removed.
* platform/graphics/chromium/RateLimiter.cpp: Removed.
* platform/graphics/chromium/RateLimiter.h: Removed.
* platform/graphics/chromium/RenderSurfaceChromium.cpp: Removed.
* platform/graphics/chromium/RenderSurfaceChromium.h: Removed.
* platform/graphics/chromium/ScrollbarLayerChromium.cpp: Removed.
* platform/graphics/chromium/ScrollbarLayerChromium.h: Removed.
* platform/graphics/chromium/ShaderChromium.cpp: Removed.
* platform/graphics/chromium/ShaderChromium.h: Removed.
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp: Removed.
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h: Removed.
* platform/graphics/chromium/SolidColorLayerChromium.cpp: Removed.
* platform/graphics/chromium/SolidColorLayerChromium.h: Removed.
* platform/graphics/chromium/TextureCopier.cpp: Removed.
* platform/graphics/chromium/TextureCopier.h: Removed.
* platform/graphics/chromium/TextureLayerChromium.cpp: Removed.
* platform/graphics/chromium/TextureLayerChromium.h: Removed.
* platform/graphics/chromium/TextureLayerChromiumClient.h: Removed.
* platform/graphics/chromium/ThrottledTextureUploader.cpp: Removed.
* platform/graphics/chromium/ThrottledTextureUploader.h: Removed.
* platform/graphics/chromium/TiledLayerChromium.cpp: Removed.
* platform/graphics/chromium/TiledLayerChromium.h: Removed.
* platform/graphics/chromium/TreeSynchronizer.cpp: Removed.
* platform/graphics/chromium/TreeSynchronizer.h: Removed.
* platform/graphics/chromium/UnthrottledTextureUploader.h: Removed.
* platform/graphics/chromium/VideoLayerChromium.cpp: Removed.
* platform/graphics/chromium/VideoLayerChromium.h: Removed.
* platform/graphics/chromium/cc/CCActiveAnimation.cpp: Removed.
* platform/graphics/chromium/cc/CCActiveAnimation.h: Removed.
* platform/graphics/chromium/cc/CCAnimationCurve.cpp: Removed.
* platform/graphics/chromium/cc/CCAnimationCurve.h: Removed.
* platform/graphics/chromium/cc/CCAnimationEvents.h: Removed.
* platform/graphics/chromium/cc/CCAppendQuadsData.h: Removed.
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCCheckerboardDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCCompletionEvent.h: Removed.
* platform/graphics/chromium/cc/CCDamageTracker.cpp: Removed.
* platform/graphics/chromium/cc/CCDamageTracker.h: Removed.
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCDebugBorderDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCDebugRectHistory.cpp: Removed.
* platform/graphics/chromium/cc/CCDebugRectHistory.h: Removed.
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp: Removed.
* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h: Removed.
* platform/graphics/chromium/cc/CCDirectRenderer.cpp: Removed.
* platform/graphics/chromium/cc/CCDirectRenderer.h: Removed.
* platform/graphics/chromium/cc/CCDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCFontAtlas.cpp: Removed.
* platform/graphics/chromium/cc/CCFontAtlas.h: Removed.
* platform/graphics/chromium/cc/CCFrameRateController.cpp: Removed.
* platform/graphics/chromium/cc/CCFrameRateController.h: Removed.
* platform/graphics/chromium/cc/CCFrameRateCounter.cpp: Removed.
* platform/graphics/chromium/cc/CCFrameRateCounter.h: Removed.
* platform/graphics/chromium/cc/CCGraphicsContext.h: Removed.
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCIOSurfaceDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCInputHandler.h: Removed.
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp: Removed.
* platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h: Removed.
* platform/graphics/chromium/cc/CCLayerAnimationController.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerAnimationController.h: Removed.
* platform/graphics/chromium/cc/CCLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCLayerIterator.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerIterator.h: Removed.
* platform/graphics/chromium/cc/CCLayerQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerQuad.h: Removed.
* platform/graphics/chromium/cc/CCLayerSorter.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerSorter.h: Removed.
* platform/graphics/chromium/cc/CCLayerTilingData.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerTilingData.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostClient.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
* platform/graphics/chromium/cc/CCMathUtil.cpp: Removed.
* platform/graphics/chromium/cc/CCMathUtil.h: Removed.
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp: Removed.
* platform/graphics/chromium/cc/CCOcclusionTracker.h: Removed.
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp: Removed.
* platform/graphics/chromium/cc/CCOverdrawMetrics.h: Removed.
* platform/graphics/chromium/cc/CCPageScaleAnimation.cpp: Removed.
* platform/graphics/chromium/cc/CCPageScaleAnimation.h: Removed.
* platform/graphics/chromium/cc/CCPrioritizedTexture.cpp: Removed.
* platform/graphics/chromium/cc/CCPrioritizedTexture.h: Removed.
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp: Removed.
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h: Removed.
* platform/graphics/chromium/cc/CCPriorityCalculator.cpp: Removed.
* platform/graphics/chromium/cc/CCPriorityCalculator.h: Removed.
* platform/graphics/chromium/cc/CCProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCProxy.h: Removed.
* platform/graphics/chromium/cc/CCQuadCuller.cpp: Removed.
* platform/graphics/chromium/cc/CCQuadCuller.h: Removed.
* platform/graphics/chromium/cc/CCQuadSink.h: Removed.
* platform/graphics/chromium/cc/CCRenderPass.cpp: Removed.
* platform/graphics/chromium/cc/CCRenderPass.h: Removed.
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCRenderPassSink.h: Removed.
* platform/graphics/chromium/cc/CCRenderSurface.cpp: Removed.
* platform/graphics/chromium/cc/CCRenderSurface.h: Removed.
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp: Removed.
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.h: Removed.
* platform/graphics/chromium/cc/CCRenderer.h: Removed.
* platform/graphics/chromium/cc/CCRendererGL.cpp: Removed.
* platform/graphics/chromium/cc/CCRendererGL.h: Removed.
* platform/graphics/chromium/cc/CCRenderingStats.h: Removed.
* platform/graphics/chromium/cc/CCResourceProvider.cpp: Removed.
* platform/graphics/chromium/cc/CCResourceProvider.h: Removed.
* platform/graphics/chromium/cc/CCScheduler.cpp: Removed.
* platform/graphics/chromium/cc/CCScheduler.h: Removed.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp: Removed.
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h: Removed.
* platform/graphics/chromium/cc/CCScopedTexture.cpp: Removed.
* platform/graphics/chromium/cc/CCScopedTexture.h: Removed.
* platform/graphics/chromium/cc/CCScopedThreadProxy.h: Removed.
* platform/graphics/chromium/cc/CCScrollbarAnimationController.cpp: Removed.
* platform/graphics/chromium/cc/CCScrollbarAnimationController.h: Removed.
* platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.cpp: Removed.
* platform/graphics/chromium/cc/CCScrollbarAnimationControllerLinearFade.h: Removed.
* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.cpp: Removed.
* platform/graphics/chromium/cc/CCScrollbarGeometryFixedThumb.h: Removed.
* platform/graphics/chromium/cc/CCScrollbarGeometryStub.cpp: Removed.
* platform/graphics/chromium/cc/CCScrollbarGeometryStub.h: Removed.
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCScrollbarLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCSettings.cpp: Removed.
* platform/graphics/chromium/cc/CCSettings.h: Removed.
* platform/graphics/chromium/cc/CCSharedQuadState.cpp: Removed.
* platform/graphics/chromium/cc/CCSharedQuadState.h: Removed.
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCSingleThreadProxy.h: Removed.
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCSolidColorLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCTexture.cpp: Removed.
* platform/graphics/chromium/cc/CCTexture.h: Removed.
* platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCTextureDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCTextureLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCTextureUpdateController.cpp: Removed.
* platform/graphics/chromium/cc/CCTextureUpdateController.h: Removed.
* platform/graphics/chromium/cc/CCTextureUpdateQueue.cpp: Removed.
* platform/graphics/chromium/cc/CCTextureUpdateQueue.h: Removed.
* platform/graphics/chromium/cc/CCThread.h: Removed.
* platform/graphics/chromium/cc/CCThreadProxy.cpp: Removed.
* platform/graphics/chromium/cc/CCThreadProxy.h: Removed.
* platform/graphics/chromium/cc/CCThreadTask.h: Removed.
* platform/graphics/chromium/cc/CCTileDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCTileDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCTiledLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCTimeSource.h: Removed.
* platform/graphics/chromium/cc/CCTimer.cpp: Removed.
* platform/graphics/chromium/cc/CCTimer.h: Removed.
* platform/graphics/chromium/cc/CCTimingFunction.cpp: Removed.
* platform/graphics/chromium/cc/CCTimingFunction.h: Removed.
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCVideoLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* WebKit.gypi:
* WebKitUnitTests.gyp:
* src/WebAnimationCurveCommon.cpp: Removed.
* src/WebAnimationCurveCommon.h: Removed.
* src/WebAnimationImpl.cpp: Removed.
* src/WebAnimationImpl.h: Removed.
* src/WebContentLayerImpl.cpp: Removed.
* src/WebContentLayerImpl.h: Removed.
* src/WebExternalTextureLayerImpl.cpp: Removed.
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebFloatAnimationCurveImpl.cpp: Removed.
* src/WebFloatAnimationCurveImpl.h: Removed.
* src/WebIOSurfaceLayerImpl.cpp: Removed.
* src/WebIOSurfaceLayerImpl.h: Removed.
* src/WebImageLayerImpl.cpp: Removed.
* src/WebImageLayerImpl.h: Removed.
* src/WebLayerImpl.cpp: Removed.
* src/WebLayerImpl.h: Removed.
* src/WebLayerTreeViewImpl.cpp: Removed.
* src/WebLayerTreeViewImpl.h: Removed.
* src/WebScrollbarLayerImpl.cpp: Removed.
* src/WebScrollbarLayerImpl.h: Removed.
* src/WebSolidColorLayerImpl.cpp: Removed.
* src/WebSolidColorLayerImpl.h: Removed.
* src/WebToCCInputHandlerAdapter.cpp: Removed.
* src/WebToCCInputHandlerAdapter.h: Removed.
* src/WebTransformAnimationCurveImpl.cpp: Removed.
* src/WebTransformAnimationCurveImpl.h: Removed.
* src/WebVideoLayerImpl.cpp: Removed.
* src/WebVideoLayerImpl.h: Removed.
* tests/CCActiveAnimationTest.cpp: Removed.
* tests/CCAnimationTestCommon.cpp: Removed.
* tests/CCAnimationTestCommon.h: Removed.
* tests/CCDamageTrackerTest.cpp: Removed.
* tests/CCDelayBasedTimeSourceTest.cpp: Removed.
* tests/CCDrawQuadTest.cpp: Removed.
* tests/CCFrameRateControllerTest.cpp: Removed.
* tests/CCGeometryTestUtils.cpp: Removed.
* tests/CCGeometryTestUtils.h: Removed.
* tests/CCHeadsUpDisplayTest.cpp: Removed.
* tests/CCKeyframedAnimationCurveTest.cpp: Removed.
* tests/CCLayerAnimationControllerTest.cpp: Removed.
* tests/CCLayerImplTest.cpp: Removed.
* tests/CCLayerIteratorTest.cpp: Removed.
* tests/CCLayerQuadTest.cpp: Removed.
* tests/CCLayerSorterTest.cpp: Removed.
* tests/CCLayerTestCommon.cpp: Removed.
* tests/CCLayerTestCommon.h: Removed.
* tests/CCLayerTreeHostCommonTest.cpp: Removed.
* tests/CCLayerTreeHostImplTest.cpp: Removed.
* tests/CCLayerTreeHostTest.cpp: Removed.
* tests/CCMathUtilTest.cpp: Removed.
* tests/CCOcclusionTrackerTest.cpp: Removed.
* tests/CCOcclusionTrackerTestCommon.h: Removed.
* tests/CCPrioritizedTextureTest.cpp: Removed.
* tests/CCQuadCullerTest.cpp: Removed.
* tests/CCRenderPassTest.cpp: Removed.
* tests/CCRenderSurfaceFiltersTest.cpp: Removed.
* tests/CCRenderSurfaceTest.cpp: Removed.
* tests/CCRendererGLTest.cpp: Removed.
* tests/CCResourceProviderTest.cpp: Removed.
* tests/CCSchedulerStateMachineTest.cpp: Removed.
* tests/CCSchedulerTest.cpp: Removed.
* tests/CCSchedulerTestCommon.h: Removed.
* tests/CCScopedTextureTest.cpp: Removed.
* tests/CCScrollbarAnimationControllerLinearFadeTest.cpp: Removed.
* tests/CCSolidColorLayerImplTest.cpp: Removed.
* tests/CCTestCommon.h: Removed.
* tests/CCTextureUpdateControllerTest.cpp: Removed.
* tests/CCThreadTaskTest.cpp: Removed.
* tests/CCThreadedTest.cpp: Removed.
* tests/CCThreadedTest.h: Removed.
* tests/CCTiledLayerImplTest.cpp: Removed.
* tests/CCTiledLayerTestCommon.cpp: Removed.
* tests/CCTiledLayerTestCommon.h: Removed.
* tests/CCTimerTest.cpp: Removed.
* tests/ContentLayerChromiumTest.cpp: Removed.
* tests/FakeCCLayerTreeHostClient.h: Removed.
* tests/FakeGraphicsContext3DTest.cpp: Removed.
* tests/FakeWebScrollbarThemeGeometry.h: Removed.
* tests/FloatQuadTest.cpp: Removed.
* tests/GraphicsLayerChromiumTest.cpp:
* tests/ImageLayerChromiumTest.cpp:
* tests/LayerChromiumTest.cpp: Removed.
* tests/MockCCQuadCuller.h: Removed.
* tests/ScrollbarLayerChromiumTest.cpp: Removed.
* tests/TextureCopierTest.cpp: Removed.
* tests/TextureLayerChromiumTest.cpp: Removed.
* tests/ThrottledTextureUploaderTest.cpp: Removed.
* tests/TiledLayerChromiumTest.cpp: Removed.
* tests/TreeSynchronizerTest.cpp: Removed.
* tests/WebAnimationTest.cpp: Removed.
* tests/WebFloatAnimationCurveTest.cpp: Removed.
* tests/WebLayerTest.cpp: Removed.
* tests/WebLayerTreeViewTest.cpp: Removed.
* tests/WebTransformAnimationCurveTest.cpp: Removed.
* tests/WebTransformOperationsTest.cpp: Removed.
* tests/WebTransformationMatrixTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark plugins/netscape-dom-access-and-reload.html as flakey
simon.fraser@apple.com [Thu, 20 Sep 2012 20:31:56 +0000 (20:31 +0000)]
Mark plugins/netscape-dom-access-and-reload.html as flakey
https://bugs.webkit.org/show_bug.cgi?id=82752

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-perf-tests should record individual value instead of statistics
rniwa@webkit.org [Thu, 20 Sep 2012 20:04:31 +0000 (20:04 +0000)]
run-perf-tests should record individual value instead of statistics
https://bugs.webkit.org/show_bug.cgi?id=97155

Reviewed by Hajime Morita.

PerformanceTests:

Report the list of values as "values" so that run-perf-tests can parse them.

* resources/runner.js:
(PerfTestRunner.computeStatistics):
(PerfTestRunner.printStatistics):

Tools:

Parse the list of individual value reported by tests and include them as "values".
We strip "values" from the output JSON when uploading it to the perf-o-matic
since it doesn't know how to parse "values" or ignore it.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
(PerfTest.parse_output): Parse and report "values".
(PageLoadingPerfTest.run): Report indivisual page loading time in "values".
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(MainTest.test_parse_output):
(MainTest.test_parse_output_with_failing_line):
(TestPageLoadingPerfTest.test_run):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_and_show_results): Strip "values" from each result
until we update perf-o-matic.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_memory_test):
(test_run_with_json_output):
(test_run_with_description):
(test_run_with_slave_config_json):
(test_run_with_multiple_repositories):

LayoutTests:

The expected result now contains individual value.

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed a missing semicolon in the C++ llint backend.
mark.lam@apple.com [Thu, 20 Sep 2012 19:54:28 +0000 (19:54 +0000)]
Fixed a missing semicolon in the C++ llint backend.
https://bugs.webkit.org/show_bug.cgi?id=97252.

Reviewed by Geoff Garen.

* offlineasm/cloop.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactored the interpreter and JIT so they don't dictate closure layout
ggaren@apple.com [Thu, 20 Sep 2012 19:51:58 +0000 (19:51 +0000)]
Refactored the interpreter and JIT so they don't dictate closure layout
https://bugs.webkit.org/show_bug.cgi?id=97221

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Capture may change the location of an argument for space efficiency. This
patch removes static assumptions about argument location from the interpreter
and JIT.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::argumentIndexAfterCapture):
(JSC::ExecState::argumentAfterCapture): Factored out a helper function
so the compiler could share this logic.

* bytecompiler/NodesCodegen.cpp:
(JSC::BracketAccessorNode::emitBytecode): Don't emit optimized bracket
access on arguments if a parameter has been captured by name. This case is
rare and, where I've seen it in the wild, the optimization mostly failed
anyway due to arguments escape, so I didn't feel like writing and testing
five copies of the code that would handle it in the baseline engines.

The DFG can still synthesize this optimization even if we don't emit the
optimized bytecode for it.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::symbolTableFor):
(AssemblyHelpers): Use the right helper function to account for the fact
that a parameter may have been captured by name and moved.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): ASSERT that we haven't inlined
a .apply on captured arguments. Once we do start inlining such things,
we'll need to do a little bit of math here to get them right.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Added support for bracket access on
an arguments object where arguments have also been captured by name. We
load the true index of the argument from a side vector. Arguments elision
is very powerful in the DFG, so I wanted to keep it working, even in this
rare case.

* interpreter/Interpreter.cpp:
(JSC::loadVarargs): Use the right helper function to account for the fact
that a parameter may have been captured by name and moved.

* jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs): Don't use the inline copy loop if some
of our arguments have moved, since it would copy stale values. (We still
optimize the actual call, and elide the arguments object.)

LayoutTests:

* fast/js/dfg-arguments-alias-activation-expected.txt: Added.
* fast/js/dfg-arguments-alias-activation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix production builds
hausmann@webkit.org [Thu, 20 Sep 2012 19:49:33 +0000 (19:49 +0000)]
[Qt] Fix production builds

Unreviewed trivial fix: Follow up r129119 and avoid clobbering LIBS through the use of LIBS_PRIVATE.

Otherwise the libQtWebKit.prl file for example contains -lWebKit1 -lWebCore, etc.

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement absolutely positioned flex items
tony@chromium.org [Thu, 20 Sep 2012 19:29:51 +0000 (19:29 +0000)]
Implement absolutely positioned flex items
https://bugs.webkit.org/show_bug.cgi?id=93798

Reviewed by Ojan Vafai.

Source/WebCore:

Previously, we treated absolutely positioned flex items as a 0x0 placeholder element.
Now we position the 0x0 placeholder where the next item would go. This causes the
following changes:
- justify-content: space-{around,between} no longer change due to the existence of absolutely positioned flex items.
- alignment doesn't change the placement of absolutely positioned flex items.
- auto margins in the alignment direction don't do anything on absolutely positioned flex items.

Test: css3/flexbox/position-absolute-children.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Absolutely positioned flex items should not use this.
(WebCore::RenderFlexibleBox::updateAutoMarginsInCrossAxis): Absolutely positioned flex items should not use this.
(WebCore::initialJustifyContentOffset): If there are no flex items, space-around should center an absolutely positioned flex item.
(WebCore::RenderFlexibleBox::numberOfInFlowPositionedChildren): Helper method for helping to compute space-between and space-around.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Fix spacing when space-between or space-around.
(WebCore::RenderFlexibleBox::layoutColumnReverse): Fix spacing when space-between or space-around.
(WebCore::RenderFlexibleBox::alignChildren): Treat absolutely positioned children like flex-start.
* rendering/RenderFlexibleBox.h: numberOfInFlowPositionedChildren method.

LayoutTests:

Fix position of absolute flex items and add some additional tests.

* css3/flexbox/align-absolute-child-expected.txt:
* css3/flexbox/align-absolute-child.html: New test cases and update expectations.
* css3/flexbox/position-absolute-child.html: Update expectations.
* css3/flexbox/position-absolute-children-expected.txt: Added.
* css3/flexbox/position-absolute-children.html: Added. Tests having only absolutely positioned children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove now passing test.
ojan@chromium.org [Thu, 20 Sep 2012 19:24:29 +0000 (19:24 +0000)]
Remove now passing test.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r129144.
commit-queue@webkit.org [Thu, 20 Sep 2012 19:09:56 +0000 (19:09 +0000)]
Unreviewed, rolling out r129144.
http://trac.webkit.org/changeset/129144
https://bugs.webkit.org/show_bug.cgi?id=97244

causing lots of assertions in tests (Requested by smfr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-20

* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty):
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start):
(WebCore::InlineTextBox::end):
(WebCore::InlineTextBox::len):
(WebCore::InlineTextBox::offsetRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMarking http/tests/media/video-referer.html as flakey in TestExpectations
simon.fraser@apple.com [Thu, 20 Sep 2012 18:55:29 +0000 (18:55 +0000)]
Marking http/tests/media/video-referer.html as flakey in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=34331

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP reports should send an empty 'referrer' rather than nothing.
commit-queue@webkit.org [Thu, 20 Sep 2012 18:52:31 +0000 (18:52 +0000)]
CSP reports should send an empty 'referrer' rather than nothing.
https://bugs.webkit.org/show_bug.cgi?id=97233

Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.

Source/WebCore:

Currently, if a protected resource doesn't have a referrer, then any
Content Security Policy violations send a report that doesn't contain
a referrer attribute. It's arguably friendlier to developers to include
an explicitly empty attribute.

This new behavior is covered by updates to existing test expectations
around the reporting functionality.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
    Drop the 'if', and always write out a referrer.

LayoutTests:

* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
    Adding the empty 'referrer' attribute to the expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WK2-specific result for this frame-flattening test (seems to be a scrollbars...
simon.fraser@apple.com [Thu, 20 Sep 2012 18:42:23 +0000 (18:42 +0000)]
Add WK2-specific result for this frame-flattening test (seems to be a scrollbars difference).
Tracked by https://bugs.webkit.org/show_bug.cgi?id=97240.

* platform/mac-wk2/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: layout test results doesn't show diffs
dpranke@chromium.org [Thu, 20 Sep 2012 18:41:46 +0000 (18:41 +0000)]
REGRESSION: layout test results doesn't show diffs
https://bugs.webkit.org/show_bug.cgi?id=97182

Reviewed by Ojan Vafai.

Go back to storing TEXT, AUDIO, and IMAGE+TEXT in results.json
so that results.html (and hopefully garden-o-matic) can
determine which things actually failed. However, we keep mapping
these results to Failure so that we still only have a single
expectation type for them.

* Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
(JSONLayoutResultsGenerator):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser):
(TestExpectations):
(TestExpectations.result_was_expected):
* Scripts/webkitpy/layout_tests/models/test_failures.py:
(determine_result_type):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_retrying_and_flaky_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MathML] Increase visual space around fraction parts, italic variables, and operators
dbarton@mathscribe.com [Thu, 20 Sep 2012 18:27:15 +0000 (18:27 +0000)]
[MathML] Increase visual space around fraction parts, italic variables, and operators
https://bugs.webkit.org/show_bug.cgi?id=97228

Reviewed by Eric Seidel.

Source/WebCore:

This makes MathML more readable, and more in agreement with Firefox and TeX.

Tested by existing tests.

* css/mathml.css:
(mfrac > :first-child):
(mfrac > :last-child):
(mfrac):
(mi):
(msub > mi:first-child, msubsup > mi:first-child):
    - Subscripts don't need to move right after an italic <mi>.
(msubsup > mi:first-child + * + *):
    - Superscripts do need to move right after an italic <mi>.
(math > mo, mrow > mo, msqrt > mo, mtd > mo):
    - These are ok values for now. It will be better to use different values for different operators, as the FIXME says.
(math > mo:last-child, mrow > mo:last-child, msqrt > mo:last-child, mtd > mo:last-child):
    - Prefix and postfix operators, including fences, generally get less spacing than infix operators.

* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
    - Usually the separator is a comma or semicolon, so we only put space after it for now.
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
(WebCore::RenderMathMLFenced::styleDidChange):
* rendering/mathml/RenderMathMLFenced.h:
(RenderMathMLFenced):

* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore):
(WebCore::RenderMathMLFraction::updateFromElement):
    - gDenominatorPad is now handled by mathml.css.

* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore):
(WebCore::RenderMathMLSubSup::fixScriptsStyle):
    - gSubsupScriptMargin is now handled by mathml.css.

LayoutTests:

* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-expected.png:
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.png:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.png:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/mroot-pref-width-expected.png:
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.png:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.png:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.png:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.png:
* platform/mac/mathml/xHeight-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Extend UserMediaRequest with a ownerDocument method
tommyw@google.com [Thu, 20 Sep 2012 18:23:13 +0000 (18:23 +0000)]
MediaStream API: Extend UserMediaRequest with a ownerDocument method
https://bugs.webkit.org/show_bug.cgi?id=97095

Reviewed by Adam Barth.

Source/WebCore:

Chromium need to know exactly which frame called getUserMedia so that it can
clean away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.

Chromium mock class extended to test the added method.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::ownerDocument):
(WebCore):
* Modules/mediastream/UserMediaRequest.h:
(WebCore):
(UserMediaRequest):

Source/WebKit/chromium:

Chromium need to know exactly which frame called getUserMedia so that it can clean
away the stream when the frame goes away.
Since that information is available in webkit add an accessor method.

Also taking the opportunity to remove an unused deprecated method,
and adding asserts in case the object is empty.

* public/WebUserMediaRequest.h:
(WebKit):
(WebUserMediaRequest):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::ownerDocument):

Tools:

Extending WebUserMediaClientMock to check that the owning document is valid,
and that the document has a frame.

* DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
(WebKit::WebUserMediaClientMock::requestUserMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent reading stale data from InlineTextBoxes
leviw@chromium.org [Thu, 20 Sep 2012 18:20:26 +0000 (18:20 +0000)]
Prevent reading stale data from InlineTextBoxes
https://bugs.webkit.org/show_bug.cgi?id=94750

Reviewed by Eric Seidel.

Text from dirty InlineTextBoxes should never be read or used. This change enforces this
design goal by forcefully zero-ing out the start and length of InlineTextBoxes when
they're being marked dirty. It also adds asserts to accessors for those members.

This change involves making markDirty virtual. Running the line-layout performance test
as well as profiling resizing the html5 spec showed negligable impact with this change.

No new tests as this doesn't change any proper behavior.

* rendering/InlineBox.h:
(WebCore::InlineBox::markDirty): Making virtual to allow InlineTextBox to overload and
zero out its start and length.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::markDirty): Zeroing out start and length when we mark the box dirty.
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::start): Adding an assert when we hit this case.
(WebCore::InlineTextBox::end): Ditto.
(WebCore::InlineTextBox::len): Ditto.
(WebCore::InlineTextBox::offsetRun): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport paths in Content Security Policy directives.
commit-queue@webkit.org [Thu, 20 Sep 2012 18:11:19 +0000 (18:11 +0000)]
Support paths in Content Security Policy directives.
https://bugs.webkit.org/show_bug.cgi?id=89750

Patch by Mike West <mkwst@chromium.org> on 2012-09-20
Reviewed by Adam Barth.

Source/WebCore:

In CSP 1.0, paths are simply ignored: 'script-src
http://example.com/path/to/a/file' would allow script to be loaded from
http://example.com/path/to/a/file/javascript.js, but also from
http://example.com/javascript.js.

This patch is an experimental implementation of more granular path
support in CSP source lists as proposed in the current editor's draft of
CSP 1.1. Paths are treated as specifying directories in which resources
can be found, and are implicitly terminated with a '/': in other words,
'script-src http://a.com/path' is the same as
'script-src http://a.com/path/'. Moreover, paths cannot contain either
'?' or '#' characters.

This is implemented outside the CSP_NEXT flag. All ports will be
effected.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#matching

Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html
       http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPSource::CSPSource):
    Store a path along with each CSP source.
(WebCore::CSPSource::matches):
    Check the path when comparing a URL to the source.
(WebCore::CSPSource::pathMatches):
    Compare the URL-decoded version of the resource to validate against
    the source's stored path. If the resource's path begins with the
    stored path, then it matches! If not, it doesn't.
(CSPSource):
    Store a path along with each CSP source.
(WebCore::CSPSourceList::parse):
    Pass a 'path' in when creating CSPSource objects.
(WebCore::CSPSourceList::parsePath):
    Actually parse the path, flagging errors if '?' or '#' are present,
    URL-decoding the result, and ensuring that a terminal '/' is
    added if necessary.
(WebCore::CSPSourceList::addSourceSelf):
    Ensure that 'self' sources have an empty path.
* page/ContentSecurityPolicy.h:
    Dropping the "ignored path component" console warning.

LayoutTests:

* http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-05.html:
* http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-06.html:
    The behavior of these tests changes based on the new functionality.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02.html: Added.
    New tests for various path cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Rewrite confusing call sequence layout tests
jsbell@chromium.org [Thu, 20 Sep 2012 18:00:18 +0000 (18:00 +0000)]
IndexedDB: Rewrite confusing call sequence layout tests
https://bugs.webkit.org/show_bug.cgi?id=97051

Reviewed by Tony Chang.

Rewrite some convoluted and hard to understand/maintain tests in a more idiomatic fashion.
This patch maintains the bulk of the non-standard output to verify that the tests have not
changed in behavior; follow-ups will make the output more standard and split the tests
into separate files.

* storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
* storage/indexeddb/open-close-version-expected.txt:
* storage/indexeddb/resources/factory-deletedatabase-interactions.js:
* storage/indexeddb/resources/open-close-version.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
commit-queue@webkit.org [Thu, 20 Sep 2012 17:56:00 +0000 (17:56 +0000)]
[GTK] ControlsPanel string is not localized in LocalizedStringsGtk
https://bugs.webkit.org/show_bug.cgi?id=96502

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-20
Reviewed by Chris Fleizach.

Source/WebCore:

Adds the ControlsPanel string to the strings localized in LocalizedStringsGtk.

Test: platform/gtk/accessibility/media-controls-panel-title.html

* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):

LayoutTests:

Added a new test to verify that the accessible object associated with the
MediaControlsPanel has the expected accessible name.

* platform/gtk/accessibility/media-controls-panel-title-expected.txt: Added.
* platform/gtk/accessibility/media-controls-panel-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSafari 6 notifications' onclick handlers can't call window.open()
jonlee@apple.com [Thu, 20 Sep 2012 17:49:31 +0000 (17:49 +0000)]
Safari 6 notifications' onclick handlers can't call window.open()
https://bugs.webkit.org/show_bug.cgi?id=96959
<rdar://problem/12132427>

Reviewed by Darin Adler.

Source/WebKit2:

The click is not being treated as a user gesture when the message is sent to the web process.

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification): Gets called when the user clicks on the
platform notification. Set UserGestureIndicator to show the click event is due to user gesture.

LayoutTests:

The test shows and clicks a platform notification. The onclick handler calls window.open(),
which in turn calls a function on the main page to confirm that a window was opened.

* http/tests/notifications/legacy/window-show-on-click-expected.txt: Added.
* http/tests/notifications/legacy/window-show-on-click.html: Added.
* http/tests/notifications/resources/window-show-on-click.html: Added.
* http/tests/notifications/window-show-on-click-expected.txt: Added.
* http/tests/notifications/window-show-on-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DRT does not support --dump-all-pixels flag
schenney@chromium.org [Thu, 20 Sep 2012 15:57:31 +0000 (15:57 +0000)]
[Chromium] DRT does not support --dump-all-pixels flag
https://bugs.webkit.org/show_bug.cgi?id=95098

Reviewed by Dirk Pranke.

Add support for the --pixel-tests and shorthand -p option in Chromium DumpRenderTree. Use
of this flag causes pixel results to be created for all tests, regardless of
individual test options. If an individual test provides a pixel hash it will be used,
otherwise the hash will be empty. This replaces a previously defined but unused option
--dump-all-pixels, and is useful primarily when debugging DRT instances.

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(runTest): Add a parameter and code to force pixel results for the test.
(main): Add parameter handling for --pixels-test and -p, and remove --dump-all-pixels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129139 268f45cc-cd09-0410-ab3c-d52691b4dbfc