WebKit-https.git
8 years ago2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 25 Jun 2011 06:28:12 +0000 (06:28 +0000)]
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        font substitution doesn't work for HTML text using SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=17608

        Selection rects are wrong for text with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=25460

        With @font-face, SVG fonts only work as primary, non-segmented
        https://bugs.webkit.org/show_bug.cgi?id=32227

        When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
        https://bugs.webkit.org/show_bug.cgi?id=34236

        SVG @font-face breaks text-overflow: ellipsis
        https://bugs.webkit.org/show_bug.cgi?id=36840

        REGRESSION: SVG Font selection problems
        https://bugs.webkit.org/show_bug.cgi?id=41934

        Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
        That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
        There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

        Update SVG pixel test baseline. Use all results that have been checked in when I landed the patch the last time.

        * platform/chromium/test_expectations.txt:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.png:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.png:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/xmlSpace-expected.png:
        * platform/mac/svg/batik/text/xmlSpace-expected.txt:
        * platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
        * platform/mac/svg/custom/glyph-selection-lang-attribute-expected.txt:
        * platform/mac/svg/custom/svg-fonts-fallback-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-fallback-expected.txt: Added.
        * platform/mac/svg/custom/svg-fonts-segmented-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-segmented-expected.txt: Added.
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.png:
        * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
        * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
        * platform/mac/svg/custom/svg-fonts-word-spacing-expected.png: Added.
        * platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/mac/svg/text/text-altglyph-01-b-expected.png:
        * platform/mac/svg/text/text-altglyph-01-b-expected.txt:
        * platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
        * platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
        * platform/mac/svg/text/text-text-04-t-expected.png:
        * platform/mac/svg/text/text-text-04-t-expected.txt:
        * platform/mac/svg/text/text-text-05-t-expected.png:
        * platform/mac/svg/text/text-text-05-t-expected.txt:
        * platform/mac/svg/text/text-text-06-t-expected.png:
        * platform/mac/svg/text/text-text-06-t-expected.txt:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
        * platform/mac/svg/wicd/test-rightsizing-b-expected.png:
        * platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
        * platform/qt-mac/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt-wk2/fast/dom/Window/window-properties-expected.txt:
        * platform/qt-wk2/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt-wk2/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/qt/Skipped:
        * platform/qt/fast/dom/Window/window-properties-expected.png: Added.
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Added.
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-2-expected.png: Added.
        * platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.png: Added.
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.png: Added.
        * platform/qt/fast/js/global-constructors-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/qt/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * platform/qt/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
        * platform/qt/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
        * platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
        * platform/qt/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
        * platform/qt/svg/custom/svg-features-expected.png: Added.
        * platform/qt/svg/custom/svg-features-expected.txt: Added.
        * platform/qt/svg/custom/svg-fonts-in-html-expected.png:
        * platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
        * platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
        * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png:
        * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
        * platform/qt/svg/wicd/test-rightsizing-b-expected.png:
        * platform/qt/svg/wicd/test-rightsizing-b-expected.txt:
        * svg/custom/resources/ABCFont.svg:
        * svg/custom/svg-fonts-fallback.xhtml: Added.
        * svg/custom/svg-fonts-segmented.xhtml: Added.
        * svg/custom/svg-fonts-word-spacing.html: Added.
        * svg/text/select-text-svgfont-expected.txt: Added.
        * svg/text/select-text-svgfont.html: Added.
        * svg/text/text-overflow-ellipsis-svgfont.html: Added.
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        * wtf/Platform.h: Force Qt-EWS into a full rebuild, otherwhise this patch breaks the EWS.
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        font substitution doesn't work for HTML text using SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=17608

        Selection rects are wrong for text with SVG fonts
        https://bugs.webkit.org/show_bug.cgi?id=25460

        With @font-face, SVG fonts only work as primary, non-segmented
        https://bugs.webkit.org/show_bug.cgi?id=32227

        When using SVG fonts with @font-face word-spacing and text-align: justify are not being honored
        https://bugs.webkit.org/show_bug.cgi?id=34236

        SVG @font-face breaks text-overflow: ellipsis
        https://bugs.webkit.org/show_bug.cgi?id=36840

        REGRESSION: SVG Font selection problems
        https://bugs.webkit.org/show_bug.cgi?id=41934

        Tests: svg/custom/svg-fonts-fallback.xhtml (for bug 17608, extended the original test from Mark Ambachtsheer)
               svg/custom/svg-fonts-segmented.xhtml (for bug 32227)
               svg/custom/svg-fonts-word-spacing.html (for bug 34236, from Michael Lewis)
               svg/text/select-text-svgfont.html (for bug 25460/41934, from Emil Schutte)
               svg/text/text-overflow-ellipsis-svgfont.html (for 36840, from Emil Schutte)

        Rewrite the SVG Fonts support to fully integrate within the GlyphPage concept and the "simple" code path used to render platform fonts.
        That means the special logic for measuring text using SVG Fonts, calculating offset for positions, computing selection rects etc. is all gone now.
        There's no difference anymore between using a native font or a SVG Font, in terms of these operations.

        This makes text selection using SVG Fonts possible again.

        * features.pri: Temporarily turn of SVG Fonts for Qt, as long as QRawFont support is not available and the fast path is disabled.
        * page/DOMWindow.idl: Touched file to force Qt regenerating the bindings.
        * platform/graphics/Font.cpp: Remove SVG Font special cases, the simple code path now handles SVG Fonts as well.
        (WebCore::Font::drawText):
        (WebCore::Font::drawEmphasisMarks):
        (WebCore::Font::width):
        (WebCore::Font::selectionRectForText):
        (WebCore::Font::offsetForPosition):
        (WebCore::Font::codePath):
        * platform/graphics/Font.h: Pass TextRun to drawGlyphBuffer/drawEmphasisMarks. Add new glyphDataAndPageForCharacter() method which returns a pair
                                    std::pair<GlyphData, GlyphPage*>, so we know the associated GlyphPage for a certain GlyphData object, which is needed to properly
                                    handle font fallback glyph matching for SVG Fonts..
        (WebCore::Font::fontList): Add FontFallbackList accessor.
        * platform/graphics/FontFallbackList.h: Add getters/setters for glyphPageZero -- SVG Fonts support needs access to these objects from SVGTextRunRenderingContext.
        (WebCore::FontFallbackList::glyphPageZero):
        (WebCore::FontFallbackList::glyphPages):
        (WebCore::FontFallbackList::setGlyphPageZero):
        (WebCore::FontFallbackList::setGlyphPages):
        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter): Move implementation to glyphDataAndPageForCharacter(), and use that method from here.
        (WebCore::Font::glyphDataAndPageForCharacter): Does the same as before, just returns an additional GlyphPage* pointer.
        (WebCore::Font::getEmphasisMarkGlyphData): Remove SVG Fonts special case.
        (WebCore::Font::drawGlyphBuffer): Ditto.
        * platform/graphics/FontMetrics.h:
        (WebCore::scaleEmToUnits): Refactored scaleEmToUnits free function from SimpleFontDataMac/CGWin to share with SVGFontData/SVGTextRunRenderingContext.
        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::fill): Stop skipping SVG Fonts, they now also fill the GlyphPage using the glyphs defined in the SVG Font.
        * platform/graphics/SVGGlyph.h: s/isValid/isPartOfLigature/. Its usage has been changed.
        (WebCore::SVGGlyph::SVGGlyph):
        (WebCore::SVGGlyph::operator==):
        * platform/graphics/SimpleFontData.cpp: Change font size to be a float, not an int.
        (WebCore::SimpleFontData::SimpleFontData):
        * platform/graphics/SimpleFontData.h: Add new pure virtual methods to the AdditionalFontData interface, to be implemented in SVGFontData.
        (WebCore::SimpleFontData::widthForGlyph): Call widthForSVGGlyph, if we encounter a SVG glyph.
        * platform/graphics/TextRun.h:
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::glyphDataForCharacter):
        (WebCore::WidthIterator::advance):
        * platform/graphics/WidthIterator.h: Store several new members needed for SVG Fonts support (last processed glyph name used for kerning pair lookup)
                                             and a map mapping each character of a text to its arabic-form (if needed, to perform SVG glyph selection for Arabic text).
        (WebCore::WidthIterator::run):
        (WebCore::WidthIterator::runWidthSoFar):
        (WebCore::WidthIterator::lastGlyphName):
        (WebCore::WidthIterator::setLastGlyphName):
        (WebCore::WidthIterator::arabicForms):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Use new scaleEmToUnits free function from FontMetrics.h.
        * platform/graphics/mac/SimpleFontDataMac.mm: Ditto.
        * platform/graphics/win/SimpleFontDataCGWin.cpp: Ditto.
        * rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
        (WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes): Handle UTF-16 surrogate pairs correctly, fixes the previous Acid3 regression.
        * rendering/svg/SVGTextMetrics.cpp:
        (WebCore::SVGTextMetrics::SVGTextMetrics):
        (WebCore::constructTextRun):
        (WebCore::SVGTextMetrics::measureCharacterRange):
        * rendering/svg/SVGTextMetrics.h:
        * rendering/svg/SVGTextRunRenderingContext.cpp: Remove drawTextUsingSVGFont/floatWidthUsingSVGFont/selectionRectForTextUsingSVGFont/offsetForPositionForTextUsingSVGFont.
        (WebCore::firstParentRendererForNonTextNode): Don't assert node() exists, doesn't hold true for generated render objects.
        (WebCore::renderObjectFromRun): Renamed from referencingRenderObjectFromRun.
        (WebCore::SVGTextRunRenderingContext::floatWidthUsingSVGFont): Remove extra "extraCharsAvailable" parameter, now solves via TextRun::charactersLength().
        (WebCore::calculateEmUnitToPixelScaleFactor): Add helper method.
        (WebCore::SVGTextRunRenderingContext::drawSVGGlyphs): Main drawing method, this actually creates/renders Paths.
        (WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Part 1/2 of SVG Glyph selection code.
        * rendering/svg/SVGTextRunRenderingContext.h:
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::hasValidGlyphElement):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::initializeFontData): Changed font size from int to float.
        (WebCore::SVGFontData::widthForSVGGlyph): Lookup a SVGGlyph from a Glyph using the glyph table in SVGFontElement and calculate its width.
        (WebCore::SVGFontData::applySVGGlyphSelection): Part 2/2 of SVG Glyph selection code.
        (WebCore::SVGFontData::fillSVGGlyphPage): Fill GlyphPage using glyphs defined in the SVG Font.
        (WebCore::SVGFontData::fillBMPGlyphs): Moved from the previous fillSVGGlyphPage implementation.
        (WebCore::SVGFontData::fillNonBMPGlyphs): Add non-bmp glyph handling, fixing the Acid3 regression (support using SVGGlyphs for UTF-16 surrogate pairs).
        * svg/SVGFontData.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::registerLigaturesInGlyphCache): Enable ligature registration for the use within GlyphPage.
        (WebCore::SVGFontElement::ensureGlyphCache):
        * svg/SVGGlyphMap.h: Switch to use SurrogatePairTextIterator, and switch glyph table from UChar to UChar32, just like GlyphPage, to handle glyphs from non-BMP correctly.
        (WebCore::SVGGlyphMap::addGlyph): Remove setting isValid, it's not needed anymore and gone.
        (WebCore::SVGGlyphMap::collectGlyphsForString):
        * svg/svgtags.in: Surround vkern in ENABLE_SVG_FONTS block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Sat, 25 Jun 2011 02:42:38 +0000 (02:42 +0000)]
2011-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Replace ";" with space in FEATURE_DEFINES macro
        https://bugs.webkit.org/show_bug.cgi?id=62211

        html.css file doesn't recognize ENABLE_XXX macro because FEATURE_DEFINES macro has ";"
        as separator. So, let the html.css to use new feature macro with space separator.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 25 Jun 2011 02:15:35 +0000 (02:15 +0000)]
2011-06-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        Arm Assembler, Immediate stack offset values truncated to 8 bits for add & sub
        https://bugs.webkit.org/show_bug.cgi?id=63345

        The methods ARMThumbImmediate::getUInt9 and ARMThumbImmediate::getUInt10
        return 9 and 10 bit quantities, therefore changed their return type from
        uint8_t to uint16_t.  Also casted the places where they are used as they
        are currently shifted and used as 7 or 8 bit values.

        These methods are currently used for literals for stack offsets,
        including creating and destroying stack frames.  The prior truncation of
        the upper bits caused stack frames to be too small, thus allowing a
        JIT'ed function to access and overwrite stack space outside of the
        incorrectly sized stack frame.

        * assembler/ARMv7Assembler.h:
        (JSC::ARMThumbImmediate::getUInt9):
        (JSC::ARMThumbImmediate::getUInt10):
        (JSC::ARMv7Assembler::add):
        (JSC::ARMv7Assembler::ldr):
        (JSC::ARMv7Assembler::str):
        (JSC::ARMv7Assembler::sub):
        (JSC::ARMv7Assembler::sub_S):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Ryuan Choi <ryuan.choi@samsung.com>
ryuan.choi@samsung.com [Sat, 25 Jun 2011 01:21:24 +0000 (01:21 +0000)]
2011-06-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove ewk_frame_theme_get/set.
        https://bugs.webkit.org/show_bug.cgi?id=63370

        Remove ewk_frame_theme_get/set to avoid confusion.
        Setting theme on each frame is meaningless and ewk_view_thjeme_set can
        do same thing.

        * ewk/ewk_frame.cpp:
        * ewk/ewk_frame.h:
        * ewk/ewk_view.cpp:
        (ewk_view_theme_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 25 Jun 2011 00:45:00 +0000 (00:45 +0000)]
2011-06-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Drag-and-drop tab in same window makes web process falsely report unresponsiveness
        https://bugs.webkit.org/show_bug.cgi?id=63369
        <rdar://problem/9673120>

        If the view becomes invisible, stop the responsiveness timer, because we might not get any
        messages that will cause it to stop (such as painting notifications since we don't paint
        when we're not visible).

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::viewStateDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Gavin Peters <gavinp@chromium.org>
gavinp@chromium.org [Sat, 25 Jun 2011 00:39:33 +0000 (00:39 +0000)]
2011-06-24  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Darin Adler.

        fix possible race in LinkLoader
        https://bugs.webkit.org/show_bug.cgi?id=63360

        In chromium bug 80729
        http://code.google.com/p/chromium/issues/detail?id=80729 I am
        seeing some kind of double triggering of the timer; I am concerned
        that it is possible that a Link element errors out or succeeds,
        sets a timer, and shortly before the timer is triggered it is
        editted, launches another request.  After that, the first timer
        triggers, zeroing out m_cachedResource.  Then, the second load
        finishes, and *crash*.  If this is the case, this fix should stop
        it.

        No new tests; I haven't reproduced this.  I hope chrome's crash
        telemetry will give good feedback; this crash is occuring many times a
        day so the difference should be obvious.

        * loader/LinkLoader.cpp:
        (WebCore::LinkLoader::LinkLoader):
        (WebCore::LinkLoader::linkLoadTimerFired):
        (WebCore::LinkLoader::linkLoadingErrorTimerFired):
        (WebCore::LinkLoader::notifyFinished):
        * loader/LinkLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 25 Jun 2011 00:16:36 +0000 (00:16 +0000)]
2011-06-24  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
        https://bugs.webkit.org/show_bug.cgi?id=63332
        <rdar://problem/9661650>

        No new tests; Only affects machines with QTKit < 7.6.3 installed.

        Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is non-NULL before passing it into -[QTMovie initWithAttributes:],
        as it is only defined in QTKit >= 7.6.3.  If it is NULL, pass QTSecurityPolicyNoCrossSiteAttribute=YES instead, which has
        the same effect in earlier versions of QTKit as the NoLocalToRemote and NoRemoteToLocal keys.  To avoid ASSERTs when running
        debug builds with earlier versions of QTKit, add a SOFT_LINK_POINTER_OPTIONAL macro to SoftLinking.h and make these keys optional.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
        * platform/mac/SoftLinking.h: Add SOFT_LINK_POINTER_OPTIONAL macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTry to fix Windows build failure.
darin@apple.com [Sat, 25 Jun 2011 00:13:22 +0000 (00:13 +0000)]
Try to fix Windows build failure.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::setFileDescriptorData): Copy string into a local so we
can call charactersWithNullTermination on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sat, 25 Jun 2011 00:11:58 +0000 (00:11 +0000)]
2011-06-24  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        releaseFastMallocFreeMemory doesn't adjust free counts for scavenger
        https://bugs.webkit.org/show_bug.cgi?id=63015

        Added code to adjust class TCMalloc_PageHeap variables free_committed_pages_ and
        min_free_committed_pages_since_last_scavenge_ in ReleaseFreeList().  These
        adjustments are a bug.  These need to reflect the pages that are released
        in ReleaseFreeLsit so that scavenge doesn't try to free that many pages as well.
        Made ReleaseFreeList a member of TCMalloc_PageHeap in the process.  Updated
        Check() and helper method CheckList() to check the number of actual free pages
        with free_committed_pages_.

        The symptom of the problem of the existing code is that the scavenger may
        run unneccesarily without any real work to do, i.e. pages on the free lists.
        The scanvenger would also end up freeing too many pages, that is going below
        the current 528 target free pages.

        Note that the style of the changes was kept consistent with the
        existing style.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::Check):
        (WTF::TCMalloc_PageHeap::CheckList):
        (WTF::TCMalloc_PageHeap::ReleaseFreeList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 25 Jun 2011 00:09:37 +0000 (00:09 +0000)]
2011-06-23  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Remove some unneeded functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=63295

        Removing 7 of the functions in FrameLoader.h is probably a step
        in the right direction.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::handledOnloadEvents):
        Moved the call to stopDeferringEvents in here from FrameLoader.
        * loader/DocumentLoader.h: Ditto.

        * loader/DocumentWriter.h: Fixed a typo.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::setFirstPartyForCookies): Changed this to
        use a non-recursive tree walk instead of recursion.
        (WebCore::FrameLoader::stopAllLoaders): Moved the code from
        stopLoadingSubframes inline, since it's only two lines of code.
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Moved
        the code from markLoadComplete inline, since it's only one line.
        (WebCore::FrameLoader::checkLoadComplete): Changed this to use a
        non-recursive tree walk instead of recursion, eliminating the
        recursiveCheckLoadComplete function completely.
        (WebCore::FrameLoader::handledOnloadEvents): Moved the call to
        stopDeferringEvents into DocumentLoader.

        * loader/FrameLoader.h: Removed unneeded forward declarations,
        and now-unneeded functions setupForReplaceByMIMEType,
        isStopping, isLoadingFromCachedPage, stopLoadingSubframes,
        markLoadComplete, mainReceivedError, and recursiveCheckLoadComplete.
        Also made allChildrenAreComplete private.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        Call DocumentLoader::isStopping so we can remove the function
        from FrameLoader that just calls through. Other call sites were
        using DocumentLoader::isStopping directly.
        (WebCore::MainResourceLoader::didReceiveResponse): Call
        DocumentLoader::setupForReplaceByMIMEType so we can remove the
        function from FrameLoader that just calls through. This was
        the only call site.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::init): Call the
        ResourceLoader::cancelledError function instead of calling
        directly to FrameLoader.

        * loader/ResourceLoader.h: Made response an inline function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Rubber-stamped by Maciej Stachowiak.
ap@apple.com [Sat, 25 Jun 2011 00:03:25 +0000 (00:03 +0000)]
    Rubber-stamped by Maciej Stachowiak.

        REGRESSION (r88984): Infinite recursion in DocumentLoader::detachFromFrame/stopLoading

        No new tests, as there is no known way to reproduce this (but we'll keep investigating, as
        the rollout will re-introduce the older less frequent crash).

        * loader/DocumentLoader.cpp: (WebCore::DocumentLoader::detachFromFrame): Rollout the fix
        for bug 62764.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 23:39:35 +0000 (23:39 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add flexbox and inline-flexbox as possible CSS display values
        https://bugs.webkit.org/show_bug.cgi?id=63361

        * css3/flexbox/display-property-expected.txt: Added.
        * css3/flexbox/display-property.html: Added.
        * css3/flexbox/script-tests/display-property.js: Added.
        (testFlex):
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add flexbox and inline-flexbox as possible CSS display values
        https://bugs.webkit.org/show_bug.cgi?id=63361

        Test: css3/flexbox/display-property.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSValueKeywords.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Anna Cavender <annacc@chromium.org>
hclam@chromium.org [Fri, 24 Jun 2011 23:06:01 +0000 (23:06 +0000)]
2011-06-24  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Loading out-of-band text track files from <track>.
        https://bugs.webkit.org/show_bug.cgi?id=62881

        Uses the src attribute of <track> urls to load out-of-band text track
        files using ThreadableLoader.  Also removes TextTrackPrivateInterface
        (as well as LoadableTextTrackImpl and MutableTextTrackImpl) classes.

        No new tests because feature is hidden behind VIDEO_TRACK feature
        define, which is turned off.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:
        * html/HTMLTrackElement.cpp:
        * html/HTMLTrackElement.h:
        * html/LoadableTextTrack.cpp:
        * html/LoadableTextTrack.h:
        * html/LoadableTextTrackImpl.cpp: Removed.
        * html/LoadableTextTrackImpl.h: Removed.
        * html/MutableTextTrack.cpp:
        * html/MutableTextTrack.h:
        * html/MutableTextTrackImpl.cpp: Removed.
        * html/MutableTextTrackImpl.h: Removed.
        * html/TextTrack.cpp:
        * html/TextTrack.h:
        * html/TextTrackPrivate.h: Removed.
        * platform/track/CueParser.cpp:
        * platform/track/CueParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 24 Jun 2011 22:32:18 +0000 (22:32 +0000)]
2011-06-24  Rob Buis  <rbuis@rim.com>

        Rubber-stamped by Nikolas Zimmermann.

        All pointer-events fail if text has visibility="hidden"
        https://bugs.webkit.org/show_bug.cgi?id=62209

        Do not use writing mode aware code for SVG Text.

        No new tests needed.

        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 22:15:29 +0000 (22:15 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=63343

        These tests were failing since they were introduced in r89687.  The
        layerTreeAsText dump on the iframe document was causing the outer
        layerTreeAsText dump to be affected by font metrics.  Fixed in this
        case by not putting layerTreeAsText output in an element when inside
        an iframe.

        * compositing/rtl/rtl-absolute-overflow-scrolled.html:
        * compositing/rtl/rtl-absolute-overflow.html:
        * compositing/rtl/rtl-absolute.html:
        * compositing/rtl/rtl-fixed-overflow-scrolled.html:
        * compositing/rtl/rtl-fixed-overflow.html:
        * compositing/rtl/rtl-fixed.html:
        * compositing/rtl/rtl-iframe-absolute-expected.txt:
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
        * compositing/rtl/rtl-iframe-fixed-expected.txt:
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
        * compositing/rtl/rtl-iframe-relative-expected.txt:
        * compositing/rtl/rtl-relative.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 22:07:10 +0000 (22:07 +0000)]
2011-06-24  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Darin Adler.

        Change NDEBUG to !LOG_DISABLED macro in databases for logging.
        https://bugs.webkit.org/show_bug.cgi?id=63346

        Changed NDEBUG to !LOG_DISABLED in databases code which involves logging.
        This change resolves also build break in Release build when logging enabled.

        No new tests because there is no new behavior or feature exposed.

        * loader/icon/IconDatabase.cpp: Macro fixes.
        (WebCore::IconDatabase::iconDatabaseSyncThread):
        (WebCore::IconDatabase::syncThreadMainLoop):
        (WebCore::IconDatabase::readFromDatabase):
        (WebCore::IconDatabase::writeToDatabase):
        (WebCore::IconDatabase::cleanupSyncThread):
        * storage/AbstractDatabase.h: Macro fixes.
        * storage/DatabaseTask.cpp: Macro fixes.
        * storage/DatabaseTask.h: Macro fixes.
        * storage/SQLTransaction.cpp: Macro fixes.
        * storage/SQLTransaction.h: Macro fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 22:05:16 +0000 (22:05 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        Pass Strings by const reference to functions
        https://bugs.webkit.org/show_bug.cgi?id=63341

        Note that since Strings hold a RefPtr to StringImpl, passing Strings
        by value isn't horrible, but it does cause ref count churn and using
        const references is more consistent with the rest of the code base.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addHTTPOriginIfNeeded): Rework the code to not
            change the value of the passed in String.
        * loader/FrameLoader.h:
        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::setFileDescriptorData):
        * platform/win/ClipboardUtilitiesWin.h:
        * storage/DatabaseTracker.h:
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::IDBLevelDBBackingStore):
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::IDBSQLiteBackingStore):
        * storage/IDBSQLiteBackingStore.h:
        * storage/chromium/DatabaseTrackerChromium.cpp:
        (WebCore::DatabaseTracker::getOpenDatabases):
        * svg/SVGPaint.cpp:
        (WebCore::SVGPaint::SVGPaint):
        * svg/SVGPaint.h:
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::updateAnimations):
        * svg/animation/SMILTimeContainer.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 24 Jun 2011 22:03:55 +0000 (22:03 +0000)]
2011-06-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Not possible for plug-ins to override the internal PDF viewer
        https://bugs.webkit.org/show_bug.cgi?id=63356
        <rdar://problem/9673382>

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
        (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
        Pass the entire resource response to shouldUseCustomRepresentationForResponse.

        * WebProcess/WebProcess.cpp:
        (WebKit::canPluginHandleResponse):
        Ask for the plug-in path for a plug-in that can handle the given resource response.
        If we fail to send the message, or if the path comes back empty, we assume that there's no plug-in
        that can handle it.

        (WebKit::WebProcess::shouldUseCustomRepresentationForResponse):
        If the response MIME type is in the m_mimeTypesWithCustomRepresentations map, check if there's
        a plug-in that can handle the given response. If that is the case, it should have precedence over
        the custom representation.

        * WebProcess/WebProcess.h:
        Rename shouldUseCustomRepresentationForMIMEType to shouldUseCustomRepresentationForResponse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 24 Jun 2011 21:45:16 +0000 (21:45 +0000)]
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Match other clampTo* functions in style with clampToInteger(float)
        function.
        https://bugs.webkit.org/show_bug.cgi?id=53449

        * wtf/MathExtras.h:
        (clampToInteger):
        (clampToFloat):
        (clampToPositiveInteger):
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Add clamping for CSSPrimitiveValues and SVGInlineText font size.
        https://bugs.webkit.org/show_bug.cgi?id=53449

        Test: svg/text/svg-zoom-large-value.xhtml

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add asserts to detect if the
        number created is valid.
        * css/CSSPrimitiveValue.h: add clamping checks to prevent overflows.
        (WebCore::CSSPrimitiveValue::getFloatValue):
        (WebCore::CSSPrimitiveValue::getIntValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): split into two
        static functions, one specific to CSSStyleSelector and other generic to help
        in clamping font size for other callers like svg text, etc.
        * css/CSSStyleSelector.h:
        * platform/graphics/FontDescription.h: add asserts to detect if the new font
        size is valid.
        (WebCore::FontDescription::setComputedSize):
        (WebCore::FontDescription::setSpecifiedSize):
        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): use the new helper
        from CSSStyleSelector to help in clamping new scaled font size. do not use
        "smart minimum" since svg allows really small unreadable fonts (tested by existing
        layout tests). Document's minimum font size clamp (0 in my case) and harmless epsilon
        check in CSSStyleSelector function should still hold for svg.
2011-06-24  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Tests that font size for svg text zoom is clamped and we do not
        crash on ASSERT(isfinite(s)) in FontDescription.h
        https://bugs.webkit.org/show_bug.cgi?id=53449

        * svg/text/svg-zoom-large-value-expected.txt: Added.
        * svg/text/svg-zoom-large-value.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Fri, 24 Jun 2011 21:22:54 +0000 (21:22 +0000)]
2011-06-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin Adler.

        Remove unsafe static_cast inside the InlineBox hierarchy
        https://bugs.webkit.org/show_bug.cgi?id=63077

        Refactoring only, no new test.

        * rendering/InlineFlowBox.h:
        (WebCore::toInlineFlowBox):
        * rendering/InlineTextBox.h:
        (WebCore::toInlineTextBox):
        Added the proper cast methods to those 2 classes from an InlineBox.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::nextLeafChild):
        (WebCore::InlineBox::prevLeafChild):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::getFlowSpacingLogicalWidth):
        (WebCore::InlineFlowBox::addToLine):
        (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
        (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
        (WebCore::InlineFlowBox::requiresIdeographicBaseline):
        (WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
        (WebCore::InlineFlowBox::computeLogicalBoxHeights):
        (WebCore::InlineFlowBox::placeBoxesInBlockDirection):
        (WebCore::InlineFlowBox::flipLinesInBlockDirection):
        (WebCore::InlineFlowBox::computeOverflow):
        (WebCore::InlineFlowBox::firstLeafChild):
        (WebCore::InlineFlowBox::lastLeafChild):
        (WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
        (WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForBox):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::createLineBoxes):
        (WebCore::RenderBlock::constructLine):
        (WebCore::setLogicalWidthForTextRun):
        (WebCore::computeExpansionForJustifiedText):
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):
        (WebCore::RenderText::positionLineBox):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::ascentAndDescentForBox):
        (WebCore::RootInlineBox::includeFontForBox):
        (WebCore::RootInlineBox::includeGlyphsForBox):
        Replaced the static_cast in those previous call sites with the new cast methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Fri, 24 Jun 2011 20:54:58 +0000 (20:54 +0000)]
2011-06-24  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix.

        Build fix on Linux when using the GStreamer backend.

        No new tests, just a build fix.

        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::keyPressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInclude the directory containing the failing tests in titles of bugs filed from TestF...
aroben@apple.com [Fri, 24 Jun 2011 20:54:23 +0000 (20:54 +0000)]
Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
which tests are failing

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
(longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
that ends in a path separator.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
in the title, first try to include the longest common prefix of the test names, then, if
that's still too long or there's no common prefix, fall back to not including any
information about which tests are failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInclude links to Trac in bugs filed from TestFailures
aroben@apple.com [Fri, 24 Jun 2011 20:53:51 +0000 (20:53 +0000)]
Include links to Trac in bugs filed from TestFailures

Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
Trac for suspect revisions

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
(Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
Trac.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
include a link to Trac for it in the first sentence of the description. Otherwise include a
link to the suspect range after the list of failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 20:46:42 +0000 (20:46 +0000)]
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * WebCore.gypi:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
        (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHost.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Removed.
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Removed.
        * platform/graphics/chromium/cc/CCMainThreadTask.h:
        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThreadTask.h:
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * WebKit.gypi:
        * public/WebWidget.h:
        (WebKit::WebWidget::animate):
        (WebKit::WebWidget::composite):
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::resize):
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::composite):
        (WebKit::WebViewImpl::fullFramePluginZoomLevelChanged):
        (WebKit::WebView::zoomLevelToZoomFactor):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        (WebKit::WebViewImpl::graphicsContext3D):
        * src/WebViewImpl.h:
        * tests/CCLayerTreeHostTest.cpp: Removed.
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):
2011-06-24  Nat Duca  <nduca@chromium.org>

        Unreviewed, rolling out r89694.
        http://trac.webkit.org/changeset/89694
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Test shell still not ready for animate changes.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 24 Jun 2011 20:33:08 +0000 (20:33 +0000)]
2011-06-24  Chris Rogers  <crogers@google.com>

        Unreviewed build fix.

        Fix Chromium Linux Build
        https://bugs.webkit.org/show_bug.cgi?id=63349

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typos introduced in r89696
aroben@apple.com [Fri, 24 Jun 2011 19:56:57 +0000 (19:56 +0000)]
Fix typos introduced in r89696

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
callback, since that's what it expects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Henry Song <hsong@sisa.samsung.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 19:49:28 +0000 (19:49 +0000)]
2011-06-24  Henry Song  <hsong@sisa.samsung.com>

        Reviewed by Martin Robinson.

        Correct _sharedTimer value in SharedTimerEfl.cpp
        https://bugs.webkit.org/show_bug.cgi?id=62380

        SharedTimerEfl.cpp set _sharedTimer = 0 is incorrect in
        timerEvent(), we have observed addNewTimer() can be triggered
        by either inside timerFunction() or others that are not within
        timerFunction().  We have observed the following case:
        1. add a new Timer within timerFunction()
        2. timerFunction returns, set _sharedTimer = 0
        3. addNewTimer() is triggered again within webkit, don't know
           it triggers this.
        4. because at this moment, _sharedTimer == 0, the previous
           registered timer (in step 1) did not get removed.
        5. Now in ecore_timer, there are two timers with same callbacks
        6. From now on, timerFunction() will be called twice back-to-back
           in each ecore_timer loop.
        To correct this, we should set _sharedTimer = 0 before
        timerFunction() so that when addNewTimer() triggered within,
        we have a valid timer object.

        * platform/efl/SharedTimerEfl.cpp:
        (WebCore::timerEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake TestFailures correctly remember whether old-run-webkit-tests exited early
aroben@apple.com [Fri, 24 Jun 2011 19:37:22 +0000 (19:37 +0000)]
Make TestFailures correctly remember whether old-run-webkit-tests exited early

Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
completion after reload

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
(Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
in the PeristentCache, store an object that contains both the number of failures and whether
old-run-webkit-tests exited early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd links to regression ranges in Trac to the TestFailures page
aroben@apple.com [Fri, 24 Jun 2011 19:36:44 +0000 (19:36 +0000)]
Add links to regression ranges in Trac to the TestFailures page

Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
links to regression ranges in Trac

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
(Trac): This new class represents a particular instance of Trac for a single project.
(Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
repository path between the two specified revisions
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController): Added new trac argument.
(ViewController.prototype._displayBuilder): Moved code to create the DOM for the
passed/failed builds from here...
(ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
Trac if there are multiple suspect revisions.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-17 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 19:29:16 +0000 (19:29 +0000)]
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Create CCLayerTreeHost and CCLayerTreeHostImpl, which are the main
        thread and compositor thread halves of a composited view. Communication
        between the two is based on the design used in FileStreamProxy.

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::create):
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::setViewport):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromiumImpl::create):
        (WebCore::LayerRendererChromiumImpl::drawLayersAndPresent):
        (WebCore::LayerRendererChromiumImpl::LayerRendererChromiumImpl):
        (WebCore::LayerRendererChromiumImpl::drawLayersOnMainThread):
        (WebCore::LayerRendererChromiumImplProxy::create):
        (WebCore::LayerRendererChromiumImplProxy::createLayerTreeHostImpl):
        (WebCore::LayerRendererChromiumImplProxy::LayerRendererChromiumImplProxy):
        (WebCore::LayerRendererChromium::createLayerTreeHostImplProxy):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::setShowFPSCounter):
        (WebCore::CCHeadsUpDisplay::setShowPlatformLayerTree):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::currentFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::init):
        (WebCore::CCLayerTreeHost::~CCLayerTreeHost):
        (WebCore::CCLayerTreeHost::beginCommit):
        (WebCore::CCLayerTreeHost::commitComplete):
        (WebCore::CCLayerTreeHost::animateAndLayout):
        (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):
        (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHost::setNeedsRedraw):
        (WebCore::CCLayerTreeHost::updateLayers):
        * platform/graphics/chromium/cc/CCLayerTreeHost.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHost::frameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::create):
        (WebCore::CCLayerTreeHostCommitter::commit):
        * platform/graphics/chromium/cc/CCLayerTreeHostCommitter.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostCommitter::CCLayerTreeHostCommitter):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Added.
        (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
        (WebCore::CCLayerTreeHostImpl::beginCommit):
        (WebCore::CCLayerTreeHostImpl::commitComplete):
        (WebCore::CCLayerTreeHostImpl::drawLayers):
        (WebCore::CCLayerTreeHostImpl::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImpl::setNeedsRedraw):
        * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCThread.cpp.
        (WebCore::CCLayerTreeHostImplClient::~CCLayerTreeHostImplClient):
        (WebCore::CCLayerTreeHostImpl::frameNumber):
        (WebCore::CCLayerTreeHostImpl::sourceFrameNumber):
        (WebCore::CCLayerTreeHostImpl::setSourceFrameNumber):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp: Added.
        (WebCore::CCLayerTreeHostImplProxy::CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::start):
        (WebCore::CCLayerTreeHostImplProxy::~CCLayerTreeHostImplProxy):
        (WebCore::CCLayerTreeHostImplProxy::isStarted):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedraw):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedraw):
        (WebCore::CCLayerTreeHostImplProxy::stop):
        (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::isMainThread):
        (WebCore::CCLayerTreeHostImplProxy::isCCThread):
        (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommit):
        (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
        (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
        * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h: Added.
        (WebCore::CCLayerTreeHostImplProxy::host):
        * platform/graphics/chromium/cc/CCMainThreadTask.h:
        * platform/graphics/chromium/cc/CCThread.cpp:
        (WebCore::CCThread::runLoop):
        * platform/graphics/chromium/cc/CCThreadTask.h:
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        Redirect invalidates and scheduling into compositor when in
        threaded compositing mode. Add stress tests for CCLayerTreeHost.

        * WebKit.gypi:
        * public/WebWidget.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        (WebKit::WebViewImpl::paint):
        (WebKit::WebViewImpl::animateAndLayout):
        (WebKit::WebViewImpl::updateLayers):
        (WebKit::WebViewImpl::composite):
        (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::createLayerTreeHostContext3D):
        (WebKit::WebViewImpl::reallocateRenderer):
        (WebKit::WebViewImpl::updateLayerRendererSettings):
        (WebKit::WebViewImpl::updateLayerRendererViewport):
        * src/WebViewImpl.h:
        * tests/CCLayerTreeHostTest.cpp: Added.
        (WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
        (WTF::CCLayerTreeHostTest::animateAndLayout):
        (WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
        (WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
        (WTF::CCLayerTreeHostTest::commitOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
        (WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTest::updateLayers):
        (WTF::CCLayerTreeHostTest::onBeginTest):
        (WTF::CCLayerTreeHostTest::doEndTest):
        (WTF::CCLayerTreeHostTest::onEndTest):
        (WTF::CCLayerTreeHostTest::runTest):
        (WTF::CCLayerTreeHostTest::testTimeout):
        (WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
        (WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
        (WTF::MockLayerTreeHostClient::animateAndLayout):
        (WTF::MockLayerTreeHostClient::updateLayers):
        (WTF::MockLayerTreeHostCommitter::create):
        (WTF::MockLayerTreeHostCommitter::commit):
        (WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
        (WTF::MockLayerTreeHostImpl::create):
        (WTF::MockLayerTreeHostImpl::beginCommit):
        (WTF::MockLayerTreeHostImpl::commitComplete):
        (WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
        (WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::create):
        (WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
        (WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::MockLayerTreeHost):
        (WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
        (WTF::MockLayerTreeHost::updateLayers):
        (WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
        (WTF::MockLayerTreeHost::beginCommit):
        (WTF::MockLayerTreeHost::commitComplete):
        (WTF::CCLayerTreeHostTest::doBeginTest):
        (WTF::CCLayerTreeHostTest::endTest):
        (WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
        (WTF::CCLayerTreeHostTestShortlived1::beginTest):
        (WTF::CCLayerTreeHostTestShortlived1::afterTest):
        (WTF::TEST_F):
        (WTF::CCLayerTreeHostTestShortlived2::CCLayerTreeHostTestShortlived2):
        (WTF::CCLayerTreeHostTestShortlived2::beginTest):
        (WTF::CCLayerTreeHostTestShortlived2::afterTest):
        (WTF::CCLayerTreeHostTestShortlived3::CCLayerTreeHostTestShortlived3):
        (WTF::CCLayerTreeHostTestShortlived3::beginTest):
        (WTF::CCLayerTreeHostTestShortlived3::afterTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::CCLayerTreeHostTestCommitingWithContinuousRedraw):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::CCLayerTreeHostTestSetNeedsCommit1):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit1::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::CCLayerTreeHostTestSetNeedsCommit2):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsCommit2::afterTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::CCLayerTreeHostTestSetNeedsRedraw):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):
        (WTF::CCLayerTreeHostTestSetNeedsRedraw::afterTest):
        * tests/CCThreadTest.cpp:
        (WebCore::TEST):
2011-05-17  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
        https://bugs.webkit.org/show_bug.cgi?id=58408

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Chris Rogers <crogers@google.com>
crogers@google.com [Fri, 24 Jun 2011 19:20:42 +0000 (19:20 +0000)]
2011-06-24  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Enable Web Audio for Chromium Win
        https://bugs.webkit.org/show_bug.cgi?id=63338

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 19:16:48 +0000 (19:16 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Unreviewed, remove assertion about root layers in RenderLayerBacking.
        https://bugs.webkit.org/show_bug.cgi?id=60741

        This was added in r89687, but somehow is not true on Safari Leopard.
        However, as the tests that were added with that revision are passing
        correctly, the assertion is most likely not correct.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 24 Jun 2011 19:11:28 +0000 (19:11 +0000)]
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Unreviewed: Skipping failing progress-clone.html on win.

        r89682 unskipped fast/dom/HTMLProgressElement/progress-clone.html
        on win, but it should stay skipped because there is no progress
        element on win (bug 49769)

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 24 Jun 2011 18:48:25 +0000 (18:48 +0000)]
2011-06-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Refactor text iterator code respecting surrogate pairs from WidthIterator
        https://bugs.webkit.org/show_bug.cgi?id=63319

        WidthIterator contains a surrogate pair aware text iterator that is needed in other parts of WebCore.
        Refactor the code into its own SurrogatePairAwareTextIterator class. It can be used like this:

        UChar32 character = 0;
        unsigned clusterLength = 0;

        SurrogatePairAwareTextIterator textIterator(myString.characters(), 0, myString.length(), myString.length());
        while (textIterator.consume(character, clusterLength)) {
            // Either clusterLength is 1 and UChar32 fits into a single UChar.
            // Or     clusterLength is 2 and the UChar32 has been computed by combining the high & low surrogate pairs
            ...

            textIterator.advance(clusterLength);
        }

        SVGGlyphMap is the next candidate that wants to make use of SurrogatePairAwareTextIterator.
        Doesn't affect any tests, just refactoring.

        * CMakeLists.txt: Add SurrogatePairAwareTextIterator.* to build.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/SurrogatePairAwareTextIterator.cpp: Copied from platform/graphics/WidthIterator.cpp.
        * platform/graphics/SurrogatePairAwareTextIterator.h: Added.
        (WebCore::SurrogatePairAwareTextIterator::currentCharacter):
        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::advance):
        * platform/graphics/WidthIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix after r89685
aroben@apple.com [Fri, 24 Jun 2011 18:47:14 +0000 (18:47 +0000)]
Mac build fix after r89685

* WebProcess/WebKitMain.cpp: Make a Windows-only #include really be Windows-only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
jberlin@webkit.org [Fri, 24 Jun 2011 18:43:59 +0000 (18:43 +0000)]
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Better solution: this test appears to give different results depending on what other test
is run before it, so just disable it.

* fast/css/font-face-in-shadow-DOM.html: Removed.
* fast/css/font-face-in-shadow-DOM.html-disabled: Copied from fast/css/font-face-in-shadow-DOM.html.
* platform/win-xp/fast/css: Removed.
* platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 18:35:12 +0000 (18:35 +0000)]
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Add a number of composited positioning tests on pages with dir=rtl.
        The reference images are all identical to what the non-composited path
        generates.

        The overflow-scrolled tests on Safari do not generate the right images
        due to bug 63284, but the layer tree is correct so they are not
        skipped.

        * compositing/rtl/rtl-absolute-expected.png: Added.
        * compositing/rtl/rtl-absolute-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-absolute-overflow.html: Added.
        * compositing/rtl/rtl-absolute.html: Added.
        * compositing/rtl/rtl-fixed-expected.png: Added.
        * compositing/rtl/rtl-fixed-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-fixed-overflow.html: Added.
        * compositing/rtl/rtl-fixed.html: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
        * compositing/rtl/rtl-iframe-absolute.html: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
        * compositing/rtl/rtl-iframe-fixed.html: Added.
        * compositing/rtl/rtl-iframe-relative-expected.png: Added.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Added.
        * compositing/rtl/rtl-iframe-relative.html: Added.
        * compositing/rtl/rtl-relative-expected.png: Added.
        * compositing/rtl/rtl-relative-expected.txt: Added.
        * compositing/rtl/rtl-relative.html: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-24  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Fix positioning of the root graphics layer for RTL pages.  The fact
        that the left side of the page is negative for pages with overflow is
        not taken into account when calculating the position.  This negative
        value ends up being double-counted for the root graphics layer (once
        in the position and once in the offset) and it shifts child layers
        into the wrong place.

        Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html
               compositing/rtl/rtl-absolute-overflow.html
               compositing/rtl/rtl-absolute.html
               compositing/rtl/rtl-fixed-overflow-scrolled.html
               compositing/rtl/rtl-fixed-overflow.html
               compositing/rtl/rtl-fixed.html
               compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
               compositing/rtl/rtl-iframe-absolute-overflow.html
               compositing/rtl/rtl-iframe-absolute.html
               compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
               compositing/rtl/rtl-iframe-fixed-overflow.html
               compositing/rtl/rtl-iframe-fixed.html
               compositing/rtl/rtl-iframe-relative.html
               compositing/rtl/rtl-relative.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
jberlin@webkit.org [Fri, 24 Jun 2011 18:24:41 +0000 (18:24 +0000)]
fast/css/font-face-in-shadow-DOM.html is flaky on Chromium, failing on Win XP Debug.
https://bugs.webkit.org/show_bug.cgi?id=63115

Add expected (failing?) results for win-xp to get the bots green.

* platform/win-xp/fast/css: Added.
* platform/win-xp/fast/css/font-face-in-shadow-DOM-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the web process pause dialog look better on Vista/7 and robust against executabl...
aroben@apple.com [Fri, 24 Jun 2011 18:09:14 +0000 (18:09 +0000)]
Make the web process pause dialog look better on Vista/7 and robust against executable renames

Fixes <http://webkit.org/b/63335> Web process pause dialog looks bad on Vista/7

Reviewed by Brian Weinstein.

* WebProcess/WebKitMain.cpp:
(pauseProcessIfNeeded): Moved code to show the pause dialog here from WebKitMain. We now
fetch the executable name using ::GetModuleFileNameW instead of hard-coding it. The string
we pass to ::MessageBoxW no longer has embedded newlines, which improves its appearance on
Vista/7 (which were doing their own wrapping in addition to our newlines). Appearance is
different but fine on XP. Note that the message text now contains the "[_debug].exe" suffix when
referring to the process; that is different from before but seems fine.
(WebKitMain): Call the new function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Fri, 24 Jun 2011 17:52:09 +0000 (17:52 +0000)]
2011-06-24  Matthew Delaney  <mdelaney@apple.com>

        Fixing burning trees from change to tests in https://bugs.webkit.org/show_bug.cgi?id=63327
        Adding new platform specific results since the new layout in the tests changes the render tree spew.
        Pixel tests are still good.

        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Jun 2011 17:45:00 +0000 (17:45 +0000)]
2011-06-24  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Enrica Casucci.

        Add BeforeChildren and AfterChildren to the Position's anchor types
        https://bugs.webkit.org/show_bug.cgi?id=63100

        Added PositionIsBeforeChildren and PositionIsAfterChildren to Position::AnchorType and deployed them in
        firstPositionInNode and lastPositionInNode.

        These new types of positions will let us express the first and the last positions in a non-text node in O(1).

        No new tests because there is no new behavior or feature exposed.

        * dom/Position.cpp:
        (WebCore::Position::Position): Assert that the anchor type is not BeforeChildren and AfterChildren for text nodes.
        (WebCore::Position::containerNode): For BeforeChildren and AfterChildren, the anchor node is the container node.
        (WebCore::Position::computeOffsetInContainerNode): The offset in the container node is 0 for BeforeChildren and
        the offset in the anchor node for AfterChildren.
        (WebCore::Position::offsetForPositionAfterAnchor): Called by deprecatedNode; the anchor type could be AfterChildren.
        (WebCore::Position::parentAnchoredEquivalent): If the anchor node is before or after children, then do the trick
        for table and ignored contents like before or after anchor.
        (WebCore::Position::computeNodeBeforePosition): Returns null for BeforeChildren and returns the last child of
        the anchor node for AfterChildren.
        (WebCore::Position::computeNodeAfterPosition): Returns the first child of the anchor node for BeforeChildren
        (WebCore::Position::atFirstEditingPositionForNode): A position is at the last editing position if the anchor type
        is BeforeChildren, or the anchor type is AfterChildren or AfterAnchor and the anchor doesn't have any children.
        (WebCore::Position::atLastEditingPositionForNode): A position is at the last editing position if the anchor type
        is AfterChildren.
        (WebCore::Position::showAnchorTypeAndOffset): Supports BeforeChildren and AfterChildren.
        * dom/Position.h:
        (WebCore::Position::deprecatedEditingOffset): Returns m_offset if the anchor type is BeforeChildren.
        (WebCore::firstPositionInNode): Returns a position in offset for a text node. Otherwise returns BeforeChildren.
        (WebCore::lastPositionInNode): Returns a position in offset for a text node. Otherwise returns AfterChildren.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::positionOutsideTabSpan): Since the anchor node was a text node,
        the anchor type shouldn't be BeforeChildren or AfterChildren.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::updatePositionForNodeRemoval): Supports BeforeChildren and AfterChildren.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): Calls updatePositionForNodeRemoval on m_downstremEnd
        when its anchor node is removed instead of manually updating the offset; also avoid calling moveToOffset
        on BeforeChildren or AfterChildren position.
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::formatRange): Since lastParagraphInBlockNode is used to insert a placeholder
        after paragraphs below the block is moved into, it needs to be the position after the current last child in
        the block instead of after children in the block; otherwise the position will move to the end of block.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter): Since the container node is never a text for position before/after
        children or before/after anchor, just return null for these anchor types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Fri, 24 Jun 2011 17:37:51 +0000 (17:37 +0000)]
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        * Source/autotools/symbols.filter: Export symbols for GTK.
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Update tests to use internals.{ensureShadowRoot, shadowRoot,
        shadowPseudoId, removeShadowRoot} instead of layoutTestController.

        * fast/dom/HTMLKeygenElement/keygen-expected.txt:
        * fast/dom/HTMLKeygenElement/keygen.html:
        * fast/dom/HTMLMeterElement/meter-clone-expected.txt:
        * fast/dom/HTMLMeterElement/meter-clone.html:
        * fast/dom/HTMLProgressElement/progress-clone-expected.txt:
        * fast/dom/HTMLProgressElement/progress-clone.html:
        * fast/dom/shadow/activeelement-should-be-shadowhost.html:
        * fast/dom/shadow/create-content-element.html:
        * fast/dom/shadow/gc-shadow-expected.txt:
        * fast/dom/shadow/gc-shadow.html:
        * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: shadowRoot of non-element throws now, so verify new behavior.
        * fast/dom/shadow/layout-tests-can-access-shadow.html:
        * fast/dom/shadow/nodetype.html:
        * fast/dom/shadow/tab-order-iframe-and-shadow.html:
        * fast/events/shadow-boundary-crossing.html:
        * fast/forms/resources/common.js:
        (getValidationMessageBubbleNode):
        * fast/html/clone-keygen-expected.txt:
        * fast/html/clone-keygen.html:
        * fast/html/clone-range-expected.txt:
        * fast/html/clone-range.html:
        * fast/html/details-clone.html:
        * fullscreen/video-controls-override-expected.txt:
        * fullscreen/video-controls-override.html:
        * media/audio-controls-do-not-fade-out.html:
        * media/media-controls.js:
        (mediaControlsButtonCoordinates):
        * media/video-controls-in-media-document.html:
        * platform/win/Skipped: shadowRoot and friends now available on win.
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        * WebCore.exp.in: Exports for symbols used by WebCoreTestSupport.
        * testing/Internals.cpp: The new home of shadowRoot and friends.
        (WebCore::Internals::ensureShadowRoot):
        (WebCore::Internals::shadowRoot):
        (WebCore::Internals::removeShadowRoot):
        (WebCore::Internals::shadowPseudoId):
        * testing/Internals.h:
        * testing/Internals.idl:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from Chromium API. These are not
        required any more.

        * public/WebElement.h:
        * src/WebElement.cpp:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow-DOM related methods from GTK DRT API. These are not
        required any more.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from Mac API. These are not
        required any more.

        * DOM/WebDOMOperations.mm:
        * DOM/WebDOMOperationsPrivate.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow-DOM related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow-DOM related methods from Qt DRT API. These are not
        required any more.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-06-24  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove shadow DOM-related methods from WebKit2 API. These are not
        required any more.

        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
        * win/WebKit2.def: Re-exports for symbols used by WebCoreTestSupport.
        * win/WebKit2CFLite.def: Same for Cairo.
2011-06-24  Dominic Cooney   <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert shadow DOM-related tests to use window.internals
        https://bugs.webkit.org/show_bug.cgi?id=61671

        Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
        removeShadowRoot from layoutTestController; these have been
        replaced by equivalents in window.internals instead.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Fri, 24 Jun 2011 16:57:47 +0000 (16:57 +0000)]
2011-06-24  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Change transforms/3d/point-mapping/3d-point-mapping{,-preserve-3d}.html to absolutely position divs
        https://bugs.webkit.org/show_bug.cgi?id=63327

        * transforms/3d/point-mapping/3d-point-mapping-preserve-3d.html:
        * transforms/3d/point-mapping/3d-point-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 16:35:11 +0000 (16:35 +0000)]
2011-06-24  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Refactor creation of primitive values in CSSParser
        https://bugs.webkit.org/show_bug.cgi?id=63270

        Covered by existing tests.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::createPrimitiveNumericValue): Helper method for creating numeric values
            to keep the cast in one place.
        (WebCore::CSSParser::createPrimitiveStringValue): Helper method for creating string values.
        (WebCore::CSSParser::parseValidPrimitive):
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseWCSSInputProperty):
        (WebCore::CSSParser::parsePage):
        (WebCore::CSSParser::parseSizeParameter):
        (WebCore::CSSParser::parseContent):
        (WebCore::CSSParser::parseFillPositionX):
        (WebCore::CSSParser::parseFillPositionY):
        (WebCore::CSSParser::parseFillPositionComponent):
        (WebCore::CSSParser::parseFillSize):
        (WebCore::CSSParser::parseAnimationDelay):
        (WebCore::CSSParser::parseAnimationDuration):
        (WebCore::CSSParser::parseAnimationIterationCount):
        (WebCore::CSSParser::parseAnimationName):
        (WebCore::CSSParser::parseTransformOriginShorthand):
        (WebCore::CSSParser::parseDashboardRegions):
        (WebCore::CSSParser::parseCounterContent):
        (WebCore::CSSParser::parseShape):
        (WebCore::CSSParser::parseFont):
        (WebCore::CSSParser::parseReflect):
        (WebCore::CSSParser::parseBorderRadius):
        (WebCore::CSSParser::parseCounter):
        (WebCore::CSSParser::parseDeprecatedGradient):
        (WebCore::CSSParser::parseLinearGradient):
        (WebCore::CSSParser::parseRadialGradient):
        (WebCore::CSSParser::parseGradientColorStops):
        (WebCore::CSSParser::parseTransform):
        (WebCore::CSSParser::parseTransformOrigin):
        (WebCore::CSSParser::parseTextEmphasisStyle):
        * css/CSSParser.h:
        * css/CSSPrimitiveValueCache.h:
        (WebCore::CSSPrimitiveValueCache::createValue): pass String by const reference

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard...
jberlin@webkit.org [Fri, 24 Jun 2011 16:28:46 +0000 (16:28 +0000)]
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add win-wk2 expected results that match the mac, but not mac-wk2, results so that the test
does not start failing on win-wk2.

* platform/win-wk2/fast/forms: Added.
* platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 16:26:59 +0000 (16:26 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [X11] Do not call NPP_SetWindow with a null window handle on destroy
        https://bugs.webkit.org/show_bug.cgi?id=62981

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard...
jberlin@webkit.org [Fri, 24 Jun 2011 16:09:26 +0000 (16:09 +0000)]
REGRESSION (r89457-r89462): fast/forms/textfield-overflow.html failing on SnowLeopard Intel
Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=63328

Add (failing?) expected results for mac-wk2 to get the bots green.

* platform/mac-wk2/fast/forms/textfield-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 24 Jun 2011 15:59:55 +0000 (15:59 +0000)]
2011-06-24  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Exit immediately if the last condition tested fails.

        Make <video> app cache test exit immediately on failure
        https://bugs.webkit.org/show_bug.cgi?id=63323

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 15:54:10 +0000 (15:54 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add more debug options to compilation
        https://bugs.webkit.org/show_bug.cgi?id=63318

        Add --enable-debug-symbols to enable/disable compilation with
        debug symbols and --enable-debug-features to enable/disable debug
        features. Both options are unconditionally enabled for debug
        builds.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r89657): http/tests/inspector/extensions-headers.html,
jberlin@webkit.org [Fri, 24 Jun 2011 15:43:35 +0000 (15:43 +0000)]
REGRESSION (r89657): http/tests/inspector/extensions-headers.html,
http/tests/inspector/extensions-resources-redirect.html timing out on SnowLeopard Intel
Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=63325

Skip those tests to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 15:42:28 +0000 (15:42 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fix runtime critical warnings in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=63256

        Check whether there's a view widget before trying to use it in
        PlatformScreenGtk. If there isn't a view widget, which is the case
        in WebKit2, try to use the default GdkScreen and monitor.

        * platform/gtk/PlatformScreenGtk.cpp:
        (WebCore::getToplevel): Helper function to get the toplevel
        widget.
        (WebCore::getVisual): Use getToplevel().
        (WebCore::getScreen): Helper funtion to get the screen of a
        widget.
        (WebCore::screenRect): Use getToplevel() and getScreen().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
ossy@webkit.org [Fri, 24 Jun 2011 14:14:48 +0000 (14:14 +0000)]
[Qt][WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=63321

* platform/qt-wk2/Skipped: Skip fast/frames/iframe-plugin-load-remove-document-crash.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Fri, 24 Jun 2011 13:10:31 +0000 (13:10 +0000)]
2011-06-24  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed.
        Remove non-existent items from the qt-wk2 skipped list.

        * platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake run-bindings-tests remove its temporary directories.
ossy@webkit.org [Fri, 24 Jun 2011 12:37:33 +0000 (12:37 +0000)]
Make run-bindings-tests remove its temporary directories.
https://bugs.webkit.org/show_bug.cgi?id=63320

Reviewed by Dirk Schulze.

* Scripts/run-bindings-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Fri, 24 Jun 2011 12:18:18 +0000 (12:18 +0000)]
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Add a flag in Setting so that WebSocket protocols can be switched
        dynamically. The protocol we have implemented so far is based on
        older Hixie-76 specification. A new protocol is being discussed in
        IETF HyBi working group, and I'm planning to implement the new protocol
        behind this Settings flag.

        I will add a method to LayoutTestController which flips this flag in
        a later patch. In this way, we can put tests for both protocols in
        the same place and test implementation for both protocols at the same time.

        This patch only adds a flag. The flag is not used yet, thus there is
        no change in functionality. Therefore, no tests were added.

        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setUseHixie76WebSocketProtocol):
        (WebCore::Settings::useHixie76WebSocketProtocol):
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Make a new flag (Setting::m_useHixie76WebSocketProtocol)
        switchable from WebView and WebPreferences.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setHixie76WebSocketProtocolEnabled:]):
        (-[WebPreferences isHixie76WebSocketProtocolEnabled]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChanged:]):
2011-06-24  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Adam Barth.

        WebSocket: Add run-time flag for new HyBi protocol
        https://bugs.webkit.org/show_bug.cgi?id=60348

        Make a new flag (Setting::m_useHixie76WebSocketProtocol)
        switchable from WebView and WebPreferences.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::setHixie76WebSocketProtocolEnabled):
        (WebPreferences::hixie76WebSocketProtocolEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 24 Jun 2011 12:02:11 +0000 (12:02 +0000)]
2011-06-24  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        Clean up some tests for search cancel buttons.
        https://bugs.webkit.org/show_bug.cgi?id=63121

        - Introduce a function to retrieve a reliable position of a search
          cancel button.
        - Convert two tests to dumpAsText().

        * fast/forms/resources/common.js:
        (searchCancelButtonPosition): Added.
        * fast/forms/search-abs-pos-cancel-button.html: Use searchCancelButtonPosition().
        * fast/forms/search-cancel-button-mouseup.html: Use searchCancelButtonPosition().
        * fast/forms/search-transformed-expected.txt: Added.
        * fast/forms/search-transformed.html:
          - Use searchCancelButtonPosition().
          - Convert to dumpAsText().
        * fast/forms/search-zoomed-expected.txt: Added.
        * fast/forms/search-zoomed.html:
          - Use searchCancelButtonPosition().
          - Convert to dumpAsText().
        * platform/chromium/test_expectation.txt:
          search-transformed.html should pass.
        * platform/chromium-linux/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/search-transformed-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-mac/fast/forms/search-transformed-expected.png: Removed.
        * platform/chromium-win/fast/forms/search-zoomed-expected.png: Removed.
        * platform/chromium-win/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/gtk/fast/forms/search-transformed-expected.png: Removed.
        * platform/gtk/fast/forms/search-transformed-expected.txt: Removed.
        * platform/gtk/fast/forms/search-zoomed-expected.png: Removed.
        * platform/gtk/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/mac-leopard/fast/forms/search-zoomed-expected.png: Removed.
        * platform/mac/fast/forms/search-transformed-expected.png: Removed.
        * platform/mac/fast/forms/search-transformed-expected.txt: Removed.
        * platform/mac/fast/forms/search-zoomed-expected.png: Removed.
        * platform/mac/fast/forms/search-zoomed-expected.txt: Removed.
        * platform/qt/fast/forms/search-transformed-expected.txt: Removed.
        * platform/qt/fast/forms/search-zoomed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 24 Jun 2011 11:52:23 +0000 (11:52 +0000)]
2011-06-24  Kent Tamura  <tkent@chromium.org>

        Remove an JavaScript error in media-controls-clone.html.
        https://bugs.webkit.org/show_bug.cgi?id=63195

        * media/media-controls-clone.html: Remove run() call.
        * platform/chromium-mac/media/media-controls-clone-expected.txt: Remove an error message.
        * platform/chromium-win/media/media-controls-clone-expected.txt: ditto.
        * platform/mac/media/media-controls-clone-expected.txt: ditto.
        * platform/win/media/media-controls-clone-expected.txt: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 24 Jun 2011 11:47:36 +0000 (11:47 +0000)]
2011-06-23  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Shorten DOMWindow URLs in heap profiles.
        https://bugs.webkit.org/show_bug.cgi?id=63238

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype._updateHasChildren):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.isDOMWindow):
        (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotRetainingPathsList.prototype.showNext.pathFound):
        (WebInspector.DetailedHeapshotView.prototype._getHoverAnchor):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup.displayString):
        (WebInspector.DetailedHeapshotView.prototype._showStringContentPopup):
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Fri, 24 Jun 2011 11:18:50 +0000 (11:18 +0000)]
2011-06-24  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: uncommenting chromium devtools tests.

        * platform/chromium/inspector/timeline/timeline-layout-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 24 Jun 2011 11:17:54 +0000 (11:17 +0000)]
2011-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Add ewk_auth.h to EWebKit.h
        https://bugs.webkit.org/show_bug.cgi?id=63311

        * ewk/EWebKit.h: Add ewk_auth.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 24 Jun 2011 10:42:54 +0000 (10:42 +0000)]
2011-06-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
        https://bugs.webkit.org/show_bug.cgi?id=63216

        Deleted m_webViewHost which looks leaked.

        * DumpRenderTree/chromium/TestShell.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::~TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 10:39:29 +0000 (10:39 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: HTML preview should delete old iframe on show().
        https://bugs.webkit.org/show_bug.cgi?id=63170

        * inspector/front-end/ResourceHTMLView.js:
        (WebInspector.ResourceHTMLView.prototype._createIFrame):
        * inspector/front-end/ResourcePreviewView.js:
        (WebInspector.ResourcePreviewView.prototype.contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 24 Jun 2011 10:21:27 +0000 (10:21 +0000)]
2011-06-24  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Convert AnimatedString to SVGAnimatorFactory concept
        https://bugs.webkit.org/show_bug.cgi?id=63296

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGString.

        No new tests added. No change of functionality.

        * CMakeLists.txt: Added new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimatedString.cpp: Added. Animator for SVGString.
        (WebCore::SVGAnimatedStringAnimator::SVGAnimatedStringAnimator):
        (WebCore::SVGAnimatedStringAnimator::constructFromString):
        (WebCore::SVGAnimatedStringAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedStringAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedStringAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedStringAnimator::calculateDistance):
        * svg/SVGAnimatedString.h:
        (WebCore::SVGAnimatedStringAnimator::~SVGAnimatedStringAnimator):
        * svg/SVGAnimatedType.cpp:
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createString):
        (WebCore::SVGAnimatedType::string):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h:
        (WebCore::SVGAnimatorFactory::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Fri, 24 Jun 2011 09:06:32 +0000 (09:06 +0000)]
2011-06-24  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Consider rows being ignored when adding children to tables
        https://bugs.webkit.org/show_bug.cgi?id=62718

        Unskip accessibility test that will be passing from now on.

        * platform/gtk/Skipped: Unskipped passing test.
2011-06-24  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Consider rows being ignored when adding children to tables
        https://bugs.webkit.org/show_bug.cgi?id=62718

        Hide row objects in tables in GTK's accessibility wrapper.

        This is a different approach in the way WebCore's accessible
        rows are exposed to assistive technologies in the GTK port,
        since from now on those objects are kept in WebCore (they do not
        declare to ignore accessibility) and just bypassed in the mapping
        to ATK, allowing to hide them in the ATK hierarchy while, at the
        same time, keeping them internally to be able to provide enough
        information to determine tables related information, such as rows
        counting or finding an cell for specific coordinates.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        Do not ignore accessibility for table rows here.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_parent): Bypass rows when needed.
        (getNChildrenForTable): New, find the number of children for a
        table, which will be the addition of all cells for its rows.
        (webkit_accessible_get_n_children): Call to getNChildrenForTable
        for accessibility tables if needed.
        (getChildForTable): New, bypass rows when needed, retrieving
        cells as if they were direct children for tables.
        (webkit_accessible_ref_child): Call to refChildForTable if needed.
        (getIndexInParentForCellInRow): New, get the index for a given
        cell in its parent table, considering other rows' cells.
        (webkit_accessible_get_index_in_parent): Call to
        getIndexInParentForCellInRow if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 24 Jun 2011 08:43:28 +0000 (08:43 +0000)]
2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extension panel iframes do not span entire panel client area
        https://bugs.webkit.org/show_bug.cgi?id=63165

        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        (WebInspector.ExtensionServer.prototype.createClientIframe):
        * inspector/front-end/inspector.css:
        (iframe.extension):
        (iframe.panel.extension):

2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: extension panel iframes do not span entire panel client area
        https://bugs.webkit.org/show_bug.cgi?id=63165

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.showPanel):
        ():
        * http/tests/inspector/inspector-test.js:
        ():
        * http/tests/inspector/resources/extension-main.html:
        * http/tests/inspector/resources/extension-main.js:
        (dumpObject):
        (dumpArray):
        (evaluateOnFrontend.callbackWrapper):
        (evaluateOnFrontend):
        ():
        * http/tests/inspector/resources/extension-panel.html:
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions-expected.txt:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 08:25:50 +0000 (08:25 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Darin Fisher.

        Web Inspector: [Chromium] Successfully prefetched page shows up as an error in console
        https://bugs.webkit.org/show_bug.cgi?id=62396

        * public/WebURLError.h:
        (WebKit::WebURLError::WebURLError):
        * src/WebURLError.cpp:
        (WebKit::WebURLError::operator=):
        (WebKit::WebURLError::operator ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 David Grogan <dgrogan@chromium.org>
pfeldman@chromium.org [Fri, 24 Jun 2011 08:24:16 +0000 (08:24 +0000)]
2011-06-24  David Grogan  <dgrogan@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION r86838] line numbers do not scroll when script paused
        https://bugs.webkit.org/show_bug.cgi?id=61653

        roll out r86838

        No new tests - refactoring.

        * dom/Document.h:
        * dom/EventQueue.cpp:
        (WebCore::EventQueueTimer::EventQueueTimer):
        (WebCore::EventQueueTimer::fired):
        (WebCore::EventQueue::create):
        (WebCore::EventQueue::EventQueue):
        (WebCore::EventQueue::~EventQueue):
        (WebCore::EventQueue::enqueueEvent):
        (WebCore::EventQueue::cancelEvent):
        (WebCore::EventQueue::cancelQueuedEvents):
        (WebCore::EventQueue::pendingEventTimerFired):
        (WebCore::EventQueue::dispatchEvent):
        * dom/EventQueue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 24 Jun 2011 08:02:11 +0000 (08:02 +0000)]
2011-06-24  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [refactoring] extension tests: replace dispatchOnFrontend with a more generic evaluateOnFrontend()
        https://bugs.webkit.org/show_bug.cgi?id=63160

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest._replyToExtension):
        (initialize_ExtensionsTest):
        * http/tests/inspector/resources/extension-main.html:
        * http/tests/inspector/resources/extension-main.js:
        (onError):
        (onTestsDone):
        * inspector/extensions/extensions-audits-tests.js:
        (extension_runAudits):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        * inspector/extensions/extensions-events.html:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 07:43:38 +0000 (07:43 +0000)]
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * icu/unicode/uscript.h: Removed.
        * wtf/unicode/ScriptCodesFromICU.h: Removed.
        * wtf/unicode/brew/UnicodeBrew.h:
        * wtf/unicode/glib/UnicodeGLib.h:
        * wtf/unicode/icu/UnicodeIcu.h:
        * wtf/unicode/qt4/UnicodeQt4.h:
        * wtf/unicode/wince/UnicodeWinCE.h:
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * icu/unicode/uscript.h: Removed.
2011-06-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89594.
        http://trac.webkit.org/changeset/89594
        https://bugs.webkit.org/show_bug.cgi?id=63316

        It broke 5 tests on the Qt bot (Requested by Ossy_DC on
        #webkit).

        * WebCore.exp.in:
        * icu/unicode/uscript.h:
        * page/Settings.cpp:
        (WebCore::Settings::setStandardFontFamily):
        (WebCore::Settings::setFixedFontFamily):
        (WebCore::Settings::setSerifFontFamily):
        (WebCore::Settings::setSansSerifFontFamily):
        (WebCore::Settings::setCursiveFontFamily):
        (WebCore::Settings::setFantasyFontFamily):
        * page/Settings.h:
        (WebCore::Settings::standardFontFamily):
        (WebCore::Settings::fixedFontFamily):
        (WebCore::Settings::serifFontFamily):
        (WebCore::Settings::sansSerifFontFamily):
        (WebCore::Settings::cursiveFontFamily):
        (WebCore::Settings::fantasyFontFamily):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 24 Jun 2011 07:09:35 +0000 (07:09 +0000)]
2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK build.

        * WebKitTestRunner/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 24 Jun 2011 06:43:34 +0000 (06:43 +0000)]
2011-06-23  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        Pass Strings by const reference in bindings code
        https://bugs.webkit.org/show_bug.cgi?id=63302

        Note that since Strings hold a RefPtr to StringImpl, passing Strings
        by value isn't horrible, but it does cause ref count churn and using
        const references is more consistent with the rest of the code base.

        * bindings/generic/BindingSecurity.h:
        (WebCore::::allowSettingFrameSrcToJavascriptUrl):
        (WebCore::::allowSettingSrcToJavascriptURL):
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneSerializer::serialize):
        (WebCore::SerializedScriptValue::create):
        * bindings/js/SerializedScriptValue.h:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:
        * bindings/v8/V8Binding.h:
        (WebCore::V8ParameterBase::setString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 24 Jun 2011 05:42:25 +0000 (05:42 +0000)]
2011-06-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Web Inspector: provide context menu item for enabling native worker inspection
        https://bugs.webkit.org/show_bug.cgi?id=63258

        Added context menu checkbox item that allows to enable inspection of
        native workers. The value will be persisted as other inspector settings
        and will be restored after frontend/breowser reopening.

        * inspector/Inspector.json:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.cpp:
        (WebCore::InspectorWorkerAgent::setFrontend):
        (WebCore::InspectorWorkerAgent::restore):
        (WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
        * inspector/InspectorWorkerAgent.h:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.reset):
        (WebInspector.ScriptsPanel.prototype._toggleFormatSourceFiles):
        (WebInspector.ScriptsPanel.prototype._contextMenu.enableWorkerInspection):
        (WebInspector.ScriptsPanel.prototype._contextMenu):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        * inspector/front-end/inspector.js:
        (WebInspector.didCreateWorker):
        (WebInspector.didDestroyWorker):
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
2011-06-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Web Inspector: provide context menu item for enabling native worker inspection
        https://bugs.webkit.org/show_bug.cgi?id=63258

        * src/js/DevTools.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Jun 2011 05:30:29 +0000 (05:30 +0000)]
2011-06-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Need to turn off default animations for anchorPointZ in PlatformCALayer
        https://bugs.webkit.org/show_bug.cgi?id=63159

        When the z-component of transform-origin changed, we ran an implicit
        animation of anchorPointZ on the CALayer. Turn this off.

        Test: transforms/3d/general/transform-origin-z-change.html

        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        (nullActionsDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 24 Jun 2011 01:53:29 +0000 (01:53 +0000)]
2011-06-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Limit WebGL internal drawingBuffer size to 4k x 4k
        https://bugs.webkit.org/show_bug.cgi?id=63304

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::reshape): Limit drawing buffer size to 4k x 4k.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 24 Jun 2011 01:35:30 +0000 (01:35 +0000)]
2011-06-20  MORITA Hajime <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [ShadowContentElement] should layout child whitespace between span.
        https://bugs.webkit.org/show_bug.cgi?id=62202

        - Added a new test case.
        - Updated expectations, which missed necessary RnederText objects.

        * platform/chromium-win/fast/html/details-add-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-add-details-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-no-summary4-expected.txt:
        * platform/chromium-win/fast/html/details-open-javascript-expected.txt:
        * platform/chromium-win/fast/html/details-open2-expected.txt:
        * platform/chromium-win/fast/html/details-open4-expected.txt:
        * platform/chromium-win/fast/html/details-remove-child-2-expected.txt:
        * platform/chromium-win/fast/html/details-replace-text-expected.txt:
        * platform/gtk/fast/html/details-add-child-2-expected.txt:
        * platform/gtk/fast/html/details-add-details-child-2-expected.txt:
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/gtk/fast/html/details-remove-child-2-expected.txt:
        * platform/gtk/fast/html/details-replace-text-expected.txt:
        * platform/mac/fast/html/details-add-child-2-expected.txt:
        * platform/mac/fast/html/details-add-details-child-2-expected.txt:
        * platform/mac/fast/html/details-no-summary4-expected.txt:
        * platform/mac/fast/html/details-open-javascript-expected.txt:
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-open4-expected.txt:
        * platform/mac/fast/html/details-remove-child-2-expected.txt:
        * platform/mac/fast/html/details-replace-text-expected.txt:
        * platform/qt/fast/html/details-add-child-2-expected.txt:
        * platform/qt/fast/html/details-add-details-child-2-expected.txt:
        * platform/qt/fast/html/details-no-summary4-expected.txt:
        * platform/qt/fast/html/details-open-javascript-expected.txt:
        * platform/qt/fast/html/details-open2-expected.txt:
        * platform/qt/fast/html/details-open4-expected.txt:
        * platform/qt/fast/html/details-remove-child-2-expected.txt:
        * platform/qt/fast/html/details-replace-text-expected.txt:
        * fast/dom/shadow/create-content-element-expected.txt: Added.
        * fast/dom/shadow/create-content-element.html: Added.
2011-06-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [ShadowContentElement] should layout child whitespace between span.
        https://bugs.webkit.org/show_bug.cgi?id=62202

        NodeRenderingContext::nextRenderer() and previousRenderer()
        ignored forwarded content tree hierarchies and used render-object
        hierarchies instead, that caused some wrong Text node rendering.

        This change uses ShadowContentElement::m_inclusions for the lookup.
        In this way, these methods can reflect hierarchies of forward light tree.

        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext):
        (WebCore::nextRendererOf): Added. This traverses content element's children for searching neighboring renderer.
        (WebCore::previousRendererOf): Added. This traverses content element's children for searching neighboring renderer.
        (WebCore::NodeRenderingContext::nextRenderer):
        (WebCore::NodeRenderingContext::previousRenderer):
        * dom/NodeRenderingContext.h:
        * dom/ShadowContentElement.h:
        (ShadowContentElement::inclusionIndexOf): Added.
        * dom/ShadowContentSelector.cpp:
        (WebCore::ShadowContentSelector::activeElement):
        * dom/ShadowContentSelector.h:
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::activeContentElement):
        * dom/ShadowRoot.h:
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation): Fixed an apparent bug introduced at r89230.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>
ryuan.choi@samsung.com [Fri, 24 Jun 2011 01:22:33 +0000 (01:22 +0000)]
2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed, add myself as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 24 Jun 2011 01:17:38 +0000 (01:17 +0000)]
2011-05-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Fix ownership of PlatformImage for ImageLayerChromiums
        https://bugs.webkit.org/show_bug.cgi?id=61099

        For a composited image, both the ImageLayerChromium and its associated LayerTilerChromium need access to a
        PlatformImage - the ImageLayerChromium has to update the PlatformImage's contents and the LayerTilerChromium has
        to upload pixels from it.  This patch makes the ImageLayerTextureUpdater have exclusive ownership of the
        PlatformImage and moves ownership of the LayerTextureUpdater from the LayerTilerChromium to the owner of the
        tiler.  The updater is passed in as a parameter to the relevant tiler calls.

        Patch also fixes a number of minor style issues (missing explicit keyword on constructor, etc).

        Refactor only, no new tests.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerPainter::create):
        (WebCore::ContentLayerPainter::ContentLayerPainter):
        (WebCore::ContentLayerChromium::paintContentsIfDirty):
        (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
        (WebCore::ContentLayerChromium::draw):
        (WebCore::ContentLayerChromium::createTilerIfNeeded):
        (WebCore::ContentLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/ContentLayerChromium.h:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::create):
        (WebCore::ImageLayerTextureUpdater::updateFromImage):
        (WebCore::ImageLayerTextureUpdater::imageSize):
        (WebCore::ImageLayerTextureUpdater::ImageLayerTextureUpdater):
        (WebCore::ImageLayerChromium::~ImageLayerChromium):
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        (WebCore::ImageLayerChromium::updateCompositorResources):
        (WebCore::ImageLayerChromium::setLayerRenderer):
        (WebCore::ImageLayerChromium::createTextureUpdaterIfNeeded):
        (WebCore::ImageLayerChromium::layerBounds):
        * platform/graphics/chromium/ImageLayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::drawRootLayer):
        (WebCore::LayerRendererChromium::updateLayers):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTextureUpdater.h:
        (WebCore::LayerTextureUpdater::LayerTextureUpdater):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
        (WebCore::LayerTextureUpdaterBitmap::create):
        (WebCore::LayerTextureUpdaterSkPicture::create):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        * platform/graphics/chromium/LayerTilerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Fri, 24 Jun 2011 01:11:29 +0000 (01:11 +0000)]
2011-06-23  Nat Duca  <nduca@chromium.org>

        Unreviewed, add myself as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 00:59:47 +0000 (00:59 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        Unreviewed, rolling out r89632 and r89640.
        http://trac.webkit.org/changeset/89632
        http://trac.webkit.org/changeset/89640
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Breaks ancestor-overflow-change unexpectedly

        * compositing/rtl/rtl-absolute-expected.png: Removed.
        * compositing/rtl/rtl-absolute-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Removed.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-absolute-overflow.html: Removed.
        * compositing/rtl/rtl-absolute.html: Removed.
        * compositing/rtl/rtl-fixed-expected.png: Removed.
        * compositing/rtl/rtl-fixed-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Removed.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-fixed-overflow.html: Removed.
        * compositing/rtl/rtl-fixed.html: Removed.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Removed.
        * compositing/rtl/rtl-iframe-absolute.html: Removed.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Removed.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Removed.
        * compositing/rtl/rtl-iframe-fixed.html: Removed.
        * compositing/rtl/rtl-iframe-relative-expected.png: Removed.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
        * compositing/rtl/rtl-iframe-relative.html: Removed.
        * compositing/rtl/rtl-relative-expected.png: Removed.
        * compositing/rtl/rtl-relative-expected.txt: Removed.
        * compositing/rtl/rtl-relative.html: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-23  Adrienne Walker  <enne@google.com>

        Unreviewed, rolling out r89632 and r89640.
        http://trac.webkit.org/changeset/89632
        http://trac.webkit.org/changeset/89640
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Breaks ancestor-overflow-change unexpectedly

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Wyatt Carss <wcarss@chromium.org>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:51:20 +0000 (00:51 +0000)]
2011-06-23  Wyatt Carss  <wcarss@chromium.org>

        Reviewed by Ryosuke Niwa.

        convert editing/deleting/5026848-1.html to dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=63289

        Renamed editing/deleting/5026848* to editing/deleting/delete-across-editable-content-boundaries*,
        and converted editing/deleting/delete-across-editable-content-boundaries-1 to a dump-as-markup test.
        Removed old png/txt test results, and added new result. Also included radr number.

        * editing/deleting/delete-across-editable-content-boundaries-1.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-1-expected.txt: Added.
        * editing/deleting/delete-across-editable-content-boundaries-2.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-2-expected.txt: Added.
        * editing/deleting/delete-across-editable-content-boundaries-3.html: Added.
        * editing/deleting/delete-across-editable-content-boundaries-3-expected.txt: Added.
        * editing/deleting/5026848-1.html: Removed.
        * editing/deleting/5026848-2.html: Removed.
        * editing/deleting/5026848-2-expected.txt: Removed.
        * editing/deleting/5026848-3.html: Removed.
        * editing/deleting/5026848-3-expected.txt: Removed.
        * platform/chromium-linux/editing/deleting/5026848-1-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5026848-1-expected.png: Removed.
        * platform/chromium-win/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/gtk/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/5026848-1-expected.png: Removed.
        * platform/mac/editing/deleting/5026848-1-expected.png: Removed.
        * platform/mac/editing/deleting/5026848-1-expected.txt: Removed.
        * platform/qt/editing/deleting/5026848-1-expected.png: Removed.
        * platform/qt/editing/deleting/5026848-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:40:18 +0000 (00:40 +0000)]
2011-06-23  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        DFG non-speculative JIT should have obvious optimizations for GetById and GetByVal
        https://bugs.webkit.org/show_bug.cgi?id=63173

        * dfg/DFGJITCodeGenerator.cpp:
        (JSC::DFG::JITCodeGenerator::cachedGetById):
        * dfg/DFGJITCodeGenerator.h:
        * dfg/DFGNonSpeculativeJIT.cpp:
        (JSC::DFG::NonSpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 24 Jun 2011 00:33:42 +0000 (00:33 +0000)]
2011-06-23  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: move http locking code into manager
        https://bugs.webkit.org/show_bug.cgi?id=63103

        * Scripts/webkitpy/layout_tests/layout_package/manager.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Qt again.
oliver@apple.com [Fri, 24 Jun 2011 00:28:54 +0000 (00:28 +0000)]
Fix Qt again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 24 Jun 2011 00:22:13 +0000 (00:22 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        [chromium] Unreviewed, mark a few tests failing on OSX after r89632.
        https://bugs.webkit.org/show_bug.cgi?id=60741

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 24 Jun 2011 00:19:15 +0000 (00:19 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        GTK Rebaseline after r89627.

        * platform/gtk/editing/selection/extend-inside-transforms-backward-expected.png: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-forward-expected.png: Added.
        * platform/gtk/editing/selection/extend-inside-transforms-forward-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Qt Build
oliver@apple.com [Fri, 24 Jun 2011 00:18:23 +0000 (00:18 +0000)]
Fix Qt Build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=63298
slewis@apple.com [Fri, 24 Jun 2011 00:16:47 +0000 (00:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63298
Replace Malloc with FastMalloc to match the rest of wtf.

Reviewed by Darin Adler.

* wtf/BlockStack.h:
(WTF::::~BlockStack):
(WTF::::grow):
(WTF::::shrink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWKTR: eventSender.keyDown is unimplemented
jberlin@webkit.org [Fri, 24 Jun 2011 00:15:26 +0000 (00:15 +0000)]
WKTR: eventSender.keyDown is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=57515

Add another test that uses eventSender.keyDown to the mac-wk2 skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 John Bates <jbates@google.com>
commit-queue@webkit.org [Fri, 24 Jun 2011 00:11:51 +0000 (00:11 +0000)]
2011-06-23  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        Fix latch deadlock when GPU process crashes or context is lost.
        https://bugs.webkit.org/show_bug.cgi?id=63189
        The main bug fix is to only set/wait latches if the child context has no errors.
        Additionally, the LayerChromium classes needed to be modified to not continue drawing when
        their corresponding contexts have errors. Otherwise, they would draw with invalid texture ids.

        Test: open particles WebGL demo in chrome, kill GPU process from Task Manager; observe no deadlock.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::isCompositorContextLost):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::drawsContent):
        (WebCore::WebGLLayerChromium::updateCompositorResources):
        (WebCore::WebGLLayerChromium::setContext):
        * platform/graphics/chromium/WebGLLayerChromium.h:
        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::drawsContent):
        * platform/graphics/chromium/Canvas2DLayerChromium.h:
2011-06-23  John Bates  <jbates@google.com>

        Reviewed by James Robinson.

        Fix latch deadlock when GPU process crashes or context is lost
        https://bugs.webkit.org/show_bug.cgi?id=63189

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Thu, 23 Jun 2011 23:47:39 +0000 (23:47 +0000)]
2011-06-23  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Red and Blue channels are swapped in images with accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=61442

        We were uploading BGRA pixels into RGBA textures and swapping the components in the pixel shader.
        This strategy does not work with accelerated drawing because we are directly rendering to the texture, not uploading pixels.
        This patch uses BGRA textures if available. If not it falls back to the original scheme of swapping the components in the pixel shader.

        Tests: compositing/color-matching/image-color-matching.html (existing)

        * WebCore.gypi:
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerTextureUpdater::sampledTexelFormat):
        (WebCore::ImageLayerTextureUpdater::updateTextureRect):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::skiaContext):
        (WebCore::LayerRendererChromium::tilerProgram):
        (WebCore::LayerRendererChromium::tilerProgramSwizzle):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/LayerTexture.h:
        (WebCore::LayerTexture::format):
        * platform/graphics/chromium/LayerTextureSubImage.cpp:
        (WebCore::LayerTextureSubImage::upload):
        (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
        (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
        * platform/graphics/chromium/LayerTextureSubImage.h:
        * platform/graphics/chromium/LayerTextureUpdater.h:
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
        (WebCore::LayerTextureUpdaterBitmap::sampledTexelFormat):
        (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):
        (WebCore::LayerTextureUpdaterSkPicture::sampledTexelFormat):
        (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
        * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::updateRect):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::growLayerToContain):
        (WebCore::LayerTilerChromium::drawTiles):
        (WebCore::LayerTilerChromium::drawTexturedQuad):
        * platform/graphics/chromium/LayerTilerChromium.h:
        * platform/graphics/chromium/PlatformColor.h: Added.
        (WebCore::PlatformColor::format):
        (WebCore::PlatformColor::bestTextureFormat):
        (WebCore::PlatformColor::sameComponentOrder):
        * platform/graphics/chromium/ShaderChromium.cpp:
        (WebCore::FragmentShaderRGBATexSwizzleAlpha::getShaderString):
        * platform/graphics/chromium/ShaderChromium.h:
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt build-fix: remove warning that no other platform appears to use.
oliver@apple.com [Thu, 23 Jun 2011 23:19:45 +0000 (23:19 +0000)]
Qt build-fix: remove warning that no other platform appears to use.
Someone can add it back if they really feel it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 23 Jun 2011 23:13:55 +0000 (23:13 +0000)]
2011-06-23  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Add a number of composited positioning tests on pages with dir=rtl.
        The reference images are all identical to what the non-composited path
        generates.

        The overflow-scrolled tests on Safari do not generate the right images
        due to bug 63284, but the layer tree is correct so they are not
        skipped.

        * compositing/rtl/rtl-absolute-expected.png: Added.
        * compositing/rtl/rtl-absolute-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-absolute-overflow.html: Added.
        * compositing/rtl/rtl-absolute.html: Added.
        * compositing/rtl/rtl-fixed-expected.png: Added.
        * compositing/rtl/rtl-fixed-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-fixed-overflow.html: Added.
        * compositing/rtl/rtl-fixed.html: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-absolute-overflow.html: Added.
        * compositing/rtl/rtl-iframe-absolute.html: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html: Added.
        * compositing/rtl/rtl-iframe-fixed-overflow.html: Added.
        * compositing/rtl/rtl-iframe-fixed.html: Added.
        * compositing/rtl/rtl-iframe-relative-expected.png: Added.
        * compositing/rtl/rtl-iframe-relative-expected.txt: Added.
        * compositing/rtl/rtl-iframe-relative.html: Added.
        * compositing/rtl/rtl-relative-expected.png: Added.
        * compositing/rtl/rtl-relative-expected.txt: Added.
        * compositing/rtl/rtl-relative.html: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.png: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled-expected.txt: Added.
        * compositing/rtlclipping/rtl-absolute-overflow-scrolled.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/Skipped:
2011-06-23  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Incorrect RenderLayer transforms on overflow RTL pages
        https://bugs.webkit.org/show_bug.cgi?id=60741

        Fix positioning of the root graphics layer for RTL pages.  The fact
        that the left side of the page is negative for pages with overflow is
        not taken into account when calculating the position.  This negative
        value ends up being double-counted for the root graphics layer (once
        in the position and once in the offset) and it shifts child layers
        into the wrong place.

        Tests: compositing/rtl/rtl-absolute-overflow-scrolled.html
               compositing/rtl/rtl-absolute-overflow.html
               compositing/rtl/rtl-absolute.html
               compositing/rtl/rtl-fixed-overflow-scrolled.html
               compositing/rtl/rtl-fixed-overflow.html
               compositing/rtl/rtl-fixed.html
               compositing/rtl/rtl-iframe-absolute-overflow-scrolled.html
               compositing/rtl/rtl-iframe-absolute-overflow.html
               compositing/rtl/rtl-iframe-absolute.html
               compositing/rtl/rtl-iframe-fixed-overflow-scrolled.html
               compositing/rtl/rtl-iframe-fixed-overflow.html
               compositing/rtl/rtl-iframe-fixed.html
               compositing/rtl/rtl-iframe-relative.html
               compositing/rtl/rtl-relative.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocompositing/tiling/huge-layer* flakey
jberlin@webkit.org [Thu, 23 Jun 2011 23:00:01 +0000 (23:00 +0000)]
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests have been flaking on multiple platforms, so disable the tests in order to get
the bots green.

* compositing/tiling/huge-layer-add-remove-child.html: Removed.
* compositing/tiling/huge-layer-add-remove-child.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-add-remove-child.html.
* compositing/tiling/huge-layer-img.html: Removed.
* compositing/tiling/huge-layer-img.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-img.html.
* compositing/tiling/huge-layer-resize.html: Removed.
* compositing/tiling/huge-layer-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-resize.html.
* compositing/tiling/huge-layer-with-layer-children-resize.html: Removed.
* compositing/tiling/huge-layer-with-layer-children-resize.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children-resize.html.
* compositing/tiling/huge-layer-with-layer-children.html: Removed.
* compositing/tiling/huge-layer-with-layer-children.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer-with-layer-children.html.
* compositing/tiling/huge-layer.html: Removed.
* compositing/tiling/huge-layer.html-disabled: Copied from LayoutTests/compositing/tiling/huge-layer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 23 Jun 2011 22:47:04 +0000 (22:47 +0000)]
2011-06-23  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add the ability to dynamically modify linked call sites
        https://bugs.webkit.org/show_bug.cgi?id=63291

        Add JITWriteBarrier as a writebarrier class that allows
        reading and writing directly into the code stream.

        This required adding logic to all the assemblers to allow
        us to read values back out of the instruction stream.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * assembler/ARMAssembler.h:
        (JSC::ARMAssembler::readPointer):
        * assembler/ARMv7Assembler.h:
        (JSC::ARMv7Assembler::readPointer):
        (JSC::ARMv7Assembler::readInt32):
        (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmFirst):
        (JSC::ARMv7Assembler::decodeTwoWordOp5i6Imm4Reg4EncodedImmSecond):
        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::readPointer):
        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::readInt32):
        (JSC::MIPSAssembler::readPointer):
        * assembler/MacroAssemblerCodeRef.h:
        (JSC::MacroAssemblerCodePtr::operator!):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::readPCrelativeAddress):
        (JSC::SH4Assembler::readPointer):
        (JSC::SH4Assembler::readInt32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::readPointer):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        (JSC::MethodCallLinkInfo::seenOnce):
        (JSC::MethodCallLinkInfo::setSeen):
        * heap/MarkStack.h:
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        (JSC::JIT::linkCall):
        (JSC::JIT::linkConstruct):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::patchMethodCallProto):
        * jit/JITPropertyAccess32_64.cpp:
        * jit/JITWriteBarrier.h: Added.
        (JSC::JITWriteBarrierBase::operator UnspecifiedBoolType*):
        (JSC::JITWriteBarrierBase::operator!):
        (JSC::JITWriteBarrierBase::setFlagOnBarrier):
        (JSC::JITWriteBarrierBase::isFlagged):
        (JSC::JITWriteBarrierBase::setLocation):
        (JSC::JITWriteBarrierBase::location):
        (JSC::JITWriteBarrierBase::JITWriteBarrierBase):
        (JSC::JITWriteBarrierBase::set):
        (JSC::JITWriteBarrierBase::get):
        (JSC::JITWriteBarrier::JITWriteBarrier):
        (JSC::JITWriteBarrier::set):
        (JSC::JITWriteBarrier::get):
        (JSC::MarkStack::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocompositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel...
jberlin@webkit.org [Thu, 23 Jun 2011 22:35:48 +0000 (22:35 +0000)]
compositing/iframes/invisible-nested-iframe-show.html failing on SnowLeopard Intel Release
(WebKit2 Tests) since introduction.
https://bugs.webkit.org/show_bug.cgi?id=59864

Update the mac-wk2 results to contain the transform line and get the bots green.

* platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 22:30:25 +0000 (22:30 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 23 Jun 2011 22:20:57 +0000 (22:20 +0000)]
2011-06-23  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Simon Fraser.

        Add a test for vertical caret movements inside transform
        https://bugs.webkit.org/show_bug.cgi?id=62834

        Add regression tests for vertical caret movements inside rotated contents.

        * editing/selection/extend-inside-transforms-backward.html: Added.
        * editing/selection/extend-inside-transforms-forward.html: Added.
        * platform/chromium/test_expectations.txt: Added test expectations to keep bots green
        until we rebaseline these tests on Chromium.
        * platform/mac/editing/selection/extend-inside-transforms-backward-expected.png: Added.
        * platform/mac/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
        * platform/mac/editing/selection/extend-inside-transforms-forward-expected.png: Added.
        * platform/mac/editing/selection/extend-inside-transforms-forward-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Gregg Tavares <gman@google.com>
commit-queue@webkit.org [Thu, 23 Jun 2011 22:19:21 +0000 (22:19 +0000)]
2011-06-23  Gregg Tavares  <gman@google.com>

        Reviewed by Kenneth Russell.

        add test expectation fast/canvas/canvas-large-dimensions.html for new assert in command buffer.
        https://bugs.webkit.org/show_bug.cgi?id=63278

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 23 Jun 2011 22:15:00 +0000 (22:15 +0000)]
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        FloatRect should implement the same methods as IntRect
        https://bugs.webkit.org/show_bug.cgi?id=63273

        Add missing methods from IntRect to FloatRect in preparation for moving
        the rendering tree over to floats.

        * platform/graphics/FloatPoint.h:
        (WebCore::FloatPoint::expandedTo):
        (WebCore::FloatPoint::transposedPoint):
        * platform/graphics/FloatRect.h:
        (WebCore::FloatRect::move):
        (WebCore::FloatRect::expand):
        (WebCore::FloatRect::contract):
        (WebCore::FloatRect::shiftXEdgeTo):
        (WebCore::FloatRect::shiftMaxXEdgeTo):
        (WebCore::FloatRect::shiftYEdgeTo):
        (WebCore::FloatRect::shiftMaxYEdgeTo):
        (WebCore::FloatRect::minXMinYCorner):
        (WebCore::FloatRect::maxXMinYCorner):
        (WebCore::FloatRect::minXMaxYCorner):
        (WebCore::FloatRect::maxXMaxYCorner):
        (WebCore::FloatRect::transposedRect):
        * platform/graphics/FloatSize.h:
        (WebCore::FloatSize::expand):
        (WebCore::FloatSize::transposedSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-23 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Thu, 23 Jun 2011 22:13:30 +0000 (22:13 +0000)]
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Dimitri Glazkov.

        input/textarea onchange doesn't fire if value is set in key listener
        https://bugs.webkit.org/show_bug.cgi?id=63092

        Add test for text field onchange when setting the value in a key listener.

        * fast/events/onchange-setvalue-expected.txt: Added.
        * fast/events/onchange-setvalue.html: Added.
2011-06-23  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        input/textarea onchange doesn't fire if value is set in key listener
        https://bugs.webkit.org/show_bug.cgi?id=63092

        Change setValue implementation of HTMLInputElement and HTMLTextAreaElement to
        not call setTextAsOfLastFormControlChangeEvent unless the value truly changed.
        Thus element.value = element.value will no longer reset the state
        m_textAsOfLastFormControlChangeEvent field and suppress the change event.

        Test: fast/events/onchange-setvalue.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setValue):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue):
        (WebCore::HTMLTextAreaElement::setNonDirtyValue):
        (WebCore::HTMLTextAreaElement::setValueCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89624 268f45cc-cd09-0410-ab3c-d52691b4dbfc