WebKit-https.git
14 years agoFix a minor bug with the computation of glyph offsets in Cairo/Win32.
hyatt [Wed, 24 May 2006 08:33:32 +0000 (08:33 +0000)]
Fix a minor bug with the computation of glyph offsets in Cairo/Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSwitch the cairo win32 create similar call over to createdib instead. Avoids wasted...
hyatt [Wed, 24 May 2006 08:28:10 +0000 (08:28 +0000)]
Switch the cairo win32 create similar call over to createdib instead.  Avoids wasted fills.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCheck in some temporary hacks to Cairo for speed.
hyatt [Wed, 24 May 2006 08:23:32 +0000 (08:23 +0000)]
Check in some temporary hacks to Cairo for speed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake sure the font options set on the context match what we draw.
hyatt [Wed, 24 May 2006 07:15:15 +0000 (07:15 +0000)]
Make sure the font options set on the context match what we draw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect reviewer from me to Tim.
mjs [Wed, 24 May 2006 01:08:30 +0000 (01:08 +0000)]
Correct reviewer from me to Tim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
mjs [Wed, 24 May 2006 00:59:34 +0000 (00:59 +0000)]
    Reviewed by Maciej.

        - more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader

        * WebCoreSupport/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
        (-[WebSubresourceLoader didReceiveResponse:]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _loadIcon]):
        (-[WebDataSource _startLoading]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadRequest:archive:]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
        (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
        * WebView/WebFrameInternal.h:
        * WebView/WebFramePrivate.h:
        * WebView/WebLoader.h:
        * WebView/WebLoader.m:
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader initWithDataSource:]):
        (-[WebMainResourceLoader didReceiveResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Timothy.
thatcher [Wed, 24 May 2006 00:24:52 +0000 (00:24 +0000)]
    Reviewed by Timothy.

        * index.html: Link to Nokia's S60 WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
thatcher [Tue, 23 May 2006 23:32:08 +0000 (23:32 +0000)]
    Reviewed by Eric.

        Remove the recent idl files from the WebCore target to prevent them
        from being copied into the framework resources.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin Garcia and Levi Weintraub.
sullivan [Tue, 23 May 2006 23:31:14 +0000 (23:31 +0000)]
    Reviewed by Justin Garcia and Levi Weintraub.

        - fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html

        * dom/Document.cpp:
        (WebCore::Document::removeMarkers):
        One more time to get this right, ugh. There is still one case where we don't want to advance the
        iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid
        my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now
        the layout tests pass even with the pixel tests enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoImplement CookieJar on Win32.
hyatt [Tue, 23 May 2006 22:11:56 +0000 (22:11 +0000)]
Implement CookieJar on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix post form submission on Win32.
hyatt [Tue, 23 May 2006 21:21:44 +0000 (21:21 +0000)]
Fix post form submission on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
sullivan [Tue, 23 May 2006 20:45:24 +0000 (20:45 +0000)]
    Reviewed by Maciej.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        Newer Xcode removed some obsolete cruft

        * DumpRenderTree/TextInputController.m:
        (-[TextInputController textInput]):
        added (id) cast to make newer compiler happy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix glyph width access on win32 to not depend on the UChar.
hyatt [Tue, 23 May 2006 20:31:53 +0000 (20:31 +0000)]
Fix glyph width access on win32 to not depend on the UChar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Tue, 23 May 2006 19:27:58 +0000 (19:27 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
        attempting to select Safari's menu bar results in a crash

        * Misc/WebNSWindowExtras.m:
        (replacementPostWindowNeedsDisplay):
        My fix yesterday for 4557117 was not quite good enough.  Now that we cancel the display timer for a
        window *before* it deallocates, we need to make sure that while a window deallocates, no new display
        timers are scheduled for that window.  This is actually possible, as 4558301 demonstrates.
        Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag
        and bail out of the throttle hack if it is set.  This should fix the last of the crashes involving
        display timers scheduled for deallocated or deallocating windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
lweintraub [Tue, 23 May 2006 17:51:29 +0000 (17:51 +0000)]
    Reviewed by Hyatt.

        Cleaned up changes to markup by adding the non-virtual
        nodeNamePreservingCase accessor function.

        * dom/Element.cpp:
        (WebCore::Element::nodeNamePreservingCase):
        * dom/Element.h:
        * editing/markup.cpp:
        (WebCore::startMarkup):
        (WebCore::endMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
sullivan [Tue, 23 May 2006 17:35:17 +0000 (17:35 +0000)]
    Reviewed by Anders Carlsson.

        * dom/Document.cpp:
        (WebCore::Document::removeMarkers):
        Fix to my previous checkin (which broke a layout test).
        Advance the iterator position every time through the loop; formerly it was not advanced in the
        case where a marker was actually removed, causing an infinite loop in certain cases. Also
        modified a comment that was confusing the situation by falsely claiming that iterating over a
        just-inserted node would always be OK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 23 May 2006 16:27:49 +0000 (16:27 +0000)]
WebCore:

2006-05-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
        Weather2.css incorrectly treated as JavaScript file @ www.live.com

        * dom/Element.cpp:
        (WebCore::Element::getAttribute):
        (WebCore::Element::setAttribute):
        (WebCore::Element::removeAttribute):
        (WebCore::Element::getAttributeNode):
        (WebCore::Element::hasAttribute):
        Use new getAttributeItem method.

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::getNamedItem):
        (WebCore::NamedAttrMap::removeNamedItem):
        Use new getAttributeItem method.

        (WebCore::NamedAttrMap::getAttributeItem):
        * dom/NamedAttrMap.h:
        New method which returns the attribute based on the nodeName.

LayoutTests:

2006-05-23  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
        Weather2.css incorrectly treated as JavaScript file @ www.live.com

        * dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
        This fails in a different way now.

        * dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
        * dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
        * dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
        * dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
        * dom/xhtml/level3/core/noderemovechild28-expected.txt:
        * dom/xhtml/level3/core/noderemovechild29-expected.txt:
        These now pass.

        * fast/dom/attribute-namespaces-get-set-expected.txt: Added.
        * fast/dom/attribute-namespaces-get-set.html: Added.
        Add new tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Tue, 23 May 2006 15:40:14 +0000 (15:40 +0000)]
    Reviewed by Eric.

        - remove knowledge of WebView from WebLoader in preparation for moving the code down

        * WebView/WebDataSource.m:
        (-[WebDataSource _defersCallbacks]):
        (-[WebDataSource _identifierForInitialRequest:]):
        (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
        (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
        (-[WebDataSource _didReceiveResponse:forResource:]):
        (-[WebDataSource _didReceiveData:contentLength:forResource:]):
        (-[WebDataSource _didFinishLoadingForResource:]):
        (-[WebDataSource _didFailLoadingWithError:forResource:]):
        (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
        (-[WebDataSource _privateBrowsingEnabled]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebLoader.h:
        * WebView/WebLoader.m:
        (-[WebLoader releaseResources]):
        (-[WebLoader setDataSource:]):
        (-[WebLoader willSendRequest:redirectResponse:]):
        (-[WebLoader didReceiveAuthenticationChallenge:]):
        (-[WebLoader didCancelAuthenticationChallenge:]):
        (-[WebLoader didReceiveResponse:]):
        (-[WebLoader didReceiveData:lengthReceived:]):
        (-[WebLoader signalFinish]):
        (-[WebLoader didFinishLoading]):
        (-[WebLoader didFailWithError:]):
        (-[WebLoader willCacheResponse:]):
        (-[WebLoader cancelWithError:]):
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        * WebView/WebView.m:
        (-[WebView _incrementProgressForIdentifier:response:]):
        (-[WebView _incrementProgressForIdentifier:data:]):
        (-[WebView _completeProgressForIdentifier:]):
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-22 Eric Seidel <eric@eseidel.com>
eseidel [Tue, 23 May 2006 01:36:01 +0000 (01:36 +0000)]
2006-05-22  Eric Seidel  <eric@eseidel.com>

        Rubber-stamped by adele.

        * bindings/js/kjs_html.h: simple style cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
thatcher [Mon, 22 May 2006 23:46:58 +0000 (23:46 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix when doing 'xcodebuild install'.
thatcher [Mon, 22 May 2006 23:30:22 +0000 (23:30 +0000)]
Build fix when doing 'xcodebuild install'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix.
thatcher [Mon, 22 May 2006 22:18:04 +0000 (22:18 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by levi
justing [Mon, 22 May 2006 22:10:58 +0000 (22:10 +0000)]
    Reviewed by levi

        Fixed and reenabled this test.

        * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
        * editing/selection/drag-to-contenteditable-iframe-expected.png:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe.html: Added.
        * editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoves svn:executable from MathExtras.h. Caused a build verification failure.
thatcher [Mon, 22 May 2006 21:39:44 +0000 (21:39 +0000)]
Removes svn:executable from MathExtras.h. Caused a build verification failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
sullivan [Mon, 22 May 2006 21:20:43 +0000 (21:20 +0000)]
    Reviewed by Anders Carlsson.

        - fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

        Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
        DeprecatedValueList and DeprecatedValueListIterator.

        * dom/Document.h:
        * dom/Document.cpp:
        (WebCore::Document::addMarker):
        (WebCore::Document::copyMarkers):
        (WebCore::Document::removeMarkers):
        (WebCore::Document::markersForNode):
        (WebCore::Document::repaintMarkers):
        (WebCore::Document::shiftMarkers):

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintAllMarkersOfType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago64-bit build fix, and removes the workaround for <rdar://problem/4294625>.
thatcher [Mon, 22 May 2006 21:00:09 +0000 (21:00 +0000)]
64-bit build fix, and removes the workaround for <rdar://problem/4294625>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
tomernic [Mon, 22 May 2006 20:55:03 +0000 (20:55 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
        opening file from file open dialog

        Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
        machine.

        * Misc/WebNSWindowExtras.m:
        (replacementDealloc):
        Cancel display timer before dealloc, not after.  Cancelling the timer can cause a message to be sent to the
        window; best to do that before the window deallocates.
        (replacementFinalize):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 22 May 2006 20:21:24 +0000 (20:21 +0000)]
2006-05-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by adele.

        Fix build.

        * Spinneret/Spinneret.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-22 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 22 May 2006 20:16:17 +0000 (20:16 +0000)]
2006-05-22  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by adele.

        Fix build.

        * WebKitWin.vcproj/WebKitWin.sln:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
lweintraub [Mon, 22 May 2006 18:34:24 +0000 (18:34 +0000)]
LayoutTests:

        Reviewed by eric.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
          <br>s created by createMarkup aren't valid xhtml
          Changes in case from innerHTML

        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * fast/dom/Range/range-exceptions-expected.txt:
        * fast/dom/Range/resources/range-exceptions.js:
        * fast/innerHTML/005-expected.txt:
        * fast/innerHTML/innerHTML-custom-tag-expected.txt:
        * fast/innerHTML/innerHTML-cast.html: Added.
        * fast/innerHTML/innerHTML-cast-expected.txt: Added.
        * fast/xsl/xslt-processer-expected.txt:

WebCore:

        Reviewed by Eric.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8393
          <br>s created by createMarkup aren't valid xhtml
          Fixed uppered output from innerHTML

        * editing/markup.cpp:
        (WebCore::startMarkup):
        (WebCore::endMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric, Kevin and Geoff.
thatcher [Mon, 22 May 2006 18:20:15 +0000 (18:20 +0000)]
    Reviewed by Eric, Kevin and Geoff.

        Merge open source build fixes. <rdar://problem/4555500>

        * kjs/collector.cpp: look at the rsp register in x86_64
        (KJS::Collector::markOtherThreadConservatively):
        * wtf/Platform.h: add x86_64 to the platform list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Mac bustage.
hyatt [Mon, 22 May 2006 08:04:56 +0000 (08:04 +0000)]
Fix Mac bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 bustage.
hyatt [Mon, 22 May 2006 06:19:01 +0000 (06:19 +0000)]
Fix win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 bustage.
hyatt [Mon, 22 May 2006 06:18:32 +0000 (06:18 +0000)]
Fix win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
adele [Sun, 21 May 2006 23:42:36 +0000 (23:42 +0000)]
    Reviewed by Maciej.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9016
        crash loading live.com in TreeShared::ref because accessing RenderTextField::text() can destroy the RenderTextField

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::text):
        Reverting recent change to user innerText instead of textContent.  For textareas,
        we need a better solution than textContent that also takes newlines into account,
        but this should fix this crasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-21 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 21 May 2006 07:51:14 +0000 (07:51 +0000)]
2006-05-21  Anders Carlsson  <acarlsson@apple.com>

        Fix build.

        * ForwardingHeaders/wtf/MathExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd mathextras to javascrtipcore project.
hyatt [Sun, 21 May 2006 07:18:49 +0000 (07:18 +0000)]
Add mathextras to javascrtipcore project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix mac bustage. Minor snafu in constructor.
hyatt [Sun, 21 May 2006 07:05:21 +0000 (07:05 +0000)]
Fix mac bustage.  Minor snafu in constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSwitch on Cairo-based text rendering on win32.
hyatt [Sun, 21 May 2006 06:58:12 +0000 (06:58 +0000)]
Switch on Cairo-based text rendering on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd mathextras.h to wtf to give win32 roundf/lroundf support.
hyatt [Sun, 21 May 2006 06:55:40 +0000 (06:55 +0000)]
Add mathextras.h to wtf to give win32 roundf/lroundf support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
mjs [Sun, 21 May 2006 02:09:59 +0000 (02:09 +0000)]
    Reviewed by Beth.

        - fix assertion failure on layout tests

        * WebView/WebDataSource.m:
        (-[WebDataSource _mainReceivedError:complete:]): Don't do anything
        if this data source is no longer connected to a frame. Used to be
        this couldn't happen because the WebView would have been nil, but
        we no longer go through the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
thatcher [Sat, 20 May 2006 22:42:59 +0000 (22:42 +0000)]
    Reviewed by Anders.

        Bug 9018: REGRESSION: resizing the top area of the inspector does not grow as expected
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9018

        Use clientHeight now that offsetHeight includes the border and padding.
        clientHeight should have been used initially.

        * WebInspector/WebInspector.m:
        (-[WebInspector resizeTopArea]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Cairo double buffering.
hyatt [Sat, 20 May 2006 21:22:06 +0000 (21:22 +0000)]
Fix Cairo double buffering.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andersca [Sat, 20 May 2006 20:19:22 +0000 (20:19 +0000)]
JavaScriptCore:

2006-05-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8993
        Support function declaration in case statements

        * kjs/grammar.y: Get rid of StatementList and use SourceElements instead.

        * kjs/nodes.cpp:
        (CaseClauseNode::evalStatements):
        (CaseClauseNode::processVarDecls):
        (CaseClauseNode::processFuncDecl):
        (ClauseListNode::processFuncDecl):
        (CaseBlockNode::processFuncDecl):
        (SwitchNode::processFuncDecl):
        * kjs/nodes.h:
        (KJS::CaseClauseNode::CaseClauseNode):
        (KJS::ClauseListNode::ClauseListNode):
        (KJS::ClauseListNode::getClause):
        (KJS::ClauseListNode::getNext):
        (KJS::ClauseListNode::releaseNext):
        (KJS::SwitchNode::SwitchNode):
        Add processFuncDecl for the relevant nodes.

        * kjs/nodes2string.cpp:
        (CaseClauseNode::streamTo):
        next got renamed to source.

LayoutTests:

2006-05-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * fast/js/function-declarations-in-switch-statement-expected.txt: Added.
        * fast/js/function-declarations-in-switch-statement.html: Added.
        * fast/js/resources/function-declarations-in-switch-statement.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sat, 20 May 2006 08:57:16 +0000 (08:57 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8991
          REGRESSION: missing or broken CSS custom cursors are displayed as
          a missing image icon

        * page/FrameView.cpp:
        (WebCore::selectCursor): Fallback to CURSOR_AUTO if the image is an error image.
        * manual-tests/custom-cursors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-20 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sat, 20 May 2006 08:47:37 +0000 (08:47 +0000)]
2006-05-20  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by ap.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
          REGRESSION: ToT crash in WebCore at Zap2it

        Test: fast/table/empty-section-crash.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint): Return immediately if the section
        has 0 rows or 0 columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 bustage caused by image document. supportsType is not implemented yet...
hyatt [Sat, 20 May 2006 05:52:02 +0000 (05:52 +0000)]
Fix Win32 bustage caused by image document.  supportsType is not implemented yet for ImageCairo, so we'll return false rather than true to keep every document from being an image document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
lweintraub [Sat, 20 May 2006 00:21:46 +0000 (00:21 +0000)]
LayoutTests:

        Reviewed by justin.

        Tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
        Drag caret not painted for editable sub-frames

        * editing/resources/select-and-drag-iframe.html: Added.
        * editing/selection/drag-in-iframe-expected.checksum: Added.
        * editing/selection/drag-in-iframe-expected.png: Added.
        * editing/selection/drag-in-iframe-expected.txt: Added.
        * editing/selection/drag-in-iframe.html: Added.

WebCore:

        Reviewed by justin.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8931>
        Drag caret not painted for editable sub-frames

        Moved the drag caret out of Frame and into Page.
        Only the Frame that contains the drag caret will paint it.

        * editing/SelectionController.h:
        * page/Frame.cpp:
        (WebCore::Frame::dragCaret):
        (WebCore::Frame::setDragCaret):
        (WebCore::Frame::paintDragCaret):
        * page/FramePrivate.h:
        * page/Page.cpp:
        (WebCore::Page::dragCaret):
        (WebCore::Page::setDragCaret):
        * page/Page.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
aliceli1 [Fri, 19 May 2006 23:16:17 +0000 (23:16 +0000)]
    Reviewed by Adele.

        * html/HTMLButtonElement.idl:
        added support for HTMLButtonElement.click()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14496 268f45cc-cd09-0410...
aliceli1 [Fri, 19 May 2006 21:18:58 +0000 (21:18 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Fri, 19 May 2006 19:35:41 +0000 (19:35 +0000)]
LayoutTests:

        - Test for overriding non-autogenerated global constructors.

        * fast/dom/constructors-overriding-expected.txt: Added.
        * fast/dom/constructors-overriding.html: Added.

WebCore:

        Reviewed by Eric.

        - Fixed non-autogenerated global constructors to match autogenerated
        ones and FF. (Found this bug while @ the GOOG.)

        (1) They're no longer read-only, so they can be overridden.
        (2) They now have the default object prototype, so they can do things
        like 'toString' and 'valueOf', necessary for general functionality,
        including my layout test.
        (3) Their prototype properties are now enumerable and not read-only.

        * bindings/js/JSDOMParser.cpp:
        (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXMLSerializer.cpp:
        (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
        * bindings/js/kjs_html.cpp:
        (KJS::OptionConstructorImp::OptionConstructorImp):
        (KJS::ImageConstructorImp::ImageConstructorImp):
        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-19 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 19 May 2006 10:53:07 +0000 (10:53 +0000)]
2006-05-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8983
        Autogenerate another 22 HTML classes

        Already covered by existing DOM tests.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add new IDL files and generated sources.

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        Use JSHTMLImageElement::info in inherits.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createJSWrapper):
        Add macros for the functions and the code to populate the hash set.

        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        Delete old cruft.

        * bindings/scripts/CodeGeneratorJS.pm:
        Add support for creating a JS object from a HTMLCollection.

        * html/HTMLAreaElement.idl: Added.
        * html/HTMLBRElement.idl: Added.
        * html/HTMLBaseFontElement.idl: Added.
        * html/HTMLBlockquoteElement.idl: Added.

        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::scrollLeft):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::scrollTop):
        (WebCore::HTMLBodyElement::setScrollTop):
        (WebCore::HTMLBodyElement::scrollHeight):
        (WebCore::HTMLBodyElement::scrollWidth):
        * html/HTMLBodyElement.h:
        Add new functions that used to be implemented in kjs_html.cpp

        * html/HTMLBodyElement.idl: Added.
        * html/HTMLFieldSetElement.idl: Added.
        * html/HTMLFontElement.idl: Added.
        * html/HTMLHRElement.idl: Added.
        * html/HTMLHeadingElement.idl: Added.
        * html/HTMLImageElement.idl: Added.
        * html/HTMLIsIndexElement.idl: Added.
        * html/HTMLLIElement.idl: Added.
        * html/HTMLLabelElement.idl: Added.
        * html/HTMLLegendElement.idl: Added.
        * html/HTMLMapElement.idl: Added.
        * html/HTMLMenuElement.idl: Added.
        * html/HTMLModElement.idl: Added.
        * html/HTMLParagraphElement.idl: Added.
        * html/HTMLParamElement.idl: Added.
        * html/HTMLPreElement.idl: Added.
        * html/HTMLQuoteElement.idl: Added.
        * html/HTMLScriptElement.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate to the latest and greatest Cairo.
hyatt [Fri, 19 May 2006 01:25:48 +0000 (01:25 +0000)]
Update to the latest and greatest Cairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
mjs [Thu, 18 May 2006 22:00:52 +0000 (22:00 +0000)]
    Reviewed by Eric.

        - remove loading-related code from WebView
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8981

        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePlugInStreamLoader didFinishLoading]):
        (-[WebNetscapePlugInStreamLoader didFailWithError:]):
        * WebCoreSupport/WebSubresourceLoader.m:
        (-[WebSubresourceLoader receivedError:]):
        (-[WebSubresourceLoader signalFinish]):
        * WebView/WebDataSource.m:
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _finishedLoadingResource]):
        (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
        (-[WebDataSource _receivedError:]):
        (-[WebDataSource _mainReceivedError:complete:]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
        (-[WebMainResourceLoader didFinishLoading]):
        * WebView/WebView.m:
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Thu, 18 May 2006 21:28:47 +0000 (21:28 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4551938> More options needed for window display throttle

        We decided to play it safe and leave our window flushing behavior unchanged from the previous
        public release.  By default, CoreGraphics deferred updates are once again OFF, and the window
        display throttle is OFF.

        Individual applications should set the WebKitThrottleWindowDisplayPreferenceKey and
        WebKitEnableDeferredUpdatesPreferenceKey defaults to suit their needs.

        Old behavior (like 10.4.6): WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
        WebKitEnableDeferredUpdatesPreferenceKey (or unset).

        Tear-free scrolling/animations: WebKitThrottleWindowDisplayPreferenceKey=0 (or unset),
        WebKitEnableDeferredUpdatesPreferenceKey=1.  While this configuration fixes the tearing issues
        caused by over-flushing, some applications will experience performance problems as over-flushing
        with CG deferred updates enabled will cause the app to block.

        Tear-free scrolling/animations, high performance: WebKitThrottleWindowDisplayPreferenceKey=1,
        WebKitEnableDeferredUpdatesPreferenceKey=1.  This is the riskiest configuration in that it
        enables the window display throttle "feature", potentially breaking applications' assumptions
        about when displays occur.  However, it provides the "best of both worlds", in that updates
        are tear-free, and performance impact should me minimal.

        * WebView/WebPreferenceKeysPrivate.h:
        Declared WebKitThrottleWindowDisplayPreferenceKey and WebKitEnableDeferredUpdatesPreferenceKey.

        * WebView/WebFrameView.m:
        (-[WebFrameView initWithFrame:]):
        Turn off CG deferred updates if WebKitEnableDeferredUpdatesPreferenceKey is NO or has no value.
        Added some comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake Win32 compile (finally). Add missing files to bindings/js directory in the...
hyatt [Thu, 18 May 2006 20:49:17 +0000 (20:49 +0000)]
Make Win32 compile (finally).  Add missing files to bindings/js directory in the vcproj.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReduce link errors from 21 to 7 by adding more auto-generated JS bindings files to...
hyatt [Thu, 18 May 2006 20:40:52 +0000 (20:40 +0000)]
Reduce link errors from 21 to 7 by adding more auto-generated JS bindings files to the vcproj. (Win32 bustage still.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoKeep working on win32 bustage. Add KWQFileButton::setDisabled to TemporaryLinkStubs.
hyatt [Thu, 18 May 2006 20:36:16 +0000 (20:36 +0000)]
Keep working on win32 bustage.  Add KWQFileButton::setDisabled to TemporaryLinkStubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoKeep going trying to fix win32 bustage. Make ImageDocument compile.
hyatt [Thu, 18 May 2006 20:31:25 +0000 (20:31 +0000)]
Keep going trying to fix win32 bustage.  Make ImageDocument compile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Thu, 18 May 2006 20:31:04 +0000 (20:31 +0000)]
    Reviewed by Darin Adler.

        - fixed <rdar://problem/4552713> REGRESSION: WebFrameView no longer responds to responder methods sent by Safari code

        * WebView/WebView.m:
        (-[WebView _responderForResponderOperations]):
        Treat sibling views of the main frameView the same as views outside of the webview for the purposes of this mechanism.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Thu, 18 May 2006 20:29:58 +0000 (20:29 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4553450> Make disabling window throttle safer

        * Misc/WebNSWindowExtras.m:
        (+[NSWindow _webkit_enableWindowDisplayThrottle]):
        Don't assume that +_webkit_disableWindowDisplayThrottle restored the NSWindow method implementations;
        now we'll only swizzle them once, and our replacement IMPs will call the old IMPs when the window
        throttle is disabled.  This is a safer approach when other components/"haxies" override the same methods
        that we are overriding, as it allows the overrides to "chain" properly.
        Moved the dictionary initialization code down a bit.  The order doesn't matter here.
        (disableWindowDisplayThrottleApplierFunction):
        Noticed that this could have been written safer with respect to the timer having the last reference to
        the window.  I never experienced a crash here, but this code is definitely safer.
        (+[NSWindow _webkit_disableWindowDisplayThrottle]):
        Don't restore NSWindow method implementations; just clear the flag, flush pending displays, and destroy
        the dictionary.
        (replacementPostWindowNeedsDisplay):
        If throttling is disabled, just call the original IMP.
        (clearWindowDisplayInfo):
        Added an assert.
        (replacementDealloc):
        Don't call clearWindowDisplayInfo() when throttling is disabled.
        (replacementFinalize):
        ditto
        (cancelPendingWindowDisplay):
        Removed an unnecessary assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix build bustage caused by broken XPath feature support checking on win32.
hyatt [Thu, 18 May 2006 20:18:44 +0000 (20:18 +0000)]
Fix build bustage caused by broken XPath feature support checking on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix no-SVG, no-XPATH build, again
darin [Thu, 18 May 2006 17:57:16 +0000 (17:57 +0000)]
    - try to fix no-SVG, no-XPATH build, again

        * Scripts/build-webkit: Use FEATURE_DEFINES= instead of FEATURE_DEFINES=''.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Turn off responding to font changes while running. It doesn't work
hyatt [Thu, 18 May 2006 17:52:30 +0000 (17:52 +0000)]
    Turn off responding to font changes while running.  It doesn't work
        right anyway.

        Reviewed by darin

        * platform/FontCache.cpp:
        (WebCore::FontCache::getCachedFontPlatformData):
        * platform/FontCache.h:
        * platform/GlyphMap.h:
        (WebCore::GlyphMap::~GlyphMap):
        * platform/GlyphWidthMap.h:
        (WebCore::GlyphWidthMap::~GlyphWidthMap):
        * platform/mac/FontCacheMac.mm:
        (WebCore::FontCache::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix no-SVG, no-XPATH build
darin [Thu, 18 May 2006 17:04:51 +0000 (17:04 +0000)]
    - try to fix no-SVG, no-XPATH build

        * Scripts/build-webkit: Pass FEATURE_DEFINES rather than GCC_PREPROCESSOR_DEFINITIONS,
        since the former is what's used in the WebCore project now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix the Windows build
darin [Thu, 18 May 2006 16:56:24 +0000 (16:56 +0000)]
    - try to fix the Windows build

        * platform/TextEncoding.h: Changed a ";" to a ",".
        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed
        JSCanvasRenderingContext2DBase.cpp and
        JSCanvasRenderingContext2DBase.h. Added
        JSCanvasRenderingContext2DCustom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Thu, 18 May 2006 16:53:35 +0000 (16:53 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Tests for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
        Bug 8896: Absolutely positioned elements should use their parent's
        direction when left, right and width are auto in quirks mode.

        * fast/block/positioning/absolute-position-direction-quirk.html: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.txt: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.png: Added.
        * fast/block/positioning/absolute-position-direction-quirk-expected.checksum: Added.
        * fast/block/positioning/absolute-position-direction-strict.html: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.txt: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.png: Added.
        * fast/block/positioning/absolute-position-direction-strict-expected.checksum: Added.

WebCore:

        Reviewed by Hyatt.

        Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8896>
        Bug 8896: Absolutely positioned elements should use their parent's
        direction when left, right and width are auto in quirks mode.

        Use the parent's direction instead of the containing
        block's in quirks mode for absolute positioning to match
        WinIE.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        * rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and tweaked (way too much) by Darin.
darin [Thu, 18 May 2006 16:13:19 +0000 (16:13 +0000)]
    Reviewed and tweaked (way too much) by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8937
          EncodingMap uses 0 as its empty value but 0 is a valid TextEncodingID

        * platform/CharsetNames.cpp:
        (WebCore::TextEncodingIDHashTraits::emptyValue): Added a non-zero empty value,
        InvalidEncoding, and used InvalidEncoding2 for the deleted value.
        (WebCore::buildCharsetMaps): Added an assertion that the deleted and empty
        values are not valid encodings.
        * platform/TextEncoding.h: Defined InvalidEncoding2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Horrible glyph map regression fix. The initial page of the map was
hyatt [Thu, 18 May 2006 09:13:08 +0000 (09:13 +0000)]
    Horrible glyph map regression fix.  The initial page of the map was
        being rebuilt over and over again.

        Reviewed by andersca

        * platform/GlyphMap.cpp:
        (WebCore::GlyphMap::locatePage):
        * platform/GlyphWidthMap.cpp:
        (WebCore::GlyphWidthMap::locatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Thu, 18 May 2006 08:20:57 +0000 (08:20 +0000)]
WebCore:

2006-05-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8964
        Autogenerate more HTML classes

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        Add new files.

        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createAnchorWrapper):
        (WebCore::createAppletWrapper):
        (WebCore::createDivWrapper):
        (WebCore::createDirectoryWrapper):
        (WebCore::createDListWrapper):
        (WebCore::createHtmlWrapper):
        (WebCore::createOListWrapper):
        (WebCore::createUListWrapper):
        (WebCore::createJSWrapper):
        Add wrappers.

        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        Delete the old implementations.

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::hash):
        (WebCore::HTMLAnchorElement::host):
        (WebCore::HTMLAnchorElement::hostname):
        (WebCore::HTMLAnchorElement::pathname):
        (WebCore::HTMLAnchorElement::port):
        (WebCore::HTMLAnchorElement::protocol):
        (WebCore::HTMLAnchorElement::search):
        (WebCore::HTMLAnchorElement::text):
        * html/HTMLAnchorElement.h:
        Add some new accessor methods which used to be in kjs_html.cpp.

        * html/HTMLAnchorElement.idl: Added.
        * html/HTMLAppletElement.idl: Added.
        * html/HTMLDListElement.idl: Added.
        * html/HTMLDirectoryElement.idl: Added.
        * html/HTMLDivElement.idl: Added.
        * html/HTMLHtmlElement.idl: Added.
        * html/HTMLOListElement.idl: Added.
        * html/HTMLUListElement.idl: Added.

LayoutTests:

2006-05-18  Anders Carlsson  <acarlsson@apple.com>

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8964
        Autogenerate more HTML classes

        * fast/dom/prototype-chain-expected.txt:
        Update test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Convert the width map for glyphs into the same new HashMap-style as the
hyatt [Thu, 18 May 2006 07:36:34 +0000 (07:36 +0000)]
    Convert the width map for glyphs into the same new HashMap-style as the
        glyph map for characters.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.cpp:
        (WebCore::FontData::~FontData):
        (WebCore::FontData::widthForGlyph):
        * platform/FontData.h:
        * platform/GlyphWidthMap.cpp: Added.
        (WebCore::GlyphWidthMap::widthForGlyph):
        (WebCore::GlyphWidthMap::setWidthForGlyph):
        (WebCore::GlyphWidthMap::locatePage):
        * platform/GlyphWidthMap.h: Added.
        (WebCore::GlyphWidthMap::GlyphWidthMap):
        (WebCore::GlyphWidthMap::~GlyphWidthMap):
        (WebCore::GlyphWidthMap::GlyphWidthPage::widthForGlyph):
        (WebCore::GlyphWidthMap::GlyphWidthPage::setWidthForGlyph):
        (WebCore::GlyphWidthMap::GlyphWidthPage::setWidthForIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename FontData.mm to FontData.cpp, since it has no obj-c in it.
hyatt [Thu, 18 May 2006 06:21:53 +0000 (06:21 +0000)]
    Rename FontData.mm to FontData.cpp, since it has no obj-c in it.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Split FontData.mm into platform-specific and cross-platform pieces.
hyatt [Thu, 18 May 2006 06:09:30 +0000 (06:09 +0000)]
    Split FontData.mm into platform-specific and cross-platform pieces.

        Reviewed by andersca

        * WebCore.xcodeproj/project.pbxproj:
        * platform/FontData.h:
        (WebCore::FontData::xHeight):
        * platform/mac/FontData.mm:
        (WebCore::FontData::widthForGlyph):
        (WebCore::m_smallCapsFontData):
        (WebCore::FontData::~FontData):
        (WebCore::extendWidthMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/do-webcore-rename: Some more future renames.
darin [Thu, 18 May 2006 05:02:36 +0000 (05:02 +0000)]
    * Scripts/do-webcore-rename: Some more future renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Thu, 18 May 2006 04:35:06 +0000 (04:35 +0000)]
    Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6915
        fast/js/date-constructor.html testcase is timezone-dependent

        * fast/js/date-constructor-expected.txt:
        * fast/js/resources/date-constructor.js:
        Disable the offending tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej, Alexey, and Eric.
staikos [Thu, 18 May 2006 04:15:21 +0000 (04:15 +0000)]
Reviewed by Maciej, Alexey, and Eric.
 - Use /**/ in .c files to compile with non-C99 and non-GCC compilers.
 - Change include to <wtf/HashTraits.h> from "HashTraits.h" to avoid -I
 - Use correct parentheses and correct mask for utf-32 support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker and John Sullivan.
tomernic [Thu, 18 May 2006 03:36:38 +0000 (03:36 +0000)]
    Reviewed by Kevin Decker and John Sullivan.

        <rdar://problem/4550801> REGRESSION: Window throttle code can sometimes leak NSWindows

        The window display throttle depended on windows being closed before they were deallocated; this is
        not guaranteed by AppKit.  Windows that were being released without being closed were getting stuck
        in our NSWindow -> WindowDisplayInfo dictionary.

        * Misc/WebNSWindowExtras.m:
        (+[NSWindow _webkit_enableWindowDisplayThrottle]):
        Don't retain the NSWindow keys in the window display info dictionary.
        Instead of overriding -close, override -dealloc and -finalize so that we can remove the NSWindow ->
        WindowDisplayInfo mapping when a window deallocates.
        (+[NSWindow _webkit_disableWindowDisplayThrottle]):
        Restore -dealloc and -finalize.
        (clearWindowDisplayInfo):
        Factored the WindowDisplayInfo cleanup code out of the now-defunct replacementClose().
        (replacementClose):
        Removed; no longer needed.
        (replacementDealloc):
        Clear the WindowDisplayInfo for the window after deallocation.
        (replacementFinalize):
        ditto
        (-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
        Rewrote this method to be safe in the case where the firing display timer has the last reference to the
        window.
        Added comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler
sullivan [Thu, 18 May 2006 01:02:24 +0000 (01:02 +0000)]
    Reviewed by Darin Adler

        Improvement to my previous patch, suggested by Darin

        * dom/Document.cpp:
        (WebCore::Document::repaintMarkers):
        new method, similar in structure to removeMarkers but just repaints each node that
        has a marker of the specified type
        * dom/Document.h:
        declare new method, and tweak style in related method declarations

        * page/Frame.cpp:
        (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
        if the value changes, call repaintMarkers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-17 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 18 May 2006 00:44:31 +0000 (00:44 +0000)]
2006-05-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Autogenerate button, optgroup, option, input and textarea js bindings
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8953

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createButtonWrapper):
        (WebCore::createInputWrapper):
        (WebCore::createOptGroupWrapper):
        (WebCore::createOptionWrapper):
        (WebCore::createTextAreaWrapper):
        (WebCore::createJSWrapper):
        * bindings/js/JSHTMLInputElementBase.cpp: Added.
        (WebCore::JSHTMLInputElementBaseProtoFunc::callAsFunction):
        (WebCore::):
        (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
        (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
        * bindings/js/JSHTMLInputElementBase.h: Added.
        (WebCore::JSHTMLInputElementBase::classInfo):
        (WebCore::JSHTMLInputElementBase::):
        (WebCore::JSHTMLInputElementBase::impl):
        * bindings/js/JSHTMLOptionElementConstructor.cpp: Added.
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        (WebCore::JSHTMLOptionElementConstructor::implementsConstruct):
        (WebCore::JSHTMLOptionElementConstructor::construct):
        * bindings/js/JSHTMLOptionElementConstructor.h: Added.
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::JSHTMLElement::getOwnPropertySlot):
        (KJS::HTMLElementFunction::callAsFunction):
        (KJS::JSHTMLElement::put):
        (KJS::JSHTMLElement::htmlSetter):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLButtonElement.idl: Added.
        * html/HTMLInputElement.idl: Added.
        * html/HTMLOptGroupElement.idl: Added.
        * html/HTMLOptionElement.idl: Added.
        * html/HTMLTextAreaElement.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-17 Eric Seidel <eseidel@apple.com>
eseidel [Thu, 18 May 2006 00:44:11 +0000 (00:44 +0000)]
2006-05-17  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Autogenerate button, optgroup, option, input and textarea js bindings
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8953

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLElementWrapperFactory.cpp:
        (WebCore::createButtonWrapper):
        (WebCore::createInputWrapper):
        (WebCore::createOptGroupWrapper):
        (WebCore::createOptionWrapper):
        (WebCore::createTextAreaWrapper):
        (WebCore::createJSWrapper):
        * bindings/js/JSHTMLInputElementBase.cpp: Added.
        (WebCore::JSHTMLInputElementBaseProtoFunc::callAsFunction):
        (WebCore::):
        (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
        (WebCore::JSHTMLInputElementBase::getOwnPropertySlot):
        * bindings/js/JSHTMLInputElementBase.h: Added.
        (WebCore::JSHTMLInputElementBase::classInfo):
        (WebCore::JSHTMLInputElementBase::):
        (WebCore::JSHTMLInputElementBase::impl):
        * bindings/js/JSHTMLOptionElementConstructor.cpp: Added.
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        (WebCore::JSHTMLOptionElementConstructor::implementsConstruct):
        (WebCore::JSHTMLOptionElementConstructor::construct):
        * bindings/js/JSHTMLOptionElementConstructor.h: Added.
        * bindings/js/kjs_domnode.h:
        * bindings/js/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLElement::classInfo):
        (KJS::JSHTMLElement::accessors):
        (KJS::JSHTMLElement::getOwnPropertySlot):
        (KJS::HTMLElementFunction::callAsFunction):
        (KJS::JSHTMLElement::put):
        (KJS::JSHTMLElement::htmlSetter):
        * bindings/js/kjs_html.h:
        (KJS::JSHTMLElement::):
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * html/HTMLButtonElement.idl: Added.
        * html/HTMLInputElement.idl: Added.
        * html/HTMLOptGroupElement.idl: Added.
        * html/HTMLOptionElement.idl: Added.
        * html/HTMLTextAreaElement.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-17 bradeeoh <beidson@apple.com>
beidson [Wed, 17 May 2006 23:45:54 +0000 (23:45 +0000)]
2006-05-17  bradeeoh  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Consolidated WebDatabase base class into WebFileDatabase as the inheritance relationship became
        obsolete.  This improves readability and sets the stage for a further in-depth rewrite of the
        WebIcon* code.

        * Misc/WebDatabase.h: Removed.
        * Misc/WebDatabase.m: Removed.
        * Misc/WebFileDatabase.h:
        * Misc/WebFileDatabase.m:
        (-[WebFileDatabaseOp dealloc]):
        (-[WebFileDatabase dealloc]):
        (-[WebFileDatabase path]):
        (-[WebFileDatabase isOpen]):
        (-[WebFileDatabase sizeLimit]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 17 May 2006 23:32:38 +0000 (23:32 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Updated test results for changes to prepare for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
        Switch to use new text field implementation for <textarea>

        * fast/block/float/032-expected.txt:

WebCore:

        Reviewed by Hyatt.

        First step for http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
        Switch to use new text field implementation for <textarea>

        New textareas can be turned on by setting -webkit-appearance:textarea.

        Tests:
        * LayoutTests/fast/block/float/032.html - Updated results.

        * bridge/mac/FrameMac.h: Added textDidChangeinTextArea to send notification over the bridge to form delegate.
        * bridge/mac/FrameMac.mm: (WebCore::FrameMac::textDidChangeInTextArea): ditto.
        * page/Frame.cpp: (WebCore::Frame::textDidChangeInTextArea): ditto.
        * page/Frame.h: ditto.

        * css/CSSValueKeywords.in: Added textarea.
        * css/cssparser.cpp: (WebCore::CSSParser::parseValue): Updates to check for textarea.
        * css/html4.css: Added style for textarea.  Leaved background-color and appearance values commented out.
        * rendering/render_style.h: (WebCore::): Added TextAreaAppearance.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::adjustStyle): Updated for textarea.
        (WebCore::RenderTheme::paint): ditto.
        (WebCore::RenderTheme::paintBorderOnly): ditto.
        (WebCore::RenderTheme::isControlStyled): ditto.
        (WebCore::RenderTheme::supportsFocusRing): ditto.
        (WebCore::RenderTheme::adjustTextFieldStyle): ditto.
        (WebCore::RenderTheme::adjustTextAreaStyle): ditto.
        * rendering/RenderTheme.h: (WebCore::RenderTheme::paintTextArea): Added.
        * rendering/RenderThemeMac.h: Added adjustTextAreaStyle.
        Note- I didn't add a paintTextArea function for RenderThemeMac, since we can just paint the border
        specified in html4.css to match the NSTextView border.  Added a paintTextArea function to the Windows
        theme can override that border.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::isControlStyled): Updated for textarea.
        (WebCore::RenderThemeMac::adjustTextAreaStyle): ditto.

        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::HTMLGenericFormElement):
        Moved m_valueMatchesRenderer and its setters and getters into this class so HTMLInputElement and
        HTMLTextArea can share.
        * html/HTMLGenericFormElement.h:
        (WebCore::HTMLGenericFormElement::valueMatchesRenderer): Added.
        (WebCore::HTMLGenericFormElement::setValueMatchesRenderer): Added.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::init): Remove m_valueMatchesRenderer intialization.
        (WebCore::HTMLInputElement::isKeyboardFocusable): Updated spelling.
        (WebCore::HTMLInputElement::createRenderer): Pass multiLine bool to RenderTextField constructor.
        (WebCore::HTMLInputElement::parseMappedAttribute): Use setValueMatchesRenderer instead of m_valueMatchesRenderer.
        (WebCore::HTMLInputElement::detach): ditto.
        (WebCore::HTMLInputElement::setValue): ditto.
        (WebCore::HTMLInputElement::setValueFromRenderer): ditto.
        * html/HTMLInputElement.h: Remove setValueMatchesRenderer and valueMatchesRenderer and m_valueMatchesRenderer.
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Calls setValueMatchesRenderer to intialize m_valueMatchesRenderer.
        (WebCore::HTMLTextAreaElement::selectionStart): Uses appearance to determine which renderer to use.
        (WebCore::HTMLTextAreaElement::selectionEnd): ditto.
        (WebCore::HTMLTextAreaElement::setSelectionStart): ditto.
        (WebCore::HTMLTextAreaElement::setSelectionEnd): ditto.
        (WebCore::HTMLTextAreaElement::select): ditto.
        (WebCore::HTMLTextAreaElement::setSelectionRange): ditto.
        (WebCore::HTMLTextAreaElement::createRenderer): ditto.
        (WebCore::HTMLTextAreaElement::appendFormData): ditto.
        (WebCore::HTMLTextAreaElement::updateValue): ditto.
        (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Added.
        (WebCore::HTMLTextAreaElement::isMouseFocusable): Added.
        (WebCore::HTMLTextAreaElement::focus): Added.
        (WebCore::HTMLTextAreaElement::defaultEventHandler): Added to forward events to the inner div.
        (WebCore::HTMLTextAreaElement::setValue): Calls setValueMatchesRenderer.
        * html/HTMLTextAreaElement.h: Added defaultEventHandler, isMouseFocusable, isKeyboardFocusable, and focus methods.
        Removed invalidateValue and m_valueMatchesRenderer since those are now handled in the base class.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
        Updated to handle textareas.
        * rendering/RenderTextArea.cpp: (WebCore::RenderTextArea::valueChanged):
        Calls setValueMatchesRenderer(false) instead of invalidateValue.

        * rendering/RenderTextField.h: Changed to be a RenderFlexibleBox instead of a RenderBlock.
        This was necessary to get the inner div's height to grow and shrink with the size of the textarea.
        Added m_multiLine bool, and calcHeight, canHaveChildren, baselinePosition, isTextArea, textWithHardLineBreaks, selectionChanged.
        (WebCore::RenderTextField::canHaveChildren): Returns false now so that no renderer gets created for
        the textarea's child text node for its initial contents.
        (WebCore::RenderTextField::isTextField): Returns true if m_multiLine is false.
        (WebCore::RenderTextField::isTextArea): Returns true if m_multiLine is true.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::RenderTextField):  Initializes m_multiLine.
        (WebCore::RenderTextField::~RenderTextField): Notifies HTMLTextAreaElement that the renderer is being destroyed so the value gets updated.
        (WebCore::RenderTextField::setStyle): Makes sure there's no overflow clip on the RenderTextField, since we're handling overflow on the inner div.
        (WebCore::RenderTextField::createDivStyle): Sets white-space, box-flex, overflow, word-wrap styles needed for text area.
        (WebCore::RenderTextField::updateFromElement): Updated for textarea elements.
        (WebCore::RenderTextField::setSelectionRange): Optimized caret case by checking to see if start is equal to end before calculating
        the same VisiblePosition twice.
        (WebCore::RenderTextField::subtreeHasChanged): Updated for textarea elements.
        (WebCore::RenderTextField::text): Use innerText so newlines are considered.
        (WebCore::RenderTextField::textWithHardLineBreaks): Added.  Not implemented yet. Just calls text method.
        (WebCore::RenderTextField::calcHeight): Added. Sets initial height based on specified number of rows, and then calls the base class.
        (WebCore::RenderTextField::baselinePosition): Added. Unlike text fields, textareas align to the bottom.
        (WebCore::RenderTextField::calcMinMaxWidth): Updated for textareas.
        (WebCore::RenderTextField::selectionChanged): Added. Not implemented yet.

WebKit:

        Reviewed by Hyatt.

        WebKit part of initial checkin to prepare for http://bugzilla.opendarwin.org/show_bug.cgi?id=8948
        Switch to use new text field implementation for <textarea>

        * WebView/WebHTMLView.m:
        (-[NSArray insertNewline:]): If we're in plain text mode, insert a line break instead of a paragraph separator.
        (-[NSArray insertParagraphSeparator:]): ditto.
        * WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]):
        Checks for textareas as well as textfields before allowing the delegate to control
        the context menu.  This won't affect the old textareas because AppKit handles those context menus.

WebKitTools:

        Reviewed by Hyatt.

        * Scripts/do-webcore-rename: Added RenderTextField => RenderTextControl and
        HTMLTextFieldInnerElement => HTMLTextControlInnerElement to list for future renames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for 8954, separate the glyph map out into its own files and make it
hyatt [Wed, 17 May 2006 21:29:03 +0000 (21:29 +0000)]
    Fix for 8954, separate the glyph map out into its own files and make it
        cross-platform.

        Reviewed by darin

        * WebCore.xcodeproj/project.pbxproj:
        * platform/Font.cpp:
        (WebCore::WidthIterator::advance):
        * platform/FontData.h:
        (WebCore::FontData::glyphDataForCharacter):
        (WebCore::FontData::setGlyphDataForCharacter):
        * platform/GlyphMap.cpp: Added.
        (WebCore::GlyphMap::glyphDataForCharacter):
        (WebCore::GlyphMap::setGlyphDataForCharacter):
        (WebCore::GlyphMap::locatePage):
        * platform/GlyphMap.h: Added.
        (WebCore::GlyphMap::GlyphMap):
        (WebCore::GlyphMap::~GlyphMap):
        (WebCore::GlyphMap::GlyphPage::glyphDataForCharacter):
        (WebCore::GlyphMap::GlyphPage::setGlyphDataForCharacter):
        (WebCore::GlyphMap::GlyphPage::setGlyphDataForIndex):
        * platform/mac/FontData.mm:
        (-[NSFont WebCore]):
        (WidthMap::m_ATSUMirrors):
        (WidthMap::FontData::~FontData):
        (WidthMap::FontData::xHeight):
        (WidthMap::FontData::platformInit):
        (WidthMap::extendWidthMap):
        * platform/mac/GlyphMapMac.cpp: Added.
        (WebCore::GlyphMap::fillPage):
        * platform/mac/WebCoreSystemInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-17 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 17 May 2006 21:10:02 +0000 (21:10 +0000)]
2006-05-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8958
        Should be able to have custom implementations for JS methods

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCanvasRenderingContext2DBase.cpp: Removed.
        * bindings/js/JSCanvasRenderingContext2DBase.h: Removed.
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp: Added.
        Remove JSCanvasRenderingContext2DBase and add
        JSCanvasRenderingContext2DCustom with custom implementations.

        (WebCore::toJS):
        (WebCore::toHTMLCanvasStyle):
        (WebCore::JSCanvasRenderingContext2D::strokeStyle):
        (WebCore::JSCanvasRenderingContext2D::setStrokeStyle):
        (WebCore::JSCanvasRenderingContext2D::fillStyle):
        (WebCore::JSCanvasRenderingContext2D::setFillStyle):
        (WebCore::JSCanvasRenderingContext2D::setFillColor):
        (WebCore::JSCanvasRenderingContext2D::setStrokeColor):
        (WebCore::JSCanvasRenderingContext2D::strokeRect):
        (WebCore::JSCanvasRenderingContext2D::drawImage):
        (WebCore::JSCanvasRenderingContext2D::drawImageFromRect):
        (WebCore::JSCanvasRenderingContext2D::setShadow):
        (WebCore::JSCanvasRenderingContext2D::createPattern):
        Move implementations from JSCanvasRenderingContext2DBase.

        * bindings/scripts/CodeGeneratorJS.pm:
        Add new "Custom" extended attribute for functions and attributes. When a function or
        attribute has this attribute, a custom implementation is called instead of calling down to
        the DOM object.

        * html/CanvasRenderingContext2D.idl:
        Add bunch of custom attributes and functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
sullivan [Wed, 17 May 2006 21:05:02 +0000 (21:05 +0000)]
    Reviewed by Maciej.

        First step towards making text-matching mechanism more flexible; updated for changes
        to WebCoreFrameBridge calls.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView highlightAllMatchesForString:caseSensitive:]):
        updated for name change in WebCoreFrameBridge, also now calls setMarkedTextMatchesAreHighlighted:
        (-[WebHTMLView clearHighlightedMatches]):
        updated for name change in WebCoreFrameBridge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
sullivan [Wed, 17 May 2006 21:04:51 +0000 (21:04 +0000)]
    Reviewed by Maciej.

        First step towards making text-matching mechanism more flexible; now caller can
        control whether or not the matches are highlighted.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:]):
        renamed from highlightAllMatchesForString:
        (-[WebCoreFrameBridge markedTextMatchesAreHighlighted]):
        new getter method
        (-[WebCoreFrameBridge setMarkedTextMatchesAreHighlighted:]):
        new setter method
        (-[WebCoreFrameBridge unmarkAllTextMatches]):
        renamed from clearHighlightedMatches

        * page/Frame.h:
        * page/Frame.cpp:
        (WebCore::Frame::markAllMatchesForText):
        renamed from highlightAllMatchesForString
        (WebCore::Frame::markedTextMatchesAreHighlighted):
        new getter method, uses boolean ivar in FramePrivate
        (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
        new setter method, uses boolean ivar in FramePrivate

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        added boolean ivar m_highlightTextMatches, initialized to 0

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        respect markedTextMatchesAreHighlighted

        * WebCore.xcodeproj/project.pbxproj:
        newer Xcode removed some obsolete settings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
adele [Wed, 17 May 2006 18:19:07 +0000 (18:19 +0000)]
    Reviewed by Beth.

        * editing/htmlediting.cpp: (WebCore::editingIgnoresContent):
        Reverting change that Darin made a few weeks ago.  He was trying
        to make editingIgnoresContent return true for the new text fields, but the code
        actually didn't change that result.  When the new text fields actually do return
        true for editingIgnoresContent, other editing problems are exposed. For example,
        moving the cursor around an editable area that contains a text field will cross the
        text field boundary and descend into the shadow tree.  So for now, we'll revert this
        change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 17 May 2006 17:19:44 +0000 (17:19 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8870
        Crash typing in Yahoo auto-complete widget.

        Test: fast/js/regexp-stack-overflow.html

        * pcre/pcre-config.h: Define NO_RECURSE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 17 May 2006 06:51:09 +0000 (06:51 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8951
          AtomicString hash corrupted by high-bit Latin-1

        * fast/encoding/high-bit-latin1-expected.txt: Added.
        * fast/encoding/high-bit-latin1.html: Added.

WebCore:

        Reviewed by Maciej, tweaked by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8951
          AtomicString hash corrupted by high-bit Latin-1

        Test: fast/encoding/high-bit-latin1.html

        * platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): Use an
        unsigned char local.
        * platform/StringImpl.cpp: (WebCore::StringImpl::init): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 17 May 2006 06:46:08 +0000 (06:46 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7492
        CSS attribute selectors fail when the setAttribute() method is used
        to create an attribute and the attribute name is not Class or ID.

        * fast/css/selector-set-attribute.html: Added.
        * fast/css/selector-set-attribute-expected.txt: Added.
        * fast/css/selector-set-attribute-expected.checksum: Added.
        * fast/css/selector-set-attribute-expected.png: Added.

WebCore:

        Reviewed by Maciej.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7492
        CSS attribute selectors fail when the setAttribute() method is used
        to create an attribute and the attribute name is not Class or ID.

        Keep track of attributes used in attribute selectors to
        check after setAttribute whether a style recalc is needed.

        Test: fast/css/selector-set-attribute.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):
        (WebCore::CSSStyleSelector::hasSelectorForAttribute):
        * css/cssstyleselector.h:
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::attributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 17 May 2006 06:36:12 +0000 (06:36 +0000)]
    Reviewed by Geoff.

        Ensured all the public headers have a newline at their end.

        Client code can now have 'Missing Newline at end of File' warnings enabled without emitting
        such warnings against any WebKit includes.

        * Misc/WebDownload.h:
        * Plugins/npfunctions.h:
        * WebView/WebResourceLoadDelegate.h:
        * WebView/WebUIDelegate.h:
        * WebView/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrect bug number.
darin [Wed, 17 May 2006 06:34:36 +0000 (06:34 +0000)]
Correct bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 17 May 2006 06:33:59 +0000 (06:33 +0000)]
LayoutTests:

        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5624
        document.createElementNS() should not allow to insert a second <html> element

        * dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
        Updated to show a different failure.

        * dom/xhtml/level3/core/nodeappendchild02-expected.txt:
        * dom/xhtml/level3/core/nodeinsertbefore06-expected.txt:
        * dom/xhtml/level3/core/nodereplacechild39-expected.txt:
        Updated to reflect success.

        * fast/dom/createDocumentType2.html: Added.
        * fast/dom/createDocumentType2-expected.txt: Added.
        * fast/dom/createElementNS.html: Added.
        * fast/dom/createElementNS-expected.txt: Added.

WebCore:

        Reviewed by Darin.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5624
        document.createElementNS() should not allow to insert a second <html> element

        Do extra checks for document nodes to detect multiple document elements
        and document types.

        * dom/Document.cpp:
        (WebCore::Document::childTypeAllowed):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
staikos [Wed, 17 May 2006 05:29:29 +0000 (05:29 +0000)]
    Reviewed by Maciej.

Fix some warnings and strict compilation errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadded yahoo.com preview to the hit list, moved capitalone to alumni list
aliceli1 [Wed, 17 May 2006 02:11:23 +0000 (02:11 +0000)]
added yahoo.com preview to the hit list, moved capitalone to alumni list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
tomernic [Wed, 17 May 2006 00:58:29 +0000 (00:58 +0000)]
    Reviewed by Tim Hatcher.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8945 (REGRESSION: Scrolling is very slow when dragging
        the thumb)

        Rolled out one of my tweaks to the window display throttle hack (remember the last flush time instead
        of the last display time).  While that was technically a better approach, we discovered a problem
        with how it interacts with NSView scroll tracking.  Rather than further complicate this already
        crazy hack, I'm reverting back to the simple version.  This should yield similar numbers on iBench,
        but not exhibit the nasty scrolling problem.

        * Misc/WebNSWindowExtras.m:
        (+[NSWindow _webkit_enableWindowDisplayThrottle]):
        (+[NSWindow _webkit_disableWindowDisplayThrottle]):
        (getWindowDisplayInfo):
        (requestWindowDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago64-bit build fix, use uintptr_t to cast from a pointer.
thatcher [Wed, 17 May 2006 00:01:08 +0000 (00:01 +0000)]
64-bit build fix, use uintptr_t to cast from a pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix ChangeLog
andersca [Tue, 16 May 2006 23:29:08 +0000 (23:29 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-17 Anders Carlsson <acarlsson@apple.com>
andersca [Tue, 16 May 2006 23:27:11 +0000 (23:27 +0000)]
2006-05-17  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        * DerivedSources.make:
        Conditionally generate the SVG and XPath related files based on the value of
        FEATURE_DEFINES. Also, pass FEATURE_DEFINES TO THE BINDINGS GENERATOR.

        * WebCore.xcodeproj/project.pbxproj:
        Add FEATURE_DEFINES as a toplevel build setting and set it to "SVG_SUPPORT XPATH_SUPPORT"
        to keep SVG and XPath support turned on. Add FEATURE_DEFINES to the CPP defines.

        * bindings/js/kjs_binding.cpp:
        (KJS::setDOMException):
        Add #ifdefs around the XPath code.

        * bindings/scripts/CodeGeneratorJS.pm:
        Add "Conditional" extended attribute for interfaces. If this is set, the generated code will be
        surrounded by an #if.

        * bindings/scripts/IDLParser.pm:
        Pass the define flags on to the preprocessor.

        * bindings/scripts/generate-bindings.pl:
        Add a --defines property and pass it on to the parser.

        * css/cssstyleselector.h:
        Add DeprecatedString.h include.

        * dom/Document.idl:
        Put back #if around the XPath functions

        * page/DOMWindow.idl:
        Put #if around the XPath constructors

        * xpath/XPathEvaluator.idl:
        * xpath/XPathExpression.idl:
        * xpath/XPathNSResolver.cpp:
        * xpath/XPathNSResolver.idl:
        * xpath/XPathNamespace.cpp:
        * xpath/XPathResult.idl:
        Add "Conditional=XPATH" to all interfaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-05-16 bradeeoh <beidson@apple.com>
beidson [Tue, 16 May 2006 23:13:19 +0000 (23:13 +0000)]
2006-05-16  bradeeoh  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        - Fixed an old deprecated method in Misc/WebFileDatabase.m

        * Misc/WebFileDatabase.m:
        (UniqueFilePathForKey):  changed `lossyCString` to `UTF8String`

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14422 268f45cc-cd09-0410-ab3c-d52691b4dbfc