WebKit-https.git
6 years agoFix EFL build, which has accelerated compositing disabled, by making
simon.fraser@apple.com [Thu, 8 Nov 2012 05:36:08 +0000 (05:36 +0000)]
Fix EFL build, which has accelerated compositing disabled, by making
repaintViewRectangle() const.

* rendering/RenderView.cpp:
(WebCore::RenderView::repaintViewRectangle):
* rendering/RenderView.h:
(RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoconstify ALL the repaint containers
simon.fraser@apple.com [Thu, 8 Nov 2012 05:15:10 +0000 (05:15 +0000)]
constify ALL the repaint containers
https://bugs.webkit.org/show_bug.cgi?id=101541

Reviewed by Beth Dakin.

Make all the RenderLayerModelObject* repaintContainer arguments const, since
these member functions should have no need to mutate this object.

* WebCore.exp.in:
* rendering/RenderBR.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::clippedOverflowRectForRepaint):
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderBox.h:
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions): Need to use a const_iterator.
* rendering/RenderFlowThread.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::rectWithOutlineForRepaint):
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderInline.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::selectionRectForRepaint):
* rendering/RenderListMarker.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::rectWithOutlineForRepaint):
(WebCore::RenderObject::clippedOverflowRectForRepaint):
(WebCore::RenderObject::computeRectForRepaint):
(WebCore::RenderObject::computeFloatRectForRepaint):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):
* rendering/RenderObject.h:
(WebCore::RenderObject::selectionRectForRepaint):
(WebCore::RenderObject::outlineBoundsForRepaint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::selectionRectForRepaint):
(WebCore::RenderReplaced::clippedOverflowRectForRepaint):
* rendering/RenderReplaced.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
* rendering/RenderTableCell.h:
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clippedOverflowRectForRepaint):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
* rendering/RenderTableRow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint):
(WebCore::RenderText::selectionRectForRepaint):
* rendering/RenderText.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::computeRectForRepaint):
* rendering/RenderView.h:
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGForeignObject::computeFloatRectForRepaint):
(WebCore::RenderSVGForeignObject::mapLocalToContainer):
* rendering/svg/RenderSVGForeignObject.h:
* rendering/svg/RenderSVGGradientStop.h:
* rendering/svg/RenderSVGHiddenContainer.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::clippedOverflowRectForRepaint):
(WebCore::RenderSVGInline::computeFloatRectForRepaint):
(WebCore::RenderSVGInline::mapLocalToContainer):
* rendering/svg/RenderSVGInline.h:
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):
(WebCore::RenderSVGModelObject::computeFloatRectForRepaint):
(WebCore::RenderSVGModelObject::mapLocalToContainer):
(WebCore::RenderSVGModelObject::outlineBoundsForRepaint):
* rendering/svg/RenderSVGModelObject.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
* rendering/svg/RenderSVGRoot.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::clippedOverflowRectForRepaint):
(WebCore::RenderSVGText::computeRectForRepaint):
(WebCore::RenderSVGText::computeFloatRectForRepaint):
(WebCore::RenderSVGText::mapLocalToContainer):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):
(WebCore::SVGRenderSupport::computeFloatRectForRepaint):
(WebCore::SVGRenderSupport::mapLocalToContainer):
* rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Make ewk_context use WebContext instead of WKContext
commit-queue@webkit.org [Thu, 8 Nov 2012 04:38:04 +0000 (04:38 +0000)]
[EFL][WK2] Make ewk_context use WebContext instead of WKContext
https://bugs.webkit.org/show_bug.cgi?id=101477

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

Refactor ewk_context to use WebContext as ewk_context is encapsulated in a C++ classes.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::create):
(EwkContext::defaultContext):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
(EwkContext::webContext):
* UIProcess/API/efl/ewk_database_manager.cpp:
(Ewk_Database_Manager::Ewk_Database_Manager):
(Ewk_Database_Manager::getDatabaseOrigins):
* UIProcess/API/efl/ewk_database_manager_private.h:
(Ewk_Database_Manager::create):
(Ewk_Database_Manager):
* UIProcess/API/efl/ewk_storage_manager.cpp:
(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):
* UIProcess/API/efl/ewk_storage_manager_private.h:
(Ewk_Storage_Manager::create):
(Ewk_Storage_Manager):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
* UIProcess/efl/RequestManagerClientEfl.cpp:
(WebKit::RequestManagerClientEfl::RequestManagerClientEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, new chromium-mac-mountainlion svg baselines.
dpranke@chromium.org [Thu, 8 Nov 2012 04:34:44 +0000 (04:34 +0000)]
Unreviewed, new chromium-mac-mountainlion svg baselines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium-win] Refactor date/time format conversion code in LocaleWin
tkent@chromium.org [Thu, 8 Nov 2012 04:12:19 +0000 (04:12 +0000)]
[Chromium-win] Refactor date/time format conversion code in LocaleWin
https://bugs.webkit.org/show_bug.cgi?id=101329

Reviewed by Kentaro Hara.

convertWindowsDateFormatToLDML and convertWindowsTimeFormatToLDML did
similar jobs with different code. We can merge them into one function.

As for the date format conversion, we have tokenized a format string and
stored token objects into a vector. We skip token object generation and
generate a LDML-compliant pattern string during parsing.

No new tests. This should make no behavior changes and
WebKit/chromium/tests/LocaleWinTest.cpp has test cases.

* platform/text/win/LocaleWin.cpp:
(WebCore): Remove DateFormatToken, isFooSymbol, ensureShortDateTokens,
convertWindowsDateFormatToLDML, mapCharacterToDateTimeFieldType, and
convertWindowsTimeFormatToLDML.
(WebCore::commitLiteralToken): Store the result to the specified StringBuilder.
(WebCore::convertWindowsDateTimeFormat):
Renamed from parseDateFormat, and supports time format symbols.
(WebCore::LocaleWin::dateFormat): Use convertWindowsDateTimeFormat.
(WebCore::LocaleWin::monthFormat): Ditto.
(WebCore::LocaleWin::timeFormat): Ditto.
(WebCore::LocaleWin::shortTimeFormat): Ditto.
* platform/text/win/LocaleWin.h:
(LocaleWin): Remove ensureShortDateTokens and m_shortDateTokens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r133428 and r133749
shinyak@chromium.org [Thu, 8 Nov 2012 04:00:28 +0000 (04:00 +0000)]
Unreviewed, rolling out r133428 and r133749
https://bugs.webkit.org/show_bug.cgi?id=101533

These patches might cause memory regression.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
(WebCore):
(WebCore::Element::setShadowPseudoId):
* dom/Element.h:
(Element):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementRareData.h:
(ElementRareData):
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement):
* html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):
* testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* fast/dom/shadow/styling-pseudo-attribute-expected.html: Removed.
* fast/dom/shadow/styling-pseudo-attribute.html: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in WebCore::RenderLayer::normalFlowList
rniwa@webkit.org [Thu, 8 Nov 2012 03:50:25 +0000 (03:50 +0000)]
Crash in WebCore::RenderLayer::normalFlowList
https://bugs.webkit.org/show_bug.cgi?id=101528

Reviewed by Simon Fraser.

Make sure the layout is up to date before re-computing the caret rect.
Avoid doing the layout when the selection is cleared since we can always stop
the blink timer in that case.

Unfortunately, we haven't found any reproduction of this crash yet.

* editing/FrameSelection.cpp:
(WebCore::isNonOrphanedCaret):
(WebCore::FrameSelection::localCaretRect):
(WebCore::FrameSelection::updateAppearance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
hayato@chromium.org [Thu, 8 Nov 2012 03:42:12 +0000 (03:42 +0000)]
Unreviewed gardening.

Marking new test editing/execCommand/switch-list-type-with-orphaned-li.html per webkit.org/b/101539.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
abarth@webkit.org [Thu, 8 Nov 2012 03:05:41 +0000 (03:05 +0000)]
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

Hopefully the memory issues with this patch have been resolved by
fixing bug 101525. This patch re-lands this patch again, hopefully for
the last time.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSeam occurred between pieces of ShadowBlur on floating point zoom
commit-queue@webkit.org [Thu, 8 Nov 2012 03:03:07 +0000 (03:03 +0000)]
Seam occurred between pieces of ShadowBlur on floating point zoom
https://bugs.webkit.org/show_bug.cgi?id=101435

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07
Reviewed by Simon Fraser.

When paint Shadow that doesn't have blurred edge on floating point zoom,
pixel seam (pixel cracks) occurred between pieces of the ShadowBlur because of unaligned clip rect.
So, enlarge the clipping area 1 pixel so that the fill does not bleed (due to antialiasing)
even if the unaligned clip rect occurred.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::calculateLayerBoundingRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, new chromium-mac-mountainlion baselines for remaining dirs outside of...
dpranke@chromium.org [Thu, 8 Nov 2012 03:01:22 +0000 (03:01 +0000)]
Unreviewed, new chromium-mac-mountainlion baselines for remaining dirs outside of fast, svg, and tables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRepaint issues with -webkit-svg-shadow used on a container
timothy_horton@apple.com [Thu, 8 Nov 2012 02:58:21 +0000 (02:58 +0000)]
Repaint issues with -webkit-svg-shadow used on a container
https://bugs.webkit.org/show_bug.cgi?id=65643
<rdar://problem/7600532>

Reviewed by Simon Fraser.

SVG renderer repaint rects are currently expanded only by the shadow of
the renderer itself; however, the area they need to repaint can be larger
than that, if their parents also have shadows. We need to take into account
parent's shadows (respecting transforms, as well).

clippedOverflowRectForRepaint already recurses upwards through the render tree,
and ends up with a rect in layout coordinates, so we manually apply the shadow
at each step (repaintRectInLocalCoordinatesExcludingSVGShadow was added to allow
us to get the raw repaint rect without the shadow baked-in).

repaintRectInLocalCoordinates now includes shadows from all parents.

Also, RenderSVGRoot was clipping repaint rects to the viewport before applying
shadows, so offscreen elements with on-screen shadows (applied by the root) would not paint the shadows.
We can just swap the order of these things to correct this.

Tests: svg/css/parent-shadow-offscreen.svg, svg/css/root-shadow-offscreen.svg, svg/repaint/repaint-webkit-svg-shadow.svg

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): Mark the child being added as having an SVG shadow if it is being added as a child of an element that does.
(WebCore::RenderObject::styleDidChange): Mark the child being added as having an SVG shadow if its new style has a shadow.
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout): Cache the repaint rect before intersecting it with the shadow.
* rendering/svg/RenderSVGImage.h:
(WebCore::RenderSVGImage::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::RenderSVGModelObject): Renderers do not have a shadow by default.
* rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::RenderSVGModelObject::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGModelObject::setHasSVGShadow): Set whether or not the renderer has a shadow.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint): Apply the shadow before clipping to the viewport, so we draw shadows for elements outside the viewport.
(WebCore::RenderSVGRoot::updateCachedBoundaries): Cache the repaint rect before intersecting it with the shadow.
* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::hasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::setHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::RenderSVGRoot::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateRepaintBoundingBox): Cache the repaint rect before intersecting it with the shadow.
* rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::repaintRectInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow): Return the cached repaint rect for the renderer without the shadow included.
(WebCore::SVGRenderSupport::clippedOverflowRectForRepaint): Apply shadows as we walk through our parents, instead of only applying the renderer's own shadow.
(WebCore::SVGRenderSupport::rendererHasSVGShadow): Return whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::setRendererHasSVGShadow): Set whether or not the renderer has a shadow.
(WebCore::SVGRenderSupport::intersectRepaintRectWithShadows): Walk through the element's parents, adding shadows to the repaint rect as we go, eventually
transforming the repaint rect back into local coordinates.
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources): Don't add shadows by default, just other resources, so that we can cache repaint rects with and without shadows.
* rendering/svg/SVGRenderSupport.h:

* platform/chromium/TestExpectations: Mark tests as needing rebaseline.
* platform/efl/TestExpectations: Mark tests as needing rebaseline.
* platform/gtk/TestExpectations: Mark tests as needing rebaseline.
* platform/qt/TestExpectations: Mark tests as needing rebaseline.

* platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
* platform/mac/svg/css/arrow-with-shadow-expected.txt:
* platform/mac/svg/css/clippath-with-shadow-expected.txt:
* platform/mac/svg/css/composite-shadow-example-expected.txt:
* platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
* platform/mac/svg/css/group-with-shadow-expected.txt:
* platform/mac/svg/css/shadow-changes-expected.txt:
* platform/mac/svg/custom/simple-text-double-shadow-expected.txt:
Rebaseline Mac results due to this change.

* svg/css/parent-shadow-offscreen-expected.svg: Added.
* svg/css/parent-shadow-offscreen.svg: Added.
Add a new test that ensures that <g> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

* svg/css/root-shadow-offscreen-expected.svg: Added.
* svg/css/root-shadow-offscreen.svg: Added.
Add a new test that ensures that <svg> with -webkit-svg-shadow applied draws when children are offscreen but the shadow is not.

* platform/mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
* svg/repaint/repaint-webkit-svg-shadow-expected.txt: Added.
* svg/repaint/repaint-webkit-svg-shadow.svg: Added.
Add a new test that ensures that SVG elements with -webkit-svg-shadow are correctly invalidated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd RemoteGraphicsLayer class
andersca@apple.com [Thu, 8 Nov 2012 02:52:49 +0000 (02:52 +0000)]
Add RemoteGraphicsLayer class
https://bugs.webkit.org/show_bug.cgi?id=101535

Reviewed by Simon Fraser.

Source/WebCore:

* WebCore.exp.in:
Export GraphicsLayer symbols required by WebKit2.

* WebCore.xcodeproj/project.pbxproj:
Make GraphicsLayerFactory.h a private header.

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/RemoteGraphicsLayer.h:
* WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
Add RemoteGraphicsLayer, a subclass of WebCore::GraphicsLayer.

* WebProcess/WebPage/mac/RemoteLayerTreeController.h:
Make RemoteLayerTreeController a GraphicsLayerFactory.

* WebProcess/WebPage/mac/RemoteLayerTreeController.mm:
(WebKit::RemoteLayerTreeController::createGraphicsLayer):
Create a new RemoteGraphicsLayer.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
Return the layer tree controller.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable Subpixel Layout on Windows. Rebaseline any failing tests that were rebaselined...
roger_fong@apple.com [Thu, 8 Nov 2012 02:52:48 +0000 (02:52 +0000)]
Enable Subpixel Layout on Windows. Rebaseline any failing tests that were rebaselined in r133351.
https://bugs.webkit.org/show_bug.cgi?id=101538

Rubberstamped by Tim Horton.

* win/tools/vsprops/FeatureDefines.vsprops:
* platform/win/css1/font_properties/font-expected.txt:
* platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/win/editing/selection/caret-ltr-right-expected.txt:
* platform/win/editing/selection/caret-rtl-2-left-expected.txt:
* platform/win/editing/selection/caret-rtl-right-expected.txt:
* platform/win/editing/selection/mixed-editability-10-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/win/fast/borders/bidi-012-expected.txt:
* platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
* platform/win/fast/forms/file/file-input-disabled-expected.txt:
* platform/win/fast/inline/inline-box-background-expected.txt:
* platform/win/fast/inline/inline-box-background-long-image-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/win/fast/lists/003-vertical-expected.txt:
* platform/win/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operation...
keishi@webkit.org [Thu, 8 Nov 2012 01:41:33 +0000 (01:41 +0000)]
[Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101408

Reviewed by Kent Tamura.

Mistake with timezone was making this test flaky.

* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, new chromium-mac-mountainlion baselines for css3/selectors3.
dpranke@chromium.org [Thu, 8 Nov 2012 01:39:35 +0000 (01:39 +0000)]
Unreviewed, new chromium-mac-mountainlion baselines for css3/selectors3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Don't leak <img> elements in content scripts
abarth@webkit.org [Thu, 8 Nov 2012 01:29:45 +0000 (01:29 +0000)]
[V8] Don't leak <img> elements in content scripts
https://bugs.webkit.org/show_bug.cgi?id=101525

Reviewed by Ojan Vafai.

I found the leak that was causing a problem for bug 101110. We weren't
filling in the derefObjectFunction for HTMLImageElements (and
potentially some other types of elements). That manifests today as a
memory leak in content scripts (which use the derefObjectFunction for
nodes) and caused a memory leak after bug 101110 because we started
using the derefObjectFunction in the main world as well.

This patch adds ASSERTs so that we won't make this mistake in the future.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::defaultWeakCallback):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Make WebVibrationProxy to be a member of WebPageProxy.
commit-queue@webkit.org [Thu, 8 Nov 2012 01:29:28 +0000 (01:29 +0000)]
[WK2] Make WebVibrationProxy to be a member of WebPageProxy.
https://bugs.webkit.org/show_bug.cgi?id=100334

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-07
Reviewed by Anders Carlsson.

WebVibrationProxy should be a member of WebPageProxy, because the IPC
messages of WebVibrationProxy have page destination ID.

The r132386 proposed a way to add/delete message receivers that can
handle IPC messages with destination ID.

Previous implementation that creating WebVibrationProxy as a WebContext
member and using the global message receiver for the proxy can make
assertions after r132386.

To handle the vibration IPC messages properly, this patch will do the
followings.

1) Instead of WebContext, WebPageProxy will have the WebVibrationProxy.

2) WebVibrationProxy will add itself to the message receiver map of
   the WebContext with page destination ID.

3) When WebProcessProxy received vibration ipc messages, it will
   forward the messages to the WebContext first. Then the message
   receiver map of the WebContext will handle the messages with the
   registered WebVibrationProxy.

4) APIs will be modified to apply these changes.
   a) WK API to get WKVibrationRef will use WKPageRef not WKContextRef.
   b) EFL APIs and API test for the vibration will also be changed.
      - EwkViewImpl will have vibration client. (EwkContext will not
        have it)
      - Previous API to register the vibration callback will be removed.
      - New signals for vibration will be added to the EwkViewImpl.
      - VibrationProxy will be renamed to VibrationClient for the
        consistency with other clients in EwkViewImpl.
      - VibrationClient will use EwkViewImpl instead of EwkContext.
      - Previous API test for vibration will be moved from context test
        to view test, and it will use the changed API.

* PlatformEfl.cmake:
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetVibration):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/efl/EwkViewCallbacks.h:
(EwkViewCallbacks):
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
(WebKit):
(EwkContext):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(VibrationCbData):
(onVibrate):
(onCancelVibration):
(loadVibrationHTMLString):
(TEST_F):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
* UIProcess/WebContext.h:
(WebKit):
(WebContext):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
(WebKit):
(WebPageProxy):
(WebKit::WebPageProxy::vibration):
* UIProcess/WebVibrationProxy.cpp:
(WebKit::WebVibrationProxy::create):
(WebKit::WebVibrationProxy::WebVibrationProxy):
(WebKit::WebVibrationProxy::~WebVibrationProxy):
(WebKit::WebVibrationProxy::invalidate):
* UIProcess/WebVibrationProxy.h:
(WebKit):
(WebVibrationProxy):
* UIProcess/efl/VibrationClientEfl.cpp: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.cpp.
(toVibrationClient):
(VibrationClientEfl::vibrateCallback):
(VibrationClientEfl::cancelVibrationCallback):
(VibrationClientEfl::create):
(VibrationClientEfl::VibrationClientEfl):
(VibrationClientEfl::~VibrationClientEfl):
* UIProcess/efl/VibrationClientEfl.h: Renamed from Source/WebKit2/UIProcess/efl/VibrationProvider.h.
(WebKit):
(VibrationClientEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd empty RemoteLayerTree class
andersca@apple.com [Thu, 8 Nov 2012 01:26:48 +0000 (01:26 +0000)]
Add empty RemoteLayerTree class
https://bugs.webkit.org/show_bug.cgi?id=101524

Reviewed by Simon Fraser.

Add a new RemoteLayerTree class which will contain the remote graphics layers.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/RemoteLayerTree.h: Added.
* WebProcess/WebPage/mac/RemoteLayerTree.mm: Added.
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Thu, 8 Nov 2012 01:18:09 +0000 (01:18 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Prepare for IDBBackingStore merge by renaming IDBLevelDBBackingStore.cpp
alecflett@chromium.org [Thu, 8 Nov 2012 01:16:53 +0000 (01:16 +0000)]
IndexedDB: Prepare for IDBBackingStore merge by renaming IDBLevelDBBackingStore.cpp
https://bugs.webkit.org/show_bug.cgi?id=101486

Reviewed by Ojan Vafai.

Rename IDBLevelDBBackingStore.cpp to IDBBackingStore.cpp in
preparation for merging these classes. This will make the merge
diffs sane. See https://bugs.webkit.org/show_bug.cgi?id=101415
for the final goal.

No new tests, this is is just a rename and minor style fix.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/indexeddb/IDBBackingStore.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Prepare DOMDataStore to be able to store ScriptWrappable wrappers inline
abarth@webkit.org [Thu, 8 Nov 2012 00:56:20 +0000 (00:56 +0000)]
[V8] Prepare DOMDataStore to be able to store ScriptWrappable wrappers inline
https://bugs.webkit.org/show_bug.cgi?id=101523

Unreviewed. Technically this patch hasn't been reviewed, but it is part
of a patch that was reviewed by Kentaro Hara.

Sadly, my patch for bug 101110 triggered the regression again. This
patch is a smaller incremental step towards the patch in bug 101110. It
doesn't make that much sense on its own, but it will help me isolate
the source of the regression.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(DOMDataStore):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::wrapperIsStoredInObject):
(WebCore::DOMDataStore::getWrapperFromObject):
(WebCore::DOMDataStore::setWrapperInObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, fix mistakenly added pngs for failing compositing ref tests :(.
dpranke@chromium.org [Thu, 8 Nov 2012 00:52:38 +0000 (00:52 +0000)]
Unreviewed, fix mistakenly added pngs for failing compositing ref tests :(.

* platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Removed.
* platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, clean up chromium-mac-mountainlion for remaining compositing, css3 (non...
dpranke@chromium.org [Thu, 8 Nov 2012 00:36:15 +0000 (00:36 +0000)]
Unreviewed, clean up chromium-mac-mountainlion for remaining compositing, css3 (non selectors3) tests.

* platform/chromium-mac-lion/css3/css3-modsel-33-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-33-expected.png.
* platform/chromium-mac-lion/css3/css3-modsel-35-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-35-expected.png.
* platform/chromium-mac-lion/css3/css3-modsel-36-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-36-expected.png.
* platform/chromium-mac-lion/css3/css3-modsel-37-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/css3-modsel-37-expected.png.
* platform/chromium-mac-lion/css3/flexbox/repaint-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/flexbox/repaint-expected.png.
* platform/chromium-mac-lion/css3/font-feature-settings-rendering-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/font-feature-settings-rendering-expected.png.
* platform/chromium-mac-lion/css3/unicode-bidi-isolate-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png.
* platform/chromium-mac-mountainlion/TestExpectations:
* platform/chromium-mac/compositing/text-on-scaled-layer-expected.png: Added.
* platform/chromium-mac/compositing/text-on-scaled-surface-expected.png: Added.
* platform/chromium-mac/css3/css3-modsel-33-expected.png:
* platform/chromium-mac/css3/css3-modsel-35-expected.png:
* platform/chromium-mac/css3/css3-modsel-36-expected.png:
* platform/chromium-mac/css3/css3-modsel-37-expected.png:
* platform/chromium-mac/css3/flexbox/repaint-expected.png:
* platform/chromium-mac/css3/font-feature-settings-rendering-expected.png:
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplifyMarkupCommand takes a disproportionally long time to run when there are many...
rniwa@webkit.org [Thu, 8 Nov 2012 00:35:58 +0000 (00:35 +0000)]
SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144

Reviewed by Enrica Casucci.

The bug was caused by attach() happening between each node removal. Since the command was trying
to remove millions of node in some cases, attach()ing render objects for each node being reinserted
imposed a huge runtime cost.

Fixed the bug by using lazy attach when removing nodes and avoiding calls to isContentEditable.
Also remove all ancestors at once when they are direct child/parent of each other so that we don't
remove an ancestor and then insert its child back only to remove it again in the next iteration.

No new tests since it doesn't change the asymptotic performance, and adding a new performance test for
this specific case is not the worth the increase in the bot cycle time. I'll note that the email
attached in the original radar bug (<rdar://problem/12179712>) took 100 seconds to open now only takes
7 seconds to open on my MacPro.

* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::doApply): Takes a flag indicating whether we should assume nodes are editable
without calling isContentEditable or not.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Update the style as later code requires render
object.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::insertNodeBefore): Passes a flag to the command.
(WebCore::CompositeEditCommand::removeNode): Ditto.
(WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto.
* editing/CompositeEditCommand.h:
(CompositeEditCommand):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeNode): Takes a flag indicating whether we should assume nodes are
editable without calling isContentEditable or not.
* editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):
* editing/EditCommand.h:
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply): Update the layout when password echo is enabled since
we need to have render objects for echoing.
* editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.
(WebCore::InsertNodeBeforeCommand::doApply): Ditto; also always use lazy attach.
(WebCore::InsertNodeBeforeCommand::doUnapply):
* editing/InsertNodeBeforeCommand.h:
(WebCore::InsertNodeBeforeCommand::create):
(InsertNodeBeforeCommand):
* editing/RemoveNodeCommand.cpp:
(WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto about the flag.
(WebCore::RemoveNodeCommand::doApply):
* editing/RemoveNodeCommand.h:
(WebCore::RemoveNodeCommand::create):
(RemoveNodeCommand):
* editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
* editing/RemoveNodePreservingChildrenCommand.h:
(WebCore::RemoveNodePreservingChildrenCommand::create):
(RemoveNodePreservingChildrenCommand):
* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove): Added to optimize removals of multiple
ancestors.
* editing/SimplifyMarkupCommand.h:
(SimplifyMarkupCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, chromium expectations cleanup
dpranke@chromium.org [Thu, 8 Nov 2012 00:22:25 +0000 (00:22 +0000)]
Unreviewed, chromium expectations cleanup

Remove entries for a couple of passing tests and one stale pixel
result for a reftest.

* platform/chromium-mac-mountainlion/TestExpectations:
* platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r133810.
abarth@webkit.org [Thu, 8 Nov 2012 00:20:16 +0000 (00:20 +0000)]
Unreviewed, rolling out r133810.
http://trac.webkit.org/changeset/133810
https://bugs.webkit.org/show_bug.cgi?id=101520

This patch made ws_single_peak_r regress by 15% (Requested by
abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, update chromium-mac-ml expectations after r133811 and r133814.
dpranke@chromium.org [Thu, 8 Nov 2012 00:14:39 +0000 (00:14 +0000)]
Unreviewed, update chromium-mac-ml expectations after r133811 and r133814.

* platform/chromium-mac-mountainlion/TestExpectations:
* platform/chromium-mac/css2.1/20110323/border-conflict-element-001d-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-007-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-010-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-012-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-013-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-014-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/overflow-applies-to-015-expected.png: Removed.
* platform/chromium-mac/css2.1/20110323/text-indent-014-expected.png: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Remove exif-orientation-image-document.html from failure list
commit-queue@webkit.org [Thu, 8 Nov 2012 00:11:02 +0000 (00:11 +0000)]
[EFL] Remove exif-orientation-image-document.html from failure list
https://bugs.webkit.org/show_bug.cgi?id=101518

Unreviewed gardening.

fast/images/exif-orientation-image-document.html passes after r133728

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-07

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaselinene after external SVG unblocked in WK100485
pdr@google.com [Thu, 8 Nov 2012 00:09:08 +0000 (00:09 +0000)]
Rebaselinene after external SVG unblocked in WK100485
https://bugs.webkit.org/show_bug.cgi?id=101248

Unreviewed update of test expectations.

* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
* platform/chromium-linux/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added property svn:mime-type.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added property svn:mime-type.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, update chromium-mac-mountainlion baselines for css2.1
dpranke@chromium.org [Wed, 7 Nov 2012 23:48:24 +0000 (23:48 +0000)]
Unreviewed, update chromium-mac-mountainlion baselines for css2.1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up confused use of Document::renderer and renderView
commit-queue@webkit.org [Wed, 7 Nov 2012 23:37:12 +0000 (23:37 +0000)]
Clean up confused use of Document::renderer and renderView
https://bugs.webkit.org/show_bug.cgi?id=101484

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-07
Reviewed by Ojan Vafai.

Document::renderer and Document::renderView are the same thing, but it seems
people don't always realize it and check if document()->renderer() is a RenderView.

This patch cleans up usage of document()->renderer() and document()->renderView() and
simplifies the code that was written without realizing they were the same thing.

No new tests, this is just a refactor.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint): Lots of simplification.
* dom/Element.cpp:
(WebCore::Element::screenRect):
(WebCore::Element::unregisterNamedFlowContentNode): Remove unneeded conditional.
* editing/FrameSelection.cpp: Remove verbose casts.
(WebCore::clearRenderViewSelection):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* page/Frame.cpp:
(WebCore::Frame::contentRenderer): Vastly simplified.
* page/PrintContext.cpp: Remove verbose casts.
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
* page/wince/FrameWinCE.cpp:
(WebCore::computePageRectsForFrame): Remove unreachable code.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::maximalOutlineSize): Remove verbose cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeakBlocks should be HeapBlocks
mhahnenberg@apple.com [Wed, 7 Nov 2012 23:34:30 +0000 (23:34 +0000)]
WeakBlocks should be HeapBlocks
https://bugs.webkit.org/show_bug.cgi?id=101411

Reviewed by Oliver Hunt.

Currently WeakBlocks use fastMalloc memory. They are very similar to the other HeapBlocks, however,
so we should change them to being allocated with the BlockAllocator.

* heap/BlockAllocator.cpp:
(JSC::BlockAllocator::BlockAllocator):
* heap/BlockAllocator.h: Added a new RegionSet for WeakBlocks.
(JSC):
(BlockAllocator):
(JSC::WeakBlock):
* heap/Heap.h: Friended WeakSet to allow access to the BlockAllocator.
(Heap):
* heap/WeakBlock.cpp:
(JSC::WeakBlock::create): Refactored to use HeapBlocks rather than fastMalloc.
(JSC::WeakBlock::WeakBlock):
* heap/WeakBlock.h: Changed the WeakBlock size to 4 KB so that it divides evenly into the Region size.
(JSC):
(WeakBlock):
* heap/WeakSet.cpp:
(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, update chromium-mac-mountainlion baselines for css2.1/2011/0323
dpranke@chromium.org [Wed, 7 Nov 2012 23:25:07 +0000 (23:25 +0000)]
Unreviewed, update chromium-mac-mountainlion baselines for css2.1/2011/0323

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
abarth@webkit.org [Wed, 7 Nov 2012 23:11:23 +0000 (23:11 +0000)]
[V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Reviewed by Kentaro Hara.

This patch generalizes our support for storing wrappers in DOM objects
to be usable for more than just nodes. After this patch, any object
with a ScriptWrappable base class will have its wrapper stored inline
in the object in the main world.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::weakCallback):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed gardening.
jsbell@chromium.org [Wed, 7 Nov 2012 23:01:35 +0000 (23:01 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Update BB10 form theme.
commit-queue@webkit.org [Wed, 7 Nov 2012 22:48:24 +0000 (22:48 +0000)]
[BlackBerry] Update BB10 form theme.
https://bugs.webkit.org/show_bug.cgi?id=100760

Patch by Tiancheng Jiang <tijiang@rim.com> on 2012-11-07
Reviewed by Rob Buis.

RIM PR 236997
Internally Reviewed by Jakob Petsovits.

Set font family to fix DRT test fast/forms/input-type-text-min-width.html

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::defaultGUIFont):
(WebCore):
(WebCore::RenderThemeBlackBerry::systemFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agohttps://bugs.webkit.org/show_bug.cgi?id=101303
bdakin@apple.com [Wed, 7 Nov 2012 22:27:12 +0000 (22:27 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=101303
Fixed position elements that are out of view still end up forcing
non-threaded scrolling
-and corresponding-
<rdar://problem/12642222>

Reviewed by Simon Fraser.

Source/WebCore:

Re-name hasNonLayerFixedObjects() to
hasVisibleSlowRepaintFixedObjects() and make it virtual.
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintFixedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
* page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):

Override hasVisibleSlowRepaintFixedObjects() to always return false.
We don't want to bother with the extra computation in the
ScrollingCoordinator implementation, though other ports might still
want it.
* page/scrolling/mac/ScrollingCoordinatorMac.h:
(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintFixedObjects):
(ScrollingCoordinatorMac):

Make this function const so that we can call it from
requiresCompositingForPosition().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

Actually be thorough here and check if the fixed object has any
descendants that are visible in the view. If it does, then we do
want to composite the fixed object.
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
* rendering/RenderLayerCompositor.h:

LayoutTests:

New tests for an invisible fixed object that has visible children.
* compositing/absolute-inside-out-of-view-fixed-expected.txt: Added.
* compositing/absolute-inside-out-of-view-fixed.html: Added.
* platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed-expected.txt: Added.
* platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html: Added.

Updated results because these tests can now scroll on the scrolling
thread, yay!
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt:
* platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Style fix following r133262.
roger_fong@apple.com [Wed, 7 Nov 2012 21:58:00 +0000 (21:58 +0000)]
Unreviewed. Style fix following r133262.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
* html/HTMLMediaElement.h:
(HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] DOMWrapperMap doesn't need to use virtual functions
abarth@webkit.org [Wed, 7 Nov 2012 21:45:32 +0000 (21:45 +0000)]
[V8] DOMWrapperMap doesn't need to use virtual functions
https://bugs.webkit.org/show_bug.cgi?id=101494

Reviewed by Kentaro Hara.

DOMWrapperMap has only one subclass. There's no reason to use virtual functions.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::get):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::clear):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(WebCore::DOMWrapperMap::remove):
(WebCore::DOMWrapperMap::defaultWeakCallback):
* bindings/v8/V8NPObject.cpp:
(WebCore::staticNPObjectMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agogarden-o-matic should handle concurrent requests
dpranke@chromium.org [Wed, 7 Nov 2012 21:42:32 +0000 (21:42 +0000)]
garden-o-matic should handle concurrent requests
https://bugs.webkit.org/show_bug.cgi?id=101407

Reviewed by Ojan Vafai.

Garden-o-Matic is implemented on top of the BaseHttpServer
python library, which implements a single-threaded (one request at
a time) server. This means that we can only rebaseline one test at
a time, and when using a local results file, even fetching the results
for diffs is single-threaded.

Mixing in the ThreadingMixin enables concurrent requests (subject
to the global python interpreter lock). Given that we're doing all
of the work in webkit-patch subprocesses, I think this is safe.

Of course, it may not be safe to do some of the subprocesses in
parallel (e.g., rollout), but I think as long as we don't issue
commands that touch overlapping sets of files things should be fine.
The file locking over modifying testexpectations should keep that
from being corrupted.

* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPServer):
(GardeningHTTPRequestHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilter...
achicu@adobe.com [Wed, 7 Nov 2012 21:30:54 +0000 (21:30 +0000)]
[CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=101071

Reviewed by Dean Jackson.

I've removed the need to get a CustomFilterValidatedProgram from FilterEffectRenderer. It was only
used to delay the compilation of the shader until it was really needed. Instead, the FilterEffectRenderer
will directly get the compiled shader in the constructor. The callers that still want to avoid
compiling the shader until it is really needed can use the setCompiledProgram to inject the shader
at a later time, before painting.

No new tests, the change is covered by the css3/filters/custom/ tests.

* platform/graphics/filters/CustomFilterConstants.h:
* platform/graphics/filters/CustomFilterProgramInfo.h:
* platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::setCompiledProgram):
(WebCore):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):
* platform/graphics/filters/CustomFilterRenderer.h:
(WebCore):
(CustomFilterRenderer):
(WebCore::CustomFilterRenderer::compiledProgram):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::prepareForDrawing):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
rwlbuis@webkit.org [Wed, 7 Nov 2012 21:30:05 +0000 (21:30 +0000)]
[BlackBerry] Remove setUserStyleSheetString/userStyleSheetString
https://bugs.webkit.org/show_bug.cgi?id=101490

Reviewed by Yong Li.

We no longer need this API.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate expectations for svg/text/text-rescale.svg
pdr@google.com [Wed, 7 Nov 2012 21:24:03 +0000 (21:24 +0000)]
Update expectations for svg/text/text-rescale.svg

Unreviewed update of test expectations.

This test needed a rebaseline after r133786.

* platform/chromium-win/svg/text/text-rescale-expected.png:
* platform/efl/svg/text/text-rescale-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndentation of ArgList.h is wrong
fpizlo@apple.com [Wed, 7 Nov 2012 21:15:57 +0000 (21:15 +0000)]
Indentation of ArgList.h is wrong
https://bugs.webkit.org/show_bug.cgi?id=101441

Reviewed by Andreas Kling.

Just unindented by 4 spaces.

* runtime/ArgList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove build-webkit dependency on Java SDK for Apple Mac WebKit.
commit-queue@webkit.org [Wed, 7 Nov 2012 21:10:11 +0000 (21:10 +0000)]
Remove build-webkit dependency on Java SDK for Apple Mac WebKit.
<http://webkit.org/b/101492>

Patch by Andreas Kling <akling@apple.com> on 2012-11-07
Reviewed by Anders Carlsson.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Remove WebJavaPlugIn.h

Source/WebKit/mac:

* Plugins/WebJavaPlugIn.h: Removed.

Tools:

Don't check for a Java SDK before building the Apple Mac port. It's no longer needed for
the build after the Java bridge was removed.

* Scripts/build-webkit:
(cMakeArgsFromFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
commit-queue@webkit.org [Wed, 7 Nov 2012 21:08:11 +0000 (21:08 +0000)]
[EFL][WK2] Allow client to override setWindowFrame() / getWindowFrame()
https://bugs.webkit.org/show_bug.cgi?id=101496

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add window_geometry_set() / window_geometry_get() smart functions to
ewk_view allowing the client to provide its own implementation for
those.

This is particularly useful if the application uses elm_win because
the default implementation will not behave correctly in this case.
This is due to the fact that the default implementation interacts
with the Ecore_Evas that contains the view and is not aware of the
parent window widget.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::windowGeometry):
(EwkViewImpl::setWindowGeometry):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):

Tools:

Provide implementation for on_window_geometry_get() / on_window_geometry_set()
smart functions that interact with the elm_win widget.

* MiniBrowser/efl/main.c:
(on_window_geometry_get):
(on_window_geometry_set):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding myself to commiters.py.
luciano.wolf@openbossa.org [Wed, 7 Nov 2012 20:54:04 +0000 (20:54 +0000)]
Adding myself to commiters.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix asm operand type for weakCompareAndSwap on ARM_THUMB2
hans@chromium.org [Wed, 7 Nov 2012 20:47:51 +0000 (20:47 +0000)]
Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=101238

Reviewed by Benjamin Poulain.

'result' was a bool, but the asm was expecting a 32-bit register. A
recent version of Clang warned about this:

  WebKit/Source/WTF/wtf/Atomics.h:163:34: error: the size being stored
  is truncated, use a modifier to specify the size [-Werror,-Wasm-operand-widths]

This patch fixes it by making 'result' an unsigned. It does not change
the functionality in practice ('result' would be in a 32-bit register
anyway), but it makes the code more correct and makes the warning go
away.

Also make 'result' for the X86 version an 'unsigned char' to make it
more clear that it is a byte.

* wtf/Atomics.h:
(WTF::weakCompareAndSwap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2][AC] API tests crash
commit-queue@webkit.org [Wed, 7 Nov 2012 20:41:26 +0000 (20:41 +0000)]
[EFL][WK2][AC] API tests crash
https://bugs.webkit.org/show_bug.cgi?id=101480

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

When AC is enabled, 8 API tests are crashing. We need to properly set the evas engine for these tests.

* TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted
abarth@webkit.org [Wed, 7 Nov 2012 20:39:34 +0000 (20:39 +0000)]
[V8] IntrusiveDOMWrapperMap is no longer needed and can be deleted
https://bugs.webkit.org/show_bug.cgi?id=101493

Reviewed by Kentaro Hara.

This patch is another incremental step towards landing the patch in bug
101110. In this patch, we delete IntrusiveDOMWrapperMap, which is no
longer needed.

* WebCore.gypi:
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::~DOMDataStore):
(WebCore::DOMDataStore::reportMemoryUsage):
(WebCore::DOMDataStore::weakCallback):
(WebCore):
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::get):
(WebCore::DOMDataStore::set):
(DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h: Removed.
* bindings/v8/V8GCController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFunction adoptNS and adoptCF should not generate memory leak diagnostic with Clang...
commit-queue@webkit.org [Wed, 7 Nov 2012 20:35:27 +0000 (20:35 +0000)]
Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer.
https://bugs.webkit.org/show_bug.cgi?id=101420

Patch by Remy Demarest <rdemarest@apple.com> on 2012-11-07
Reviewed by Benjamin Poulain.

Add attributes to the adoptNS and adoptCF function arguments to remove Clang Static Analyzer diagnotics.
Define CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not available, use them in function declarations.

* wtf/RetainPtr.h:
(WTF::adoptCF): Adds CF_RELEASES_ARGUMENT attribute to the argument.
(WTF::adoptNS): Adds NS_RELEASES_ARGUMENT attribute to the argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding myself to commiters.py.
lauro.neto@openbossa.org [Wed, 7 Nov 2012 20:34:54 +0000 (20:34 +0000)]
Adding myself to commiters.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking...
commit-queue@webkit.org [Wed, 7 Nov 2012 20:32:59 +0000 (20:32 +0000)]
[AC] glXChooseFBConfig() and glXGetVisualFromFBConfig() return values are leaking in GraphicsSurface
https://bugs.webkit.org/show_bug.cgi?id=101475

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Free the memory returned by glXChooseFBConfig and glXGetVisualFromFBConfig
using XFree to avoid memory leaks.

No tests. No change in behavior.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAutoresize should work even if turned on while the page is loading.
fsamuel@chromium.org [Wed, 7 Nov 2012 20:10:47 +0000 (20:10 +0000)]
Autoresize should work even if turned on while the page is loading.
https://bugs.webkit.org/show_bug.cgi?id=101380

Reviewed by David Levin.

Autoresize does not work in cases where it is turned on while loading.
This patch addresses this by allowing autoSize to complete if it's turned on
while loading and doing a final pass after loading.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
Adjust to call renamed function.
* page/FrameView.cpp:
(WebCore::FrameView::handleLoadCompleted):
Rename function to encompass its expanded responsibilities (which include doing the final auto size after the load is completed).
(WebCore::FrameView::autoSizeIfEnabled):
Allow the size to shrink if autosize is adjusted while the page is loading.
* page/FrameView.h:
(FrameView):
Renamed 'checkFlushDeferredRepaintsAfterLoadComplete' to 'handleLoadComplete'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Open link in this window action
ossy@webkit.org [Wed, 7 Nov 2012 19:49:30 +0000 (19:49 +0000)]
[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Patch by Allan Sandfeld Jensen <allan.jensen@digia.com> on 2012-11-07
Reviewed by Csaba Osztrogon√°c.

* Api/qwebpage.cpp: Fix after r133763, move the initialization of OpenLinkInThisWindow to the proper place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL build fix.
eae@chromium.org [Wed, 7 Nov 2012 19:35:23 +0000 (19:35 +0000)]
Unreviewed EFL build fix.

* ewk/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd API for touchEventHandlerRegion to WebLayer
commit-queue@webkit.org [Wed, 7 Nov 2012 19:31:17 +0000 (19:31 +0000)]
Add API for touchEventHandlerRegion to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=101406

Patch by Yusuf Ozuysal <yusufo@google.com> on 2012-11-07
Reviewed by James Robinson.

These will be used to keep track of JavaScript touch event handlers from the compositor thread.

* chromium/public/WebLayer.h:
(WebKit::WebLayer::setTouchEventHandlerRegion):
(WebKit::WebLayer::touchEventHandlerRegion):
(WebLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip SVG repaint tracking when parent container transforms
pdr@google.com [Wed, 7 Nov 2012 19:26:57 +0000 (19:26 +0000)]
Skip SVG repaint tracking when parent container transforms
https://bugs.webkit.org/show_bug.cgi?id=101177

Reviewed by Eric Seidel.

Source/WebCore:

This patch skips child repaint rect checks when a parent container is transformed, leading
to a 75% increase on the RoboHornet SVG benchmark:
    http://www.robohornet.org/#et=svg  (average of 2 runs)
    Before patch: 161.6ms
    After patch: 38.5ms

SVG transforms are relative to the local container which makes calculating an absolute
repaint rect expensive because it requires multiplying the local repaint rect by each
parent container's local transform. See SVGRenderSupport::computeFloatRectForRepaint
as an example of this calculation.

This patch takes advantage of SVG's container rules: when a parent container's transform
changes, all children must be repainted (there is no absolute positioning in SVG).
SVGRenderSupport::checkForSVGRepaintDuringLayout has been added which checks for whether
the parent transform changed before doing child repaint checks. A similar optimization is
used in HTML (see RenderObject::checkForRepaintDuringLayout) where no repaint checking
is done when the view is fully repainted.

This code is tested in existing tests.

* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::layout):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::layout):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::checkForSVGRepaintDuringLayout):
(WebCore):
* rendering/svg/SVGRenderSupport.h:
(SVGRenderSupport):

LayoutTests:

The repaint area in svg/repaint/inner-svg-change-viewBox.svg has
been tightened as a result of this patch.

* platform/chromium/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Textfields don't get focus when navigated to from 'show all tabs' button
cfleizach@apple.com [Wed, 7 Nov 2012 19:24:10 +0000 (19:24 +0000)]
AX: Textfields don't get focus when navigated to from 'show all tabs' button
https://bugs.webkit.org/show_bug.cgi?id=101369

Reviewed by Darin Adler.

When focus leaves a webpage, the webpage does not normally clear its focused node. When focus
returns (through tab, or mouse click), then focus will be cleared and restored.

However, when focus is returned through accessibility means, focus is not cleared first, which
means subsequent focus actions do nothing.

This fix will check if the focused node is the same as the node being focused, and if so, clear the focus first.

Making a layout test for this is not possible because it requires setting focus to something in the chrome, and then
moving focus back to the webpage.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Text on scaled layer is blurry
kbalazs@webkit.org [Wed, 7 Nov 2012 19:02:19 +0000 (19:02 +0000)]
[Qt] Text on scaled layer is blurry
https://bugs.webkit.org/show_bug.cgi?id=101491

Unreviewed gardening.

Mark tests as ImageOnlyFailure.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] We should hide the DOMWrapperMaps inside DOMDataStore
abarth@webkit.org [Wed, 7 Nov 2012 18:59:52 +0000 (18:59 +0000)]
[V8] We should hide the DOMWrapperMaps inside DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101430

Reviewed by Kentaro Hara.

Source/WebCore:

This is yet another incremental step towards landing the patch in bug
101110. In this patch, we hide the existence of DOMWrapperMaps inside
DOMDataStore. In the process, we can remove V8DOMMap.cpp.

* UseV8.cmake:
* WebCore.gypi:
* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::set):
* bindings/v8/DOMWrapperWorld.h:
* bindings/v8/ScriptProfiler.cpp:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::neuterBinding):
* bindings/v8/V8DOMMap.cpp: Removed.
* bindings/v8/V8DOMMap.h: Removed.
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::getCachedWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/WorkerContextExecutionProxy.cpp:
* bindings/v8/WorkerScriptController.cpp:

Source/WebKit/chromium:

Remove unneeded header includes.

* src/WebScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable text dump in fast/forms/file/get-file-upload.html earlier.
rakuco@webkit.org [Wed, 7 Nov 2012 18:53:55 +0000 (18:53 +0000)]
Enable text dump in fast/forms/file/get-file-upload.html earlier.
https://bugs.webkit.org/show_bug.cgi?id=101468

Reviewed by Kentaro Hara.

Do not call testRunner.dumpAsText() only when processing the form
submission, since that will not be triggered if a port does not
support, say, beginDragWithFiles(), and a useless pixel result
will be generated in that case.

Instead, call dumpAsText() as early as possible.

* fast/forms/file/get-file-upload.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditio...
ossy@webkit.org [Wed, 7 Nov 2012 18:49:08 +0000 (18:49 +0000)]
[Qt][ARM] REGRESSION(r133688): It made all JSC and layout tests crash on ARM traditional platform
https://bugs.webkit.org/show_bug.cgi?id=101465

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-07
Reviewed by Oliver Hunt.

Fix failing javascriptcore tests on ARM after r133688

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd new gesture type, LongTap, which is basically the completion of a GestureLongPress
commit-queue@webkit.org [Wed, 7 Nov 2012 18:37:18 +0000 (18:37 +0000)]
Add new gesture type, LongTap, which is basically the completion of a GestureLongPress
https://bugs.webkit.org/show_bug.cgi?id=101385

Patch by Varun Jain <varunjain@chromium.org> on 2012-11-07
Reviewed by Adam Barth.

Test: Only creating the new enum. No functionality change, hence no tests required.

Source/WebCore:

* platform/PlatformEvent.h:

Source/WebKit/chromium:

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):
* src/PageWidgetDelegate.cpp:
(WebKit::PageWidgetDelegate::handleInputEvent):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove LayoutTypes abstraction
eae@chromium.org [Wed, 7 Nov 2012 18:33:44 +0000 (18:33 +0000)]
Remove LayoutTypes abstraction
https://bugs.webkit.org/show_bug.cgi?id=93050

Reviewed by Levi Weintraub.

Remove LayoutTypes abstraction and rename FractionalLayout* to
Layout* now that all platforms use the FractionalLayout version
(albeit with different fractions).

No new tests, no change in functionality.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityNodeObject.cpp:
* accessibility/AccessibilityNodeObject.h:
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.h:
* css/LengthFunctions.cpp:
* css/LengthFunctions.h:
* dom/Document.h:
* dom/DocumentMarkerController.h:
* dom/ElementRareData.h:
* dom/MouseRelatedEvent.h:
* dom/Node.h:
* dom/Touch.h:
* editing/FrameSelection.cpp:
* editing/FrameSelection.h:
* editing/RenderedPosition.h:
* html/HTMLAreaElement.h:
* inspector/InspectorOverlay.h:
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
* inspector/TimelineRecordFactory.h:
* loader/cache/CachedImage.h:
* page/FocusController.h:
* page/FrameView.h:
* page/Page.h:
* page/SpatialNavigation.cpp:
* page/SpatialNavigation.h:
* platform/FractionalLayoutUnit.h: Removed.
* platform/LayoutUnit.h: Copied from Source/WebCore/platform/FractionalLayoutUnit.h.
* platform/Length.h:
* platform/PopupMenuClient.h:
* platform/animation/AnimationUtilities.h:
* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/FractionalLayoutBoxExtent.cpp: Removed.
* platform/graphics/FractionalLayoutBoxExtent.h: Removed.
* platform/graphics/FractionalLayoutPoint.h: Removed.
* platform/graphics/FractionalLayoutRect.cpp: Removed.
* platform/graphics/FractionalLayoutRect.h: Removed.
* platform/graphics/FractionalLayoutSize.h: Removed.
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayerAnimation.cpp:
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
* platform/graphics/LayoutBoxExtent.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.cpp.
* platform/graphics/LayoutBoxExtent.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutBoxExtent.h.
* platform/graphics/LayoutPoint.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutPoint.h.
* platform/graphics/LayoutRect.cpp: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.cpp.
* platform/graphics/LayoutRect.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutRect.h.
* platform/graphics/LayoutSize.h: Copied from Source/WebCore/platform/graphics/FractionalLayoutSize.h.
* platform/graphics/MediaPlayer.h:
* platform/graphics/filters/CustomFilterOperation.h:
* platform/graphics/filters/CustomFilterParameterList.h:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/filters/FilterOperations.h:
* platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
* platform/graphics/filters/ValidatedCustomFilterOperation.h:
* platform/graphics/qt/FractionalLayoutPointQt.cpp: Removed.
* platform/graphics/qt/FractionalLayoutRectQt.cpp: Removed.
* platform/graphics/qt/FractionalLayoutSizeQt.cpp: Removed.
* platform/graphics/qt/LayoutPointQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutPointQt.cpp.
* platform/graphics/qt/LayoutRectQt.cpp: Added.
* platform/graphics/qt/LayoutSizeQt.cpp: Copied from Source/WebCore/platform/graphics/qt/FractionalLayoutSizeQt.cpp.
* platform/graphics/transforms/TransformOperations.h:
* platform/graphics/transforms/TransformState.h:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* rendering/AutoTableLayout.h:
* rendering/ColumnInfo.h:
* rendering/ExclusionShapeInsideInfo.h:
* rendering/FilterEffectRenderer.h:
* rendering/FixedTableLayout.h:
* rendering/GapRects.h:
* rendering/HitTestResult.h:
* rendering/HitTestingTransformState.cpp:
* rendering/HitTestingTransformState.h:
* rendering/InlineFlowBox.cpp:
* rendering/LayoutRepainter.cpp:
* rendering/LayoutRepainter.h:
* rendering/LayoutState.h:
* rendering/LayoutTypes.h:
* rendering/LayoutTypesInlineMethods.h:
* rendering/PaintInfo.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
* rendering/RenderBoxModelObject.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
* rendering/RenderFieldset.cpp:
* rendering/RenderFlexibleBox.cpp:
* rendering/RenderFlowThread.cpp:
* rendering/RenderGeometryMap.h:
* rendering/RenderImageResource.h:
* rendering/RenderInline.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerFilterInfo.h:
* rendering/RenderLineBoxList.cpp:
* rendering/RenderListMarker.cpp:
* rendering/RenderMarquee.cpp:
* rendering/RenderMenuList.h:
* rendering/RenderMultiColumnBlock.cpp:
* rendering/RenderMultiColumnSet.cpp:
* rendering/RenderNamedFlowThread.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderOverflow.h:
* rendering/RenderRegion.cpp:
* rendering/RenderReplaced.cpp:
* rendering/RenderTable.cpp:
* rendering/RenderTable.h:
* rendering/RenderText.cpp:
* rendering/RenderThemeChromiumCommon.cpp:
* rendering/RenderThemeChromiumCommon.h:
* rendering/RenderTreeAsText.cpp:
* rendering/RenderTreeAsText.h:
* rendering/RenderView.h:
* rendering/style/NinePieceImage.h:
* rendering/style/RenderStyle.h:
* rendering/style/ShadowData.cpp:
* rendering/style/ShadowData.h:
* rendering/style/StyleCachedImageSet.h:
* rendering/style/StyleImage.h:
* rendering/svg/SVGRenderSupport.h:

Source/WebKit/chromium:

* src/LinkHighlight.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't show the Android tester in garden-o-matic yet
peter@chromium.org [Wed, 7 Nov 2012 18:33:31 +0000 (18:33 +0000)]
Don't show the Android tester in garden-o-matic yet
https://bugs.webkit.org/show_bug.cgi?id=101476

Reviewed by Adam Barth.

The Android tester just started running layout tests, and doesn't upload its
results yet. Don't show it for now. This exception will be removed once it
has a baseline of greenness.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
achicu@adobe.com [Wed, 7 Nov 2012 18:29:27 +0000 (18:29 +0000)]
CoordinatedGraphicsArgumentCoders should use ValidatedCustomFitlerOperation instead
https://bugs.webkit.org/show_bug.cgi?id=100905

Reviewed by Noam Rosenthal.

Source/WebCore:

Added getters for the validated shaders, so that platform code could extract them.

No new tests, just added two getters.

* platform/graphics/filters/CustomFilterValidatedProgram.h:
(WebCore::CustomFilterValidatedProgram::validatedVertexShader):
(WebCore::CustomFilterValidatedProgram::validatedFragmentShader):
(CustomFilterValidatedProgram):

Source/WebKit2:

The code now knows how to read a ValidatedCustomFitlerOperation and serialize it to the UI process.

No new tests, the code path is not used yet.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/CoordinatedGraphics/WebCustomFilterProgram.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Assertion failure with open() within upgradeneeded
jsbell@chromium.org [Wed, 7 Nov 2012 18:26:18 +0000 (18:26 +0000)]
IndexedDB: Assertion failure with open() within upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=96947

Reviewed by Dimitri Glazkov.

Source/WebCore:

Postpone creation of the "pending second half open" until the version change
transaction has started.

Test: storage/indexeddb/unblocked-version-changes.html

* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::setIntVersionInternal):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseCallbacks.h:

LayoutTests:

Exercise the code path leading to the assert by having a second version change transaction
unblocked by the first's connection closing. Includes a known failure due to metadata
snapshot timing.

* storage/indexeddb/resources/unblocked-version-changes.js: Added.
(test):
(openConnection):
(onUpgradeNeeded):
(onError):
(onUpgradeNeeded2):
(onSuccess):
* storage/indexeddb/unblocked-version-changes-expected.txt: Added.
* storage/indexeddb/unblocked-version-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix failing platform/mac/tiled-drawing on Lion.
simon.fraser@apple.com [Wed, 7 Nov 2012 17:48:38 +0000 (17:48 +0000)]
Fix failing platform/mac/tiled-drawing on Lion.

It's not possible to use TestExpectations to skip tests on all but current mac-wk2,
so just land results for Lion.

* platform/mac-lion/platform/mac/tiled-drawing/fixed/absolute-inside-fixed-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-in-overflow-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/four-bars-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/nested-fixed-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/fixed/percentage-inside-fixed-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-after-scroll-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/scrolling-tree-slow-scrolling-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-after-scroll-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Added.
* platform/mac-lion/platform/mac/tiled-drawing/use-tiled-drawing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shaders] Add CustomFilterMeshBoxType to ValidatedCustomFilterOperation
achicu@adobe.com [Wed, 7 Nov 2012 17:46:53 +0000 (17:46 +0000)]
[CSS Shaders] Add CustomFilterMeshBoxType to ValidatedCustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=100890

Reviewed by Dean Jackson.

Added the CustomFilterMeshBoxType parameter to the ValidatedCustomFilterOperation.

No new tests, this parameter is not used in the implementation yet.

* platform/graphics/filters/ValidatedCustomFilterOperation.cpp:
(WebCore::ValidatedCustomFilterOperation::ValidatedCustomFilterOperation):
* platform/graphics/filters/ValidatedCustomFilterOperation.h:
(WebCore::ValidatedCustomFilterOperation::create):
(WebCore::ValidatedCustomFilterOperation::meshBoxType):
(WebCore::ValidatedCustomFilterOperation::operator==):
(ValidatedCustomFilterOperation):
* rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Implement deleteCookie() for persistent storage
sergio@webkit.org [Wed, 7 Nov 2012 17:39:26 +0000 (17:39 +0000)]
[Qt] Implement deleteCookie() for persistent storage
https://bugs.webkit.org/show_bug.cgi?id=101272

Reviewed by Jocelyn Turcotte.

Individual cookies were never persistently cleared as the
deleteCookie() virtual method was not implemented for persistent
storage. That's why cookies were only deleted for the current
session.

* platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::deleteCookie):
(WebCore): added deleteCookie() implementation for persistent
storage.
* platform/qt/CookieJarQt.h:
(SharedCookieJarQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Shadow] Style should update when 'pseudo' attribute is dynamically updated
shinyak@chromium.org [Wed, 7 Nov 2012 17:35:22 +0000 (17:35 +0000)]
[Shadow] Style should update when 'pseudo' attribute is dynamically updated
https://bugs.webkit.org/show_bug.cgi?id=100918

Reviewed by Dimitri Glazkov.

Source/WebCore:

When 'pseudo' attribute is changed and its element is in ShadowTree, we enable the styleShouldRecalc flag.

It would be fast if we have a set of pseudo attribute style value in RuleFeatureSet,
but it might consume a lot of memory.

Test: fast/dom/shadow/pseudo-attribute-dynamic.html

* dom/Element.cpp:
(WebCore::Element::attributeChanged):

LayoutTests:

* fast/dom/shadow/pseudo-attribute-dynamic-expected.html: Added.
* fast/dom/shadow/pseudo-attribute-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKitTestRunner flakily hangs when running pixel tests on Qt
kbalazs@webkit.org [Wed, 7 Nov 2012 17:33:11 +0000 (17:33 +0000)]
WebKitTestRunner flakily hangs when running pixel tests on Qt
https://bugs.webkit.org/show_bug.cgi?id=100686

Reviewed by Csaba Osztrogon√°c.

Make WebKitTestRunner harden against the situation when the coordinated
graphics rendering synchronisation fails. If we time out when waiting
for the forced repaint to finish it usually a symptom of the synchronisation
has been broken. In this case all other tests will fail with the same error.
The underlying problem is not yet known. Ths patch make us report this situation
as web process unresponsiveness, so the test harness will kill us and launch
a new instance. This will make our pixel test bot usable while it should not limit
us debugging the underlying bug.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/TestInvocation.h:
(TestInvocation): Introduce new members to hold our state
that was local to invoke() so far.
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed test expectations update.
vsevik@chromium.org [Wed, 7 Nov 2012 17:30:56 +0000 (17:30 +0000)]
Unreviewed test expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed gardening. Rebaseline the tests added
jsbell@chromium.org [Wed, 7 Nov 2012 17:14:47 +0000 (17:14 +0000)]
[Chromium] Unreviewed gardening. Rebaseline the tests added
in http://trac.webkit.org/changeset/133686 - part deux.

* platform/chromium-win/fast/backgrounds/transformed-body-background-expected.png: Added.
* platform/chromium-win/fast/backgrounds/transformed-body-html-background-expected.png: Added.
* platform/chromium-win/fast/backgrounds/transformed-html-body-background-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] WebKit sends unnecessary low memory notification when running memory benchmarks
commit-queue@webkit.org [Wed, 7 Nov 2012 17:12:17 +0000 (17:12 +0000)]
[V8] WebKit sends unnecessary low memory notification when running memory benchmarks
https://bugs.webkit.org/show_bug.cgi?id=101474

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-11-07
Reviewed by Kentaro Hara.

Do not send low memory notification to V8 when most of memory usage
comes from V8 heap and not DOM objects. In this case V8 can schedule GC
itself more optimally.

* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Wed, 7 Nov 2012 16:28:38 +0000 (16:28 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Open link in this window action
allan.jensen@digia.com [Wed, 7 Nov 2012 16:12:53 +0000 (16:12 +0000)]
[Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Reviewed by Simon Hausmann.

Source/WebCore:

Adds the action to the WebCore context-menu controller.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.h:
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::contextMenuItemTagOpenLinkInThisWindow):

Source/WebKit/qt:

Adds the action to QtWebKit.

* Api/qwebpage.cpp:
(webActionForContextMenuAction):
(QWebPage::triggerAction):
(QWebPage::action):
* Api/qwebpage.h:

Tools:

Populates the context-menu with the new action when the default action is to open in a new window.

* QtTestBrowser/webview.cpp:
(createContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
commit-queue@webkit.org [Wed, 7 Nov 2012 16:04:03 +0000 (16:04 +0000)]
[EFL][WK2] Add ewk_settings_preferred_minimum_contents_width_get/set API
https://bugs.webkit.org/show_bug.cgi?id=101467

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

Tools:

Added ewk_settings_preferred_minimum_contents_width_get/set API which is used for setting/getting
of default minimum contents width for non viewport meta element sites.
Set default minimum contents width to '0' for MiniBrowser as it should behave like desktop browser.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2][AC] Avoid creating an empty surface
commit-queue@webkit.org [Wed, 7 Nov 2012 15:16:38 +0000 (15:16 +0000)]
[EFL][WK2][AC] Avoid creating an empty surface
https://bugs.webkit.org/show_bug.cgi?id=101464

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure we have a valid view size before creating a GL surface.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test inspector/debugger/script-formatter-breakpoints.html is failing
vsevik@chromium.org [Wed, 7 Nov 2012 15:13:01 +0000 (15:13 +0000)]
Layout Test inspector/debugger/script-formatter-breakpoints.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101361

Unreviewed test fix.

* inspector/debugger/script-formatter-breakpoints.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening
kbalazs@webkit.org [Wed, 7 Nov 2012 15:07:37 +0000 (15:07 +0000)]
[Qt] Unreviewed gardening

Some image expectetions was accidentally added for reference tests and it consused nrwt.
Deleted them.

* platform/qt-5.0-wk2/compositing/text-on-scaled-layer-expected.png: Removed.
* platform/qt-5.0-wk2/compositing/text-on-scaled-surface-expected.png: Removed.
* platform/qt/css2.1/20110323/margin-collapse-clear-016-expected.png: Removed.
* platform/qt/svg/animations/animateMotion-additive-2c-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add EFL to garden-o-matic
commit-queue@webkit.org [Wed, 7 Nov 2012 15:05:49 +0000 (15:05 +0000)]
[EFL] Add EFL to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=101444

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Added the EFL bots running layout tests to the garden-o-matic report
page. We are skipping here the bot that just builds WebKit EFL to make
the data fetching faster.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 7 Nov 2012 14:58:42 +0000 (14:58 +0000)]
Unreviewed GTK gardening.

Adding a timeout expectation for the test introduced in r133660.
Adding timeout expectations for two media tests that started timing
out probably after r133633.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin()
commit-queue@webkit.org [Wed, 7 Nov 2012 14:55:47 +0000 (14:55 +0000)]
[WK2][UNIX] Crash in WebKit::PluginProcessProxy::scanPlugin()
https://bugs.webkit.org/show_bug.cgi?id=101446

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Make sure that the disposition of the SIGCHLD signal is reset to the default
before calling g_spawn_sync(). If the disposition is set to SIG_IGN, then
g_spawn_sync() will not be able to return the exit status of the child
process, our exit failure check will be useless and the following warning
will be printed:

GLib-WARNING **: In call to g_spawn_sync(), exit status of a child process
was requested but SIGCHLD action was set to SIG_IGN and ECHILD was received
by waitpid(), so exit status can't be returned. This is a bug in the
program calling g_spawn_sync(); either don't request the exit status, or
don't set the SIGCHLD action.

This patch also adds a NULL-check for stdOut to avoid crashing in such
case and makes use of String::split() to parse stdOut instead of doing it
manually.

* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 7 Nov 2012 14:52:02 +0000 (14:52 +0000)]
[EFL] Unreviewed gardening.

Rebaselining a few ruby tests.

* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-horizontal-bt-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expecte...
ossy@webkit.org [Wed, 7 Nov 2012 14:42:12 +0000 (14:42 +0000)]
[Qt] Unreviewed gardening after r133688, remove unnecessary platform specific expected files.

* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Removed.
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Removed.
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Canvas] closure compiler fixes
commit-queue@webkit.org [Wed, 7 Nov 2012 14:37:41 +0000 (14:37 +0000)]
Web Inspector: [Canvas] closure compiler fixes
https://bugs.webkit.org/show_bug.cgi?id=101459

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r133712.
commit-queue@webkit.org [Wed, 7 Nov 2012 14:18:43 +0000 (14:18 +0000)]
Unreviewed, rolling out r133712.
http://trac.webkit.org/changeset/133712
https://bugs.webkit.org/show_bug.cgi?id=101461

Broke fast/forms/time* tests on chromium-win. (Requested by
mkwst on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-07

* platform/text/win/LocaleWin.cpp:
(WebCore::DateFormatToken::DateFormatToken):
(DateFormatToken):
(WebCore):
(WebCore::isEraSymbol):
(WebCore::isYearSymbol):
(WebCore::isMonthSymbol):
(WebCore::isDaySymbol):
(WebCore::commitLiteralToken):
(WebCore::parseDateFormat):
(WebCore::LocaleWin::ensureShortDateTokens):
(WebCore::convertWindowsDateFormatToLDML):
(WebCore::mapCharacterToDateTimeFieldType):
(WebCore::convertWindowsTimeFormatToLDML):
(WebCore::LocaleWin::dateFormat):
(WebCore::LocaleWin::monthFormat):
(WebCore::LocaleWin::timeFormat):
(WebCore::LocaleWin::shortTimeFormat):
* platform/text/win/LocaleWin.h:
(LocaleWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Regression] Editing formatted source should not be allowed.
vsevik@chromium.org [Wed, 7 Nov 2012 14:14:49 +0000 (14:14 +0000)]
Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Shadow] Use setPseudo() instead of setShadowPseudoId().
shinyak@chromium.org [Wed, 7 Nov 2012 14:13:30 +0000 (14:13 +0000)]
[Shadow] Use setPseudo() instead of setShadowPseudoId().
https://bugs.webkit.org/show_bug.cgi?id=101306

Reviewed by Kent Tamura.

.:

Exposes necessary symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

We would like to remove setShadowPseudoId() and use setPseudo() instead, since ShadowDOM spec now has
'pseudo' attribute.

We change all setShadowPseudoId() invocation to setPseudo() invocation. Also, when AtomicString is not
constructed with AtomicStringFromLiteral, we use it.

No new tests, refactoring.

* WebCore.exp.in:
* dom/Element.cpp:
* dom/Element.h:
(Element):
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
* html/ColorInputType.cpp:
(WebCore::ColorInputType::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::updatePlaceholderText):
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::buildBubbleTree):
* html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditBuilder::visitLiteral):
(WebCore::DateTimeEditElement::DateTimeEditElement):
* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::initialize):
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement):
* html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCueBox::TextTrackCueBox):
(WebCore::TextTrackCue::updateDisplayTree):
* testing/Internals.cpp:
(WebCore::Internals::setShadowPseudoId):

Source/WebKit2:

Exposes necessary symbols.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 7 Nov 2012 13:57:31 +0000 (13:57 +0000)]
[EFL] Unreviewed gardening.

navigator-vibration.html is still crashing occasionally.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Canvas] Save CanvasGradient objects state for a replay
commit-queue@webkit.org [Wed, 7 Nov 2012 13:53:57 +0000 (13:53 +0000)]
Web Inspector: [Canvas] Save CanvasGradient objects state for a replay
https://bugs.webkit.org/show_bug.cgi?id=101432

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-07
Reviewed by Pavel Feldman.

Source/WebCore:

Save CanvasGradient resource state for a subsequent replay. The gradient's state is modified by the gradient.addColorStop() call.

Test: inspector/profiler/canvas2d/canvas2d-gradient-capturing.html

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

LayoutTests:

Alerts about API changes to CanvasGradient and CanvasPattern classes.
Checks capturing for CanvasGradient objects' state.

* inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt:
* inspector/profiler/canvas2d/canvas2d-api-changes.html:
* inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Added.
* inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Regression] Snippets evaluations should not appear in Sources tab...
vsevik@chromium.org [Wed, 7 Nov 2012 13:51:00 +0000 (13:51 +0000)]
Web Inspector: [Regression] Snippets evaluations should not appear in Sources tab of navigator.
https://bugs.webkit.org/show_bug.cgi?id=101354

Reviewed by Pavel Feldman.

* inspector/front-end/DebuggerScriptMapping.js:
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.isSnippet):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Wed, 7 Nov 2012 13:50:22 +0000 (13:50 +0000)]
[EFL] Unreviewed gardening.

fast/repaint/block-selection-gap-in-table-cell.html is not
rendering correctly, so skip it when running pixel tests. Need a

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Make EWK classes Ewk_Objects
commit-queue@webkit.org [Wed, 7 Nov 2012 13:45:09 +0000 (13:45 +0000)]
[EFL][WK2] Make EWK classes Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101057

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-07
Reviewed by Kenneth Rohde Christiansen.

Now all the existing EWK classes share common Ewk_Object ref/unref API.

Source/WebKit2:

* UIProcess/API/efl/EwkViewCallbacks.h:
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
* UIProcess/API/efl/ewk_database_manager.cpp:
(Ewk_Database_Manager::createOriginList):
* UIProcess/API/efl/ewk_database_manager_private.h:
* UIProcess/API/efl/ewk_file_chooser_request.cpp:
(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_allow_multiple_files_get):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_cancel):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):
* UIProcess/API/efl/ewk_file_chooser_request.h:
* UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest):
(EwkFileChooserRequest::create):
* UIProcess/API/efl/ewk_form_submission_request.cpp:
(EwkFormSubmissionRequest::EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::~EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::fieldValue):
(EwkFormSubmissionRequest::fieldNames):
(EwkFormSubmissionRequest::submit):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):
* UIProcess/API/efl/ewk_form_submission_request.h:
* UIProcess/API/efl/ewk_form_submission_request_private.h:
(EwkFormSubmissionRequest):
(EwkFormSubmissionRequest::create):
* UIProcess/API/efl/ewk_intent.cpp:
(EwkIntent::EwkIntent):
(EwkIntent::webIntentData):
(EwkIntent::action):
(EwkIntent::type):
(EwkIntent::service):
(EwkIntent::suggestions):
(EwkIntent::extra):
(EwkIntent::extraKeys):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
* UIProcess/API/efl/ewk_intent.h:
* UIProcess/API/efl/ewk_intent_private.h:
(EwkIntent):
(EwkIntent::create):
* UIProcess/API/efl/ewk_intent_service.cpp:
(EwkIntentService::EwkIntentService):
(EwkIntentService::action):
(EwkIntentService::type):
(EwkIntentService::href):
(EwkIntentService::title):
(EwkIntentService::disposition):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):
* UIProcess/API/efl/ewk_intent_service.h:
* UIProcess/API/efl/ewk_intent_service_private.h:
(EwkIntentService):
(EwkIntentService::create):
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(EwkNavigationPolicyDecision::EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::~EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::navigationType):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(EwkNavigationPolicyDecision::frameName):
(EwkNavigationPolicyDecision::request):
(EwkNavigationPolicyDecision::accept):
(EwkNavigationPolicyDecision::reject):
(EwkNavigationPolicyDecision::download):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):
* UIProcess/API/efl/ewk_navigation_policy_decision.h:
* UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
(EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::create):
* UIProcess/API/efl/ewk_resource.cpp:
(EwkResource::EwkResource):
(EwkResource::url):
(EwkResource::isMainResource):
(ewk_resource_url_get):
(ewk_resource_main_resource_get):
* UIProcess/API/efl/ewk_resource.h:
* UIProcess/API/efl/ewk_resource_private.h:
(EwkResource):
(EwkResource::create):
* UIProcess/API/efl/ewk_security_origin.cpp:
(EwkSecurityOrigin::EwkSecurityOrigin):
(EwkSecurityOrigin::host):
(EwkSecurityOrigin::protocol):
(EwkSecurityOrigin::port):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):
* UIProcess/API/efl/ewk_security_origin.h:
* UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin):
(EwkSecurityOrigin::create):
* UIProcess/API/efl/ewk_storage_manager.cpp:
(Ewk_Storage_Manager::createOriginList):
* UIProcess/API/efl/ewk_url_scheme_request_private.h:
(EwkUrlSchemeRequest):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
* UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(onFileChooserRequest):
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
(TEST_F):
* UIProcess/efl/FormClientEfl.cpp:
(WebKit::FormClientEfl::willSubmitForm):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
* UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
* UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::runOpenPanel):
* UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
* UIProcess/efl/ResourceLoadClientEfl.h:

Tools:

* MiniBrowser/efl/main.c:
(close_file_picker):
(on_file_chooser_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed inspector test polish.
vsevik@chromium.org [Wed, 7 Nov 2012 13:35:35 +0000 (13:35 +0000)]
Unreviewed inspector test polish.
Made http/tests/indexeddb/database-data.html test faster, added more verbose errors for test debugging.

* http/tests/inspector/indexeddb/database-data-expected.txt:
* http/tests/inspector/indexeddb/database-data.html:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(onIndexedDBError):
(onIndexedDBBlocked):
(doWithDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Return earlier if a plugin snapshot cannot be created.
rakuco@webkit.org [Wed, 7 Nov 2012 13:35:13 +0000 (13:35 +0000)]
[WK2] Return earlier if a plugin snapshot cannot be created.
https://bugs.webkit.org/show_bug.cgi?id=101445

Reviewed by Kenneth Rohde Christiansen.

Currently only the Mac port has support for creating snapshots of
Netscape plugins. Return earlier in PluginProxy::snapshot() so
that we do not pass a null handler to ShareableBitmap::create()
and avoid crashing when running pixel tests with plugins.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Change encoding detector API names
commit-queue@webkit.org [Wed, 7 Nov 2012 13:33:40 +0000 (13:33 +0000)]
[EFL][WK2] Change encoding detector API names
https://bugs.webkit.org/show_bug.cgi?id=101450

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-07
Reviewed by Gyuyoung Kim.

To make settings API name consistent, we need to change two APIs with respect to encoding detector.

* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
* UIProcess/API/efl/ewk_settings.h:
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133740 268f45cc-cd09-0410-ab3c-d52691b4dbfc