WebKit-https.git
7 years ago[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
commit-queue@webkit.org [Mon, 11 Jun 2012 08:26:10 +0000 (08:26 +0000)]
[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
https://bugs.webkit.org/show_bug.cgi?id=88751

Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Web Inspector: implement breaking from native callback
commit-queue@webkit.org [Mon, 11 Jun 2012 08:24:02 +0000 (08:24 +0000)]
[JSC] Web Inspector: implement breaking from native callback
https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::breakProgram):
* bindings/js/ScriptDebugServer.h:
(WebCore::supportsNativeBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Remove expectations for passing tests
dominicc@chromium.org [Mon, 11 Jun 2012 08:23:01 +0000 (08:23 +0000)]
[Chromium] Unreviewed: Remove expectations for passing tests

The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpellchecker crash in async scenario.
morrita@google.com [Mon, 11 Jun 2012 08:17:14 +0000 (08:17 +0000)]
Spellchecker crash in async scenario.
https://bugs.webkit.org/show_bug.cgi?id=88617

Reviewed by Tony Chang.

SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.

No new tests. It's hard to reproduce this.

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::invokeRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
commit-queue@webkit.org [Mon, 11 Jun 2012 08:11:59 +0000 (08:11 +0000)]
[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=88752

Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-11

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Extract CursorMap from WidgetEfl.cpp.
ryuan.choi@samsung.com [Mon, 11 Jun 2012 07:41:19 +0000 (07:41 +0000)]
[EFL] Extract CursorMap from WidgetEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=88633

Reviewed by Ryosuke Niwa.

In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.

No new tests, refactoring only.

* platform/efl/EflScreenUtilities.cpp:
(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):
* platform/efl/EflScreenUtilities.h:
(WebCore):
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119955.
commit-queue@webkit.org [Mon, 11 Jun 2012 06:58:40 +0000 (06:58 +0000)]
Unreviewed, rolling out r119955.
http://trac.webkit.org/changeset/119955
https://bugs.webkit.org/show_bug.cgi?id=88758

Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-10

Source/WebCore:

* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):
* WebView/WebFramePrivate.h:

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUsing BlobBuilder should show a deprecation warning message (if it is enabled)
kinuko@chromium.org [Mon, 11 Jun 2012 06:23:59 +0000 (06:23 +0000)]
Using BlobBuilder should show a deprecation warning message (if it is enabled)
https://bugs.webkit.org/show_bug.cgi?id=88644

Reviewed by Jian Li.

Source/WebCore:

Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.

Tests: fast/files/blob-builder-crash.html

* fileapi/WebKitBlobBuilder.cpp:
(WebCore):
(WebCore::WebKitBlobBuilder::create):
* fileapi/WebKitBlobBuilder.h:
(WebCore):
(WebKitBlobBuilder):
* fileapi/WebKitBlobBuilder.idl:

LayoutTests:

* fast/files/blob-builder-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for disconnected/excluded from search frames, they are not used by...
weinig@apple.com [Mon, 11 Jun 2012 06:11:39 +0000 (06:11 +0000)]
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

* WebCore.exp.in:
Update export.
* editing/Editor.cpp:
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/Editor.h:
(Editor):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::findFrameForNavigation):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/Frame.h:
(Frame):
* page/FrameTree.cpp:
(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(FrameTree):
* page/Location.cpp:
(WebCore::Location::ancestorOrigins):
* xml/XMLTreeViewer.cpp:
(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/mac:

* WebView/WebFrame.mm:
* WebView/WebFramePrivate.h:
Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove Quota related code out of DOMWindow and into the quota/ folder
kinuko@chromium.org [Mon, 11 Jun 2012 06:03:31 +0000 (06:03 +0000)]
Move Quota related code out of DOMWindow and into the quota/ folder
https://bugs.webkit.org/show_bug.cgi?id=88512

Patch by Kinuko Yasuda <kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.

No new tests: no visible changes.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* Modules/quota/DOMWindowQuota.cpp: Added.
* Modules/quota/DOMWindowQuota.h: Added.
* Modules/quota/DOMWindowQuota.idl: Added.
* Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
* Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
* Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
* Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
* Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
* Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
* Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
* Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
* Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:
* page/DOMWindow.cpp:
* page/DOMWindow.h:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Add expectations for svg-as-background-6.html
dominicc@chromium.org [Mon, 11 Jun 2012 05:47:38 +0000 (05:47 +0000)]
[Chromium] Unreviewed: Add expectations for svg-as-background-6.html

Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale...
dominicc@chromium.org [Mon, 11 Jun 2012 05:35:36 +0000 (05:35 +0000)]
[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale on Linux, Win

These differ in antialiasing only, where there are already
platform differences antialiasing.

* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Update
dominicc@chromium.org [Mon, 11 Jun 2012 04:45:21 +0000 (04:45 +0000)]
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed: Update
dominicc@chromium.org [Mon, 11 Jun 2012 04:38:23 +0000 (04:38 +0000)]
[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAn inheritance of '-webkit-user-modify' does not stop at shadow boundary.
hayato@chromium.org [Mon, 11 Jun 2012 03:58:56 +0000 (03:58 +0000)]
An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
https://bugs.webkit.org/show_bug.cgi?id=88514

Reviewed by Ryosuke Niwa.

Source/WebCore:

In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough.  We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.

Test: fast/dom/shadow/user-modify-inheritance.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):
* css/StyleResolver.h:
(StyleResolver):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritFrom):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
* fast/dom/shadow/user-modify-inheritance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Introduce Decimal behind the InputNumber type
yosin@chromium.org [Mon, 11 Jun 2012 02:30:39 +0000 (02:30 +0000)]
[Forms] Introduce Decimal behind the InputNumber type
https://bugs.webkit.org/show_bug.cgi?id=88383

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.

Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.

Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.

Test: fast/forms/range/range-value-rounding.html

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.
* html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
* html/InputType.cpp:
(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.
* html/InputType.h:
(InputType): Removed parseToNumberWIthDecimaplPlaces.
* html/MonthInputType.cpp:
(WebCore::MonthInputType::createStepRange): Changed for Decimal type.
* html/NumberInputType.cpp:
(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.
* html/NumberInputType.h:
(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble):  Changed to real implementation.
* html/StepRange.h:
(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):
* html/TimeInputType.cpp:
(WebCore::TimeInputType::createStepRange): Changed for Decimal type.
* html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Changed for Decimal type.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.
* html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Changed for Decimal type.

LayoutTests:

* fast/forms/range/range-value-rounding-expected.txt: Added.
* fast/forms/range/range-value-rounding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Possible to clobber httponly cookie.
commit-queue@webkit.org [Mon, 11 Jun 2012 02:16:19 +0000 (02:16 +0000)]
[BlackBerry] Possible to clobber httponly cookie.
https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

* platform/blackberry/CookieJarBlackBerry.cpp:
(WebCore::setCookies):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
* platform/blackberry/CookieMap.h:
(CookieMap):

LayoutTests:

* http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
* http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
* platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose layoutTestController as testRunner
rniwa@webkit.org [Sun, 10 Jun 2012 21:36:29 +0000 (21:36 +0000)]
Expose layoutTestController as testRunner
https://bugs.webkit.org/show_bug.cgi?id=88210

Reviewed by Darin Adler.

Tools:

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::makeWindowObject):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::initJSObjects):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::makeWindowObject):

LayoutTests:

Add a test for testRunner object.

* fast/harness/testrunner-object-expected.txt: Added.
* fast/harness/testrunner-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccess control allow lists starting with a comma are parsed incorrectly (CORS)
commit-queue@webkit.org [Sun, 10 Jun 2012 20:18:36 +0000 (20:18 +0000)]
Access control allow lists starting with a comma are parsed incorrectly (CORS)
https://bugs.webkit.org/show_bug.cgi?id=88461

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.

Source/WebCore:

The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.

Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html

* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):

LayoutTests:

* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
* http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoving mixed content tests' dependency on WebKitBlobBuilder:
commit-queue@webkit.org [Sun, 10 Jun 2012 19:48:56 +0000 (19:48 +0000)]
Removing mixed content tests' dependency on WebKitBlobBuilder:
https://bugs.webkit.org/show_bug.cgi?id=88736

http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.

It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).

Patch by Mike West <mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.

* http/tests/security/mixedContent/blob-url-in-iframe.html:
* http/tests/security/mixedContent/filesystem-url-in-iframe.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome additional tweaks to keep TreeShared code simple/clean
darin@apple.com [Sun, 10 Jun 2012 19:19:19 +0000 (19:19 +0000)]
Some additional tweaks to keep TreeShared code simple/clean
https://bugs.webkit.org/show_bug.cgi?id=88738

Reviewed by Adam Barth.

* platform/TreeShared.h: Make constructor and destructor both protected.
It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
commit-queue@webkit.org [Sun, 10 Jun 2012 18:44:05 +0000 (18:44 +0000)]
[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88725

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10
Reviewed by Eric Carlson.

* media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values
so that the test passes for EFL and GTK ports.
* platform/efl/TestExpectations: Unskip test.
* platform/gtk/TestExpectations: Unskip test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip fast/dom/frame-loading-via-document-write.html
commit-queue@webkit.org [Sun, 10 Jun 2012 18:41:53 +0000 (18:41 +0000)]
[EFL] Skip fast/dom/frame-loading-via-document-write.html
https://bugs.webkit.org/show_bug.cgi?id=88737

Unreviewed EFL gardening. Skipping test that is flaky after r119788.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Setting invalid media "src" does not cause "error" event
jer.noble@apple.com [Sun, 10 Jun 2012 18:18:44 +0000 (18:18 +0000)]
REGRESSION: Setting invalid media "src" does not cause "error" event
https://bugs.webkit.org/show_bug.cgi?id=88423

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/video-src-invalid-error.html

Two problems here.  When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled.  It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.

Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.

Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):
* html/HTMLMediaElement.h:

And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

* http/tests/media/video-src-invalid-error-expected.txt: Added.
* http/tests/media/video-src-invalid-error.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd logging functions to MediaPlayerPrivateQTKit.
jer.noble@apple.com [Sun, 10 Jun 2012 18:14:40 +0000 (18:14 +0000)]
Add logging functions to MediaPlayerPrivateQTKit.
https://bugs.webkit.org/show_bug.cgi?id=88425

Reviewed by Eric Carlson.

No new tests; adds logging functions to aide debugging.

MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.

Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):

Add LOG messages for each of the following functions:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore should use a single definition of an invalid media time.
jer.noble@apple.com [Sun, 10 Jun 2012 18:09:52 +0000 (18:09 +0000)]
WebCore should use a single definition of an invalid media time.
https://bugs.webkit.org/show_bug.cgi?id=88572

Reviewed by Eric Carlson.

No new tests; no change in functionality, so covered by existing tests.

Add a new, universal definition for an invalid media time:
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::invalidTime):

Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):
* html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unneeded callRemovedLastRef function from TreeShared refactoring
darin@apple.com [Sun, 10 Jun 2012 17:15:55 +0000 (17:15 +0000)]
Remove unneeded callRemovedLastRef function from TreeShared refactoring
https://bugs.webkit.org/show_bug.cgi?id=88653

Reviewed by Sam Weinig.

.:

* Source/autotools/symbols.filter: Filter removedLastRef instead of
callRemovedLastRef.

Source/WebCore:

* WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.

* dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer
needed and also had a bad cast in it.

* dom/Document.h: Made removedLastRef private and non-virtual and made Node
a friend so it can call the private function.

* dom/Node.cpp:
(WebCore::Node::removedLastRef): Moved here. This should not be an inline
function. Added comments explaining why it should not be inlined. Also added
explicit code to call to Document::removedLastRef, and added a comment why
that's the right thing to do here.
* dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the
removedLastRef function non-virtual and removed it from the header file.
Updated TreeShared using statements. Made the TreeShared template class a
friend so it can call the private removedLastRef.

* html/HTMLFormControlElement.h: Updated TreeShared using statements to specify
Node instead, which accomplishes the same thing.
* html/HTMLObjectElement.h: Ditto.

* platform/TreeShared.h: Made TreeShared take two template arguments for the
node type and the parent node type. Removed the callRemovedLastRef functions and
the extra forward declarations it required. Removed the private unused
removedLastRef function; not sure why it was left in here at all.
(WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
(WebCore::TreeShared::setParent): Use ParentNodeType.
(WebCore::TreeShared::parent): Ditto.
(WebCore::adopted): Updated to have both template arguments.

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
this. Moved the body out of the header and added a comment explaining why the
function should not be inlined.
* svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and
private. Made TreeShared a friend so it can call the private removedLastRef.
Updated TreeShared using statements.

Source/WebKit2:

* win/WebKit2.def: Export removedLastRef instead of callRemovedLastRef.
* win/WebKit2CFLite.def: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Updating a few animations tests baselines,
zandobersek@gmail.com [Sun, 10 Jun 2012 16:54:03 +0000 (16:54 +0000)]
Unreviewed GTK gardening. Updating a few animations tests baselines,
adding test expectations for one FileSystem test.

* platform/gtk/TestExpectations:
* platform/gtk/animations/3d/change-transform-in-end-event-expected.txt:
* platform/gtk/animations/3d/matrix-transform-type-animation-expected.txt: Added.
* platform/gtk/animations/3d/state-at-end-event-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTemporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the...
mitz@apple.com [Sun, 10 Jun 2012 16:33:01 +0000 (16:33 +0000)]
Temporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the Mac skip
list. <http://webkit.org/b/88736> tracks moving this test off of the legacy
WebKitBlobBuilder API.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip...
mitz@apple.com [Sun, 10 Jun 2012 16:14:50 +0000 (16:14 +0000)]
Added http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip list,
because FILE_SYSTEM is not enabled.

Part of: http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html are failing
<http://webkit.org/b/88736>

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] 2 fast/multicol/span tests are flaky
commit-queue@webkit.org [Sun, 10 Jun 2012 16:14:12 +0000 (16:14 +0000)]
[EFL] 2 fast/multicol/span tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=88734

Unreviewed EFL gardening. Move to TestExpectations 2 tests that
are flaky on the bot.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago* WebCore.exp.in: Re-sorted and alphabetized the file.
darin@apple.com [Sun, 10 Jun 2012 15:37:01 +0000 (15:37 +0000)]
* WebCore.exp.in: Re-sorted and alphabetized the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
commit-queue@webkit.org [Sun, 10 Jun 2012 15:32:37 +0000 (15:32 +0000)]
[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
https://bugs.webkit.org/show_bug.cgi?id=88728

Unreviewed gardening. Skip new test added in r119911 which fails for both
GTK and EFL ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Several test cases can be unskipped
commit-queue@webkit.org [Sun, 10 Jun 2012 15:29:44 +0000 (15:29 +0000)]
[EFL] Several test cases can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=88731

Unreviewed EFL gardening. Unskip a few tests that are passing after
r118618 was rolled out.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
commit-queue@webkit.org [Sun, 10 Jun 2012 14:53:44 +0000 (14:53 +0000)]
[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
https://bugs.webkit.org/show_bug.cgi?id=88730

Unreviewed EFL gardening. Skip a few tests causing flakiness.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
ryuan.choi@samsung.com [Sun, 10 Jun 2012 14:21:31 +0000 (14:21 +0000)]
[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
https://bugs.webkit.org/show_bug.cgi?id=84124

Reviewed by Chang Shu.

Modify ewk_view and add ewk_context to provide a platform-depedent WebKit2
API.
This patch provides the minimum to support MiniBrowser.

* PlatformEfl.cmake: add ewk_context.cpp.
* UIProcess/API/efl/EWebKit2.h: Added.
* UIProcess/API/efl/ewk_context.cpp: Added.
(_Ewk_Context):
(createDefaultWebContext):
(ewk_context_WKContext_get):
(ewk_context_default_get):
* UIProcess/API/efl/ewk_context.h: Added.
* UIProcess/API/efl/ewk_context_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_add):
(ewk_view_uri_set):
(ewk_view_uri_get):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
kbalazs@webkit.org [Sun, 10 Jun 2012 13:44:32 +0000 (13:44 +0000)]
[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=88308

Reviewed by Simon Hausmann.

No new tests, just a build fix.

Use ownerWindow() from page client. It has been
introduced for x11 plugins to solve exactly the
same problem.

* plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.
paroga@webkit.org [Sun, 10 Jun 2012 12:49:32 +0000 (12:49 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.

* runtime/Executable.h:
(ExecutableBase):
(JSC::ExecutableBase::clearCodeVirtual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build fix for !ENABLE(JIT) after r119844.
paroga@webkit.org [Sun, 10 Jun 2012 12:25:57 +0000 (12:25 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r119844.

* runtime/Executable.h:
(ExecutableBase):
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix building ImageQt.cpp
kbalazs@webkit.org [Sun, 10 Jun 2012 12:09:37 +0000 (12:09 +0000)]
[Qt][Win] Fix building ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=88306

Reviewed by Simon Hausmann.

No new tests, this is just a build fix.

* platform/graphics/qt/ImageQt.cpp:
(WebCore):
(WebCore::BitmapImage::create):
Adapt to the "API" changes in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
commit-queue@webkit.org [Sun, 10 Jun 2012 11:43:40 +0000 (11:43 +0000)]
[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
https://bugs.webkit.org/show_bug.cgi?id=88726

Unreviewed gardening. Skip test added in r119907 for GTK and EFL ports.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-10

* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WebGL mark draws for compositing even if the draw count is zero
commit-queue@webkit.org [Sun, 10 Jun 2012 06:36:27 +0000 (06:36 +0000)]
Make WebGL mark draws for compositing even if the draw count is zero
https://bugs.webkit.org/show_bug.cgi?id=88718

Patch by Gregg Tavares <gman@google.com> on 2012-06-09
Reviewed by Kenneth Russell.

No new tests as no new functionality.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove JavaScriptCore dependencies from gyp
dominicc@chromium.org [Sun, 10 Jun 2012 06:31:14 +0000 (06:31 +0000)]
[Chromium] Remove JavaScriptCore dependencies from gyp
https://bugs.webkit.org/show_bug.cgi?id=88510

Reviewed by Adam Barth.

Chromium doesn't support JSC any more and there doesn't seem to be
a strong interest in using GYP as the common build system in other
ports.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp: WebCore still depends on YARR interpreter.
* JavaScriptCore.gypi: Only include YARR source.
* gyp/JavaScriptCore.gyp: Removed.
* gyp/gtk.gyp: Removed.

Source/WebCore:

No new functionality => No new tests.

* gyp/WebCore.gyp: Removed.
* gyp/copy-forwarding-and-icu-headers.sh: Removed.
* gyp/copy-inspector-resources.sh: Removed.
* gyp/generate-derived-sources.sh: Removed.
* gyp/generate-webcore-export-file-generator.sh: Removed.
* gyp/gtk.gyp: Removed.
* gyp/run-if-exists.sh: Removed.
* gyp/streamline-inspector-source.sh: Removed.
* gyp/update-info-plist.sh: Removed.

Source/WTF:

* WTF.gyp/WTF.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* Scripts/generate-project-files: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove a Chromium test expectation for the test that has been rolled out in r119918.
rniwa@webkit.org [Sun, 10 Jun 2012 02:45:59 +0000 (02:45 +0000)]
Remove a Chromium test expectation for the test that has been rolled out in r119918.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor and improve code style in TextResourceDecoder to prepare for buffering impro...
darin@apple.com [Sun, 10 Jun 2012 01:08:27 +0000 (01:08 +0000)]
Refactor and improve code style in TextResourceDecoder to prepare for buffering improvement
https://bugs.webkit.org/show_bug.cgi?id=88566

Reviewed by Alexey Proskuryakov.

* loader/TextResourceDecoder.cpp:
(WebCore::bytesEqual): Added helper function to make comparing against sequences of bytes
easier to read at the call site.
(WebCore::KanjiCode::judge): Changed to use bytesEqual in a few places, merged multiple if
statements, got rid of else after goto.
(WebCore::TextResourceDecoder::checkForCSSCharset): Changed to use early return instead of
nesting the whole function. Changed to use bytesEqual.
(WebCore::skipComment): Changed to use early return for more cases. Changed to use bytesEqual.
(WebCore::TextResourceDecoder::checkForHeadCharset): Changed to use bytesEqual.
(WebCore::TextResourceDecoder::decode): Changed to use emptyString() instead of "", since
the former is more efficient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r118618 and r119353.
commit-queue@webkit.org [Sat, 9 Jun 2012 23:03:25 +0000 (23:03 +0000)]
Unreviewed, rolling out r118618 and r119353.
http://trac.webkit.org/changeset/118618
http://trac.webkit.org/changeset/119353
https://bugs.webkit.org/show_bug.cgi?id=88720

Caused at least 30 different crashes on ClusterFuzz (Requested
by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-09

Source/WebCore:

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::allClientsRemoved):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::allClientsRemoved):
* loader/cache/CachedFont.h:
(WebCore::CachedFontClient::resourceClientType):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::removeClientForRenderer):
(WebCore):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
* loader/cache/CachedImage.h:
(CachedImage):
(WebCore::CachedImageClient::resourceClientType):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::allClientsRemoved):
(WebCore):
* loader/cache/CachedRawResource.h:
(CachedRawResource):
(WebCore::CachedRawResourceClient::resourceClientType):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::allClientsRemoved):
* loader/cache/CachedResourceClient.h:
(WebCore::CachedResourceClient::resourceClientType):
* loader/cache/CachedSVGDocument.h:
(WebCore::CachedSVGDocumentClient::resourceClientType):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::allClientsRemoved):
* loader/cache/CachedStyleSheetClient.h:
(WebCore::CachedStyleSheetClient::resourceClientType):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::removeClient):
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::removeClient):
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
* svg/graphics/SVGImageCache.h:
(WebCore):
(SVGImageCache):

LayoutTests:

* http/tests/cache/cancel-in-progress-load-expected.txt: Removed.
* http/tests/cache/cancel-in-progress-load.html: Removed.
* http/tests/misc/write-while-waiting.html:
* svg/as-image/svg-image-leak-cached-data-expected.txt: Removed.
* svg/as-image/svg-image-leak-cached-data.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Chromium test expectations after my previous commit (r119916).
rniwa@webkit.org [Sat, 9 Jun 2012 21:38:31 +0000 (21:38 +0000)]
Fix Chromium test expectations after my previous commit (r119916).

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpring CRASH cleanup of Chromium test expectations.
rniwa@webkit.org [Sat, 9 Jun 2012 20:57:07 +0000 (20:57 +0000)]
Spring CRASH cleanup of Chromium test expectations.
Removed a whole bunch of bogus CRASH test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove bogus CRASH expectations from skipped tests.
rniwa@webkit.org [Sat, 9 Jun 2012 19:58:48 +0000 (19:58 +0000)]
Remove bogus CRASH expectations from skipped tests.
There's no point in specifying test expectation when tests are skipped.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed-position foreignObject descendants should be relative to the foreignObject...
fmalita@chromium.org [Sat, 9 Jun 2012 19:37:07 +0000 (19:37 +0000)]
Fixed-position foreignObject descendants should be relative to the foreignObject viewport
https://bugs.webkit.org/show_bug.cgi?id=88547

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: svg/foreignObject/fO-fixed-position-crash.html
       svg/foreignObject/fixed-position-expected.svg
       svg/foreignObject/fixed-position.svg

Fixed position elements are currently registered with the top level
RenderView even when embedded within an SVG foreignOject. This patch
changes containingBlock() & container() to return the containing
foreignObject renderer instead.

The new foreignObject fixed position behavior matches that of current
FireFox and Opera versions and is consistent with the spec:
http://www.w3.org/TR/CSS2/visuren.html#fixed-positioning
http://www.w3.org/TR/SVG/coords.html#EstablishingANewViewport

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
(WebCore::RenderObject::container):

LayoutTests:

* svg/foreignObject/fO-fixed-position-crash-expected.txt: Added.
* svg/foreignObject/fO-fixed-position-crash.html: Added.
* svg/foreignObject/fixed-position-expected.svg: Added.
* svg/foreignObject/fixed-position.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCan't use eval in iframes sanbdoxed via CSP header
abarth@webkit.org [Sat, 9 Jun 2012 19:35:02 +0000 (19:35 +0000)]
Can't use eval in iframes sanbdoxed via CSP header
https://bugs.webkit.org/show_bug.cgi?id=88450

Reviewed by Mihai Parparita.

Source/WebCore:

The initial empty document in a frame inherits the security context of
its parent (including the CSP policy).  When we load the real document,
in some cases we'll do a "secure transition" to the new document.  That
means that we leave the global object in place in case the parent
document has created any properties that it expects will be visible to
the new document.

If the parent document has a CSP policy that blocks eval, the "no eval"
bit will be set on the global object of the initial document.  When we
perform a "secure transition" to the new document, we'll keep the bit,
which is wrong.  In this patch, we reset the bit by always enabling
eval when clearing the context, regardless of whether we're performing
a "secure transition".

Test: http/tests/security/contentSecurityPolicy/iframe-inside-csp.html

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::enableEval):
(WebCore):
* bindings/js/ScriptController.h:
(ScriptController):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::enableEval):
(WebCore):
(WebCore::ScriptController::disableEval):
* bindings/v8/ScriptController.h:
(ScriptController):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):

LayoutTests:

* http/tests/security/contentSecurityPolicy/iframe-inside-csp-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/iframe-inside-csp.html: Added.
* http/tests/security/contentSecurityPolicy/resources/sandboxed-eval.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] skip new tests added in r119883
commit-queue@webkit.org [Sat, 9 Jun 2012 19:14:27 +0000 (19:14 +0000)]
[EFL] skip new tests added in r119883
https://bugs.webkit.org/show_bug.cgi?id=88716

Unreviewed EFL gardening. Skip new tests added in r119883.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-09

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe value in Access-Control-Allow-Origin is not being matched correctly for CORS...
commit-queue@webkit.org [Sat, 9 Jun 2012 18:42:41 +0000 (18:42 +0000)]
The value in Access-Control-Allow-Origin is not being matched correctly for CORS-enabled requests
https://bugs.webkit.org/show_bug.cgi?id=88139

Patch by Pablo Flouret <pablof@motorola.com> on 2012-06-09
Reviewed by Adam Barth.

Source/WebCore:

Compare a request's origin with the value given in any
Access-Control-Allow-Origin headers in an exact, case-sensitive manner,
instead of using SecurityOrigin::isSameSchemeHostPort(). Per step 3 of
the resource sharing check algorithm in
http://dvcs.w3.org/hg/cors/raw-file/tip/Overview.html#resource-sharing-check

Test: http/tests/xmlhttprequest/origin-exact-matching.html

* loader/CrossOriginAccessControl.cpp:
(WebCore::passesAccessControlCheck):

LayoutTests:

* http/tests/xmlhttprequest/origin-exact-matching-expected.txt: Added.
* http/tests/xmlhttprequest/origin-exact-matching.html: Added.
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Get rid of a trailing slash in the origin.
* http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip tests that rely on pathToLocalResource() due to regression in r119788
commit-queue@webkit.org [Sat, 9 Jun 2012 18:26:28 +0000 (18:26 +0000)]
[EFL] Skip tests that rely on pathToLocalResource() due to regression in r119788
https://bugs.webkit.org/show_bug.cgi?id=88714

Unreviewed EFL gardening. Skip tests that rely on pathToLocalResource()
due to regression in r119788.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-09

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling back in part2 of r118646.
ggaren@apple.com [Sat, 9 Jun 2012 17:34:30 +0000 (17:34 +0000)]
Unreviewed, rolling back in part2 of r118646.

This patch removes eager finalization.

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

* heap/Heap.cpp:
(JSC::Heap::collect): Don't finalize eagerly -- we'll do it lazily.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep): Do sweep weak sets when sweeping a block,
since we won't get another chance.

* heap/MarkedBlock.h:
(JSC::MarkedBlock::sweepWeakSet):
* heap/MarkedSpace.cpp:
(MarkedSpace::WeakSetSweep):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sweepWeakSets): Removed now-unused code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
commit-queue@webkit.org [Sat, 9 Jun 2012 17:11:58 +0000 (17:11 +0000)]
[Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=88703

The bug originated from StillImage that is not override
Image::currentFrameHasAlpha(), so it always returns false.
StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
TextureMapperBackingStore thinks contents does not have alpha.

Covered by existing compositing tests.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-09
Reviewed by Noam Rosenthal.

* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore):
* platform/graphics/qt/StillImageQt.h:
(StillImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBasic support for timestamps within a TextTrackCue
commit-queue@webkit.org [Sat, 9 Jun 2012 17:01:44 +0000 (17:01 +0000)]
Basic support for timestamps within a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=88187

Implemented support for timestamps within a TextTrackCue.
This enables rendering functionality for Karaoke and Paint-on captions.

Patch by Victor Carbune <victor@rosedu.org> on 2012-06-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-cue-rendering-inner-timestamps.html

* css/mediaControls.css: Remove the background shadow pseudo-id and
added two others, which can be further used for styling past / future
contents of the cue.
(video::-webkit-media-text-track-past-nodes): Used to style elements
within the cue that are before the current movie time.
(video::-webkit-media-text-track-future-nodes): Used to style elements
within the cue that are after the current movie time.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Regardless of whether
the active set changed or not, the current cues need to be informed of the current
movie time.
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): Initiliazed past and future containers.
(WebCore::TextTrackCue::getCueAsHTML): Checked whether the current cue text has
inner timestamps or not, in order to render faster if no timestamps are there.
(WebCore::TextTrackCue::updateDisplayTree): Added method that keeps the past and future
containers up to date, given a current movie time.
(WebCore):
(WebCore::TextTrackCue::getDisplayTree): Replaced the cue background container with the
past cues container. The *internal* display tree of the cue now has two containers,
representing past and future elements.
* html/track/TextTrackCue.h: Added several variables to support the new functionality.
(TextTrackCue):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken): Updated representation for this patch.
* html/track/WebVTTParser.h:
(WebVTTParser): Made public the collectTimeStamp method, as this is required for
parsing timestamps within a cue as well.

LayoutTests:

* media/track/captions-webvtt/captions-inner-timestamps.vtt: Added.
* media/track/track-cue-rendering-inner-timestamps-expected.txt: Added.
* media/track/track-cue-rendering-inner-timestamps.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Open links in Sources panel by default and fallback to Resources and...
vsevik@chromium.org [Sat, 9 Jun 2012 16:53:17 +0000 (16:53 +0000)]
Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
https://bugs.webkit.org/show_bug.cgi?id=88710

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._showAnchorLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Only expand root domain in Sources/Scripts panel
vsevik@chromium.org [Sat, 9 Jun 2012 16:48:07 +0000 (16:48 +0000)]
Web Inspector: Only expand root domain in Sources/Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=88135

Reviewed by Pavel Feldman.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Pretty print should respect text editor indent setting.
vsevik@chromium.org [Sat, 9 Jun 2012 16:46:49 +0000 (16:46 +0000)]
Web Inspector: Pretty print should respect text editor indent setting.
https://bugs.webkit.org/show_bug.cgi?id=88713

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptFormatter.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixed the build after r119895.
mitz@apple.com [Sat, 9 Jun 2012 16:29:59 +0000 (16:29 +0000)]
Fixed the build after r119895.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [refactoring] rename TimelineVerticalOverview into TimelineFrameOverview
caseq@chromium.org [Sat, 9 Jun 2012 13:18:08 +0000 (13:18 +0000)]
Web Inspector: [refactoring] rename TimelineVerticalOverview into TimelineFrameOverview
https://bugs.webkit.org/show_bug.cgi?id=88708

Reviewed by Vsevolod Vlasov.

- rename TimelineVerticalOverview to TimelineFrameOverview;
- rename associated fields, parameters, CSS classes etc;
- rename overview mode designators to match the UI;
- drop unused CSS rules for old-style mode selector;

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._showEvents):
(WebInspector.TimelineOverviewPane.prototype._showFrames):
(WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
(WebInspector.TimelineFrameOverview):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._shouldShowFrames):
(WebInspector.TimelinePanel.prototype.revealRecordAt):
* inspector/front-end/timelinePanel.css:
(.timeline-frame-overview #timeline-overview-grid):
(.timeline-frame-overview .timeline-overview-window):
(.timeline-frame-overview .timeline-overview-dividers-background):
(.timeline-frame-overview #timeline-overview-memory):
(.timeline-frame-overview-status-bar-item.toggled-on .glyph):
(.timeline-frame-overview-bars):
(.timeline.timeline-frame-overview .resources-divider):
(.sidebar-tree-item .timeline-frame-overview-status-bar-item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Inspector should handle null, string, and array keyPaths
vsevik@chromium.org [Sat, 9 Jun 2012 12:01:18 +0000 (12:01 +0000)]
IndexedDB: Inspector should handle null, string, and array keyPaths
https://bugs.webkit.org/show_bug.cgi?id=84303

Reviewed by Pavel Feldman.

Source/WebCore:

Supported different key path types and updated tests to cover each case.
Key path strings are now highlighted in the DataGrid column headers.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.idbKeyPathFromKeyPath):
(WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath):
(WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.ObjectStore.prototype.get keyPathString):
(WebInspector.IndexedDBModel.Index.prototype.get keyPathString):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
(WebInspector.IDBDataView.prototype._keyPathStringFragment):
(WebInspector.IDBDataGridNode.prototype.createCell):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
(WebInspector.IDBIndexTreeElement.prototype._updateTooltip):

LayoutTests:

* http/tests/inspector/indexeddb/database-structure-expected.txt:
* http/tests/inspector/indexeddb/database-structure.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening failure case on EFL build bot
commit-queue@webkit.org [Sat, 9 Jun 2012 11:49:03 +0000 (11:49 +0000)]
[EFL] Gardening failure case on EFL build bot
https://bugs.webkit.org/show_bug.cgi?id=88656

Unreviewed EFL gardening after r119795. jquery/core.html test
is crashing on debug bot and failing with a text diff on
release bot.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-09

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Increase size limits for resource content cached in InspectorResourceA...
vsevik@chromium.org [Sat, 9 Jun 2012 11:25:26 +0000 (11:25 +0000)]
Web Inspector: Increase size limits for resource content cached in InspectorResourceAgent.
https://bugs.webkit.org/show_bug.cgi?id=88674

Reviewed by Pavel Feldman.

* inspector/NetworkResourcesData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce...
vsevik@chromium.org [Sat, 9 Jun 2012 11:23:50 +0000 (11:23 +0000)]
Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
https://bugs.webkit.org/show_bug.cgi?id=87270

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced WebInspector.RawLocation interface, a generic raw location independent from concrete domain (Styles, Debugger).
Made WebInspector.DebuggerModel.Location implement it and switched all debugger related methods to it.

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._breakpointResolved):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.Location):
(WebInspector.DebuggerModel.prototype.continueToLocation):
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.createRawLocation):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
(WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
(WebInspector.DebuggerModel.prototype.createLiveLocation):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
(WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerResourceBinding.setScriptSource):
(WebInspector.DebuggerResourceBinding.prototype.setContent.get if):
(WebInspector.DebuggerResourceBinding.prototype.setContent):
(WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
* inspector/front-end/Linkifier.js:
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/PresentationConsoleMessageHelper.js:
* inspector/front-end/RawSourceCode.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.rawLocationToUILocation):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
* inspector/front-end/SourceMapping.js:
* inspector/front-end/UISourceCode.js:
(WebInspector.RawLocation):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/pause-in-inline-script.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add message loop instrumentation to public API and timeline agent
commit-queue@webkit.org [Sat, 9 Jun 2012 10:16:10 +0000 (10:16 +0000)]
Web Inspector: Add message loop instrumentation to public API and timeline agent
https://bugs.webkit.org/show_bug.cgi?id=88639

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-06-09
Reviewed by Vsevolod Vlasov.

Message loop instrumentation will show when the render thread is busy.
That way developer can discover if a render thread business causes low fps, or not.

Source/WebCore:

* inspector/InspectorClient.h:
(WebCore::InspectorClient::startMessageLoopMonitoring): Starts observer.
(WebCore::InspectorClient::stopMessageLoopMonitoring): Stops observer.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
Changed timeline agent constructor parameters.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willProcessTaskImpl):
Forwards observer notification.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTaskImpl):
Ditto.
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willProcessTask):
Ditto.
(WebCore):
(WebCore::InspectorInstrumentation::didProcessTask):
Ditto.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
Starts observer.
(WebCore::InspectorTimelineAgent::stop):
Stops observer.
(WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
Changed result origin.
(WebCore::InspectorTimelineAgent::willProcessTask):
Noop implementqation.
(WebCore):
(WebCore::InspectorTimelineAgent::didProcessTask):
Noop implementqation.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
Changed constructor parameters.
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
Ditto.
(InspectorTimelineAgent):
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
Changed timeline agent constructor parameters.

Source/WebKit/chromium:

* public/WebDevToolsAgent.h:
(WebDevToolsAgent):
* public/WebDevToolsAgentClient.h:
(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit::WebDevToolsAgentClient::stopMessageLoopMonitoring):
Cancel message loop notifications.
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::InspectorClientImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::startMessageLoopMonitoring):
Request message loop notifications.
(WebKit):
(WebKit::WebDevToolsAgentImpl::stopMessageLoopMonitoring):
Cancel message loop notifications.
(WebKit::WebDevToolsAgentImpl::instrumentWillProcessTask):
Message loop notification.
(WebKit::WebDevToolsAgentImpl::instrumentDidProcessTask):
Ditto.
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: optimize timeline's frame mode overview appearance for 30fps
caseq@chromium.org [Sat, 9 Jun 2012 10:13:21 +0000 (10:13 +0000)]
Web Inspector: optimize timeline's frame mode overview appearance for 30fps
https://bugs.webkit.org/show_bug.cgi?id=88556

Reviewed by Vsevolod Vlasov.

- adjust frame overview scale to 30fps == full height by default;
- provide a fall-back auto-scale mode when median frame is longer than 1/30s;
- add horizontal lines for 30 and 60fps;
- drive-by fix: always use same order of categories in frame bars.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype._renderBars):
(WebInspector.TimelineVerticalOverview.prototype._drawFPSMarks):
(WebInspector.TimelineVerticalOverview.prototype._renderBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd UNDO_MANAGER flag
commit-queue@webkit.org [Sat, 9 Jun 2012 09:05:22 +0000 (09:05 +0000)]
Add UNDO_MANAGER flag
https://bugs.webkit.org/show_bug.cgi?id=87908

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-06-09
Reviewed by Tony Chang.

.:

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add undoManager property to document behind the UNDO_MANAGER flag and
add placeholders for some methods of undoManager.

Test: editing/undomanager/document-has-undomanager.html

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore):
(WebCore::Document::undoManager):
* dom/Document.h:
(WebCore):
(Document):
* dom/Document.idl:
* editing/UndoManager.cpp: Added.
(WebCore):
(WebCore::UndoManager::create):
(WebCore::UndoManager::UndoManager):
(WebCore::UndoManager::undo):
(WebCore::UndoManager::redo):
(WebCore::UndoManager::clearUndo):
(WebCore::UndoManager::clearRedo):
* editing/UndoManager.h: Added.
(WebCore):
(UndoManager):
* editing/UndoManager.idl: Added.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch land-safely should set cq? if the patch author is not in committers.py
rniwa@webkit.org [Sat, 9 Jun 2012 06:18:30 +0000 (06:18 +0000)]
webkit-patch land-safely should set cq? if the patch author is not in committers.py
https://bugs.webkit.org/show_bug.cgi?id=88689

Reviewed by Dirk Pranke.

When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
in committers.py or the contributor cannot commit. If anything, the contributor can still
set cq+ on thier patches manually so I don't think this will be an issue for people who
don't list their Bugzille email on committers.py.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._commit_queue_flag):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
(test_commit_queue_flag):
(test_commit_queue_flag.assert_commit_queue_flag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
leviw@chromium.org [Sat, 9 Jun 2012 05:44:08 +0000 (05:44 +0000)]
RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
https://bugs.webkit.org/show_bug.cgi?id=88554

Reviewed by Darin Adler.

Source/WebCore:

Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
issue.

Test: fast/sub-pixel/column-clipping.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnContents):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):

LayoutTests:

* fast/sub-pixel/column-clipping-expected.html: Added.
* fast/sub-pixel/column-clipping.html: Added.
* platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.
rniwa@webkit.org [Sat, 9 Jun 2012 05:02:41 +0000 (05:02 +0000)]
Remove FAIL test expectations from EFL, Mac, and Qt ports' test expectations.

* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r116487?): HTMLFormElement::elements['name'] is empty if the form is detac...
commit-queue@webkit.org [Sat, 9 Jun 2012 03:50:03 +0000 (03:50 +0000)]
REGRESSION(r116487?): HTMLFormElement::elements['name'] is empty if the form is detached from the document tree
https://bugs.webkit.org/show_bug.cgi?id=88632

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Update root node of RadioNodeList when the form element is detached from dom tree.

Test: fast/forms/radionodelist-whose-form-element-detached-from-domtree.html

* dom/Node.cpp:
(WebCore::Node::resetCachedRadioNodeListRootNode):
New function to update the root node of RadioNodeLists to form element from document.
* dom/Node.h: Ditto.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::removedFrom):
On detach, we update the root node of all RadioNodeLists of this form element.
* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::setRootElement):
Setter for updating root node.
* html/RadioNodeList.h:
(RadioNodeList): Ditto.

LayoutTests:

* fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt: Added.
* fast/forms/radionodelist-whose-form-element-detached-from-domtree.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove obsolete NewRunWebKitTests buildbot master factory classes
dpranke@chromium.org [Sat, 9 Jun 2012 03:04:53 +0000 (03:04 +0000)]
remove obsolete NewRunWebKitTests buildbot master factory classes
https://bugs.webkit.org/show_bug.cgi?id=88693

Reviewed by Ryosuke Niwa.

I believe these aren't used any more ...

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.getText2):
(BuildAndTestLeaksFactory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove all uses of FAIL test expectation from Chromium test expectations.
rniwa@webkit.org [Sat, 9 Jun 2012 02:51:14 +0000 (02:51 +0000)]
Remove all uses of FAIL test expectation from Chromium test expectations.

* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium-Android] Build DumpRenderTree with Android SDK
wangxianzhu@chromium.org [Sat, 9 Jun 2012 02:45:25 +0000 (02:45 +0000)]
[Chromium-Android] Build DumpRenderTree with Android SDK
https://bugs.webkit.org/show_bug.cgi?id=88598

Change WebKit side of DRT related code according to some recent changes at chromium side.

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
(ChromiumAndroidPort._path_to_driver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Compositor doesn't support translucent root layers.
commit-queue@webkit.org [Sat, 9 Jun 2012 02:29:09 +0000 (02:29 +0000)]
[Chromium] Compositor doesn't support translucent root layers.
https://bugs.webkit.org/show_bug.cgi?id=87821

Patch by David Reveman <reveman@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/Platform:

* chromium/public/WebLayer.h:
(WebLayer):
* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):

Source/WebCore:

Forward the isTransparent WebView setting to WebLayerTreeView,
CCLayerTreeHost and CCLayerTreeHostImpl as hasTransparentBackground.
Use hasTransparentBackground setting to determine how to clear the
root render pass and draw the background. Set opaque flag correctly
on the NonCompositedContentHost's graphics layer to make sure
sub-pixel rendering is not used with a transparent WebView.

Unit tests: CCLayerTreeHostImplTest.hasTransparentBackground
            LayerRendererChromiumTest2.opaqueRenderPass
            LayerRendererChromiumTest2.transparentRenderPass

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::clearRenderPass):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setHasTransparentBackground):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::hasTransparentBackground):
(WebCore::CCLayerTreeHostImpl::setHasTransparentBackground):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::CCRenderPass):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore::CCRenderPass::hasTransparentBackground):
(WebCore::CCRenderPass::setHasTransparentBackground):
(CCRenderPass):

Source/WebKit/chromium:

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::setHasTransparentBackground):
(WebKit):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsTransparent):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostImplTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
(ClearCountingContext):
(ClearCountingContext::ClearCountingContext):
(ClearCountingContext::clear):
(ClearCountingContext::clearCount):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Single thread proxy's animation timer should short circuit if the layer...
commit-queue@webkit.org [Sat, 9 Jun 2012 02:26:36 +0000 (02:26 +0000)]
[chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
https://bugs.webkit.org/show_bug.cgi?id=88668

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-08
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer.runSingleThreaded

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestWriteLayersRedraw::beginTest):
(WTF::CCLayerTreeHostTestWriteLayersAfterVisible::commitCompleteOnCCThread):
(WTF):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::CCLayerTreeHostTestLayerAddedWithAnimation):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::beginTest):
(WTF::CCLayerTreeHostTestLayerAddedWithAnimation::didAddAnimation):
(CCLayerTreeHostTestLayerAddedWithAnimation):
* tests/CCSingleThreadProxyTest.cpp: Added.
(FakeWebGraphicsContext3DMakeCurrentFails):
(FakeWebGraphicsContext3DMakeCurrentFails::makeContextCurrent):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::beginTest):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::animateLayers):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::didRecreateContext):
(CCSingleThreadProxyTestInitializeLayerRendererFailsAfterAddAnimation::afterTest):
(TEST_F):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::beginTest):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::animateLayers):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didRecreateContext):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::didAddAnimation):
(CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer::afterTest):
* tests/CCThreadedTest.cpp: Added.
(WebKitTests):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::create):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::createTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::deleteTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::bindTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::texture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::numUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::usedTexture):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::resetUsedTextures):
(WebKitTests::CompositorFakeWebGraphicsContext3DWithTextureTracking::CompositorFakeWebGraphicsContext3DWithTextureTracking):
(WebKitTests::TestHooks::createContext):
(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::beginCommit):
(WebKitTests::MockLayerTreeHostImpl::commitComplete):
(WebKitTests::MockLayerTreeHostImpl::prepareToDraw):
(WebKitTests::MockLayerTreeHostImpl::drawLayers):
(WebKitTests::MockLayerTreeHostImpl::animateLayers):
(WebKitTests::MockLayerTreeHostImpl::lowFrequencyAnimationInterval):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHost):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHostClient):
(WebKitTests::MockLayerTreeHostClient::create):
(WebKitTests::MockLayerTreeHostClient::MockLayerTreeHostClient):
(TimeoutTask):
(WebKitTests::TimeoutTask::TimeoutTask):
(WebKitTests::TimeoutTask::clearTest):
(WebKitTests::TimeoutTask::~TimeoutTask):
(WebKitTests::TimeoutTask::run):
(BeginTask):
(WebKitTests::BeginTask::BeginTask):
(WebKitTests::BeginTask::~BeginTask):
(WebKitTests::BeginTask::run):
(EndTestTask):
(WebKitTests::EndTestTask::EndTestTask):
(WebKitTests::EndTestTask::~EndTestTask):
(WebKitTests::EndTestTask::clearTest):
(WebKitTests::EndTestTask::run):
(WebKitTests::CCThreadedTest::CCThreadedTest):
(WebKitTests::CCThreadedTest::endTest):
(WebKitTests::CCThreadedTest::endTestAfterDelay):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateToMainThread):
(WebKitTests::CCThreadedTest::postAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::postAddInstantAnimationToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsCommitToMainThread):
(WebKitTests::CCThreadedTest::postAcquireLayerTextures):
(WebKitTests::CCThreadedTest::postSetNeedsRedrawToMainThread):
(WebKitTests::CCThreadedTest::postSetNeedsAnimateAndCommitToMainThread):
(WebKitTests::CCThreadedTest::postSetVisibleToMainThread):
(WebKitTests::CCThreadedTest::postDidAddAnimationToMainThread):
(WebKitTests::CCThreadedTest::doBeginTest):
(WebKitTests::CCThreadedTest::timeout):
(WebKitTests::CCThreadedTest::scheduleComposite):
(WebKitTests::CCThreadedTest::onEndTest):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimate):
(WebKitTests::CCThreadedTest::dispatchAddInstantAnimation):
(WebKitTests::CCThreadedTest::dispatchAddAnimation):
(WebKitTests::CCThreadedTest::dispatchSetNeedsAnimateAndCommit):
(WebKitTests::CCThreadedTest::dispatchSetNeedsCommit):
(WebKitTests::CCThreadedTest::dispatchAcquireLayerTextures):
(WebKitTests::CCThreadedTest::dispatchSetNeedsRedraw):
(WebKitTests::CCThreadedTest::dispatchSetVisible):
(WebKitTests::CCThreadedTest::dispatchSetInvisible):
(WebKitTests::CCThreadedTest::dispatchComposite):
(WebKitTests::CCThreadedTest::dispatchDidAddAnimation):
(WebKitTests::CCThreadedTest::runTest):
* tests/CCThreadedTest.h: Added.
(WebCore):
(WebKit):
(WebKitTests):
(TestHooks):
(WebKitTests::TestHooks::beginCommitOnCCThread):
(WebKitTests::TestHooks::commitCompleteOnCCThread):
(WebKitTests::TestHooks::prepareToDrawOnCCThread):
(WebKitTests::TestHooks::drawLayersOnCCThread):
(WebKitTests::TestHooks::animateLayers):
(WebKitTests::TestHooks::willAnimateLayers):
(WebKitTests::TestHooks::applyScrollAndScale):
(WebKitTests::TestHooks::updateAnimations):
(WebKitTests::TestHooks::layout):
(WebKitTests::TestHooks::didRecreateContext):
(WebKitTests::TestHooks::didAddAnimation):
(WebKitTests::TestHooks::didCommit):
(WebKitTests::TestHooks::didCommitAndDrawFrame):
(WebKitTests::TestHooks::scheduleComposite):
(WebKitTests::TestHooks::notifyAnimationStarted):
(WebKitTests::TestHooks::notifyAnimationFinished):
(CCThreadedTest):
(WebKitTests::CCThreadedTest::clearTimeout):
(WebKitTests::CCThreadedTest::clearEndTestTask):
(WebKitTests::CCThreadedTest::layerTreeHost):
(CCThreadedTestThreadOnly):
(WebKitTests::CCThreadedTestThreadOnly::runTestThreaded):
(MockLayerTreeHostImpl):
(CompositorFakeWebGraphicsContext3DWithTextureTracking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLast set of chromium rebaselines missed in r119875.
ojan@chromium.org [Sat, 9 Jun 2012 02:00:19 +0000 (02:00 +0000)]
Last set of chromium rebaselines missed in r119875.

* platform/chromium-linux/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
* platform/chromium-linux/svg/custom/js-update-container-expected.png: Added.
* platform/chromium-linux/svg/custom/js-update-polygon-changes-expected.png: Added.
* platform/chromium-linux/svg/custom/js-update-polygon-removal-expected.png: Added.
* platform/chromium-linux/svg/custom/js-update-transform-addition-expected.png: Added.
* platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png: Added.
* platform/chromium-linux/svg/custom/marker-referencePoint-expected.png: Added.
* platform/chromium-linux/svg/custom/non-scaling-stroke-markers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCaret is not rendered in empty inline contenteditable elements
commit-queue@webkit.org [Sat, 9 Jun 2012 01:56:42 +0000 (01:56 +0000)]
Caret is not rendered in empty inline contenteditable elements
https://bugs.webkit.org/show_bug.cgi?id=85793

Patch by Shezan Baig <shezbaig.wk@gmail.com> on 2012-06-08
Reviewed by Ryosuke Niwa.

Source/WebCore:

Override localCaretRect in RenderInline. The implementation was almost
identical to localCaretRect in RenderBlock for empty block elements, so
I refactored RenderBlock::localCaretRect and moved the logic to a new
method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
implementation of 'localCaretRect' in RenderBlock and RenderInline both
use this helper method in RenderBoxModelObject.

Tests: editing/selection/caret-in-empty-inline-1.html
       editing/selection/caret-in-empty-inline-2.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::localCaretRect):
Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
(WebCore):
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
Add localCaretRectForEmptyElement helper method.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::localCaretRect):
(WebCore):
* rendering/RenderInline.h:
(RenderInline):
Override localCaretRect using localCaretRectForEmptyElement.

LayoutTests:

Add test cases for caret in empty inline.

* editing/selection/caret-in-empty-inline-1-expected.txt: Added.
* editing/selection/caret-in-empty-inline-1.html: Added.
* editing/selection/caret-in-empty-inline-2-expected.txt: Added.
* editing/selection/caret-in-empty-inline-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Treat blob: and filesystem: URLs generated via secure origins as...
commit-queue@webkit.org [Sat, 9 Jun 2012 01:51:27 +0000 (01:51 +0000)]
Source/WebCore: Treat blob: and filesystem: URLs generated via secure origins as secure.
https://bugs.webkit.org/show_bug.cgi?id=84054

Loading a blob: or filesystem: URL into an iframe or image that's
contained on an HTTPS page shouldn't generate a mixed content warning.
This change adds a SecurityOrigin::isSecure to check both against a
URLs protocol, and the protocol of it's so-called "inner URL" if it's
the type of URL that has such a thing. These sorts of URLs which are
generated from secure sources will themselves be treated as secure.

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

Tests: http/tests/security/mixedContent/blob-url-in-iframe.html
       http/tests/security/mixedContent/filesystem-url-in-iframe.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::isMixedContent):
* page/SecurityOrigin.cpp:
(WebCore):
(WebCore::SecurityOrigin::isSecure):
* page/SecurityOrigin.h:
(SecurityOrigin):

LayoutTests: Excluding blob: and filesystem: schemes from the mixed content check.
https://bugs.webkit.org/show_bug.cgi?id=84054

Patch by Mike West <mkwst@chromium.org> on 2012-06-08
Reviewed by Adam Barth.

* http/tests/security/mixedContent/blob-url-in-iframe-expected.txt: Added.
* http/tests/security/mixedContent/blob-url-in-iframe.html: Added.
* http/tests/security/mixedContent/filesystem-url-in-iframe-expected.txt: Added.
* http/tests/security/mixedContent/filesystem-url-in-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting...
commit-queue@webkit.org [Sat, 9 Jun 2012 00:56:05 +0000 (00:56 +0000)]
[Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting with canvas
https://bugs.webkit.org/show_bug.cgi?id=87797

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-08
Reviewed by Philippe Normand.

No new tests. WebGL is already covered by WebGL tests and this
bug is only present on certain hardware.

After resolving multisampling before drawing the texture via the
TextureMapper, first rebind the multisampling framebuffer. This ensures
that the texture isn't active in two framebuffers at a time.

* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Rebind the multisampling
framebuffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Build fix after Windows export definition file change.
bfulgham@webkit.org [Sat, 9 Jun 2012 00:46:02 +0000 (00:46 +0000)]
[WinCairo] Build fix after Windows export definition file change.

* win/WebKit2CFLite.def: This file needs to be kept in sync with
WebKit2.def (aside from the WebKitInterface exports.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix crash on PagePopupChromeClient
commit-queue@webkit.org [Sat, 9 Jun 2012 00:12:16 +0000 (00:12 +0000)]
[BlackBerry] Fix crash on PagePopupChromeClient
https://bugs.webkit.org/show_bug.cgi?id=88675

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-08
Reviewed by Antonio Gomes.

PR 163672.

Actually it's the bug inside InputHandler, should delete the old popup and create a new one,
because update() is problematic. Also no need to save pointer in InputHandler.

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::openPagePopup):
(WebCore::ChromeClientBlackBerry::closePagePopup):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
* WebKitSupport/InputHandler.h:
(WebCore):
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Default font settings are getting deleted
efidler@rim.com [Sat, 9 Jun 2012 00:07:36 +0000 (00:07 +0000)]
[BlackBerry] Default font settings are getting deleted
https://bugs.webkit.org/show_bug.cgi?id=88670

Reviewed by Rob Buis.

Source/WebKit/blackberry:

RIM PR: 163720

WebSettings is overriding the default font settings with "", which deletes them.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):

LayoutTests:

This test crashes if -webkit-body (i.e.  WebCore::Settings::standardFontFamily())
is not a valid font family.

* fonts/valid-standard-font.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling back in part1 of r118646.
ggaren@apple.com [Fri, 8 Jun 2012 23:57:58 +0000 (23:57 +0000)]
Unreviewed, rolling back in part1 of r118646.

This patch includes everything necessary for lazy finalization, but
keeps eager finalization enabled for the time being.

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Sam Weinig.

* heap/MarkedBlock.cpp:
* heap/MarkedBlock.h:
(JSC::MarkedBlock::resetAllocator):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocators):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::resetAllocators): Don't force allocator reset anymore.
It will happen automatically when a weak set is swept. It's simpler to
have only one canonical way for this to happen, and it wasn't buying
us anything to do it eagerly.
* heap/WeakBlock.cpp:
(JSC::WeakBlock::sweep): Don't short-circuit a sweep unless we know
the sweep would be a no-op. If even one finalizer is pending, we need to
run it, since we won't get another chance.
* heap/WeakSet.cpp:
(JSC::WeakSet::sweep): This loop can be simpler now that
WeakBlock::sweep() does what we mean.
Reset our allocator after a sweep because this is the optimal time to
start trying to recycle old weak pointers.
(JSC::WeakSet::tryFindAllocator): Don't sweep when searching for an
allocator because we've swept already, and forcing a new sweep would be
wasteful.
* heap/WeakSet.h:
(JSC::WeakSet::shrink): Be sure to reset our allocator after a shrink
because the shrink may have removed the block the allocator was going to
allocate out of.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/11412294> Add appropriate iOS default font settings
ap@apple.com [Fri, 8 Jun 2012 23:54:16 +0000 (23:54 +0000)]
    <rdar://problem/11412294> Add appropriate iOS default font settings

        Reviewed by Dan Bernstein.

        * page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Transactions without any request scheduled should abort itself.
charles.wei@torchmobile.com.cn [Fri, 8 Jun 2012 23:41:36 +0000 (23:41 +0000)]
IndexedDB: Transactions without any request scheduled should abort itself.
https://bugs.webkit.org/show_bug.cgi?id=88052

Reviewed by Kentaro Hara.

This is needed for indexedDB to make it work for JSC. We need to clean up all the
pending transactions(transactions without any request scheduled) when leaving Javascript context.

Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html

* bindings/js/JSMainThreadExecState.cpp:
(WebCore):
(WebCore::JSMainThreadExecState::didLeaveScriptContext):
* bindings/js/JSMainThreadExecState.h:
(WebCore::JSMainThreadExecState::~JSMainThreadExecState):
(JSMainThreadExecState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFinal set of chromium rebaselines for skia change. See crbug.com/131829.
ojan@chromium.org [Fri, 8 Jun 2012 23:18:05 +0000 (23:18 +0000)]
Final set of chromium rebaselines for skia change. See crbug.com/131829.

* platform/chromium-linux/svg/clip-path/clipper-placement-issue-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
* platform/chromium-linux/svg/css/arrow-with-shadow-expected.png: Added.
* platform/chromium-linux/svg/css/background-image-svg-expected.png: Added.
* platform/chromium-linux/svg/custom/broken-internal-references-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
* platform/chromium-linux/svg/custom/dynamic-empty-path-expected.png: Added.
* platform/chromium-linux/svg/custom/gradient-stop-corner-cases-expected.png: Added.
* platform/chromium-linux/svg/custom/svgpolyparser-extra-space-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
* platform/chromium-linux/svg/custom/use-forward-refs-expected.png: Added.
* platform/chromium-linux/svg/custom/use-on-clip-path-with-transformation-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
* platform/chromium-linux/svg/text/text-hkern-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
* platform/chromium-linux/svg/text/text-vkern-expected.png: Added.
* platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png.
* platform/chromium-linux/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png.
* platform/chromium-linux/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Copied from LayoutTests/platform/chromium-win/svg/custom/js-update-container-expected.png.
* platform/chromium-win-xp/platform/chromium/compositing/accelerated-drawing/svg-filters-expected.png: Removed.
* platform/chromium-win/svg/custom/js-late-marker-creation-expected.png:
* platform/chromium-win/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png:
* platform/chromium-win/svg/custom/js-update-bounce-expected.png:
* platform/chromium-win/svg/custom/js-update-container-expected.png:
* platform/chromium-win/svg/custom/js-update-path-changes-expected.png:
* platform/chromium-win/svg/custom/js-update-path-removal-expected.png:
* platform/chromium-win/svg/custom/js-update-polygon-changes-expected.png:
* platform/chromium-win/svg/custom/js-update-polygon-removal-expected.png:
* platform/chromium-win/svg/custom/js-update-transform-addition-expected.png:
* platform/chromium-win/svg/custom/js-update-transform-changes-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
* platform/chromium-win/svg/custom/linking-uri-01-b-expected.png:
* platform/chromium-win/svg/custom/marker-changes-expected.png:
* platform/chromium-win/svg/custom/marker-child-changes-css-expected.png:
* platform/chromium-win/svg/custom/marker-child-changes-expected.png:
* platform/chromium-win/svg/custom/marker-opacity-expected.png:
* platform/chromium-win/svg/custom/marker-referencePoint-expected.png:
* platform/chromium-win/svg/custom/marker-strokeWidth-changes-expected.png:
* platform/chromium-win/svg/custom/marker-viewBox-changes-expected.png:
* platform/chromium-win/svg/custom/mask-colorspace-expected.png:
* platform/chromium-win/svg/custom/mask-on-multiple-objects-expected.png:
* platform/chromium-win/svg/custom/no-inherited-dashed-stroke-expected.png:
* platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
* platform/chromium-win/svg/custom/non-scaling-stroke-markers-expected.png:
* platform/chromium-win/svg/custom/object-sizing-explicit-height-expected.png:
* platform/chromium-win/svg/custom/object-sizing-explicit-width-height-expected.png:
* platform/chromium-win/svg/filters/invalidate-on-child-layout-expected.png:
* platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the GTK+ build when OpenGL is enabled.
mrobinson@webkit.org [Fri, 8 Jun 2012 23:13:35 +0000 (23:13 +0000)]
Fix the GTK+ build when OpenGL is enabled.

* configure.ac: Fix the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoviewspec-parser tests still timeout in Chromium debug even when marked slow.
ojan@chromium.org [Fri, 8 Jun 2012 23:13:03 +0000 (23:13 +0000)]
viewspec-parser tests still timeout in Chromium debug even when marked slow.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
rniwa@webkit.org [Fri, 8 Jun 2012 23:09:35 +0000 (23:09 +0000)]
Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
https://bugs.webkit.org/show_bug.cgi?id=88361

Reviewed by Levi Weintraub.

Use RefPtr instead of raw pointers across DOM mutations.

No tests are added for the lack of a reliable reduction.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119514.
commit-queue@webkit.org [Fri, 8 Jun 2012 23:00:37 +0000 (23:00 +0000)]
Unreviewed, rolling out r119514.
http://trac.webkit.org/changeset/119514
https://bugs.webkit.org/show_bug.cgi?id=88664

Broke JSFiddle.net (Requested by arv on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-08

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate):

LayoutTests:

* fast/dom/Window/window-property-shadowing-name-expected.txt:
* fast/dom/Window/window-property-shadowing-name.html:
* fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
* fast/dom/Window/window-property-shadowing-onclick.html: Removed.
* platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
* platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::InsertParagraphSeparatorCommand::doApply
rniwa@webkit.org [Fri, 8 Jun 2012 22:35:35 +0000 (22:35 +0000)]
Crash in WebCore::InsertParagraphSeparatorCommand::doApply
https://bugs.webkit.org/show_bug.cgi?id=88108

Reviewed by Levi Weintraub.

Use NodeVector instead of walking through siblings as we mutate the DOM.

No new tests are added since there is no reliable reduction.

* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
(WebCore):
* editing/CompositeEditCommand.h:
(CompositeEditCommand):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] build accelerated compositing on by default if OpenGL is present
mrobinson@webkit.org [Fri, 8 Jun 2012 22:24:55 +0000 (22:24 +0000)]
[GTK] build accelerated compositing on by default if OpenGL is present
https://bugs.webkit.org/show_bug.cgi?id=88677

Reviewed by Alejandro G. Castro.

Build accelerated compositing by default if OpenGL is present, just like WebGL.
Also prevent enabling WebGL if Clutter is turned on.

* configure.ac: Build AC by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: rename some instances of open to registerFrontendCallbacks
dgrogan@chromium.org [Fri, 8 Jun 2012 21:59:30 +0000 (21:59 +0000)]
IndexedDB: rename some instances of open to registerFrontendCallbacks
https://bugs.webkit.org/show_bug.cgi?id=88611

Source/WebCore:

We should still make the change in the WebKit API.

Reviewed by Tony Chang.

No new tests, just a method rename.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::registerFrontendCallbacks):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::open):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Skip willDraw() and didDraw() on fully occluded layers
danakj@chromium.org [Fri, 8 Jun 2012 21:37:33 +0000 (21:37 +0000)]
[chromium] Skip willDraw() and didDraw() on fully occluded layers
https://bugs.webkit.org/show_bug.cgi?id=88435

Reviewed by Adrienne Walker.

Source/WebCore:

Current willDraw() is called on all layers with non-empty
visibleLayerRect and non-empty scissorRect. This excludes
layers outside the viewport, but does not exclude occluded
layers. We add a check for occlusion to calculateRenderPasses
in order to avoid willDraw() when it will be culled anyway.

We prevent didDraw() from being called for occluded layers, for
which we did not call didDraw() by holding a vector of layers
for which we did call willDraw(). This lets us avoid storing a
flag on the layers, or computing occlusion again in
didDrawAllLayers.

Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSecond wave of Chromium rebaselines after skia change. See crbug.com/131829.
ojan@chromium.org [Fri, 8 Jun 2012 21:37:01 +0000 (21:37 +0000)]
Second wave of Chromium rebaselines after skia change. See crbug.com/131829.

List of changed expectations deleted because it's too long.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed roll out r119795.
barraclough@apple.com [Fri, 8 Jun 2012 21:30:35 +0000 (21:30 +0000)]
Unreviewed roll out r119795.

This broke jquery/core.html

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
* llint/LowLevelInterpreter.asm:
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
(JSC::JSObject::createInheritorID):
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID):
(JSC):
(JSC::JSObject::offsetOfInheritorID):
(JSC::JSObject::inheritorID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made...
mitz@apple.com [Fri, 8 Jun 2012 21:13:56 +0000 (21:13 +0000)]
Added Mac pixel results for canvas-imageSmoothingEnabled-patterns.html, and made the text
results shared between platforms.

* fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Added.
* platform/chromium/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
* platform/gtk/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
* platform/mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119864 268f45cc-cd09-0410-ab3c-d52691b4dbfc