WebKit-https.git
8 years ago[chromium] Remove some leftover references to LayerTilerChromium
danakj@chromium.org [Thu, 24 May 2012 19:03:05 +0000 (19:03 +0000)]
[chromium] Remove some leftover references to LayerTilerChromium
https://bugs.webkit.org/show_bug.cgi?id=87405

Reviewed by James Robinson.

* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/SolidColorLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash...
jberlin@webkit.org [Thu, 24 May 2012 18:57:14 +0000 (18:57 +0000)]
REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=87410

Reviewed by Anders Carlsson.

Do not pass a reference type to va_start (see r75435).

* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT
yael.aharon@nokia.com [Thu, 24 May 2012 18:54:16 +0000 (18:54 +0000)]
[Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=87392

Reviewed by Antonio Gomes.

Source/WebCore:

Remove our dependency on a build flag and use the new setting.

No new tests.

* css/StyleResolver.cpp:

Source/WebKit2:

Turn on the setting setFixedPositionCreatesStackingContext.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):

LayoutTests:

Update test expectations, since now don't turn on the setting when running layout tests.

* platform/qt/fast/block/positioning/016-expected.txt:
* platform/qt/fast/block/positioning/025-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [WK2] Let the client give local files universal access on a case by case...
ap@apple.com [Thu, 24 May 2012 18:42:58 +0000 (18:42 +0000)]
    [WK2] Let the client give local files universal access on a case by case basis
        https://bugs.webkit.org/show_bug.cgi?id=87174
        <rdar://problem/11024330>

        Reviewed by Maciej Stachowiak.

        * dom/Document.cpp: (WebCore::Document::initSecurityContext): When settings->allowUniversalAccessFromFileURLs()
        is false, also try asking the client for an indulgence.

        * loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::shouldForceUniversalAccessFromLocalURL):
        Default implementation doesn't change anything.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoimprove StyleRareNonInheritedData bit packing on Windows
tony@chromium.org [Thu, 24 May 2012 18:35:10 +0000 (18:35 +0000)]
improve StyleRareNonInheritedData bit packing on Windows
https://bugs.webkit.org/show_bug.cgi?id=87322

Reviewed by Eric Seidel.

Accessors for m_runningAcceleratedAnimation and m_hasAspectRatio are on RenderStyle already.

Also reorder the variables in operator== to be consistent with the constructor and header file.
This makes it easier to add or remove values.

No new tests, just refactoring.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNegative margin block doesn't properly clear a float enclosed by a previous sibling
robert@webkit.org [Thu, 24 May 2012 18:14:36 +0000 (18:14 +0000)]
Negative margin block doesn't properly clear a float enclosed by a previous sibling
https://bugs.webkit.org/show_bug.cgi?id=10900

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/css/clear-float-sibling.html

Parent blocks keep a list of child floats that extend out of the parent block and
by implication overhang into the parent's siblings. But this doesn't work if the
sibling has collapsing margins - it will not find the float in the previous block's
list so will ignore the float and fail to clear it.

RenderBlock:collapseMargins() needs to check if a child's collapsing margin has
reduced the height of the parent up past the bottom of its previous sibling's lowest float
and add the now overhanging float to the parent's float list if appropriate.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::collapseMargins):

LayoutTests:

* fast/css/clear-float-sibling-expected.html: Added.
* fast/css/clear-float-sibling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup: introduce toFile() to reduce static cast from Blob to File
kinuko@chromium.org [Thu, 24 May 2012 18:08:21 +0000 (18:08 +0000)]
Cleanup: introduce toFile() to reduce static cast from Blob to File
https://bugs.webkit.org/show_bug.cgi?id=87234

Reviewed by Eric Seidel.

Source/WebCore:

No new tests as this must have no side effect.

* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::toV8):
* fileapi/Blob.cpp:
(WebCore::Blob::webkitSlice):
* fileapi/Blob.h:
(Blob):
* fileapi/File.h:
(WebCore::toFile): Added.
(WebCore):
* fileapi/FileReader.cpp:
(WebCore::FileReader::readAsArrayBuffer):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::files):
* platform/network/FormData.cpp:
(WebCore::FormData::appendKeyValuePairItems):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):

Source/WebKit/chromium:

* src/WebDragData.cpp:
(WebKit::WebDragData::items):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVGElement::addEventListener has peculiar RefPtr usage
darin@apple.com [Thu, 24 May 2012 18:03:22 +0000 (18:03 +0000)]
SVGElement::addEventListener has peculiar RefPtr usage
https://bugs.webkit.org/show_bug.cgi?id=86497

Reviewed by Andy Estes.

* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener): Switch to a more-standard style of RefPtr usage,
getting rid of some unneeded reference count churn; also removed an unneeded special case
for zero listeners.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up the Windows Skipped list a bit.
jberlin@webkit.org [Thu, 24 May 2012 17:54:51 +0000 (17:54 +0000)]
Clean up the Windows Skipped list a bit.

Update it for the renames in r108832 and the test removed in r113532.
Also, replace "//" with "#" in a couple comments.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Modify keycode conversion functions to return keycodes with location informatio...
rakuco@webkit.org [Thu, 24 May 2012 17:44:26 +0000 (17:44 +0000)]
[EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
https://bugs.webkit.org/show_bug.cgi?id=87203

Reviewed by Andreas Kling.

Source/WebCore:

Add the required changes to make
fast/events/keydown-leftright-keys.html pass after r118001.

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createWindowsKeyMap): Translate the keycodes for
"{left,right}{Shift,Alt,Control}" into the right windows keyboard
definitions.

Tools:

Add the required changes to make
fast/events/keydown-leftright-keys.html pass after r118001.

* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
into the proper X11 keysym definitions.

LayoutTests:

* platform/efl/test_expectations.txt: Unskip fast/events/keydown-leftright-keys.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update test expectations for layout test fast/events/click-focus-anchor.html
commit-queue@webkit.org [Thu, 24 May 2012 17:24:20 +0000 (17:24 +0000)]
[EFL] Update test expectations for layout test fast/events/click-focus-anchor.html
https://bugs.webkit.org/show_bug.cgi?id=87293

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-24
Reviewed by Eric Seidel.

Anchor elements are mouse focusable in EFL port.

* fast/events/click-focus-anchor-expected.txt:
* fast/events/click-focus-anchor.html:
* platform/efl/Skipped:
* platform/efl/fast/events/click-focus-anchor-expected.txt:
* platform/gtk/fast/events/click-focus-anchor-expected.txt:
* platform/qt/fast/events/click-focus-anchor-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Wrong cursor used for ne-resize
commit-queue@webkit.org [Thu, 24 May 2012 17:20:33 +0000 (17:20 +0000)]
[Gtk] Wrong cursor used for ne-resize
https://bugs.webkit.org/show_bug.cgi?id=87366

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2012-05-24
Reviewed by Eric Seidel.

* platform/gtk/CursorGtk.cpp:
(WebCore::Cursor::ensurePlatformCursor): Use GDK_TOP_RIGHT_CORNER
for Cursor::NorthEastPanning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update test expectations for layout test fast/events/click-focus-control.html
commit-queue@webkit.org [Thu, 24 May 2012 17:18:07 +0000 (17:18 +0000)]
[EFL] Update test expectations for layout test fast/events/click-focus-control.html
https://bugs.webkit.org/show_bug.cgi?id=87295

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-05-24
Reviewed by Eric Seidel.

HTMLFormControlElement is not mouse focusable in EFL port.

* platform/efl/Skipped:
* platform/efl/fast/events/click-focus-control-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse built-in data type DashArray
commit-queue@webkit.org [Thu, 24 May 2012 17:15:13 +0000 (17:15 +0000)]
use built-in data type DashArray
https://bugs.webkit.org/show_bug.cgi?id=87344

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-24
Reviewed by Eric Seidel.

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unskip and rebase now passing tests from qt-5.0/Skipped list.
ossy@webkit.org [Thu, 24 May 2012 17:02:40 +0000 (17:02 +0000)]
[Qt] Unskip and rebase now passing tests from qt-5.0/Skipped list.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-05-24
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.txt: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.txt: Added.
* platform/qt-5.0-wk2/editing/selection/select-box-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/select-box-expected.txt: Added.
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Added.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/box-shadow-override-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/input-disabled-color-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/menulist-separator-painting-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/placeholder-pseudo-style-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/select-background-none-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/selectlist-minsize-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/textarea-align-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/textarea-align-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/textarea-setinnerhtml-expected.txt: Added.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.png: Added.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.txt: Added.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.png: Added.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.txt: Added.
* platform/qt-5.0-wk2/fast/replaced/three-selects-break-expected.png: Added.
* platform/qt-5.0-wk2/fast/replaced/three-selects-break-expected.txt: Added.
* platform/qt-5.0-wk2/fast/table/003-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/003-expected.txt: Added.
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png: Added.
* platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.txt: Added.
* platform/qt-5.0/Skipped:
* platform/qt-5.0/editing/pasteboard/4944770-1-expected.png: Added.
* platform/qt-5.0/editing/pasteboard/4944770-1-expected.txt: Added.
* platform/qt-5.0/editing/pasteboard/4944770-2-expected.png: Added.
* platform/qt-5.0/editing/pasteboard/4944770-2-expected.txt: Added.
* platform/qt-5.0/editing/selection/select-box-expected.png: Added.
* platform/qt-5.0/editing/selection/select-box-expected.txt: Added.
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png: Added.
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceMotion/create-event-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceMotion/no-page-cache-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceMotion/optional-event-properties-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceMotion/window-property-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceOrientation/create-event-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceOrientation/no-page-cache-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceOrientation/optional-event-properties-expected.txt: Added.
* platform/qt-5.0/fast/dom/DeviceOrientation/window-property-expected.txt: Added.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
* platform/qt-5.0/fast/dom/Orientation/create-event-orientationchange-expected.txt: Added.
* platform/qt-5.0/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
* platform/qt-5.0/fast/dynamic/008-expected.png: Added.
* platform/qt-5.0/fast/dynamic/008-expected.txt: Added.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.png: Added.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label06-expected.txt: Added.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.png: Added.
* platform/qt-5.0/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
* platform/qt-5.0/fast/forms/box-shadow-override-expected.png: Added.
* platform/qt-5.0/fast/forms/box-shadow-override-expected.txt: Added.
* platform/qt-5.0/fast/forms/form-element-geometry-expected.png: Added.
* platform/qt-5.0/fast/forms/form-element-geometry-expected.txt: Added.
* platform/qt-5.0/fast/forms/input-disabled-color-expected.png: Added.
* platform/qt-5.0/fast/forms/input-disabled-color-expected.txt: Added.
* platform/qt-5.0/fast/forms/menulist-separator-painting-expected.png: Added.
* platform/qt-5.0/fast/forms/menulist-separator-painting-expected.txt: Added.
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.png: Added.
* platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt: Added.
* platform/qt-5.0/fast/forms/select-background-none-expected.png: Added.
* platform/qt-5.0/fast/forms/select-background-none-expected.txt: Added.
* platform/qt-5.0/fast/forms/select-baseline-expected.png: Added.
* platform/qt-5.0/fast/forms/select-baseline-expected.txt: Added.
* platform/qt-5.0/fast/forms/selectlist-minsize-expected.png: Added.
* platform/qt-5.0/fast/forms/selectlist-minsize-expected.txt: Added.
* platform/qt-5.0/fast/forms/textarea-align-expected.png: Added.
* platform/qt-5.0/fast/forms/textarea-align-expected.txt: Added.
* platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.png: Added.
* platform/qt-5.0/fast/forms/textarea-setinnerhtml-expected.txt: Added.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.png: Added.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.txt: Added.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.png: Added.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.txt: Added.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.png: Added.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.txt: Added.
* platform/qt-5.0/fast/table/003-expected.png: Added.
* platform/qt-5.0/fast/table/003-expected.txt: Added.
* platform/qt-5.0/fast/text/basic/003-expected.png: Added.
* platform/qt-5.0/fast/text/basic/003-expected.txt: Added.
* platform/qt-5.0/fast/text/large-text-composed-char-expected.png: Added.
* platform/qt-5.0/fast/text/large-text-composed-char-expected.txt: Added.
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.png: Added.
* platform/qt-5.0/fast/text/letter-spacing-negative-opacity-expected.txt: Added.
* platform/qt-5.0/fast/xsl/document-function-expected.png: Added.
* platform/qt-5.0/fast/xsl/document-function-expected.txt: Added.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.png: Added.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix Webkit1 + V8 build.
commit-queue@webkit.org [Thu, 24 May 2012 16:39:51 +0000 (16:39 +0000)]
[Qt]  Fix Webkit1 + V8 build.
https://bugs.webkit.org/show_bug.cgi?id=87368

Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-05-24
Reviewed by Eric Seidel.

Source/WebCore:

No new tests, because this is a buildfix.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/v8/npruntime_impl.h:
* bindings/v8/npruntime_priv.h:

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move queryLocalizedString to Platform.h
pilgrim@chromium.org [Thu, 24 May 2012 16:29:22 +0000 (16:29 +0000)]
[Chromium] Move queryLocalizedString to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85762

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::queryLocalizedString):
* chromium/public/WebLocalizedString.h: Added.
(WebKit):

Source/WebKit/chromium:

* WebKit.gyp:
* public/platform/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::getPluginList):
* public/platform/WebLocalizedString.h:
* src/LocalizedStrings.cpp:
(WebCore::query):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Only display frames created with memory allocations meant to be displayed
danakj@chromium.org [Thu, 24 May 2012 16:25:12 +0000 (16:25 +0000)]
[chromium] Only display frames created with memory allocations meant to be displayed
https://bugs.webkit.org/show_bug.cgi?id=85108

Reviewed by Adrienne Walker.

Source/WebCore:

In this patch we remove the setVisible() code paths from CCProxy, and
instead commit visiblity state along with a frame. We also commit a
flag with a frame that indicates if the frame is one that can be drawn.

The impl host is set to visible during commit instead of using a
special channel through the proxy, and the scheduler allows
commits when we are waiting to draw our first frame but blocked on
being non-visible.

canDraw is gated on a new flag that indicates if the frame is one meant
for display. A frame is meant for display if the frame was generated
with a memory allocation meant for display. At this time, any non-zero
memory allocation is considered meant for display.

We prevent races by not changing the memory allocation at any time
except during a commit. So we force a commit when the memory
allocation needs to be adjusted and we are not visible. Similarly,
we force a commit when visibility changes so that we are able to
commit the visibility change to the impl tree.

In order to prevent drawing frames that are not meant for display
with a single thread, we prevent compositing when the impl tree
is not visible, with an early out in CCSingleThreadProxy.

Unit tests: CCLayerTreeHostTestVisibilityAndAllocationControlDrawing

* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setNeedsCommit):
(WebCore):
(WebCore::CCLayerTreeHost::setNeedsForcedCommit):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::setContentsMemoryAllocationLimitBytes):
(WebCore::CCLayerTreeHost::scheduleComposite):
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::sourceFrameCanBeDrawn):
(WebCore::CCLayerTreeHostImpl::setSourceFrameCanBeDrawn):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::drawSuspendedUntilCommit):
(WebCore::CCSchedulerStateMachine::scheduledToDraw):
(WebCore::CCSchedulerStateMachine::updateState):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore):
(WebCore::CCSingleThreadProxy::setNeedsForcedCommit):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::setNeedsForcedCommit):
(WebCore):
(WebCore::CCThreadProxy::setNeedsForcedCommitOnImplThread):
(WebCore::CCThreadProxy::forceBeginFrameOnImplThread):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::scheduledActionCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

Removing code to protect visible textures when a tab becomes invisible,
as we want to reduce our memory limit for invisible tabs and these
textures should not be saved.

* src/NonCompositedContentHost.cpp:
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::didCommit):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::scheduleComposite):
(WTF::CCLayerTreeHostTest::dispatchComposite):
(CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestTickAnimationWhileBackgrounded):
(WTF::CCLayerTreeHostTestTickAnimationWhileBackgrounded::willAnimateLayers):
(CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::beginTest):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommitAndDrawFrame):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::didCommit):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestVisibilityAndAllocationControlDrawing::afterTest):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [regression] search in formatted scripts is broken.
pfeldman@chromium.org [Thu, 24 May 2012 15:50:31 +0000 (15:50 +0000)]
Web Inspector: [regression] search in formatted scripts is broken.
https://bugs.webkit.org/show_bug.cgi?id=87377

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Using formatted content in search.

Test: inspector/debugger/script-formatter-search.html

* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype.searchInContent.callbackWrapper):
(WebInspector.JavaScriptSource.prototype.searchInContent):

LayoutTests:

* inspector/debugger/script-formatter-search-expected.txt: Added.
* inspector/debugger/script-formatter-search.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the Mac tests after r118353.
jberlin@webkit.org [Thu, 24 May 2012 15:48:03 +0000 (15:48 +0000)]
Fix the Mac tests after r118353.

* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt5][WK2] Gardening. Skip failing test after r118058.
ossy@webkit.org [Thu, 24 May 2012 15:45:38 +0000 (15:45 +0000)]
[Qt5][WK2] Gardening. Skip failing test after r118058.
https://bugs.webkit.org/show_bug.cgi?id=87395

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-24
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/Skipped: Skip fast/forms/ValidityState-valueMissing-002.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType...
pdr@google.com [Thu, 24 May 2012 15:31:07 +0000 (15:31 +0000)]
Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call
https://bugs.webkit.org/show_bug.cgi?id=87309

Reviewed by Nikolas Zimmermann.

This is a simple refactor that matches the work done in
https://bugs.webkit.org/show_bug.cgi?id=87309 to avoid an expensive call.

No new tests, no actual effects beyond performance improvement.

* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Gardening. Remove no more required expected file.
ossy@webkit.org [Thu, 24 May 2012 15:12:04 +0000 (15:12 +0000)]
[Qt] Gardening. Remove no more required expected file.

[WK2] Skip test that uses unimplemented feature.
https://bugs.webkit.org/show_bug.cgi?id=81042

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-24
Reviewed by Csaba Osztrogonác.

* platform/qt/svg/custom/global-constructors-expected.txt: Removed.
* platform/wk2/Skipped: editing/spelling/grammar-markers.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed trvial fixes.
ossy@webkit.org [Thu, 24 May 2012 15:10:35 +0000 (15:10 +0000)]
[Qt] Unreviewed trvial fixes.

* Target.pri: Typo fix after r118226.
* WebCore.pri: Warning fix after r117291.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove StyleRuleImport to a file of its own
antti@apple.com [Thu, 24 May 2012 15:07:29 +0000 (15:07 +0000)]
Move StyleRuleImport to a file of its own
https://bugs.webkit.org/show_bug.cgi?id=87386

Rubber-stamped by Andreas Kling.

Move StyleRuleImport out from CSSImportRule.cpp/.h

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSImportRule.cpp:
(WebCore):
(WebCore::CSSImportRule::href):
* css/CSSImportRule.h:
(WebCore):
(CSSImportRule):
* css/CSSParser.cpp:
* css/StyleRuleImport.cpp: Copied from Source/WebCore/css/CSSImportRule.cpp.
(WebCore):
* css/StyleRuleImport.h: Copied from Source/WebCore/css/CSSImportRule.h.
(WebCore):
* css/StyleSheetContents.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118352.
vsevik@chromium.org [Thu, 24 May 2012 14:59:47 +0000 (14:59 +0000)]
Unreviewed, rolling out r118352.
http://trac.webkit.org/changeset/118352
https://bugs.webkit.org/show_bug.cgi?id=87390

Caused 6 editing/spelling tests crash/fail on chromium in
debug. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-24

Source/WebCore:

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker):

Source/WebKit/chromium:

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::isGrammarCheckingEnabled):
* src/WebTextCheckingResult.cpp:
(WebKit::WebTextCheckingResult::operator TextCheckingResult):

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
* DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):

LayoutTests:

* editing/spelling/grammar-markers-expected.txt: Removed.
* editing/spelling/grammar-markers.html: Removed.
* platform/chromium-linux/editing/spelling/grammar-markers-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/editing/spelling/grammar-markers-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Support hierarchical context menus
apavlov@chromium.org [Thu, 24 May 2012 14:54:13 +0000 (14:54 +0000)]
Web Inspector: Support hierarchical context menus
https://bugs.webkit.org/show_bug.cgi?id=86847

Reviewed by Pavel Feldman.

This patch makes use of the WebMenuItemInfo SubMenu type to expose the capability of building submenu items
in the Web Inspector's context menu. ContextMenuItems are also passed/stored by reference/value rather than pointer
in order to be consistent with the PlatformMenuDescription typedef.

* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems): Enable submenu item population.
(WebCore):
(WebCore::JSInspectorFrontendHost::showContextMenu): Extract the menu population part into populateContextMenuItems().
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems): Enable submenu item population.
(WebCore):
(WebCore::V8InspectorFrontendHost::showContextMenuCallback): Extract the menu population part into populateContextMenuItems().
* inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::create): Use reference instead of pointer for ContextMenuItems.
(WebCore::FrontendMenuProvider::FrontendMenuProvider): Use reference instead of pointer for ContextMenuItems.
(WebCore::FrontendMenuProvider::populateContextMenu): Use reference instead of pointer for ContextMenuItems.
(WebCore::FrontendMenuProvider::contextMenuCleared):
(FrontendMenuProvider):
(WebCore::InspectorFrontendHost::showContextMenu): Use reference instead of pointer for ContextMenuItems.
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/front-end/ContextMenu.js: Support the tree-like structure of context menus.
(WebInspector.ContextMenuItem):
(WebInspector.ContextMenuItem.prototype.id):
(WebInspector.ContextMenuItem.prototype.type):
(WebInspector.ContextMenuItem.prototype._buildDescriptor):
(WebInspector.ContextSubMenuItem):
(WebInspector.ContextSubMenuItem.prototype.appendItem):
(WebInspector.ContextSubMenuItem.prototype.appendSubMenuItem):
(WebInspector.ContextSubMenuItem.prototype.appendCheckboxItem):
(WebInspector.ContextSubMenuItem.prototype.appendSeparator):
(WebInspector.ContextSubMenuItem.prototype._buildDescriptor):
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.prototype.nextId):
(WebInspector.ContextMenu.prototype.show):
(WebInspector.ContextMenu.prototype._setHandler):
(WebInspector.ContextMenu.prototype._buildDescriptor):
* inspector/front-end/SoftContextMenu.js:
(.WebInspector.SoftContextMenu): Support sub-menus.
(.WebInspector.SoftContextMenu.prototype.show):
(.WebInspector.SoftContextMenu.prototype._parentGlassPaneElement):
(.WebInspector.SoftContextMenu.prototype._createMenuItem):
(.WebInspector.SoftContextMenu.prototype._createSubMenu):
(.WebInspector.SoftContextMenu.prototype._createSeparator):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):
(.WebInspector.SoftContextMenu.prototype._focus):
(.WebInspector.SoftContextMenu.prototype._triggerAction):
(.WebInspector.SoftContextMenu.prototype._showSubMenu):
(.WebInspector.SoftContextMenu.prototype._buildMouseEventForSubMenu):
(.WebInspector.SoftContextMenu.prototype._hideSubMenu):
(.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):
(.WebInspector.SoftContextMenu.prototype._highlightMenuItem):
(.WebInspector.SoftContextMenu.prototype._menuKeyDown):
(.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):
(.WebInspector.SoftContextMenu.prototype._discardMenu):
(.WebInspector.SoftContextMenu.prototype._discardSubMenus):
* inspector/front-end/inspector.css: Support for sub-menus, separator improvement.
(.soft-context-menu-separator):
(.soft-context-menu-separator > .separator-line):
(.soft-context-menu-item-submenu-arrow):
* platform/chromium/ContextMenuChromium.cpp:
(WebCore::contextMenuItemVector): Implemented.
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd John Mellor as a contributor
peter@chromium.org [Thu, 24 May 2012 14:54:04 +0000 (14:54 +0000)]
Add John Mellor as a contributor
https://bugs.webkit.org/show_bug.cgi?id=87389

Reviewed by Kenneth Rohde Christiansen.

John will be working on Font Boosting and is very involved with various
web-facing subjects of Chrome for Android, such as viewport.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118256.
ossy@webkit.org [Thu, 24 May 2012 14:53:25 +0000 (14:53 +0000)]
Unreviewed, rolling out r118256.
http://trac.webkit.org/changeset/118256
https://bugs.webkit.org/show_bug.cgi?id=87388

It still fails on Qt5-WK2 (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-24

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Breakpoints Pane should not show context menu with no breakpoints
commit-queue@webkit.org [Thu, 24 May 2012 14:50:12 +0000 (14:50 +0000)]
Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
https://bugs.webkit.org/show_bug.cgi?id=87340

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-24
Reviewed by Pavel Feldman.

Removed the method _contextMenu as this would be redundant call
because _breakpointContextMenu would take care of showing the remove
all breakpoints option.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [DRT] Add baselines for execCommand tests which are missing expected results
commit-queue@webkit.org [Thu, 24 May 2012 14:43:31 +0000 (14:43 +0000)]
[EFL] [DRT] Add baselines for execCommand tests which are missing expected results
https://bugs.webkit.org/show_bug.cgi?id=84839

Unreviewed gardening, add EFL baselines for execCommand tests and move a
few tests which rely on copy & paste functionality to test_expectations.txt.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-24

* platform/efl/editing/execCommand/4580583-1-expected.png: Added.
* platform/efl/editing/execCommand/4580583-1-expected.txt: Added.
* platform/efl/editing/execCommand/4580583-2-expected.png: Added.
* platform/efl/editing/execCommand/4580583-2-expected.txt: Added.
* platform/efl/editing/execCommand/4641880-1-expected.png: Added.
* platform/efl/editing/execCommand/4641880-1-expected.txt: Added.
* platform/efl/editing/execCommand/4641880-2-expected.png: Added.
* platform/efl/editing/execCommand/4641880-2-expected.txt: Added.
* platform/efl/editing/execCommand/4747450-expected.png: Added.
* platform/efl/editing/execCommand/4747450-expected.txt: Added.
* platform/efl/editing/execCommand/4916402-expected.png: Added.
* platform/efl/editing/execCommand/4916402-expected.txt: Added.
* platform/efl/editing/execCommand/4916541-expected.png: Added.
* platform/efl/editing/execCommand/4916541-expected.txt: Added.
* platform/efl/editing/execCommand/4924441-expected.png: Added.
* platform/efl/editing/execCommand/4924441-expected.txt: Added.
* platform/efl/editing/execCommand/5080333-1-expected.png: Added.
* platform/efl/editing/execCommand/5080333-1-expected.txt: Added.
* platform/efl/editing/execCommand/5080333-2-expected.png: Added.
* platform/efl/editing/execCommand/5080333-2-expected.txt: Added.
* platform/efl/editing/execCommand/5136770-expected.png: Added.
* platform/efl/editing/execCommand/5136770-expected.txt: Added.
* platform/efl/editing/execCommand/5138441-expected.png: Added.
* platform/efl/editing/execCommand/5138441-expected.txt: Added.
* platform/efl/editing/execCommand/5142012-1-expected.png: Added.
* platform/efl/editing/execCommand/5142012-1-expected.txt: Added.
* platform/efl/editing/execCommand/5142012-2-expected.png: Added.
* platform/efl/editing/execCommand/5142012-2-expected.txt: Added.
* platform/efl/editing/execCommand/5190926-expected.png: Added.
* platform/efl/editing/execCommand/5190926-expected.txt: Added.
* platform/efl/editing/execCommand/5481523-expected.png: Added.
* platform/efl/editing/execCommand/5481523-expected.txt: Added.
* platform/efl/editing/execCommand/5482023-expected.png: Added.
* platform/efl/editing/execCommand/5482023-expected.txt: Added.
* platform/efl/editing/execCommand/5569741-expected.png: Added.
* platform/efl/editing/execCommand/5569741-expected.txt: Added.
* platform/efl/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/efl/editing/execCommand/create-list-with-hr-expected.txt: Added.
* platform/efl/editing/execCommand/findString-2-expected.png: Added.
* platform/efl/editing/execCommand/findString-2-expected.txt: Added.
* platform/efl/editing/execCommand/findString-expected.png: Added.
* platform/efl/editing/execCommand/findString-expected.txt: Added.
* platform/efl/editing/execCommand/format-block-with-trailing-br-expected.png: Added.
* platform/efl/editing/execCommand/indent-empty-root-expected.png: Added.
* platform/efl/editing/execCommand/indent-empty-root-expected.txt: Added.
* platform/efl/editing/execCommand/indent-list-item-expected.png: Added.
* platform/efl/editing/execCommand/indent-list-item-expected.txt: Added.
* platform/efl/editing/execCommand/indent-selection-expected.png: Added.
* platform/efl/editing/execCommand/indent-selection-expected.txt: Added.
* platform/efl/editing/execCommand/insert-list-and-stitch-expected.png: Added.
* platform/efl/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
* platform/efl/editing/execCommand/insertHorizontalRule-expected.png: Added.
* platform/efl/editing/execCommand/insertHorizontalRule-expected.txt: Added.
* platform/efl/editing/execCommand/insertImage-expected.png: Added.
* platform/efl/editing/execCommand/insertImage-expected.txt: Added.
* platform/efl/editing/execCommand/nsresponder-indent-expected.png: Added.
* platform/efl/editing/execCommand/nsresponder-indent-expected.txt: Added.
* platform/efl/editing/execCommand/nsresponder-outdent-expected.png: Added.
* platform/efl/editing/execCommand/nsresponder-outdent-expected.txt: Added.
* platform/efl/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
* platform/efl/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
* platform/efl/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
* platform/efl/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
* platform/efl/editing/execCommand/print-expected.png: Added.
* platform/efl/editing/execCommand/print-expected.txt: Added.
* platform/efl/editing/execCommand/remove-list-from-range-selection-expected.png: Added.
* platform/efl/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
* platform/efl/editing/execCommand/remove-list-item-1-expected.png: Added.
* platform/efl/editing/execCommand/remove-list-item-1-expected.txt: Added.
* platform/efl/editing/execCommand/selectAll-expected.png: Added.
* platform/efl/editing/execCommand/selectAll-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Remove unused API function touchEventCancelAndClearFocusedNode.
mifenton@rim.com [Thu, 24 May 2012 14:41:24 +0000 (14:41 +0000)]
[BlackBerry] Remove unused API function touchEventCancelAndClearFocusedNode.
https://bugs.webkit.org/show_bug.cgi?id=87379

Reviewed by Antonio Gomes.

Remove unused API, touchEventCancelAndClearFocusedNode.

Reviewed Internally by Gen Mak.

* Api/WebPage.cpp:
* Api/WebPage.h:
* WebKitSupport/TouchEventHandler.cpp:
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Chromium Mac build fix after r118357.
yurys@chromium.org [Thu, 24 May 2012 14:38:19 +0000 (14:38 +0000)]
Unreviewed. Chromium Mac build fix after r118357.
Use full name specifier instead of "using" directive.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::jsHeapInfo):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: introduce virtual resource for inspector stylesheet.
pfeldman@chromium.org [Thu, 24 May 2012 14:35:50 +0000 (14:35 +0000)]
Web Inspector: introduce virtual resource for inspector stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=87357

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change introduces virtual resource that represents inspector stylesheet (that is added for styles added via inspector).
New resource has url of form "inspector://<page url folder>/inspector-stylesheet. It enables live editing and revision
history of the inspector stylesheet.

Test: inspector/styles/edit-inspector-stylesheet.html

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asInspectorStyleSheet):
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
(WebCore::InspectorCSSAgent::detectOrigin):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
(WebCore::InspectorDOMAgent::pageAgent):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheet::buildObjectForStyleSheetInfo):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
* inspector/InspectorStyleSheet.h:
(WebCore):
(InspectorStyleSheet):
(WebCore::InspectorStyleSheet::canBind):
(InspectorStyleSheetForInlineStyle):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._undoRedoCompleted):
(WebInspector.CSSStyleModel.prototype.getViaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._inspectedURLChanged):
(WebInspector.CSSStyleModelResourceBinding.prototype._loadStyleSheetHeaders):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):
(WebInspector.CSSStyleModelResourceBinding.prototype._getViaInspectorResource.hadersLoaded):
(WebInspector.CSSStyleModelResourceBinding.prototype._getViaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResource.overrideRequestContent.callbackWrapper):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResource.overrideRequestContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._viaInspectorResourceURL):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.isHidden):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeFrame.prototype._navigate):
(WebInspector.ResourceTreeFrame.prototype.addResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.appendResource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/StylesPanel.js:
(WebInspector.InspectorStyleSource):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode.callback):
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

* inspector/styles/edit-inspector-stylesheet-expected.txt: Added.
* inspector/styles/edit-inspector-stylesheet.html: Added.
* inspector/styles/styles-add-new-rule-expected.txt:
* inspector/styles/styles-add-new-rule.html:
* inspector/styles/undo-add-new-rule-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] LayoutTestController's setCacheModel() implementation
commit-queue@webkit.org [Thu, 24 May 2012 14:21:07 +0000 (14:21 +0000)]
[EFL][DRT] LayoutTestController's setCacheModel() implementation
https://bugs.webkit.org/show_bug.cgi?id=86840

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-24
Reviewed by Csaba Osztrogonác.

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setDeadDecodedDataDeletionInterval): Aux wrapper function for DRT.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCacheModel): Implementation added.

LayoutTests:

* platform/efl/Skipped: Unskipped fast/dom/HTMLScriptElement/nested-execution.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Possible deadlock in the WebGL code path
commit-queue@webkit.org [Thu, 24 May 2012 14:20:05 +0000 (14:20 +0000)]
[BlackBerry] Possible deadlock in the WebGL code path
https://bugs.webkit.org/show_bug.cgi?id=87375

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-05-24
Reviewed by Rob Buis.

Fix a deadlock happening in the WebGL code path. The mutex is locked
but is not unlocked afterword. Also fix a possible double delete,
the mutex m_frontBufferLock will be destroyed in the base class.

Covered by tests in fast/canvas/webgl.

* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::releaseTextureResources):
* platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Forcibly sync running animations in the waiting state when synchronized...
commit-queue@webkit.org [Thu, 24 May 2012 14:13:48 +0000 (14:13 +0000)]
[chromium] Forcibly sync running animations in the waiting state when synchronized start times are needed.
https://bugs.webkit.org/show_bug.cgi?id=87153

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-24
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerAnimationControllerTest.ForceSyncWhenSynchronizedStartTimeNeeded

* platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
(WebCore::CCLayerAnimationController::replaceImplThreadAnimations):

Source/WebKit/chromium:

* tests/CCLayerAnimationControllerTest.cpp:
(WebKitTests::TEST):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed. Update platform specific expectation after r118353
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 13:56:07 +0000 (13:56 +0000)]
[Qt] Unreviewed. Update platform specific expectation after r118353

* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: convert HeapSnapshotGridNode._provider into getter.
loislo@chromium.org [Thu, 24 May 2012 13:39:04 +0000 (13:39 +0000)]
Web Inspector: convert HeapSnapshotGridNode._provider into getter.
https://bugs.webkit.org/show_bug.cgi?id=87382

I found that we create a provider for child nodes for the each DataGrid node in advance.
It cost us one async call to the HeapSnapshot's worker per each such the node.
I converted the property into the getter which is initializing the provider lazily.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.createProvider):
(WebInspector.HeapSnapshotGridNode.prototype._provider):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.serializeNextChunk):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.revealNodeBySnapshotObjectId):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Add platform specific expectation.
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 13:32:02 +0000 (13:32 +0000)]
[Qt] Unreviewed gardening. Add platform specific expectation.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-24

* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.txt: Added after r117672.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] r118325 made two inspector tests to fail
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 13:25:35 +0000 (13:25 +0000)]
[Qt] r118325 made two inspector tests to fail
https://bugs.webkit.org/show_bug.cgi?id=87385

Unreviewed gardening.

* platform/qt/Skipped: skip the failing tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFilter for RadioNodeList should be case sensitive.
commit-queue@webkit.org [Thu, 24 May 2012 13:19:06 +0000 (13:19 +0000)]
Filter for RadioNodeList should be case sensitive.
https://bugs.webkit.org/show_bug.cgi?id=87369

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-05-24
Reviewed by Kent Tamura.

Source/WebCore:

Element's id/name attribute matching criteria is case sensitive now.

Modified existing test.

* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::nodeMatches):
Element matching criteria is case sensitive.

LayoutTests:

* fast/forms/form-collection-radio-node-list.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add a command to InspectorMemoryAgent for getting process memory break...
yurys@chromium.org [Thu, 24 May 2012 13:01:53 +0000 (13:01 +0000)]
Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down
https://bugs.webkit.org/show_bug.cgi?id=87263

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced new protocol command Memory.getProcessMemoryDistribution which returns
memory distribution for the inspected process. Currently only JS allocated and used
heap size is included.

* inspector/Inspector.json:
* inspector/InspectorMemoryAgent.cpp:
(WebCore::jsHeapInfo):
(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

Added an API for retrieving render process private and shared memory in bytes.

* public/platform/WebKitPlatformSupport.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::getProcessMemorySize):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getProcessMemorySize):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonew test fast/js/dfg-arguments-mixed-alias.html fail on 32 bit linux
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 13:00:54 +0000 (13:00 +0000)]
new test fast/js/dfg-arguments-mixed-alias.html fail on 32 bit linux
https://bugs.webkit.org/show_bug.cgi?id=87378

Unreviewed gardening.

* platform/qt/Skipped: skip the failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReorder arguments to compare() in the QML WebView tests
ahf@0x90.dk [Thu, 24 May 2012 12:49:50 +0000 (12:49 +0000)]
Reorder arguments to compare() in the QML WebView tests
https://bugs.webkit.org/show_bug.cgi?id=87374

Reviewed by Simon Hausmann.

Based on patch by Kenneth Rohde Christiansen.

The reordering is necessary to get correct information printed when
the tests fails. Without this, the test suite will display the bogus
value and not the expected value.

This patch also removes the delayed windowShown since this is not
needed anymore, due to us using the touch events instead of mouse
events.

* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67093
commit-queue@webkit.org [Thu, 24 May 2012 12:49:02 +0000 (12:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67093
[Qt] Default window.alert shows HTML entities in certain cases

Instead of HTML escaping the text of JS alerts (which does not work
consistently because of Qt's automatisms), build message boxes
explicitly to be able set the text format to plain text.
QInputDialog is a bit hacky, because there is no way to access or
control the contained QLabel.

Patch by Steffen Imhof <steffen.imhof@basyskom.com> on 2012-05-24
Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVGZoomAndPan constants are missing from window object
zimmermann@webkit.org [Thu, 24 May 2012 12:21:50 +0000 (12:21 +0000)]
SVGZoomAndPan constants are missing from window object
https://bugs.webkit.org/show_bug.cgi?id=15494

Reviewed by Rob Buis.

Source/WebCore:

Generate the SVGZoomAndPanConstructor, so that the constants defined in the IDL
can be reached from the bindings. Provide a stub-implementation of ref/deref
that's never used, as we don't actually use JSSVGZoomAndPan which needs this, but
only the JSSVGZoomAndPanConstructor.

Add a new IDL flag "SuppressToJSObject" which disables generation of toJS/toV8
methods for classes that are only used in SVGs interfaces via multiple inheritance.
This affects: SVGFitToViewBox, SVGTests, SVGLangSapce, SVGExternalResourcesRequired, etc.

Unlike those classes SVGZoomAndPan defines constants, and thus needs a generated Constructor.
That requires us to build JSSVGZoomAndPan.* (JSSVGFitToViewBox/etc. is generated, but not built!).
Unfortunately this causes compilation problems on Windows, as it builds all sources in a single-file.
MSVC can't decide whether it should call toJS(Node*) or toJS(SVGZoomAndPan*) for a SVGSVGElement.
To avoid these problems stop generating toJS/toV8 completely for all SVG MI types. They were
never used before, so there's no point in actually generating them, as it's now causing problems.

This is a preparation towards bug 15495, which covers implementing
SVGSVGElement.currentView and the SVGViewSpec interface.

No new tests. The SVGZoomAndPan constructor is covered by existing tests, now that its enabled.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToJSDeclaration):
(ShouldGenerateToJSImplementation):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/IDLAttributes.txt:
* gyp/WebCore.gyp:
* page/DOMWindow.idl:
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::zoomAndPanEnabled):
* svg/SVGExternalResourcesRequired.idl:
* svg/SVGFitToViewBox.idl:
* svg/SVGLangSpace.idl:
* svg/SVGLocatable.idl:
* svg/SVGRenderingIntent.idl:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::viewBoxToViewTransform):
(WebCore::SVGSVGElement::setupInitialView):
(WebCore::SVGSVGElement::inheritViewAttributes):
* svg/SVGSVGElement.h:
(SVGSVGElement):
(WebCore::SVGSVGElement::useCurrentView):
(WebCore::SVGSVGElement::setUseCurrentView):
(WebCore::SVGSVGElement::zoomAndPan):
(WebCore::SVGSVGElement::setZoomAndPan):
* svg/SVGStylable.idl:
* svg/SVGTests.idl:
* svg/SVGURIReference.idl:
* svg/SVGUnitTypes.idl:
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::SVGViewElement):
(WebCore::SVGViewElement::parseAttribute):
* svg/SVGViewElement.h:
(SVGViewElement):
(WebCore::SVGViewElement::zoomAndPan):
(WebCore::SVGViewElement::setZoomAndPan):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::SVGViewSpec):
(WebCore::SVGViewSpec::setTransformString):
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGViewSpec.h:
(SVGViewSpec):
(WebCore::SVGViewSpec::transformBaseValue):
(WebCore::SVGViewSpec::zoomAndPan):
(WebCore::SVGViewSpec::setZoomAndPanBaseValue):
* svg/SVGZoomAndPan.cpp:
(WebCore::SVGZoomAndPan::isKnownAttribute):
(WebCore::SVGZoomAndPan::addSupportedAttributes):
(WebCore):
(WebCore::SVGZoomAndPan::parseZoomAndPan):
(WebCore::SVGZoomAndPan::ref):
(WebCore::SVGZoomAndPan::deref):
(WebCore::SVGZoomAndPan::setZoomAndPan):
* svg/SVGZoomAndPan.h:
(SVGZoomAndPan):
(WebCore::SVGZoomAndPan::parseFromNumber):
(WebCore::SVGZoomAndPan::parseAttribute):
(WebCore::SVGZoomAndPan::zoomAndPan):
* svg/SVGZoomAndPan.idl:

LayoutTests:

SVGZoomAndPan is now available as global constructor, rebaseline results.

* svg/custom/global-constructors-expected.txt:
* svg/custom/js-svg-constructors-expected.txt:
* svg/custom/js-svg-constructors.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable grammar checking on Chromium when we paste text.
hbono@chromium.org [Thu, 24 May 2012 12:04:03 +0000 (12:04 +0000)]
Enable grammar checking on Chromium when we paste text.
https://bugs.webkit.org/show_bug.cgi?id=74393

Reviewed by Hajime Morita.

This change enables grammar checking on Chromium and implements a mock grammar
checker to fix a failing test.

Source/WebCore:

Test: editing/spelling/grammar-markers.html

* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker): render grammar markers in gray on Windows and Linux or in green on Mac.

Source/WebKit/chromium:

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems): Show suggestions when we right-click grammatically-misspelled words.
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::isGrammarCheckingEnabled): Enable grammar checking when we enable asynchronous spellchecking.
* src/WebTextCheckingResult.cpp:
(WebKit::WebTextCheckingResult::operator TextCheckingResult): Fill GrammarDetails for grammatical errors.

Tools:

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
(MockGrammarCheck::checkGrammarOfString):
* DumpRenderTree/chromium/MockGrammarCheck.h: Added.
(WebKit):
(MockGrammarCheck):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.

LayoutTests:

* editing/spelling/grammar-markers-expected.txt: Added.
* editing/spelling/grammar-markers.html: Added.
* platform/chromium-linux/editing/spelling/grammar-markers-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/editing/spelling/grammar-markers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: add inspector instrumentation interface for compositing
caseq@chromium.org [Thu, 24 May 2012 11:44:58 +0000 (11:44 +0000)]
Web Inspector: add inspector instrumentation interface for compositing
https://bugs.webkit.org/show_bug.cgi?id=83842

Reviewed by Pavel Feldman.

Source/WebCore:

- added instrumentation methods to mark start/end of layer compositing;
- added associated timeline record type (CompositeLayers);
- plumbed the calls from instrumentation up to the timeline panel;
- actual call-sites are platform-specific and will come as separate patches.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCompositeImpl):
(WebCore):
(WebCore::InspectorInstrumentation::didCompositeImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willComposite):
(WebCore):
(WebCore::InspectorInstrumentation::didComposite):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore):
(WebCore::InspectorTimelineAgent::didComposite):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.recordStyle):

LayoutTests:

* inspector/timeline/timeline-enum-stability-expected.txt: added CompositeLayers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Web Inspector: remove obsolete isDetailedSnapshot method from HeapSnapshot...
loislo@chromium.org [Thu, 24 May 2012 11:33:08 +0000 (11:33 +0000)]
Unreviewed Web Inspector: remove obsolete isDetailedSnapshot method from HeapSnapshotView.

* inspector/front-end/HeapSnapshotView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: localStorage items are not updated when the storage changes
pfeldman@chromium.org [Thu, 24 May 2012 11:28:50 +0000 (11:28 +0000)]
Web Inspector: localStorage items are not updated when the storage changes
https://bugs.webkit.org/show_bug.cgi?id=83012

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-05-24
Reviewed by Pavel Feldman.

Source/WebCore:

Renamed the inspector protocol UpdateDOMStorage to domStorageUpdated.
Instrumented StorageEventDispatcher to send the update event to the
front-end. Also removed the way DOM Storage Agent used to listen for
the storage events. Added new test to verify the update notifications.

Test: inspector/storage-panel-dom-storage-update.html

* dom/EventListener.h:
* inspector/Inspector.json:
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
* inspector/InspectorDOMStorageAgent.h:
(InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::isSameHostAndType):
(WebCore::InspectorDOMStorageResource::unbind):
* inspector/InspectorDOMStorageResource.h:
(WebCore):
(InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::id):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEventImpl):
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore):
(WebCore::InspectorInstrumentation::didDispatchDOMStorageEvent):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher.prototype.domStorageUpdated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.domStorageUpdated):
* storage/StorageEventDispatcher.cpp:
(WebCore::StorageEventDispatcher::dispatch):

Source/WebKit/chromium:

Instrumented the DOM Storage Events in order to update the frontend.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::dispatchLocalStorageEvent):
(WebCore::StorageAreaProxy::dispatchSessionStorageEvent):

LayoutTests:

Test to verify the storage list is updated in the inspector frontend
whenever there is any modifications to dom storage.

* inspector/storage-panel-dom-storage-update-expected.txt: Added.
* inspector/storage-panel-dom-storage-update.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: introduce console proxy object for HeapSnapshot worker.
loislo@chromium.org [Thu, 24 May 2012 11:27:01 +0000 (11:27 +0000)]
Web Inspector: introduce console proxy object for HeapSnapshot worker.
https://bugs.webkit.org/show_bug.cgi?id=87346

There is no console object in html5 workers at the moment.
This makes me sad when I'm troubleshooting the HeapSnapshot stuff.
I wrote a simplest proxy object which sends the log, info and error messages
to the WebInspector window.

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotRealWorker.prototype._messageReceived):
* inspector/front-end/HeapSnapshotWorker.js:
(WebInspector.WorkerConsole):
(WebInspector.WorkerConsole.prototype.log):
(WebInspector.WorkerConsole.prototype.error):
(WebInspector.WorkerConsole.prototype.info):
(WebInspector.WorkerConsole.prototype._postMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r118291) fast/frames/flattening/iframe-tiny.html fails
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 11:17:28 +0000 (11:17 +0000)]
[Qt] REGRESSION(r118291) fast/frames/flattening/iframe-tiny.html fails
https://bugs.webkit.org/show_bug.cgi?id=87363

Unreviewed gardening.

* platform/qt/Skipped: skip the failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] new test fast/block/positioning/fixed-position-stacking-context.html is failing
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 11:03:52 +0000 (11:03 +0000)]
[Qt] new test fast/block/positioning/fixed-position-stacking-context.html is failing
https://bugs.webkit.org/show_bug.cgi?id=87367

Unreviewed gardening.

* platform/qt/Skipped: skip the failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip tests because ENABLE(SHADOW_DOM) is disabled.
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 10:52:57 +0000 (10:52 +0000)]
[Qt] Unreviewed gardening. Skip tests because ENABLE(SHADOW_DOM) is disabled.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-24

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocti_vm_throw gets kicked out by gcc 4.6 -flto
commit-queue@webkit.org [Thu, 24 May 2012 10:50:40 +0000 (10:50 +0000)]
cti_vm_throw gets kicked out by gcc 4.6 -flto
https://bugs.webkit.org/show_bug.cgi?id=56088

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-24
Reviewed by Darin Adler.

Source/JavaScriptCore:

Add REFERENCED_FROM_ASM to functions only referenced from assembler.

* dfg/DFGOperations.cpp:
* jit/HostCallReturnValue.h:
* jit/JITStubs.h:
* jit/ThunkGenerators.cpp:

Source/WTF:

Define REFERENCED_FROM_ASM to __attribute__((used)) on GCC.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Several canvas/philip test cases can be unskipped
commit-queue@webkit.org [Thu, 24 May 2012 10:30:27 +0000 (10:30 +0000)]
[EFL] Several canvas/philip test cases can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=87362

Unreviewed EFL gardening. Unskip several canvas/philip that are now
passing.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-24

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Tiles not painted after wheel or keyboard scroll.
commit-queue@webkit.org [Thu, 24 May 2012 10:18:34 +0000 (10:18 +0000)]
[Qt] Tiles not painted after wheel or keyboard scroll.
https://bugs.webkit.org/show_bug.cgi?id=87358

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-24
Reviewed by Kenneth Rohde Christiansen.

After performing a scroll requested from the WebProcess we also need
to inform the painting layer of the viewport change.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::pagePositionRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix bounce-back animation on pinch->pan
abecsi@webkit.org [Thu, 24 May 2012 10:15:36 +0000 (10:15 +0000)]
[Qt][WK2] Fix bounce-back animation on pinch->pan
https://bugs.webkit.org/show_bug.cgi?id=87266

Reviewed by Kenneth Rohde Christiansen.

If ending an out-of-bounds pinch gesture with releasing one finger
(transition to a pan gesture) the bounce back animation blinks in
the end position immediately first, then animates the content back
into bounds.

QtViewportInteractionEngine::cancelScrollAnimation should return
early if there is no active kinetic animation.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, updating chromium test expectations.
vsevik@chromium.org [Thu, 24 May 2012 10:01:13 +0000 (10:01 +0000)]
Unreviewed, updating chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] compositing/repaint/opacity-between-absolute.html does not pass
commit-queue@webkit.org [Thu, 24 May 2012 09:21:21 +0000 (09:21 +0000)]
[EFL][DRT] compositing/repaint/opacity-between-absolute.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=87353

Unreviewed. Gardening of compositing/repaint/opacity-between-absolute.html test.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-24

* platform/efl/compositing/repaint/opacity-between-absolute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElements in Shadow DOM are not resizable.
shinyak@chromium.org [Thu, 24 May 2012 09:17:05 +0000 (09:17 +0000)]
Elements in Shadow DOM are not resizable.
https://bugs.webkit.org/show_bug.cgi?id=87342

Reviewed by Ryosuke Niwa.

Source/WebCore:

In RenderLayer::resize(), shadowAncestorNode() was used but if the ancestor node is used,
it is not possible to resize elements in Shadow DOM.

The comments said it is necessary for textarea, however actually it is not necessary now.
Existing test (fast/css/resize-corner-tracking) covers it.

Test: fast/dom/shadow/resize-in-shadow-dom.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):

LayoutTests:

* fast/dom/shadow/resize-in-shadow-dom-expected.txt: Added.
* fast/dom/shadow/resize-in-shadow-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skipping failing tests on chromium.
vsevik@chromium.org [Thu, 24 May 2012 09:13:20 +0000 (09:13 +0000)]
Unreviewed, skipping failing tests on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove StyleSheetContents to a separate file
antti@apple.com [Thu, 24 May 2012 08:54:22 +0000 (08:54 +0000)]
Move StyleSheetContents to a separate file
https://bugs.webkit.org/show_bug.cgi?id=87354

Reviewed by Eric Seidel.

Move StyleSheetContents class to StyleSheetContents.h/cpp.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSFontFaceSrcValue.cpp:
* css/CSSGrammar.y:
* css/CSSImportRule.cpp:
* css/CSSParser.cpp:
* css/CSSPrimitiveValue.cpp:
* css/CSSRule.cpp:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::href):
(WebCore):
(WebCore::CSSStyleSheet::baseURL):
(WebCore::CSSStyleSheet::isLoading):
* css/CSSStyleSheet.h:
(WebCore):
(CSSStyleSheet):
* css/StylePropertySet.cpp:
* css/StyleResolver.cpp:
* css/StyleSheetContents.cpp: Copied from css/CSSStyleSheet.cpp.
(WebCore):
* css/StyleSheetContents.h: Copied from css/CSSStyleSheet.h.
(WebCore):
* dom/DOMImplementation.cpp:
(WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
* dom/Document.cpp:
* dom/ProcessingInstruction.cpp:
* dom/StyleElement.cpp:
* html/HTMLLinkElement.cpp:
* html/HTMLStyleElement.cpp:
* inspector/InspectorStyleSheet.cpp:
* loader/cache/CachedCSSStyleSheet.cpp:
* page/PageSerializer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Buildfix for the minimal build because the r118197 broke it.
kkristof@inf.u-szeged.hu [Thu, 24 May 2012 08:14:26 +0000 (08:14 +0000)]
[Qt] Buildfix for the minimal build because the r118197 broke it.
https://bugs.webkit.org/show_bug.cgi?id=87096

Reviewed by Csaba Osztrogonác.

* plugins/PluginData.cpp:
(WebCore):
(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSee https://bugs.webkit.org/show_bug.cgi?id=87347
slewis@apple.com [Thu, 24 May 2012 07:44:46 +0000 (07:44 +0000)]
See https://bugs.webkit.org/show_bug.cgi?id=87347

Unreviewed, skipping newly flaky test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect merge of r117542 from dfg opt branch in r118323 is leading to fast/js/dfg...
fpizlo@apple.com [Thu, 24 May 2012 07:35:05 +0000 (07:35 +0000)]
Incorrect merge of r117542 from dfg opt branch in r118323 is leading to fast/js/dfg-arguments-osr-exit.html failing
https://bugs.webkit.org/show_bug.cgi?id=87350

Reviewed by Maciej Stachowiak.

The dfgopt branch introduced the notion of a local variable being killed because it was aliased
to the Arguments object as in cases like:

var a = arguments;
return a.length;

This required changes to OSR exit handling - if the variable is dead but aliased to arguments, then
OSR exit should reify the arguments. But meanwhile, in tip of tree we introduced special handling for
dead variables on OSR exit. When the two were merged in r118323, the structure of the if/else branches
ended up being such that we would treat dead arguments variables as totally dead as opposed to treating
them as variables that need arguments reification.

This fixes the structure of the relevant if/else block so that variables that are dead-but-arguments
end up being treated as reified arguments objects, while variables that are dead but not aliased to
arguments are treated as tip of tree would have treated them (initialize to Undefined).

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
ossy@webkit.org [Thu, 24 May 2012 07:29:21 +0000 (07:29 +0000)]
[Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.

* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
commit-queue@webkit.org [Thu, 24 May 2012 07:20:57 +0000 (07:20 +0000)]
[EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
https://bugs.webkit.org/show_bug.cgi?id=86867

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-24
Reviewed by Adam Barth.

Source/WebKit/efl:

ewk_intent_request_failure_post() should call
WebCore::IntentRequest::postFailure(), not
WebCore::IntentRequest::postResult().

* ewk/ewk_intent_request.cpp:
(ewk_intent_request_failure_post):

Tools:

Add implementation for sendWebIntentResponse() in EFL's
LayoutTestController and add empty implementation for other ports.

* DumpRenderTree/LayoutTestController.cpp:
(sendWebIntentResponseCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::currentIntentRequest):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onFrameIntentNew):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::sendWebIntentResponse):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::sendWebIntentResponse):

LayoutTests:

Remove from test expectations the webintents tests that require
support for sendWebIntentResponse() in EFL's LayoutTestController.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed 32 bit buildfix after r118325.
ossy@webkit.org [Thu, 24 May 2012 07:05:31 +0000 (07:05 +0000)]
Unreviewed 32 bit buildfix after r118325.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal): Use ASSERT_UNUSED instead ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] The EFL port has no support for title directionality
commit-queue@webkit.org [Thu, 24 May 2012 07:03:15 +0000 (07:03 +0000)]
[EFL] The EFL port has no support for title directionality
https://bugs.webkit.org/show_bug.cgi?id=86462

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-24
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Define a new Ewk_Text_With_Direction type to store the direction of
the text along with the text itself. This is needed to support text
directionality in EFL port.

Use the new Ewk_Text_With_Direction type for the frame title. Updated
"title,changed" signal, title getter/setter and Ewk_Hit_Test struct.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveTitle):
* ewk/ewk_frame.cpp:
(Ewk_Frame_Smart_Data):
(_ewk_frame_smart_del):
(ewk_frame_title_get):
(ewk_frame_hit_test_free):
(ewk_frame_hit_test_new):
(ewk_frame_title_set):
* ewk/ewk_frame.h:
* ewk/ewk_frame_private.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_title_get):
(ewk_view_title_set):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:

Tools:

Update "title,changed" signal handlers in DRT and EWebLauncher to
reflect the change from const char* to Ewk_Text_With_Direction* type
for the title.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onTitleChanged):
* EWebLauncher/main.c:
(title_set):
(on_title_changed):
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG operationTearOffActivation should return after handling the null activation case
fpizlo@apple.com [Thu, 24 May 2012 07:00:24 +0000 (07:00 +0000)]
DFG operationTearOffActivation should return after handling the null activation case
https://bugs.webkit.org/show_bug.cgi?id=87348
<rdar://problem/11522295>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGOperations.cpp:

LayoutTests:

* fast/js/dfg-tear-off-arguments-not-activation-expected.txt: Added.
* fast/js/dfg-tear-off-arguments-not-activation.html: Added.
* fast/js/script-tests/dfg-tear-off-arguments-not-activation.js: Added.
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, merge the arguments fix in r118138 to get bots green.
fpizlo@apple.com [Thu, 24 May 2012 06:58:52 +0000 (06:58 +0000)]
Unreviewed, merge the arguments fix in r118138 to get bots green.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Web Inspector single line fix for r118162.
loislo@chromium.org [Thu, 24 May 2012 06:55:28 +0000 (06:55 +0000)]
Unreviewed: Web Inspector single line fix for r118162.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CFA should record if a node can OSR exit
fpizlo@apple.com [Thu, 24 May 2012 06:24:36 +0000 (06:24 +0000)]
DFG CFA should record if a node can OSR exit
https://bugs.webkit.org/show_bug.cgi?id=86905

Reviewed by Oliver Hunt.

Merged r117931 from dfgopt.

Adds a NodeFlag that denotes nodes that are known to not have OSR exits.
This ought to aid any backwards analyses that need to know when a
backward flow merge might happen due to a side exit.

Also added assertions into speculationCheck() that ensure that we did not
mark a node as non-exiting and then promptly compile in an exit. This
helped catch some minor bugs where we were doing unnecessary speculation
checks.

This is a perf-neutral change. The speculation checks that this removes
were not on hot paths of major benchmarks.

* bytecode/PredictedType.h:
(JSC):
(JSC::isAnyPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::speculateInt32Unary):
(AbstractState):
(JSC::DFG::AbstractState::speculateNumberUnary):
(JSC::DFG::AbstractState::speculateBooleanUnary):
(JSC::DFG::AbstractState::speculateInt32Binary):
(JSC::DFG::AbstractState::speculateNumberBinary):
* dfg/DFGNode.h:
(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(Node):
(JSC::DFG::Node::setCanExit):
(JSC::DFG::Node::canExit):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::nodeFlagsAsString):
* dfg/DFGNodeFlags.h:
(DFG):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not do unnecessary indirections when storing to objects
fpizlo@apple.com [Thu, 24 May 2012 05:51:05 +0000 (05:51 +0000)]
DFG should not do unnecessary indirections when storing to objects
https://bugs.webkit.org/show_bug.cgi?id=86959

Reviewed by Oliver Hunt.

Merged r117819 from dfgopt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should optimize aliased uses of the Arguments object of the current call frame
fpizlo@apple.com [Thu, 24 May 2012 05:33:09 +0000 (05:33 +0000)]
DFG should optimize aliased uses of the Arguments object of the current call frame
https://bugs.webkit.org/show_bug.cgi?id=86552

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Merged r117542 and r117543 from dfgopt.

Performs must-alias and escape analysis on uses of CreateArguments, and if
a variable is must-aliased to CreateArguments and does not escape, then we
turn all uses of that variable into direct arguments accesses.

36% speed-up on V8/earley leading to a 2.3% speed-up overall in V8.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::uncheckedArgumentsRegister):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::argumentsThatWereNotCreated):
(ValueRecovery):
(JSC::ValueRecovery::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAdjacencyList.h:
(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdgeFromBag):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
(ArgumentsSimplificationPhase):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::observeBadArgumentsUses):
(JSC::DFG::ArgumentsSimplificationPhase::observeProperArgumentsUse):
(JSC::DFG::ArgumentsSimplificationPhase::isOKToOptimize):
(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::argumentsRegisterFor):
(AssemblyHelpers):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
* dfg/DFGGPRInfo.h:
(GPRInfo):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::collectGarbage):
(DFG):
* dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::executableFor):
(JSC::DFG::Graph::argumentsRegisterFor):
(JSC::DFG::Graph::uncheckedArgumentsRegisterFor):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler.h:
(JSC::DFG::OSRExitCompiler::OSRExitCompiler):
(OSRExitCompiler):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsArgumentsAlias):
(VariableAccessData):
(JSC::DFG::VariableAccessData::isArgumentsAlias):
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_argument_by_val):

LayoutTests:

Rubber stamped by Geoff Garen.

Merged r117542 from dfgopt.

Added a bunch of tests that check that our optimizations for aliased uses of the
'arguments' object are robust against various forms of JavaScript crazy.

* fast/js/dfg-arguments-alias-escape-expected.txt: Added.
* fast/js/dfg-arguments-alias-escape.html: Added.
* fast/js/dfg-arguments-alias-expected.txt: Added.
* fast/js/dfg-arguments-alias.html: Added.
* fast/js/dfg-arguments-cross-code-origin-expected.txt: Added.
* fast/js/dfg-arguments-cross-code-origin.html: Added.
* fast/js/dfg-arguments-mixed-alias-expected.txt: Added.
* fast/js/dfg-arguments-mixed-alias.html: Added.
* fast/js/dfg-arguments-osr-exit-expected.txt: Added.
* fast/js/dfg-arguments-osr-exit.html: Added.
* fast/js/dfg-arguments-unexpected-escape-expected.txt: Added.
* fast/js/dfg-arguments-unexpected-escape.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-arguments-alias-escape.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-arguments-alias.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-arguments-cross-code-origin.js: Added.
(foo):
(bar):
(baz):
* fast/js/script-tests/dfg-arguments-mixed-alias.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-arguments-osr-exit.js: Added.
(baz):
(foo):
(bar):
* fast/js/script-tests/dfg-arguments-unexpected-escape.js: Added.
(baz):
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosort the array 'non_wrapper_types'
commit-queue@webkit.org [Thu, 24 May 2012 05:24:47 +0000 (05:24 +0000)]
sort the array 'non_wrapper_types'
https://bugs.webkit.org/show_bug.cgi?id=87335

Patch by Lu Guanqun <guanqun.lu@intel.com> on 2012-05-23
Reviewed by Kentaro Hara.

* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange EFL debug build name with more detail one
gyuyoung.kim@samsung.com [Thu, 24 May 2012 04:39:04 +0000 (04:39 +0000)]
Change EFL debug build name with more detail one
https://bugs.webkit.org/show_bug.cgi?id=87254

Reviewed by Ryosuke Niwa.

EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
In addition, remove efl-linux-debug triggerable since nobody uses it.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a test case of event dispatching which uses inactive insertion points.
hayato@chromium.org [Thu, 24 May 2012 04:23:25 +0000 (04:23 +0000)]
Add a test case of event dispatching which uses inactive insertion points.
https://bugs.webkit.org/show_bug.cgi?id=87229

Reviewed by Darin Adler.

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument.elementFromPoint exposes inner element of Shadow DOM.
shinyak@chromium.org [Thu, 24 May 2012 03:59:41 +0000 (03:59 +0000)]
Document.elementFromPoint exposes inner element of Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87235

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::elementFromPoint didn't consider nested Shadow DOM.
The container node should be adjusted up to document TreeScope beyond ShadowRoot TreeScope.

Test: fast/dom/shadow/element-from-point-in-nested-shadow.html

* dom/Document.cpp:
(WebCore::Document::elementFromPoint):

LayoutTests:

* fast/dom/shadow/element-from-point-in-nested-shadow-expected.txt: Added.
* fast/dom/shadow/element-from-point-in-nested-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r118297.
commit-queue@webkit.org [Thu, 24 May 2012 03:48:39 +0000 (03:48 +0000)]
Unreviewed, rolling out r118297.
http://trac.webkit.org/changeset/118297
https://bugs.webkit.org/show_bug.cgi?id=87338

It caused several layout failures on Mac (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-23

Source/WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

* fast/block/float/floats-with-margin-should-not-wrap-expected.html: Removed.
* fast/block/float/floats-with-margin-should-not-wrap.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDocument.caretRangeFromPoint exposes inner elemnet of Shadow DOM.
shinyak@chromium.org [Thu, 24 May 2012 03:45:18 +0000 (03:45 +0000)]
Document.caretRangeFromPoint exposes inner elemnet of Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87231

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::caretRangeFromPoint didn't consider nested Shadow DOM.
The container node should be adjusted up to document TreeScope beyond ShadowRoot TreeScope.

Test: fast/dom/shadow/caret-range-from-point-in-nested-shadow.html

* dom/Document.cpp:
(WebCore::Document::caretRangeFromPoint):

LayoutTests:

* fast/dom/shadow/caret-range-from-point-in-nested-shadow-expected.txt: Added.
* fast/dom/shadow/caret-range-from-point-in-nested-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in RenderTableCol::nextColumn
jchaffraix@webkit.org [Thu, 24 May 2012 03:42:27 +0000 (03:42 +0000)]
Crash in RenderTableCol::nextColumn
https://bugs.webkit.org/show_bug.cgi?id=87314

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/table/canvas-column-in-column-group.html
       fast/table/columngroup-inside-columngroup.html

The issue comes from elements not abiding by the display property (e.g. canvas). This means
that any renderer with display: table-column would pass the current isChildAllowed check and
would confuse our algorithm to iterate.

We were getting away with allowing those children as table columns or column groups don't
paint themselves but it's better to just not allow such children in the first place.

* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::isChildAllowed):
Fixed the logic to only accept proper column renderer (RenderTableCol with display: column
to ignore column-groups). Also removed an unneeded NULL-check.

LayoutTests:

* fast/table/canvas-column-in-column-group-expected.txt: Added.
* fast/table/canvas-column-in-column-group.html: Added.
* fast/table/columngroup-inside-columngroup-expected.txt: Added.
* fast/table/columngroup-inside-columngroup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening after r118203 and r118171.
rakuco@webkit.org [Thu, 24 May 2012 03:11:50 +0000 (03:11 +0000)]
[EFL] Gardening after r118203 and r118171.

Remove wrong expectations added in r118171 and unskip passing
tests after r118203.

* platform/efl/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
* platform/efl/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: compositing/video/video-poster.html fails on Mac
jer.noble@apple.com [Thu, 24 May 2012 02:44:14 +0000 (02:44 +0000)]
REGRESSION: compositing/video/video-poster.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=87199

Reviewed by Maciej Stachowiak.

No new tests; fixes failing compositing/video/video-poster.html test.

Instead of creating the video layer directly, simply allow the layer
to be created in updateStates() by changing the definition of
isReadyForVideoSetup() to bypass the m_isAllowedToRender check if
the player reports a video track is present.  This causes the video layer
to be created and for future calls to prepareForRendering() to result
in calls to mediaPlayerRenderingModeChanged().

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::isReadyForVideoSetup):
(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Unreviewed, add ENABLE_CSS3_FLEXBOX after r118304.
rakuco@webkit.org [Thu, 24 May 2012 02:43:51 +0000 (02:43 +0000)]
[CMake] Unreviewed, add ENABLE_CSS3_FLEXBOX after r118304.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium/mac] Unbreak popup menus.
thakis@chromium.org [Thu, 24 May 2012 02:41:16 +0000 (02:41 +0000)]
[chromium/mac] Unbreak popup menus.
https://bugs.webkit.org/show_bug.cgi?id=87325

Reviewed by David Levin.

http://svn.webkit.org/repository/webkit/trunk@117607 added this function, but the
Chromium/Mac build doesn't use the file added in that change and hence didn't have
the category method.. Adding it doesn't help, as the category calls a
10.7-only function. Just don't use the category for chromium/mac. Fixes
http://crbug.com/129418

* platform/mac/WebCoreNSCellExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][DRT] Fix WebCore library path and rebaseline result
commit-queue@webkit.org [Thu, 24 May 2012 02:38:50 +0000 (02:38 +0000)]
[EFL][DRT] Fix WebCore library path and rebaseline result
https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-23
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
Therefore, this patch adjusted the path correctly.

Tools:

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

LayoutTests:

* platform/efl/test_expectations.txt: Added some cases to skipped list since we don't support those at this stage

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFGCapabilities should not try to get an arguments register from code blocks that...
fpizlo@apple.com [Thu, 24 May 2012 02:34:09 +0000 (02:34 +0000)]
DFGCapabilities should not try to get an arguments register from code blocks that don't have one
https://bugs.webkit.org/show_bug.cgi?id=87332

Reviewed by Andy Estes.

* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineOpcode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should have sparse conditional constant propagation
fpizlo@apple.com [Thu, 24 May 2012 02:28:52 +0000 (02:28 +0000)]
DFG should have sparse conditional constant propagation
https://bugs.webkit.org/show_bug.cgi?id=86580

Reviewed by Oliver Hunt.

Merged r117370 from dfgopt.

This enhances CFA so that if it suspects at any point during the fixpoint that a
branch will only go one way, then it only propagates in that one way.

This vastly increases the opportunities for CFG simplification. For example, it
enables us to evaporate this loop:

for (var i = 0; i < 1; ++i) doThings(i);

As a result, it uncovered loads of bugs in the CFG simplifier. In particular:

- Phi fixup was assuming that all Phis worth fixing up are shouldGenerate().
  That's not true; we also fixup Phis that are dead.

- GetLocal fixup was assuming that it's only necessary to rewire links to a
  GetLocal, and that the GetLocal's own links don't need to be rewired. Untrue,
  because the GetLocal may not be rewirable (first block has no GetLocal for r42
  but second block does have a GetLocal), in which case it will refer to a Phi
  in the second block. We need it to refer to a Phi from the first block to
  ensure that subsequent transformations work.

- Tail operand fixup was ignoring the fact that Phis in successors may contain
  references to the children of our tail variables. Hence, successor Phi child
  substitution needs to use the original second block variable table as its
  prior, rather than trying to reconstruct the prior later (since by that point
  the children of the second block's tail variables will have been fixed up, so
  we will not know what the prior would have been).

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeToSuccessors):
* dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::branchDirectionToString):
(AbstractState):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::OperandSubstitution::OperandSubstitution):
(OperandSubstitution):
(JSC::DFG::CFGSimplificationPhase::skipGetLocal):
(JSC::DFG::CFGSimplificationPhase::recordPossibleIncomingReference):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixTailOperand):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::changeEdge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSee https://bugs.webkit.org/show_bug.cgi?id=87208
slewis@apple.com [Thu, 24 May 2012 02:08:49 +0000 (02:08 +0000)]
See https://bugs.webkit.org/show_bug.cgi?id=87208

Unreviewed, skipping new test that can have side effects.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd back the ability to disable flexbox
ojan@chromium.org [Thu, 24 May 2012 02:03:04 +0000 (02:03 +0000)]
add back the ability to disable flexbox
https://bugs.webkit.org/show_bug.cgi?id=87147

Reviewed by Tony Chang.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] mousewheel event isn't fired on nodes in Shadow DOM.
shinyak@chromium.org [Thu, 24 May 2012 01:57:45 +0000 (01:57 +0000)]
[Shadow] mousewheel event isn't fired on nodes in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87218

Reviewed by Dimitri Glazkov.

Source/WebCore:

EventHander::handleWheelEvent re-targets an event to a shadow ancestor node,
however it should be done by adjusting event target. So we don't need to have it.

Tests: fast/dom/shadow/wheel-event-in-shadow-dom.html
       fast/dom/shadow/wheel-event-on-input-in-shadow-dom.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

* fast/dom/shadow/wheel-event-in-shadow-dom-expected.txt: Added.
* fast/dom/shadow/wheel-event-in-shadow-dom.html: Added.
* fast/dom/shadow/wheel-event-on-input-in-shadow-dom-expected.txt: Added.
* fast/dom/shadow/wheel-event-on-input-in-shadow-dom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove an unused setter in CachedResource.h.
commit-queue@webkit.org [Thu, 24 May 2012 01:53:58 +0000 (01:53 +0000)]
Remove an unused setter in CachedResource.h.
https://bugs.webkit.org/show_bug.cgi?id=87324

CachedResource::setInLiveDecodedResourcesList was defined in r24925, but it has
been unused.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-05-23
Reviewed by Darin Adler.

* loader/cache/CachedResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdjust a target node of a mouse event correctly when a distributed text node is clicked.
hayato@chromium.org [Thu, 24 May 2012 01:47:38 +0000 (01:47 +0000)]
Adjust a target node of a mouse event correctly when a distributed text node is clicked.
https://bugs.webkit.org/show_bug.cgi?id=86999

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make EventHandler::updateMouseEventTargetNode() be aware of shadow dom subtree
so that an insertion point can receive an event when a distributed text node is clicked.

Tests: fast/dom/shadow/shadow-dom-event-dispatching.html

* page/EventHandler.cpp:
(WebCore::EventHandler::updateMouseEventTargetNode):

LayoutTests:

* fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
* fast/dom/shadow/shadow-dom-event-dispatching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Shadow] drop event is not fired on nodes in Shadow DOM
shinyak@chromium.org [Thu, 24 May 2012 01:40:28 +0000 (01:40 +0000)]
[Shadow] drop event is not fired on nodes in Shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=85774

Reviewed by Dimitri Glazkov.

Source/WebCore:

EventHander::updateDragAndDrop re-targets an event to a shadow ancestor node,
however it should be done by adjusting event target. So we don't need to have it.

Tests: fast/dom/shadow/drop-event-for-input-in-shadow.html
       fast/dom/shadow/drop-event-in-shadow.html

* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

Confirms drop event is fired on div and input in Shadow DOM.

* fast/dom/shadow/drop-event-for-input-in-shadow-expected.txt: Added.
* fast/dom/shadow/drop-event-for-input-in-shadow.html: Added.
* fast/dom/shadow/drop-event-in-shadow-expected.txt: Added.
* fast/dom/shadow/drop-event-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (115573): Incorrect rounding of margins for floats
eae@chromium.org [Thu, 24 May 2012 01:31:06 +0000 (01:31 +0000)]
REGRESSION (115573): Incorrect rounding of margins for floats
https://bugs.webkit.org/show_bug.cgi?id=87319

Reviewed by Eric Seidel.

Source/WebCore:

In RenderBlock::computeInlinePreferredLogicalWidths we used a float to
accumulate margins for floating children while the children themselves
represent their margins as LayoutUnits. Due to lack of rounding this can
cause the block to be too small at certain certain zoom levels, causing
unwanted wrapping.

This patch changes computeInlinePreferredLogicalWidths to use a
LayoutUnit to accumulate the margins and thus ensures that the margin
values are rounded the same way.

Test: fast/block/float/floats-with-margin-should-not-wrap.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

LayoutTests:

Add new test ensuring that using margins with floats doesn't cause
undesired wrapping.

* fast/block/float/floats-with-margin-should-not-wrap-expected.html: Added.
* fast/block/float/floats-with-margin-should-not-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused declarations in MemoryCache.h
commit-queue@webkit.org [Thu, 24 May 2012 01:09:13 +0000 (01:09 +0000)]
Remove unused declarations in MemoryCache.h
https://bugs.webkit.org/show_bug.cgi?id=87323

It is originated from r75912.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-05-23
Reviewed by Darin Adler.

* loader/cache/MemoryCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd seamless layout code (and pass most of the remaining seamless tests)
eric@webkit.org [Thu, 24 May 2012 01:07:22 +0000 (01:07 +0000)]
Add seamless layout code (and pass most of the remaining seamless tests)
https://bugs.webkit.org/show_bug.cgi?id=86608

Reviewed by Ojan Vafai.

Source/WebCore:

This patch contains almost all the layout changes needed for seamless iframes.
I removed the scroll-bar avoiding code at the last moment, as it didn't
work for platforms other than mac-lion.  I'll add that, as well as the
HTMLIFrameElement.seamless idl attribute in a follow-up patch.

Seamless iframes piggy-back a bit on the existing frame-flattening
logic, however seamless is different from frame-flattening in a few ways:
- Frame flattening can only ever make an iframe larger (seamless just behaves like a normal div).
- Frame flattening disables scrollbars (seamless frames behave like normal overflow: auto divs).
- Seamless only has to work with iframes (flattening works with frame/frameset as well).
- Seamless support shrink-wrap size negotiation when the iframe is inline.

Test: fast/frames/seamless/seamless-percent-height.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): map inline -> inline-block for seamless iframes.
* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
 - Seamless iframes don't manage their own style recalc.
(WebCore::Document::recalcStyle):
 - We should make sure our parent is resolved before we are, but currently that causes some tests to crash
   I don't have a test to demonstrate this need yet, as presumably it's fulfilled through other codepaths atm.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayout): Do the cheaper check first.
(WebCore::FrameView::isInChildFrameWithFrameFlattening): Make frameview layout abort child layouts like how frame flattening does.
* rendering/RenderBox.h:
(WebCore::RenderBox::stretchesToViewport): Disable the stretch-to-viewport quirk for seamless iframes (it makes no sense and breaks the layout code).
* rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::computeLogicalHeight):
 - This function is needed for the child document to participate in the normal block shrink-wrap algorithm.
   Thankfully all the shrink-wrap logic is in RenderBox instead of RenderBlock. In the future we may make
   RenderIframe a RenderBlock for the seamless case. We may just split RenderIframe into two renderers.
(WebCore::RenderIFrame::computeLogicalWidth):
(WebCore::RenderIFrame::shouldComputeSizeAsReplaced):
 - seamless iframes behave like blocks, not inline replaced elements.
(WebCore):
(WebCore::RenderIFrame::isInlineBlockOrInlineTable):
 - Behave like an inline-block when marked inline.
(WebCore::RenderIFrame::minPreferredLogicalWidth):
 - When asked for our pref widths, return those of our child document.
(WebCore::RenderIFrame::maxPreferredLogicalWidth):
(WebCore::RenderIFrame::isSeamless): helper function
(WebCore::RenderIFrame::contentRootRenderer): helper function
(WebCore::RenderIFrame::flattenFrame): seamless iframes never use the frame-flattening feature.
(WebCore::RenderIFrame::layoutSeamlessly): The guts of seamless layout.
(WebCore::RenderIFrame::layout):
* rendering/RenderIFrame.h:
(WebCore):
(RenderIFrame):

LayoutTests:

Add a test for percent height in child documents, as well as
disabling the expand-to-fill-viewport quirk of html/body elements
in quirks mode.
Also update all the expectations now that we pass almost all the tests.

* fast/frames/seamless/resources/percent-square.html: Added.
* fast/frames/seamless/resources/two-inline-blocks.html:
* fast/frames/seamless/seamless-basic-expected.txt:
* fast/frames/seamless/seamless-float-expected.txt:
* fast/frames/seamless/seamless-inherited-origin-expected.txt:
* fast/frames/seamless/seamless-inherited-origin.html:
* fast/frames/seamless/seamless-inline-expected.txt:
* fast/frames/seamless/seamless-nested-expected.txt:
* fast/frames/seamless/seamless-percent-height-expected.txt: Added.
* fast/frames/seamless/seamless-percent-height.html: Added.
* fast/frames/seamless/seamless-quirks-expected.txt:
* fast/frames/seamless/seamless-sandbox-flag-expected.txt:
* fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@118291 268f45cc-cd09-0410-ab3c-d52691b4dbfc