WebKit-https.git
8 years agoAdd jsCast to replace static_cast
mhahnenberg@apple.com [Fri, 11 Nov 2011 20:40:10 +0000 (20:40 +0000)]
Add jsCast to replace static_cast
https://bugs.webkit.org/show_bug.cgi?id=72071

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::toStringCallback):
(JSC::JSCallbackFunction::valueOfCallback):
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildren):
* API/JSCallbackObjectFunctions.h:
(JSC::::className):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::put):
(JSC::::deleteProperty):
(JSC::::deletePropertyByIndex):
(JSC::::getConstructData):
(JSC::::hasInstance):
(JSC::::getCallData):
(JSC::::getOwnPropertyNames):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildren):
(JSC::DebuggerActivation::className):
(JSC::DebuggerActivation::getOwnPropertySlot):
(JSC::DebuggerActivation::put):
(JSC::DebuggerActivation::putWithAttributes):
(JSC::DebuggerActivation::deleteProperty):
(JSC::DebuggerActivation::getOwnPropertyNames):
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
(JSC::DebuggerActivation::defineGetter):
(JSC::DebuggerActivation::defineSetter):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::getOwnPropertySlotByIndex):
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::getOwnPropertyDescriptor):
(JSC::Arguments::getOwnPropertyNames):
(JSC::Arguments::putByIndex):
(JSC::Arguments::put):
(JSC::Arguments::deletePropertyByIndex):
(JSC::Arguments::deleteProperty):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertySlot):
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildren):
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
(JSC::JSActivation::getOwnPropertyNames):
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::put):
(JSC::JSActivation::putWithAttributes):
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putByIndex):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::deletePropertyByIndex):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::visitChildren):
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::visitChildren):
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlot):
(JSC::JSByteArray::getOwnPropertyDescriptor):
(JSC::JSByteArray::getOwnPropertySlotByIndex):
(JSC::JSByteArray::put):
(JSC::JSByteArray::putByIndex):
(JSC::JSByteArray::getOwnPropertyNames):
* runtime/JSCell.h:
(JSC::JSCell::visitChildren):
(JSC::jsCast):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::getConstructData):
* runtime/JSGlobalData.cpp:
(JSC::StackPreservingRecompiler::operator()):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::putWithAttributes):
(JSC::JSGlobalObject::defineGetter):
(JSC::JSGlobalObject::defineSetter):
(JSC::JSGlobalObject::visitChildren):
(JSC::JSGlobalObject::getOwnPropertySlot):
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
(JSC::JSGlobalObject::clearRareData):
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::visitChildren):
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSObject.cpp:
(JSC::JSObject::finalize):
(JSC::JSObject::visitChildren):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::put):
(JSC::JSObject::putByIndex):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::deletePropertyByIndex):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildren):
(JSC::JSStaticScopeObject::put):
(JSC::JSStaticScopeObject::putWithAttributes):
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSString.cpp:
(JSC::JSString::visitChildren):
(JSC::JSString::toThisObject):
(JSC::JSString::getOwnPropertySlot):
(JSC::JSString::getOwnPropertySlotByIndex):
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
(JSC::JSVariableObject::getOwnPropertyNames):
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildren):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
(JSC::ObjectPrototype::getOwnPropertySlotByIndex):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
(JSC::RegExpConstructor::put):
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
(JSC::RegExpMatchesArray::getOwnPropertySlotByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
(JSC::RegExpMatchesArray::put):
(JSC::RegExpMatchesArray::putByIndex):
(JSC::RegExpMatchesArray::deleteProperty):
(JSC::RegExpMatchesArray::deletePropertyByIndex):
(JSC::RegExpMatchesArray::getOwnPropertyNames):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildren):
(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::getOwnPropertyDescriptor):
(JSC::RegExpObject::put):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildren):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
(JSC::StringObject::getOwnPropertySlotByIndex):
(JSC::StringObject::getOwnPropertyDescriptor):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnPropertyNames):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/Structure.cpp:
(JSC::Structure::visitChildren):
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildren):

Source/JavaScriptGlue:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* UserObjectImp.cpp:
(UserObjectImp::getCallData):
(UserObjectImp::getOwnPropertyNames):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::visitChildren):

Source/WebCore:

No new tests.

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildren):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildren):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildren):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildren):
* bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toHTMLCanvasStyle):
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildren):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::toThisObject):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildren):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
(WebCore::JSDOMWindow::put):
(WebCore::JSDOMWindow::deleteProperty):
(WebCore::JSDOMWindow::getPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):
(WebCore::JSDOMWindow::defineGetter):
(WebCore::JSDOMWindow::defineSetter):
(WebCore::JSDOMWindow::defineOwnProperty):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getCallData):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getCallData):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getCallData):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::deleteProperty):
(WebCore::JSHistory::getOwnPropertyNames):
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildren):
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::deleteProperty):
(WebCore::JSLocation::getOwnPropertyNames):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildren):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildren):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildren):
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildren):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildren):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildren):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildren):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildren):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
(WebCore::JSTestObj::put):
(WebCore::JSTestObj::visitChildren):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getCallData):
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildren):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertyDescriptor):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::put):
(JSC::RuntimeArray::putByIndex):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
(JSC::Bindings::RuntimeObject::put):
(JSC::Bindings::RuntimeObject::defaultValue):
(JSC::Bindings::RuntimeObject::getCallData):
(JSC::Bindings::RuntimeObject::getConstructData):
(JSC::Bindings::RuntimeObject::getOwnPropertyNames):

Source/WebKit2:

Added new jsCast and changed all of the static_cast sites in functions that
are in the MethodTable to use jsCast instead.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallData):
(WebKit::JSNPObject::getConstructData):
(WebKit::JSNPObject::getOwnPropertySlot):
(WebKit::JSNPObject::getOwnPropertyDescriptor):
(WebKit::JSNPObject::put):
(WebKit::JSNPObject::deleteProperty):
(WebKit::JSNPObject::deletePropertyByIndex):
(WebKit::JSNPObject::getOwnPropertyNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable DFG JIT for ARMv7/iOS.
barraclough@apple.com [Fri, 11 Nov 2011 20:31:16 +0000 (20:31 +0000)]
Enable DFG JIT for ARMv7/iOS.

Rubber stamped by Oliver Hunt.

* wtf/Platform.h:
    - enable DFG JIT for ARMv7/iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99994.
scheib@chromium.org [Fri, 11 Nov 2011 20:24:33 +0000 (20:24 +0000)]
Unreviewed, rolling out r99994.
http://trac.webkit.org/changeset/99994
https://bugs.webkit.org/show_bug.cgi?id=72150

Broke chromium windows build

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitLockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitUnlockMouseEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMouseLockedEnabled):
* page/MouseLockable.cpp: Removed.
* page/MouseLockable.h: Removed.
* page/MouseLockable.idl: Removed.
* page/Navigator.cpp:
* page/Navigator.h:
* page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] Remove unused V8Proxy::executingScript method
adamk@chromium.org [Fri, 11 Nov 2011 19:49:20 +0000 (19:49 +0000)]
[v8] Remove unused V8Proxy::executingScript method
https://bugs.webkit.org/show_bug.cgi?id=72160

Reviewed by Nate Chapin.

* bindings/v8/V8Proxy.cpp:
* bindings/v8/V8Proxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
rniwa@webkit.org [Fri, 11 Nov 2011 19:47:14 +0000 (19:47 +0000)]
Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
https://bugs.webkit.org/show_bug.cgi?id=72090

Reviewed by Eric Seidel.

Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.

yay! r100002.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRubberstamped by Andy Estes
beidson@apple.com [Fri, 11 Nov 2011 19:45:36 +0000 (19:45 +0000)]
Rubberstamped by Andy Estes

100,000!
Congratulations WebKit, and here's to hundreds of thousands more!

* ChangeLog: Point out revision 100,000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago100,000 !!!
ossy@webkit.org [Fri, 11 Nov 2011 19:45:34 +0000 (19:45 +0000)]
100,000 !!!

Reviewed by Zoltan Herczeg.

* ChangeLog: Point out revision 100,000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/71921> Remove use of strcpy in KURL
ddkilzer@apple.com [Fri, 11 Nov 2011 19:45:13 +0000 (19:45 +0000)]
<webkit.org/b/71921> Remove use of strcpy in KURL

Reviewed by Antti Koivisto.

* platform/KURL.cpp:
(WebCore::KURL::init): Replace strcpy() with strncpy().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove --force from gclient sync. The bots seem to have made it past
tony@chromium.org [Fri, 11 Nov 2011 19:41:23 +0000 (19:41 +0000)]
Remove --force from gclient sync.  The bots seem to have made it past
the update step.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in...
mhahnenberg@apple.com [Fri, 11 Nov 2011 19:32:59 +0000 (19:32 +0000)]
De-virtualize supportsProfiling, supportsRichSourceInfo, shouldInterruptScript in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=72035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

De-virtualized the methods through the use of a new method table just for JSGlobalObject and subclasses.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* bytecompiler/BytecodeGenerator.cpp: Changed call sites to use the new GlobalObjectMethodTable.
(JSC::BytecodeGenerator::BytecodeGenerator):
* interpreter/Interpreter.cpp: Ditto.
(JSC::Interpreter::execute):
* runtime/JSGlobalObject.cpp: Added a static const GlobalObjectMethodTable with the correct function pointers.
* runtime/JSGlobalObject.h: Added a field in JSGlobalObject to keep track of the current method table.
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::globalObjectMethodTable): The new struct to contain the function pointers.
(JSC::JSGlobalObject::supportsProfiling): Made static to put in the method table.
(JSC::JSGlobalObject::supportsRichSourceInfo): Ditto.
(JSC::JSGlobalObject::shouldInterruptScript): Ditto.
* runtime/TimeoutChecker.cpp: Changed call sites to use the new GlobalObjectMethodTable for lookup.
(JSC::TimeoutChecker::didTimeOut):

Source/WebCore:

No new tests.

* bindings/js/JSDOMGlobalObject.cpp: Changed constructor to support passing new GlobalObjectMethodTable pointer to parent class.
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp: Added static const GlobalObjectMethodTable and filled it in with the proper function pointers.
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::supportsProfiling): Changed to static to put in the method table.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Ditto.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Ditto.
* bindings/js/JSDOMWindowBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd --force to gclient sync. Once the cq bots cycle, we can remove
tony@chromium.org [Fri, 11 Nov 2011 19:28:34 +0000 (19:28 +0000)]
Add --force to gclient sync. Once the cq bots cycle, we can remove
this since it slows down the normal sync.

* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99869.
ojan@chromium.org [Fri, 11 Nov 2011 19:14:25 +0000 (19:14 +0000)]
Unreviewed, rolling out r99869.
http://trac.webkit.org/changeset/99869
https://bugs.webkit.org/show_bug.cgi?id=72157

"Caused a ~400% perf regression on the Chromium intl1 page
cyclers" (Requested by ojan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
* dom/Document.h:
* html/CollectionType.h:

LayoutTests:

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMouse Lock Navigator IDL
scheib@chromium.org [Fri, 11 Nov 2011 19:09:49 +0000 (19:09 +0000)]
Mouse Lock Navigator IDL
https://bugs.webkit.org/show_bug.cgi?id=72150

Reviewed by Dimitri Glazkov.

Tests require mocking (similar to geolocation) that will be built after this.

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitPointerEnabled):
* page/MouseLockable.cpp: Added.
(WebCore::MouseLockable::MouseLockable):
(WebCore::MouseLockable::~MouseLockable):
(WebCore::MouseLockable::webkitLock):
(WebCore::MouseLockable::webkitUnlock):
(WebCore::MouseLockable::webkitIsLocked):
* page/MouseLockable.h: Added.
(WebCore::MouseLockable::create):
* page/MouseLockable.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::webkitPointer):
* page/Navigator.h:
* page/Navigator.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSGlobalObject::allowsAccessFrom
mhahnenberg@apple.com [Fri, 11 Nov 2011 19:07:22 +0000 (19:07 +0000)]
De-virtualize JSGlobalObject::allowsAccessFrom
https://bugs.webkit.org/show_bug.cgi?id=71969

Reviewed by Darin Adler.

Source/JavaScriptCore:

* runtime/JSGlobalObject.h: Removed allowsAccessFrom from JSGlobalObject since it is exclusive to
JSDOMWindowBase and WebScriptObject.

Source/WebCore:

No new tests.

Since allowsAccessFrom is only used by WebScriptObject, we know that we'll always have a
JSDOMWindowBase, so we can simply have allowsAccessFrom to live in JSDOMWindowBase rather
than JSGlobalObject.

* bindings/js/JSDOMWindowBase.h: De-virtualized allowsAccessFrom.
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _isSafeScript]): Added a cast from a JSGlobalObject to a JSDOMWindowBase in
order to call the allowsAccessFrom method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MutationObservers] Support attributeFilter for attribute mutations
adamk@chromium.org [Fri, 11 Nov 2011 18:56:02 +0000 (18:56 +0000)]
[MutationObservers] Support attributeFilter for attribute mutations
https://bugs.webkit.org/show_bug.cgi?id=70860

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

Source/WebCore:

This patch adds an attributeFilter to the MutationObserverRegistration and
adds support for only observing attributes whose name are in the provided
filter set (array of strings).

Test: fast/mutation/observe-attributes.html.

* bindings/js/JSWebKitMutationObserverCustom.cpp:
(WebCore::JSWebKitMutationObserver::observe):
* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get):
* bindings/v8/OptionsObject.h:
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::resetObservation):
(WebCore::MutationObserverRegistration::shouldReceiveMutationFrom):
(WebCore::MutationObserverRegistration::caseInsensitiveAttributeFilter):
* dom/MutationObserverRegistration.h:
* dom/Node.cpp:
(WebCore::Node::collectMatchingObserversForMutation):
(WebCore::Node::getRegisteredMutationObserversOfType):
* dom/Node.h:
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
* dom/WebKitMutationObserver.h:

LayoutTests:

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen --force is used, also use --reset
tony@chromium.org [Fri, 11 Nov 2011 18:40:30 +0000 (18:40 +0000)]
When --force is used, also use --reset
https://bugs.webkit.org/show_bug.cgi?id=72129

Patch by Marc-Antoine Ruel <maruel@chromium.org> on 2011-11-11
Reviewed by Dimitri Glazkov.

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative fix for a few worker tests.
tony@chromium.org [Fri, 11 Nov 2011 18:35:20 +0000 (18:35 +0000)]
Speculative fix for a few worker tests.
https://bugs.webkit.org/show_bug.cgi?id=72134

Looking at the recent failures, it looks like the test starts and completes
before the page is done loading completely (the test output is correct except
for the HTML on top of the files). So start the tests from an onload callback so
that the plain HTML text also gets printed correctly.

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-11-11
Reviewed by Tony Chang.

* fast/workers/resources/worker-replace-self.js:
(startTest.worker.onmessage):
(startTest):
* fast/workers/worker-call.html:
* fast/workers/worker-close.html:
* fast/workers/worker-messageport-gc.html:
* fast/workers/worker-replace-self.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoallow two chromium drivers to run at the same time in NRWT
tony@chromium.org [Fri, 11 Nov 2011 18:30:46 +0000 (18:30 +0000)]
allow two chromium drivers to run at the same time in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72067

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
    posix prevents the subprocesses from sharing the same fd for stdin.
    Sharing the same fd prevents us from closing the files unless all references
    to the fd are closed.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
    to adding a test for this, speed up a test (from 3sec to 0) by fixing
    the timeout override. It looks like it regressed in r95875.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoApplication cache status indicator gets stuck at DOWNLOADING after a failure
vsevik@chromium.org [Fri, 11 Nov 2011 18:28:50 +0000 (18:28 +0000)]
Application cache status indicator gets stuck at DOWNLOADING after a failure
https://bugs.webkit.org/show_bug.cgi?id=60793

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html

* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::restore):
(WebCore::InspectorApplicationCacheAgent::enable):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.updateStatus):

LayoutTests:

* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt:
* http/tests/inspector/resource-tree/appcache-iframe-manifests.html:
* http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.
* http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file.html: Added.
* http/tests/inspector/resource-tree/appcache-test.js: Added.
(createAndNavigateIFrame):
(removeIFrame):
(navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.createAndNavigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame.frameNavigated):
(initialize_ApplicationCacheTest.InspectorTest.navigateIFrame):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame.frameDetached):
(initialize_ApplicationCacheTest.InspectorTest.removeIFrame):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCache):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheTree):
(initialize_ApplicationCacheTest.InspectorTest.frameIdToString):
(initialize_ApplicationCacheTest.InspectorTest.applicationCacheStatusToString):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheModel):
(initialize_ApplicationCacheTest.InspectorTest.waitForFrameManifestURLAndStatus):
(initialize_ApplicationCacheTest.InspectorTest.startApplicationCacheStatusesRecording):
(initialize_ApplicationCacheTest.InspectorTest.ensureFrameManifestStatusEventReceived):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords.compareFunc):
(initialize_ApplicationCacheTest.InspectorTest.dumpApplicationCacheStatusesRecords):
(initialize_ApplicationCacheTest):
* http/tests/inspector/resource-tree/resources/manifest.php:
* platform/chromium/http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
* platform/chromium/http/tests/inspector/resource-tree/appcache-manifest-with-non-existing-file-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] failing media/track/tracklist-is-reachable
tonyg@chromium.org [Fri, 11 Nov 2011 18:20:19 +0000 (18:20 +0000)]
[chromium] failing media/track/tracklist-is-reachable
https://bugs.webkit.org/show_bug.cgi?id=72149

* platform/chromium/test_expectations.txt: Expect test to fail for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnly use the textured window style mask when there is no override inspector page.
timothy@apple.com [Fri, 11 Nov 2011 18:03:59 +0000 (18:03 +0000)]
Only use the textured window style mask when there is no override inspector page.

https://webkit.org/b/72142

Reviewed by Dan Bernstein.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformOpen): Don't set NSTexturedBackgroundWindowMask if
there is an override inspector page. Make setAutorecalculatesContentBorderThickness:,
setContentBorderThickness: and WKNSWindowMakeBottomCornersSquare conditional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExpect chromium to pass this test after r99958.
tonyg@chromium.org [Fri, 11 Nov 2011 17:58:24 +0000 (17:58 +0000)]
Expect chromium to pass this test after r99958.

* platform/chromium/fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement TextTrackList and the textTracks attribute of HTMLMediaElement
eric.carlson@apple.com [Fri, 11 Nov 2011 17:33:51 +0000 (17:33 +0000)]
Implement TextTrackList and the textTracks attribute of HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=71123

Reviewed by Sam Weinig.

Source/WebCore:

Test: media/track/track-add-track.html
      media/track/tracklist-is-reachable.html

* CMakeLists.txt: Add new files for TextTrackList.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* DerivedSources.pri: Ditto.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSTextTrackListCustom.cpp: Added.
(WebCore::JSTextTrackListOwner::isReachableFromOpaqueRoots):

* dom/EventTargetFactory.in: Add TextTrackList, conditional on VIDEO_TRACK.

* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::createForJSConstructor): Update for scheduleLoad change.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Update for m_textTracks change from
    generic Vector to TextTrackList.
(WebCore::HTMLMediaElement::attributeChanged): Ditto.
(WebCore::HTMLMediaElement::insertedIntoDocument): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::scheduleLoad): Add a parameter so caller can specify if
    the main resource or a text track should be loaded.
(WebCore::HTMLMediaElement::loadTimerFired): Update to allow text track loading.
(WebCore::HTMLMediaElement::loadInternal): Don't call loadTextTracks.
(WebCore::HTMLMediaElement::isSafeToLoadURL): Log when CSP denies load.
(WebCore::HTMLMediaElement::playInternal): Update for scheduleLoad change.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::addTrack): Update for m_textTracks change from
    generic Vector to TextTrackList.
(WebCore::HTMLMediaElement::addTextTrack): New, add track to m_textTracks and configure.
(WebCore::HTMLMediaElement::configureTextTracks): New, add comments about what this should
    do eventually.
(WebCore::HTMLMediaElement::textTracks): New, return TextTrackList.
(WebCore::HTMLMediaElement::trackWasAdded): Bail if runtime feature is not enabled, schedule
    asynchronous text track load.
(WebCore::HTMLMediaElement::trackWillBeRemoved): Minor cleanup.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.
(WebCore::HTMLMediaElement::sourceWasAdded): Update for scheduleLoad change.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl: Add textTracks attribute.

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree): Use new mediaElement() method.
(WebCore::HTMLTrackElement::willRemove): Ditto.
(WebCore::HTMLTrackElement::attributeChanged): When 'src' is changed, call scheduleLoad
    instead of HTMLMediaElement
(WebCore::HTMLTrackElement::isDefault): hasAttribute -> fastHasAttribute.
(WebCore::HTMLTrackElement::track): Allocate track if necessary.
(WebCore::HTMLTrackElement::scheduleLoad): New, tell the track to schedule a load.
(WebCore::HTMLTrackElement::canLoadUrl): New, check security policy to see if it is OK
    to load a text track. If so, dispatch 'beforeload' event to give it a chance to disallow
    load.
(WebCore::HTMLTrackElement::loadingCompleted): Renamed from textTrackLoadingCompleted.
(WebCore::HTMLTrackElement::textTrackReadyStateChanged): New, TextTrackLoadingClient interface
    used to inform parent of TextTrack state changes.
(WebCore::HTMLTrackElement::textTrackModeChanged): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCues): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCues): Ditto.
(WebCore::HTMLTrackElement::textTrackAddCue): Ditto.
(WebCore::HTMLTrackElement::textTrackRemoveCue): Ditto.
(WebCore::HTMLTrackElement::mediaElement): New, return parent element.
* html/HTMLTrackElement.h:

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack): Initialize new instance variables.
(WebCore::LoadableTextTrack::scheduleLoad): New, prime a timer to kick off loading.
(WebCore::LoadableTextTrack::loadTimerFired): Cancel current load, if any, check to see if
    new url is allowed to load, and start new load.
(WebCore::LoadableTextTrack::cueLoadingCompleted):
* html/LoadableTextTrack.h:
(WebCore::LoadableTextTrackClient::~LoadableTextTrackClient): TextTrackLoadingClient -> LoadableTextTrackClient
(WebCore::LoadableTextTrackClient::canLoadUrl):
(WebCore::LoadableTextTrackClient::loadingCompleted):
(WebCore::LoadableTextTrack::create):

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): setClient(0) -> clearClient().
* html/TextTrack.h:
(WebCore::TextTrack::clearClient): Renamed from setClient, because it is only used to clear the client pointer.

* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Get rid of a compiler warning that breaks the OS X build.

* html/track/TextTrackList.cpp: Added. Implement the TextTrackList object.
(TextTrackList::TextTrackList):
(TextTrackList::~TextTrackList):
(TextTrackList::length):
(TextTrackList::item):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::interfaceName):
(TextTrackList::scheduleAddTrackEvent):
(TextTrackList::asyncEventTimerFired):
* html/track/TextTrackList.h: Added.
(WebCore::TextTrackList::create):
(WebCore::TextTrackList::scriptExecutionContext):
(WebCore::TextTrackList::clearOwner):
(WebCore::TextTrackList::owner):
(WebCore::TextTrackList::refEventTarget):
(WebCore::TextTrackList::derefEventTarget):
(WebCore::TextTrackList::eventTargetData):
(WebCore::TextTrackList::ensureEventTargetData):
* html/track/TextTrackList.idl: Added.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::cancelLoad): New, cancel pending or in progress load and delete loader.
(WebCore::TextTrackLoader::notifyFinished): Call cancelLoad.
(WebCore::TextTrackLoader::load): Ditto.
* loader/TextTrackLoader.h:
* page/DOMWindow.idl: Add TextTrackList.

LayoutTests:

* media/track/track-add-track-expected.txt: Added.
* media/track/track-add-track.html: Added.
* media/track/tracklist-is-reachable-expected.txt: Added.
* media/track/tracklist-is-reachable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: reimplement DOM search using no XPath.
pfeldman@chromium.org [Fri, 11 Nov 2011 17:18:22 +0000 (17:18 +0000)]
Web Inspector: reimplement DOM search using no XPath.
https://bugs.webkit.org/show_bug.cgi?id=72125

Reviewed by Yury Semikhatsky.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/InspectorDOMAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProtect Document during error responses
gavinp@chromium.org [Fri, 11 Nov 2011 16:55:31 +0000 (16:55 +0000)]
Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/misc/xslt-bad-import.html

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

LayoutTests:

* http/tests/misc/resources/xslt-bad-import-uri.xml: Added.
* http/tests/misc/resources/xslt-bad-import-uri.xsl: Added.
* http/tests/misc/xslt-bad-import-expected.txt: Added.
* http/tests/misc/xslt-bad-import.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99979.
gavinp@chromium.org [Fri, 11 Nov 2011 16:53:33 +0000 (16:53 +0000)]
Unreviewed, rolling out r99979.
http://trac.webkit.org/changeset/99979
https://bugs.webkit.org/show_bug.cgi?id=72136

bad commit message (Requested by gavinp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Nov 2011 16:50:57 +0000 (16:50 +0000)]
2011-11-11  Yury Semikhatsky  <yurys@chromium.org>

        Fixed overlapping expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProtect Document during error responses
gavinp@chromium.org [Fri, 11 Nov 2011 16:47:05 +0000 (16:47 +0000)]
Protect Document during error responses
https://bugs.webkit.org/show_bug.cgi?id=72068

Add a Document protector to the error response code handler, just
as exists for other ends of requests.

Reviewed by NOBODY (OOPS!).

Test: http/tests/misc/xslt-bad-import.html

* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::didReceiveData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Nov 2011 16:43:07 +0000 (16:43 +0000)]
2011-11-11  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mark http/tests/inspector-enabled/dedicated-workers-list.html as timing out on Mac.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] GstCaps and GstPad RefPtr implementation
philn@webkit.org [Fri, 11 Nov 2011 16:35:13 +0000 (16:35 +0000)]
[GStreamer] GstCaps and GstPad RefPtr implementation
https://bugs.webkit.org/show_bug.cgi?id=72023

Reviewed by Martin Robinson.

Smart pointer implementations for GstCaps and GstPad and them
in the media player code.

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::GstPad):
(WTF::GstCaps):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::naturalSize):
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(StreamingClient::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed evening gardening. Add platform specific expected results for new...
ossy@webkit.org [Fri, 11 Nov 2011 16:33:05 +0000 (16:33 +0000)]
[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

* platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.png: Added.
* platform/qt/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.png: Added.
* platform/qt/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/qt/fast/multicol/pagination-h-vertical-lr-expected.png: Added.
* platform/qt/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
* platform/qt/fast/multicol/pagination-h-vertical-rl-expected.png: Added.
* platform/qt/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.png: Added.
* platform/qt/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.png: Added.
* platform/qt/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
* platform/qt/fast/multicol/pagination-v-vertical-lr-expected.png: Added.
* platform/qt/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
* platform/qt/fast/multicol/pagination-v-vertical-rl-expected.png: Added.
* platform/qt/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rilling out 99971,99972.
gavinp@chromium.org [Fri, 11 Nov 2011 16:31:50 +0000 (16:31 +0000)]
Unreviewed, rilling out 99971,99972.

They were landed in error in using git-svn by gavinp@chromium.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed evening gardening. Add platform specific expected results for new...
ossy@webkit.org [Fri, 11 Nov 2011 16:28:46 +0000 (16:28 +0000)]
[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

* platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/qt/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/qt/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip 2 failing pasteboard tests after r99924.
philn@webkit.org [Fri, 11 Nov 2011 16:27:02 +0000 (16:27 +0000)]
Unreviewed, skip 2 failing pasteboard tests after r99924.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoar
gavinp@chromium.org [Fri, 11 Nov 2011 16:25:38 +0000 (16:25 +0000)]
Moar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofirst shot yo
gavinp@chromium.org [Fri, 11 Nov 2011 16:25:26 +0000 (16:25 +0000)]
first shot yo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed evening gardening. Add platform specific expected results for new...
ossy@webkit.org [Fri, 11 Nov 2011 16:22:17 +0000 (16:22 +0000)]
[Qt] Unreviewed evening gardening. Add platform specific expected results for new passing tests.

* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother baseline for contain-and-cover-zoomed that I didn't catch earlier.
tonyg@chromium.org [Fri, 11 Nov 2011 16:14:59 +0000 (16:14 +0000)]
Another baseline for contain-and-cover-zoomed that I didn't catch earlier.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99964.
hausmann@webkit.org [Fri, 11 Nov 2011 15:52:10 +0000 (15:52 +0000)]
Unreviewed, rolling out r99964.
http://trac.webkit.org/changeset/99964
https://bugs.webkit.org/show_bug.cgi?id=72124

Broke too many Qt tests (Requested by tronical_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* Target.pri:
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::usesMenuList):
* platform/qt/QtMobileWebStyle.cpp: Added.
(QtMobileWebStyle::QtMobileWebStyle):
(drawRectangularControlBackground):
(QtMobileWebStyle::drawChecker):
(QtMobileWebStyle::findChecker):
(QtMobileWebStyle::drawRadio):
(QtMobileWebStyle::findRadio):
(QtMobileWebStyle::drawControl):
(QtMobileWebStyle::drawPrimitive):
(QtMobileWebStyle::drawMultipleComboButton):
(QtMobileWebStyle::drawSimpleComboButton):
(QtMobileWebStyle::getButtonImageSize):
(QtMobileWebStyle::findComboButton):
(QtMobileWebStyle::drawComplexControl):
* platform/qt/QtMobileWebStyle.h: Added.
* platform/qt/QtStyleOptionWebComboBox.h:
(WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox):
(WebCore::QtStyleOptionWebComboBox::checkMultiple):
* platform/qt/RenderThemeQStyle.cpp: Removed.
* platform/qt/RenderThemeQStyle.h: Removed.
* platform/qt/RenderThemeQt.cpp:
(WebCore::initStyleOption):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
(WebCore::RenderThemeQt::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::~RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::popupInternalPaddingBottom):
(WebCore::RenderThemeQt::fallbackStyle):
(WebCore::RenderThemeQt::qStyle):
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::RenderThemeQt::findFrameLineWidth):
(WebCore::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::computeSizeBasedOnStyle):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::setButtonPadding):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::setPopupPadding):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::animationDurationForProgressBar):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):
(WebCore::RenderThemeQt::paintSliderThumb):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::paintInnerSpinButton):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::initializeCommonQStyleOptions):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
* platform/qt/RenderThemeQt.h:
(WebCore::StylePainter::isValid):
(WebCore::StylePainter::drawPrimitive):
(WebCore::StylePainter::drawControl):
(WebCore::StylePainter::drawComplexControl):
* platform/qt/RenderThemeQtMobile.cpp: Removed.
* platform/qt/RenderThemeQtMobile.h: Removed.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/webcore.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: fix Snow Leopard build.
pfeldman@chromium.org [Fri, 11 Nov 2011 15:42:16 +0000 (15:42 +0000)]
Not reviewed: fix Snow Leopard build.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove dead MeeGoTouch code.
hausmann@webkit.org [Fri, 11 Nov 2011 15:35:45 +0000 (15:35 +0000)]
[Qt] Remove dead MeeGoTouch code.

Reviewed by Tor Arne Vestbø.

* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: make search in DOM panel scale.
pfeldman@chromium.org [Fri, 11 Nov 2011 15:22:36 +0000 (15:22 +0000)]
Web Inspector: make search in DOM panel scale.
https://bugs.webkit.org/show_bug.cgi?id=72118

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::discardSearchResults):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent.prototype.performSearch.callback):
(WebInspector.DOMAgent.prototype.performSearch):
(WebInspector.DOMAgent.prototype.searchResult.mycallback):
(WebInspector.DOMAgent.prototype.searchResult):
(WebInspector.DOMAgent.prototype.cancelSearch):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.searchCanceled):
(WebInspector.ElementsPanel.prototype.performSearch.resultCountCallback):
(WebInspector.ElementsPanel.prototype.performSearch):
(WebInspector.ElementsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ElementsPanel.prototype.jumpToPreviousSearchResult):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult.):
(WebInspector.ElementsPanel.prototype._highlightCurrentSearchResult):
(WebInspector.ElementsPanel.prototype._hideSearchHighlights):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._showSearchResult.callback):
(WebInspector.ResourcesPanel.prototype._showSearchResult):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):
(WebInspector.ScriptsPanel.prototype.performSearch):
(WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):
(WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):

LayoutTests:

* inspector/elements/elements-panel-search-expected.txt:
* inspector/elements/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_b...
hausmann@webkit.org [Fri, 11 Nov 2011 15:16:19 +0000 (15:16 +0000)]
[Qt] Remove the QStyle dependency in Qt's mobile theme https://bugs.webkit.org/show_bug.cgi?id=67773

This refactoring splits up RenderThemeQt with two
subclasses, a QStyle-backed one, and a Mobile version
that uses the old mobile theme for now.

QStyle availability is detected at compile time, and
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
environment variable.

Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-11-11
Reviewed by Simon Hausmann.

Source/WebCore:

Covered by the existing tests.

* Target.pri:
* platform/qt/QtMobileWebStyle.cpp: Removed. The relevant logic
now lives within RenderThemeQtMobile.
* platform/qt/QtMobileWebStyle.h: Removed. Ditto.
* platform/qt/RenderThemeQStyle.cpp: Added.
(WebCore::initStyleOption):
(WebCore::RenderThemeQStyle::getStylePainter):
(WebCore::StylePainterQStyle::StylePainterQStyle):
(WebCore::StylePainterQStyle::init):
(WebCore::RenderThemeQStyle::create):
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
(WebCore::RenderThemeQStyle::fallbackStyle):
(WebCore::RenderThemeQStyle::qStyle):
(WebCore::RenderThemeQStyle::findFrameLineWidth):
(WebCore::RenderThemeQStyle::inflateButtonRect):
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::setButtonPadding):
(WebCore::RenderThemeQStyle::paintButton):
(WebCore::RenderThemeQStyle::adjustTextFieldStyle):
(WebCore::RenderThemeQStyle::paintTextField):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::paintTextArea):
(WebCore::RenderThemeQStyle::setPopupPadding):
(WebCore::RenderThemeQStyle::paintMenuList):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::paintMenuListButton):
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
(WebCore::RenderThemeQStyle::paintProgressBar):
(WebCore::RenderThemeQStyle::paintSliderTrack):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::paintSliderThumb):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::paintSearchField):
(WebCore::RenderThemeQStyle::adjustSearchFieldStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* platform/qt/RenderThemeQStyle.h: Added.
(WebCore::StylePainterQStyle::isValid):
(WebCore::StylePainterQStyle::drawPrimitive):
(WebCore::StylePainterQStyle::drawControl):
(WebCore::StylePainterQStyle::drawComplexControl):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::RenderThemeQt):
(WebCore::RenderThemeQt::isControlStyled):
(WebCore::RenderThemeQt::inflateButtonRect):
(WebCore::RenderThemeQt::adjustRepaintRect):
(WebCore::RenderThemeQt::minimumMenuListSize):
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::paintSearchFieldCancelButton):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQt::paintMediaFullscreenButton):
(WebCore::RenderThemeQt::paintMediaMuteButton):
(WebCore::RenderThemeQt::paintMediaPlayButton):
(WebCore::RenderThemeQt::paintMediaCurrentTime):
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb):
(WebCore::RenderThemeQt::paintMediaSliderTrack):
(WebCore::RenderThemeQt::paintMediaSliderThumb):
(WebCore::RenderThemeQt::adjustSliderThumbSize):
(WebCore::RenderThemeQt::caretBlinkInterval):
(WebCore::RenderThemeQt::fileListNameForWidth):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
* platform/qt/RenderThemeQt.h:
(WebCore::RenderThemeQt::useMobileTheme):
(WebCore::StylePainter::isValid):
* platform/qt/RenderThemeQtMobile.cpp: Added.
(WebCore::drawRectangularControlBackground):
(WebCore::RenderThemeQtMobile::getStylePainter):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findChecker):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::RenderThemeQtMobile::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeQtMobile::RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::~RenderThemeQtMobile):
(WebCore::RenderThemeQtMobile::isControlStyled):
(WebCore::RenderThemeQtMobile::popupInternalPaddingBottom):
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::setButtonPadding):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::checkMultiple):
(WebCore::RenderThemeQtMobile::setPaletteFromPageClientIfExists):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h: Added.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeQt::paint):
(WebCore::ScrollbarThemeQt::scrollbarThickness):
(WebCore::ScrollbarThemeQt::paintScrollCorner):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::swallowContextMenuEvent):
* tests/tests.pri:

Tools:

* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
based on availability of QtWidgets.
* qmake/mkspecs/features/webcore.prf: cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Option to configure indentation of pretty-printed Javascript
apavlov@chromium.org [Fri, 11 Nov 2011 15:14:39 +0000 (15:14 +0000)]
Web Inspector: Option to configure indentation of pretty-printed Javascript
https://bugs.webkit.org/show_bug.cgi?id=72119

Reviewed by Pavel Feldman.

Source/WebCore:

Drive-by fix for field names and added indent caching, as suggested by Pavel Podivilov.

* inspector/front-end/JavaScriptFormatter.js:
(FormattedContentBuilder):
(FormattedContentBuilder.prototype.increaseNestingLevel):
(FormattedContentBuilder.prototype.decreaseNestingLevel):
(FormattedContentBuilder.prototype._addIndent):
* inspector/front-end/ScriptFormatter.js:
* inspector/front-end/ScriptFormatterWorker.js:
(onmessage):
(formatScript):
(HTMLScriptFormatter):
(HTMLScriptFormatter.prototype.scriptEnded):

LayoutTests:

* inspector/debugger/script-formatter-expected.txt:
* inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Chromium build fix after r99958.
andreas.kling@nokia.com [Fri, 11 Nov 2011 15:08:38 +0000 (15:08 +0000)]
Unreviewed Chromium build fix after r99958.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementationCustomCall):o

    Remove hack that forced HTMLOptionsCollection to have a custom
    callAsFunctionCallback().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix of the private QML module with --no-webkit2.
alexis.menard@openbossa.org [Fri, 11 Nov 2011 14:55:12 +0000 (14:55 +0000)]
[Qt] Build fix of the private QML module with --no-webkit2.
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Tor Arne Vestbø.

* Source/QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
loislo@chromium.org [Fri, 11 Nov 2011 14:50:56 +0000 (14:50 +0000)]
Web Inspector: DevTools InspectorStubs.js incorrectly converting responses to arguments.
https://bugs.webkit.org/show_bug.cgi?id=72096

JSON.parse doesn't garantee the order of keys.
We have to explicitly order the results according to Inspector.json spec.

Patch by Mike Lewis <mikelikespie@gmail.com> on 2011-11-11
Reviewed by Pavel Feldman.

* inspector/CodeGeneratorInspector.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skip a svg test and GTK rebaseline after r99941.
philn@webkit.org [Fri, 11 Nov 2011 14:50:47 +0000 (14:50 +0000)]
Unreviewed, skip a svg test and GTK rebaseline after r99941.

* platform/gtk/Skipped:
* platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove ability to call HTMLCollections in V8 bindings as well.
andreas.kling@nokia.com [Fri, 11 Nov 2011 14:37:58 +0000 (14:37 +0000)]
Remove ability to call HTMLCollections in V8 bindings as well.
<http://webkit.org/b/72045>

Reviewed by Anders Carlsson.

Source/WebCore:

Follow the JSC bindings and remove the ability to call HTMLCollections
in the V8 bindings (excluding HTMLAllCollection.)

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderCustomCall):
(GenerateImplementationCustomCall):
* dom/NodeList.idl:
* html/HTMLCollection.idl:

    Remove the V8CustomCall attribute as it's no longer needed.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
* bindings/v8/custom/V8NodeListCustom.cpp:

LayoutTests:

Add a test verifying that calling collections other than document.all
will now throw.

* fast/dom/collection-calling-expected.txt: Added.
* fast/dom/collection-calling.html: Added.
* fast/dom/script-tests/collection-calling.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Interactive color box for gradients in CSS property values
apavlov@chromium.org [Fri, 11 Nov 2011 14:22:42 +0000 (14:22 +0000)]
Web Inspector: Interactive color box for gradients in CSS property values
https://bugs.webkit.org/show_bug.cgi?id=72112

Reviewed by Yury Semikhatsky.

Add "background-image" to the list of color-aware properties (may contain gradient definition).

* inspector/front-end/CSSKeywordCompletions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add missing include to PlatformWebViewQt
vestbo@webkit.org [Fri, 11 Nov 2011 13:47:13 +0000 (13:47 +0000)]
[Qt] Add missing include to PlatformWebViewQt

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Nov 2011 13:40:00 +0000 (13:40 +0000)]
2011-11-11  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Correct test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium baselines after r99941.
tonyg@chromium.org [Fri, 11 Nov 2011 13:34:55 +0000 (13:34 +0000)]
Update chromium baselines after r99941.

That patch changed the number of zooms performed, so it seems to make sense that the
baseline would show a different sized image.

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [chromium] list dedicated workers in case inspector opened post-worker...
yurys@chromium.org [Fri, 11 Nov 2011 13:20:27 +0000 (13:20 +0000)]
Web Inspector: [chromium] list dedicated workers in case inspector opened post-worker creation.
https://bugs.webkit.org/show_bug.cgi?id=72020

Source/WebCore:

Collect information about dedicated workers even when inspector is closed. This
way we can list all dedicated workers if the front-end opens later.

Reviewed by Pavel Feldman.

Test: http/tests/inspector-enabled/dedicated-workers-list.html

* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didStartWorkerContext):
* inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::setFrontend):
(WebCore::InspectorWorkerAgent::restore):
(WebCore::InspectorWorkerAgent::clearFrontend):
(WebCore::InspectorWorkerAgent::setWorkerInspectionEnabled):
(WebCore::InspectorWorkerAgent::didStartWorkerContext):
(WebCore::InspectorWorkerAgent::workerContextTerminated):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):
(WebCore::InspectorWorkerAgent::createWorkerFrontendChannel):
* inspector/InspectorWorkerAgent.h:

LayoutTests:

Reviewed by Pavel Feldman.

* http/tests/inspector-enabled/dedicated-workers-list-expected.txt: Added.
* http/tests/inspector-enabled/dedicated-workers-list.html: Added.
* http/tests/inspector-enabled/resources/dedicated-worker.js: Added.
(doWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add a way to have experimental features in WebKit2
alexis.menard@openbossa.org [Fri, 11 Nov 2011 13:19:06 +0000 (13:19 +0000)]
[Qt] Add a way to have experimental features in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=67707

Reviewed by Kenneth Rohde Christiansen.

.:

Add the new private QML module in the build.

* Source/QtWebKit.pro:

Source/WebKit/qt:

This patch is adding a new module for accessing private
method and property from the view. It requires an import
QtWebKit.private in QML to be used.

* declarative/private/plugin.cpp: Added.
(WebKitQmlPluginPrivate::registerTypes):
* declarative/private/private.pro: Added.
* declarative/private/qmldir: Added.

Source/WebKit2:

Add new QML extensions for our public view. This extension
returns the private object of the view so that the user could
use unstable/unreleased APIs. This requires our private class
to be exported and QObject subclass.

* Target.pri:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebviewprivateextension.cpp: Added.
(QQuickWebViewPrivateExtension::QQuickWebViewPrivateExtension):
(QQuickWebViewPrivateExtension::viewPrivate):
* UIProcess/API/qt/qquickwebviewprivateextension_p.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99950.
yurys@chromium.org [Fri, 11 Nov 2011 13:12:50 +0000 (13:12 +0000)]
Unreviewed, rolling out r99950.
http://trac.webkit.org/changeset/99950
https://bugs.webkit.org/show_bug.cgi?id=72117

"Landed wrong patch by mistake" (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/JavaScriptCore:

* JavaScriptCore.exp:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:

Source/WebCore:

* bindings/js/JSInjectedScriptHostCustom.cpp:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
* inspector/InjectedScript.cpp:
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

* inspector/debugger/function-location-expected.txt: Removed.
* inspector/debugger/function-location.html: Removed.
* platform/chromium/inspector/debugger/function-location-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: function remote objetct should provide access to function position...
yurys@chromium.org [Fri, 11 Nov 2011 13:05:33 +0000 (13:05 +0000)]
Web Inspector: function remote objetct should provide access to function position in the script
https://bugs.webkit.org/show_bug.cgi?id=71808

Source/WebCore:

Added Debugger.getFunctionLocation command for resolving function location including
start line, column and script id.

Reviewed by Pavel Feldman.

Test: inspector/debugger/function-location.html

* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::functionLocation):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::functionLocationCallback):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getFunctionLocation):
* inspector/InjectedScript.h:
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::getFunctionLocation):
* inspector/InspectorDebuggerAgent.h:

LayoutTests:

Added test for Debugger.getFunctionLocation command.

Reviewed by Pavel Feldman.

* inspector/debugger/function-location-expected.txt: Added.
* inspector/debugger/function-location.html: Added.
* platform/chromium/inspector/debugger/function-location-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix incremental builds on Windows after buildsystem refactor
vestbo@webkit.org [Fri, 11 Nov 2011 12:47:33 +0000 (12:47 +0000)]
[Qt] Fix incremental builds on Windows after buildsystem refactor

The qmake rules to ensure that we run make on the derived sources
before running qmake on the target were inside a unix-scope, which
resulted in flakey builds on Windows.

We now generate a rule on all platforms that ensures that "make qmake"
will always run make on the derived sources. In addition, on platforms
that have GNU make (where "make incremental" does not run "make qmake",
but only "make"), we add a similar rule that ensures that any time the
target makefile is regenerated we first run qmake and make on the derived
sources. This rule relies on GNU make's order-only-prerequisites to
not trigger a qmake-run of the target every time we run make.

https://bugs.webkit.org/show_bug.cgi?id=71778

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.
pfeldman@chromium.org [Fri, 11 Nov 2011 12:46:17 +0000 (12:46 +0000)]
Not reviewed: roll out changes to InspectorDOMAgent that squeezed into 99933.

* inspector/InspectorDOMAgent.cpp:
(WebCore::MatchJob::MatchJob):
(WebCore::InspectorDOMAgent::onMatchJobsTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Metrics] Editor is committed when scrolling a content box dimension...
apavlov@chromium.org [Fri, 11 Nov 2011 12:44:24 +0000 (12:44 +0000)]
Web Inspector: [Metrics] Editor is committed when scrolling a content box dimension up/down for the first time
https://bugs.webkit.org/show_bug.cgi?id=72108

Reviewed by Pavel Feldman.

* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._attributesUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Remove QWebNavigationController
hausmann@webkit.org [Fri, 11 Nov 2011 12:40:05 +0000 (12:40 +0000)]
[Qt][WK2] Remove QWebNavigationController
https://bugs.webkit.org/show_bug.cgi?id=72113

Reviewed by Andreas Kling.

Source/WebKit/qt:

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.

Source/WebKit2:

Fold the functions and properties of QWebNavigationController into
QQuickWebView.

* Target.pri:
* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::QQuickWebPagePrivate):
* UIProcess/API/qt/qquickwebpage.h:
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::canStop):
(QQuickWebView::canReload):
(QQuickWebView::title):
* UIProcess/API/qt/qquickwebview.h:
* UIProcess/API/qt/qwebnavigationcontroller.cpp: Removed.
* UIProcess/API/qt/qwebnavigationcontroller.h: Removed.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):

Tools:

Adapt to the move of the QWebNavigationController functions/properties to
QQuickWebView.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build system tweak
hausmann@webkit.org [Fri, 11 Nov 2011 12:33:19 +0000 (12:33 +0000)]
[Qt] Build system tweak

Reviewed by Tor Arne Vestbø.

Be a good qmake citizen, return true from our linkStaticLibrary
"test" function.

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium expectations for new test in r99937.
tonyg@chromium.org [Fri, 11 Nov 2011 12:33:15 +0000 (12:33 +0000)]
Chromium expectations for new test in r99937.

* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-object-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
hclam@chromium.org [Fri, 11 Nov 2011 12:17:24 +0000 (12:17 +0000)]
[chromium] Fix CCLayerTreeHost leak in webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=72081

Patch by James Robinson <jamesr@chromium.org> on 2011-11-11
Reviewed by Kenneth Russell.

LayerChromium and CCLayerTreeHosts hold RefPtr<>s to each other, so if
you do not clear out the layerTreeHost pointer on the LayerChromium
the layer tree is leaked. The real code does this in WebViewImpl but
this test was not.

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] scrolling is broken with compositor thread
hclam@chromium.org [Fri, 11 Nov 2011 12:16:04 +0000 (12:16 +0000)]
[chromium] scrolling is broken with compositor thread
https://bugs.webkit.org/show_bug.cgi?id=72059

Reviewed by James Robinson.

No new test. Existing test CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls checks scroll deltas are applied
on the right layer.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::scrollLayer):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
Instead of calling on the root layer which doesn't have scroll delta applied. Change this to scrollLayer()
which actually has scroll delta.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 11:49:10 +0000 (11:49 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        [Qt] 4 new tests fail introduced in r98852
        https://bugs.webkit.org/show_bug.cgi?id=71253

        Reviewed by Zoltan Herczeg.

        Fix a non-Mac only problem with contain-and-cover-zoomed.html. It zooms out four times, which is ignored on Mac, but respected elsewhere.
        This is the same fix I applied to the svg/zoom/page tests, I forgot this one.

        * fast/backgrounds/size/contain-and-cover-zoomed.html: Don't zoom out more than three times, it's otherwise ignored on Mac/DRT!
        * fast/backgrounds/size/resources/SquirrelFish.svg: Fix typo in XML version, now this shows up in Qt again. Credits to Zoltan Arvai for spotting this.
        * platform/qt/Skipped: Unskip last regression from bug 7153.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99826.
tonyg@chromium.org [Fri, 11 Nov 2011 11:47:13 +0000 (11:47 +0000)]
Unreviewed, rolling out r99826.
http://trac.webkit.org/changeset/99826
https://bugs.webkit.org/show_bug.cgi?id=72109

"Likely causing test flakiness" (Requested by tonyg-cr on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
* tests/data/page_with_image.mht: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add support for QT += webkit-private
hausmann@webkit.org [Fri, 11 Nov 2011 11:37:29 +0000 (11:37 +0000)]
[Qt] Add support for QT += webkit-private

Reviewed by Tor Arne Vestbø.

* qmake/qt_webkit.pri: Declare private headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing media/video-frame-accurate-seek.html expectation after r99887.
tonyg@chromium.org [Fri, 11 Nov 2011 11:02:22 +0000 (11:02 +0000)]
Fixing media/video-frame-accurate-seek.html expectation after r99887.

* platform/chromium-cg-mac-leopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-frame-accurate-seek-expected.png.
* platform/chromium-gpu-mac/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium-gpu/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-gpu-cg-mac/media/video-frame-accurate-seek-expected.png.
* platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Removed.
* platform/chromium/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 09:52:29 +0000 (09:52 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Zooming in SVGs in <object> is flakey
        https://bugs.webkit.org/show_bug.cgi?id=71673

        Reviewed by Zoltan Herczeg.

        Add another minimal testcase using <object> embedding SVGs + zooming.

        * platform/qt/Skipped: Unskip zoom-img-preserveAspectRatio-support-1.html.
        * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
        * svg/zoom/page/resources/zoom-svg-as-object.svg: Added.
        * svg/zoom/page/zoom-svg-as-object.html: Added.

2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Zooming in SVGs in <object> is flakey
        https://bugs.webkit.org/show_bug.cgi?id=71673

        Reviewed by Zoltan Herczeg.

        It turns out zooming in SVGs in <object> wasn't flakey in Safari at all, only in DRT/Mac. In Safari it failed 100% reproducable.
        Scrollbars would always appear when zooming in a HTML document, containing an embedded SVG by <object>/<embed>/<iframe>, even
        though the content would visually fit perfectly, also it zoomed properly. Reloading would make the scrollbars disappear again.

        If scrollbars should be created for a FrameView or not, is determined by ScrollView::updateScrollbars(), by comparing the
        visible size of the scroll view against the contents size. The contents size is propagated to the ScrollView, by
        FrameView::adjustViewSize(), which is called during FrameView::layout(). The size thats propagated is RenderView::documentRect().
        RenderView::documentRect() returns a writing-mode aware layoutOverflowRect(), computed by RenderBox::layoutOverflowRectForPropagation.

        If overflow is "visible", layoutOverflowRect() will return a union of the borderBoxRect() and the layoutOverflowRect(), which
        may exceed the visible size of the RenderView. For standalone SVG documents, the default value for the outermost <svg> renderer is
        "visible". When embedding SVGs through <object>s into a host document, the same code path is taken, and RenderView::documentRect()
        of the embedded SVG document will always return a union of the borderBoxREct() and the layoutOverflowRect().

        If that happens while zooming in a HTML document containing a SVG by <object>, scrollbars are created.
        By ensuring that overflow is treated as hidden, which is what Opera does (and makes sense!) this can't happen.

        The fix is to treat embedded SVGs as they would carry overflow="hidden" on the outermost <svg> renderer. That also makes
        sense as the embedded SVG cant paint outside an external "frame rect" thats given by the FrameView, effectively rendering
        as overflow "hidden" already.

        The fix is realized, by altering the overflow x/y values that are used in FrameView::applyOverflowToViewport(). Previously
        we never called that method for SVG, which was fine. Now we always call applyOverflowToViewport(), but only do something
        if the FrameView of the SVG is embedded in another document. If so, we force overflow to hidden.

        That fixes all zooming+<object> related flakiness seen on the chromium bots, most noticeable, without other side effects.
        All svg/overflow tests, still work as expected.

        Test: svg/zoom/page/zoom-svg-as-object.html

        * page/Frame.cpp:
        (WebCore::Frame::setPageAndTextZoomFactors): Remove unnecessary setNeedsLayout() call in SVG builds.
        * page/FrameView.cpp:
        (WebCore::FrameView::applyOverflowToViewport): Always enforce overflow=hidden, when embedding SVGs through object/embed/iframe.
                                                       Otherwise scrollbars will appear, even though the contents would fit without them.
        (WebCore::FrameView::calculateScrollbarModesForLayout): Always call applyOverflowToViewport, even for RenderSVGRoot. It only has
                                                                an effect though, when the FrameView of the SVG is embedded through <object>/etc.
        (WebCore::FrameView::layout): Remove unnecessary setChildNeedsLayout() call.
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::isEmbeddedThroughFrameContainingSVGDocument): Fix this function, its meaning was reversed before!
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): Fix logical error, by negating the result of isEmbeddedThroughFrameContainingSVGDocument.
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
        * rendering/svg/RenderSVGRoot.h: Expose isEmbeddedThroughFrameContainingSVGDocument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 11 Nov 2011 09:44:39 +0000 (09:44 +0000)]
2011-11-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Unbreak my 32bit SL build.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateOrRemoveFilterEffect): Use narrowPrecisionToFloat() to convert float -> double.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix attempt after r99907. Since that revision
philn@webkit.org [Fri, 11 Nov 2011 09:03:42 +0000 (09:03 +0000)]
Unreviewed, build fix attempt after r99907. Since that revision
GTK layout tests were not running at all...

* Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHRTF Database consolidation
philn@webkit.org [Fri, 11 Nov 2011 08:40:02 +0000 (08:40 +0000)]
HRTF Database consolidation
https://bugs.webkit.org/show_bug.cgi?id=69703

Reviewed by Kenneth Russell.

Access to the consolidated parts of the HRTF database by segmented
chunks. A concatenated Composite HRTF database is provided in
Composite.wav. Additionnally a new build step that concatenates
the platform/audio/resources/ files into one (sox can be used for
this) can be configured for specific ports.

* platform/audio/HRTFDatabase.h:
* platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
* platform/audio/resources/Composite.wav: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: provide an id to the root inspector element for third party UA styling.
pfeldman@chromium.org [Fri, 11 Nov 2011 08:37:35 +0000 (08:37 +0000)]
Web Inspector: provide an id to the root inspector element for third party UA styling.
https://bugs.webkit.org/show_bug.cgi?id=72094

Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for !ENABLE(JIT) after r99898.
paroga@webkit.org [Fri, 11 Nov 2011 08:11:15 +0000 (08:11 +0000)]
Unreviewed. Build fix for !ENABLE(JIT) after r99898.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.
yutak@chromium.org [Fri, 11 Nov 2011 07:39:41 +0000 (07:39 +0000)]
[Chromium] Unreviewed, add Linux baselines I forgot to commit in the last rebaseline.

* platform/chromium-linux/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-linux/svg/as-background-image/svg-as-background-3-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKitCSSShaderValue.h is not a member of the WebCore target
aestes@apple.com [Fri, 11 Nov 2011 07:23:31 +0000 (07:23 +0000)]
WebKitCSSShaderValue.h is not a member of the WebCore target
https://bugs.webkit.org/show_bug.cgi?id=72093

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj: Make WebKitCSSShaderValue.h a
member of the WebCore target, and make it a project header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisabling assertions breaks the debug build
mitz@apple.com [Fri, 11 Nov 2011 07:08:46 +0000 (07:08 +0000)]
Disabling assertions breaks the debug build
https://bugs.webkit.org/show_bug.cgi?id=72091

Reviewed by Geoff Garen.

Source/JavaScriptCore:

* dfg/DFGNode.h: Made hasIdentifier() available when assertions are
disabled. It is used in Graph::dump().
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Update m_isCheckingForDefaultMarkViolation
only if assertions are enabled.
* wtf/Deque.h:
(WTF::::checkIndexValidity): Changed ASSERT to ASSERT_UNUSED.
* wtf/ThreadRestrictionVerifier.h:
(WTF::ThreadRestrictionVerifier::setShared): Guarded the definition of
a local variable that is only used in an assertion.

Source/WebCore:

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::didDecodeProperties): Guarded the definition of local variables that are
only used in an assertion correctly.
* platform/graphics/gpu/TilingData.h: Changed ASSERT to ASSERT_UNUSED.
(WebCore::TilingData::assertTile):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed): Guarded the definition of a local variable that is
only used in an assertion correctly.
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyResource): Changed ASSERT to ASSERT_UNUSED.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource): Changed ASSERT to ASSERT_UNUSED.
(WebCore::RenderSVGResourceFilter::postApplyResource): Changed ASSERT to ASSERT_UNUSED.
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource): Changed ASSERT to ASSERT_UNUSED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7...
yutak@chromium.org [Fri, 11 Nov 2011 06:53:19 +0000 (06:53 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 7, the final)

* platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-background-image/svg-as-background-3-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-cg-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-cg-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png:
* platform/chromium-mac-leopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-3-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Added.
* platform/chromium-mac/svg/as-background-image/svg-as-background-1-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/svg-as-background-3-expected.png: Removed.
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSString forgets to clear m_fibers when resolving ropes
fpizlo@apple.com [Fri, 11 Nov 2011 06:39:54 +0000 (06:39 +0000)]
JSString forgets to clear m_fibers when resolving ropes
https://bugs.webkit.org/show_bug.cgi?id=72089

Reviewed by Geoff Garen.

* runtime/JSString.cpp:
(JSC::JSString::resolveRopeSlowCase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed morning gardening after r99862.
ossy@webkit.org [Fri, 11 Nov 2011 06:28:49 +0000 (06:28 +0000)]
[Qt] Unreviewed morning gardening after r99862.

* platform/qt/svg/foreignObject/background-render-phase-expected.png: Added.
* platform/qt/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
dcheng@chromium.org [Fri, 11 Nov 2011 04:13:25 +0000 (04:13 +0000)]
[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
https://bugs.webkit.org/show_bug.cgi?id=71414

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no new functionality enabled yet.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebClipboard.h:
(WebKit::WebClipboard::writeDataObject):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardWriteDataObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAtomically update the system clipboard for copy/cut events
dcheng@chromium.org [Fri, 11 Nov 2011 04:12:14 +0000 (04:12 +0000)]
Atomically update the system clipboard for copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=40515

Reviewed by David Levin.

This change consolidates the system pasteboard mutation logic into dispatchCPPEvent() rather
than having it scattered throughout tryDHTMLCopy/tryDHTMLCut and the various Clipboard*
classes. This allows us to ensure that the system pasteboard remains in a consistent state
even if there's an exception thrown during event handling, and it also lays the ground work
for allowing pages to prevent copy/cut without causing the system pasteboard to be cleared.

No new tests, since any layout test would be flaky since it would depend on and affect
global system state.

* editing/Editor.cpp:
(WebCore::Editor::tryDHTMLCopy): Move Pasteboard::clear() call to dispatchCPPEvent().
(WebCore::Editor::tryDHTMLCut): Ditto.
(WebCore::Editor::dispatchCPPEvent):
Only persist Clipboard mutations to the system pasteboard if the event was dispatched
successfully and default processing was prevented.
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard):
When creating a Clipboard for copy/cut, back it with a unique instance of NSPasteboard to
buffer pasteboard mutations.
* platform/Pasteboard.h:
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardGtk.
(WebCore::ClipboardGtk::setData):
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::clipboard):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard):
Implement logic to flush data from temporary NSPasteboard to system pasteboard.
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardQt.
(WebCore::ClipboardGtk::setData):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::writeClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines after r99902.
ojan@chromium.org [Fri, 11 Nov 2011 02:15:44 +0000 (02:15 +0000)]
Chromium rebaselines after r99902.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99916.
hayato@chromium.org [Fri, 11 Nov 2011 02:10:20 +0000 (02:10 +0000)]
Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

* platform/chromium/fast/harness/results-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] only run media GPU layout tests on platforms supporting accelerated compos...
scherkus@chromium.org [Fri, 11 Nov 2011 01:45:57 +0000 (01:45 +0000)]
[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableSection's recalcCell logic is doing too much work
jchaffraix@webkit.org [Fri, 11 Nov 2011 01:41:26 +0000 (01:41 +0000)]
RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT when outdenting styled line break.
enrica@apple.com [Fri, 11 Nov 2011 01:26:32 +0000 (01:26 +0000)]
ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.

Test: editing/execCommand/outdent-break-with-style.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.
* editing/htmlediting.cpp:
(WebCore::isInline): Added.
* editing/htmlediting.h: Added isInline.

LayoutTests:

* editing/execCommand/outdent-break-with-style-expected.txt: Added.
* editing/execCommand/outdent-break-with-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG byte array support sometimes clamps values incorrectly
fpizlo@apple.com [Fri, 11 Nov 2011 01:07:44 +0000 (01:07 +0000)]
DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests:

Reviewed by Oliver Hunt.

Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

* fast/js/dfg-byte-array-put-expected.txt: Added.
* fast/js/dfg-byte-array-put.html: Added.
* fast/js/script-tests/dfg-byte-array-put.js: Added.
(doPut):
(doGet):
* fast/js/script-tests/dfg-min-max.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, revert a misplaced expected text in r99819.
hayato@chromium.org [Fri, 11 Nov 2011 00:50:58 +0000 (00:50 +0000)]
Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

* platform/chromium/fast/harness/results-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnce more for the QT build.
bdakin@apple.com [Fri, 11 Nov 2011 00:36:48 +0000 (00:36 +0000)]
Once more for the QT build.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setFindIndicator):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore attempted build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:33:23 +0000 (00:33 +0000)]
More attempted build fix.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix 32-bit build.
andersca@apple.com [Fri, 11 Nov 2011 00:32:33 +0000 (00:32 +0000)]
Fix 32-bit build.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer drawInContext:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:28:42 +0000 (00:28 +0000)]
Speculative build fix.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=66584
bdakin@apple.com [Fri, 11 Nov 2011 00:06:02 +0000 (00:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take
an additional parameter indicating whether or not setting the find indicator
should result in a bounce animation. This is because when the device scale factor
changes, if there is currently a find indicator, it must be re-set to a higher or
lower resolution version, but we don't want the bounce animation to happen again.
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if
FindController::deviceScaleFactorDidChange() needs to be called.
* WebProcess/WebPage/FindController.h:
(WebKit::FindController::isShowingOverlay):

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the
FindIndicator should animate. It defaults to true since the deviceScaleFactor
changing is the only case currently where we do not want it to animate.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has
changed and the find overlay is showing.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValueProfile/PredictedType contains dead code, and doesn't recognize functions
fpizlo@apple.com [Thu, 10 Nov 2011 23:59:31 +0000 (23:59 +0000)]
ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.

Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isFunctionPrediction):
* bytecode/ValueProfile.cpp:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobencher script should support remote benchmarking
fpizlo@apple.com [Thu, 10 Nov 2011 23:47:29 +0000 (23:47 +0000)]
bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.

Added the following features:

- Benchmark report tells you the hostname and machine model (according to
  'sysctl hw.model') of the machine you did the run on, and svn revision number
  (according to 'svn info') of the VMs you're testing.

- The --remote option. You give this an ssh-style hostname (i.e. user@host is
  acceptable, in addition to just host, in which case your username is used)
  and it automatically packages the build directories of the VMs you're testing,
  sends them to the remote machine along with your copy of the bencher script
  and all of the options you passed.  This pretty much seamlessly allows you
  to run a set of benchmarks on any machine that is sufficiently compatible with
  yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
  must now include a tempPath setting that tells bencher where to put files
  when that machine is used as a slave in a remote benchmarking run.

- Added yet another way of specifying which benchmarks to run. This was sort of
  necessary for --remote to work as expected. Previously, you either said what
  suites to exclude (for example --exclude-sunspider) or that you only wanted
  to run one suite to the exclusion of others (--sunspider-only). But it's
  often better to just be able to specify the list of suites you want. This is
  now supported. You can say, for example, --v8 --sunspider, which means, just
  run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
  still supported.

* Scripts/bencher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLazily start DRT instances in NRWT
tony@chromium.org [Thu, 10 Nov 2011 23:31:45 +0000 (23:31 +0000)]
Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAM...
ddkilzer@apple.com [Thu, 10 Nov 2011 23:31:31 +0000 (23:31 +0000)]
<webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

* JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js
script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation.  Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi...
dino@apple.com [Thu, 10 Nov 2011 23:11:15 +0000 (23:11 +0000)]
Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

* rendering/FilterEffectRenderer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99905 268f45cc-cd09-0410-ab3c-d52691b4dbfc