WebKit-https.git
8 years agoUnreviewed, rolling out r111094.
tony@chromium.org [Sat, 17 Mar 2012 01:29:39 +0000 (01:29 +0000)]
Unreviewed, rolling out r111094.
http://trac.webkit.org/changeset/111094
https://bugs.webkit.org/show_bug.cgi?id=80882

broke test on chromium-win

Source/WebCore:

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/child-overflow-expected.html:
* css3/flexbox/child-overflow.html:
* css3/flexbox/flex-align-stretch-expected.txt:
* css3/flexbox/flex-align-stretch.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r110737): Height element changes on scrolled page causes failure
andersca@apple.com [Sat, 17 Mar 2012 01:21:14 +0000 (01:21 +0000)]
REGRESSION (r110737): Height element changes on scrolled page causes failure
https://bugs.webkit.org/show_bug.cgi?id=81381
<rdar://problem/11066006>

Reviewed by Sam Weinig.

Limit the fix made in r110737 to check if there's a rubber-band gesture in progress and only ignore the range if that is the case.

* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::isRubberBandInProgress):
(ScrollAnimator):
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
* platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::isRubberBandInProgress):
(WebCore):
* platform/mac/ScrollElasticityController.h:
(ScrollElasticityController):
* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::isRubberBandInProgress):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGestureTapDown needs to pin in-progress flings
commit-queue@webkit.org [Sat, 17 Mar 2012 00:52:17 +0000 (00:52 +0000)]
GestureTapDown needs to pin in-progress flings
https://bugs.webkit.org/show_bug.cgi?id=80875

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

* page/EventHandler.cpp:
(WebCore):
(WebCore::EventHandler::handleGestureTapDown):
* page/EventHandler.h:
(EventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccount for sample-rate in convolution normalization
crogers@google.com [Sat, 17 Mar 2012 00:49:27 +0000 (00:49 +0000)]
Account for sample-rate in convolution normalization
https://bugs.webkit.org/show_bug.cgi?id=81432

Reviewed by James Robinson.

* platform/audio/Reverb.cpp:
(WebCore):
(WebCore::calculateNormalizationScale):
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
commit-queue@webkit.org [Sat, 17 Mar 2012 00:41:19 +0000 (00:41 +0000)]
[BlackBerry] Rename the existing WebPageCompositor class to WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81108
RIM PR: 136687

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is done in anticipation of a new WebPageCompositor class in the
public API. The existing internal class will serve to d-pointerize the
new public API. In addition, it is and will be possible to create only
the private class, for cases where existing code paths require
OpenGL compositing (i.e. due to accelerated compositing layers being
added to the page).

Reviewed internally by Robin Cao.

* Api/BackingStore.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setIsAcceleratedCompositingActive):
* Api/WebPageCompositor.cpp: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.cpp.
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::~WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::hardwareCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setRootLayer):
(BlackBerry::WebKit::WebPageCompositorPrivate::setBackingStoreUsesOpenGL):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::releaseLayerResources):
(BlackBerry::WebKit::WebPageCompositorPrivate::animationTimerFired):
* Api/WebPageCompositor_p.h: Renamed from Source/WebKit/blackberry/WebKitSupport/WebPageCompositor.h.
(BlackBerry::WebKit::WebPageCompositorPrivate::layoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLayoutRectForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::contentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContentsSizeForCompositing):
(BlackBerry::WebKit::WebPageCompositorPrivate::lastCompositingResults):
(BlackBerry::WebKit::WebPageCompositorPrivate::setLastCompositingResults):
* Api/WebPage_p.h:
* CMakeListsBlackBerry.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake V8 window.open.call(), window.open.showModalDialog() results more closely match...
tsepez@chromium.org [Sat, 17 Mar 2012 00:31:22 +0000 (00:31 +0000)]
Make V8 window.open.call(), window.open.showModalDialog() results more closely match JSC.
https://bugs.webkit.org/show_bug.cgi?id=81260
https://bugs.webkit.org/show_bug.cgi?id=39897

Reviewed by Adam Barth.

Source/WebCore:

Tested via http/tests/security/cross-frame-access-call.htm

* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::showModalDialogCallback):
(WebCore::V8DOMWindow::openCallback):

LayoutTests:

* http/tests/security/cross-frame-access-call-expected.txt:
* http/tests/security/cross-frame-access-call.html:
* http/tests/security/cross-frame-access-get-expected.txt:
* http/tests/security/cross-frame-access-get.html:
* platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
* platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=81065
slewis@apple.com [Sat, 17 Mar 2012 00:29:38 +0000 (00:29 +0000)]
Source/WebKit2: https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Add some string function exports to Windows so the WebKitTestRunner can use them.

Reviewed by Geoff Garen.

* win/WebKit2.def:

Tools: https://bugs.webkit.org/show_bug.cgi?id=81065
<rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
Fix crash preventing WebKitTestRunner from working in Release.
WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.

I removed ostringstream in favor of StringBuilder.

Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.

Reviewed by Geoff Garen.

Add DEBUG_DEFINES to set NDEBUG on release builds.
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Remove ostringstream member in favor of StringBuilder.
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
(WTR::InjectedBundle::done):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTF):
(WTR::InjectedBundle::stringBuilder):
(InjectedBundle):

Append output to StringBuilder.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::hasPrefix):
(WTR::dumpPath):
(WTR::rangeToStr):
(WTR::styleDecToStr):
(WTR::frameToStr):
(WTR::dumpFrameScrollPosition):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):
(WTR::InjectedBundlePage::dump):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::decidePolicyForNavigationAction):
(WTR::lastFileURLPathComponent):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
(WTR::InjectedBundlePage::supportsFullScreen):
(WTR::InjectedBundlePage::enterFullScreenForElement):
(WTR::InjectedBundlePage::exitFullScreenForElement):
(WTR::InjectedBundlePage::beganEnterFullScreen):
(WTR::InjectedBundlePage::beganExitFullScreen):
(WTR::dumpBackForwardListItem):
(WTR::InjectedBundlePage::dumpBackForwardList):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
(WTR::LayoutTestController::dumpConfigurationForViewport):

Convert between WTF::String and WKStringRef.
* WebKitTestRunner/StringFunctions.h:
(WTR::toWTFString):
(WTR):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse modern NSNumberFormatter API in LocalizedNumberMac.mm
mlilek@apple.com [Sat, 17 Mar 2012 00:27:49 +0000 (00:27 +0000)]
Use modern NSNumberFormatter API in LocalizedNumberMac.mm
https://bugs.webkit.org/show_bug.cgi?id=81429

Reviewed by Dan Bernstein.

No new tests as no change in behavior.

* platform/text/mac/LocalizedNumberMac.mm:
(WebCore::createFormatterForCurrentLocaleForDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a land-from-url command
eric@webkit.org [Sat, 17 Mar 2012 00:19:11 +0000 (00:19 +0000)]
Add a land-from-url command
https://bugs.webkit.org/show_bug.cgi?id=81411

Reviewed by Adam Barth.

Very basic so far.  The goal is to make it landing smarter
so that users don't have to bother to parse out the ids out of the urls.

* Scripts/webkitpy/common/config/urls.py:
(parse_bug_id):
(parse_attachment_id):
* Scripts/webkitpy/common/config/urls_unittest.py:
(URLsTest.test_parse_bug_id):
(URLsTest):
(URLsTest.test_parse_attachment_id):
* Scripts/webkitpy/tool/commands/download.py:
(ProcessURLsMixin):
(ProcessURLsMixin._fetch_list_of_patches_to_process):
(LandFromURL):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_from_bug):
(test_land_from_url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoflex-item-align: stretch should only grow, never shrink
tony@chromium.org [Sat, 17 Mar 2012 00:16:37 +0000 (00:16 +0000)]
flex-item-align: stretch should only grow, never shrink
https://bugs.webkit.org/show_bug.cgi?id=80882

Reviewed by Ojan Vafai.

Source/WebCore:

New test cases in css3/flexbox/flex-align-stretch.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::alignChildren): Move stretch code into a separate function.
(WebCore::RenderFlexibleBox::alignChildStretch): Add an early return if our height is shrinking.
(WebCore):
* rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):

LayoutTests:

* css3/flexbox/child-overflow-expected.html:
* css3/flexbox/child-overflow.html: For cases that overflow the height, we now just overflow rather than reducing the height.
* css3/flexbox/flex-align-stretch-expected.txt:
* css3/flexbox/flex-align-stretch.html: New test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobuild-webkit launcher instructions use wrong relative path for Qt
commit-queue@webkit.org [Sat, 17 Mar 2012 00:13:06 +0000 (00:13 +0000)]
build-webkit launcher instructions use wrong relative path for Qt
https://bugs.webkit.org/show_bug.cgi?id=81357

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-03-16
Reviewed by Eric Seidel.

Ensure we are at the proper directory before generating run-launcher
instructions.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, fix build after r111041.
kubo@profusion.mobi [Sat, 17 Mar 2012 00:10:02 +0000 (00:10 +0000)]
[EFL] Unreviewed, fix build after r111041.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::emitMediaButtonSignal): Rename
MediaFullscreenButton to MediaEnterFullscreenButton.
(WebCore::RenderThemeEfl::paintMediaFullscreenButton): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd layout tests that accidentally got left out of r111061
dcheng@chromium.org [Fri, 16 Mar 2012 23:49:40 +0000 (23:49 +0000)]
Add layout tests that accidentally got left out of r111061

* fast/events/clipboard-dataTransferItemList-expected.txt: Added.
* fast/events/clipboard-dataTransferItemList.html: Added.
* fast/events/drag-dataTransferItemList-expected.txt: Added.
* fast/events/drag-dataTransferItemList.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
dslomov@google.com [Fri, 16 Mar 2012 23:49:29 +0000 (23:49 +0000)]
REGRESSION: DOMURL::revokeObjectURL accesses memoryCache on worker thread.
https://bugs.webkit.org/show_bug.cgi?id=80889
On worker threads, post a task to main thread to evict from cache.
ASSERT that MemoryCache is only accessed from main thread.

Reviewed by David Levin.

* html/DOMURL.cpp:
(WebCore::DOMURL::revokeObjectURL):
* loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
(WebCore):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeUrlFromCacheImpl):
* loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
commit-queue@webkit.org [Fri, 16 Mar 2012 23:47:05 +0000 (23:47 +0000)]
[BlackBerry] Upstream ScriptControllerBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=81397

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Initial upstream, no new tests.

* bindings/js/ScriptControllerBlackBerry.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to...
commit-queue@webkit.org [Fri, 16 Mar 2012 23:46:15 +0000 (23:46 +0000)]
[BlackBerry] Syncing up left over bits in WebKitSupport from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81118

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spannableTextInRange):
* WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::createBuffers):
(BlackBerry::WebKit::SurfacePool::releaseBuffers):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
* WebKitSupport/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
* WebKitSupport/WebPageCompositor.h:
(WebPageCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoremove-body-during-body-replacement2.html is triggering crashes on all platforms
abarth@webkit.org [Fri, 16 Mar 2012 23:41:23 +0000 (23:41 +0000)]
remove-body-during-body-replacement2.html is triggering crashes on all platforms
https://bugs.webkit.org/show_bug.cgi?id=81374

Reviewed by Eric Seidel.

When overriding disconnectFrame, we need to call the base class version
of the method so that it can clear the m_frame pointer.

Tests: This patch fixes a large number of crashes in tests.

* notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
leo.yang@torchmobile.com.cn [Fri, 16 Mar 2012 23:27:03 +0000 (23:27 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/Widget.h
https://bugs.webkit.org/show_bug.cgi?id=81304

Reviewed by Rob Buis.

typedefs of PlatformWidget and PlatformPageClient for the BlackBerry.

* platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMathML internals - factor code for almost anonymous blocks
commit-queue@webkit.org [Fri, 16 Mar 2012 23:12:37 +0000 (23:12 +0000)]
MathML internals - factor code for almost anonymous blocks
https://bugs.webkit.org/show_bug.cgi?id=81387

Patch by David Barton <dbarton@mathscribe.com> on 2012-03-16
Reviewed by Eric Seidel.

Source/WebCore:

MathML uses "almost anonymous" blocks to layout parts of mathematical expressions. These
will be converted to true anonymous blocks in a later patch. Here we factor out the code
to create them into RenderMathMLBlock::createAlmostAnonymousBlock().

No new tests. Some tree dump output is modified for existing tests. <munder>, <mover>,
and <munderover> renderers already used true anonymous blocks, so we change them to call
RenderBlock::createAnonymousBlock(). In the other direction, <mroot>'s almost anonymous
blocks are now made RenderMathMLBlock not just RenderBlock, in agreement with other
current MathML renderers.

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):
* rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):
* rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::addChild):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
    - improve some variable names
(WebCore::RenderMathMLFraction::addChild):
(WebCore::RenderMathMLFraction::layout):
(WebCore::RenderMathMLFraction::paint):
(WebCore::RenderMathMLFraction::baselinePosition):
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::addChild):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
* rendering/mathml/RenderMathMLSubSup.h:
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::addChild):

LayoutTests:

* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrepare RenderObject for FractionalLayoutUnits
leviw@chromium.org [Fri, 16 Mar 2012 23:05:34 +0000 (23:05 +0000)]
Prepare RenderObject for FractionalLayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=81178

Reviewed by Eric Seidel.

This readies RenderObject to deal with FractionalLayoutUnits as a backend for the
LayoutUnit abstraction.

No new tests. No change in behavior.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::pixelSnappedAbsoluteClippedOverflowRect): Convenience method to be
used instead of absouluteClippedOverflowRect in platform code. Platform updates will come
in a separate patch.
(WebCore):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Borders remain ints when we move to
sub-pixel layout. This adjusts border variables for this, and adds compiler fixes when
using std::max and std::min with mixed int/LayoutUnits.
(WebCore::RenderObject::adjustRectForOutlineAndShadow): Outlines, like borders, remain
ints in the new sub-pixel world. Using variables that reflect that.
* rendering/RenderObject.h:
(RenderObject):
(WebCore::adjustForAbsoluteZoom): Handles FractionalLayoutUnit values. Flooring is what
JavaScript requires since this is used with values that must return ints.
(WebCore): Adding FractionalLayoutUnit.h to support the new adjusteForAbsoluteZoom method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSIO...
beidson@apple.com [Fri, 16 Mar 2012 22:29:59 +0000 (22:29 +0000)]
<rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412 REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted

Reviewed by Geoff Garen.

Source/WebCore:

WebKit API test WebViewCanPasteURL.mm added.

* WebCore.exp.in:

Add a strategy method specifically for getting the URL:
* platform/PasteboardStrategy.h:

Use that strategy method when creating the fragment for a URL:
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::documentFragment):

Add a platform pasteboard accessor to "do the right thing" for getting a URL:
* platform/PlatformPasteboard.h:
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::url):

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::setInsertionPasteboard):
* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::url):

Source/WebKit2:

Add new message so the WebProcess can ask the UIProcesses pasteboard for the URL:
* UIProcess/WebContext.h:
* UIProcess/WebContext.messages.in:
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::getPasteboardURL):

Use that new message to implement the pasteboard strategy:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::url):
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/81380> clang warning unused variable when ENABLE(TEXT_CARET...
commit-queue@webkit.org [Fri, 16 Mar 2012 22:26:59 +0000 (22:26 +0000)]
<webkit.org/b/81380> clang warning unused variable when ENABLE(TEXT_CARET) is disabled

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-16
Reviewed by Dan Bernstein.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):
Put the variable inside of a guard because it is only
used inside of a guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some tests that broke with r111042.
ojan@chromium.org [Fri, 16 Mar 2012 22:23:43 +0000 (22:23 +0000)]
Fix some tests that broke with r111042.

* platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-linux/compositing/absolute-position-changed-with-composited-parent-layer-expected.png: Added.
* platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
* platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Removed.
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark wontfix tests in full_results.json so we can ignore them in garden-o-matic
ojan@chromium.org [Fri, 16 Mar 2012 22:19:53 +0000 (22:19 +0000)]
Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=81407

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest):
(ResultSummaryTest.test_summarized_results_wontfix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink BorderValue.
kling@webkit.org [Fri, 16 Mar 2012 22:03:26 +0000 (22:03 +0000)]
Shrink BorderValue.
<http://webkit.org/b/69521>

Reviewed by Anders Carlsson.

Split BorderValue's Color member into RGBA32/bool buddies and stash the bool in
the BorderValue bitfield.

This shrinks BorderValue by 4 bytes, in turn shrinking BorderData by 16 bytes.
Altogether this yields ~800 kB in reduced memory consumption when viewing the full
HTML5 spec at <http://whatwg.org/c>

* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(BorderValue):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):
* rendering/style/RenderStyle.cpp:
(SameSizeAsBorderValue):
* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMoves remaining filesystem files to Modules/filesystem/
commit-queue@webkit.org [Fri, 16 Mar 2012 22:00:09 +0000 (22:00 +0000)]
Moves remaining filesystem files to Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81353

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/filesystem/AsyncFileWriter.h: Copied from Source/WebCore/fileapi/AsyncFileWriter.h.
* Modules/filesystem/AsyncFileWriterClient.h: Copied from Source/WebCore/fileapi/AsyncFileWriterClient.h.
* Modules/filesystem/DOMFilePath.cpp: Copied from Source/WebCore/fileapi/DOMFilePath.cpp.
* Modules/filesystem/DOMFilePath.h: Copied from Source/WebCore/fileapi/DOMFilePath.h.
* Modules/filesystem/DOMFileSystem.cpp: Copied from Source/WebCore/fileapi/DOMFileSystem.cpp.
* Modules/filesystem/DOMFileSystem.h: Copied from Source/WebCore/fileapi/DOMFileSystem.h.
* Modules/filesystem/DOMFileSystem.idl: Copied from Source/WebCore/fileapi/DOMFileSystem.idl.
* Modules/filesystem/DOMFileSystemBase.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemBase.cpp.
* Modules/filesystem/DOMFileSystemBase.h: Copied from Source/WebCore/fileapi/DOMFileSystemBase.h.
* Modules/filesystem/DOMFileSystemSync.cpp: Copied from Source/WebCore/fileapi/DOMFileSystemSync.cpp.
* Modules/filesystem/DOMFileSystemSync.h: Copied from Source/WebCore/fileapi/DOMFileSystemSync.h.
* Modules/filesystem/DOMFileSystemSync.idl: Copied from Source/WebCore/fileapi/DOMFileSystemSync.idl.
* Modules/filesystem/Entry.cpp: Copied from Source/WebCore/fileapi/Entry.cpp.
* Modules/filesystem/Entry.h: Copied from Source/WebCore/fileapi/Entry.h.
* Modules/filesystem/Entry.idl: Copied from Source/WebCore/fileapi/Entry.idl.
* Modules/filesystem/EntryArray.cpp: Copied from Source/WebCore/fileapi/EntryArray.cpp.
* Modules/filesystem/EntryArray.h: Copied from Source/WebCore/fileapi/EntryArray.h.
* Modules/filesystem/EntryArray.idl: Copied from Source/WebCore/fileapi/EntryArray.idl.
* Modules/filesystem/EntryArraySync.cpp: Copied from Source/WebCore/fileapi/EntryArraySync.cpp.
* Modules/filesystem/EntryArraySync.h: Copied from Source/WebCore/fileapi/EntryArraySync.h.
* Modules/filesystem/EntryArraySync.idl: Copied from Source/WebCore/fileapi/EntryArraySync.idl.
* Modules/filesystem/EntryBase.cpp: Copied from Source/WebCore/fileapi/EntryBase.cpp.
* Modules/filesystem/EntryBase.h: Copied from Source/WebCore/fileapi/EntryBase.h.
* Modules/filesystem/EntryCallback.h: Copied from Source/WebCore/fileapi/EntryCallback.h.
* Modules/filesystem/EntryCallback.idl: Copied from Source/WebCore/fileapi/EntryCallback.idl.
* Modules/filesystem/EntrySync.cpp: Copied from Source/WebCore/fileapi/EntrySync.cpp.
* Modules/filesystem/EntrySync.h: Copied from Source/WebCore/fileapi/EntrySync.h.
* Modules/filesystem/EntrySync.idl: Copied from Source/WebCore/fileapi/EntrySync.idl.
* Modules/filesystem/ErrorCallback.h: Copied from Source/WebCore/fileapi/ErrorCallback.h.
* Modules/filesystem/ErrorCallback.idl: Copied from Source/WebCore/fileapi/ErrorCallback.idl.
* Modules/filesystem/FileCallback.h: Copied from Source/WebCore/fileapi/FileCallback.h.
* Modules/filesystem/FileCallback.idl: Copied from Source/WebCore/fileapi/FileCallback.idl.
* Modules/filesystem/FileEntry.cpp: Copied from Source/WebCore/fileapi/FileEntry.cpp.
* Modules/filesystem/FileEntry.h: Copied from Source/WebCore/fileapi/FileEntry.h.
* Modules/filesystem/FileEntry.idl: Copied from Source/WebCore/fileapi/FileEntry.idl.
* Modules/filesystem/FileEntrySync.cpp: Copied from Source/WebCore/fileapi/FileEntrySync.cpp.
* Modules/filesystem/FileEntrySync.h: Copied from Source/WebCore/fileapi/FileEntrySync.h.
* Modules/filesystem/FileEntrySync.idl: Copied from Source/WebCore/fileapi/FileEntrySync.idl.
* Modules/filesystem/FileSystemCallback.h: Copied from Source/WebCore/fileapi/FileSystemCallback.h.
* Modules/filesystem/FileSystemCallback.idl: Copied from Source/WebCore/fileapi/FileSystemCallback.idl.
* Modules/filesystem/FileSystemCallbacks.cpp: Copied from Source/WebCore/fileapi/FileSystemCallbacks.cpp.
* Modules/filesystem/FileSystemCallbacks.h: Copied from Source/WebCore/fileapi/FileSystemCallbacks.h.
* Modules/filesystem/FileWriter.cpp: Copied from Source/WebCore/fileapi/FileWriter.cpp.
* Modules/filesystem/FileWriter.h: Copied from Source/WebCore/fileapi/FileWriter.h.
* Modules/filesystem/FileWriter.idl: Copied from Source/WebCore/fileapi/FileWriter.idl.
* Modules/filesystem/FileWriterBase.cpp: Copied from Source/WebCore/fileapi/FileWriterBase.cpp.
* Modules/filesystem/FileWriterBase.h: Copied from Source/WebCore/fileapi/FileWriterBase.h.
* Modules/filesystem/FileWriterBaseCallback.h: Copied from Source/WebCore/fileapi/FileWriterBaseCallback.h.
* Modules/filesystem/FileWriterCallback.h: Copied from Source/WebCore/fileapi/FileWriterCallback.h.
* Modules/filesystem/FileWriterCallback.idl: Copied from Source/WebCore/fileapi/FileWriterCallback.idl.
* Modules/filesystem/FileWriterSync.cpp: Copied from Source/WebCore/fileapi/FileWriterSync.cpp.
* Modules/filesystem/FileWriterSync.h: Copied from Source/WebCore/fileapi/FileWriterSync.h.
* Modules/filesystem/FileWriterSync.idl: Copied from Source/WebCore/fileapi/FileWriterSync.idl.
* Modules/filesystem/LocalFileSystem.cpp: Copied from Source/WebCore/fileapi/LocalFileSystem.cpp.
* Modules/filesystem/LocalFileSystem.h: Copied from Source/WebCore/fileapi/LocalFileSystem.h.
* Modules/filesystem/Metadata.h: Copied from Source/WebCore/fileapi/Metadata.h.
* Modules/filesystem/Metadata.idl: Copied from Source/WebCore/fileapi/Metadata.idl.
* Modules/filesystem/MetadataCallback.h: Copied from Source/WebCore/fileapi/MetadataCallback.h.
* Modules/filesystem/MetadataCallback.idl: Copied from Source/WebCore/fileapi/MetadataCallback.idl.
* Modules/filesystem/SyncCallbackHelper.h: Copied from Source/WebCore/fileapi/SyncCallbackHelper.h.
* Modules/filesystem/WebKitFlags.h: Copied from Source/WebCore/fileapi/WebKitFlags.h.
* Modules/filesystem/WorkerContextFileSystem.cpp: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.cpp.
* Modules/filesystem/WorkerContextFileSystem.h: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.h.
* Modules/filesystem/WorkerContextFileSystem.idl: Copied from Source/WebCore/fileapi/WorkerContextFileSystem.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/AsyncFileWriter.h: Removed.
* fileapi/AsyncFileWriterClient.h: Removed.
* fileapi/DOMFilePath.cpp: Removed.
* fileapi/DOMFilePath.h: Removed.
* fileapi/DOMFileSystem.cpp: Removed.
* fileapi/DOMFileSystem.h: Removed.
* fileapi/DOMFileSystem.idl: Removed.
* fileapi/DOMFileSystemBase.cpp: Removed.
* fileapi/DOMFileSystemBase.h: Removed.
* fileapi/DOMFileSystemSync.cpp: Removed.
* fileapi/DOMFileSystemSync.h: Removed.
* fileapi/DOMFileSystemSync.idl: Removed.
* fileapi/Entry.cpp: Removed.
* fileapi/Entry.h: Removed.
* fileapi/Entry.idl: Removed.
* fileapi/EntryArray.cpp: Removed.
* fileapi/EntryArray.h: Removed.
* fileapi/EntryArray.idl: Removed.
* fileapi/EntryArraySync.cpp: Removed.
* fileapi/EntryArraySync.h: Removed.
* fileapi/EntryArraySync.idl: Removed.
* fileapi/EntryBase.cpp: Removed.
* fileapi/EntryBase.h: Removed.
* fileapi/EntryCallback.h: Removed.
* fileapi/EntryCallback.idl: Removed.
* fileapi/EntrySync.cpp: Removed.
* fileapi/EntrySync.h: Removed.
* fileapi/EntrySync.idl: Removed.
* fileapi/ErrorCallback.h: Removed.
* fileapi/ErrorCallback.idl: Removed.
* fileapi/FileCallback.h: Removed.
* fileapi/FileCallback.idl: Removed.
* fileapi/FileEntry.cpp: Removed.
* fileapi/FileEntry.h: Removed.
* fileapi/FileEntry.idl: Removed.
* fileapi/FileEntrySync.cpp: Removed.
* fileapi/FileEntrySync.h: Removed.
* fileapi/FileEntrySync.idl: Removed.
* fileapi/FileSystemCallback.h: Removed.
* fileapi/FileSystemCallback.idl: Removed.
* fileapi/FileSystemCallbacks.cpp: Removed.
* fileapi/FileSystemCallbacks.h: Removed.
* fileapi/FileWriter.cpp: Removed.
* fileapi/FileWriter.h: Removed.
* fileapi/FileWriter.idl: Removed.
* fileapi/FileWriterBase.cpp: Removed.
* fileapi/FileWriterBase.h: Removed.
* fileapi/FileWriterBaseCallback.h: Removed.
* fileapi/FileWriterCallback.h: Removed.
* fileapi/FileWriterCallback.idl: Removed.
* fileapi/FileWriterSync.cpp: Removed.
* fileapi/FileWriterSync.h: Removed.
* fileapi/FileWriterSync.idl: Removed.
* fileapi/LocalFileSystem.cpp: Removed.
* fileapi/LocalFileSystem.h: Removed.
* fileapi/Metadata.h: Removed.
* fileapi/Metadata.idl: Removed.
* fileapi/MetadataCallback.h: Removed.
* fileapi/MetadataCallback.idl: Removed.
* fileapi/SyncCallbackHelper.h: Removed.
* fileapi/WebKitFlags.h: Removed.
* fileapi/WorkerContextFileSystem.cpp: Removed.
* fileapi/WorkerContextFileSystem.h: Removed.
* fileapi/WorkerContextFileSystem.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCollapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB) in OperationNotAllowed...
commit-queue@webkit.org [Fri, 16 Mar 2012 21:54:35 +0000 (21:54 +0000)]
Collapse ENABLE(BLOB)|ENABLE(FILE_SYSTEM) to just ENABLE(BLOB) in OperationNotAllowedException.idl
https://bugs.webkit.org/show_bug.cgi?id=81391

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-16
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* fileapi/OperationNotAllowedException.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoscrollbars/scrollbar-middleclick-nopaste.html times out on mac WK1
timothy_horton@apple.com [Fri, 16 Mar 2012 21:49:15 +0000 (21:49 +0000)]
scrollbars/scrollbar-middleclick-nopaste.html times out on mac WK1
https://bugs.webkit.org/show_bug.cgi?id=81410

Skip scrollbars/scrollbar-middleclick-nopaste.html on Mac.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/netscape-plugin-setwindow-size-2.html and plugins/resize-from-plugin.html...
jberlin@webkit.org [Fri, 16 Mar 2012 21:47:55 +0000 (21:47 +0000)]
plugins/netscape-plugin-setwindow-size-2.html and plugins/resize-from-plugin.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81405

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Added.
* platform/mac-wk2/plugins/resize-from-plugin-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/npruntime/browser-object-identity.html failing on Lion Intel Debug WebKit2...
jberlin@webkit.org [Fri, 16 Mar 2012 21:47:50 +0000 (21:47 +0000)]
plugins/npruntime/browser-object-identity.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81403

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/plugins/npruntime/browser-object-identity-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/refcount-leaks.html failing on Lion Intel Debug WebKit2 testers
jberlin@webkit.org [Fri, 16 Mar 2012 21:47:44 +0000 (21:47 +0000)]
plugins/refcount-leaks.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81400

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/plugins/refcount-leaks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/crash-restoring-plugin-page-from-page-cache.html and
jberlin@webkit.org [Fri, 16 Mar 2012 21:47:37 +0000 (21:47 +0000)]
plugins/crash-restoring-plugin-page-from-page-cache.html and
plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81392

Skip these tests for WK2.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix rounding and usage of LayoutUnits in RenderBoxModelObject
eae@chromium.org [Fri, 16 Mar 2012 21:30:11 +0000 (21:30 +0000)]
Fix rounding and usage of LayoutUnits in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=81057

Reviewed by Julien Chaffraix.

No new tests.

(WebCore):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
Fix implementation of pixelSnappedOffsetWidth/Height. The location
parameter will be ignored until we enable subpixel support.

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Use ints for border widths.

(WebCore::resolveWidthForRatio):
(WebCore::resolveHeightForRatio):
(WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio):
(WebCore::resolveAgainstIntrinsicRatio):
Change resolve*Ratio methods to operate on IntSizes as none of the
callers need subpixel precision.

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
Pixel snap paintRect when computing image geometry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed new mac baselines after http://trac.webkit.org/changeset/108185
timothy_horton@apple.com [Fri, 16 Mar 2012 21:19:48 +0000 (21:19 +0000)]
Unreviewed new mac baselines after trac.webkit.org/changeset/108185

* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-ancestor-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.txt: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png: Added.
* platform/mac/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago100% height elements to not respond to vertical browser rescaling
commit-queue@webkit.org [Fri, 16 Mar 2012 21:15:46 +0000 (21:15 +0000)]
100% height elements to not respond to vertical browser rescaling
https://bugs.webkit.org/show_bug.cgi?id=43022

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-03-16
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/replaced/vertical-resize-100percent-element.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
    For the case where a replaced element has a percentage height,
    we update the entries in RenderBlock::gPercentHeightDescendantsMap
    corresponding to all ancestors of the replaced element.

LayoutTests:

* fast/replaced/resources/vertical-resize-100percent-contents.html: Added.
* fast/replaced/vertical-resize-100percent-element-expected.txt: Added.
* fast/replaced/vertical-resize-100percent-element.html: Added.
      Layout test to ensure that an image with 100% height is resized when
      its containing iframe is vertically resized to be larger or smaller.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
      Rebaseline for chromium. This patch causes a progression in this layout test.  In the
      diff, note that the viewport has height 585, which is 600 minus 15 pixels to account for
      the horizontal scrollbar.  In the old expected output the first image to be displayed
      has height 600, which is incorrect because it should be 100% of the viewport height.
      The new expected output shows the first image with the correct height of 585.
* platform/chromium/test_expectations.txt:
      WIN will need a regenerated image, and MAC will need a regenerated image+text.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
      Skip the rebaselined test on all other platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Marking media/track/track-active-cues.html as flaky timeout...
leviw@chromium.org [Fri, 16 Mar 2012 21:08:30 +0000 (21:08 +0000)]
Unreviewed gardening. Marking media/track/track-active-cues.html as flaky timeout on windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to...
dcheng@chromium.org [Fri, 16 Mar 2012 20:53:25 +0000 (20:53 +0000)]
[chromium] Refactor ClipboardChromium and DataTransferItemList/DataTransferItem to support HTML spec
https://bugs.webkit.org/show_bug.cgi?id=76598

Reviewed by Tony Chang.

Source/WebCore:

We no longer store drag/clipboard data in named fields. We used to maintain the data store
list separately, which resulted in a lot of complicated code to try to make sure that
ChromiumDataObject and this list stayed in sync. We now just store what is essentially a
list MIME type/data pairs directly in ChromiumDataObject. This has the benefit of letting us
easily add write support during dragstart/copy operations using DataTransferItemList.

Tests: fast/events/clipboard-dataTransferItemList.html
       fast/events/drag-dataTransferItemList.html

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::findItem):
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::copy):
(WebCore::ChromiumDataObject::items):
(WebCore::ChromiumDataObject::clearData):
(WebCore::ChromiumDataObject::clearAll):
(WebCore::ChromiumDataObject::clearAllExceptFiles):
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::setData):
(WebCore::ChromiumDataObject::urlAndTitle):
(WebCore::ChromiumDataObject::setURLAndTitle):
(WebCore::ChromiumDataObject::htmlAndBaseURL):
(WebCore::ChromiumDataObject::setHTMLAndBaseURL):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore):
(WebCore::ChromiumDataObject::filenames):
(WebCore::ChromiumDataObject::addFilename):
(WebCore::ChromiumDataObject::addSharedBuffer):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore):
(ChromiumDataObject):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::normalizeType):
(WebCore::ClipboardChromium::ClipboardChromium):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::writeImageToDataObject):
(WebCore::ClipboardChromium::declareAndWriteDragImage):
(WebCore::ClipboardChromium::writeURL):
(WebCore::ClipboardChromium::writeRange):
(WebCore::ClipboardChromium::writePlainText):
(WebCore::ClipboardChromium::hasData):
(WebCore::ClipboardChromium::items):
* platform/chromium/ClipboardChromium.h:
(WebCore):
(ClipboardChromium):
(WebCore::ClipboardChromium::frame):
* platform/chromium/ClipboardUtilitiesChromium.cpp:
(WebCore::convertURIListToURL):
(WebCore):
* platform/chromium/ClipboardUtilitiesChromium.h:
(WebCore):
* platform/chromium/DataTransferItemChromium.cpp:
(WebCore::DataTransferItemChromium::createFromString):
(WebCore::DataTransferItemChromium::createFromFile):
(WebCore::DataTransferItemChromium::createFromURL):
(WebCore::DataTransferItemChromium::createFromHTML):
(WebCore):
(WebCore::DataTransferItemChromium::createFromSharedBuffer):
(WebCore::DataTransferItemChromium::createFromPasteboard):
(WebCore::DataTransferItemChromium::DataTransferItemChromium):
(WebCore::DataTransferItemChromium::getAsString):
(WebCore::DataTransferItemChromium::getAsFile):
(WebCore::DataTransferItemChromium::internalGetAsString):
(WebCore::DataTransferItemChromium::isFilename):
* platform/chromium/DataTransferItemChromium.h:
(WebCore):
(DataTransferItemChromium):
(WebCore::DataTransferItemChromium::kind):
(WebCore::DataTransferItemChromium::type):
(WebCore::DataTransferItemChromium::sharedBuffer):
(WebCore::DataTransferItemChromium::title):
(WebCore::DataTransferItemChromium::baseURL):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::create):
(WebCore::DataTransferItemListChromium::createFromPasteboard):
(WebCore):
(WebCore::DataTransferItemListChromium::DataTransferItemListChromium):
(WebCore::DataTransferItemListChromium::length):
(WebCore::DataTransferItemListChromium::item):
(WebCore::DataTransferItemListChromium::deleteItem):
(WebCore::DataTransferItemListChromium::clear):
(WebCore::DataTransferItemListChromium::add):
(WebCore::DataTransferItemListChromium::internalAddStringItem):
(WebCore::DataTransferItemListChromium::internalAddFileItem):
* platform/chromium/DataTransferItemListChromium.h:
(WebCore):
(DataTransferItemListChromium):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asFragment):

Source/WebKit/chromium:

* src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):
(WebKit::WebDragData::assign):

LayoutTests:

* fast/events/clipboard-dataTransferItemList-expected.txt: Added.
* fast/events/clipboard-dataTransferItemList.html: Added.
* fast/events/drag-dataTransferItemList-expected.txt: Added.
* fast/events/drag-dataTransferItemList.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago ASSERTION FAILED: m_loadState == LoadStateCommitted in WebFrameProxy::didFini...
ap@apple.com [Fri, 16 Mar 2012 20:49:30 +0000 (20:49 +0000)]
    ASSERTION FAILED: m_loadState == LoadStateCommitted in WebFrameProxy::didFinishLoad causing
        "crashes" on Lion Intel Debug WebKit2 Tests
        https://bugs.webkit.org/show_bug.cgi?id=81184
        <rdar://problem/11052462>

        Rubber-stamped by Anders Carlsson.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading):
        Don't leave a lingering m_pluginView after load is finished. When plug-in data was empty,
        we would create the plug-in here, but failed to finalize the load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't install libWebCoreTestSupport on OS X production builds
mlilek@apple.com [Fri, 16 Mar 2012 20:48:03 +0000 (20:48 +0000)]
Don't install libWebCoreTestSupport on OS X production builds
https://bugs.webkit.org/show_bug.cgi?id=81087

Reviewed by Mark Rowe.

* Configurations/WebCoreTestSupport.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip move-by-word-visually-wrong-left-right.html added in r110965 in wk2 since SetEdi...
xji@chromium.org [Fri, 16 Mar 2012 20:41:31 +0000 (20:41 +0000)]
Skip move-by-word-visually-wrong-left-right.html added in r110965 in wk2 since SetEditingBehavior is not supported.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix layout test to output the same result for V8 and JSC
arv@chromium.org [Fri, 16 Mar 2012 20:27:30 +0000 (20:27 +0000)]
Fix layout test to output the same result for V8 and JSC
https://bugs.webkit.org/show_bug.cgi?id=81395

Reviewed by Nate Chapin.

* fast/dom/inline-event-attributes-crash-expected.txt:
* fast/dom/inline-event-attributes-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd RenderMultiColumnBlock.cpp to RenderingAllInOne.cpp for Windows build.
hyatt@apple.com [Fri, 16 Mar 2012 20:25:40 +0000 (20:25 +0000)]
Add RenderMultiColumnBlock.cpp to RenderingAllInOne.cpp for Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoincorrectly removing scrollbar height for auto height flexbox children
tony@chromium.org [Fri, 16 Mar 2012 20:16:17 +0000 (20:16 +0000)]
incorrectly removing scrollbar height for auto height flexbox children
https://bugs.webkit.org/show_bug.cgi?id=81388

Reviewed by Ojan Vafai.

Source/WebCore:

In a column flexbox, when computing the preferred height of an auto
height child, we were subtracting out the horizontal scrollbar height.

New test case in css3/flexbox/columns-auto-size.html.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):

LayoutTests:

* css3/flexbox/columns-auto-size-expected.txt:
* css3/flexbox/columns-auto-size.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOut-of-document radio buttons should be grouped when associated with a form
adamk@chromium.org [Fri, 16 Mar 2012 20:08:35 +0000 (20:08 +0000)]
Out-of-document radio buttons should be grouped when associated with a form
https://bugs.webkit.org/show_bug.cgi?id=81268

Reviewed by Kent Tamura.

Source/WebCore:

Per the HTML spec, and the behavior of Firefox and IE 8/9, radio buttons
with a form owner should be grouped, even if that form is not in the document.

r104668 added many inDocument() tests to radio button grouping code.
While those are necessary to avoid unattached <input type=radio>
elements being grouped together, it also kept them from being grouped
when associated with a form outside the document.

This patch changes the HTMLInputElement::checkedRadioButtons() method
to return either a pointer to the proper CheckedRadioButtons instance
(either the document's or a form's), but will return null if the
element should not be associated with any radio button group.

The main fallout of this was that the callers of checkedRadioButtons()
now have to check for null, resulting in the creation of a few helper
methods in HTMLInputElement to wrap the null checks.

This refactoring has the pleasant side-effect of exposing a cleaner API between
HTMLInputElement and RadioInputType, and making a clearer contract
between HTMLInputElement and CheckedRadioButtons (e.g., all
CheckedRadioButtons methods that take an element can now assume that
it is a radio button, where previously some checked for that and
others asserted it).

Test: fast/forms/radio/radio-group-in-detached-form.html

* dom/CheckedRadioButtons.cpp:
(WebCore): Removed shouldMakeRadioGroup() helper function.
(WebCore::CheckedRadioButtons::addButton): Replace call to shouldMakeRadioGroup
with appropriate assert and name check.
(WebCore::CheckedRadioButtons::updateCheckedState): ditto.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): ditto.
(WebCore::CheckedRadioButtons::isRequiredGroup): Renamed from isInRequiredGroup,
changed to take only a group name, not an element.
(WebCore::CheckedRadioButtons::removeButton): Replace call to shouldMakeRadioGroup.
with appropriate assert and name check.
* dom/CheckedRadioButtons.h:
(CheckedRadioButtons):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement): Added isRadioButton check
now that it's asserted in CheckedRadioButtons.
(WebCore::HTMLInputElement::updateType): Call helper method instead of
calling directly into CheckedRadioButtons.
(WebCore::HTMLInputElement::parseAttribute): ditto.
(WebCore::HTMLInputElement::setChecked): ditto.
(WebCore::HTMLInputElement::willChangeForm): ditto.
(WebCore::HTMLInputElement::didChangeForm): ditto.
(WebCore::HTMLInputElement::insertedIntoDocument): ditto.
(WebCore::HTMLInputElement::removedFromDocument): ditto.
(WebCore::HTMLInputElement::didMoveToNewDocument): Added isRadioButton check.
(WebCore::HTMLInputElement::requiredAttributeChanged): Check for membership in a group
before calling into CheckedRadioButtons.
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup): Added helper method for use by RadioInputType.
(WebCore):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup): ditto.
(WebCore::HTMLInputElement::checkedRadioButtons): Changed to return a
pointer, only return non-null if actually a member of a group.
(WebCore::HTMLInputElement::addToRadioButtonGroup): Helper method for
use in HTMLInputElement.
(WebCore::HTMLInputElement::removeFromRadioButtonGroup): ditto.
* html/HTMLInputElement.h:
(HTMLInputElement): Added/removed methods, removed outdated comment about visibility.
* html/RadioInputType.cpp:
(WebCore::RadioInputType::valueMissing): Call new HTMLInputElement methods instead
of interacting directly with CheckedRadioButtons.
(WebCore::RadioInputType::isKeyboardFocusable): ditto.
(WebCore::RadioInputType::willDispatchClick): ditto.

LayoutTests:

* fast/forms/radio/radio-group-expected.txt:
* fast/forms/radio/radio-group-in-detached-form-expected.txt: Added.
* fast/forms/radio/radio-group-in-detached-form.html: Added.
* fast/forms/radio/radio-group.html: Updated to match new behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to...
commit-queue@webkit.org [Fri, 16 Mar 2012 20:00:22 +0000 (20:00 +0000)]
[BlackBerry] Syncing up left over bits in WebCoreSupport from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81120

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This is a consolidation of various changes that are in our local dev branch
but do not appear in our upstreamed port.

* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/AboutDataHaveFeatures.in:
* WebCoreSupport/AboutDataUseFeatures.in:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::hasOpenedPopup):
(WebCore):
(WebCore::ChromeClientBlackBerry::screenToRootView):
(WebCore::ChromeClientBlackBerry::rootViewToScreen):
(WebCore::ChromeClientBlackBerry::invalidateRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsAndRootView):
(WebCore::ChromeClientBlackBerry::invalidateContentsForSlowScroll):
(WebCore::ChromeClientBlackBerry::scrollableAreasDidChange):
(WebCore::ChromeClientBlackBerry::createColorChooser):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
(WebCore::ChromeClientBlackBerry::numTouchEventHandlersChanged):
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::registerUndoStep):
(WebCore::EditorClientBlackBerry::registerRedoStep):
(WebCore::EditorClientBlackBerry::undo):
(WebCore::EditorClientBlackBerry::redo):
* WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
* WebCoreSupport/GeolocationControllerClientBlackBerry.cpp:
(GeolocationControllerClientBlackBerry::requestPermission):
(GeolocationControllerClientBlackBerry::cancelPermissionRequest):
* WebCoreSupport/GeolocationControllerClientBlackBerry.h:
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::closeInspectorFrontend):
(WebCore):
(WebCore::InspectorClientBlackBerry::bringFrontendToFront):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
* WebCoreSupport/NotificationPresenterImpl.cpp:
(WebCore::NotificationPresenterImpl::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMissed adding new files to Targets.pri
hyatt@apple.com [Fri, 16 Mar 2012 19:57:30 +0000 (19:57 +0000)]
Missed adding new files to Targets.pri

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=81366
hyatt@apple.com [Fri, 16 Mar 2012 19:55:25 +0000 (19:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81366

Add RenderMultiColumnBlock subclass of RenderBlock. This new class will hold all of the multi-column
logic (as well as painting/hit testing). That way the column code can be kept out of the base class
and be more cleanly factored.

Patch Node::diff so that we detach and re-attach the renderer if column counts or widths change
from auto to non-auto (and vice versa) to ensure the right renderer gets made.

Patch RenderObject::createObject to make a RenderMultiColumnBlock if either the column count or
column width is non-auto.

Patch RenderBlock::calcColumnWidth to "turn off" the old implementation of columns if the pref to use
the new column implementation is set. This single chokepoint should be sufficient for disabling the old
columns in favor of the new.

Reviewed by Dan Bernstein.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::regionBasedColumnsEnabled):
(WebCore):
(WebCore::Document::recalcStyle):
* dom/Document.h:
(Document):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
* dom/Node.cpp:
(WebCore::Node::diff):
* dom/Node.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::updateFirstLetterStyle):
* rendering/RenderMultiColumnBlock.cpp: Added.
(WebCore):
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::renderName):
* rendering/RenderMultiColumnBlock.h: Added.
(WebCore):
(RenderMultiColumnBlock):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::updateBeforeAfterContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Improve CSS3 filter blur performance.
senorblanco@chromium.org [Fri, 16 Mar 2012 19:45:04 +0000 (19:45 +0000)]
[chromium] Improve CSS3 filter blur performance.
https://bugs.webkit.org/show_bug.cgi?id=81360

This change improves blur performance by 2-2.5X on blurred CSS
3D transforms and accelerated canvas demos by skipping an unnecessary
texture allocation and bitmap draw.

Reviewed by James Robinson.

Covered by existing layout tests in css3/filters.

* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
Call SkCanvas::drawSprite() directly instead of using
saveLayer()/restore().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline GTK expected results after r111041.
jer.noble@apple.com [Fri, 16 Mar 2012 19:43:57 +0000 (19:43 +0000)]
Rebaseline GTK expected results after r111041.

* platform/gtk/accessibility/media-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplugins/keyboard-events.html, mouse-events-fixedpos.html, and mouse-events.html faili...
jberlin@webkit.org [Fri, 16 Mar 2012 19:41:48 +0000 (19:41 +0000)]
plugins/keyboard-events.html, mouse-events-fixedpos.html, and mouse-events.html failing on Lion
Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81386

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/plugins/keyboard-events-expected.txt: Added.
* platform/mac-wk2/plugins/mouse-events-expected.txt: Added.
* platform/mac-wk2/plugins/mouse-events-fixedpos-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] IndexedDB: Assertion failure when storing File objects
jsbell@chromium.org [Fri, 16 Mar 2012 19:26:00 +0000 (19:26 +0000)]
[Chromium] IndexedDB: Assertion failure when storing File objects
https://bugs.webkit.org/show_bug.cgi?id=76746

Source/WebCore:

The blob data in Blob/File/FileList objects is serialized "by reference" (the
internal URL) rather than "by value" (the actual data); this is sufficient for
postMessage() but not for IndexedDB since the referenced data is not retained
Expose a mechanism to enumerate the URLs so that SSVs can be rejected by IDB
until blob data serialization can is implemented (outside the SSV mechanism, and
potentially asynchronously).

Also, correct issue in V8DOMWrapper::instantiateV8Object where context is assumed
to be a Worker context if it's not a Window, which is incorrect for the
Chromium utility process; this is hit if Blobs are not blocked.

Reviewed by Tony Chang.

Test: storage/indexeddb/noblobs.html

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Reject SSVs that contain blob references.
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::add): Reject SSVs that contain blob references.
(WebCore::IDBObjectStore::put): Reject SSVs that contain blob references.
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneSerializer::write):
(CloneSerializer):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
* bindings/js/SerializedScriptValue.h: New API to enable the clients to be picky.
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::SerializedScriptValue):
* bindings/v8/SerializedScriptValue.h: New API to enable the clients to be picky.
(WebCore::SerializedScriptValue::blobURLs):
(SerializedScriptValue):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):  Ensure context is a worker context before treating it as such.

LayoutTests:

Ensure that Blob/File/FileList types are rejected in IDB values, to detect regressions.

Reviewed by Tony Chang.

* storage/indexeddb/noblobs-expected.txt: Added.
* storage/indexeddb/noblobs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
arv@chromium.org [Fri, 16 Mar 2012 19:23:14 +0000 (19:23 +0000)]
[V8] Ensure that invalid syntax in inline event handlers does not cause a crash
https://bugs.webkit.org/show_bug.cgi?id=81385

Reviewed by Nate Chapin.

Source/WebCore:

The way that V8 does its inline event handler involves concatting strings and
if the attribute value is crafted in a special way this could cause a crash.

Test: fast/dom/inline-event-attributes-crash.html

* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

* fast/dom/inline-event-attributes-crash-expected.txt: Added.
* fast/dom/inline-event-attributes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines for expected failures on garden-o-matic.
ojan@chromium.org [Fri, 16 Mar 2012 19:22:31 +0000 (19:22 +0000)]
Chromium rebaselines for expected failures on garden-o-matic.

* platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-linux/compositing/color-matching/pdf-image-match-expected.png: Added.
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-mac-snowleopard/animations/cross-fade-border-image-source-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.txt: Added.
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-transition-expected.png: Added.
* platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Added.
* platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Added.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Added.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Copied from LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt.
* platform/chromium-win/compositing/absolute-position-changed-with-composited-parent-layer-expected.png:
* platform/chromium-win/compositing/color-matching/pdf-image-match-expected.png: Added.
* platform/chromium-win/compositing/color-matching/pdf-image-match-expected.txt: Added.
* platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWrong icon to restore to windowed mode in full screen video panel
jer.noble@apple.com [Fri, 16 Mar 2012 19:21:31 +0000 (19:21 +0000)]
Wrong icon to restore to windowed mode in full screen video panel
https://bugs.webkit.org/show_bug.cgi?id=70437

Reviewed by Eric Carlson.

Source/WebCore:

No new tests. Updated platform/mac/accessibility/media-element-expected.txt.

Renamed MediaFullscreenButton to MediaEnterFullscreenButton and added MediaExitFullscreenButton:
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::controlTypeName):
(WebCore::AccessibilityMediaControl::roleValue):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSValueKeywords.in:
* platform/ThemeTypes.h:

Added setIsFullscreen which controls the display of the enter/exit fullscreen button:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::setIsFullscreen): Added.
* html/shadow/MediaControlElements.h:
* html/shadow/MediaControlRootElement.cpp:
(WebCore::MediaControlRootElement::enteredFullscreen):
(WebCore::MediaControlRootElement::exitedFullscreen):

Paint the enter/exit fullscreen button accordingly:
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::paintMediaFullscreenButton):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaFullscreenButton):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::paintMediaControlsPart):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintMediaFullscreenButton):

Update the localized strings for the exit and enter fullscreen buttons:
* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

WebKitLibraries:

* WebKitSystemInterface.h: Added WKMediaUIPartExitFullscreenButton.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceLion.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

LayoutTests:

* platform/mac/accessibility/media-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate LayoutUnit usage in RenderListBox
leviw@chromium.org [Fri, 16 Mar 2012 19:07:24 +0000 (19:07 +0000)]
Update LayoutUnit usage in RenderListBox
https://bugs.webkit.org/show_bug.cgi?id=81038

Reviewed by Julien Chaffraix.

Bringing RenderListBox in line with the rules listed in
https://trac.webkit.org/wiki/LayoutUnit

No new tests. No change in behavior.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintScrollbar): Pixel snapping before handing off scrollbar
painting to the platform.
(WebCore::RenderListBox::paintItemForeground): Rounding the offset for text painting.
(WebCore::RenderListBox::paintItemBackground): Pixel snapping the background rect.
(WebCore::RenderListBox::panScroll): EventHandler::currentMousePosition is an IntPoint,
so it doesn't require additional rounding in RenderListBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHave webkit-patch rebaseline-test update test_expectations.txt
ojan@chromium.org [Fri, 16 Mar 2012 19:02:52 +0000 (19:02 +0000)]
Have webkit-patch rebaseline-test update test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=81054

Recommit http://trac.webkit.org/changeset/110783 now that
http://trac.webkit.org/changeset/111034 has landed.

* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.remove_configuration_from_test):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(RemoveConfigurationsTest):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest):
(RebaselineTest.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline window-properties-expected on GTK; add two new tests
jer.noble@apple.com [Fri, 16 Mar 2012 18:57:10 +0000 (18:57 +0000)]
Rebaseline window-properties-expected on GTK; add two new tests
to the GTK Skipped list associated with existing bug:
https://bugs.webkit.org/show_bug.cgi?id=61118

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Input fields with id of e-mail and url should be styled as such.
commit-queue@webkit.org [Fri, 16 Mar 2012 18:39:09 +0000 (18:39 +0000)]
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Treat fields that have name/id's that match url or
email as url or email fields providing the appropriate
keyboard.

PR 137259.

Reviewed Internally by Gen Mak and Nima Ghanavatian.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::matchesReservedStringEmail):
(DOMSupport):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesEmail):
(BlackBerry::WebKit::DOMSupport::elementIdOrNameIndicatesUrl):
(BlackBerry::WebKit::DOMSupport::matchesReservedStringPreventingAutocomplete):
* WebKitSupport/DOMSupport.h:
(WebCore):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::convertInputType):
(BlackBerry::WebKit::inputStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark form-associated-element-crash3.html as flakily timing out, since it often passes.
adamk@chromium.org [Fri, 16 Mar 2012 18:33:30 +0000 (18:33 +0000)]
Mark form-associated-element-crash3.html as flakily timing out, since it often passes.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r111020.
pkasting@chromium.org [Fri, 16 Mar 2012 18:33:25 +0000 (18:33 +0000)]
Unreviewed, rolling out r111020.
http://trac.webkit.org/changeset/111020
https://bugs.webkit.org/show_bug.cgi?id=81377

Broke Chromium Win compile (Requested by pkasting on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-16

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Removed.
* platform/mediastream/PeerConnection00Handler.h: Removed.
* platform/mediastream/PeerConnection00HandlerClient.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpecifier collapsing when writing test expectations lines gets a number of cases...
ojan@chromium.org [Fri, 16 Mar 2012 18:31:33 +0000 (18:31 +0000)]
Specifier collapsing when writing test expectations lines gets a number of cases wrong
https://bugs.webkit.org/show_bug.cgi?id=81309

Reviewed by Dimitri Glazkov.

I've run this over all the lines in the current Chromium test_expectations.txt file,
so I'm relatively confident we now cover all the cases.

* Scripts/webkitpy/layout_tests/models/test_configuration.py:
(TestConfigurationConverter.__init__):
(TestConfigurationConverter.collapse_macros):
(TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
(TestConfigurationConverter):
(TestConfigurationConverter.intersect_combination):
(TestConfigurationConverter.symmetric_difference):
(TestConfigurationConverter.to_specifiers_list):
(TestConfigurationConverter.to_specifiers_list.try_collapsing):
(TestConfigurationConverter.to_specifiers_list.try_abbreviating):
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
(make_mock_all_test_configurations_set):
(TestConfigurationConverterTest.test_symmetric_difference):
(TestConfigurationConverterTest.test_to_config_set):
(TestConfigurationConverterTest.test_macro_expansion):
(TestConfigurationConverterTest.test_to_specifier_lists):
(TestConfigurationConverterTest.test_converter_macro_collapsing):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.__init__):
The android port uses "arm" as it's architecture, which is technically correct,
but considerably complicates making collapsing work. We probably should kill
the concept of architecture entirely. The benefits are not worth the code
complexity.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumPortTest.test_all_test_configurations):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:21 +0000 (18:27 +0000)]
6 platform/mac/editing/spelling autocorrect-related tests failing on Lion Intel Debug WebKit2
testers
https://bugs.webkit.org/show_bug.cgi?id=81375

Add expected failing results to get the bots green.

* platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/click-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Added.
* platform/mac-wk2/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplatform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:15 +0000 (18:27 +0000)]
platform/mac/editing/spelling/editing-word-with-marker-1.html failing on Lion Intel Debug
testers
https://bugs.webkit.org/show_bug.cgi?id=81372

Add expected failing results to get the bots green.

* platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplatform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel...
jberlin@webkit.org [Fri, 16 Mar 2012 18:27:10 +0000 (18:27 +0000)]
platform/mac/editing/spelling/autocorrection-contraction.html fails on Lion Intel Debug testers.
https://bugs.webkit.org/show_bug.cgi?id=81369

Add expected failing results to get the bots green.

* platform/mac/editing/spelling/autocorrection-contraction-expected.png:
* platform/mac/editing/spelling/autocorrection-contraction-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFile input control accessibility can cause a crash
dmazzoni@google.com [Fri, 16 Mar 2012 18:23:25 +0000 (18:23 +0000)]
File input control accessibility can cause a crash
https://bugs.webkit.org/show_bug.cgi?id=80896

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/input-file-causes-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):

LayoutTests:

* accessibility/input-file-causes-crash-expected.txt: Added.
* accessibility/input-file-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking...
commit-queue@webkit.org [Fri, 16 Mar 2012 18:21:16 +0000 (18:21 +0000)]
[chromium] compositing tests with videos fail in chromium DumpRenderTree, seeking doesn't appear to work
https://bugs.webkit.org/show_bug.cgi?id=76511

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-03-16
Reviewed by Eric Carlson.

* compositing/resources/media-testing.js:
(ensureFrameVisible.playingHandler):
(ensureFrameVisible.seekedHandler):
(ensureFrameVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport W3C Full Screen API proposal
jer.noble@apple.com [Fri, 16 Mar 2012 18:12:14 +0000 (18:12 +0000)]
Support W3C Full Screen API proposal
https://bugs.webkit.org/show_bug.cgi?id=80660

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fullscreen/full-screen-element-stack.html
       fullscreen/full-screen-enabled.html
       fullscreen/full-screen-restrictions.html

The W3C proposal for taking arbitrary elements into full-screen mode is significantly
different than the Mozilla proposal. For example, the W3C has proposed a lower-case "s"
in "Fullscreen", which means the W3C and Mozilla "requestFullscreen" APIs differ only by
in that lower-case "s". Annoying as this is, it does allow us to retain the semantics for
the Mozilla case (har!).

A significant difficulty is obeying the new W3C spec rules is that we would like to apply the
fullscreen CSS rules while exiting fullscreen mode, though the W3C spec insists that the
webkitFullscreenElement returns the new value immediately.  As such, we retain the m_fullScreenElement
variable (distinct from the top of the m_fullScreenElements stack) which is controlled by the
webkit{Will,Did}{Enter,Exit}FullScreen functions.

New APIs for the W3C Fullscreen spec:
* dom/Document.h:
(WebCore::Document::webkitFullscreenElement):
(WebCore::Document::webkitFullscreenEnabled):
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::webkitRequestFullscreen):
* dom/Element.h:
* dom/Element.idl:

* dom/Document.cpp:
(WebCore::Document::removedLastRef): Clear m_fullScreenElementStack.
(WebCore::Document::requestFullScreenForElement): Implement the W3C requirements.
(WebCore::Document::webkitExitFullscreen): Ditto.
(WebCore::Document::webkitCancelFullScreen): Implement in terms of webkitCancelFullscreen.
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
(WebCore::Document::fullScreenChangeDelayTimerFired): Protect against items being
    added to the event and error queue by swapping out empty queues before starting.
(WebCore::Document::clearFullscreenElementStack): Simple accessor.
(WebCore::Document::popFullscreenElementStack): Ditto.
(WebCore::Document::pushFullscreenElementStack): Ditto.
* dom/Element.cpp:
(WebCore::Element::webkitRequestFullScreen):

Add new RuntimeEnabledFeatures functions for the added Document and Element functions.
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):

Source/WebKit/mac:

Allow full screen elements to access the keyboard.

* WebView/WebView.mm:
(-[WebView _supportsFullScreenForElement:WebCore::withKeyboard:]):

Source/WebKit2:

Allow full screen elements to access the keyboard.

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::exitFullScreenForElement):

LayoutTests:

* fullscreen/full-screen-element-stack-expected.txt: Added.
* fullscreen/full-screen-element-stack.html: Added.
* fullscreen/full-screen-enabled-expected.txt: Added.
* fullscreen/full-screen-enabled.html: Added.
* fullscreen/full-screen-request-rejected.html:
* fullscreen/full-screen-request-removed.html:
* fullscreen/full-screen-restrictions-expected.txt: Added.
* fullscreen/full-screen-restrictions.html: Added.
* fullscreen/full-screen-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitWebResource::load-failed uses the wrong marshaller
commit-queue@webkit.org [Fri, 16 Mar 2012 18:00:10 +0000 (18:00 +0000)]
[GTK] WebKitWebResource::load-failed uses the wrong marshaller
https://bugs.webkit.org/show_bug.cgi?id=81229

Patch by Victor Lucero <victor.lucero@ipartner.cl> on 2012-03-16
Reviewed by Philippe Normand.

* webkit/webkitwebresource.cpp:
(webkit_web_resource_class_init): load-failed signal in WebkitWebResource was using the wrong marshaller

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlEle...
adamk@chromium.org [Fri, 16 Mar 2012 17:58:13 +0000 (17:58 +0000)]
Make HTMLInputElement::isRadioButton non-virtual and remove unused HTMLFormControlElement::isRadioButton method
https://bugs.webkit.org/show_bug.cgi?id=81255

Reviewed by Kent Tamura.

No new tests, no change in behavior.

* html/HTMLFormControlElement.h:
* html/HTMLInputElement.h:
(HTMLInputElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Update NetworkJob to accept batched headers
commit-queue@webkit.org [Fri, 16 Mar 2012 17:43:56 +0000 (17:43 +0000)]
[BlackBerry] Update NetworkJob to accept batched headers
https://bugs.webkit.org/show_bug.cgi?id=81273

Batch up the headers into a vector before they come into
webkit to increase performance, and simplify the API.

Patch by Tay Grigg <tgrigg@rim.com> on 2012-03-16
Reviewed by George Staikos.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyHeadersReceived):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
commit-queue@webkit.org [Fri, 16 Mar 2012 17:17:03 +0000 (17:17 +0000)]
[BlackBerry] Syncing up left over bits in Api from our local branch to upstream
https://bugs.webkit.org/show_bug.cgi?id=81105

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-03-16
Reviewed by Rob Buis.

This patches fixes up a previous sync done in this directory and adds some new bits
as well.  This is accurate as of ddea1528b37b29925638fe1183318b3c3994f1f8 in our
local repo.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::drawLayersOnCommitIfNeeded):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
* Api/WebPage.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add overdraw metrics for texture uploads
commit-queue@webkit.org [Fri, 16 Mar 2012 17:14:30 +0000 (17:14 +0000)]
[chromium] Add overdraw metrics for texture uploads
https://bugs.webkit.org/show_bug.cgi?id=81175

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Record texture upload metrics during paint. To properly record
the amount of pixels culled, we must compute the amount of pixels we
would have uploaded for a tile. This requires knowing the dirty rect of
the tile, but the dirty rect can be changed by WebKit during a paint, so
we always store the dirtyRect in the tile's updateRect. We add an
m_updateCulled bool to the UpdatableTile structure, to identify tiles
that were not updated, and know a tile was updated if updateRect is not
empty and updateCulled is false.

Tested by all TiledLayerChromiumTests that use occlusion tracker.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow AudioContext::create() to emit an ExceptionCode.
jer.noble@apple.com [Fri, 16 Mar 2012 17:07:41 +0000 (17:07 +0000)]
Allow AudioContext::create() to emit an ExceptionCode.
https://bugs.webkit.org/show_bug.cgi?id=81049

Reviewed by Kentaro Hara.

No new tests; no change in functionality.

Pass through an ExceptionCode parameter to AudioContext::create().  It is currently
never modified, but exceptions will be added in the future.

* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::create):
* webaudio/AudioContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove surface damage client from occlusion tracker
commit-queue@webkit.org [Fri, 16 Mar 2012 16:59:43 +0000 (16:59 +0000)]
[chromium] Remove surface damage client from occlusion tracker
https://bugs.webkit.org/show_bug.cgi?id=81242

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Code was not used yet, so no new tests. Removing tests instead!

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::CCOcclusionTrackerBase):
(WebCore::::layerScissorRectInTargetSurface):
(WebCore):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(WebCore):
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Introducing PeerConnection00Handler
tommyw@google.com [Fri, 16 Mar 2012 16:56:57 +0000 (16:56 +0000)]
MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Added.
(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):
* platform/mediastream/PeerConnection00Handler.h: Added.
(WebCore):
(PeerConnection00Handler):
* platform/mediastream/PeerConnection00HandlerClient.h: Added.
(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Input processing mode should be cancelled when processing hot keys
commit-queue@webkit.org [Fri, 16 Mar 2012 16:56:57 +0000 (16:56 +0000)]
[BlackBerry] Input processing mode should be cancelled when processing hot keys
https://bugs.webkit.org/show_bug.cgi?id=81348

Patch by Mike Fenton <mifenton@rim.com> on 2012-03-16
Reviewed by Rob Buis.

Don't suppress IMF notifications if we are handling
the event as a hotkey.

Reviewed Internally by Nima Ghanavatian.

* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix exception when hovering over bound function in heap profiler.
podivilov@chromium.org [Fri, 16 Mar 2012 16:49:45 +0000 (16:49 +0000)]
Web Inspector: fix exception when hovering over bound function in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=81362

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix.
sfalken@apple.com [Fri, 16 Mar 2012 16:49:32 +0000 (16:49 +0000)]
Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSkip visual word movement tests in gtk and qt after r110965 since isWordTextBreak...
xji@chromium.org [Fri, 16 Mar 2012 16:49:09 +0000 (16:49 +0000)]
Skip visual word movement tests in gtk and qt after r110965 since isWordTextBreak is not implemented.

* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix bounce-back behaviour for panning
abecsi@webkit.org [Fri, 16 Mar 2012 16:43:31 +0000 (16:43 +0000)]
[Qt][WK2] Fix bounce-back behaviour for panning
https://bugs.webkit.org/show_bug.cgi?id=81144

Reviewed by Kenneth Rohde Christiansen.

If the pan gesture recognizer receives a touch begin event
during an ongoing kinetic scroll animation of a previous
pan gesture, the animation is stopped and the content is
immediately positioned back to valid boundaries.

* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cancelScrollAnimation):
(WebKit):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit/gtk/resources/error.html font-size error
mrobinson@webkit.org [Fri, 16 Mar 2012 16:40:54 +0000 (16:40 +0000)]
WebKit/gtk/resources/error.html font-size error
https://bugs.webkit.org/show_bug.cgi?id=39232

Patch by Landry Breuil <landry@openbsd.org> on 2012-03-14
Reviewed by Martin Robinson.

Fix font-size in the 404 error page. Apparently the % is filtered out,
so 120% becomes 120 and the error message is huge. Experienced in epiphany.

* resources/error.html: Double the % so it doesn't get filtered

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove diagnostic benefit of JSGlobalData::m_isInitializingObject
msaboff@apple.com [Fri, 16 Mar 2012 16:26:26 +0000 (16:26 +0000)]
Improve diagnostic benefit of JSGlobalData::m_isInitializingObject
https://bugs.webkit.org/show_bug.cgi?id=81244

Rubber stamped by Filip Pizlo.

Changed type and name of JSGlobalData::m_isInitializingObject to
ClassInfo* and m_initializingObjectClass.
Changed JSGlobalData::setInitializingObject to
JSGlobalData::setInitializingObjectClass.  This pointer can be used within
the debugger to determine what type of object is being initialized.

* runtime/JSCell.h:
(JSC::JSCell::finishCreation):
(JSC::allocateCell):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::isInitializingObject):
(JSC::JSGlobalData::setInitializingObjectClass):
* runtime/Structure.h:
(JSC::JSCell::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Wk2] Assertion Failure and crash on file upload
commit-queue@webkit.org [Fri, 16 Mar 2012 16:16:25 +0000 (16:16 +0000)]
[Qt][Wk2] Assertion Failure and crash on file upload
https://bugs.webkit.org/show_bug.cgi?id=80854

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Source/WebKit2:

Crash resulted from attempting to create QFileDialog, a QtWidget based dialog from a
QGuiApplication. Replace QFileDialog with a QML implementable component.
Added a new property 'filePicker' to WebView experimental to set the QML component for
file upload triggered by an input file element.

Co-authored with Kasthuri Nallappasoundararajan <kasthuri.n-s@nokia.com>

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewExperimental::filePicker):
(QQuickWebViewExperimental::setFilePicker):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/tests/qmltests/DesktopBehavior.pro:
* UIProcess/API/qt/tests/qmltests/DesktopBehavior/tst_singleFileUpload.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/singlefileupload.html: Added.
* UIProcess/qt/QtDialogRunner.cpp:
(FilePickerContextObject):
(FilePickerContextObject::FilePickerContextObject):
(FilePickerContextObject::fileList):
(FilePickerContextObject::reject):
(FilePickerContextObject::accept):
(QtDialogRunner::initForFilePicker):
* UIProcess/qt/QtDialogRunner.h:
(QtDialogRunner):
(QtDialogRunner::filePaths):
(QtDialogRunner::onFileSelected):

Tools:

Added filePicker to WebView using experimental API.

* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/icons/folder.png: Added.
* MiniBrowser/qt/icons/titlebar.png: Added.
* MiniBrowser/qt/icons/up.png: Added.
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/FilePicker.qml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating email for committer.py script.
mahesh.kulkarni@nokia.com [Fri, 16 Mar 2012 16:04:44 +0000 (16:04 +0000)]
Updating email for committer.py script.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Build failure when using --no-touch-events
commit-queue@webkit.org [Fri, 16 Mar 2012 15:51:07 +0000 (15:51 +0000)]
[Qt][WK2] Build failure when using --no-touch-events
https://bugs.webkit.org/show_bug.cgi?id=81241

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-03-16
Reviewed by Simon Hausmann.

Fixed inconsistency in the use of ENABLE_TOUCH_EVENTS flag that caused build
failure when using --no-touch-events option

* UIProcess/qt/QtPageClient.h:
(QtPageClient):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handlePotentialSingleTapEvent):
* UIProcess/qt/QtWebPageEventHandler.h:
(QtWebPageEventHandler):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebPage/WebPage.h:
(WebPage):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] The "progress" element should not be a form-associated element.
commit-queue@webkit.org [Fri, 16 Mar 2012 15:01:16 +0000 (15:01 +0000)]
[Forms] The "progress" element should not be a form-associated element.
https://bugs.webkit.org/show_bug.cgi?id=80240

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes base class of HTMLProgressElement to LabelableElement from
HTMLFormControlElement for saving memory space and iteration time of
extra "progress" elements in HTMLFormElement::m_formAssociatedElements
and matching the HTML5 specification for ease of maintenance.

Changes of TextIterator is lead by usage of isFormControlElement. This
changes will be replaced with more meaningful predicate as part of
https://bugs.webkit.org/show_bug.cgi?id=80381

No new tests. Update existing tests to cover this change.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement): Moved the "progress" element support code from canShareStyleWithControl.
(WebCore::CSSStyleSelector::canShareStyleWithControl):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Remove isFormControlElement check for PseudoIndeterminate.
* editing/TextIterator.cpp:
(WebCore::TextIterator::advance): Check HTMLProgressElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute.
* html/HTMLProgressElement.cpp: Remove unused include file.
(WebCore::HTMLProgressElement::HTMLProgressElement): Changed base class to LabelableElement.
(WebCore::HTMLProgressElement::create): Remove form paraprogress.
(WebCore::HTMLProgressElement::parseAttribute): Replace HTMLFormControlElement to LabelableElement.
(WebCore::HTMLProgressElement::attach): Replace HTMLFormControlElement to LabelableElement.
* html/HTMLProgressElement.h:
(HTMLProgressElement):
* html/HTMLProgressElement.idl: Remove the "form" attribute which isn't listed in the HTML5 specification.
* html/HTMLTagNames.in: Remove "constructorNeedsFormElement" for not passing "form" parameter in HTMLElementFactory.

LayoutTests:

This patch changes tests for non-existent "form" attribute of the
"progress" element. The "form" attribute is available only for
form-associate elements. However, the "progress" element isn't.

* fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Update expectation for test output changes.
* fast/dom/HTMLProgressElement/progress-element-form.html: Changed for the "progress" element doesn't have IDL attribute "form".
* fast/forms/form-attribute-expected.txt: Update expectation for test output changes.
* fast/forms/form-attribute.html: Removed lines for the "progress" element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.
loislo@chromium.org [Fri, 16 Mar 2012 14:54:09 +0000 (14:54 +0000)]
Web Inspector: Heap Snapshot: Unreviewed single line fix for isWindow getter.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API (JSEP): Fixing a few nits
tommyw@google.com [Fri, 16 Mar 2012 14:53:01 +0000 (14:53 +0000)]
MediaStream API (JSEP): Fixing a few nits
https://bugs.webkit.org/show_bug.cgi?id=81322

Reviewed by Adam Barth.

Addressing the nits from bugs 81206 and 81207.

Nothing to test.

* Modules/mediastream/SessionDescription.idl:
* platform/mediastream/IceOptions.h:
(WebCore::IceOptions::IceOptions):
* platform/mediastream/SessionDescriptionDescriptor.h:
(SessionDescriptionDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] DRT: Add support for sending gesture scrolls without a begin
commit-queue@webkit.org [Fri, 16 Mar 2012 14:48:05 +0000 (14:48 +0000)]
[chromium] DRT: Add support for sending gesture scrolls without a begin
https://bugs.webkit.org/show_bug.cgi?id=81292

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureScrollFirstPoint):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
yurys@chromium.org [Fri, 16 Mar 2012 14:43:13 +0000 (14:43 +0000)]
Web Inspector: TypeBuilder: Introduce OptOutput class for optional output parameters
https://bugs.webkit.org/show_bug.cgi?id=80789

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-03-16
Reviewed by Yury Semikhatsky.

OptOutput class is added for optional return parameters.

Strict mode added to Generator that makes all parameter types strict
and drop pre-set default values for return parameters.

Debugger and Page domain is switched to strict mode.

* inspector/CodeGeneratorInspector.py:
(CommandReturnPassModel.OptOutput):
(CommandReturnPassModel.OptOutput.__init__):
(CommandReturnPassModel.OptOutput.get_return_var_type):
(CommandReturnPassModel.OptOutput.get_output_argument_prefix):
(CommandReturnPassModel.OptOutput.get_output_to_raw_expression):
(CommandReturnPassModel.OptOutput.get_output_parameter_type):
(CommandReturnPassModel):
(CommandReturnPassModel.OptOutput.get_set_return_condition):
(TypeModel.Enum.get_optional.EnumOptional.get_command_return_pass_model):
(TypeModel.ValueType.ValueOptional.get_command_return_pass_model):
(OptOutput):
(Generator.process_event):
(Generator.process_command):
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::buildObjectForSearchMatch):
(WebCore::ContentSearchUtils::searchInTextByLines):
* inspector/ContentSearchUtils.h:
(ContentSearchUtils):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::evaluate):
(WebCore::InjectedScript::callFunctionOn):
(WebCore::InjectedScript::evaluateOnCallFrame):
(WebCore::InjectedScript::makeEvalCall):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getFunctionDetails):
(WebCore::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::breakProgram):
(WebCore::InspectorDebuggerAgent::clearBreakDetails):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/InspectorPageAgent.cpp:
(WebCore::buildObjectForCookie):
(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::getResourceTree):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrame):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
* inspector/InspectorPageAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
(WebCore::InspectorRuntimeAgent::callFunctionOn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe IDL parser should support sequence<T> type
haraken@chromium.org [Fri, 16 Mar 2012 14:01:09 +0000 (14:01 +0000)]
The IDL parser should support sequence<T> type
https://bugs.webkit.org/show_bug.cgi?id=81345

Reviewed by Adam Barth.

This patch makes the IDL parser support sequence<T> type.
This patch just makes sequence<T> parseable, and the generated code
for sequence<T> is wrong. This issue will be soon fixed in bug 80696.
This is a preparing patch for bug 80696.

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/test/TestObj.idl: Added tests for sequence<T>.

* bindings/scripts/IDLStructure.pm: Updated the regular expressions to support sequence<T>.

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
(WebDOMTestObj::sequenceAttr):
(WebDOMTestObj::setSequenceAttr):
(WebDOMTestObj::methodWithSequenceArg):
(WebDOMTestObj::methodReturningSequence):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_method_with_sequence_arg):
(webkit_dom_test_obj_method_returning_sequence):
(webkit_dom_test_obj_get_sequence_attr):
(webkit_dom_test_obj_set_sequence_attr):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
(WebCore::jsTestObjSequenceAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj sequenceAttr]):
(-[DOMTestObj setSequenceAttr:]):
(-[DOMTestObj methodWithSequenceArg:]):
(-[DOMTestObj methodReturningSequence:]):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::sequenceAttrAttrGetter):
(TestObjInternal):
(WebCore::TestObjInternal::sequenceAttrAttrSetter):
(WebCore::TestObjInternal::methodWithSequenceArgCallback):
(WebCore::TestObjInternal::methodReturningSequenceCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: HeapSnapshot: merge two long operations into one.
loislo@chromium.org [Fri, 16 Mar 2012 13:50:33 +0000 (13:50 +0000)]
Web Inspector: HeapSnapshot: merge two long operations into one.
https://bugs.webkit.org/show_bug.cgi?id=81347

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.aggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildAggregates.forDominatedNodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] QtWebKit documentation missing a few since 4.6 information
commit-queue@webkit.org [Fri, 16 Mar 2012 13:45:40 +0000 (13:45 +0000)]
[Qt] QtWebKit documentation missing a few since 4.6 information
https://bugs.webkit.org/show_bug.cgi?id=81328

Patch by Teemu Katajisto <teemu.katajisto@digia.com> on 2012-03-16
Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:
* Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge setVisibleContentsForScaling with setVisibleContentsRectForPanning
kenneth@webkit.org [Fri, 16 Mar 2012 13:42:18 +0000 (13:42 +0000)]
Merge setVisibleContentsForScaling with setVisibleContentsRectForPanning
https://bugs.webkit.org/show_bug.cgi?id=81346

Reviewed by Simon Hausmann.

This cleans up the code path and is one step on the way to avoid
calling both methods in succession, for instance after ending pinch
zoom.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_commitScaleChange):
(QQuickWebViewPrivate::_q_commitPositionChange):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentsRect):
* UIProcess/LayerTreeHostProxy.h:
(LayerTreeHostProxy):
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setVisibleContentsRect):
* UIProcess/WebLayerTreeRenderer.h:
(WebLayerTreeRenderer):
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::setVisibleContentsRect):
* WebProcess/WebPage/LayerTreeHost.messages.in:
* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::setVisibleContentsRect):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Can not open certain links from bridge applications
commit-queue@webkit.org [Fri, 16 Mar 2012 13:35:37 +0000 (13:35 +0000)]
[BlackBerry] Can not open certain links from bridge applications
https://bugs.webkit.org/show_bug.cgi?id=81197

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-03-16
Reviewed by Rob Buis.

Currently, the engine asks the client to handle some type of requests externally.
But WebPageClient::handleStringPattern is not yet implemented and exposed to
the client. Before that, we still need to give the client a chance to decide
how to handle requests such as 'mailto:'.

To address this problem, r108763 introduced a change that ask the client to
decide how to handle the navigation in dispatchDecidePolicyForNewWindowAction().
This is not intuitive and will bring troubles, because this navigation will
happen in the new page. So the new page client is to decide how to handle
the navigation, not the old one.

This patch reverts r108763 and skips calling WebPageClient::handleStringPattern
since it's not implemented.

This way the new window action will continue, and the logic in
dispatchDecidePolicyForNavigationAction() will handle the navigation correctly.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] WebKitIconDatabase doesn't keep icons cached
sergio@webkit.org [Fri, 16 Mar 2012 13:34:46 +0000 (13:34 +0000)]
[GTK] WebKitIconDatabase doesn't keep icons cached
https://bugs.webkit.org/show_bug.cgi?id=56200

Reviewed by Martin Robinson.

Source/WebKit/gtk:

* GNUmakefile.am: Added new files to compilation.
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::registerForIconNotification): instruct
the WebView to listen to IconDatabase's notifications.
(WebKit::FrameLoaderClient::dispatchDidReceiveIcon): ask both
WebView and IconDatabase to issue notifications for a new icon.
* docs/webkitgtk-docs.sgml: updated docs.
* docs/webkitgtk-sections.txt: ditto.
* docs/webkitgtk.types: ditto.
* tests/testicondatabase.c: Added.
(server_callback):
(deleteDatabaseFileIfExists):
(testWebkitIconDatabaseSetPath):
(iconDatabaseGetIconValidCallback):
(iconDatabaseGetIconInvalidCallback):
(iconDatabaseGetIconCancelledCallback):
(mainLoopQuitIfLoadCompleted):
(idleQuitLoopCallback):
(webkitWebViewIconLoaded):
(loadURI):
(faviconDatabaseGetFaviconValidIdle):
(faviconDatabaseGetFaviconInvalidIdle):
(faviconDatabaseGetFaviconCancelledIdle):
(testWebKitFaviconDatabaseGetFavicon):
(testWebKitFaviconDatabaseGetFaviconURI):
(testWebKitFaviconDatabaseRemoveAll):
(testWebKitFaviconDatabaseCloseDatabase):
(main):
* webkit/webkit.h: added new API.
* webkit/webkitdefines.h: added WebKitFaviconDatabase.
* webkit/webkitfavicondatabase.cpp:
(IconDatabaseClientGtk): IconDatabaseClient implementation.
(IconDatabaseClientGtk::performImport):
(IconDatabaseClientGtk::didRemoveAllIcons):
(IconDatabaseClientGtk::didImportIconURLForPageURL):
(IconDatabaseClientGtk::didImportIconDataForPageURL):
(IconDatabaseClientGtk::didChangeIconForPageURL):
(IconDatabaseClientGtk::didFinishURLImport):
(PendingIconRequest): machinery for asynchronous calls.
(PendingIconRequest::PendingIconRequest):
(PendingIconRequest::~PendingIconRequest):
(PendingIconRequest::pageURI):
(PendingIconRequest::asyncResult):
(PendingIconRequest::asyncResultCancel):
(PendingIconRequest::asyncResultCompleteInIdle):
(PendingIconRequest::asyncResultComplete):
(_WebKitIconDatabasePrivate):
(webkit_favicon_database_dispose): GObject stuff.
(webkit_favicon_database_set_property): ditto.
(webkit_favicon_database_get_property): ditto.
(webkit_favicon_database_class_init): ditto.
(webkit_favicon_database_init): ditto.
(webkitFaviconDatabaseNotifyAndUpdateExpiration): notify about new
icons and update expiration times.
(webkitFaviconDatabaseDispatchDidReceiveIcon): "protected" method
called by the FrameLoaderClient to inform about new icons.
(webkit_favicon_database_get_path): retrieves database path.
(selectQueryCallback): releases expired icons to let IconDatabase
prune them.
(webkitFaviconDatabasePruneExpiredIcons): selects the icons to be
pruned by the IconDatabase.
(webkitFaviconDatabaseClose): close the database.
(createExpirationTimesDatabaseTableIfNotExists): creates the
database used to control expiration times.
(webkit_favicon_database_set_path): opens the database delaying the
cleanup of icons until the import is complete.
(webkit_favicon_database_get_favicon_uri): returns the uri of the
favicon.
(getIconPixbufSynchronously): helper function to call
IconDatabase::synchronousIconURLForPageURL().
(webkit_favicon_database_try_get_favicon_pixbuf): returns the
favicon if exists and is loaded from disk.
(webkitFaviconDatabaseGetOrCreateRequests): helper function to get
the vector of pending requests for the given uri.
(webkitfavicondatabaseDeleteRequests): helper function to remove the
vector of pending requests for the given uri.
(getIconPixbufCancelled):
(webkitFaviconDatabaseGetIconPixbufCancelled):
(webkit_favicon_database_get_favicon_pixbuf): asynchronously
retrieve icons from the database.
(webkit_favicon_database_get_favicon_pixbuf_finish): finishes an
operation started with webkit_icon_database_get_icon_pixbuf().
(webkitFaviconDatabaseProcessPendingIconsForURI): process pending
requests once the import is finished.
(webkitFaviconDatabaseImportFinished): check pending requests and
delete those that ask for icons that do not exist in the database.
(webkit_favicon_database_clear): clears the database.
* webkit/webkitfavicondatabase.h: added.
(_WebKitFaviconDatabase):
(_WebKitFaviconDatabaseClass):
* webkit/webkitfavicondatabaseprivate.h: Added.
* webkit/webkitglobals.cpp:
(webkit_get_favicon_database): retrieves the new
WebKitFaviconDatabase.
(webkitExit): unref icon database on exit.
* webkit/webkitglobals.h: added new API.
* webkit/webkiticondatabase.cpp: added deprecation documentation.
(webkit_icon_database_class_init):
* webkit/webkitwebview.cpp:
(webkit_web_view_try_get_icon_pixbuf): new API that uses the new
WebKitFaviconDatabase API.
(webkitWebViewIconLoaded): dispatch the icon-loaded signal when
requested by the FrameLoaderClient.
(webkitWebViewRegisterForIconNotification): starts/stops listening
to icon database notifications.
* webkit/webkitwebview.h: added new API.
* webkit/webkitwebviewprivate.h: added some protected methods.

Tools:

Add support for favicons in GtkLauncher.

* GtkLauncher/main.c:
(activateUriEntryCb):
(iconLoadedCb):
(createBrowser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd asserts and improve logging in PageCache.
gavinp@chromium.org [Fri, 16 Mar 2012 13:25:31 +0000 (13:25 +0000)]
Add asserts and improve logging in PageCache.
https://bugs.webkit.org/show_bug.cgi?id=81179

Reviewed by Brady Eidson.

The early exits from logCanCacheFrameDecision had the potential to skew histogram data.  Moving
the DocumentLoader check to the top, but eliminating the early exits is a compromise that keeps
the logged data mostly accurate.

* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove sheriff-bot's last-green-revision command
abarth@webkit.org [Fri, 16 Mar 2012 13:13:14 +0000 (13:13 +0000)]
Remove sheriff-bot's last-green-revision command
https://bugs.webkit.org/show_bug.cgi?id=81314

Reviewed by Eric Seidel.

This command is a cruel joke.  WebKit doesn't really ever have a
last-green-revision.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot._find_green_revision):
* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuildBot.builder_statuses):
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(test_find_green_revision):
* Scripts/webkitpy/tool/bot/irc_command.py:
(IRCCommand.execute):
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_help):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview.execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] label.form attribute doesn't work
commit-queue@webkit.org [Fri, 16 Mar 2012 13:05:35 +0000 (13:05 +0000)]
[Forms] label.form attribute doesn't work
https://bugs.webkit.org/show_bug.cgi?id=80499

Patch by Yoshifumi Inoue <yosin@chromium.org> on 2012-03-16
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes implementation of label.form of IDL attribute to
compute it to the form element specified by the "form" HTML attribute
or form ancestor when the "form" HTML attribute isn't in HTML.

This patch introduces new function FormAssociatedElement::findAssociatedForm
for sharing code among FormAssociateElement::insertedIntoTree, resetFormOwner
and HTMLLabelElement::form.

No new tests. Update existing tests.

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm): Added.
(WebCore):
(WebCore::FormAssociatedElement::insertedIntoTree):
(WebCore::FormAssociatedElement::resetFormOwner):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLLabelElement.cpp: Remove unused include files
(WebCore::HTMLLabelElement::form): Added.

LayoutTests:

This patch updates test cases and expectation for functional
"form" attribute of the "label" element.

* fast/forms/form-attribute-expected.txt:
* fast/forms/form-attribute-nonexistence-form-id-expected.txt:
* fast/forms/form-attribute-nonexistence-form-id.html:
* fast/forms/form-attribute.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the normalize method of FloatPoint instead of normalizing manually
kenneth@webkit.org [Fri, 16 Mar 2012 13:00:57 +0000 (13:00 +0000)]
Use the normalize method of FloatPoint instead of normalizing manually
https://bugs.webkit.org/show_bug.cgi?id=81343

Reviewed by Simon Hausmann.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::coverWithTilesIfNeeded):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@110995 268f45cc-cd09-0410-ab3c-d52691b4dbfc