rniwa@webkit.org [Wed, 6 Apr 2011 12:59:24 +0000 (12:59 +0000)]
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872
r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
avoiding the tab span.
Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
Test: editing/inserting/insert-paragraph-separator-tab-span.html
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
separator into a paragraph separator.
2011-04-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
https://bugs.webkit.org/show_bug.cgi?id=57872
Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
style to the paragraph separator or the text.
* editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
* editing/inserting/insert-paragraph-separator-tab-span.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Wed, 6 Apr 2011 12:12:58 +0000 (12:12 +0000)]
2011-04-06 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
Add member functions for determining line/paragraph separation to InlineIterator
https://bugs.webkit.org/show_bug.cgi?id=57938
Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
InlineIterator, where it makes far more sense for them to be. Also moving
shouldPreserveNewline to RenderObject and renaming it preservesNewline.
No new tests as this provides no new functionality.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::atTextParagraphSeparator):
(WebCore::InlineIterator::atParagraphSeparator):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::requiresLineBox):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderObject.h:
(WebCore::RenderObject::preservesNewline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 6 Apr 2011 09:57:54 +0000 (09:57 +0000)]
2011-04-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Range insertNode function does not update content in the inspector
https://bugs.webkit.org/show_bug.cgi?id=57829
* inspector/elements/modify-chardata-expected.txt:
* inspector/elements/modify-chardata.html:
2011-04-05 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Range insertNode function does not update content in the inspector
https://bugs.webkit.org/show_bug.cgi?id=57829
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 09:37:32 +0000 (09:37 +0000)]
2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Improve tests for QWebFrame::url() and related methods
https://bugs.webkit.org/show_bug.cgi?id=57865
* tests/qwebframe/tst_qwebframe.cpp:
(FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
(tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
that fails and a load() that fails (for a different URL).
(tst_QWebFrame::setUrlWithFragment_data):
(tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
the URL in the frame before the test starts.
(tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
the same URL as argument.
(extractBaseUrl):
(tst_QWebFrame::setUrlThenLoads_data):
(tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
sequence of set and loads. Those tests are interesting because the properties
react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
is used or after the load() is committed and baseUrl() is similar to url() but also depends
on the contents of the page when it loads.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 09:24:20 +0000 (09:24 +0000)]
2011-04-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
getComputedTextLength always returns 0 with tspan elements
https://bugs.webkit.org/show_bug.cgi?id=19814
Add a testcase showing that getComputedTextLength for <tspan> works fine.
* svg/text/tspan-getComputedTextLength-expected.txt: Added.
* svg/text/tspan-getComputedTextLength.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 6 Apr 2011 09:03:39 +0000 (09:03 +0000)]
2011-04-06 Alejandro G. Castro <alex@igalia.com>
Fix GTK3 compilation after r82962.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
* platform/gtk/ScrollbarThemeGtk3.cpp:
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 6 Apr 2011 08:24:28 +0000 (08:24 +0000)]
2011-04-06 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] remove inspectedPage.* events
https://bugs.webkit.org/show_bug.cgi?id=57763
- Removed webInspector.inspectedPage.* events
- moved onNavigated to webInspector.resources
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI):
(WebInspector.injectedExtensionAPI.InspectedWindow):
* inspector/front-end/ExtensionAPISchema.json:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
* inspector/front-end/inspector.js:
(WebInspector.domContentEventFired):
(WebInspector.loadEventFired):
(WebInspector.inspectedURLChanged):
2011-04-06 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] remove inspectedPage.* events
https://bugs.webkit.org/show_bug.cgi?id=57763
- Removed webInspector.inspectedPage.* events
- moved onNavigated to webInspector.resources
* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.runWhenPageLoads):
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.InspectorTest.runWhenPageLoads.chainedCallback):
(initialize_InspectorTest.InspectorTest.runWhenPageLoads):
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Wed, 6 Apr 2011 08:10:05 +0000 (08:10 +0000)]
2011-04-06 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Antti Koivisto.
Add <head> to the simpleUserAgentStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=57915
* css/CSSStyleSelector.cpp:
(WebCore::elementCanUseSimpleDefaultStyle): add head to the
simple stylesheet, display:none.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Wed, 6 Apr 2011 08:03:27 +0000 (08:03 +0000)]
2011-04-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57856
Test: inspector/profiler/detailed-heapshots-summary.html
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
2011-04-05 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
https://bugs.webkit.org/show_bug.cgi?id=57856
* http/tests/inspector/inspector-test.js:
(initialize_InspectorTest.):
(initialize_InspectorTest):
* inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
* inspector/profiler/detailed-heapshots-summary.html: Added.
* inspector/profiler/detailed-heapshots-test.js: Added.
* platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 6 Apr 2011 07:50:47 +0000 (07:50 +0000)]
2011-04-06 Ojan Vafai <ojan@chromium.org>
http://trac.webkit.org/changeset/83024 incorrectly removed the mac-leopard results.
Instead, it should have moved the results from chromium-mac to chromium-mac-leopard.
* platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open3-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open4-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open5-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-open6-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-position-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac-leopard/fast/inline-block/inline-block-vertical-align-expected.png: Added.
* platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-length-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-runs-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-runs-spans-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/ruby-trailing-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 07:46:22 +0000 (07:46 +0000)]
2011-04-06 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin.
[Qt] SmartReplaceQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40261
This patch does not require new test cases.
* editing/qt/SmartReplaceQt.cpp:
(WebCore::isCharacterSmartReplaceExempt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 6 Apr 2011 07:40:50 +0000 (07:40 +0000)]
2011-04-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed.
Add missing pixel test result.
* platform/mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
* platform/mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Wed, 6 Apr 2011 07:38:43 +0000 (07:38 +0000)]
2011-04-06 James Kozianski <koz@chromium.org>
[chromium] Add expectations for failing GPU tests.
https://bugs.webkit.org/show_bug.cgi?id=57926
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 07:22:26 +0000 (07:22 +0000)]
2011-04-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Ryosuke Niwa.
REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
https://bugs.webkit.org/show_bug.cgi?id=57755
* editing/execCommand/insert-line-break-onload-expected.txt: Added.
* editing/execCommand/insert-line-break-onload.html: Added to check calling InsertLineBreak without any crash.
2011-04-06 Naoki Takano <takano.naoki@gmail.com>
Reviewed by Ryosuke Niwa.
REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
https://bugs.webkit.org/show_bug.cgi?id=57755
Test: editing/execCommand/insert-line-break-onload.html
* editing/TypingCommand.cpp:
(WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Wed, 6 Apr 2011 06:50:42 +0000 (06:50 +0000)]
2011-04-05 James Kozianski <koz@chromium.org>
[chromium] Rebaseline images after r82969
Rebaseline for missed linux test in r83019.
* platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed.
* platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 6 Apr 2011 06:39:13 +0000 (06:39 +0000)]
2011-04-05 Shane Stephens <shanestephens@google.com>
Reviewed by Ojan Vafai.
[Chromium] Greening the Mac 10.5 and 10.6 trees.
https://bugs.webkit.org/show_bug.cgi?id=57924
Rebaselines a bunch of tests with differences due to text anti-aliasing.
(Prepared using rebaseline script)
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-position-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/list-marker-expected.png:
* platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Removed.
* platform/chromium-mac/fast/ruby/ruby-length-expected.png: Removed.
* platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Removed.
* platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Removed.
* platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Removed.
* platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/css/background-clip-values-expected.checksum: Added.
* platform/mac/fast/css/background-clip-values-expected.png: Added.
* platform/mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
* platform/mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
* platform/mac/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
* platform/mac/fast/gradients/gradient-after-transparent-border-expected.png: Added.
* platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
* platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
* platform/mac/media/controls-without-preload-expected.checksum: Added.
* platform/mac/media/controls-without-preload-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 06:29:53 +0000 (06:29 +0000)]
2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by David Levin.
Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566
* public/WebContextMenuData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 6 Apr 2011 06:27:23 +0000 (06:27 +0000)]
Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
https://bugs.webkit.org/show_bug.cgi?id=57914
Reviewed by Cameron Zwarich.
Don't call adjustedDeferredRepaintDelay unnecessarily.
* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::adjustedDeferredRepaintDelay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 06:01:02 +0000 (06:01 +0000)]
2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r83007.
http://trac.webkit.org/changeset/83007
https://bugs.webkit.org/show_bug.cgi?id=57920
Broke WebFrameTest.FrameForEnteredContext on Chromium-win and
Chromium-mac (Requested by tkent on #webkit).
* WebKit.gyp:
* WebKit.gypi:
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::WebFrameTest):
(WebKit::WebFrameTest::registerMockedURLLoad):
(WebKit::WebFrameTest::serveRequests):
(WebKit::TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 05:57:43 +0000 (05:57 +0000)]
2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Update call to SkAdvancedTypefaceMetrics to new API.
https://bugs.webkit.org/show_bug.cgi?id=57887
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::emSizeInFontUnits):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Wed, 6 Apr 2011 05:57:21 +0000 (05:57 +0000)]
2011-04-05 James Kozianski <koz@chromium.org>
Rebaseline images after r82969
https://bugs.webkit.org/show_bug.cgi?id=57917
Rebaseline for r82969, which causes slight changes in rounded corner rendering.
* platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/inset-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
* platform/chromium-linux/fast/forms/basic-selects-expected.png:
* platform/chromium-linux/fast/layers/video-layer-expected.checksum: Removed.
* platform/chromium-linux/fast/layers/video-layer-expected.png:
* platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
* platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
* platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
* platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
* platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
* platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/media/audio-controls-rendering-expected.checksum: Removed.
* platform/chromium-linux/media/audio-controls-rendering-expected.png:
* platform/chromium-linux/media/controls-after-reload-expected.checksum: Removed.
* platform/chromium-linux/media/controls-after-reload-expected.png:
* platform/chromium-linux/media/controls-strict-expected.checksum: Removed.
* platform/chromium-linux/media/controls-strict-expected.png:
* platform/chromium-linux/media/controls-styling-expected.checksum: Removed.
* platform/chromium-linux/media/controls-styling-expected.png:
* platform/chromium-linux/media/controls-without-preload-expected.checksum: Removed.
* platform/chromium-linux/media/controls-without-preload-expected.png:
* platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Removed.
* platform/chromium-linux/media/media-document-audio-repaint-expected.png:
* platform/chromium-linux/media/video-controls-rendering-expected.checksum: Removed.
* platform/chromium-linux/media/video-controls-rendering-expected.png:
* platform/chromium-linux/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-linux/media/video-display-toggle-expected.png:
* platform/chromium-linux/media/video-empty-source-expected.checksum: Removed.
* platform/chromium-linux/media/video-empty-source-expected.png:
* platform/chromium-linux/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-linux/media/video-no-audio-expected.png:
* platform/chromium-linux/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-linux/media/video-volume-slider-expected.png:
* platform/chromium-linux/media/video-zoom-controls-expected.checksum: Removed.
* platform/chromium-linux/media/video-zoom-controls-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win-xp/media/controls-after-reload-expected.checksum: Removed.
* platform/chromium-win-xp/media/controls-after-reload-expected.png: Removed.
* platform/chromium-win-xp/media/controls-strict-expected.checksum: Removed.
* platform/chromium-win-xp/media/controls-strict-expected.png: Removed.
* platform/chromium-win-xp/media/controls-styling-expected.checksum: Removed.
* platform/chromium-win-xp/media/controls-styling-expected.png: Removed.
* platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Removed.
* platform/chromium-win-xp/media/controls-without-preload-expected.png: Removed.
* platform/chromium-win-xp/media/video-controls-rendering-expected.checksum: Removed.
* platform/chromium-win-xp/media/video-controls-rendering-expected.png: Removed.
* platform/chromium-win-xp/media/video-zoom-controls-expected.checksum: Removed.
* platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
* platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/inset-expected.png:
* platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
* platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-expected.png:
* platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
* platform/chromium-win/fast/forms/basic-selects-expected.png:
* platform/chromium-win/fast/layers/video-layer-expected.checksum: Removed.
* platform/chromium-win/fast/layers/video-layer-expected.png:
* platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
* platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
* platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
* platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
* platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
* platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/media/audio-controls-rendering-expected.checksum: Removed.
* platform/chromium-win/media/audio-controls-rendering-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.checksum: Removed.
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-strict-expected.checksum: Removed.
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.checksum: Removed.
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.checksum: Removed.
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Removed.
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.checksum: Removed.
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.checksum: Removed.
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-empty-source-expected.checksum: Removed.
* platform/chromium-win/media/video-empty-source-expected.png:
* platform/chromium-win/media/video-no-audio-expected.checksum: Removed.
* platform/chromium-win/media/video-no-audio-expected.png:
* platform/chromium-win/media/video-volume-slider-expected.checksum: Removed.
* platform/chromium-win/media/video-volume-slider-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.checksum: Removed.
* platform/chromium-win/media/video-zoom-controls-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 6 Apr 2011 05:21:20 +0000 (05:21 +0000)]
[wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch to deps.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Wed, 6 Apr 2011 05:11:56 +0000 (05:11 +0000)]
2011-04-05 Kent Tamura <tkent@chromium.org>
[Chromium] Update expectation images for a Skia rounded rectangle change (r83002).
https://bugs.webkit.org/show_bug.cgi?id=57907
* platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
* platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
* platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/inset-expected.png:
* platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
* platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
* platform/chromium-linux/fast/forms/basic-selects-expected.png:
* platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
* platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
* platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
* platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
* platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
* platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
* platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
* platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
* platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
* platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/inset-expected.png:
* platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
* platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-expected.png:
* platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
* platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
* platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
* platform/chromium-win/fast/forms/basic-selects-expected.png:
* platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
* platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
* platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
* platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
* platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
* platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
* platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
* platform/chromium-win/fast/transforms/shadows-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 6 Apr 2011 04:35:01 +0000 (04:35 +0000)]
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Rename event dispatching functions after form event removal
https://bugs.webkit.org/show_bug.cgi?id=57908
* dom/InputElement.cpp:
(WebCore::InputElement::setValueFromRenderer):
* dom/Node.cpp:
(WebCore::Node::dispatchChangeEvent):
(WebCore::Node::dispatchInputEvent):
(WebCore::Node::defaultEventHandler):
* dom/Node.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
Renamed "events" to "event", since there is only one event to dispatch now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 03:58:08 +0000 (03:58 +0000)]
2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82978, r82999, and r83001.
http://trac.webkit.org/changeset/82978
http://trac.webkit.org/changeset/82999
http://trac.webkit.org/changeset/83001
https://bugs.webkit.org/show_bug.cgi?id=57913
Does not work in Python 2.5 (Requested by abarth on #webkit).
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/common/system/executive_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 03:56:29 +0000 (03:56 +0000)]
2011-04-05 Anders Bakken <agbakken@gmail.com>
Reviewed by David Levin.
[Qt] DragControllerQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40258
This patch does not require new test cases.
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::dragOperation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 03:53:10 +0000 (03:53 +0000)]
2011-04-05 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by David Levin.
Update deprecated include: platform_canvas_win.h to platform_canvas.h.
https://bugs.webkit.org/show_bug.cgi?id=57896
* platform/graphics/chromium/FontChromiumWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 6 Apr 2011 03:49:23 +0000 (03:49 +0000)]
Try to fix the Windows build.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Who likes export files? I do!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 6 Apr 2011 03:44:48 +0000 (03:44 +0000)]
2011-04-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Introduced the concept of opaque roots, in preparation for marking the DOM with them
https://bugs.webkit.org/show_bug.cgi?id=57903
* JavaScriptCore.exp: Who likes export files? I do!
* collector/handles/HandleHeap.cpp:
(JSC::isValidWeakHandle): Factored out a helper function for ASSERTs.
(JSC::WeakHandleOwner::~WeakHandleOwner): Moved from header to avoid
weak linkage problems.
(JSC::WeakHandleOwner::isReachableFromOpaqueRoots): New callback.
Currently unused.
(JSC::WeakHandleOwner::finalize): Switched from pure virtual to a
default empty implementation, since not all clients necessarily want
or need non-trivial finalizers.
(JSC::HandleHeap::markWeakHandles): Split updateWeakHandles into two
passes. The first pass marks all reachable weak handles. The second pass
finalizes all unreachable weak handles. This must be two passes because
we don't know the set of finalizable weak handles until we're done
marking all weak handles.
(JSC::HandleHeap::finalizeWeakHandles): Use new helper function.
* collector/handles/HandleHeap.h: Ditto.
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots):
(JSC::Heap::reset): Split out handle marking from handle finalization.
* runtime/MarkStack.cpp:
(JSC::MarkStack::reset):
* runtime/MarkStack.h:
(JSC::MarkStack::addOpaqueRoot):
(JSC::MarkStack::containsOpaqueRoot):
(JSC::MarkStack::opaqueRootCount):
(JSC::HeapRootMarker::markStack): New helper functions for managing the
set of opaque roots.
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::finalize): Renamed to match parent class declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 03:05:04 +0000 (03:05 +0000)]
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694
Unskip passed tests.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleNumberOfPages):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::numberOfPages):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.numberOfPages
https://bugs.webkit.org/show_bug.cgi?id=42694
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::numberOfPages):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 6 Apr 2011 02:20:00 +0000 (02:20 +0000)]
2011-04-05 Tony Chang <tony@chromium.org>
Reviewed by Mihai Parparita.
[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
https://bugs.webkit.org/show_bug.cgi?id=57889
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
koz@chromium.org [Wed, 6 Apr 2011 02:06:56 +0000 (02:06 +0000)]
2011-04-05 James Kozianski <koz@chromium.org>
Unreviewed, rolling out r82976.
http://trac.webkit.org/changeset/82976
https://bugs.webkit.org/show_bug.cgi?id=57566
Breaks chromium canary build
* public/WebContextMenuData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aa@chromium.org [Wed, 6 Apr 2011 01:55:40 +0000 (01:55 +0000)]
2011-04-05 Aaron Boodman <aa@chromium.org>
Reviewed by Adam Barth.
Add ability to get frame from v8 context to chromium WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57516
* public/WebFrame.h:
* src/WebFrameImpl.cpp:
(WebKit::WebFrame::frameForV8Context):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 6 Apr 2011 01:28:52 +0000 (01:28 +0000)]
Try to fix Leopard bots.
* platform/mac/HTMLConverter.mm: Fix #if back the way Alexey seems
to have intended it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 6 Apr 2011 01:00:41 +0000 (01:00 +0000)]
Try to fix Leopard bots.
* platform/mac/HTMLConverter.mm: Move declarations of new functions
inside the appropriate #if.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 6 Apr 2011 00:55:34 +0000 (00:55 +0000)]
2011-04-05 Darin Adler <darin@apple.com>
Reviewed by Alexey Proskuryakov.
[Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
https://bugs.webkit.org/show_bug.cgi?id=57893
<rdar://problem/9130486>
* UIProcess/API/mac/PageClientImpl.h: Added executeSavedCommandBySelector.
* UIProcess/API/mac/PageClientImpl.mm: Renamed internal Objective-C classes to use
the WebKit2 Objective-C class prefix, WK, rather than the WebKit1 Objective-C class
prefix, Web. Removed some unneeded explicit WebKit namespace prefixes.
(-[WKEditCommandObjC initWithWebEditCommandProxy:]): Removed unneeded WebKit
namespace prefix.
(-[WKEditCommandObjC command]): Ditto.
(-[WKEditorUndoTargetObjC undoEditing:]): Updated for new class name.
(-[WKEditorUndoTargetObjC redoEditing:]): Ditto.
(WebKit::PageClientImpl::PageClientImpl): Ditto.
(WebKit::PageClientImpl::registerEditCommand): Ditto.
(WebKit::PageClientImpl::executeSavedCommandBySelector): Added.
* UIProcess/API/mac/WKView.mm: Renamed internal Objective-C categories to use the
WebKit2 Objective-C prefix, WK, rather than the WebKit1 Objective-C prefix, Web,
or no prefix at all. Tweaked use of extern "C" a little.
(-[WKView doCommandBySelector:]): Tweaked the comment.
(-[WKView _executeSavedCommandBySelector:]): Added. For use when command is not handled
by WebCore.
(-[WKResponderChainSink initWithResponderChain:]): Added. Based on the
WebResponderChainSink class in WebKit1.
(-[WKResponderChainSink detach]): Added.
(-[WKResponderChainSink didReceiveUnhandledCommand]): Added.
(-[WKResponderChainSink noResponderFor:]): Added.
(-[WKResponderChainSink doCommandBySelector:]): Added.
(-[WKResponderChainSink tryToPerform:with:]): Added.
* UIProcess/API/mac/WKViewInternal.h: Added declaration of _executeSavedCommandBySelector:
method. Also removed unneeded includes.
* UIProcess/PageClient.h: Added executeSavedCommandBySelector.
* UIProcess/WebPageProxy.h: Added executeSavedCommandBySelector.
* UIProcess/WebPageProxy.messages.in: Added ExecuteSavedCommandBySelector.
* UIProcess/mac/WebFullScreenManagerProxyMac.mm: Updated includes.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::executeSavedCommandBySelector): Added.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal): Send the synchronous
ExecuteSavedCommandBySelector message when a command is not handled by WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 6 Apr 2011 00:31:56 +0000 (00:31 +0000)]
2011-04-05 Adrienne Walker <enne@google.com>
Unreviewed, temporarily mark two tests as more generally failing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 6 Apr 2011 00:28:28 +0000 (00:28 +0000)]
2011-04-05 Adrienne Walker <enne@google.com>
Reviewed by Tony Chang.
Correctly set color when using skia's fillRoundedRect.
https://bugs.webkit.org/show_bug.cgi?id=57907
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillRoundedRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 6 Apr 2011 00:28:23 +0000 (00:28 +0000)]
2011-04-05 Adam Barth <abarth@webkit.org>
Silly with statement, from the future!
* Scripts/webkitpy/common/system/executive.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 6 Apr 2011 00:22:17 +0000 (00:22 +0000)]
Reviewed by Darin Adler.
Move attributedStringFromRange down to WebCore
https://bugs.webkit.org/show_bug.cgi?id=57905
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 5 Apr 2011 23:54:34 +0000 (23:54 +0000)]
2011-04-05 Adam Barth <abarth@webkit.org>
Reviewed by Tony Chang.
Don't use Exception.message because it's deprecated
https://bugs.webkit.org/show_bug.cgi?id=57892
Suppress the warning for now. When we move to Python 3, we might need
to something more dramatic.
* Scripts/webkitpy/common/system/executive.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 5 Apr 2011 23:17:48 +0000 (23:17 +0000)]
2011-04-05 Mihai Parparita <mihaip@chromium.org>
Reviewed by Ojan Vafai.
Add builders.js to dashboard file list
https://bugs.webkit.org/show_bug.cgi?id=57899
Add file added by http://crrev.com/80538 to dashboard file list.
* TestResultServer/handlers/dashboardhandler.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 23:03:33 +0000 (23:03 +0000)]
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Alexey Proskuryakov.
Some plug-in content is displayed upside down in Unity plug-in
https://bugs.webkit.org/show_bug.cgi?id=57895
<rdar://problem/9212003>
Create the flipped geometry layer in the web process instead of the plug-in process,
which matches what we do in WebKit1.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Tue, 5 Apr 2011 22:59:47 +0000 (22:59 +0000)]
2011-04-05 Nico Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Don't have 'using namespace' declarations in header files
https://bugs.webkit.org/show_bug.cgi?id=57882
* src/EventListenerWrapper.cpp:
* src/EventListenerWrapper.h:
* src/VideoFrameChromiumImpl.h:
* src/WebDOMEventListener.cpp:
* src/WebDOMEventListenerPrivate.cpp:
* src/WebDOMEventListenerPrivate.h:
(WebKit::WebDOMEventListenerPrivate::ListenerInfo::ListenerInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 5 Apr 2011 22:50:13 +0000 (22:50 +0000)]
2011-04-05 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Rename variables in border drawing code for readability
https://bugs.webkit.org/show_bug.cgi?id=57894
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::drawBoxSideFromPath):
(WebCore::RenderObject::drawArcForBoxSide):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 5 Apr 2011 22:29:33 +0000 (22:29 +0000)]
Defer repaints during style recalc
https://bugs.webkit.org/show_bug.cgi?id=57886
Reviewed by Darin Adler.
This reduces the need to do (often expensive) platform surface invalidation.
We already do this during layout but style recalculation may trigger
invalidation as well.
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Tue, 5 Apr 2011 22:23:18 +0000 (22:23 +0000)]
2011-04-05 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
HTML5 Player Has no Fullscreen Mode
https://bugs.webkit.org/show_bug.cgi?id=57795
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen): Call the new ChromeClient API
supportsFullScreenForElement() before the old supportsFullScreenForNode() API.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 5 Apr 2011 22:10:09 +0000 (22:10 +0000)]
3 tests fail on apple-macpro-6 (due to different JS MIME type) but not any other Leopard
slaves.
https://bugs.webkit.org/show_bug.cgi?id=56564
Skip fast/preloader/scan-body-from-head-script.html on Leopard to get the bots green.
* platform/mac-leopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wjmaclean@chromium.org [Tue, 5 Apr 2011 22:07:47 +0000 (22:07 +0000)]
Added wjmaclean@chromium.org to WebKit committers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Tue, 5 Apr 2011 22:04:43 +0000 (22:04 +0000)]
2011-04-05 Balazs Kelemen <kbalazs@webkit.org>
Reviewed by Darin Adler.
Build fix for YarrParser.h
https://bugs.webkit.org/show_bug.cgi?id=57822
* yarr/YarrParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::CharacterClassParserDelegate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 5 Apr 2011 22:03:51 +0000 (22:03 +0000)]
Follow-up Windows build fix.
Don't skip react-to-vsprops-changes.py for all production builds,
only those initiated via JavaScriptCore.make.
* JavaScriptCore.vcproj/JavaScriptCore.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 5 Apr 2011 22:01:29 +0000 (22:01 +0000)]
2011-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Darin Adler.
REGRESSION (r82849): 85,000+ JSC-related leaks seen on SnowLeopard Intel Leaks
https://bugs.webkit.org/show_bug.cgi?id=57857
Whoops, accidentally removed a deref().
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 21:59:09 +0000 (21:59 +0000)]
2011-04-05 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: fix data url's status and timing the network panel.
https://bugs.webkit.org/show_bug.cgi?id=53066
Added data url support for status of network resources.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.isDataURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 5 Apr 2011 21:53:54 +0000 (21:53 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Add per-configuration vsprops files.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Removed inheritance from common.vsprops.
Set production environment variable before calling make.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebug.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedProduction.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedRelease.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedReleasePGO.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 21:25:40 +0000 (21:25 +0000)]
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Assertion failure when navigating quickly between file URLs
https://bugs.webkit.org/show_bug.cgi?id=57884
<rdar://problem/9080559>
Remove bogus assertion. The pending provisional sandbox extension can be
non-null if the current provisional load fails because we're about to load a new
page that also has a sandbox extension.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Tue, 5 Apr 2011 21:20:31 +0000 (21:20 +0000)]
2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810
* bindings/v8/V8GCController.cpp:
(WebCore::GrouperVisitor::visitDOMWrapper):
2011-04-04 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Adam Barth.
[V8] Keep dirty primitive CSS values alive.
https://bugs.webkit.org/show_bug.cgi?id=57810
* platform/chromium/test_expectations.txt: Mark
fast/dom/StyleSheet/gc-inline-style-cssvalues.html as passing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 21:11:49 +0000 (21:11 +0000)]
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Grant the web process access to ~/Library/Preferences/com.apple.universalaccess.plist
https://bugs.webkit.org/show_bug.cgi?id=57879
The web process needs access to the unviersal access preferences to determine if full keyboard
access is enabled. I've filed <rdar://problem/9237619> which tracks reading this preference in the UI
process and sending it over to the web process whenever it changes.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 5 Apr 2011 21:07:29 +0000 (21:07 +0000)]
[Windows] fast/blockflow/Kusa-Makura-background-canvas.html failing since introduction in r82903
https://bugs.webkit.org/show_bug.cgi?id=57880
Update Windows expected results (with pixel tests) to greenify the bots.
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/win/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 5 Apr 2011 21:04:16 +0000 (21:04 +0000)]
2011-04-05 MORITA Hajime <morrita@google.com>
Reviewed by Adam Barth.
webkit-patch should print git's stderr when git svn dcommit fail
http://webkit.org/b/57861
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Tue, 5 Apr 2011 20:59:33 +0000 (20:59 +0000)]
[Windows Tests] fast/dom/Window/window-property-descriptors.html failing since r82925.
https://bugs.webkit.org/show_bug.cgi?id=57881
Update the Windows-specific results to get the bots green.
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
onformchange and onforminput were removed in r82925.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 20:44:21 +0000 (20:44 +0000)]
2011-04-05 Zelidrag Hornung <zelidrag@chromium.org>
Reviewed by David Levin.
Added MediaTypeFile enum value to WebContextMenuData::MediaType.
https://bugs.webkit.org/show_bug.cgi?id=57566
* public/WebContextMenuData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 5 Apr 2011 20:37:15 +0000 (20:37 +0000)]
2011-04-05 Tony Chang <tony@chromium.org>
Unreviewed, removing the chromium-win results causes this test to
start passing on chromium win and linux.
* platform/chromium-win/fast/images/svg-as-tiled-background-expected.checksum: Removed.
* platform/chromium-win/fast/images/svg-as-tiled-background-expected.png: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Tue, 5 Apr 2011 20:34:03 +0000 (20:34 +0000)]
2011-04-05 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser.
Add parentheses around && within || to avoid clang warning.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 20:26:38 +0000 (20:26 +0000)]
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Add two more entries to the sandbox profile
https://bugs.webkit.org/show_bug.cgi?id=57875
Allow read-access to /Library/Dictionaries since WebCore::nextBreakablePosition
ends up calling into ICU which accesses the dictionary.
Allow Mach access to com.apple.networkd since it's used by CFNetwork.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 5 Apr 2011 20:03:18 +0000 (20:03 +0000)]
2011-04-05 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Add --baseline-search-path to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56233
Add NRWT option to specify additional directories to look for baselines
(will be used by hardware GPU bots which will have local per-bot
expectations for some tests)
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 5 Apr 2011 20:03:08 +0000 (20:03 +0000)]
2011-04-05 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Make caches window show more info about non-jsobject GC values
https://bugs.webkit.org/show_bug.cgi?id=57874
Add ClassInfo to the various internal JS types that currently
don't have any, and make the text for caches window show the
classname for non-JSObject instances.
* runtime/Executable.cpp:
* runtime/Executable.h:
(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::createStructure):
(JSC::ProgramExecutable::createStructure):
(JSC::FunctionExecutable::createStructure):
* runtime/Heap.cpp:
(JSC::TypeCounter::typeName):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/ScopeChain.cpp:
* runtime/ScopeChain.h:
(JSC::ScopeChainNode::createStructure):
* runtime/StructureChain.cpp:
* runtime/StructureChain.h:
(JSC::StructureChain::createStructure):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 20:02:42 +0000 (20:02 +0000)]
2011-04-05 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Invalidate callbacks if the WebPageProxy is no longer valid
https://bugs.webkit.org/show_bug.cgi?id=57873
<rdar://problem/9059717>
Audit all function calls that take callbacks and make sure to invalidate the callbacks
if the web page is no longer valid.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::getSourceForFrame):
(WebKit::WebPageProxy::getContentsAsString):
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::getMainResourceDataOfFrame):
(WebKit::WebPageProxy::getResourceDataFromFrame):
(WebKit::WebPageProxy::getWebArchiveOfFrame):
(WebKit::WebPageProxy::forceRepaint):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToPDF):
(WebKit::WebPageProxy::drawPagesToPDF):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 5 Apr 2011 20:01:56 +0000 (20:01 +0000)]
2011-04-04 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adele Peterson.
Add a fast path for simple color backgrounds
https://bugs.webkit.org/show_bug.cgi?id=57773
Add a fast path for drawing simple color backgrounds. It's
faster to fill a path or rect than it is to set up a clip,
and then paint the rect.
No visible behavior change so no new tests.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Tue, 5 Apr 2011 19:59:28 +0000 (19:59 +0000)]
2011-04-05 Patrick Gansterer <paroga@webkit.org>
Unreviewed EFL build fix for r82962.
* CMakeListsEfl.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 5 Apr 2011 19:39:42 +0000 (19:39 +0000)]
Strip off /results.html from results URLs before trying to load leaks files from them
r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
files, rather than pointing to the directory that contains them. This is more convenient for
people browsing build.webkit.org, but confused Leaks Viewer.
Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
list don't work
Reviewed by Joseph Pecoraro.
* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 5 Apr 2011 19:33:44 +0000 (19:33 +0000)]
Disable accelerated compositing on Windows machines that don't support it
This includes machines without the necessary graphics hardware, and machines without
WebKitQuartzCoreAdditions (like the Windows 7 Release (WebKit2 Tests) bots).
Fixes <http://webkit.org/b/57870> REGRESSION (r82960): Lots of tests crashing in
DrawingAreaImpl::enterAcceleratedCompositingMode on Windows 7 Release (WebKit2 Tests)
Reviewed by Anders Carlsson.
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. On platforms other than
Windows, this always returns true.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Only enable accelerated compositing-related
preferences if the machine supports accelerated compositing.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::supportsAcceleratedCompositing): Added. Creates a view, asks it
if it can draw, and returns the result.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Added supportsAcceleratedCompositing.
* WebProcess/WebPage/win/LayerTreeHostWin.cpp: Added.
(WebKit::LayerTreeHost::supportsAcceleratedCompositing): Added. Calls through to
LayerTreeHostCAWin in configurations that support that class. Otherwise just returns false.
* win/WebKit2.vcproj: Added LayerTreeHostWin.cpp. Let VS reorder some other files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 5 Apr 2011 19:18:51 +0000 (19:18 +0000)]
2011-04-05 David Levin <levin@chromium.org>
Reviewed by Jian Li.
[chromium] send-sliced-dragged-file.html started to crash on chromium bots
https://bugs.webkit.org/show_bug.cgi?id=57539
* platform/chromium/test_expectations.txt: Removed passing test
as it has been fixed in the chromium network stack as of chromium r80114
and it was introduced in r79905 so no need to change the chromium deps
since it is before the regression.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 5 Apr 2011 19:17:08 +0000 (19:17 +0000)]
2011-04-05 Adrienne Walker <enne@google.com>
Unreviewed, mark unexpectedly passing Linux Chromium tests as such.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Tue, 5 Apr 2011 18:59:53 +0000 (18:59 +0000)]
2011-04-05 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
Add support for offline audio rendering to AudioContext API
https://bugs.webkit.org/show_bug.cgi?id=57676
No new tests since audio API is not yet implemented.
* DerivedSources.make:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContextConstructor::constructJSAudioContext):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
* bindings/v8/custom/V8AudioContextCustom.cpp:
(WebCore::V8AudioContext::constructorCallback):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):
* dom/Event.cpp:
(WebCore::Event::isOfflineAudioCompletionEvent):
* dom/Event.h:
* dom/EventTarget.cpp:
(WebCore::EventTarget::toAudioContext):
* dom/EventTarget.h:
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):
* platform/audio/HRTFDatabaseLoader.h:
(WebCore::HRTFDatabaseLoader::loader):
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOfflineContext):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::document):
(WebCore::AudioContext::scriptExecutionContext):
(WebCore::AudioContext::toAudioContext):
(WebCore::AudioContext::startRendering):
(WebCore::AudioContext::fireCompletionEvent):
* webaudio/AudioContext.h:
(WebCore::AudioContext::isOfflineContext):
(WebCore::AudioContext::eventTargetData):
(WebCore::AudioContext::ensureEventTargetData):
(WebCore::AudioContext::refEventTarget):
(WebCore::AudioContext::derefEventTarget):
* webaudio/AudioContext.idl:
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::reset):
(WebCore::AudioDestinationNode::numberOfChannels):
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):
* webaudio/DefaultAudioDestinationNode.cpp: Added.
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::~DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::uninitialize):
(WebCore::DefaultAudioDestinationNode::startRendering):
* webaudio/DefaultAudioDestinationNode.h: Added.
(WebCore::DefaultAudioDestinationNode::create):
(WebCore::DefaultAudioDestinationNode::sampleRate):
* webaudio/OfflineAudioCompletionEvent.cpp: Added.
(WebCore::OfflineAudioCompletionEvent::create):
(WebCore::OfflineAudioCompletionEvent::OfflineAudioCompletionEvent):
(WebCore::OfflineAudioCompletionEvent::~OfflineAudioCompletionEvent):
(WebCore::OfflineAudioCompletionEvent::isOfflineAudioCompletionEvent):
* webaudio/OfflineAudioCompletionEvent.h: Added.
(WebCore::OfflineAudioCompletionEvent::renderedBuffer):
* webaudio/OfflineAudioCompletionEvent.idl: Added.
* webaudio/OfflineAudioDestinationNode.cpp: Added.
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::~OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::initialize):
(WebCore::OfflineAudioDestinationNode::uninitialize):
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::renderEntry):
(WebCore::OfflineAudioDestinationNode::render):
(WebCore::OfflineAudioDestinationNode::notifyCompleteDispatch):
(WebCore::OfflineAudioDestinationNode::notifyComplete):
* webaudio/OfflineAudioDestinationNode.h: Added.
(WebCore::OfflineAudioDestinationNode::create):
(WebCore::OfflineAudioDestinationNode::sampleRate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 5 Apr 2011 18:40:21 +0000 (18:40 +0000)]
2011-04-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.
No new tests. This patch is only a code cleanup.
* GNUmakefile.am:
* platform/graphics/GraphicsContext.h: The platform context is no longer a
cairo_t, but our new class the PlatformContextCairo.
* platform/graphics/cairo/ContextShadowCairo.cpp: Updated to reflect new class.j
* platform/graphics/cairo/FontCairo.cpp: Ditto.
* platform/graphics/cairo/GradientCairo.cpp: Ditto.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Mostly mechanical
changes which now reference platformContext()->cr() to get the cairo_t.
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: Now hold the
PlatformContextCairo instead of the cairo_t.
* platform/graphics/cairo/ImageBufferCairo.cpp: Update to reflect new class.
* platform/graphics/cairo/ImageCairo.cpp: Ditto.
* platform/graphics/cairo/PathCairo.cpp: Ditto.
* platform/graphics/cairo/PlatformContextCairo.cpp: Added.
* platform/graphics/cairo/PlatformContextCairo.h: Added.
* platform/graphics/gtk/FontGtk.cpp: Update to reflect new class.
* platform/graphics/gtk/IconGtk.cpp: Ditto.
* platform/graphics/win/GraphicsContextCairoWin.cpp: Now fill out
m_data with a private section containing the platform context instead of
just a cairo_t.
* platform/gtk/RenderThemeGtk.cpp: Update to reflect new class.
* platform/gtk/WidgetRenderingContext.cpp: Ditto.
(WebCore::WidgetRenderingContext::~WidgetRenderingContext): Ditto.
* plugins/gtk/PluginViewGtk.cpp: Ditto.
2011-04-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
Add a PlatformContextCairo which right now stores the cairo_t* for a
GraphicsContextCairo. Later patches will move logic for tracking ContextShadow
and image masking layers into this PlatformContextCairo class.
* webkit/webkitwebframe.cpp:
(draw_page_callback):
* webkit/webkitwebview.cpp:
(webkit_web_view_expose_event):
(webkit_web_view_draw):
2011-04-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
* WebFrame.cpp:
(hdcFromContext): Modify this method to take PlatformContextCairo
instead of a cairo_t.
(WebFrame::spoolPage): Update to reflect new platform context.
(WebFrame::spoolPages): Ditto.
* WebFrame.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 5 Apr 2011 18:36:53 +0000 (18:36 +0000)]
2011-04-05 Adrienne Walker <enne@google.com>
Unreviewed, mark some unexpectedly passing Chromium tests as such.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 5 Apr 2011 18:01:52 +0000 (18:01 +0000)]
Make accelerated compositing work in WebKit2 on Windows
LayerTreeHostCAWin uses WKCACFView to render each frame to an image, then has
DrawingAreaImpl send that image over to the UI process (just like it does for
non-accelerated rendering). It's unfortunate that this requires reading every frame back
from the GPU into system memory. More efficient solutions can be explored in the future.
Fixes <http://webkit.org/b/45567>.
Reviewed by Anders Carlsson.
* DerivedSources.make: Added $(WebKit2) to the VPATH so that DerivedSources.make can be
found when used as a target dependency. Added rules to generate a HeaderDetection.h file on
Windows. If we can find WebKitQuartzCoreAdditions headers, we define HAVE_WKQCA in
HeaderDetection.h.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setLayerHostNeedsDisplay):
* WebProcess/WebPage/DrawingAreaImpl.h:
Added setLayerHostNeedsDisplay. Lets the layer host tell the DrawingAreaImpl that it has a
new frame to render. This should only be called by layer hosts that participate in
DrawingAreaImpl's display mechanism.
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create): Only try to instantiate LayerTreeHostCAWin if we have
WebKitQuartzCoreAdditions, since it depends on that library.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Removed code that forced accelerated compositing to be
disabled on Windows.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::registerDummyWindowClass): Registers the window class we use for the dummy window.
(WebKit::createDummyWindow): Creates the dummy window we pass to WKCACFView so that D3D can
determine the display mode, etc. (The window is never shown on screen.)
(WebKit::LayerTreeHostCAWin::LayerTreeHostCAWin): Initialize new members.
(WebKit::LayerTreeHostCAWin::platformInitialize): Create our dummy window and view and
associate the two. We set ourselves as the view's context's user data so that
PlatformCALayer can get our AbstractCACFLayerTreeHost pointer as needed.
(WebKit::LayerTreeHostCAWin::invalidate): Cancel any pending flushes, tear down our view,
and destroy the dummy window if no other layer host is using it.
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Ask LayerChangesFlusher to call us back
soon to perform the flush.
(WebKit::LayerTreeHostCAWin::participatesInDisplay): Added. Returns true, since we render
each frame to an image.
(WebKit::LayerTreeHostCAWin::needsDisplay): Added. Returns true if it's now time to
displayReturns true if it's now time to display.
(WebKit::LayerTreeHostCAWin::timeUntilNextDisplay): Added. Returns how many seconds remain
before we need to display again.
(WebKit::size): Added. Helper function to get the size of a WKCACFImage.
(WebKit::toShareableBitmap): Added. Helper function to convert a WKCACFImage to a
ShareableBitmap.
(WebKit::LayerTreeHostCAWin::display): Added. Renders the next frame to an image and stuffs
the image into the UpdateInfo struct.
(WebKit::LayerTreeHostCAWin::sizeDidChange): Added. Tells the view about the new size.
(WebKit::LayerTreeHostCAWin::forceRepaint): Added. Flushes any pending changes to the view.
(WebKit::LayerTreeHostCAWin::contextDidChangeCallback): Added. WKCACFView calls this
whenever any changes made to the view or its layer tree have been flushed. Just calls
through to contextDidChange.
(WebKit::LayerTreeHostCAWin::contextDidChange): Added. Tells layers that they've started
animating, and tells the DrawingAreaImpl that we need to display again.
(WebKit::LayerTreeHostCAWin::rootLayer): Added. Gets the root layer's PlatformCALayer.
(WebKit::LayerTreeHostCAWin::addPendingAnimatedLayer): Added. Stores the layer so that we
can tell it animations have started the next time we get a contextDidChange callback.
(WebKit::LayerTreeHostCAWin::layerTreeDidChange): Added. Schedules a flush, unless we're
already in the process of flushing. This code came from WebCore::WKCACFViewLayerTreeHost.
(WebKit::LayerTreeHostCAWin::flushPendingLayerChangesNow): Added. Performs the flush. This
code was adapted from WebCore::WKCACFViewLayerTreeHost.
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h: Wrapped this whole header in HAVE(WKQCA),
since this class only works when WebKitQuartzCoreAdditions is available. Added a bunch of
new members.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Tue, 5 Apr 2011 18:01:12 +0000 (18:01 +0000)]
Add a way for LayerTreeHost to participate in DrawingAreaImpl's normal display mechanism
When LayerTreeHost participates in display, it renders each frame into a bitmap.
DrawingAreaImpl sends the bitmap to the UI process in an Update message, just like in
non-accelerated compositing mode. The UI process never knows that accelerated compositing is
going on. (When LayerTreeHost does not participate in display, as on Mac, it is responsible
for getting bits from the web process to the UI process.)
No LayerTreeHost uses this mechanism (yet). This patch should cause no change in behavior.
Fixes <http://webkit.org/b/57792> LayerTreeHost needs a way to render frames to a bitmap
Reviewed by Anders Carlsson.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint): If the layer tree host participates in display,
perform a display (like in the non-accelerated case).
(WebKit::DrawingAreaImpl::layerHostDidFlushLayers): Don't send an
EnterAcceleratedCompositing message to the UI process if the layer tree host participates in
display. In that case, the UI process doesn't even need to know we're using accelerated
compositing in the web process.
(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState): Go through the normal display
mechanism if we have a layer tree host that participates in display.
(WebKit::DrawingAreaImpl::didUpdate): Don't ignore DidUpdate messages when we have a layer
tree host that participates in display.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): If the new layer tree host
participates in display, let the display timer continue to run and continue to expect
DidUpdate messages so that we don't interrupt the normal display mechanism. We still clear
out m_dirtyRegion, m_scrollRect, and m_scrollOffset, though, because the layer tree host is
still responsible for keeping track of those things even when it participates in display.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): If the outgoing layer tree host
was participating in display, just send another Update message instead of an
ExitAcceleratedCompositing message, since the UI process never even knew we were using
accelerated compositing.
(WebKit::DrawingAreaImpl::displayTimerFired): If we have a layer tree host that's
participating in display, ask it when it next needs to display when scheduling our timer.
(WebKit::DrawingAreaImpl::scheduleDisplay):
(WebKit::DrawingAreaImpl::display):
If we have a layer tree host that's participating in display, it will keep track of its own
dirty region, so ask it if it needs display rather than checking our own dirty region.
(WebKit::DrawingAreaImpl::display): If we have a layer tree host that's participating in
display, don't bail out. Instead, tell it to display rather than asking the page to paint.
Moved the setting of updateInfo.viewSize earlier so that it will be set even when the layer
tree host is displaying. Other changes are just due to indentation.
* WebProcess/WebPage/LayerTreeHost.h:
(WebKit::LayerTreeHost::participatesInDisplay):
(WebKit::LayerTreeHost::needsDisplay):
(WebKit::LayerTreeHost::timeUntilNextDisplay):
(WebKit::LayerTreeHost::display):
Stubbed out these functions. Derived classes can override them to participate in display.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol@webkit.org [Tue, 5 Apr 2011 17:49:24 +0000 (17:49 +0000)]
Unreviewed.
Updated my info in committers.py
Scripts\webkitpy\common\config\committers.py
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carol@webkit.org [Tue, 5 Apr 2011 17:47:41 +0000 (17:47 +0000)]
Unreviewed.
Updated my info in committers.py
Scripts\webkitpy\common\config\committers.py
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 17:40:30 +0000 (17:40 +0000)]
2011-04-05 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=57400
Check whether the full screen renderer layer is being composited by the GPU before assuming that the backing is valid.
Accelerated compositing may be compiled in but disabled at runtime or for some elements.
Tests: Fullscreen layout tests on Chromium.
* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):
(WebCore::Document::webkitWillExitFullScreenForElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 5 Apr 2011 17:34:49 +0000 (17:34 +0000)]
2011-04-05 Adrienne Walker <enne@google.com>
Unreviewed, temporarily suppress Chromium failures for tests in r82947.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 5 Apr 2011 17:32:01 +0000 (17:32 +0000)]
2011-04-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Add Web Inspector stack trace, pause on exception and window.onerror
screenshots.
* blog-files/inspector/stack-traces-img/1.png: Added.
* blog-files/inspector/stack-traces-img/2.png: Added.
* blog-files/inspector/stack-traces-img/3.png: Added.
* blog-files/inspector/stack-traces-img/4.png: Added.
* blog-files/inspector/stack-traces-img/5.png: Added.
* blog-files/inspector/stack-traces-img/6.png: Added.
* blog-files/inspector/stack-traces-img/button.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 5 Apr 2011 17:28:28 +0000 (17:28 +0000)]
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721
* svg/text/font-size-null-assertion-expected.txt: Added.
* svg/text/font-size-null-assertion.svg: Added.
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Regression: Invalid write in SVGTextLayoutEngine
https://bugs.webkit.org/show_bug.cgi?id=57721
Properly stop layout if all metrics object refer to zero-width/height characters,
which can happen for instance when using <text font-size="0">.
Test: svg/text/font-size-null-assertion.svg
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterMetrics):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 5 Apr 2011 17:23:34 +0000 (17:23 +0000)]
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
Removed WebCore::SpellCheckingResult and replaced it with TextCheckingResult.
This change also added TextCheckerClient::requestCheckingOfString() should have
TextCheckingTypeMask as a parameter to control text checking type.
* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
(WebCore::Editor::textCheckingTypeMaskFor): Extracted from markAllMisspellingsAndBadGrammarInRanges()
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::requestCheckingFor): Added a parameter.
(WebCore::SpellChecker::markAt): Extracted from didCheck(), Added a check for the GrammarDetail object.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:
* loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
* platform/text/TextCheckerClient.h:
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
Followed the signature change.
* src/EditorClientImpl.h:
* src/EditorClientImpl.cpp:
* src/WebTextCheckingCompletionImpl.cpp
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/EditorClientEfl.h:
(WebCore::EditorClientEfl::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/TextCheckerClientEnchant.h:
(WebKit::TextCheckerClientEnchant::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/EditorClientHaiku.h:
(WebCore::EditorClientHaiku::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
Removed NSTextCheckingResult to SpellCheckingResult convertion, and extracted
NSTextCheckingResult to TextCheckingResult convertio from checkTextOfParagraph method.
for requestCheckingOfString method.
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(toCoreTextCheckingResults):
(WebEditorClient::checkTextOfParagraph):
(-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:types:WebCore::results:]):
(-[WebEditorSpellCheckResponder perform]):
(WebEditorClient::requestCheckingOfString):
* WebView/WebFrame.mm:
(-[WebFrame markersForSelectionStartAsText]):
* WebView/WebFramePrivate.h:
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/EditorClientQt.h:
(WebCore::EditorClientQt::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/EditorClientWinCE.h:
(WebKit::EditorClientWinCE::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebKitSupport/EditorClientWx.h:
(WebCore::EditorClientWx::requestCheckingOfString):
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::requestCheckingOfString):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::checkTextOfParagraph):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 5 Apr 2011 17:20:00 +0000 (17:20 +0000)]
Print stylesheet on nytimes.com loads too early
https://bugs.webkit.org/show_bug.cgi?id=57814
Reviewed by Sam Weinig.
Don't load resources with Very Low priority until there are no other resources to
load for the host (or until document is complete enough that we stop limiting requests).
No tests, this is difficult to observe reliably with our current testing infrastructure.
Verified working with Wireshark.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
* loader/ResourceLoadScheduler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Tue, 5 Apr 2011 17:11:39 +0000 (17:11 +0000)]
2011-04-04 Steve Block <steveblock@google.com>
Reviewed by Dimitri Glazkov.
JavaInstance should be a pure interface
https://bugs.webkit.org/show_bug.cgi?id=55383
This patch fixes JavaInstance for V8 only.
It factors out a JavaInstance interface which does not use JNI
types. This will allow the Java bridge to be used with objects
that don't use JNI directly. The existing jobject-backed
implementation is moved to a new JavaInstanceJobject class which
implements the interface.
No new tests, refactoring only.
* Android.v8bindings.mk:
* WebCore.gypi:
* bridge/jni/JobjectWrapper.h:
* bridge/jni/v8/JNIUtilityPrivate.cpp:
(JSC::Bindings::jvalueToJavaValue):
(JSC::Bindings::javaValueToJvalue):
* bridge/jni/v8/JavaInstanceJobjectV8.cpp:
(JavaInstanceJobject::JavaInstanceJobject):
(JavaInstanceJobject::~JavaInstanceJobject):
(JavaInstanceJobject::begin):
(JavaInstanceJobject::end):
(JavaInstanceJobject::getClass):
(JavaInstanceJobject::invokeMethod):
(JavaInstanceJobject::getField):
* bridge/jni/v8/JavaInstanceJobjectV8.h: Copied from Source/WebCore/bridge/jni/v8/JavaInstanceV8.h.
(JSC::Bindings::JavaInstanceJobject::javaInstance):
* bridge/jni/v8/JavaInstanceV8.h:
(JSC::Bindings::JavaInstance::~JavaInstance):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Tue, 5 Apr 2011 17:01:57 +0000 (17:01 +0000)]
2011-04-05 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Move MouseEvent-dispatching logic into MouseEventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=57639
Refactoring, covered by existing tests.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Moved useful assertion here
from dispatchMouseEvent.
(WebCore::EventDispatcher::adjustRelatedTarget): Converted into a method.
* dom/EventDispatcher.h: Adjusted decls.
(WebCore::EventDispatcher::node): Added.
* dom/MouseEvent.cpp:
(WebCore::MouseEvent::create): Moved useful assertion here from
dispatchMouseEvent.
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator): Added.
(WebCore::MouseEventDispatchMediator::event): Added.
(WebCore::MouseEventDispatchMediator::dispatchEvent): Added.
* dom/MouseEvent.h:
(WebCore::MouseEvent::setRelatedTarget): Added.
* dom/Node.cpp:
(WebCore::Node::dispatchMouseEvent): Changed to use MouseEventDispatchMediator.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 5 Apr 2011 16:38:10 +0000 (16:38 +0000)]
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben & Dirk Schulze.
text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831
Add text-tspan-02-b.svg from SVG 1.1 2nd edition, which was buggy.
Add reduced testcase, which exposes a bug with midpoint splitting, which is now fixed.
* platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/mac/svg/text/text-midpoint-split-bug-expected.checksum: Added.
* platform/mac/svg/text/text-midpoint-split-bug-expected.png: Added.
* platform/mac/svg/text/text-midpoint-split-bug-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg: Added.
* svg/text/text-midpoint-split-bug.svg: Added.
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben & Dirk Schulze.
text-tspan-02-b.svg from SVG 1.1 2nd edition fails
https://bugs.webkit.org/show_bug.cgi?id=57831
We were not spanning rotation values correcty accross text children, which resulted in text-span-02-b.svg misrendering.
While rewriting the rotation specific code, it came apparent that the LayoutScope concept is flawed in general and
should be replaced by a global list of x/y/dx/dy/rotate values for the whole text subtree. This makes it much simpler
to implement the demand that the last rotation value spans the whole scope. A follow-up patch will optimize the
required memory.
Example:
<text rotate="10,20,999,50">AB<tspan rotate="30">CDE</>FGH</text>
text: A B C D E F G H
rotate="10 20 30 30 30 50 50 50"
Tests: svg/W3C-SVG-1.1-SE/text-tspan-02-b.svg
svg/text/text-midpoint-split-bug.svg
* rendering/RenderBlockLineLayout.cpp: Move SVG specific midpoint creation after the non-SVG specific code that may mutate the midpoints. otherwhise we end up in an
(WebCore::RenderBlock::findNextLineBreak): inconsistent state. We were intereferring with the ignoreSpaces code resulting in wrong truncations - covered by new testcase.
* rendering/svg/SVGTextLayoutAttributes.cpp:
(WebCore::SVGTextLayoutAttributes::reserveCapacity): Also reserveCapacity for the text metrics list (minor optimization).
(WebCore::SVGTextLayoutAttributes::fillWithEmptyValue): Added helper function for use from SVGTextLayoutAttributesBuilder.
(WebCore::SVGTextLayoutAttributes::appendEmptyValue): Ditto.
(WebCore::safeValueAtPosition): Ditto. (Inline helper)
(WebCore::SVGTextLayoutAttributes::appendSingleValueFromAttribute): Ditto.
* rendering/svg/SVGTextLayoutAttributes.h: Ditto.
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp: Rewrite code, see explaination above.
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextSubtree):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForAllCharacters):
(WebCore::SVGTextLayoutAttributesBuilder::propagateLayoutAttributes):
(WebCore::fillListAtPosition):
(WebCore::SVGTextLayoutAttributesBuilder::fillAttributesAtPosition):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
(WebCore::SVGTextLayoutAttributesBuilder::TextPosition::TextPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Tue, 5 Apr 2011 16:34:45 +0000 (16:34 +0000)]
2011-04-05 Levi Weintraub <leviw@chromium.org>
Reviewed by Ryosuke Niwa.
DeleteButtonController is given invalid style
https://bugs.webkit.org/show_bug.cgi?id=57853
DeleteButtonController was assigned an invalid style that can lead to assertions
in debug builds. This matches up the code with its intent.
No new tests as this changes nothing on release builds.
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 16:22:28 +0000 (16:22 +0000)]
Didn't mean to land this.
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView getVariable:value:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 16:18:43 +0000 (16:18 +0000)]
2011-04-05 Anders Bakken <agbakken@gmail.com>
Reviewed by Laszlo Gombos.
[Qt] EditorQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40260
This patch does not require new test cases.
* editing/qt/EditorQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 15:55:10 +0000 (15:55 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: go to line dialog highlights wrong line.
https://bugs.webkit.org/show_bug.cgi?id=57845
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 15:36:16 +0000 (15:36 +0000)]
2011-04-05 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Implement CSSPropertyDirection in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=57608
No new tests required as no new functionality introduced.
* css/CSSStyleApplyProperty.cpp:
Add implementation class for CSSPropertyDirection
* css/CSSStyleSelector.cpp:
Remove existing implementation for CSSPropertyDirection
* css/CSSStyleSelector.h:
Add getter for element
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 5 Apr 2011 15:21:08 +0000 (15:21 +0000)]
Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>
Unreviewed. Update Qt specific expected results after r82925.
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 15:10:18 +0000 (15:10 +0000)]
2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Factoring the creation of 'FunctionOnly' callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=57760
This method creates a template from an existing functionality in V8GeolocationCustom.cpp
to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* bindings/v8/V8Utilities.cpp:
(WebCore::throwTypeMismatchException):
* bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 5 Apr 2011 15:07:22 +0000 (15:07 +0000)]
2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Make WebKitLibraries optional for building QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=57542
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 14:48:14 +0000 (14:48 +0000)]
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MiniBrowser defaultUrl does not work
https://bugs.webkit.org/show_bug.cgi?id=57021
Match the behavior and coding of MiniBrowser to QtTestBrowser.
* MiniBrowser/qt/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Tue, 5 Apr 2011 14:23:47 +0000 (14:23 +0000)]
2011-04-05 Chang Shu <cshu@webkit.org>
Unreviewed.
Unskip passed tests after bugs 57572, 57568, 42540, 42692 have been resolved.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 5 Apr 2011 13:40:06 +0000 (13:40 +0000)]
2011-04-05 Alejandro G. Castro <alex@igalia.com>
Another compilation fix after r82929 horrible patch merge.
* UIProcess/WebPageProxy.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log