WebKit-https.git
9 years agoGive a resize handle for sidebyside diffs.
ojan@chromium.org [Wed, 14 Dec 2011 18:30:55 +0000 (18:30 +0000)]
Give a resize handle for sidebyside diffs.
https://bugs.webkit.org/show_bug.cgi?id=74465

Reviewed by Ryosuke Niwa.

This gives a drag handle so you can make the side-by-side
diff not be 50/50 on a per-file-diff basis. This is useful
for cases like new files where there's no value on the
left side.

* PrettyPatch/PrettyPatch.rb:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
ossy@webkit.org [Wed, 14 Dec 2011 18:14:42 +0000 (18:14 +0000)]
[Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102688.
kbr@google.com [Wed, 14 Dec 2011 18:03:32 +0000 (18:03 +0000)]
Unreviewed, rolling out r102688.
http://trac.webkit.org/changeset/102688
https://bugs.webkit.org/show_bug.cgi?id=74220

Under the hypothesis that it might be the cause of
browser_tests and ui_tests crashes on Chromium canaries --
will reland if not.

* bindings/v8/V8Proxy.cpp:
(WebCore::addMessageToConsole):
(WebCore::logInfo):
(WebCore::V8Proxy::reportUnsafeAccessTo):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomXPathNSResolver.cpp:
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: DatabaseTableView should escape table name.
vsevik@chromium.org [Wed, 14 Dec 2011 17:48:26 +0000 (17:48 +0000)]
Web Inspector: DatabaseTableView should escape table name.
https://bugs.webkit.org/show_bug.cgi?id=74503

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/database-table-name-excaping.html

* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._escapeTableName):
(WebInspector.DatabaseTableView.prototype.update):

LayoutTests:

* inspector/database-table-name-excaping-expected.txt: Added.
* inspector/database-table-name-excaping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 17:41:37 +0000 (17:41 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

* platform/qt-5.0/Skipped: Unskip a bunch of now passing tests - part 4. : svg
* platform/qt-wk2/Skipped: Skip 2 flakey tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] padTemplate leak in webkitwebaudiosrc
philn@webkit.org [Wed, 14 Dec 2011 17:26:08 +0000 (17:26 +0000)]
[GStreamer] padTemplate leak in webkitwebaudiosrc
https://bugs.webkit.org/show_bug.cgi?id=74495

Reviewed by Martin Robinson.

Use a GstPadTemplate smart pointer in webkit_web_audio_src_init to
avoid a memory leak after the ghost pad creation.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webkit_web_audio_src_init):
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::GstPadTemplate):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake my e-mail address a little more awesome.
kling@webkit.org [Wed, 14 Dec 2011 17:20:27 +0000 (17:20 +0000)]
Make my e-mail address a little more awesome.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [Gardening] editing/pasteboard/4242293-1.html now passes.
commit-queue@webkit.org [Wed, 14 Dec 2011 17:17:49 +0000 (17:17 +0000)]
[Qt] [Gardening] editing/pasteboard/4242293-1.html now passes.
https://bugs.webkit.org/show_bug.cgi?id=73417

Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2011-12-14
Reviewed by Csaba Osztrogonác.

Remove this test from the skip list since it is passing now.

* platform/qt-5.0/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 17:15:53 +0000 (17:15 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

* platform/qt-5.0/Skipped: Unskip a bunch of now passing tests - part 3. : editing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in RenderBox::paintBoxDecorations when documentElement has no renderer
jchaffraix@webkit.org [Wed, 14 Dec 2011 17:13:38 +0000 (17:13 +0000)]
Crash in RenderBox::paintBoxDecorations when documentElement has no renderer
https://bugs.webkit.org/show_bug.cgi?id=64284

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dynamic/crash-paint-no-documentElement-renderer.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackground): Check the documentElement's
renderer before using it which matches what RenderView does.

LayoutTests:

* fast/dynamic/crash-paint-no-documentElement-renderer-expected.png: Added.
* fast/dynamic/crash-paint-no-documentElement-renderer-expected.txt: Added.
* fast/dynamic/crash-paint-no-documentElement-renderer.html: Added.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
The test hits the ASSERT from bug 68859 in Debug. However it works well in Release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDocumentLoader should ref its mainResourceLoader.
tsepez@chromium.org [Wed, 14 Dec 2011 17:03:07 +0000 (17:03 +0000)]
DocumentLoader should ref its mainResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=74424

Reviewed by Adam Barth.

Source/WebCore:

Tests: platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html
       platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::loadNow):

LayoutTests:

More tests for insecure iframes blocked inside of https frames.

* http/tests/security/mixedContent/resources/frame-with-insecure-iframe.html: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked.html: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
* platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 16:59:57 +0000 (16:59 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

* platform/qt-5.0/Skipped: Unskip a bunch of now passing tests - part 2. : tables

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 16:47:04 +0000 (16:47 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

* platform/qt-5.0/Skipped: Unskip a bunch of now passing tests - part 1. : css2.1, css3

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS Filters should support GPU acceleration
senorblanco@chromium.org [Wed, 14 Dec 2011 16:45:51 +0000 (16:45 +0000)]
CSS Filters should support GPU acceleration
https://bugs.webkit.org/show_bug.cgi?id=74441

Reviewed by Darin Adler.

Will be covered by existing CSS filters tests, when run in GPU mode.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::prepare):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateOrRemoveFilterEffect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions...
commit-queue@webkit.org [Wed, 14 Dec 2011 16:37:19 +0000 (16:37 +0000)]
Source/WebCore: [CHROMIUM/SKIA] Handle put[Un/Pre]multipliedImageData conversions in Skia rather than ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <bsalomon@google.com> on 2011-12-14
Reviewed by Stephen White.

Tested by existing canvas2d layout tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::putImageData):
(WebCore::ImageBuffer::putUnmultipliedImageData):
(WebCore::ImageBuffer::putPremultipliedImageData):

LayoutTests: [CHROMIUM] Make canvas/philip/tests/2d.imageData.put.unchanged.html be expected to fail
on the GPU due to slight difference in alpha-premul computation.

https://bugs.webkit.org/show_bug.cgi?id=73953

Patch by Brian Salomon <bsalomon@google.com> on 2011-12-14
Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Rollout r102769, because it broke Qt-4.8 builds.
ossy@webkit.org [Wed, 14 Dec 2011 16:29:50 +0000 (16:29 +0000)]
[Qt] Rollout r102769, because it broke Qt-4.8 builds.

.:

* Source/api.pri:

Tools:

* qmake/mkspecs/features/webcore.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove SharedBufferBlackBerry.cpp from WebCore/platform/blackberry
commit-queue@webkit.org [Wed, 14 Dec 2011 16:20:05 +0000 (16:20 +0000)]
Remove SharedBufferBlackBerry.cpp from WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=74488

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-14
Reviewed by Rob Buis.

Remove dead code, no new tests.

* platform/blackberry/SharedBufferBlackBerry.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Move download handling out of QtWebPageProxy
caio.oliveira@openbossa.org [Wed, 14 Dec 2011 16:04:21 +0000 (16:04 +0000)]
[Qt] [WK2] Move download handling out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=74506

Reviewed by Kenneth Rohde Christiansen.

Also moves the creation of QtWebContext out of QtWebPageProxy.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleDownloadRequest):
(QQuickWebViewPrivate::_q_onReceivedResponseFromDownload):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/qwebdownloaditem_p.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleDownloadRequest):
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 15:56:17 +0000 (15:56 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

Unreviewed gardening, remove unnecessary Qt5 specific expected files.

* platform/qt-5.0/animations/cross-fade-background-image-expected.png: Removed.
* platform/qt-5.0/animations/cross-fade-background-image-expected.txt: Removed.
* platform/qt-5.0/animations/cross-fade-border-image-source-expected.png: Removed.
* platform/qt-5.0/animations/cross-fade-border-image-source-expected.txt: Removed.
* platform/qt-5.0/animations/cross-fade-list-style-image-expected.png: Removed.
* platform/qt-5.0/animations/cross-fade-list-style-image-expected.txt: Removed.
* platform/qt-5.0/animations/cross-fade-webkit-mask-box-image-expected.png: Removed.
* platform/qt-5.0/animations/cross-fade-webkit-mask-box-image-expected.txt: Removed.
* platform/qt-5.0/animations/cross-fade-webkit-mask-image-expected.png: Removed.
* platform/qt-5.0/animations/cross-fade-webkit-mask-image-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-002-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-003-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.png: Removed.
* platform/qt-5.0/css2.1/20110323/dynamic-top-change-004-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/empty-inline-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/empty-inline-002-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/empty-inline-003-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-002-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-margins-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-001-expected.txt: Removed.
* platform/qt-5.0/css2.1/20110323/table-caption-optional-002-expected.txt: Removed.
* platform/qt-5.0/editing/execCommand/indent-nested-lists-3-expected.txt: Removed.
* platform/qt-5.0/fast/css/child-style-can-override-visited-style-expected.txt: Removed.
* platform/qt-5.0/fast/css/empty-inline-003-quirksmode-expected.txt: Removed.
* platform/qt-5.0/fast/css/empty-inline-line-height-first-line-expected.txt: Removed.
* platform/qt-5.0/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Removed.
* platform/qt-5.0/fast/css/font-face-descending-unicode-range-expected.txt: Removed.
* platform/qt-5.0/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-bt-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/block-axis-horizontal-tb-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/block-axis-vertical-lr-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/block-axis-vertical-rl-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
* platform/qt-5.0/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
* platform/qt-5.0/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Removed.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image-expected.txt: Removed.
* platform/qt-5.0/svg/as-image/same-image-two-instances-expected.txt: Removed.
* platform/qt-5.0/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
* platform/qt-5.0/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
* platform/qt-5.0/svg/custom/pointer-events-image-css-transform-expected.txt: Removed.
* platform/qt-5.0/svg/custom/pointer-events-text-css-transform-expected.txt: Removed.
* platform/qt-5.0/svg/transforms/svg-css-transforms-clip-path-expected.txt: Removed.
* platform/qt-5.0/svg/transforms/svg-css-transforms-expected.txt: Removed.
* platform/qt-5.0/transitions/cross-fade-background-image-expected.png: Removed.
* platform/qt-5.0/transitions/cross-fade-background-image-expected.txt: Removed.
* platform/qt-5.0/transitions/cross-fade-border-image-expected.png: Removed.
* platform/qt-5.0/transitions/cross-fade-border-image-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Test fonts are not used with Qt5
ossy@webkit.org [Wed, 14 Dec 2011 15:55:25 +0000 (15:55 +0000)]
[Qt] Test fonts are not used with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72513

Patch by Balazs Kelemen <kbalazs@webkit.org> on 2011-12-14
Reviewed by Simon Hausmann.

Don't depend on Q_WS_X11 anymore since it's not the Qt5
way to detect the platform. Make the guards depend
on our own configtest for fontconfig. For Qt4 we can still
use the preassumption that we have it on Linux.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::initializeFonts):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/main.cpp:
(main): Additionally remove a nonsense piece of code that was
trying to reset the font settings - which is not necessary -
after we have already returned from main.
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
from WTR. It is not needed. We set up the fonts via the injected bundle.
* qmake/config.tests/fontconfig/fontconfig.cpp: Added.
(main):
* qmake/config.tests/fontconfig/fontconfig.pro: Added.
* qmake/mkspecs/features/features.prf:
* qmake/sync.profile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt-WK2 gardening.
kbalazs@webkit.org [Wed, 14 Dec 2011 15:33:21 +0000 (15:33 +0000)]
Unreviewed Qt-WK2 gardening.

[Qt][WK2] fast/dom/rtl-scroll-to-leftmost-and-resize.html fails
https://bugs.webkit.org/show_bug.cgi?id=74504

[Qt][WK2] css3/unicode-bidi-isolate-aharon-failing.html fails
https://bugs.webkit.org/show_bug.cgi?id=74505

Skip failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse [Supplemental] IDL in WebSocket
haraken@chromium.org [Wed, 14 Dec 2011 14:13:31 +0000 (14:13 +0000)]
Use [Supplemental] IDL in WebSocket
https://bugs.webkit.org/show_bug.cgi?id=74160

Reviewed by Adam Barth.

By using the [Supplemental] IDL, this patch moves declarations of WebSocket
attributes from DOMWindow.idl to websocket/DOMWindowWebSocket.idl,
which helps make WebSocket a self-contained module.

No new tests, no change in behavior.
Confirm that http/tests/websocket/* pass.

* WebCore.gypi: Added DOMWindowWebSocket.idl.
* page/DOMWindow.idl: Added the [Supplemented] IDL to WebSocket-related attributes. This [Supplemented] IDL will be removed after all platforms support the [Supplemental] IDL (See bug 73394 for more details).
* websockets/DOMWindowWebSocket.idl: Added. Used the [Supplemental=DOMWindow] IDL. The attributes in this IDL file are treated as if they are described in DOMWindow.idl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed fix after mobile theme changes.
pierre.rossi@gmail.com [Wed, 14 Dec 2011 14:08:17 +0000 (14:08 +0000)]
Unreviewed fix after mobile theme changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Roll chromium DEPS (r113807 -> r114356)
peter@chromium.org [Wed, 14 Dec 2011 13:58:47 +0000 (13:58 +0000)]
[Chromium] Roll chromium DEPS (r113807 -> r114356)
https://bugs.webkit.org/show_bug.cgi?id=74496

Reviewed by Tony Gentilcore.

Roll deps to r114356 and update the location of sfntly to
pick up the change at Chromium.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Move QWebNavigationHistory to QQuickWebView
caio.oliveira@openbossa.org [Wed, 14 Dec 2011 13:57:00 +0000 (13:57 +0000)]
[Qt] [WK2] Move QWebNavigationHistory to QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=74442

Reviewed by Simon Hausmann.

QWebNavigationHistory used QtWebPageProxy to be QObject parent of the inner models,
this patch change that to use OwnPtr instead. When creating the history object we pass
only the WKPageRef and let it get the backForwardList.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didChangeBackForwardList):
(QQuickWebViewExperimental::navigationHistory):
(QQuickWebViewExperimental::goForwardTo):
(QQuickWebViewExperimental::goBackTo):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp:
(QWebNavigationListModelPrivate::createWebNavigationModel):
(QWebNavigationHistoryPrivate::QWebNavigationHistoryPrivate):
(QWebNavigationHistoryPrivate::createHistory):
(QWebNavigationHistoryPrivate::goBackTo):
(QWebNavigationHistoryPrivate::goForwardTo):
(QWebNavigationListModel::QWebNavigationListModel):
(QWebNavigationHistory::backItems):
(QWebNavigationHistory::forwardItems):
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/qwebnavigationhistory_p_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd different salt to different types of selectors. So the CSS fast
commit-queue@webkit.org [Wed, 14 Dec 2011 13:51:58 +0000 (13:51 +0000)]
Add different salt to different types of selectors. So the CSS fast
path can tell the different between tags and class attributes with
otherwise identical values.
https://bugs.webkit.org/show_bug.cgi?id=74284

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2011-12-14
Reviewed by Antti Koivisto.

* css/SelectorChecker.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::collectDescendantSelectorIdentifierHashes):
* css/SelectorChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
vestbo@webkit.org [Wed, 14 Dec 2011 13:48:47 +0000 (13:48 +0000)]
[Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path

Followup to r102679

https://bugs.webkit.org/show_bug.cgi?id=74413

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Mobile theme could use a little refresh
pierre.rossi@gmail.com [Wed, 14 Dec 2011 13:20:50 +0000 (13:20 +0000)]
[Qt] Mobile theme could use a little refresh
https://bugs.webkit.org/show_bug.cgi?id=74293

Source/WebCore:

The look and feel of the "mobile theme" we're
using in QtWebKit dates back to the maemo 5 days.
This is an attempt at making it look less out of
place, and also support progress and range.

Reviewed by Kenneth Rohde Christiansen.

No new tests, this is still not the default theme
for tests.

* DerivedSources.pri:
* css/mobileThemeQt.css: Added.
(input[type="submit"], select):
(input[type="submit"]:disabled, input[type="submit"]:disabled:active, select:disabled, input[type="text"]:disabled):
(input[type="submit"]:active):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::extraDefaultStyleSheet):
(WebCore::StylePainter::StylePainter):
(WebCore::StylePainter::init):
(WebCore::StylePainter::~StylePainter):
* platform/qt/RenderThemeQt.h:
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::drawRectangularControlBackground):
(WebCore::shrinkRectToSquare):
(WebCore::StylePainterMobile::StylePainterMobile):
(WebCore::StylePainterMobile::~StylePainterMobile):
(WebCore::StylePainterMobile::drawCheckableBackground):
(WebCore::StylePainterMobile::sizeForPainterScale):
(WebCore::StylePainterMobile::drawChecker):
(WebCore::StylePainterMobile::findCheckBox):
(WebCore::StylePainterMobile::drawRadio):
(WebCore::StylePainterMobile::findRadio):
(WebCore::StylePainterMobile::drawMultipleComboButton):
(WebCore::StylePainterMobile::drawSimpleComboButton):
(WebCore::StylePainterMobile::getButtonImageSize):
(WebCore::StylePainterMobile::findComboButton):
(WebCore::StylePainterMobile::drawLineEdit):
(WebCore::StylePainterMobile::drawCheckBox):
(WebCore::StylePainterMobile::drawRadioButton):
(WebCore::StylePainterMobile::drawPushButton):
(WebCore::StylePainterMobile::drawComboBox):
(WebCore::StylePainterMobile::drawProgress):
(WebCore::StylePainterMobile::drawSliderThumb):
(WebCore::RenderThemeQtMobile::paintButton):
(WebCore::RenderThemeQtMobile::paintTextField):
(WebCore::RenderThemeQtMobile::setPopupPadding):
(WebCore::RenderThemeQtMobile::paintMenuList):
(WebCore::RenderThemeQtMobile::paintMenuListButton):
(WebCore::RenderThemeQtMobile::animationDurationForProgressBar):
(WebCore::RenderThemeQtMobile::paintProgressBar):
(WebCore::RenderThemeQtMobile::paintSliderTrack):
(WebCore::RenderThemeQtMobile::paintSliderThumb):
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h:

Tools:

Have MiniBrowser use the mobile theme when not
passed --desktop.

Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Non-Mac] Change event should be fired when changing option by using keyboard.
commit-queue@webkit.org [Wed, 14 Dec 2011 13:00:21 +0000 (13:00 +0000)]
[Non-Mac] Change event should be fired when changing option by using keyboard.
https://bugs.webkit.org/show_bug.cgi?id=74384

Patch by Rakesh KN <rakesh.kn@motorola.com> on 2011-12-14
Reviewed by Kent Tamura.

Source/WebCore:

Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys.

Test: fast/forms/select/menulist-onchange-fired-with-key-up-down.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
Setting the DispatchChangeEvent selection option flag when the option is selected using
up/down/right/left/pageup/pagedown/home/end keys.

LayoutTests:

Fire onchange event when option is changed using up/down/right/left/pageup/pagedown/home/end keys.

* fast/forms/select/menulist-onchange-fired-with-key-up-down-expected.txt: Added.
* fast/forms/select/menulist-onchange-fired-with-key-up-down.html: Added.
* platform/chromium/test_expectations.txt:
Skipped for Chromium MAC.
* platform/mac/Skipped:
Skipped for Apple MAC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [Gardening] Remove qt-4.7 layout tests dir
alexis.menard@openbossa.org [Wed, 14 Dec 2011 12:50:47 +0000 (12:50 +0000)]
[Qt] [Gardening] Remove qt-4.7 layout tests dir
https://bugs.webkit.org/show_bug.cgi?id=74426

Building trunk now depends on Qt >= 4.8, so no need to keep this directory
on the tree.

Patch by João Paulo Rechi Vita <jprvita@openbossa.org> on 2011-12-14
Reviewed by Csaba Osztrogonác.

Tools:

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.qt_version):
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest._assert_search_path):

LayoutTests:

* platform/qt-4.7/Skipped: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
caio.oliveira@openbossa.org [Wed, 14 Dec 2011 12:50:02 +0000 (12:50 +0000)]
[Qt][WK2] Remove DrawingArea and QtWebPageEventHandler code from QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=74414

Reviewed by Simon Hausmann.

This also moves QtWebPageEventHandler to inside QQuickWebPagePrivate, to avoid
the WebPage having a backpointer to the QQuickWebView.

* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::initialize):
(QQuickWebPagePrivate::setDrawingAreaSize):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPagePrivate::resetPaintNode):
* UIProcess/API/qt/qquickwebpage_p.h:
* UIProcess/API/qt/qquickwebpage_p_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::_q_resume):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::createDrawingAreaProxy):
(QQuickWebViewPrivate::updateVisibleContentRectAndScale):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::updateViewportSize):
* UIProcess/API/qt/qquickwebview_p_p.h:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::createDrawingAreaProxy):
* UIProcess/qt/QtPageClient.h:
(QtPageClient::findStringInCustomRepresentation):
(QtPageClient::countStringMatchesInCustomRepresentation):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::startDrag):
* UIProcess/qt/QtWebPageEventHandler.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip 2 tests failing on 32-bit GTK bot.
philn@webkit.org [Wed, 14 Dec 2011 11:42:34 +0000 (11:42 +0000)]
Unreviewed, skip 2 tests failing on 32-bit GTK bot.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix compilation of QtWebKit with --orientation-events without ENABLE_DEVICE_ORIE...
commit-queue@webkit.org [Wed, 14 Dec 2011 11:27:59 +0000 (11:27 +0000)]
[Qt] Fix compilation of QtWebKit with --orientation-events without ENABLE_DEVICE_ORIENTATION
https://bugs.webkit.org/show_bug.cgi?id=74492

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-14
Reviewed by Simon Hausmann.

.:

* Source/api.pri:

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFramePrivate::_q_orientationChanged):
* Api/qwebframe_p.h:
* WebCoreSupport/DeviceMotionProviderQt.cpp:
* WebCoreSupport/DeviceMotionProviderQt.h:
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
* WebCoreSupport/DeviceOrientationProviderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Gtk] rebaseline test results for editing/selection/transformed-selection-rects.html
commit-queue@webkit.org [Wed, 14 Dec 2011 11:10:20 +0000 (11:10 +0000)]
[Gtk] rebaseline test results for editing/selection/transformed-selection-rects.html
https://bugs.webkit.org/show_bug.cgi?id=74307

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-12-14
Reviewed by Philippe Normand.

Update test results for editing/selection/transformed-selection-rects.html
and unskip the test.

* platform/gtk/Skipped:
* platform/gtk/editing/selection/transformed-selection-rects-expected.png:
* platform/gtk/editing/selection/transformed-selection-rects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
haraken@chromium.org [Wed, 14 Dec 2011 10:31:31 +0000 (10:31 +0000)]
[Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
through parameter passing
https://bugs.webkit.org/show_bug.cgi?id=74485

Reviewed by Ryosuke Niwa.

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
manner. This bug is one of the incremental refactorings to remove all top-level
code and global variables from prepare-ChangeLog. In this patch,
we make the following global variables be used only through parameter passing.
    - $isGit
    - $isSVN

* Scripts/prepare-ChangeLog:
(generateFunctionLists):
(printDiff):
(diffFromToString):
(diffCommand):
(statusCommand):
(createPatchCommand):
(diffHeaderFormat):
(generateFileList):
(isAddedStatus):
(isConflictStatus):
(statusDescription):
(extractLineRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Linking fails if GStreamer not installed after r102493
commit-queue@webkit.org [Wed, 14 Dec 2011 10:23:52 +0000 (10:23 +0000)]
[Qt] [WK2] Linking fails if GStreamer not installed after r102493
https://bugs.webkit.org/show_bug.cgi?id=74412

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-14
Reviewed by Simon Hausmann.

Add -lrt to fix WK2 linking when gstreamer is not used.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation for Qt with --minimal option after r102755.
ossy@webkit.org [Wed, 14 Dec 2011 10:16:11 +0000 (10:16 +0000)]
Fix compilation for Qt with --minimal option after r102755.

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-14
Reviewed by Csaba Osztrogonác.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark a GTK accessibility test flaky and fix
philn@webkit.org [Wed, 14 Dec 2011 10:09:30 +0000 (10:09 +0000)]
Unreviewed, mark a GTK accessibility test flaky and fix
expectation of http/tests/security/cross-origin-xsl-redirect-BLOCKED.html.

* platform/gtk/test_expectations.txt:
platform/gtk/accessibility/unknown-roles-not-exposed.html is flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: TreeOutline's is broken when li elements have padding-left different...
vsevik@chromium.org [Wed, 14 Dec 2011 10:06:20 +0000 (10:06 +0000)]
Web Inspector: TreeOutline's is broken when li elements have padding-left different from 14px.
https://bugs.webkit.org/show_bug.cgi?id=74445

Reviewed by Pavel Feldman.

* inspector/front-end/treeoutline.js:
(TreeElement.prototype.isEventWithinDisclosureTriangle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] Scripts panel debug sidebar toolbar should not be scrolle...
vsevik@chromium.org [Wed, 14 Dec 2011 10:04:38 +0000 (10:04 +0000)]
Web Inspector: [Regression] Scripts panel debug sidebar toolbar should not be scrolled out of the screen.
https://bugs.webkit.org/show_bug.cgi?id=74447

Reviewed by Pavel Feldman.

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
* inspector/front-end/scriptsPanel.css:
(#scripts-debug-toolbar):
(#scripts-debug-sidebar-contents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationCli...
commit-queue@webkit.org [Wed, 14 Dec 2011 09:57:26 +0000 (09:57 +0000)]
[Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
https://bugs.webkit.org/show_bug.cgi?id=74417

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-14
Reviewed by Simon Hausmann.

Based on original patch by Kenneth Christiansen.

.:

* Source/api.pri:

Source/WebCore:

Already covered by current tests.

* dom/DeviceOrientationController.h:
(WebCore::DeviceOrientationController::client):

Source/WebKit/qt:

Already covered by current tests.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
* WebCoreSupport/DeviceMotionProviderQt.cpp:
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
(WebCore::DeviceMotionProviderQt::filter):
* WebCoreSupport/DeviceMotionProviderQt.h:
* WebCoreSupport/DeviceOrientationClientMockQt.cpp: Removed.
* WebCoreSupport/DeviceOrientationClientMockQt.h: Removed.
* WebCoreSupport/DeviceOrientationClientQt.cpp:
(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::~DeviceOrientationClientQt):
(WebCore::DeviceOrientationClientQt::lastOrientation):
* WebCoreSupport/DeviceOrientationClientQt.h:
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::setController):
(WebCore::DeviceOrientationProviderQt::start):
(WebCore::DeviceOrientationProviderQt::stop):
(WebCore::DeviceOrientationProviderQt::filter):
* WebCoreSupport/DeviceOrientationProviderQt.h:
(WebCore::DeviceOrientationProviderQt::isActive):
(WebCore::DeviceOrientationProviderQt::lastOrientation):
(WebCore::DeviceOrientationProviderQt::hasAlpha):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(toDeviceOrientationClientMock):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Already covered by current tests.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockDeviceOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add notification support for the BlackBerry port
leo.yang@torchmobile.com.cn [Wed, 14 Dec 2011 09:51:07 +0000 (09:51 +0000)]
[BlackBerry] Add notification support for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=73194

Patch by Robin Qiu <robin.qiu@torchmobile.com.cn> on 2011-12-14
Reviewed by Nikolas Zimmermann.

Contributed by Torch team, the main contributor is Robin Qiu
<robin.qiu@torchmobile.com.cn>.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/NotificationPresenterImpl.cpp: Added.
(WebKit::NotificationPresenterImpl::instance):
(WebKit::NotificationPresenterImpl::NotificationPresenterImpl):
(WebKit::NotificationPresenterImpl::~NotificationPresenterImpl):
(WebKit::NotificationPresenterImpl::show):
(WebKit::NotificationPresenterImpl::cancel):
(WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
(WebKit::NotificationPresenterImpl::requestPermission):
(WebKit::NotificationPresenterImpl::onPermission):
(WebKit::NotificationPresenterImpl::cancelRequestsForPermission):
(WebKit::NotificationPresenterImpl::checkPermission):
(WebKit::NotificationPresenterImpl::notificationClicked):
* blackberry/WebCoreSupport/NotificationPresenterImpl.h: Added.
There is already a header file: Source/WebCore/notifications/NotificationPresenter.h.
To avoid conflicting with the it, I name my header file to NotificationPresenterImpl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Wed, 14 Dec 2011 09:50:33 +0000 (09:50 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
* platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-path-css-transform-1-expected.txt: Added.
* platform/gtk/svg/clip-path/clip-path-css-transform-2-expected.txt: Added.
* platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.txt: Added.
* platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.txt: Added.
* platform/gtk/svg/custom/no-inherited-dashed-stroke-expected.txt: Added.
* platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt: Added.
* platform/gtk/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
* platform/gtk/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
* platform/gtk/svg/custom/recursive-filter-expected.txt: Added.
* platform/gtk/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Added.
* platform/gtk/svg/custom/relative-sized-use-on-symbol-expected.txt: Added.
* platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
* platform/gtk/svg/custom/use-on-symbol-inside-pattern-expected.txt: Added.
* platform/gtk/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.
* platform/gtk/svg/text/non-bmp-positioning-lists-expected.txt: Added.
* platform/gtk/svg/transforms/svg-css-transforms-clip-path-expected.txt: Added.
* platform/gtk/svg/transforms/svg-css-transforms-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectation update.
morrita@google.com [Wed, 14 Dec 2011 09:41:07 +0000 (09:41 +0000)]
Unreviewed expectation update.

* platform/chromium-win/fast/gradients/css3-radial-gradients-expected.png:
* platform/chromium-win/fast/gradients/css3-repeating-radial-gradients-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r102748.
philn@webkit.org [Wed, 14 Dec 2011 09:29:14 +0000 (09:29 +0000)]
Unreviewed, GTK rebaseline after r102748.

* platform/gtk/css1/font_properties/font-expected.txt:
* platform/gtk/css1/font_properties/font_variant-expected.txt:
* platform/gtk/css1/pseudo/firstline-expected.txt:
* platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/gtk/css2.1/t051201-c23-first-line-00-b-expected.txt:
* platform/gtk/css2.1/t051202-c26-psudo-nest-00-c-expected.txt:
* platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/gtk/css2.1/t1505-c524-font-var-00-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt:
* platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/gtk/fast/css/font-face-cache-bug-expected.txt: Added.
* platform/gtk/fast/css/font-face-multiple-faces-expected.txt:
* platform/gtk/fast/css/font-face-opentype-expected.txt:
* platform/gtk/fast/css/font-face-remote-expected.txt:
* platform/gtk/fast/css/font-face-woff-expected.txt:
* platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt:
* platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
* platform/gtk/fast/repaint/text-emphasis-h-expected.txt:
* platform/gtk/fast/repaint/text-emphasis-v-expected.txt:
* platform/gtk/fast/text/emphasis-avoid-ruby-expected.txt:
* platform/gtk/fast/text/emphasis-combined-text-expected.txt:
* platform/gtk/fast/text/emphasis-expected.txt:
* platform/gtk/fast/text/emphasis-overlap-expected.txt:
* platform/gtk/fast/text/emphasis-vertical-expected.txt:
* platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
* platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
* platform/gtk/fonts/font-face-with-complex-text-expected.txt:
* platform/gtk/fonts/synthetic-oblique-positioning-expected.txt:
* platform/gtk/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Switch to libjpeg for decoding
commit-queue@webkit.org [Wed, 14 Dec 2011 09:12:08 +0000 (09:12 +0000)]
[BlackBerry] Switch to libjpeg for decoding
https://bugs.webkit.org/show_bug.cgi?id=74475

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-14
Reviewed by Daniel Bates.

.:

Find libjpeg instead of libimg.

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

Switch to cross platform JPEG image decoder for decoding as this keeps
us inline with other ports and less to maintain.

* PlatformBlackBerry.cmake:

Source/WebKit:

Append libjpeg instead of libimg.

* blackberry/CMakeListsBlackBerry.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Bad text rendering since r101343
philn@webkit.org [Wed, 14 Dec 2011 08:35:38 +0000 (08:35 +0000)]
[GTK] Bad text rendering since r101343
https://bugs.webkit.org/show_bug.cgi?id=73744

Reviewed by Martin Robinson.

Source/WebCore:

* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::setCairoFontOptionsFromFontConfigPattern): Keep Cairo
hint metrics unchanged for better visual font rendering results.

Tools:

Turn cairo hint metrics off for better font metrics reporting in
the tests. This is especially important for SVG.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(initializeGtkFontSettings):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeGtkSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream text codec and web string files of BlackBerry API
commit-queue@webkit.org [Wed, 14 Dec 2011 08:25:46 +0000 (08:25 +0000)]
Upstream text codec and web string files of BlackBerry API
https://bugs.webkit.org/show_bug.cgi?id=73586

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-12-14
Reviewed by Daniel Bates.

Initial upstream, no new tests.

* blackberry/Api/WebKitTextCodec.cpp: Added.
(BlackBerry::WebKit::isSameEncoding):
(BlackBerry::WebKit::isASCIICompatibleEncoding):
(BlackBerry::WebKit::transcode):
(BlackBerry::WebKit::base64DecodePolicyForWebCore):
(BlackBerry::WebKit::base64Decode):
(BlackBerry::WebKit::base64Encode):
(BlackBerry::WebKit::unescapeURL):
(BlackBerry::WebKit::escapeURL):
(BlackBerry::WebKit::getExtensionForMimeType):
* blackberry/Api/WebKitTextCodec.h: Added.
* blackberry/Api/WebString.cpp: Added.
(BlackBerry::WebKit::WebString::WebString):
(BlackBerry::WebKit::WebString::~WebString):
(BlackBerry::WebKit::WebString::fromUtf8):
(BlackBerry::WebKit::WebString::operator=):
(BlackBerry::WebKit::WebString::utf8):
(BlackBerry::WebKit::WebString::characters):
(BlackBerry::WebKit::WebString::length):
(BlackBerry::WebKit::WebString::isEmpty):
(BlackBerry::WebKit::WebString::equal):
(BlackBerry::WebKit::WebString::equalIgnoringCase):
* blackberry/Api/WebString.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectation update.
morrita@google.com [Wed, 14 Dec 2011 08:24:03 +0000 (08:24 +0000)]
Unreviewed expectation update.

* platform/chromium-linux/fast/gradients/css3-radial-gradients-expected.png:
* platform/chromium-linux/fast/gradients/css3-repeating-radial-gradients-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed attempt for fixing windows build.
morrita@google.com [Wed, 14 Dec 2011 08:01:04 +0000 (08:01 +0000)]
Unreviewed attempt for fixing windows build.

- Included <wtf/MathExtras.h> which defined portable version of lround().
- Add some static_cast<> to suppress warnings.

* platform/animation/AnimationUtilities.h:
(WebCore::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add the new plugin files into the build system.
leo.yang@torchmobile.com.cn [Wed, 14 Dec 2011 07:34:24 +0000 (07:34 +0000)]
[BlackBerry] Add the new plugin files into the build system.
https://bugs.webkit.org/show_bug.cgi?id=74483

Patch by Wei Charles <charles.wei@torchmobile.com.cn> on 2011-12-13
Reviewed by Daniel Bates.

No new tests, just add new files to the build system.

* PlatformBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should infer when local variables are doubles
fpizlo@apple.com [Wed, 14 Dec 2011 07:16:36 +0000 (07:16 +0000)]
DFG should infer when local variables are doubles
https://bugs.webkit.org/show_bug.cgi?id=74480

Reviewed by Oliver Hunt.

Introduced the notion that a local variable (though not an argument, yet!) can
be stored as a double, and will be guaranteed to always contain a double. This
requires more magic in the OSR (conversion in both entry and exit). The inference
is quite unorthodox: all uses of a variable vote on whether they think it should
be a double or a JSValue, based on how they use it. If they use it in an integer
or boxed value context, they vote JSValue. If they use it in a double context,
they vote double. This voting is interleaved in the propagator's fixpoint, so
that variables voted double then have a double prediction propagated from them.
This interleaving is needed because a variable that actually always contains an
integer that always gets used in arithmetic that involves doubles may end up
being voted double, which then means that all uses of the variable will see a
double rather than an integer.

This is worth 18% to SunSpider/3d-cube, 7% to Kraken/audio-beat-detection, 7%
to Kraken/audio-fft, 6% to Kraken/imaging-darkroom, 20% to
Kraken/imaging-gaussian-blur, and just over 1% to Kraken/json-parse-financial.
It results in a 1% speed-up on SunSpider and a 4% speed-up in Kraken.  Similar
results on JSVALUE32_64, though with a bigger win on Kraken (5%) and no overall
win on SunSpider.

* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::alreadyInRegisterFileAsUnboxedDouble):
(JSC::ValueRecovery::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::boxDouble):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::vote):
(JSC::DFG::Propagator::doRoundOfDoubleVoting):
(JSC::DFG::Propagator::propagatePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::clearVotes):
(JSC::DFG::VariableAccessData::vote):
(JSC::DFG::VariableAccessData::doubleVoteRatio):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
* runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed morning gardening.
ossy@webkit.org [Wed, 14 Dec 2011 06:49:42 +0000 (06:49 +0000)]
[Qt] Unreviewed morning gardening.

* platform/qt/Skipped: Skip new failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Default selection of select(menulist) should not be disabled
commit-queue@webkit.org [Wed, 14 Dec 2011 06:14:46 +0000 (06:14 +0000)]
[Forms] Default selection of select(menulist) should not be disabled
https://bugs.webkit.org/show_bug.cgi?id=74270

Patch by Yosifumi Inoue <yosin@chromium.org> on 2011-12-13
Reviewed by Kent Tamura.

Source/WebCore:

This patch changes default selection of select(menulist) element to
  1. Selected option element. If there are multiple options which have
     selected state, we pick the largest index option up. (same as current)
  2. Non-disabled option element (new behavior)
  3. The first option if all options are disabled. (new behavior)

Tests: fast/forms/select/menulist-disabled-option-expected.html
       fast/forms/select/menulist-disabled-option.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::recalcListItems): Implement new logic for selection.

LayoutTests:

basic-selects.html will fail because select element displays disabled
option element "foo" at index 0 as default selection. This should be
non-disabled option "bar" at index 1.

menulist-disabled-option-expected.html checks default selection of
select(menulist) with disabled option element.

* fast/forms/select/menulist-disabled-option-expected.html: Added.
* fast/forms/select/menulist-disabled-option.html: Added.
* platform/chromium/test_expectations.txt: Add fast/forms/basic-selects.html
* platform/gtk/test_expectations.txt: Add fast/forms/basic-selects.html
* platform/mac/test_expectations.txt: Add fast/forms/basic-selects.html
* platform/qt/test_expectations.txt: Add fast/forms/basic-selects.html
* platform/win/test_expectations.txt: Add fast/forms/basic-selects.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShare blend progress code
simon.fraser@apple.com [Wed, 14 Dec 2011 05:52:18 +0000 (05:52 +0000)]
Share blend progress code
https://bugs.webkit.org/show_bug.cgi?id=74464

Reviewed by Dean Jackson.

Lots of places in the code had copies of the animation interpolation
logic "from + (to - from) * progress", in various forms.

Coalesce all these into calls to a few new inline functions in a new
AnimationUtilities.h header. Color and Length get their own blend fuctions
in their respective headers.

Covered by existing tests.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSGradientValue.cpp:
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
* platform/Length.h:
(WebCore::Length::blend):
* platform/animation/AnimationUtilities.h: Added.
(WebCore::blend):
* platform/graphics/Color.h:
(WebCore::blend):
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::PerspectiveTransformOperation::blend):
* platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend):
* platform/graphics/transforms/ScaleTransformOperation.cpp:
(WebCore::ScaleTransformOperation::blend):
* platform/graphics/transforms/SkewTransformOperation.cpp:
(WebCore::SkewTransformOperation::blend):
* platform/graphics/transforms/TranslateTransformOperation.cpp:
(WebCore::TranslateTransformOperation::blend):
* svg/SVGLength.h:
(WebCore::SVGLength::blend):
* svg/SVGPathBlender.cpp:
(WebCore::blendFloatPoint):
(WebCore::SVGPathBlender::blendAnimatedDimensonalFloat):
(WebCore::SVGPathBlender::blendArcToSegment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpstream 3 files into WebCore/platform/blackberry
commit-queue@webkit.org [Wed, 14 Dec 2011 05:22:47 +0000 (05:22 +0000)]
Upstream 3 files into WebCore/platform/blackberry
ClipboardBlackBerry.cpp/h, PasteboardBlackBerry.cpp
https://bugs.webkit.org/show_bug.cgi?id=74381

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-13
Reviewed by Rob Buis.

Main contributor:
Mike Fenton <mifenton@rim.com>

Initial upstream, no new tests.

* platform/blackberry/ClipboardBlackBerry.cpp: Added.
* platform/blackberry/ClipboardBlackBerry.h: Added.
* platform/blackberry/PasteboardBlackBerry.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102726.
jamesr@google.com [Wed, 14 Dec 2011 05:19:46 +0000 (05:19 +0000)]
Unreviewed, rolling out r102726.
http://trac.webkit.org/changeset/102726
https://bugs.webkit.org/show_bug.cgi?id=74154

Does not compile on clang

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Windows build.
andersca@apple.com [Wed, 14 Dec 2011 05:15:51 +0000 (05:15 +0000)]
Try to fix the Windows build.

Remove the callOnMainThread overload that takes a WTF::Function since it's not being used.

* wtf/MainThread.cpp:
* wtf/MainThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Remove several global variables from prepare-ChangeLog
haraken@chromium.org [Wed, 14 Dec 2011 05:13:07 +0000 (05:13 +0000)]
[Refactoring] Remove several global variables from prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=74389

Reviewed by David Kilzer.

We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
manner. This bug is one of the incremental refactorings to remove all top-level
code and global variables from prepare-ChangeLog. In this patch,
we make the following global variables being used only through parameter passing.
    - %paths
    - $changedFiles
    - $conflictFiles
    - $functionLists
    - $bugURL

* Scripts/prepare-ChangeLog:
(findChangeLogs):
(generateNewChangeLogs):
(processPaths):
(generateFileList):
(firstDirectoryOrCwd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102732.
morrita@google.com [Wed, 14 Dec 2011 05:07:42 +0000 (05:07 +0000)]
Unreviewed, rolling out r102732.
http://trac.webkit.org/changeset/102732

The last fix makes no sense...

* platform/graphics/chromium/cc/CCLayerTilingData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTML details summary not working with form controls
commit-queue@webkit.org [Wed, 14 Dec 2011 04:59:33 +0000 (04:59 +0000)]
HTML details summary not working with form controls
https://bugs.webkit.org/show_bug.cgi?id=74398

Patch by Hajime Morrita <morrita@chromium.org> on 2011-12-13
Reviewed by Kent Tamura.

Source/WebCore:

Allowed HTMLSummaryElement to skip the toggle logic if the event
target is a form control.

Test: fast/html/details-click-controls.html

* html/HTMLSummaryElement.cpp:
(WebCore::isClickableControl):
(WebCore::HTMLSummaryElement::defaultEventHandler):

LayoutTests:

* fast/html/details-click-controls-expected.txt: Added.
* fast/html/details-click-controls.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize to not use pow() in the inner loop in AudioParamTimeline
commit-queue@webkit.org [Wed, 14 Dec 2011 04:56:56 +0000 (04:56 +0000)]
Optimize to not use pow() in the inner loop in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=73530

Patch by James Wei <james.wei@intel.com> on 2011-12-13
Reviewed by Kenneth Russell.

No new tests.

* webaudio/AudioParamTimeline.cpp:
(WebCore:AudioParamTimeline:valuesForTimeRangeImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium-Mac build fix trial.
morrita@google.com [Wed, 14 Dec 2011 04:49:56 +0000 (04:49 +0000)]
Unreviewed Chromium-Mac build fix trial.

* platform/graphics/chromium/cc/CCLayerTilingData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Initialize Settings::m_perTileDrawingEnabled properly.
commit-queue@webkit.org [Wed, 14 Dec 2011 04:11:24 +0000 (04:11 +0000)]
[Chromium] Initialize Settings::m_perTileDrawingEnabled properly.
https://bugs.webkit.org/show_bug.cgi?id=74476

Patch by David Reveman <reveman@chromium.org> on 2011-12-13
Reviewed by James Robinson.

Add m_perTileDrawingEnabled(false) to WebCore::Settings initialize list.

No new tests.

* page/Settings.cpp:
(WebCore::Settings::Settings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a very bare-bones implementation of bind and Function to WTF
andersca@apple.com [Wed, 14 Dec 2011 03:12:15 +0000 (03:12 +0000)]
Add a very bare-bones implementation of bind and Function to WTF
https://bugs.webkit.org/show_bug.cgi?id=74462

Reviewed by Sam Weinig.

Source/JavaScriptCore:

In order to make it easier to package up function calls and send them across
threads, add a (currently very simple) implementation of WTF::bind and WTF::Function to a new
wtf/Functional.h header.

Currently, all bind can do is bind a nullary function and return a Function object that can be called and copied,
but I'll add more as the need arises.

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Functional.h: Added.
(WTF::R):
(WTF::FunctionImplBase::~FunctionImplBase):
(WTF::FunctionWrapper::ResultType):
(WTF::FunctionBase::isNull):
(WTF::FunctionBase::FunctionBase):
(WTF::FunctionBase::impl):
(WTF::bind):
* wtf/MainThread.cpp:
(WTF::callFunctionObject):
(WTF::callOnMainThread):
* wtf/MainThread.h:
* wtf/wtf.pro:

Source/WebCore:

Add a forwarding header for Functional.h.

* ForwardingHeaders/wtf/Functional.h: Added.

Tools:

Add basic tests for WTF::Function and WTF::bind.

* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/Functional.cpp: Added.
(TestWebKitAPI::returnFortyTwo):
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=74456
dslomov@google.com [Wed, 14 Dec 2011 02:56:11 +0000 (02:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=74456
[V8][Chromium] Reenable dedicated worker layout tests.

Chromium-specific results are caused by exception message text differences between JSC and V8.

Reviewed by David Levin.

* platform/chromium/fast/workers/use-machine-stack-expected.txt: Added.
* platform/chromium/fast/workers/worker-constructor-expected.txt: Added.
* platform/chromium/fast/workers/worker-location-expected.txt: Added.
* platform/chromium/fast/workers/worker-script-error-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10577239> GC Crash introduced in r102545
ggaren@apple.com [Wed, 14 Dec 2011 02:55:02 +0000 (02:55 +0000)]
<rdar://problem/10577239> GC Crash introduced in r102545

Reviewed by Gavin Barraclough.

MarkedArgumentBuffer was still marking items in forwards order, even though
the argument order has been reversed.

I fixed this bug, and replaced address calculation code with some helper
functions -- mallocBase() and slotFor() -- so it stays fixed everywhere.

* runtime/ArgList.cpp:
(JSC::MarkedArgumentBuffer::markLists):
(JSC::MarkedArgumentBuffer::slowAppend):
* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::~MarkedArgumentBuffer):
(JSC::MarkedArgumentBuffer::at):
(JSC::MarkedArgumentBuffer::append):
(JSC::MarkedArgumentBuffer::last):
(JSC::MarkedArgumentBuffer::slotFor):
(JSC::MarkedArgumentBuffer::mallocBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochromium port - remove nacl hack in DEPS/gyp_webkit
dpranke@chromium.org [Wed, 14 Dec 2011 02:32:43 +0000 (02:32 +0000)]
chromium port - remove nacl hack in DEPS/gyp_webkit
https://bugs.webkit.org/show_bug.cgi?id=74150

Reviewed by Tony Chang.

This change reverts the change added in r101011; it is
no longer necessary to pull in anything from Native Client for
the chromium port to build.

* DEPS:
* gyp_webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
enne@google.com [Wed, 14 Dec 2011 01:52:40 +0000 (01:52 +0000)]
[chromium] Use HashMap<..., OwnPtr<Tile>> for compositor tilemap
https://bugs.webkit.org/show_bug.cgi?id=74154

Reviewed by James Robinson.

After r102410 landed, it's now possible to properly use an OwnPtr to
store tiles rather than hackily use a RefPtr.

Covered by the compositing/ layout tests.

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::UpdatableTile::create):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::createTile):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::addTile):
(WebCore::CCLayerTilingData::takeTile):
(WebCore::CCLayerTilingData::tileAt):
* platform/graphics/chromium/cc/CCLayerTilingData.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::create):
(WebCore::DrawableTile::DrawableTile):
(WebCore::CCTiledLayerImpl::createTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
kov@webkit.org [Wed, 14 Dec 2011 01:51:45 +0000 (01:51 +0000)]
Unreviewed build fix.

* GNUmakefile.am: make sure we do not derreference the target link
if it already exists, and replace it with the new one instead,
otherwise we end up with a gtk link inside
Source/WebKit2/UIProcess/API/gtk, which causes the documentation
build to produce warnings, and make the build fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG OSR exit for UInt32ToNumber should roll forward, not roll backward
fpizlo@apple.com [Wed, 14 Dec 2011 01:46:36 +0000 (01:46 +0000)]
DFG OSR exit for UInt32ToNumber should roll forward, not roll backward
https://bugs.webkit.org/show_bug.cgi?id=74463

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

Implements roll-forward OSR exit for UInt32ToNumber, which requires ValueRecoveries knowing
how to execute the slow path of UInt32ToNumber.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::lastOSRExit):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::operator!=):
* bytecode/ValueRecovery.h:
(JSC::ValueRecovery::uint32InGPR):
(JSC::ValueRecovery::gpr):
(JSC::ValueRecovery::dump):
* dfg/DFGAssemblyHelpers.cpp:
* dfg/DFGAssemblyHelpers.h:
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::valueRecoveryForOperand):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeUInt32ToNumber):
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-uint32-to-number-expected.txt: Added.
* fast/js/dfg-uint32-to-number.html: Added.
* fast/js/script-tests/dfg-uint32-to-number.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=73691
dslomov@google.com [Wed, 14 Dec 2011 01:17:41 +0000 (01:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.
This change supports a new signature of windowPostMessage:
  postMessage(message, targetOrigin[, transferrables])
as well as the legacy webkit-proprietary:
  postMessage(message, [transferrables,] targetOrigin)
The latter is only supported for cases when targetOrigin is a String.

Reviewed by David Levin.

Source/WebCore:

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[MutationObservers] Avoid allocations if no observers are present
adamk@chromium.org [Wed, 14 Dec 2011 01:03:01 +0000 (01:03 +0000)]
[MutationObservers] Avoid allocations if no observers are present
https://bugs.webkit.org/show_bug.cgi?id=74423

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-12-13
Reviewed by Ojan Vafai.

This patch adds Node::mayHaveMutationObserversOfType which can be used to check
if there are any observers at all which could receive a give type of mutation.
MutationObserverInterestGroup uses this to possibly exit early (returning
null) if no observers are present.

No tests needed. This patch is just a refactor.

* css/CSSMutableStyleDeclaration.cpp:
* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::MutationAccumulationRouter::incrementScopingLevel):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/Node.cpp:
(WebCore::Node::mayHaveMutationObserversOfType):
* dom/Node.h:
* dom/WebKitMutationObserver.cpp:
(WebCore::MutationObserverInterestGroup::createIfNeeded):
(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):
(WebCore::MutationObserverInterestGroup::MutationObserverInterestGroup):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
* dom/WebKitMutationObserver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport WebArrayBuffer::byteLength
commit-queue@webkit.org [Wed, 14 Dec 2011 00:20:11 +0000 (00:20 +0000)]
Export WebArrayBuffer::byteLength
https://bugs.webkit.org/show_bug.cgi?id=74438

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-13
Reviewed by Darin Fisher.

* public/WebArrayBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpanding context is broken for prepare-ChangeLog in the code review tool.
ojan@chromium.org [Wed, 14 Dec 2011 00:07:22 +0000 (00:07 +0000)]
Expanding context is broken for prepare-ChangeLog in the code review tool.
https://bugs.webkit.org/show_bug.cgi?id=74458

Reviewed by Adam Barth.

* code-review-test.html:
-Moved all the tests into test* functions.
-Automated calling all test* functions.
-Added testIsChangeLog.
* code-review.js:
Made the check for whether it's a ChangeLog file more robust.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Don't make the bitmap transparent when using theme drawing
kevino@webkit.org [Wed, 14 Dec 2011 00:00:43 +0000 (00:00 +0000)]
[wx] Don't make the bitmap transparent when using theme drawing
calls that don't support transparent bitmaps.
https://bugs.webkit.org/show_bug.cgi?id=74319

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r102652): New window opens with zero size at produbanco.com
kling@webkit.org [Tue, 13 Dec 2011 23:59:24 +0000 (23:59 +0000)]
REGRESSION (r102652): New window opens with zero size at produbanco.com
<http://webkit.org/b/74418> and <rdar://problem/10565998>

Reviewed by Anders Carlsson.

Don't use the cached window frame if it's empty (meaning we haven't received
a WindowAndViewFramesChanged message yet.) Instead use the synchronous
GetWindowFrame (WP->UIP) message.

This situation occurs when opening a new window via window.open(), in which
WebCore::createWindow() will query the windowRect() on the new window.

I spent a long time trying to write a layout test for this but couldn't come
up with something reliable. The windowRect() is non-empty before we get a
chance to run JS in/on the new window, and we can't check against the
requested geometry since it varies depending on whether the window manager
has shown the new window yet.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRolling out r102461, a change to a layout test to try to remove flakiness on Chromium.
tony@chromium.org [Tue, 13 Dec 2011 23:54:03 +0000 (23:54 +0000)]
Rolling out r102461, a change to a layout test to try to remove flakiness on Chromium.

http://trac.webkit.org/changeset/102461
Test is still flaky on Chromium, so rollout the change.

* fast/replaced/width100percent-textarea.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Add a URL argument to the wxWebView constructor,
kevino@webkit.org [Tue, 13 Dec 2011 23:50:44 +0000 (23:50 +0000)]
[wx] Add a URL argument to the wxWebView constructor,
and fix page calculations and margins on Windows and Mac.
https://bugs.webkit.org/show_bug.cgi?id=74316

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInline all of initForRegionStyling except for the rarely used part for non-null regions.
tony@chromium.org [Tue, 13 Dec 2011 23:50:23 +0000 (23:50 +0000)]
Inline all of initForRegionStyling except for the rarely used part for non-null regions.
https://bugs.webkit.org/show_bug.cgi?id=74435

Reviewed by Andreas Kling.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForRegionStyling): Inline setting of m_regionForStyling
(WebCore::CSSStyleSelector::initRegionRules): Move code that only
applies to CSSRegions into non-inlined code.
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Blackberry] Fix a leak in BackingStore class
commit-queue@webkit.org [Tue, 13 Dec 2011 23:39:48 +0000 (23:39 +0000)]
[Blackberry] Fix a leak in BackingStore class

Don't leak the blit generation condvar and mutex.

https://bugs.webkit.org/show_bug.cgi?id=74444

Patch by Arvid Nilsson <anilsson@rim.com> on 2011-12-13
Reviewed by Antonio Gomes.

* blackberry/Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinline setting m_regionForStyling since region is rarely set
tony@chromium.org [Tue, 13 Dec 2011 23:38:17 +0000 (23:38 +0000)]
inline setting m_regionForStyling since region is rarely set
https://bugs.webkit.org/show_bug.cgi?id=74435

Reviewed by Andreas Kling.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug in the code review tool when readding a discarded comment
ojan@chromium.org [Tue, 13 Dec 2011 23:26:58 +0000 (23:26 +0000)]
Fix bug in the code review tool when readding a discarded comment
https://bugs.webkit.org/show_bug.cgi?id=74450

Reviewed by Adam Barth.

If you discard a comment that has a corresponding previousComment,
then we would incorrectly remove the comment baseline. So, the next
time you added a comment by clicking on the previousComment, we
would get undefined as the start line for the new comment.

All of this works fine until you try to restore the comment from
localStorage, at which point we throw an error because the start
line is undefined.

Also added some failsafes to better handle the case of corrupted comments.

* code-review-test.html:
* code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium expectations update. Expand a couple of existing suppressions.
kbr@google.com [Tue, 13 Dec 2011 23:19:19 +0000 (23:19 +0000)]
Unreviewed Chromium expectations update. Expand a couple of existing suppressions.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoArguments object doesn't handle mutation of length property correctly
oliver@apple.com [Tue, 13 Dec 2011 23:17:43 +0000 (23:17 +0000)]
Arguments object doesn't handle mutation of length property correctly
https://bugs.webkit.org/show_bug.cgi?id=74454

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Correct handling of arguments objects with overridden length property

* interpreter/Interpreter.cpp:
(JSC::loadVarargs):
* runtime/Arguments.cpp:
(JSC::Arguments::copyToArguments):
(JSC::Arguments::fillArgList):

LayoutTests:

Add tests of mutated arguments.length

* fast/js/arguments-expected.txt:
* fast/js/script-tests/arguments.js:
(argumentLengthIs5):
(duplicateArgumentAndReturnLast_call):
(duplicateArgumentAndReturnFirst_call):
(duplicateArgumentAndReturnLast_apply):
(duplicateArgumentAndReturnFirst_apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, Chromium Mac build fix.
simonjam@chromium.org [Tue, 13 Dec 2011 22:24:38 +0000 (22:24 +0000)]
Unreviewed, Chromium Mac build fix.

* page/PerformanceTiming.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG GetByVal CSE rule should match PutByValAlias
fpizlo@apple.com [Tue, 13 Dec 2011 22:12:33 +0000 (22:12 +0000)]
DFG GetByVal CSE rule should match PutByValAlias
https://bugs.webkit.org/show_bug.cgi?id=74390

Reviewed by Geoff Garen.

Tiny win on some benchmarks. Maybe a 0.2% win on SunSpider.

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix interpreter debug build.
commit-queue@webkit.org [Tue, 13 Dec 2011 22:10:05 +0000 (22:10 +0000)]
Fix interpreter debug build.
https://bugs.webkit.org/show_bug.cgi?id=74439

Patch by Andy Wingo <wingo@igalia.com> on 2011-12-13
Reviewed by Geoffrey Garen.

* bytecode/ValueRecovery.h: Include stdio.h on debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate variable names in NamedNodeMap methods to match WebKit style
adamk@chromium.org [Tue, 13 Dec 2011 22:05:00 +0000 (22:05 +0000)]
Update variable names in NamedNodeMap methods to match WebKit style
https://bugs.webkit.org/show_bug.cgi?id=74437

Reviewed by Ojan Vafai.

While reading these methods in preparation for a refactor, I found
them hard to understand due to short or confusing variable names.
I think the new names are much clearer, and match WebKit style.

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::removeNamedItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowatchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
kubo@profusion.mobi [Tue, 13 Dec 2011 21:50:52 +0000 (21:50 +0000)]
watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
https://bugs.webkit.org/show_bug.cgi?id=74430

Reviewed by David Levin.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r102693.
kbr@google.com [Tue, 13 Dec 2011 21:42:54 +0000 (21:42 +0000)]
Unreviewed, rolling out r102693.
http://trac.webkit.org/changeset/102693
https://bugs.webkit.org/show_bug.cgi?id=74334

Broke Chromium Windows DRT build

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement a function of vector multiply with SSE2 optimization in VectorMath.cpp.
commit-queue@webkit.org [Tue, 13 Dec 2011 21:42:37 +0000 (21:42 +0000)]
Implement a function of vector multiply with SSE2 optimization in VectorMath.cpp.
https://bugs.webkit.org/show_bug.cgi?id=74048

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2011-12-13
Reviewed by Benjamin Poulain.

The vmul is a function for an element-by-element multiply of two float vectors and we
get about 3.4x performance improvement with SSE2 optimization compared with the common
multiply.

Use vmul in AudioBus::copyWithSampleAccurateGainValuesFrom().

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::copyWithSampleAccurateGainValuesFrom):
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vmul):
* platform/audio/VectorMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Regression] ResourceHeadersView sections should be expanded by default.
vsevik@chromium.org [Tue, 13 Dec 2011 21:27:15 +0000 (21:27 +0000)]
Web Inspector: [Regression] ResourceHeadersView sections should be expanded by default.
https://bugs.webkit.org/show_bug.cgi?id=74434

Reviewed by Pavel Feldman.

* inspector/front-end/treeoutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Pull in FreeType and decrease check-out complexity for Android
peter@chromium.org [Tue, 13 Dec 2011 21:23:02 +0000 (21:23 +0000)]
[Chromium] Pull in FreeType and decrease check-out complexity for Android
https://bugs.webkit.org/show_bug.cgi?id=74401

Source/WebKit/chromium:

Pull in FreeType in the third_party/ directory from a separate git
repository at Chromium. This introduces a new prerequisite for checking
out the Chromium WebKit port for Android, namely that git needs to be
available on the system. gclient can handle this just fine.

Reviewed by Adam Barth.

* DEPS:

Tools:

Decrease the check-out complexity by removing the need to first run
"update-webkit-chromium --chromium" prior to running it with
"--chromium-android", which was caused by an unversioned third_party/
directory being created. This moves the Android NDK to Source/WebKit/
chromium/, coming from third_party/ in that directory.

Reviewed by Adam Barth.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(buildChromiumMakefile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Network item view does not correctly decode "+" in request parameters.
vsevik@chromium.org [Tue, 13 Dec 2011 21:19:52 +0000 (21:19 +0000)]
Web Inspector: Network item view does not correctly decode "+" in request parameters.
https://bugs.webkit.org/show_bug.cgi?id=74422

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/network/request-parameters-decoding.html

* inspector/front-end/ResourceHeadersView.js:
(WebInspector.ResourceHeadersView.prototype._formatParameter):
(WebInspector.ResourceHeadersView.prototype._refreshParms):

LayoutTests:

* http/tests/inspector/network/request-parameters-decoding-expected.txt: Added.
* http/tests/inspector/network/request-parameters-decoding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] compositing/masks layout tests fail with accelerated drawing
alokp@chromium.org [Tue, 13 Dec 2011 21:12:40 +0000 (21:12 +0000)]
[chromium] compositing/masks layout tests fail with accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=72760

Reviewed by Stephen White.

Source/WebCore:

Accelerated drawing path used to render bottom-up upright textures, which was opposite of what the software path rendered.
The textures produced by the accelerated path was flipped along Y in the shader to make it upside down as expected by the compositor.
This strategy does not work in case of masks which do not go through a shader and hence do not get flipped,
which results in a case where texture in the render surface is top-down, while that in the mask is bottom-up.
This patch makes accelerated drawing path render textures in the same orientation as the software path.
LayerTextureUpdater::Orientation was added to support the difference in texture orientation between software and accelerated paths.
Now that both paths produce textures in the same orientation, there is no need for it.

No new tests needed. Covered by existing compositing tests.

* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(WebCore::CCTiledLayerImpl::setSkipsDraw):

Source/WebKit/chromium:

* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::createTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement GLES2 CheckFramebufferStatus() behavior
zmo@google.com [Tue, 13 Dec 2011 20:53:17 +0000 (20:53 +0000)]
Implement GLES2 CheckFramebufferStatus() behavior
https://bugs.webkit.org/show_bug.cgi?id=74228

Reviewed by Kenneth Russell.

Source/WebCore:

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::getColorBufferWidth): Add ColorBuffer to the function name - this is more accurate.
(WebCore::WebGLFramebuffer::getColorBufferHeight): Ditto.
(WebCore::WebGLFramebuffer::checkStatus): Implement full semantics of GLES2 glCheckFramebufferStatus().
(WebCore::WebGLFramebuffer::onAccess): Call checkStatus().
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::checkFramebufferStatus): Call checkStatus().
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): No longer check framebuffer status.
(WebCore::WebGLRenderingContext::getBoundFramebufferWidth): Call getColorBufferWidth.
(WebCore::WebGLRenderingContext::getBoundFramebufferHeight): Call getColorBufferHeight.

LayoutTests:

* fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
* fast/canvas/webgl/framebuffer-object-attachment.html: sync with khronos side, the whole file
* fast/canvas/webgl/resources/webgl-test.js: synced with khronos side, two listed functions
(shouldGenerateGLError):
(glErrorShouldBe):
* platform/chromium/test_expectations.txt: Mark framebuffer-object-*.html as failing due to mesa lib bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()
simonjam@chromium.org [Tue, 13 Dec 2011 20:48:08 +0000 (20:48 +0000)]
[Navigation Timing] Use monotonicallyIncreasingTime() instead of currentTime()
https://bugs.webkit.org/show_bug.cgi?id=58354

Reviewed by Pavel Feldman.

No new tests. Relies on existing webtiming-* tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp: Use monotonic times.
(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishLoadingImpl): Convert monotonicFinishTime to wall time if needed.
* inspector/InspectorResourceAgent.cpp:
(WebCore::buildObjectForTiming): Convert monotonic requestTime to wall time.
(WebCore::buildObjectForResourceResponse): Plumbing for above.
(WebCore::buildObjectForCachedResource): Ditto.
(WebCore::InspectorResourceAgent::willSendRequest): Ditto.
(WebCore::InspectorResourceAgent::didReceiveResponse): Ditto.
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache): Ditto.
* loader/DocumentLoadTiming.cpp: Added.
(WebCore::DocumentLoadTiming::DocumentLoadTiming):
(WebCore::DocumentLoadTiming::setNavigationStart): Determine reference time and root reference time.
(WebCore::DocumentLoadTiming::addRedirect): Moved logic from MainResourceLoader.
(WebCore::DocumentLoadTiming::convertMonotonicTimeToDocumentTime): Helper to compute wall time from monotonic time.
* loader/DocumentLoadTiming.h: Turned into class. Made times monotonic.
(WebCore::DocumentLoadTiming::setUnloadEventStart):
(WebCore::DocumentLoadTiming::setUnloadEventEnd):
(WebCore::DocumentLoadTiming::setRedirectStart):
(WebCore::DocumentLoadTiming::setRedirectEnd):
(WebCore::DocumentLoadTiming::setFetchStart):
(WebCore::DocumentLoadTiming::setResponseEnd):
(WebCore::DocumentLoadTiming::setLoadEventStart):
(WebCore::DocumentLoadTiming::setLoadEventEnd):
(WebCore::DocumentLoadTiming::setHasSameOriginAsPreviousDocument):
(WebCore::DocumentLoadTiming::navigationStart):
(WebCore::DocumentLoadTiming::unloadEventStart):
(WebCore::DocumentLoadTiming::unloadEventEnd):
(WebCore::DocumentLoadTiming::redirectStart):
(WebCore::DocumentLoadTiming::redirectEnd):
(WebCore::DocumentLoadTiming::redirectCount):
(WebCore::DocumentLoadTiming::fetchStart):
(WebCore::DocumentLoadTiming::responseEnd):
(WebCore::DocumentLoadTiming::loadEventStart):
(WebCore::DocumentLoadTiming::loadEventEnd):
(WebCore::DocumentLoadTiming::hasCrossOriginRedirect):
(WebCore::DocumentLoadTiming::hasSameOriginAsPreviousDocument):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::willSendRequest): Moved logic to DocumentLoadTiming.
(WebCore::MainResourceLoader::didReceiveData): Use monotonic time.
(WebCore::MainResourceLoader::didFinishLoading): Ditto.
(WebCore::MainResourceLoader::load):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
* page/DOMWindow.h: Removed dispatchTimedEvent. It doesn't really help in the new model.
* page/PerformanceNavigation.cpp:
(WebCore::PerformanceNavigation::redirectCount):
* page/PerformanceTiming.cpp: Removed skew correction code. This should never happen now.
(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::domLoading):
(WebCore::PerformanceTiming::domInteractive):
(WebCore::PerformanceTiming::domContentLoadedEventStart):
(WebCore::PerformanceTiming::domContentLoadedEventEnd):
(WebCore::PerformanceTiming::domComplete):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Used for ResourceLoadTiming.
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds): Used for DocumentTiming and DocumentLoadTiming.
* page/PerformanceTiming.h:
* platform/network/ResourceLoadTiming.cpp:
(WebCore::ResourceLoadTiming::convertResourceLoadTimeToDocumentTime):
* platform/network/ResourceLoadTiming.h: Added helper function to convert to wall times. Added instructions for use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce code duplication in Element::setAttribute methods
adamk@chromium.org [Tue, 13 Dec 2011 20:40:51 +0000 (20:40 +0000)]
Reduce code duplication in Element::setAttribute methods
https://bugs.webkit.org/show_bug.cgi?id=74425

Reviewed by Ryosuke Niwa.

Two overloads of Element::setAttribute share almost all their code,
including tricky logic around updating the appropriate Attribute and
Attr objects and notifying the Inspector and MutationObservers.

This patch puts the common logic in a new setAttributeInternal method
which is called by the other two.

No new tests, refactoring only.

* dom/Element.cpp:
(WebCore::Element::setAttribute):
(WebCore::Element::setAttributeInternal):
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should know exactly why recompilation was triggered
fpizlo@apple.com [Tue, 13 Dec 2011 19:49:49 +0000 (19:49 +0000)]
DFG should know exactly why recompilation was triggered
https://bugs.webkit.org/show_bug.cgi?id=74362

Reviewed by Oliver Hunt.

Each OSR exit is now individually counted, as well as counting the total number
of OSR exits that occurred in a code block. If recompilation is triggered, we
check to see if there are OSR exit sites that make up a sufficiently large
portion of the total OSR exits that occurred. For any such OSR exit sites, we
add a description of the site (bytecode index, kind) to a data structure in the
corresponding baseline CodeBlock. Then, when we recompile the code, we immediately
know which speculations would be unwise based on the fact that previous such
speculations proved to be fruitless.

This means 2% win on two of the SunSpider string tests, a 4% win on V8's deltablue,
and 5% on Kraken's imaging-darkroom. It is only a minor win in the averages, less
than 0.5%.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::exitProfile):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::tallyFrequentExitSites):
* bytecode/DFGExitProfile.cpp: Added.
(JSC::DFG::ExitProfile::ExitProfile):
(JSC::DFG::ExitProfile::~ExitProfile):
(JSC::DFG::ExitProfile::add):
(JSC::DFG::QueryableExitProfile::QueryableExitProfile):
(JSC::DFG::QueryableExitProfile::~QueryableExitProfile):
* bytecode/DFGExitProfile.h: Added.
(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):
(JSC::DFG::FrequentExitSite::FrequentExitSite):
(JSC::DFG::FrequentExitSite::operator!):
(JSC::DFG::FrequentExitSite::operator==):
(JSC::DFG::FrequentExitSite::hash):
(JSC::DFG::FrequentExitSite::bytecodeOffset):
(JSC::DFG::FrequentExitSite::kind):
(JSC::DFG::FrequentExitSite::isHashTableDeletedValue):
(JSC::DFG::FrequentExitSiteHash::hash):
(JSC::DFG::FrequentExitSiteHash::equal):
(JSC::DFG::QueryableExitProfile::hasExitSite):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::baselineCodeBlockForOriginAndBaselineCodeBlock):
(JSC::DFG::AssemblyHelpers::baselineCodeBlockFor):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGOSRExit.h:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayLength):
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithMul):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102694 268f45cc-cd09-0410-ab3c-d52691b4dbfc