WebKit-https.git
9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 1 Dec 2010 00:40:17 +0000 (00:40 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Cleanup UTF8.cpp
        https://bugs.webkit.org/show_bug.cgi?id=49581

        Use macros and functions instead of range values directly.

        * wtf/unicode/UTF8.cpp:
        (WTF::Unicode::inlineUTF8SequenceLength):
        (WTF::Unicode::UTF8SequenceLength):
        (WTF::Unicode::convertUTF16ToUTF8):
        (WTF::Unicode::readUTF8Sequence):
        (WTF::Unicode::convertUTF8ToUTF16):
        * wtf/unicode/UnicodeMacrosFromICU.h: Added U_IS_SUPPLEMENTARY macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename DrawingAreaBase.h to DrawingAreaInfo.h.
andersca@apple.com [Wed, 1 Dec 2010 00:37:28 +0000 (00:37 +0000)]
Rename DrawingAreaBase.h to DrawingAreaInfo.h.

Reviewed by Sam Weinig.

* Shared/DrawingAreaInfo.h: Renamed from WebKit2/Shared/DrawingAreaBase.h.
(WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo):
(WebKit::DrawingAreaBase::~DrawingAreaBase):
(WebKit::DrawingAreaBase::info):
(WebKit::DrawingAreaBase::DrawingAreaBase):
* Shared/WebPageCreationParameters.h:
* UIProcess/DrawingAreaProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingArea.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 1 Dec 2010 00:32:06 +0000 (00:32 +0000)]
2010-11-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        REGRESSION(r72861): editing/selection/click-left-of-rtl-wrapping-text.html and
        modify-up-on-rtl-wrapping-text.html fail on all but Mac platform
        https://bugs.webkit.org/show_bug.cgi?id=50204

        Fixed the tests. Instead of using "ex" to specify the width of the container div,
        the tests now auto-detect the correct width by comparing the computed height to
        the expected height deduced from the height of one line and the expected number of lines.

        * editing/selection/click-left-of-rtl-wrapping-text-expected.txt:
        * editing/selection/click-left-of-rtl-wrapping-text.html:
        * editing/selection/modify-up-on-rtl-wrapping-text.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProgress and meter elements should take a form in their constructor like any other...
yael.aharon@nokia.com [Wed, 1 Dec 2010 00:13:33 +0000 (00:13 +0000)]
Progress and meter elements should take a form in their constructor like any other form control.
https://bugs.webkit.org/show_bug.cgi?id=50195

Reviewed by Darin Adler.

WebCore:

Tests: fast/dom/HTMLMeterElement/meter-element-form.html
       fast/dom/HTMLProgressElement/progress-element-form.html

* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::HTMLMeterElement):
(WebCore::HTMLMeterElement::create):
* html/HTMLMeterElement.h:
* html/HTMLProgressElement.h:
* html/HTMLTagNames.in:

LayoutTests:

* fast/dom/HTMLMeterElement/meter-element-form-expected.txt: Added.
* fast/dom/HTMLMeterElement/meter-element-form.html: Added.
* fast/dom/HTMLProgressElement/progress-element-form-expected.txt: Added.
* fast/dom/HTMLProgressElement/progress-element-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 1 Dec 2010 00:01:42 +0000 (00:01 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Unreviewed, remove dupe expectation for chromium win drt.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 23:55:46 +0000 (23:55 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=49036

        No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html

        In http://codereview.chromium.org/11574, the forked chromium test
        plugin changed how it testGetIntIdentifier to work around a change
        caused by a silverlight specific plugin fix:
        http://codereview.chromium.org/11569/diff/1/2

        It's not clear to me that this change is needed anymore since
        silverlight has had multiple releases, testing without this patch
        works on a test windows build, and safari win seems to run silverlight
        without this either.  Since there's no test for this behavior, I'm
        rolling it out so we can match the upstream test.

        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
        https://bugs.webkit.org/show_bug.cgi?id=49036

        * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
            for CppVariants.
        (LayoutTestController::cppVariantToBool):
        (LayoutTestController::cppVariantToInt32):
        (LayoutTestController::setDatabaseQuota):
        (LayoutTestController::evaluateInWebInspector):
        (LayoutTestController::setMockGeolocationError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Tue, 30 Nov 2010 23:48:07 +0000 (23:48 +0000)]
Fix build.

* PluginProcess/mac/PluginProcessShim.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a simple shim function for Debugger().
andersca@apple.com [Tue, 30 Nov 2010 23:44:16 +0000 (23:44 +0000)]
Add a simple shim function for Debugger().
https://bugs.webkit.org/show_bug.cgi?id=50268

Reviewed by Dan Bernstein.

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initShouldCallRealDebugger):
We only want to call the real Debugger() function when USERBREAK is set.

(WebKit::shouldCallRealDebugger):
Return whether USERBREAK is set.

(WebKit::PluginProcess::initializeShim):
Initialize the shim.

* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
Call PluginProcess::initializeShim.

* PluginProcess/mac/PluginProcessShim.cpp:
(WebKit::WebKitPluginProcessShimInitialize):
This now takes a struct of callbacks.

(WebKit::shimDebugger):
Call the shouldCallDebugger function. If it returns true, the real Debugger() function should be called.

* PluginProcess/mac/PluginProcessShim.h:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 23:31:52 +0000 (23:31 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Unreviewed, try to green the chromium win DRT bot.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 23:27:36 +0000 (23:27 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Mark failing tests after http://trac.webkit.org/changeset/72962/
        to green the chromium tree.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Chris Guillory <chris.guillory@google.com>
inferno@chromium.org [Tue, 30 Nov 2010 23:21:15 +0000 (23:21 +0000)]
2010-11-30  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Computing style on a stale node while sending pending accessibility notification.
        https://bugs.webkit.org/show_bug.cgi?id=50162

        Retain node pointer members of AccessibilityImageMapLink.

        Test: accessibility/image-map-title-causes-crash.html

        * accessibility/AccessibilityImageMapLink.cpp:
        (WebCore::AccessibilityImageMapLink::parentObject):
        (WebCore::AccessibilityImageMapLink::anchorElement):
        (WebCore::AccessibilityImageMapLink::url):
        (WebCore::AccessibilityImageMapLink::elementRect):
        * accessibility/AccessibilityImageMapLink.h:
        (WebCore::AccessibilityImageMapLink::areaElement):
        (WebCore::AccessibilityImageMapLink::mapElement):
        (WebCore::AccessibilityImageMapLink::node):
        * dom/Document.cpp:
        (WebCore::Document::clearAXObjectCache):
2010-11-30  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Computing style on a stale node while sending pending accessibility notification.
        https://bugs.webkit.org/show_bug.cgi?id=50162

        * accessibility/image-map-title-causes-crash-expected.txt: Added.
        * accessibility/image-map-title-causes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 30 Nov 2010 23:17:48 +0000 (23:17 +0000)]
2010-11-30  James Robinson  <jamesr@chromium.org>

        Reviewed by Tony Chang.

        Build fix - add parens in foo || bar && baz to make gcc happy
        https://bugs.webkit.org/show_bug.cgi?id=50276

        gcc 4.4 warns that statements of the form "foo || bar && baz".  It wants
        parens around the "bar && baz" part to make it clear which way the logical
        operators bind.

        * editing/TextIterator.cpp:
        (WebCore::SearchBuffer::search):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a crash seen when using a PageAllocation to store itself.
ggaren@apple.com [Tue, 30 Nov 2010 22:57:02 +0000 (22:57 +0000)]
Fixed a crash seen when using a PageAllocation to store itself.

Reviewed by Gavin Barraclough.

* wtf/PageAllocation.h:
(WTF::PageAllocation::systemDeallocate): Zero out m_base before unmapping
it, in case unmapping m_base unmaps the PageAllocation.

* wtf/BumpPointerAllocator.h:
(WTF::BumpPointerPool::destroy): Now this work-around isn't needed!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Nov 2010 22:50:12 +0000 (22:50 +0000)]
2010-11-30  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        update-webkit should call git fetch before git svn rebase
        https://bugs.webkit.org/show_bug.cgi?id=50273

        After discussion on webkit-dev, we've decided to move the "default"
        git setup to pulling updates from git.webkit.org in preference
        to rebuilding the local svn index using git svn fetch every time.

        This change should have no effect on people using the "old" git setup
        and should dramatically increase the speed of updates for those using
        the "new" git setup along with update-webkit.  I'm about to move the
        EWS and other queues over to this setup once this lands.

        * Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 30 Nov 2010 22:30:09 +0000 (22:30 +0000)]
2010-11-30  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Update yasm entry in DEPS to match downstream
        https://bugs.webkit.org/show_bug.cgi?id=50274

        http://src.chromium.org/viewvc/chrome?view=rev&revision=67540 changed the downstream DEPS rule
        for yasm to pull unconditionally rather than pulling in each deps_os.  This changes the WebKit
        chromium DEPS to match.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 22:18:54 +0000 (22:18 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Add new expected result after http://trac.webkit.org/changeset/72689
        and update test expectations to match the builders and pull the appropriate bits
        from the downstream expectations file.

        * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.checksum:
        * platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 22:07:13 +0000 (22:07 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        GTK: AX: implement press in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36146

        Unskipped test accessibility/label-element-press.html.

        * platform/gtk/Skipped: Unskip passing test.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        GTK: AX: implement press in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36146

        Implement AccessibilityUIElement::press() for GTK.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::press): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 30 Nov 2010 21:57:16 +0000 (21:57 +0000)]
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by David Hyatt.

        Focused <area> should use CSS properties of <area> instead of associated <img>
        https://bugs.webkit.org/show_bug.cgi?id=49888

        Fixes an issue where the CSS properties of an <area> were not used when
        the <area> was focused.

        Currently, when focusing an <area> (say by pressing option + tab in Mac
        Safari) we use the CSS style information for the <img> associated with
        the <area>. Instead, we should use the CSS style information for the
        focused <area>. In particular, this will make the us honor the outline-
        color property of a focused <area> when drawing its focus ring.

        Tests: fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
               fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
               fast/images/imagemap-focus-ring-outline-color.html

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintFocusRing): Use the style information of
        the focused <area> when drawing the focus ring for it.
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by David Hyatt.

        Focused <area> should use CSS properties of <area> instead of associated <img>
        https://bugs.webkit.org/show_bug.cgi?id=49888

        Updated the test result for test fast/images/imagemap-focus-ring.html. Added
        test to verify that the color of the focus ring for a focused <area> is
        the outline-color specified by the :focus pseudo-class .

        Also, added tests to ensure that outline-color is not inherited (by default) as per
        section 18.4 of the CSS 2.1 spec <http://www.w3.org/TR/CSS2/ui.html#dynamic-outlines>,
        unless explicitly inherited.

        * fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html: Added.
        * fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html: Added.
        * fast/images/imagemap-focus-ring-outline-color.html: Added.
        * platform/mac/fast/images/imagemap-focus-ring-expected.checksum: Updated result.
        * platform/mac/fast/images/imagemap-focus-ring-expected.png: Ditto.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.txt: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.checksum: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Added.
        * platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Nov 2010 21:56:03 +0000 (21:56 +0000)]
2010-11-30  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        m_hasNonEnumerableProperties is never initialized in Structure
        https://bugs.webkit.org/show_bug.cgi?id=50266

        * runtime/Structure.cpp:
        (JSC::Structure::Structure): initialize member variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 30 Nov 2010 21:49:25 +0000 (21:49 +0000)]
2010-11-30  Tony Chang  <tony@chromium.org>

        Reviewed by James Robinson.

        [chromium] enable WebCore compiler warnings on Linux take 3
        https://bugs.webkit.org/show_bug.cgi?id=50258

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 21:38:55 +0000 (21:38 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Update expectations to de-orange the builders.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 21:16:14 +0000 (21:16 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Implement ROLE_COMBO_BOX
        https://bugs.webkit.org/show_bug.cgi?id=25678

        Implement the remaining bits for combo boxes.

        This patch finishes the implementation, from the point of view of
        the Atk library, of those objects exposed to ATK as combo boxes,
        and their related elements (menus and menu items). It therefore
        implements the proper interfaces for each type of object related
        to combo boxes (AtkSelection for the combo box, AtkText for every
        menu item and AtkAction for the combo box, the menu and the menu
        items), takes care of emitting the proper signals when focus or a
        given a selection changes and adds a new unit test to check all
        this new stuff.

        Make possible to ask an AccessibleMenuListOption for a sensible
        string representation, so far only available through the private
        and MSAA related method nameForMSAA. Just moved the implementation
        of that method to an overriden version of stringValue(), which is
        platform independent, and called that from nameForMSAA().

        * accessibility/AccessibilityMenuListOption.h:
        * accessibility/AccessibilityMenuListOption.cpp:
        (WebCore::AccessibilityMenuListOption::nameForMSAA): Just call to
        stringValue(), which holds from now on that used to be here.
        (WebCore::AccessibilityMenuListOption::stringValue): New, override
        of AccessibilityObject::stringValue() to return a proper string.

        Emit the missing signals when a selection is made.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::AXObjectCache::postPlatformNotification): Emit the usual
        'focus' signals when a selection is made over the combo box.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (setAtkStateSetFromCoreObject): Ensure the EXPANDABLE and EXPANDED
        Atk states are added to the state set when needed.
        (listObjectForSelection): New, returns the proper list object (the
        one holding the list of available options as its children) for an
        specific AtkObject implementing AtkSelection. This is needed
        because sometimes the selectable options are not directly children
        of the AtkSelection object (i.e. a combo box has a 'menu' object
        as its only child of it, holding the list of options as children).
        (optionFromList): Use listObjectForSelection() to get the actual
        object holding the list of children as the available options.
        (optionFromSelection): Add support for combo boxes.
        (webkit_accessible_selection_add_selection): Ditto.
        (webkit_accessible_selection_clear_selection): Ditto.
        (webkit_accessible_selection_get_selection_count): Ditto.
        (webkit_accessible_selection_is_child_selected): Ditto.
        (webkit_accessible_selection_remove_selection): Ditto.
        (webkit_accessible_text_get_text): Makes sure stringValue() is
        considered to get the result substring when it was already
        considered when checking the maximum text length for the object.
        (getInterfaceMaskFromObject): Make sure the AtkSelection interface
        is implemented for the combo boxes, that the AtkText is
        implemented for the menu items and that the AtkAction interface is
        now implemented for every object (WebCore will decide what to do).

        Avoid a segfault crash when using this from unit tests.

        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenuGtk::show): Make sure we got a valid GdkWindow
        before calling gdk_window_get_origin() over it.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Implement ROLE_COMBO_BOX
        https://bugs.webkit.org/show_bug.cgi?id=25678

        New test to check the implementation of the combo boxes.

        * tests/testatk.c:
        (testWebkitAtkComboBox): New test, checking that the roles and the
        implemented interfaces for a combo box and its descendants work.
        (main): Added the new unit test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPass the plug-in process shim in DYLD_INSERT_LIBRARIES when launching the plug-in...
andersca@apple.com [Tue, 30 Nov 2010 21:05:47 +0000 (21:05 +0000)]
Pass the plug-in process shim in DYLD_INSERT_LIBRARIES when launching the plug-in process
https://bugs.webkit.org/show_bug.cgi?id=50262

Reviewed by Sam Weinig.

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
Add an EnvironmentVariables class that allows for easy modification of the environment variables
passed to posix_spawn.

(WebKit::ProcessLauncher::launchProcess):
When spawning the plug-in process, insert the plug-in process shim.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 30 Nov 2010 20:59:00 +0000 (20:59 +0000)]
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Tor Arne Vestbø.

        [Qt] GraphicsContext: Avoid unnecessarily copying the painter's QTransform

        Stash the transform in a const reference (QPainter::transform() returns one)
        instead of making a copy in the shadow drawing parts of fillPath, strokePath and fillRect.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd plug-in process shim
andersca@apple.com [Tue, 30 Nov 2010 20:53:08 +0000 (20:53 +0000)]
Add plug-in process shim
https://bugs.webkit.org/show_bug.cgi?id=50261

Reviewed by Sam Weinig.

* Configurations/PluginProcessShim.xcconfig: Added.
* PluginProcess/mac/PluginProcessShim.cpp: Added.
(PluginProcessShimInitialize):
* PluginProcess/mac/PluginProcessShim.h: Added.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 30 Nov 2010 20:41:59 +0000 (20:41 +0000)]
2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on accelerated
        compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
        has now been replaced by allowedCompositingTriggers which returns a bitfield of
        all the features which can trigger the compositor.

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::allowedCompositingTriggers):
        * src/ChromeClientImpl.h:
2010-11-29  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on accelerated
        compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        As part of this change, the old hasAcceleratedCompositing method on the ChromeClient
        has now been replaced by allowedCompositingTriggers which returns a bitfield of
        all the features which can trigger the compositor.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::allowedCompositingTriggers):
        * WebCoreSupport/ChromeClientQt.h:
2010-11-30  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Simon Fraser.

        Provide more fine grained control to ports over when to turn on
        accelerated compositing.
        https://bugs.webkit.org/show_bug.cgi?id=49998

        The RenderLayerCompositor now checks with the chrome client whether
        3d transforms, video, plugins, canvas and animation require
        switching over to the composited path. Layers that overlap composited
        content will still turn into composited layers regardless of the
        setting.

        * css/MediaQueryEvaluator.cpp:
        (WebCore::transform_3dMediaFeatureEval):
        * page/ChromeClient.h:
        (WebCore::ChromeClient::allowedCompositingTriggers):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::canRender3DTransforms):
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::currentTransform):
        * rendering/RenderLayer.h:
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateLayerTransform):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):
        (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
        (WebCore::RenderLayerCompositor::canRender3DTransforms):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):
        (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
        (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
        (WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
        (WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
        (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 30 Nov 2010 20:35:49 +0000 (20:35 +0000)]
2010-11-30  Daniel Bates  <dbates@rim.com>

        Reviewed by Alexey Proskuryakov.

        Change and focus events happen in different order if using tab vs. clicking
        https://bugs.webkit.org/show_bug.cgi?id=6181

        Tests to ensure adherence to section 7.4.2 of the HTML5 spec.
        <http://www.w3.org/TR/html5/editing.html#focus-management> with respect to
        focusing on an <input>, modifying its contents, and defocusing it either by
        pressing the tab key or clicking on another element.

        * fast/events/check-defocus-event-order-when-triggered-by-mouse-click-expected.txt: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-mouse-click.html: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-tab-expected.txt: Added.
        * fast/events/check-defocus-event-order-when-triggered-by-tab.html: Added.
        * fast/events/resources/record-events.js: Added.
        (registerElementsAndEventsToRecord):
        (beginRecordingEvents.callback):
        (beginRecordingEvents):
        (endRecordingEvents.callback):
        (endRecordingEvents):
        (_processEachRegisteredElement):
        (_recordEvent):
        (checkThatEventsFiredInOrder.eventTarget):
        (checkThatEventsFiredInOrder.elementIdOrTagName):
        (checkThatEventsFiredInOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 30 Nov 2010 20:27:06 +0000 (20:27 +0000)]
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Scroll position might not be exactly the same after page ZoomIn and ZoomOut, for example, they are not exactly the same in Windows platform.
        Change to test that the scroll position before and after ZoomIn/Out are close enough.
        Rebaseline horizontal-scrollbar-when-dir-change in Win7.

        * fast/dom/horizontal-scrollbar-in-rtl.html:
        * platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 30 Nov 2010 20:18:30 +0000 (20:18 +0000)]
2010-11-30 Xan Lopez <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Plug leak in SoupCache
        https://bugs.webkit.org/show_bug.cgi?id=50142

        Free the cache file contents when we don't need them anymore.

        * platform/network/soup/cache/webkit/soup-cache.c:
        (webkit_soup_cache_load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the Windows build by copying WKFindOptions.h into WebKitOutputDir with the other...
bweinstein@apple.com [Tue, 30 Nov 2010 20:02:08 +0000 (20:02 +0000)]
Fix the Windows build by copying WKFindOptions.h into WebKitOutputDir with the other headers.

* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 20:00:37 +0000 (20:00 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] New expected result after http://trac.webkit.org/changeset/72926/.
        That patch unintentionally fixed a bug where the skia codepath was drawing paths twice.
        The new results better match the platform/mac results (borders are grey instead of black).

        * platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum: Added.
        * platform/chromium-linux/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
        * platform/chromium-linux/svg/batik/paints/patternRegionA-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegionA-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
        * platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
        * platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.checksum:
        * platform/chromium-linux/svg/custom/pattern-incorrect-tiling-expected.png:
        * platform/chromium-linux/svg/custom/recursive-gradient-expected.checksum:
        * platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
        * platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.checksum:
        * platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
        * platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.checksum:
        * platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
        * platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.checksum:
        * platform/chromium-win/svg/custom/pattern-incorrect-tiling-expected.png:
        * platform/chromium-win/svg/custom/pattern-y-offset-expected.checksum:
        * platform/chromium-win/svg/custom/pattern-y-offset-expected.png:
        * platform/chromium-win/svg/custom/recursive-gradient-expected.checksum:
        * platform/chromium-win/svg/custom/recursive-gradient-expected.png:
        * platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.checksum:
        * platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.checksum:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Tue, 30 Nov 2010 19:57:02 +0000 (19:57 +0000)]
2010-11-30  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Make QtWebKit with V8 build on Linux.
        https://bugs.webkit.org/show_bug.cgi?id=50244

        No new tests needed.

        * WebCore.pri: add missing idl file
        * WebCore.pro: enable Linux build
        * bindings/scripts/CodeGeneratorV8.pm: add missing headers
        * bindings/v8/ScriptControllerQt.cpp: fix instantiation
        (WebCore::ScriptController::qtScriptEngine):
        * bindings/v8/V8GCController.cpp: fix guard
        (WebCore::V8GCController::checkMemoryUsage):
        * inspector/CodeGeneratorInspector.pm: add missing header
        * loader/ResourceLoadScheduler.cpp: ditto
        * loader/cache/MemoryCache.cpp: ditto
        * loader/loader.cpp: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=50183
hyatt@apple.com [Tue, 30 Nov 2010 19:48:39 +0000 (19:48 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50183

Reviewed by Simon Fraser.

Code got commented out by accident during render tree refactoring last year.  Put the code back in, since
it hurts performance to have that line commented out.

In order to put this code back in, I had to fix some bugs with preferred width computations and
overflow: scroll.  Make the pref widths computation create the scrollbar if it doesn't exist yet.

Make sure the scrollbar size is included prior to checking for defined width/min-width/max-width values.  Otherwise
the scrollbar inflates the width beyond the fixed size that was specified.

For table cells, there is an additional wrinkle.  Make sure not to include the scrollbar size as part of the minimum
intrinsic width so that we don't incorrectly grow.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::computePreferredLogicalWidths):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Windows build.
mitz@apple.com [Tue, 30 Nov 2010 19:44:36 +0000 (19:44 +0000)]
Try to fix the Windows build.

* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
hclam@chromium.org [Tue, 30 Nov 2010 19:35:56 +0000 (19:35 +0000)]
Not reviewed.

Submitted for Kenji Imasaki <imasaki@chromium.org>.

Update test expectations for Chromium to enable expectation analyzer for video.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 19:35:39 +0000 (19:35 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        Attempt to fix windows debug chromium build.

        * html/TimeInputType.cpp: Added include providing isfinite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded Leopard-specific results for editing/text-iterator/findString.html. In the...
mitz@apple.com [Tue, 30 Nov 2010 19:33:56 +0000 (19:33 +0000)]
Added Leopard-specific results for editing/text-iterator/findString.html. In the Leopard version
of ICU, the full stop character is a word separator, so an at-word-starts search for "org" in
"webkit.org" matches.

* platform/mac-leopard/editing/text-iterator: Added.
* platform/mac-leopard/editing/text-iterator/findString-expected.txt: Copied from LayoutTests/editing/text-iterator/findString-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 19:31:30 +0000 (19:31 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Updating test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 30 Nov 2010 19:31:15 +0000 (19:31 +0000)]
2010-11-30  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        DOM binding code generator scripts import unused File::stat Perl module
        https://bugs.webkit.org/show_bug.cgi?id=50250

        * bindings/scripts/CodeGeneratorCPP.pm: Removed "using File::stat".
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 30 Nov 2010 19:27:41 +0000 (19:27 +0000)]
2010-11-29  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        config.webkit_base_dir returns a path with a trailing slash
        https://bugs.webkit.org/show_bug.cgi?id=50197

        config.webkit_base_dir() should return a path without a trailing slash,
        like all the other methods that return paths.

        Undoes MockFileSytem changes by r72640, since they're no longer
        necessary for GetBaselinesTest to pass.

        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 30 Nov 2010 19:23:38 +0000 (19:23 +0000)]
2010-11-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Rebaseline server: baseline display tweaks
        https://bugs.webkit.org/show_bug.cgi?id=50207

        Determine which baselines were used when running the tests and higlight
        them in the UI. Sort platform names alphabetically.

        Also makes the server URL be launched in the user's browser
        automatically.

        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
        * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 30 Nov 2010 19:16:56 +0000 (19:16 +0000)]
2010-11-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement "Revert to this revision" in resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=50107

        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::setStyleSheetText2):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::reparseStyleSheet):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleModel.prototype._onRevert):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get contentTimestamp):
        (WebInspector.Resource.prototype.setInitialContent):
        (WebInspector.Resource.prototype.isLocallyModified):
        (WebInspector.Resource.prototype.setContent.else.finished):
        (WebInspector.Resource.prototype.setContent):
        (WebInspector.Resource.prototype.revertToThis.callback):
        (WebInspector.Resource.prototype.revertToThis):
        (WebInspector.Resource.prototype.get baseRevision):
        (WebInspector.Resource.prototype._innerRequestContent):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._showResourceView):
        (WebInspector.FrameResourceTreeElement.prototype._contentChanged):
        (WebInspector.ResourceRevisionTreeElement):
        (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
        (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.editScriptSource.mycallback):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._editLine):
        (WebInspector.SourceView.prototype._editLineComplete):
        (WebInspector.SourceView.prototype._revertEditLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Injected bundle support for <rdar://problem/8710645> WebKitTestRunner needs...
mitz@apple.com [Tue, 30 Nov 2010 19:14:56 +0000 (19:14 +0000)]
WebKit2: Injected bundle support for <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* Shared/API/c/WKFindOptions.h: Added. Moved the definition of WKFindOptions here from WKPage.h.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFindOptions): Moved from WKAPICast.h.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPage.h:
* WebKit2.xcodeproj/project.pbxproj: Added WKFindOptions.h.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageFindString): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findStringFromInjectedBundle): Added.
* WebProcess/WebPage/WebPage.h:

WebKitTools: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::findString): Added.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests: <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
https://bugs.webkit.org/show_bug.cgi?id=50238

Reviewed by Anders Carlsson.

* platform/mac-wk2/Skipped: Removed editing/text-iterator/findString.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClean up WebCore.vcproj's bindings filter
aroben@apple.com [Tue, 30 Nov 2010 19:02:32 +0000 (19:02 +0000)]
Clean up WebCore.vcproj's bindings filter

I added files that we compile (via an all-in-one file) but weren't in
the .vcproj, removed files that no longer exist, and added the scripts
we use.

Fixes <http://webkit.org/b/50248> WebCore.vcproj's bindings filter is
out-of-date

Reviewed by Darin Adler.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove JSIDB* files to the DerivedSources filter
aroben@apple.com [Tue, 30 Nov 2010 18:35:32 +0000 (18:35 +0000)]
Move JSIDB* files to the DerivedSources filter

This correctly reflects their location on disk. (They were formerly
listed under bindings/js.)

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 30 Nov 2010 18:31:16 +0000 (18:31 +0000)]
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Remove clampNegativeToZero in adjustScrollPositionWithinRange.
        https://bugs.webkit.org/show_bug.cgi?id=50203

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::adjustScrollPositionWithinRange):
2010-11-30  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Unskip fast/dom/horizontal-scrollbar-in-rtl.html and fast/dom/horizontal-scrollbar-when-dir-change.html in Chromium and Win7.
        Rebaseline after r72852.
        https://bugs.webkit.org/show_bug.cgi?id=50203

        * platform/chromium/test_expectations.txt:
        * platform/win/Skipped:
        * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
        * platform/win/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix timing-out tests on WebKit2 by skipping an earlier test
aroben@apple.com [Tue, 30 Nov 2010 18:20:53 +0000 (18:20 +0000)]
Try to fix timing-out tests on WebKit2 by skipping an earlier test

I'll file a bug if this fixes the problem.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove duplicate files from WebCore.vcproj
aroben@apple.com [Tue, 30 Nov 2010 18:20:47 +0000 (18:20 +0000)]
Remove duplicate files from WebCore.vcproj

Rubber-stamped by Steve Falkenburg.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLet VS do its thang with WebCore.vcproj
aroben@apple.com [Tue, 30 Nov 2010 18:20:12 +0000 (18:20 +0000)]
Let VS do its thang with WebCore.vcproj

I just removed and readded AnimationBase.cpp.

Rubber-stamped by Steve Falkenburg.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 18:17:19 +0000 (18:17 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        * fast/forms/select-option-accesskey-crash-expected.txt: Added.
        * fast/forms/select-option-accesskey-crash.html: Added
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        Don't call listBoxOnChange for elements using menu lists.

        Test: fast/forms/select-option-accesskey-crash.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check
        to decide whether to call menuListOnChange() or listBoxOnChange()
        instead of always calling listBoxOnChange().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 30 Nov 2010 18:13:59 +0000 (18:13 +0000)]
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument.
        https://bugs.webkit.org/show_bug.cgi?id=48516

        No new tests, this is refactoring only.

        fillPath() -> fillPath(const Path&)
        strokePath() -> strokePath(const Path&)
        clipPath(WindRule) -> clipPath(const Path&, WindRule)

        drawPath() was only used by CG, so made it PLATFORM(CG) specific.

        The Qt, CG and Cairo implementations are best-effort.
        For the rest, I've put beginPath/addPath and FIXMEs in the three affected methods.

        * WebCore.exp.in:
        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        * inspector/InspectorController.cpp:
        (WebCore::drawOutlinedQuad):
        * mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::paint):
        * mathml/RenderMathMLSquareRoot.cpp:
        (WebCore::RenderMathMLSquareRoot::paint):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::addConvexPolygonToPath):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::clipConvexPolygon):
        (WebCore::GraphicsContext::drawPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillPath):
        * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::GraphicsContext::translate):
        (WebCore::GraphicsContext::rotate):
        (WebCore::GraphicsContext::scale):
        (WebCore::GraphicsContext::concatCTM):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::clipPath):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::clipPath):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderSVGResource.h:
        (WebCore::RenderSVGResource::postApplyResource):
        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::pathOnlyClipping):
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceGradient.h:
        * rendering/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::postApplyResource):
        * rendering/RenderSVGResourcePattern.h:
        * rendering/RenderSVGResourceSolidColor.cpp:
        (WebCore::RenderSVGResourceSolidColor::postApplyResource):
        * rendering/RenderSVGResourceSolidColor.h:
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::finishRenderSVGContent):
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::fillAndStrokePath):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::releasePaintingResource):
        (WebCore::SVGInlineTextBox::restoreGraphicsContextAfterTextPainting):
        (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
        * rendering/svg/SVGInlineTextBox.h:
        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):
2010-11-30  Andreas Kling  <kling@webkit.org>

        Reviewed by Dirk Schulze.

        GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument
        https://bugs.webkit.org/show_bug.cgi?id=48516

        * UIProcess/FindIndicator.cpp:
        (WebKit::FindIndicator::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 30 Nov 2010 18:00:50 +0000 (18:00 +0000)]
2010-11-30  Satish Sampath  <satish@chromium.org>

        Unreviewed, updating a speech input pixel test expectations with new baselines.

        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
        * platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler and Geoff Garen.
ap@apple.com [Tue, 30 Nov 2010 17:54:26 +0000 (17:54 +0000)]
    Reviewed by Darin Adler and Geoff Garen.

        https://bugs.webkit.org/show_bug.cgi?id=44152
        <rdar://problem/8324423> CSSOM should match DOM in discarding wrapper-less parents.

        We have existing behaviors where parent objects in detached subtrees are not preserved:
        - if a root of a node tree doesn't have a wrapper, it's immediately destroyed, making
        its children parentNode attribute null;
        - relationship between a <style> or <link> node and its stylesheet is immediately broken
        when the node is removed from document (in this case, regardless of wrapper existence).

        Both match Firefox. For consistency, CSSOM should do the same. In fact, it already partially
        does - CSSRule.parentRule gets zeroed out when the parent rule is destroyed.

        Tests: fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html
               fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html

        * css/StyleSheet.cpp: (WebCore::StyleSheet::~StyleSheet): Clear out child rule parent.

        * svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::insertedIntoDocument): Keep
        the new assertion from firing. This function was adding a rule to style sheet, without
        telling the rule about it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 30 Nov 2010 17:53:14 +0000 (17:53 +0000)]
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * WebKit.vcproj/InterfacesCommon.vsprops:
        * WebKit.vcproj/InterfacesPostBuild.cmd: Added.
        * WebKit.vcproj/InterfacesPreBuild.cmd: Added.
        * WebKit.vcproj/WebKitGUIDCommon.vsprops:
        * WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
        * WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
        * WebKit.vcproj/WebKitLibCommon.vsprops:
        * WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
        * WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * WebCore.vcproj/QTMovieWinCommon.vsprops:
        * WebCore.vcproj/QTMovieWinPostBuild.cmd: Added.
        * WebCore.vcproj/QTMovieWinPreBuild.cmd: Added.
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCorePostBuild.cmd: Added.
        * WebCore.vcproj/WebCorePreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
        * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
        * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
        * DumpRenderTree/win/ImageDiffCommon.vsprops:
        * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
        * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
        * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
        * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
        * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
        * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
        * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
        * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
        * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
        * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
        * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
        * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
        * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
        * WinLauncher/WinLauncherCommon.vsprops:
        * WinLauncher/WinLauncherPostBuild.cmd: Added.
        * WinLauncher/WinLauncherPreBuild.cmd: Added.
2010-11-30  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        All projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50213

        * win/WebKit2Common.vsprops:
        * win/WebKit2WebProcessCommon.vsprops:
        * win/WebKit2WebProcessPostBuild.cmd: Added.
        * win/WebKit2WebProcessPreBuild.cmd: Added.
        * win/WebKitPostBuild.cmd: Added.
        * win/WebKitPreBuild.cmd: Added.
        * win/WebKitPreLink.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 17:48:01 +0000 (17:48 +0000)]
2010-11-30  Ojan Vafai  <ojan@chromium.org>

        [chromium] Rebaselines. Details below.

        * platform/chromium-linux/fast/overflow/overflow-update-transform-expected.checksum: Added.
        * platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png: Added.
        Just scrollbar pixel differences.

        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
        * platform/chromium-linux/svg/carto.net/selectionlist-expected.checksum:
        * platform/chromium-linux/svg/carto.net/selectionlist-expected.png:
        * platform/chromium-linux/svg/custom/image-small-width-height-expected.checksum:
        * platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
        https://bugs.webkit.org/show_bug.cgi?id=50206

        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum:
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.txt: Added.
        Completes http://trac.webkit.org/changeset/72875/

        * platform/chromium-win/fast/overflow/overflow-update-transform-expected.checksum: Added.
        * platform/chromium-win/fast/overflow/overflow-update-transform-expected.png: Added.
        Just scrollbar pixel differences.

        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
        * platform/chromium-win/svg/carto.net/selectionlist-expected.checksum:
        * platform/chromium-win/svg/carto.net/selectionlist-expected.png:
        * platform/chromium-win/svg/custom/image-small-width-height-expected.checksum:
        * platform/chromium-win/svg/custom/image-small-width-height-expected.png:
        https://bugs.webkit.org/show_bug.cgi?id=50206

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Tue, 30 Nov 2010 17:18:18 +0000 (17:18 +0000)]
2010-11-30  Vitaly Repeshko  <vitalyr@chromium.org>

        Unreviewed.

        [chromium] Updating test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Tue, 30 Nov 2010 16:58:26 +0000 (16:58 +0000)]
2010-11-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Early return if setResizesToContentsUsingLayoutSize() is called with already-set size

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setResizesToContentsUsingLayoutSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Sheriff Bot <webkit.review.bot@gmail.com>
apavlov@chromium.org [Tue, 30 Nov 2010 16:47:06 +0000 (16:47 +0000)]
2010-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72914.
        http://trac.webkit.org/changeset/72914
        https://bugs.webkit.org/show_bug.cgi?id=50241

        "pfeldman has a revision management patch both for CSS and JS"
        (Requested by apavlov on #webkit).

        * English.lproj/localizedStrings.js:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::reparseStyleSheet):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleSheet.prototype.getText):
        (WebInspector.CSSStyleSheet.prototype.setText):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
        (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 30 Nov 2010 16:29:30 +0000 (16:29 +0000)]
2010-11-30  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        New fast canvas test to ensure correct behavior of canvas with
        drawImage + shadow after scaling
        https://bugs.webkit.org/show_bug.cgi?id=50202

        The shadow offsets of the drawn images must not be affected by the
        scaling transformation.

        * fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
        * fast/canvas/canvas-scale-drawImage-shadow.html: Added.
        * fast/canvas/script-tests/canvas-scale-drawImage-shadow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 30 Nov 2010 16:26:39 +0000 (16:26 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Add WebView
        https://bugs.webkit.org/show_bug.cgi?id=50216

        * WebView.cpp: Added.
        * WebView.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-25 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 30 Nov 2010 15:33:11 +0000 (15:33 +0000)]
2010-11-25  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Fix rendering of speech button when setting the attribute dynamically.
        https://bugs.webkit.org/show_bug.cgi?id=50077

        * fast/speech/input-appearance-speechbutton.html:
2010-11-25  Satish Sampath  <satish@chromium.org>

        Reviewed by Kent Tamura.

        Fix rendering of speech button when setting the attribute dynamically.
        https://bugs.webkit.org/show_bug.cgi?id=50077

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::speechAttributeChanged):
        * rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 30 Nov 2010 15:28:53 +0000 (15:28 +0000)]
2010-11-30  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Enable switching between revisions of stylesheets
        https://bugs.webkit.org/show_bug.cgi?id=50227

        Drive-by fix: styleSheetChanged() call needed after a stylesheet reparsing on setStyleSheetText2().

        * English.lproj/localizedStrings.js:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::reparseStyleSheet):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.setStyleSheetText):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged.callback):
        (WebInspector.CSSStyleModel.prototype._styleSheetChanged):
        (WebInspector.CSSStyleSheet.prototype.getText):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourceRevisionTreeElement.prototype.onattach):
        (WebInspector.ResourceRevisionTreeElement.prototype._ondragstart):
        (WebInspector.ResourceRevisionTreeElement.prototype._handleContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix recently-added bug numbers
aroben@apple.com [Tue, 30 Nov 2010 15:25:59 +0000 (15:25 +0000)]
Fix recently-added bug numbers

* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Tue, 30 Nov 2010 15:14:29 +0000 (15:14 +0000)]
2010-11-30  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by David Levin.

        V8 binding for DOMTimeStamp should be Number, not Date
        https://bugs.webkit.org/show_bug.cgi?id=49963

        * fast/dom/domtimestamp-is-number-expected.txt: Added.
        * fast/dom/domtimestamp-is-number.html: Added.
        * fast/dom/script-tests/domtimestamp-is-number.js: Added.
        (do_check):
2010-11-30  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by David Levin.

        V8 binding for DOMTimeStamp should be Number, not Date
        https://bugs.webkit.org/show_bug.cgi?id=49963

        Test: fast/dom/domtimestamp-is-number.html

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate mac-wk2 Skipped file and add some bug numbers to other Skipped files
aroben@apple.com [Tue, 30 Nov 2010 15:06:20 +0000 (15:06 +0000)]
Update mac-wk2 Skipped file and add some bug numbers to other Skipped files

* platform/mac-wk2/Skipped: Added current failures.

* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
Added bug numbers for implementing layoutTestController.findString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Thiago Macieira <thiago.macieira@nokia.com>
andreas.kling@nokia.com [Tue, 30 Nov 2010 14:35:02 +0000 (14:35 +0000)]
2010-11-30  Thiago Macieira  <thiago.macieira@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QWebFrame::load(QNetworkRequest) should respect the CustomVerbAttribute

        For CustomOperation requests, pass the CustomVerbAttribute on to
        the WebCore::ResourceRequest.

        * Api/qwebframe.cpp:
        (QWebFrame::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Carlos Garcia Campos <cgarcia@igalia.com>
mrobinson@webkit.org [Tue, 30 Nov 2010 14:30:23 +0000 (14:30 +0000)]
2010-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Test fast/events/mouseover-mouseout2.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=50214

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_query_tooltip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 30 Nov 2010 13:54:36 +0000 (13:54 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Use preprocessor argument in GENERATE_DOM_NAMES
        https://bugs.webkit.org/show_bug.cgi?id=49886

        * cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
reni@webkit.org [Tue, 30 Nov 2010 13:40:11 +0000 (13:40 +0000)]
[Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext()
https://bugs.webkit.org/show_bug.cgi?id=49916

Reviewed by Andreas Kling.

Change the order of calling QPainter::device() and QPainter::end(), so device() will return with a valid device.
No new test is needed.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 30 Nov 2010 13:19:24 +0000 (13:19 +0000)]
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Move generator logic into WebCore CMakeLists.txt file
        https://bugs.webkit.org/show_bug.cgi?id=49885

        * cmake/WebKitMacros.cmake:
2010-11-30  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Move generator logic into main CMakeLists.txt file
        https://bugs.webkit.org/show_bug.cgi?id=49885

        Also make the generator calls more portable.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 12:34:07 +0000 (12:34 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, rolling out r72902.
        http://trac.webkit.org/changeset/72902
        https://bugs.webkit.org/show_bug.cgi?id=50062

        This change is causing layout test failures on the Tests bots
        for the mac platform.

        * accessibility/select-menulist-crash-expected.txt: Removed.
        * accessibility/select-menulist-crash.html: Removed.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, rolling out r72902.
        http://trac.webkit.org/changeset/72902
        https://bugs.webkit.org/show_bug.cgi?id=50062

        This change is causing layout test failures on the Tests bots
        for the mac platform.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::accessKeySetSelectedIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 30 Nov 2010 11:27:40 +0000 (11:27 +0000)]
2010-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72764.
        http://trac.webkit.org/changeset/72764
        https://bugs.webkit.org/show_bug.cgi?id=50215

        This change is causing assertion failures on the debug bots.
        (Requested by mrobinson on #webkit).

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name):
        (webkit_accessible_detach):
2010-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r72764.
        http://trac.webkit.org/changeset/72764
        https://bugs.webkit.org/show_bug.cgi?id=50215

        This change is causing assertion failures on the debug bots.
        (Requested by mrobinson on #webkit).

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::notifyStatus):
        * tests/testatk.c:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 30 Nov 2010 11:12:01 +0000 (11:12 +0000)]
2010-11-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make copy(node) work in console.
        https://bugs.webkit.org/show_bug.cgi?id=50180

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 30 Nov 2010 10:55:35 +0000 (10:55 +0000)]
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Darin Adler.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        * accessibility/select-menulist-crash-expected.txt: Added.
        * accessibility/select-menulist-crash.html: Added.
2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Darin Adler.

        ASSERT failing for combo boxes when selection changes
        https://bugs.webkit.org/show_bug.cgi?id=50062

        Don't call listBoxOnChange for elements using menu lists.

        Test: accessibility/select-menulist-crash.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::accessKeySetSelectedIndex): Extra check
        to decide whether to call menuListOnChange() or listBoxOnChange()
        instead of always calling listBoxOnChange().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Tue, 30 Nov 2010 10:36:18 +0000 (10:36 +0000)]
2010-11-30  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] pass webframe to web frame client's cookieJar
        https://bugs.webkit.org/show_bug.cgi?id=50148

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::cookieJar):
        * src/ChromiumBridge.cpp:
        (WebCore::getCookieJar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 30 Nov 2010 10:20:10 +0000 (10:20 +0000)]
2010-11-30  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Path stroke shadow has incorrect behavior when using ctx.scale(x,y)
        https://bugs.webkit.org/show_bug.cgi?id=50198

        New fast canvas test to ensure correct behavior of path stroke shadow
        when using scaling.

        * fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
        * fast/canvas/canvas-scale-strokePath-shadow.html: Added.
        * fast/canvas/script-tests/canvas-scale-strokePath-shadow.js: Added.
2010-11-30  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Path stroke shadow has incorrect behavior when using ctx.scale(x,y)
        https://bugs.webkit.org/show_bug.cgi?id=50198

        Handle the special case when scaling is used and translate the shadow
        offset accordingly. The correct behavior is ensured in ContextShadow
        already, the issue only happens when using a non-blur shadow.

        Test: fast/canvas/canvas-scale-strokePath-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::strokePath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 30 Nov 2010 10:11:10 +0000 (10:11 +0000)]
2010-11-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Update mac-leopard pixel baseline to pass with tolerance 0.
        Update svg/dom/SVGTransformList-basics.xhtml mac baseline, after my last SVGList commit.

        * platform/mac-leopard/svg/batik/text/smallFonts-expected.checksum:
        * platform/mac-leopard/svg/batik/text/smallFonts-expected.png:
        * platform/mac-leopard/svg/batik/text/smallFonts-expected.txt:
        * platform/mac/svg/dom/SVGTransformList-basics-expected.checksum:
        * platform/mac/svg/dom/SVGTransformList-basics-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Tue, 30 Nov 2010 10:03:25 +0000 (10:03 +0000)]
2010-11-30  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Path filling should keep shadow offset after context scaling
        https://bugs.webkit.org/show_bug.cgi?id=50194

        New fast canvas test to ensure correct behavior of path fill shadow
        when using scaling.

        * fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
        * fast/canvas/canvas-scale-fillPath-shadow.html: Added.
        * fast/canvas/script-tests/canvas-scale-fillPath-shadow.js: Added.
2010-11-30  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Path filling should keep shadow offset after context scaling
        https://bugs.webkit.org/show_bug.cgi?id=50194

        Handle the special case when scaling is used and translate the shadow
        offset accordingly. The correct behavior is ensured in ContextShadow
        already, the issue only happens when using a non-blur shadow.

        Test: fast/canvas/canvas-scale-fillPath-shadow.html

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Xan Lopez <xlopez@igalia.com>
jochen@chromium.org [Tue, 30 Nov 2010 09:58:05 +0000 (09:58 +0000)]
2010-11-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * configure.ac: bump version for 1.3.7 release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix bugs when building WebKit with Qt 4.7.1
ossy@webkit.org [Tue, 30 Nov 2010 08:56:46 +0000 (08:56 +0000)]
[Qt] Fix bugs when building WebKit with Qt 4.7.1
https://bugs.webkit.org/show_bug.cgi?id=46248

Reviewed by Andreas Kling.

Migrate to Qt 4.7.1, add failing tests to the Skipped list,
remove passing tests from Skipped list, update expected files.

* platform/qt/Skipped:
* platform/qt/css1/basic/class_as_selector-expected.txt:
* platform/qt/css1/basic/comments-expected.txt:
* platform/qt/css1/basic/containment-expected.txt:
* platform/qt/css1/basic/contextual_selectors-expected.txt:
* platform/qt/css1/basic/grouping-expected.txt:
* platform/qt/css1/basic/id_as_selector-expected.txt:
* platform/qt/css1/basic/inheritance-expected.txt:
* platform/qt/css1/box_properties/border-expected.txt:
* platform/qt/css1/box_properties/border_bottom-expected.txt:
* platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/border_bottom_width-expected.txt:
* platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_color-expected.txt:
* platform/qt/css1/box_properties/border_color_inline-expected.txt:
* platform/qt/css1/box_properties/border_inline-expected.txt:
* platform/qt/css1/box_properties/border_left-expected.txt:
* platform/qt/css1/box_properties/border_left_inline-expected.txt:
* platform/qt/css1/box_properties/border_left_width-expected.txt:
* platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_right-expected.txt:
* platform/qt/css1/box_properties/border_right_inline-expected.txt:
* platform/qt/css1/box_properties/border_right_width-expected.txt:
* platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_style-expected.txt:
* platform/qt/css1/box_properties/border_style_inline-expected.txt:
* platform/qt/css1/box_properties/border_top-expected.txt:
* platform/qt/css1/box_properties/border_top_inline-expected.txt:
* platform/qt/css1/box_properties/border_top_width-expected.txt:
* platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_width-expected.txt:
* platform/qt/css1/box_properties/border_width_inline-expected.txt:
* platform/qt/css1/box_properties/clear-expected.txt:
* platform/qt/css1/box_properties/clear_float-expected.txt:
* platform/qt/css1/box_properties/float-expected.txt:
* platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
* platform/qt/css1/box_properties/float_margin-expected.txt:
* platform/qt/css1/box_properties/height-expected.txt:
* platform/qt/css1/box_properties/margin-expected.txt:
* platform/qt/css1/box_properties/margin_bottom-expected.txt:
* platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/margin_inline-expected.txt:
* platform/qt/css1/box_properties/margin_left-expected.txt:
* platform/qt/css1/box_properties/margin_left_inline-expected.txt:
* platform/qt/css1/box_properties/margin_right-expected.txt:
* platform/qt/css1/box_properties/margin_right_inline-expected.txt:
* platform/qt/css1/box_properties/margin_top-expected.txt:
* platform/qt/css1/box_properties/margin_top_inline-expected.txt:
* platform/qt/css1/box_properties/padding-expected.txt:
* platform/qt/css1/box_properties/padding_bottom-expected.txt:
* platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/padding_inline-expected.txt:
* platform/qt/css1/box_properties/padding_left-expected.txt:
* platform/qt/css1/box_properties/padding_left_inline-expected.txt:
* platform/qt/css1/box_properties/padding_right-expected.txt:
* platform/qt/css1/box_properties/padding_right_inline-expected.txt:
* platform/qt/css1/box_properties/padding_top-expected.txt:
* platform/qt/css1/box_properties/padding_top_inline-expected.txt:
* platform/qt/css1/box_properties/width-expected.txt:
* platform/qt/css1/cascade/cascade_order-expected.txt:
* platform/qt/css1/cascade/important-expected.txt:
* platform/qt/css1/classification/display-expected.txt:
* platform/qt/css1/classification/list_style-expected.txt:
* platform/qt/css1/classification/list_style_image-expected.txt:
* platform/qt/css1/classification/list_style_position-expected.txt:
* platform/qt/css1/classification/list_style_type-expected.txt:
* platform/qt/css1/color_and_background/background-expected.txt:
* platform/qt/css1/color_and_background/background_attachment-expected.txt:
* platform/qt/css1/color_and_background/background_color-expected.txt:
* platform/qt/css1/color_and_background/background_image-expected.txt:
* platform/qt/css1/color_and_background/background_position-expected.txt:
* platform/qt/css1/color_and_background/background_repeat-expected.txt:
* platform/qt/css1/color_and_background/color-expected.txt:
* platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/qt/css1/font_properties/font-expected.txt:
* platform/qt/css1/font_properties/font_family-expected.txt:
* platform/qt/css1/font_properties/font_size-expected.txt:
* platform/qt/css1/font_properties/font_style-expected.txt:
* platform/qt/css1/font_properties/font_variant-expected.txt:
* platform/qt/css1/font_properties/font_weight-expected.txt:
* platform/qt/css1/formatting_model/canvas-expected.txt:
* platform/qt/css1/formatting_model/floating_elements-expected.txt:
* platform/qt/css1/formatting_model/height_of_lines-expected.txt:
* platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/qt/css1/formatting_model/inline_elements-expected.txt:
* platform/qt/css1/formatting_model/replaced_elements-expected.txt:
* platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
* platform/qt/css1/pseudo/anchor-expected.txt:
* platform/qt/css1/pseudo/firstletter-expected.txt:
* platform/qt/css1/pseudo/firstline-expected.txt:
* platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
* platform/qt/css1/text_properties/letter_spacing-expected.txt:
* platform/qt/css1/text_properties/line_height-expected.txt:
* platform/qt/css1/text_properties/text_align-expected.txt:
* platform/qt/css1/text_properties/text_decoration-expected.txt:
* platform/qt/css1/text_properties/text_indent-expected.txt:
* platform/qt/css1/text_properties/text_transform-expected.txt:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css1/text_properties/word_spacing-expected.txt:
* platform/qt/css1/units/color_units-expected.txt:
* platform/qt/css1/units/length_units-expected.txt:
* platform/qt/css1/units/percentage_units-expected.txt:
* platform/qt/css1/units/urls-expected.txt:
* platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
* platform/qt/editing/inserting/paragraph-separator-03-expected.txt:
* platform/qt/editing/pasteboard/5027857-expected.txt:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
* platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
* platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
* platform/qt/editing/pasteboard/paste-text-019-expected.txt:
* platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/dom/gc-10-expected.txt:
* platform/qt/fast/forms/isindex-placeholder-expected.txt:
* platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
* platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
* platform/qt/fast/lists/003-vertical-expected.txt:
* platform/qt/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/qt/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
* platform/qt/svg/custom/bug45331-expected.txt:
* platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-30 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 30 Nov 2010 08:15:28 +0000 (08:15 +0000)]
2010-11-30  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: make ScriptCallStack and ScriptArguments reference counted
        https://bugs.webkit.org/show_bug.cgi?id=50156

        No new tests. This refactoring is covered with existing inspector tests.

        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profile):
        (WebCore::JSConsole::profileEnd):
        * bindings/js/ScriptCallStackFactory.cpp:
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        * bindings/js/ScriptCallStackFactory.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::customArgsAndExceptionCallback):
        * bindings/v8/ScriptCallStackFactory.cpp:
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        * bindings/v8/ScriptCallStackFactory.h:
        * bindings/v8/V8ConsoleMessage.cpp:
        (WebCore::V8ConsoleMessage::handler):
        (WebCore::V8ConsoleMessage::dispatchNow):
        * bindings/v8/V8ConsoleMessage.h:
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        (WebCore::V8Console::traceCallback):
        (WebCore::V8Console::assertCallback):
        (WebCore::V8Console::profileCallback):
        (WebCore::V8Console::profileEndCallback):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::startGroup):
        * inspector/InspectorController.h:
        * inspector/ScriptArguments.cpp:
        (WebCore::ScriptArguments::create):
        * inspector/ScriptArguments.h:
        * inspector/ScriptCallFrame.h:
        * inspector/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::create):
        (WebCore::ScriptCallStack::at):
        (WebCore::ScriptCallStack::size):
        * inspector/ScriptCallStack.h:
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::debug):
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::dir):
        (WebCore::Console::dirxml):
        (WebCore::Console::trace):
        (WebCore::Console::assertCondition):
        (WebCore::Console::count):
        (WebCore::Console::markTimeline):
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupCollapsed):
        (WebCore::Console::warn):
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix (part 2).
sfalken@apple.com [Tue, 30 Nov 2010 07:56:55 +0000 (07:56 +0000)]
Windows build fix (part 2).
Define Visual Studio internal variables used in pre-build/pre-link/post-build commands in environment for separated cmd files.

* win/tools/vsprops/common.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix (part 1). Use correct environment variable syntax in cmd files.
sfalken@apple.com [Tue, 30 Nov 2010 07:55:33 +0000 (07:55 +0000)]
Windows build fix (part 1). Use correct environment variable syntax in cmd files.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreLink.cmd:
* JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
* JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
* JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
* JavaScriptCore.vcproj/jsc/jscPreLink.cmd:
* JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
* JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:
* JavaScriptCore.vcproj/testapi/testapiPreLink.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK DumpRenderTree build fix after r72887.
mitz@apple.com [Tue, 30 Nov 2010 07:39:40 +0000 (07:39 +0000)]
GTK DumpRenderTree build fix after r72887.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix for non-ICU platforms after r72887.
mitz@apple.com [Tue, 30 Nov 2010 07:32:37 +0000 (07:32 +0000)]
Build fix for non-ICU platforms after r72887.

* editing/TextIterator.cpp:
(WebCore::SearchBuffer::prependContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows DumpRenderTree build fix after r72887.
mitz@apple.com [Tue, 30 Nov 2010 07:30:08 +0000 (07:30 +0000)]
Windows DumpRenderTree build fix after r72887.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::findString): Added empty implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip editing/text-iterator/findString.html on platforms that do not have an implement...
mitz@apple.com [Tue, 30 Nov 2010 07:25:39 +0000 (07:25 +0000)]
Skip editing/text-iterator/findString.html on platforms that do not have an implementation of
layoutTestController.findString()

* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 30 Nov 2010 07:08:13 +0000 (07:08 +0000)]
2010-11-29  MORITA Hajime  <morrita@google.com>

        Unreviewed, updated expectations (unskip some passing tests).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: WTF support for <rdar://problem/8650085> adding word-prefix search...
mitz@apple.com [Tue, 30 Nov 2010 06:39:39 +0000 (06:39 +0000)]
JavaScriptCore: WTF support for <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

* wtf/unicode/UnicodeMacrosFromICU.h: Copied additional macros from icu/unicode/utf16.h.

WebCore: WebCore part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

Test: editing/text-iterator/findString.html

* GNUmakefile.am: Added FindOptions.h.
* WebCore.exp.in: Export the new methods that take FindOptions.
* WebCore.gypi: Added FindOptions.h.
* WebCore.pro: Added FindOptions.h and TextBoundaries.{cpp,h}.
* WebCore.vcproj/WebCore.vcproj: Added FindOptions.h.
* WebCore.xcodeproj/project.pbxproj: Added FindOptions.h and TextBoundaries.cpp.
* editing/Editor.cpp:
(WebCore::Editor::firstVisibleRange): Changed to use FindOptions.
(WebCore::Editor::lastVisibleRange): Ditto.
(WebCore::Editor::nextVisibleRange): Ditto.
(WebCore::Editor::findString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.
* editing/Editor.h: Added a version of findString() that takes FindOptions. Changed
countMatchesForText() to take FindOptions. Made nextVisibleRange() private and changed it
and firstVisibleRange() and lastVisibleRange() to take FindOptions.
* editing/FindOptions.h: Added.
* editing/TextIterator.cpp:
Augmented SearchBuffer with an optional prefix, which is not searched, but provides context
for determining word boundaries.
(WebCore::isSeparator): Added. Identifies a class of characters used to determine where
“words” are embedded in a word.
(WebCore::SearchBuffer::SearchBuffer): Changed to take FindOptions. Added initialization of
m_options, m_prefixLength and m_needsMoreContext.
(WebCore::SearchBuffer::append): Adjust m_prefixLength as part of the prefix gets pushed out
of the buffer.
(WebCore::SearchBuffer::needsMoreContext): Added.
(WebCore::SearchBuffer::prependContext): Added.
(WebCore::SearchBuffer::isWordStartMatch): Added.
(WebCore::SearchBuffer::search): Changed to account for the context prefix. When searching
only for word prefix matches, maintains enough context before a tentative match when moving
it to the beginning of the buffer. Reject matches that are not at word starts if requested.
Adjust m_prefixLength when pushing characters out of the buffer.
(WebCore::findPlainText): Changed to work with FindOptions. Feed the search buffer with context
if and as long as it requires more of it.
* editing/TextIterator.h: Added a version of findPlainText() that takes FindOptions.
* editing/visible_units.cpp: Moved {end,start}Of{First,Last}WordBoundary to TextBoundaries.cpp.
* page/Page.cpp:
(WebCore::Page::findString): Changed to work with FindOptions.
(WebCore::Page::markAllMatchesForText): Ditto.
* page/Page.h: Added FindOptions-based findString() and markAllMatchesForText().
* platform/text/TextBoundaries.cpp:
(WebCore::endOfFirstWordBoundaryContext): Moved here from visible_units.cpp.
(WebCore::startOfLastWordBoundaryContext): Ditto.
* platform/text/TextBoundaries.h:

WebKit/mac: WebKit Mac part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

* WebView/WebDocumentInternal.h: Removed -markAllMatchesForText:caseSensitive:limit: and
replaced -countMatchesForText:caseSensitive:limit:markMatches: with a WebFindOptions-based
method. Declared a WebDocumentOptionsSearching protocol with a new -findString:options:
method. Made WebHTMLView conform to the new protocol.
* WebView/WebHTMLView.mm:
(coreOptions): Added. Converts WebFindOptions to WebCore FindOptions.
(-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Changed to use
-findString:options:.
(-[WebHTMLView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
(-[WebHTMLView findString:options:]): Added. Calls through to WebCore::Editor::findString().
* WebView/WebPDFView.mm:
(-[WebPDFView countMatchesForText:options:limit:markMatches:]): Changed to use WebFindOptions.
* WebView/WebView.mm:
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Now calls through to
-countMatchesForText:options:highlight:limit:markMatches.
(-[WebView countMatchesForText:caseSensitive:highlight:limit:markMatches:]): Ditto.
(-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): Now calls through to
-findString:options:.
(incrementFrame): Changed to use WebFindOptions.
(findString): Added this helper method that performs the search using the best supported
method for the document view.
(-[WebView findString:options:]): Changed -searchFor::::: into this.
(-[WebView canMarkAllTextMatches]):
(-[WebView countMatchesForText:options:highlight:limit:markMatches:]): Updated to use
WebFindOptions.
(-[WebView unmarkAllTextMatches]): Updated for change to incrementFrame.
(-[WebView rectsForTextMatches]): Ditto.
* WebView/WebViewPrivate.h: Added WebFindOptions, -findString:options:, and WebFindOptions version
of countMatchesForText:.

WebKit2: WebKit2 part of <rdar://problem/8650085> adding word-prefix search options to the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038
Based on a patch from Darin Adler.

Reviewed by Darin Adler.

* Shared/WebFindOptions.h: Renamed FindOptions.h to this to account for WebCore’s new private
FindOptions.h. Added and reordered FindOptions and rolled FindDirection into FindOptions.
* UIProcess/API/C/WKAPICast.h: Removed toFindDirection().
(WebKit::toFindOptions): Updated for new values.
* UIProcess/API/C/WKPage.cpp:
(WKPageFindString): Removed separate WKFindDirection.
(WKPageCountStringMatches): Replaces caseInsensitive boolean with WKFindOptions.
* UIProcess/API/C/WKPage.h: Removed WKFindDirection and updated WKFindOptions.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findString): Removed separate FindDirection.
(WebKit::WebPageProxy::countStringMatches): Replaced caseInsensitive boolean with FindOptions.
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj: Updated for the header rename.
* WebProcess/WebPage/FindController.cpp:
(WebKit::core): Added. Converts WebKit2 FindOptions to WebCore FindOptions.
(WebKit::FindController::countStringMatches): Changed to use FindOptions.
(WebKit::FindController::findString): Ditto.
* WebProcess/WebPage/FindController.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findString): Ditto.
(WebKit::WebPage::countStringMatches): Ditto.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Ditto.

WebKitTools: DumpRenderTree changes for testing the text search API.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

* DumpRenderTree/LayoutTestController.cpp:
(findStringCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::findString):
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController find:]):

LayoutTests: Added text search tests, in particular testing word-prefix search.
https://bugs.webkit.org/show_bug.cgi?id=50038

Reviewed by Darin Adler.

* editing/text-iterator/findString-expected.txt: Added.
* editing/text-iterator/findString.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 06:28:22 +0000 (06:28 +0000)]
2010-11-29  Ojan Vafai  <ojan@chromium.org>

        [chromium] Fix expectations for fast/block/basic/truncation-rtl.html
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 30 Nov 2010 06:14:20 +0000 (06:14 +0000)]
2010-11-29  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        JavaScriptCore projects on Windows should use cmd files for build events
        https://bugs.webkit.org/show_bug.cgi?id=50193

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreLink.cmd: Added.
        * JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd: Added property svn:eol-style.
        * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd: Added property svn:eol-style.
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscPostBuild.cmd: Added.
        * JavaScriptCore.vcproj/jsc/jscPreBuild.cmd: Added.
        * JavaScriptCore.vcproj/jsc/jscPreLink.cmd: Added.
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd: Added.
        * JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd: Added.
        * JavaScriptCore.vcproj/testapi/testapiPreLink.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Tue, 30 Nov 2010 06:11:08 +0000 (06:11 +0000)]
2010-11-29  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        when empty, clicking "down" on outer-spin-button returns "max value"
        https://bugs.webkit.org/show_bug.cgi?id=45491

        It is required to calculate UTC/DST offsets to retrieve the current local milliseconds for
        date/time type inputs. WTF::currentTimeMS() returns a UTC time, and WTF::getLocalTime()
        returns a struct tm, not milliseconds.

        Calculating milliseconds from a struct tm is not simple since timegm() cannot be used in all
        environments. This calculation is already done in calculateUTCOffset(), and complicated.
        Duplicating this complicated calculation is unreasonable because of maintainability.
        To achieve this without duplication, we must call calculate{UTC|DST}Offset in some way.

        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * wtf/DateMath.cpp: Changed calculateUTCOffset() and calculateDSTOffset() to external functions.
        (WTF::calculateUTCOffset):
        (WTF::calculateDSTOffset):
        * wtf/DateMath.h:
2010-11-29  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        when empty, clicking "down" on outer-spin-button returns "max value"
        https://bugs.webkit.org/show_bug.cgi?id=45491

        * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Added.
        * fast/forms/input-stepup-stepdown-from-renderer.html: Added.
        * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Added.
        ():
        (setInputAttributes):
        (stepUp):
        (stepDown):
        (stepUpExplicitBounds):
        (stepDownExplicitBounds):
2010-11-29  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        when empty, clicking "down" on outer-spin-button returns "max value"
        https://bugs.webkit.org/show_bug.cgi?id=45491

        Modified stepping-up/down from renderer
        - to clamp steps,
        - to handle empty values (described below), and
        - to apply them for range type inputs.

        Stepping-up/down for empty values are handled "the empty as 0."
        For example :
        * If 0 is in-range, and matches to step value
          "down" -> -step
          "up" -> +step
          If -step or +step is out of range, new value should be 0.

        * If 0 is smaller than the minimum value
          "down" -> the minimum value
          "up" -> the minimum value

        * If 0 is larger than the maximum value
          "down" -> the maximum value
          "up" -> the maximum value

        * If 0 is in-range, but not matched to step value
          "down" -> smaler matched value nearest to 0.
            e.g. <input type=number min=-100 step=3> -> -1
          "up" -> larger matched value nearest to 0.
            e.g. <input type=number min=-100 step=3> -> 2

        As for date/datetime-local/month/time/week types, the empty is assumed as "current local date/time".
        As for datetime type, the empty is assumed as "current date/time in UTC".

        As for range input types, changed stepping from renderer to use stepUpFromRenderer().
        It was calculated with stepUp() from RangeInputType::handleKeydownEvent().

        Test: fast/forms/input-stepup-stepdown-from-renderer.html

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
        * html/BaseDateAndTimeInputType.h:
        * html/DateTimeInputType.cpp:
        (WebCore::DateTimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current UTC time
        * html/DateTimeInputType.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer): Modified it to clamp steps, support empty values and support range type inputs
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::isRangeControl):
        * html/InputType.cpp:
        (WebCore::InputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns 0
        * html/InputType.h:
        * html/MonthInputType.cpp:
        (WebCore::MonthInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local month
        * html/MonthInputType.h:
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::handleKeydownEvent): Added comments and modified it to use stepUpFromRenderer()
        * html/TimeInputType.cpp:
        (WebCore::TimeInputType::defaultValueForStepUp): Added defaultValueForStepUp() which returns the current local time
        * html/TimeInputType.h:
        * manual-tests/input-type-datetime-default-value.html: Added manual tests for default values of date/time inputs since they are "the current local/UTC time", which cannot be tested automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 05:40:39 +0000 (05:40 +0000)]
2010-11-29  Ojan Vafai  <ojan@chromium.org>

        Update listing for spatial nav tests after they were moved
        in http://trac.webkit.org/changeset/72880/.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-24 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 30 Nov 2010 05:21:27 +0000 (05:21 +0000)]
2010-11-24  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed; updating test expectations.

        * fast/filesystem/async-operations-expected.txt:
        * fast/filesystem/read-directory-expected.txt:
        * fast/filesystem/simple-persistent-expected.txt:
        * fast/filesystem/simple-temporary-expected.txt:
        * platform/chromium-linux/fast/filesystem/async-operations-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 05:14:20 +0000 (05:14 +0000)]
2010-11-29  Ojan Vafai  <ojan@chromium.org>

        [chromium] Hopefully final modification to text_expectations to green chromium bots.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-28 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Tue, 30 Nov 2010 05:09:02 +0000 (05:09 +0000)]
2010-11-28  Antonio Gomes  <agomes@rim.com>

        Reviewed by Kenneth Rohde Christiansen.

        Spatial navigation: move tests to its own feature directory
        https://bugs.webkit.org/show_bug.cgi?id=50133

        Patch basically moves all spatial navigation tests out of the fast/events folder,
        putting them all under /fast/spatial-navigation.

        Some needed changes in some tests and Skipped files were also made, but there is not
        any content changes in the tests.

        * fast/events/spatial-navigation: Moved to fast/spatial-navigation
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 05:06:18 +0000 (05:06 +0000)]
2010-11-29  Ojan Vafai  <ojan@chromium.org>

        [chromium] Rebaseline results after http://trac.webkit.org/changeset/72802/.
        The only differences are in the scrollbars.
        The original patch included the chromium-linux results in addition to the
        platform/mac results.

        * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Added.
        * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 30 Nov 2010 05:01:26 +0000 (05:01 +0000)]
2010-11-29  Ryosuke Niwa  <rniwa@webkit.org>

        More unreviewed rebaseline for r72861.

        * platform/chromium-linux/editing/selection/home-end-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 30 Nov 2010 04:53:51 +0000 (04:53 +0000)]
2010-11-29  Ojan Vafai  <ojan@chromium.org>

        [chromium] Some more expectations updates to green chromium bots.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 30 Nov 2010 04:48:40 +0000 (04:48 +0000)]
2010-11-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        A display-isolated URL can only be displayed (e.g., put in an iframe,
        hyperlinked to) by documents from that scheme.  In a sense, this is a
        generalization of some of the protections we give file URLs, but
        instead of lumping them all together into one "local" bucket, this
        patch creates a separate bucket for each scheme.

        For a while, I tried using a separate bucket for each origin.  That
        would have played nicely with what Blob URLs are trying to do, but some
        "chrome" URL pages rely on being able to display other chrome URL
        pages, even in different origins.  For example, the New Tab Page shows
        thumbnails from the "thumbnail" host.

        This patch also removes a bunch of unused code.  I've also propagated
        the "deprecated" status of deprecatedCanDisplay to
        deprecatedShouldTreatURLAsLocal because that method has no other
        callers and is really asking for uppercase/lowercase bugs.  I dream of
        someday removing these functions.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canDisplay):
        (WebCore::SecurityOrigin::deprecatedCanDisplay):
        * platform/SchemeRegistry.cpp:
        (WebCore::displayIsolatedURLSchemes):
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::deprecatedShouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        (WebCore::SchemeRegistry::registerURLSchemeAsDisplayIsolated):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsDisplayIsolated):
        * platform/SchemeRegistry.h:
2010-11-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Introduce the notion of a "display-isolated" URL scheme for use by Chrome-internal URLs
        https://bugs.webkit.org/show_bug.cgi?id=50182

        This patch adds a Chromium API for registering schemes as
        display-isolated.  In a subsequent patch, I'll change the "chrome"
        scheme in Chrome to be display isolated instead of local.  That will
        prevent file URLs from linking to chrome URLs.

        * public/WebSecurityPolicy.h:
        * src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsDisplayIsolated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72876 268f45cc-cd09-0410-ab3c-d52691b4dbfc