WebKit-https.git
7 years ago[Qt] Add Source/qtwebkitversion.h to .gitignore
commit-queue@webkit.org [Mon, 5 Dec 2011 15:53:02 +0000 (15:53 +0000)]
[Qt] Add Source/qtwebkitversion.h to .gitignore
https://bugs.webkit.org/show_bug.cgi?id=73823

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-12-05
Reviewed by Tor Arne Vestbø.

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRedeploy apple-macpro-7 and apple-xserve-1
aroben@apple.com [Mon, 5 Dec 2011 15:52:21 +0000 (15:52 +0000)]
Redeploy apple-macpro-7 and apple-xserve-1

These slaves have been sitting idle since we removed our Leopard builders in r97496.

Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
sitting idle

Reviewed by Sam Weinig.

* BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
(WebKit2 Tests)".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@102000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOut-of-band text tracks may only load from same origin as the media element's Documen...
eric.carlson@apple.com [Mon, 5 Dec 2011 15:38:11 +0000 (15:38 +0000)]
Out-of-band text tracks may only load from same origin as the media element's Document's origin
https://bugs.webkit.org/show_bug.cgi?id=73184

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/text-track-crossorigin.html

* html/HTMLTrackElement.cpp:
(WebCore::urlForLogging): Debug-only function for logging urls.
(WebCore::HTMLTrackElement::scheduleLoad): Call canLoadUrl() before passing control off to
    the Track.
(WebCore::HTMLTrackElement::canLoadUrl): Don't ask HTMLMediaElement to validate the url, the
    requirements for <track> are different from <video>.
(WebCore::HTMLTrackElement::didCompleteLoad): Change bool param to enum.
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute): New, return parent 'crossorigin'
    attribute value.
* html/HTMLTrackElement.h:

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::scheduleLoad): Add comments from the spec.
(WebCore::LoadableTextTrack::loadTimerFired): Always cancel pending loads. Let the caller know
    if the loader refuses the url immediately.
(WebCore::LoadableTextTrack::cueLoadingStarted): The <track> deals with readyState.
(WebCore::LoadableTextTrack::cueLoadingCompleted): HTMLTrackElement::didCompleteLoad takes
    an enum, not a bool.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::corsPolicyPreventedLoad): New, log the error and set m_state.
(WebCore::TextTrackLoader::notifyFinished): Check for CORS failure.
(WebCore::TextTrackLoader::load): Take media element cross-origin attribute as a param so we
    can make the correct checks.
* loader/TextTrackLoader.h:

LayoutTests:

* http/tests/security/resources/captions-with-access-control-headers.php: Added
* http/tests/security/resources/captions.vtt: Added.
* http/tests/security/text-track-crossorigin-expected.txt: Added.
* http/tests/security/text-track-crossorigin.html: Added.
* media/track/track-add-track-expected.txt: Updated results.
* media/track/track-add-track.html: readyState changes as soon as the track url is set.
* platform/efl/Skipped: Skip new test.
* platform/gtk/Skipped: Ditto.
* platform/mac/Skipped: Ditto.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
* platform/wincairo/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
rolandsteiner@chromium.org [Mon, 5 Dec 2011 15:30:38 +0000 (15:30 +0000)]
"Raw" pseudo selectors don't match if immediately after a child or descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=72933

Source/WebCore:

Remove shortcut that prevents universal selectors from being created before shadow pseudo-elements.

Reviewed by Antti Koivisto.

* css/CSSParser.cpp:
(WebCore::CSSParser::updateSpecifiersWithElementName):

LayoutTests:

Add tests cases for "raw" shadow pseudo-element selectors with various combinators.
Also add cases with explicit universal '*' selector.

Reviewed by Antti Koivisto.

* fast/css/css-selector-text-expected.txt:
* fast/css/css-selector-text.html:
* fast/css/css-set-selector-text-expected.txt:
* fast/css/css-set-selector-text.html:
* fast/css/unknown-pseudo-element-matching-expected.txt:
* fast/css/unknown-pseudo-element-matching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 15:21:18 +0000 (15:21 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-cg-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt.
* platform/chromium-mac-snowleopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Renamed from LayoutTests/platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt.
* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make the UI of the MiniBrowser slightly nicer
kenneth@webkit.org [Mon, 5 Dec 2011 14:47:46 +0000 (14:47 +0000)]
[Qt] Make the UI of the MiniBrowser slightly nicer

Rubberstamped by Simon Hausmann.

- Add proper padding
- Show feedback when pressing on the toolbar icons
- Make the text entry better looking

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r101983.
commit-queue@webkit.org [Mon, 5 Dec 2011 14:46:36 +0000 (14:46 +0000)]
Unreviewed, rolling out r101983.
http://trac.webkit.org/changeset/101983
https://bugs.webkit.org/show_bug.cgi?id=73827

It broke all tests on GTK and on Qt in debug mode (Requested
by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-05

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 14:32:31 +0000 (14:32 +0000)]
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fixed chromium DEPS syntax.
vsevik@chromium.org [Mon, 5 Dec 2011 14:16:56 +0000 (14:16 +0000)]
Unreviewed, fixed chromium DEPS syntax.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
vsevik@chromium.org [Mon, 5 Dec 2011 13:50:49 +0000 (13:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 13:44:40 +0000 (13:44 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chrmoium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 13:35:05 +0000 (13:35 +0000)]
Unreviewed chrmoium tests rebaseline.

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 12:24:19 +0000 (12:24 +0000)]
Unreviewed chromium tests expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 11:54:02 +0000 (11:54 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-cg-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/custom/svg-fonts-word-spacing-expected.png.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/custom/svg-fonts-word-spacing-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/svg-fonts-word-spacing-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<style scoped>: Add 'scoped' attribute
rolandsteiner@chromium.org [Mon, 5 Dec 2011 11:48:28 +0000 (11:48 +0000)]
<style scoped>: Add 'scoped' attribute
https://bugs.webkit.org/show_bug.cgi?id=67718

Source/WebCore:

Add 'scoped' attribute to IDL and attribute list,
implement and test setting/resetting of the attribute.

Reviewed by Antti Koivisto.

Test: fast/css/style-scoped/basic-attribute.html

* html/HTMLAttributeNames.in:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::scoped):
(WebCore::HTMLStyleElement::setScoped):
(WebCore::HTMLStyleElement::scopingElement):
* html/HTMLStyleElement.h:
* html/HTMLStyleElement.idl:

LayoutTests:

Test setting/resetting of the 'scoped' attribute in various circumstances.
Disable test directory, since STYLE_SCOPED is not enabled by default.

Reviewed by Antti Koivisto.

* fast/css/style-scoped/basic-attribute-expected.txt: Added.
* fast/css/style-scoped/basic-attribute.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium tests rebaseline.
vsevik@chromium.org [Mon, 5 Dec 2011 11:38:44 +0000 (11:38 +0000)]
Unreviewed chromium tests rebaseline.

* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert input-appearance-spinbutton-visibility.html to a reftest
tkent@chromium.org [Mon, 5 Dec 2011 11:26:23 +0000 (11:26 +0000)]
Convert input-appearance-spinbutton-visibility.html to a reftest
https://bugs.webkit.org/show_bug.cgi?id=73807

Reviewed by Hajime Morita.

* fast/forms/input-appearance-spinbutton-visibility-expected.html: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/efl/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.png: Removed.
* platform/qt/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium test expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 11:20:10 +0000 (11:20 +0000)]
Unreviewed chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Accessing Node::m_document should be minimized.
morrita@google.com [Mon, 5 Dec 2011 11:15:19 +0000 (11:15 +0000)]
[Refactoring] Accessing Node::m_document should be minimized.
https://bugs.webkit.org/show_bug.cgi?id=73800

Reviewed by Kent Tamura.

No new tests. No behavioral change.

Replaced m_document reference with the document() accessor
or temporaril variables. This is a preparation for using
m_document space to point a shadow root pointer.

* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* dom/Node.h:
(WebCore::Node::inDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Add platform specific results.
ossy@webkit.org [Mon, 5 Dec 2011 10:00:11 +0000 (10:00 +0000)]
[Qt] Unreviewed gardening. Add platform specific results.

Patch by Czene Tamás <tczene@inf.u-szeged.hu> on 2011-12-05

* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png: Added.
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt: Added.
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png: Added.
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt: Added.
* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.png: Added.
* platform/qt/svg/stroke/zero-length-arc-linecaps-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update.
vsevik@chromium.org [Mon, 5 Dec 2011 09:50:27 +0000 (09:50 +0000)]
Unreviewed chromium expectations update.

* platform/chromium-win/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium-win/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Added.
* platform/chromium/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMacroAssemblerSH4 does not implement readCallTarget
ossy@webkit.org [Mon, 5 Dec 2011 09:41:04 +0000 (09:41 +0000)]
MacroAssemblerSH4 does not implement readCallTarget
https://bugs.webkit.org/show_bug.cgi?id=73434

Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-12-05
Reviewed by Csaba Osztrogonác.

* assembler/MacroAssemblerSH4.h: Support for SH4.
(JSC::MacroAssemblerSH4::readCallTarget):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::readCallTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNRWT should handle duplicated expectations
kkristof@inf.u-szeged.hu [Mon, 5 Dec 2011 09:28:10 +0000 (09:28 +0000)]
NRWT should handle duplicated expectations
https://bugs.webkit.org/show_bug.cgi?id=69750

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAsynchronous SpellChecker should consider multiple requests.
commit-queue@webkit.org [Mon, 5 Dec 2011 08:47:33 +0000 (08:47 +0000)]
Asynchronous SpellChecker should consider multiple requests.
https://bugs.webkit.org/show_bug.cgi?id=72939

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-12-05
Reviewed by Hajime Morita.

Source/WebCore:

Now SpellChecker saves a request when it is processing the previous spellcheck request.
If there is a request having the same root editable element, the older request is replaced by newer request

Test: editing/spelling/spellcheck-queue.html

* editing/SpellChecker.cpp:
(WebCore::SpellChecker::SpellCheckRequest::SpellCheckRequest):
  A structure to have spell check request.
(WebCore::SpellChecker::SpellCheckRequest::sequence):
(WebCore::SpellChecker::SpellCheckRequest::range):
(WebCore::SpellChecker::SpellCheckRequest::text):
(WebCore::SpellChecker::SpellCheckRequest::mask):
(WebCore::SpellChecker::SpellCheckRequest::rootEditableElement):
(WebCore::SpellChecker::SpellChecker):
(WebCore::SpellChecker::createRequest):
(WebCore::SpellChecker::timerFiredToProcessQueuedRequest):
  When timer is fired, queued request is processed if any.
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::requestCheckingFor):
  When the spellchecker is processing another request, the latest request is queued.
(WebCore::SpellChecker::invokeRequest):
(WebCore::SpellChecker::enqueueRequest):
  Enqueues a request. If there is an older request whose root editable element is the same as the request,
  it will be replaced.
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:

LayoutTests:

Tests for multiple spellcheck requests.

* editing/spelling/spellcheck-queue-expected.txt: Added.
* editing/spelling/spellcheck-queue.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: WebCore part of: Add WebKit preferences for text track settings
eric.carlson@apple.com [Mon, 5 Dec 2011 08:42:27 +0000 (08:42 +0000)]
Source/WebCore: WebCore part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

No new tests yet, still nothing to test.

* page/Settings.cpp:
(WebCore::Settings::setShouldDisplaySubtitles): Move the setters to the .cpp file so they
    aren't inlined.
(WebCore::Settings::setShouldDisplayCaptions): Ditto.
(WebCore::Settings::setShouldDisplayTextDescriptions): Ditto.
* page/Settings.h:

Source/WebKit/chromium: WebKit/chromium part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::shouldDisplaySubtitles): Added.
(WebKit::WebSettingsImpl::shouldDisplayCaptions): Ditto.
(WebKit::WebSettingsImpl::shouldDisplayTextDescriptions): Ditto.
* src/WebSettingsImpl.h:

Source/WebKit/mac: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* WebView/WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize new preferences to NO.
(-[WebPreferences setShouldDisplaySubtitles:]): Added.
(-[WebPreferences shouldDisplaySubtitles]): Ditto.
(-[WebPreferences setShouldDisplayCaptions:]): Ditto.
(-[WebPreferences shouldDisplayCaptions]): Ditto.
(-[WebPreferences setShouldDisplayTextDescriptions:]): Ditto.
(-[WebPreferences shouldDisplayTextDescriptions]): Ditto.
* WebView/WebPreferencesPrivate.h:

* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Updates WebCore settings from WebKit prefs.

Source/WebKit/win: WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.

* WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.

* WebPreferences.cpp:
(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.
* WebPreferences.h: Declare new methods.

* WebView.cpp:
(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.

Source/WebKit2: WebKit2 part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721

Reviewed by John Sullivan.

* Shared/WebPreferencesStore.h: Declared shouldDisplaySubtitles, shouldDisplayCaptions, and
shouldDisplayTextDescriptions properties with macros. All default to false.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShouldDisplaySubtitles): Added.
(WKPreferencesGetShouldDisplaySubtitles): Ditto.
(WKPreferencesSetShouldDisplayCaptions): Ditto.
(WKPreferencesGetShouldDisplayCaptions): Ditto.
(WKPreferencesSetShouldDisplayTextDescriptions): Ditto.
(WKPreferencesGetShouldDisplayTextDescriptions): Ditto.
* UIProcess/API/C/WKPreferences.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Updates WebCore settings from WebKit2 prefs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
ossy@webkit.org [Mon, 5 Dec 2011 08:19:46 +0000 (08:19 +0000)]
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

* platform/qt/Skipped: Skip the failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImageDecoder setSize() should check for backing store allocation failure
noel.gordon@gmail.com [Mon, 5 Dec 2011 07:58:18 +0000 (07:58 +0000)]
ImageDecoder setSize() should check for backing store allocation failure
https://bugs.webkit.org/show_bug.cgi?id=72864

Reviewed by Adam Barth.

The backing store of a decoded image is a Vector<PixelData> on the affected
ports. And Vector<> provides a resize capacity member that returns false if
memory allocation fails.

setSize() should be called once only during an image decode - add an ASSERT
for that. Resize the backing store capacity to the requested image size and
return false if memory allocation fails.

ImageDecoder::isOverSize(width, height) is called to check that the decoded
width and height won't overflow 'width x height x sizeof(PixelData)' before
calls to setSize(). Refer to http://webkit.org/b/48634

No new tests. Covered by fast/images/size-failure.html

* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd binary support in WebSocket test server's echo handler.
commit-queue@webkit.org [Mon, 5 Dec 2011 07:42:19 +0000 (07:42 +0000)]
Add binary support in WebSocket test server's echo handler.
https://bugs.webkit.org/show_bug.cgi?id=73649

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-12-04
Reviewed by Eric Seidel.

* http/tests/websocket/tests/hybi/echo_wsh.py: Support binary frames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAfter success with Mac, Win and Gtk, turning on parallel testing
eric@webkit.org [Mon, 5 Dec 2011 06:52:20 +0000 (06:52 +0000)]
After success with Mac, Win and Gtk, turning on parallel testing
by default for all platforms (except Qt).

We'll add more platforms to the blacklist if we see problems.

Unreviewed.

* Scripts/run-webkit-tests:
(platformIsReadyForParallelTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSStyleSheet can't be reparented, enforce this at compile time.
kling@webkit.org [Mon, 5 Dec 2011 05:44:02 +0000 (05:44 +0000)]
CSSStyleSheet can't be reparented, enforce this at compile time.
<http://webkit.org/b/73793>

Reviewed by Benjamin Poulain.

* css/StyleSheet.h:
(WebCore::StyleSheet::clearOwnerRule):

    Changed setParentRule(CSSImportRule*) to clearOwnerRule() to document and
    enforce the fact that style sheets should never be reparented after creation.

(WebCore::StyleSheet::ownerRule):

    Renamed parentRule() to ownerRule() to match the CSSOM name.

(WebCore::StyleSheet::ownerNode):
(WebCore::StyleSheet::clearOwnerNode):

    Also renamed StyleSheet::m_parentNode to m_ownerNode to match its accessors.

* css/CSSStyleSheet.h:

    Removed ownerRule() as we now inherit it from StyleSheet.

* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):
* inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):

    Update call sites to use the new names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline of placeholder tests for r101742 and r101848.
tkent@chromium.org [Mon, 5 Dec 2011 05:24:38 +0000 (05:24 +0000)]
[Chromium] Rebaseline of placeholder tests for r101742 and r101848.

* platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/forms/placeholder-position-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-linux/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-linux/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-linux/fast/forms/search-styled-expected.txt:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-linux/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-mac-leopard/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-position-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/search-styled-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-pseudo-style-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.png: Added.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-1-expected.png: Removed.
* platform/chromium-mac/fast/forms/input-placeholder-visibility-3-expected.png: Removed.
* platform/chromium-mac/fast/forms/textarea-placeholder-visibility-1-expected.png: Removed.
* platform/chromium-mac/fast/forms/textarea-placeholder-visibility-2-expected.png: Removed.
* platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/chromium-win/fast/forms/placeholder-position-expected.txt:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/search-styled-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
* platform/mac-snowleopard/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoborder-width: initial and border-color: initial cannot be removed via CSSOM.
kling@webkit.org [Mon, 5 Dec 2011 02:29:33 +0000 (02:29 +0000)]
border-width: initial and border-color: initial cannot be removed via CSSOM.
<http://webkit.org/b/68551>

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/cssom-remove-shorthand-property.html

When asked to remove a shorthand property, we should toss out both the
sub-properties of that shorthand as well as the shorthand itself, should the
declaration contain it. The latter part was missing in our implementation.

* css/CSSMutableStyleDeclaration.h:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
(WebCore::CSSMutableStyleDeclaration::removeShorthandProperty):

    Changed to return true only if something was actually removed.

LayoutTests:

Add a test verifying that shorthand properties can be added/removed
via CSSOM'S CSSStyleDeclaration interface.

* fast/css/cssom-remove-shorthand-property-expected.txt: Added.
* fast/css/cssom-remove-shorthand-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Sun, 4 Dec 2011 23:09:33 +0000 (23:09 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-04

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved obsolete expected results that should have been removed when converting to...
darin@apple.com [Sun, 4 Dec 2011 22:10:08 +0000 (22:10 +0000)]
Removed obsolete expected results that should have been removed when converting to a ref test.

* platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/chromium-linux/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/chromium-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/chromium-win/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
* platform/efl/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/efl/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
* platform/gtk/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/gtk/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.png: Removed.
* platform/mac/css3/unicode-bidi-isolate-aharon-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild...
rniwa@webkit.org [Sun, 4 Dec 2011 21:52:56 +0000 (21:52 +0000)]
HIERARCHY_REQUEST_ERR check in checkAcceptChild should be optimized for newChild without children
https://bugs.webkit.org/show_bug.cgi?id=73737

Reviewed by Darin Adler.

It turned out that 50-70% of nodes inserted by DOM APIs such as insertBefore and appendChild
don't have any descendent nodes. Optimize isDescendantOf which is used by checkAcceptChild for this case.
On a test case attached on the bug, we see a 40% improvement.

Also optimize for cases where either new child or new parent but not both are in document as suggested
by Erik Arvidsson. This appears to happen about 40-70% of the time, and the symmetric difference between
the two cases is about 50% so it's worth implementing both optimizations.

Unfortunately no tests because we still have a O(n) algorithm somewhere.

* dom/Node.cpp:
(WebCore::Node::isDescendantOf):
(WebCore::Node::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
darin@apple.com [Sun, 4 Dec 2011 21:50:37 +0000 (21:50 +0000)]
* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
Oops, landed the wrong versions of these yesterday. These are the right ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd tests for RetainPtr::adoptNS/adoptCF
weinig@apple.com [Sun, 4 Dec 2011 21:25:30 +0000 (21:25 +0000)]
Add tests for RetainPtr::adoptNS/adoptCF
https://bugs.webkit.org/show_bug.cgi?id=73470

Reviewed by Adam Roben and Darin Adler.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
(TestWebKitAPI::TEST):
Test that adopting using adoptCF creates a RetainPtr with a
value whose retain count is 1.

* TestWebKitAPI/Tests/WTF/ns: Added.
* TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
(TestWebKitAPI::TEST):
Test that adopting using adoptNS creates a RetainPtr with a
value whose retain count is 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should optimize strict equality
fpizlo@apple.com [Sun, 4 Dec 2011 21:16:43 +0000 (21:16 +0000)]
DFG should optimize strict equality
https://bugs.webkit.org/show_bug.cgi?id=73764

Reviewed by Oliver Hunt.

1% speed-up on V8.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerCompare):
(JSC::DFG::SpeculativeJIT::compileDoubleCompare):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] cleanup qmltests.pro
commit-queue@webkit.org [Sun, 4 Dec 2011 20:42:05 +0000 (20:42 +0000)]
[Qt] cleanup qmltests.pro
https://bugs.webkit.org/show_bug.cgi?id=73718

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-12-04
Reviewed by Simon Hausmann.

Removed unused file WebView/tst_loadZeroSizeView.qml and reordered file list.

* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][GTK] enable-fullscreen WebSettings
philn@webkit.org [Sun, 4 Dec 2011 19:09:16 +0000 (19:09 +0000)]
[WK2][GTK] enable-fullscreen WebSettings
https://bugs.webkit.org/show_bug.cgi?id=73774

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_set_enable_fullscreen):
(webkit_settings_get_enable_fullscreen):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
mrobinson@webkit.org [Sun, 4 Dec 2011 18:46:11 +0000 (18:46 +0000)]
[GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=73748

Reviewed by Gustavo Noronha Silva.

* gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Check for the load-complete event only in the unit tests.
mario@webkit.org [Sun, 4 Dec 2011 16:58:28 +0000 (16:58 +0000)]
[Gtk] Check for the load-complete event only in the unit tests.

There is currently a known issue happening in debug builds when
reloading the webview if it was loaded before through the function
webkit_web_view_load_string, resulting in a ASSERT failing (see
bug 50331) so we can't check for the reload event here, since it
makes the test to fail. Fortunately, checking for load-complete
event is a good enough test, so this small patch is about that.

Rubber-stamped by Philippe Normand.

* tests/testatk.c:
(testWebkitAtkDocumentLoadingEvents): Don't load and then reload
to check events, just load once and check whether the
'load-complete' event has happened.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSValuePool: Inline trivial getters.
kling@webkit.org [Sun, 4 Dec 2011 16:31:16 +0000 (16:31 +0000)]
CSSValuePool: Inline trivial getters.
<http://webkit.org/b/73763>

Reviewed by Anders Carlsson.

* css/CSSValuePool.cpp:
* css/CSSValuePool.h:
(WebCore::CSSValuePool::createInheritedValue): Inlined.
(WebCore::CSSValuePool::createImplicitInitialValue): Ditto.
(WebCore::CSSValuePool::createExplicitInitialValue): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip two more tests.
philn@webkit.org [Sun, 4 Dec 2011 15:48:11 +0000 (15:48 +0000)]
Unreviewed, skip two more tests.

* platform/gtk/Skipped: Skip
platform/gtk/fonts/custom-font-missing-glyphs.html failing on
64-bit Debug.
* platform/gtk/test_expectations.txt:
fast/table/multiple-captions-display.xhtml is flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, moving flaky ref test to Skipped list.
philn@webkit.org [Sun, 4 Dec 2011 15:32:19 +0000 (15:32 +0000)]
Unreviewed, moving flaky ref test to Skipped list.

* platform/gtk/Skipped:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip two flaky tests and one SVG test timing out on GTK.
philn@webkit.org [Sun, 4 Dec 2011 13:59:27 +0000 (13:59 +0000)]
Unreviewed, skip two flaky tests and one SVG test timing out on GTK.

* platform/gtk/test_expectations.txt: Skip two fast/ tests.
* platform/gtk/Skipped: Skip svg/text/text-style-recalc-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother GTK build fix after r101922.
philn@webkit.org [Sun, 4 Dec 2011 13:10:50 +0000 (13:10 +0000)]
Another GTK build fix after r101922.

Rubber-stamped by Martin Robinson.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pathToLocalResource): Plug possible String ref leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-12-04 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 4 Dec 2011 12:42:55 +0000 (12:42 +0000)]
2011-12-04  Xan Lopez  <xlopez@igalia.com>

        Fix compiler warning in LayoutTestController

        Reviewed by Philippe Normand.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController): fix warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing methods used by fast/notifications tests to LayoutTestController
commit-queue@webkit.org [Sun, 4 Dec 2011 11:56:22 +0000 (11:56 +0000)]
Add missing methods used by fast/notifications tests to LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=63616

Patch by Alexandre Mazari <scaroo@gmail.com> on 2011-12-04
Reviewed by Martin Robinson.

Add missing simulateDesktopNotificationClick method used by
fast/notifications. Provide a default implementation for
areDesktopNotificationPermissionRequestsIgnored and
ignoreDesktopNotificationPermissionRequests.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController): call into the port implementation.
(simulateDesktopNotificationClickCallback): ditto.
(ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
(LayoutTestController::staticFunctions): declare new methods.
(LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::simulateDesktopNotificationClick): ditto.
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::simulateDesktopNotificationClick): ditto.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::simulateDesktopNotificationClick): ditto.
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::simulateDesktopNotificationClick): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix broken UTF-8 characters issue on editor command.
commit-queue@webkit.org [Sun, 4 Dec 2011 11:32:26 +0000 (11:32 +0000)]
[EFL] Fix broken UTF-8 characters issue on editor command.
https://bugs.webkit.org/show_bug.cgi?id=73516

Patch by Kangil Han <kangil.han@samsung.com> on 2011-12-04
Reviewed by Ryosuke Niwa.

The issue has been described that Korean character is broken on pasting copied text.
In my analysis, this is from lack of format change between C style UTF-8 character pointer and C++ style String reference.
Therefore, this patch will convert types to resolve the problem.

* ewk/ewk_view.cpp:
(_ewk_view_editor_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/gtk: Removing document related events from DRT
mario@webkit.org [Sun, 4 Dec 2011 09:39:28 +0000 (09:39 +0000)]
Source/WebKit/gtk: Removing document related events from DRT

[GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

New unit test to check events when reloading a document. This
replaces the former document-reload-events.html layout test.

* tests/testatk.c:
(updateLoadingEventsResult): New, updates a global variable to
allow checking later on that the right signals were emmitted.
(documentLoadingEventCallback): New, global listener for load-complete
and reload signals over the document object (the web area).
(testWebkitAtkDocumentLoadingEvents): New unit test, globally
connects to document-related signals and check they are properly
emitted when reloading the web view.
(main): Added new test.

Tools: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Stop connecting globally to document-related events.

* DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
(connectAccessibilityCallbacks): Removed connections.
(disconnectAccessibilityCallbacks): Removed disconnections.

LayoutTests: [GTK] Don't log document events in DRT
https://bugs.webkit.org/show_bug.cgi?id=73746

Reviewed by Martin Robinson.

Unskip passing test, remove other transformed into a unit test and
rebaseline expectations now we stopped logging document events.

* platform/gtk/Skipped: Removed two skipped tests.
* platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Rebaselined
* platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Ditto.
* platform/gtk/accessibility/document-reload-events-expected.txt: Removed.
* platform/gtk/accessibility/document-reload-events.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd failing expectation to css3/unicode-bidi-isolate-aharon-failing.html as it was...
rniwa@webkit.org [Sun, 4 Dec 2011 08:55:57 +0000 (08:55 +0000)]
Add failing expectation to css3/unicode-bidi-isolate-aharon-failing.html as it was split from
css3/unicode-bidi-isolate-aharon.html in r101949.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert isolate and plaintext tests to reftests
rniwa@webkit.org [Sun, 4 Dec 2011 08:28:17 +0000 (08:28 +0000)]
Convert isolate and plaintext tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=73680

Reviewed by Darin Adler.

Convert bdi-element-expected.html, unicode-bidi-isolate-aharon.html, and unicode-bidi-plaintext.html to reftests.
In addition, isolate the failing test case in unicode-bidi-plaintext.html as unicode-bidi-isolate-aharon-failing.html.

* css3/bdi-element-expected.html: Copied from LayoutTests/css3/bdi-element.html.
* css3/unicode-bidi-isolate-aharon-expected.html: Copied from LayoutTests/css3/unicode-bidi-isolate-aharon.html.
* css3/unicode-bidi-isolate-aharon-failing-expected.html: Added.
* css3/unicode-bidi-isolate-aharon-failing.html: Added.
* css3/unicode-bidi-isolate-aharon.html:
* fast/text/international/unicode-bidi-plaintext.html:
* platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Removed.
* platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/chromium-cg-mac/css3/bdi-element-expected.png: Removed.
* platform/chromium-linux/css3/bdi-element-expected.png: Removed.
* platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/chromium-mac-leopard/css3/bdi-element-expected.png: Removed.
* platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/chromium-mac/css3/bdi-element-expected.png: Removed.
* platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/chromium-win/css3/bdi-element-expected.png: Removed.
* platform/chromium-win/css3/bdi-element-expected.txt: Removed.
* platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
* platform/chromium/css3/bdi-element-expected.txt: Removed.
* platform/efl/css3/bdi-element-expected.png: Removed.
* platform/efl/css3/bdi-element-expected.txt: Removed.
* platform/efl/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/efl/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
* platform/gtk/css3/bdi-element-expected.png: Removed.
* platform/gtk/css3/bdi-element-expected.txt: Removed.
* platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/gtk/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
* platform/mac/css3/bdi-element-expected.png: Removed.
* platform/mac/css3/bdi-element-expected.txt: Removed.
* platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.
* platform/qt/css3/bdi-element-expected.png: Removed.
* platform/qt/css3/bdi-element-expected.txt: Removed.
* platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Removed.
* platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix WebPImageDecoder decoder leak.
noel.gordon@gmail.com [Sun, 4 Dec 2011 06:46:06 +0000 (06:46 +0000)]
Fix WebPImageDecoder decoder leak.
https://bugs.webkit.org/show_bug.cgi?id=73756

Reviewed by Andreas Kling.

Delete the m_decoder member in the destructor if needed with WebPIDelete.

No new tests, it's valgrind territory.

* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::~WEBPImageDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaselined /accessibility/aria-checkbox-sends-notification-expected.txt
scheib@chromium.org [Sun, 4 Dec 2011 05:49:03 +0000 (05:49 +0000)]
[Chromium] Rebaselined /accessibility/aria-checkbox-sends-notification-expected.txt

* platform/chromium-cg-mac-leopard/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt.
* platform/chromium-cg-mac-snowleopard/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.
* platform/chromium/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/chromium-win/accessibility/aria-checkbox-sends-notification-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse HashMap<OwnPtr> for ScriptSampleRecordMap
darin@apple.com [Sun, 4 Dec 2011 05:20:49 +0000 (05:20 +0000)]
Use HashMap<OwnPtr> for ScriptSampleRecordMap
https://bugs.webkit.org/show_bug.cgi?id=73758

Reviewed by Andreas Kling.

* bytecode/SamplingTool.cpp:
(JSC::SamplingTool::notifyOfScope): Added adoptPtr.
(JSC::SamplingTool::dump): Added get.
* bytecode/SamplingTool.h: Changed the value type of ScriptSampleRecordMap to be OwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse HashMap<OwnPtr> for the opaqueJSClassData map
darin@apple.com [Sun, 4 Dec 2011 05:20:08 +0000 (05:20 +0000)]
Use HashMap<OwnPtr> for the opaqueJSClassData map
https://bugs.webkit.org/show_bug.cgi?id=73759

Reviewed by Andreas Kling.

* API/JSClassRef.cpp:
(OpaqueJSClass::contextData): Update types.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Add an explicit clear of opaqueJSClassData to keep the
timing the same. If we didn't care about the order of operations, we could remove this, too.
* runtime/JSGlobalData.h: Use OwnPtr instead of raw pointer for the mapped type in the
opaqueJSClassData map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Supressing more failures via test_expectations.txt
scheib@chromium.org [Sun, 4 Dec 2011 05:11:35 +0000 (05:11 +0000)]
[Chromium] Supressing more failures via test_expectations.txt

* platform/chromium/test_expectations.txt:
editing/spelling/markers.html, new expectations fail
svg/animations/svginteger-animation-1.html, merging overlapping lines

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
kling@webkit.org [Sun, 4 Dec 2011 03:51:27 +0000 (03:51 +0000)]
CSSStyleSheet: Parent rule can only ever be @import, enforce this at compile time.
<http://webkit.org/b/73725>

Reviewed by Darin Adler.

Made StyleSheet::m_parentRule a CSSImportRule* rather than a CSSRule*
and updated getters, setters and constructors accordingly.

There is no change in behavior, this simply enforces the status quo.

* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::create):
(WebCore::CSSStyleSheet::ownerRule):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
* css/StyleSheet.h:
(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange HashMap implementation to use the pass type and peek type from traits for...
darin@apple.com [Sun, 4 Dec 2011 03:45:11 +0000 (03:45 +0000)]
Change HashMap implementation to use the pass type and peek type from traits for the mapped value
https://bugs.webkit.org/show_bug.cgi?id=72474

Reviewed by Anders Carlsson.

* wtf/HashMap.h: Added ReferenceTypeMaker struct template. Get PassInType, PassOutType,
and PeekType from the traits of the mapped value instead of hard-coding them here.
Changed inlineAdd to take a reference to the PassInType instead of the PassInType itself,
to accomodate a PassInType that can't be copied. Use the store, peek, and passOut
functions from the traits as well.

* wtf/HashTraits.h: Updated GenericHashTraits and HashTraits for OwnPtr to include
PassInType, PassOutType, PeekType, store, passOut, and peek. Before this, the file had
an earlier version that was just PassType, PeekType, pass, and peek. Also commented
the HashTraits for RefPtr to foreshadow some work we can do there.

* wtf/RefPtrHashMap.h: Same changes as HashMap.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate some layout test expected results
darin@apple.com [Sun, 4 Dec 2011 03:25:41 +0000 (03:25 +0000)]
Update some layout test expected results
https://bugs.webkit.org/show_bug.cgi?id=73755

Reviewed by Sam Weinig.

* editing/spelling/markers-expected.txt: Added. We just forgot to check this in when the
test was added, and the test is skipped on most platforms so that was not noticed.

* fast/css/getComputedStyle/computed-style-without-renderer.html: Changed this test to
share the list of properties to skip and the list of hidden properties.
* fast/css/getComputedStyle/computed-style.html: Ditt.
* fast/css/getComputedStyle/resources/property-names.js: Added. Besides the structural
change the change is that CSS_GRID_LAYOUT properties are now in the list to skip.

* platform/mac/accessibility/multiselect-list-reports-active-option-expected.txt: Added.
Shows this test is failing on Mac, even though it is passing on Chromium. That needs a bug report.

* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/textarea-placeholder-visibility-2-expected.txt:
Updated these results now that we don't use relative positioning for placeholders any more.
The original patch r101742 updated other platforms, including mac-snowleopard, but missed this one.

* platform/mac/svg/css/getComputedStyle-basic-expected.txt: Removed. The Mac platform can
share the platform-independent expected results as long as we skip the CSS_GRID_LAYOUT
properties.

* svg/css/getComputedStyle-basic.xhtml: Updated to skip the same properties that the tests
in fast/css/getComputedStyle skip.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, revert accidental change from r101932.
kling@webkit.org [Sun, 4 Dec 2011 01:22:24 +0000 (01:22 +0000)]
Unreviewed, revert accidental change from r101932.

* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/mac: <rdar://problem/10523721> Crash at WebCore::SubresourceLoader...
mitz@apple.com [Sun, 4 Dec 2011 01:01:36 +0000 (01:01 +0000)]
Source/WebKit/mac: <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
Reviewed by Darin Adler.

* WebView/WebView.mm:
(-[WebView _removeObjectForIdentifier:]): Changed the CFRelease(self) into
a WebCFAutorelease(self). This prevents re-entry into this method due to
the WebView closing and canceling all subresource loads, including the
one we have just removed.

Tools: Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources

Reviewed by Darin Adler.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved some obsolete expected result files that should have been removed in r97308...
darin@apple.com [Sat, 3 Dec 2011 23:55:10 +0000 (23:55 +0000)]
Removed some obsolete expected result files that should have been removed in r97308 and r101738.

* platform/efl/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
* platform/efl/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Revise ewk_view_fixed_layout_size_set
commit-queue@webkit.org [Sat, 3 Dec 2011 23:32:14 +0000 (23:32 +0000)]
[EFL] Revise ewk_view_fixed_layout_size_set
https://bugs.webkit.org/show_bug.cgi?id=73401

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2011-12-03
Reviewed by Eric Seidel.

Improve readability and replace forceLayout to setNeedsLayout,
since it sometimes causes double drawing.

* ewk/ewk_view.cpp:
(ewk_view_fixed_layout_size_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream 4 files into WebCore/platform/blackberry
commit-queue@webkit.org [Sat, 3 Dec 2011 23:11:14 +0000 (23:11 +0000)]
Upstream 4 files into WebCore/platform/blackberry
https://bugs.webkit.org/show_bug.cgi?id=73614

Patch by Mary Wu <mary.wu@torchmobile.com.cn> on 2011-12-03
Reviewed by Eric Seidel.

* platform/blackberry/CursorBlackBerry.cpp: Added.
(WebCore::AllCursors::AllCursors):
(WebCore::getCursor):
(WebCore::Cursor::Cursor):
(WebCore::Cursor::~Cursor):
(WebCore::Cursor::operator=):
(WebCore::aliasCursor):
(WebCore::cellCursor):
(WebCore::columnResizeCursor):
(WebCore::contextMenuCursor):
(WebCore::copyCursor):
(WebCore::crossCursor):
(WebCore::eastResizeCursor):
(WebCore::eastWestResizeCursor):
(WebCore::grabbingCursor):
(WebCore::grabCursor):
(WebCore::handCursor):
(WebCore::helpCursor):
(WebCore::iBeamCursor):
(WebCore::moveCursor):
(WebCore::noDropCursor):
(WebCore::noneCursor):
(WebCore::northEastResizeCursor):
(WebCore::northEastSouthWestResizeCursor):
(WebCore::northResizeCursor):
(WebCore::northSouthResizeCursor):
(WebCore::northWestResizeCursor):
(WebCore::northWestSouthEastResizeCursor):
(WebCore::notAllowedCursor):
(WebCore::pointerCursor):
(WebCore::progressCursor):
(WebCore::rowResizeCursor):
(WebCore::southEastResizeCursor):
(WebCore::southResizeCursor):
(WebCore::southWestResizeCursor):
(WebCore::verticalTextCursor):
(WebCore::waitCursor):
(WebCore::westResizeCursor):
(WebCore::zoomInCursor):
(WebCore::zoomOutCursor):
(WebCore::middlePanningCursor):
(WebCore::eastPanningCursor):
(WebCore::northPanningCursor):
(WebCore::northEastPanningCursor):
(WebCore::northWestPanningCursor):
(WebCore::southPanningCursor):
(WebCore::southEastPanningCursor):
(WebCore::southWestPanningCursor):
(WebCore::westPanningCursor):
* platform/blackberry/DragDataBlackBerry.cpp: Added.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsFiles):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::containsURL):
(WebCore::DragData::asFilenames):
(WebCore::DragData::asColor):
(WebCore::DragData::asPlainText):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
* platform/blackberry/DragImageBlackBerry.cpp: Added.
(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImage):
(WebCore::deleteDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::scaleDragImage):
(WebCore::dragImageSize):
* platform/blackberry/EventLoopBlackBerry.cpp: Added.
(WebCore::EventLoop::platformInit):
(WebCore::EventLoop::cycle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCache CSSInitialValue instances per-document.
kling@webkit.org [Sat, 3 Dec 2011 21:53:29 +0000 (21:53 +0000)]
Cache CSSInitialValue instances per-document.
<http://webkit.org/b/73745>

Reviewed by Oliver Hunt.

Source/WebCore:

Test: http/tests/security/cross-origin-css-primitive.html

Have CSSValuePool manage the caching of CSSInitialValue objects.

* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::createExplicit):
(WebCore::CSSInitialValue::createImplicit):
(WebCore::CSSInitialValue::CSSInitialValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createImplicitInitialValue):
(WebCore::CSSValuePool::createExplicitInitialValue):
* css/CSSValuePool.h:

LayoutTests:

Test that 'initial' and 'inherit' values are cached per-document.

* http/tests/security/cross-origin-css-primitive-expected.txt:
* http/tests/security/cross-origin-css-primitive.html:
* http/tests/security/resources/cross-origin-css-primitive-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKeep CSSInheritedValue in the CSS value pool.
kling@webkit.org [Sat, 3 Dec 2011 21:45:35 +0000 (21:45 +0000)]
Keep CSSInheritedValue in the CSS value pool.
<http://webkit.org/b/73747>

Reviewed by Antti Koivisto.

We only need one CSSInheritedValue instance per document, so cache it
in CSSValuePool and have the parser create it through there.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createInheritedValue):
* css/CSSValuePool.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Implement History API FrameLoaderClient methods
commit-queue@webkit.org [Sat, 3 Dec 2011 20:06:11 +0000 (20:06 +0000)]
[GTK] Implement History API FrameLoaderClient methods
https://bugs.webkit.org/show_bug.cgi?id=59017

Patch by Xan Lopez <xlopez@igalia.com> on 2011-12-03
Reviewed by Gustavo Noronha Silva.

Fake the load process when the new HTML5 History APIs are
used. Otherwise the UA does not have a chance of updating the URL
entry, back/forward buttons, etc.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchDidNavigateWithinPage): fake a
load process.
(WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage): call
dispatchDidNavigateWithinPage.
(WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
ditto.
(WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage): do
nothing, because push was already called, but note this in a
comment.
* WebCoreSupport/FrameLoaderClientGtk.h: add the new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename CSSPrimitiveValueCache to CSSValuePool.
kling@webkit.org [Sat, 3 Dec 2011 18:19:44 +0000 (18:19 +0000)]
Rename CSSPrimitiveValueCache to CSSValuePool.
<http://webkit.org/b/73742>

Reviewed by Antti Koivisto.

CSSPrimitiveValueCache -> CSSValuePool
Document::primitiveValueCache() -> Document::cssValuePool()

This is in preparation for sharing more than just primitive values.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImageRepeat):
(WebCore::valueForNinePieceImage):
(WebCore::zoomAdjustedPixelValue):
(WebCore::zoomAdjustedNumberValue):
(WebCore::zoomAdjustedPixelValueForLength):
(WebCore::valueForReflection):
(WebCore::getPositionOffsetValue):
(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):
(WebCore::getBorderRadiusCornerValue):
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::valueForGridTrackList):
(WebCore::getDelayValue):
(WebCore::getDurationValue):
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getFontSizeCSSValuePreferringKeyword):
(WebCore::CSSComputedStyleDeclaration::valueForShadow):
(WebCore::valueForFamily):
(WebCore::renderTextDecorationFlagsToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::fillSizeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::counterToCSSValue):
(WebCore::fontFamilyFromStyle):
(WebCore::lineHeightFromStyle):
(WebCore::fontSizeFromStyle):
(WebCore::fontStyleFromStyle):
(WebCore::fontVariantFromStyle):
(WebCore::fontWeightFromStyle):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::parseColorValue):
(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::setStyleSheet):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::parseBackgroundClip):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parsePage):
(WebCore::CSSParser::parseSizeParameter):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseBackgroundColor):
(WebCore::CSSParser::parseFillPositionX):
(WebCore::CSSParser::parseFillPositionY):
(WebCore::CSSParser::parseFillPositionComponent):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseFillSize):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationDirection):
(WebCore::CSSParser::parseAnimationFillMode):
(WebCore::CSSParser::parseAnimationIterationCount):
(WebCore::CSSParser::parseAnimationName):
(WebCore::CSSParser::parseAnimationPlayState):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseAnimationTimingFunction):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseDashboardRegions):
(WebCore::CSSParser::parseCounterContent):
(WebCore::CSSParser::parseShape):
(WebCore::CSSParser::parseWrapShape):
(WebCore::CSSParser::parseFont):
(WebCore::CSSParser::parseFontFamily):
(WebCore::CSSParser::parseFontStyle):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseFontWeight):
(WebCore::CSSParser::parseColor):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitStyle):
(WebCore::CSSParser::parseShadow):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::parseFlex):
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
(WebCore::BorderImageSliceParseContext::commitNumber):
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::BorderImageQuadParseContext::BorderImageQuadParseContext):
(WebCore::BorderImageQuadParseContext::commitNumber):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):
(WebCore::CSSParser::parseBorderImageQuad):
(WebCore::CSSParser::parseBorderRadius):
(WebCore::CSSParser::parseAspectRatio):
(WebCore::CSSParser::parseCounter):
(WebCore::parseDeprecatedGradientPoint):
(WebCore::parseDeprecatedGradientColorStop):
(WebCore::CSSParser::parseDeprecatedGradient):
(WebCore::valueFromSideKeyword):
(WebCore::parseGradientColorOrKeyword):
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parseCrossfade):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::parseRegionThread):
(WebCore::CSSParser::parseTextEmphasisStyle):
(WebCore::CSSParser::parseFontFeatureSettings):
* css/CSSParser.h:
(WebCore::CSSParser::cssValuePool):
* css/CSSValuePool.cpp: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.cpp.
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::~CSSValuePool):
(WebCore::CSSValuePool::createIdentifierValue):
(WebCore::CSSValuePool::createColorValue):
(WebCore::CSSValuePool::createValue):
* css/CSSValuePool.h: Renamed from Source/WebCore/css/CSSPrimitiveValueCache.h.
(WebCore::CSSValuePool::create):
(WebCore::CSSValuePool::createValue):
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* dom/Document.cpp:
(WebCore::Document::cssValuePool):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother GTK build fix after r101922.
philn@webkit.org [Sat, 3 Dec 2011 18:17:52 +0000 (18:17 +0000)]
Another GTK build fix after r101922.

Rubber-stamped by Martin James Robinson.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pathToLocalResource): return value needs to
be a URI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall fix for my previous patch. Do not try to delete a member
mrobinson@webkit.org [Sat, 3 Dec 2011 16:37:50 +0000 (16:37 +0000)]
Small fix for my previous patch. Do not try to delete a member
of a dictionary that does not exist.

Reviewed by Gustavo Noronha Silva.

* gtk/run-with-jhbuild:
(install_and_run_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix jhbuild installation for people who have unusual MAKE environment
mrobinson@webkit.org [Sat, 3 Dec 2011 15:55:51 +0000 (15:55 +0000)]
Fix jhbuild installation for people who have unusual MAKE environment
variables such as 'make -j4' as the jhbuild build does not handle it.

Reviewed by Gustavo Noronha Silva.

* gtk/run-with-jhbuild:
(install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the update-webkitgtk-libs script to properly trigger a jhbuild installation
mrobinson@webkit.org [Sat, 3 Dec 2011 15:39:02 +0000 (15:39 +0000)]
Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
when run for the first time.

Reviewed by Gustavo Noronha Silva.

* Scripts/update-webkitgtk-libs: Fix first run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip new failing tests on GTK.
philn@webkit.org [Sat, 3 Dec 2011 14:07:44 +0000 (14:07 +0000)]
Unreviewed, skip new failing tests on GTK.

* platform/gtk/Skipped: Skip 3 new
http/tests/security/mixedContent failing partly because of bug 73743.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK build fix after r101922.
philn@webkit.org [Sat, 3 Dec 2011 13:55:07 +0000 (13:55 +0000)]
Unreviewed, GTK build fix after r101922.

* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pathToLocalResource): Added sentinel in
g_build_filename call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGTK API tests build fix. Run the tests inside jhbuild.
philn@webkit.org [Sat, 3 Dec 2011 13:02:58 +0000 (13:02 +0000)]
GTK API tests build fix. Run the tests inside jhbuild.

Rubber-stamped by Gustavo Noronha Silva.

* Scripts/run-gtk-tests:
(TestRunner.__init__):
(TestRunner.run._error_handler):
(TestRunner):
(TestRunner.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShrink CSSValueList.
kling@webkit.org [Sat, 3 Dec 2011 12:20:26 +0000 (12:20 +0000)]
Shrink CSSValueList.
<http://webkit.org/b/73732>

Reviewed by Antti Koivisto.

Packed CSSValueList::m_isSpaceSeparated into the CSSValue bit field
and renamed it to m_isSpaceSeparatedValue, shrinking CSSValueList
by one CPU word.

Also renamed CSSValue::m_isImplicit to m_isImplicitInitialValue
for good measure.

* css/CSSInitialValue.h:
(WebCore::CSSInitialValue::CSSInitialValue):
* css/CSSValue.h:
(WebCore::CSSValue::isImplicitInitialValue):
(WebCore::CSSValue::CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCssText):
* css/CSSValueList.h:
(WebCore::CSSValueList::isSpaceSeparated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall build fix. Properly specify the path to the locally installed jhbuild.
mrobinson@webkit.org [Sat, 3 Dec 2011 12:12:07 +0000 (12:12 +0000)]
Small build fix. Properly specify the path to the locally installed jhbuild.

* Scripts/update-webkitgtk-libs: Fix jhbuild path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalReso...
commit-queue@webkit.org [Sat, 3 Dec 2011 11:33:05 +0000 (11:33 +0000)]
[GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=67256

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-12-03
Reviewed by Philippe Normand.

Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
which points to the more generic top-level path of the WebKit checkout. This code is
duplicated between WK1 and WK2 harnesses because we do not currently have a way to
share code here.

If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
location. This will cause the fallback to fail if you build into a non-typical location
or even fake it with a symlink. In this case it's important to use the environment variable.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath): Added.
(initializeFonts): Use the new helper to get the font path.
* DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::pathToLocalResource):Use the new helper to normalize
test paths.
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server):Pass the top-level path of the
checkout instead of passing the font path.
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getTopLevelPath): Added this helper.
(WTR::inititializeFontConfigSetting): Use the helper to find the font path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK rebaseline after r101858.
philn@webkit.org [Sat, 3 Dec 2011 11:06:21 +0000 (11:06 +0000)]
Unreviewed, GTK rebaseline after r101858.

* platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
philn@webkit.org [Sat, 3 Dec 2011 10:26:48 +0000 (10:26 +0000)]
[GStreamer] Fullscreen controller support for the new WebKit Fullscreen API
https://bugs.webkit.org/show_bug.cgi?id=66968

Reviewed by Martin Robinson.

Source/WebCore:

* GNUmakefile.am: Don't use the Quicktime fullscreen CSS anymore,
it wasn't suited for GTK in the first place anyway.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::extraFullScreenStyleSheet): Simply reuse
GTK CSS.

Source/WebKit/gtk:

If the element being fullscreened is a video use the native
fullscreen controls.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

LayoutTests:

* platform/gtk/Skipped: Skip
fullscreen/video-controls-override.html now failing because of bug 73583.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-12-03 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 3 Dec 2011 09:44:59 +0000 (09:44 +0000)]
2011-12-03  Alejandro G. Castro  <alex@igalia.com>

        [GTK] TextureMapperNode should not use Qt types and functions
        https://bugs.webkit.org/show_bug.cgi?id=73713

        Replace qreal with double and qMin with min.

        Reviewed by Noam Rosenthal.

        * platform/graphics/texmap/TextureMapperNode.cpp:
        (WebCore::solveCubicBezierFunction):
        (WebCore::solveStepsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed weekend gardening.
ossy@webkit.org [Sat, 3 Dec 2011 09:36:54 +0000 (09:36 +0000)]
[Qt] Unreviewed weekend gardening.

* platform/qt/Skipped: Skip new failing tests.
* platform/qt/fast/css/font-face-opentype-expected.png: Updated.
* platform/qt/fast/css/font-face-opentype-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: [GTK] Update required libsoup version
mrobinson@webkit.org [Sat, 3 Dec 2011 09:22:54 +0000 (09:22 +0000)]
.: [GTK] Update required libsoup version
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

* configure.ac: require libsoup 2.37.2.1 for SoupRequestHTTP API
changes

Source/WebCore: [GTK] Remove lots of code that is now unnecessary after
SoupRequestHTTP API changes.
https://bugs.webkit.org/show_bug.cgi?id=71611

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

No new tests; behavior is unchanged

* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): remove
no-longer-needed fields.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::finishedCallback): remove this, and m_finished, which
we no longer need to explicitly track
(WebCore::statusWillBeHandledBySoup):
(WebCore::soupErrorShouldCauseLoadFailure): No longer needed;
SoupRequestHTTP's logic is now aligned with WebKit's.
(WebCore::gotChunkCallback): remove gotChunkCallback, which
is no longer needed
(WebCore::startHTTPRequest):
(WebCore::sendRequestCallback):
(WebCore::gotHeadersCallback):
(WebCore::contentSniffedCallback): merge the code from
gotHeadersCallback and contentSniffedCallback into
sendRequestCallback
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage): move the
sniffing override logic here

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [EFL] Update some cookie-related tests
mrobinson@webkit.org [Sat, 3 Dec 2011 09:19:29 +0000 (09:19 +0000)]
[GTK] [EFL] Update some cookie-related tests
https://bugs.webkit.org/show_bug.cgi?id=73673

Patch by Dan Winship <danw@gnome.org> on 2011-12-03
Reviewed by Martin Robinson.

* platform/efl/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:
* platform/gtk/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt:
Copied from platform/chromium because libsoup also follows the RFC
6265 behavior.

* platform/efl/Skipped:
* platform/gtk/Skipped: Unskip that, and another cookie test that
has been fixed for a while.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r101904.
ossy@webkit.org [Sat, 3 Dec 2011 09:06:15 +0000 (09:06 +0000)]
Unreviewed, rolling out r101904.
http://trac.webkit.org/changeset/101904
https://bugs.webkit.org/show_bug.cgi?id=73739

It broke zillions of tests on all bot (Requested by
Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-03

Source/WebCore:

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):

LayoutTests:

* fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGen...
haraken@chromium.org [Sat, 3 Dec 2011 07:22:10 +0000 (07:22 +0000)]
[Refactoring] Use join(", ", @arguments) to build a method argument string in CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=73651

Reviewed by Darin Adler.

The code in CodeGenerator*.pm to build a method argument string is really dirty
and error-prone. It is building an argument string incrementally judging whether
", " is necessary or not, like this:

    my $method = ... ? "func(" : "func(a";
    if (...) {
        $method .= $method =~ /\($/ ? "b" : ", b";
    }
    $method .= ")";

Alternatively, we can refactor the code as follows:

    my $funcName = "func";
    my @arguments;
    push(@arguments, "a") if (...);
    push(@arguments, "b") if (...);
    my $method = $funcName . "(" . join(", ", @arguments) . ")";

This patch just refactors the code, and generated .h and .cpp files should be
exactly the same as the current .h and .cpp files.

Tests: bindings/scripts/test/*

* bindings/scripts/CodeGenerator.pm:
(GetterExpression):
(SetterExpression):
* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
():
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename WTF class from TemporarilyChange to TemporaryChange.
levin@chromium.org [Sat, 3 Dec 2011 07:06:54 +0000 (07:06 +0000)]
Rename WTF class from TemporarilyChange to TemporaryChange.
https://bugs.webkit.org/show_bug.cgi?id=73479

Reviewed by Eric Seidel.

Source/JavaScriptCore:

* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/TemporaryChange.h: Renamed from Source/JavaScriptCore/wtf/TemporarilyChange.h.
(WTF::TemporaryChange::TemporaryChange):
(WTF::TemporaryChange::~TemporaryChange):

Source/JavaScriptGlue:

* ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
* ForwardingHeaders/wtf/TemporaryChange.h: Added.

Source/WebCore:

* ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
* ForwardingHeaders/wtf/TemporaryChange.h: Added.
* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::autoSizeIfEnabled):

Source/WebKit/mac:

* ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
* ForwardingHeaders/wtf/TemporaryChange.h: Added.

Tools:

* DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
* DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r101906.
scheib@chromium.org [Sat, 3 Dec 2011 06:56:09 +0000 (06:56 +0000)]
Unreviewed, rolling out r101906.
http://trac.webkit.org/changeset/101906
https://bugs.webkit.org/show_bug.cgi?id=73736

Failing chromium webkit_unit_tests (Requested by scheib on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-12-02

* WebKit.gypi:
* tests/DispatchEventTest.cpp: Removed.
* tests/data/event_target.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT fails in updateState ACTION_DRAW case
commit-queue@webkit.org [Sat, 3 Dec 2011 06:47:35 +0000 (06:47 +0000)]
ASSERT fails in updateState ACTION_DRAW case
https://bugs.webkit.org/show_bug.cgi?id=73351

Patch by Armand Navabi <armand.navabi@gmail.com> on 2011-12-02
Reviewed by James Robinson.

Changed ASSERT in CCSchedulerStateMachine to include ( || !m_visible) as discussed in bug
report. m_commitState is set to COMMIT_STATE_WAITING_FOR_FIRST_DRAW if m_needsCommit or
!m_visible, so in ACTION_DRAW the assert should have both conditions.

* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::updateState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r99754): All layout tests crash on Windows
mhahnenberg@apple.com [Sat, 3 Dec 2011 06:31:50 +0000 (06:31 +0000)]
REGRESSION (r99754): All layout tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=72305

Reviewed by Geoffrey Garen.

Fixes a crash in release builds on Windows.  Windows was optimizing the out-of-line virtual destructor in
JSFunction away, which left it with no virtual functions.  Its vtable ptr was then identical to that of
a different class, therefore the optimization in the visitChildren helper function in MarkedStack.cpp was calling an
incorrect version of visitChildren on the object, which left its children unmarked, causing them to be
collected when they were still reachable.

* runtime/JSFunction.cpp:
(JSC::JSFunction::vtableAnchor): Add a virtual function to JSFunction that Visual Studio can't optimize away.
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs): Add checks to make sure that all virtual pointers that we rely on for optimization
purposes are distinct from one another.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove a stale comment in flexbox code
tony@chromium.org [Sat, 3 Dec 2011 06:21:48 +0000 (06:21 +0000)]
remove a stale comment in flexbox code
https://bugs.webkit.org/show_bug.cgi?id=73720

Reviewed by Ojan Vafai.

This was fixed by Ojan in https://bugs.webkit.org/show_bug.cgi?id=70754.

* css3/flexbox/flex-flow-padding.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Scissor rect optimization for chromium compositor
commit-queue@webkit.org [Sat, 3 Dec 2011 06:14:08 +0000 (06:14 +0000)]
[chromium] Scissor rect optimization for chromium compositor
https://bugs.webkit.org/show_bug.cgi?id=67341

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-12-02
Reviewed by James Robinson.

Mostly covered by damage tracker tests. Currently this relies on
manually running layout tests, because this patch requires partial
swaps that are not supported by DumpRenderTree. The feature
automatically disables if partial swap is not supported.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::trackDamageForAllSurfaces):
(WebCore::LayerRendererChromium::drawLayersOntoRenderSurfaces):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::draw):
* platform/graphics/chromium/cc/CCRenderSurface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] reftest asserts intermittently on the Qt-WK2 bot
tony@chromium.org [Sat, 3 Dec 2011 06:06:56 +0000 (06:06 +0000)]
[NRWT] reftest asserts intermittently on the Qt-WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=73453

Reviewed by Ryosuke Niwa.

We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
The verbose output will include the failure reason.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
* Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
(determine_result_type):
(FailureReftestNoImagesGenerated.__init__):
(FailureReftestNoImagesGenerated):
(FailureReftestNoImagesGenerated.message):
* Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_unexpected_failures):
(EndToEndTest.test_end_to_end):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a unit test for creating, listening for, and dispatching events
commit-queue@webkit.org [Sat, 3 Dec 2011 05:56:31 +0000 (05:56 +0000)]
Add a unit test for creating, listening for, and dispatching events
via the chromium API.
https://bugs.webkit.org/show_bug.cgi?id=72988

Patch by Dave Michael <dmichael@chromium.org> on 2011-12-02
Reviewed by Darin Fisher.

* WebKit.gypi:
* tests/DispatchEventTest.cpp: Added.
(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't call FocusController:setActive() in
japhet@chromium.org [Sat, 3 Dec 2011 05:51:02 +0000 (05:51 +0000)]
Don't call FocusController:setActive() in
WebViewImpl::setFocus(), since being active and
being focused are different concepts and chromium
now properly sends setActive IPCs on all platforms.
https://bugs.webkit.org/show_bug.cgi?id=73687

Reviewed by Eric Seidel.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
* tests/WebViewTest.cpp: Test how different combinations of
    setIsActive() and setFocus() affect whether the document
    has focus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=73691
dslomov@google.com [Sat, 3 Dec 2011 05:40:46 +0000 (05:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=73691
[JSC] Implement correct order of window.postMessage arguments.

Reviewed by Geoffrey Garen.

Source/WebCore:

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):

LayoutTests:

* fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r91125): Polyline tool in google docs is broken
commit-queue@webkit.org [Sat, 3 Dec 2011 05:34:42 +0000 (05:34 +0000)]
REGRESSION (r91125): Polyline tool in google docs is broken
https://bugs.webkit.org/show_bug.cgi?id=65796

Source/WebCore:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Tests: svg/custom/path-moveto-only-rendering.svg
       svg/custom/subpaths-moveto-only-rendering.svg

* platform/graphics/cg/PathCG.cpp:
(WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to
test for isEmpty accoridng ot the same rules as other platforms.
(WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result
(WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method
(WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a
path contains only move-to elements, and hence should have null bounds.
(WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result
(WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method.
(WebCore::Path::boundingRect): Modified to check for move-to only paths
(WebCore::Path::fastBoundingRect): Modified to check for move-to only paths
(WebCore::Path::isEmpty): Now uses the method that matches other platforms.
(WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly
(WebCore::Path::transform) : Now uses CGPathIsEmpty directly

LayoutTests:

Work around a bug in CoreGraphics, that caused incorrect bounds for paths
consisting only of move-to elements. This causes problems in SVG, when the enormous
bounds prevented the drawing of things behind.

Will revert expectation file when expectations are stable.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-12-02
Reviewed by Darin Adler.

* platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
* platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed.
* platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added.
* platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added.
* platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added.
* svg/custom/path-moveto-only-rendering.svg: Added.
* svg/custom/subpaths-moveto-only-rendering.svg: Added.
* svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output
* platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] [WK2] MiniBrowser --touch asserts in debug build
commit-queue@webkit.org [Sat, 3 Dec 2011 05:26:52 +0000 (05:26 +0000)]
[Qt] [WK2] MiniBrowser --touch asserts in debug build
https://bugs.webkit.org/show_bug.cgi?id=73697

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-12-02
Reviewed by Eric Seidel.

Add missing guard to QtViewportInteractionEngine::itemSizeChanged().

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::itemSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@101902 268f45cc-cd09-0410-ab3c-d52691b4dbfc