WebKit-https.git
13 years ago2007-01-03 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 4 Jan 2007 06:36:52 +0000 (06:36 +0000)]
2007-01-03  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Mark Rowe.

        - more updated results for http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        * css1/box_properties/acid_test-expected.checksum:
        * css1/box_properties/acid_test-expected.png:
        * css1/box_properties/acid_test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:28:35 +0000 (05:28 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
        * css2.1/t09-c5526c-display-00-e-expected.checksum:
        * css2.1/t09-c5526c-display-00-e-expected.png:
        * css2.1/t09-c5526c-display-00-e-expected.txt:
        * fast/block/basic/011-expected.checksum:
        * fast/block/basic/011-expected.png:
        * fast/block/basic/011-expected.txt:
        * fast/css/percentage-non-integer-expected.checksum: Added.
        * fast/css/percentage-non-integer-expected.png: Added.
        * fast/css/percentage-non-integer-expected.txt: Added.
        * fast/css/percentage-non-integer.html: Added.
        * tables/mozilla/bugs/bug4385-expected.checksum:
        * tables/mozilla/bugs/bug4385-expected.png:
        * tables/mozilla/bugs/bug4385-expected.txt:
        * tables/mozilla_expected_failures/core/col_span2-expected.checksum:
        * tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        Test: fast/css/percentage-non-integer.html

        Added floating point constructor and accessors to Length for use with
        Percent lengths only. The raw value of a percent length is the integer
        part of a constant multiple of the original double value. The constant
        is percentScaleFactor, which is currently 128.

        Added assertions that the correct constructors and accessors are used
        depending on the type: the double-based percent(), setValue() and Length()
        for the Percent type, and the integer-based value(), setValue() and Length()
        for all other types.

        calcValue() and calcMinValue() work the same as before, regardless of the
        type.

        Added helpers for testing if the value is 0, positive, negative or undefined
        without having to check the type first.

        Added raw value accessors. These are useful for doing integer math and
        comparisons with scaled percent values or doing Length type-agnostic math.

        Changed the rest of the code to use the appropriate accessors and helpers.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForLength):
        (WebCore::primitiveValueFromLength):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundSize):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        * platform/StringImpl.cpp:
        (WebCore::parseLength):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::fullRecalc):
        (WebCore::AutoTableLayout::calcMinMaxWidth):
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::layout):
        (WebCore::AutoTableLayout::calcPercentages):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::layout):
        * rendering/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::value):
        (WebCore::Length::rawValue):
        (WebCore::Length::percent):
        (WebCore::Length::setValue):
        (WebCore::Length::setRawValue):
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        (WebCore::Length::isUndefined):
        (WebCore::Length::isZero):
        (WebCore::Length::isPositive):
        (WebCore::Length::isNegative):
        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::lineHeight):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        * rendering/RenderBox.cpp:
        (WebCore::cacluateBackgroundSize):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcReplacedWidth):
        (WebCore::RenderBox::calcReplacedHeight):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lineHeight):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::Marquee::direction):
        (WebCore::Marquee::start):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::lineHeight):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::layout): Added FIXMEs.
        * rendering/RenderStyle.h:
        (WebCore::LengthBox::nonZero):
        (WebCore::RenderStyle::initialLineHeight):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:23:33 +0000 (05:23 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11744
          Setting the 'content' property dynamically has no effect

        * fast/css/content-dynamic-expected.checksum: Added.
        * fast/css/content-dynamic-expected.png: Added.
        * fast/css/content-dynamic-expected.txt: Added.
        * fast/css/content-dynamic.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11744
          Setting the 'content' property dynamically has no effect

        Test: fast/css/content-dynamic.html

        * dom/Node.cpp:
        (WebCore::Node::diff): Changed to return 'Detach' if the styles' content
        data are not equivalent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:19:10 +0000 (05:19 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12082
          REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

        * fast/frames/negative-remaining-length-crash-expected.txt: Added.
        * fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12082
          REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

        Test: fast/frames/negative-remaining-length-crash.html

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength
        as zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-03 Mark Rowe <bdash@webkit.org>
bdash [Thu, 4 Jan 2007 02:17:18 +0000 (02:17 +0000)]
2007-01-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Anders.

        * Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Written by Darin over my shoulder; reviewed by me
sullivan [Thu, 4 Jan 2007 02:01:07 +0000 (02:01 +0000)]
    Written by Darin over my shoulder; reviewed by me

        - fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused

        * page/Frame.cpp:
        (WebCore::isInShadowTree):
        new helper function used by findString
        (WebCore::Frame::findString):
        when deciding whether to start from the selection, ignore selections that are in
        a shadow tree (i.e. in a form control)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe
beidson [Thu, 4 Jan 2007 01:21:28 +0000 (01:21 +0000)]
    Reviewed by Mark Rowe

        Fixes http://bugs.webkit.org/show_bug.cgi?id=12089

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * WebView/WebPDFView.mm:
sullivan [Thu, 4 Jan 2007 01:20:11 +0000 (01:20 +0000)]
    * WebView/WebPDFView.mm:
        (-[WebPDFView _openWithFinder:]):
        Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd layout test for inline generated content.
hyatt [Thu, 4 Jan 2007 01:07:46 +0000 (01:07 +0000)]
Add layout test for inline generated content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Relax the display type restriction a little bit for generated content inside
hyatt [Thu, 4 Jan 2007 01:07:33 +0000 (01:07 +0000)]
    Relax the display type restriction a little bit for generated content inside
        inlines.  We still don't allow block display types like we should (since this
        will cause a crash), but we at least handle inline-table and inline-block now.

        Reviewed by beth

        fast/css-generated-content/inline-display-types.html

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updatePseudoChildForObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 4 Jan 2007 01:05:46 +0000 (01:05 +0000)]
LayoutTests:

        Reviewed by john

        * editing/pasteboard/merge-end-blockquote-expected.txt: A
        recent change caused an acceptable change in these expected results.

WebCore:

        Reviewed by john

        <rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item

        No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to
        the highest editable root, instead of the lowest.  Use firstEditablePosition...
        to look for an editable position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixing silly mistake.
bdakin [Thu, 4 Jan 2007 00:57:38 +0000 (00:57 +0000)]
    Fixing silly mistake.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string
        function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker
sullivan [Thu, 4 Jan 2007 00:55:41 +0000 (00:55 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the
          PDF in /tmp, both group and world-readable

        * WebView/WebPDFView.mm:
        (-[WebPDFView _openWithFinder:]):
        Make the file only readable by the current user

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders
beidson [Thu, 4 Jan 2007 00:53:36 +0000 (00:53 +0000)]
    Reviewed by Anders

        http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
        I can't really think of a cleaner way to fix this then to help these SVG cases avoid
        the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
        and we find better ways to handle it...

        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the
        ASSERTing method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
darin [Thu, 4 Jan 2007 00:40:28 +0000 (00:40 +0000)]
    Reviewed by Adele.

        - removed some obsolete source files

        * CMakeLists.txt: Removed obsolete files.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.

        * platform/qt/ComboBoxQt.cpp: Removed.
        * platform/qt/LineEditQt.cpp: Removed.
        * platform/qt/ListBoxQt.cpp: Removed.
        * platform/qt/TextEditQt.cpp: Removed.
        * rendering/RenderFormElement.cpp: Removed.
        * rendering/RenderFormElement.h: Removed.
        * rendering/RenderLabel.cpp: Removed.
        * rendering/RenderLabel.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Thu, 4 Jan 2007 00:27:25 +0000 (00:27 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for bug where :after content appeared in the wrong order

        * fast/css-generated-content/after-order-expected.checksum: Added.
        * fast/css-generated-content/after-order-expected.png: Added.
        * fast/css-generated-content/after-order-expected.txt: Added.
        * fast/css-generated-content/after-order.html: Added.
        * fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

        Reviewed by Hyatt.

        - fix bug where :after content appears backwards

        Test: fast/css-generated-content/after-order.html

        * rendering/RenderBlock.cpp:
        (WebCore::isAfterContent): Added.
        (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
        * rendering/RenderInline.cpp:
        (WebCore::isAfterContent): Added.
        (WebCore::RenderInline::addChildToFlow): Use isAfterContent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Implement box-shadow parsing... getting it all into the RenderStyle.
hyatt [Thu, 4 Jan 2007 00:04:06 +0000 (00:04 +0000)]
    Implement box-shadow parsing... getting it all into the RenderStyle.

        Reviewed by beth

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::operator==):
        (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::setBoxShadow):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::boxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Wed, 3 Jan 2007 23:38:28 +0000 (23:38 +0000)]
WebCore:
        Reviewed by John.

        Call into WebKit to get localized strings for all of the context
        menu item titles.

WebKit:
        Reviewed by John.

        Make localized strings for all of the context menu item titles that
        are accessible to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin and Geoff
beidson [Wed, 3 Jan 2007 22:19:17 +0000 (22:19 +0000)]
    Reviewed by Darin and Geoff

        http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
        -Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
        -Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createHistoryItem):
        (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
        (WebCore::FrameLoader::createHistoryItemTree):
        (WebCore::FrameLoader::updateHistoryForInternalLoad):
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Wed, 3 Jan 2007 21:48:27 +0000 (21:48 +0000)]
    Reviewed by Geoff.

        Allow plugin elements to handle off events to their widgets.

        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::defaultEventHandler):
        * html/HTMLPlugInElement.h:
        * platform/Widget.h:
        (WebCore::Widget::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John Sullivan
beidson [Wed, 3 Jan 2007 20:56:26 +0000 (20:56 +0000)]
    Reviewed by John Sullivan

        In the Bookmarks View/History View, favicon may be the incorrect size

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
adele [Wed, 3 Jan 2007 19:35:46 +0000 (19:35 +0000)]
    Reviewed by Darin.

        - Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)

        * Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Wed, 3 Jan 2007 19:16:27 +0000 (19:16 +0000)]
    Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=3420
        XMLHttpRequest does not handle set-cookie headers

        * http/tests/xmlhttprequest/cookies-expected.txt: Added.
        * http/tests/xmlhttprequest/cookies.html: Added.
        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build
lars [Wed, 3 Jan 2007 12:04:40 +0000 (12:04 +0000)]
Fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Controversially reviewed by Tim H. and Maciej
beidson [Wed, 3 Jan 2007 08:31:34 +0000 (08:31 +0000)]
    Controversially reviewed by Tim H. and Maciej

        Fixes http://bugs.webkit.org/show_bug.cgi?id=12086, http://bugs.webkit.org/show_bug.cgi?id=12088,
        possibly http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others

        WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
        by the Safari app.  This bug never surfaced before because the WebBackForwardList had a retain on the
        item, preventing deallocation. Since the items are now just temporary wrappers, the list
        is no longer actually retaining them.

        This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the
        only solution for now...  =/

        We can possibly consider reverting this fix at a later date - that task is marked by
        <rdar://problem/4905705>

        * History/WebBackForwardList.mm:
        (-[WebBackForwardList backItem]):
        (-[WebBackForwardList currentItem]):
        (-[WebBackForwardList forwardItem]):
        (-[WebBackForwardList itemAtIndex:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Wed, 3 Jan 2007 04:16:35 +0000 (04:16 +0000)]
    Reviewed by Geoff.

        Remove un-used function.

        * WebCoreSupport/WebContextMenuClient.h:
        * WebCoreSupport/WebContextMenuClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson [Wed, 3 Jan 2007 03:11:18 +0000 (03:11 +0000)]
WebCore:

        Reviewed extensively and repeatedly by Darin

        <rdar://problem/4887137> - WebCore Back/Forward Cache

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * bridge/mac/WebCorePageState.h: Removed.
        * bridge/mac/WebCorePageState.mm: Removed.

        * history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList
        (WebCore::BackForwardList::BackForwardList):
        (WebCore::BackForwardList::~BackForwardList):
        (WebCore::BackForwardList::addItem):
        (WebCore::BackForwardList::goBack):
        (WebCore::BackForwardList::goForward):
        (WebCore::BackForwardList::goToItem):
        (WebCore::BackForwardList::backItem):
        (WebCore::BackForwardList::currentItem):
        (WebCore::BackForwardList::forwardItem):
        (WebCore::BackForwardList::backListWithLimit):
        (WebCore::BackForwardList::forwardListWithLimit):
        (WebCore::BackForwardList::capacity):
        (WebCore::BackForwardList::setCapacity):
        (WebCore::BackForwardList::setPageCacheSize):
        (WebCore::BackForwardList::pageCacheSize):
        (WebCore::BackForwardList::clearPageCache):
        (WebCore::BackForwardList::usesPageCache):
        (WebCore::BackForwardList::backListCount):
        (WebCore::BackForwardList::forwardListCount):
        (WebCore::BackForwardList::itemAtIndex):
        (WebCore::BackForwardList::entries):
        (WebCore::BackForwardList::close):
        (WebCore::BackForwardList::closed):
        (WebCore::BackForwardList::removeItem):
        (WebCore::BackForwardList::containsItem):
        (WebCore::BackForwardList::setDefaultPageCacheSize):
        (WebCore::BackForwardList::defaultPageCacheSize):
        * history/BackForwardList.h: Added.

        * history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList
        (WebCore::defaultNotifyHistoryItemChanged):
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::~HistoryItem):
        (WebCore::HistoryItem::copy):
        (WebCore::HistoryItem::setHasPageCache):
        (WebCore::HistoryItem::retainIconInDatabase):
        (WebCore::HistoryItem::urlString):
        (WebCore::HistoryItem::originalURLString):
        (WebCore::HistoryItem::title):
        (WebCore::HistoryItem::alternateTitle):
        (WebCore::HistoryItem::icon):
        (WebCore::HistoryItem::lastVisitedTime):
        (WebCore::HistoryItem::url):
        (WebCore::HistoryItem::originalURL):
        (WebCore::HistoryItem::target):
        (WebCore::HistoryItem::parent):
        (WebCore::HistoryItem::setAlternateTitle):
        (WebCore::HistoryItem::setURLString):
        (WebCore::HistoryItem::setURL):
        (WebCore::HistoryItem::setOriginalURLString):
        (WebCore::HistoryItem::setTitle):
        (WebCore::HistoryItem::setTarget):
        (WebCore::HistoryItem::setParent):
        (WebCore::HistoryItem::setLastVisitedTime):
        (WebCore::HistoryItem::visitCount):
        (WebCore::HistoryItem::setVisitCount):
        (WebCore::HistoryItem::scrollPoint):
        (WebCore::HistoryItem::setScrollPoint):
        (WebCore::HistoryItem::clearScrollPoint):
        (WebCore::HistoryItem::setDocumentState):
        (WebCore::HistoryItem::documentState):
        (WebCore::HistoryItem::clearDocumentState):
        (WebCore::HistoryItem::isTargetItem):
        (WebCore::HistoryItem::setIsTargetItem):
        (WebCore::HistoryItem::alwaysAttemptToUsePageCache):
        (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache):
        (WebCore::HistoryItem::addChildItem):
        (WebCore::HistoryItem::childItemWithName):
        (WebCore::HistoryItem::recurseToFindTargetItem):
        (WebCore::HistoryItem::targetItem):
        (WebCore::HistoryItem::pageCache):
        (WebCore::HistoryItem::children):
        (WebCore::HistoryItem::hasChildren):
        (WebCore::HistoryItem::formContentType):
        (WebCore::HistoryItem::formReferrer):
        (WebCore::HistoryItem::rssFeedReferrer):
        (WebCore::HistoryItem::setRSSFeedReferrer):
        (WebCore::HistoryItem::setFormInfoFromRequest):
        (WebCore::HistoryItem::formData):
        (WebCore::HistoryItem::mergeAutoCompleteHints):
        (WebCore::HistoryItem::hasPageCache):
        (WebCore::timer): Function to manage the global release timer
        (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released
        (WebCore::HistoryItem::releasePageCache):
        (WebCore::closeObjectsInPendingPageCaches):
        (WebCore::HistoryItem::releaseAllPendingPageCaches):
        (WebCore::HistoryItem::scheduleRelease):
        (WebCore::HistoryItem::print):
        * history/HistoryItem.h: Added.
        * history/mac/HistoryItemMac.mm: Added.
        (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state
        (WebCore::HistoryItem::setViewState):
        (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept
        (WebCore::HistoryItem::setTransientProperty):

        * history/HistoryItemTimer.cpp: Added
        (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because
        WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept
        (WebCore::HistoryItemTimer::isActive):
        (WebCore::HistoryItemTimer::schedule):
        (WebCore::HistoryItemTimer::invalidate):
        (WebCore::HistoryItemTimer::callReleasePageCache):
        * history/HistoryItemTimer.h: Added.

        * history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit
        (WebCore::PageCache::PageCache):
        (WebCore::PageCache::setPageState):
        (WebCore::PageCache::~PageCache):
        (WebCore::PageCache::pageState):
        (WebCore::PageCache::setDocumentLoader):
        (WebCore::PageCache::documentLoader):
        (WebCore::PageCache::setTimeStamp):
        (WebCore::PageCache::setTimeStampToNow):
        (WebCore::PageCache::timeStamp):
        * history/PageCache.h: Added.
        * history/mac/PageCacheMac.mm: Added.
        (WebCore::PageCache::close):
        (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView
        (WebCore::PageCache::documentView):

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::loadFromPageCache):
        (WebCore::DocumentLoader::setLoadingFromPageCache):
        (WebCore::DocumentLoader::isLoadingFromPageCache):
        (WebCore::DocumentLoader::originalURL):
        (WebCore::DocumentLoader::requestURL):
        (WebCore::DocumentLoader::responseURL):
        (WebCore::DocumentLoader::responseMIMEType):
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame
          are now here, where they should be.
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::restoreDocumentState):
        (WebCore::FrameLoader::goBackOrForward):
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::FrameLoader::canCachePage):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::didFirstLayout):
        (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage):
        (WebCore::FrameLoader::dispatchDidFinishLoadToClient):
        (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now)
        (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto
        (WebCore::FrameLoader::shouldGoToHistoryItem):
        (WebCore::FrameLoader::addExtraFieldsToRequest):
        (WebCore::FrameLoader::addHistoryItemForFragmentScroll):
        (WebCore::FrameLoader::loadProvisionalItemFromPageCache):
        (WebCore::FrameLoader::createPageCache):
        (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent):
        (WebCore::FrameLoader::createItem):
        (WebCore::FrameLoader::addBackForwardItemClippedAtTarget):
        (WebCore::FrameLoader::createItemTree):
        (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
        (WebCore::FrameLoader::restoreScrollPositionAndViewState):
        (WebCore::FrameLoader::purgePageCache):
        (WebCore::FrameLoader::invalidateCurrentItemPageCache):
        (WebCore::FrameLoader::saveDocumentState):
        (WebCore::FrameLoader::loadItem):
        (WebCore::FrameLoader::urlsMatchItem):
        (WebCore::FrameLoader::goToItem):
        (WebCore::FrameLoader::recursiveGoToItem):
        (WebCore::FrameLoader::childFramesMatchItem):
        (WebCore::FrameLoader::updateHistoryForStandardLoad):
        (WebCore::FrameLoader::updateHistoryForClientRedirect):
        (WebCore::FrameLoader::updateHistoryForBackForwardNavigation):
        (WebCore::FrameLoader::updateHistoryForReload):
        (WebCore::FrameLoader::updateHistoryForInternalLoad):
        (WebCore::FrameLoader::updateHistoryForCommit):
        (WebCore::FrameLoader::saveDocumentAndScrollState):
        (WebCore::FrameLoader::currentHistoryItem):
        (WebCore::FrameLoader::previousHistoryItem):
        (WebCore::FrameLoader::provisionalHistoryItem):
        (WebCore::FrameLoader::setCurrentHistoryItem):
        (WebCore::FrameLoader::setPreviousHistoryItem):
        (WebCore::FrameLoader::setProvisionalHistoryItem):
        * loader/FrameLoader.h:

        * loader/FrameLoaderClient.h:

        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders):
        (WebCore::DocumentLoader::commitIfReady):
        (WebCore::DocumentLoader::urlForHistory):

        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::dataURLBaseFromRequest):
        (WebCore::FrameLoader::didChangeTitle):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):

        * page/FrameTree.cpp:
        (WebCore::FrameTree::removeChild):

        * page/Page.cpp: Transfered a handful of concepts from WebView
        (WebCore::Page::Page):
        (WebCore::Page::~Page):
        (WebCore::Page::backForwardList):
        (WebCore::Page::goBack):
        (WebCore::Page::goForward):
        (WebCore::Page::goToItem):
        * page/Page.h:

        * page/PageState.h:
        * page/mac/FrameMac.h:
        * page/mac/FrameMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:

        * platform/KURL.cpp:
        (WebCore::KURL::print):  Added debug only method for debugging convenience
        * platform/KURL.h:

        * platform/Logging.cpp:
        (WebCore::): Added some logging channels
        * platform/Logging.h:

        * platform/PlatformString.h:
        (WebCore::nsStringNilIfEmpty): Added for WebKit use

        * platform/SystemTime.h: Added userIdleTime()

        * platform/graphics/svg/SVGImage.cpp:
        * platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods
        (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad):
        (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload):
        (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem):
        (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem):
        (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::canCachePage):
        (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):

        * platform/mac/LoggingMac.mm:
        (WebCore::InitializeLoggingChannelsIfNecessary):

        * platform/mac/SystemTimeMac.cpp:
        (WebCore::userIdleTime):

        * platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
        * platform/mac/WebCoreSystemInterface.mm:

        * platform/network/FormData.cpp:
        (WebCore::FormData::FormData):
        (WebCore::FormData::copy):
        * platform/network/FormData.h:

        * platform/network/ResourceHandle.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag

        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::userIdleTime):
        * rendering/RenderPart.h:

WebKit:

        Reviewed extensively and repeatedly by Darin

        <rdar://problem/4887137> - WebCore Back/Forward Cache
        Most things not specifically commented on in the ChangeLog can be summed up as
        "Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"

        * History/WebBackForwardList.mm:
        (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList
        (core):
        (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart
        (kit):
        (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]):
        (-[WebBackForwardList initWithWebCoreBackForwardList:]):
        (-[WebBackForwardList init]):
        (-[WebBackForwardList dealloc]):
        (-[WebBackForwardList finalize]):
        (-[WebBackForwardList _close]):
        (-[WebBackForwardList addItem:]):
        (-[WebBackForwardList removeItem:]):
        (-[WebBackForwardList containsItem:]):
        (-[WebBackForwardList goBack]):
        (-[WebBackForwardList goForward]):
        (-[WebBackForwardList goToItem:]):
        (-[WebBackForwardList backItem]):
        (-[WebBackForwardList currentItem]):
        (-[WebBackForwardList forwardItem]):
        (vectorToNSArray):
        (-[WebBackForwardList backListWithLimit:]):
        (-[WebBackForwardList forwardListWithLimit:]):
        (-[WebBackForwardList capacity]):
        (-[WebBackForwardList setCapacity:]):
        (-[WebBackForwardList description]):
        (-[WebBackForwardList _clearPageCache]):
        (-[WebBackForwardList setPageCacheSize:]):
        (-[WebBackForwardList pageCacheSize]):
        (-[WebBackForwardList _usesPageCache]):
        (-[WebBackForwardList backListCount]):
        (-[WebBackForwardList forwardListCount]):
        (-[WebBackForwardList itemAtIndex:]):
        * History/WebBackForwardListInternal.h: Added.

        * History/WebHistory.m: Removed.
        * History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style
        (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]):
        (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):

        * History/WebHistoryItem.mm:
        (kitPrivate): Same pattern as WebBackForwardList
        (core):
        (historyItemWrappers):
        (WKNotifyHistoryItemChanged):
        (-[WebHistoryItem init]):
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem dealloc]):
        (-[WebHistoryItem finalize]):
        (-[WebHistoryItem copyWithZone:]):
        (-[WebHistoryItem URLString]):
        (-[WebHistoryItem originalURLString]):
        (-[WebHistoryItem title]):
        (-[WebHistoryItem setAlternateTitle:]):
        (-[WebHistoryItem alternateTitle]):
        (-[WebHistoryItem icon]):
        (-[WebHistoryItem lastVisitedTimeInterval]):
        (-[WebHistoryItem hash]):
        (-[WebHistoryItem isEqual:]):
        (-[WebHistoryItem description]):
        (kit):
        (+[WebHistoryItem entryWithURL:]):
        (+[WebHistoryItem initWindowWatcherIfNecessary]):
        (-[WebHistoryItem initWithURL:target:parent:title:]):
        (-[WebHistoryItem initWithWebCoreHistoryItem:]):
        (-[WebHistoryItem setTitle:]):
        (-[WebHistoryItem setVisitCount:]):
        (-[WebHistoryItem setViewState:]):
        (-[WebHistoryItem _mergeAutoCompleteHints:]):
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        (-[WebHistoryItem scrollPoint]):
        (-[WebHistoryItem _transientPropertyForKey:]):
        (-[WebHistoryItem _setTransientProperty:forKey:]):
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem target]):
        (-[WebHistoryItem isTargetItem]):
        (-[WebHistoryItem visitCount]):
        (-[WebHistoryItem RSSFeedReferrer]):
        (-[WebHistoryItem setRSSFeedReferrer:]):
        (-[WebHistoryItem children]):
        (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
        (-[WebHistoryItem URL]):
        (-[WebHistoryItem _setLastVisitedTimeInterval:]):
        (-[WebHistoryItem _lastVisitedDate]):
        (-[WebHistoryItem targetItem]):
        (+[WebHistoryItem _releaseAllPendingPageCaches]):
        (-[WebWindowWatcher windowWillClose:]):
        * History/WebHistoryItemInternal.h:
        * History/WebHistoryItemPrivate.h:

        * WebCoreSupport/WebFrameBridge.mm:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setDocumentViewFromPageCache):
        (WebFrameLoaderClient::detachedFromParent1):
        (WebFrameLoaderClient::loadedFromPageCache):
        (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad):
        (WebFrameLoaderClient::updateGlobalHistoryForReload):
        (WebFrameLoaderClient::shouldGoToHistoryItem):
        (WebFrameLoaderClient::frameLoadCompleted):
        (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem):
        (WebFrameLoaderClient::restoreScrollPositionAndViewState):
        (WebFrameLoaderClient::provisionalLoadStarted):
        (WebFrameLoaderClient::setTitle):
        (WebFrameLoaderClient::saveDocumentViewToPageCache):
        (WebFrameLoaderClient::canCachePage):

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

        * WebKit.xcodeproj/project.pbxproj:

        * WebView/WebDataSource.mm:
        * WebView/WebDataSourceInternal.h:

        * WebView/WebFrame.mm:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _canCachePage]):
        (-[WebFrame _loadURL:referrer:intoChild:]):
        * WebView/WebFrameInternal.h:

        * WebView/WebFrameView.mm:
        (-[WebFrameView initWithFrame:]):
        (-[WebFrameView keyDown:]):

        * WebView/WebHTMLView.m:
        (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
        * WebView/WebHTMLViewInternal.h:

        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebViewPrivate dealloc]):
        (-[WebView _close]):
        (-[WebView _loadBackForwardListFromOtherView:]):
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (-[WebView initWithCoder:]):
        (-[WebView backForwardList]):
        (-[WebView goBack]):
        (-[WebView goForward]):
        (-[WebView goToBackForwardItem:]):
        (-[WebView canGoBack]):
        (-[WebView canGoForward]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker
sullivan [Wed, 3 Jan 2007 01:05:09 +0000 (01:05 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to
          open it in Preview while PDF was loading

        * WebView/WebPDFView.mm:
        (-[WebPDFView menuForEvent:]):
        added comment
        (-[WebPDFView validateUserInterfaceItem:]):
        disable this menu item when there's no document yet
        (-[WebPDFView _openWithFinder:]):
        If this is invoked when there is no document yet (e.g. via the PDFKit delegate method),
        just beep and return. I should make a nice error message here, but I'll do that separately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Timothy.
zimmermann [Wed, 3 Jan 2007 00:32:52 +0000 (00:32 +0000)]
Reviewed by Timothy.
Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber stamped by Mitz.
darin [Tue, 2 Jan 2007 23:34:18 +0000 (23:34 +0000)]
    Rubber stamped by Mitz.

        Rename isRenderSVGContainer to isSVGContainer.

        * platform/graphics/ImageBuffer.cpp:
        (WebCore::ImageBuffer::renderSubtreeToImage):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGContainer):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::viewportTransform):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::isSVGContainer):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer...
zimmermann [Tue, 2 Jan 2007 23:22:43 +0000 (23:22 +0000)]
Forgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer to isRenderSVGContainer)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Mitz.
zimmermann [Tue, 2 Jan 2007 23:20:25 +0000 (23:20 +0000)]
Reviewed by Mitz.
Rename isKCanvasContainer to isRenderSVGContainer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin [Tue, 2 Jan 2007 23:18:25 +0000 (23:18 +0000)]
WebCore:
        Reviewed by Darin.

        Fix assertion failure with WebCore context menus by getting "Copy
        Image" item added in.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate): Check if the image url is a local
        file or if we have an image in the cache.

WebKit:
        Reviewed by Darin.

        Fix bug with WebCore context menu item "Copy Image."

        * WebCoreSupport/WebContextMenuClient.mm:
        (WebContextMenuClient::copyImageToClipboard): We must call
        declareTypes on the pasteboard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 2 Jan 2007 18:58:00 +0000 (18:58 +0000)]
LayoutTests:

        Reviewed by Anders.

        Testcase for http://bugs.webkit.org/show_bug.cgi?id=12072

        * fast/forms/select-align-expected.checksum: Added.
        * fast/forms/select-align-expected.png: Added.
        * fast/forms/select-align-expected.txt: Added.
        * fast/forms/select-align.html: Added.

WebCore:

        Reviewed by Anders.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12072
        select with align attribute should not affect contained text

        Don't map align for select elements.

        Test: fast/forms/select-align.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 2 Jan 2007 18:04:35 +0000 (18:04 +0000)]
LayoutTests:

        Reviewed by Mitz.

        Testcase for http://bugs.webkit.org/show_bug.cgi?id=12071

        * fast/forms/button-align-expected.checksum: Added.
        * fast/forms/button-align-expected.png: Added.
        * fast/forms/button-align-expected.txt: Added.
        * fast/forms/button-align.html: Added.

WebCore:

        Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12071
        button with align attribute should not affect contained text

        Don't map align for button elements.

        Test: fast/forms/button-align.html

        * html/HTMLButtonElement.cpp:
        (WebCore::HTMLButtonElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 2 Jan 2007 17:41:50 +0000 (17:41 +0000)]
LayoutTests:

        Reviewed by Mitz and Anders.

        Testcases for http://bugs.webkit.org/show_bug.cgi?id=7075

        * fast/forms/textarea-align-expected.checksum: Added.
        * fast/forms/textarea-align-expected.png: Added.
        * fast/forms/textarea-align-expected.txt: Added.
        * fast/forms/textarea-align.html: Added.

WebCore:

        Reviewed by Mitz and Anders.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=7075
        textarea with align=right should not cause contained text to
        be right-justified

        Don't map align for textarea elements.

        Test: fast/forms/textarea-align.html

        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - minor tweak (hope this doesn't re-break Windows)
darin [Tue, 2 Jan 2007 17:39:50 +0000 (17:39 +0000)]
    - minor tweak (hope this doesn't re-break Windows)

        * pcre/pcre_compile.c: Removed use of const pcre_uchar const * -- Mitz probably
        meant const pcre_uchar *const, but I think we can do without the explicit const here.

        * pcre/pcre_internal.h: Re-enabled warning C4114.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Tue, 2 Jan 2007 17:22:59 +0000 (17:22 +0000)]
JavaScriptCore:

        Reviewed by NOBODY (Windows build fix).

        The MSVC compiler requires variables to be declared at the top of the enclosing block in C source.

        Disable this warning to prevent MSVC from complaining about the 'const pcre_uchar const *' type:
        warning C4114: same type qualifier used more than once

        * pcre/pcre_compile.c:
        (pcre_compile2): Moved variable declarations to top of their respective enclosing blocks.
        * pcre/pcre_internal.h: Added pragma to disable compiler warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-02 Eric Seidel <eric@webkit.org>
eseidel [Tue, 2 Jan 2007 17:08:50 +0000 (17:08 +0000)]
2007-01-02  Eric Seidel  <eric@webkit.org>

        Reviewed by mitz.

        Implement SVGSVGElement::deselectAll()

        * ksvg2/svg/SVGAnimationElement.h:
        (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::deselectAll): implement
        (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
        * ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Tue, 2 Jan 2007 14:12:09 +0000 (14:12 +0000)]
LayoutTests:

        Reviewed by Darin.

        Testcases for http://bugs.webkit.org/show_bug.cgi?id=3360

        * fast/forms/input-align-expected.checksum: Added.
        * fast/forms/input-align-expected.png: Added.
        * fast/forms/input-align-expected.txt: Added.
        * fast/forms/input-align-image-expected.checksum: Added.
        * fast/forms/input-align-image-expected.png: Added.
        * fast/forms/input-align-image-expected.txt: Added.
        * fast/forms/input-align-image.html: Added.
        * fast/forms/input-align.html: Added.

WebCore:

        Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=3360
        align="right" on a text input aligns the input field to the right

        Don't map align if input type is not 'image'.

        Test: fast/forms/input-align-image.html
        Test: fast/forms/input-align.html

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::mapToEntry):
        (WebCore::HTMLInputElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRubber stamped by Rob.
zimmermann [Tue, 2 Jan 2007 13:46:47 +0000 (13:46 +0000)]
Rubber stamped by Rob.
Adding all carto.net SVG/JS examples. Highlights some nifty bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric.
zimmermann [Tue, 2 Jan 2007 12:09:22 +0000 (12:09 +0000)]
Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12013
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11980
Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)

Rewrite gradient & pattern code, fixing all known bugs & regressions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agofix compile for svg as well (filenames are case-sensitive)
zack [Tue, 2 Jan 2007 10:13:06 +0000 (10:13 +0000)]
fix compile for svg as well (filenames are case-sensitive)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agocompilation fixes for the Qt port
zack [Tue, 2 Jan 2007 10:05:11 +0000 (10:05 +0000)]
compilation fixes for the Qt port

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-02 Eric Seidel <eric@webkit.org>
eseidel [Tue, 2 Jan 2007 09:03:08 +0000 (09:03 +0000)]
2007-01-02  Eric Seidel  <eric@webkit.org>

        Reviewed by rwlbuis.

        Refactor more animation code for better sharing between SVGAnimate*Element classes.
        - replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
        - move initialTransform() function down into SVGTimer (eventually to AnimationCompositor)
        Add non-functional (only parses) SVGAnimateMotionElement
        Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion)
        Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well.
        Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking
        change transformMatrix() to currentTransform() to match AffineTransform class name

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement):
        (WebCore::baseValueTransformList):
        (WebCore::SVGTimer::applyAnimations):
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateMotionElement.cpp: Added.
        (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
        (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement):
        (WebCore::SVGAnimateMotionElement::hasValidTarget): added.
        (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
        (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute
        (WebCore::SVGAnimateMotionElement::updateCurrentValue):
        (WebCore::SVGAnimateMotionElement::handleStartCondition):
        (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
        * ksvg2/svg/SVGAnimateMotionElement.h: Added.
        (WebCore::SVGAnimateMotionElement::contextElement):
        (WebCore::SVGAnimateMotionElement::):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::hasValidTarget): added.
        (WebCore::SVGAnimateTransformElement::storeInitialValue):
        (WebCore::SVGAnimateTransformElement::updateCurrentValue):
        (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent):
        (WebCore::SVGAnimateTransformElement::applyAnimationToValue):
        (WebCore::SVGAnimateTransformElement::currentTransform):
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::hasValidTarget): added.
        (WebCore::SVGAnimationElement::parseMappedAttribute):
        (WebCore::SVGAnimationElement::isAdditive):
        (WebCore::SVGAnimationElement::isAccumulated):
        (WebCore::SVGAnimationElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElement.h:
        (WebCore::SVGAnimationElement::updateLastValueWithCurrent):
        (WebCore::SVGAnimationElement::resetValues):
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::getPointAtLength):
        (WebCore::SVGPathElement::getPathSegAtLength):
        (WebCore::SVGPathElement::parseMappedAttribute):
        (WebCore::SVGPathElement::toPathData):
        * ksvg2/svg/SVGPathSegList.cpp:
        (WebCore::SVGPathSegList::getPathSegAtLength): added.
        (WebCore::SVGPathSegList::toPathData): added.
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/svgtags.in: add animateMotion
        * platform/graphics/Path.cpp:
        (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
        * platform/graphics/PathTraversalState.cpp:
        (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support
        (WebCore::PathTraversalState::quadraticBezierTo):
        (WebCore::PathTraversalState::cubicBezierTo):
        * platform/graphics/PathTraversalState.h:
        (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Tue, 2 Jan 2007 05:13:00 +0000 (05:13 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11849
          REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

        Modified pcre_compile() (and the functions that it calls) to work with patterns
        containing null characters.

        Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead
        pass its length to pcre_compile.
        * pcre/pcre.h:
        * pcre/pcre_compile.c:
        (check_escape):
        (get_ucp):
        (is_counted_repeat):
        (check_posix_syntax):
        (compile_branch):
        (compile_regex):
        (pcre_compile): Added a parameter specifying the length of the pattern, which
        is no longer required to be null-terminated and may contain null characters.
        (pcre_compile2):
        * pcre/pcre_internal.h:
        * tests/mozilla/expected.html: Updated for the two tests that this patch
        fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js
        which were not updated after bug 6257 was fixed.

WebCore:

        Reviewed by Darin.

        - WebCore changes for http://bugs.webkit.org/show_bug.cgi?id=11849
          REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly)

        * platform/RegularExpression.cpp:
        (WebCore::RegularExpression::Private::compile): Changed to not null-terminate
        the pattern string and instead pass its length to pcre_compile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Tue, 2 Jan 2007 04:37:43 +0000 (04:37 +0000)]
LayoutTests:

        Reviewed by Darin.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=11359
          Incomplete repaint of table cell's collapsed border when changing only the cell

        * fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
        * fast/repaint/table-cell-collapsed-border-expected.png: Added.
        * fast/repaint/table-cell-collapsed-border-expected.txt: Added.
        * fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11359
          Incomplete repaint of table cell's collapsed border when changing only the cell

        Test: fast/repaint/table-cell-collapsed-border.html

        * rendering/RenderTable.h:
        Added needsSectionRecalc() accessor.
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the
        outer half of any collapsed borders. This function checks the cell's borders'
        widths but also the widths of the adjoining cells' borders, since they can
        contribute to the length of this cell's borders perpendicular to them, making
        such a border overflow the cell in both dimensions.
        (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to
        borderHalfLeft().
        (WebCore::RenderTableCell::borderRight): Ditto.
        (WebCore::RenderTableCell::borderTop): Ditto.
        (WebCore::RenderTableCell::borderBottom): Ditto.
        (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean
        parameter. When true, this function returns the width of the part of the border
        that is outside the cell (different from the inner width when the total width is odd).
        (WebCore::RenderTableCell::borderHalfRight): Ditto.
        (WebCore::RenderTableCell::borderHalfTop): Ditto.
        (WebCore::RenderTableCell::borderHalfBottom): Ditto.
        * rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Tue, 2 Jan 2007 04:27:25 +0000 (04:27 +0000)]
WebCore:

        WebCore.vcproj change reviewed by Darin.  Additional build files updated by ddkilzer.

        * CMakeLists.txt: Removed RenderLineEdit.cpp.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
        * WebCoreSources.bkl: Removed RenderLineEdit.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Tue, 2 Jan 2007 04:19:35 +0000 (04:19 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12057
          REGRESSION: JavaScript Date Is One Day In The Future in GMT time zone

        Because Mac OS X returns geographically and historically accurate time zone information,
        converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
        in GMT (London - England) since it was in BST (+0100) all year in 1970[1].  Instead, the
        UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
        subtracting that from the same date in UTC.

        [1] http://en.wikipedia.org/wiki/British_Summer_Time

        * kjs/DateMath.cpp:
        (KJS::getUTCOffset): Updated UTC offset calculation.
        (KJS::getDSTOffset): Improved comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
ddkilzer [Tue, 2 Jan 2007 04:13:43 +0000 (04:13 +0000)]
WebKitTools:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12023
        svn-create-patch and friends should handle moved/copied files

        * Scripts/svn-apply: Identify copied files and handle those before all other patches.
        * Scripts/svn-create-patch: Generate patches with subtle changes for copied files.
        (findMimeType($)): Added.
        (findModificationTime($)): Added.
        (findSourceFileAndRevision($)): Added.
        (generateDiff($$$)): Changed to use svn stat instead of svn diff.
        (isBinaryMimeType($)): Added.
        (manufacturePatchForAdditionWithHistory($$)): Added.
        * Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * quality/bugzilla.html: Fix a lingering reference to opendarwin.org.
darin [Tue, 2 Jan 2007 02:27:07 +0000 (02:27 +0000)]
    * quality/bugzilla.html: Fix a lingering reference to opendarwin.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Tue, 2 Jan 2007 02:03:37 +0000 (02:03 +0000)]
LayoutTests:

        Reviewed by Mark Rowe.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=12042
          Assertion failure in WebCore::RenderObject::drawBorder

        * fast/borders/outline-offset-min-assert-expected.checksum: Added.
        * fast/borders/outline-offset-min-assert-expected.png: Added.
        * fast/borders/outline-offset-min-assert-expected.txt: Added.
        * fast/borders/outline-offset-min-assert.html: Added.

WebCore:

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12042
          Assertion failure in WebCore::RenderObject::drawBorder

        Test: fast/borders/outline-offset-min-assert.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintOutline): Bail out if the width or height is
        smaller than twice the outline inset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Mark Rowe <bdash@webkit.org>
bdash [Tue, 2 Jan 2007 01:42:45 +0000 (01:42 +0000)]
2007-01-01  Mark Rowe  <bdash@webkit.org>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12061
        Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

        * rendering/RenderStyle.cpp:
        (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent
        do not result in derefing deallocated members.

2007-01-01  Mark Rowe  <bdash@webkit.org>

        Reviewed by Eric.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=12061
        Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

        * fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
        * fast/css-generated-content/reset-content-to-initial.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 20:48:30 +0000 (20:48 +0000)]
2007-01-01  Eric Seidel  <eric@webkit.org>

        Reviewed by andersca.

        Begin pushing code down into SVGAnimateElement

        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::handleStartCondition):
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.h:
        (WebCore::SVGAnimateElement::updateCurrentValue):
        (WebCore::SVGAnimateElement::handleStartCondition):
        (WebCore::SVGAnimateElement::handleEndCondition):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleStartCondition):
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        (WebCore::SVGSetElement::updateCurrentValue):
        (WebCore::SVGSetElement::handleStartCondition):
        (WebCore::SVGSetElement::handleEndCondition):
        * ksvg2/svg/SVGSetElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 19:40:02 +0000 (19:40 +0000)]
2007-01-01  Eric Seidel  <eric@webkit.org>

        Reviewed by andersca.

        Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString
        (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString
        (WebCore::parseNumberOrPercent): new color parsing helper
        (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
        * ksvg2/svg/SVGColor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 18:58:58 +0000 (18:58 +0000)]
2007-01-01  Eric Seidel  <eric@webkit.org>

        Reviewed by andersca.

        Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::storeInitialValue):
        (WebCore::SVGAnimateColorElement::resetValues):
        (WebCore::SVGAnimateColorElement::updateCurrentValue):
        (WebCore::SVGAnimateColorElement::startIfNecessary):
        (WebCore::SVGAnimateColorElement::handleEndCondition):
        (WebCore::SVGAnimateColorElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::storeInitialValue):
        (WebCore::SVGAnimateTransformElement::resetValues):
        (WebCore::SVGAnimateTransformElement::updateCurrentValue):
        (WebCore::SVGAnimateTransformElement::startIfNecessary):
        (WebCore::SVGAnimateTransformElement::handleEndCondition):
        (WebCore::SVGAnimateTransformElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Mon, 1 Jan 2007 18:56:54 +0000 (18:56 +0000)]
    Reviewed by Eric.

        Simple cleanups, removing unused color table, copyright and include guard fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agocorrect reviewer, was andersca not mitz
eseidel [Mon, 1 Jan 2007 18:20:26 +0000 (18:20 +0000)]
correct reviewer, was andersca not mitz

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 1 Jan 2007 18:19:51 +0000 (18:19 +0000)]
2007-01-01  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        More animation code cleanup.

        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        (WebCore::SVGAnimationElement::connectedToTimer):
        (WebCore::SVGAnimationElement::connectTimer):
        (WebCore::SVGAnimationElement::disconnectTimer):
        (WebCore::SVGAnimationElement::updateForElapsedSeconds):
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        (WebCore::SVGSetElement::handleTimerEvent):
        * ksvg2/svg/SVGSetElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@eseidel.com>
eseidel [Mon, 1 Jan 2007 17:53:40 +0000 (17:53 +0000)]
2007-01-01  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        More clean-up to animation code.

        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleTimerEvent):
        (WebCore::SVGAnimateTransformElement::parseTransformValue):
        (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 08:12:43 +0000 (08:12 +0000)]
2007-01-01  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.

        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement): add comment
        (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        (WebCore::calculateTimePercentage): logic moved from SVGTimer
        (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGTransformList.cpp:
        (SVGTransformList::concatenate): fixed spacing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-01-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 06:47:28 +0000 (06:47 +0000)]
2007-01-01  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        Split out animationsByElement() logic in preparation for adding AnimationCompositor class
        Add addColorsAndClamp helper (since adding and clamping is the common case)

        * ksvg2/misc/SVGTimer.cpp:
        (WebCore::SVGTimer::animationsByElement): split out from notifyAll
        (WebCore::SVGTimer::notifyAll):
        * ksvg2/misc/SVGTimer.h:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
        * ksvg2/svg/SVGAnimateColorElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-31 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 06:03:15 +0000 (06:03 +0000)]
2006-12-31  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
        (Basic clean-up before re-working animation system)

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
        * ksvg2/misc/KSVGTimeScheduler.h: Removed.
        * ksvg2/misc/SVGTimer.cpp: Added.
        (WebCore::SVGTimer::SVGTimer):
        (WebCore::SVGTimer::calculateTimePercentage):
        (WebCore::SVGTimer::notifyAll):
        * ksvg2/misc/SVGTimer.h: Added.
        * ksvg2/misc/TimeScheduler.cpp: Added.
        (WebCore::TimeScheduler::TimeScheduler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-31 Eric Seidel <eric@webkit.org>
eseidel [Mon, 1 Jan 2007 05:15:28 +0000 (05:15 +0000)]
2006-12-31  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        Re-enable animateTransform (now that SVGList is fixed)
        (Things are only "less broken" not totally fixed yet.)

        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (WebCore::SVGTimer::notifyAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ddkilzer [Mon, 1 Jan 2007 05:07:40 +0000 (05:07 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        Update embedded pcre library from version 6.2 to 6.4.  Changes from pcre 6.2 to 6.3
        did not include any files in JavaScriptCore/pcre.

        All changes include renaming EXPORT to PCRE_EXPORT, renaming of ucp_findchar() to
        _pcre_ucp_findchar(), or comment changes.  Additional changes noted below.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated source file list.
        * JavaScriptCore.xcodeproj/project.pbxproj: Renamed pcre_printint.c to pcre_printint.src
        and changed it from a source file to a header file.
        * JavaScriptCoreSources.bkl: Updated source file list.
        * pcre/CMakeLists.txt: Updated source file list.
        * pcre/pcre-config.h:
        * pcre/pcre.h: Updated version.
        * pcre/pcre.pri: Updated source file list.
        * pcre/pcre_compile.c: Include pcre_printint.src #if DEBUG.
        (pcre_compile2):
        * pcre/pcre_config.c:
        * pcre/pcre_exec.c:
        (match):
        * pcre/pcre_fullinfo.c:
        * pcre/pcre_info.c:
        * pcre/pcre_internal.h: Added header guard.  Removed export of _pcre_printint().
        * pcre/pcre_ord2utf8.c:
        * pcre/pcre_printint.c: Renamed to pcre_printint.src.
        * pcre/pcre_printint.src: Added.  Renamed _pcre_printint() to pcre_printint().
        * pcre/pcre_refcount.c:
        * pcre/pcre_study.c:
        * pcre/pcre_tables.c:
        * pcre/pcre_try_flipped.c:
        * pcre/pcre_ucp_findchar.c: Added contents of ucp_findchar.c.
        * pcre/pcre_version.c:
        * pcre/pcre_xclass.c:
        (_pcre_xclass):
        * pcre/ucp.h: Removed export of ucp_findchar().
        * pcre/ucp_findchar.c: Removed.  Contents moved to pcre_ucp_findchar.c.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ddkilzer [Mon, 1 Jan 2007 00:49:29 +0000 (00:49 +0000)]
WebCore:

        Reviewed by Hyatt.

        - http://bugs.webkit.org/show_bug.cgi?id=12049
          RenderBlock::calcMinMaxWidth() should not examine children of fixed-width blocks

        No test possible (no change to functionality).

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth()
        only if their result is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRoll over WebCore ChangeLog
bdash [Mon, 1 Jan 2007 00:37:31 +0000 (00:37 +0000)]
Roll over WebCore ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-31 Eric Seidel <eric@webkit.org>
eseidel [Sun, 31 Dec 2006 21:45:39 +0000 (21:45 +0000)]
2006-12-31  Eric Seidel  <eric@webkit.org>

        Reviewed by weinig.

        Make SVGPathSeg construction take fewer lines of code.

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
        (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
        (WebCore::SVGPathElement::createSVGPathSegArcAbs):
        (WebCore::SVGPathElement::createSVGPathSegArcRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
        * ksvg2/svg/SVGPathSegArc.cpp:
        (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
        (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
        (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
        (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
        (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
        (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
        (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
        (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
        (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
        (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.cpp:
        (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
        (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
        (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
        (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
        (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
        (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegMoveto.cpp:
        (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
        (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
        * ksvg2/svg/SVGPathSegMoveto.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-31 Eric Seidel <eric@eseidel.com>
eseidel [Sun, 31 Dec 2006 20:38:28 +0000 (20:38 +0000)]
2006-12-31  Eric Seidel  <eric@eseidel.com>

        Reviewed by mitz.

        Make getTotalLength test case work in Opera and FireFox.

        * svg/custom/path-getTotalLength-expected.checksum: Removed.
        * svg/custom/path-getTotalLength-expected.png: Removed.
        * svg/custom/path-getTotalLength-expected.txt:
        * svg/custom/path-getTotalLength.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-31 Eric Seidel <eric@eseidel.com>
eseidel [Sun, 31 Dec 2006 19:37:02 +0000 (19:37 +0000)]
2006-12-31  Eric Seidel  <eric@eseidel.com>

        Reviewed by weinig.

        Implement path length measuring for SVGPathElement::getTotalLength and friends.
        http://bugs.webkit.org/show_bug.cgi?id=12033

        * WebCore.xcodeproj/project.pbxproj:
        * ksvg2/svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::getTotalLength):
        (WebCore::SVGPathElement::getPointAtLength):
        * platform/graphics/Path.cpp:
        (WebCore::pathLengthApplierFunction):
        (WebCore::Path::length):
        (WebCore::Path::pointAtLength):
        * platform/graphics/Path.h:
        * platform/graphics/PathTraversalState.cpp: Added.
        (WebCore::midPoint):
        (WebCore::distanceLine):
        (WebCore::QuadraticBezier::QuadraticBezier):
        (WebCore::QuadraticBezier::approximateDistance):
        (WebCore::QuadraticBezier::split):
        (WebCore::CubicBezier::CubicBezier):
        (WebCore::CubicBezier::approximateDistance):
        (WebCore::CubicBezier::split):
        (WebCore::curveLength):
        (WebCore::PathTraversalState::PathTraversalState):
        (WebCore::PathTraversalState::closeSubpath):
        (WebCore::PathTraversalState::moveTo):
        (WebCore::PathTraversalState::lineTo):
        (WebCore::PathTraversalState::quadraticBezierTo):
        (WebCore::PathTraversalState::cubicBezierTo):
        * platform/graphics/PathTraversalState.h: Added.
        (WebCore::PathTraversalState::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Sun, 31 Dec 2006 16:08:49 +0000 (16:08 +0000)]
    Reviewed by Mitz.

        Move the SVGZoomAndPanType enum out of SVGSVGElement and
        SVGViewElement and into SVGZoomAndPan where it belongs.

        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        (WebCore::SVGZoomAndPan::SVGZoomAndPan):
        (WebCore::SVGZoomAndPan::parseMappedAttribute):
        * ksvg2/svg/SVGZoomAndPan.h:
        (WebCore::SVGZoomAndPan::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Sun, 31 Dec 2006 14:25:57 +0000 (14:25 +0000)]
LayoutTests:

        Reviewed by Hyatt. Tweaked by Mitz.

        - test for http://bugs.webkit.org/show_bug.cgi?id=9659
          Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

        * fast/overflow/clip-rects-fixed-ancestor-expected.checksum: Added.
        * fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
        * fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
        * fast/overflow/clip-rects-fixed-ancestor.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=9659
          Quirksmode: Fixed / Overflow > Positioned objects get hidden when scrolling

        Added a 'fixed' flag to ClipRects, indicating that the cached rects are in
        viewport coordinates. The flag is set (and scrolling is compensated for) for
        fixed objects and their descendants.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateClipRects):
        (WebCore::RenderLayer::calculateRects):
        * rendering/RenderLayer.h:
        (WebCore::ClipRects::ClipRects):
        (WebCore::ClipRects::fixed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Sun, 31 Dec 2006 14:00:18 +0000 (14:00 +0000)]
LayoutTests:

        Reviewed by Sam.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12037
          For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

        * fast/block/positioning/relative-overconstrained-expected.checksum: Added.
        * fast/block/positioning/relative-overconstrained-expected.png: Added.
        * fast/block/positioning/relative-overconstrained-expected.txt: Added.
        * fast/block/positioning/relative-overconstrained.html: Added.

WebCore:

        Reviewed by Sam.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12037
          For relatively positioned boxes in an RTL block, 'right' should win over 'left' if both are not 'auto'

        Test: fast/block/positioning/relative-overconstrained.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::relativePositionOffsetX):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Sat, 30 Dec 2006 23:02:57 +0000 (23:02 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12004
        Webkit doesnt handle omitting M at the start of path syntax well

        Improve path parsing error handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Sat, 30 Dec 2006 21:54:06 +0000 (21:54 +0000)]
    Reviewed by Darin.

        The marker is used for start, mid and end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by weinig.
rwlbuis [Sat, 30 Dec 2006 20:53:19 +0000 (20:53 +0000)]
    Reviewed by weinig.

        http://bugs.webkit.org/show_bug.cgi?id=12035
        Use SVGParserUtilities in lists of values

        Use SVGParserUtilities in some more places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by weinig.
rwlbuis [Sat, 30 Dec 2006 16:09:42 +0000 (16:09 +0000)]
    Reviewed by weinig.

        http://bugs.webkit.org/show_bug.cgi?id=12034
        Adapt preserveAspectRatio parsing to SVGParserUtilities

        Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-30 Mitz Pettel <mitz@webkit.org>
ap [Sat, 30 Dec 2006 10:12:21 +0000 (10:12 +0000)]
2006-12-30  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Alexey.

        - remove unused member variables m_loadingSheet and m_bAllDataReceived

        No test possible (no change to functionality).

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setCSSStyleSheet):
        * dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
ap [Sat, 30 Dec 2006 08:34:00 +0000 (08:34 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11998
        Incorrect serialization of quotation marks in XML attributes.

        Test: fast/dom/serialize-attribute.xhtml

        * editing/markup.cpp:
        (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark
        only needs to be encoded in attribute values.
        (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Sat, 30 Dec 2006 03:03:43 +0000 (03:03 +0000)]
2006-12-29  David Kilzer  <ddkilzer@webkit.org>

        Reviewed by Geoff.

        Update embedded pcre library from version 6.1 to 6.2.  From the pcre ChangeLog:

        3. Added "b" to the 2nd argument of fopen() in dftables.c, for non-Unix-like
           operating environments where this matters.

        5. Named capturing subpatterns were not being correctly counted when a pattern
           was compiled. This caused two problems: (a) If there were more than 100
           such subpatterns, the calculation of the memory needed for the whole
           compiled pattern went wrong, leading to an overflow error. (b) Numerical
           back references of the form \12, where the number was greater than 9, were
           not recognized as back references, even though there were sufficient
           previous subpatterns.

        * pcre/dftables.c: Item 3.
        (main):
        * pcre/pcre.h: Updated version.
        * pcre/pcre_compile.c: Item 5.
        (read_repeat_counts):
        (pcre_compile2):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 David Kilzer <ddkilzer@webkit.org>
ddkilzer [Sat, 30 Dec 2006 01:30:47 +0000 (01:30 +0000)]
2006-12-29  David Kilzer  <ddkilzer@webkit.org>

        Build fix for no-svg build.

        Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

        * bindings/js/kjs_css.cpp:
        (KJS::toJS):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren [Sat, 30 Dec 2006 00:48:56 +0000 (00:48 +0000)]
JavaScriptCore:

        Reviewed by Brian Dash... err... Mark Rowe.

        More cleanup in preparation for fixing <rdar://problem/4608404>
        WebScriptObject's _executionContext lack of ownership policy causes
        crashes (e.g., in Dashcode)

        The key change here is to RootObject::RootObject().

        * JavaScriptCore.exp:

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant): Changed to use new constructor.

        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::createNative): Changed to use new constructor. Replaced
        large 'if' followed by default condition with "if !" and explicit default
        condition.

        * bindings/objc/objc_runtime.mm:
        (convertValueToObjcObject): Changed to use new constructor.

        * bindings/runtime_root.cpp:
        (KJS::Bindings::RootObject::destroy): "removeAllNativeReferences" => "destroy"
        because this function actually destroys the RootObject.

        * bindings/runtime_root.h: Changed Interpreter* to RefPtr<Interpreter>
        to prevent a RootObject from holding a stale Interperter*.

        (KJS::Bindings::RootObject::RootObject): Changed constructor to take an
        Interpreter*, since it's pointless to create a RootObject without one.
        Removed setRootObjectImp() and rootObjectImp() because they were just
        a confusing way of setting and getting the Interpreter's global object.

        (KJS::Bindings::RootObject::nativeHandle): "_nativeHandle" => "m_nativeHandle"
        (KJS::Bindings::RootObject::interpreter): "_interpreter" => "m_interpreter"

WebCore:

        Reviewed by Brian Dash... err... Mark Rowe.

        More cleanup in preparation for fixing <rdar://problem/4608404>
        WebScriptObject's _executionContext lack of ownership policy causes
        crashes (e.g., in Dashcode)

        The key change here is to RootObject::RootObject().

        Layout tests pass.

        Renamed "_bindingRoot" => "_bindingRootObject" because "RootObject" is the
        type name.

        * bindings/objc/WebScriptObject.mm:
        (_didExecute): Use Interpreter::globalObject(), since RootObject::rootObjectImp()
        no longer exists.

        * page/mac/FrameMac.mm:
        (WebCore::FrameMac::bindingRootObject): Use the new RootObject constructor.
        Stop lying about who deletes _bindingRoot.

        (WebCore::FrameMac::cleanupPluginObjects): => "destroy". Fixed a bug where
        the RootObject would only free its own memory if there were a ReferencesSet*
        associated with it.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge rootObjectForView:]): Use new constructor. Changed
        misleading comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Fri, 29 Dec 2006 22:14:41 +0000 (22:14 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12007
        SVGColor::setRGBColor color creates/deletes many strings, slowing down parsing

        Refactor code so svg reuses cssparser methods. Also make
        SVGColor and SVGPaint more efficient by avoiding using
        setRGBColor internally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by weinig.
rwlbuis [Fri, 29 Dec 2006 20:59:44 +0000 (20:59 +0000)]
    Reviewed by weinig.

        http://bugs.webkit.org/show_bug.cgi?id=12022
        typo in SVGTransformable.cpp introduce in r18440

        Use the helper method proposed by Eric.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Eric.
rwlbuis [Fri, 29 Dec 2006 20:47:03 +0000 (20:47 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=12028
        Adapt viewBox parsing to SVGParserUtilities

        Use the new parseNumber and add tests for viewBox parsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix: SVGImage only works on Mac.
ggaren [Fri, 29 Dec 2006 20:00:02 +0000 (20:00 +0000)]
    Build fix: SVGImage only works on Mac.

        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
weinig [Fri, 29 Dec 2006 19:28:15 +0000 (19:28 +0000)]
    Reviewed by Geoff.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12018
        Cleanup of CSSRule and its subclasses

        - Make CSSRule::type() virtual instead of using a member variable.
        - General style cleanup.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSCharsetRule.cpp:
        (WebCore::CSSCharsetRule::CSSCharsetRule):
        * css/CSSCharsetRule.h:
        (WebCore::CSSCharsetRule::isCharsetRule):
        (WebCore::CSSCharsetRule::type):
        * css/CSSFontFaceRule.cpp:
        (WebCore::CSSFontFaceRule::CSSFontFaceRule):
        (WebCore::CSSFontFaceRule::cssText):
        * css/CSSFontFaceRule.h:
        (WebCore::CSSFontFaceRule::isFontFaceRule):
        (WebCore::CSSFontFaceRule::type):
        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::CSSImportRule):
        (WebCore::CSSImportRule::setCSSStyleSheet):
        (WebCore::CSSImportRule::insertedIntoParent):
        * css/CSSImportRule.h:
        (WebCore::CSSImportRule::isImportRule):
        (WebCore::CSSImportRule::type):
        * css/CSSMediaRule.cpp:
        (WebCore::CSSMediaRule::CSSMediaRule):
        (WebCore::CSSMediaRule::insertRule):
        (WebCore::CSSMediaRule::deleteRule):
        (WebCore::CSSMediaRule::cssText):
        * css/CSSMediaRule.h:
        (WebCore::CSSMediaRule::isMediaRule):
        (WebCore::CSSMediaRule::type):
        * css/CSSPageRule.cpp:
        (WebCore::CSSPageRule::CSSPageRule):
        (WebCore::CSSPageRule::selectorText):
        (WebCore::CSSPageRule::setSelectorText):
        (WebCore::CSSPageRule::cssText):
        * css/CSSPageRule.h:
        (WebCore::CSSPageRule::style):
        (WebCore::CSSPageRule::type):
        * css/CSSRule.cpp:
        (WebCore::CSSRule::cssText):
        (WebCore::CSSRule::setCssText):
        * css/CSSRule.h:
        (WebCore::CSSRule::):
        (WebCore::CSSRule::CSSRule):
        * css/CSSStyleRule.cpp:
        (WebCore::CSSStyleRule::CSSStyleRule):
        (WebCore::CSSStyleRule::setSelectorText):
        (WebCore::CSSStyleRule::cssText):
        (WebCore::CSSStyleRule::parseString):
        * css/CSSStyleRule.h:
        (WebCore::CSSStyleRule::isStyleRule):
        (WebCore::CSSStyleRule::style):
        (WebCore::CSSStyleRule::type):
        * css/CSSUnknownRule.h:
        (WebCore::CSSUnknownRule::CSSUnknownRule):
        (WebCore::CSSUnknownRule::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 Eric Seidel <eric@eseidel.com>
eseidel [Fri, 29 Dec 2006 17:45:28 +0000 (17:45 +0000)]
2006-12-29  Eric Seidel  <eric@eseidel.com>

        Reviewed by ap.

        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::size): explicitly cast to integers to prevent compile error

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake the Qt port not crash on many sites such as www.apple.com: painter was closed too
staikos [Fri, 29 Dec 2006 14:47:17 +0000 (14:47 +0000)]
Make the Qt port not crash on many sites such as apple.com: painter was closed too
early, and I think also there is a Qt bug that it complains about a painter being
around on a destroyed object that's really just a QShared reference going away.  Worked
around.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fixed, not reviewed. Noticed by Daniel Molkentin.
zimmermann [Fri, 29 Dec 2006 11:17:51 +0000 (11:17 +0000)]
Build fixed, not reviewed. Noticed by Daniel Molkentin.
* platform/graphics/svg/SVGImage.h: s/WTF/wtf/ in include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 Eric Seidel <eric@webkit.org>
eseidel [Fri, 29 Dec 2006 09:17:04 +0000 (09:17 +0000)]
2006-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyCromeClient::scaleFactor):  build fix, use 1.f instead of 1f

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 Eric Seidel <eric@eseidel.com>
eseidel [Fri, 29 Dec 2006 08:36:18 +0000 (08:36 +0000)]
2006-12-29  Eric Seidel  <eric@eseidel.com>

        Reviewed by olliej.

        Add updated SVGImage results, forgotten in last commit.

        * fast/images/svg-as-background-expected.checksum: Added.
        * fast/images/svg-as-background-expected.png: Added.
        * fast/images/svg-as-background-expected.txt: Added.
        * fast/images/svg-as-image-expected.checksum: Added.
        * fast/images/svg-as-image-expected.png: Added.
        * fast/images/svg-as-image-expected.txt: Added.
        * fast/images/svg-as-tiled-background-expected.checksum: Added.
        * fast/images/svg-as-tiled-background-expected.png: Added.
        * fast/images/svg-as-tiled-background-expected.txt: Added.
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
        * svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 Eric Seidel <eric@webkit.org>
eseidel [Fri, 29 Dec 2006 08:27:45 +0000 (08:27 +0000)]
2006-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by hyatt.

        New tests:
        * fast/images/svg-as-image.html
        * fast/images/svg-as-background.html
        * fast/images/svg-as-tiled-background.html

        Implement basic SVGImage support.
        http://bugs.webkit.org/show_bug.cgi?id=5971

        This implementation depends on (rather ugly) stub Page and Frame clients in SVGImageEmptyClients.h

        * WebCore.xcodeproj/project.pbxproj: add SVGImage.*
        * ksvg2/svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::parseMappedAttribute): ignore fragment urls
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):
        * platform/graphics/Image.h: made setData virtual
        * platform/graphics/cg/PDFDocumentImage.cpp:
        (WebCore::PDFDocumentImage::drawTiled): stub method
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/svg/SVGImage.cpp: Added.
        (WebCore::SVGImage::SVGImage):
        (WebCore::SVGImage::~SVGImage):
        (WebCore::SVGImage::size):
        (WebCore::SVGImage::draw):
        (WebCore::SVGImage::drawTiled): stub method
        (WebCore::SVGImage::setData):
        * platform/graphics/svg/SVGImage.h: Added.
        (WebCore::SVGImage::frameAtIndex):
        * platform/graphics/svg/SVGImageEmptyClients.h: Added.
        (WebCore::SVGEmptyCromeClient::~SVGEmptyCromeClient):
        (WebCore::SVGEmptyCromeClient::chromeDestroyed):
        (WebCore::SVGEmptyCromeClient::setWindowRect):
        (WebCore::SVGEmptyCromeClient::windowRect):
        (WebCore::SVGEmptyCromeClient::pageRect):
        (WebCore::SVGEmptyCromeClient::scaleFactor):
        (WebCore::SVGEmptyCromeClient::focus):
        (WebCore::SVGEmptyCromeClient::unfocus):
        (WebCore::SVGEmptyCromeClient::createWindow):
        (WebCore::SVGEmptyCromeClient::createModalDialog):
        (WebCore::SVGEmptyCromeClient::show):
        (WebCore::SVGEmptyCromeClient::canRunModal):
        (WebCore::SVGEmptyCromeClient::runModal):
        (WebCore::SVGEmptyCromeClient::setToolbarsVisible):
        (WebCore::SVGEmptyCromeClient::toolbarsVisible):
        (WebCore::SVGEmptyCromeClient::setStatusbarVisible):
        (WebCore::SVGEmptyCromeClient::statusbarVisible):
        (WebCore::SVGEmptyCromeClient::setScrollbarsVisible):
        (WebCore::SVGEmptyCromeClient::scrollbarsVisible):
        (WebCore::SVGEmptyCromeClient::setMenubarVisible):
        (WebCore::SVGEmptyCromeClient::menubarVisible):
        (WebCore::SVGEmptyCromeClient::setResizable):
        (WebCore::SVGEmptyCromeClient::addMessageToConsole):
        (WebCore::SVGEmptyCromeClient::canRunBeforeUnloadConfirmPanel):
        (WebCore::SVGEmptyCromeClient::runBeforeUnloadConfirmPanel):
        (WebCore::SVGEmptyCromeClient::closeWindowSoon):
        (WebCore::SVGEmptyFrameLoaderClient::~SVGEmptyFrameLoaderClient):
        (WebCore::SVGEmptyFrameLoaderClient::frameLoaderDestroyed):
        (WebCore::SVGEmptyFrameLoaderClient::hasWebView):
        (WebCore::SVGEmptyFrameLoaderClient::hasFrameView):
        (WebCore::SVGEmptyFrameLoaderClient::hasBackForwardList):
        (WebCore::SVGEmptyFrameLoaderClient::resetBackForwardList):
        (WebCore::SVGEmptyFrameLoaderClient::provisionalItemIsTarget):
        (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::privateBrowsingEnabled):
        (WebCore::SVGEmptyFrameLoaderClient::makeDocumentView):
        (WebCore::SVGEmptyFrameLoaderClient::makeRepresentation):
        (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::forceLayout):
        (WebCore::SVGEmptyFrameLoaderClient::forceLayoutForNonHTML):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForCommit):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForBackForwardNavigation):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForReload):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForStandardLoad):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryForInternalLoad):
        (WebCore::SVGEmptyFrameLoaderClient::updateHistoryAfterClientRedirect):
        (WebCore::SVGEmptyFrameLoaderClient::setCopiesOnScroll):
        (WebCore::SVGEmptyFrameLoaderClient::tokenForLoadErrorReset):
        (WebCore::SVGEmptyFrameLoaderClient::resetAfterLoadError):
        (WebCore::SVGEmptyFrameLoaderClient::doNotResetAfterLoadError):
        (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent1):
        (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent2):
        (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent3):
        (WebCore::SVGEmptyFrameLoaderClient::detachedFromParent4):
        (WebCore::SVGEmptyFrameLoaderClient::loadedFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::download):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchIdentifierForInitialRequest):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidHandleOnloadEvents):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelClientRedirect):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillPerformClientRedirect):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillClose):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveIcon):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidStartProvisionalLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveTitle):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCommitLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailProvisionalLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoad):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFirstLayout):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchShow):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForMIMEType):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
        (WebCore::SVGEmptyFrameLoaderClient::cancelPolicyCheck):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchUnableToImplementPolicy):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSubmitForm):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadMainResource):
        (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromPageCache):
        (WebCore::SVGEmptyFrameLoaderClient::revertToProvisionalState):
        (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError):
        (WebCore::SVGEmptyFrameLoaderClient::clearUnarchivingState):
        (WebCore::SVGEmptyFrameLoaderClient::progressStarted):
        (WebCore::SVGEmptyFrameLoaderClient::progressCompleted):
        (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
        (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
        (WebCore::SVGEmptyFrameLoaderClient::setMainFrameDocumentReady):
        (WebCore::SVGEmptyFrameLoaderClient::startDownload):
        (WebCore::SVGEmptyFrameLoaderClient::willChangeTitle):
        (WebCore::SVGEmptyFrameLoaderClient::didChangeTitle):
        (WebCore::SVGEmptyFrameLoaderClient::committedLoad):
        (WebCore::SVGEmptyFrameLoaderClient::finishedLoading):
        (WebCore::SVGEmptyFrameLoaderClient::finalSetupForReplace):
        (WebCore::SVGEmptyFrameLoaderClient::cancelledError):
        (WebCore::SVGEmptyFrameLoaderClient::cannotShowURLError):
        (WebCore::SVGEmptyFrameLoaderClient::interruptForPolicyChangeError):
        (WebCore::SVGEmptyFrameLoaderClient::cannotShowMIMETypeError):
        (WebCore::SVGEmptyFrameLoaderClient::fileDoesNotExistError):
        (WebCore::SVGEmptyFrameLoaderClient::shouldFallBack):
        (WebCore::SVGEmptyFrameLoaderClient::setDefersLoading):
        (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):
        (WebCore::SVGEmptyFrameLoaderClient::isArchiveLoadPending):
        (WebCore::SVGEmptyFrameLoaderClient::cancelPendingArchiveLoad):
        (WebCore::SVGEmptyFrameLoaderClient::clearArchivedResources):
        (WebCore::SVGEmptyFrameLoaderClient::canHandleRequest):
        (WebCore::SVGEmptyFrameLoaderClient::canShowMIMEType):
        (WebCore::SVGEmptyFrameLoaderClient::representationExistsForURLScheme):
        (WebCore::SVGEmptyFrameLoaderClient::generatedMIMETypeForURLScheme):
        (WebCore::SVGEmptyFrameLoaderClient::frameLoadCompleted):
        (WebCore::SVGEmptyFrameLoaderClient::restoreScrollPositionAndViewState):
        (WebCore::SVGEmptyFrameLoaderClient::provisionalLoadStarted):
        (WebCore::SVGEmptyFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
        (WebCore::SVGEmptyFrameLoaderClient::addHistoryItemForFragmentScroll):
        (WebCore::SVGEmptyFrameLoaderClient::didFinishLoad):
        (WebCore::SVGEmptyFrameLoaderClient::prepareForDataSourceReplacement):
        (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):
        (WebCore::SVGEmptyFrameLoaderClient::setTitle):
        (WebCore::SVGEmptyFrameLoaderClient::userAgent):
        (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):
        (WebCore::SVGEmptyEditorClient::pageDestroyed):
        (WebCore::SVGEmptyEditorClient::shouldDeleteRange):
        (WebCore::SVGEmptyEditorClient::shouldShowDeleteInterface):
        (WebCore::SVGEmptyEditorClient::smartInsertDeleteEnabled):
        (WebCore::SVGEmptyEditorClient::isContinuousSpellCheckingEnabled):
        (WebCore::SVGEmptyEditorClient::toggleContinuousSpellChecking):
        (WebCore::SVGEmptyEditorClient::isGrammarCheckingEnabled):
        (WebCore::SVGEmptyEditorClient::toggleGrammarChecking):
        (WebCore::SVGEmptyEditorClient::spellCheckerDocumentTag):
        (WebCore::SVGEmptyEditorClient::selectWordBeforeMenuEvent):
        (WebCore::SVGEmptyEditorClient::isEditable):
        (WebCore::SVGEmptyEditorClient::shouldBeginEditing):
        (WebCore::SVGEmptyEditorClient::shouldEndEditing):
        (WebCore::SVGEmptyEditorClient::shouldInsertNode):
        (WebCore::SVGEmptyEditorClient::shouldInsertText):
        (WebCore::SVGEmptyEditorClient::shouldApplyStyle):
        (WebCore::SVGEmptyEditorClient::didBeginEditing):
        (WebCore::SVGEmptyEditorClient::respondToChangedContents):
        (WebCore::SVGEmptyEditorClient::didEndEditing):
        (WebCore::SVGEmptyEditorClient::registerCommandForUndo):
        (WebCore::SVGEmptyEditorClient::registerCommandForRedo):
        (WebCore::SVGEmptyEditorClient::clearUndoRedoOperations):
        (WebCore::SVGEmptyEditorClient::canUndo):
        (WebCore::SVGEmptyEditorClient::canRedo):
        (WebCore::SVGEmptyEditorClient::undo):
        (WebCore::SVGEmptyEditorClient::redo):
        (WebCore::SVGEmptyEditorClient::dataForArchivedSelection):
        (WebCore::SVGEmptyEditorClient::userVisibleString):
        (WebCore::SVGEmptyContextMenuClient::~SVGEmptyContextMenuClient):
        (WebCore::SVGEmptyContextMenuClient::contextMenuDestroyed):
        (WebCore::SVGEmptyContextMenuClient::addCustomContextMenuItems):
        (WebCore::SVGEmptyContextMenuClient::contextMenuItemSelected):
        (WebCore::SVGEmptyContextMenuClient::downloadURL):
        (WebCore::SVGEmptyContextMenuClient::copyImageToClipboard):
        (WebCore::SVGEmptyContextMenuClient::lookUpInDictionary):
        (WebCore::SVGEmptyContextMenuClient::speak):
        (WebCore::SVGEmptyContextMenuClient::stopSpeaking):
        (WebCore::SVGEmptyContextMenuClient::searchWithSpotlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-29 Eric Seidel <eric@eseidel.com>
eseidel [Fri, 29 Dec 2006 08:27:00 +0000 (08:27 +0000)]
2006-12-29  Eric Seidel  <eric@eseidel.com>

        Reviewed by olliej.

        Stop DumpRenderTree from reporting false Frame/Node leaks due to new SVGImage

        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree): clear WebCore cache before exiting

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Fri, 29 Dec 2006 08:15:53 +0000 (08:15 +0000)]
LayoutTests:

        Reviewed by NOBODY (build fix).

        Reverted last commit until WebResourceData issue is fixed.

        http://bugs.webkit.org/show_bug.cgi?id=11882
        Need a way to regression test .webarchive output files

        * webarchive/resources/apple.gif: Removed.
        * webarchive/resources/dump-webarchive.js: Removed.
        * webarchive/resources/test-frame.html: Removed.
        * webarchive/resources/test-style.css: Removed.
        * webarchive/test-body-background-expected.txt: Removed.
        * webarchive/test-body-background.html: Removed.
        * webarchive/test-duplicate-resources-expected.txt: Removed.
        * webarchive/test-duplicate-resources.html: Removed.
        * webarchive/test-frameset-expected.txt: Removed.
        * webarchive/test-frameset.html: Removed.
        * webarchive/test-img-src-expected.txt: Removed.
        * webarchive/test-img-src.html: Removed.
        * webarchive/test-input-src-expected.txt: Removed.
        * webarchive/test-input-src.html: Removed.
        * webarchive/test-link-href-expected.txt: Removed.
        * webarchive/test-link-href.html: Removed.
        * webarchive/test-object-data-expected.txt: Removed.
        * webarchive/test-object-data.html: Removed.
        * webarchive/test-script-src-expected.txt: Removed.
        * webarchive/test-script-src.html: Removed.
        * webarchive/test-table-background-expected.txt: Removed.
        * webarchive/test-table-background.html: Removed.
        * webarchive/test-td-background-expected.txt: Removed.
        * webarchive/test-td-background.html: Removed.

WebKitTools:

        Reviewed by NOBODY (build fix).

        Reverted last commit until WebResourceData issue is fixed.

        http://bugs.webkit.org/show_bug.cgi?id=11882
        Need a way to regression test .webarchive output files

        * DumpRenderTree/DumpRenderTree.m:
        (serializeWebArchiveToXML): Removed.
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpAsWebArchive]): Removed.
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMake redirects work.
staikos [Fri, 29 Dec 2006 05:50:43 +0000 (05:50 +0000)]
Make redirects work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ddkilzer [Fri, 29 Dec 2006 04:38:12 +0000 (04:38 +0000)]
LayoutTests:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11882
        Need a way to regression test .webarchive output files

        Created webarchive tests that exercise various features of the WebArchive format.

        * webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
        * webarchive/resources/dump-webarchive.js: Added.
        * webarchive/resources/test-frame.html: Added.
        * webarchive/resources/test-style.css: Added.
        * webarchive/test-body-background-expected.txt: Added.
        * webarchive/test-body-background.html: Added.
        * webarchive/test-duplicate-resources-expected.txt: Added.
        * webarchive/test-duplicate-resources.html: Added.
        * webarchive/test-frameset-expected.txt: Added.
        * webarchive/test-frameset.html: Added.
        * webarchive/test-img-src-expected.txt: Added.
        * webarchive/test-img-src.html: Added.
        * webarchive/test-input-src-expected.txt: Added.
        * webarchive/test-input-src.html: Added.
        * webarchive/test-link-href-expected.txt: Added.
        * webarchive/test-link-href.html: Added.
        * webarchive/test-object-data-expected.txt: Added.
        * webarchive/test-object-data.html: Added.
        * webarchive/test-script-src-expected.txt: Added.
        * webarchive/test-script-src.html: Added.
        * webarchive/test-table-background-expected.txt: Added.
        * webarchive/test-table-background.html: Added.
        * webarchive/test-td-background-expected.txt: Added.
        * webarchive/test-td-background.html: Added.

WebKitTools:

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11882
        Need a way to regression test .webarchive output files

        Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
        Saves WebArchive plist in xml format, then alters file:// URLs to remove path
        where WebKit was checked out.

        * DumpRenderTree/DumpRenderTree.m:
        (serializeWebArchiveToXML): Added.
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpAsWebArchive]): Added.
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt build. Reviewed by Olliej.
staikos [Fri, 29 Dec 2006 03:36:27 +0000 (03:36 +0000)]
Fix the Qt build.  Reviewed by Olliej.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver Hunt.
ggaren [Fri, 29 Dec 2006 03:09:49 +0000 (03:09 +0000)]
    Reviewed by Oliver Hunt.

        More cleanup. Layout tests pass.

        Use a helper function to initialize and access WebUndefined and WebScriptObject.

        * bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        (KJS::Bindings::webScriptObjectClass):
        (KJS::Bindings::webUndefinedClass):
        (convertValueToObjcObject):
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertValueToObjcValue):
        (KJS::Bindings::convertObjcValueToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-12-28 Daniel Molkentin <molkentin@kde.org>
eseidel [Fri, 29 Dec 2006 01:57:44 +0000 (01:57 +0000)]
2006-12-28  Daniel Molkentin <molkentin@kde.org>

        Reviewed by Eric Seidel <eric@webkit.org>

        - Fix font sizes
        - Make Qt plattform build again:
          - Adjust Qt platform to the Image class split.
          - Introduce BitmapImage class
          - add stub PDFDocumentImage class

        * WebCore.pro:
        * editing/qt/EditorQt.cpp:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        * loader/qt/FrameLoaderQt.cpp:
        (WebCore::FrameLoader::partClearedInBegin):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):
        (WebCore::BitmapImage::draw):
        (WebCore::BitmapImage::drawTiled):
        (WebCore::BitmapImage::checkForSolidColor):
        * platform/graphics/svg/SVGPaintServerLinearGradient.h:
        * platform/graphics/svg/SVGPaintServerRadialGradient.h:
        * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
        (WebCore::SVGPaintServerLinearGradient::setup):
        * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
        (WebCore::SVGPaintServerPattern::setup):
        * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
        (WebCore::SVGPaintServer::teardown):
        * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
        (WebCore::SVGPaintServerRadialGradient::setup):
        * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
        (WebCore::SVGPaintServerSolid::setup):
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::FrameQt):
        (WebCore::FrameQt::bindingRootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18463 268f45cc-cd09-0410-ab3c-d52691b4dbfc