WebKit-https.git
2 years agoUnreviewed, rolling out r221327.
ryanhaddad@apple.com [Wed, 30 Aug 2017 22:54:22 +0000 (22:54 +0000)]
Unreviewed, rolling out r221327.

This change caused test262 failures.

Reverted changeset:

"[JSC] Use reifying system for "name" property of builtin
JSFunction"
https://bugs.webkit.org/show_bug.cgi?id=175260
http://trac.webkit.org/changeset/221327

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cache API] Support cache names persistency
commit-queue@webkit.org [Wed, 30 Aug 2017 22:50:22 +0000 (22:50 +0000)]
[Cache API] Support cache names persistency
https://bugs.webkit.org/show_bug.cgi?id=175995

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-30
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/cache-storage/cache-persistency.https.html

Adding method to clear the memory representation of the cache storage.
Exposing it as internals so that layout tests can be used for testing persistency by combining clearing and private browsing mode.

Introducing ReadDisk and WriteDisk errors that are used by CacheStorage::Engine.

* Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::clearMemoryRepresentation):
* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::errorToException):
* Modules/cache/DOMCache.h:
* testing/Internals.cpp:
(WebCore::Internals::clearCacheStorageMemoryRepresentation):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

Adding disk read/write capacities to CacheStorage engine.
This is used to store per-origin cache names in a file.
Making Engine a thread safe refcounted object so that it does read/write in a background thread.

Introducing CacheStorage::Caches as the object managing the list of Cache objects for a given origin.
Caches will be responsible to do all the read/write operations for all of its caches.
It will be responsible for quota limitation as well.

Moving part of the logic from CacheStorage::Engine into CacheStorage::Caches.

CacheStorage::Engine is initialized asynchronously as it first creates a salt which is used
to obfuscate the names of the various files stored on disk.

In the same spirit, CacheStorage::Caches is initialized asynchronously as it needs to read from the disk the list of cache names.
Once read, the names will be stored in memory.
Added the possibility to clear this in-memory representation. This will be useful for testing.
This might also be useful to save memory when there is no more use of CacheStorage by web pages.

Introducing a new cacheStorageSubdirectoryName parameter for WebsiteDataStore so as to segment the different per session CacheStorageEngine
in direct sub folders of the main cacheStorageDirectory folder.

* CMakeLists.txt:
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::initialize):
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::cache):
(WebKit::CacheStorage::Engine::writeFile): Making use of default parameter to directly return to the main loop.
(WebKit::CacheStorage::Engine::readFile): Ditto.
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):
* NetworkProcess/cache/CacheStorageEngine.h:
(WebKit::CacheStorage::Engine::rootPath const):
(WebKit::CacheStorage::Engine::salt const):
(WebKit::CacheStorage::Engine::nextCacheIdentifier):
* NetworkProcess/cache/CacheStorageEngineCaches.cpp: Added.
(WebKit::CacheStorage::cachesRootPath):
(WebKit::CacheStorage::cachesListFilename):
(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::encodeCacheNames):
(WebKit::CacheStorage::decodeCachesNames):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::writeCachesToDisk):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):
(WebKit::CacheStorage::Caches::cacheInfos const):
* NetworkProcess/cache/CacheStorageEngineCaches.h: Added.
(WebKit::CacheStorage::Caches::create):
(WebKit::CacheStorage::Caches::isInitialized const):
(WebKit::CacheStorage::Caches::detach):
* NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::clearMemoryRepresentation):
* NetworkProcess/cache/CacheStorageEngineConnection.h:
* NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
* NetworkProcess/cache/NetworkCacheData.cpp:
(WebKit::NetworkCache::makeSalt):
* NetworkProcess/cache/NetworkCacheData.h:
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::clearMemoryRepresentation):
* WebProcess/Cache/WebCacheStorageConnection.h:

LayoutTests:

Putting these tests in http/tests folder so that they run in a different origin and so a different Caches than other tests.
Testing private browsing caching and clearing the memory representation would probably affect other cache+prviate browsing tests that would run in parallel.

* http/tests/cache-storage/cache-persistency.https-expected.txt: Added.
* http/tests/cache-storage/cache-persistency.https.html: Added.
* http/tests/cache-storage/resources/cache-persistency-iframe.html: Added.
* platform/ios-wk1/TestExpectations: Skipping new test on WK1.
* platform/mac-wk1/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r221384.
jlewis3@apple.com [Wed, 30 Aug 2017 22:48:08 +0000 (22:48 +0000)]
Unreviewed, rolling out r221384.

This patch caused multiple 32-bit JSC test failures.

Reverted changeset:

"Strings need to be in some kind of gigacage"
https://bugs.webkit.org/show_bug.cgi?id=174924
http://trac.webkit.org/changeset/221384

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSpeedometer 2.0: jQuery test fails occasionally
commit-queue@webkit.org [Wed, 30 Aug 2017 22:45:26 +0000 (22:45 +0000)]
Speedometer 2.0: jQuery test fails occasionally
https://bugs.webkit.org/show_bug.cgi?id=176017

Patch by Shiyu Zhang <shiyu.zhang@intel.com> on 2017-08-30
Reviewed by Ryosuke Niwa.

Create a dummy node to notify that app is ready for jQuery suite. It prevents Speedometer injecting items before app.js is loaded.

* Speedometer/resources/tests.js:
(Suites.push.prepare):
* Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
(jQuery.App.init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agosemicolon is being interpreted as an = in the LiteralParser
sbarati@apple.com [Wed, 30 Aug 2017 22:27:09 +0000 (22:27 +0000)]
semicolon is being interpreted as an = in the LiteralParser
https://bugs.webkit.org/show_bug.cgi?id=176114

Reviewed by Oliver Hunt.

JSTests:

* stress/jsonp-literal-parser-semicolon-is-not-assignment.js: Added.
* stress/resources/literal-parser-test-case.js: Added.

Source/JavaScriptCore:

When lexing a semicolon in the LiteralParser, we were properly
setting the TokenType on the current token, however, we were
*returning* the wrong TokenType. The lex function both returns
the TokenType and sets it on the current token. Semicolon was
setting the TokenType to semicolon, but returning the TokenType
for '='. This caused programs like `x;123` to be interpreted as
`x=123`.

* runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::next):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd "Identified" base class to replace a whole bunch of custom identifier generators.
beidson@apple.com [Wed, 30 Aug 2017 21:50:27 +0000 (21:50 +0000)]
Add "Identified" base class to replace a whole bunch of custom identifier generators.
https://bugs.webkit.org/show_bug.cgi?id=176120

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No behavior change).

Instead of repeating the common pattern of a class with an integer identifier keeping its
own static counter of the next identifier and generating it for each instance, this
uses a common template in WTF that does that automatically.

* Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionPendingCloseFromClient):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::confirmDidCloseFromServer):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didFireVersionChangeEvent):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didFinishHandlingVersionChange):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::establishTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):
(WebCore::IDBServer::nextDatabaseConnectionIdentifier): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::identifier const): Deleted.

* workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):
* workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):
(WebCore::ServiceWorkerJobData::identifier const): Deleted.

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::Connection):
* workers/service/server/SWServer.h:
(WebCore::SWServer::Connection::identifier const): Deleted.

* workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::SWServerRegistration):
(WebCore::SWServerRegistration::data const):
* workers/service/server/SWServerRegistration.h:
(WebCore::SWServerRegistration::identifier const): Deleted.

Source/WebKit:

* UIProcess/API/APIUserScript.cpp:
(API::UserScript::UserScript):
(API::generateIdentifier): Deleted.
* UIProcess/API/APIUserScript.h:

* UIProcess/API/APIUserStyleSheet.cpp:
(API::UserStyleSheet::UserStyleSheet):
(API::generateIdentifier): Deleted.
* UIProcess/API/APIUserStyleSheet.h:

* UIProcess/UserContent/WebScriptMessageHandler.cpp:
(WebKit::WebScriptMessageHandler::WebScriptMessageHandler):
(WebKit::generateIdentifier): Deleted.
* UIProcess/UserContent/WebScriptMessageHandler.h:
(WebKit::WebScriptMessageHandler::identifier const): Deleted.

* UIProcess/UserContent/WebUserContentControllerProxy.cpp:
(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::~WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::removeProcess):
(WebKit::WebUserContentControllerProxy::addUserContentWorldUse):
(WebKit::WebUserContentControllerProxy::removeUserContentWorldUses):
(WebKit::WebUserContentControllerProxy::addUserScript):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::addUserScriptMessageHandler):
(WebKit::WebUserContentControllerProxy::removeUserMessageHandlerForName):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
(WebKit::WebUserContentControllerProxy::addContentRuleList):
(WebKit::WebUserContentControllerProxy::removeContentRuleList):
(WebKit::WebUserContentControllerProxy::removeAllContentRuleLists):
(WebKit::generateIdentifier): Deleted.
* UIProcess/UserContent/WebUserContentControllerProxy.h:
(WebKit::WebUserContentControllerProxy::identifier const): Deleted.

* UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::~VisitedLinkStore):
(WebKit::VisitedLinkStore::VisitedLinkStore):
(WebKit::VisitedLinkStore::addProcess):
(WebKit::VisitedLinkStore::removeProcess):
(WebKit::VisitedLinkStore::removeAll):
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::sendTable):
(WebKit::generateIdentifier): Deleted.
* UIProcess/VisitedLinkStore.h:

* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::generateIdentifier): Deleted.
* UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::identifier const): Deleted.

* WebProcess/Network/WebSocketStream.cpp:
(WebKit::WebSocketStream::WebSocketStream):
(WebKit::WebSocketStream::~WebSocketStream):
(WebKit::WebSocketStream::messageSenderDestinationID):
* WebProcess/Network/WebSocketStream.h:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/Identified.h: Added.
(WTF::IdentifiedBase::identifier const):
(WTF::IdentifiedBase::IdentifiedBase):
(WTF::Identified::Identified):
(WTF::ThreadSafeIdentified::ThreadSafeIdentified):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate expectations for CSS regions tests after r220870.
pvollan@apple.com [Wed, 30 Aug 2017 21:36:04 +0000 (21:36 +0000)]
Update expectations for CSS regions tests after r220870.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove FetchRequest::InternalRequest
commit-queue@webkit.org [Wed, 30 Aug 2017 21:19:46 +0000 (21:19 +0000)]
Remove FetchRequest::InternalRequest
https://bugs.webkit.org/show_bug.cgi?id=176085

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-30
Reviewed by Alex Christensen.

No change of behavior.

Removing InternalRequest struct and passing/defining fields directly.

* Modules/cache/Cache.cpp:
(WebCore::Cache::updateRecords):
* Modules/fetch/FetchRequest.cpp:
(WebCore::computeReferrer):
(WebCore::buildOptions):
(WebCore::methodCanHaveBody):
(WebCore::FetchRequest::initializeOptions):
(WebCore::FetchRequest::initializeWith):
(WebCore::FetchRequest::setBody):
(WebCore::FetchRequest::create):
(WebCore::FetchRequest::referrer const):
(WebCore::FetchRequest::urlString const):
(WebCore::FetchRequest::resourceRequest const):
(WebCore::FetchRequest::clone):
(WebCore::setReferrer): Deleted.
* Modules/fetch/FetchRequest.h:
(WebCore::FetchRequest::FetchRequest):
(WebCore::FetchRequest::cache const):
(WebCore::FetchRequest::credentials const):
(WebCore::FetchRequest::destination const):
(WebCore::FetchRequest::mode const):
(WebCore::FetchRequest::redirect const):
(WebCore::FetchRequest::referrerPolicy const):
(WebCore::FetchRequest::type const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for FetchRequest.body
commit-queue@webkit.org [Wed, 30 Aug 2017 20:19:17 +0000 (20:19 +0000)]
Add support for FetchRequest.body
https://bugs.webkit.org/show_bug.cgi?id=176066
<rdar://problem/34148373>

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-30
Reviewed by Sam Weinig and Alex Christensen.

Follow-up to https://trac.webkit.org/r221329 as per post landing comments.
Returning a RefPtr<ReadableStream> so as to to not specialize ReadableStream converter.

* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::readableStream):
* Modules/fetch/FetchBodyOwner.h:
* bindings/js/ReadableStream.h:
(WebCore::toJS):
(WebCore::JSConverter<IDLInterface<ReadableStream>>::convert): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] Crash in MathML layout test.
pvollan@apple.com [Wed, 30 Aug 2017 20:01:10 +0000 (20:01 +0000)]
[Win] Crash in MathML layout test.
https://bugs.webkit.org/show_bug.cgi?id=176109

Reviewed by Brent Fulgham.

Return early if no font can be found for code point.

No new tests, covered by existing tests.

* rendering/mathml/MathOperator.cpp:
(WebCore::MathOperator::paintVerticalGlyphAssembly):
(WebCore::MathOperator::paintHorizontalGlyphAssembly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename ArrayLang to WebGPU Shading Language, or WSL for short, pronounced "whistle"
fpizlo@apple.com [Wed, 30 Aug 2017 19:46:32 +0000 (19:46 +0000)]
Rename ArrayLang to WebGPU Shading Language, or WSL for short, pronounced "whistle"
https://bugs.webkit.org/show_bug.cgi?id=176117

Reviewed by Myles Maxfield.

Renamed ArrayLangRI to WebGPUShadingLanguageRI.

Renamed ALSyntaxError/ALTypeError to WSyntaxError/WTypeError.

Renamed all references to "ArrayLang" in the code to "WSL".

* ArrayLangRI: Removed.
* ArrayLangRI/ALSyntaxError.js: Removed.
* ArrayLangRI/ALTypeError.js: Removed.
* ArrayLangRI/AddressSpace.js: Removed.
* ArrayLangRI/All.js: Removed.
* ArrayLangRI/ArrayRefType.js: Removed.
* ArrayLangRI/ArrayType.js: Removed.
* ArrayLangRI/Assignment.js: Removed.
* ArrayLangRI/Block.js: Removed.
* ArrayLangRI/CallAssignment.js: Removed.
* ArrayLangRI/CallExpression.js: Removed.
* ArrayLangRI/CallFunction.js: Removed.
* ArrayLangRI/Check.js: Removed.
* ArrayLangRI/Checker.js: Removed.
* ArrayLangRI/CommaExpression.js: Removed.
* ArrayLangRI/ConstexprTypeParameter.js: Removed.
* ArrayLangRI/EBuffer.js: Removed.
* ArrayLangRI/EBufferBuilder.js: Removed.
* ArrayLangRI/EFloat.js: Removed.
* ArrayLangRI/EInt.js: Removed.
* ArrayLangRI/EPtr.js: Removed.
* ArrayLangRI/EValue.js: Removed.
* ArrayLangRI/EvaluationCommon.js: Removed.
* ArrayLangRI/Evaluator.js: Removed.
* ArrayLangRI/Expression.js: Removed.
* ArrayLangRI/Field.js: Removed.
* ArrayLangRI/Func.js: Removed.
* ArrayLangRI/FuncDef.js: Removed.
* ArrayLangRI/FuncInstantiator.js: Removed.
* ArrayLangRI/FuncParameter.js: Removed.
* ArrayLangRI/FunctionLikeBlock.js: Removed.
* ArrayLangRI/Inline.js: Removed.
* ArrayLangRI/Inliner.js: Removed.
* ArrayLangRI/InstantiateImmediates.js: Removed.
* ArrayLangRI/IntLiteral.js: Removed.
* ArrayLangRI/Intrinsics.js: Removed.
* ArrayLangRI/Lexer.js: Removed.
* ArrayLangRI/LexerToken.js: Removed.
* ArrayLangRI/NameContext.js: Removed.
* ArrayLangRI/NameResolver.js: Removed.
* ArrayLangRI/NativeFunc.js: Removed.
* ArrayLangRI/NativeType.js: Removed.
* ArrayLangRI/NativeTypeInstance.js: Removed.
* ArrayLangRI/Node.js: Removed.
* ArrayLangRI/NullType.js: Removed.
* ArrayLangRI/Parse.js: Removed.
* ArrayLangRI/Prepare.js: Removed.
* ArrayLangRI/Program.js: Removed.
* ArrayLangRI/Protocol.js: Removed.
* ArrayLangRI/ProtocolDecl.js: Removed.
* ArrayLangRI/ProtocolRef.js: Removed.
* ArrayLangRI/PtrType.js: Removed.
* ArrayLangRI/ReferenceType.js: Removed.
* ArrayLangRI/ResolveNames.js: Removed.
* ArrayLangRI/ResolveOverloadImpl.js: Removed.
* ArrayLangRI/ResolveTypeDefs.js: Removed.
* ArrayLangRI/Return.js: Removed.
* ArrayLangRI/ReturnException.js: Removed.
* ArrayLangRI/Rewriter.js: Removed.
* ArrayLangRI/StandardLibrary.js: Removed.
* ArrayLangRI/StructType.js: Removed.
* ArrayLangRI/Substitution.js: Removed.
* ArrayLangRI/SuffixCallAssignment.js: Removed.
* ArrayLangRI/Test.js: Removed.
* ArrayLangRI/Type.js: Removed.
* ArrayLangRI/TypeDef.js: Removed.
* ArrayLangRI/TypeDefResolver.js: Removed.
* ArrayLangRI/TypeOrVariableRef.js: Removed.
* ArrayLangRI/TypeRef.js: Removed.
* ArrayLangRI/TypeVariable.js: Removed.
* ArrayLangRI/UnificationContext.js: Removed.
* ArrayLangRI/Value.js: Removed.
* ArrayLangRI/VariableDecl.js: Removed.
* ArrayLangRI/VariableRef.js: Removed.
* ArrayLangRI/VisitingSet.js: Removed.
* ArrayLangRI/Visitor.js: Removed.
* WebGPUShadingLanguageRI: Copied from Tools/ArrayLangRI.
* WebGPUShadingLanguageRI/ALSyntaxError.js: Removed.
* WebGPUShadingLanguageRI/ALTypeError.js: Removed.
* WebGPUShadingLanguageRI/All.js:
* WebGPUShadingLanguageRI/CallFunction.js:
(callFunctionByRef):
* WebGPUShadingLanguageRI/Checker.js:
(Checker.prototype.visitProtocolDecl.set throw):
* WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics.prototype.add):
(Intrinsics):
* WebGPUShadingLanguageRI/Lexer.js:
(Lexer):
* WebGPUShadingLanguageRI/NameContext.js:
(NameContext.prototype.add):
* WebGPUShadingLanguageRI/NameResolver.js:
(NameResolver.prototype._resolveTypeArguments):
(NameResolver.prototype.visitTypeRef):
(NameResolver.prototype.visitVariableRef):
* WebGPUShadingLanguageRI/Parse.js:
* WebGPUShadingLanguageRI/StandardLibrary.js:
* WebGPUShadingLanguageRI/StructType.js:
(StructType.prototype.add):
(StructType.prototype.instantiate):
* WebGPUShadingLanguageRI/TypeDefResolver.js:
(TypeDefResolver.prototype.visitTypeRef):
(TypeDefResolver):
* WebGPUShadingLanguageRI/VisitingSet.js:
(VisitingSet.prototype.doVisit):
(VisitingSet):
* WebGPUShadingLanguageRI/WSyntaxError.js: Copied from Tools/ArrayLangRI/ALSyntaxError.js.
(ALSyntaxError): Deleted.
* WebGPUShadingLanguageRI/WTypeError.js: Copied from Tools/ArrayLangRI/ALTypeError.js.
(ALTypeError): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoImplement all of "Register" right up until where the script is fetched.
beidson@apple.com [Wed, 30 Aug 2017 19:40:35 +0000 (19:40 +0000)]
Implement all of "Register" right up until where the script is fetched.
https://bugs.webkit.org/show_bug.cgi?id=176082

Reviewed by Andy Estes.

Source/WebCore:

Test: http/tests/workers/service/basic-register-exceptions.html

This patch implements every detail of the "Register" and "Update" algorithms right up to
where we would actually fetch the service worker script file.

It also includes miscellaneous refactoring and cleanup along the way.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsPotentiallyTrustworthy): Expose in the header for other files to use.
* page/SecurityOrigin.h:

* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration): Add some more exception cases from the spec.
(WebCore::ServiceWorkerContainer::scheduleJob): Use the correct job identifier.
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobDidFinish):
* workers/service/ServiceWorkerContainer.h:

* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException): Call through to the client to handle the failure.
(WebCore::ServiceWorkerJob::resolvedWithRegistration): Call through to the client to handle success.
* workers/service/ServiceWorkerJob.h:
(WebCore::ServiceWorkerJob::promise):
(WebCore::ServiceWorkerJob::identifier const): Deleted. Rely on the identifier from the JobData.

* workers/service/ServiceWorkerJobClient.h:

* workers/service/ServiceWorkerJobData.cpp:
(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):
* workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::identifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):
(WebCore::ServiceWorkerJobData::jobIdentifier const): Deleted.

* workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration): Make this class an ActiveDOMObject
  both because it *is* an active DOM object and because we need to get at the ScriptExecutionContext.
* workers/service/ServiceWorkerRegistration.h:

Add a class to encapsulate everything about a registration for encode/decode/crossthread:
* workers/service/ServiceWorkerRegistrationData.cpp:
(WebCore::ServiceWorkerRegistrationData::isolatedCopy const):
* workers/service/ServiceWorkerRegistrationData.h:
(WebCore::ServiceWorkerRegistrationData::encode const):
(WebCore::ServiceWorkerRegistrationData::decode):

* workers/service/ServiceWorkerRegistrationKey.cpp:
(WebCore::ServiceWorkerRegistrationKey::isolatedCopy const):
* workers/service/ServiceWorkerRegistrationKey.h:
(WebCore::ServiceWorkerRegistrationKey::encode const):
(WebCore::ServiceWorkerRegistrationKey::decode):

* workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::jobResolvedInServer):
* workers/service/server/SWClientConnection.h:

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveJob):
* workers/service/server/SWServer.h:

* workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::SWServerRegistration):
(WebCore::SWServerRegistration::startNextJob):
(WebCore::SWServerRegistration::isEmpty):
(WebCore::SWServerRegistration::getNewestWorker): Implement "Get Newest Worker" algorithm.
(WebCore::SWServerRegistration::runRegisterJob): Implement the rest of the "Register" algorithm.
(WebCore::SWServerRegistration::runUpdateJob): Implement every part of "Update" up to where we would fetch.
(WebCore::SWServerRegistration::rejectWithExceptionOnMainThread):
(WebCore::SWServerRegistration::resolveWithRegistrationOnMainThread):
(WebCore::SWServerRegistration::resolveCurrentJob):
(WebCore::SWServerRegistration::data const):
(WebCore::SWServerRegistration::performCurrentJob): Deleted.
* workers/service/server/SWServerRegistration.h:
(WebCore::SWServerRegistration::identifier const):

Add a stub class to represent "active service workers" in the SWServer:
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::~SWServerWorker):
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::scriptURL const):

Source/WebKit:

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::resolveJobInClient):
* StorageProcess/ServiceWorker/WebSWServerConnection.h:
* WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

* http/tests/workers/service/basic-register-exceptions-expected.txt: Added.
* http/tests/workers/service/basic-register-exceptions.html: Added.
* http/tests/workers/service/resources/basic-register-exceptions.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd Logger observer and helper class
eric.carlson@apple.com [Wed, 30 Aug 2017 19:06:49 +0000 (19:06 +0000)]
Add Logger observer and helper class
https://bugs.webkit.org/show_bug.cgi?id=176106

Reviewed by Andy Estes.

Source/WebCore/PAL:

* pal/Logger.h:
(PAL::LogArgument::toString): Add new variants.
(PAL::Logger::Observer::~Observer):
(PAL::Logger::logAlways const): Constify.
(PAL::Logger::error const): Ditto.
(PAL::Logger::warning const): Ditto.
(PAL::Logger::notice const): Ditto.
(PAL::Logger::info const): Ditto.
(PAL::Logger::debug const): Ditto.
(PAL::Logger::willLog const): Ditto.
(PAL::Logger::MethodAndPointer::MethodAndPointer): Add class name, make object pointer const.
(PAL::Logger::addObserver): New.
(PAL::Logger::removeObserver): New.
(PAL::Logger::Logger):
(PAL::Logger::log):
(PAL::Logger::observers):
(PAL::LogHelper::willLog const):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::LoggingTest::LoggingTest):
(TestWebKitAPI::LoggingTest::Logger::create):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::LogObserver::log):
(TestWebKitAPI::LogObserver::channel const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake][WinCairo] Use find_package for libpng and libjpeg
don.olmstead@sony.com [Wed, 30 Aug 2017 18:48:35 +0000 (18:48 +0000)]
[CMake][WinCairo] Use find_package for libpng and libjpeg
https://bugs.webkit.org/show_bug.cgi?id=176113

Reviewed by Alex Christensen.

.:

* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* PlatformWinCairo.cmake:
* platform/ImageDecoders.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoOpt all Mac clients into document-level media user gesture quirks.
mrajca@apple.com [Wed, 30 Aug 2017 18:45:15 +0000 (18:45 +0000)]
Opt all Mac clients into document-level media user gesture quirks.
https://bugs.webkit.org/show_bug.cgi?id=175831

Source/WebCore:

This un-breaks many of the sites that take a long time to load video ad elements on-demand.

Reviewed by Eric Carlson.

Test: media/document-level-media-user-gesture-quirk.html

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted const):
(WebCore::needsDocumentLevelMediaUserGestureQuirk): Deleted.

LayoutTests:

Reviewed by Eric Carlson.

* media/document-level-media-user-gesture-quirk-expected.txt: Added.
* media/document-level-media-user-gesture-quirk.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline js/dom/global-constructors-attributes.html for High Sierra after r221302.
jlewis3@apple.com [Wed, 30 Aug 2017 18:29:07 +0000 (18:29 +0000)]
Rebaseline js/dom/global-constructors-attributes.html for High Sierra after r221302.

Unreviewed test gardening.

* platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-highsierra-wk2/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoStrings need to be in some kind of gigacage
fpizlo@apple.com [Wed, 30 Aug 2017 17:46:55 +0000 (17:46 +0000)]
Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Reviewed by Oliver Hunt.
Source/bmalloc:

This adds a StringGigacage.

* bmalloc/Gigacage.cpp:
* bmalloc/Gigacage.h:
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::forEachKind):
* bmalloc/HeapKind.h:
(bmalloc::isGigacage):
(bmalloc::gigacageKind):
(bmalloc::heapKind):

Source/JavaScriptCore:

* runtime/JSString.cpp:
(JSC::JSRopeString::resolveRopeToAtomicString const):
(JSC::JSRopeString::resolveRope const):
* runtime/JSString.h:
(JSC::JSString::create):
(JSC::JSString::createHasOtherOwner):
* runtime/JSStringBuilder.h:
* runtime/VM.h:
(JSC::VM::gigacageAuxiliarySpace):

Source/WebCore:

No new tests because no new behavior.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::normalizeSpaces):

Source/WTF:

This makes all strings allocations come from the string gigacage. Because we expect string allocation
to be a hot path, I created specialized allocation paths for the string gigacage. These paths are
accessible via <wtf/text/StringMalloc.h>. However, those paths are equivalent to saying
Gigacage::malloc and friends with the Gigacage::String kind.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/Deque.h:
* wtf/FastMalloc.cpp:
(WTF::fastFree):
* wtf/FastMalloc.h:
(WTF::FastMalloc::malloc):
(WTF::FastMalloc::tryMalloc):
(WTF::FastMalloc::realloc):
(WTF::FastMalloc::free):
* wtf/Forward.h:
* wtf/Gigacage.cpp:
(Gigacage::tryMalloc):
* wtf/Gigacage.h:
(Gigacage::name):
* wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::deallocateBuffer):
(WTF::Malloc>::Vector):
(WTF::=):
(WTF::Malloc>::contains const):
(WTF::Malloc>::findMatching const):
(WTF::Malloc>::find const):
(WTF::Malloc>::reverseFind const):
(WTF::Malloc>::appendIfNotContains):
(WTF::Malloc>::fill):
(WTF::Malloc>::appendRange):
(WTF::Malloc>::expandCapacity):
(WTF::Malloc>::tryExpandCapacity):
(WTF::Malloc>::resize):
(WTF::Malloc>::resizeToFit):
(WTF::Malloc>::shrink):
(WTF::Malloc>::grow):
(WTF::Malloc>::asanSetInitialBufferSizeTo):
(WTF::Malloc>::asanSetBufferSizeToFullCapacity):
(WTF::Malloc>::asanBufferSizeWillChangeTo):
(WTF::Malloc>::reserveCapacity):
(WTF::Malloc>::tryReserveCapacity):
(WTF::Malloc>::reserveInitialCapacity):
(WTF::Malloc>::shrinkCapacity):
(WTF::Malloc>::append):
(WTF::Malloc>::tryAppend):
(WTF::Malloc>::constructAndAppend):
(WTF::Malloc>::tryConstructAndAppend):
(WTF::Malloc>::appendSlowCase):
(WTF::Malloc>::constructAndAppendSlowCase):
(WTF::Malloc>::tryConstructAndAppendSlowCase):
(WTF::Malloc>::uncheckedAppend):
(WTF::Malloc>::appendVector):
(WTF::Malloc>::insert):
(WTF::Malloc>::insertVector):
(WTF::Malloc>::remove):
(WTF::Malloc>::removeFirst):
(WTF::Malloc>::removeFirstMatching):
(WTF::Malloc>::removeAll):
(WTF::Malloc>::removeAllMatching):
(WTF::Malloc>::reverse):
(WTF::Malloc>::map const):
(WTF::Malloc>::releaseBuffer):
(WTF::Malloc>::checkConsistency):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::removeRepeatedElements):
(WTF::minCapacity>::Vector): Deleted.
(WTF::minCapacity>::contains const): Deleted.
(WTF::minCapacity>::findMatching const): Deleted.
(WTF::minCapacity>::find const): Deleted.
(WTF::minCapacity>::reverseFind const): Deleted.
(WTF::minCapacity>::appendIfNotContains): Deleted.
(WTF::minCapacity>::fill): Deleted.
(WTF::minCapacity>::appendRange): Deleted.
(WTF::minCapacity>::expandCapacity): Deleted.
(WTF::minCapacity>::tryExpandCapacity): Deleted.
(WTF::minCapacity>::resize): Deleted.
(WTF::minCapacity>::resizeToFit): Deleted.
(WTF::minCapacity>::shrink): Deleted.
(WTF::minCapacity>::grow): Deleted.
(WTF::minCapacity>::asanSetInitialBufferSizeTo): Deleted.
(WTF::minCapacity>::asanSetBufferSizeToFullCapacity): Deleted.
(WTF::minCapacity>::asanBufferSizeWillChangeTo): Deleted.
(WTF::minCapacity>::reserveCapacity): Deleted.
(WTF::minCapacity>::tryReserveCapacity): Deleted.
(WTF::minCapacity>::reserveInitialCapacity): Deleted.
(WTF::minCapacity>::shrinkCapacity): Deleted.
(WTF::minCapacity>::append): Deleted.
(WTF::minCapacity>::tryAppend): Deleted.
(WTF::minCapacity>::constructAndAppend): Deleted.
(WTF::minCapacity>::tryConstructAndAppend): Deleted.
(WTF::minCapacity>::appendSlowCase): Deleted.
(WTF::minCapacity>::constructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::tryConstructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::uncheckedAppend): Deleted.
(WTF::minCapacity>::appendVector): Deleted.
(WTF::minCapacity>::insert): Deleted.
(WTF::minCapacity>::insertVector): Deleted.
(WTF::minCapacity>::remove): Deleted.
(WTF::minCapacity>::removeFirst): Deleted.
(WTF::minCapacity>::removeFirstMatching): Deleted.
(WTF::minCapacity>::removeAll): Deleted.
(WTF::minCapacity>::removeAllMatching): Deleted.
(WTF::minCapacity>::reverse): Deleted.
(WTF::minCapacity>::map const): Deleted.
(WTF::minCapacity>::releaseBuffer): Deleted.
(WTF::minCapacity>::checkConsistency): Deleted.
* wtf/text/AtomicStringImpl.h:
* wtf/text/CString.cpp:
(WTF::CStringBuffer::createUninitialized):
* wtf/text/CString.h:
* wtf/text/StringBuffer.h:
(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::~StringBuffer):
(WTF::StringBuffer::resize):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::destroy):
(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::releaseAssertCaged const):
* wtf/text/StringImpl.h:
(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::bufferOwnership const):
(WTF::StringImpl::assertCaged const):
* wtf/text/StringMalloc.cpp: Added.
(WTF::tryStringMalloc):
(WTF::stringMalloc):
(WTF::stringRealloc):
(WTF::stringFree):
* wtf/text/StringMalloc.h: Added.
(WTF::StringMalloc::malloc):
(WTF::StringMalloc::tryMalloc):
(WTF::StringMalloc::realloc):
(WTF::StringMalloc::free):
* wtf/text/StringVector.h: Added.
* wtf/text/SymbolImpl.h:
* wtf/text/UniquedStringImpl.h:
* wtf/text/WTFString.h:
(WTF::String::adopt):
(WTF::String::assertCaged const):
(WTF::String::releaseAssertCaged const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoVersioning.
jmarcell@apple.com [Wed, 30 Aug 2017 17:42:41 +0000 (17:42 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK test gardening.
commit-queue@webkit.org [Wed, 30 Aug 2017 17:42:39 +0000 (17:42 +0000)]
Unreviewed GTK test gardening.
https://bugs.webkit.org/show_bug.cgi?id=176111

Patch by Alicia Boya GarcĂ­a <aboya@igalia.com> on 2017-08-30

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] Upstream Accessibility-related WebKitSystemInterface functions
aestes@apple.com [Wed, 30 Aug 2017 17:37:43 +0000 (17:37 +0000)]
[Mac] Upstream Accessibility-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176093

Reviewed by Eric Carlson.

Source/WebCore:

* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]):
(AXObjectIsTextMarker):
(AXObjectIsTextMarkerRange):
(AXTextMarkerRange):
(AXTextMarkerRangeStart):
(AXTextMarkerRangeEnd):
(getBytesFromAXTextMarker):
(isTextMarkerIgnored):
(accessibilityObjectForTextMarker):
(startOrEndTextmarkerForRange):
(nextTextMarkerForCharacterOffset):
(previousTextMarkerForCharacterOffset):
(textMarkerForCharacterOffset):
(characterOffsetForTextMarker):
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper textMarkerForFirstPositionInTextControl:]):
(visiblePositionForTextMarker):
(AXAttributeStringSetElement):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/mac/HIServicesSPI.h: Added.
* pal/spi/mac/NSAccessibilitySPI.h:

Source/WebKit:

* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setAccessibilityWebProcessToken):
(WebKit::WebViewImpl::updateRemoteAccessibilityRegistration):
(WebKit::WebViewImpl::accessibilityRegisterUIProcessTokens):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoInitial reference implementation scaffolding for ArrayLang
fpizlo@apple.com [Wed, 30 Aug 2017 17:33:26 +0000 (17:33 +0000)]
Initial reference implementation scaffolding for ArrayLang
https://bugs.webkit.org/show_bug.cgi?id=175925

Reviewed by Myles Maxfield.

This introduces a very rough scaffolding for an AST walk interpreter and type checker for an
experimental shader language we are calling ArrayLang for now.

The idea is to have a strong core type system that includes generics and memory-safe pointers
and array references. Everything has deterministic semantics right up to the limit of what is
portably possible.

This language will support generics. This will be valid:

protocol Addable { Addable operator+(Addable, Addable); }
T add<T:Addable>(T a, T b) { return a + b; }

This language will support pointers and array references. This will be valid:

thread int^ foo() { int x; return \x; }

Each variable behaves as if it was declared "static", with one copy per type instantiation.
Functions cannot recurse and there is no stack.

Currently, this just tests that the following function can be parsed, checked, and called:

int foo(int x) { return x + 1; }

* ArrayLangRI: Added.
* ArrayLangRI/ALSyntaxError.js: Added.
(ALSyntaxError):
* ArrayLangRI/ALTypeError.js: Added.
(ALTypeError):
* ArrayLangRI/AddressSpace.js: Added.
(isAddressSpace):
(validateAddressSpace):
* ArrayLangRI/All.js: Added.
* ArrayLangRI/ArrayRefType.js: Added.
(ArrayRefType.prototype.unifyImpl):
(ArrayRefType.prototype.toString):
(ArrayRefType):
* ArrayLangRI/ArrayType.js: Added.
(ArrayType):
(ArrayType.prototype.get origin):
(ArrayType.prototype.get elementType):
(ArrayType.prototype.get numElements):
(ArrayType.prototype.get isPrimitive):
(ArrayType.prototype.toString):
(ArrayType.prototype.get size):
(ArrayType.prototype.unifyImpl):
* ArrayLangRI/Assignment.js: Added.
(Assignment):
(Assignment.prototype.get lhs):
(Assignment.prototype.get rhs):
(Assignment.prototype.toString):
* ArrayLangRI/Block.js: Added.
(Block):
(Block.prototype.get origin):
(Block.prototype.add):
(Block.prototype.get statements):
(Block.prototype.toString):
* ArrayLangRI/CallAssignment.js: Added.
(CallAssignment):
(CallAssignment.prototype.get name):
(CallAssignment.prototype.get lhs):
(CallAssignment.prototype.get rhs):
(CallAssignment.prototype.toString):
* ArrayLangRI/CallExpression.js: Added.
(CallExpression):
(CallExpression.prototype.get name):
(CallExpression.prototype.get typeArguments):
(CallExpression.prototype.get argumentList):
(CallExpression.prototype.toString):
* ArrayLangRI/CallFunction.js: Added.
(callFunctionByRef):
(callFunction):
* ArrayLangRI/Check.js: Added.
(check):
* ArrayLangRI/Checker.js: Added.
(Checker):
(Checker.prototype.visitProgram):
(Checker.prototype.visitProtocolDecl.NoticeTypeVariable.prototype.visitTypeRef):
(Checker.prototype.visitProtocolDecl.NoticeTypeVariable.prototype.visitVariableRef):
(Checker.prototype.visitProtocolDecl.NoticeTypeVariable):
(Checker.prototype.visitProtocolDecl.set throw):
* ArrayLangRI/CommaExpression.js: Added.
(CommaExpression):
(CommaExpression.prototype.get list):
(CommaExpression.prototype.toString):
* ArrayLangRI/ConstexprTypeParameter.js: Added.
(ConstexprTypeParameter):
(ConstexprTypeParameter.prototype.get name):
(ConstexprTypeParameter.prototype.get type):
(ConstexprTypeParameter.prototype.get isConstexpr):
(ConstexprTypeParameter.prototype.get isUnifiable):
(ConstexprTypeParameter.prototype.typeVariableUnify):
(ConstexprTypeParameter.prototype.unifyImpl):
(ConstexprTypeParameter.prototype.verifyAsArgument):
(ConstexprTypeParameter.prototype.verifyAsParameter):
(ConstexprTypeParameter.prototype.toString):
* ArrayLangRI/EBuffer.js: Added.
(EBuffer):
(EBuffer.get index):
* ArrayLangRI/EBufferBuilder.js: Added.
(EBufferBuilder):
(EBufferBuilder.prototype._createEPtr):
(EBufferBuilder.prototype.visitFuncParameter):
* ArrayLangRI/EFloat.js: Added.
(EFloat):
(EFloat.prototype.get value):
(EFloat.prototype.add):
(EFloat.prototype.toString):
* ArrayLangRI/EInt.js: Added.
(EInt):
(EInt.prototype.get value):
(EInt.prototype.add):
(EInt.prototype.toString):
* ArrayLangRI/EPtr.js: Added.
(EPtr):
(EPtr.box):
(EPtr.prototype.get buffer):
(EPtr.prototype.get offset):
(EPtr.prototype.loadValue):
(EPtr.prototype.copyFrom):
(EPtr.prototype.toString):
* ArrayLangRI/EValue.js: Added.
(EValue):
(EValue.prototype.get type):
* ArrayLangRI/EvaluationCommon.js: Added.
* ArrayLangRI/Evaluator.js: Added.
(Evaluator):
(Evaluator.prototype.visitFunctionBody):
(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitReturn):
(Evaluator.prototype.visitCommaExpression):
(Evaluator.prototype.visitVariableRef):
(Evaluator.prototype.visitIntLiteral):
(Evaluator.prototype.visitCallExpression):
* ArrayLangRI/Expression.js: Added.
(Expression):
(Expression.prototype.get origin):
* ArrayLangRI/Field.js: Added.
(Field):
(Field.prototype.get origin):
(Field.prototype.get name):
(Field.prototype.get type):
(Field.prototype.toString):
* ArrayLangRI/Func.js: Added.
(Func):
(Func.prototype.get name):
(Func.prototype.get returnType):
(Func.prototype.get typeParameters):
(Func.prototype.get parameters):
(Func.prototype.get parameterTypes):
(Func.prototype.get kind):
(Func.prototype.toString):
* ArrayLangRI/FuncDef.js: Added.
(FuncDef):
(FuncDef.prototype.get origin):
(FuncDef.prototype.toString):
* ArrayLangRI/FuncInstantiator.js: Added.
(FuncInstantiator):
(FuncInstantiator.prototype.getUnique):
* ArrayLangRI/FuncParameter.js: Added.
(FuncParameter):
(FuncParameter.prototype.get origin):
(FuncParameter.prototype.get name):
(FuncParameter.prototype.get type):
(FuncParameter.prototype.toString):
* ArrayLangRI/FuncSignature.js: Added.
* ArrayLangRI/FunctionLikeBlock.js: Added.
(FunctionLikeBlock):
(FunctionLikeBlock.prototype.get origin):
(FunctionLikeBlock.prototype.get argumentList):
(FunctionLikeBlock.prototype.get parameters):
(FunctionLikeBlock.prototype.get body):
(FunctionLikeBlock.prototype.toString):
* ArrayLangRI/Inline.js: Added.
(inline):
(_inlineFunction):
(resolveInlinedFunction):
* ArrayLangRI/Inliner.js: Added.
(Inliner):
(Inliner.prototype.visitCallExpression):
* ArrayLangRI/InstantiateImmediates.js: Added.
(InstantiateImmediates.prototype.visitTypeRef):
(InstantiateImmediates.prototype.visitReferenceType):
(InstantiateImmediates.prototype.visitStructType):
(InstantiateImmediates.prototype.visitNativeType):
(InstantiateImmediates.prototype.visitTypeVariable):
(InstantiateImmediates):
* ArrayLangRI/IntLiteral.js: Added.
(IntLiteral):
(IntLiteral.prototype.get value):
(IntLiteral.prototype.get isConstexpr):
(IntLiteral.prototype.toString):
* ArrayLangRI/Intrinsics.js: Added.
(Intrinsics):
(Intrinsics.prototype.add):
* ArrayLangRI/Lexer.js: Added.
(Lexer):
(Lexer.prototype.get lineNumber):
(Lexer.prototype.get origin):
(Lexer.prototype.get originString):
(Lexer.prototype.lineNumberForIndex):
(Lexer.prototype.get state):
(Lexer.prototype.set state):
(Lexer.prototype.next):
* ArrayLangRI/LexerToken.js: Added.
(LexerToken):
(LexerToken.prototype.get kind):
(LexerToken.prototype.get text):
(LexerToken.prototype.get origin):
(LexerToken.prototype.get index):
(LexerToken.prototype.get lineNumber):
(LexerToken.prototype.get originString):
(LexerToken.prototype.toString):
* ArrayLangRI/NameContext.js: Added.
(isWildcardKind):
(NameContext):
(NameContext.prototype.mapFor):
(NameContext.prototype.add):
(NameContext.get currentStatement):
(NameContext.get intrinsics):
(NameContext.set program):
(NameContext.get program):
(NameContext.prototype.get let):
* ArrayLangRI/NameResolver.js: Added.
(NameResolver):
(NameResolver.prototype.visitProgram):
(NameResolver.prototype._visitTypeParametersAndBuildNameContext):
(NameResolver.prototype.visitFunc):
(NameResolver.prototype.visitFuncDef):
(NameResolver.prototype.visitBlock):
(NameResolver.prototype.visitProtocolDecl):
(NameResolver.prototype.visitTypeDef):
(NameResolver.prototype.visitStructType):
(NameResolver.prototype._resolveTypeArguments):
(NameResolver.prototype.visitTypeRef):
(NameResolver.prototype.visitReferenceType):
(NameResolver.prototype.visitVariableRef):
(NameResolver.prototype.visitReturn):
(NameResolver.prototype.visitCallExpression):
* ArrayLangRI/NativeFunc.js: Added.
(NativeFunc):
(NativeFunc.prototype.get origin):
(NativeFunc.prototype.get isNative):
(NativeFunc.prototype.toString):
* ArrayLangRI/NativeType.js: Added.
(NativeType):
(NativeType.prototype.get origin):
(NativeType.prototype.get name):
(NativeType.prototype.get isPrimitive):
(NativeType.prototype.get typeParameters):
(NativeType.prototype.get isNative):
(NativeType.prototype.instantiate):
(NativeType.prototype.toString):
* ArrayLangRI/NativeTypeInstance.js: Added.
(NativeTypeInstance):
(NativeTypeInstance.prototype.get type):
(NativeTypeInstance.prototype.get typeArguments):
(NativeTypeInstance.prototype.get isPrimitive):
(NativeTypeInstance.prototype.get isNative):
(NativeTypeInstance.prototype.unifyImpl):
(NativeTypeInstance.prototype.toString):
* ArrayLangRI/Node.js: Added.
(Node.prototype.visit):
(Node.unify):
(Node.prototype.unifyImpl):
(Node.prototype.typeVariableUnify):
(Node.prototype.get unifyNode):
(Node.prototype.get isUnifiable):
(Node.prototype.get isNative):
(Node.prototype.equals):
(Node.prototype.substitute):
(Node.prototype.substituteToUnification):
(Node):
* ArrayLangRI/NullType.js: Added.
(NullType):
* ArrayLangRI/Parse.js: Added.
(genericConsume):
(consume):
(genericTest):
(test):
(tryConsumeKind):
(parseProtocolRef):
(consumeEndOfTypeArgs):
(parseTypeParameters):
(parseTerm):
(parseConstexpr):
(parseTypeArguments):
(parseType.getAddressSpace):
(parseType):
(parseTypeDef):
(parseNative):
(genericParseLeft):
(parseLeftOperatorCall):
(parsePossibleSuffix):
(parsePossiblePrefix):
(parsePossibleProduct):
(parsePossibleSum):
(parsePossibleShift):
(parsePossibleRelationalInequality):
(parsePossibleRelationalEquality):
(parsePossibleBitwiseXor):
(parsePossibleBitwiseOr):
(parseLeftLogicalExpression):
(parsePossibleLogicalOr):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(parseAssignment):
(parseEffectfulExpression):
(genericParseCommaExpression):
(parseCommaExpression):
(parseExpression):
(parseEffectfulStatement):
(parseReturn):
(parseVariableDecls):
(parseStatement):
(parseBlock):
(parseParameter):
(parseFuncName):
(parseFuncDef):
(parse):
* ArrayLangRI/Prepare.js: Added.
(prepare):
* ArrayLangRI/Program.js: Added.
(Program):
(Program.prototype.get topLevelStatements):
(Program.prototype.get functions):
(Program.prototype.get types):
(Program.prototype.get funcInstantiator):
(Program.prototype.add):
(Program.prototype.resolveFuncOverload):
(Program.prototype.get nameContext):
(Program.prototype.toString):
* ArrayLangRI/Protocol.js: Added.
(Protocol):
(Protocol.prototype.get origin):
(Protocol.prototype.get name):
(Protocol.prototype.get kind):
(Protocol.prototype.toString):
* ArrayLangRI/ProtocolDecl.js: Added.
(ProtocolDecl):
(ProtocolDecl.prototype.addSignature):
(ProtocolDecl.prototype.get signatures):
(ProtocolDecl.prototype.signaturesByName):
(ProtocolDecl.prototype.get typeVariable):
(ProtocolDecl.prototype.signaturesByNameWithTypeVariable):
(ProtocolDecl.prototype.inherits):
(ProtocolDecl.prototype.hasHeir):
(ProtocolDecl.prototype.toString):
* ArrayLangRI/ProtocolRef.js: Added.
(ProtocolRef):
(ProtocolRef.prototype.inherits):
(ProtocolRef.prototype.hasHeir):
* ArrayLangRI/PtrType.js: Added.
(PtrType.prototype.unifyImpl):
(PtrType.prototype.toString):
(PtrType):
* ArrayLangRI/ReferenceType.js: Added.
(ReferenceType):
(ReferenceType.prototype.get origin):
(ReferenceType.prototype.get addressSpace):
(ReferenceType.prototype.get elementType):
(ReferenceType.prototype.get isPrimitive):
(ReferenceType.prototype.get size):
* ArrayLangRI/ResolveNames.js: Added.
(resolveNames):
* ArrayLangRI/ResolveOverloadImpl.js: Added.
(resolveOverloadImpl):
* ArrayLangRI/ResolveTypeDefs.js: Added.
(resolveTypeDefs):
* ArrayLangRI/Return.js: Added.
(Return):
(Return.prototype.get origin):
(Return.prototype.get value):
(Return.prototype.toString):
* ArrayLangRI/ReturnException.js: Added.
(ReturnException):
(ReturnException.prototype.get value):
* ArrayLangRI/Rewriter.js: Added.
(Rewriter):
(Rewriter.prototype._map):
(Rewriter.prototype._getMapping):
(Rewriter.prototype.visitFunc):
(Rewriter.prototype.visitFuncParameter):
(Rewriter.prototype.visitBlock):
(Rewriter.prototype.visitCommaExpression):
(Rewriter.prototype.visitProtocolRef):
(Rewriter.prototype.visitTypeRef):
(Rewriter.prototype.visitTypeVariable):
(Rewriter.prototype.visitConstexprTypeParameter):
(Rewriter.prototype.visitField):
(Rewriter.prototype.visitReferenceType):
(Rewriter.visitPtrType):
(Rewriter.prototype.visitArrayRefType):
(Rewriter.prototype.visitArrayType):
(Rewriter.prototype.visitAssignment):
(Rewriter.prototype.visitVariableRef):
(Rewriter.prototype.visitReturn):
(Rewriter.prototype.visitIntLiteral):
(Rewriter.prototype.visitCallExpression):
(Rewriter.prototype.visitFunctionLikeBlock):
* ArrayLangRI/StandardLibrary.js: Added.
* ArrayLangRI/StructType.js: Added.
(StructType):
(StructType.prototype.add):
(StructType.prototype.get name):
(StructType.prototype.get typeParameters):
(StructType.prototype.get fieldNames):
(StructType.prototype.fieldByName):
(StructType.prototype.get fields):
(StructType.prototype.get fieldMap):
(StructType.prototype.get isPrimitive):
(StructType.prototype.instantiate):
(StructType.prototype.toString):
* ArrayLangRI/Substitution.js: Added.
(Substitution):
(Substitution.mapping):
(Substitution.prototype.visitTypeRef):
(Substitution.prototype.visitVariableRef):
* ArrayLangRI/SuffixCallAssignment.js: Added.
(SuffixCallAssignment):
(SuffixCallAssignment.prototype.get name):
(SuffixCallAssignment.prototype.get lhs):
(SuffixCallAssignment.prototype.toString):
* ArrayLangRI/Test.js: Added.
(load):
* ArrayLangRI/Type.js: Added.
(Type.prototype.get typeParameters):
(Type.prototype.get kind):
(Type.prototype.inherits):
(Type.prototype.get instantiatedType):
(Type):
* ArrayLangRI/TypeDef.js: Added.
(TypeDef):
(TypeDef.prototype.get origin):
(TypeDef.prototype.get name):
(TypeDef.prototype.get typeParameters):
(TypeDef.prototype.get type):
* ArrayLangRI/TypeDefResolver.js: Added.
(TypeDefResolver):
(TypeDefResolver.prototype.visitTypeRef):
* ArrayLangRI/TypeOrVariableRef.js: Added.
(TypeOrVariableRef):
(TypeOrVariableRef.prototype.get origin):
(TypeOrVariableRef.prototype.get name):
(TypeOrVariableRef.prototype.toString):
* ArrayLangRI/TypeRef.js: Added.
(TypeRef):
(TypeRef.wrap):
(TypeRef.prototype.get origin):
(TypeRef.prototype.get name):
(TypeRef.prototype.get typeArguments):
(TypeRef.prototype.get isPrimitive):
(TypeRef.prototype.get instantiatedType):
(TypeRef.prototype.get unifyNode):
(TypeRef.prototype.populateDefaultValue):
(TypeRef.prototype.get size):
(TypeRef.prototype.setTypeAndArguments):
(TypeRef.prototype.unifyImpl):
(TypeRef.prototype.toString):
* ArrayLangRI/TypeVariable.js: Added.
(TypeVariable):
(TypeVariable.prototype.get name):
(TypeVariable.prototype.get protocol):
(TypeVariable.prototype.get isPrimitive):
(TypeVariable.prototype.get isUnifiable):
(TypeVariable.prototype.inherits):
(TypeVariable.prototype.typeVariableUnify):
(TypeVariable.prototype.unifyImpl):
(TypeVariable.prototype.verifyAsArgument):
(TypeVariable.prototype.verifyAsParameter):
(TypeVariable.prototype.toString):
* ArrayLangRI/UnificationContext.js: Added.
(UnificationContext):
(UnificationContext.prototype.union):
(UnificationContext.prototype.find):
(UnificationContext.prototype.get nodes):
(UnificationContext.prototype.verify):
(UnificationContext.prototype.isUnunified):
* ArrayLangRI/Value.js: Added.
(Value.prototype.get kind):
(Value.prototype.get isConstexpr):
(Value):
* ArrayLangRI/VariableDecl.js: Added.
(VariableDecl):
(VariableDecl.prototype.get origin):
(VariableDecl.prototype.get name):
(VariableDecl.prototype.get type):
(VariableDecl.prototype.get initializer):
(VariableDecl.prototype.toString):
* ArrayLangRI/VariableRef.js: Added.
(VariableRef):
(VariableRef.prototype.get name):
(VariableRef.prototype.get isConstexpr):
(VariableRef.prototype.get unifyNode):
(VariableRef.prototype.toString):
* ArrayLangRI/VisitingSet.js: Added.
(VisitingSet):
(VisitingSet.prototype.doVisit):
* ArrayLangRI/Visitor.js: Added.
(Visitor.prototype.visitProgram):
(Visitor.prototype.visitFunc):
(Visitor.prototype.visitFuncParameter):
(Visitor.prototype.visitFuncDef):
(Visitor.prototype.visitNativeFunc):
(Visitor.prototype.visitBlock):
(Visitor.prototype.visitCommaExpression):
(Visitor.prototype.visitProtocolRef):
(Visitor.prototype.visitProtocolDecl):
(Visitor.prototype.visitTypeRef):
(Visitor.prototype.visitNativeType):
(Visitor.prototype.visitTypeDef):
(Visitor.prototype.visitStructType):
(Visitor.prototype.visitTypeVariable):
(Visitor.prototype.visitConstexprTypeParameter):
(Visitor.prototype.visitField):
(Visitor.prototype.visitElementalType):
(Visitor.prototype.visitPtrType):
(Visitor.prototype.visitArrayRefType):
(Visitor.prototype.visitArrayType):
(Visitor.prototype.visitAssignment):
(Visitor.prototype.visitVariableRef):
(Visitor.prototype.visitReturn):
(Visitor.prototype.visitIntLiteral):
(Visitor.prototype.visitCallExpression):
(Visitor.prototype.visitFunctionLikeBlock):
(Visitor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRenderMultiColumnFlowThread - Avoid render tree mutation during layout
antti@apple.com [Wed, 30 Aug 2017 17:28:10 +0000 (17:28 +0000)]
RenderMultiColumnFlowThread - Avoid render tree mutation during layout
https://bugs.webkit.org/show_bug.cgi?id=176026
<rdar://problem/33402891>

Reviewed by Zalan Bujtas.

Source/WebCore:

Mutations should be done in RenderTreeUpdater.

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):

    Don't create columns for RenderSVGBlock. Before this patch this was avoided because it
    has custom layout() function that doesn't call to setComputedColumnCountAndWidth.
    Same for mathml and ruby.

    Don't create columns for pseudo elements (first-letter mostly).

(WebCore::RenderBlockFlow::setComputedColumnCountAndWidth):

    This now assumes that the multicolumn renderer has been initialized correctly already.

* rendering/RenderBlockFlow.h:
* style/RenderTreeUpdater.cpp:
(WebCore::updateMultiColumnFlowThread):

    Create or delte multicolumn renderer after descendants are known.

(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

LayoutTests:

* imported/blink/fast/pagination/first-letter-inherit-all-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCreation of missing expectation folders and rebaseline for js/dom/global-constructors...
jlewis3@apple.com [Wed, 30 Aug 2017 17:25:48 +0000 (17:25 +0000)]
Creation of missing expectation folders and rebaseline for js/dom/global-constructors-attributes-expected.txt after r221302.

* platform/mac-sierra-wk2/js/dom/global-constructors-attributes-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThe SVG fragment identifier is not respected if it is a part of an HTTP URL
commit-queue@webkit.org [Wed, 30 Aug 2017 17:20:26 +0000 (17:20 +0000)]
The SVG fragment identifier is not respected if it is a part of an HTTP URL
https://bugs.webkit.org/show_bug.cgi?id=163811

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-30
Reviewed by Darin Adler.

Source/WebCore:

If an image is referenced more than once in a page and the URL to that
image is an HTTP URL, one CachedImage is created for all the renderers
even if the original URLs have different fragmentIdentifiers. In this
case the fragment will be removed from the request which is associated
with the shared CachedImage. This CachedImage creates an SVGImage with
a URL but without a fragmentIdentifier. So SVGImage::draw() does not call
FrameView::scrollToFragment() and therefore the viewport is not setup
correctly for displaying the SVG in this case.

The fix is to move the url from the SVGImage to SVGImageForContainer.
Because there is one SVGImageForContainer created for every renderer,
we can move the full URL there. The drawing of an SVGImage has to start
from the SVGImageForContainer::draw() because the SVGImage may not have
an intrinsic size and the SVGImageForContainer is the one which knows
the destination rectangle. So SVGImageForContainer can pass the full url
to SVGImage::drawForContainer() which can be used to scrollToFragment()
before calling SVGImage::draw().

For clarity and consistency, all setContainerSizeForRenderer() will be
changed to setContainerContext() and the pair SizeAndZoom will be replaced
by the struct ContainerContext.

Tests: http/tests/svg/svg-fragment-background.html
       http/tests/svg/svg-fragment-image.html

* css/CSSCursorImageValue.h:
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
* css/CSSImageSetValue.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::switchClientsToRevalidatedResource):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::setContainerContextForClient):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::setContainerSizeForRenderer): Deleted.
* loader/cache/CachedImage.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry const):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::repaintOrMarkForLayout):
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setContainerContext):
(WebCore::RenderImageResource::setContainerSizeForRenderer): Deleted.
* rendering/RenderImageResource.h:
* rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::setContainerContext):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Deleted.
* rendering/RenderImageResourceStyleImage.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage const):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::imageURL):
(WebCore::StyleCachedImage::setContainerContextForRenderer):
(WebCore::StyleCachedImage::setContainerSizeForRenderer): Deleted.
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
* svg/SVGImageElement.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::SVGImage):
(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dump const): Deleted.
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerContextForClient):
(WebCore::SVGImageCache::setContainerSizeForRenderer): Deleted.
* svg/graphics/SVGImageCache.h:
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::size const):
(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):
* svg/graphics/SVGImageForContainer.h:

LayoutTests:

* http/tests/svg/resources/rgb-icons-1.svg: Added.
* http/tests/svg/resources/rgb-icons-2.svg: Added.
* http/tests/svg/resources/rgb-icons-3.svg: Added.
* http/tests/svg/svg-fragment-background-expected.html: Added.
* http/tests/svg/svg-fragment-background.html: Added.
* http/tests/svg/svg-fragment-image-expected.html: Added.
* http/tests/svg/svg-fragment-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win][JSCOnly] Support running JSC tests for win-cairo from windows command prompt
commit-queue@webkit.org [Wed, 30 Aug 2017 17:18:09 +0000 (17:18 +0000)]
[Win][JSCOnly] Support running JSC tests for win-cairo from windows command prompt
https://bugs.webkit.org/show_bug.cgi?id=174985

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-30
Reviewed by Keith Miller.

* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc-stress-tests:
* Scripts/webkitruby/jsc-stress-test-writer-default.rb:
* Scripts/webkitruby/jsc-stress-test-writer-ruby.rb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThe test imported/w3c/web-platform-tests/dom/traversal/NodeFilter-constants.html...
pvollan@apple.com [Wed, 30 Aug 2017 15:35:42 +0000 (15:35 +0000)]
The test imported/w3c/web-platform-tests/dom/traversal/NodeFilter-constants.html is slow on Windows.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThe test imported/w3c/web-platform-tests/encoding/api-basics.html is slow on Windows.
pvollan@apple.com [Wed, 30 Aug 2017 15:27:16 +0000 (15:27 +0000)]
The test imported/w3c/web-platform-tests/encoding/api-basics.html is slow on Windows.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Enable MEMORY_SAMPLER
clopez@igalia.com [Wed, 30 Aug 2017 15:06:43 +0000 (15:06 +0000)]
[WPE] Enable MEMORY_SAMPLER
https://bugs.webkit.org/show_bug.cgi?id=176099

Reviewed by Michael Catanzaro.

.:

Enable the otion at build time by default on Linux (currently
there are only Linux and Mac implementations of this feature).

* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsGTK.cmake:

Source/WebKit:

Enable it at runtime if the environment variable WEBKIT_SAMPLE_MEMORY is set.

* UIProcess/API/wpe/WPEView.cpp:
(WKWPE::m_compositingManagerProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Do not use autogen whenever possible in JHBuild modules
aperez@igalia.com [Wed, 30 Aug 2017 13:22:25 +0000 (13:22 +0000)]
[GTK] Do not use autogen whenever possible in JHBuild modules
https://bugs.webkit.org/show_bug.cgi?id=176098

Reviewed by Carlos Alberto Lopez Perez.

* gtk/jhbuild.modules: Added autogen-sh="configure" attributes for many Autootools modules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Avoid building fontconfig documentation in jhbuild
tpopela@redhat.com [Wed, 30 Aug 2017 12:48:56 +0000 (12:48 +0000)]
[GTK] Avoid building fontconfig documentation in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=176097

Reviewed by Carlos Alberto Lopez Perez.

Disable building fontconfig documentation in jhbuild as it needs the
docbook-utils-pdf package installed which depends on quite a few
packages (on Fedora it's 226 packages (mostly textlive) with installed
size of 274 MB). The documentation is not needed at all in jhbuild, so
disable it to save some bandwidth and disc space.

* gtk/install-dependencies: Pass --disable-docs to fontconfig.
* gtk/jhbuild.modules: Don't install docbook-utils-pdf on Fedora.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, remove trailing space
tpopela@redhat.com [Wed, 30 Aug 2017 11:41:36 +0000 (11:41 +0000)]
Unreviewed, remove trailing space

* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix versions numbers after r221136.
carlosgc@webkit.org [Wed, 30 Aug 2017 11:07:10 +0000 (11:07 +0000)]
Unreviewed. Fix versions numbers after r221136.

We normally use .0 in trunk after branching, and bump to .1 when making the first unstable release. We also need
to bump the library version.

* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[ESNext] Async iteration - Implement async iteration statement: for-await-of
gskachkov@gmail.com [Wed, 30 Aug 2017 09:51:45 +0000 (09:51 +0000)]
[ESNext] Async iteration - Implement async iteration statement: for-await-of
https://bugs.webkit.org/show_bug.cgi?id=166698

Reviewed by Yusuke Suzuki.

JSTests:

* stress/async-iteration-for-await-of-syntax.js: Added.
(assert):
(checkSyntax):
(checkSyntaxError):
(checkSimpleAsyncGeneratorSloppyMode):
(checkSimpleAsyncGeneratorStrictMode):
(checkNestedAsyncGenerators):
(checkSimpleAsyncGeneratorSyntaxErrorInStrictMode):
* stress/async-iteration-for-await-of.js: Added.
(assert):
(async.foo):
(async.boo):
(const.boo.async):

Source/JavaScriptCore:

Implementation of the for-await-of statement.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorNext):
* bytecompiler/BytecodeGenerator.h:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createForOfLoop):
* parser/NodeConstructors.h:
(JSC::ForOfNode::ForOfNode):
* parser/Nodes.h:
(JSC::ForOfNode::isForAwait const):
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseForStatement):
* parser/Parser.h:
(JSC::Scope::setSourceParseMode):
(JSC::Scope::setIsFunction):
(JSC::Scope::setIsAsyncGeneratorFunction):
(JSC::Scope::setIsAsyncGeneratorFunctionBody):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForOfLoop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] Upstream Carbon-related WebKitSystemInterface functions
aestes@apple.com [Wed, 30 Aug 2017 08:59:10 +0000 (08:59 +0000)]
[Mac] Upstream Carbon-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176087

Reviewed by Alex Christensen.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/cocoa/FoundationSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
* pal/spi/mac/HIToolboxSPI.h: Copied from Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h.
* pal/spi/mac/NSEventSPI.h:
* pal/spi/mac/NSWindowSPI.h:
* pal/spi/mac/QuickDrawSPI.h: Added.

Source/WebKit:

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::cgWindowID):
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::scriptCodeFromCurrentKeyboardInputSource):
(WebKit::NetscapePlugin::sendComplexTextInput):

Source/WebKitLegacy:

* WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

* Carbon/CarbonUtils.m:
(getNSAutoreleasePoolCount):
(WebInitForCarbon):
(PoolCleaner):
* Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter frameViewClassForStyleMask:]):
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
(-[CarbonWindowAdapter _oldPlaceWindow:]):
(-[CarbonWindowAdapter _windowMovedToRect:]):
* Carbon/HIViewAdapter.m:
* Carbon/HIWebView.mm:
(Draw):
(CreateNSEventAdoptingCGEvent):
(CopyEventCGEvent):
(CreateNSEventWithCarbonClickEvent):
(Click):
(CreateNSEventWithCarbonEvent):
(MouseUp):
(CreateNSEventWithCarbonMouseMoveEvent):
(MouseMoved):
(MouseDragged):
(MouseWheelMoved):
(WindowHandler):
(HIWebViewEventHandler):
* Misc/QuickDrawCompatibility.h: Removed.
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(getCarbonEvent):
(WebNetscapePluginEventHandlerCarbon::keyDown):
(WebNetscapePluginEventHandlerCarbon::keyUp):
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::keyDown):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView tellQuickTimeToChill]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Try to fix layout test timing out after r221344.
carlosgc@webkit.org [Wed, 30 Aug 2017 08:40:17 +0000 (08:40 +0000)]
Unreviewed. Try to fix layout test timing out after r221344.

There seems to be an infinite loop in the web process when WebPage::platformEditorState is called with non
content editable result.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformEditorState const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Add layout tests covering EC P-521
zandobersek@gmail.com [Wed, 30 Aug 2017 07:31:32 +0000 (07:31 +0000)]
[WebCrypto] Add layout tests covering EC P-521
https://bugs.webkit.org/show_bug.cgi?id=175659

Reviewed by Jiewen Tan.

Add layout tests that cover operations with 521-bit elliptic curves.
The newly-introduced tests are skipped on all platforms for now since
no implementation provides support just yet. The already-existing tests
are modified in a way that only tests the EC P-521 capability optionally,
if e.g. P-521 key imports are successful, without affecting the tests for
P-256 and P-384 operations.

The newly-introduced tests are mirros of existing P-256 and P-384 tests,
but they specifically test the P-521 capabilities and use appropriate
curve information (X and Y coordinates for the EC public key, D for the
EC private key) for that type of elliptic curve.

* crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p521-expected.txt: Added.
* crypto/subtle/ec-import-pkcs8-key-export-pkcs8-key-p521.html: Added.
* crypto/subtle/ec-import-spki-key-export-spki-key-p521-expected.txt: Added.
* crypto/subtle/ec-import-spki-key-export-spki-key-p521.html: Added.
* crypto/subtle/ecdh-derive-bits-length-limits-expected.txt:
* crypto/subtle/ecdh-derive-bits-length-limits.html:
* crypto/subtle/ecdh-generate-export-jwk-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-generate-export-jwk-key-p521.html: Added.
* crypto/subtle/ecdh-generate-export-key-pkcs8-p521-expected.txt: Added.
* crypto/subtle/ecdh-generate-export-key-pkcs8-p521.html: Added.
* crypto/subtle/ecdh-generate-export-key-raw-p521-expected.txt: Added.
* crypto/subtle/ecdh-generate-export-key-raw-p521.html: Added.
* crypto/subtle/ecdh-generate-export-key-spki-p521-expected.txt: Added.
* crypto/subtle/ecdh-generate-export-key-spki-p521.html: Added.
* crypto/subtle/ecdh-generate-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-generate-key-p521.html: Added.
* crypto/subtle/ecdh-import-jwk-private-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-import-jwk-private-key-p521.html: Added.
* crypto/subtle/ecdh-import-jwk-public-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-import-jwk-public-key-p521.html: Added.
* crypto/subtle/ecdh-import-pkcs8-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Added.
* crypto/subtle/ecdh-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html: Added.
* crypto/subtle/ecdh-import-pkcs8-key-p521.html: Added.
* crypto/subtle/ecdh-import-raw-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-import-raw-key-p521.html: Added.
* crypto/subtle/ecdh-import-spki-key-ecdh-identifier-expected.txt:
* crypto/subtle/ecdh-import-spki-key-ecdh-identifier.html:
* crypto/subtle/ecdh-import-spki-key-p521-expected.txt: Added.
* crypto/subtle/ecdh-import-spki-key-p521.html: Added.
* crypto/subtle/ecdsa-generate-key-sign-verify-p521-expected.txt: Added.
* crypto/subtle/ecdsa-generate-key-sign-verify-p521.html: Added.
* crypto/subtle/ecdsa-import-jwk-public-key-alg-521-expected.txt: Added.
* crypto/subtle/ecdsa-import-jwk-public-key-alg-521.html: Added.
* crypto/subtle/ecdsa-import-key-sign-p521-expected.txt: Added.
* crypto/subtle/ecdsa-import-key-sign-p521.html: Added.
* crypto/subtle/ecdsa-import-key-verify-p521-expected.txt: Added.
* crypto/subtle/ecdsa-import-key-verify-p521.html: Added.
* crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey-expected.txt: Added.
* crypto/subtle/ecdsa-import-pkcs8-key-p521-validate-ecprivatekey-parameters-publickey.html: Added.
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r221064): [GTK] Editor not correctly working after r221064
carlosgc@webkit.org [Wed, 30 Aug 2017 06:59:57 +0000 (06:59 +0000)]
REGRESSION(r221064): [GTK] Editor not correctly working after r221064
https://bugs.webkit.org/show_bug.cgi?id=176052

Reviewed by Michael Catanzaro.

Source/WebKit:

Since r221064 we are not always notified about typing attributes when editor state changes. didChangeSelection
no longer includes the typing attributes in EditorStateChange message, it's scheduled to be sent after the
compositing layer have been flushed, but that part is not implemented for GTK+ port.

Fixes test /webkit2/WebKitWebView/editor-state/typing-attributes.

* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::updateBackingStoreState): Call WebPage::flushPendingEditorStateUpdate() after
the layout.
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired): Call WebPage::flushPendingEditorStateUpdate() after
the display sync.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display): Call WebPage::flushPendingEditorStateUpdate() after the layout.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformEditorState const): Also return early, setting isMissingPostLayoutData to true, when
there's no frame view, the view needs a layout or the result is not for editable content.

Tools:

Run the test inside a window to ensure display updates happen.

* TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
(testWebViewEditorEditorStateTypingAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r210287) On drop, event.dataTransfer.getData("text") returns an empty...
wenson_hsieh@apple.com [Wed, 30 Aug 2017 05:09:23 +0000 (05:09 +0000)]
REGRESSION(r210287) On drop, event.dataTransfer.getData("text") returns an empty string when dragging an image
https://bugs.webkit.org/show_bug.cgi?id=170637
<rdar://problem/31347248>

Reviewed by Ryosuke Niwa.

Source/WebCore:

In r210287, the behavior of DragData::containsFiles was changed to return true if NSFilesPromisePboardType is
present in the pasteboard. This means that we will consider images dragged from web content, for which we add
the NSFilesPromisePboardType UTI, as containing files on the pasteboard; this, in turn, means we'll initialize
the DataTransfer upon drop with m_forFileDrag set to true. Due to early returns in getData() and setData() to
deny data access when dropping a dragged file, this means the page won't ever get access to the URL in the
pasteboard due to the presence of the NSFilesPromisePboardType UTI.

To fix this, we replace the early m_forFileDrag returns in getData and setData, instead early returning the null
string if there are any file URLs present on the pasteboard (determined via readFilenames() retrieving a non-
empty result).

Test: editing/pasteboard/drag-drop-href-as-text-data.html

* dom/DataTransfer.cpp:
(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::getData const):
(WebCore::DataTransfer::setData):

Rather than bail upon forFileDrag() (formerly, m_forFileDrag) being true, bail if there are any file URLs
present on the pasteboard. It seems like this was the intention of the early return in the first place, to
prevent the page from being able to ask for a real file URL when dragging a file.

(WebCore::DataTransfer::files const):
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::setDropEffect):
(WebCore::DataTransfer::setEffectAllowed):

Swap m_forDrag and m_forFileDrag with forDrag() and forFileDrag(), respectively.

* dom/DataTransfer.h:
(WebCore::DataTransfer::forDrag const):
(WebCore::DataTransfer::forFileDrag const):

Instead of caching two bools to represent state (m_forDrag and m_forFileDrag), just remember the DataTransfer's
m_type and turn the flags into const helpers that check for the value of m_type.

LayoutTests:

Adds a new test to verify that upon dropping an image enclosed within an anchor, DataTransfer.getData() can be
used to grab the href of the enclosing anchor.

* TestExpectations:
* editing/pasteboard/drag-drop-href-as-text-data-expected.txt: Added.
* editing/pasteboard/drag-drop-href-as-text-data.html: Added.
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Fetch API] Request should throw when keep alive is true and body is a ReadableStream
commit-queue@webkit.org [Wed, 30 Aug 2017 04:32:49 +0000 (04:32 +0000)]
[Fetch API] Request should throw when keep alive is true and body is a ReadableStream
https://bugs.webkit.org/show_bug.cgi?id=176083

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/request/request-keepalive-expected.txt:

Source/WebCore:

Covered by rebased test.

* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r221317.
commit-queue@webkit.org [Wed, 30 Aug 2017 04:20:45 +0000 (04:20 +0000)]
Unreviewed, rolling out r221317.
https://bugs.webkit.org/show_bug.cgi?id=176090

"It broke a testing mode because we will never FTL compile a
function that repeatedly throws" (Requested by saamyjoon on
#webkit).

Reverted changeset:

"Throwing an exception in the DFG/FTL should not be a
jettison-able OSR exit"
https://bugs.webkit.org/show_bug.cgi?id=176060
http://trac.webkit.org/changeset/221317

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Use find_package for zlib
don.olmstead@sony.com [Wed, 30 Aug 2017 04:07:50 +0000 (04:07 +0000)]
[CMake] Use find_package for zlib
https://bugs.webkit.org/show_bug.cgi?id=176075

Reviewed by Alex Christensen.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformAppleWin.cmake:
* PlatformMac.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Xcode] Fix up file and group paths in PAL.xcodeproj
aestes@apple.com [Wed, 30 Aug 2017 04:07:39 +0000 (04:07 +0000)]
[Xcode] Fix up file and group paths in PAL.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=176073

Reviewed by Alex Christensen.

* PAL.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Critical content browser toolbar buttons are hidden at narrow widths
mattbaker@apple.com [Wed, 30 Aug 2017 04:04:02 +0000 (04:04 +0000)]
Web Inspector: Critical content browser toolbar buttons are hidden at narrow widths
https://bugs.webkit.org/show_bug.cgi?id=175999

Reviewed by Devin Rousso.

This patch adds a VisibilityPriority concept to NavigationItems. If a
NavigationBar cannot fit all of its items in the available space, items
are hidden to make room, starting with the lowest priority item. Consecutive
dividers are then collapsed, as well as leading and trailing dividers.

* UserInterface/Main.html:
New file.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
* UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer):
* UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser):
* UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView):
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
Set `High` and `Low` priorities, and group the back/forward buttons.

* UserInterface/Views/GroupNavigationItem.js: Added.
(WI.GroupNavigationItem):
(WI.GroupNavigationItem.prototype.get navigationItems):
(WI.GroupNavigationItem.prototype.get minimumWidth):
(WI.GroupNavigationItem.prototype.updateLayout):
(WI.GroupNavigationItem.prototype.didAttach):
(WI.GroupNavigationItem.prototype.didDetach):
NavigationItem groups. Grouped items are shown/hidden together.

* UserInterface/Views/HierarchicalPathNavigationItem.js:
(WI.HierarchicalPathNavigationItem.prototype.updateLayout):
* UserInterface/Views/ImageResourceContentView.js:
(WI.ImageResourceContentView):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
(WI.IndexedDatabaseObjectStoreContentView):
* UserInterface/Views/LogContentView.js:
(WI.LogContentView):
Set `High` and `Low` priorities.

* UserInterface/Views/NavigationBar.css:
(.navigation-bar .item.force-hidden):
New hidden class, which must be tracked separately from ".hidden".
The former is an implementation detail of NavigationBar, while the
latter is set by the client.

* UserInterface/Views/NavigationBar.js:
(WI.NavigationBar.prototype.insertNavigationItem):
(WI.NavigationBar.prototype.removeNavigationItem):
(WI.NavigationBar.prototype.findNavigationItem.matchingSelfOrChild):
(WI.NavigationBar.prototype.findNavigationItem):
(WI.NavigationBar.prototype.layout.forceItemHidden):
(WI.NavigationBar.prototype.layout.isDivider):
(WI.NavigationBar.prototype.layout.calculateVisibleItemWidth):
(WI.NavigationBar.prototype.layout):
(WI.NavigationBar.prototype._calculateMinimumWidth):
(WI.NavigationBar.prototype.get _visibleNavigationItems):
(WI.NavigationBar):

* UserInterface/Views/NavigationItem.js:
Add support for visibility priority, an integer value that determines the
order in which items are hidden when the NavigationBar becomes too narrow
to fit all of items child items. NavigationIte3m defines constants for
Low, Normal (the default), and High priority.

(WI.NavigationItem):
(WI.NavigationItem.prototype.get minimumWidth):
(WI.NavigationItem.prototype.get width):
(WI.NavigationItem.prototype.get visibilityPriority):
(WI.NavigationItem.prototype.set visibilityPriority):
(WI.NavigationItem.prototype.updateLayout):
(WI.NavigationItem.prototype.didAttach):
(WI.NavigationItem.prototype.didDetach):
Encapsulate the setting of the parent NavigationBar. Needed so that
GroupNavigationItem can forward this action to its children.

* UserInterface/Views/NetworkGridContentView.js:
(WI.NetworkGridContentView):
* UserInterface/Views/RadioButtonNavigationItem.js:
(WI.RadioButtonNavigationItem.prototype.updateLayout):
* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
* UserInterface/Views/ScriptContentView.js:
(WI.ScriptContentView):
* UserInterface/Views/TextContentView.js:
(WI.TextContentView):
* UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView):
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView):
Set `High` and `Low` priorities, and group Timeline view mode buttons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoResourceLoadStatistics logic does not understand custom WebsiteData stores
bfulgham@apple.com [Wed, 30 Aug 2017 02:54:31 +0000 (02:54 +0000)]
ResourceLoadStatistics logic does not understand custom WebsiteData stores
https://bugs.webkit.org/show_bug.cgi?id=176037
<rdar://problem/33338238>

Reviewed by Alex Christensen.

Source/WebKit:

The NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains always notifies the default website
data store about observations it has made. This should be revised so that WebKit clients that register
custom data stores through the WKWebsiteDataStores API can be assured that observations made in one session
do not manipulate data from another session.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Use the passed sessionID to locate
the correct NetworkStorageSession to notify about the new partitioning data.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in: Accept new argument.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Include the WebsiteDataStore's
session ID in the message to update cookie partition data.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
(TEST): Update for ResourceLoadStatistics directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCallTracingCallback should ignore `readonly attribute`
webkit@devinrousso.com [Wed, 30 Aug 2017 02:40:03 +0000 (02:40 +0000)]
CallTracingCallback should ignore `readonly attribute`
https://bugs.webkit.org/show_bug.cgi?id=176070

Reviewed by Matt Baker.

Source/WebCore:

Update existing tests to remove calls to existing readonly attributes.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
If the attribute is marked `readonly` do not add logic for the `CallTracingCallback`.

* bindings/scripts/test/TestCallTracer.idl:
* bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::JSTestCallTracerConstructor::initializeProperties):
(WebCore::jsTestCallTracerTestReadonlyAttributeGetter):
(WebCore::jsTestCallTracerTestReadonlyAttribute):

LayoutTests:

* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-2d.html:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl.html:
Remove calls to existing readonly attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAssertion failure when opening a file with a missing tag closing bracket
commit-queue@webkit.org [Wed, 30 Aug 2017 02:26:42 +0000 (02:26 +0000)]
Assertion failure when opening a file with a missing tag closing bracket
https://bugs.webkit.org/show_bug.cgi?id=176061

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-29
Reviewed by Darin Adler.

Source/WebCore:

If a tag is missing its closing bracket, the tokenizer just needs to advance()
the character position without checking m_currentCharacter != '\n'. Newline
character is a valid ending for partially closed tags.

Test: fast/tokenizer/missing-script-tag-closing-bracket.html

* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::commitToPartialEndTag):

LayoutTests:

* fast/tokenizer/missing-script-tag-closing-bracket-expected.txt: Added.
* fast/tokenizer/missing-script-tag-closing-bracket.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRename "potentionally trustworthy" to "potentially trustworthy"
beidson@apple.com [Wed, 30 Aug 2017 02:13:19 +0000 (02:13 +0000)]
Rename "potentionally trustworthy" to "potentially trustworthy"
https://bugs.webkit.org/show_bug.cgi?id=176081

Reviewed by Daniel Bates.

Source/WebCore:

The Secure Context spec refers to this as "potentially trustworthy"

It's possible that this was done potentionally, but we should follow the spec to alleviate confusion.

* dom/Document.cpp:
(WebCore::Document::isSecureContext const):
* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsPotentiallyTrustworthy):
(WebCore::shouldTreatAsPotentionallyTrustworthy): Deleted.
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::isPotentiallyTrustworthy const):
(WebCore::SecurityOrigin::isPotentionallyTrustworthy const): Deleted.
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::isSecureContext const):

Tools:

* TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAutomatically determine if a class has a modern decoder
commit-queue@webkit.org [Wed, 30 Aug 2017 01:38:32 +0000 (01:38 +0000)]
Automatically determine if a class has a modern decoder
https://bugs.webkit.org/show_bug.cgi?id=176084

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-29
Reviewed by Sam Weinig.

Instead of determining if ModernDecoder is defined in the class,
just check the signature of the decode member function.

* Platform/IPC/ArgumentCoder.h:
(): Deleted.
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.h:
* Shared/WebsitePolicies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r220235): Web Inspector: Global search should not happen incrementally
commit-queue@webkit.org [Wed, 30 Aug 2017 01:29:25 +0000 (01:29 +0000)]
REGRESSION(r220235): Web Inspector: Global search should not happen incrementally
https://bugs.webkit.org/show_bug.cgi?id=176063

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-29
Reviewed by Devin Rousso.

* UserInterface/Base/Main.js:
(WI.contentLoaded):
* UserInterface/Views/SearchBar.js:
(WI.SearchBar):
(WI.SearchBar.prototype._handleKeydownEvent):
Remove delegate and simplify setting incremental.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win][JSCOnly] Fix call for updating wincairo-libs in build-jsc
commit-queue@webkit.org [Wed, 30 Aug 2017 01:27:18 +0000 (01:27 +0000)]
[Win][JSCOnly] Fix call for updating wincairo-libs in build-jsc
https://bugs.webkit.org/show_bug.cgi?id=176080

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-29
Reviewed by Brent Fulgham.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Use table based approach for JSON.stringify's Quote
utatane.tea@gmail.com [Wed, 30 Aug 2017 01:22:33 +0000 (01:22 +0000)]
[JSC] Use table based approach for JSON.stringify's Quote
https://bugs.webkit.org/show_bug.cgi?id=176044

Reviewed by Darin Adler.

We change escape operation of JSON Quote from branch-based to table-based.
This patch partially adopts SpiderMonkey's change to StringBuilderJSON.cpp
to optimize this escaping operation. We separate changes from StringBuilder.cpp
to apply MPL to StringBuilderJSON.cpp file. Since WebKit already adopts MPL in
some files (like, DateMath.h), it is acceptable.

Kraken json-stringify-tinderbox shows 7.2% improvement.

                                   baseline                  patched

json-stringify-tinderbox        40.429+-0.771      ^      37.693+-0.862         ^ definitely 1.0726x faster

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/StringBuilder.cpp:
(WTF::appendQuotedJSONStringInternalSlow): Deleted.
(WTF::appendQuotedJSONStringInternal): Deleted.
(WTF::StringBuilder::appendQuotedJSONString): Deleted.
* wtf/text/StringBuilderJSON.cpp: Added.
(WTF::appendQuotedJSONStringInternal):
(WTF::StringBuilder::appendQuotedJSONString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd support for FetchRequest.body
commit-queue@webkit.org [Wed, 30 Aug 2017 00:39:26 +0000 (00:39 +0000)]
Add support for FetchRequest.body
https://bugs.webkit.org/show_bug.cgi?id=176066

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/fetch/api/request/request-disturbed-expected.txt:
* web-platform-tests/fetch/api/request/request-idl-expected.txt:

Source/WebCore:

Covered by existing tests.

Adding support for body attribute getter for FetchRequest.
To do so, FetchRequest will need to create a ReadableStream.
Adding support for DOM based creation of ReadableStream and conversion to JS values.
Small refactoring to make names more consistent.

* CMakeLists.txt:
* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
* Modules/cache/Cache.cpp:
(WebCore::Cache::put):
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::extract):
* Modules/fetch/FetchBody.h:
(WebCore::FetchBody::hasReadableStream const):
(WebCore::FetchBody::readableStream):
(WebCore::FetchBody::setReadableStream):
(WebCore::FetchBody::FetchBody):
(WebCore::FetchBody::isReadableStream const): Deleted.
(WebCore::FetchBody::setAsReadableStream): Deleted.
* Modules/fetch/FetchBody.idl:
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::readableStream):
* Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::hasReadableStreamBody const):
(WebCore::FetchBodyOwner::isReadableStreamBody const): Deleted.
* Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::setBody):
* Modules/fetch/FetchRequest.h:
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::setBodyAsReadableStream):
(WebCore::FetchResponse::fetch):
* Modules/fetch/FetchResponse.h:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ReadableStream.h:
(WebCore::JSConverter<IDLInterface<ReadableStream>>::convert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[DFG] Add constant folding rule to convert CompareStrictEq(Untyped, Untyped [with...
utatane.tea@gmail.com [Wed, 30 Aug 2017 00:29:39 +0000 (00:29 +0000)]
[DFG] Add constant folding rule to convert CompareStrictEq(Untyped, Untyped [with non string cell constant]) to CompareEqPtr(Untyped)
https://bugs.webkit.org/show_bug.cgi?id=175895

Reviewed by Saam Barati.

We have `bucket === @sentinelMapBucket` code in builtin. Since @sentinelMapBucket and bucket
are MapBucket cell (SpecCellOther), we do not have any good fixup for CompareStrictEq.
But rather than introducing a special fixup edge (like, NonStringCellUse), converting
CompareStrictEq(Untyped, Untyped) to CompareEqPtr is simpler.
In constant folding phase, we convert CompareStrictEq(Untyped, Untyped) to CompareEqPtr(Untyed)
if one side of the children is constant non String cell.

This slightly optimizes map/set iteration.

set-for-each          4.5064+-0.3072     ^      3.2862+-0.2098        ^ definitely 1.3713x faster
large-map-iteration  56.2583+-1.6640           53.6798+-2.0097          might be 1.0480x faster
set-for-of            8.8058+-0.5953     ^      7.5832+-0.3805        ^ definitely 1.1612x faster
map-for-each          4.2633+-0.2694     ^      3.3967+-0.3013        ^ definitely 1.2551x faster
map-for-of           13.1556+-0.5707           12.4911+-0.6004          might be 1.0532x faster

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToCompareEqPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Use reifying system for "name" property of builtin JSFunction
utatane.tea@gmail.com [Wed, 30 Aug 2017 00:06:43 +0000 (00:06 +0000)]
[JSC] Use reifying system for "name" property of builtin JSFunction
https://bugs.webkit.org/show_bug.cgi?id=175260

Reviewed by Saam Barati.

JSTests:

* stress/accessors-get-set-prefix.js:
* stress/builtin-function-name.js: Added.
(shouldBe):
(shouldThrow):
(shouldBe.JSON.stringify.Object.getOwnPropertyDescriptor):
(shouldBe.JSON.stringify.Object.getOwnPropertyNames.Array.prototype.filter.sort):

Source/JavaScriptCore:

Currently builtin JSFunction uses direct property for "name", which is different
from usual JSFunction. Usual JSFunction uses reifying system for "name". We would like
to apply this reifying mechanism to builtin JSFunction to simplify code and drop
JSFunction::createBuiltinFunction.

We would like to store the "correct" name in FunctionExecutable. For example,
we would like to store the name like "get [Symbol.species]" to FunctionExecutable
instead of specifying name when creating JSFunction. To do so, we add a new
annotations, @getter and @overriddenName. When @getter is specified, the name of
the function becomes "get xxx". And when @overriddenName="xxx" is specified,
the name of the function becomes "xxx".

* Scripts/builtins/builtins_generate_combined_header.py:
(generate_section_for_code_table_macro):
* Scripts/builtins/builtins_generate_combined_implementation.py:
(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):
* Scripts/builtins/builtins_generate_separate_header.py:
(generate_section_for_code_table_macro):
* Scripts/builtins/builtins_generate_separate_implementation.py:
(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):
* Scripts/builtins/builtins_model.py:
(BuiltinFunction.__init__):
(BuiltinFunction.fromString):
* Scripts/builtins/builtins_templates.py:
* Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Combined.js:
(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):
* Scripts/tests/builtins/JavaScriptCore-Builtin.prototype-Separate.js:
(overriddenName.string_appeared_here.match):
(intrinsic.RegExpTestIntrinsic.test):
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
* Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
* Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
* Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
* builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::BuiltinExecutables):
* builtins/BuiltinExecutables.h:
* builtins/FunctionPrototype.js:
(symbolHasInstance): Deleted.
* builtins/GlobalOperations.js:
(globalPrivate.speciesGetter): Deleted.
* builtins/IteratorPrototype.js:
(symbolIteratorGetter): Deleted.
* builtins/RegExpPrototype.js:
(match): Deleted.
(replace): Deleted.
(search): Deleted.
(split): Deleted.
* jsc.cpp:
(functionCreateBuiltin):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/IteratorPrototype.cpp:
(JSC::IteratorPrototype::finishCreation):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):
(JSC::JSFunction::createBuiltinFunction): Deleted.
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSObject.cpp:
(JSC::JSObject::putDirectBuiltinFunction):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition):
* runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
* runtime/Lookup.cpp:
(JSC::reifyStaticAccessor):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):

Source/WebCore:

Use @getter for JSBuiltin getters.

* Modules/fetch/FetchResponse.js:
(bodyUsed): Deleted.
(body): Deleted.
* Modules/streams/ReadableByteStreamController.js:
(byobRequest): Deleted.
(desiredSize): Deleted.
* Modules/streams/ReadableStream.js:
(locked): Deleted.
* Modules/streams/ReadableStreamBYOBReader.js:
(closed): Deleted.
* Modules/streams/ReadableStreamBYOBRequest.js:
(view): Deleted.
* Modules/streams/ReadableStreamDefaultController.js:
(desiredSize): Deleted.
* Modules/streams/ReadableStreamDefaultReader.js:
(closed): Deleted.
* Modules/streams/WritableStream.js:
(closed): Deleted.
(ready): Deleted.
(state): Deleted.
* bindings/js/JSDOMBuiltinConstructor.h:
(WebCore::JSDOMBuiltinConstructor<JSClass>::finishCreation):

LayoutTests:

* js/dom/builtin-getter-name-expected.txt: Added.
* js/dom/builtin-getter-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline editing/style/5084241.html after r220706.
pvollan@apple.com [Tue, 29 Aug 2017 23:50:00 +0000 (23:50 +0000)]
Rebaseline editing/style/5084241.html after r220706.

Unreviewed test gardening.

* platform/win/editing/style/5084241-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for...
jlewis3@apple.com [Tue, 29 Aug 2017 23:47:26 +0000 (23:47 +0000)]
Rebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for ios-11.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shorthand syntax
nvasilyev@apple.com [Tue, 29 Aug 2017 23:45:19 +0000 (23:45 +0000)]
Web Inspector: Convert all methods in Utilities.js to ECMAScript 2015 shorthand syntax
https://bugs.webkit.org/show_bug.cgi?id=176067

Reviewed by Joseph Pecoraro.

* UserInterface/Base/Utilities.js:
(get return):
(addStringToken):
(prettyFunctionName):
(warn):
(error):
(isEmptyObject):
(isEnterKey):
(resolveDotsInPath):
(parseMIMEType):
(simpleGlobStringToRegExp):
(defaultComparator):
(get Object):
(appendWebInspectorSourceURL):
(appendWebInspectorConsoleEvaluationSourceURL):
(isWebInspectorInternalScript):
(isWebInspectorConsoleEvaluationScript):
(isWebKitInjectedScript):
(isWebKitInternalScript):
(isFunctionStringNativeCode):
(isTextLikelyMinified):
(doubleQuotedString):
(insertionIndexForObjectInListSortedByFunction):
(insertObjectIntoSortedArray):
(decodeBase64ToBlob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
pvollan@apple.com [Tue, 29 Aug 2017 23:35:33 +0000 (23:35 +0000)]
[Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=176064

Reviewed by Saam Barati.

The crash log indicates that the function pointer is null in this case.

* wtf/win/WorkQueueWin.cpp:
(WTF::WorkQueue::dispatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaselined js/dom/global-constructors-attributes.html after r221258.
jlewis3@apple.com [Tue, 29 Aug 2017 23:32:43 +0000 (23:32 +0000)]
Rebaselined js/dom/global-constructors-attributes.html after r221258.

Unreviewed test gardening.

* platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION (r215290): "Where From" metadata is empty when dragging an image out of...
aestes@apple.com [Tue, 29 Aug 2017 23:32:36 +0000 (23:32 +0000)]
REGRESSION (r215290): "Where From" metadata is empty when dragging an image out of Safari
https://bugs.webkit.org/show_bug.cgi?id=176068

Reviewed by Wenson Hsieh.

If you drag an image out of Safari, drop it on the Desktop, and open "Get Info", there is a
"Where from:" field under "More Info" that should list the image's URL. After r215290, this
field is blank due to a mixup with the string passed to URLWithUserTypedString().

Fix this by passing metadataURLString to URLWithUserTypedString() instead of urlString.

Not possible to reliably test this since WebKit adds metadata on a global concurrent queue.

* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline editing/style/5065910.html after r220706.
pvollan@apple.com [Tue, 29 Aug 2017 23:10:46 +0000 (23:10 +0000)]
Rebaseline editing/style/5065910.html after r220706.

Unreviewed test gardening.

* platform/win/editing/style/5065910-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBegin transition to modern IPC decoding
achristensen@apple.com [Tue, 29 Aug 2017 22:49:50 +0000 (22:49 +0000)]
Begin transition to modern IPC decoding
https://bugs.webkit.org/show_bug.cgi?id=176043

Reviewed by JF Bastien.

Right now, if a class is decoded from IPC we must have a default constructor.
This prevents us from having Ref or C++ references in such types, which is cluttering up our code.
This is because IPC::decode makes a default-constructed object, fills it, and returns a bool indicating success.
Making IPC::decode instead return a std::optional makes it so we do not need to call an empty constructor.
This could also enable us to add IPC::Decoder::operator>> and other fun things!
I also modernized two arbitrary classes, WebsitePolicies and WebPageGroupData with more to come.
There's no good way to update the actual generated IPC code until each class has been transitioned.

* Platform/IPC/ArgumentCoder.h:
(IPC::ArgumentCoder::decode):
* Platform/IPC/Decoder.h:
(IPC::Decoder::decode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
* Shared/WebsitePolicies.h:
(WebKit::WebsitePolicies::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCacheStorage does not need to sort its caches
commit-queue@webkit.org [Tue, 29 Aug 2017 22:34:17 +0000 (22:34 +0000)]
CacheStorage does not need to sort its caches
https://bugs.webkit.org/show_bug.cgi?id=176059

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Chris Dumez.

Covered by existing tests.

* Modules/cache/CacheStorage.cpp:
(WebCore::CacheStorage::retrieveCaches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThrowing an exception in the DFG/FTL should not be a jettison-able OSR exit
sbarati@apple.com [Tue, 29 Aug 2017 21:55:12 +0000 (21:55 +0000)]
Throwing an exception in the DFG/FTL should not be a jettison-able OSR exit
https://bugs.webkit.org/show_bug.cgi?id=176060

Reviewed by Michael Saboff.

OSR exitting when we throw an exception is expected behavior. We should
not count these exits towards our jettison OSR exit threshold.

* bytecode/ExitKind.cpp:
(JSC::exitKindToString):
(JSC::exitKindMayJettison):
* bytecode/ExitKind.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileThrow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS
aperez@igalia.com [Tue, 29 Aug 2017 21:41:35 +0000 (21:41 +0000)]
[WPE] Avoid using autogen for JHBuild modules, trying to fix the EWS

Unreviewed build fix.

This also makes the JHBuild process faster, because there are less
modules which will trigger slow, ancient Perl and M4 based tooling.

* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSetting the cache storage engine root path according the session WebsiteDataStore
commit-queue@webkit.org [Tue, 29 Aug 2017 21:39:48 +0000 (21:39 +0000)]
Setting the cache storage engine root path according the session WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=176055

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Alex Christensen.

Source/WebCore:

No test right now as the engine is not making any read/write operations.

* platform/network/NetworkStorageSession.h:
(WebCore::NetworkStorageSession::cacheStorageDirectory const):
(WebCore::NetworkStorageSession::setCacheStorageDirectory):

Source/WebKit:

Adding disk read/write capacities to CacheStorage engine.
This is used to store per-origin cache names in a file.
Making Engine a thread safe refcounted object so that it does read/write in a background thread.

Setting the root path of the engine to the directory set for the session in use according the WebsiteDataStore.
For each WebsiteDataStore, a path and a sandbox extension is passed to the network process if persistency of the cache storage is wanted.
Ephemeral sessions will set the path of the engine to null so that no read/write access is performed.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::cacheStorageDirectory const):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::defaultEngine):
(WebKit::CacheStorage::Engine::Engine):
(WebKit::CacheStorage::Engine::writeFile):
* NetworkProcess/cache/CacheStorageEngine.h:
(WebKit::CacheStorage::Engine::create):
(WebKit::CacheStorage::Engine::shouldPersist const):
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):
* Shared/WebsiteDataStoreParameters.h:
* UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::WebsiteDataStore::parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoBuild fix. OS X "revision" can have a space.
rniwa@webkit.org [Tue, 29 Aug 2017 21:28:04 +0000 (21:28 +0000)]
Build fix. OS X "revision" can have a space.

* public/include/commit-log-fetcher.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake it possible to specify A/B testing revision with a partial hash
rniwa@webkit.org [Tue, 29 Aug 2017 21:18:49 +0000 (21:18 +0000)]
Make it possible to specify A/B testing revision with a partial hash
https://bugs.webkit.org/show_bug.cgi?id=176047

Rubber-stamped by Chris Dumez.

Added the support for specifying a partial hash in A/B testing instead of the full hash.

* public/include/commit-log-fetcher.php:
(CommitLogFetcher::find_commit_id_by_revision): Extracted from associate-commit.php.
* public/privileged-api/associate-commit.php:
(main):
* public/privileged-api/create-test-group.php:
(main): Use find_commit_id_by_revision here to support scheduling an A/B testing with a partial hash.
* server-tests/privileged-api-create-test-group-tests.js:
(createAnalysisTask): Make it possible to customize revision string in some test cases.
* server-tests/resources/test-server.js:
(TestServer.prototype._stopApache): Fixed the bug that cleanup step always fails whenever the test file
runs more than 8s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for...
jlewis3@apple.com [Tue, 29 Aug 2017 21:00:32 +0000 (21:00 +0000)]
Rebaselined http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl for ios-11.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[CMake] Use find_package for libxml2 and libxstl
don.olmstead@sony.com [Tue, 29 Aug 2017 20:53:02 +0000 (20:53 +0000)]
[CMake] Use find_package for libxml2 and libxstl
https://bugs.webkit.org/show_bug.cgi?id=176042

Reviewed by Konstantin Tokarev.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Optimize View.prototype.removeSubview
nvasilyev@apple.com [Tue, 29 Aug 2017 19:25:56 +0000 (19:25 +0000)]
Web Inspector: Optimize View.prototype.removeSubview
https://bugs.webkit.org/show_bug.cgi?id=176041

Reviewed by Matt Baker.

Source/WebInspectorUI:

Look up a subview in an array only once, not twice.

* UserInterface/Base/Utilities.js:
(Array.prototype.removeAll):
(Array.prototype.remove):
Split Array.propotype.remove(value, onlyFirst) into Array.propotype.removeAll(value) and
Array.propotype.remove(value).

* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype._debuggerBreakpointOptions):
* UserInterface/Views/ContentViewContainer.js:
(WI.ContentViewContainer.prototype._clearTombstonesForContentView):
(WI.ContentViewContainer.prototype._disassociateFromContentView):
* UserInterface/Views/View.js:
(WI.View.prototype.removeSubview):

LayoutTests:

Split Array.prototype.remove(value, onlyFirst) into Array.prototype.removeAll(value) and Array.prototype.remove(value).

* inspector/unit-tests/array-utilities-expected.txt:
* inspector/unit-tests/array-utilities.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Win] A WTF test is timing out in run-api-tests.
pvollan@apple.com [Tue, 29 Aug 2017 18:34:38 +0000 (18:34 +0000)]
[Win] A WTF test is timing out in run-api-tests.
https://bugs.webkit.org/show_bug.cgi?id=176056

Reviewed by Brent Fulgham.

The test SynchronizedFixedQueue.ProduceOnly relies on that putting a thread to sleep for
1ms will wake it up before another thread which is put to sleep for 10ms. I believe this
is not neccessarily true on Windows where the thread scheduling does not have millisecond
accuracy. Fix the test timeout by adjusting the sleep time slightly.

* TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
(TestWebKitAPI::ToUpperConverter::startProducing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCacheQueryOptions::isolatedCopy() copies the cache name twice
dbates@webkit.org [Tue, 29 Aug 2017 18:08:54 +0000 (18:08 +0000)]
CacheQueryOptions::isolatedCopy() copies the cache name twice
https://bugs.webkit.org/show_bug.cgi?id=175974

Reviewed by Youenn Fablet.

Currently CacheQueryOptions has a user-defined constructor that calls String.isolatedCopy()
on the passed cache name. CacheQueryOptions::isolatedCopy() also calls String.isolatedCopy()
on the cache name before passing the result to the user-defined constructor; => we malloc
and copy the cache name twice. Ideally we would remove the user-defined constructors and
have callers use aggregate initializer syntax to instantiate a CacheQueryOptions. Unfortunately
we cannot do this until we upgrade from Visual Studio 2015 to Visual Studio 2017 as the former
does not support non-static data member initializers (NSDMI) for aggregates and CacheQueryOptions
has some. Therefore we modify the user-defined, non-default, constructor to take a String&&
and conditionally compile the the constructors when building with compilers that do not
support NSDMI for aggregates.

* Modules/cache/CacheQueryOptions.h:
(WebCore::CacheQueryOptions::CacheQueryOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
commit-queue@webkit.org [Tue, 29 Aug 2017 17:43:51 +0000 (17:43 +0000)]
CanvasCaptureMediaStreamTrack clone is not a CanvasCaptureMediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=176036

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-29
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

Instead of creating a MediaStreamTrack clone when cloning a CanvasCaptureMediaStreamTrack,
we are now creating a CanvasCaptureMediaStreamTrack.
This allows exposing the expected methods and having the expected functionality.

* Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:
(WebCore::CanvasCaptureMediaStreamTrack::clone):
* Modules/mediastream/CanvasCaptureMediaStreamTrack.h:
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::clone):
* Modules/mediastream/MediaStreamTrack.h:

LayoutTests:

* fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt:
* fast/mediastream/captureStream/canvas2d.html:
* fast/mediastream/captureStream/canvas2d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSkip editing/pasteboard/paste-empty-startcontainer.html on Windows.
pvollan@apple.com [Tue, 29 Aug 2017 17:40:14 +0000 (17:40 +0000)]
Skip editing/pasteboard/paste-empty-startcontainer.html on Windows.
It is skipped on all other platforms.

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMarked fast/events/mouse-cursor-no-mousemove.html as flaky.
jlewis3@apple.com [Tue, 29 Aug 2017 17:35:39 +0000 (17:35 +0000)]
Marked fast/events/mouse-cursor-no-mousemove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169238

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd initial support for dataTransferItem.webkitGetAsEntry()
cdumez@apple.com [Tue, 29 Aug 2017 17:00:09 +0000 (17:00 +0000)]
Add initial support for dataTransferItem.webkitGetAsEntry()
https://bugs.webkit.org/show_bug.cgi?id=176038
<rdar://problem/34121095>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Add CommonIdentifier needed by [EnabledAtRuntime].

* runtime/CommonIdentifiers.h:

Source/WebCore:

Add initial support for dataTransferItem.webkitGetAsEntry() as per:
- https://wicg.github.io/entries-api/#html-data

The method works as expected and returns a FileSystemEntry. The entry
can be either a file or a directory. All of the attributes exposed on
the FileSystemEntry return correct values.

What remains to be implemented for this new API to actually be useful:
- directory.getFile() / directory.getDirectory()
- file.file()
- entry.getParent()
- directoryReader.readEntries()

Test: editing/pasteboard/datatransfer-items-drop-getAsEntry.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
Add new files to projects.

* Modules/entriesapi/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::DOMFileSystem):
* Modules/entriesapi/DOMFileSystem.h:
(WebCore::DOMFileSystem::create):
DOMFileSystem factory now takes a name parameter. This name is a UUID, as suggested in
the specification and implemented by Firefox.

* Modules/entriesapi/ErrorCallback.cpp: Added.
* Modules/entriesapi/ErrorCallback.h:
Add scheduleCallback() convenience method as we often need to call this callback
asynchronously.

* Modules/entriesapi/FileSystemDirectoryEntry.cpp:
(WebCore::FileSystemDirectoryEntry::FileSystemDirectoryEntry):
(WebCore::FileSystemDirectoryEntry::createReader):
(WebCore::FileSystemDirectoryEntry::getFile):
(WebCore::FileSystemDirectoryEntry::getDirectory):
* Modules/entriesapi/FileSystemDirectoryEntry.h:
- Add implementation for createReader().
- Update getFile() / getDirectory() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* Modules/entriesapi/FileSystemDirectoryEntry.idl:
Expose createReader() now that we have stubs for FileSystemDirectoryReader.

* Modules/entriesapi/FileSystemDirectoryReader.cpp: Added.
* Modules/entriesapi/FileSystemDirectoryReader.h: Added.
* Modules/entriesapi/FileSystemDirectoryReader.idl: Added.
* Modules/entriesapi/FileSystemEntriesCallback.cpp: Added.
* Modules/entriesapi/FileSystemEntriesCallback.h: Added.
* Modules/entriesapi/FileSystemEntriesCallback.idl: Added.
Land stubs for FileSystemDirectoryReader and its FileSystemEntriesCallback.

* Modules/entriesapi/FileSystemEntry.cpp:
(WebCore::FileSystemEntry::FileSystemEntry):
* Modules/entriesapi/FileSystemEntry.h:
(WebCore::FileSystemEntry::virtualPath const):
* Modules/entriesapi/FileSystemEntry.idl:
Update constructor to take a virtual path, which is exposed via fullPath
attribute in IDL.

* Modules/entriesapi/FileSystemFileEntry.cpp:
(WebCore::FileSystemFileEntry::FileSystemFileEntry):
(WebCore::FileSystemFileEntry::file):
* Modules/entriesapi/FileSystemFileEntry.h:
(isType):
* Modules/entriesapi/FileSystemFileEntry.idl:
- Update file() to call the error callback for now as they are
  unimplemented.
- Have the factory take the virtual path of the entry so that it can be
  exposed via the fullPath attribute in IDL.

* bindings/js/JSFileSystemEntryCustom.cpp: Added.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
Add custom implementation of FileSystemEntry's toJS() function. This is
needed because FileSystemEntry has 2 subclasses and we need to type check
at runtime to construct the right wrapper.

* dom/DataTransferItem.cpp:
(WebCore::DataTransferItem::getAsEntry const):
* dom/DataTransferItem.h:
* dom/DataTransferItem.idl:
Add initial implementation for getAsEntry(), currently exposed as
webkitGetAsEntry().

* dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::ensureItems const):
Construct a DataTransferItem if the file is a directory now that we
support getAsEntry().

* fileapi/File.cpp:
(WebCore::File::isDirectory const):
* fileapi/File.h:
Add convenience method to query if a File is a directory.

Source/WebKit:

Make dataTransfer.items an experimental feature so that it can be easily
turned on from the Develop menu, for testing convenience.

* Shared/WebPreferencesDefinitions.h:

LayoutTests:

* editing/pasteboard/datatransfer-items-drop-getAsEntry-expected.txt: Added.
* editing/pasteboard/datatransfer-items-drop-getAsEntry.html: Added.
Add layout test coverage.

* http/wpt/entries-api/interfaces-expected.txt:
Rebaseline test now that we support more of the API.

* platform/wk2/TestExpectations:
Skip new test on WK2 because it relies on beginDragWithFiles().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, update my watchlist filters.
eric.carlson@apple.com [Tue, 29 Aug 2017 17:00:04 +0000 (17:00 +0000)]
Unreviewed, update my watchlist filters.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago Marked media/video-controls-no-display-with-text-track.html and media/video-controls...
jlewis3@apple.com [Tue, 29 Aug 2017 16:52:23 +0000 (16:52 +0000)]
 Marked media/video-controls-no-display-with-text-track.html and media/video-controls-in-media-document.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=176054

 Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline fast/doctypes/002.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 15:21:42 +0000 (15:21 +0000)]
Rebaseline fast/doctypes/002.html after r220858.

Unreviewed test gardening.

* platform/win/fast/doctypes/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline fast/lists/marker-before-empty-inline.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:57:36 +0000 (14:57 +0000)]
Rebaseline fast/lists/marker-before-empty-inline.html after r220858.

Unreviewed test gardening.

* platform/win/fast/lists/marker-before-empty-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.
pvollan@apple.com [Tue, 29 Aug 2017 14:33:06 +0000 (14:33 +0000)]
Rebaseline css2.1/t0805-c5520-brdr-b-01-e.html after r220858.

Unreviewed test gardening.

* platform/win/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Remove some obsolete expectations.
commit-queue@webkit.org [Tue, 29 Aug 2017 14:20:04 +0000 (14:20 +0000)]
[GTK] Remove some obsolete expectations.
https://bugs.webkit.org/show_bug.cgi?id=176051

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-29

* platform/gtk/TestExpectations:
  - fast/animation/request-animation-frame-throttling-detached-iframe.html: passing since r215259.
  - fast/animation/request-animation-frame-throttling-lowPowerMode.html: passing since r215259.
  - fast/events/drag-parent-node.html: passing since r217670-r217679.
  - fast/events/keydown-leftright-keys.html: passing since r210504.
  - fast/events/selectionchange-iframe.html: passing since r205908-r205913.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.
carlosgc@webkit.org [Tue, 29 Aug 2017 14:01:47 +0000 (14:01 +0000)]
Unreviewed. REGRESSION(r221219): Fix unit tests using resources from WebKit directory.

The WebKit2 directory was renamed as WebKit in r221219, but neither run-gtk-tests script nor
Test::getResourcesDir() were updated to use the new name.

* Scripts/run-gtk-tests:
(TestRunner._setup_testing_environment):
* TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::getResourcesDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared...
zandobersek@gmail.com [Tue, 29 Aug 2017 11:30:49 +0000 (11:30 +0000)]
[WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175620

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code and other code duplicated between the
Mac and libgcrypt implementations of Web Crypto into the shared layer.
This patch focuses on the HKDF, HMAC and PBKDF2 algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr
value. CryptoAlgorithmParameters objects are passed through non-const
references because data getters could lazily construct the underlying
Vector objects. CryptoKey objects are passed through const references.
Implementations can then manually retrieve and further validate any key
or parameter data, as required for that specific implementation. Input
data is passed through const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmHKDF.cpp:
(WebCore::CryptoAlgorithmHKDF::deriveBits):
* crypto/algorithms/CryptoAlgorithmHKDF.h:
* crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
* crypto/algorithms/CryptoAlgorithmHMAC.h:
* crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
(WebCore::CryptoAlgorithmPBKDF2::deriveBits):
* crypto/algorithms/CryptoAlgorithmPBKDF2.h:
* crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
* crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
zandobersek@gmail.com [Tue, 29 Aug 2017 11:29:56 +0000 (11:29 +0000)]
[WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175619

Reviewed by Jiewen Tan.

Push the WorkQueue dispatch code duplicated between the Mac and libgcrypt
implementations of Web Crypto into the shared layer. This patch focuses on
the EC-based algorithms.

Functions with platform-specific implementations that are invoked from
these asynchronous dispatches are made static and return an ExceptionOr or
std::optional value. CryptoKey and CryptoAlgorithmParameters objects are
passed to those through const references. Input data is passed through
const references to the original Vector objects.

No new tests -- no changes in behavior that's covered by existing tests.

* crypto/algorithms/CryptoAlgorithmECDH.cpp:
(WebCore::CryptoAlgorithmECDH::deriveBits):
* crypto/algorithms/CryptoAlgorithmECDH.h:
* crypto/algorithms/CryptoAlgorithmECDSA.cpp:
(WebCore::CryptoAlgorithmECDSA::sign):
(WebCore::CryptoAlgorithmECDSA::verify):
* crypto/algorithms/CryptoAlgorithmECDSA.h:
* crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):
* crypto/keys/CryptoKeyEC.h:
* crypto/mac/CryptoAlgorithmECDHMac.cpp:
(WebCore::CryptoAlgorithmECDH::platformDeriveBits):
* crypto/mac/CryptoAlgorithmECDSAMac.cpp:
(WebCore::CryptoAlgorithmECDSA::platformSign):
(WebCore::CryptoAlgorithmECDSA::platformVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[SVG] Leak in SVGAnimatedListPropertyTearOff
svillar@igalia.com [Tue, 29 Aug 2017 09:32:34 +0000 (09:32 +0000)]
[SVG] Leak in SVGAnimatedListPropertyTearOff
https://bugs.webkit.org/show_bug.cgi?id=172545

Reviewed by Darin Adler.

Source/WebCore:

SVGAnimatedListPropertyTearOff maintains a vector m_wrappers with references to
SVGPropertyTraits<PropertyType>::ListItemTearOff. Apart from that SVGPropertyTearOff has a
reference to SVGAnimatedProperty.

When SVGListProperty::getItemValuesAndWrappers() is called, it creates a
SVGPropertyTraits<PropertyType>::ListItemTearOff pointing to the same SVGAnimatedProperty (a
SVGAnimatedListPropertyTearOff) which stores the m_wrappers vector where the ListItemTearOff
is going to be added to. This effectively creates a reference cycle between the
SVGAnimatedListPropertyTearOff and all the ListItemTearOff it stores in m_wrappers.

In order to effectively break the cycle without freeing too many wrappers we should take two
measures:
1) Break the reference cycle by storing raw pointers in the m_wrappers Vector
2) Remove the ListItemTearOff which is being deleted (it notifies the animated property by
calling propertyWillBeDeleted) from the m_wrappers Vector.

This is a re-land of r219334 which caused early releases of custom data attribute objects
added to SVG elements (wkb.ug/175023).

Tests: svg/animations/animation-leak-list-property-instances.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html
       svg/dom/SVGAnimatedListPropertyTearOff-crash.html
       svg/dom/SVGAnimatedListPropertyTearOff-leak.html

* svg/properties/SVGAnimatedListPropertyTearOff.h:
* svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::getItemValuesAndWrappers):
* svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::removeItemFromList):

LayoutTests:

The list of new added tests includes the one for the original bug, a new test for the
regression and a couple of tests imported from Blink which verify that
SVGAnimatedListPropertyTearOff does not crash after the context element goes out of scope.

* svg/animations/animation-leak-list-property-instances-expected.txt: Added.
* svg/animations/animation-leak-list-property-instances.html: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-2.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash-expected.txt: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-crash.html: Added. Imported from Blink.
* svg/dom/SVGAnimatedListPropertyTearOff-leak-expected.txt: Added.
* svg/dom/SVGAnimatedListPropertyTearOff-leak.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
aestes@apple.com [Tue, 29 Aug 2017 09:10:52 +0000 (09:10 +0000)]
[Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=176046

Reviewed by Alex Christensen.

Source/WebCore:

* platform/FileSystem.cpp:
(WebCore::setMetadataURL):
* platform/FileSystem.h:
(WebCore::setMetadataURL):
* platform/mac/FileSystemMac.mm:
(WebCore::setMetadataURL):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/spi/mac/MetadataSPI.h: Added.

Source/WebKit:

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw):
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.

* Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
(setMetaData): Deleted.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed WPE debug build fix.
zandobersek@gmail.com [Tue, 29 Aug 2017 07:46:13 +0000 (07:46 +0000)]
Unreviewed WPE debug build fix.

* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
AppendState is an enum class, enum values have to be accessed
using scope resolution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix #2 after r221275.
bfulgham@apple.com [Tue, 29 Aug 2017 04:33:36 +0000 (04:33 +0000)]
Unreviewed build fix #2 after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.
* WebCoreSupport/WebPlatformStrategies.h: Update signatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLogger should use makeString instead of String::format
eric.carlson@apple.com [Tue, 29 Aug 2017 02:59:18 +0000 (02:59 +0000)]
Logger should use makeString instead of String::format
https://bugs.webkit.org/show_bug.cgi?id=176035

Reviewed by Jer Noble.

Source/WebCore/PAL:

* pal/Logger.h:
(PAL::LogArgument::toString):
(PAL::Logger::logAlways):
(PAL::Logger::error):
(PAL::Logger::warning):
(PAL::Logger::notice):
(PAL::Logger::info):
(PAL::Logger::debug):
(PAL::Logger::MethodAndPointer::MethodAndPointer):
(PAL::Logger::log):
(PAL::LogArgument<Logger::MethodAndPointer>::toString):

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F): Update test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline accessibility/menu-list-crash2.html after r220930.
pvollan@apple.com [Tue, 29 Aug 2017 02:18:29 +0000 (02:18 +0000)]
Rebaseline accessibility/menu-list-crash2.html after r220930.

Unreviewed test gardening.

* platform/win/accessibility/menu-list-crash2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
aestes@apple.com [Tue, 29 Aug 2017 00:55:01 +0000 (00:55 +0000)]
[Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
https://bugs.webkit.org/show_bug.cgi?id=176039

Reviewed by Alex Christensen.

Source/WebCore:

* PlatformMac.cmake:
* WebCore.xcodeproj/project.pbxproj:
* platform/ios/WebCoreSystemInterfaceIOS.mm:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
* platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage):
* platform/text/TextEncodingRegistry.h:
* platform/text/ios/TextEncodingRegistryIOS.mm: Added.
(WebCore::webDefaultCFStringEncoding):
* platform/text/mac/TextEncodingRegistryMac.mm: Added.
(WebCore::webDefaultCFStringEncoding):

Source/WebKit:

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
* WebView/WebPreferences.mm:
(+[WebPreferences _systemCFStringEncoding]):

Source/WTF:

* wtf/spi/cf/CFStringSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.
ryanhaddad@apple.com [Tue, 29 Aug 2017 00:42:27 +0000 (00:42 +0000)]
Rebaseline http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl.

Unreviewed test gardening.

* http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt:
* platform/mac-highsierra/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Copied from LayoutTests/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and...
mcatanzaro@igalia.com [Tue, 29 Aug 2017 00:40:35 +0000 (00:40 +0000)]
[GStreamer] The glvideoflip GStreamer element isn't available. Video mirroring and rotation functionalities are thus disabled.
https://bugs.webkit.org/show_bug.cgi?id=175576

Reviewed by Carlos Alberto Lopez Perez.

Build graphene to enable the glvideoflip element.

* gstreamer/jhbuild.modules:
* gtk/jhbuild.modules:
* jhbuild/jhbuild-wrapper:
* wpe/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
commit-queue@webkit.org [Tue, 29 Aug 2017 00:27:54 +0000 (00:27 +0000)]
REGRESSION(r220278): Web Inspector: ContextMenu items are not getting triggered
https://bugs.webkit.org/show_bug.cgi?id=176034

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-08-28
Reviewed by Devin Rousso.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::showContextMenu):
Responses go through InspectorFrontendAPI not InspectorFrontendHost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoFix incorrect enum in atBoundaryOfGranularity call
megan_gardner@apple.com [Mon, 28 Aug 2017 23:56:25 +0000 (23:56 +0000)]
Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004

Reviewed by Wenson Hsieh and Enrica Casucci

Enum that was being used was incorrect, as that case in not covered in called function.
Resulted in a no-op. Should now have correct behavior around line boundaries.

Not possible to add tests for selections with velocity. Will attempt to add this behavior later.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::rangeAtWordBoundaryForPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed test gardening. <rdar://problem/34051745>
jlewis3@apple.com [Mon, 28 Aug 2017 23:29:54 +0000 (23:29 +0000)]
Unreviewed test gardening. <rdar://problem/34051745>

* platform/ios-11/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[WinCairo] Add PlatformWin cmake for Webkit
commit-queue@webkit.org [Mon, 28 Aug 2017 23:29:29 +0000 (23:29 +0000)]
[WinCairo] Add PlatformWin cmake for Webkit
https://bugs.webkit.org/show_bug.cgi?id=176027

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-08-28
Reviewed by Brent Fulgham.

* PlatformWin.cmake: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix after r221275.
bfulgham@apple.com [Mon, 28 Aug 2017 22:46:02 +0000 (22:46 +0000)]
Unreviewed build fix after r221275.

* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
to match new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221278 268f45cc-cd09-0410-ab3c-d52691b4dbfc