WebKit-https.git
9 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 30 Apr 2010 15:46:01 +0000 (15:46 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Simon Fraser.

        SHOULD NEVER BE REACHED assertion loading forbes.com
        https://bugs.webkit.org/show_bug.cgi?id=38272

        * printing/pseudo-class-outside-page-expected.txt: Added.
        * printing/pseudo-class-outside-page.html: Added.
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Simon Fraser.

        SHOULD NEVER BE REACHED assertion loading forbes.com
        https://bugs.webkit.org/show_bug.cgi?id=38272

        Ignore page media related pseudo classes.

        Test: printing/pseudo-class-outside-page.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChanged Steve Block from committer to reviewer.
steveblock@google.com [Fri, 30 Apr 2010 15:22:22 +0000 (15:22 +0000)]
Changed Steve Block from committer to reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 15:11:50 +0000 (15:11 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. While I'm at it: Update prototype-inheritance-2-expected.txt result, it's failing since CSSPageRule has been introduced.

        * platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 15:08:25 +0000 (15:08 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Windows fails on svg/custom/mask-changes.svg. Trying to fix the test which is really flawed. Shows a DRT difference between Mac/Win.

        * svg/custom/mask-changes.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 30 Apr 2010 13:34:21 +0000 (13:34 +0000)]
2010-04-30  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed.  Fixing a missed test from https://bugs.webkit.org/show_bug.cgi?id=38331

        * fast/events/init-events-expected.txt:
        * fast/events/script-tests/init-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 30 Apr 2010 13:31:59 +0000 (13:31 +0000)]
2010-04-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        Fix compiler warning "suggest parentheses around"

        No new tests as there is no new functionality.

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::calculateFromAndToValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Unreviewed. Regression fix.
tkent@chromium.org [Fri, 30 Apr 2010 11:49:06 +0000 (11:49 +0000)]
WebCore: Unreviewed. Regression fix.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
 r58564 made a region check for the cancel button stricter, but it
 made some tests failing on Chromium. So, relax the check again.

LayoutTests: Unreviewed.

Revert a part of r58564 to be compatible with prior behavior
https://bugs.webkit.org/show_bug.cgi?id=38383

* platform/chromium/test_expectations.txt: Remove expectations added by r58568.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 30 Apr 2010 11:26:31 +0000 (11:26 +0000)]
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        Change the existing tests to test 'url' rather than 'uri'.

        * storage/domstorage/events/documentURI-expected.txt:
        * storage/domstorage/events/script-tests/documentURI.js:
        (step2):
        (step3):
        * storage/domstorage/localstorage/resources/iframe-events-second.html:
        * storage/domstorage/sessionstorage/resources/iframe-events-second.html:
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        As I mentioned in http://www.mail-archive.com/public-webapps@w3.org/msg08495.html
        WebKit is the only one who places the document's URL in a 'uri' property
        rather than a 'url' property.  Even though we've shipped several versions of
        browsers with the old name, we probably should change this to comply with the
        spec.

        This stuff is covered by existing tests.

        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::create):
        (WebCore::StorageEvent::StorageEvent):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::url):
        * storage/StorageEvent.idl:
2010-04-29  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Change StorageEvent.uri to StorageEvent.url to match the spec
        https://bugs.webkit.org/show_bug.cgi?id=38331

        Get rid of a stale FIXME and combine 2 lines that needn't be split.

        * src/StorageEventDispatcherImpl.cpp:
        (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 30 Apr 2010 11:22:30 +0000 (11:22 +0000)]
2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
        https://bugs.webkit.org/show_bug.cgi?id=38385

        The last SVG performance patch broke repainting if bounds of a RenderPath get smaller.
        It would only repaint the smaller part, not the original larger bounds.

        Remove all lazy calculation of the repaint rects, instead calculate object/strokeBoundingBox and repaintRectInLocalCoordinates
        once in layout - after LayoutRepainter grabbed the initial bounds, before calling repaintAfterLayout(). We can now inline
        all these functions, and save a lot of m_path.isEmpty() checks, which are expensive. No need to store a seperated markerBoundingBox(),
        combine with strokeBoundingBox() -> save one FloatRect per RenderPath. Move strokeBoundingBox() from SVGRenderBase to RenderObject,
        right next to objectBoundingBox() - to save unnecessary toSVGRenderBase() calls. Completly remove this method.

        Overall this is a regression fix, a performance improvement and saves memory. Something for everyone.

        Tests: svg/custom/repaint-stroke-width-changes.svg

        * rendering/RenderObject.cpp: Added strokeBoundingBox() here, to avoid the toSVGRenderBase() dance.
        (WebCore::RenderObject::strokeBoundingBox):
        * rendering/RenderObject.h: Ditto.
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath):
        (WebCore::RenderPath::layout): Fix regression, do repainting correctly, by recalculating the boundaries, if needed, instead of nulling them.
        (WebCore::RenderPath::paint): Cache SVGRenderStyle in local variable, remove no longer valid FIXME.
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Return a FloatRect, to avoid having to store the marker bounding box seperated.
        (WebCore::RenderPath::styleWillChange): Mark boundaries as dirty.
        (WebCore::RenderPath::updateCachedBoundaries): New function to (re-)calculate all cached boundaries, only called from layout().
        * rendering/RenderPath.h: Rename cached rect variables to have more sensible names.
        (WebCore::RenderPath::objectBoundingBox): Inlined, just returns the cached value - no more lazy creation. Huge speedup as this is hot code.
        (WebCore::RenderPath::strokeBoundingBox): Ditto.
        (WebCore::RenderPath::repaintRectInLocalCoordinates): Ditto.
        * rendering/RenderSVGBlock.h: Remove toSVGRenderBase() method.
        * rendering/RenderSVGImage.h: Ditto.
        * rendering/RenderSVGInline.cpp: No need to call toSVGRenderBase() just to get the strokeBoundingBox(). Unifies code to retrieve bounding boxes.
        (WebCore::RenderSVGInline::strokeBoundingBox):
        * rendering/RenderSVGInline.h: Remove toSVGRenderBase() method.
        * rendering/RenderSVGModelObject.h: Ditto.
        * rendering/RenderSVGResourceFilter.cpp: No need to call toSVGRenderBase() anymore, just grab the strokeBoundingBox() from the RenderObject.
        (WebCore::RenderSVGResourceFilter::applyResource):
        * rendering/RenderSVGText.h: Remove toSVGRenderBase() method.
        * rendering/SVGRenderSupport.h: Ditto. Remove markerBoundingBox() method, now combined with strokeBoundingBox().
        (WebCore::SVGRenderBase::strokeBoundingBox):
        * rendering/SVGRootInlineBox.h: Remove toSVGRenderBase() method.
        * rendering/style/SVGRenderStyle.h: Add hasMarkers() helper method, to avoid doing unnecessary work in RenderPath.
        (WebCore::SVGRenderStyle::hasMarkers):

2010-04-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        REGRESSION: RenderPath does not handle repaints correctly anymore if bounds changed
        https://bugs.webkit.org/show_bug.cgi?id=38385

        Add new test covering the repaint problem. Influences some marker results, that can be safely ignored.

        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.png: Added.
        * platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
        * svg/custom/repaint-stroke-width-changes.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Fri, 30 Apr 2010 11:11:11 +0000 (11:11 +0000)]
2010-04-30  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        Add bindings for async DB API in Workers.
        https://bugs.webkit.org/show_bug.cgi?id=34992

        * storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
        * storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
        * storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
        * storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
        * storage/execute-sql-args.js: This is the extracted shared core of the test.

        These are the worker versions of the tests; they're tiny shims around shared code.
        * fast/workers/execute-sql-args-worker-expected.txt: Added.
        * fast/workers/execute-sql-args-worker.html: Added.
        * fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
        * fast/workers/change-version-handle-reuse-worker.html: Added.
        This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
        * fast/workers/resources/database-worker-controller.js: Added.
        This file is the boilerplate for the worker side of the database tests.  It will import and run the actual test on command, and will report back completion and exceptions.
        * fast/workers/resources/database-worker.js: Added.
2010-04-30  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Dmitry Titov.

        Add bindings for async DB API in Workers.
        https://bugs.webkit.org/show_bug.cgi?id=34992

        Tests: storage/change-version-handle-reuse-worker.html
               storage/execute-sql-args-worker.html

        * bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
        (WebCore::JSWorkerContext::openDatabase):

        * bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
        (WebCore::V8WorkerContext::openDatabaseCallback):

        Add NoStaticTables flags to all objects now shared with workers.
        * storage/Database.idl:
        * storage/SQLError.idl:
        * storage/SQLResultSet.idl:
        * storage/SQLResultSetRowList.idl:
        * storage/SQLTransaction.idl:

        * workers/WorkerContext.h: Add databaseExceededQuota.
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
        (WebCore::WorkerContext::openDatabase): Remove invalid assertion.

        Add the IDL for the call to openDatabase.
        * workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewd, update test expectations.
ukai@chromium.org [Fri, 30 Apr 2010 10:06:12 +0000 (10:06 +0000)]
Unreviewd, update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=38383

Start failing after WebKit r58563:r58565
- fast/forms/search-abs-pos-cancel-button.html
- fast/forms/search-cancel-button-mouseup.html
- fast/forms/search-rtl.html
- fast/forms/search-zoomed.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix wrong bug numbers in ChangeLogs for r58564.
tkent@chromium.org [Fri, 30 Apr 2010 09:24:36 +0000 (09:24 +0000)]
Unreviewed.  Fix wrong bug numbers in ChangeLogs for r58564.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 30 Apr 2010 09:14:28 +0000 (09:14 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Unnecessary PrintContext::end() calls
        https://bugs.webkit.org/show_bug.cgi?id=38247

        Refactoring only, so no new tests.

        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageNumberForElement):
        (WebCore::PrintContext::numberOfPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewd, test expectations cleanup.
ukai@chromium.org [Fri, 30 Apr 2010 08:48:47 +0000 (08:48 +0000)]
Unreviewd, test expectations cleanup.

media/video-empty-source.html passes since r58480:r58515 (win), r58489 (linux), r58488:458490 (mac)
fast/backround/svg-as-background-6.html passes since r58488:r58490 (mac)
fast/repaint/caret-outside-block.html passes since r58414:r58415 (mac)
fast/replaced/border-radius-clip.html passes since r58543 (win, linux)
fast/images/svg-as-tiled-background.html passes r58488:r58490 (mac)
fast/text/line-breaks.html passes since r58480:r58515 (win)
fast/backgrounds/svg-as-background-2.html passes since r58480:r58515 (win), r58489 (linux), r58488:r58490 (mac)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement interactive behavior of spin buttons.
tkent@chromium.org [Fri, 30 Apr 2010 08:45:49 +0000 (08:45 +0000)]
Implement interactive behavior of spin buttons.
https://bugs.webkit.org/show_bug.cgi?id=27968

Reviewed by Adele Peterson.

WebCore:

Introduce SpinButtonElement. It is a shadow element class for
spin buttons. If the upper side of the element is clicked, calls
HTMLInputElement::stepUpFromRenderer(1). If the lower button is
clicked, calls HTMLInputElement::stepUpFromRenderer(-1).

SpinButtonElement tracks the mouse pointer position, and
RenderTheme sets ControlStates::SpinUpState if the pointer is on
the upper side.

Test: platform/mac/fast/forms/input-number-click.html

* dom/Element.h:
(WebCore::Element::isSpinButtonElement):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
 Remove an assertion. lastEditablePositionBeforePositionInRoot() can
 return null in a case that m_end is at a shadow element (a spin button)
 and baseRoot is another shadow element (inner text block) in the same
 node (an INPUT element).
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::hasSpinButton):
 Add types supporting step attribute except RANGE.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::forwardEvent):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
* rendering/RenderTextControlSingleLine.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::controlStatesForRenderer):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
* rendering/RenderTheme.h:
* rendering/TextControlInnerElements.cpp:
(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::defaultEventHandler):
* rendering/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isSpinButtonElement):
(WebCore::SpinButtonElement::isEnabledFormControl):
(WebCore::SpinButtonElement::onUpButton):

LayoutTests:

* platform/mac/fast/forms/input-number-click-expected.txt: Added.
* platform/mac/fast/forms/input-number-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Fri, 30 Apr 2010 08:41:39 +0000 (08:41 +0000)]
2010-04-30  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable DOMWindow constructor for HTMLProgressElement
        https://bugs.webkit.org/show_bug.cgi?id=38333

        Update expected test results after this change

        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.txt:
2010-04-30  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable DOMWindow constructor for HTMLProgressElement
        https://bugs.webkit.org/show_bug.cgi?id=38333

        Add ENABLE_PROGRESS_TAG to FEATURES_DEFINES_JAVASCRIPT.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 30 Apr 2010 07:56:38 +0000 (07:56 +0000)]
2010-04-29  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add codegen support for unsigned right shift
        https://bugs.webkit.org/show_bug.cgi?id=38375

        Expose unsigned right shift in the macro assembler, and make use of it
        from the jit.  Currently if the result is outside the range 0..2^31-1
        we simply fall back to the slow case, even in JSVALUE64 and JSVALUE32_64
        where technically we could still return an immediate value.

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::urshift32):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::urshift32):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::urshift32):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::shrl_i8r):
        (JSC::X86Assembler::shrl_CLr):
           Add unsigned right shift to the x86 assembler
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
           op_rshift no longer simply get thrown to a stub function
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
          JSVALUE32 and JSVALUE64 implementation.  Only supports
          double lhs in JSVALUE64.
        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_rshift):
        (JSC::JIT::emitSlow_op_rshift):
        (JSC::JIT::emit_op_urshift):
        (JSC::JIT::emitSlow_op_urshift):
          Refactor right shift code to have shared implementation between signed
          and unsigned versions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 30 Apr 2010 07:45:09 +0000 (07:45 +0000)]
2010-04-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adele Peterson.

        Mac implementation of outer-spin-button appearance, and anonymous
        element generation for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=32813

        input-appearance-spinbutton.html checks the appearances of various
        sizes of spin-buttons. input-appearance-spinbutton-size.html
        checks a spin-button height is equal to or less than the
        corresponding text field height.

        * platform/mac/fast/forms/input-appearance-spinbutton-expected.checksum: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton-size.html: Added.
        * platform/mac/fast/forms/input-appearance-spinbutton.html: Added.
2010-04-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adele Peterson.

        Mac implementation of outer-spin-button appearance, and anonymous
        element generation for <input type=number>.
        https://bugs.webkit.org/show_bug.cgi?id=32813

        The implementation uses NSStepperCell. Like the other Mac
        controls, it has only three candidates for sizes.

        The editable block of an input element is shrunk, and the
        anonymous block for a spin button is put on the right of the
        editable block.

        Tests: platform/mac/fast/forms/input-appearance-spinbutton-size.html
               platform/mac/fast/forms/input-appearance-spinbutton.html

        * dom/Element.cpp:
        (WebCore::Element::pseudoStyleCacheIsInvalid):
        * dom/InputElement.h:
        (WebCore::InputElement::hasSpinButton):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::hasSpinButton): Return true for NUMBER type.
        * platform/mac/ThemeMac.mm:
        (WebCore::sizeFromNSControlSize): Split the main part of sizeFromFont()
          to this in order to use stepperControlSizeForFont() instead of
          controlSizeForFont().
        (WebCore::sizeFromFont): Just calls sizeFromNSControlSize() with
          sizeFromFont(). No behavior changes.
        (WebCore::stepperSizes): Returns sizes for mini, small, and regular.
        (WebCore::stepperControlSizeForFont):
          Dedicated version of controlSizeForFont().
        (WebCore::stepper): Returns NSStepperCell object with specified settings.
        (WebCore::paintStepper):
        (WebCore::ThemeMac::controlSize): Support for OuterSpinButton.
        (WebCore::ThemeMac::minimumControlSize): ditto.
        (WebCore::ThemeMac::inflateControlPaintRect): ditto.
        (WebCore::ThemeMac::paint): ditto.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
          Move the content to paintBoxDecorationsWithSize().
        (WebCore::RenderBox::paintBoxDecorationsWithSize):
        * rendering/RenderBox.h: Declare paintBoxDecorationsWithSize().
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
        (WebCore::RenderTextControlSingleLine::paintBoxDecorations):
          Call paintBoxDecorationsWithSize() with smaller width by decorationWidthRight().
        (WebCore::RenderTextControlSingleLine::addFocusRingRects):
          Add a rectangle of which width is smaller by decorationWidthRight().
        (WebCore::RenderTextControlSingleLine::layout):
          Adjust m_outerSpinButton position.
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::textBlockWidth):
        (WebCore::RenderTextControlSingleLine::decorationWidthRight):
        (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
          Creates an element for m_outerSpinButton if it is needed.
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
        * rendering/RenderTextControlSingleLine.h: Declare new methods and m_outerSpinButton.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect): Support for OuterSpinButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Roll out r58557. Compile failures on Tiger, Leopard, and Chromium/Mac.
tkent@chromium.org [Fri, 30 Apr 2010 06:46:03 +0000 (06:46 +0000)]
Unreviewed.  Roll out r58557.  Compile failures on Tiger, Leopard, and Chromium/Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skip media/media-document-audio-size.html on Windows too.
tkent@chromium.org [Fri, 30 Apr 2010 06:26:13 +0000 (06:26 +0000)]
Unreviewed. Skip media/media-document-audio-size.html on Windows too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
tkent@chromium.org [Fri, 30 Apr 2010 06:20:35 +0000 (06:20 +0000)]
Unreviewed.

Add media/media-document-audio-size.html to Skipped lists.
https://bugs.webkit.org/show_bug.cgi?id=38376

* platform/gtk/Skipped:
* platform/mac-tiger/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Dan Bernstein.
kevino@webkit.org [Fri, 30 Apr 2010 06:13:46 +0000 (06:13 +0000)]
Reviewed by Dan Bernstein.

Allow other ports to compile ATSUI and CoreText functions in SimpleFontData for Mac.
https://bugs.webkit.org/show_bug.cgi?id=38334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 02:54:57 +0000 (02:54 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Unreviewed, fix chromium linux test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 30 Apr 2010 02:49:47 +0000 (02:49 +0000)]
2010-04-29  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Handle double on righthand side of a right shift
        https://bugs.webkit.org/show_bug.cgi?id=38363

        In 64-bit we support right shift of a double, and there's no
        reason not to in 32-bit either.  This is a 1.1% sunspider
        improvement in 32bit.

        Given high performance javascript code frequently makes
        use of bit operators to perform double->int conversion i'll
        follow this patch up with similar patches for bitwise 'and'
        and 'or'.

        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_rshift):
        (JSC::JIT::emitSlow_op_rshift):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 02:31:34 +0000 (02:31 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update Chromium test expectations and add new SVG baselines
        https://bugs.webkit.org/show_bug.cgi?id=38345

        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Fri, 30 Apr 2010 01:52:44 +0000 (01:52 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Updated expectations for 2 more tests on mac:
        svg/custom/dominant-baseline-hanging.svg
        fast/replaced/border-radius-clip.html

        https://bugs.webkit.org/show_bug.cgi?id=38365

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 30 Apr 2010 00:52:32 +0000 (00:52 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update JSC CodeGenerator baseline.  Not sure how I missed
        this one earlier.

        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionSerializedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed to updateLayout after typing commands too
justin.garcia@apple.com [Fri, 30 Apr 2010 00:21:15 +0000 (00:21 +0000)]
Need to updateLayout after typing commands too
https://bugs.webkit.org/show_bug.cgi?id=38352

Reviewed by Adele Peterson.

Replaced !m_parent checks in EditCommand.cpp by the more descriptive isTopLevelCommand().
Move the post editing operation updateLayout() call to {un,re}appliedEditing so that text insertions,
which don't go through EditCommand::{un,re}apply() can benefit from it too.  No test case possible
since most platforms have a layout performed as a side effect of post operation selection code.

* editing/EditCommand.cpp:
(WebCore::EditCommand::apply):
(WebCore::EditCommand::unapply):
(WebCore::EditCommand::reapply):
* editing/EditCommand.h:
(WebCore::EditCommand::isTopLevelCommand):
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Not reviewed.
ap@apple.com [Thu, 29 Apr 2010 23:57:17 +0000 (23:57 +0000)]
    Not reviewed.

        * platform/mac-tiger/Skipped: Accidentally committed with a commented out line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 23:40:30 +0000 (23:40 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Added two new timeout expectations media/audio-only-video-intrinsic-size.html, media/media-document-audio-size.html which started failing after r58543.
        https://bugs.webkit.org/show_bug.cgi?id=38362

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Re-enable Sputnik tests on Leopard and Snow Leopard.
ap@apple.com [Thu, 29 Apr 2010 23:37:53 +0000 (23:37 +0000)]
    Re-enable Sputnik tests on Leopard and Snow Leopard.

        * fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Applying_the_percent_Operator/S11.5.3_A4_T2-expected.txt:
        * fast/js/sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.12_Array_prototype_splice/S15.4.4.12_A2.1_T3-expected.txt:
        Changed expectation to PASS.

        * platform/mac-snowleopard/Skipped: Skip the above tests, since they fail in 64 bit, and
        DRT may run 64 bit on Snow Leopard.

        * platform/mac-leopard/fast/js: Added.
        * platform/mac-leopard/fast/js/sputnik: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Added.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Added.
        Added platform specific results for tests that depend on supported Unicode version.

        * platform/mac-tiger/Skipped: Skipped Sputnik on Tiger.

        * platform/mac/Skipped: Unskipped Sputnik.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 23:28:49 +0000 (23:28 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Skipping layout tests with bad/missing expectations.
        https://bugs.webkit.org/show_bug.cgi?id=38361

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Not reviewed.
ap@apple.com [Thu, 29 Apr 2010 23:18:11 +0000 (23:18 +0000)]
    Not reviewed.

        Trying to fix Windows checkout by shortening more paths in Sputnik tests.

        * fast/js/sputnik: Many directories renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Dean Jackson <dino@apple.com>
dino@apple.com [Thu, 29 Apr 2010 23:07:34 +0000 (23:07 +0000)]
2010-04-29  Dean Jackson  <dino@apple.com>

        Unreviewed. Make a note that we are no longer proposing
        the evaluateMediaQuery method. Instead, we are following
        the standard matchMedium method from CSS 3 View.

        * specs/MediaQueriesExtensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Not reviewed.
ap@apple.com [Thu, 29 Apr 2010 22:43:11 +0000 (22:43 +0000)]
    Not reviewed.

        Trying to fix Windows checkout by shortening paths in Sputnik tests.

        * fast/js/sputnik: Many directories renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window...
mitz@apple.com [Thu, 29 Apr 2010 22:20:45 +0000 (22:20 +0000)]
<rdar://problem/7918086> REGRESSION (r57820): Controller is not displayed in window when opening a MP3 file in browser window
https://bugs.webkit.org/show_bug.cgi?id=38350

Reviewed by Simon Fraser.

WebCore:

Tests: media/audio-only-video-intrinsic-size.html
       media/media-document-audio-size.html

* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::RenderVideo): Until metadata is available, ignore the natural size
reported by the player.
(WebCore::RenderVideo::videoSizeChanged): Respect a natural size of zero if reported by the
player, except in standalone media documents.

LayoutTests:

* media/audio-only-video-intrinsic-size-expected.txt: Added.
* media/audio-only-video-intrinsic-size.html: Added.
* media/media-document-audio-size-expected.txt: Added.
* media/media-document-audio-size.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFirst part of
andersca@apple.com [Thu, 29 Apr 2010 22:16:05 +0000 (22:16 +0000)]
First part of
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types.

Reviewed by Dan Bernstein.

WebCore:

Add nptypes.h to the build.

* WebCore.xcodeproj/project.pbxproj:
* bridge/npapi.h:
* bridge/npruntime.h:
* bridge/nptypes.h: Added.

WebKit/mac:

* MigrateHeaders.make:

WebKit/win:

* WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 22:11:01 +0000 (22:11 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Fixed corrupt svg-background-partial-redraw-expected.checksum files
        https://bugs.webkit.org/show_bug.cgi?id=38355

        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum:
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum:
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 21:51:30 +0000 (21:51 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Adam Barth.

        Update GObject bindings test results. We are actually moving
        backwards here, but we'll update them again when we figure out
        what broke.

        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_set_property):
        (webkit_dom_test_obj_get_property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 21:50:36 +0000 (21:50 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Skip sputnik tests for chromium until we decide what to do with them.
        https://bugs.webkit.org/show_bug.cgi?id=38353

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Skipping Sputnik tests, because tey fail a lot on buildbots. The current...
ap@apple.com [Thu, 29 Apr 2010 21:34:11 +0000 (21:34 +0000)]
    Skipping Sputnik tests, because tey fail a lot on buildbots. The current (early) theory is
        that this depends on when exactly DumpRenderTree gets restarted.

        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/win/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHoist JSVALUE32_64 arithmetic implementations into a separate file.
oliver@apple.com [Thu, 29 Apr 2010 21:32:26 +0000 (21:32 +0000)]
Hoist JSVALUE32_64 arithmetic implementations into a separate file.

Reviewed by Geoff Garen.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):
(JSC::JIT::compileBinaryArithOp):
* jit/JITArithmetic32_64.cpp: Added.
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 21:30:11 +0000 (21:30 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Skip fast/images/svg-nested.html which crashes chromium.py
        https://bugs.webkit.org/show_bug.cgi?id=38351

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 20:52:33 +0000 (20:52 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

       Not reviewed.

        Adding missing expectations, skipping tests
        https://bugs.webkit.org/show_bug.cgi?id=38343

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-mac/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
        * platform/chromium-win/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/chromium-win/fast/text/international/bold-bengali-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Rubber-stamped by Darin Adler.
ap@apple.com [Thu, 29 Apr 2010 20:43:09 +0000 (20:43 +0000)]
    Rubber-stamped by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38296
        Import Sputnik JavaScript test suite

        * fast/js/sputnik: Added.
        * fast/js/sputnik/AUTHORS: Added.
        * fast/js/sputnik/Conformance: Added.
        * fast/js/sputnik/Implementation_Diagnostics: Added.
        * fast/js/sputnik/LICENSE: Added.
        * fast/js/sputnik/Regression: Added.
        * fast/js/sputnik/Unicode: Added.

        * fast/js/script-tests/sputnik-S15.4.4.12_A3_T3.js: Deleted.
        * fast/js/sputnik-S15.4.4.12_A3_T3-expected.txt: Deleted.
        * fast/js/sputnik-S15.4.4.12_A3_T3.html: Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38277
weinig@apple.com [Thu, 29 Apr 2010 20:16:46 +0000 (20:16 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38277
MiniBrowser: -[WebCoreFlippedView currentEditor]: unrecognized selector

Reviewed by Anders Carlsson.

* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView currentEditor]): Added currentEditor nil implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 20:02:13 +0000 (20:02 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CodeGeneratorJS.pm should be consistent about castedThis versus castedThisObj
        https://bugs.webkit.org/show_bug.cgi?id=38338

        Currently CodeGeneratorJS.pm uses castThis for methods and
        castedThisObj for attributes.  This inconsistency makes it difficult to
        factor common code genereration code into methods shared by both kinds
        of bindings.  This match aligns the names so that a future patch (e.g.,
        in https://bugs.webkit.org/show_bug.cgi?id=38313) can reduce copy/paste
        code.

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::setJSTestObjIntAttr):
        (WebCore::setJSTestObjLongLongAttr):
        (WebCore::setJSTestObjUnsignedLongLongAttr):
        (WebCore::setJSTestObjStringAttr):
        (WebCore::setJSTestObjTestObjAttr):
        (WebCore::setJSTestObjAttrWithException):
        (WebCore::setJSTestObjAttrWithSetterException):
        (WebCore::setJSTestObjAttrWithGetterException):
        (WebCore::jsTestObjPrototypeFunctionVoidMethod):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethod):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethod):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithException):
        (WebCore::jsTestObjPrototypeFunctionCustomMethod):
        (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        (WebCore::jsTestObjPrototypeFunctionAddEventListener):
        (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Gustavo Noronha Silva <gustavo.noronhaollabora.co.uk>
kov@webkit.org [Thu, 29 Apr 2010 19:39:51 +0000 (19:39 +0000)]
2010-04-29  Gustavo Noronha Silva  <gustavo.noronhaollabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR
        https://bugs.webkit.org/show_bug.cgi?id=36963

        Use the default cursor instead of hard-coding left pointer.

        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):
        (WebCore::pointerCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 19:14:55 +0000 (19:14 +0000)]
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Consider implementing addOriginAccessWhitelistEntry method
        http://trac.webkit.org/changeset/57537 introduced a new method
        to manage whitelisting of origins.
        Expose this method in Chromium's bridge.
        https://bugs.webkit.org/show_bug.cgi?id=37578

        * public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
        * src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 29 Apr 2010 18:30:06 +0000 (18:30 +0000)]
2010-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        webkit-patch doesn't work if a git repo is tracking multiple svn repos
        https://bugs.webkit.org/show_bug.cgi?id=38290

        Getting the tests to pass required getting our SVN repo to more closely
        match the real svn.webkit.org repo by having a trunk directory.
        That involved adding an extra commit at the beginning and thus changing
        all the commit numbers in the tests.

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 18:12:42 +0000 (18:12 +0000)]
2010-04-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: If Timeline panel is in recording mode and is not visible and has received
        new events then these events do not appear in the panel when the panel becomes visible.
        Timeline popup may appear in the upper left window corner when you switch to another panel.
        https://bugs.webkit.org/show_bug.cgi?id=38322

        * inspector/front-end/Popover.js:
        (WebInspector.PopoverHelper.prototype._mouseMove.doHide):
        (WebInspector.PopoverHelper.prototype._mouseMove):
        (WebInspector.PopoverHelper.prototype.hidePopup):
        (WebInspector.PopoverHelper.prototype._hidePopup):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.show):
        (WebInspector.TimelinePanel.prototype._scheduleRefresh):
        (WebInspector.TimelinePanel.prototype._refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 29 Apr 2010 18:06:34 +0000 (18:06 +0000)]
2010-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release
        https://bugs.webkit.org/show_bug.cgi?id=38304

        This change provides backward compatibility with some previously
        exported private symbols. No new functionality introduced.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (qt_resumeActiveDOMObjects):
        (qt_suspendActiveDOMObjects):
        (qt_drt_clearFrameName):
        (qt_drt_garbageCollector_collect):
        (qt_drt_garbageCollector_collectOnAlternateThread):
        (qt_drt_javaScriptObjectsCount):
        (qt_drt_numberOfActiveAnimations):
        (qt_drt_overwritePluginDirectories):
        (qt_drt_pauseAnimation):
        (qt_drt_pauseTransitionOfProperty):
        (qt_drt_resetOriginAccessWhiteLists):
        (qt_drt_run):
        (qt_drt_setJavaScriptProfilingEnabled):
        (qt_drt_whiteListAccessFromOrigin):
        (qt_webpage_groupName):
        (qt_webpage_setGroupName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 18:02:47 +0000 (18:02 +0000)]
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Let's cache nodelists instead of DynamicNodeList::Caches
        https://bugs.webkit.org/show_bug.cgi?id=33696

        * fast/dom/Element/node-list-identity-expected.txt: Added to verify that node lists are indeed cached
        * fast/dom/Element/node-list-identity.html: Added to verify that node lists are indeed cached
        * fast/dom/gc-9-expected.txt: Updated to follow changed semantics of caching
        * fast/dom/gc-9.html: Updated to follow changed semantics of caching
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Let's cache nodelists instead of DynamicNodeList::Caches
        https://bugs.webkit.org/show_bug.cgi?id=33696

        Test: fast/dom/Element/node-list-identity.html

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::markChildren): Mark all cached node lists as well
        * dom/ClassNodeList.cpp:
        (WebCore::ClassNodeList::ClassNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::ClassNodeList::~ClassNodeList): Remove from the cache
        * dom/ClassNodeList.h: Added a field with original class names to be used as a key for removal from the cache
        (WebCore::ClassNodeList::create): Don't need DynamicNodeList::Caches argument any more
        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::NameNodeList::~NameNodeList): Remove from the cache
        * dom/NameNodeList.h:
        (WebCore::NameNodeList::create): Don't need DynamicNodeList::Caches argument any more
        * dom/Node.cpp:
        (WebCore::Node::removeCachedClassNodeList): Remove ClassNodeList from the cache
        (WebCore::Node::removeCachedNameNodeList): Remove NameNodeList from the cache
        (WebCore::Node::removeCachedTagNodeList): Remove TagNodeList from the cache
        (WebCore::Node::getElementsByTagNameNS): Switch to caching node lists themselves, not the data
        (WebCore::Node::getElementsByName): Switch to caching node lists themselves, not the data
        (WebCore::Node::getElementsByClassName): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::invalidateCaches): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::isEmpty): Switch to caching node lists themselves, not the data
        (WebCore::markNodeLists): Helper to mark all the node lists in the cache
        (WebCore::Node::markCachedNodeListsSlow): Mark all the cached node lists if any could be present
        * dom/Node.h:
        (WebCore::Node::markCachedNodeLists): Fast-path marking of cached node lists---bails out if there is no rare data
        * dom/NodeRareData.h: Changed type of caches to hold raw pointers to node lists, not RefPtr's to data
        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::TagNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::TagNodeList::~TagNodeList): Remove from the cache
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create): Don't need DynamicNodeList::Caches argument any more

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 17:45:03 +0000 (17:45 +0000)]
2010-04-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        [Chromium] Update ScriptProfileNode to retrieve execution time in milliseconds.

        https://bugs.webkit.org/show_bug.cgi?id=38330

        * bindings/v8/ScriptProfileNode.cpp:
        (WebCore::ScriptProfileNode::totalTime):
        (WebCore::ScriptProfileNode::selfTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Marcus Bulach <bulach@chromium.org>
jorlow@chromium.org [Thu, 29 Apr 2010 17:41:56 +0000 (17:41 +0000)]
2010-04-29  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Rebaseline chromium SVG tests
        This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=37986
        https://bugs.webkit.org/show_bug.cgi?id=38106

        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.txt:
        * platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/chromium-linux/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
        * platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/chromium-mac/fast/images: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/traversal: Added.
        * platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
        * platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
        * platform/chromium-win/svg/carto.net/tabgroup-expected.txt: Added.
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/fill-fallback-expected.txt:
        * platform/chromium-win/svg/custom/gradient-cycle-detection-expected.txt:
        * platform/chromium-win/svg/custom/gradient-deep-referencing-expected.txt:
        * platform/chromium-win/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
        * platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-update-gradient-expected.checksum:
        * platform/chromium-win/svg/custom/js-update-gradient-expected.png:
        * platform/chromium-win/svg/custom/pattern-cycle-detection-expected.txt:
        * platform/chromium-win/svg/custom/pattern-deep-referencing-expected.txt:
        * platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
        * platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
        * platform/chromium-win/svg/custom/stroke-fallback-expected.txt:
        * platform/chromium-win/svg/custom/stroked-pattern-expected.txt:
        * platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/chromium-win/svg/hixie/error/003-expected.txt:
        * platform/chromium-win/svg/hixie/perf/005-expected.txt:
        * platform/chromium-win/svg/hixie/perf/006-expected.txt:
        * platform/chromium-win/svg/text/selection-background-color-expected.txt:
        * platform/chromium-win/svg/text/selection-styles-expected.txt:
        * platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
        * platform/chromium-win/traversal: Added.
        * platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 17:35:12 +0000 (17:35 +0000)]
2010-04-29  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Get rid of forceLayout() on FrameView
        https://bugs.webkit.org/show_bug.cgi?id=38199

        The function FrameView::forceLayout() is missleading
        because it does not actually force the layout, the call is
        equivalent to layout().

        This patch replace the call to forceLayout() by layout() in Qt
        to avoid the misunderstanding/improve readability.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):
        (QWebPage::setPreferredContentsSize):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setMediaType):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::forceLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 29 Apr 2010 16:43:50 +0000 (16:43 +0000)]
2010-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58498.
        http://trac.webkit.org/changeset/58498
        https://bugs.webkit.org/show_bug.cgi?id=38332

        "Broke a bunch of tests on Chromium canaries" (Requested by
        dglazkov on #webkit).

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations tweak.
dglazkov@chromium.org [Thu, 29 Apr 2010 16:23:57 +0000 (16:23 +0000)]
Unreviewed, expectations tweak.

Update stale expectations I accidentally checked in in http://trac.webkit.org/changeset/58520
https://bugs.webkit.org/show_bug.cgi?id=9756

* fast/forms/implicit-submission-expected.txt: Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA form without a submit button unexpectedly performs its action when Return is pressed
dglazkov@chromium.org [Thu, 29 Apr 2010 15:53:34 +0000 (15:53 +0000)]
A form without a submit button unexpectedly performs its action when Return is pressed
https://bugs.webkit.org/show_bug.cgi?id=9756

Reviewed by Darin Adler.

WebCore:

Implemented implicit form submission algorithm as defined in HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission,
falling back to match IE's behavior in the edge cases.

The underlying rules are:

* If the form has no enabled submit buttons, submit if Enter/Return is pressed on the only single-line text field.

* Otherwise, submit form using first enabled submit button if Enter/Return is pressed on a field
  that's not a textarea or a select.

Test: fast/forms/implicit-submission.html

* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler): Ripped out implicit submission for select elements.
(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Ditto.
* dom/SelectElement.h: Ditto.
(WebCore::HTMLFormElement::submitImplicitly): Renamed submitClick to submitImplicitly to better match HTML5 spec
    language, changed the logic to match the rules above.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Reamed clickDefaultButton to implicitSubmission to better match
    HTML5 spec language, made radio element to trigger implicit submission.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Removed passing of form() as parameter, because it's no longer
    necessary.

LayoutTests:

A comprehensive test for various edge cases involving implicit form submission.

* fast/forms/implicit-submission-expected.txt: Added.
* fast/forms/implicit-submission.html: Added.
* fast/forms/check-box-enter-key-expected.txt: Removed because it's now part of implicit-submission.html.
* fast/forms/check-box-enter-key.html: Ditto.
* fast/forms/select-enter-key-expected.txt: Ditto.
* fast/forms/select-enter-key.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 15:46:50 +0000 (15:46 +0000)]
2010-04-29  Paweł Hajdan, Jr.  <phajdan.jr@chromium.org>

        Reviewed by Jeremy Orlow.

        Fix building with libpng-1.4.
        https://bugs.webkit.org/show_bug.cgi?id=33287

        No new tests (no behavior change).

        Original patch by John Bowler <jbowler@acm.org>

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 29 Apr 2010 15:26:22 +0000 (15:26 +0000)]
2010-04-29  Adam Langley  <agl@chromium.org>

        Unreviewed, DEPS roll.

        WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
        r45932.

        * DEPS:
          Use Chromium r45932.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 29 Apr 2010 14:57:55 +0000 (14:57 +0000)]
2010-04-29  Adam Langley  <agl@chromium.org>

        Reviewed by David Levin.

        This patch adds support for WOFF in Chromium. Since Chromium
        already transcodes all OpenType files for security reasons we
        are adding WOFF support into the transcoder.

        https://bugs.webkit.org/show_bug.cgi?id=38217

        * css/CSSFontFaceSrcValue.cpp:
        (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
          Recognise "woff" as a font-face format value (guarded by
          ENABLE(OPENTYPE_SANITIZER) at this point)
        * platform/graphics/opentype/OpenTypeSanitizer.cpp:
        (WebCore::OpenTypeSanitizer::sanitize):
          Change so that the transcoded font can be larger than the original.
          (WOFF files are compressed, so the transcoded TTF is typically
          larger.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Alex Milowski <alex@milowski.com>
eric@webkit.org [Thu, 29 Apr 2010 14:26:20 +0000 (14:26 +0000)]
2010-04-29  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        Updates to the Qt build to enable building MathML support.

        * WebCore.pri:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd sqrt() instruction support for ARM assembler (using VFP)
zherczeg@webkit.org [Thu, 29 Apr 2010 14:08:44 +0000 (14:08 +0000)]
Add sqrt() instruction support for ARM assembler (using VFP)
https://bugs.webkit.org/show_bug.cgi?id=38312

Reviewed by Oliver Hunt

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fsqrtd_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::sqrtDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:44 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_element_by_id;

        * tests/testdomdocument.c:
        (test_dom_document_get_element_by_id):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:32 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_elements_by_class_name.

        * tests/testdomdocument.c:
        (test_dom_document_get_elements_by_class_name):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:19 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_elements_by_tag_name.

        * tests/testdomdocument.c:
        (test_dom_document_get_elements_by_tag_name):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:07 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Add WebKitDOMDocument tests to the build.

        * GNUmakefile.am:

WebKit/gtk:

2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Move WebKitDOMDocument unit tests to their own file.

        * tests/testdomdocument.c: Added.
        (finish_loading):
        (dom_document_fixture_setup):
        (dom_document_fixture_teardown):
        (test_dom_document_title):
        (main):
        * tests/testwebview.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:49:52 +0000 (13:49 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Do not generate unneeded boilerplate in {get,set}_property methods
        when there are no properties to generate code for. This gets rid
        of lots of compiler warnings.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:48:53 +0000 (13:48 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Include <webkit/webkitdom.h> in the main webkit.h header.

        * webkit/webkit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Loading of large page can take up to 10 seconds
ossy@webkit.org [Thu, 29 Apr 2010 13:37:38 +0000 (13:37 +0000)]
[Qt] Loading of large page can take up to 10 seconds
https://bugs.webkit.org/show_bug.cgi?id=31719

Rubber-stamped by Simon Hausmann.

Followup patch. Update expected files because of minor differences.
(size of whitespaces, place of linebreaks)

* platform/qt/css1/basic/inheritance-expected.txt:
* platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
* platform/qt/css1/box_properties/float_margin-expected.txt:
* platform/qt/css1/color_and_background/background_attachment-expected.txt:
* platform/qt/css1/color_and_background/background_repeat-expected.txt:
* platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/qt/css1/font_properties/font-expected.txt:
* platform/qt/css1/font_properties/font_style-expected.txt:
* platform/qt/css1/formatting_model/inline_elements-expected.txt:
* platform/qt/css1/text_properties/line_height-expected.txt:
* platform/qt/css1/text_properties/text_decoration-expected.txt:
* platform/qt/css1/text_properties/text_indent-expected.txt:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css2.1/t1202-counter-01-b-expected.txt:
* platform/qt/css2.1/t1202-counter-02-b-expected.txt:
* platform/qt/css2.1/t1202-counter-03-b-expected.txt:
* platform/qt/css2.1/t1202-counter-04-b-expected.txt:
* platform/qt/css2.1/t1202-counters-01-b-expected.txt:
* platform/qt/css2.1/t1202-counters-02-b-expected.txt:
* platform/qt/css2.1/t1202-counters-03-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
* platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
* platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/size/zero-expected.txt:
* platform/qt/fast/css/font-face-opentype-expected.txt:
* platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt:
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
* platform/qt/fast/text/fake-italic-expected.txt:
* platform/qt/fast/text/international/khmer-selection-expected.txt:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/qt/svg/filters/feColorMatrix-values-expected.txt:
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
* platform/qt/svg/text/selection-background-color-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.txt:
* platform/qt/svg/text/selection-styles-expected.txt:
* platform/qt/svg/text/selection-tripleclick-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Speed up text layouting
ossy@webkit.org [Thu, 29 Apr 2010 13:36:00 +0000 (13:36 +0000)]
[Qt] Speed up text layouting
https://bugs.webkit.org/show_bug.cgi?id=31719

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-04-29
Reviewed by Kenneth Rohde Christiansen.

Use QFontMetrics::width() for the text width calculation instead
of QTextLayout. This avoids expensive bearing calculations and the
line breaking code.

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 29 Apr 2010 13:11:26 +0000 (13:11 +0000)]
2010-04-29  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Export g_stackBase with JS_EXPORTDATA
        https://bugs.webkit.org/show_bug.cgi?id=37437

        Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.

        * platform/wince/SharedTimerWince.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Skip editing/pasteboard/drag-drop-input-textarea.html on GTK and Qt.
tkent@chromium.org [Thu, 29 Apr 2010 12:05:32 +0000 (12:05 +0000)]
Unreviewed.  Skip editing/pasteboard/drag-drop-input-textarea.html on GTK and Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:46:33 +0000 (11:46 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Remove custom bindings for PopStateEvent.initPopStateEvent
        https://bugs.webkit.org/show_bug.cgi?id=38311

        Our code generation of SerializedScriptValue was slightly buggy, but
        it's easy to fix.  Notice that the conversion to an atomic string is
        handled by the C++ type system and doesn't require logic in the code
        generator.

        * bindings/js/JSPopStateEventCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_serialized_value):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionSerializedValue):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj serializedValue:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::serializedValueCallback):
        (WebCore::ConfigureV8TestObjTemplate):
        * bindings/v8/custom/V8PopStateEventCustom.cpp:
        * dom/PopStateEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:29:07 +0000 (11:29 +0000)]
2010-04-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests can deadlock with Chromium's TestShell
        https://bugs.webkit.org/show_bug.cgi?id=38298

        Fix _write_command_and_read_line to never send unicode() to
        test_shell, instead to always encode as utf-8.  This was causing
        random hangs because if test_shell ever encounters a \0 in the
        stream it can deadlock with NRWT.

        There is still a deadlock bug to fix in NRWT/test_shell design, however
        this fix should make the deadlock occur less often.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 29 Apr 2010 11:23:12 +0000 (11:23 +0000)]
2010-04-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that selection drag-and-drop doesn't work for input/textarea.
        https://bugs.webkit.org/show_bug.cgi?id=38175

        * editing/pasteboard/drag-drop-input-textarea-expected.txt: Added.
        * editing/pasteboard/drag-drop-input-textarea.html: Added.
2010-04-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that selection drag-and-drop doesn't work for input/textarea.
        https://bugs.webkit.org/show_bug.cgi?id=38175

        The code supposed the selected region was in the destination text
        field. It is not true in a case of drag-and-drop.

        Test: editing/pasteboard/drag-drop-input-textarea.html

        * dom/InputElement.cpp:
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:18:22 +0000 (11:18 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Remove custom bindings for NodeFilter.acceptNode
        https://bugs.webkit.org/show_bug.cgi?id=38309

        This "custom" code was just an instance of the CallWith=ScriptState
        pattern.  Also, it looks like V8 just had a garbage implemenation that
        did nothing.

        * WebCore.gypi:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
        * dom/NodeFilter.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 11:05:11 +0000 (11:05 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebkit doesn't link with 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=38299

        Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.

        No new tests: build fix

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 11:02:36 +0000 (11:02 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Maciej Stachowiak.

        Add missing pixel test results for several tests on Mac. Now doesn't create any new files anymore, when running run-webkit-tests -p.

        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Added.
        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.png: Added.
        * platform/mac/fast/runin/generated2-expected.checksum: Added.
        * platform/mac/fast/runin/generated2-expected.png: Added.
        * platform/mac/fast/runin/generated3-expected.checksum: Added.
        * platform/mac/fast/runin/generated3-expected.png: Added.
        * platform/mac/fast/runin/generated4-expected.checksum: Added.
        * platform/mac/fast/runin/generated4-expected.png: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:55:22 +0000 (10:55 +0000)]
2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Darin Fisher.

        Include WindowFeatures in call to WebViewClient::createView.

        https://bugs.webkit.org/show_bug.cgi?id=38301

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary call to FrameView::forceLayout() in setViewportSize()
hausmann@webkit.org [Thu, 29 Apr 2010 10:42:59 +0000 (10:42 +0000)]
Remove unnecessary call to FrameView::forceLayout() in setViewportSize()
This prevents a double relayout on resize.

Patch by Andreas Kling <andreas.kling@nokia.com> on 2010-04-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38179

Thanks to Nate Whetsell <nathan.whetsell@gmail.com> for spotting this.

* Api/qwebpage.cpp:
(QWebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:35:11 +0000 (10:35 +0000)]
2010-04-29  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Expose the RuntimeFeature for touch events through the
        WebRuntimeFeatures mechanism.
        https://bugs.webkit.org/show_bug.cgi?id=37486

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableTouch):
        (WebKit::WebRuntimeFeatures::isTouchEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactored svn-apply and svn-unapply to use the new
cjerdonek@webkit.org [Thu, 29 Apr 2010 10:33:18 +0000 (10:33 +0000)]
Refactored svn-apply and svn-unapply to use the new
parsePatch() subroutine.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34033

* Scripts/VCSUtils.pm:
  - Consolidated %diffHash documentation.
  - Added prepareParsedPatch().

* Scripts/svn-apply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/svn-unapply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/test-webkitperl:
  - Changed to render relative test paths rather than absolute
    test paths.

* Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
  - Added unit tests for prepareParsedPatch().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:25:16 +0000 (10:25 +0000)]
2010-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Refactor qtscriptglobal.h
        https://bugs.webkit.org/show_bug.cgi?id=37953

        Use the same pattern in qtscriptglobal.h as in
        qwebkitglobal.h without checking for specific OSs.

        * qt/api/qtscriptglobal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
hausmann@webkit.org [Thu, 29 Apr 2010 10:20:29 +0000 (10:20 +0000)]
[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
https://bugs.webkit.org/show_bug.cgi?id=38316

Reviewed by Tor Arne Vestbø.

Accessing properties of a deleted objects doesn't throw an exception
anymore.

Continue to expose the QObject class wrapper for objects that
previously existed but don't exist anymore. QtClass is safe to
use with a deleted QObject.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getClass): Return null only if m_class
doesn't exist yet and there's no m_object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:04:47 +0000 (10:04 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        Reverse animations don't work in some use cases
        https://bugs.webkit.org/show_bug.cgi?id=38075

        This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
        with the CA implementation. That special case code path is now a bug - and this patch removes it.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
        animation correctly.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::applyFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 09:42:46 +0000 (09:42 +0000)]
Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt: fast/media/media-query-invalid-value.html should be MISSING, not IMAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>
eric@webkit.org [Thu, 29 Apr 2010 09:33:42 +0000 (09:33 +0000)]
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        Test whether HTMLOptionElement::ownerSelectElement() is considering the keygen element.
        https://bugs.webkit.org/show_bug.cgi?id=26016

        * fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
        * fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
        https://bugs.webkit.org/show_bug.cgi?id=26016

        Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.

        Test: fast/dom/HTMLKeygenElement/keygen-option-select.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::ownerSelectElement):
        Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 09:07:01 +0000 (09:07 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
        https://bugs.webkit.org/show_bug.cgi?id=38307

        balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
        We now properly ignored the subtree. s/def/defs/ and the testcase works again.

        fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
        Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.

        Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
        I can now run those tests with --tolerance 0 without a problem.

        * fast/backgrounds/resources/balloon.svg: s/def/defs/
        * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
        * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
        * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 08:57:36 +0000 (08:57 +0000)]
Unreviewed, test expectations update.

r58479 add fast/media/media-query-invalid-value.html, but it misses
image expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 29 Apr 2010 08:46:29 +0000 (08:46 +0000)]
2010-04-29  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Eric Seidel.

        Add EFL-specific code to Widget.h and move the empty
        frameRectsChanged() definition to Widget.cpp, since the EFL port
        needs to override that.
        http://webkit.org/b/36317

        No new tests required.

        * WebCore.base.exp:
        * platform/Widget.cpp:
        (WebCore::Widget::frameRectsChanged):
        * platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 29 Apr 2010 08:44:12 +0000 (08:44 +0000)]
2010-04-29  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        wrong filename: LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt
        https://bugs.webkit.org/show_bug.cgi?id=38310

        * platform/win/fast/text/international/bold-bengali-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
hausmann@webkit.org [Thu, 29 Apr 2010 08:41:53 +0000 (08:41 +0000)]
[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
https://bugs.webkit.org/show_bug.cgi?id=38314

Reviewed by Tor Arne Vestbø.

Make sure that there's always a main frame when returning from createWindow()
to the caller in WebCore.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 29 Apr 2010 08:25:56 +0000 (08:25 +0000)]
2010-04-29  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
        https://bugs.webkit.org/show_bug.cgi?id=38216

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 08:14:50 +0000 (08:14 +0000)]
2010-04-29  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Small cleanup.

        QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
        as a parameter, because it breaks a private / public separation rule.
        QScriptEnginePrivate::get(QScriptEngine*) should return
        a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
        implementation.

        [Qt] QScriptValuePrivate class needs some cleanup.
        https://bugs.webkit.org/show_bug.cgi?id=37729

        * qt/api/qscriptengine_p.h:
        (QScriptEnginePrivate::get):
        * qt/api/qscriptvalue.cpp:
        (QScriptValue::QScriptValue):
        * qt/api/qscriptvalue_p.h:
        (QScriptValuePrivate::QScriptValuePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 29 Apr 2010 07:52:37 +0000 (07:52 +0000)]
2010-04-29  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Export g_stackBase with JS_EXPORTDATA
        https://bugs.webkit.org/show_bug.cgi?id=37437

        Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.

        * runtime/Collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 29 Apr 2010 07:42:12 +0000 (07:42 +0000)]
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
        (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
        (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
        * html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
        * platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 07:15:15 +0000 (07:15 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
        https://bugs.webkit.org/show_bug.cgi?id=38076

        This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
        animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
        is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
        upon stop (updateState) and not upon the object's destruction.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
        the animation is toggled frequently.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::TransformAnimationQt::updateState):
        (WebCore::OpacityAnimationQt::~OpacityAnimationQt):
        (WebCore::OpacityAnimationQt::updateState):
        (WebCore::GraphicsLayerQt::removeAnimationsForProperty):
        (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 29 Apr 2010 07:05:32 +0000 (07:05 +0000)]
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        * fast/media/media-query-invalid-value-expected.txt: Added.
        * fast/media/media-query-invalid-value.html: Added.
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        Test: fast/media/media-query-invalid-value.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp):
        * css/MediaQueryExp.h:
        (WebCore::MediaQueryExp::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58479 268f45cc-cd09-0410-ab3c-d52691b4dbfc