WebKit-https.git
9 years ago2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 1 Jun 2011 07:46:13 +0000 (07:46 +0000)]
2011-05-31  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector [Chromium]: Put worker scripts into devtools_frontend.zip.
        https://bugs.webkit.org/show_bug.cgi?id=61803

        * WebKit.gyp:
        * scripts/generate_devtools_zip.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-01 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 1 Jun 2011 07:40:41 +0000 (07:40 +0000)]
2011-06-01  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Remove ShadowElement and compact remaining used bits into RenderFileUploadControl.
        https://bugs.webkit.org/show_bug.cgi?id=61816

        This is a near-mechanical move-and-rename of ShadowElement, which is now only
        used by input[type=file]. Next step -- switch it over to new shadow DOM.

        Refactoring, no change in behavior.

        * CMakeLists.txt: Removed ShadowElement.cpp and ShadowElement.h.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore/WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCore/rendering/RenderingAllInOne.cpp: Ditto.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::UploadButton::create): Moved from ShadowElement, renamed as UploadButton.
        (WebCore::UploadButton::detach): Ditto.
        (WebCore::UploadButton::UploadButton): Ditto.
        (WebCore::RenderFileUploadControl::updateFromElement): Changed to use UploadButton.
        * rendering/RenderMeter.cpp: Removed ShadowElement.h include, which is no longer used.
        * rendering/RenderProgress.cpp: Ditto.
        * rendering/ShadowElement.cpp: Removed.
        * rendering/ShadowElement.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-01 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Wed, 1 Jun 2011 07:30:10 +0000 (07:30 +0000)]
2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        SVG fails all 3 of Hixie's CSS intrinsic sizing tests
        https://bugs.webkit.org/show_bug.cgi?id=15473

        Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
        and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
        SVGs width/height attributes into account when determining the intrinsic size of the <object>.

        Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
        The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
        interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

        * platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-height-50p-on-target-svg-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-50p-on-target-svg-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Added.
        * platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.png: Added.
        * platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
        * platform/mac/svg/hixie/intrinsic: Added.
        * platform/mac/svg/hixie/intrinsic/001-expected.png: Added.
        * platform/mac/svg/hixie/intrinsic/001-expected.txt: Added.
        * platform/mac/svg/hixie/intrinsic/002-expected.png: Added.
        * platform/mac/svg/hixie/intrinsic/002-expected.txt: Added.
        * platform/mac/svg/hixie/intrinsic/003-expected.png: Added.
        * platform/mac/svg/hixie/intrinsic/003-expected.txt: Added.
        * svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml: Added.
        * svg/custom/object-sizing-height-50p-on-target-svg.xhtml: Added.
        * svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml: Added.
        * svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml: Added.
        * svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml: Added.
        * svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml: Added.
        * svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml: Added.
        * svg/custom/object-sizing-width-50p-on-target-svg.xhtml: Added.
        * svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml: Added.
        * svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml: Added.
        * svg/custom/resources/object-sizing-height-50p.svg: Added.
        * svg/custom/resources/object-sizing-width-50p-height-50p.svg: Added.
        * svg/custom/resources/object-sizing-width-50p-height-75p.svg: Added.
        * svg/custom/resources/object-sizing-width-50p.svg: Added.
        * svg/custom/resources/object-sizing-width-75p-height-50p.svg: Added.
        * svg/hixie/intrinsic: Added.
        * svg/hixie/intrinsic/001.html: Added.
        * svg/hixie/intrinsic/002.html: Added.
        * svg/hixie/intrinsic/003.html: Added.
        * svg/hixie/intrinsic/resources: Added.
        * svg/hixie/intrinsic/resources/001.svg: Added.
        * svg/hixie/intrinsic/resources/002.svg: Added.
        * svg/hixie/intrinsic/resources/003.svg: Added.
        * svg/hixie/intrinsic/resources/test-bl: Added.
        * svg/hixie/intrinsic/resources/test-br: Added.
        * svg/hixie/intrinsic/resources/test-tl: Added.
        * svg/hixie/intrinsic/resources/test-tr: Added.

2011-06-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        SVG fails all 3 of Hixie's CSS intrinsic sizing tests
        https://bugs.webkit.org/show_bug.cgi?id=15473

        Hixies CSS intrinsic sizing tests cover percentage sizes specified on the target SVG document as width/height attributes
        and using width: auto / height: auto on the <object> that hosts the SVG document. Take percentage sizes of the outermost
        SVGs width/height attributes into account when determining the intrinsic size of the <object>.

        Added several other testcases demonstrating several scenarios. All tests work exactly the same in WebKit and Firefox now.
        The *on-target-svg-absolute.xhtml tests look equal to WebKit/FF but Opera fails them, likely a relict of the different
        interpretation of the intrinsic size of a SVG document in SVG Tiny 1.2.

        Tests: svg/custom/object-sizing-height-50p-on-target-svg-absolute.xhtml
               svg/custom/object-sizing-height-50p-on-target-svg.xhtml
               svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute.xhtml
               svg/custom/object-sizing-width-50p-height-50p-on-target-svg.xhtml
               svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute.xhtml
               svg/custom/object-sizing-width-50p-height-75p-on-target-svg.xhtml
               svg/custom/object-sizing-width-50p-on-target-svg-absolute.xhtml
               svg/custom/object-sizing-width-50p-on-target-svg.xhtml
               svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute.xhtml
               svg/custom/object-sizing-width-75p-height-50p-on-target-svg.xhtml
               svg/hixie/intrinsic/001.html
               svg/hixie/intrinsic/002.html
               svg/hixie/intrinsic/003.html

        * rendering/RenderPart.cpp:
        (WebCore::RenderPart::computeReplacedLogicalWidth):
        (WebCore::RenderPart::computeReplacedLogicalHeight):
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::computeIntrinsicRatio):
        * rendering/svg/RenderSVGRoot.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-01 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 07:16:05 +0000 (07:16 +0000)]
2011-06-01  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert editing/pasteboard/4861010 to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61683

        Renamed test to drag-drop-list.html, cleaned up html, and updated description.

        * editing/pasteboard/4861080.html: Removed.
        * editing/pasteboard/drag-drop-list.html: Copied from LayoutTests/editing/pasteboard/4861080.html.
        * platform/chromium-linux/editing/pasteboard/4861080-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/4861080-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/4861080-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/4861080-expected.png: Removed.
        * platform/gtk/editing/pasteboard/4861080-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/4861080-expected.png: Removed.
        * platform/mac/editing/pasteboard/4861080-expected.png: Removed.
        * platform/mac/editing/pasteboard/4861080-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 1 Jun 2011 06:57:51 +0000 (06:57 +0000)]
2011-05-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Convert fast/forms/date-input-visible-strings.html to dumpAsText().
        https://bugs.webkit.org/show_bug.cgi?id=61777

        * fast/forms/date-input-visible-strings.html:
        * fast/forms/date-input-visible-strings-expected.txt: Added.
        * platform/chromium-linux/fast/forms/date-input-visible-strings-expected.png: Removed.
        * platform/chromium-mac-leopard/fast/forms/date-input-visible-strings-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-input-visible-strings-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-input-visible-strings-expected.txt: Removed.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.png: Removed.
        * platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Removed.
        * platform/mac/fast/forms/date-input-visible-strings-expected.png: Removed.
        * platform/mac/fast/forms/date-input-visible-strings-expected.txt: Removed.
        * platform/win/fast/forms/date-input-visible-strings-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 06:25:44 +0000 (06:25 +0000)]
2011-05-31  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Timeline panel improvements for managing current selection
        https://bugs.webkit.org/show_bug.cgi?id=61468

        Enables X-axis dragging of the selected area.
        Double click zoom-out.
        Fixes slightly wrong selection area position.

        * inspector/front-end/TimelineOverviewPane.js:
        (WebInspector.TimelineOverviewPane):
        (WebInspector.TimelineOverviewPane.prototype._dragWindow):
        (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
        (WebInspector.TimelineOverviewPane.prototype._resizeWindowMaximum):
        (WebInspector.TimelineOverviewPane.prototype.scrollWindow):
        (WebInspector.TimelineOverviewPane.prototype._createTimelineCategoryStatusBarCheckbox):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 06:18:43 +0000 (06:18 +0000)]
2011-05-31  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        Convert editing/pasteboard/paste-blockquote-into-blockquote-2.html to dump-as-markup
        https://bugs.webkit.org/show_bug.cgi?id=61682

        Convert test to dump-as-markup and clean up HTML. Also update test description.

        * editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
        * editing/pasteboard/paste-blockquote-into-blockquote-2.html:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
        * platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
        * platform/mac-leopard/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.png: Removed.
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Hao Zheng <zhenghao@chromium.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 05:54:40 +0000 (05:54 +0000)]
2011-05-31  Hao Zheng  <zhenghao@chromium.org>

        Reviewed by Dirk Pranke.

        Fix exception in verbose printing mode.
        https://bugs.webkit.org/show_bug.cgi?id=61723

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Wed, 1 Jun 2011 05:46:37 +0000 (05:46 +0000)]
2011-05-31  Keishi Hattori  <keishi@webkit.org>

        Reviewed by Kent Tamura.

        Fix to enable page scroll of select element
        https://bugs.webkit.org/show_bug.cgi?id=53628

        Manual test: select-page-scroll.html

        * manual-tests/select-page-scroll.html: Added.
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::computeLogicalHeight): Fix min to max.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 1 Jun 2011 05:09:52 +0000 (05:09 +0000)]
2011-05-31  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
        https://bugs.webkit.org/show_bug.cgi?id=61823

        Added a new test for the fix marked the new test 'skipped' on unsupported platforms.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/storageinfo-no-callbacks-expected.txt: Added.
        * storage/storageinfo-no-callbacks.html: Added.
2011-05-31  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given.
        https://bugs.webkit.org/show_bug.cgi?id=61823

        Fixed assertion on errorCallback parameter.

        Test: storage/quotainfo-no-callbacks.html

        * src/StorageInfoChromium.cpp:
        (WebCore::StorageInfo::queryUsageAndQuota):
        (WebCore::StorageInfo::requestQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 02:40:27 +0000 (02:40 +0000)]
2011-05-31  Yong Li  <yoli@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=54807
        We have been assuming plain bitfields (like "int a : 31") are always signed integers.
        However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
        bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
        http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
        Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
        always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
        rule we should have in order to make our code independent from compilers and compiler flags.

        No new test added because this change is not known to fix any issue.

        * bytecode/StructureStubInfo.h:
2011-05-31  Yong Li  <yoli@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=54807
        We have been assuming plain bitfields (like "int a : 31") are always signed integers.
        However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
        bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
        http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
        Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
        always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
        rule we should have in order to make our code independent from compilers and compiler flags.

        No new test added because this change is not known to fix any issue.

        * css/CSSPrimitiveValue.h:
        * css/CSSProperty.h:
        * rendering/InlineBox.h:
        * rendering/RenderBlock.h:
2011-05-31  Yong Li  <yoli@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=54807
        We have been assuming plain bitfields (like "int a : 31") are always signed integers.
        However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
        bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
        http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
        Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
        always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
        rule we should have in order to make our code independent from compilers and compiler flags.

        * Scripts/webkitpy/style/checkers/cpp.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Hironori Bono <hbono@chromium.org>
morrita@google.com [Wed, 1 Jun 2011 02:25:47 +0000 (02:25 +0000)]
2011-05-31  Hironori Bono  <hbono@chromium.org>

        Reviewed by Eric Seidel.

        Send an input event when we change the text direction.
        https://bugs.webkit.org/show_bug.cgi?id=50952

        This adds a new layout test to verify that we can receive input events
        when we change the text direction of a <textarea> element and an <input>
        element.

        * fast/html/set-text-direction-expected.txt: Added.
        * fast/html/set-text-direction.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-31  Hironori Bono  <hbono@chromium.org>

        Reviewed by Eric Seidel.

        Send an input event when we change the text direction.
        https://bugs.webkit.org/show_bug.cgi?id=50952

        Both Safari and Chrome call Editor::setBaseWritingDirection() to change
        the text direction of an editable element with their UIs. This change
        calls dispatchInputEvent() to send an input event when the function
        actually changes the "dir" attribute so we can send an input event as
        written in the HTML5 spec.

        Test: fast/html/set-text-direction.html

        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection):
2011-05-31  Hironori Bono  <hbono@chromium.org>

        Reviewed by Eric Seidel.

        Add a JavaScript function layoutTestController.setTextDirection().
        https://bugs.webkit.org/show_bug.cgi?id=50952

        This change adds a new JavaScript function setTextDirection() to the
        LayoutTestController class of Safari and Chrome to write layout tests
        that changes the text direction of an editable element.

        * DumpRenderTree/LayoutTestController.cpp:
        (setTextDirectionCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setTextDirection):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setTextDirection):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setTextDirection):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setTextDirection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Chris Evans <cevans@chromium.org>
cevans@google.com [Wed, 1 Jun 2011 02:22:52 +0000 (02:22 +0000)]
2011-05-31  Chris Evans  <cevans@chromium.org>

        Reviewed by Drew Yao.

        Add "Collaboration" to WebKit Security Group Privileges and Responsibilities section.

        * security/index.html: Add "Collaboration" section with text discussed on webkit-security.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Wed, 1 Jun 2011 01:48:53 +0000 (01:48 +0000)]
2011-05-31  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Flash of black at the end of full screen transition at apple.com product videos
        https://bugs.webkit.org/show_bug.cgi?id=61756

        Added two new entries to the WebCore exports list.

        * WebCore.exp.in:
2011-05-31  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        Flash of black at the end of full screen transition at apple.com product videos
        https://bugs.webkit.org/show_bug.cgi?id=61756

        The @"WebKitLayerHostChanged" notification is causing the QTMovie to tear down its layer
        (which is good) at the wrong time (which is bad).  Send this notification only after
        the dragImage snapshot is taken.  This exposed another problem, that the snapshot has
        a white background.  Set the default background color and transparency for the view (making
        sure to reset them afterwards) to transparent.

        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 01:47:23 +0000 (01:47 +0000)]
2011-05-31  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::render() failing
        https://bugs.webkit.org/show_bug.cgi?id=60893

        Due a problem on QPicture (http://bugreports.qt.nokia.com/browse/QTBUG-19496),
        this test was calculating the final geometry incorrectly. As the order between
        a translate and a draw operation could be relevant for it, but not for the
        final rendered result, they were changed on ScrollbarThemeQt::paint.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paint):
2011-05-31  Rafael Brandao  <rafael.lobo@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::render() failing
        https://bugs.webkit.org/show_bug.cgi?id=60893

        The test was expecting the frame contents to be already loaded
        before rendering it into a QPicture. Renamed the test to fit
        its real purpose more accordingly.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::renderGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Wed, 1 Jun 2011 01:26:11 +0000 (01:26 +0000)]
2011-05-31  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] gtkdoc run produces many warnings about missing declarations
        https://bugs.webkit.org/show_bug.cgi?id=61797

        * docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
        to reduce the number of gtkdoc warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Raphael Kubo da Costa <kubo@profusion.mobi>
commit-queue@webkit.org [Wed, 1 Jun 2011 01:05:12 +0000 (01:05 +0000)]
2011-05-31  Raphael Kubo da Costa  <kubo@profusion.mobi>

        Reviewed by Adam Barth.

        [efl] Add ewk API to enable/disable developer extras.
        https://bugs.webkit.org/show_bug.cgi?id=61746

        Add ewk_view_setting_enable_developer_extras_{get,set}, which is used
        to enable or disable developer extras (currently, the Web Inspector)
        in a given view.

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (ewk_view_setting_enable_developer_extras_get):
        (ewk_view_setting_enable_developer_extras_set):
        * ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Daniel Erat <derat@chromium.org>
commit-queue@webkit.org [Wed, 1 Jun 2011 00:43:32 +0000 (00:43 +0000)]
2011-05-31  Daniel Erat  <derat@chromium.org>

        Reviewed by Tony Chang.

        Make WebScreenInfoFactory return fresh screen dimensions.
        https://bugs.webkit.org/show_bug.cgi?id=61679

        * public/x11/WebScreenInfoFactory.h:
        * src/x11/WebScreenInfoFactory.cpp:
        (WebKit::WebScreenInfoFactory::screenInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
ademar.reis@openbossa.org [Wed, 1 Jun 2011 00:14:56 +0000 (00:14 +0000)]
2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Simon Hausmann.

        [Qt] User-agent list of Qt test browsers is very outdated
        https://bugs.webkit.org/show_bug.cgi?id=61531

        The user can edit the user-agent manually, so there's no need to have
        a super complete and up to date list, but it's nice to have it
        minimally updated.

        * MiniBrowser/qt/useragentlist.txt:
        * QtTestBrowser/useragentlist.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-27 Adrienne Walker <enne@google.com>
enne@google.com [Tue, 31 May 2011 23:49:22 +0000 (23:49 +0000)]
2011-05-27  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix crash from empty reflections with masks
        https://bugs.webkit.org/show_bug.cgi?id=61654

        * compositing/reflections/empty-reflection-with-mask-expected.txt: Added.
        * compositing/reflections/empty-reflection-with-mask.html: Added.
2011-05-27  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Fix crash from empty reflections with masks
        https://bugs.webkit.org/show_bug.cgi?id=61654

        Change the iteration for updateCompositorResources to match that being
        done in the paint and draw steps.  This mismatch of iteration style
        was causing layers with replica masks to correctly get skipped while
        painting but not get skipped during texture upload.

        Test: compositing/reflections/empty-reflection-with-mask.html

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::updateCompositorResources):
        * platform/graphics/chromium/LayerRendererChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 31 May 2011 23:35:34 +0000 (23:35 +0000)]
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] [WebKit2] Implement a basic WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57068

        * GNUmakefile.am: Added reference to WebKitTestRunner GNUmakefile.
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] [WebKit2] Implement a basic WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57068

        Added InjectedBundle support for GTK+.

        * WebProcess/InjectedBundle/InjectedBundle.h: Added typedef for GTK+.
        * WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp: Added implementation.
        (WebKit::InjectedBundle::load):
        (WebKit::InjectedBundle::activateMacFontAscentHack):
        * WebProcess/WebPage/gtk/WebPageGtk.cpp: Remove unnecessary method definition.
2011-03-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        [GTK] [WebKit2] Implement a basic WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=57068

        Add an implementation of WebKitTestRunner for GTK+.

        * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
        * Scripts/old-run-webkit-tests: Ditto.
        * Scripts/run-launcher: Ditto.
        * Scripts/webkitdirs.pm: Ditto.
        * WebKitTestRunner/GNUmakefile.am: Added.
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
        * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
        * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
        * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
        * WebKitTestRunner/PlatformWebView.h:
        * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
        * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
        * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
        (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
        * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
        (main): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Berend-Jan Wever <skylined@chromium.org>
commit-queue@webkit.org [Tue, 31 May 2011 22:40:17 +0000 (22:40 +0000)]
2011-05-31  Berend-Jan Wever  <skylined@chromium.org>

        Reviewed by Adam Barth.

        Add test to make sure an error in requestFileSystem or resolveLocalFileSystemURI
        when no error callback is supplied does not cause a NULL ptr.
        https://bugs.webkit.org/show_bug.cgi?id=49539

        * fast/filesystem/filesystem-no-callback-null-ptr-crash.html: Added.
        * fast/filesystem/filesystem-no-callback-null-ptr-crash-expected.txt: Added.
2011-05-31  B.J. Wever  <skylined@chromium.org>

        Reviewed by Adam Barth.

        requestFileSystem and resolveLocalFileSystemURI are not checking if
        errorCallback is NULL before scheduling a callback on error.
        https://bugs.webkit.org/show_bug.cgi?id=49539

        Test: fast/filesystem/filesystem-no-callback-null-ptr-crash.html

        * fileapi/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::scheduleCallback): Only call callback if
          one is supplied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 31 May 2011 22:26:55 +0000 (22:26 +0000)]
2011-05-31  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
        https://bugs.webkit.org/show_bug.cgi?id=60241

        * Scripts/new-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_...
beidson@apple.com [Tue, 31 May 2011 22:13:06 +0000 (22:13 +0000)]
Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494

Reviewed by Darin Adler.

Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.

No new tests. No change in behavior.

Instead of storing the DocumentLoader at construction and never changing it,
always calculate it based on the FrameLoader's current DocumentLoader:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::suggestedMIMEType):
(WebCore::Document::lastModified):
(WebCore::Document::initSecurityContext):
(WebCore::Document::updateURLForPushOrReplaceState):
(WebCore::Document::loader):
* dom/Document.h:

Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
* platform/mac/HTMLConverter.mm:
(fileWrapperForElement):

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigat...
mitz@apple.com [Tue, 31 May 2011 22:11:28 +0000 (22:11 +0000)]
<rdar://problem/9523192> REGRESSION (5.0.5-ToT, WebKit2): Flash to white when navigating between pages on wsj.com, other sites (when navigating away from composited page)
https://bugs.webkit.org/show_bug.cgi?id=61808

Reviewed by Simon Fraser.

WebKit1 has a mechanism to prevent the stale bits from the outgoing page from being erased
until the incoming page has layout. Adapt this in WebKit2 to prevent the composited layer tree
of the outgoing page from being torn down or updated until the incoming page has layout.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidFirstLayout): Unfreeze the layer tree state.
(WebKit::WebFrameLoaderClient::frameLoadCompleted): Ditto.
(WebKit::WebFrameLoaderClient::provisionalLoadStarted): Freeze the layer tree state.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setLayerTreeStateIsFrozen): Added.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl): Initialize new member variables.
(WebKit::DrawingAreaImpl::setLayerTreeStateIsFrozen): Added. When freezing, sets the flag and
disables layer flush scheduling and exiting accelerated compositing mode. When unfreezing,
clears the flag and exits compositing mode if needed.
(WebKit::DrawingAreaImpl::setRootCompositingLayer): Reset m_wantsToExitAcceleratedCompositingMode.
(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon): If the layer tree state is frozen,
bail out but set m_wantsToExitAcceleratedCompositingMode.

* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/LayerTreeHost.h:

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Initialize m_layerFlushSchedulingEnabled.

* WebProcess/WebPage/ca/LayerTreeHostCA.h:
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.h:

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.
(WebKit::LayerTreeHostCAMac::flushPendingLayerChangesRunLoopObserverCallback): Added an assertion.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::scheduleLayerFlush): Bail out if scheduling is not enabled.
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled): Added. Sets the flag. If disabling
flushing, cancels the pending flush.

* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Hao Zheng <zhenghao@chromium.org>
commit-queue@webkit.org [Tue, 31 May 2011 22:03:05 +0000 (22:03 +0000)]
2011-05-31  Hao Zheng  <zhenghao@chromium.org>

        Reviewed by Tony Chang.

        Flush output buffer of php.
        https://bugs.webkit.org/show_bug.cgi?id=56060

        On Lucid, the output buffer is enabled by default, but it's not
        enabled on Hardy. Fix test http/tests/loading/preload-slow-loading.php
        http://www.php.net/manual/en/function.ob-flush.php

        * http/tests/loading/preload-slow-loading.php:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 31 May 2011 21:55:41 +0000 (21:55 +0000)]
2011-05-31  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Simon Fraser.

        Change InlineBox::paint and its overloaded variants to use IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61804

        Changing InlineBox::paint, its 7 overloaded variants, and RootInlineBox::paintEllipsisBox
        to use IntPoint for their paint offset instead of a pair of ints.

        No new tests since this is just a refactoring.

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        * rendering/EllipsisBox.h:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::paint):
        * rendering/InlineBox.h:
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        * rendering/InlineTextBox.h:
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintEllipsisBoxes):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderLineBoxList.cpp:
        (WebCore::RenderLineBoxList::paint):
        * rendering/RootInlineBox.cpp:
        (WebCore::RootInlineBox::paintEllipsisBox):
        (WebCore::RootInlineBox::paint):
        * rendering/RootInlineBox.h:
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::paint):
        * rendering/svg/SVGInlineFlowBox.h:
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paint):
        * rendering/svg/SVGInlineTextBox.h:
        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::paint):
        * rendering/svg/SVGRootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Tue, 31 May 2011 21:50:19 +0000 (21:50 +0000)]
2011-05-31  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Clear out LayerChromium's m_ccLayerImpl ptr on CCLayerImpl destruction
        https://bugs.webkit.org/show_bug.cgi?id=61593

        Whenever a CCLayerImpl is being destroyed, clear out its owner's m_ccLayerImpl pointer.
        This is extremely defensive and not strictly necessary, but not harmful either.

        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::~CCLayerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 31 May 2011 21:15:16 +0000 (21:15 +0000)]
2011-05-31  Eric Seidel  <eric@webkit.org>

        Reviewed by David Kilzer.

        webkitpy should create zips with zip -9
        https://bugs.webkit.org/show_bug.cgi?id=61789

        Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 31 May 2011 21:02:28 +0000 (21:02 +0000)]
2011-05-31  Stephen White  <senorblanco@chromium.org>

        Unreviewed; build fix.

        Silence some warnings on the Safari/Mac release build.

        * platform/graphics/gpu/TilingData.h:
        (WebCore::TilingData::assertTile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 May 2011 20:53:21 +0000 (20:53 +0000)]
2011-05-31  Adam Barth  <abarth@webkit.org>

        Add chromium-mac-leopard image results for these SVG tests.

        * platform/chromium-mac-leopard/svg/custom/invalid-fill-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/invalid-fill-hex-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/invalid-uri-stroke-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Justin Novosad <junov@chromium.org>
senorblanco@chromium.org [Tue, 31 May 2011 20:21:30 +0000 (20:21 +0000)]
2011-05-31  Justin Novosad  <junov@chromium.org>

        Reviewed by Stephen White.

        [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled
        https://bugs.webkit.org/show_bug.cgi?id=61790
        Changing the build guards in these two files that are required
        by the accelerated compositing feature.

        * platform/graphics/gpu/LoopBlinnMathUtils.cpp:
        * platform/graphics/gpu/TilingData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 31 May 2011 19:51:03 +0000 (19:51 +0000)]
2011-05-31  Rob Buis  <rbuis@rim.com>

        RS=Dirk Schulze.

        run-webkit-tests on animate-path-nested-transform.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=61798

        "Fix" the crashing test by choosing safer values.

        * svg/animations/script-tests/animate-path-nested-transforms.js:
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 31 May 2011 19:38:11 +0000 (19:38 +0000)]
2011-05-31  Rob Buis  <rbuis@rim.com>

        Reviewed by Dirk Schulze.

        https://bugs.webkit.org/show_bug.cgi?id=34301
        Creating <animateMotion> elements via javascript do not execute

        https://bugs.webkit.org/show_bug.cgi?id=17043
        SVG missing some .idl files

        Add missing idl files.

        Test: svg/animations/animate-mpath-insert.html

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/SVGAnimateMotionElement.idl: Added.
        * svg/SVGMPathElement.idl: Added.
2011-05-31  Rob Buis  <rbuis@rim.com>

        Reviewed by Dirk Schulze.

        https://bugs.webkit.org/show_bug.cgi?id=34301
        Creating <animateMotion> elements via javascript do not execute

        https://bugs.webkit.org/show_bug.cgi?id=17043
        SVG missing some .idl files

        Verify that adding mpath via javascript works.

        * svg/animations/animate-mpath-insert-expected.txt: Added.
        * svg/animations/animate-mpath-insert.html: Added.
        * svg/animations/script-tests/animate-mpath-insert.js: Added.
        (mpath.setAttributeNS.animateMotion.appendChild.g.appendChild.rootSVGElement.appendChild.passIfCloseEnough):
        (startSample):
        (endSample):
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed by Kevin Ollivier.
kevino@webkit.org [Tue, 31 May 2011 19:21:39 +0000 (19:21 +0000)]
Reviewed by Kevin Ollivier.

[wx] Implement printing support for wxWidgets 2.9.x and above.

https://bugs.webkit.org/show_bug.cgi?id=61796

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 31 May 2011 18:53:57 +0000 (18:53 +0000)]
2011-05-31  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Missing InspectorFrontendHost.saveSessionSetting function
        https://bugs.webkit.org/show_bug.cgi?id=61751

        Add missing stub function causing an error on load.

        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.saveSessionSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 31 May 2011 18:16:13 +0000 (18:16 +0000)]
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Improve hasMediaControls logic to check that node has
        media controls. This can be false when cloning nodes.
        https://bugs.webkit.org/show_bug.cgi?id=61765

        Test: media/media-controls-clone-crash.html

        * dom/Node.h:
        (WebCore::Node::isMediaControls):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaControls):
        (WebCore::HTMLMediaElement::hasMediaControls):
        * html/shadow/MediaControls.h:
        (WebCore::MediaControls::isMediaControls):
        (WebCore::toMediaControls):
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that cloning an audio element with media controls does
        not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=61765

        * media/media-controls-clone-crash-expected.txt: Added.
        * media/media-controls-clone-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 31 May 2011 18:14:24 +0000 (18:14 +0000)]
2011-05-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Bump version to 1.5.1.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 31 May 2011 18:10:12 +0000 (18:10 +0000)]
2011-05-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
        https://bugs.webkit.org/show_bug.cgi?id=61791

        * bindings/gobject/GNUmakefile.am: add new files.
        * bindings/gobject/WebKitDOMCustom.cpp: Added.
        (webkit_dom_html_text_area_element_is_edited):
        (webkit_dom_html_input_element_is_edited):
        * bindings/gobject/WebKitDOMCustom.h: Added.
2011-05-31  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Provide custom DOM bindings methods to check if input/textareas have been edited
        https://bugs.webkit.org/show_bug.cgi?id=61791

        * GNUmakefile.am: add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 17:55:20 +0000 (17:55 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Unreviewed. Rebaseline Mac after JSC/Canvas bindings changes.

        * platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Tue, 31 May 2011 17:22:47 +0000 (17:22 +0000)]
2011-05-31  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Unreviewed build fix for Symbian.
        Opt-out Symbian for TextureMapper.

        No new tests: build fix.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 31 May 2011 17:12:39 +0000 (17:12 +0000)]
2011-05-31  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintFocusRing to IntPoint
        https://bugs.webkit.org/show_bug.cgi?id=61580

        Switching paintFocusRing to take an IntPoint representing the paint offset
        instead of a pair of ints.

        No new tests as this is just refactoring.

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paintOutline):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintFocusRing):
        (WebCore::RenderObject::paintOutline):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 31 May 2011 16:51:09 +0000 (16:51 +0000)]
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Convert raw ptr to RefPtr for documentElement.
        https://bugs.webkit.org/show_bug.cgi?id=61688

        Test: fast/dom/xml-parser-error-message-crash.svg

        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::insertErrorMessageBlock):
2011-05-31  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Test that we do not crash when a DOMNodeInsertedIntoDocument event
        is fired while generating a error message block in xml parsing.
        https://bugs.webkit.org/show_bug.cgi?id=61688

        * fast/dom/xml-parser-error-message-crash-expected.txt: Added.
        * fast/dom/xml-parser-error-message-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:28:33 +0000 (16:28 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setShadow()
        https://bugs.webkit.org/show_bug.cgi?id=61786

        Move CanvasRenderingContext2D.setShadow() to auto-generated JSC bindings.

        There is a subtle difference to the previous behavior: invalid numbers of
        arguments now raise TypeError instead of SyntaxError. This is in accordance
        with Web IDL, and matches the existing V8 bindings.

        Test: fast/canvas/canvas-overloads-setShadow.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setShadow()
        https://bugs.webkit.org/show_bug.cgi?id=61786

        Add a test to verify the behavior of setShadow() when called
        with different numbers of arguments.

        * fast/canvas/canvas-overloads-setShadow-expected.txt: Added.
        * fast/canvas/canvas-overloads-setShadow.html: Added.
        * fast/canvas/script-tests/canvas-overloads-setShadow.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:25:34 +0000 (16:25 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for drawImageFromRect()
        https://bugs.webkit.org/show_bug.cgi?id=61709

        Add a test to verify the behavior of drawImageFromRect() when called
        with different numbers of arguments.

        * fast/canvas/canvas-overloads-drawImageFromRect-expected.txt: Added.
        * fast/canvas/canvas-overloads-drawImageFromRect.html: Added.
        * fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js: Added.
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for drawImageFromRect()
        https://bugs.webkit.org/show_bug.cgi?id=61709

        Move CanvasRenderingContext2D.drawImageFromRect() to auto-generated JSC bindings.
        Make it [RequiresAllArguments=Raise] to match the old behavior.
        Side effect: calling drawImageFromRect() with zero arguments will now raise
        SyntaxError instead of TypeError.

        Test: fast/canvas/canvas-overloads-drawImageFromRect.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.h:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:22:31 +0000 (16:22 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for drawImage()
        https://bugs.webkit.org/show_bug.cgi?id=61703

        Move CanvasRenderingContext2D.drawImage() to auto-generated JSC bindings.

        There is a subtle difference to the previous behavior: invalid numbers of
        arguments now raise TypeError instead of SyntaxError. This is in accordance
        with Web IDL, and matches the existing V8 bindings.

        Test: fast/canvas/canvas-overloads-drawImage.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for drawImage()
        https://bugs.webkit.org/show_bug.cgi?id=61703

        Add a test to verify the behavior of drawImage() when called with
        different numbers of arguments.

        * fast/canvas/canvas-overloads-drawImage-expected.txt: Added.
        * fast/canvas/canvas-overloads-drawImage.html: Added.
        * fast/canvas/script-tests/canvas-overloads-drawImage.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:20:32 +0000 (16:20 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for strokeRect()
        https://bugs.webkit.org/show_bug.cgi?id=61641

        Add a test to verify the behavior of strokeRect() when called with
        different numbers of arguments.

        * fast/canvas/canvas-overloads-strokeRect-expected.txt: Added.
        * fast/canvas/canvas-overloads-strokeRect.html: Added.
        * fast/canvas/script-tests/canvas-overloads-strokeRect.js: Added.
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for strokeRect()
        https://bugs.webkit.org/show_bug.cgi?id=61641

        Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

        No behavioral change.

        Test: fast/canvas/canvas-overloads-strokeRect.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:15:27 +0000 (16:15 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setFillColor()
        https://bugs.webkit.org/show_bug.cgi?id=61635

        Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

        There is a subtle difference to the previous behavior: invalid numbers of
        arguments now raise TypeError instead of SyntaxError. This is in accordance
        with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

        Test: fast/canvas/canvas-overloads-setFillColor.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setFillColor()
        https://bugs.webkit.org/show_bug.cgi?id=61635

        Add a test to verify the behavior of setFillColor() when called with
        different numbers of arguments.

        * fast/canvas/canvas-overloads-setFillColor-expected.txt: Added.
        * fast/canvas/canvas-overloads-setFillColor.html: Added.
        * fast/canvas/script-tests/canvas-overloads-setFillColor.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:12:35 +0000 (16:12 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setStrokeColor()
        https://bugs.webkit.org/show_bug.cgi?id=61629

        Add a test to verify the behavior of setStrokeColor() when called with
        different numbers of arguments.

        * fast/canvas/canvas-overloads-setStrokeColor-expected.txt: Added.
        * fast/canvas/canvas-overloads-setStrokeColor.html: Added.
        * fast/canvas/script-tests/canvas-overloads-setStrokeColor.js: Added.
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for setStrokeColor()
        https://bugs.webkit.org/show_bug.cgi?id=61629

        Move CanvasRenderingContext2D.setStrokeColor() to auto-generated JSC bindings.

        There is a subtle difference to the previous behavior: invalid numbers of
        arguments now raise TypeError instead of SyntaxError. This is in accordance
        with Web IDL, but doesn't matter much anyway since this method is WebKit-only.

        Test: fast/canvas/canvas-overloads-setStrokeColor.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:10:39 +0000 (16:10 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for strokeText()
        https://bugs.webkit.org/show_bug.cgi?id=61626

        Move CanvasRenderingContext2D.strokeText() to auto-generated JSC bindings.
        Make it [RequiresAllArguments=Raise] to match the old behavior.
        This has the side-effect of aligning the behaviors of JSC and V8.

        Test: fast/canvas/canvas-overloads-strokeText.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for strokeText()
        https://bugs.webkit.org/show_bug.cgi?id=61626

        Add a test to verify the behavior of strokeText() when called with different
        numbers of arguments. There are two differences to the previous behavior:

        - SyntaxError exceptions are now raised with the message "Not enough arguments."
        - Calling strokeText() with superfluous arguments now lets the call through
          instead of raising a SyntaxError. This matches both Gecko and Presto.

        * fast/canvas/canvas-overloads-strokeText-expected.txt: Added.
        * fast/canvas/canvas-overloads-strokeText.html: Added.
        * fast/canvas/script-tests/canvas-overloads-strokeText.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Tue, 31 May 2011 16:08:49 +0000 (16:08 +0000)]
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for fillText()
        https://bugs.webkit.org/show_bug.cgi?id=61623

        Add a test to verify the behavior of fillText() when called with different
        numbers of arguments. There are two differences to the previous behavior:

        - SyntaxError exceptions are now raised with the message "Not enough arguments."
        - Calling fillText() with superfluous arguments now lets the call through
          instead of raising a SyntaxError. This matches both Gecko and Presto.

        * fast/canvas/canvas-overloads-fillText-expected.txt: Added.
        * fast/canvas/canvas-overloads-fillText.html: Added.
        * fast/canvas/script-tests/canvas-overloads-fillText.js: Added.
2011-05-31  Andreas Kling  <kling@webkit.org>

        Reviewed by Antti Koivisto.

        Canvas/JSC: Auto-generate overloads for fillText()
        https://bugs.webkit.org/show_bug.cgi?id=61623

        Move CanvasRenderingContext2D.fillText() to auto-generated JSC bindings.
        Make it [RequiresAllArguments=Raise] to match the old behavior.
        This has the side-effect of aligning the behaviors of JSC and V8.

        Test: fast/canvas/canvas-overloads-fillText.html

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        * html/canvas/CanvasRenderingContext2D.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Tue, 31 May 2011 16:05:31 +0000 (16:05 +0000)]
2011-05-31  Cary Clark  <caryclark@google.com>

        Reviewed by Eric Seidel.

        Allow Chromium porting layer to use Skia on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=61548

        * public/WebCommon.h:
        Don't allow WebKit to use CG if it is already using Skia.

        * src/PlatformBridge.cpp:
        (WebCore::PlatformBridge::paintScrollbarThumb):
        Allow scrollbar thumb draw to take WebCanvas.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 ChangeLog <james.cooley@nokia.com>
commit-queue@webkit.org [Tue, 31 May 2011 15:38:37 +0000 (15:38 +0000)]
2011-05-31  ChangeLog  <james.cooley@nokia.com>

        Reviewed by Andreas Kling.

        [Qt][WK2] Qt port needs test content for QWKHistory
        https://bugs.webkit.org/show_bug.cgi?id=57850

        Created data-driven QTestLib tests for existing QWKHistory APIs.

        This walks through loading four simple pages, navigating
        backwards and forwards.

        We check the results at each action by creating expected forward/back
        lists and comparing those lists in count and membership to those kept by
        WebKit and retrieved via the QWKHistory APIs.

        * UIProcess/API/qt/tests/html/a.htm: Added.
        * UIProcess/API/qt/tests/html/b.htm: Added.
        * UIProcess/API/qt/tests/html/c.htm: Added.
        * UIProcess/API/qt/tests/html/d.htm: Added.
        Four added simple pages

        * UIProcess/API/qt/tests/qwkhistory: Added.
        * UIProcess/API/qt/tests/qwkhistory/qwkhistory.pro: Added.
        Created qwkhistory folder and pro

        * UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp: Added.
        (TestHistoryItem::title):
        (TestHistoryItem::url):
        (TestHistoryItem::TestHistoryItem):
        Utility class to hold expected url,title for test

        (tst_QWKHistory::initTestCase):
        (tst_QWKHistory::historyFBTest_data):
        (tst_QWKHistory::historyFBTest):
        init, data, and data-driven test case

        * UIProcess/API/qt/tests/tests.pro:
        Included qwkhistory in tests.pro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 31 May 2011 14:20:05 +0000 (14:20 +0000)]
2011-05-31  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Kenneth Rohde Christiansen.

        Frame flattening is broken with nested frames
        https://bugs.webkit.org/show_bug.cgi?id=61491

        * fast/frames/flattening/iframe-flattening-nested.html: Added.
        * fast/frames/flattening/resources/inner-frame.html: Added.
        * fast/frames/flattening/resources/intermediate-frame.html: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt: Added.
2011-05-31  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Frame flattening is broken with nested frames
        https://bugs.webkit.org/show_bug.cgi?id=61491

        After r77988, when frame flattening is enabled, performPostLayoutTasks() is called on a timer for iframes.
        This causes layout of nested iframes to sometimes happen asynchronously, but WebCore expects layout to always finish synchronously.
        Added a call to updateWidgetPosition() for cases that performPostLayoutTasks() is now happening asynchronously.

        Test: fast/frames/flattening/iframe-flattening-nested.html

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Tommy Widenflycht <tommyw@google.com>
commit-queue@webkit.org [Tue, 31 May 2011 13:46:13 +0000 (13:46 +0000)]
2011-05-31  Tommy Widenflycht  <tommyw@google.com>

        Reviewed by Tony Gentilcore.

        Fix getUserMedia callback bindings for JSC.
        https://bugs.webkit.org/show_bug.cgi?id=60174

        This patch initializes the exception code variable to 0.

        Test: fast/dom/MediaStream/argument-types.html

        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::webkitGetUserMedia):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement find feature for QtTestBrowser
ossy@webkit.org [Tue, 31 May 2011 13:32:46 +0000 (13:32 +0000)]
[Qt] Implement find feature for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=61425

Patch by Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu> on 2011-05-31
Reviewed by Csaba Osztrogonác.

Buildfix for --minimal and CONFIG+=qt_minimal build.

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::createChrome):
* QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Oleg Romashin <oleg.romashin@nokia.com>
commit-queue@webkit.org [Tue, 31 May 2011 12:43:11 +0000 (12:43 +0000)]
2011-05-31  Oleg Romashin  <oleg.romashin@nokia.com>

        Reviewed by Benjamin Poulain.

        Fix compilation with debug enabled, m_lightSource.type is not valid anymore
        https://bugs.webkit.org/show_bug.cgi?id=61719

        * platform/graphics/filters/arm/FELightingNEON.h:
        (WebCore::FELighting::platformApplyNeon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 31 May 2011 11:49:22 +0000 (11:49 +0000)]
2011-05-31  Mikhail Naganov  <mnaganov@chromium.org>

        [Chromium] Unreviewed tests results rebaseline after r87721.

        * platform/chromium-linux-x86/svg/custom/invalid-fill-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
        * platform/chromium-linux-x86/svg/custom/invalid-fill-hex-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/chromium-linux-x86/svg/custom/invalid-uri-stroke-expected.png: Added.
        * platform/chromium-linux/svg/custom/invalid-fill-expected.png:
        * platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
        * platform/chromium-linux/svg/custom/invalid-fill-hex-expected.png:
        * platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/invalid-fill-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/invalid-fill-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
        * platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/invalid-fill-hex-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/custom/invalid-fill-expected.txt.
        * platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/invalid-stroke-hex-expected.txt: Added.
        * platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.png: Added.
        * platform/chromium-win-vista/svg/custom/invalid-uri-stroke-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>
commit-queue@webkit.org [Tue, 31 May 2011 10:46:25 +0000 (10:46 +0000)]
2011-05-31  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>

        Reviewed by Nikolas Zimmermann.

        Invalid color handling is broken for SVG
        https://bugs.webkit.org/show_bug.cgi?id=58531

        Fix invalid color fallback handling. If the fill/stroke attributes computed
        value leads to a an invalid color, inherit the desired color from the parent
        style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

        * platform/chromium-linux/svg/custom/invalid-fill-expected.txt:
        * platform/chromium-linux/svg/custom/invalid-fill-hex-expected.txt:
        * platform/chromium-linux/svg/custom/invalid-stroke-hex-expected.txt: Added.
        * platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.txt: Added.
        * platform/mac/svg/custom/invalid-fill-expected.png:
        * platform/mac/svg/custom/invalid-fill-expected.txt:
        * platform/mac/svg/custom/invalid-fill-hex-expected.png:
        * platform/mac/svg/custom/invalid-fill-hex-expected.txt:
        * platform/mac/svg/custom/invalid-stroke-hex-expected.png: Added.
        * platform/mac/svg/custom/invalid-stroke-hex-expected.txt: Added.
        * platform/mac/svg/custom/invalid-uri-stroke-expected.png: Added.
        * platform/mac/svg/custom/invalid-uri-stroke-expected.txt: Added.
        * platform/qt/svg/custom/invalid-fill-expected.txt:
        * platform/qt/svg/custom/invalid-fill-hex-expected.txt:
        * platform/qt/svg/custom/invalid-stroke-hex-expected.txt: Added.
        * platform/qt/svg/custom/invalid-uri-stroke-expected.txt: Added.
        * svg/custom/invalid-fill-hex.svg:
        * svg/custom/invalid-fill.svg:
        * svg/custom/invalid-stroke-hex.svg: Added.
        * svg/custom/invalid-uri-stroke.svg: Added.
2011-05-31  Oliver Varga  <Varga.Oliver@stud.u-szeged.hu>

        Reviewed by Nikolas Zimmermann.

        Invalid color handling is broken for SVG
        https://bugs.webkit.org/show_bug.cgi?id=58531

        Fix invalid color fallback handling. If the fill/stroke attributes computed
        value leads to a an invalid color, inherit the desired color from the parent
        style instead. Matches Opera/FF and SVG 1.1 Second Edition (http://www.w3.org/TR/SVG/).

        Tests: svg/custom/invalid-stroke-hex.svg
               svg/custom/invalid-uri-stroke.svg

        * rendering/svg/RenderSVGResource.cpp:
        (WebCore::inheritColorFromParentStyleIfNeeded):
        (WebCore::requestPaintingResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
commit-queue@webkit.org [Tue, 31 May 2011 10:42:01 +0000 (10:42 +0000)]
2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [Qt] Implement find feature for QtTestBrowser
        https://bugs.webkit.org/show_bug.cgi?id=61425

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::LauncherWindow):
        (LauncherWindow::createChrome):
        (LauncherWindow::showFindBar):
        (LauncherWindow::find):
        * QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 31 May 2011 10:20:05 +0000 (10:20 +0000)]
2011-05-31  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket: Make the output of client-close.html more verbose
        https://bugs.webkit.org/show_bug.cgi?id=61770

        * http/tests/websocket/tests/client-close-expected.txt:
        * http/tests/websocket/tests/client-close.html:
        * http/tests/websocket/tests/client-close_wsh.py:
        Echo back the first two bytes received from the client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 31 May 2011 09:58:31 +0000 (09:58 +0000)]
2011-05-31  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] Avoid double deletion of DrawingBuffer's color buffer
        texture.
        https://bugs.webkit.org/show_bug.cgi?id=61761

        Test: Verified that the DCHECK in GraphicsContext3D implementation
        doesn't trigger.

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::~DrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Ossyize editing/pasteboard/copy-standalone-image-crash.html since eventSend...
zoltan@webkit.org [Tue, 31 May 2011 09:10:42 +0000 (09:10 +0000)]
[Qt][WK2] Ossyize editing/pasteboard/copy-standalone-image-crash.html since eventSender is not implemented.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 31 May 2011 07:39:32 +0000 (07:39 +0000)]
2011-05-30  Hayato Ito  <hayato@chromium.org>

        Reviewed by Ryosuke Niwa.

        Add a utility function for dumping a tree for the Node, including a document of a frame.
        https://bugs.webkit.org/show_bug.cgi?id=61727

        No new tests since added functions are only available in debug builds.

        * dom/Node.cpp:
        (WebCore::parentOrHostOrFrameOwner):
        (WebCore::traverseNextNodeAcrossFrame):
        (WebCore::Node::showTreeForThisAcrossFrame):
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-31 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Tue, 31 May 2011 07:29:20 +0000 (07:29 +0000)]
2011-05-31  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed. Update Chromium test expectation for http/tests/websocket/tests/client-close.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Gabor Loki <loki@webkit.org>
loki@webkit.org [Tue, 31 May 2011 07:01:28 +0000 (07:01 +0000)]
2011-05-30 Gabor Loki <loki@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Skip crashed test after r87691-r87693 on ARM
        https://bugs.webkit.org/show_bug.cgi?id=61764

        * platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 James Kozianski <koz@chromium.org>
koz@chromium.org [Tue, 31 May 2011 06:28:58 +0000 (06:28 +0000)]
2011-05-30  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Make isValidProtocol() accept protocols with '+'.
        https://bugs.webkit.org/show_bug.cgi?id=61759

        * platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt: Added.
        * platform/chromium/fast/dom/register-protocol-handler-expected.txt: Added.
2011-05-30  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Make isValidProtocol() accept protocols with '+'.
        https://bugs.webkit.org/show_bug.cgi?id=61759

        Also, detect syntax errors before security errors; some syntax errors
        will also trigger a security error, but it's more helpful to the
        programmer to know if they have a syntax error, which are well-defined
        in the spec, rather than a security error, which aren't.

        * page/Navigator.cpp:
        (WebCore::Navigator::registerProtocolHandler):
        Detect syntax errors before security errors.
        * platform/KURLGoogle.cpp:
        (WebCore::isSchemeChar):
        Include '+' in the list of valid characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>
commit-queue@webkit.org [Tue, 31 May 2011 05:00:51 +0000 (05:00 +0000)]
2011-05-30  Andrey Petrov  <andrey.petrov@gmail.com>

        Reviewed by Hajime Morita.

        Using jQuery to show/hide IMG elements crashes WebKit
        https://bugs.webkit.org/show_bug.cgi?id=31721

        * editing/pasteboard/copy-standalone-image-crash-expected.txt: Added.
        * editing/pasteboard/copy-standalone-image-crash.html: Added.
2011-05-30  Andrey Petrov  <andrey.petrov@gmail.com>

        Reviewed by Hajime Morita.

        Using jQuery to show/hide IMG elements crashes WebKit
        https://bugs.webkit.org/show_bug.cgi?id=31721

        For platform code, do not assert nodes always have renderer at
        the time context menu action is invoked.
        Renderer can actually be empty for a given node if it was hidden
        or removed from domtree by some non-user generated event (e.g timeout)
        after the popup menu had been created.

        Changing Chromium, Gtk, Mac, Qt, Win and WinCE.

        Test: editing/pasteboard/copy-standalone-image-crash.html

        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/wince/PasteboardWinCE.cpp:
        (WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 31 May 2011 04:03:56 +0000 (04:03 +0000)]
2011-05-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        Rename XSSFilter to XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=61718

        Currently we use the names XSSFilter and XSSAuditor throughout the project.
        Instead, we should choose one name for consistency.

        No functionality was changed. So, no new tests.

        * XSSAuditor: Copied from PerformanceTests/XSSFilter.
        * XSSFilter: Removed.
        * XSSFilter/large-post-many-events.html: Removed.
        * XSSFilter/large-post-many-inline-scripts-and-events.html: Removed.
        * XSSFilter/resources: Removed.
        * XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Removed.
2011-05-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        Rename XSSFilter to XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=61718

        Currently we use the names XSSFilter and XSSAuditor throughout the project.
        Instead, we should choose one name for consistency.

        No functionality was changed. So, no new tests.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLDocumentParser.h:
        * html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp.
        (WebCore::XSSAuditor::XSSAuditor):
        (WebCore::XSSAuditor::init):
        (WebCore::XSSAuditor::filterToken):
        (WebCore::XSSAuditor::filterTokenInitial):
        (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
        (WebCore::XSSAuditor::filterScriptToken):
        (WebCore::XSSAuditor::filterObjectToken):
        (WebCore::XSSAuditor::filterParamToken):
        (WebCore::XSSAuditor::filterEmbedToken):
        (WebCore::XSSAuditor::filterAppletToken):
        (WebCore::XSSAuditor::filterIframeToken):
        (WebCore::XSSAuditor::filterMetaToken):
        (WebCore::XSSAuditor::filterBaseToken):
        (WebCore::XSSAuditor::filterFormToken):
        (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
        (WebCore::XSSAuditor::eraseAttributeIfInjected):
        (WebCore::XSSAuditor::snippetForRange):
        (WebCore::XSSAuditor::snippetForAttribute):
        (WebCore::XSSAuditor::isContainedInRequest):
        (WebCore::XSSAuditor::isSameOriginResource):
        * html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
        * html/parser/XSSFilter.cpp: Removed.
        * html/parser/XSSFilter.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Tue, 31 May 2011 02:21:49 +0000 (02:21 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Expose a public clearAll() function to reset WebCore::Animation.

        No new functionality, so no new tests.

        * platform/animation/Animation.h:
        (WebCore::Animation::clearAll):
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Create an ArgumentCoder for WebCore::Animation.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>
commit-queue@webkit.org [Tue, 31 May 2011 02:18:05 +0000 (02:18 +0000)]
2011-05-30  Raphael Kubo da Costa  <kubo@profusion.mobi>

        Reviewed by Kent Tamura.

        [efl] Fix _ewk_frame_children_iterator_next().
        https://bugs.webkit.org/show_bug.cgi?id=61749

        The iterator was returning always the first child, making tests like
        fast/history/history-back-initial-vs-final-url.html to timeout and
        eventually run out of memory.

        * ewk/ewk_frame.cpp:
        (_ewk_frame_children_iterator_next):
        (ewk_frame_children_iterator_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 31 May 2011 02:04:53 +0000 (02:04 +0000)]
2011-05-30  Kent Tamura  <tkent@chromium.org>

        [Mac] Skip a flaky test: svg/zoom/page/zoom-svg-through-object-with-text.xhtml

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 31 May 2011 01:44:55 +0000 (01:44 +0000)]
2011-05-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Audio and video files saved to the Application Cache should preserve the original file extension
        https://bugs.webkit.org/show_bug.cgi?id=61750
        <rdar://9524922>

        No new tests, it isn't possible to check the name of the file in the cache from within
        DRT. Changes verified manually.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache
            file name.
        (WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.
        * loader/appcache/ApplicationCacheStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 31 May 2011 00:05:02 +0000 (00:05 +0000)]
2011-05-30  Jer Noble  <jer.noble@apple.com>

        Reviewed by Dan Bernstein.

        Play/Pause button in wrong state when entering full screen on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61754

        Update the play/pause button inside reset().  This ensures the button is in
        the correct state when the controls are created after playback has already
        started.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Hojong Han <hojong.han@samsung.com>
commit-queue@webkit.org [Mon, 30 May 2011 23:49:51 +0000 (23:49 +0000)]
2011-05-30  Hojong Han  <hojong.han@samsung.com>

        Reviewed by Geoffrey Garen.

        [JSC] malfunction during arithmetic condition check with negative number (-2147483648)
        https://bugs.webkit.org/show_bug.cgi?id=61416

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::branch32):
        * tests/mozilla/ecma/Expressions/11.12-1.js:
        (getTestCases):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 23:43:58 +0000 (23:43 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Added a public TimingFunction::type() method.

        No new functionality, so no new tests.

        * platform/animation/TimingFunction.h:
        (WebCore::TimingFunction::type):
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Add an ArgumentCoder for WebCore::TimingFunction. This serializer can create the appropriate
        TimingFunction subclass based on the type of timing function.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 22:29:50 +0000 (22:29 +0000)]
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        BUILD FIX for r87697 on Windows/Symbian

        For now enabling TextureMapper for Mac/Linux only.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 22:02:57 +0000 (22:02 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Add WebCore::Length and WebCore::TransformationMatrix to the types that use SimpleArgumentCoder.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)
ddkilzer@apple.com [Mon, 30 May 2011 22:00:57 +0000 (22:00 +0000)]
BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior): Mark
shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 20:57:18 +0000 (20:57 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Texmap][Qt] Enable TextureMapper by default
        https://bugs.webkit.org/show_bug.cgi?id=61740

        Make CONFIG+=texmap an opt-out instead of an opt-in.

        No new functionality so no new tests.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Mon, 30 May 2011 20:08:51 +0000 (20:08 +0000)]
2011-05-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=61693

        * platform/gtk/Skipped: Unskip the test which is no longer crashing.
2011-05-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=61693

        Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
        null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
        may now be null.

        No new tests. This change should cause fast/css/font-face-zero-hash-key.html
        to stop crashing.

        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing
        m_scaledFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Mon, 30 May 2011 19:02:21 +0000 (19:02 +0000)]
2011-05-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
        https://bugs.webkit.org/show_bug.cgi?id=61711

        The loadFinished() signal was emitted directly inside the call for setHtml, so
        the test was waiting the loadFinished() signal with a big timeout. Change this by
        a very small timeout and a verification with signal spy.

        In practice, setHtml() will either directly call loadFinished() or queue it to
        the next event loop run, and test will work for both situations.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::scrollbarsOff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 18:28:08 +0000 (18:28 +0000)]
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Disable accelerated plugins/media until they're working.
        https://bugs.webkit.org/show_bug.cgi?id=61687

        Until this works properly, we should indicate that our media implementation
        in texture mapper doesn't support accelerated compositing.

        This makes LayoutTests/compositing/video/* work again.

        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
        (WebCore::MediaPlayerPrivateQt::platformLayer):
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Disable accelerated plugins/media in until they're working.
        https://bugs.webkit.org/show_bug.cgi?id=61687

        Turn off accelerated compositing for media and plugins when in texture-mapper.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Mikhail Naganov <mnaganov@chromium.org>
abarth@webkit.org [Mon, 30 May 2011 17:21:14 +0000 (17:21 +0000)]
2011-05-30  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Fix regression after r87628.
        https://bugs.webkit.org/show_bug.cgi?id=61733

        Having r87628 in place, Chrome reliability bot crashes in
        WebCore::HTMLLinkElement::onloadTimerFired.

        This is because the change makes WebCore::CachedResource::setRequest to
        call checkNotify on request reset.  HTMLLinkElement registers itself as
        CachedResource client via m_cachedSheet, which can happen even if
        m_cachedLinkResource wasn't set.  As a result,
        WebCore::HTMLLinkElement::notifyFinished is got called with unset
        m_cachedLinkResource, which causes a crash in
        HTMLLinkElement::onloadTimerFired

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Jer Noble <jer.noble@apple.com>
darin@apple.com [Mon, 30 May 2011 17:09:48 +0000 (17:09 +0000)]
2011-05-30  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler and Simon Fraser.

        REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
        https://bugs.webkit.org/show_bug.cgi?id=61717
        rdar://problem/9522272

        May be some good way to test this later. No immediate idea about the best way.

        When a media element is taken into full-screen mode, stop events from propagating
        outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
        has been changed to take a shadow root node. In our full screen media element check,
        we check to see if the passed shadow root is the shadow root of the full screen media
        element, and if so, specify events should StayInsideShadowDOM. The end result is that
        inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
        way from the SliderThumb to the video element's shadow root, but no further.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the
        shadow DOM when showing a full screen video.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls.
        The events telling us about activity in the shadow DOM no longer bubble out so we need to
        handle this inside the shadow DOM on the root element.
        (WebCore::HTMLMediaElement::play): Ditto.
        (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
        (WebCore::HTMLMediaElement::defaultEventHandler): Ditto.
        (WebCore::HTMLMediaElement::enterFullscreen): Ditto.
        (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
        * html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out
        changes that tried to make special rules for events using preDispatchEventHandler and such.
        This rolls out both r87622 and r87655.
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
        * html/shadow/MediaControlElements.h: Ditto.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members.
        (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider
        hiding the controls later.
        (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse
        is no longer over the controls.
        (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide
        automatically if we're playing.
        (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer.
        (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care
        if we are full screen.
        (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function.
        (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions
        as the mouse is moved in and out.
        (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if
        needed.
        (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions
        are met.
        (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.

        * html/shadow/MediaControlRootElement.h: Added new functions and data members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Gavin Peters <gavinp@chromium.org>
abarth@webkit.org [Mon, 30 May 2011 17:05:37 +0000 (17:05 +0000)]
2011-05-30  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
2011-05-30  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 30 May 2011 16:25:06 +0000 (16:25 +0000)]
2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement JavaScript dialogs in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=61725

        * MiniBrowser/gtk/BrowserWindow.c:
        (WKStringGetCString): Helper function to get a UTF-8 c string from
        a WKStringRef.
        (WKURLGetCString): Helper function to get a UTF-8 c string from a
        WKURLRef.
        (browserWindowUpdateURL): Update to use WKURLGetCString.
        (didReceiveTitleForFrame): Update to use WKStringGetCString.
        (createMessageDialog): Create a GtkMessageDialog.
        (runJavaScriptAlert):
        (runJavaScriptConfirm):
        (runJavaScriptPrompt):
        (browserWindowUIClientInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Anders Carlsson <andersca@apple.com>
carlosgc@webkit.org [Mon, 30 May 2011 16:17:56 +0000 (16:17 +0000)]
2011-05-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Remove incorrect asserts from PluginProcessConnection
        https://bugs.webkit.org/show_bug.cgi?id=61731

        There might be pending incoming messages from a PluginProxy even though we've
        destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::didReceiveMessage):
        (WebKit::PluginProcessConnection::didReceiveSyncMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 30 May 2011 16:14:29 +0000 (16:14 +0000)]
2011-05-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Remove incorrect asserts from PluginProcessConnection
        https://bugs.webkit.org/show_bug.cgi?id=61731

        There might be pending incoming messages from a PluginProxy even though we've
        destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::didReceiveMessage):
        (WebKit::PluginProcessConnection::didReceiveSyncMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Mon, 30 May 2011 15:44:02 +0000 (15:44 +0000)]
2011-05-30  Peter Varga  <pvarga@webkit.org>

        Unreviewed build fix.

        [Qt][V8] Fix debug build.

        No new tests needed.

        * css/CSSStyleDeclaration.cpp: Add missing header.
        * dom/Text.cpp: Ditto.
        * rendering/InlineTextBox.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 30 May 2011 14:50:13 +0000 (14:50 +0000)]
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87683.
        http://trac.webkit.org/changeset/87683
        https://bugs.webkit.org/show_bug.cgi?id=61729

        Breaks inspector tests on Chromium (Requested by apavlov on
        #webkit).

        * http/tests/inspector/inspect-iframe-from-different-domain.html:
        * inspector/elements/elements-delete-inline-style.html:
        * inspector/elements/elements-panel-styles.html:
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js-expected.txt:
        * inspector/styles/styles-update-from-js.html:
        * inspector/styles/styles-url-linkify.html:
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87683.
        http://trac.webkit.org/changeset/87683
        https://bugs.webkit.org/show_bug.cgi?id=61729

        Breaks inspector tests on Chromium (Requested by apavlov on
        #webkit).

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 30 May 2011 14:13:32 +0000 (14:13 +0000)]
2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove some unneeded header includes
        https://bugs.webkit.org/show_bug.cgi?id=60536

        * Platform/CoreIPC/Connection.cpp: Remove WebProcess.h.
        * Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove
        ProcessLauncher.h and WebProcessProxy.h. Add <wtf/OwnArrayPtr.h>.
        * WebProcess/Plugins/Netscape/NPJSObject.cpp: Remove PluginView.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove passing tests from ARM Skipped list
rgabor@webkit.org [Mon, 30 May 2011 14:06:58 +0000 (14:06 +0000)]
[Qt] Remove passing tests from ARM Skipped list

Rubber-stamped by Csaba Osztrogonác.

* platform/qt-arm/Skipped:
* platform/qt-arm/fast: Removed.
* platform/qt-arm/fast/block: Removed.
* platform/qt-arm/fast/block/float: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
* platform/qt-arm/fast/transforms: Removed.
* platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Removed.
* platform/qt-arm/transforms: Removed.
* platform/qt-arm/transforms/2d: Removed.
* platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Removed.
* platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Removed.
* platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
* platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Removed.
* platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt-arm/transforms/svg-vs-css-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 30 May 2011 13:48:09 +0000 (13:48 +0000)]
2011-05-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: node selection is slow in the Elements panel.
        https://bugs.webkit.org/show_bug.cgi?id=60813

        * http/tests/inspector/inspect-iframe-from-different-domain.html:
        * inspector/elements/elements-delete-inline-style.html:
        * inspector/elements/elements-panel-styles.html:
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js.html:
        * inspector/styles/styles-update-from-js-expected.txt:
        * inspector/styles/styles-url-linkify.html:
2011-05-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: node selection is slow in the Elements panel.
        https://bugs.webkit.org/show_bug.cgi?id=60813

        Schedule full style updates rather than request all node styles from the backend up front.

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
        (WebInspector.StylesSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 30 May 2011 10:36:55 +0000 (10:36 +0000)]
2011-05-30  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed.
        [Chromium] Rebaseline tests after r87680.

        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago011-05-30 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 30 May 2011 09:18:16 +0000 (09:18 +0000)]
011-05-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not issue frontendReused for reload or navigation.
        https://bugs.webkit.org/show_bug.cgi?id=61192

       - only issue frontendReused when inspector is attached after main resource committed load
       - upon committing loading main resource, reset agents before sending FrameNavigated to page agent
       - Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
       - do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restore):
        (WebCore::InspectorAgent::clearFrontend):
        (WebCore::InspectorAgent::didCommitLoad):
        * inspector/InspectorAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        * inspector/front-end/NetworkManager.js:
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._processCachedResources):
        (WebInspector.ResourceTreeModel.prototype._frameNavigated):
        (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._resetResourcesTree):
        (WebInspector.DatabaseTreeElement.prototype.onpopulate):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
        * inspector/front-end/inspector.js:
        (WebInspector.reset):
        (WebInspector.frontendReused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Ryan Sleevi <rsleevi@chromium.org>
commit-queue@webkit.org [Mon, 30 May 2011 08:30:17 +0000 (08:30 +0000)]
2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>

        Reviewed by Darin Adler.

        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
        https://bugs.webkit.org/show_bug.cgi?id=61603

        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
        * svg/filters/feConvolveFilter-y-bounds.svg: Added.
2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>

        Reviewed by Darin Adler.

        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
        https://bugs.webkit.org/show_bug.cgi?id=61603

        Test: svg/filters/feConvolveFilter-y-bounds.svg

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::getPixelValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 30 May 2011 07:45:41 +0000 (07:45 +0000)]
2011-05-30  Nate Chapin  <japhet@chromium.org>

        Reviewed by Antti Koivisto.

        Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
        flow so it's a little less circular.
        https://bugs.webkit.org/show_bug.cgi?id=61666

        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::beginLoadIfNeeded):
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::load):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::requestImage):
        (WebCore::CachedResourceLoader::setAutoLoadImages):
        (WebCore::CachedResourceLoader::loadStarted):
        * loader/cache/CachedResourceLoader.h:
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Mon, 30 May 2011 07:22:21 +0000 (07:22 +0000)]
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-05-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 30 May 2011 06:22:06 +0000 (06:22 +0000)]
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        * http/tests/websocket/tests/client-close-expected.txt: Added.
        * http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
        * http/tests/websocket/tests/client-close_wsh.py: Added.
        * http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
        * http/tests/websocket/tests/close-event-expected.txt:
        * http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
        * http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
        * http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
        We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket
        waits for a close frame to arrive and this test will time out.
        * http/tests/websocket/tests/server-close-expected.txt: Added.
        * http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
        * http/tests/websocket/tests/server-close_wsh.py: Added.
        * http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        Implement WebSocket closing handshake based on Ian Hickson's
        WebSocket protocol draft 76.

        Tests: http/tests/websocket/tests/client-close.html
               http/tests/websocket/tests/server-close.html

        * platform/network/SocketStreamHandleBase.cpp:
        (WebCore::SocketStreamHandleBase::send):
        Do not send a message if we are in Closing state.
        (WebCore::SocketStreamHandleBase::close):
        Do not disconnect if we have pending data which have not been sent yet.
        In this case, the actual disconnection will happen in sendPendingData().
        (WebCore::SocketStreamHandleBase::disconnect):
        Renamed from close(). Disconnect the connection immediately.
        (WebCore::SocketStreamHandleBase::sendPendingData):
        * platform/network/SocketStreamHandleBase.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
        to didClose().
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::send):
        (WebCore::WebSocket::close):
        Fail if close() is attempted before the connection is established.
        Otherwise, set the state to CLOSING and start the closing handshake.
        (WebCore::WebSocket::bufferedAmount):
        If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
        (WebCore::WebSocket::didConnect):
        (WebCore::WebSocket::didReceiveMessage):
        We need to invoke message event in CLOSING state as well as OPEN state.
        (WebCore::WebSocket::didReceiveMessageError):
        (WebCore::WebSocket::didStartClosingHandshake):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::close):
        Start the closing handshake.
        (WebCore::WebSocketChannel::disconnect):
        Disconnect the socket stream, instead of close.
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::didReceiveData): Ditto.
        (WebCore::WebSocketChannel::didFail): Ditto.
        (WebCore::WebSocketChannel::processBuffer):
        Ditto.
        Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
        (WebCore::WebSocketChannel::startClosingHandshake):
        Send 0xFF 0x00 byte sequence.
        (WebCore::WebSocketChannel::closingTimerFired):
        Disconnect the socket stream if the closing handshake has timed out.
        * websockets/WebSocketChannel.h:
        m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
        specification).
        * websockets/WebSocketChannelClient.h:
        (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
        (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
        (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
        (WebCore::workerContextDidStartClosingHandshake):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
        (WebCore::workerContextDidClose):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
        * websockets/WorkerThreadableWebSocketChannel.h:
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        * Scripts/webkitpy/thirdparty/__init__.py:
        Pull in pywebsocket 0.6b1. We need to update pywebsocket
        to get the right behavior of closing handshake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87674 268f45cc-cd09-0410-ab3c-d52691b4dbfc