WebKit-https.git
8 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 14:03:06 +0000 (14:03 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FECompositeElement changes doesn't require relayout.
        https://bugs.webkit.org/show_bug.cgi?id=55367

        When the FECompositeElement receives an update message but the given value remains the same we don't need
        to relayout the filter.

        No new tests are needed because this modification is covered by the dynamic update tests of FEComposite.

        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::setOperation):
        (WebCore::FEComposite::setK1):
        (WebCore::FEComposite::setK2):
        (WebCore::FEComposite::setK3):
        (WebCore::FEComposite::setK4):
        * platform/graphics/filters/FEComposite.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::setFilterEffectAttribute):
        (WebCore::SVGFECompositeElement::svgAttributeChanged):
        * svg/SVGFECompositeElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 28 Feb 2011 13:46:06 +0000 (13:46 +0000)]
2011-02-28  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        FrameLoader: Reorder early-returns in checkCompleted()
        https://bugs.webkit.org/show_bug.cgi?id=55366

        Check allChildrenAreComplete() last, since it's the most expensive.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 28 Feb 2011 13:24:25 +0000 (13:24 +0000)]
2011-02-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Range::processContents needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=51006

        Refactored Range::processContents.  Extracted childOfCommonRootBeforeOffset from processContents
        which is used to find processStart and processEnd respectively.  In the case of processStart,
        we use the next sibling of the node returned by childOfCommonRootBeforeOffset when m_start is not
        the common root because copying m_start's ancestors will result in processing too much contents.

        Also extracted processNodes and deleteCharacterData from processContents and processContentsBetweenOffsets.

        In addition, lengthOfContentsInNode was modified to return the correct length instead of
        numeric_limits<unsigned>::max() because the convention that processContentsBetweenOffsets automatically
        corrects the length when endOffset is numeric_limits<unsigned>::max() seemed more confusing than
        having two switch statements that need to be consistent.

        Historically, lengthOfContentsInNode was introduced in r78413 as a build fix because unsigned const
        LengthOfContentsInNode added in r78409 violated WebKit C++ rules and caused build failures on Mac and
        other ports.

        * dom/Range.cpp:
        (WebCore::childOfCommonRootBeforeOffset): Extracted from processContents.
        (WebCore::lengthOfContentsInNode): Added.
        (WebCore::Range::processContents): Calls childOfCommonRootBeforeOffset, lengthOfContentsInNode,
        and processNodes.
        (WebCore::deleteCharacterData): Added.
        (WebCore::Range::processContentsBetweenOffsets): Calls deleteCharacterData and processNodes.
        (WebCore::Range::processNodes): Extracted from processContents and processContentsBetweenOffsets.
        (WebCore::Range::processAncestorsAndTheirSiblings):
        * dom/Range.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:47:46 +0000 (11:47 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Test harness change follow up.
        Consider missing localized string a warning, not an error in the front-end.

        * inspector/front-end/inspector.js:
        (WebInspector.UIString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 28 Feb 2011 11:40:22 +0000 (11:40 +0000)]
2011-02-28  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        getJNIEnv() passes wrong type to AttachCurrentThread() for JNIEnv argument on Android
        https://bugs.webkit.org/show_bug.cgi?id=55218

        AttachCurrentThread() in Android's JVM takes a JINEnv**
        argument.

        No new tests, build fix only.

        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::getJNIEnv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Renata Hodovan <reni@webkit.org>
reni@webkit.org [Mon, 28 Feb 2011 11:31:11 +0000 (11:31 +0000)]
2011-02-28  Renata Hodovan  <reni@webkit.org>

        Reviewed by Andreas Kling.

        FETurbulenceElement changes doesn't require relayout
        https://bugs.webkit.org/show_bug.cgi?id=55141

        When the FETurbulenceElement receives an update message but the given value remains the same we don't need
        to relayout the filter.
        Besides fix a typo in FETurbulence and change the paramterer type of FETurbulence::setNumOctaves from bool
        to int according to the spec.

        No new tests are needed because this modification is covered by the dynamic update tests of FETurbulence.

        * platform/graphics/filters/FETurbulence.cpp:
        (WebCore::FETurbulence::FETurbulence):
        (WebCore::FETurbulence::create):
        (WebCore::FETurbulence::type):
        (WebCore::FETurbulence::setType):
        (WebCore::FETurbulence::setBaseFrequencyY):
        (WebCore::FETurbulence::setBaseFrequencyX):
        (WebCore::FETurbulence::setSeed):
        (WebCore::FETurbulence::setNumOctaves):
        (WebCore::FETurbulence::setStitchTiles):
        (WebCore::operator<<):
        * platform/graphics/filters/FETurbulence.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::setFilterEffectAttribute):
        (WebCore::SVGFETurbulenceElement::svgAttributeChanged):
        (WebCore::SVGFETurbulenceElement::build):
        * svg/SVGFETurbulenceElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:23:55 +0000 (11:23 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: InspectorAgent calls offsetWidth in the middle of painting
        https://bugs.webkit.org/show_bug.cgi?id=54597

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::drawElementTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 11:21:20 +0000 (11:21 +0000)]
2011-02-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add first network test, improve harness.
        https://bugs.webkit.org/show_bug.cgi?id=55306

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.assertGreaterOrEqual):
        * http/tests/inspector/network/network-size-expected.txt: Added.
        * http/tests/inspector/network/network-size.html: Added.
        * http/tests/inspector/network/network-timing-expected.txt: Added.
        * http/tests/inspector/network/network-timing.html: Added.
        * http/tests/inspector/network/resources/resource.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 11:06:46 +0000 (11:06 +0000)]
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Added full webkit module profile and a syncqt profile.

        This is for modularized Qt.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * Source/sync.profile: Added.
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Added full webkit module profile and a syncqt profile.

        This is for modularized Qt.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * qt_webkit_version.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Mon, 28 Feb 2011 10:49:56 +0000 (10:49 +0000)]
2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>

        Unreviewed, fix spelling mistake.

        hardware-accelated => hardware-accelerated.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 10:04:21 +0000 (10:04 +0000)]
2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Made sure that the build-webkit --qmake argument is always respected.

        Previously, it would be respected during the build, but not during
        the early feature detection. The build would also fail if qmake was
        not in your path, even if you specified --qmake with a valid qmake
        binary.

        [Qt] WebKit patches required to work with a modularized version of Qt
        https://bugs.webkit.org/show_bug.cgi?id=53916

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Mon, 28 Feb 2011 08:45:22 +0000 (08:45 +0000)]
2011-02-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 55355 - TextIterator should not be a friend of RenderTextControl
        https://bugs.webkit.org/show_bug.cgi?id=55355

        Remove need for 'friend' clause by making innerTextElement() public.

        No new tests. (simple refactoring)

        * rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Mon, 28 Feb 2011 07:30:10 +0000 (07:30 +0000)]
2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
        https://bugs.webkit.org/show_bug.cgi?id=53917

        The bug got fixed by other changes. Adding test case to avoid
        regressions in the future.

        * fast/overflow/horizontal-scroll-after-back-expected.txt: Added.
        * fast/overflow/horizontal-scroll-after-back.html: Added.
2011-02-27  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Antonio Gomes.

        [Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
        https://bugs.webkit.org/show_bug.cgi?id=53917

        Adding test case to check the scenario to avoid regressions in the
        future.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 28 Feb 2011 07:28:49 +0000 (07:28 +0000)]
2011-02-27  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Darin Fisher.

        Pass frame history state in the context menu parameters.
        https://bugs.webkit.org/show_bug.cgi?id=55232

        * public/WebContextMenuData.h:
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 28 Feb 2011 06:53:41 +0000 (06:53 +0000)]
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecWinCE
        https://bugs.webkit.org/show_bug.cgi?id=55317

        This functions are obsolete, since r78499 added TextCodecUTF8.
        Also remove the "fast path" for UTF-8 data, because we now have a separate TextCodec.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        * platform/text/wince/TextCodecWinCE.cpp:
        * platform/text/wince/TextCodecWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 05:49:30 +0000 (05:49 +0000)]
2011-02-27  Ojan Vafai  <ojan@chromium.org>

        Fix failing tests from http://trac.webkit.org/changeset/79837.

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        This was just a mistake that would break if someone tried printing with this configuration.
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        Method signature changed. Didn't notice that this method was being calling in a unittest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-24 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 28 Feb 2011 05:18:57 +0000 (05:18 +0000)]
2011-02-24  Hayato Ito  <hayato@chromium.org>

        Reviewed by Eric Seidel.

        [NRWT] Remove test_types/* classes.

        This is the last patch in the series of efforts which tried to remove test_types classes.
        A single_test_runner module will take over responsibilities of test_type classes.

        From this patch, we won't display statistics per test_type even if a '--verbose' option is given.

        https://bugs.webkit.org/show_bug.cgi?id=55123

        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
        * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForce dictionary popup to use overlay type
weinig@apple.com [Mon, 28 Feb 2011 04:35:21 +0000 (04:35 +0000)]
Force dictionary popup to use overlay type
<rdar://problem/9052483>
https://bugs.webkit.org/show_bug.cgi?id=55337

Reviewed by Dan Bernstein.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup): As this is only
used for the hot key version of the dictionary popup, force the overlay
style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 28 Feb 2011 04:00:37 +0000 (04:00 +0000)]
2011-02-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Restore parameters of efl header files.
        https://bugs.webkit.org/show_bug.cgi?id=55292

        Restore parameters in efl header files.

        * ewk/ewk_frame.h:
        * ewk/ewk_tiled_backing_store.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_view.cpp:
        (ewk_view_pre_render_relative_radius):
        * ewk/ewk_view.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 03:55:14 +0000 (03:55 +0000)]
2011-02-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        Change results.json format to the one used by unexpected_results.json
        https://bugs.webkit.org/show_bug.cgi?id=52267

        Also add runtimes in milliseconds to the JSON and make the output format more compact.
        Named the file full_results.json to avoid conflicting with the results.json
        file the test-results server currently serves up.

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 28 Feb 2011 03:39:20 +0000 (03:39 +0000)]
2011-02-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] fix expand links on git diffs
        https://bugs.webkit.org/show_bug.cgi?id=55208

        In git diffs, we don't have a "revision" span at the end
        of each FileDiff.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Feb 2011 03:11:44 +0000 (03:11 +0000)]
2011-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement WTF::randomNumber in terms of WTF::cryptographicallyRandomNumber when possible
        https://bugs.webkit.org/show_bug.cgi?id=55326

        Currently, randomNumber does a bunch of platform-specific work that to
        get a cryptographic randomness when available.  Instead, we should use
        cryptographicallyRandomNumber, which abstracts this work.
        Unfortunately, we can't remove all of the WTF::randomNumber
        implementation because not every port has access to cryptographically
        random numbers.

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 28 Feb 2011 01:33:53 +0000 (01:33 +0000)]
2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Sam Weinig.

        Use OwnPtr to handle the memory of RenderBlock::m_floatingObjects and RenderBlock::m_positionedObjects
        https://bugs.webkit.org/show_bug.cgi?id=55327

        Refactor RenderBlock to use OwnPtr for m_floatingObjects and m_positionedObjects so we do not have
        to release the memory manually.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::~RenderBlock):
        (WebCore::RenderBlock::selectionGaps):
        (WebCore::RenderBlock::insertPositionedObject):
        (WebCore::RenderBlock::insertFloatingObject):
        (WebCore::RenderBlock::addOverhangingFloats):
        (WebCore::RenderBlock::addIntrudingFloats):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::positionedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFollowup fix to r79827
aroben@apple.com [Sun, 27 Feb 2011 23:28:56 +0000 (23:28 +0000)]
Followup fix to r79827

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
lastPathComponent. This matches what we did here before r79827, and matches Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 23:18:51 +0000 (23:18 +0000)]
[Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330

Reviewed by Kenneth Rohde Christiansen.

Move QGraphicsWKView::showContextMenu() to the public API. Add documentation
on its use.

* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/API/qt/qgraphicswkview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake bisect-builds print a trac link for the regression range
mitz@apple.com [Sun, 27 Feb 2011 22:14:45 +0000 (22:14 +0000)]
Make bisect-builds print a trac link for the regression range
https://bugs.webkit.org/show_bug.cgi?id=55331

Reviewed by Adam Roben.

* Scripts/bisect-builds:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
aroben@apple.com [Sun, 27 Feb 2011 21:51:08 +0000 (21:51 +0000)]
Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate

Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled

Reviewed by Anders Carlsson.

* DumpRenderTree/win/EditingDelegate.cpp:
(indexOfFirstWordCharacter):
(wordLength):
Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached...
aroben@apple.com [Sun, 27 Feb 2011 21:29:42 +0000 (21:29 +0000)]
Add Windows expected failure results for fast/events/pageshow-pagehide-on-back-cached.html

<http://webkit.org/b/55329> tracks the failure.

* platform/win/fast/events/pageshow-pagehide-on-back-cached-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Windows expected failure results for fast/images/support-broken-image-delegate...
aroben@apple.com [Sun, 27 Feb 2011 21:29:12 +0000 (21:29 +0000)]
Add Windows expected failure results for fast/images/support-broken-image-delegate.html

<http://webkit.org/b/55324> tracks the failure.

* platform/win/fast/images/support-broken-image-delegate-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ResourceLoadDelegate print URLs relative to the main resource on Windows
aroben@apple.com [Sun, 27 Feb 2011 21:16:50 +0000 (21:16 +0000)]
Make ResourceLoadDelegate print URLs relative to the main resource on Windows

This matches Mac. (In fact, the code was ported from Mac!)

Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
match Mac

Reviewed by Anders Carlsson.

* DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
(urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
_drt_descriptionSuitableForTestResult].
(cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.

* DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.

* DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
DumpRenderTree.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 19:38:50 +0000 (19:38 +0000)]
2011-02-27  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
        https://bugs.webkit.org/show_bug.cgi?id=55322

        Documentation update, add a reference to the QtWebKit bridge page.

        * Api/qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate DeprecatedPtrList
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 18:59:01 +0000 (18:59 +0000)]
Eliminate DeprecatedPtrList
https://bugs.webkit.org/show_bug.cgi?id=17425

Reviewed by Andreas Kling.

Remove the implementation of DeprecatedPtrList and all its references
from the build systems.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/DeprecatedPtrList.h: Removed.
* platform/DeprecatedPtrListImpl.cpp: Removed.
* platform/DeprecatedPtrListImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Windows-specific html5lib results
aroben@apple.com [Sun, 27 Feb 2011 18:25:45 +0000 (18:25 +0000)]
Remove Windows-specific html5lib results

I suspect these haven't been needed since r77781.

* platform/win/html5lib/runner-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange the order of Chang Shu's email addresses so the first one is their Bugzilla...
aroben@apple.com [Sun, 27 Feb 2011 18:15:41 +0000 (18:15 +0000)]
Change the order of Chang Shu's email addresses so the first one is their Bugzilla username

This makes Bugzilla autocompletion work correctly.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-27 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sun, 27 Feb 2011 18:05:12 +0000 (18:05 +0000)]
2011-02-27  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed GTK compilation after r79806.

        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/gtk/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows
aroben@apple.com [Sun, 27 Feb 2011 18:04:40 +0000 (18:04 +0000)]
Skip fast/frames/iframe-plugin-load-remove-document-crash.html on Windows

It's been crashing since it was added in r79808. <http://webkit.org/b/55307> tracks the
failure.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-27 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Feb 2011 17:59:33 +0000 (17:59 +0000)]
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] fast/loader/user-stylesheet-fast-path.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50911

        * platform/qt/Skipped:  Unskip test which is now passing.
2011-02-27  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] fast/loader/user-stylesheet-fast-path.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50911

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setUserStyleSheetLocation):
        Use QUrl::fromEncoded since the passed string is already encoded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure $testResultsDirectory is an absolute path before setting up Windows crash...
aroben@apple.com [Sun, 27 Feb 2011 17:29:35 +0000 (17:29 +0000)]
Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving

Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
is different from old-run-webkit-test's. Because of this, the path to the crash log file
(which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
details.

Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
--results-directory path is used (like on the test slaves)

Reviewed by Dan Bernstein.

* Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
made $testResultsDirectory an absolute path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 27 Feb 2011 15:56:01 +0000 (15:56 +0000)]
2011-02-27  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Use WTF ref counting for FontPlatformDataPrivate
        https://bugs.webkit.org/show_bug.cgi?id=55303

        Make FontPlatformDataPrivate a RefCounted<FPDP>.
        Incidentally fixes an uninitialized member bug in FontPlatformData().

        * platform/graphics/qt/FontPlatformData.h:
        (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::isHashTableDeletedValue):
        (WebCore::FontPlatformData::font):
        (WebCore::FontPlatformData::size):
        (WebCore::FontPlatformData::family):
        (WebCore::FontPlatformData::bold):
        (WebCore::FontPlatformData::italic):
        (WebCore::FontPlatformData::smallCaps):
        (WebCore::FontPlatformData::pixelSize):
        * platform/graphics/qt/FontPlatformDataQt.cpp:
        (WebCore::toQFontWeight):
        (WebCore::FontPlatformData::operator==):
        (WebCore::FontPlatformData::hash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEliminate DeprecatedPtrList from RenderBlock
benjamin.poulain@nokia.com [Sun, 27 Feb 2011 15:51:19 +0000 (15:51 +0000)]
Eliminate DeprecatedPtrList from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=54972

Patch by Benjamin Poulain <ikipou@gmail.com> on 2011-02-27
Reviewed by Darin Adler.

Source/JavaScriptCore:

Add methods find() and contains() using an adaptor to ListHashSet.
Those method are like the one of HashSet, they allow to find objects
based on a different key than the one used to define the set.

Add convenience methods for direct access to the head and tail of the list.
Those methods are providing similar API/behavior as Vector.

* wtf/ListHashSet.h:
(WTF::::first):
(WTF::::last):
(WTF::::removeLast):
(WTF::ListHashSetTranslatorAdapter::hash):
(WTF::ListHashSetTranslatorAdapter::equal):
(WTF::::find):
(WTF::::contains):

Source/WebCore:

Refactor RenderBlock to get rid of the DeprecatedPtrList.
The floating objects are stored in a ListHashSet.

Refactoring covered by existing test.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObjectHashFunctions::hash):
(WebCore::RenderBlock::FloatingObjectHashFunctions::equal):
(WebCore::RenderBlock::FloatingObjectHashTranslator::hash):
(WebCore::RenderBlock::FloatingObjectHashTranslator::equal):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::matchedEndLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 27 Feb 2011 06:53:21 +0000 (06:53 +0000)]
2011-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        <input value="type=submit"> throws a warning (“HTML parse error”)
        https://bugs.webkit.org/show_bug.cgi?id=55120

        This patch removes parse error messages from the HTML parser.  These
        messages are displayed at the wrong times, aren't tested, and aren't
        helpful.  We'll try again with some more informative messages and
        better testing.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::parseError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 27 Feb 2011 03:38:36 +0000 (03:38 +0000)]
2011-02-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove registerBaseEncodingNames and registerBaseCodecs from TextCodecBrew
        https://bugs.webkit.org/show_bug.cgi?id=55309

        This functions are obsolete, since r78499 added TextCodecUTF8.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        * platform/text/brew/TextCodecBrew.cpp:
        * platform/text/brew/TextCodecBrew.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Dihan Wickremasuriya <dihan.wickremasuriya@nokia.com>
commit-queue@webkit.org [Sun, 27 Feb 2011 03:28:47 +0000 (03:28 +0000)]
2011-02-26  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Disable dependency to a specific version of a Qt package for
        non-production builds.
        https://bugs.webkit.org/show_bug.cgi?id=55313

        * Source/WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Dominic Mazzoni <dmazzoni@google.com>
commit-queue@webkit.org [Sun, 27 Feb 2011 02:45:54 +0000 (02:45 +0000)]
2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>

        Reviewed by Adam Barth.

        m_dumpAccessibilityNotifications should be initialized.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        * DumpRenderTree/chromium/AccessibilityController.cpp:
        (AccessibilityController::AccessibilityController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 26 Feb 2011 23:03:47 +0000 (23:03 +0000)]
2011-02-26  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        Add support for DragonFly BSD
        https://bugs.webkit.org/show_bug.cgi?id=54407

        DragonFly BSD is based on FreeBSD, so handle it like FreeBSD.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 26 Feb 2011 22:55:37 +0000 (22:55 +0000)]
2011-02-26  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Skip the test on QT, GTK until we can figure out the plugin load problem.
        https://bugs.webkit.org/show_bug.cgi?id=55307

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Sat, 26 Feb 2011 22:40:36 +0000 (22:40 +0000)]
2011-02-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Delay firing of mutation events while setting attribute values
        https://bugs.webkit.org/show_bug.cgi?id=55199

        * fast/dom/attribute-change-on-mutate-expected.txt: Added.
        * fast/dom/attribute-change-on-mutate.html: Added.
2011-02-26  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        Delay firing of mutation events while setting attribute values
        https://bugs.webkit.org/show_bug.cgi?id=55199

        Test: fast/dom/attribute-change-on-mutate.html

        * dom/Attr.cpp:
        (WebCore::Attr::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Sat, 26 Feb 2011 22:38:44 +0000 (22:38 +0000)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed
        https://bugs.webkit.org/show_bug.cgi?id=55252

        Need to invoke a callback function to notify the HTMLMediaElement
        when MediaPlayerPrivateQt's playback state gets changed.

        * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt): Set a flag to ignore the playback state change for pre-roll
        (WebCore::MediaPlayerPrivateQt::commitLoad): Call playbackStateChanged() to notify HTMLMediaElement
        (WebCore::MediaPlayerPrivateQt::stateChanged):
        * platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 26 Feb 2011 21:26:04 +0000 (21:26 +0000)]
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Tests that removing a document during a plugin load does not result
        in crash.
        https://bugs.webkit.org/show_bug.cgi?id=55289

        * fast/frames/iframe-plugin-load-remove-document-crash-expected.txt: Added.
        * fast/frames/iframe-plugin-load-remove-document-crash.html: Added.
2011-02-25  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        When plugin document parser finishes parsing, it runs the raw
        document's parser finish functions which call the pending document
        onload events that removes the frame from underneath. So, we protect
        frame (and hence frameloader) in DocumentLoader::commitLoad.
        https://bugs.webkit.org/show_bug.cgi?id=55289

        Test: fast/frames/iframe-plugin-load-remove-document-crash.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 21:02:05 +0000 (21:02 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Asynchronous response to FramePolicyListener is not finishing the load
        https://bugs.webkit.org/show_bug.cgi?id=55305
        <rdar://problem/9044356>

        Always initialize the receivedPolicyAction reply parameter.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::decidePolicyForNavigationAction):
        (WebKit::WebPageProxy::decidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 20:44:53 +0000 (20:44 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        DidFinishLoadingDataForCustomRepresentation should pass along the suggested filename
        https://bugs.webkit.org/show_bug.cgi?id=55304

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (WebKit::PDFViewController::setPDFDocumentData):
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _didFinishLoadingDataForCustomRepresentationWithSuggestedFilename:dataReference:CoreIPC::]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
        * UIProcess/win/WebView.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::finishedLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 20:14:47 +0000 (20:14 +0000)]
2011-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: rolling out 79799 and 79804 for breaking xml tests on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 19:58:04 +0000 (19:58 +0000)]
2011-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r79799. Fixing WinCE+Efl, mute new tests on Qt.
        https://bugs.webkit.org/show_bug.cgi?id=55302

        * CMakeLists.txt:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 26 Feb 2011 19:10:39 +0000 (19:10 +0000)]
2011-02-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        DrawingArea should not be reference counted
        https://bugs.webkit.org/show_bug.cgi?id=55284

        * Shared/DrawingAreaInfo.h:
        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
        (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
        (WebKit::ChunkedUpdateDrawingAreaProxy::update):
        (WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.cpp:
        (WebKit::DrawingAreaProxy::DrawingAreaProxy):
        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::type):
        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
        * UIProcess/DrawingAreaProxyImpl.h:
        * UIProcess/TiledDrawingAreaProxy.cpp:
        (WebKit::TiledDrawingAreaProxy::TiledDrawingAreaProxy):
        * UIProcess/TiledDrawingAreaProxy.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveSyncMessage):
        (WebKit::WebPageProxy::creationParameters):
        * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
        (WebKit::ChunkedUpdateDrawingArea::display):
        (WebKit::ChunkedUpdateDrawingArea::setSize):
        (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        (WebKit::DrawingArea::DrawingArea):
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::create):
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/TiledDrawingArea.cpp:
        (WebKit::TiledDrawingArea::TiledDrawingArea):
        * WebProcess/WebPage/TiledDrawingArea.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 19:08:30 +0000 (19:08 +0000)]
2011-02-26  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Xan Lopez.

        [GTK] Implemented API to set/get web application cache directory path database.

        * GNUmakefile.am: Add webkitapplicationcache.h file.
        * webkit/webkit.h: Add webkitapplicationcache.h file.
        * webkit/webkitapplicationcache.cpp: definition of API setting and getting
        web application cache directory path database.
        (webkit_application_cache_get_database_directory_path):
        (webkit_application_cache_set_database_directory_path):
        * webkit/webkitapplicationcache.h: Added new API file for setting and getting
        web application cache directory path database.
        * webkit/webkitglobals.cpp:
        (webkitInit): use webkit_application_cache_set_database_directory_path
        to set default web application cache directory path database.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 19:06:03 +0000 (19:06 +0000)]
2011-02-26  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations update.

        Add failing expectation for fast/images/support-broken-image-delegate.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 19:00:09 +0000 (19:00 +0000)]
2011-02-26  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed update of the Chromium html5lib expectations after r79765
        (diff matches the base expectations change).

        * platform/chromium/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 18:54:02 +0000 (18:54 +0000)]
2011-02-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        Added tests for XML tree view mode. Testing both logic for entering
        XML tree view mode and rendering itself.

        * http/tests/xmlviewer/dumpAsText/css-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/css-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/frames-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/frames.html: Added.
        * http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/mathml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/css-stylesheet.css: Added.
        (assertion):
        * http/tests/xmlviewer/dumpAsText/resources/frames-helper.xml: Added.
        * http/tests/xmlviewer/dumpAsText/resources/xsl.xml: Added.
        * http/tests/xmlviewer/dumpAsText/svg-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/svg.xml: Added.
        * http/tests/xmlviewer/dumpAsText/wml-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/wml.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xhtml-tag.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xlink-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xlink.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xmlviewer.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml: Added.
        * http/tests/xmlviewer/dumpAsText/xul-expected.txt: Added.
        * http/tests/xmlviewer/dumpAsText/xul.xml: Added.
        * platform/chromium/http/tests/xmlviewer/dumpAsText/mathml-expected.txt: Added.
2011-02-25  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        XML without style should render as syntax-highlighted source.
        https://bugs.webkit.org/show_bug.cgi?id=13807

        XML tree view mode implemented. If XML does not have any style
        information, it is rendered as highlighted source with collapsable
        elements.

        Tests: http/tests/xmlviewer/dumpAsText/css-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/frames.html
               http/tests/xmlviewer/dumpAsText/mathml.xml
               http/tests/xmlviewer/dumpAsText/svg.xml
               http/tests/xmlviewer/dumpAsText/wml.xml
               http/tests/xmlviewer/dumpAsText/xhtml-tag.xml
               http/tests/xmlviewer/dumpAsText/xlink.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-cp1251.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer-charset-utf8.xml
               http/tests/xmlviewer/dumpAsText/xmlviewer.xml
               http/tests/xmlviewer/dumpAsText/xsl-stylesheet.xml
               http/tests/xmlviewer/dumpAsText/xul.xml

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::createElement):
        * dom/Document.h:
        (WebCore::Document::usesViewSourceStyles):
        (WebCore::Document::setUsesViewSourceStyles):
        (WebCore::Document::sawElementsInKnownNamespaces):
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        * xml/XMLTreeViewer.cpp: Added.
        (WebCore::XMLTreeViewer::XMLTreeViewer):
        (WebCore::XMLTreeViewer::hasNoStyleInformation):
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):
        * xml/XMLTreeViewer.h: Added.
        (WebCore::XMLTreeViewer::~XMLTreeViewer):
        * xml/XMLViewer.xsl: Added.
        * xml/XSLStyleSheet.h:
        (WebCore::XSLStyleSheet::createFromString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Christian Dywan <christian@lanedo.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 18:26:08 +0000 (18:26 +0000)]
2011-02-26  Christian Dywan  <christian@lanedo.com>

        Reviewed by Andreas Kling.

        Untranslated network error messages
        https://bugs.webkit.org/show_bug.cgi?id=55223

        * POTFILES: Add FrameLoaderClientGtk.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 17:29:47 +0000 (17:29 +0000)]
2011-02-26  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        [chromium] Update op-get-entry filesystem test to match spec
        https://bugs.webkit.org/show_bug.cgi?id=55263

        Chromium behavior changed in r76098. This patch updates WebKit test
        to match. Both now match the spec, which says of TYPE_MISMATCH_ERR:

          user agent MUST use this code when the user has attempted to look up
          a file or directory, but the Entry found is of the wrong type

        Reference: http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#error-code-descriptions

        * fast/filesystem/op-get-entry-expected.txt:
        * fast/filesystem/resources/op-get-entry.js:
        GetFile/GetDirectory now expected to return TYPE_MISMATCH_ERR
        if requesting a non-file/non-directory.
        * platform/chromium/test_expectations.txt:
        Allow op-get-entry to pass while waiting for Chromium roll.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 26 Feb 2011 17:26:46 +0000 (17:26 +0000)]
2011-02-26  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium expectations change.

        Remove failing Snow Leopard expectations for tests that were fixed by
        r79754.

        Skip more viewport tests added by r79783.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sat, 26 Feb 2011 17:12:30 +0000 (17:12 +0000)]
2011-02-26  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable usage of synchronous HTTP feature in Qt
        https://bugs.webkit.org/show_bug.cgi?id=37191

        Currently, we spin an event loop when doing synchronous calls to
        wait for completion. This patch uses synchronous requests in Qt,
        if available, and spins the event loop as a fallback solution.

        Based on work by Simon Hausmann and Peter Hartmann.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/QNetworkReplyHandler.h:
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::WebCoreSynchronousLoader::setReplyFinished):
        (WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
        (WebCore::WebCoreSynchronousLoader::didFinishLoading):
        (WebCore::WebCoreSynchronousLoader::didFail):
        (WebCore::ResourceHandle::loadResourceSynchronously):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 26 Feb 2011 17:02:46 +0000 (17:02 +0000)]
2011-02-26  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        REGRESSION(r79398): Webkit crash on dojo theme tester page
        https://bugs.webkit.org/show_bug.cgi?id=55290

        Added a test to ensure WebKit does not crash when querying style value without selection.

        * editing/execCommand/value-without-selection-crash-expected.txt: Added.
        * editing/execCommand/value-without-selection-crash.html: Added.
2011-02-26  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        REGRESSION(r79398): Webkit crash on dojo theme tester page
        https://bugs.webkit.org/show_bug.cgi?id=55290

        The bug was caused by selectionStartCSSPropertyValue's not considering the possibility
        of selectionStartStyle() returning a null pointer. Fixed it by adding a null check.

        Test: editing/execCommand/value-without-selection-crash.html

        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartCSSPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 16:31:17 +0000 (16:31 +0000)]
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        No new tests. (no code affected, just exporting a method for DumpRenderTree use)

        * WebCore.exp.in:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFrame.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearOpener):
        * src/WebFrameImpl.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportGTK.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFramePrivate.

        * WebView/WebFrame.mm:
        (-[WebFrame _clearOpener]):
        * WebView/WebFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportQT.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to IWebFramePrivate.
        Touched WebKit.idl to trigger build scripts.

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        (WebFrame::clearOpener):
        * WebFrame.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WKBundleWebFramePrivate.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameClearOpener):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener() calls between tests.
        Some tests are using window.open() to change current window location.
        This changes window.opener property whose nullity is checked before
        showing xml viewer.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Sat, 26 Feb 2011 16:20:19 +0000 (16:20 +0000)]
2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Replace WTF_USE_SOUP macro with USE(SOUP)
        https://bugs.webkit.org/show_bug.cgi?id=55296

        ewk_cookies.cpp and ewk_main.cpp are using WTF_USE_SOUP macro.
        So, according to policy decision macro usage, the macro needs to
        be changed with USE(SOUP).

        * ewk/ewk_cookies.cpp:
        (ewk_cookies_file_set):
        (ewk_cookies_clear):
        (ewk_cookies_get_all):
        (ewk_cookies_cookie_del):
        (ewk_cookies_cookie_free):
        (ewk_cookies_policy_set):
        (ewk_cookies_policy_get):
        * ewk/ewk_main.cpp:
        (_ewk_init_body):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Sat, 26 Feb 2011 15:52:57 +0000 (15:52 +0000)]
2011-02-26  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Fix the focus in MiniBrowser.
        https://bugs.webkit.org/show_bug.cgi?id=55288

        Implement basic functionality for focus in QWKPagePrivate.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::isViewWindowActive):
        (QWKPagePrivate::isViewFocused):
        (QWKPagePrivate::isViewVisible):
2011-02-26  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Fix the focus in MiniBrowser.
        https://bugs.webkit.org/show_bug.cgi?id=55288

        Give focus to the web view when a load starts.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (BrowserWindow::urlChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 15:48:16 +0000 (15:48 +0000)]
2011-02-26  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        On Mac, need to remove misspell underline in Editor::learnSpelling().
        https://bugs.webkit.org/show_bug.cgi?id=55251

        This change makes sure that the misspelling markers are removed after the word is learned.

        * editing/Editor.cpp:
        (WebCore::Editor::learnSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Sat, 26 Feb 2011 15:38:13 +0000 (15:38 +0000)]
2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Adam Barth.

        [EFL] Add coding style exceptions for EFL port
        https://bugs.webkit.org/show_bug.cgi?id=54733

        The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
        underscore-sparated values. But, style checking rule have found parameter_name errors
        in efl directories so far.

        * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 26 Feb 2011 15:32:59 +0000 (15:32 +0000)]
2011-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        JavaScriptCore should use the xcconfig file instead of importing that information into GYP
        https://bugs.webkit.org/show_bug.cgi?id=55282

        Technically, this breaks the build because I had removed one of the
        warnings in this config file, but this change seems like an
        improvement.

        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 David Levin <levin@chromium.org>
levin@chromium.org [Sat, 26 Feb 2011 15:29:46 +0000 (15:29 +0000)]
2011-02-26  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        check-webkit-style should check for spaces after periods in comments
        https://bugs.webkit.org/show_bug.cgi?id=55253

        * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
          and fixed the name of one related test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 26 Feb 2011 15:00:11 +0000 (15:00 +0000)]
2011-02-26  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: rolling chromium DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 David Levin <levin@chromium.org>
levin@chromium.org [Sat, 26 Feb 2011 14:45:10 +0000 (14:45 +0000)]
2011-02-26  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        Add style guidelines about comments from the unwritten rules email.
        https://bugs.webkit.org/show_bug.cgi?id=55272

        * coding/coding-style.html: Added the guidelines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Rik Cabanier <cabanier@adobe.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 14:40:20 +0000 (14:40 +0000)]
2011-02-26  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        Transitions now return matrices in floating point. 2 of the transition tests were failing
        because they expected integer values.

        * transitions/matched-transform-functions.html:
        * transitions/retargetted-transition.html:
2011-02-26  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by David Hyatt.

        Fix that allows fixed length values to be floating point
        https://bugs.webkit.org/show_bug.cgi?id=52699

        Transitions now return matrices in floating point. 2 of the transition tests were failing
        because they expected integer values.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::convertToIntLength):
        (WebCore::convertToFloatLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::createTransformOperations):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator==):
        (WebCore::Length::operator!=):
        (WebCore::Length::rawValue):
        (WebCore::Length::type):
        (WebCore::Length::quirk):
        (WebCore::Length::setValue):
        (WebCore::Length::calcFloatValue):
        (WebCore::Length::isZero):
        (WebCore::Length::blend):
        (WebCore::Length::getIntValue):
        (WebCore::Length::getFloatValue):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Sat, 26 Feb 2011 14:39:12 +0000 (14:39 +0000)]
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        * fast/viewport/viewport-*.html: Update to new JS API.
        * fast/viewport/viewport-91.html: Add new tests.
        * fast/viewport/viewport-92.html:
        * fast/viewport/viewport-93.html:
        * fast/viewport/viewport-94.html:
        * fast/viewport/viewport-95.html:
        * fast/viewport/viewport-96.html:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::viewportAsText):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Make it possible to test the targetdensity-dpi support
        https://bugs.webkit.org/show_bug.cgi?id=55142

        Test the viewport meta tag feature targetdensity-dpi by
        adding extra arguments to dumpConfigurationForViewport

        Add the new arguments to the shared header and all
        implementation.

        * DumpRenderTree/LayoutTestController.cpp:
        (dumpConfigurationForViewportCallback):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::dumpConfigurationForViewport):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 14:26:03 +0000 (14:26 +0000)]
2011-02-26  Bill Budge  <bbudge@chromium.org>

        Reviewed by David Levin.

        WebURLRequest, WebURLResponse properties should be passed to WebCore Layer
        https://bugs.webkit.org/show_bug.cgi?id=54489

        No tests needed. This is already tested by ui_tests, nacl_ui_tests, and nacl_sandbox_tests

        * src/WebURLRequest.cpp:
        (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl):
        (WebKit::WebURLRequest::downloadToFile):
        (WebKit::WebURLRequest::setDownloadToFile):
        * src/WebURLRequestPrivate.h:
        (WebKit::WebURLRequestPrivate::WebURLRequestPrivate):
        * src/WebURLResponse.cpp:
        (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl):
        (WebKit::WebURLResponse::downloadFilePath):
        (WebKit::WebURLResponse::setDownloadFilePath):
        * src/WebURLResponsePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 13:59:36 +0000 (13:59 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        malloc in removeChildren shows up on profile of peacekeeper domDynamicCreationCreateElement
        https://bugs.webkit.org/show_bug.cgi?id=55204

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::removeChildren):
         - Using an inlineCapacity of 10 for now. We may want to tweak it later.
         - This removes yet another malloc from code which removes nodes (which is rather common).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 13:47:13 +0000 (13:47 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        HashSet<T>::end() creation is expensive and should be avoided
        https://bugs.webkit.org/show_bug.cgi?id=55205

        In the common case, m_ranges is an empty set.  When that's
        the case, we spend all our time in skipEmptyBuckets, walking
        the hash storage skipping over empty buckets.

        This looks to be at least a 5% speedup on (my local version of) peacekeeper's domDynamicCreationCreateElement.

        Before:
        avg 383.6666666666667
        median 386
        stdev 7.152311203768722
        min 360
        max 391

        After:
        avg 366.3333333333333
        median 366
        stdev 2.712112747574399
        min 362
        max 377

        * dom/Document.cpp:
        (WebCore::Document::nodeChildrenChanged):
        (WebCore::Document::nodeChildrenWillBeRemoved):
        (WebCore::Document::nodeWillBeRemoved):
        (WebCore::Document::textInserted):
        (WebCore::Document::textRemoved):
        (WebCore::Document::textNodesMerged):
        (WebCore::Document::textNodeSplit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
rniwa@webkit.org [Sat, 26 Feb 2011 13:15:58 +0000 (13:15 +0000)]
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        * src/WebFrameImpl.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        * WebFrame.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebView/WebFrame.mm:
        * WebView/WebFramePrivate.h:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebCore.exp.in:
2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79764.
        http://trac.webkit.org/changeset/79764
        https://bugs.webkit.org/show_bug.cgi?id=55295

        "broke Chromium builds" (Requested by rniwa on #webkit).

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 13:14:04 +0000 (13:14 +0000)]
2011-02-26  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
        https://bugs.webkit.org/show_bug.cgi?id=54585

        * fast/filesystem/resources/file-entry-to-uri-sync.js: Added.
        * fast/filesystem/workers/file-entry-to-uri-sync-expected.txt: Added.
        * fast/filesystem/workers/file-entry-to-uri-sync.html: Added.
2011-02-26  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [fileapi] Implement EntrySync.toURI by moving Entry::toURI to EntryBase
        https://bugs.webkit.org/show_bug.cgi?id=54585

        In order to move toURI to EntryBase, it needed access to
        SecurityOrigin. Most of the changes below were to pass a
        ScriptExecutionContext to DOMFileSystemBase to enable this.

        Test: fast/filesystem/workers/file-entry-to-uri-sync.html

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * fileapi/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::DOMFileSystem):
        * fileapi/DOMFileSystemBase.cpp:
        (WebCore::DOMFileSystemBase::DOMFileSystemBase):
        (WebCore::DOMFileSystemBase::securityOrigin):
        * fileapi/DOMFileSystemBase.h:
        (WebCore::DOMFileSystemBase::create):
        * fileapi/DOMFileSystemSync.cpp:
        (WebCore::DOMFileSystemSync::create):
        (WebCore::DOMFileSystemSync::DOMFileSystemSync):
        * fileapi/DOMFileSystemSync.h:
        (WebCore::DOMFileSystemSync::create):
        * fileapi/Entry.cpp:
        * fileapi/Entry.h:
        * fileapi/EntryBase.cpp: Added.
        (WebCore::EntryBase::EntryBase):
        (WebCore::EntryBase::~EntryBase):
        (WebCore::EntryBase::toURI):
        * fileapi/EntryBase.h:
        * fileapi/EntrySync.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Alice Boxhall <aboxhall@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 12:12:13 +0000 (12:12 +0000)]
2011-02-26  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ojan Vafai.

        Tests that typing enter in the input element does not fire textInput.
        https://bugs.webkit.org/show_bug.cgi?id=54152

        * fast/forms/textinput-not-fired-on-enter-in-input-expected.txt: Added.
        * fast/forms/textinput-not-fired-on-enter-in-input.html: Added.
2011-02-26  Alice Boxhall  <aboxhall@chromium.org>

        Reviewed by Ojan Vafai.

        typing enter in the input element should not fire textInput
        https://bugs.webkit.org/show_bug.cgi?id=54152

        Stop textInput event propagation in HTMLInputElement::preDispatchEventHandler if the event target should submit implicitly.

        Test: fast/forms/textinput-not-fired-on-enter-in-input.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::preDispatchEventHandler): Check m_inputType->shouldSubmitImplicitly for textInputEvents and stop propagation if true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 26 Feb 2011 12:04:55 +0000 (12:04 +0000)]
2011-02-26  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] loadEvent timing should refer to first load event if there are many
        https://bugs.webkit.org/show_bug.cgi?id=55201

        * fast/dom/script-tests/webtiming-document-open.js:
        (testTimingWithDocumentOpen): Fire via setTimeout to match w3c test and reveal loadEventEnd.
        (finishTest): Fire via setTimeout to match w3c test.
2011-02-26  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        [Web Timing] loadEvent timing should refer to first load event if there are many
        https://bugs.webkit.org/show_bug.cgi?id=55201

        Test: fast/dom/webtiming-document-open.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 26 Feb 2011 11:20:11 +0000 (11:20 +0000)]
2011-02-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Fix isLayoutTimerActive for ports that set a minimumLayoutDelay
        https://bugs.webkit.org/show_bug.cgi?id=54810

        No new tests because no new functionality.

        * dom/Document.cpp:
        (WebCore::Document::isLayoutTimerActive): Moved from HTMLParserScheduler per FIXME. Compare
        minimumLayoutDelay() to m_extraLayoutDelay instead of 0. This spirit of this comparison was
        broken by r52919. The effect would be that ports that set an extra layout delay can't yield
        between tokens. Note: can't be const because minimumLayoutDelay sets a member.
        * dom/Document.h:
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
        (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 David Dorwin <ddorwin@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 10:17:48 +0000 (10:17 +0000)]
2011-02-26  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Darin Fisher.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        Tested by the existing fullscreen Layout Tests.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2011-02-26  David Dorwin  <ddorwin@chromium.org>

        Reviewed by Darin Fisher.

        Enable WebKit Full Screen API in Chromium. The element becomes the full size of the window, but the window is not yet full screen. Support is disabled by default.

        fullscreen javascript bindings not implemented for v8
        https://bugs.webkit.org/show_bug.cgi?id=44797

        * features.gypi:
        * public/WebSettings.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        (WebKit::ChromeClientImpl::enterFullScreenForElement):
        (WebKit::ChromeClientImpl::exitFullScreenForElement):
        (WebKit::ChromeClientImpl::fullScreenRendererChanged):
        * src/ChromeClientImpl.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setFullScreenEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 10:11:10 +0000 (10:11 +0000)]
2011-02-26  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Nikolas Zimmermann.

        SH4 JIT SUPPORT
        https://bugs.webkit.org/show_bug.cgi?id=44329

        Provide an ExecutableAllocater::cacheFlush() implementation for
        Linux/SH4.

        * jit/ExecutableAllocator.h:
        (JSC::ExecutableAllocator::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Sat, 26 Feb 2011 09:45:44 +0000 (09:45 +0000)]
2011-02-26  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Prevent parser yields from triggering early dumpAsText()
        https://bugs.webkit.org/show_bug.cgi?id=55187

        DRT's dumpAsText() takes a snapshot when DocumentLoader::isLoadingInAPISense()
        indicates the page is done. isLoadingInAPISense depends on
        HTMLDocumentParser::isProcessingData(), which just checks if the parser is in an
        insert() or append().

        This means that if the parser is pumping in a resumeParsingAfterScriptExecution() or
        resumeParsingAfterYield(), isLoadingInAPISense() may not be blocked. This patch
        fixes that by repurposing m_writeNestingLevel as m_pumpSessionNestingLevel and
        incrementing it in pumpTokenizer().

        When I locally cause the parser to yield after every token, a lot of tests fail
        because DRT snapshots too early. This patch fixes those tests, however I'm having
        trouble writing a test case that reliably reproduces the problem without this patch
        and passes with it (without changing yield constants). This is because it requires
        4,096 tokens in a single pump session to yield and (len('<b>' * 4096 = 12k, which
        doesn't always happen).

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::processingData):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        (WebCore::HTMLDocumentParser::insert):
        (WebCore::HTMLDocumentParser::append):
        * html/parser/HTMLDocumentParser.h:
        (WebCore::HTMLDocumentParser::inPumpSession):
        (WebCore::HTMLDocumentParser::shouldDelayEnd):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::PumpSession::PumpSession):
        * html/parser/NestingLevelIncrementer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 09:32:19 +0000 (09:32 +0000)]
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        * fast/images/resources/broken-image-with-invalid-format.png: Added.
        * fast/images/support-broken-image-delegate.html: Added.
        * platform/mac/fast/images/support-broken-image-delegate-expected.txt: Added.
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.  The method also passes the
        URL of the failed image.

        Test: fast/images/support-broken-image-delegate.html

        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::shouldPaintBrokenImage):
        * loader/cache/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::checkShouldPaintBrokenImage):
        (WebCore::CachedImage::error):
        * loader/cache/CachedImage.h:
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.  The method also passes the
        URL of the failed image.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::shouldPaintBrokenImage):
        * WebView/WebDelegateImplementationCaching.h:
        * WebView/WebDelegateImplementationCaching.mm: Added case for passing one object.
        (CallResourceLoadDelegateReturningBoolean):
        * WebView/WebResourceLoadDelegatePrivate.h:
        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]):
2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>

        Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=48781

        Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.

        Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
        should paint the default broken image when an image fails to load or decode.

        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (setShouldPaintBrokenImageCallback):
        (LayoutTestController::staticFunctions):
        (LayoutTestController::setShouldPaintBrokenImage):
        * DumpRenderTree/LayoutTestController.h:
        (LayoutTestController::shouldPaintBrokenImage):
        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 09:24:26 +0000 (09:24 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove disabled xmlhttprequest/web-apps tests
        https://bugs.webkit.org/show_bug.cgi?id=55181

        Per ap's suggestion in:
        https://bugs.webkit.org/show_bug.cgi?id=55164#c15

        I don't think we've ever run these tests.  Some of them
        depend on 10 minute timeouts and another nonsense. :)

        * http/tests/xmlhttprequest/web-apps/006-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/006.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/009-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/009.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/016-test.cgi: Removed.
        * http/tests/xmlhttprequest/web-apps/016.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/017.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/recursion/001.html-disabled: Removed.
        * http/tests/xmlhttprequest/web-apps/recursion/README: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 09:16:01 +0000 (09:16 +0000)]
2011-02-26  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Database: Data race: should only touch the transaction queue inside the
        lock.
        https://bugs.webkit.org/show_bug.cgi?id=55031

        * storage/Database.cpp:
        (WebCore::Database::changeVersion): only touch queue inside lock.
        (WebCore::Database::runTransaction): only touch queue inside lock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Sat, 26 Feb 2011 09:03:34 +0000 (09:03 +0000)]
2011-02-26  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Carlson.

        Missing volumechangeEvent in case of mediaPlayerVolumeChanged gets callback
        https://bugs.webkit.org/show_bug.cgi?id=55147

        When HTMLMediaElement::mediaPlayerVolumeChanged() gets callback,
        a volumechangeEvent event should be fired if the volume gets changed.

        Test: media/event-attributes.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setMuted): Remove updateVolume() since it does nothing when m_player is 0.
        (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): Fire a volumechangeEvent when the volume is changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 John Mellor <johnme@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:59:38 +0000 (08:59 +0000)]
2011-02-26  John Mellor  <johnme@chromium.org>

        Reviewed by Antonio Gomes.

        [chromium] WebFrameImpl::m_totalMatchCount should be an int
        https://bugs.webkit.org/show_bug.cgi?id=55134

        WebFrameImpl::m_totalMatchCount should be an int instead of a size_t since it can be -1.

        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 08:41:55 +0000 (08:41 +0000)]
2011-02-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        disableRangeMutation quirk for mail slows down peacekeeper domDynamicCreationCreateElement
        https://bugs.webkit.org/show_bug.cgi?id=55127

        Before:
        avg 513.4
        median 515
        stdev 7.234638899074368
        min 490
        max 528

        After:
        avg 508.15
        median 510
        stdev 6.966168243733426
        min 485
        max 515

        Yes, the stdev is a bit high to actually support my conclusions.  But looking
        at the profile, this change makes a lot of sense.  I'll up the iterations
        for future testing.

        * dom/Document.cpp:
        (WebCore::disableRangeMutation):
         - This check should only be compiled in if we're planning to run on Tiger or Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 26 Feb 2011 08:35:29 +0000 (08:35 +0000)]
2011-02-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Synchronized tests with html5lib
        https://bugs.webkit.org/show_bug.cgi?id=55128

        I didn't copy all of plain-test-unsafe because it confuses pretty-diff.

        * html5lib/resources/pending-spec-changes-plain-text-unsafe.dat:
        * html5lib/resources/pending-spec-changes.dat:
        * html5lib/resources/tests1.dat:
        * html5lib/resources/tests10.dat:
        * html5lib/resources/tests19.dat:
        * html5lib/resources/tests20.dat:
        * html5lib/resources/tests22.dat: Added.
        * html5lib/resources/tests23.dat: Added.
        * html5lib/resources/tests24.dat: Added.
        * html5lib/resources/tests25.dat: Added.
        * html5lib/resources/tests26.dat: Added.
        * html5lib/resources/tests3.dat:
        * html5lib/resources/tests6.dat:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:16:26 +0000 (08:16 +0000)]
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        No new tests. (no code affected, just exporting a method for DumpRenderTree use)

        * WebCore.exp.in:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFrame.

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::clearOpener):
        * src/WebFrameImpl.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportGTK.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WebFramePrivate.

        * WebView/WebFrame.mm:
        (-[WebFrame _clearOpener]):
        * WebView/WebFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to DumpRenderTreeSupportQT.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::clearOpener):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to IWebFramePrivate.
        Touched WebKit.idl to trigger build scripts.

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        (WebFrame::clearOpener):
        * WebFrame.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener method to WKBundleWebFramePrivate.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameClearOpener):
        * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        DumpRenderTree should reset frame opener between tests.
        https://bugs.webkit.org/show_bug.cgi?id=54874

        Added clearOpener() calls between tests.
        Some tests are using window.open() to change current window location.
        This changes window.opener property whose nullity is checked before
        showing xml viewer.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController):
        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 08:13:30 +0000 (08:13 +0000)]
2011-02-26  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Eric Seidel.

        Fix Chromium test failure http://crbug.com/33358
        https://bugs.webkit.org/show_bug.cgi?id=55125

        * platform/chromium/test_expectations.txt:
        * platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-26 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Sat, 26 Feb 2011 08:12:23 +0000 (08:12 +0000)]
2011-02-26  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: Add support for <select> element in multiple selection mode
        https://bugs.webkit.org/show_bug.cgi?id=49261

        Enhanced existing tests and added new tests for the bug.

        * fast/spatial-navigation/snav-multiple-select-expected.txt:
        * fast/spatial-navigation/snav-multiple-select.html:
        * fast/spatial-navigation/snav-single-select-list-expected.txt: Added.
        * fast/spatial-navigation/snav-single-select-list.html: Added.
2011-02-26  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Antonio Gomes.

        Based on patch by Carlos Garcia Campos  <cgarcia@igalia.com>.

        Spatial Navigation: Add support for <select> element in multiple selection mode
        https://bugs.webkit.org/show_bug.cgi?id=49261

        When spatial navigation is enabled, use space key to toggle select
        items. And the up and down keys should not affect selection but just
        navigate through items, which is indicated visually by a focus ring.

        New Test: fast/spatial-navigation/snav-single-select-list.html
        Enhanced Test: fast/spatial-navigation/snav-multiple-select.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::listBoxDefaultEventHandler):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::addFocusRingRects):
        * rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Sat, 26 Feb 2011 07:55:07 +0000 (07:55 +0000)]
2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Added EWebLauncher command line option to turn on/off frame flattening
        https://bugs.webkit.org/show_bug.cgi?id=54809

        * EWebLauncher/main.c: Handling -f option added.
        (on_key_down):
        (browserCreate):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
eric@webkit.org [Sat, 26 Feb 2011 07:33:44 +0000 (07:33 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Make positioned elements work with vertical text
        https://bugs.webkit.org/show_bug.cgi?id=46500

        Rebaseline fast/table/fixed-with-auto-with-colspan-vertical.html for r79725.

        * platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png:
        * platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:
        * platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 26 Feb 2011 05:35:56 +0000 (05:35 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Qt build fix; included CSSValueList.h in EditingStyle.cpp.

        * editing/EditingStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 26 Feb 2011 05:26:30 +0000 (05:26 +0000)]
2011-02-25  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Move HTMLEquivalent and its subclasses to EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=55207

        Moved HTMLEquivalent and its subclasses from ApplyStyleCommand to EditingStyle,
        and renamed HTMLEquivalent, HTMLEquivalentValueList, HTMLAttributeEquivalent,
        and HTMLEquivalentFontSizeAttribute to HTMLElementEquivalent, HTMLTextDecorationEquivalent,
        HTMLAttributeEquivalent, and HTMLFontSizeEquivalent respectively.

        Also extracted the logic to determine which element and attribute are removed
        as conflictsWithImplicitStyleOfElement, conflictsWithImplicitStyleOfAttributes,
        and extractConflictingImplicitStyleOfAttributes.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
        (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::HTMLElementEquivalent::create): Moved from ApplyStyleCommand.cpp.
        (WebCore::HTMLElementEquivalent::~HTMLElementEquivalent): Ditto.
        (WebCore::HTMLElementEquivalent::matches): Ditto.
        (WebCore::HTMLElementEquivalent::hasAttribute): Ditto.
        (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Ditto.
        (WebCore::HTMLElementEquivalent::HTMLElementEquivalent): Ditto.
        (WebCore::HTMLElementEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLElementEquivalent::addToStyle): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::create): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Ditto.
        (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::create): Ditto.
        (WebCore::HTMLAttributeEquivalent::matches): Ditto.
        (WebCore::HTMLAttributeEquivalent::hasAttribute): Ditto.
        (WebCore::HTMLAttributeEquivalent::attributeName): Ditto.
        (WebCore::HTMLAttributeEquivalent::HTMLAttributeEquivalent): Ditto.
        (WebCore::HTMLAttributeEquivalent::valueIsPresentInStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::addToStyle): Ditto.
        (WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue): Ditto.
        (WebCore::HTMLFontSizeEquivalent::create): Ditto.
        (WebCore::HTMLFontSizeEquivalent::HTMLFontSizeEquivalent): Ditto.
        (WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue): Ditto.
        (WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Added.
        (WebCore::htmlAttributeEquivalents): Added.
        (WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes): Added.
        (WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes): Added.
        * editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 26 Feb 2011 02:49:04 +0000 (02:49 +0000)]
2011-02-25  James Robinson  <jamesr@chromium.org>

        Update chromium expectations and add new chromium and mac-leopard baselines for new tests.

        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/chromium-linux/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/differing-writing-modes-replaced-expected.txt: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.png: Added.
        * platform/chromium-win/fast/table/table-continuation-outline-paint-crash-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.checksum: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-expected.png: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.checksum: Added.
        * platform/mac-leopard/fast/block/positioning/differing-writing-modes-replaced-expected.png: Added.
        * platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.checksum: Added.
        * platform/mac-leopard/fast/table/table-continuation-outline-paint-crash-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79757 268f45cc-cd09-0410-ab3c-d52691b4dbfc