WebKit-https.git
10 years agoHoist JSVALUE32_64 arithmetic implementations into a separate file.
oliver@apple.com [Thu, 29 Apr 2010 21:32:26 +0000 (21:32 +0000)]
Hoist JSVALUE32_64 arithmetic implementations into a separate file.

Reviewed by Geoff Garen.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_div):
(JSC::JIT::compileBinaryArithOp):
* jit/JITArithmetic32_64.cpp: Added.
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emit_op_jnless):
(JSC::JIT::emitSlow_op_jnless):
(JSC::JIT::emit_op_jless):
(JSC::JIT::emitSlow_op_jless):
(JSC::JIT::emit_op_jnlesseq):
(JSC::JIT::emitSlow_op_jnlesseq):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitSlow_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emitSlow_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emitSlow_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emitSlow_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
(JSC::JIT::emitSlow_op_pre_dec):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitAdd32Constant):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSub32Constant):
(JSC::JIT::emitSlow_op_sub):
(JSC::JIT::emitBinaryDoubleOp):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 21:30:11 +0000 (21:30 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Skip fast/images/svg-nested.html which crashes chromium.py
        https://bugs.webkit.org/show_bug.cgi?id=38351

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Thu, 29 Apr 2010 20:52:33 +0000 (20:52 +0000)]
2010-04-29  Yaar Schnitman  <yaar@chromium.org>

       Not reviewed.

        Adding missing expectations, skipping tests
        https://bugs.webkit.org/show_bug.cgi?id=38343

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-mac/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.
        * platform/chromium-win/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/chromium-win/fast/text/international/bold-bengali-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Darin Adler.
ap@apple.com [Thu, 29 Apr 2010 20:43:09 +0000 (20:43 +0000)]
    Rubber-stamped by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38296
        Import Sputnik JavaScript test suite

        * fast/js/sputnik: Added.
        * fast/js/sputnik/AUTHORS: Added.
        * fast/js/sputnik/Conformance: Added.
        * fast/js/sputnik/Implementation_Diagnostics: Added.
        * fast/js/sputnik/LICENSE: Added.
        * fast/js/sputnik/Regression: Added.
        * fast/js/sputnik/Unicode: Added.

        * fast/js/script-tests/sputnik-S15.4.4.12_A3_T3.js: Deleted.
        * fast/js/sputnik-S15.4.4.12_A3_T3-expected.txt: Deleted.
        * fast/js/sputnik-S15.4.4.12_A3_T3.html: Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38277
weinig@apple.com [Thu, 29 Apr 2010 20:16:46 +0000 (20:16 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38277
MiniBrowser: -[WebCoreFlippedView currentEditor]: unrecognized selector

Reviewed by Anders Carlsson.

* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView currentEditor]): Added currentEditor nil implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 20:02:13 +0000 (20:02 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CodeGeneratorJS.pm should be consistent about castedThis versus castedThisObj
        https://bugs.webkit.org/show_bug.cgi?id=38338

        Currently CodeGeneratorJS.pm uses castThis for methods and
        castedThisObj for attributes.  This inconsistency makes it difficult to
        factor common code genereration code into methods shared by both kinds
        of bindings.  This match aligns the names so that a future patch (e.g.,
        in https://bugs.webkit.org/show_bug.cgi?id=38313) can reduce copy/paste
        code.

        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::setJSTestObjIntAttr):
        (WebCore::setJSTestObjLongLongAttr):
        (WebCore::setJSTestObjUnsignedLongLongAttr):
        (WebCore::setJSTestObjStringAttr):
        (WebCore::setJSTestObjTestObjAttr):
        (WebCore::setJSTestObjAttrWithException):
        (WebCore::setJSTestObjAttrWithSetterException):
        (WebCore::setJSTestObjAttrWithGetterException):
        (WebCore::jsTestObjPrototypeFunctionVoidMethod):
        (WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionIntMethod):
        (WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionObjMethod):
        (WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionMethodWithException):
        (WebCore::jsTestObjPrototypeFunctionCustomMethod):
        (WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        (WebCore::jsTestObjPrototypeFunctionAddEventListener):
        (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
        (WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
        (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
        (WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
        (WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Gustavo Noronha Silva <gustavo.noronhaollabora.co.uk>
kov@webkit.org [Thu, 29 Apr 2010 19:39:51 +0000 (19:39 +0000)]
2010-04-29  Gustavo Noronha Silva  <gustavo.noronhaollabora.co.uk>

        Reviewed by Xan Lopez.

        [GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR
        https://bugs.webkit.org/show_bug.cgi?id=36963

        Use the default cursor instead of hard-coding left pointer.

        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):
        (WebCore::pointerCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 19:14:55 +0000 (19:14 +0000)]
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Consider implementing addOriginAccessWhitelistEntry method
        http://trac.webkit.org/changeset/57537 introduced a new method
        to manage whitelisting of origins.
        Expose this method in Chromium's bridge.
        https://bugs.webkit.org/show_bug.cgi?id=37578

        * public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
        * src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 29 Apr 2010 18:30:06 +0000 (18:30 +0000)]
2010-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        webkit-patch doesn't work if a git repo is tracking multiple svn repos
        https://bugs.webkit.org/show_bug.cgi?id=38290

        Getting the tests to pass required getting our SVN repo to more closely
        match the real svn.webkit.org repo by having a trunk directory.
        That involved adding an extra commit at the beginning and thus changing
        all the commit numbers in the tests.

        * Scripts/webkitpy/common/checkout/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 18:12:42 +0000 (18:12 +0000)]
2010-04-29  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: If Timeline panel is in recording mode and is not visible and has received
        new events then these events do not appear in the panel when the panel becomes visible.
        Timeline popup may appear in the upper left window corner when you switch to another panel.
        https://bugs.webkit.org/show_bug.cgi?id=38322

        * inspector/front-end/Popover.js:
        (WebInspector.PopoverHelper.prototype._mouseMove.doHide):
        (WebInspector.PopoverHelper.prototype._mouseMove):
        (WebInspector.PopoverHelper.prototype.hidePopup):
        (WebInspector.PopoverHelper.prototype._hidePopup):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype.show):
        (WebInspector.TimelinePanel.prototype._scheduleRefresh):
        (WebInspector.TimelinePanel.prototype._refresh):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 29 Apr 2010 18:06:34 +0000 (18:06 +0000)]
2010-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Reinstate qt_drt_ symbol exports as of QtWebKit 4.6 release
        https://bugs.webkit.org/show_bug.cgi?id=38304

        This change provides backward compatibility with some previously
        exported private symbols. No new functionality introduced.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (qt_resumeActiveDOMObjects):
        (qt_suspendActiveDOMObjects):
        (qt_drt_clearFrameName):
        (qt_drt_garbageCollector_collect):
        (qt_drt_garbageCollector_collectOnAlternateThread):
        (qt_drt_javaScriptObjectsCount):
        (qt_drt_numberOfActiveAnimations):
        (qt_drt_overwritePluginDirectories):
        (qt_drt_pauseAnimation):
        (qt_drt_pauseTransitionOfProperty):
        (qt_drt_resetOriginAccessWhiteLists):
        (qt_drt_run):
        (qt_drt_setJavaScriptProfilingEnabled):
        (qt_drt_whiteListAccessFromOrigin):
        (qt_webpage_groupName):
        (qt_webpage_setGroupName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 18:02:47 +0000 (18:02 +0000)]
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Let's cache nodelists instead of DynamicNodeList::Caches
        https://bugs.webkit.org/show_bug.cgi?id=33696

        * fast/dom/Element/node-list-identity-expected.txt: Added to verify that node lists are indeed cached
        * fast/dom/Element/node-list-identity.html: Added to verify that node lists are indeed cached
        * fast/dom/gc-9-expected.txt: Updated to follow changed semantics of caching
        * fast/dom/gc-9.html: Updated to follow changed semantics of caching
2010-04-29  Anton Muhin  <antonm@chromium.org>

        Reviewed by Darin Adler.

        Let's cache nodelists instead of DynamicNodeList::Caches
        https://bugs.webkit.org/show_bug.cgi?id=33696

        Test: fast/dom/Element/node-list-identity.html

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::JSNode::markChildren): Mark all cached node lists as well
        * dom/ClassNodeList.cpp:
        (WebCore::ClassNodeList::ClassNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::ClassNodeList::~ClassNodeList): Remove from the cache
        * dom/ClassNodeList.h: Added a field with original class names to be used as a key for removal from the cache
        (WebCore::ClassNodeList::create): Don't need DynamicNodeList::Caches argument any more
        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::NameNodeList::~NameNodeList): Remove from the cache
        * dom/NameNodeList.h:
        (WebCore::NameNodeList::create): Don't need DynamicNodeList::Caches argument any more
        * dom/Node.cpp:
        (WebCore::Node::removeCachedClassNodeList): Remove ClassNodeList from the cache
        (WebCore::Node::removeCachedNameNodeList): Remove NameNodeList from the cache
        (WebCore::Node::removeCachedTagNodeList): Remove TagNodeList from the cache
        (WebCore::Node::getElementsByTagNameNS): Switch to caching node lists themselves, not the data
        (WebCore::Node::getElementsByName): Switch to caching node lists themselves, not the data
        (WebCore::Node::getElementsByClassName): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::invalidateCaches): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes): Switch to caching node lists themselves, not the data
        (WebCore::NodeListsNodeData::isEmpty): Switch to caching node lists themselves, not the data
        (WebCore::markNodeLists): Helper to mark all the node lists in the cache
        (WebCore::Node::markCachedNodeListsSlow): Mark all the cached node lists if any could be present
        * dom/Node.h:
        (WebCore::Node::markCachedNodeLists): Fast-path marking of cached node lists---bails out if there is no rare data
        * dom/NodeRareData.h: Changed type of caches to hold raw pointers to node lists, not RefPtr's to data
        * dom/TagNodeList.cpp:
        (WebCore::TagNodeList::TagNodeList): Don't need DynamicNodeList::Caches argument any more
        (WebCore::TagNodeList::~TagNodeList): Remove from the cache
        * dom/TagNodeList.h:
        (WebCore::TagNodeList::create): Don't need DynamicNodeList::Caches argument any more

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 17:45:03 +0000 (17:45 +0000)]
2010-04-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        [Chromium] Update ScriptProfileNode to retrieve execution time in milliseconds.

        https://bugs.webkit.org/show_bug.cgi?id=38330

        * bindings/v8/ScriptProfileNode.cpp:
        (WebCore::ScriptProfileNode::totalTime):
        (WebCore::ScriptProfileNode::selfTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Marcus Bulach <bulach@chromium.org>
jorlow@chromium.org [Thu, 29 Apr 2010 17:41:56 +0000 (17:41 +0000)]
2010-04-29  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Rebaseline chromium SVG tests
        This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=37986
        https://bugs.webkit.org/show_bug.cgi?id=38106

        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/chromium-linux/svg/batik/paints/patternRegions-expected.txt:
        * platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/chromium-linux/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
        * platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/chromium-mac/fast/images: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-mac/traversal: Added.
        * platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added.
        * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * platform/chromium-win/svg/batik/filters/feTile-expected.txt:
        * platform/chromium-win/svg/batik/masking/maskRegions-expected.txt:
        * platform/chromium-win/svg/batik/paints/gradientLimit-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternRegionA-expected.txt:
        * platform/chromium-win/svg/batik/paints/patternRegions-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect2-expected.txt:
        * platform/chromium-win/svg/batik/text/textEffect3-expected.txt:
        * platform/chromium-win/svg/batik/text/textProperties-expected.txt:
        * platform/chromium-win/svg/carto.net/colourpicker-expected.txt:
        * platform/chromium-win/svg/carto.net/tabgroup-expected.txt: Added.
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/chromium-win/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/chromium-win/svg/custom/fill-fallback-expected.txt:
        * platform/chromium-win/svg/custom/gradient-cycle-detection-expected.txt:
        * platform/chromium-win/svg/custom/gradient-deep-referencing-expected.txt:
        * platform/chromium-win/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
        * platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/chromium-win/svg/custom/invalid-css-expected.txt:
        * platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-gradient-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-late-pattern-creation-expected.txt:
        * platform/chromium-win/svg/custom/js-update-gradient-expected.checksum:
        * platform/chromium-win/svg/custom/js-update-gradient-expected.png:
        * platform/chromium-win/svg/custom/pattern-cycle-detection-expected.txt:
        * platform/chromium-win/svg/custom/pattern-deep-referencing-expected.txt:
        * platform/chromium-win/svg/custom/pattern-rotate-expected.txt:
        * platform/chromium-win/svg/custom/pattern-with-transformation-expected.txt:
        * platform/chromium-win/svg/custom/stroke-fallback-expected.txt:
        * platform/chromium-win/svg/custom/stroked-pattern-expected.txt:
        * platform/chromium-win/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/chromium-win/svg/hixie/error/003-expected.txt:
        * platform/chromium-win/svg/hixie/perf/005-expected.txt:
        * platform/chromium-win/svg/hixie/perf/006-expected.txt:
        * platform/chromium-win/svg/text/selection-background-color-expected.txt:
        * platform/chromium-win/svg/text/selection-styles-expected.txt:
        * platform/chromium-win/svg/text/text-gradient-positioning-expected.txt:
        * platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
        * platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
        * platform/chromium-win/traversal: Added.
        * platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 17:35:12 +0000 (17:35 +0000)]
2010-04-29  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Get rid of forceLayout() on FrameView
        https://bugs.webkit.org/show_bug.cgi?id=38199

        The function FrameView::forceLayout() is missleading
        because it does not actually force the layout, the call is
        equivalent to layout().

        This patch replace the call to forceLayout() by layout() in Qt
        to avoid the misunderstanding/improve readability.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::dynamicPropertyChangeEvent):
        (QWebPage::setPreferredContentsSize):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::setMediaType):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::forceLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 29 Apr 2010 16:43:50 +0000 (16:43 +0000)]
2010-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58498.
        http://trac.webkit.org/changeset/58498
        https://bugs.webkit.org/show_bug.cgi?id=38332

        "Broke a bunch of tests on Chromium canaries" (Requested by
        dglazkov on #webkit).

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, expectations tweak.
dglazkov@chromium.org [Thu, 29 Apr 2010 16:23:57 +0000 (16:23 +0000)]
Unreviewed, expectations tweak.

Update stale expectations I accidentally checked in in http://trac.webkit.org/changeset/58520
https://bugs.webkit.org/show_bug.cgi?id=9756

* fast/forms/implicit-submission-expected.txt: Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA form without a submit button unexpectedly performs its action when Return is pressed
dglazkov@chromium.org [Thu, 29 Apr 2010 15:53:34 +0000 (15:53 +0000)]
A form without a submit button unexpectedly performs its action when Return is pressed
https://bugs.webkit.org/show_bug.cgi?id=9756

Reviewed by Darin Adler.

WebCore:

Implemented implicit form submission algorithm as defined in HTML5 spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission,
falling back to match IE's behavior in the edge cases.

The underlying rules are:

* If the form has no enabled submit buttons, submit if Enter/Return is pressed on the only single-line text field.

* Otherwise, submit form using first enabled submit button if Enter/Return is pressed on a field
  that's not a textarea or a select.

Test: fast/forms/implicit-submission.html

* dom/SelectElement.cpp:
(WebCore::SelectElement::menuListDefaultEventHandler): Ripped out implicit submission for select elements.
(WebCore::SelectElement::listBoxDefaultEventHandler): Ditto.
(WebCore::SelectElement::defaultEventHandler): Ditto.
* dom/SelectElement.h: Ditto.
(WebCore::HTMLFormElement::submitImplicitly): Renamed submitClick to submitImplicitly to better match HTML5 spec
    language, changed the logic to match the rules above.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler): Reamed clickDefaultButton to implicitSubmission to better match
    HTML5 spec language, made radio element to trigger implicit submission.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Removed passing of form() as parameter, because it's no longer
    necessary.

LayoutTests:

A comprehensive test for various edge cases involving implicit form submission.

* fast/forms/implicit-submission-expected.txt: Added.
* fast/forms/implicit-submission.html: Added.
* fast/forms/check-box-enter-key-expected.txt: Removed because it's now part of implicit-submission.html.
* fast/forms/check-box-enter-key.html: Ditto.
* fast/forms/select-enter-key-expected.txt: Ditto.
* fast/forms/select-enter-key.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Paweł Hajdan, Jr. <phajdan.jr@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 15:46:50 +0000 (15:46 +0000)]
2010-04-29  Paweł Hajdan, Jr.  <phajdan.jr@chromium.org>

        Reviewed by Jeremy Orlow.

        Fix building with libpng-1.4.
        https://bugs.webkit.org/show_bug.cgi?id=33287

        No new tests (no behavior change).

        Original patch by John Bowler <jbowler@acm.org>

        * platform/image-encoders/skia/PNGImageEncoder.cpp:
        (WebCore::PNGImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 29 Apr 2010 15:26:22 +0000 (15:26 +0000)]
2010-04-29  Adam Langley  <agl@chromium.org>

        Unreviewed, DEPS roll.

        WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
        r45932.

        * DEPS:
          Use Chromium r45932.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 29 Apr 2010 14:57:55 +0000 (14:57 +0000)]
2010-04-29  Adam Langley  <agl@chromium.org>

        Reviewed by David Levin.

        This patch adds support for WOFF in Chromium. Since Chromium
        already transcodes all OpenType files for security reasons we
        are adding WOFF support into the transcoder.

        https://bugs.webkit.org/show_bug.cgi?id=38217

        * css/CSSFontFaceSrcValue.cpp:
        (WebCore::CSSFontFaceSrcValue::isSupportedFormat):
          Recognise "woff" as a font-face format value (guarded by
          ENABLE(OPENTYPE_SANITIZER) at this point)
        * platform/graphics/opentype/OpenTypeSanitizer.cpp:
        (WebCore::OpenTypeSanitizer::sanitize):
          Change so that the transcoded font can be larger than the original.
          (WOFF files are compressed, so the transcoded TTF is typically
          larger.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Alex Milowski <alex@milowski.com>
eric@webkit.org [Thu, 29 Apr 2010 14:26:20 +0000 (14:26 +0000)]
2010-04-29  Alex Milowski  <alex@milowski.com>

        Reviewed by Kenneth Rohde Christiansen.

        Updates to the Qt build to enable building MathML support.

        * WebCore.pri:
        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd sqrt() instruction support for ARM assembler (using VFP)
zherczeg@webkit.org [Thu, 29 Apr 2010 14:08:44 +0000 (14:08 +0000)]
Add sqrt() instruction support for ARM assembler (using VFP)
https://bugs.webkit.org/show_bug.cgi?id=38312

Reviewed by Oliver Hunt

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::):
(JSC::ARMAssembler::fsqrtd_r):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::sqrtDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:44 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_element_by_id;

        * tests/testdomdocument.c:
        (test_dom_document_get_element_by_id):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:32 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_elements_by_class_name.

        * tests/testdomdocument.c:
        (test_dom_document_get_elements_by_class_name):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:19 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_elements_by_tag_name.

        * tests/testdomdocument.c:
        (test_dom_document_get_elements_by_tag_name):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:50:07 +0000 (13:50 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Add WebKitDOMDocument tests to the build.

        * GNUmakefile.am:

WebKit/gtk:

2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Move WebKitDOMDocument unit tests to their own file.

        * tests/testdomdocument.c: Added.
        (finish_loading):
        (dom_document_fixture_setup):
        (dom_document_fixture_teardown):
        (test_dom_document_title):
        (main):
        * tests/testwebview.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:49:52 +0000 (13:49 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Do not generate unneeded boilerplate in {get,set}_property methods
        when there are no properties to generate code for. This gets rid
        of lots of compiler warnings.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 29 Apr 2010 13:48:53 +0000 (13:48 +0000)]
2010-04-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Include <webkit/webkitdom.h> in the main webkit.h header.

        * webkit/webkit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Loading of large page can take up to 10 seconds
ossy@webkit.org [Thu, 29 Apr 2010 13:37:38 +0000 (13:37 +0000)]
[Qt] Loading of large page can take up to 10 seconds
https://bugs.webkit.org/show_bug.cgi?id=31719

Rubber-stamped by Simon Hausmann.

Followup patch. Update expected files because of minor differences.
(size of whitespaces, place of linebreaks)

* platform/qt/css1/basic/inheritance-expected.txt:
* platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
* platform/qt/css1/box_properties/float_margin-expected.txt:
* platform/qt/css1/color_and_background/background_attachment-expected.txt:
* platform/qt/css1/color_and_background/background_repeat-expected.txt:
* platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/qt/css1/font_properties/font-expected.txt:
* platform/qt/css1/font_properties/font_style-expected.txt:
* platform/qt/css1/formatting_model/inline_elements-expected.txt:
* platform/qt/css1/text_properties/line_height-expected.txt:
* platform/qt/css1/text_properties/text_decoration-expected.txt:
* platform/qt/css1/text_properties/text_indent-expected.txt:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css2.1/t1202-counter-01-b-expected.txt:
* platform/qt/css2.1/t1202-counter-02-b-expected.txt:
* platform/qt/css2.1/t1202-counter-03-b-expected.txt:
* platform/qt/css2.1/t1202-counter-04-b-expected.txt:
* platform/qt/css2.1/t1202-counters-01-b-expected.txt:
* platform/qt/css2.1/t1202-counters-02-b-expected.txt:
* platform/qt/css2.1/t1202-counters-03-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/qt/editing/selection/select-text-overflow-ellipsis-expected.txt:
* platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
* platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/size/zero-expected.txt:
* platform/qt/fast/css/font-face-opentype-expected.txt:
* platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt:
* platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
* platform/qt/fast/text/fake-italic-expected.txt:
* platform/qt/fast/text/international/khmer-selection-expected.txt:
* platform/qt/http/tests/local/file-url-sent-as-referer-expected.txt:
* platform/qt/svg/filters/feColorMatrix-values-expected.txt:
* platform/qt/svg/text/foreignObject-text-clipping-bug-expected.txt:
* platform/qt/svg/text/selection-background-color-expected.txt:
* platform/qt/svg/text/selection-doubleclick-expected.txt:
* platform/qt/svg/text/selection-styles-expected.txt:
* platform/qt/svg/text/selection-tripleclick-expected.txt:
* platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Speed up text layouting
ossy@webkit.org [Thu, 29 Apr 2010 13:36:00 +0000 (13:36 +0000)]
[Qt] Speed up text layouting
https://bugs.webkit.org/show_bug.cgi?id=31719

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2010-04-29
Reviewed by Kenneth Rohde Christiansen.

Use QFontMetrics::width() for the text width calculation instead
of QTextLayout. This avoids expensive bearing calculations and the
line breaking code.

* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::floatWidthForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 29 Apr 2010 13:11:26 +0000 (13:11 +0000)]
2010-04-29  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Export g_stackBase with JS_EXPORTDATA
        https://bugs.webkit.org/show_bug.cgi?id=37437

        Declare g_stackBase with JS_EXPORTDATA as it is imported from JavaScriptCore.

        * platform/wince/SharedTimerWince.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Skip editing/pasteboard/drag-drop-input-textarea.html on GTK and Qt.
tkent@chromium.org [Thu, 29 Apr 2010 12:05:32 +0000 (12:05 +0000)]
Unreviewed.  Skip editing/pasteboard/drag-drop-input-textarea.html on GTK and Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:46:33 +0000 (11:46 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Remove custom bindings for PopStateEvent.initPopStateEvent
        https://bugs.webkit.org/show_bug.cgi?id=38311

        Our code generation of SerializedScriptValue was slightly buggy, but
        it's easy to fix.  Notice that the conversion to an atomic string is
        handled by the C++ type system and doesn't require logic in the code
        generator.

        * bindings/js/JSPopStateEventCustom.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        (webkit_dom_test_obj_serialized_value):
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::):
        (WebCore::jsTestObjPrototypeFunctionSerializedValue):
        * bindings/scripts/test/JS/JSTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.h:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj serializedValue:]):
        * bindings/scripts/test/TestObj.idl:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::serializedValueCallback):
        (WebCore::ConfigureV8TestObjTemplate):
        * bindings/v8/custom/V8PopStateEventCustom.cpp:
        * dom/PopStateEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:29:07 +0000 (11:29 +0000)]
2010-04-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests can deadlock with Chromium's TestShell
        https://bugs.webkit.org/show_bug.cgi?id=38298

        Fix _write_command_and_read_line to never send unicode() to
        test_shell, instead to always encode as utf-8.  This was causing
        random hangs because if test_shell ever encounters a \0 in the
        stream it can deadlock with NRWT.

        There is still a deadlock bug to fix in NRWT/test_shell design, however
        this fix should make the deadlock occur less often.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 29 Apr 2010 11:23:12 +0000 (11:23 +0000)]
2010-04-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that selection drag-and-drop doesn't work for input/textarea.
        https://bugs.webkit.org/show_bug.cgi?id=38175

        * editing/pasteboard/drag-drop-input-textarea-expected.txt: Added.
        * editing/pasteboard/drag-drop-input-textarea.html: Added.
2010-04-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Fix a bug that selection drag-and-drop doesn't work for input/textarea.
        https://bugs.webkit.org/show_bug.cgi?id=38175

        The code supposed the selected region was in the destination text
        field. It is not true in a case of drag-and-drop.

        Test: editing/pasteboard/drag-drop-input-textarea.html

        * dom/InputElement.cpp:
        (WebCore::InputElement::handleBeforeTextInsertedEvent):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::handleBeforeTextInsertedEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Adam Barth <abarth@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 11:18:22 +0000 (11:18 +0000)]
2010-04-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Remove custom bindings for NodeFilter.acceptNode
        https://bugs.webkit.org/show_bug.cgi?id=38309

        This "custom" code was just an instance of the CallWith=ScriptState
        pattern.  Also, it looks like V8 just had a garbage implemenation that
        did nothing.

        * WebCore.gypi:
        * bindings/js/JSNodeFilterCustom.cpp:
        * bindings/v8/custom/V8NodeFilterCustom.cpp: Removed.
        * dom/NodeFilter.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 11:05:11 +0000 (11:05 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] QtWebkit doesn't link with 3D canvas
        https://bugs.webkit.org/show_bug.cgi?id=38299

        Added implementation for GraphicsContext3D::isGLES2Compliant, which returns the correct value based on a Qt #define.

        No new tests: build fix

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 11:02:36 +0000 (11:02 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Maciej Stachowiak.

        Add missing pixel test results for several tests on Mac. Now doesn't create any new files anymore, when running run-webkit-tests -p.

        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.checksum: Added.
        * platform/mac/fast/block/positioning/absolute-positioning-no-scrollbar-expected.png: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.checksum: Added.
        * platform/mac/fast/css/css3-space-in-nth-and-lang-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-simple-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/frameset-flattening-subframesets-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.png: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.checksum: Added.
        * platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.png: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.checksum: Added.
        * platform/mac/fast/media/media-query-invalid-value-expected.png: Added.
        * platform/mac/fast/runin/generated2-expected.checksum: Added.
        * platform/mac/fast/runin/generated2-expected.png: Added.
        * platform/mac/fast/runin/generated3-expected.checksum: Added.
        * platform/mac/fast/runin/generated3-expected.png: Added.
        * platform/mac/fast/runin/generated4-expected.checksum: Added.
        * platform/mac/fast/runin/generated4-expected.png: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.checksum: Added.
        * platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:55:22 +0000 (10:55 +0000)]
2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Darin Fisher.

        Include WindowFeatures in call to WebViewClient::createView.

        https://bugs.webkit.org/show_bug.cgi?id=38301

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unnecessary call to FrameView::forceLayout() in setViewportSize()
hausmann@webkit.org [Thu, 29 Apr 2010 10:42:59 +0000 (10:42 +0000)]
Remove unnecessary call to FrameView::forceLayout() in setViewportSize()
This prevents a double relayout on resize.

Patch by Andreas Kling <andreas.kling@nokia.com> on 2010-04-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=38179

Thanks to Nate Whetsell <nathan.whetsell@gmail.com> for spotting this.

* Api/qwebpage.cpp:
(QWebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 10:35:11 +0000 (10:35 +0000)]
2010-04-29  Garret Kelly  <gdk@chromium.org>

        Reviewed by Darin Fisher.

        Expose the RuntimeFeature for touch events through the
        WebRuntimeFeatures mechanism.
        https://bugs.webkit.org/show_bug.cgi?id=37486

        * public/WebRuntimeFeatures.h:
        * src/WebRuntimeFeatures.cpp:
        (WebKit::WebRuntimeFeatures::enableTouch):
        (WebKit::WebRuntimeFeatures::isTouchEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRefactored svn-apply and svn-unapply to use the new
cjerdonek@webkit.org [Thu, 29 Apr 2010 10:33:18 +0000 (10:33 +0000)]
Refactored svn-apply and svn-unapply to use the new
parsePatch() subroutine.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=34033

* Scripts/VCSUtils.pm:
  - Consolidated %diffHash documentation.
  - Added prepareParsedPatch().

* Scripts/svn-apply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/svn-unapply:
  - Replaced main while loop with calls to parsePatch() and
    prepareParsedPatch().

* Scripts/test-webkitperl:
  - Changed to render relative test paths rather than absolute
    test paths.

* Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
  - Added unit tests for prepareParsedPatch().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:25:16 +0000 (10:25 +0000)]
2010-04-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Refactor qtscriptglobal.h
        https://bugs.webkit.org/show_bug.cgi?id=37953

        Use the same pattern in qtscriptglobal.h as in
        qwebkitglobal.h without checking for specific OSs.

        * qt/api/qtscriptglobal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
hausmann@webkit.org [Thu, 29 Apr 2010 10:20:29 +0000 (10:20 +0000)]
[Qt] REGRESSION(r57638): tst_qwebframe::objectDeleted() fails
https://bugs.webkit.org/show_bug.cgi?id=38316

Reviewed by Tor Arne Vestbø.

Accessing properties of a deleted objects doesn't throw an exception
anymore.

Continue to expose the QObject class wrapper for objects that
previously existed but don't exist anymore. QtClass is safe to
use with a deleted QObject.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getClass): Return null only if m_class
doesn't exist yet and there's no m_object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 10:04:47 +0000 (10:04 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        Reverse animations don't work in some use cases
        https://bugs.webkit.org/show_bug.cgi?id=38075

        This was due to a code path special-casing reverse animations, that became obselete when we aligned our animation code
        with the CA implementation. That special case code path is now a bug - and this patch removes it.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now runs the reverse
        animation correctly.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::applyFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 09:42:46 +0000 (09:42 +0000)]
Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt: fast/media/media-query-invalid-value.html should be MISSING, not IMAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Jan Hanssen <jhanssen@codeaurora.org>
eric@webkit.org [Thu, 29 Apr 2010 09:33:42 +0000 (09:33 +0000)]
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        Test whether HTMLOptionElement::ownerSelectElement() is considering the keygen element.
        https://bugs.webkit.org/show_bug.cgi?id=26016

        * fast/dom/HTMLKeygenElement/keygen-option-select-expected.txt: Added.
        * fast/dom/HTMLKeygenElement/keygen-option-select.html: Added.
2010-04-29  Jan Hanssen  <jhanssen@codeaurora.org>

        Reviewed by Adam Barth.

        HTMLOptionElement::ownerSelectElement() needs to consider keygen elements
        https://bugs.webkit.org/show_bug.cgi?id=26016

        Patch written by Grace Kloba <klobag@gmail.com>, test fixed by me.

        Test: fast/dom/HTMLKeygenElement/keygen-option-select.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::ownerSelectElement):
        Make HTMLOptionElement::ownerSelectElement() consider the keygen element in addition to the current select element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 29 Apr 2010 09:07:01 +0000 (09:07 +0000)]
2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
        https://bugs.webkit.org/show_bug.cgi?id=38307

        balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
        We now properly ignored the subtree. s/def/defs/ and the testcase works again.

        fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
        Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.

        Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
        I can now run those tests with --tolerance 0 without a problem.

        * fast/backgrounds/resources/balloon.svg: s/def/defs/
        * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
        * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
        * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, test expectations update.
ukai@chromium.org [Thu, 29 Apr 2010 08:57:36 +0000 (08:57 +0000)]
Unreviewed, test expectations update.

r58479 add fast/media/media-query-invalid-value.html, but it misses
image expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Gustavo Sverzut Barbieri <barbieri@profusion.mobi>
eric@webkit.org [Thu, 29 Apr 2010 08:46:29 +0000 (08:46 +0000)]
2010-04-29  Gustavo Sverzut Barbieri  <barbieri@profusion.mobi>

        Reviewed by Eric Seidel.

        Add EFL-specific code to Widget.h and move the empty
        frameRectsChanged() definition to Widget.cpp, since the EFL port
        needs to override that.
        http://webkit.org/b/36317

        No new tests required.

        * WebCore.base.exp:
        * platform/Widget.cpp:
        (WebCore::Widget::frameRectsChanged):
        * platform/Widget.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 29 Apr 2010 08:44:12 +0000 (08:44 +0000)]
2010-04-29  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        wrong filename: LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt
        https://bugs.webkit.org/show_bug.cgi?id=38310

        * platform/win/fast/text/international/bold-bengali-expected.txt: Renamed from LayoutTests/platform/win/fast/text/international/bold-bengali-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
hausmann@webkit.org [Thu, 29 Apr 2010 08:41:53 +0000 (08:41 +0000)]
[Qt] REGRESSION(r57982): tst_qwebpage::showModalDialog() crashes
https://bugs.webkit.org/show_bug.cgi?id=38314

Reviewed by Tor Arne Vestbø.

Make sure that there's always a main frame when returning from createWindow()
to the caller in WebCore.

* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Thu, 29 Apr 2010 08:25:56 +0000 (08:25 +0000)]
2010-04-29  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant()
        https://bugs.webkit.org/show_bug.cgi?id=38216

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 08:14:50 +0000 (08:14 +0000)]
2010-04-29  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        Small cleanup.

        QScriptValuePrivate constructor shouldn't take QScriptEngine pointer
        as a parameter, because it breaks a private / public separation rule.
        QScriptEnginePrivate::get(QScriptEngine*) should return
        a QScriptEnginePrivate pointer instead of a QScriptEnginePtr, it simplifies
        implementation.

        [Qt] QScriptValuePrivate class needs some cleanup.
        https://bugs.webkit.org/show_bug.cgi?id=37729

        * qt/api/qscriptengine_p.h:
        (QScriptEnginePrivate::get):
        * qt/api/qscriptvalue.cpp:
        (QScriptValue::QScriptValue):
        * qt/api/qscriptvalue_p.h:
        (QScriptValuePrivate::QScriptValuePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 29 Apr 2010 07:52:37 +0000 (07:52 +0000)]
2010-04-29  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Simon Hausmann.

        [WINCE] Export g_stackBase with JS_EXPORTDATA
        https://bugs.webkit.org/show_bug.cgi?id=37437

        Export g_stackBase with JS_EXPORTDATA as it is used by SharedTimerWince.cpp.

        * runtime/Collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Thu, 29 Apr 2010 07:42:12 +0000 (07:42 +0000)]
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::texImage2D): Add extractImageData; add a common entry point for texImage2D with image input.
        (WebCore::WebGLRenderingContext::texImage2DBase): Add this function as the common entry point for texImage2D.
        (WebCore::WebGLRenderingContext::texSubImage2D): Add extractImageData; add a common entry point for texSubImage2D with image input.
        (WebCore::WebGLRenderingContext::texSubImage2DBase): Add this function as the common entry point for texSubImage2D.
        * html/canvas/WebGLRenderingContext.h: Add tex*Image{Base/Image} function declaration.
        * platform/graphics/GraphicsContext3D.h: Remove tex*Image declaration with Image input.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Remove tex*Image implementation with Image input.
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
2010-04-29  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=38235

        * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 29 Apr 2010 07:15:15 +0000 (07:15 +0000)]
2010-04-29  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended.
        https://bugs.webkit.org/show_bug.cgi?id=38076

        This was due to the cude in the removeAnimations functions, which called deleteLater() without stopping the
        animation synchronously. The delay between the call to that function and the actual call to the animation's destructor
        is when the flicker occured. We fix this by calling stop() synchronously, and making sure that the value is reverted
        upon stop (updateState) and not upon the object's destruction.

        http://staff.washington.edu/fmf/2009/03/25/iphone-3d-css-transformations/ now doesn't flicker when
        the animation is toggled frequently.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::TransformAnimationQt::~TransformAnimationQt):
        (WebCore::TransformAnimationQt::applyFrame):
        (WebCore::TransformAnimationQt::updateState):
        (WebCore::OpacityAnimationQt::~OpacityAnimationQt):
        (WebCore::OpacityAnimationQt::updateState):
        (WebCore::GraphicsLayerQt::removeAnimationsForProperty):
        (WebCore::GraphicsLayerQt::removeAnimationsForKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 29 Apr 2010 07:05:32 +0000 (07:05 +0000)]
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        * fast/media/media-query-invalid-value-expected.txt: Added.
        * fast/media/media-query-invalid-value.html: Added.
2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Simon Fraser.

        Media queries empty values
        https://bugs.webkit.org/show_bug.cgi?id=38116

        Adding isValid() method to MediaQueryExp to make it possible to differentiate
        between queries with empty values and queries with invalid values.

        Test: fast/media/media-query-invalid-value.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp):
        * css/MediaQueryExp.h:
        (WebCore::MediaQueryExp::isValid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Thu, 29 Apr 2010 06:19:24 +0000 (06:19 +0000)]
2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Added to VCSUtils's parseDiffHeader() support for binary patches.

        https://bugs.webkit.org/show_bug.cgi?id=38094

        The parseDiffHeader() function is part of new patch-parsing code
        for svn-apply and svn-unapply that will go live in a subsequent
        revision.

        * Scripts/VCSUtils.pm:
          - Added logic to parseDiffHeader() to recognize the ending of
            the header portion of a binary diff.

        * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
          - Added unit test cases for SVN and Git binary diffs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Thu, 29 Apr 2010 06:10:03 +0000 (06:10 +0000)]
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Allow editing script resources when resource tracking is enabled.

        https://bugs.webkit.org/show_bug.cgi?id=38269

        * inspector/front-end/ScriptView.js:
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.canEditScripts):
        (WebInspector.ScriptsPanel.prototype.editScriptSource):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.get textModel):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView):
        (WebInspector.SourceView.prototype._addBreakpoint):
        (WebInspector.SourceView.prototype._editLine):
        (WebInspector.SourceView.prototype._editLineComplete):
        (WebInspector.SourceView.prototype._sourceIDForLine):
2010-04-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Allow editing script resources when resource tracking is enabled.

        http://bugs.webkit.org/show_bug.cgi?id=38269

        * src/js/DebuggerAgent.js:
        * src/js/InspectorControllerImpl.js:
        (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
        (.devtools.InspectorBackendImpl.prototype.editScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-25 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 29 Apr 2010 04:45:17 +0000 (04:45 +0000)]
2010-04-25  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Darin Adler.

        Clicking a scrollbar blurs the currently focused element
        https://bugs.webkit.org/show_bug.cgi?id=16809

        WebKit ports that do not use native (platform) widgets for rendering the scrollbars
        are currently mismatching a common behaviour of other browser vendors (including
        Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
        WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
        instance, can observe the opposite behaviour.

        Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
        If that is the case, it bails out and do not change focus behavior at all.

        It is important to note that the given way this is implemented by this patch, non-frame
        scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
        in the same way as it works currently.

        Tests: scrollbars/scrollbar-click-does-not-blur-content.html
               scrollbars/scrollbar-iframe-click-does-not-blur-content.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::dispatchMouseEve

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo an unordered compare so that we don't treat NaN incorrectly.
oliver@apple.com [Thu, 29 Apr 2010 04:34:50 +0000 (04:34 +0000)]
Do an unordered compare so that we don't treat NaN incorrectly.

RS=Gavin Barraclough

* jit/ThunkGenerators.cpp:
(JSC::powThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix test failures seen on the Leopard build bot after r58467
mitz@apple.com [Thu, 29 Apr 2010 04:23:52 +0000 (04:23 +0000)]
Try to fix test failures seen on the Leopard build bot after r58467

Rubber-stamped by Maciej Stachowiak.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::platformGlyphInit): Initialize m_zeroWidthSpaceGlyph before
calling widthForGlyph(), as the latter uses the former.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 04:20:36 +0000 (04:20 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Document that subprocess.poll/wait are not threadsafe
        https://bugs.webkit.org/show_bug.cgi?id=38289

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Thu, 29 Apr 2010 04:16:29 +0000 (04:16 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 29 Apr 2010 04:13:23 +0000 (04:13 +0000)]
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Make ClipboardGtk a "live" DataTransfer object, able to modify
        the clipboard when setData(...) is called.

        * platform/gtk/Skipped: Uncomment tests that are now passing.
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Make ClipboardGtk a "live" DataTransfer object, able to modify
        the clipboard when setData(...) is called.

        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
        (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
        (WebCore::dataObjectTypeFromHTMLClipboardType): Added.
        (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
        (WebCore::ClipboardGtk::clearAllData): Ditto.
        (WebCore::joinURIList): Added.
        (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
        (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
        (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
        (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
        (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
        (WebCore::ClipboardGtk::writeRange): Ditto.
        (WebCore::ClipboardGtk::writePlainText): Ditto.
        (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
        * platform/gtk/ClipboardGtk.h:
        (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
        * platform/gtk/DataObjectGtk.cpp:
        (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text.
        (WebCore::DataObjectGtk::markup): Actually return the range if it's set.
        (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text.
        (WebCore::DataObjectGtk::clearText): Added.
        (WebCore::DataObjectGtk::clearMarkup): Added.
        * platform/gtk/DataObjectGtk.h:
        (WebCore::DataObjectGtk::clearURIList): Added.
        (WebCore::DataObjectGtk::clearImage): Added.
        * platform/gtk/PasteboardHelper.cpp:
        (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
        (WebCore::urisToKURLVector): Added.
        (WebCore::PasteboardHelper::getClipboardContents): Added.
        (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
        (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
        * platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 29 Apr 2010 03:57:16 +0000 (03:57 +0000)]
2010-04-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Add fast paths for Math.pow and Math.sqrt
        https://bugs.webkit.org/show_bug.cgi?id=38294

        Add specialized thunks for Math.pow and Math.sqrt.
        This requires adding a sqrtDouble function to the MacroAssembler
        and sqrtsd to the x86 assembler.

        Math.pow is slightly more complicated, in that we have
        to implement exponentiation ourselves rather than relying
        on hardware support.  The inline exponentiation is restricted
        to positive integer exponents on a numeric base.  Exponentiation
        is finally performed through the "Exponentiation by Squaring"
        algorithm.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ImmPtr::ImmPtr):
        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARM::loadDouble):
        (JSC::MacroAssemblerARM::sqrtDouble):
        * assembler/MacroAssemblerARMv7.h:
        (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
        (JSC::MacroAssemblerARMv7::sqrtDouble):
        * assembler/MacroAssemblerX86.h:
        (JSC::MacroAssemblerX86::loadDouble):
        (JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
        * assembler/MacroAssemblerX86Common.h:
        (JSC::MacroAssemblerX86Common::sqrtDouble):
        * assembler/MacroAssemblerX86_64.h:
        (JSC::MacroAssemblerX86_64::loadDouble):
        (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::movsd_mr):
        (JSC::X86Assembler::sqrtsd_rr):
        (JSC::X86Assembler::X86InstructionFormatter::twoByteOp):
        (JSC::X86Assembler::X86InstructionFormatter::memoryModRM):
        * create_hash_table:
        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        * jit/JITOpcodes.cpp:
        * jit/JITStubs.h:
        (JSC::JITThunks::ctiNativeCallThunk):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::emitLoadDouble):
        (JSC::JSInterfaceJIT::emitJumpIfImmediateNumber):
        (JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber):
        (JSC::JSInterfaceJIT::emitLoadInt32):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::loadDoubleArgument):
        (JSC::SpecializedThunkJIT::loadInt32Argument):
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::finalize):
        * jit/ThunkGenerators.cpp:
        (JSC::sqrtThunkGenerator):
        (JSC::powThunkGenerator):
        * jit/ThunkGenerators.h:
        * runtime/Executable.h:
        (JSC::NativeExecutable::NativeExecutable):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::JSFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 29 Apr 2010 03:46:50 +0000 (03:46 +0000)]
2010-04-28  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Gustavo Noronha.

        [GTK] Enable DOM clipboard and drag-and-drop access
        https://bugs.webkit.org/show_bug.cgi?id=30623

        Use the length of the UTF-8 markup data in bytes when filling GtkSelectionData.

        No new tests, because pasteboard DataTransfer tests will be enabled
        with the completion of the GTK+ DataTransfer object.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::clipboard_get_contents_cb): Use strlen here instead of g_utf8_strlen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing...
mitz@apple.com [Thu, 29 Apr 2010 03:11:37 +0000 (03:11 +0000)]
More of <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Adele Peterson.

Assigning zero width and empty bounds to the ZERO WIDTH SPACE glyph often allocates a width map
page and a bounds map page for the glyph, each of which pages contains 255 unused entries. Save
this space by not storing the zero width and empty bounds in the metrics maps.

* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Initialize m_zeroWidthSpaceGlyph.
(WebCore::SimpleFontData::platformGlyphInit): Set m_zeroWidthSpaceGlyph. Don’t create entries
for the ZERO WIDTH SPACE glyph in the width map and in the bounds map.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::boundsForGlyph): Return empty bounds for the ZERO WIDTH SPACE glyph
without consulting the bounds map.
(WebCore::SimpleFontData::widthForGlyph): Return zero for the ZERO WIDTH SPACE glyph without
consulting the width map.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page...
mrowe@apple.com [Thu, 29 Apr 2010 03:05:03 +0000 (03:05 +0000)]
<rdar://problem/7847573> Safari welcome page logs JavaScript exception during page load

Reviewed by Adele Peterson.

The Safari welcome page runs afoul of the same-origin restriction on access to stylesheet rules
that was added to address <https://bugs.webkit.org/show_bug.cgi?id=20527>. To work around this we're
adding a temporary site-specific quirk that relaxes this restriction for the particular cross-origin
access that occurs on the Safari welcome page.

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
mthole@apple.com [Thu, 29 Apr 2010 03:00:07 +0000 (03:00 +0000)]
Build fix, not reviewed.

Fix WebKit2 build by stubbing out WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace().

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved the dividing line (i.e. "====...") logic from the code
cjerdonek@webkit.org [Thu, 29 Apr 2010 02:30:20 +0000 (02:30 +0000)]
Removed the dividing line (i.e. "====...") logic from the code
called by svn-apply and svn-unapply.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38093

The dividing line logic is unnecessary.  Removing it simplifies the
code and makes some subsequent changes easier.

* Scripts/VCSUtils.pm:
  - Removed the logic in gitdiff2svndiff() to convert the git
    "index" line to an SVN dividing line.
  - Adjusted the logic similarly in parseDiffHeader().

* Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
  - Updated the unit tests as necessary.

* Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
  - Updated the unit tests as necessary.
  - Corrected an error in the unit tests whereby all elements
    of an array were referencing the same element rather than
    distinct elements -- causing unit test failures to be masked.

* Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
  - Updated the unit tests as necessary.
  - Made the same unit test correction as above for parseDiff.pl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 29 Apr 2010 02:22:17 +0000 (02:22 +0000)]
2010-04-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, Qt build fix.

        [Qt] Guard the body of the function instead of the function for
        exported functions.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::webInspectorExecuteScript):
        (DumpRenderTreeSupportQt::webInspectorClose):
        (DumpRenderTreeSupportQt::webInspectorShow):
        (DumpRenderTreeSupportQt::setTimelineProfilingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed.
estade@chromium.org [Thu, 29 Apr 2010 01:50:53 +0000 (01:50 +0000)]
    Unreviewed.

        * Scripts/webkitpy/common/config/committers.py: adding myself as a committer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
mthole@apple.com [Thu, 29 Apr 2010 00:54:57 +0000 (00:54 +0000)]
JavaScriptCore: Reenable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK now that an
exports file for it has been added.

Reviewed by Mark Rowe.

* wtf/Platform.h:

WebCore: Add separate exports file for symbols dependent on WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK.

Reviewed by Mark Rowe.

* DerivedSources.make: Updated for WebCore.ProtectionSpaceAuthCallback.exp.
* WebCore.ProtectionSpaceAuthCallback.exp: Added.
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Thu, 29 Apr 2010 00:38:40 +0000 (00:38 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] revert getFontDataForCharacters change in r58341
        https://bugs.webkit.org/show_bug.cgi?id=38288

        * platform/chromium/test_expectations.txt: add the test to the now-failing list.
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by David Levin.

        [chromium] revert getFontDataForCharacters change in r58341
        https://bugs.webkit.org/show_bug.cgi?id=38288

        It caused a performance regression.

        * platform/chromium/ChromiumBridge.h:
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 29 Apr 2010 00:34:25 +0000 (00:34 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58441.
        http://trac.webkit.org/changeset/58441
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Broke 3 test on Qt.

        * editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Removed.
        * editing/pasteboard/drag-drop-iframe-refresh-crash.html: Removed.
        * editing/resources/drag-drop.html: Removed.
2010-04-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58441.
        http://trac.webkit.org/changeset/58441
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Broke 3 test on Qt.

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::concludeEditDrag):
        * page/DragController.h:
        (WebCore::DragController::setDragInitiator):
        (WebCore::DragController::dragInitiator):
        (WebCore::DragController::documentUnderMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 29 Apr 2010 00:22:16 +0000 (00:22 +0000)]
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Remove some obsolete scrolling code
        https://bugs.webkit.org/show_bug.cgi?id=38293

        * page/Chrome.cpp:
        (WebCore::Chrome::scrollRectIntoView): Removed ScrollView* argument.
        * page/Chrome.h: Made scrollRectIntoView non-virtual, and removed ScrollView* argument.

        * page/FrameView.cpp: Removed scrollRectIntoViewRecursively.
        * page/FrameView.h: Removed scrollRectIntoViewRecursively and made
        setScrollPosition non-virtual, since there is no class derived from
        this class, and ScrollView's setScrollPosition is non-virtual.

        * platform/HostWindow.h: Removed scrollRectIntoView.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Updated comment
        since I was able to do most of the tasks listed here.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Removed 0 passed for
        ScrollView* argument to Chrome::scrollRectIntoView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix, not reviewed.
mthole@apple.com [Thu, 29 Apr 2010 00:14:21 +0000 (00:14 +0000)]
Build fix, not reviewed.

* wtf/Platform.h:
Disable WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK until an exports file is created.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago.: Add WebKit2 to the lists of modules to build.
weinig@apple.com [Wed, 28 Apr 2010 23:58:33 +0000 (23:58 +0000)]
.: Add WebKit2 to the lists of modules to build.

Reviewed by Mark Rowe.

* Makefile:

WebKit2: Only build on SnowLeopard and later when using the Makefile.

Reviewed by Mark Rowe.

* Makefile:

WebKitTools: Add MiniBrowser to the lists of modules to build and only build it on
SnowLeopard and later.

Reviewed by Mark Rowe.

* Makefile:
* MiniBrowser/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd canAuthenticateAgainstProtectionSpace() to frame loader so that a protection...
mthole@apple.com [Wed, 28 Apr 2010 23:16:41 +0000 (23:16 +0000)]
Add canAuthenticateAgainstProtectionSpace() to frame loader so that a protection space
can be inspected before attempting to authenticate against it
https://bugs.webkit.org/show_bug.cgi?id=38271

Reviewed by David Kilzer.

JavaScriptCore:

* wtf/Platform.h: Add WTF_USE_PROTECTION_SPACE_AUTH_CALLBACK define.

WebCore:

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/ProtectionSpace.h:
(WebCore::):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::canAuthenticateAgainstProtectionSpace): Added.
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
Add cases for case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested and
ProtectionSpaceAuthenticationSchemeClientCertificateRequested.  Guarded with the
#if USE(PROTECTION_SPACE_AUTH_CALLBACK) as the new NSURLProtectionSpace constants don't
exist prior to Mac OS X 10.6.
(WebCore::core): Ditto.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace): Added.
(-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Added.

WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canAuthenticateAgainstProtectionSpace):
Added.  If the resource load delegate implements the callback, use its answer.  If it does
not, then only send authentication challenges for pre-10.6 protection spaces, which matches
CFNetwork's default behavior.
* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDelegateImplementationCaching.mm:
(CallResourceLoadDelegateReturningBoolean): Added case for passing three objects.
* WebView/WebResourceLoadDelegatePrivate.h:
Added private SPI definition: webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Abhishek Arya <inferno@chromium.org>
eric@webkit.org [Wed, 28 Apr 2010 22:48:23 +0000 (22:48 +0000)]
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        * editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
        * editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
        * editing/resources/drag-drop.html: Added.
2010-04-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
        Eliminated unused m_dragInitiator accessor to prevent dereferencing.
        https://bugs.webkit.org/show_bug.cgi?id=37618

        Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):
        (WebCore::DragController::concludeEditDrag):
        * page/DragController.h:
        (WebCore::DragController::draggingImageURL):
        (WebCore::DragController::documentUnderMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fixing a build problem introduced by the previous patch.
dumi@chromium.org [Wed, 28 Apr 2010 22:33:15 +0000 (22:33 +0000)]
Unreviewed, fixing a build problem introduced by the previous patch.

* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 28 Apr 2010 22:28:25 +0000 (22:28 +0000)]
2010-04-28  Adam Langley  <agl@chromium.org>

        Unreviewed, expectations update.

        These results are no longer specific to chromium-win. I believe that
        they should have been deleted in r58182, but I didn't notice the
        deletions, only the modified files.

        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.checksum: Removed.
        * platform/chromium-win/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
weinig@apple.com [Wed, 28 Apr 2010 22:17:48 +0000 (22:17 +0000)]
Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.

Reviewed by Mark Rowe.

* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/make-launchable.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding some required classes for the sync WebSQLDatabases API.
dumi@chromium.org [Wed, 28 Apr 2010 22:17:23 +0000 (22:17 +0000)]
Adding some required classes for the sync WebSQLDatabases API.
https://bugs.webkit.org/show_bug.cgi?id=34994

Reviewed by Jeremy Orlow.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/DatabaseSync.cpp: Added.
(WebCore::DatabaseSync::databaseInfoTableName):
(WebCore::DatabaseSync::setIsAvailable):
(WebCore::DatabaseSync::isAvailable):
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::version):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
* storage/DatabaseSync.h: Added.
(WebCore::DatabaseSync::databaseDebugName):
* storage/SQLTransactionSync.cpp: Added.
(WebCore::SQLTransactionSync::create):
(WebCore::SQLTransactionSync::SQLTransactionSync):
(WebCore::SQLTransactionSync::~SQLTransactionSync):
(WebCore::SQLTransactionSync::executeSQL):
* storage/SQLTransactionSync.h: Added.
(WebCore::SQLTransactionSync::database):
(WebCore::SQLTransactionSync::isReadOnly):
* storage/SQLTransactionSyncCallback.h: Added.
(WebCore::SQLTransactionSyncCallback::~SQLTransactionSyncCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 İsmail Dönmez <ismail@namtrac.org>
eric@webkit.org [Wed, 28 Apr 2010 22:05:32 +0000 (22:05 +0000)]
2010-04-28  İsmail Dönmez  <ismail@namtrac.org>

        Reviewed by Simon Hausmann.

        Fix compilation with QT_NO_CURSOR defined.

        * platform/qt/QWebPageClient.h:
        (QWebPageClient::resetCursor):
        (QWebPageClient::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 21:53:53 +0000 (21:53 +0000)]
2010-04-28  Ojan Vafai  <ojan@chromium.org>

        Reviewed by David Levin.

        fix linux expected result for fast/text/line-breaks.html
        https://bugs.webkit.org/show_bug.cgi?id=38283

        This is needed after r58426. See http://trac.webkit.org/changeset/57242
        for more details.

        * platform/chromium-linux/fast/text/line-breaks-expected.checksum:
        * platform/chromium-linux/fast/text/line-breaks-expected.png:
        * platform/chromium-linux/fast/text/line-breaks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 28 Apr 2010 21:51:34 +0000 (21:51 +0000)]
2010-04-28  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Audit all uses of subprocess in webkitpy
        https://bugs.webkit.org/show_bug.cgi?id=38284

        After further discussions with Jeffrey Yasskin
        about http://bugs.python.org/issue2320
        and related issues of using subprocess from
        multiple threads, I have learned that subprocess
        is known to be non-threadsafe through recent
        Python 2.7 builds.

        I'm attempting to lessen our exposure to these
        subprocess bugs by auditing each use of subprocess
        in webkitpy.  I did not find any unsafe calls
        in my audit, but I did remove numerous unneeded
        import subprocess lines.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
        * Scripts/webkitpy/common/system/user.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Alexey Proskuryakov.
ap@apple.com [Wed, 28 Apr 2010 21:42:18 +0000 (21:42 +0000)]
    Reviewed by Alexey Proskuryakov.

        Added a check to make sure that resources from a different https origin are not cached.
        https://bugs.webkit.org/show_bug.cgi?id=33456

        Test: http/tests/appcache/different-https-origin-resource-main.html

        * loader/appcache/ManifestParser.cpp:
        (WebCore::parseManifest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 28 Apr 2010 21:23:19 +0000 (21:23 +0000)]
2010-04-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/7918719> ASSERT(isMainThread()) from Font::setShouldUseSmoothing()

        Ensure that the WebView +initialize method initializes threading, so that things are correctly
        initialized when the first call into the WebKit framework is via a WebView class method.

        * WebView/WebView.mm:
        (+[WebView initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOnly set -allowable_client WebKit2 for engineering builds on SnowLeopard
weinig@apple.com [Wed, 28 Apr 2010 21:19:58 +0000 (21:19 +0000)]
Only set -allowable_client WebKit2 for engineering builds on SnowLeopard
and later.

Reviewed by Mark Rowe.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 28 Apr 2010 21:04:24 +0000 (21:04 +0000)]
2010-04-28  Evan Martin  <evan@chromium.org>

        Reviewed by Adam Roben.

        rebaseline for fast/text/international/bold-bengali
        https://bugs.webkit.org/show_bug.cgi?id=38281

        * platform/win/fast/text/international/bold-bengali-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
darin@apple.com [Wed, 28 Apr 2010 21:02:13 +0000 (21:02 +0000)]
Don't use CFAbsoluteTimeGetCurrent on Mac OS X, since it's just a cover
for gettimeofday anyway.

Reviewed by Sam Weinig.

* wtf/CurrentTime.cpp:
(WTF::currentTime): Remove the CF version of this. Change the "other POSIX"
version to pass 0 for the time zone instead of ignoring a return value.
Also get rid of unneeded type casts, since operations involving both
integers and doubles are always evaluated as doubles in C without explicit
type casting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 28 Apr 2010 20:57:02 +0000 (20:57 +0000)]
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scrollRectIntoView): When converting coordinates, use the document view
        rather than the WebView itself. This logic may not be correct for the case where
        usesDocumentViews is NO, but that is currently an experimental mode and can be fixed later.
2010-04-28  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        REGRESSION: Autoscroll does not work in Mail messages
        https://bugs.webkit.org/show_bug.cgi?id=38267
        rdar://problem/7559799

        Still haven't figured out a good way to test this with DumpRenderTree
        or with Safari. Testing has to be done with Mail for now.

        The machinery to make autoscrolling work on Mac OS X when a WebView is embedded in another
        view had gotten broken in multiple ways. For some reason, a combination of bugs made it
        partly work until around r48064. This brings it back.

        There were three problems:

            1) Code in EventHandler decided there was nothing to scroll, so didn't start
               the autoscroll timer.
            2) The wrong rectangle was passed to Chrome::scrollRectIntoView.
            3) The Mac WebKit implementation of ChromeClient::scrollRectIntoView did incorrect
               coordinate conversion.

        I verified that none of these have any effect on regression tests, or behavior in
        web browsers, or behavior on platforms other than Mac.

        * page/EventHandler.cpp:
        (WebCore::canAutoscroll): Added. Returns true for boxes that can scroll directly
        and for the top level box of the top frame.
        (WebCore::EventHandler::handleMouseDraggedEvent): Use canAutoscroll.
        (WebCore::EventHandler::updateAutoscrollRenderer): Ditto.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollToAnchor): Fixed comment.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively): Put ASSERT_NOT_REACHED into this
        now-unused function along with some comments about removing some obsolete code.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible): Removed call to scrollRectIntoViewRecursively
        since from the WebKit point of view this is the topmost scroll view anyway. Instead call
        setScrollPosition. Moved the code to call Chrome::scrollRectIntoView here since it needs
        to use a different rectangle anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] tst_QWebHistoryInterface::visitedLinks() fails
tonikitoo@webkit.org [Wed, 28 Apr 2010 20:50:23 +0000 (20:50 +0000)]
[Qt] tst_QWebHistoryInterface::visitedLinks() fails
https://bugs.webkit.org/show_bug.cgi?id=37323

Patch by Antonio Gomes  <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com> on 2010-04-28
Reviewed by NOBODY Simon Hausmann.

Patch fixes styleProperty method of QWebElement to make use of
CSSComputedStyleDeclaration::computedStyle 'allowVisitedStyle' parameter
and the corresponding failing QWebHistoryInterface::visitedLinks method.

* Api/qwebelement.cpp:
(QWebElement::styleProperty):
* tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:
(tst_QWebHistoryInterface::visitedLinks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 28 Apr 2010 20:50:17 +0000 (20:50 +0000)]
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
        * platform/mac/fast/repaint/stacked-diacritics-expected.png:
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::canUseGlyphCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-28 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 28 Apr 2010 20:35:17 +0000 (20:35 +0000)]
2010-04-28  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] callOnMainThread should equate to MessageLoop::PostTask
        https://bugs.webkit.org/show_bug.cgi?id=38276

        * JavaScriptCore.gyp/JavaScriptCore.gyp:
        * wtf/MainThread.cpp:
        * wtf/chromium/ChromiumThreading.h:
        * wtf/chromium/MainThreadChromium.cpp:
        (WTF::initializeMainThread):
        (WTF::callOnMainThread):
        (WTF::callOnMainThreadAndWait):
        (WTF::setMainThreadCallbacksPaused):
        (WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by David Kilzer.
ap@apple.com [Wed, 28 Apr 2010 20:30:16 +0000 (20:30 +0000)]
    Reviewed by David Kilzer.

        https://bugs.webkit.org/show_bug.cgi?id=38278
        https://localhost:8443 doesn't work in WebKit tests

        We only had a VirtualHost for 127.0.0.1:8443. Changed that to *:8443.

        * http/conf/apache2-debian-httpd.conf:
        * http/conf/apache2-httpd.conf:
        * http/conf/fedora-httpd.conf:
        * http/conf/httpd.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58424 268f45cc-cd09-0410-ab3c-d52691b4dbfc