WebKit-https.git
8 years ago[GTK] Build fix for Accelerated Compositing with OpenGL
commit-queue@webkit.org [Wed, 6 Jun 2012 07:29:35 +0000 (07:29 +0000)]
[GTK] Build fix for Accelerated Compositing with OpenGL
https://bugs.webkit.org/show_bug.cgi?id=88292

Patch by Joone Hur <joone.hur@intel.com> on 2012-06-06
Reviewed by Martin Robinson.

Build fix after r119247.
Do not include GraphicsSurface.h when not building
with GRAPHICS_SURFACE.

No new tests. This is only a build fix.

* platform/graphics/texmap/TextureMapperBackingStore.cpp:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/graphics/texmap/TextureMapperGL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 07:01:11 +0000 (07:01 +0000)]
[BlackBerry] IndexedDB file should be sand-boxed to the application data directory.
https://bugs.webkit.org/show_bug.cgi?id=88065

Reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::indexedDataBasePath):
(BlackBerry::WebKit::WebSettings::setIndexedDataBasePath):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrin...
commit-queue@webkit.org [Wed, 6 Jun 2012 06:53:11 +0000 (06:53 +0000)]
ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
https://bugs.webkit.org/show_bug.cgi?id=88197

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-05
Reviewed by Daniel Bates.

RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
So this assertion should be fired only if intrinsicRatio is non-zero.

Source/WebCore:

Test: svg/in-html/svg-assert-failure-percentage.html

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):

LayoutTests:

* svg/in-html/svg-assert-failure-percentage-expected.txt: Added.
* svg/in-html/svg-assert-failure-percentage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging flexbox justify/alignment doesn't update their positioning
tony@chromium.org [Wed, 6 Jun 2012 06:45:22 +0000 (06:45 +0000)]
Changing flexbox justify/alignment doesn't update their positioning
https://bugs.webkit.org/show_bug.cgi?id=88366

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/style-change.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Since these member variables were moved
out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.

LayoutTests:

* css3/flexbox/style-change-expected.txt: Added.
* css3/flexbox/style-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC implementation of SerializedScriptValue for IndexedDB
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 05:51:34 +0000 (05:51 +0000)]
JSC implementation of SerializedScriptValue for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=88048

Reviewed by George Staikos.

No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serializeNumber):
(CloneSerializer):
(WebCore::CloneDeserializer::toWireString):
(CloneDeserializer):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::toWireString):
(WebCore):
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::deserialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNested CSS flexbox renders incorrectly
ojan@chromium.org [Wed, 6 Jun 2012 05:41:51 +0000 (05:41 +0000)]
Nested CSS flexbox renders incorrectly
https://bugs.webkit.org/show_bug.cgi?id=87679

Reviewed by Julien Chaffraix.

Source/WebCore:

If the containing block with a perpendicular writing mode has an overrideHeight,
then its logical height should be based off that instead of its RenderStyle.

Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

* css3/flexbox/perpendicular-writing-modes-inside-flex-item-expected.txt: Added.
* css3/flexbox/perpendicular-writing-modes-inside-flex-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed special-case toJS(IDBAny) for IDBCursorWithValue
charles.wei@torchmobile.com.cn [Wed, 6 Jun 2012 05:37:24 +0000 (05:37 +0000)]
Need special-case toJS(IDBAny) for IDBCursorWithValue
https://bugs.webkit.org/show_bug.cgi?id=87963

Reviewed by George Staikos.

No new tests, this is for indexedDB, which is not working for JSC binding.
When indexedDB working for JSC, all the indexdb test cases should apply.

* bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll Chromium DEPS from r140653 to r140700.
rniwa@webkit.org [Wed, 6 Jun 2012 05:35:04 +0000 (05:35 +0000)]
Roll Chromium DEPS from r140653 to r140700.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload...
commit-queue@webkit.org [Wed, 6 Jun 2012 05:32:27 +0000 (05:32 +0000)]
[Qt][WK2] Use Component.onCompleted in API tests for single and multi file upload tests.
https://bugs.webkit.org/show_bug.cgi?id=88247

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-06-05
Reviewed by Kenneth Rohde Christiansen.

With r116936, Component.onCompleted can be used for callback instead of the
1s timer in single and multi file upload tests.

* UIProcess/API/qt/tests/qmltests/WebView/tst_multiFileUpload.qml:
* UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove Math.round and Math.floor intrinsic
yuqiang.xian@intel.com [Wed, 6 Jun 2012 05:25:54 +0000 (05:25 +0000)]
Improve Math.round and Math.floor intrinsic
https://bugs.webkit.org/show_bug.cgi?id=88314

Reviewed by Filip Pizlo.

Currently we call a native function from the JIT code to complete the
"round" and "floor" operations. We could inline some fast paths
especially for those positive values on the platforms where floating
point truncation is supported.
This brings 3% gain on Kraken, especially 32% on audio-oscillator,
and slight win on SunSpider, measured on IA32.

* jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC):
(JSC::roundThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] show the feature list in alphabetical order
commit-queue@webkit.org [Wed, 6 Jun 2012 05:19:18 +0000 (05:19 +0000)]
[GTK] show the feature list in alphabetical order
https://bugs.webkit.org/show_bug.cgi?id=88343

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-06-05
Reviewed by Gustavo Noronha Silva.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove JSObject::m_inheritorID
barraclough@apple.com [Wed, 6 Jun 2012 05:08:45 +0000 (05:08 +0000)]
Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Geoff Garen.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject):
    - No need m_inheritorID to initialize!
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject):
    - No need m_inheritorID to initialize!
* llint/LowLevelInterpreter.asm:
    - No need m_inheritorID to initialize!
* runtime/JSGlobalData.h:
(JSGlobalData):
    - Added private name 'm_inheritorIDKey'.
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject):
    - resetInheritorID is now passed a JSGlobalData&.
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren):
    - No m_inheritorID to be marked.
(JSC::JSObject::createInheritorID):
    - Store the newly created inheritorID in the property map.
* runtime/JSObject.h:
(JSC::JSObject::resetInheritorID):
    - Remove the inheritorID from property storage.
(JSC::JSObject::inheritorID):
    - Read the inheritorID from property storage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove erroneous expected image added in r119544.
rniwa@webkit.org [Wed, 6 Jun 2012 04:58:10 +0000 (04:58 +0000)]
Remove erroneous expected image added in r119544.

* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_mana...
commit-queue@webkit.org [Wed, 6 Jun 2012 04:44:56 +0000 (04:44 +0000)]
[chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
https://bugs.webkit.org/show_bug.cgi?id=87996

Patch by Michal Mocny <mmocny@google.com> on 2012-06-05
Reviewed by James Robinson.

Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
allocation given by GpuMemoryManager.  However, when the graphics context does not support the
GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
memory allocation limit to some non-0 value.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
(DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
(WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r119494.
haraken@chromium.org [Wed, 6 Jun 2012 03:44:03 +0000 (03:44 +0000)]
Unreviewed, rolling out r119494.
http://trac.webkit.org/changeset/119494
https://bugs.webkit.org/show_bug.cgi?id=87911

We found similar APIs are already implemented

* public/WebWidget.h:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebViewTest.cpp:
* tests/data/textarea.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
commit-queue@webkit.org [Wed, 6 Jun 2012 03:04:29 +0000 (03:04 +0000)]
[Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
https://bugs.webkit.org/show_bug.cgi?id=78720

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-05
Reviewed by Noam Rosenthal.

Source/WebCore:

Functions are removed from GraphicsContext3DQt that already implemented
in GraphicsContext3DCommon. Macros that not supported at GLES have been
changed to their appropriate pair that found in GraphicsContext3D
(e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
It was needed because OpenGLES does not support these macros.
Extensions3DQt is removed beceause it has never been used.
Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
and *OpenGLES to provide specialization.
The "m_depthStencilBuffer" member is added to Qt port because it uses
"m_depthStencilBuffer" like the other platforms.

* Target.pri:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::readRenderingResults):
(WebCore::GraphicsContext3D::reshape):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
(WebCore::GraphicsContext3D::readPixels):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::depthRange):
(WebCore):
(WebCore::GraphicsContext3D::clearDepth):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::isGLES2Compliant):
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore):

Source/WTF:

Defined a global Opengl ES macro to check OpenGL ES on every platforms.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines after r115091.
rniwa@webkit.org [Wed, 6 Jun 2012 02:41:45 +0000 (02:41 +0000)]
Chromium rebaselines after r115091.

* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Added.
* platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Chromium rebaselines after r119528 and r119512.
rniwa@webkit.org [Wed, 6 Jun 2012 02:13:34 +0000 (02:13 +0000)]
More Chromium rebaselines after r119528 and r119512.

* platform/chromium-linux/editing/selection/3690703-2-expected.png:
* platform/chromium-linux/editing/selection/3690703-expected.png:
* platform/chromium-linux/editing/selection/3690719-expected.png:
* platform/chromium-linux/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
commit-queue@webkit.org [Wed, 6 Jun 2012 01:57:53 +0000 (01:57 +0000)]
[BlackBerry]Differentiate options and group options by TypeOption and TypeOptionInGroup
https://bugs.webkit.org/show_bug.cgi?id=88342

Patch by Crystal Zhang <haizhang@rim.com> on 2012-06-05
Reviewed by Rob Buis.

RIM PR: 163141

Reviewed internally by Mike Fenton.

We set all options' type to TypeOption, which can't tell if an option belongs to a group,
introduce TypeOptionInGroup to fix it.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpecial layout handler should be done on top frame being printed.
darin@apple.com [Wed, 6 Jun 2012 01:51:08 +0000 (01:51 +0000)]
Special layout handler should be done on top frame being printed.
https://bugs.webkit.org/show_bug.cgi?id=88201

Patch by Vitaly Buka <vitalybuka@chromium.org> on 2012-06-05
Reviewed by Brady Eidson.

No new tests. Root case is already covered by tests.
Case described in the issue can be reproduced only by direct call
to Frame::setPrinting of subframe. Probably it's not possible with
layout tests.

* page/Frame.cpp:
(WebCore::Frame::setPrinting):
Use shouldUsePrintingLayout to choose proper version of forceLayout().
(WebCore::Frame::shouldUsePrintingLayout):
Checks if current frame is the top frame being printed.
* rendering/RenderView.cpp:
(WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
commit-queue@webkit.org [Wed, 6 Jun 2012 01:40:38 +0000 (01:40 +0000)]
[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=87551

Patch by Max Feil <mfeil@rim.com> on 2012-06-05
Reviewed by Antonio Gomes.

Source/WebCore:

Changes to make media controls larger in fullscreen mode. The
BlackBerry media controls used to be sized by a combination
of CSS styles specified in mediaControlsBlackBerry.css and
hard coded constants in RenderThemeBlackBerry.cpp. This patch
moves all the dimensional sizes to a common location, i.e.
RenderThemeBlackBerry.cpp. Having all the logic in C++ code allows
more complex decision making for when and how much to enlarge the
media controls. Currently the controls are enlarged by a factor
of 2 if the document is in fullscreen mode, the video element
is the current fullscreen element, and the deviceScaleFactor of
the page is less than 2.0. This avoids overly large controls
on pages which are already at least doubling the size of the
controls via viewport meta tag device-width settings. In other
words, if the CSS pixels are already enlarged compared to device
pixels by a factor of at least 2 in length and width.

In order to accomplish this, I had to add a new Element* parameter
to RenderTheme::adjustSliderThumbSize(). This is needed so
that fullscreen mode can be checked and the deviceScaleFactor
retrieved. I feel that this does not have a big impact on the
code and the other ports, for which I will simply be adding the
additional parameter in their platform code.

Tests:
video-controls-enlarged-fullscreen-meta.html
video-controls-enlarged-fullscreen-nometa.html

* css/mediaControlsBlackBerry.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::determineRenderSlider):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustSliderThumbSize):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustSliderThumbSize):
* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
* rendering/RenderThemeChromiumLinux.h:
(RenderThemeChromiumLinux):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::adjustSliderThumbSize):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
* rendering/RenderThemeSafari.h:
(RenderThemeSafari):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustSliderThumbSize):
* rendering/RenderThemeWin.h:
(RenderThemeWin):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustSliderThumbSize):
* rendering/RenderThemeWinCE.h:
(RenderThemeWinCE):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):
* rendering/RenderTheme.h:
(RenderTheme):

Source/WebKit/qt:

Add a new parameter to adjustSliderThumbSize() for BlackBerry
port. Fixing compiles of other ports.

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
* WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):

LayoutTests:

* media/media-controls.js:
(mediaControlsButtonDimensions):
* platform/blackberry/media/video-controls-enlarged-fullscreen-meta-expected.txt: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-meta.html: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-nometa-expected.txt: Added.
* platform/blackberry/media/video-controls-enlarged-fullscreen-nometa.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=88370
slewis@apple.com [Wed, 6 Jun 2012 01:37:09 +0000 (01:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=88370
Memory sampler should trigger low memory signal

Reviewed by Geoff Garen.

Source/WebCore:

No new tests. Verify by running stress test which crashes
in a few minutes without the fix.

Fix assumption in block code.  We could get in a state where timer_event_source
had already been released before the block ran.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::holdOff):

Source/WebKit2:

Send low memory signal when running the memory sampler.  We'd
like to test memory that cannot be freed.

* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::sampleTimerFired):
* Shared/WebMemorySampler.h:
(WebMemorySampler):
* Shared/mac/WebMemorySampler.mac.mm:
(WebKit):
(WebKit::WebMemorySampler::sendMemoryPressureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop generating image results in the tests added by r114172.
rniwa@webkit.org [Wed, 6 Jun 2012 01:10:49 +0000 (01:10 +0000)]
Stop generating image results in the tests added by r114172.

Rubber-stamped by Simon Fraser.

* css3/filters/huge-region-composited.html:
* css3/filters/huge-region.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines after r118772.
rniwa@webkit.org [Wed, 6 Jun 2012 01:01:32 +0000 (01:01 +0000)]
Chromium rebaselines after r118772.

* platform/chromium-mac-leopard/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-mac/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
andersca@apple.com [Wed, 6 Jun 2012 00:57:10 +0000 (00:57 +0000)]
Build fix.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
The error constant has been renamed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename a plug-in loading error constant
andersca@apple.com [Wed, 6 Jun 2012 00:48:14 +0000 (00:48 +0000)]
Rename a plug-in loading error constant
https://bugs.webkit.org/show_bug.cgi?id=88381
<rdar://problem/11602601>

Reviewed by Sam Weinig.

* Misc/WebKitErrors.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fixing an incorrect path in lion Skipped file.
leviw@chromium.org [Wed, 6 Jun 2012 00:47:22 +0000 (00:47 +0000)]
Unreviewed. Fixing an incorrect path in lion Skipped file.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
yosin@chromium.org [Wed, 6 Jun 2012 00:39:52 +0000 (00:39 +0000)]
[Forms] Introduce InputNumber type as an alias of double for replacing it to Decimal
https://bugs.webkit.org/show_bug.cgi?id=88275

Reviewed by Kent Tamura.

This patch introduced InputNumber type as alias of double to be
replaced to Decimal and convertDoubleToInputNumber and
convertToInputNumberToDouble for reducing size of patch when we
introduce Decimal type.

This patch added new vairables to use const variable to reduce
copy operation when introducing Decimal type.

In the implementation, we use InputNumber, will be Decimal, however some methods in IDL
use double. To clarify internal usage of value and external usage, thit patch renamed
following functions:

- parseToDouble => parseNumber
- setValueAsNumber => setValueAsDouble and setValueAsInputNumber
- valueAsNumber => valueAsDouble

This patch is a part of introducing Decimal, https://bugs.webkit.org/show_bug.cgi?id=80009

No new tests. This patch doesn't change behavior.

* html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::valueAsDate): Replaced parseToNumber() to valueAsDouble()
(WebCore::BaseDateAndTimeInputType::setValueAsDate): Inserted convertDoubleToInputNumber.
(WebCore::BaseDateAndTimeInputType::valueAsDouble): Use new function parseToDouble().
(WebCore::BaseDateAndTimeInputType::setValueAsInputNumber): Added.
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::BaseDateAndTimeInputType::parseToNumber): This is replacement of parseToDouble().
(WebCore::BaseDateAndTimeInputType::parseToDouble): Added for valueAsDate and valueAsDouble.
(WebCore::BaseDateAndTimeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): Replace double to InputNumber for getAllowdStep.
* html/BaseDateAndTimeInputType.h:
(BaseDateAndTimeInputType):
* html/DateInputType.cpp:
(WebCore::DateInputType::createStepRange): Replaced double to InputNumber.
* html/DateInputType.h:
(DateInputType):
* html/DateTimeInputType.cpp:
(WebCore::DateTimeInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::DateTimeInputType::createStepRange): Replaced double to InputNumber.
* html/DateTimeInputType.h:
(DateTimeInputType):
* html/DateTimeLocalInputType.cpp:
(WebCore::DateTimeLocalInputType::createStepRange): Replaced double to InputNumber.
* html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::HTMLInputElement::valueAsNumber): Use InputType::valueAsDouble.
(WebCore::HTMLInputElement::setValueAsNumber): Use InputType::valueAsDouble.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsDouble): Replacement of valueAsNumber.
(WebCore::InputType::setValueAsInputNumber): Replacement of valueAsNumber.
(WebCore::InputType::rangeUnderflow): Replaced double to InputNumber.
(WebCore::InputType::rangeOverflow): Replaced double to InputNumber.
(WebCore::InputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::InputType::isInRange): Replaced double to InputNumber.
(WebCore::InputType::isOutOfRange): Replaced double to InputNumber.
(WebCore::InputType::stepMismatch): Replaced double to InputNumber.
(WebCore::InputType::validationMessage): Replaced double to InputNumber.
(WebCore::InputType::parseToNumber): Replacement of parseToDouble.
(WebCore::InputType::parseToNumberOrNaN): Added for reducing number of std::numeric_limits<double>::quiet_NaN().
(WebCore::InputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::InputType::serialize): Changed parameter type to InputNumber.
(WebCore::InputType::applyStep): Replaced double to InputNumber.
(WebCore::InputType::getAllowedValueStep): Changed parameter type to InputNumber.
(WebCore::InputType::stepUpFromRenderer): Replaced double to InputNumber.
* html/InputType.h:
(InputType):
* html/MonthInputType.cpp:
(WebCore::MonthInputType::defaultValueForStepUp): Changed return type to InputNumber.
(WebCore::MonthInputType::createStepRange): Replaced double to InputNumber.
(WebCore::MonthInputType::parseToNumber): Replacement of parseToDouble.
* html/MonthInputType.h:
(MonthInputType):
* html/NumberInputType.cpp:
(WebCore::NumberInputType::valueAsDouble): Replacement of valueAsNumber. Changed to use parseToDoubleForNumberType.
(WebCore::NumberInputType::setValueAsDouble):  Replacement of setValueAsNumber.  Changed to use serializeForNumberType.
(WebCore::NumberInputType::setValueAsInputNumber): Replacement of setValueAsNumber.
(WebCore::NumberInputType::createStepRange): Replaced double to InputNumber.
(WebCore::NumberInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::NumberInputType::parseToNumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::NumberInputType::serialize):
* html/NumberInputType.h:
(NumberInputType):
* html/RangeInputType.cpp:
(WebCore::ensureMaximum): Replaced double to InputNumber.
(WebCore::RangeInputType::valueAsDouble): Replacement of valueAsNumber.
(WebCore::RangeInputType::setValueAsInputNumber):  Replacement of setValueAsNumber.
(WebCore::RangeInputType::createStepRange): Replaced double to InputNumber.
(WebCore::RangeInputType::handleKeydownEvent): Replaced double to InputNumber.
(WebCore::RangeInputType::parseToNumber): Replacement of parseToDouble.
(WebCore::RangeInputType::serialize): Changed parameter type to InputNumber.
(WebCore::RangeInputType::sanitizeValue): Replaced double to InputNumber.
* html/RangeInputType.h:
(RangeInputType):
* html/StepRange.cpp:
(WebCore::StepRange::StepRange): Replaced double to InputNumber.
(WebCore::StepRange::acceptableError): Replaced double to InputNumber.
(WebCore::StepRange::alignValueForStep): Replaced double to InputNumber.
(WebCore):
(WebCore::StepRange::clampValue): Replaced double to InputNumber.
(WebCore::StepRange::stepMismatch): Replaced double to InputNumber.
* html/StepRange.h:
(WebCore::convertDoubleToInputNumber): Added.
(WebCore::convertInputNumberToDouble): Added.
(WebCore::StepRange::NumberWithDecimalPlaces::NumberWithDecimalPlaces): Replaced double to InputNumber.
(WebCore::StepRange::StepDescription::defaultValue): Replaced double to InputNumber.
(StepRange):
(WebCore::StepRange::maximum): Replaced double to InputNumber.
(WebCore::StepRange::minimum): Replaced double to InputNumber.
(WebCore::StepRange::step): Replaced double to InputNumber.
(WebCore::StepRange::stepBase): Replaced double to InputNumber.
(WebCore::StepRange::defaultValue): Replaced double to InputNumber.
(WebCore::StepRange::proportionFromValue): Replaced double to InputNumber.
(WebCore::StepRange::valueFromProportion): Replaced double to InputNumber.
* html/TimeInputType.cpp:
(WebCore::TimeInputType::defaultValueForStepUp): Replaced double to InputNumber.
(WebCore::TimeInputType::createStepRange): Replaced double to InputNumber.
* html/TimeInputType.h:
(TimeInputType):
* html/WeekInputType.cpp:
(WebCore::WeekInputType::createStepRange): Replaced double to InputNumber.
* html/WeekInputType.h:
(WeekInputType):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::writeDocument): Replaced double to InputNumber.
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderPosition): Replaced double to InputNumber.
(WebCore::RenderSliderThumb::layout): Replaced double to InputNumber.
(WebCore::SliderThumbElement::setPositionFromPoint): Replaced double to InputNumber.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Chromium windows test expectation updates.
eae@chromium.org [Wed, 6 Jun 2012 00:38:21 +0000 (00:38 +0000)]
Unreviewed gardening. Chromium windows test expectation updates.

* platform/chromium-win/fast/sub-pixel: Added.
* platform/chromium-win/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll Chromium DEPS from r140528 to r140653.
rniwa@webkit.org [Wed, 6 Jun 2012 00:32:24 +0000 (00:32 +0000)]
Roll Chromium DEPS from r140528 to r140653.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. More updated Chromium test expectations following 119528.
leviw@chromium.org [Wed, 6 Jun 2012 00:31:22 +0000 (00:31 +0000)]
Unreviewed gardening. More updated Chromium test expectations following 119528.

* platform/chromium-linux-x86/editing/selection: Added.
* platform/chromium-linux-x86/editing/selection/3690703-2-expected.png: Added.
* platform/chromium-linux-x86/editing/selection/3690703-expected.png: Added.
* platform/chromium-linux-x86/editing/selection/3690719-expected.png: Added.
* platform/chromium-linux-x86/fast/sub-pixel: Added.
* platform/chromium-linux-x86/fast/sub-pixel/selection: Added.
* platform/chromium-linux-x86/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-linux/fast/sub-pixel: Added.
* platform/chromium-linux/fast/sub-pixel/selection: Added.
* platform/chromium-linux/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-leopard/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac-leopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac/fast/sub-pixel/selection: Added.
* platform/chromium-mac/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-win-vista/fast/sub-pixel: Added.
* platform/chromium-win-vista/fast/sub-pixel/selection: Added.
* platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-win/editing/selection/3690703-2-expected.png:
* platform/chromium-win/editing/selection/3690703-expected.png:
* platform/chromium-win/editing/selection/3690719-expected.png:
* platform/chromium-win/fast/sub-pixel: Added.
* platform/chromium-win/fast/sub-pixel/selection: Added.
* platform/chromium-win/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines for r119523 and r119529.
rniwa@webkit.org [Wed, 6 Jun 2012 00:25:11 +0000 (00:25 +0000)]
Chromium rebaselines for r119523 and r119529.

* platform/chromium-linux/compositing/layer-creation: Removed.
* platform/chromium-mac-snowleopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/chromium-win/compositing/iframes/scroll-fixed-transformed-element-expected.png: Added.
* platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
beidson@apple.com [Wed, 6 Jun 2012 00:15:42 +0000 (00:15 +0000)]
<rdar://problem/11575898> and https://bugs.webkit.org/show_bug.cgi?id=88372
REGRESSION(110494): Can no longer drag-and-drop links into FileMaker Pro 12

- Before r110494 we used to write the NSStringPboardType to the pasteboard.
  After r110494 we write NSURLPboardType instead.
  That's basically a no-op, but the NSStringPboardType needs to be restored.
- Before r110494 we wrote the link destination URL to the pasteboard.
  After r110494 we write the image src URL if the link is an image.
  We need to revert to writing the link URL.

Fortunately these changes can be accomplished with a 2-line fix.

Reviewed by Enrica Casucci.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
n

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix after r119527.
rniwa@webkit.org [Wed, 6 Jun 2012 00:05:46 +0000 (00:05 +0000)]
Build fix after r119527.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
commit-queue@webkit.org [Tue, 5 Jun 2012 23:12:19 +0000 (23:12 +0000)]
[Cairo] [OpenGL] Enable GL_OES_standard_derivatives
https://bugs.webkit.org/show_bug.cgi?id=87583

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-06-05
Reviewed by Alejandro G. Castro.

No new tests. This is covered by oes-standard-derivatives.html
in the Khronos WebGL conformance tests, which may one day be part
of the WebKit test suite.

Activate the GL_OES_standard_derivatives on Cairo along with
Qt and Mac.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildbot fix.
jonlee@apple.com [Tue, 5 Jun 2012 22:45:01 +0000 (22:45 +0000)]
Buildbot fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
in the function. Store in a local variable.
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing two leopard-specific baselines following r119528.
leviw@chromium.org [Tue, 5 Jun 2012 22:28:02 +0000 (22:28 +0000)]
Fixing two leopard-specific baselines following r119528.

* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Chromium test expectations.
rniwa@webkit.org [Tue, 5 Jun 2012 22:19:47 +0000 (22:19 +0000)]
Fix Chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAvoid creating compositing layers for preserve-3d without transformed descendants
simon.fraser@apple.com [Tue, 5 Jun 2012 22:18:31 +0000 (22:18 +0000)]
Avoid creating compositing layers for preserve-3d without transformed descendants
https://bugs.webkit.org/show_bug.cgi?id=88115

Source/WebCore:

Reviewed by Antti Koivisto.

Avoid creating compositing layers, and therefore using excess backing store,
for elements that have -webkit-transform-style: preserve-3d, but no 3D-transformed
descendants that would be affected by that preserve-3d.

Test: compositing/layer-creation/no-compositing-for-preserve-3d.html

* rendering/RenderLayer.h: Replace the "mustOverlap" flag with a enum
that describes the different reasons for indirect compositing, so that
we can use that information to decide whether to allocate backing store.
(WebCore::RenderLayer::setIndirectCompositingReason):
(WebCore::RenderLayer::indirectCompositingReason):
(WebCore::RenderLayer::mustCompositeForIndirectReasons):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer): Initialize m_indirectCompositingReason

* rendering/RenderLayerCompositor.h: New out param for computeCompositingRequirements()
that is uses to indicate that a 3d-transformed descendant has been encountered.
Rename requiresCompositingWhenDescendantsAreCompositing() to requiresCompositingForIndirectReason(),
and return the reason as an out param.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers): Pass in the saw3DTransform
param to computeCompositingRequirements().
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Return a flag
from computeCompositingRequirements() that is set to true if we've seen descendants
that have 3d transforms. This is later used to decide whether to composite for
perspective or preserve-3d.
Change the "mustOverlapCompositedLayers" code to use the new "indirect compositing"
enum flags.
After enumerating children, call requiresCompositingForIndirectReason() and
record the reason in the layer.
(WebCore::RenderLayerCompositor::needsToBeComposited): Use mustCompositeForIndirectReasons() now.
(WebCore::RenderLayerCompositor::requiresOwnBackingStore): Consult the indirect compositing
reason rather than just looking for the overlap flag.
(WebCore::RenderLayerCompositor::reasonForCompositing): Now that we have more information
about indirect compositing reasons, the logging can be more detailed.
(WebCore::RenderLayerCompositor::requiresCompositingForTransform): This now only looks
for 3d transforms. We now treat perspective and perserve-3d as "indirect" reasons, because
whether they composite depends on descendants having non-affine transforms.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): Includes the logic
previously in requiresCompositingWhenDescendantsAreCompositing(), and now determines
whether to composite for preserve-3d and perspective, based on whether we have transformed descendants.

LayoutTests:

Reviewed by Antti Koivisto.

* compositing/backing/no-backing-for-perspective-expected.txt:
* compositing/backing/no-backing-for-perspective.html: Change the transform to be non-affine so that
we keep making layers for perspective.
* compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
* compositing/layer-creation/no-compositing-for-preserve-3d.html: Copied from LayoutTests/compositing/backing/no-backing-for-perspective.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBlock selection gaps painted not properly pixel snapped
leviw@chromium.org [Tue, 5 Jun 2012 21:56:24 +0000 (21:56 +0000)]
Block selection gaps painted not properly pixel snapped
https://bugs.webkit.org/show_bug.cgi?id=88000

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes for selection painting in both inline line heights and block gaps. We were unintentionally
flooring inline and block offsets in RenderBlock, but actually need to intentionally floor the
logical left and right values in logical(Left|Right)SelectionGap to properly align our block
selection gaps. This is to properly mirror the behavior in pixelSnappedLogicalRightOffsetForLine.

We were also unintentionally upcasting LayoutUnits to floats in InlineTextBox's selection painting
routine. Now we're properly rounding.

Test: fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintSelection): Move paint values to integers and do proper rounding.
* rendering/RenderBlock.cpp:
(WebCore::blockDirectionOffset): Fix incorrect flooring in return value.
(WebCore::inlineDirectionOffset): Ditto.
(WebCore): Removing previous attempt to properly mirror inline box selection pixel alignment. This
implementation rounded the final x value instead of properly rounding our block offset then flooring
the offset that corresponds to the behavior in InlineTextBox. It also didn't properly pixel snap
the y offset and height.
(WebCore::RenderBlock::blockSelectionGap): Properly pixel snapping the gap rect before painting.
(WebCore::RenderBlock::logicalLeftSelectionGap): Correctly match InlineTextBox's selection pixel
alignment by flooring the logicalLeft and pixel snapping the subsequent rect. We do this in order
to maintain proper render tree pixel snapping while simultaneously mirroring the flooring in the
inline direction that occurs in InlineTextBox.cpp's alignSelectionRectToDevicePixels method.
(WebCore::RenderBlock::logicalRightSelectionGap): Ditto with the right.

LayoutTests:

One new selection test and updated snowleopard expectations for a handful that improved.

Note: a couple of the RTL results appear worse, but sadly are only returning to our old pre-sub-pixel results.

* fast/sub-pixel/selection: Added.
* fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Added.
* fast/sub-pixel/selection/selection-gaps-at-fractional-offsets.html: Added.
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/selection-button-text-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/chromium-mac-snowleopard/fast/sub-pixel: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/selection: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Added.
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/gtk-wk2/Skipped:
* platform/mac-lion/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/Skipped:
* platform/qt-4.8/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:
* platform/win-xp/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove support for target-densitydpi in the viewport meta tag
abarth@webkit.org [Tue, 5 Jun 2012 21:36:55 +0000 (21:36 +0000)]
Remove support for target-densitydpi in the viewport meta tag
https://bugs.webkit.org/show_bug.cgi?id=88047

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The target-densitydpi parameter was originally implemented on Android,
but it does not appear to be widely used and introduces significant
implementation complexity because it forces us to track three scale
factors (defaultDeviceScaleFactor, deviceScaleFactor, and
pageScaleFactor) rather than just two (deviceScaleFactor and
pageScaleFactor).

There don't appear to be many web sites that use target-densitydpi
because it is not supported on iOS.  There are also concerns from the
standards community about the design of the feature.  It seems our best
course of action is to remove target-densitydpi and address these use
cases via other mechanisms, such as responsive images and device units
in CSS because those approaches are likely to be implemented broadly.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore):
(WebCore::setViewportFeature):
(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessageLevel):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):
* Api/WebViewportArguments.cpp:
(BlackBerry::WebKit::WebViewportArguments::targetDensityDpi):
(BlackBerry::WebKit::WebViewportArguments::setTargetDensityDpi):
* Api/WebViewportArguments.h:

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

LayoutTests:

These tests are no longer needed because they're testing a feature we
no longer support.

* fast/viewport/viewport-133-expected.txt: Removed.
* fast/viewport/viewport-133.html: Removed.
* fast/viewport/viewport-92-expected.txt: Removed.
* fast/viewport/viewport-92.html: Removed.
* fast/viewport/viewport-93-expected.txt: Removed.
* fast/viewport/viewport-93.html: Removed.
* fast/viewport/viewport-94-expected.txt: Removed.
* fast/viewport/viewport-94.html: Removed.
* fast/viewport/viewport-95-expected.txt: Removed.
* fast/viewport/viewport-95.html: Removed.
* fast/viewport/viewport-96-expected.txt: Removed.
* fast/viewport/viewport-96.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CFG simplification should not attempt to deref nodes inside of an unreachable...
fpizlo@apple.com [Tue, 5 Jun 2012 21:32:18 +0000 (21:32 +0000)]
DFG CFG simplification should not attempt to deref nodes inside of an unreachable subgraph
https://bugs.webkit.org/show_bug.cgi?id=88362

Reviewed by Gavin Barraclough.

* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix Chromium test expectations.
rniwa@webkit.org [Tue, 5 Jun 2012 21:24:21 +0000 (21:24 +0000)]
Fix Chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium mac rebaseline for float-containing-block-with-margin.
eae@chromium.org [Tue, 5 Jun 2012 21:16:24 +0000 (21:16 +0000)]
Unreviewed chromium mac rebaseline for float-containing-block-with-margin.

* platform/chromium-mac-leopard/fast/sub-pixel: Added.
* platform/chromium-mac-leopard/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Chromium test failure expectations per Skia roll:
rniwa@webkit.org [Tue, 5 Jun 2012 20:54:46 +0000 (20:54 +0000)]
Add Chromium test failure expectations per Skia roll:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140580

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuildbot fix.
jonlee@apple.com [Tue, 5 Jun 2012 20:53:51 +0000 (20:53 +0000)]
Buildbot fix.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: clean up win-specific path handling and tests
dpranke@chromium.org [Tue, 5 Jun 2012 20:47:42 +0000 (20:47 +0000)]
webkitpy: clean up win-specific path handling and tests
https://bugs.webkit.org/show_bug.cgi?id=88281

Reviewed by Adam Barth.

There was a bunch of inconsistent logic for handling path
conversions for win32 and cygwin paths due to us sometimes
looking at sys.platform and sometimes using mock hosts. This
patch cleans everything up so that we are required to pass
PlatformInfo objects to the path module and stop trying to do
different things when running on cygwin or win32 hosts (except
in the path_unittest module itself).

This may slightly reduce test coverage for the win32 code paths
but will be a lot easier to follow and maintain.

* Scripts/webkitpy/common/system/path.py:
(abspath_to_uri):
(_convert_path):
* Scripts/webkitpy/common/system/path_unittest.py:
(AbspathTest.platforminfo):
(AbspathTest.test_abspath_to_uri_cygwin):
(AbspathTest.test_abspath_to_uri_unixy):
(AbspathTest.test_abspath_to_uri_win):
(AbspathTest.test_abspath_to_uri_escaping_unixy):
(AbspathTest.test_abspath_to_uri_escaping_cygwin):
(AbspathTest.test_stop_cygpath_subprocess):
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo.is_cygwin):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_cygwin):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.show_results_html_file):
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.test_to_uri):
(Driver.uri_to_test):
* Scripts/webkitpy/layout_tests/port/driver_unittest.py:
(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTPortTest.make_port):
(MockDRTTest.input_line):
(MockChromiumDRTTest.test_pixeltest__fails):
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWorkaround buildbot bug when merging build requests.
jonlee@apple.com [Tue, 5 Jun 2012 20:41:41 +0000 (20:41 +0000)]
Workaround buildbot bug when merging build requests.
https://bugs.webkit.org/show_bug.cgi?id=88158

Reviewed by Mark Rowe.

For expediency, we still want testers to pick the latest build to test, but to ensure
that the builders are reporting the correct revision number, we should let the building bots
run as they normally would. That is, the builder picks the oldest revision, and merges
subsequent requests. Because merged requests get appended to the list of changes for a given
build, the last change in that list is also the latest change. When we used pickLatestBuild
for the builders, this was not the case (it would always report the penultimate change).

http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
for all Apple builders.
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
the latest build to run.
(loadBuilderConfig):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEntry into JSC should CRASH() if the Heap is busy
mhahnenberg@apple.com [Tue, 5 Jun 2012 20:38:21 +0000 (20:38 +0000)]
Entry into JSC should CRASH() if the Heap is busy
https://bugs.webkit.org/show_bug.cgi?id=88355

Reviewed by Geoffrey Garen.

Interpreter::execute() returns jsNull() right now if we try to enter it while
the Heap is busy (e.g. with a collection), which is okay, but some code paths
that call Interpreter::execute() allocate objects before checking if the Heap
is busy. Attempting to execute JS code while the Heap is busy should not be
allowed and should be enforced by a release-mode CRASH() to prevent vague,
unhelpful backtraces later on if somebody makes a mistake. Normally, recursively
executing JS code is okay, e.g. for evals, but it should not occur during a
Heap allocation or collection because the Heap is not guaranteed to be in a
consistent state (especially during collections). We are protected from
executing JS on the same Heap concurrently on two separate threads because
they must each take a JSLock first. However, we are not protected from reentrant
execution of JS on the same thread because JSLock allows reentrancy. Therefore,
we should fail early if we detect an entrance into JS code while the Heap is busy.

* heap/Heap.cpp: Changed Heap::collect so that it sets the m_operationInProgress field
at the beginning of collection and then unsets it at the end so that it is set at all
times throughout the duration of a collection rather than sporadically during various
phases. There is no reason to unset during a collection because our collector does
not currently support running additional JS between the phases of a collection.
(JSC::Heap::getConservativeRegisterRoots):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute): Crash if the Heap is busy.
* runtime/Completion.cpp: Crash if the Heap is busy. We do it here before we call
Interpreter::execute() because we do some allocation prior to calling execute() which
could cause Heap corruption if, for example, that allocation caused a collection.
(JSC::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Implement log channel initialization for WebKit2
vestbo@webkit.org [Tue, 5 Jun 2012 20:06:26 +0000 (20:06 +0000)]
[Qt] Implement log channel initialization for WebKit2

Reviewed by Alexis Menard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebLayerTreeRenderer behaves wrongly when no contentsScale is set.
alexis.menard@openbossa.org [Tue, 5 Jun 2012 19:59:17 +0000 (19:59 +0000)]
WebLayerTreeRenderer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=88357

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-05
Reviewed by Alexis Menard.

The contentsScale needs to get a default value in case no
value is explicitely set yet.
This fixes the blank-until-resize problem when running MiniBrowser
in --desktop mode.

* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAssertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
timothy_horton@apple.com [Tue, 5 Jun 2012 19:52:48 +0000 (19:52 +0000)]
Assertion failure on mac-lion-wk2 in fast/hidpi/device-scale-factor-paint.html
https://bugs.webkit.org/show_bug.cgi?id=88356

Unreviewed, remove incorrect baselines and skip test on Mac.

* platform/mac/Skipped:
* platform/mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
* platform/mac/fast/hidpi/device-scale-factor-paint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Improve variable resolution order on window
arv@chromium.org [Tue, 5 Jun 2012 19:22:46 +0000 (19:22 +0000)]
[V8] Improve variable resolution order on window
https://bugs.webkit.org/show_bug.cgi?id=84247

Reviewed by Ojan Vafai.

This changes the V8 flag to turn on es52_globals and updates the layout tests to reflect the fixed behavior.

Source/WebCore:

Test: fast/dom/Window/window-property-shadowing-onclick.html

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded): Set the flag as we initialize V8.
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initIsolate): Ditto.

LayoutTests:

* fast/dom/Window/window-property-shadowing-name-expected.txt: The expectation is now reversed.
* fast/dom/Window/window-property-shadowing-name.html: JSC fails so this test says fail. Bug 75575 tracks JSC.
* fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.
* fast/dom/Window/window-property-shadowing-onclick.html: Added.
* platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Copied from LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt.
* platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDelete dead code from RenderBox::computeLogicalWidthInRegion
ojan@chromium.org [Tue, 5 Jun 2012 19:16:55 +0000 (19:16 +0000)]
Delete dead code from RenderBox::computeLogicalWidthInRegion
https://bugs.webkit.org/show_bug.cgi?id=88353

Reviewed by Tony Chang.

No new tests obviously since this is dead code.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange fast/sub-pixel/float-containing-block-with-margin.html to pixel test
eae@chromium.org [Tue, 5 Jun 2012 19:16:11 +0000 (19:16 +0000)]
Change fast/sub-pixel/float-containing-block-with-margin.html to pixel test
https://bugs.webkit.org/show_bug.cgi?id=88351

Reviewed by Levi Weintraub.

Change fast/sub-pixel/float-containing-block-with-margin.html to pixel
test to allow for platform differences as the default styling makes it
very hard to use a reftests for this.

* fast/sub-pixel/float-containing-block-with-margin-expected.html: Removed.
* fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* fast/sub-pixel/float-containing-block-with-margin-expected.txt: Added.
* fast/sub-pixel/float-containing-block-with-margin.html:
* platform/chromium-mac/fast/sub-pixel/float-containing-block-with-margin-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Fixing improper text expectation following r119503.
leviw@chromium.org [Tue, 5 Jun 2012 19:01:26 +0000 (19:01 +0000)]
Unreviewed gardening. Fixing improper text expectation following r119503.

* platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Removed.
* platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Removed.
* platform/chromium/fast/line-grid: Added.
* platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move createLocalStorageNamespace to Platform.h
pilgrim@chromium.org [Tue, 5 Jun 2012 18:53:44 +0000 (18:53 +0000)]
[Chromium] Move createLocalStorageNamespace to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=85766

Source/Platform:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::createLocalStorageNamespace):
* chromium/public/WebStorageArea.h: Added.
(WebKit):
(WebStorageArea):
(WebKit::WebStorageArea::~WebStorageArea):
(WebKit::WebStorageArea::setItem):
(WebKit::WebStorageArea::removeItem):
(WebKit::WebStorageArea::clear):
* chromium/public/WebStorageNamespace.h: Added.
(WebKit):
(WebStorageNamespace):
(WebKit::WebStorageNamespace::~WebStorageNamespace):
(WebKit::WebStorageNamespace::isSameNamespace):

Source/WebKit/chromium:

Reviewed by James Robinson.

Part of a refactoring series. See tracking bug 82948.

* WebKit.gyp:
* public/WebStorageArea.h:
* public/WebStorageNamespace.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaseline per Chromium r140536.
rniwa@webkit.org [Tue, 5 Jun 2012 18:53:14 +0000 (18:53 +0000)]
Chromium rebaseline per Chromium r140536.

* platform/chromium-linux-x86/http/tests/media: Added.
* platform/chromium-linux-x86/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
* platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
* platform/chromium-win-vista/http/tests/media: Added.
* platform/chromium-win-vista/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
* platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew constructor for WebIntent to be used for delivery
commit-queue@webkit.org [Tue, 5 Jun 2012 18:39:37 +0000 (18:39 +0000)]
New constructor for WebIntent to be used for delivery
https://bugs.webkit.org/show_bug.cgi?id=87143

Patch by Greg Billock <gbillock@google.com> on 2012-06-05
Reviewed by Darin Fisher.

Source/WebCore:

* Modules/intents/Intent.cpp:
(WebCore::Intent::setExtras):
(WebCore):
* Modules/intents/Intent.h:
(Intent):

Source/WebKit/chromium:

When delivering an intent to webkit, the caller needs to be able to
provide the action, type, and data, and also extra data and ports.

* public/WebIntent.h:
(WebIntent):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::deliverIntent):
* src/WebIntent.cpp:
(WebKit::WebIntent::WebIntent):
(WebKit):
(WebKit::WebIntent::reset):
(WebKit::WebIntent::messagePortChannelsRelease):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange overrideSizes to be content-box instead of border-box
ojan@chromium.org [Tue, 5 Jun 2012 18:32:10 +0000 (18:32 +0000)]
Change overrideSizes to be content-box instead of border-box
https://bugs.webkit.org/show_bug.cgi?id=88116

Reviewed by Tony Chang.

Source/WebCore:

Previously, the code used border-box everywhere except for one place
where it used content-box when setting the override size. Conversely,
it subtracted the borderAndPaddingSize everywhere it grabbed the override
size except for one.

Instead, make the override size override the content-box size.
Converging on using the border-box size would be tricky given RenderTableCell's
tricky management of intrinsic padding.

There is no behavior change except in RenderBox::availableLogicalHeightUsing,
which fixes a table test.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::setOverrideLogicalContentHeight):
(WebCore::RenderBox::setOverrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentWidth):
(WebCore::RenderBox::overrideLogicalContentHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
We were incorrectly subtracting the borderAndPaddingLogicalWidth instead
of the borderAndPaddingLogicalHeight.

* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):

LayoutTests:

* fast/table/padding-height-and-override-height-expected.txt:
* fast/table/padding-height-and-override-height.html:
Tests the change in RenderBox::availableLogicalHeightUsing to correctly subtract the
borderAndPaddingLogicalHeight instead of the borderAndPaddingLogicalWidth.
* platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug131020-expected.txt:
The new results are more correct. The table cell had 2px too much padding-top and padding-bottom before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_AP...
aestes@apple.com [Tue, 5 Jun 2012 18:28:47 +0000 (18:28 +0000)]
REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88296

Reviewed by Dan Bernstein.

refresh() and initPlugins() should call into PluginStrategy even if
ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
plug-ins, so PluginStrategy should be consulted even if Netscape
plug-ins specifically are disabled.

Ports that support platform strategies but not Netscape plug-ins should
handle this inside their PluginStrategy rather than modifying generic
plug-in code.

* plugins/PluginData.cpp:
(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] DumpRenderTree should call resetInternalsObject
jberlin@webkit.org [Tue, 5 Jun 2012 18:23:27 +0000 (18:23 +0000)]
[Win] DumpRenderTree should call resetInternalsObject
https://bugs.webkit.org/show_bug.cgi?id=88346

Reviewed by Simon Fraser.

Invoke it on Windows in the same place it is invoked on Mac.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp/tests/media/remove-while-loading.html times out on mac-lion-wk2
timothy_horton@apple.com [Tue, 5 Jun 2012 18:15:01 +0000 (18:15 +0000)]
http/tests/media/remove-while-loading.html times out on mac-lion-wk2
https://bugs.webkit.org/show_bug.cgi?id=88348

Unreviewed skip of this test for greenness.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Updating test expectations after r119456.
leviw@chromium.org [Tue, 5 Jun 2012 18:13:45 +0000 (18:13 +0000)]
Unreviewed gardening. Updating test expectations after r119456.

* fast/line-grid/line-grid-contains-value-expected.txt: Added.
* platform/chromium-mac-leopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac-leopard/fast/forms/001-expected.png:
* platform/chromium-mac-leopard/fast/inline/inline-box-background-expected.png:
* platform/chromium-mac-leopard/fast/inline/inline-box-background-long-image-expected.png:
* platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-x-expected.png:
* platform/chromium-mac-leopard/fast/inline/inline-box-background-repeat-y-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/001-expected.png:
* platform/chromium-mac-snowleopard/fast/inline/inline-box-background-expected.png:
* platform/chromium-mac-snowleopard/fast/inline/inline-box-background-long-image-expected.png:
* platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-x-expected.png:
* platform/chromium-mac-snowleopard/fast/inline/inline-box-background-repeat-y-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-mac/fast/forms/001-expected.png:
* platform/chromium-mac/fast/forms/001-expected.txt:
* platform/chromium-mac/fast/inline/inline-box-background-expected.png:
* platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
* platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
* platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
* platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.png:
* platform/chromium-mac/fast/line-grid/line-align-left-edges-expected.txt: Added.
* platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.txt: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
* platform/chromium-win/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/chromium-win/fast/line-grid/line-align-left-edges-expected.png:
* platform/chromium-win/fast/line-grid/line-align-left-edges-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-contains-value-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/line-grid: Removed.
* platform/chromium/fast/line-grid/line-align-left-edges-expected.txt: Removed.
* platform/efl/fast/line-grid/line-grid-contains-value-expected.txt: Removed.
* platform/gtk/fast/line-grid/line-grid-contains-value-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when modifying fixed-position elements in a detached frame
commit-queue@webkit.org [Tue, 5 Jun 2012 18:05:26 +0000 (18:05 +0000)]
Crash when modifying fixed-position elements in a detached frame
https://bugs.webkit.org/show_bug.cgi?id=88288

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-05
Reviewed by James Robinson.

Source/WebCore:

Test: fast/block/positioning/fixed-position-detached-frame.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

* fast/block/positioning/fixed-position-detached-frame-expected.txt: Added.
* fast/block/positioning/fixed-position-detached-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll Chromium DEPS from r140492 to r140528.
rniwa@webkit.org [Tue, 5 Jun 2012 17:22:31 +0000 (17:22 +0000)]
Roll Chromium DEPS from r140492 to r140528.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: render timeline paint category dark green
caseq@chromium.org [Tue, 5 Jun 2012 17:12:39 +0000 (17:12 +0000)]
Web Inspector: render timeline paint category dark green
https://bugs.webkit.org/show_bug.cgi?id=88333

Reviewed by Pavel Feldman.

- Added a new, dark-green color for timeline events.

* WebCore.gypi: Added timelineBarDarkGreen.png
* inspector/front-end/Images/timelineBarDarkGreen.png: Added.
* inspector/front-end/Images/timelineCheckmarks.png: Added a dark-green checkbox.
* inspector/front-end/Images/timelineDots.png: Added a dark-green dot.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
* inspector/front-end/WebKit.qrc: Added timelineBarDarkGreen.png.
* inspector/front-end/timelinePanel.css:
(.timeline-category-statusbar-item.timeline-category-painting .timeline-category-checkbox):
(.timeline-category-painting .timeline-graph-bar):
(.popover .timeline-painting):
(.timeline-category-painting .timeline-tree-icon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: serialize edge counts instead of indexes in heap snapshot
loislo@chromium.org [Tue, 5 Jun 2012 17:08:19 +0000 (17:08 +0000)]
Web Inspector: serialize edge counts instead of indexes in heap snapshot
https://bugs.webkit.org/show_bug.cgi?id=88324

The serialized node structure currently holds an index
of its first containment edge in the edges array.
The index can be quite big (up to 7 digits for large snapshots).
The patch changes the serialization format to pass
node containment edge count instead. For most nodes the count
is just a single digit number.
This reduces serialized snapshot size and therefore its transfer time.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-05
Reviewed by Yury Semikhatsky.

PerformanceTests:

* inspector/heap-snapshot-performance-test.js:

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesStart):
(WebInspector.HeapSnapshotNode.prototype._edgeIndexesEnd):
(WebInspector.HeapSnapshotNode.prototype._ordinal):
(WebInspector.HeapSnapshotNodeIterator):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._buildEdgeIndexes):
(WebInspector.HeapSnapshot.prototype._buildRetainers):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):
(WebInspector.HeapSnapshot.prototype._buildPostOrderIndex):
(WebInspector.HeapSnapshot.prototype._buildDominatorTree):
(WebInspector.HeapSnapshot.prototype._markPageOwnedNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

* inspector/profiler/heap-snapshot-expected.txt:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockObject):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockRaw):
(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest.):
* inspector/profiler/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Don't propagate viewport size changes if the viewport is empty.
alexis.menard@openbossa.org [Tue, 5 Jun 2012 16:30:47 +0000 (16:30 +0000)]
[Qt] Don't propagate viewport size changes if the viewport is empty.
https://bugs.webkit.org/show_bug.cgi?id=88336

Reviewed by Tor Arne Vestbø.

Qt Quick sequentially set the x, y, width, height of the view. We really want to
start propagating further when the size of the viewport becomes valid, i.e. both
height and width are defined. In any case lower level classes are discarding an empty
size such as WebPage::sendViewportAttributesChanged() so it was pointless to send the size
through the IPC bus for nothing.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry]Web Inspector highlight is slow
commit-queue@webkit.org [Tue, 5 Jun 2012 16:23:42 +0000 (16:23 +0000)]
[BlackBerry]Web Inspector highlight is slow
https://bugs.webkit.org/show_bug.cgi?id=88331

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-06-05
Reviewed by Rob Buis.

Highlight is slow on large pages because of constant repaint calls.
Change to use the accelerated layer highlight all the time.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):
* WebCoreSupport/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Fix two more memory leaks in DRT
commit-queue@webkit.org [Tue, 5 Jun 2012 16:18:40 +0000 (16:18 +0000)]
[GTK] Fix two more memory leaks in DRT
https://bugs.webkit.org/show_bug.cgi?id=88255

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-05
Reviewed by Martin Robinson.

Fixed memory leaks in GTK's DRT code.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem): webkit_web_history_item_get_target() returns a
g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
* DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
(createBitmapContextFromWebView): Free the cairo surface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] There is no way to retrieve composition character rectangle in WebKit...
commit-queue@webkit.org [Tue, 5 Jun 2012 16:04:50 +0000 (16:04 +0000)]
[chromium] There is no way to retrieve composition character rectangle in WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=87911

Patch by Seigo Nonaka <nona@chromium.org> on 2012-06-05
Reviewed by Ryosuke Niwa.

Add an API for retreieving each character bounds in composition text.
This API is necessary for implementing IMR_QUERYCHARPOSITION message in Windows.
The message is used by Japanese IME for showing their window at the correct position.

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::compositionCharacterBounds):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositionCharacterBounds):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 5 Jun 2012 15:47:15 +0000 (15:47 +0000)]
[GTK] Add webkit_download_get_received_data_length to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=88323

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_get_received_data_length):
* UIProcess/API/gtk/WebKitDownload.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestDownloads.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS 2.1 failure: border-conflict-element-021a
commit-queue@webkit.org [Tue, 5 Jun 2012 15:37:20 +0000 (15:37 +0000)]
CSS 2.1 failure: border-conflict-element-021a
https://bugs.webkit.org/show_bug.cgi?id=86885

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-06-05
Reviewed by Julien Chaffraix.

Source/WebCore:

When two adjacent table row groups (thead, tbody, tfoot) have the same border-width
and the same border-style in a 'border-collapse: collapse' table the color of the border
from the top-most table row wins.

Tests: fast/table/border-collapsing/adjacent-row-groups-multi.html
       fast/table/border-collapsing/adjacent-row-groups.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
Currently each row group is sent for paint from top (firstChild) to bottom thereby causing
the borders of the bottom-most row group (which is painted last) to overlap over the
previous row-group. This breaks the precedence for collapsed borders between adjacent cells.

This fix thus reverses the order in which the row-groups/sections are passed for painting.
Additional change has been done to iterate over the RenderTableSections directly.

(WebCore):
(WebCore::RenderTable::bottomSection):
* rendering/RenderTable.h:
New function has been added to obtain the last section of the table.

(RenderTable):
* rendering/RenderTableSection.h:
(RenderTableSection):
RenderTableSection's paint() method has now been made public so as to make it accessible
from RenderTable.

LayoutTests:

* css2.1/20110323/border-conflict-element-021a-expected.html: Added.
* css2.1/20110323/border-conflict-element-021a.htm: Added.
Added ref test under the css2.1 test-suite for border-conflict-element-021a.

* fast/table/border-collapsing/adjacent-row-groups-expected.html: Added.
* fast/table/border-collapsing/adjacent-row-groups.html: Added.
Added ref test for verifying 'border-collapse: collapse' table rendering when two
adjacent table row-groups have the same border-width and the same border-style. In
such a case the color of the border from the top-most table row-group wins.

* fast/table/border-collapsing/adjacent-row-groups-multi.html: Added.
* fast/table/border-collapsing/adjacent-row-groups-multi-expected.html: Added.
Additional ref test added for verifying 'border-collapse: collapse' table rendering
for adjacent table row-groups when more than one table headers and/or footers are specified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium unreviewed sheriffing: enable blob tests that are passing since r119454.
loislo@chromium.org [Tue, 5 Jun 2012 15:32:45 +0000 (15:32 +0000)]
Chromium unreviewed sheriffing: enable blob tests that are passing since r119454.

* platform/chromium/TestExpectations:
fast/filesystem/file-writer-gc-blob.html
fast/filesystem/workers/file-writer-sync-truncate-extend.html
fast/filesystem/workers/file-writer-gc-blob.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Win] Fix IDL dependency generation
ossy@webkit.org [Tue, 5 Jun 2012 15:26:04 +0000 (15:26 +0000)]
[Qt][Win] Fix IDL dependency generation
https://bugs.webkit.org/show_bug.cgi?id=88304

Reviewed by Tor Arne Vestbø.

* DerivedSources.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r119467, r119471, and r119476.
loislo@chromium.org [Tue, 5 Jun 2012 15:17:29 +0000 (15:17 +0000)]
Unreviewed, rolling out r119467, r119471, and r119476.
http://trac.webkit.org/changeset/119467
http://trac.webkit.org/changeset/119471
http://trac.webkit.org/changeset/119476
https://bugs.webkit.org/show_bug.cgi?id=88332

it broke chromium-mac static initializers test.\ (Requested by
loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-05

Source/WebCore:

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/graphics/FontPlatformData.h:
(FontPlatformData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
* platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Removed.
* platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Removed.
* platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Removed.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Removed.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Removed.
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):

LayoutTests:

* platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Removed.
* platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Building when a top directory is named Source
commit-queue@webkit.org [Tue, 5 Jun 2012 15:13:41 +0000 (15:13 +0000)]
[Qt] Building when a top directory is named Source
https://bugs.webkit.org/show_bug.cgi?id=77727

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-05
Reviewed by Tor Arne Vestbø.

Change regex to only replace the last instance of OUT_PWD.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: SHIFT key as helper to color adjustment in color picker
apavlov@chromium.org [Tue, 5 Jun 2012 15:01:27 +0000 (15:01 +0000)]
Web Inspector: SHIFT key as helper to color adjustment in color picker
https://bugs.webkit.org/show_bug.cgi?id=88319

Reviewed by Pavel Feldman.

With Shift depressed, the dragger in the color picker will snap to the horizontal
or vertical axis while dragging, depending on which axis offset is greater.

* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.colorDragStart):
(WebInspector.Spectrum.colorDrag):
(WebInspector.Spectrum.draggable.move):
(WebInspector.Spectrum.draggable.start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: aggregate all events before first frame into a fake frame
caseq@chromium.org [Tue, 5 Jun 2012 14:50:04 +0000 (14:50 +0000)]
Web Inspector: aggregate all events before first frame into a fake frame
https://bugs.webkit.org/show_bug.cgi?id=88229

- in Timeline's frame mode, start aggregating events by frame even before we get first frame marker.

* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB
charles.wei@torchmobile.com.cn [Tue, 5 Jun 2012 12:27:44 +0000 (12:27 +0000)]
JSC:need to implement Dictionary::getWithUndefinedOrNullCheck for IDB
https://bugs.webkit.org/show_bug.cgi?id=88283

Reviewed by Kentaro Hara.

No new tests, idb not working for JSC yet.

* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getWithUndefinedOrNullCheck):
* bindings/js/Dictionary.h:
(Dictionary):
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::getWithUndefinedOrNullCheck):
(WebCore):
* bindings/js/JSDictionary.h:
(JSDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHit ASSERT when editing attribute value in Element in SVG Document
rwlbuis@webkit.org [Tue, 5 Jun 2012 11:35:30 +0000 (11:35 +0000)]
Hit ASSERT when editing attribute value in Element in SVG Document
https://bugs.webkit.org/show_bug.cgi?id=88179

Reviewed by Pavel Feldman.

Test setting attribute on non HTML element.

* inspector/elements/set-attribute-non-html-expected.txt: Added.
* inspector/elements/set-attribute-non-html.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
commit-queue@webkit.org [Tue, 5 Jun 2012 11:32:22 +0000 (11:32 +0000)]
Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
https://bugs.webkit.org/show_bug.cgi?id=73176

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-06-05
Reviewed by Adam Barth.

Two more APIs are added in Custom Scheme Handler specification.
http://dev.w3.org/html5/spec/Overview.html#custom-handlers
One is 'isProtocolHandlerRegistered' to query whether the specific URL
is registered or not.
The other is 'unregisterProtocolHandler' to remove the registered URL.

.:

* Source/cmake/WebKitFeatures.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
* Source/cmakeconfig.h.cmake: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebCore:

Test: fast/dom/unregister-protocol-handler.html

* Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
* loader/EmptyClients.h: Add prototypes.
(EmptyChromeClient):
(WebCore::EmptyChromeClient::isProtocolHandlerRegistered):
(WebCore::EmptyChromeClient::unregisterProtocolHandler):
* page/ChromeClient.h:
(ChromeClient):
* page/NavigatorRegisterProtocolHandler.cpp:
(WebCore):
(WebCore::customHandlersStateString):
(WebCore::NavigatorRegisterProtocolHandler::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::NavigatorRegisterProtocolHandler::unregisterProtocolHandler): Unregister the registered handler.
* page/NavigatorRegisterProtocolHandler.h:
(NavigatorRegisterProtocolHandler):
* page/NavigatorRegisterProtocolHandler.idl:

Source/WebKit/chromium:

* features.gypi: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::customHandlerDataCreate):
(WebCore::customHandlerDataDelete):
(WebCore::ChromeClientEfl::registerProtocolHandler):
(WebCore):
(WebCore::ChromeClientEfl::isProtocolHandlerRegistered): Query if the handler is registered.
(WebCore::ChromeClientEfl::unregisterProtocolHandler): Unregister the registered handler.
* WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
* ewk/ewk_custom_handler.cpp:
(ewk_custom_handler_is_protocol_handler_registered): Query if the handler is registered.
(ewk_custom_handler_unregister_protocol_handler): Unregister the registered handler.
* ewk/ewk_custom_handler_private.h: Adds private function.
* ewk/ewk_view.h: Adds enumeration.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

Tools:

* Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
* win/tools/vsprops/FeatureDefinesCairo.vsprops: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.

LayoutTests:

* fast/dom/unregister-protocol-handler-expected.txt: Added.
* fast/dom/unregister-protocol-handler.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=88029
morrita@google.com [Tue, 5 Jun 2012 11:28:24 +0000 (11:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=88029
content-element-api.html and shadow-element.html depend on V8.

Reviewed by Kentaro Hara.

Replaced typeof checking with comparison.

* fast/dom/shadow/content-element-api.html:
* fast/dom/shadow/shadow-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL][WK2] WebKit2-EFL does not link with gold linker
commit-queue@webkit.org [Tue, 5 Jun 2012 11:13:14 +0000 (11:13 +0000)]
[EFL][WK2] WebKit2-EFL does not link with gold linker
https://bugs.webkit.org/show_bug.cgi?id=88295

Unreviewed. Fix linking when using gold linker.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-05

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium tests: "Add support for the Blob constructor" [r115582] regressed blob layou...
kinuko@chromium.org [Tue, 5 Jun 2012 10:57:00 +0000 (10:57 +0000)]
Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
https://bugs.webkit.org/show_bug.cgi?id=85174

Reviewed by Kentaro Hara.

Source/WebCore:

This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).

There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception.  (The issue will be addresse in a separate patch.)

Test: fast/files/blob-constructor.html

* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):

LayoutTests:

Changing blob-constructor.html label from CRASH to TEXT.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary constructor of SelectorQueryCache
haraken@chromium.org [Tue, 5 Jun 2012 10:39:59 +0000 (10:39 +0000)]
Remove unnecessary constructor of SelectorQueryCache
https://bugs.webkit.org/show_bug.cgi?id=87942

Reviewed by Ryosuke Niwa.

Per the comment from darin@ (https://bugs.webkit.org/show_bug.cgi?id=87942#c27),
this patch removes an inline constructor that has no arguments.
To have the compiler generate the constructor,
this patch also removes WTF_MAKE_NONCOPYABLE().

No tests. No change in behavior.

* dom/SelectorQuery.h:
(SelectorQueryCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused methods from SelectorQuery.h
haraken@chromium.org [Tue, 5 Jun 2012 10:25:59 +0000 (10:25 +0000)]
Remove unused methods from SelectorQuery.h
https://bugs.webkit.org/show_bug.cgi?id=88289

Reviewed by Antti Koivisto.

This patch removes SelectorDataList::size() and
SelectorDataList::SelectorDataList().
SelectorDataList::size() is not used by anybody.
SelectorDataList::SelectorDataList() can be auto-generated
by a compiler.

No tests. No change in behavior.

* dom/SelectorQuery.cpp:
* dom/SelectorQuery.h:
(SelectorDataList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed test expectations update
bashi@chromium.org [Tue, 5 Jun 2012 09:55:17 +0000 (09:55 +0000)]
[Chromium] Unreviewed test expectations update

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][WK2] Implement API for Geolocation permission requests in the GTK port
mario@webkit.org [Tue, 5 Jun 2012 09:46:21 +0000 (09:46 +0000)]
[GTK][WK2] Implement API for Geolocation permission requests in the GTK port
https://bugs.webkit.org/show_bug.cgi?id=83879

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Added a new kind of permission request for supporting the
Geolocation API in WebKit2GTK+.

New WebKitGeolocationPermissionRequest class, implementing the
WebKitPermissionRequest interface, to enabling client applications
to allow or deny geolocation permission requests.

* GNUmakefile.list.am: Added new files.
* UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp: Added.
(_WebKitGeolocationPermissionRequestPrivate):
(webkitGeolocationPermissionRequestAllow):
(webkitGeolocationPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkit_geolocation_permission_request_init):
(webkitGeolocationPermissionRequestFinalize):
(webkit_geolocation_permission_request_class_init):
(webkitGeolocationPermissionRequestCreate):
* UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h: Added.
(_WebKitGeolocationPermissionRequest):
(_WebKitGeolocationPermissionRequestClass):
* UIProcess/API/gtk/WebKitGeolocationPermissionRequestPrivate.h: Added.

Include WKGeolocationPermissionRequest.h in WebKitPrivate.h, so we
can use it from the new WebKitGeolocationPermissionRequest class.

* UIProcess/API/gtk/WebKitPrivate.h: Added new include.

Implement geolocation permission requests in the UI client.

* UIProcess/API/gtk/WebKitUIClient.cpp:
(decidePolicyForGeolocationPermissionRequest): Create a new
instance of the WebKitGeolocationPermissionRequest class and call
to webkitWebViewMakePermissionRequest().
(attachUIClientToView): Provide an implementation function for
decidePolicyForGeolocationPermissionRequest.
* UIProcess/API/gtk/WebKitWebView.h: Add new element to
WebKitPermissionRequestType enumeration for geolocation requests.
* UIProcess/API/gtk/webkit2.h: Added header file for
WebKitGeolocationPermissionRequest

New unit tests to test allowing and denying permission requests.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPermissionRequests): New test that loads a simple HTML
with JavaScript code requesting the current location.
(beforeAll): Added new test.

Updated documentation files.

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:

Make minibrowser connect to the new 'permission requests' signal
to allow users handle the Geolocation permission requests.

* MiniBrowser/gtk/BrowserWindow.c:
(geolocationRequestDialogCallback): Callback for the dialog asking
the user for allowing or not geolocation permission requests.
(webViewDecidePermissionRequest): Launch a dialog to ask the user
whether to allow or deny geolocation permission requests.
(browserWindowConstructed): Connect to 'permission-request' signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix for r119470.
tkent@chromium.org [Tue, 5 Jun 2012 09:37:41 +0000 (09:37 +0000)]
Build fix for r119470.

* loader/EmptyClients.cpp: Add #include "IntentRequest.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused function: Document::formElements
tkent@chromium.org [Tue, 5 Jun 2012 09:34:35 +0000 (09:34 +0000)]
Remove unused function: Document::formElements
https://bugs.webkit.org/show_bug.cgi?id=88272

Reviewed by Kentaro Hara.

No new tests. No behavior change.

* dom/Document.h:
(Document): remove formElements(). It was used for radio group
validation, but the current code doesn't use it any more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix after r119469.
apavlov@chromium.org [Tue, 5 Jun 2012 09:33:33 +0000 (09:33 +0000)]
Unreviewed, build fix after r119469.

* inspector/styles/lazy-computed-style-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix on Chromium mac
bashi@chromium.org [Tue, 5 Jun 2012 09:28:46 +0000 (09:28 +0000)]
Unreviewed build fix on Chromium mac

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::isAATFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove some function definitions in EmptyClients.h to EmptyClients.cpp
tkent@chromium.org [Tue, 5 Jun 2012 09:08:04 +0000 (09:08 +0000)]
Move some function definitions in EmptyClients.h to EmptyClients.cpp
https://bugs.webkit.org/show_bug.cgi?id=88285

Reviewed by Ryosuke Niwa.

Source/WebCore:

If we have definitions of functions with RefPtr<> in EmptyClients.h like

    virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { }

and a source file includes EmptyClient.h, the source file needs to
include FileChooser.h though the source file doesn't use FileChooser
class explicitly because the definition of runOpenPanel() needs to call
FileChooser::deref().
To avoid this, we had better move such functions to EmptyClients.cpp.

No new tests. No behavior changes.

* loader/EmptyClients.cpp: Move such functions from EmptyClients.h to
here, and move EmptyPopupMenu and EmptySearchPopupMenu too because
they're used only by EmptyChromeClient.
(WebCore):
(EmptyPopupMenu):
(WebCore::EmptyPopupMenu::show):
(WebCore::EmptyPopupMenu::hide):
(WebCore::EmptyPopupMenu::updateFromElement):
(WebCore::EmptyPopupMenu::disconnectClient):
(EmptySearchPopupMenu):
(WebCore::EmptySearchPopupMenu::popupMenu):
(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):
(WebCore::EmptySearchPopupMenu::enabled):
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
(WebCore::EmptyChromeClient::createColorChooser):
(WebCore::EmptyChromeClient::runOpenPanel):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebCore::EmptyFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebCore::EmptyFrameLoaderClient::dispatchWillSubmitForm):
(WebCore::EmptyFrameLoaderClient::createDocumentLoader):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
(WebCore::EmptyFrameLoaderClient::createJavaAppletWidget):
(WebCore::EmptyFrameLoaderClient::createMediaPlayerProxyPlugin):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
(WebCore::EmptyTextCheckerClient::requestCheckingOfString):
(WebCore::EmptyEditorClient::registerUndoStep):
(WebCore::EmptyEditorClient::registerRedoStep):
(WebCore::EmptyContextMenuClient::customizeMenu):
* loader/EmptyClients.h: Move such function definitions to
EmptyClient.cpp, and append OVERRIDE.
(EmptyChromeClient):
(EmptyFrameLoaderClient):
(EmptyTextCheckerClient):
(EmptyEditorClient):
(EmptyContextMenuClient):
* svg/graphics/SVGImage.cpp: Remove unnecessary #includes.

Source/WebKit/chromium:

* src/WebHelperPluginImpl.cpp: Remove unnecessary #includes, and add necessary #includes.
* src/WebPagePopupImpl.cpp: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: "-webkit"-prefixed properties are considered inherited in the Computed...
apavlov@chromium.org [Tue, 5 Jun 2012 08:56:24 +0000 (08:56 +0000)]
Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
https://bugs.webkit.org/show_bug.cgi?id=88257

Reviewed by Pavel Feldman.

Source/WebCore:

Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):

LayoutTests:

* inspector/elements/elements-panel-styles-expected.txt:
* inspector/elements/elements-panel-styles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
noel.gordon@gmail.com [Tue, 5 Jun 2012 08:27:06 +0000 (08:27 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Implement font shaping with font-feature-settings on Mac
bashi@chromium.org [Tue, 5 Jun 2012 08:15:40 +0000 (08:15 +0000)]
[Chromium] Implement font shaping with font-feature-settings on Mac
https://bugs.webkit.org/show_bug.cgi?id=69826

Reviewed by Tony Chang.

Source/WebCore:

Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.

No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.

* WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
* WebCore.gypi: Added harfbuzz-ng files.
* platform/graphics/FontPlatformData.h:
(FontPlatformData): Added m_harfbuzzFace.
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):
* platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.
(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):
* platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.
(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):
* platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.
(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.
(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.
(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

LayoutTests:

Added the expectation for sss3/font-feature-settings-rendering.html.

* platform/chromium-mac/css3/font-feature-settings-rendering-expected.png: Added.
* platform/chromium-mac/css3/font-feature-settings-rendering-expected.txt: Added.
* platform/chromium/TestExpectations: Removed css3/font-feature-settings-rendering.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIETC: FileList.item(-1) should return null instead of raising
commit-queue@webkit.org [Tue, 5 Jun 2012 08:12:59 +0000 (08:12 +0000)]
IETC: FileList.item(-1) should return null instead of raising
https://bugs.webkit.org/show_bug.cgi?id=77899

Patch by Li Yin <li.yin@intel.com> on 2012-06-05
Reviewed by Kentaro Hara.

Source/WebCore:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Accroding to http://es5.github.com/#x9.6
When the index is negative, it should not raise exception.
Firefox and IE returns null when there is not indexth File object.

Test: fast/files/file-list-test.html

* fileapi/FileList.idl:

LayoutTests:

IETC: http://samples.msdn.microsoft.com/ietestcenter/fileapi/filelist.htm
Ref: http://es5.github.com/#x9.6
Some index values have been covered in this test, including negative index,
undefined, null, normal index(0~length-1), more than length index.

* fast/files/file-list-test-expected.txt:
* fast/files/file-list-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEventHandler shouldn't dispatch fake mousemove events when scrolling on devices that...
abarth@webkit.org [Tue, 5 Jun 2012 07:38:56 +0000 (07:38 +0000)]
EventHandler shouldn't dispatch fake mousemove events when scrolling on devices that don't have a mouse
https://bugs.webkit.org/show_bug.cgi?id=88270

Reviewed by James Robinson.

Source/WebCore:

This patch adds a setting analogous to deviceSupportsTouch to determine
whether the device supports mouse. We then don't dispatch fake mouse
events on devices that don't have a mouse in the first place.

Test: fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html

* page/EventHandler.cpp:
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setDeviceSupportsMouse):
(WebCore::Settings::deviceSupportsMouse):
(Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsMouse):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit/chromium:

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setDeviceSupportsMouse):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

LayoutTests:

* fast/events/touch/scroll-without-mouse-lacks-mousemove-events-expected.txt: Added.
* fast/events/touch/scroll-without-mouse-lacks-mousemove-events.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119465 268f45cc-cd09-0410-ab3c-d52691b4dbfc