oliver@apple.com [Sat, 23 Feb 2008 02:04:49 +0000 (02:04 +0000)]
Reviewed by NOBODY (build fix).
Unbreak windows vcproj
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 23 Feb 2008 01:27:17 +0000 (01:27 +0000)]
Fix Qt build.
* Api/qwebhistoryinterface.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 23 Feb 2008 01:16:16 +0000 (01:16 +0000)]
Bug 17486: Support HTML5 Canvas.getImageData API
Support Canvas.getImageData and Canvas.createImageData
Reviewed by Sam W.
This patch adds support for all the pixel reading portions
of the HTML5 Canvas spec. There are two new types ImageData
and CanvasPixelArray which are used to provide the HTML5
ImageData object, and the required semantics for assignment
to the ImageData data array.
We only implement the CG version of ImageBuffer::getImageData,
but the logic is null safe, so this will not introduce any
crashes into other platforms, unfortunately it will result in
JS Object detection "lying" on non-CG platforms.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 23 Feb 2008 00:55:20 +0000 (00:55 +0000)]
WebCore:
Rubber-stamped by Adam Roben.
Rid the project of the Devil known as DeprecatedString!
* GNUmakefile.am:
* WebCore.base.exp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* dom/Node.h:
* html/HTMLFormElement.cpp:
* platform/DeprecatedString.cpp: Removed.
* platform/DeprecatedString.h: Removed.
* platform/graphics/qt/IconQt.cpp:
* platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
* platform/gtk/CookieJarGtk.cpp:
* platform/gtk/CursorGtk.cpp:
* platform/gtk/KeyEventGtk.cpp:
* platform/mac/DeprecatedStringMac.mm: Removed.
* platform/network/qt/ResourceHandleQt.cpp:
* platform/network/win/CookieJarWin.cpp:
(WebCore::cookies):
* platform/qt/ClipboardQt.cpp:
* platform/qt/CookieJarQt.cpp:
* platform/qt/CursorQt.cpp:
* platform/symbian/DeprecatedStringSymbian.cpp: Removed.
* platform/text/AtomicString.cpp:
* platform/text/AtomicString.h:
* platform/text/PlatformString.h:
* platform/text/String.cpp:
* platform/text/StringImpl.cpp:
* platform/text/qt/StringQt.cpp:
(WebCore::String::String):
* platform/text/wx/StringWx.cpp:
* platform/win/BString.cpp:
* platform/win/BString.h:
* platform/win/PasteboardWin.cpp:
WebKit/qt:
Rubber-stamped by Adam Roben.
Rid the project of the Devil known as DeprecatedString!
* Api/qwebhistory.cpp:
* Api/qwebhistoryinterface.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Sat, 23 Feb 2008 00:23:43 +0000 (00:23 +0000)]
2008-02-22 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transformations.
Also corrects an uninitialized variable in the Cairo Windows
image drag handler.
* platform/graphics/cairo/GraphicsContextCairo.cpp: Modify
methods to call GraphicsContextPlatformPrivate calls, just
as is done for the CoreGraphics version. These calls are
nop's for everything but Windows.
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM): Re-enable for Windows
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
* platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
* platform/graphics/win/GraphicsContextCGWin.cpp: Move common
code for handling WorldTransform calls to parent class.
* platform/graphics/win/GraphicsContextCairoWin.cpp: Add common
code for handling WorldTransform calls.
(WebCore::GraphicsContextPlatformPrivate::concatCTM): Change
implementation so that it only handles WorldTransform. The
Cairo update is done in GraphicsContextCairo.cpp
* platform/graphics/win/GraphicsContextWin.cpp: Call platform-private
methods to keep WorldTransform in sync.
(WebCore::GraphicsContextPlatformPrivate::save):
(WebCore::GraphicsContextPlatformPrivate::restore):
(WebCore::GraphicsContextPlatformPrivate::clip):
(WebCore::GraphicsContextPlatformPrivate::scale):
(WebCore::GraphicsContextPlatformPrivate::rotate):
(WebCore::GraphicsContextPlatformPrivate::translate):
* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage): Correct uninitialized value
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 23 Feb 2008 00:16:05 +0000 (00:16 +0000)]
Reviewed by Geoff Garen.
- Remove use of DeprecatedString in CSSStyleSelector.
* css/CSSStyleSelector.cpp:
(WebCore::findHash): Removed. Use find instead.
(WebCore::findSlashDotDotSlash): Changed to take a UChar* and a length.
(WebCore::findSlashSlash): Ditto.
(WebCore::findSlashDotSlash): Ditto.
(WebCore::containsColonSlashSlash): Ditto.
(WebCore::cleanPath): Change to operate on a String.
(WebCore::checkPseudoState): Changed to use a Vector as a buffer.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 22 Feb 2008 23:16:57 +0000 (23:16 +0000)]
Reviewed by Sam Weinig.
Fixed <rdar://problem/5057509> Repro leak of JSXMLHttpRequest and
associated objects @ www.viamichelin.it, which was probably an underlying
cause of <rdar://problem/5744037> Gmail out of memory (17455)
If SubresourceLoader::create returned NULL, we would ref() / gcProtect()
the XMLHttpRequest but think we hadn't, therefore never
calling deref() / gcUnprotect().
This could happen at gmail.com, since gmail.com attempts to send
XMLHttpRequests from unload handlers in order to gather usage statistics.
(According to comments in the code, SubresourceLoader::create returns
NULL when called from an unload handler.)
The solution is to ref() / gcProtect() only if SubresourceLoader::create
doesn't return NULL. This make sense, since we only need to protect the
request as long as it has an outstanding network transaction.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::send):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 22 Feb 2008 23:16:40 +0000 (23:16 +0000)]
JavaScriptCore:
Reviewed by Sam Weinig.
Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)
I'm removing KJS_MEM_LIMIT for the following reasons:
- We have a few reports of KJS_MEM_LIMIT breaking important web
applications, like GMail and Google Reader. (For example, if you
simply open 12 GMail tabs, tab #12 will hit the limit.)
- Firefox has no discernable JS object count limit, so any limit, even
a large one, is a potential compatibility problem.
- KJS_MEM_LIMIT does not protect against malicious memory allocation,
since there are many ways to maliciously allocate memory without
increasing the JS object count.
- KJS_MEM_LIMIT is already mostly broken, since it only aborts the
script that breaches the limit, not any subsequent scripts.
- We've never gotten bug reports about websites that would have
benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of
KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that
needed it.
- Any website that brings you anywhere close to crashing due to the
number of live JS objects will almost certainly put up the "slow
script" dialog at least 20 times beforehand.
* kjs/collector.cpp:
(KJS::Collector::collect):
* kjs/collector.h:
* kjs/nodes.cpp:
(KJS::TryNode::execute):
LayoutTests:
Reviewed by Sam Weinig.
Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.
* fast/js/out-of-memory-expected.txt: Removed.
* fast/js/out-of-memory.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 22 Feb 2008 22:30:57 +0000 (22:30 +0000)]
Reviewed, tweaked and landed by Sam.
- Make RegularExpression operate on Strings instead of DeprecatedStrings.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::isXMLMIMEType): Use string instead of DeprecatedString
to build up the RegularExpression.
* page/Frame.cpp:
(WebCore::createRegExpForLabels): Use String instead of DeprecatedString.
(WebCore::Frame::searchForLabelsAboveCell): Ditto.
(WebCore::Frame::searchForLabelsBeforeElement): Ditto.
(WebCore::Frame::matchLabelsAgainstElement): Ditto.
* page/Frame.h:
* page/mac/FrameMac.mm:
(WebCore::regExpForLabels): Ditto.
(WebCore::Frame::searchForNSLabelsAboveCell): Ditto.
(WebCore::Frame::searchForLabelsBeforeElement): Ditto.
(WebCore::Frame::matchLabelsAgainstElement): Ditto.
* platform/text/RegularExpression.cpp:
(WebCore::RegularExpression::Private::Private):
(WebCore::RegularExpression::Private::compile):
(WebCore::RegularExpression::RegularExpression):
(WebCore::RegularExpression::operator=):
(WebCore::RegularExpression::pattern):
(WebCore::RegularExpression::match):
(WebCore::RegularExpression::search):
(WebCore::RegularExpression::searchRev):
(WebCore::replace): Added.
* platform/text/RegularExpression.h:
Change functions to take Strings as input instead of DeprecatedStrings and
reduce the complexity of the class by removing unneeded globbing support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 22 Feb 2008 22:15:31 +0000 (22:15 +0000)]
2008-02-22 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
<rdar://problem/5760360> REGRESSION(r30376): Crash loading plugin page
during stress test (after only 5 min) - null dereference
Full-frame plug-ins create PluginStream objects without loaders, as the
PluginView receives the loading callbacks. We were trying to call
setDefersLoading on these null pointers.
* plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream): Add null check.
(WebCore::PluginStream::destroyStream): Same.
(WebCore::PluginStream::deliverData): Same.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 22 Feb 2008 21:39:27 +0000 (21:39 +0000)]
Reviewed and tweaked by Jon Honeycutt. Reviewed and landed by Sam.
- Remove uses of DeprecatedString in Windows plugin code.
* plugins/win/PluginPackageWin.cpp:
(WebCore::getVersionInfo): Cleanup formatting.
(WebCore::PluginPackage::freeLibraryTimerFired): Remove un-needed variable name.
(WebCore::PluginPackage::storeFileVersion): Move casts.
(WebCore::PluginPackage::fetchInfo): Use OwnArrayPtr and switch to more efficient
use of Vectors.
(WebCore::PluginPackage::load): Fix whitespace.
(WebCore::PluginPackage::hash): Make the hashCodes const
* plugins/win/PluginViewWin.cpp:
(WebCore::makeURL): Use String instead of DeprecatedString.
(WebCore::parseRFC822HeaderFields): Ditto.
(WebCore::PluginView::handlePost): Ditto.
(WebCore::PluginView::status): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 22 Feb 2008 21:16:18 +0000 (21:16 +0000)]
Reviewed, tweaked and landed by Sam.
- Don't use DeprecatedString in HTMLTokenizer.
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::finish):
* platform/text/PlatformString.h:
(WebCore::find):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 22 Feb 2008 20:58:36 +0000 (20:58 +0000)]
Move hasWebView to WebFrameLoaderClient
I added an m_webFrame member to WebFrameLoaderClient. This is slightly
strange because WebFrame inherits from WebFrameLoaderClient, but this
member will be needed once we remove the inheritance, so we might as
well prepare for that now.
Reviewed by Anders.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a
WebFrame* parameter.
(WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
* WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame
parameter.
* WebFrame.cpp: Removed hasWebView.
(WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor
change.
* WebFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 22 Feb 2008 20:05:46 +0000 (20:05 +0000)]
Reviewed by Adam.
<rdar://problem/5748781>
https://bugs.webkit.org/show_bug.cgi?id=17413
REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
Copy the Java plug-in over to the new location.
* FindSafari/FindSafari.cpp:
(_tmain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 22 Feb 2008 19:53:56 +0000 (19:53 +0000)]
Start to move FrameLoaderClient methods off WebFrame onto a separate class
WebFrame now inherits from a new WebFrameLoaderClient class, which
will gradually assume all FrameLoaderClient responsibilities. Once
that process is complete, WebFrame will no longer inherit from
WebFrameLoaderClient.
In this first patch, I've only moved createDocumentLoader up to the
WebFrameLoaderClient class.
Reviewed by Anders.
* WebCoreSupport/WebFrameLoaderClient.cpp: Added.
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::~WebFrameLoaderClient):
(WebFrameLoaderClient::createDocumentLoader): Moved here from
WebFrame.cpp.
* WebCoreSupport/WebFrameLoaderClient.h: Added.
* WebFrame.cpp: Removed createDocumentLoader implementation.
* WebFrame.h: Changed to inherit from WebFrameLoaderClient.
* WebKit.vcproj/WebKit.vcproj: Added new files to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 22 Feb 2008 19:51:49 +0000 (19:51 +0000)]
Reviewed by Adam.
<rdar://problem/5747325> REGRESSION: HTTP layout tests hang
* DumpRenderTree/win/DumpRenderTree.cpp:
(runTest):
Init the URL request with the correct timeout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 22 Feb 2008 19:07:53 +0000 (19:07 +0000)]
Move FormValuesPropertyBag into its own files
Reviewed by Sam.
* WebCoreSupport/FormValuesPropertyBag.cpp: Added.
(FormValuesPropertyBag::QueryInterface):
(FormValuesPropertyBag::AddRef):
(FormValuesPropertyBag::Release):
(FormValuesPropertyBag::Read):
(FormValuesPropertyBag::Write):
(FormValuesPropertyBag::CountProperties):
(FormValuesPropertyBag::GetPropertyInfo):
(FormValuesPropertyBag::LoadObject):
* WebCoreSupport/FormValuesPropertyBag.h: Added.
(FormValuesPropertyBag::FormValuesPropertyBag):
* WebFrame.cpp: Deleted FormValuesPropertyBag code.
* WebKit.vcproj/WebKit.vcproj: Added new files to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 22 Feb 2008 19:07:40 +0000 (19:07 +0000)]
Remove some unused WebFrame methods
FrameWinClient was deleted back in r22965, but these methods were
never deleted.
Reviewed by Sam.
* WebFrame.cpp:
* WebFrame.h: Made one createFrame overload protected, since it's only
called internally by WebFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 22 Feb 2008 19:06:18 +0000 (19:06 +0000)]
Move Client implementations into a WebCoreSupport directory
Reviewed by Anders.
* WebKit.vcproj/WebKit.vcproj: Updated file paths, and added
WebCoreSupport directory to the include path.
* WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
* WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
* WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
* WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
* WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
* WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
* WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
* WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
* WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
* WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 22 Feb 2008 18:32:12 +0000 (18:32 +0000)]
Reviewed by Adam Roben
Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
pasteAsPlainText: has the same behavior.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
(-[WebHTMLView readSelectionFromPasteboard:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView pasteAsRichText:]):
(-[WebHTMLView paste:]):
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 22 Feb 2008 10:27:12 +0000 (10:27 +0000)]
<rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true)
Reviewed by Alexey P.
Fix yet another case where we incorrectly relied on implicit double
to bool coercion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 22 Feb 2008 07:04:16 +0000 (07:04 +0000)]
Add null check to fix crash in media query code I checked in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 22 Feb 2008 06:10:42 +0000 (06:10 +0000)]
2008-02-21 Alp Toker <alp@atoker.com>
Fix a configure script typo.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 22 Feb 2008 03:35:40 +0000 (03:35 +0000)]
WebCore:
Reviewed by Anders Carlsson.
Fix for <rdar://problem/5757946>
- Parse URLs before checking whether they are javascript: urls
(which require security checks).
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::setValue):
* bindings/js/JSElementCustom.cpp:
(WebCore::allowSettingSrcToJavascriptURL):
* bindings/js/JSHTMLFrameElementCustom.cpp:
(WebCore::allowSettingJavascriptURL):
* bindings/js/JSHTMLIFrameElementCustom.cpp:
(WebCore::JSHTMLIFrameElement::setSrc):
LayoutTests:
Reviewed by Anders Carlsson.
Update tests and results for <rdar://problem/5757946>
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
* http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adachan@apple.com [Fri, 22 Feb 2008 01:07:35 +0000 (01:07 +0000)]
<rdar://problem/5757873> Buffer overrun in DeprecatedCString::find() in WebCore
We could get a buffer overrun in DeprecatedCString::find() if the end of the
string matches a beginning portion of the substring, for example, if string is
"a" but the substring is "ab".
The code as is also will not match things correctly under certain situations
since the inner while loop increments the index. For example, we wouldn't find
a match if the string is "aab..." and the substring is "ab". Changed the
inner while loop to increment a temporary index into str.
Test: fast/loader/charset-parse.html
Reviewed by Dan Berstein.
* platform/DeprecatedCString.cpp:
(WebCore::DeprecatedCString::find):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 22 Feb 2008 00:15:12 +0000 (00:15 +0000)]
Add test case for viewport media queries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 22 Feb 2008 00:14:47 +0000 (00:14 +0000)]
Fix for bug 17301. CSS media queries need to use the correct viewport
when contained in documents inside iframes (rather than always using the
top-level document's viewport). CSS media queries based on the viewport
also needed to be dynamic and update as you resize the window (this is
a HOT feature). :)
This patch gets Acid3 up to 86/100 with 3 colored boxes filled in.
Reviewed by olliej
Added fast/media/viewport-media-query.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):
(WebCore::CSSStyleSelector::affectedByViewportChange):
* css/CSSStyleSelector.h:
(WebCore::MediaQueryResult::MediaQueryResult):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator):
(WebCore::MediaQueryEvaluator::eval):
(WebCore::colorMediaFeatureEval):
(WebCore::monochromeMediaFeatureEval):
(WebCore::device_aspect_ratioMediaFeatureEval):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::gridMediaFeatureEval):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::min_colorMediaFeatureEval):
(WebCore::max_colorMediaFeatureEval):
(WebCore::min_monochromeMediaFeatureEval):
(WebCore::max_monochromeMediaFeatureEval):
(WebCore::min_device_aspect_ratioMediaFeatureEval):
(WebCore::max_device_aspect_ratioMediaFeatureEval):
(WebCore::min_device_pixel_ratioMediaFeatureEval):
(WebCore::max_device_pixel_ratioMediaFeatureEval):
(WebCore::min_heightMediaFeatureEval):
(WebCore::max_heightMediaFeatureEval):
(WebCore::min_widthMediaFeatureEval):
(WebCore::max_widthMediaFeatureEval):
(WebCore::min_device_heightMediaFeatureEval):
(WebCore::max_device_heightMediaFeatureEval):
(WebCore::min_device_widthMediaFeatureEval):
(WebCore::max_device_widthMediaFeatureEval):
* css/MediaQueryEvaluator.h:
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::~MediaQueryExp):
* css/MediaQueryExp.h:
(WebCore::MediaQueryExp::value):
(WebCore::MediaQueryExp::isViewportDependent):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pickMedia):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 21 Feb 2008 21:23:08 +0000 (21:23 +0000)]
WebCore:
Reviewed by Sam.
Make more classes start out with a refcount of 1.
* dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
(WebCore::QualifiedName::QualifiedName):
* dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedNameImpl::create):
(WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
* history/BackForwardList.cpp:
(WebCore::BackForwardList::BackForwardList):
* history/BackForwardList.h:
(WebCore::BackForwardList::create):
* page/Page.cpp:
(WebCore::Page::Page):
* platform/text/CString.cpp:
(WebCore::CString::init):
(WebCore::CString::newUninitialized):
(WebCore::CString::copyBufferIfNeeded):
* platform/text/CString.h:
(WebCore::CStringBuffer::create):
(WebCore::CStringBuffer::CStringBuffer):
WebKit/mac:
Reviewed by Sam.
Use BackForwardList::create instead.
* History/WebBackForwardList.mm:
(-[WebBackForwardList init]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Thu, 21 Feb 2008 21:21:23 +0000 (21:21 +0000)]
wx build fix for the domString() -> string() rename in r30443.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Thu, 21 Feb 2008 20:35:16 +0000 (20:35 +0000)]
Reviewed by Jessica Kahn
support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
(-[WebHTMLView readSelectionFromPasteboard:]):
pass NO for new matchStyle parameter to match old behavior
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
validate pasteAndMatchStyle the same way as pasteAsRichText
(-[WebHTMLView pasteAndMatchStyle:]):
just like pasteAsRichText but passes YES for matchStyle
(-[WebHTMLView pasteAsRichText:]):
pass NO for new matchStyle parameter to match old behavior
(-[WebHTMLView paste:]):
ditto
* WebView/WebView.mm:
added macro(pasteAndMatchStyle)
* WebView/WebViewPrivate.h:
added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 21 Feb 2008 20:16:43 +0000 (20:16 +0000)]
2008-02-21 Alp Toker <alp@atoker.com>
GTK+/autotools SVG experimental build fix
Don't enable SVG filters in --enable-svg-experimental.
This feature isn't supported at all yet. Developers can enable it
explicitly by passing --enable-svg-filters if needed.
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 21 Feb 2008 20:10:00 +0000 (20:10 +0000)]
Reviewed by Sam Weinig.
<rdar://problem/5753789>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)
Ensure all versions of allowsAccessFrom are inlined to single functions.
This is a 2% win in browser hosted Sunspider.
* bindings/js/kjs_window.cpp:
(KJS::Window::allowsAccessFrom):
(KJS::Window::allowsAccessFromPrivate):
* bindings/js/kjs_window.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 21 Feb 2008 19:59:40 +0000 (19:59 +0000)]
Reviewed by Sam Weinig.
- minor cleanup
* rendering/bidi.cpp:
(WebCore::bidiNext): Removed redundant isBR() check -- isText() returns
true for RenderLineBreak.
(WebCore::bidiFirst): Ditto.
(WebCore::shouldSkipWhitespaceAfterStartObject):
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Thu, 21 Feb 2008 19:43:44 +0000 (19:43 +0000)]
2008-02-21 Mike Auty <mike.auty@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=17445
[GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
The GNUmakefile.am files make use of the LDFLAGS variable to include library
additions such as -ljpeg etc. Unfortunately, if these inclusions aren't made
in LIBADD/LDADD variables, then they are mis-ordered during the linking.
The as-needed flag discards libraries whose functions have not been needed by
earlier libraries, which therefore makes the ordering important.
This moves all -l library inclusion statements from LDFLAGS variables to
LIBADD/LDADD variables.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 21 Feb 2008 18:09:48 +0000 (18:09 +0000)]
WebCore:
Reviewed by David Harrison.
Fixed <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
Test: fast/dom/script-element-without-frame-crash.html
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag): Added back a NULL check that was
accidentally removed in r30325.
LayoutTests:
Reviewed by David Harrison.
Test for <rdar://problem/5756125> REGRESSION: A crash occurs at
WebCore::Frame::scriptProxy() when completing a search with Package Tracker widget
* fast/dom/script-element-without-frame-crash-expected.txt: Added.
* fast/dom/script-element-without-frame-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 21 Feb 2008 17:30:01 +0000 (17:30 +0000)]
2008-02-21 Rodney Dawes <dobey@wayofthemonkey.com>
GTK+ build fix. s/domString()/string()/
* platform/graphics/gtk/FontPlatformDataGtk.cpp:
(FontPlatformData::FontPlatformData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 07:54:57 +0000 (07:54 +0000)]
Rubber-stamped by Dan Bernstein.
Gratuitous change to this test to use the instanceof operator
instead of the isPrototypeOf method.
* fast/tokenizer/doctype-search-reset.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 21 Feb 2008 07:38:13 +0000 (07:38 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17465
REGRESSION: <DIV> tokenized into Div if still searching for DOCTYPE
Test: fast/tokenizer/doctype-search-reset.html
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17465
REGRESSION: <DIV> tokenized into Div if still searching for DOCTYPE
* fast/tokenizer/doctype-search-reset-expected.txt: Added.
* fast/tokenizer/doctype-search-reset.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 21 Feb 2008 05:00:10 +0000 (05:00 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=17464
REGRESSION: Crash in RenderBlock::findNextLineBreak reading r30444 commit email in GMail
Test: fast/text/wbr-in-pre-crash.html
* rendering/bidi.cpp:
(WebCore::RenderBlock::findNextLineBreak):
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=17464
REGRESSION: Crash in RenderBlock::findNextLineBreak reading r30444 commit email in GMail
* fast/text/wbr-in-pre-crash.html: Added.
* platform/mac-leopard/fast/text/wbr-in-pre-crash-expected.checksum: Added.
* platform/mac-leopard/fast/text/wbr-in-pre-crash-expected.png: Added.
* platform/mac/fast/text/wbr-in-pre-crash-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 04:50:47 +0000 (04:50 +0000)]
JavaScriptCore:
Reviewed by Darin.
Fix for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
The set values result in NaN now when called with no args, NaN or +/- inf values.
The setYear, setFullYear and setUTCFullYear methods used on NaN dates work as
descripted in the standard.
* kjs/date_object.cpp:
(KJS::fillStructuresUsingTimeArgs):
(KJS::fillStructuresUsingDateArgs):
(KJS::setNewValueFromTimeArgs):
(KJS::setNewValueFromDateArgs):
(KJS::dateProtoFuncSetYear):
LayoutTests:
Reviewed by Darin.
- test for Bug 16753: date set methods with no args should result in NaN (Acid3 bug)
* fast/js/date-set-to-nan-expected.txt: Added.
* fast/js/date-set-to-nan.html: Added.
* fast/js/resources/date-set-to-nan.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 21 Feb 2008 04:24:35 +0000 (04:24 +0000)]
Bug 17303: Canvas crash in ImageBuffer
Reviewed by Hyatt.
We handle a null GraphicsContext everywhere, but we weren't checking for
a null ImageBuffer, which is what will result in a null GraphicsContext in
the first place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 21 Feb 2008 04:06:27 +0000 (04:06 +0000)]
Land new results for a layout test that now passes now that dynamic media lists work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 21 Feb 2008 04:05:37 +0000 (04:05 +0000)]
Fix the layout test failure that never should have passed in the first
place by making changes to media lists actually result in the recomputation
of the style selector. Now it passes for the right reasons and not because
of dumb luck.
Reviewed by Sam Weinig
* css/MediaList.cpp:
(WebCore::MediaList::deleteMedium):
(WebCore::MediaList::setMediaText):
(WebCore::MediaList::appendMedium):
(WebCore::MediaList::notifyChanged):
* css/MediaList.h:
* dom/Document.cpp:
(WebCore::Document::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 04:00:46 +0000 (04:00 +0000)]
Reviewed, tweaked and landed by Sam.
- make markup functions not use DeprecatedString.
* editing/markup.cpp:
(WebCore::append): Added.
(WebCore::escapeContentText): Build up string using a Vector.
(WebCore::appendStartMarkup): Use String instead of DeprecatedString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 03:57:22 +0000 (03:57 +0000)]
Fix changelog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 03:54:53 +0000 (03:54 +0000)]
Reviewed, tweaked and landed by Sam.
- make HTMLInterchange return a String instead of a DeprecatedString
* editing/TextIterator.cpp:
(WebCore::CharacterIterator::string): Build up the String using a
Vector.
(WebCore::WordAwareIterator::advance): Switch to using Vector functions.
(WebCore::WordAwareIterator::length): Ditto.
(WebCore::WordAwareIterator::characters): Ditto.
* editing/TextIterator.h: Use a Vector<UChar> for the buffer instead
of DeprecatedString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 21 Feb 2008 03:42:35 +0000 (03:42 +0000)]
Reviewed, tweaked and landed by Sam.
- make HTMLInterchange return a String instead of a DeprecatedString
* editing/HTMLInterchange.cpp:
(WebCore::): Return a String from convertedSpaceString.
(WebCore::convertHTMLTextToInterchangeFormat): Use a Vector instead of
a DeprecatedString to build up the return String.
* editing/HTMLInterchange.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 21 Feb 2008 03:38:04 +0000 (03:38 +0000)]
Reviewed by Oliver.
Remove m_drawingContext and change m_data to m_imageBuffer
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::createImageBuffer):
(WebCore::HTMLCanvasElement::buffer):
(WebCore::HTMLCanvasElement::createPlatformImage):
* html/HTMLCanvasElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:26:00 +0000 (02:26 +0000)]
2008-02-20 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Alp.
- http://bugs.webkit.org/show_bug.cgi?id=17428
Reenable a Windows-based launcher
This patch reenables the venerable Spinneret application,
changing its name to match the other lanch applications.
* WinLauncher: Added.
* WinLauncher/WinLauncher.cpp: Added.
(WinLauncherWebHost::updateAddressBar):
(WinLauncherWebHost::QueryInterface):
(WinLauncherWebHost::AddRef):
(WinLauncherWebHost::Release):
(resizeSubViews):
(_tWinMain):
(MyRegisterClass):
(InitInstance):
(WndProc):
(MyEditProc):
(About):
(loadURL):
* WinLauncher/WinLauncher.h: Added.
(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):
* WinLauncher/WinLauncher.ico: Added.
* WinLauncher/WinLauncher.rc: Added.
* WinLauncher/WinLauncher.vcproj: Added.
* WinLauncher/resource.h: Added.
* WinLauncher/small.ico: Added.
* WinLauncher/stdafx.cpp: Added.
* WinLauncher/stdafx.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 21 Feb 2008 02:17:30 +0000 (02:17 +0000)]
Reviewed by Sam.
Rename AtomicString::domString() to AtomicString::string().
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::getFontData):
* dom/Attr.cpp:
(WebCore::Attr::createTextChild):
* dom/Comment.cpp:
(WebCore::Comment::nodeName):
* dom/Document.cpp:
(WebCore::Document::recalcStyleSelector):
(WebCore::Document::setHTMLWindowEventListener):
(WebCore::Document::formElementsState):
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute):
* dom/Text.cpp:
(WebCore::Text::nodeName):
* editing/SelectionController.cpp:
(WebCore::SelectionController::debugRenderer):
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::nodeName):
(WebCore::HTMLElement::setHTMLEventListener):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::getNamedFormItem):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute):
(WebCore::HTMLImageElement::isURLAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute):
(WebCore::HTMLLinkElement::tokenizeRelAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isURLAttribute):
(WebCore::HTMLObjectElement::containsJavaApplet):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLAttribute):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleIsindex):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedIntoDocument):
(WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseMappedAttribute):
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::parseTag):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addViewSourceToken):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::saveDocumentState):
* page/FrameTree.cpp:
(WebCore::FrameTree::uniqueChildName):
* platform/text/AtomicString.h:
(WebCore::AtomicString::string):
(WebCore::AtomicString::contains):
(WebCore::AtomicString::find):
(WebCore::AtomicString::startsWith):
(WebCore::AtomicString::endsWith):
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::updateWidget):
* svg/SVGElement.cpp:
(WebCore::SVGElement::addSVGEventListener):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::addSVGWindowEventListener):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunLocalName::evaluate):
(WebCore::XPath::FunNamespaceURI::evaluate):
(WebCore::XPath::FunName::evaluate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:12:09 +0000 (02:12 +0000)]
Remove stray conflict marker
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:10:56 +0000 (02:10 +0000)]
2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Dan.
http://bugs.webkit.org/show_bug.cgi?id=17336
Provide implementations for Windows (Cairo) build of WebKit that
handles font formatting.
- Split font implementation files to allow maximal code sharing
between CG and Cairo back-ends.
* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/SimpleFontData.h: Add signatures for private win
initialization functions.
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::platformInit):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCairoWin.cpp: Removed. Universal version
is now part of platform/graphics/cairo.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp: Added.
(WebCore::FontCustomPlatformDataCairo::~FontCustomPlatformDataCairo):
(WebCore::FontCustomPlatformDataCairo::fontPlatformData):
(WebCore::releaseData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/win/FontCustomPlatformDataCairo.h: Added.
(WebCore::FontCustomPlatformDataCairo::FontCustomPlatformDataCairo):
* platform/graphics/win/FontPlatformData.h:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::fontFace):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::operator==):
* platform/graphics/win/FontPlatformDataCGWin.cpp: Copied from WebCore/platform/graphics/win/FontPlatformDataWin.cpp.
(WebCore::FontPlatformData::platformDataInit):
* platform/graphics/win/FontPlatformDataCairoWin.cpp: Added.
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
* platform/graphics/win/FontPlatformDataWin.cpp: Moved CG-specific
code to FontPlatformDataCG.cpp.
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
(WebCore::GlyphPage::fill):
* platform/graphics/win/GlyphPageTreeNodeWin.cpp: Removed. Replaced
with CG- and Cairo-specific versions.
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::setFont):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformCommonDestroy):
(WebCore::SimpleFontData::widthForGDIGlyph):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 21 Feb 2008 02:03:59 +0000 (02:03 +0000)]
Reviewed by Sam.
* dom/Node.h: Took out unneeded forward declaration of TextStream.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 21 Feb 2008 02:01:12 +0000 (02:01 +0000)]
Reviewed by Sam.
* rendering/RenderObject.h: Took out unneeded forward declaration of TextStream.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 21 Feb 2008 01:59:14 +0000 (01:59 +0000)]
Fix for bug 16760, incorrect <object> MIME type handling and fallback
handling.
Reviewed by darin
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
If the image had an error, make sure to do <object> fallback.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
Before doing fallback check if there is a MIME type mismatch between
an image type and a non-image type. If so, detach and re-attach after
storing the correct MIME type.
* loader/loader.cpp:
(WebCore::Loader::didReceiveData):
Consider it an error when a 404 is encountered on a CachedResource load.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 21 Feb 2008 01:41:14 +0000 (01:41 +0000)]
Reviewed by Sam.
StringImpl constructors used by AtomicString should start with a refcount of 1.
* platform/text/AtomicString.cpp:
(WebCore::AtomicString::add):
* platform/text/AtomicString.h:
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 21 Feb 2008 01:06:56 +0000 (01:06 +0000)]
* bindings/js/kjs_navigator.cpp:
(WebCore::needsYouTubeQuirk): Tweak comments.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 20 Feb 2008 23:54:37 +0000 (23:54 +0000)]
Reviewed by Darin.
Change all refcounted classes in page/ to start with a refcount of 1.
* page/BarInfo.cpp:
(WebCore::BarInfo::BarInfo):
* page/BarInfo.h:
(WebCore::BarInfo::create):
* page/Console.cpp:
(WebCore::Console::Console):
* page/Console.h:
(WebCore::Console::create):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
* page/DOMSelection.h:
(WebCore::DOMSelection::create):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::getSelection):
* page/DOMWindow.h:
(WebCore::DOMWindow::create):
* page/Frame.cpp:
(WebCore::Frame::domWindow):
* page/History.cpp:
(WebCore::History::History):
* page/History.h:
(WebCore::History::create):
* page/InspectorController.cpp:
(WebCore::InspectorResource::create):
(WebCore::InspectorResource::InspectorResource):
(WebCore::InspectorDatabaseResource::create):
(WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
(WebCore::InspectorController::didLoadResourceFromMemoryCache):
(WebCore::InspectorController::identifierForInitialRequest):
(WebCore::InspectorController::didOpenDatabase):
* page/Plugin.h:
(WebCore::Plugin::create):
(WebCore::Plugin::Plugin):
* page/Screen.cpp:
(WebCore::Screen::Screen):
* page/Screen.h:
(WebCore::Screen::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 20 Feb 2008 23:04:40 +0000 (23:04 +0000)]
WebCore:
Reviewed by Darin and Geoff.
- <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
* WebCore.base.exp: Updated.
* bindings/js/kjs_navigator.cpp:
(WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed.
(WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk
return true, then return the empty string.
* page/Settings.cpp:
(WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false.
(WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
* page/Settings.h: Added m_needsSiteSpecificQuirks.
(WebCore::Settings::needsSiteSpecificQuirks): Added.
WebKit/mac:
Reviewed by Darin and Geoff.
- WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
There are currently no site-specific quirks on Mac, but we will propagate the state
to WebCore to avoid possible mistakes later.
WebKit/win:
Reviewed by Darin and Geoff.
- WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
* WebView.cpp:
(WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
(WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
after you disable the site-specific hacks they persist until you open a new window or tweak
some other preference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 20 Feb 2008 22:57:03 +0000 (22:57 +0000)]
Land additional doctype piece. toString fix of doctype.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 20 Feb 2008 22:47:57 +0000 (22:47 +0000)]
Fix for bug 12751, doctype nodes aren't part of the Document (Acid3).
Reviewed by Sam Weinig
Many tests added in fast/doctypes.
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::setDocType):
(WebCore::Document::attach):
(WebCore::Document::getImageMap):
* dom/Document.h:
(WebCore::Document::doctype):
(WebCore::Document::):
(WebCore::Document::determineParseMode):
(WebCore::Document::setParseMode):
(WebCore::Document::parseMode):
(WebCore::Document::inCompatMode):
(WebCore::Document::inAlmostStrictMode):
(WebCore::Document::inStrictMode):
* dom/DocumentType.cpp:
(WebCore::DocumentType::cloneNode):
(WebCore::DocumentType::insertedIntoDocument):
(WebCore::DocumentType::removedFromDocument):
* dom/DocumentType.h:
* dom/Node.cpp:
(WebCore::Node::childAllowed):
* dom/StyledElement.cpp:
(WebCore::StyledElement::attributeChanged):
* dom/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::internalSubset):
(WebCore::):
* editing/markup.cpp:
(WebCore::appendStartMarkup):
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::createRenderer):
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
(WebCore::HTMLDocument::childAllowed):
(WebCore::HTMLDocument::determineParseMode):
* html/HTMLDocument.h:
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::parseMappedAttribute):
* html/HTMLParser.cpp:
(WebCore::HTMLParser::parseDoctypeToken):
* html/HTMLParser.h:
* html/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::parseDoctype):
(WebCore::HTMLTokenizer::parseTag):
(WebCore::HTMLTokenizer::write):
(WebCore::HTMLTokenizer::finish):
(WebCore::HTMLTokenizer::processDoctypeToken):
* html/HTMLTokenizer.h:
(WebCore::):
(WebCore::DoctypeToken::DoctypeToken):
(WebCore::DoctypeToken::reset):
(WebCore::DoctypeToken::state):
(WebCore::DoctypeToken::setState):
(WebCore::HTMLTokenizer::State::inDoctype):
(WebCore::HTMLTokenizer::State::setInDoctype):
(WebCore::HTMLTokenizer::State::needsSpecialWriteHandling):
(WebCore::HTMLTokenizer::State::):
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addViewSourceToken):
(WebCore::HTMLViewSourceDocument::addViewSourceDoctypeToken):
* html/HTMLViewSourceDocument.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::write):
(WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
* page/Frame.cpp:
(WebCore::Frame::documentTypeString):
* page/inspector/utilities.js:
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 20 Feb 2008 22:28:42 +0000 (22:28 +0000)]
Reviewed by Darin.
Change most SVG related classes to start out with a ref count of 1.
* bindings/js/JSSVGPointListCustom.cpp:
(WebCore::JSSVGPointList::initialize):
(WebCore::JSSVGPointList::insertItemBefore):
(WebCore::JSSVGPointList::replaceItem):
(WebCore::JSSVGPointList::appendItem):
* bindings/js/JSSVGTransformListCustom.cpp:
(WebCore::JSSVGTransformList::initialize):
(WebCore::JSSVGTransformList::insertItemBefore):
(WebCore::JSSVGTransformList::replaceItem):
(WebCore::JSSVGTransformList::appendItem):
* rendering/SVGCharacterLayoutInfo.h:
(WebCore::SVGCharOnPath::create):
(WebCore::SVGCharOnPath::SVGCharOnPath):
* rendering/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseBeginOrEndValue):
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::canvasResource):
* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::childNodes):
* svg/SVGElementInstanceList.cpp:
(WebCore::SVGElementInstanceList::SVGElementInstanceList):
* svg/SVGElementInstanceList.h:
(WebCore::SVGElementInstanceList::create):
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::SVGFitToViewBox):
* svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::canvasResource):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
* svg/SVGLengthList.h:
(WebCore::SVGLengthList::create):
* svg/SVGList.h:
(WebCore::SVGList::SVGList):
(WebCore::SVGPODListItem::create):
(WebCore::SVGPODListItem::copy):
(WebCore::SVGPODListItem::SVGPODListItem):
(WebCore::SVGPODList::initialize):
(WebCore::SVGPODList::insertItemBefore):
(WebCore::SVGPODList::replaceItem):
(WebCore::SVGPODList::appendItem):
(WebCore::SVGPODList::SVGPODList):
* svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::canvasResource):
* svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::canvasResource):
* svg/SVGNumberList.h:
(WebCore::SVGNumberList::create):
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::createSVGPathSegClosePath):
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
(WebCore::SVGPathElement::createSVGPathSegMovetoRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathElement::createSVGPathSegArcAbs):
(WebCore::SVGPathElement::createSVGPathSegArcRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathElement::pathSegList):
* svg/SVGPathElement.h:
* svg/SVGPathSeg.h:
(WebCore::SVGPathSeg::SVGPathSeg):
* svg/SVGPathSegArc.h:
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcRel::create):
* svg/SVGPathSegClosePath.h:
(WebCore::SVGPathSegClosePath::create):
* svg/SVGPathSegCurvetoCubic.h:
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicRel::create):
* svg/SVGPathSegCurvetoCubicSmooth.h:
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
* svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
* svg/SVGPathSegCurvetoQuadraticSmooth.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
* svg/SVGPathSegLineto.h:
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoRel::create):
* svg/SVGPathSegLinetoHorizontal.h:
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalRel::create):
* svg/SVGPathSegLinetoVertical.h:
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalRel::create):
* svg/SVGPathSegList.h:
(WebCore::SVGPathSegList::create):
* svg/SVGPathSegMoveto.h:
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoRel::create):
* svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::canvasResource):
* svg/SVGPointList.h:
(WebCore::SVGPointList::create):
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::points):
* svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
* svg/SVGPreserveAspectRatio.h:
(WebCore::SVGPreserveAspectRatio::create):
* svg/SVGRenderingIntent.h:
(WebCore::SVGRenderingIntent::SVGRenderingIntent):
* svg/SVGStringList.h:
(WebCore::SVGStringList::create):
* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
* svg/SVGTests.cpp:
(WebCore::SVGTests::requiredFeatures):
(WebCore::SVGTests::requiredExtensions):
(WebCore::SVGTests::systemLanguage):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
* svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
* svg/SVGTransformList.h:
(WebCore::SVGTransformList::create):
* svg/SVGUnitTypes.h:
(WebCore::SVGUnitTypes::SVGUnitTypes):
* svg/SVGViewElement.cpp:
(WebCore::SVGViewElement::viewTarget):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::SVGViewSpec):
* svg/graphics/SVGPaintServer.cpp:
(WebCore::SVGPaintServer::sharedSolidPaintServer):
* svg/graphics/SVGPaintServer.h:
* svg/graphics/SVGPaintServerGradient.h:
(WebCore::SVGPaintServerGradient::SharedStopCache::create):
(WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
* svg/graphics/SVGPaintServerLinearGradient.h:
(WebCore::SVGPaintServerLinearGradient::create):
* svg/graphics/SVGPaintServerPattern.h:
(WebCore::SVGPaintServerPattern::create):
* svg/graphics/SVGPaintServerRadialGradient.h:
(WebCore::SVGPaintServerRadialGradient::create):
* svg/graphics/SVGPaintServerSolid.h:
(WebCore::SVGPaintServerSolid::create):
* svg/graphics/SVGResource.cpp:
(WebCore::SVGResource::SVGResource):
* svg/graphics/SVGResource.h:
* svg/graphics/SVGResourceClipper.h:
(WebCore::SVGResourceClipper::create):
* svg/graphics/SVGResourceMarker.h:
(WebCore::SVGResourceMarker::create):
* svg/graphics/SVGResourceMasker.h:
(WebCore::SVGResourceMasker::create):
* svg/graphics/cg/SVGPaintServerGradientCg.cpp:
(WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 20 Feb 2008 21:36:34 +0000 (21:36 +0000)]
Reviewed by Sam.
- make conversion from CSS ParseString to String and AtomicString
automatic and remove all the explicit calls to do the conversion
- fix CSS parsing to do fewer allocations, mostly by using the
equalIgnoringCase function in CSSParser
* css/CSSGrammar.y: Take out all the explicit atomicString and
domString calls now that ParseString knows how to convert itself.
* css/CSSParser.cpp:
(WebCore::equal): Added.
(WebCore::equalIgnoringCase): Allow non-lettters.
(WebCore::ParseString::lower): Used charactersAreAllASCII.
(WebCore::unitFromString): Use equal.
(WebCore::CSSParser::parseValue): Removed unneeded call to domString.
(WebCore::CSSParser::parseContent): Use equalIgnoringCase.
(WebCore::CSSParser::parseBackgroundImage): Removed unneeded call to domString.
(WebCore::CSSParser::parseTransitionTimingFunction): Use equalIgnoringCase.
(WebCore::CSSParser::parseDashboardRegions): More of the same.
(WebCore::CSSParser::parseCounterContent): Ditto.
(WebCore::CSSParser::parseShape): Use equalIgnoringCase.
(WebCore::CSSParser::parseFontFamily): Removed unneeded calls to domString.
(WebCore::CSSParser::parseFontFaceSrc): More.
(WebCore::CSSParser::parseFontFaceUnicodeRange): More.
(WebCore::CSSParser::parseColor): Don't lowercase here -- setNamedColor now
handles the case folding.
(WebCore::CSSParser::parseColorFromValue): More.
(WebCore::CSSParser::parseBorderImage): More.
(WebCore::CSSParser::parseCounter): More.
(WebCore::TransformOperationInfo::TransformOperationInfo): More.
(WebCore::CSSParser::parseTransform): More.
(WebCore::CSSParser::createCharsetRule): More.
(WebCore::CSSParser::createImportRule): More.
* css/CSSParser.h: Removed domString and atomicString functions.
(WebCore::ParseString::operator String): Added. Allows conversion to String
without an explicit function call.
(WebCore::ParseString::operator AtomicString): Ditto.
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::MediaQueryExp): Removed a call to domString.
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue): Removed calls to domString.
* platform/graphics/Color.cpp:
(WebCore::findNamedColor): Call toASCIILower on each character as we copy
it into the 8-bit character buffer to make the operation fold case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 20 Feb 2008 21:03:48 +0000 (21:03 +0000)]
Fix a bug in this SVG test harness. Make sure it uses document.documentElement instead of document.firstChild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Wed, 20 Feb 2008 17:48:44 +0000 (17:48 +0000)]
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd): The common case here
is where there are no special elements. Avoid creating VisiblePositions in
that case. Additionally, this change postpones the more expensive creation
of an upstream VisiblePosition until the last possible moment.
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Add an
early return for a common case: deleting characters that are all inside the
same text node. In that case the style at the start of the selection will
not change during the delete, so there is no need to save/recompute it.
(WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Early return
before VisiblePosition creation if the ends of the selection aren't enclosed
by an anchor.
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::markMisspellingsAfterTyping): Early return if spell
checking isn't enabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 20 Feb 2008 12:35:15 +0000 (12:35 +0000)]
Incorporates some improvements made by Dan Bernstein.
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=17106
<rdar://problem/5750722> Debug build ASSERTs on page load
Test: fast/encoding/GBK/close-gbk-converter.html
* platform/text/TextCodecICU.cpp:
(WebCore::getGbkEscape): Changed to use a switch instead of a HashMap, as there
are only four values.
(WebCore::gbkCallbackEscape): Check the reason why the function is called, and do not attempt
getting an escape character if it's not UCNV_UNASSIGNED.
(WebCore::gbkCallbackSubstitute): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 20 Feb 2008 11:39:40 +0000 (11:39 +0000)]
Build fix.
* xml/XMLHttpRequest.cpp:
(WebCore::isSafeRequestHeader):
(WebCore::XMLHttpRequest::setRequestHeader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 20 Feb 2008 11:10:30 +0000 (11:10 +0000)]
Reviewed by Darin.
<rdar://problem/5749455> Unable to set the Referer header in Dashboard using XMLHttpRequest
Cannot be tested in DRT.
* xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Assume that a request that can load
local files can also set any headers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 20 Feb 2008 02:17:25 +0000 (02:17 +0000)]
Reviewed by Sam.
- removed use of DeprecatedString for font family names
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated
function and String rather than DeprecatedString.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Updated for name change.
* css/FontFamilyValue.cpp:
(WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular
expression with code that does the same thing more efficiently.
(WebCore::FontFamilyValue::appendSpaceSeparated): Added.
(WebCore::FontFamilyValue::cssText): Updated for name change.
* css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName
to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType
and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can
be private instead of public.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 20 Feb 2008 02:07:18 +0000 (02:07 +0000)]
- fix build when SVG is not enabled
* rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 20 Feb 2008 01:55:42 +0000 (01:55 +0000)]
Reviewed by Darin.
Change all classes in xml/ to start out with a ref count of 1.
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSXMLHttpRequest.cpp:
(WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
* bindings/js/JSXSLTProcessor.cpp:
(WebCore::JSXSLTProcessor::JSXSLTProcessor):
* bindings/objc/DOMCustomXPathNSResolver.h:
(WebCore::DOMCustomXPathNSResolver::create):
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* dom/Document.cpp:
(WebCore::Document::applyXSLTransform):
(WebCore::Document::createExpression):
(WebCore::Document::createNSResolver):
(WebCore::Document::evaluate):
* xml/DOMParser.h:
(WebCore::DOMParser::create):
(WebCore::DOMParser::DOMParser):
* xml/NativeXPathNSResolver.h:
(WebCore::NativeXPathNSResolver::create):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest):
* xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::create):
* xml/XMLSerializer.h:
(WebCore::XMLSerializer::create):
(WebCore::XMLSerializer::XMLSerializer):
* xml/XPathEvaluator.cpp:
(WebCore::XPathEvaluator::createNSResolver):
* xml/XPathEvaluator.h:
(WebCore::XPathEvaluator::create):
(WebCore::XPathEvaluator::XPathEvaluator):
* xml/XPathExpression.cpp:
(WebCore::XPathExpression::createExpression):
(WebCore::XPathExpression::evaluate):
* xml/XPathExpression.h:
(WebCore::XPathExpression::create):
(WebCore::XPathExpression::XPathExpression):
* xml/XPathNSResolver.h:
* xml/XPathResult.cpp:
(WebCore::XPathResult::XPathResult):
* xml/XPathResult.h:
(WebCore::XPathResult::create):
* xml/XPathValue.cpp:
(WebCore::XPath::Value::modifiableNodeSet):
* xml/XPathValue.h:
(WebCore::XPath::ValueData::create):
(WebCore::XPath::ValueData::ValueData):
(WebCore::XPath::Value::Value):
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::create):
(WebCore::XSLTProcessor::XSLTProcessor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 20 Feb 2008 01:51:41 +0000 (01:51 +0000)]
WebCore:
Reviewed by Sam.
- Trimmed down TextStream and weaned it from DeprecatedString.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge renderTreeAsExternalRepresentation]):
Removed now-unneeded call to getNSString.
* platform/text/TextStream.cpp: Removed unused functions.
Use snprintf instead of sprintf, for better security.
(WebCore::TextStream::release): Added.
* platform/text/TextStream.h: Removed lots of unneeded stuff.
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation): Changed to use String instead
of DeprecatedString.
* rendering/RenderTreeAsText.h: Ditto.
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBox): Use "\n" instead of endl.
(WebCore::write): Ditto.
(WebCore::writeRenderResources): Ditto.
WebKit/win:
Reviewed by Sam.
* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead
of DeprecatedString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Wed, 20 Feb 2008 01:43:50 +0000 (01:43 +0000)]
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes
This brings performance on the phone back to old levels. Andre and I are doing
some formal testing to see exactly where we stand.
* dom/Position.cpp:
(WebCore::enclosingBlockIgnoringEditability): Added. This is enclosingBlock
without the expensive editability checks. upstream and downstream can avoid
those because they do their own editability checking.
(WebCore::Position::upstream):
(WebCore::Position::downstream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison@apple.com [Wed, 20 Feb 2008 00:41:46 +0000 (00:41 +0000)]
Reviewed by Darin.
<rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject linkedUIElement]):
Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).
(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Support NSAccessibilityLinkedUIElementsAttribute.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Wed, 20 Feb 2008 00:00:27 +0000 (00:00 +0000)]
Reviewed by Sam.
- Removed old debugging aids, Node::dump, RenderObject::dump, and
RenderObject::information, that used DeprecatedString.
* dom/CharacterData.cpp: Removed override of Node::dump.
* dom/CharacterData.h: Ditto.
* dom/Element.cpp: Ditto.
* dom/Element.h: Ditto.
* dom/EventTargetNode.cpp: Ditto.
* dom/EventTargetNode.h: Ditto.
* dom/Node.cpp: Removed Node::dump.
* dom/Node.h: Ditto.
* rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
* rendering/RenderBlock.h: Ditto.
* rendering/RenderFrameSet.cpp: Ditto.
* rendering/RenderFrameSet.h: Ditto.
* rendering/RenderObject.cpp: Removed RenderObject::dump and
RenderObject::information.
* rendering/RenderObject.h: Ditto.
* rendering/RenderTable.cpp: Removed override of RenderObject::dump.
* rendering/RenderTable.h: Ditto.
* rendering/RenderTableCell.cpp: Ditto.
* rendering/RenderTableCell.h: Ditto.
* rendering/RenderTableCol.cpp: Ditto.
* rendering/RenderTableCol.h: Ditto.
* rendering/RenderTableSection.cpp: Ditto.
* rendering/RenderTableSection.h: Ditto.
* rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h
and added forward declarations as appropriate.
* svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
* svg/graphics/SVGResourceClipper.cpp: And here.
* svg/graphics/SVGResourceFilter.cpp: Ditto.
* svg/graphics/filters/SVGFEBlend.cpp: Ditto.
* svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
* svg/graphics/filters/SVGFEComposite.cpp: Ditto.
* svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
* svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
* svg/graphics/filters/SVGFEImage.cpp: Ditto.
* svg/graphics/filters/SVGFEMerge.cpp: Ditto.
* svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
* svg/graphics/filters/SVGFEOffset.cpp: Ditto.
* svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
* svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
* svg/graphics/filters/SVGFilterEffect.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Tue, 19 Feb 2008 23:26:47 +0000 (23:26 +0000)]
WebCore:
Reviewed by Sam.
Fix for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com
Inputs should not honor first-letter.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
LayoutTests:
Reviewed by Sam.
Test for <rdar://problem/5729674> Seed: Crash in
RenderButton::setStyle at http://www.dinorpg.com
* fast/forms/input-first-letter.html: Added.
* platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
* platform/mac/fast/forms/input-first-letter-expected.png: Added.
* platform/mac/fast/forms/input-first-letter-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 19 Feb 2008 22:09:48 +0000 (22:09 +0000)]
Reviewed by Darin.
Change OpaqueJSClass and RootObject to start with a ref count of 1.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClass::createNoAutomaticPrototype):
(OpaqueJSClass::create):
* API/JSClassRef.h:
* API/JSObjectRef.cpp:
(JSClassCreate):
* bindings/runtime_root.cpp:
(KJS::Bindings::RootObject::create):
(KJS::Bindings::RootObject::RootObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 19 Feb 2008 21:13:19 +0000 (21:13 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
Test: fast/text/wbr-styled.html
Changed RenderWordBreak to inherit from RenderText instead of
RenderInline.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcInlinePrefWidths):
* rendering/RenderFlow.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::renderName):
(WebCore::RenderText::isTextFragment):
(WebCore::RenderText::isWordBreak):
* rendering/RenderText.h:
* rendering/RenderWordBreak.cpp:
(WebCore::RenderWordBreak::RenderWordBreak):
* rendering/RenderWordBreak.h:
* rendering/bidi.cpp:
(WebCore::RenderBlock::findNextLineBreak):
LayoutTests:
Reviewed by Darin Adler.
- test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15
* fast/text/wbr-styled.html: Added.
* platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
* platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
* platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
* platform/mac/fast/text/wbr-pre-expected.txt:
* platform/mac/fast/text/wbr-styled-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 19 Feb 2008 19:42:54 +0000 (19:42 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 19 Feb 2008 19:42:28 +0000 (19:42 +0000)]
WebCore:
Reviewed by Darin.
WARNING: NO TEST CASES ADDED OR CHANGED
* ChangeLog:
* WebCore.base.exp:
* loader/mac/LoaderNSURLExtras.h:
* loader/mac/LoaderNSURLExtras.m:
Move unused functions to WebKit (where they are used)
(vectorContainsString):
Use const references.
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:
Remove wkNSURLProtocolClassForReqest.
WebKit/mac:
Reviewed by Darin.
Move back WebKit methods that were unused in WebCore.
* Misc/WebNSURLExtras.mm:
(+[NSURL _web_URLWithData:]):
(+[NSURL _web_URLWithData:relativeToURL:]):
(-[NSURL _web_originalData]):
(-[NSURL _web_originalDataAsString]):
(-[NSURL _web_isEmpty]):
(-[NSURL _webkit_canonicalize]):
(-[NSURL _webkit_URLByRemovingComponent:]):
(-[NSURL _webkit_URLByRemovingFragment]):
(-[NSURL _webkit_URLByRemovingResourceSpecifier]):
(-[NSURL _webkit_isFileURL]):
(-[NSString _webkit_isFileURL]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle):
* WebCoreSupport/WebSystemInterface.m:
(InitWebCoreSystemInterface):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Tue, 19 Feb 2008 19:28:05 +0000 (19:28 +0000)]
Reviewed by Darin Adler.
<rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore
These changes bring deleting performance back to old levels on the phone
except for deleting the first space to the right of a word, which we are
still working on.
* dom/Position.cpp:
(WebCore::Position::upstream): Avoid the use of enclosingBlock when determining
if we have left the original enclosing block or entered a new one, and avoid
rootEditableElement for determining if we have changed editability. These
operations are expensive.
(WebCore::Position::downstream): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 19:16:42 +0000 (19:16 +0000)]
JavaScriptCore:
Rubber stamped by Anders.
- removed explicit initialization to 1 for RefCounted; that's now the default
* kjs/regexp.cpp:
(KJS::RegExp::RegExp): Removed RefCounted initializer.
WebCore:
Rubber stamped by Anders.
- removed explicit initialization to 1 for RefCounted; that's now the default
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle): Ditto.
* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 19 Feb 2008 19:08:38 +0000 (19:08 +0000)]
Reviewed by Geoff
Fixed a bug in DRT --threaded mode
* DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
(startJavaScriptThreads): Don't detach the newly created thread. The later call to stopJavaScriptThreads() tries
to pthread_join() each thread that had been created, but you can't join a detached thread!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 19:06:07 +0000 (19:06 +0000)]
Reviewed by Anders.
- next step for http://bugs.webkit.org/show_bug.cgi?id=17257
start ref counts at 1 instead of 0 for speed
* wtf/RefCounted.h:
(WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start
removing the explicit initialization of RefCounted from classes and eventually we
can remove the ability to have the initial count of 0 entirely.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 19 Feb 2008 18:25:56 +0000 (18:25 +0000)]
Reviewed by Darin.
Make ResourceLoader and ResourceHandle start out with a refcount of 1.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::create):
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::create):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::ResourceLoader):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Tue, 19 Feb 2008 13:05:03 +0000 (13:05 +0000)]
2008-02-19 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16863
[GTK] tab focusing doesn't work
GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state.
Use GDK_META_MASK where available, otherwise do not support the meta
key. This matches the behaviour of other applications.
Also add a comment noting that the platform event constructors need to
be kept in sync (it's not obvious that there are multiple places that
check the key state).
* platform/gtk/KeyEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/gtk/MouseEventGtk.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
* platform/gtk/WheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 19 Feb 2008 07:17:18 +0000 (07:17 +0000)]
Reviewed by Sam Weinig's white rhino tusk stamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::stop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 19 Feb 2008 07:15:55 +0000 (07:15 +0000)]
Reviewed by Sam Weinig's rubberstamp
SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase
* platform/sql/SQLiteTransaction.cpp:
(WebCore::SQLiteTransaction::stop):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 19 Feb 2008 07:03:32 +0000 (07:03 +0000)]
Make Drosera work on Vista.
Runtime type library registration on Vista requires use of two new call:
RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
HKCU. LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
Reviewed by Adam.
* WebKitDLL.cpp:
(DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number.
(DllRegisterServer): Call RegisterTypeLibraryForUser if available.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 19 Feb 2008 06:24:13 +0000 (06:24 +0000)]
Reviewed by Adam Roben in California.
- remove unnecessary and erroneous layoutTestController calls from a test
* fast/css/font-face-multiple-remote-sources.html:
* platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Tue, 19 Feb 2008 05:19:04 +0000 (05:19 +0000)]
WebCore:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
Test: platform/mac/plugins/webScriptObject-exception-deadlock.html
* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject valueForKey:]): The line `resultObj = [super valueForKey:key]; // defaults to throwing an exception`
says it all - it throws an exception. This method also happens to hold the JSLock. Problematically, when the exeception
is thrown and the method exited, the JSLock is never released. Fix that without otherwise changing behavior by holding the
JSLock in two individual scopes - Right before the exception and right after.
WebKitTools:
Changes by Geoff Garen, Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
[WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread. If the lock has leaked,
this series of method calls will deadlock. If things are good, it will complete successfully.
* DumpRenderTree/mac/ObjCController.m:
(runJavaScriptThread):
(+[ObjCController isSelectorExcludedFromWebScript:]):
(+[ObjCController webScriptNameForSelector:]):
(-[ObjCController testValueForKey]):
LayoutTests:
Reviewed by Darin
Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
* platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
* platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
* platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pewtermoose@webkit.org [Tue, 19 Feb 2008 04:07:10 +0000 (04:07 +0000)]
Remove FindSafari's Release configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 02:21:07 +0000 (02:21 +0000)]
WebCore:
Reviewed by Sam.
- reduce use of DeprecatedString and memory allocations in processing of CSS
- remove unnecessary double -> float -> double trip in the CSS parser
- cleaned up names and structure in CSS grammar
* css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp
instead, and they now work on ParseString and String objects and don't require the caller
to put the string into a char*. Gave members of the %union more sensible names, removed
duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving
it commented out.
* css/CSSParser.cpp:
(WebCore::equalIgnoringCase): Added.
(WebCore::hasPrefix): Added.
(WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID,
which obviates the need to call lower() and utf8() or to allocate memory at all. Also
used equalIgnoringCase rather than putting the value into a String just to compare it.
(WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change
along with the CSSGrammar.y change, removes the double -> float -> double round trip, and
affects the result of one layout test.
(WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but
without allocating any memory.
(WebCore::cssValueKeywordID): Ditto.
* css/CSSParser.h: Removed declaration for deprecatedString function (now used only in
CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID.
(WebCore::CSSStyleDeclaration::getPropertyValue): Ditto.
(WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto.
(WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto.
(WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto.
(WebCore::CSSStyleDeclaration::setProperty): Ditto.
(WebCore::CSSStyleDeclaration::removeProperty): Ditto.
(WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
* css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate,
and the getPropertyID function declaration along with its associated apology comment.
* css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an
enumeration, like properties, since you rarely have any reason to handle all values, but
often have a reason to handle all properties). Renamed the constant for the number of CSS
value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.
* platform/text/String.cpp:
(WebCore::charactersToDouble): Made this function more efficient by using a stack buffer
rather than a CString.
LayoutTests:
Reviewed by Sam.
- generate new results for the one test that was altered by the
double -> float -> double trip taken by numeric values in the
CSS parser
This test appears under three different names in three different
parts of our test suite.
* platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
* platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
* platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
* platform/mac/fast/block/basic/011-expected.checksum: Ditto.
* platform/mac/fast/block/basic/011-expected.png: Ditto.
* platform/mac/fast/block/basic/011-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 19 Feb 2008 02:13:55 +0000 (02:13 +0000)]
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
Test: fast/css/font-face-multiple-remote-sources.html
* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded):
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded):
LayoutTests:
- test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms
* fast/css/font-face-multiple-remote-sources.html: Added.
* platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
* platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
* platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 01:12:12 +0000 (01:12 +0000)]
Reviewed by Sam.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::hasCSSPropertyNamePrefix): Added.
(WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster
by using a Vector<UChar> and eliminating all the string operations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 00:54:41 +0000 (00:54 +0000)]
Reviewed by Sam.
* Misc/WebNSAttributedStringExtras.mm:
(+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
DeprecatedString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Tue, 19 Feb 2008 00:48:54 +0000 (00:48 +0000)]
2008-02-18 Stephanie Lewis <slewis@apple.com>
Reviewed by Adam.
Remove workaround for <rdar://problem/5695848>.
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::doUpdateResourceResponse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 19 Feb 2008 00:48:06 +0000 (00:48 +0000)]
Reviewed by Sam.
* Api/qwebnetworkinterface.cpp:
(QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 19 Feb 2008 00:25:26 +0000 (00:25 +0000)]
JavaScriptCore:
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
* kjs/JSGlobalObject.cpp:
(KJS::JSGlobalObject::init):
* kjs/JSGlobalObject.h:
(KJS::JSGlobalObject::setDebugger):
* kjs/date_object.cpp:
(KJS::dateProtoFuncGetYear):
WebCore:
Reviewed by Geoff Garen.
Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode
* bindings/js/kjs_proxy.cpp:
(WebCore::KJSProxy::initScript):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Mon, 18 Feb 2008 23:04:37 +0000 (23:04 +0000)]
2008-02-18 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=17381
[CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)
This patch resolves the regression for the GTK+ port.
* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::parseDataUrl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc