WebKit-https.git
7 years agoTry to fix Qt build.
antti@apple.com [Tue, 24 Apr 2012 22:03:34 +0000 (22:03 +0000)]
Try to fix Qt build.

Not reviewed.

* css/StyleRule.h:
(WebCore::StyleRuleBase::StyleRuleBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
tkent@chromium.org [Tue, 24 Apr 2012 21:58:42 +0000 (21:58 +0000)]
[Chromium] Implement WebCore::dateFormat{DayInMonth,Month,Year}Text()
https://bugs.webkit.org/show_bug.cgi?id=84683

Reviewed by Dimitri Glazkov.

* public/platform/WebLocalizedString.h:
Add DateFormat{DayInMonth,Month,Year}Label
* src/LocalizedStrings.cpp:
(WebCore::dateFormatYearText): Implemented.
(WebCore::dateFormatMonthText): ditto.
(WebCore::dateFormatDayInMonthText): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement StyleRule copying
antti@apple.com [Tue, 24 Apr 2012 21:56:48 +0000 (21:56 +0000)]
Implement StyleRule copying
https://bugs.webkit.org/show_bug.cgi?id=84752

Reviewed by Andreas Kling.

We'll need this for copy-on-write when style sheet data is shared between documents.

Implement copy() and copy constructor for style rules their children as needed.

The code is not yet used.

* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore):
* css/CSSSelectorList.h:
(CSSSelectorList):
* css/MediaList.h:
(WebCore::MediaQuerySet::copy):
(MediaQuerySet):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
(WebCore):
* css/MediaQuery.h:
(MediaQuery):
(WebCore::MediaQuery::copy):
* css/MediaQueryExp.h:
(WebCore::MediaQueryExp::copy):
(MediaQueryExp):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::StylePropertySet):
(WebCore):
(WebCore::StylePropertySet::copy):
* css/StylePropertySet.h:

    Make this copy parse mode too. As a result ElementAttributeData no longer needs to set it explicitly after copying.

(StylePropertySet):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::copy):
(WebCore):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):
* css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRule::copy):
(StyleRule):
(WebCore::StyleRuleFontFace::copy):
(StyleRuleFontFace):
(WebCore::StyleRulePage::copy):
(StyleRulePage):
(StyleRuleBlock):
(WebCore::StyleRuleMedia::copy):
(StyleRuleMedia):
(WebCore::StyleRuleRegion::copy):
(StyleRuleRegion):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore):
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
* css/WebKitCSSKeyframesRule.h:
(WebCore):
(WebCore::StyleRuleKeyframes::copy):
(StyleRuleKeyframes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert r115009; It doesn't make necessary changes to NodeRareData and Node.
rniwa@webkit.org [Tue, 24 Apr 2012 21:24:50 +0000 (21:24 +0000)]
Revert r115009; It doesn't make necessary changes to NodeRareData and Node.

Source/WebCore:

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::getNamedItems):
* html/CollectionType.h:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::shouldIncludeChildren):
(WebCore::HTMLCollection::isAcceptableElement):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
* html/RadioNodeList.cpp: Removed.
* html/RadioNodeList.h: Removed.
* html/RadioNodeList.idl: Removed.

LayoutTests:

* fast/forms/form-collection-radio-node-list-expected.txt: Removed.
* fast/forms/form-collection-radio-node-list.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWaveTable should normalize to 0dbFS instead of -6dbFS
crogers@google.com [Tue, 24 Apr 2012 21:20:09 +0000 (21:20 +0000)]
WaveTable should normalize to 0dbFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84644

Reviewed by Kenneth Russell.

No new tests. Oscillator tests will be rebaselined after landing, since several platforms are affected.

* Modules/webaudio/WaveTable.cpp:
(WebCore::WaveTable::createBandLimitedTables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Test expectations updates to make lint happy.
hclam@chromium.org [Tue, 24 Apr 2012 21:15:55 +0000 (21:15 +0000)]
Unreviewed. Test expectations updates to make lint happy.

Some test files are removed or moved so update test expectations accordingly.

* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Create a new flag for PeerConnection
tommyw@google.com [Tue, 24 Apr 2012 21:14:21 +0000 (21:14 +0000)]
MediaStream API: Create a new flag for PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=84723

Reviewed by Dimitri Glazkov.

To allow Chrome to make the GetUserMedia functionality available by default we
need another flag for the PeerConnection related parts. This new flag is in
addition to the general media stream flag, and both need to be enabled for
PeerConnection object creation.

Source/WebCore:

No code behavior changes.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitDeprecatedPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitPeerConnection00Enabled):

Source/WebKit/chromium:

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enablePeerConnection):
(WebKit):
(WebKit::WebRuntimeFeatures::isPeerConnectionEnabled):

Tools:

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline 2 tests after r115091
robert@webkit.org [Tue, 24 Apr 2012 21:13:59 +0000 (21:13 +0000)]
Rebaseline 2 tests after r115091

Unreviewed.

* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/accessibility/table-with-rules-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rebaseline and enable the background-blur layout tests
danakj@chromium.org [Tue, 24 Apr 2012 21:10:54 +0000 (21:10 +0000)]
[chromium] Rebaseline and enable the background-blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=84654

Unreviewed.

* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
* platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, 32-bit build fix.
fpizlo@apple.com [Tue, 24 Apr 2012 21:01:19 +0000 (21:01 +0000)]
Unreviewed, 32-bit build fix.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Revert broken changes to authentication dialog
commit-queue@webkit.org [Tue, 24 Apr 2012 20:52:51 +0000 (20:52 +0000)]
[BlackBerry] Revert broken changes to authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=80135

Patch by Joe Mason <jmason@rim.com> on 2012-04-24
Reviewed by Antonio Gomes.

The previous patches from this bug caused an infinite loop when using digest auth;
apparently they were only tested with basic.

Source/WebCore:

* platform/blackberry/PageClientBlackBerry.h:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleAuthHeader):
(WebCore::NetworkJob::sendRequestWithCredentials):

Source/WebKit/blackberry:

* Api/DumpRenderTreeClient.h:
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

Tools:

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG performs incorrect DCE on (some?) intrinsics
fpizlo@apple.com [Tue, 24 Apr 2012 20:43:01 +0000 (20:43 +0000)]
DFG performs incorrect DCE on (some?) intrinsics
https://bugs.webkit.org/show_bug.cgi?id=84746
<rdar://problem/11310772>

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::setIntrinsicResult):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

Rubber stamped by Oliver Hunt.

* fast/js/dfg-dead-min-one-arg-expected.txt: Added.
* fast/js/dfg-dead-min-one-arg.html: Added.
* fast/js/dfg-dead-min-two-args-expected.txt: Added.
* fast/js/dfg-dead-min-two-args.html: Added.
* fast/js/script-tests/dfg-dead-min-one-arg.js: Added.
(foo):
(.x.f.valueOf):
* fast/js/script-tests/dfg-dead-min-two-args.js: Added.
(foo):
(bar):
(.x.f.valueOf):
(.y.f.valueOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix wrong ASSERT() in findAttributeInVector()
caio.oliveira@openbossa.org [Tue, 24 Apr 2012 20:23:27 +0000 (20:23 +0000)]
Fix wrong ASSERT() in findAttributeInVector()
https://bugs.webkit.org/show_bug.cgi?id=84756

Unreviewed build fix.

* dom/ElementAttributeData.h:
(WebCore::findAttributeInVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the scroll layer position on the main thread when viewing full-frame images
andersca@apple.com [Tue, 24 Apr 2012 20:15:02 +0000 (20:15 +0000)]
Update the scroll layer position on the main thread when viewing full-frame images
https://bugs.webkit.org/show_bug.cgi?id=84754
<rdar://problem/11193304>

Reviewed by Andreas Kling.

Showing really big images can be slow sometimes and in that case it's better to update the scroll layer position on
the main thread, which will avoid flashing white.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline mac rendertree output for svg/custom/use-css-events.svg.
kling@webkit.org [Tue, 24 Apr 2012 20:01:45 +0000 (20:01 +0000)]
Rebaseline mac rendertree output for svg/custom/use-css-events.svg.

* platform/mac/svg/custom/use-css-events-expected.txt: Updated for custom ellipse renderer changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse Vector<Attribute> directly instead of encapsulating it in AttributeVector
caio.oliveira@openbossa.org [Tue, 24 Apr 2012 19:59:02 +0000 (19:59 +0000)]
Use Vector<Attribute> directly instead of encapsulating it in AttributeVector
https://bugs.webkit.org/show_bug.cgi?id=84413

Reviewed by Andreas Kling.

As commented in https://bugs.webkit.org/show_bug.cgi?id=79963#c16 we do not
usually subclass basic types like Vector. This patch changes code to use
Vector<Attribute> directly and move around the functionality of the former
methods to more specific helper functions or inline code at the callers.

* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
(WebCore::Element::normalizeAttributes):
* dom/Element.h:
(Element):
* dom/ElementAttributeData.cpp:
* dom/ElementAttributeData.h:
(WebCore::getAttributeFromVector):
(WebCore::ElementAttributeData::getAttributeItem):
(ElementAttributeData):
(WebCore::ElementAttributeData::attributeVector):
(WebCore::ElementAttributeData::clonedAttributeVector):
(WebCore::ElementAttributeData::getAttributeItemIndex):
(WebCore):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElementFromSavedElement):
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::attributesForIsindexInput):
* html/parser/HTMLTreeBuilder.h:
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):
* xml/XMLErrors.cpp:
(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(WebCore::AtomicMarkupTokenBase::getAttributeItem):
(WebCore::AtomicMarkupTokenBase::attributes):
(AtomicMarkupTokenBase):
(WebCore::::initializeAttributes):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
tommyw@google.com [Tue, 24 Apr 2012 19:47:10 +0000 (19:47 +0000)]
MediaStream API: Moving LT/fast/dom/MediaStream/* to LT/fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=82870

Reviewed by Dimitri Glazkov.

* fast/dom/MediaStream/script-tests/argument-types.js: Removed.
* fast/mediastream/argument-types-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/argument-types-expected.txt.
* fast/mediastream/argument-types.html: Renamed from LayoutTests/fast/dom/MediaStream/argument-types.html.
* fast/mediastream/enabled-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/enabled-expected.txt.
* fast/mediastream/enabled.html: Renamed from LayoutTests/fast/dom/MediaStream/enabled.html.
* fast/mediastream/no-interface-object-expected.txt: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object-expected.txt.
* fast/mediastream/no-interface-object.html: Renamed from LayoutTests/fast/dom/MediaStream/no-interface-object.html.
* fast/mediastream/peerconnection-Attributes.html:
* fast/mediastream/peerconnection-argument-types.html:
* fast/mediastream/script-tests/argument-types.js:
(test):
* fast/mediastream/script-tests/enabled.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/enabled.js.
(hasGetUserMediaProperty):
* fast/mediastream/script-tests/no-interface-object.js: Renamed from LayoutTests/fast/dom/MediaStream/script-tests/no-interface-object.js.
(shouldThrowReferenceError):
(test):
* fast/mediastream/script-tests/peerconnection-Attributes.js: Renamed from LayoutTests/fast/mediastream/script-tests/Attributes.js.
(shouldNotThrow):
(test):
(shouldBeA):
(shouldBeTrueA):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
(gotStream):
(gotStreamFailed):
* fast/mediastream/script-tests/peerconnection-argument-types.js: Copied from LayoutTests/fast/mediastream/script-tests/argument-types.js.
(shouldNotThrow):
(test):
(emptyFunction):
(ObjectThrowingException.prototype.toString):
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename CSSStyleSelector class to StyleResolver.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 19:46:29 +0000 (19:46 +0000)]
Rename CSSStyleSelector class to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=84734

Reviewed by Andreas Kling.

The name CSSStyleSelector is confusing as it conflicts a bit with
the CSS concept of selectors. One could think it's an encapsulation
of the CSS selectors but it's not, in fact this class is responsible
of finding the RenderStyle for a given element. This is the first patch
as I will later rename the files, and then rename the local variables.

Source/WebCore:

No new tests : renaming, no behavior changes should appear.

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseSizeParameter):
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::RuleSet::features):
(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addAuthorRulesAndCollectUserRulesFromSheets):
(WebCore::makeRuleSet):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::determineScope):
(WebCore::StyleResolver::ruleSetForScope):
(WebCore::StyleResolver::appendAuthorStylesheets):
(WebCore::StyleResolver::setupScopeStack):
(WebCore::StyleResolver::pushScope):
(WebCore::StyleResolver::popScope):
(WebCore::StyleResolver::pushParentElement):
(WebCore::StyleResolver::popParentElement):
(WebCore::StyleResolver::pushParentShadowRoot):
(WebCore::StyleResolver::popParentShadowRoot):
(WebCore::StyleResolver::addKeyframeStyle):
(WebCore::StyleResolver::~StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::Features::Features):
(WebCore::StyleResolver::Features::~Features):
(WebCore::StyleResolver::Features::add):
(WebCore::StyleResolver::Features::clear):
(WebCore::StyleResolver::addMatchedProperties):
(WebCore::StyleResolver::addElementStyleProperties):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(StyleResolver):
(Features):
* css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::eval):
* css/MediaQueryEvaluator.h:
(WebCore):
(MediaQueryEvaluator):
* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
* css/StyleMedia.cpp:
(WebCore::StyleMedia::matchMedium):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::setName):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleSelector):
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
* dom/Document.h:
(WebCore):
(WebCore::Document::styleSelectorIfExists):
(WebCore::Document::styleSelector):
(Document):
* dom/Element.cpp:
(StyleSelectorParentPusher):
(WebCore::Element::attributeChanged):
(WebCore::Element::beginParsingChildren):
(WebCore::Element::finishParsingChildren):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::attach):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::recalcShadowTreeStyle):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle):
(WebCore::legacyFontSizeFromCSSValue):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::focusedOrActiveStateChanged):
* history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::styleSelector):
* html/HTMLCanvasElement.h:
(HTMLCanvasElement):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::getMatchedCSSRules):
* page/Page.cpp:
(WebCore::Page::allVisitedStateChanged):
(WebCore::Page::visitedStateChanged):
* page/animation/AnimationController.cpp:
(WebCore::AnimationController::updateAnimations):
* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::adjustButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustTextAreaStyle):
(WebCore::RenderThemeBlackBerry::adjustTextFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldStyle):
(WebCore::RenderThemeBlackBerry::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListButtonStyle):
(WebCore::RenderThemeBlackBerry::adjustMenuListStyle):
(WebCore::RenderThemeBlackBerry::adjustCheckboxStyle):
(WebCore::RenderThemeBlackBerry::adjustRadioStyle):
* platform/blackberry/RenderThemeBlackBerry.h:
(RenderThemeBlackBerry):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):
* platform/gtk/RenderThemeGtk.h:
(RenderThemeGtk):
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustTextFieldStyle):
(WebCore::RenderThemeQt::adjustTextAreaStyle):
(WebCore::RenderThemeQt::adjustMenuListStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::adjustProgressBarStyle):
(WebCore::RenderThemeQt::adjustSliderTrackStyle):
(WebCore::RenderThemeQt::adjustSliderThumbStyle):
(WebCore::RenderThemeQt::adjustSearchFieldStyle):
(WebCore::RenderThemeQt::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeQt::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQt::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeQt::adjustInnerSpinButtonStyle):
* platform/qt/RenderThemeQt.h:
(RenderThemeQt):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::adjustButtonStyle):
(WebCore::RenderThemeQtMobile::adjustTextFieldStyle):
(WebCore::RenderThemeQtMobile::adjustMenuListStyle):
* platform/qt/RenderThemeQtMobile.h:
(RenderThemeQtMobile):
* platform/wx/RenderThemeWx.cpp:
(RenderThemeWx):
(WebCore::RenderThemeWx::adjustButtonStyle):
(WebCore::RenderThemeWx::adjustTextFieldStyle):
(WebCore::RenderThemeWx::adjustMenuListStyle):
(WebCore::RenderThemeWx::adjustMenuListButtonStyle):
* rendering/RenderInputSpeech.cpp:
(WebCore::RenderInputSpeech::adjustInputFieldSpeechButtonStyle):
* rendering/RenderInputSpeech.h:
(RenderInputSpeech):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
* rendering/RenderTheme.h:
(RenderTheme):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::adjustInnerSpinButtonStyle):
* rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
* rendering/RenderThemeChromiumLinux.h:
(RenderThemeChromiumLinux):
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
(WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumWin::adjustProgressBarStyle):
* rendering/RenderThemeChromiumWin.h:
(RenderThemeChromiumWin):
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::setFontFromControlSize):
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeSafari.h:
(RenderThemeSafari):
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
* rendering/RenderThemeWin.h:
(RenderThemeWin):
(WebCore::RenderThemeWin::adjustButtonStyle):
(WebCore::RenderThemeWin::adjustTextFieldStyle):
(WebCore::RenderThemeWin::adjustTextAreaStyle):
* rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeWinCE::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
* rendering/RenderThemeWinCE.h:
(RenderThemeWinCE):
(WebCore::RenderThemeWinCE::adjustButtonStyle):
(WebCore::RenderThemeWinCE::adjustTextFieldStyle):
(WebCore::RenderThemeWinCE::adjustTextAreaStyle):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::isStyleAvailable):
* rendering/style/RenderStyle.h:
(WebCore):
* rendering/style/StyleRareNonInheritedData.h:
(WebCore):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::isOverflowHidden):

Source/WebKit/qt:

* WebCoreSupport/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
* WebCoreSupport/RenderThemeQStyle.h:
(RenderThemeQStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFailure to allocate ArrayStorage in emit_op_new_array leads to poisonous JSArray
mhahnenberg@apple.com [Tue, 24 Apr 2012 19:43:01 +0000 (19:43 +0000)]
Failure to allocate ArrayStorage in emit_op_new_array leads to poisonous JSArray
https://bugs.webkit.org/show_bug.cgi?id=84648

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When emit_op_new_array successfully allocates a new JSArray but fails to allocate
the corresponding ArrayStorage for it, it falls back to the out-of-line stub call
to constructArray, which constructs and entirely new JSArray/ArrayStorage pair.
This leaves us with a JSArray hanging around on the stack or in a register that
did not go through its own constructor, thus giving it uninitialized memory in the
two fields that are checked in JSArray::visitChildren.

* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray): We try to allocate the ArrayStorage first, so that
if we fail we haven't generated the poisonous JSArray that can cause a GC crash.
* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_array):

LayoutTests:

Added a test that randomly allocates new arrays, modifies the object graph by
pointing arrays to other arrays, and removes arrays from the global list. This test
is sufficient to repro this bug when the DFG is disabled, and it should serve as
a good regression test as we implement more optimizations for array allocation in
both JITs.

* fast/js/random-array-gc-stress-expected.txt: Added.
* fast/js/random-array-gc-stress.html: Added.
* fast/js/script-tests/random-array-gc-stress.js: Added.
(gc):
(getRandomIndex):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed build fix after r115083
jesus@webkit.org [Tue, 24 Apr 2012 19:41:08 +0000 (19:41 +0000)]
[Qt] Unreviewed build fix after r115083

* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TestResultsServer] Add a unit test for changes in r114868
zandobersek@gmail.com [Tue, 24 Apr 2012 19:28:07 +0000 (19:28 +0000)]
[TestResultsServer] Add a unit test for changes in r114868
https://bugs.webkit.org/show_bug.cgi?id=84713

Reviewed by Ojan Vafai.

Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
that is created for either DEPS or ToT builder groups. The unit test covers changes
made in r114868.

* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
(testBuilderGroupIsToTWebKitAttribute.assertEquals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG on ARMv7 should not OSR exit on every integer division
fpizlo@apple.com [Tue, 24 Apr 2012 19:19:35 +0000 (19:19 +0000)]
DFG on ARMv7 should not OSR exit on every integer division
https://bugs.webkit.org/show_bug.cgi?id=84661

Reviewed by Oliver Hunt.

On ARMv7, ArithDiv no longer has to know whether or not to speculate integer (since
that was broken with the introduction of Int32ToDouble) nor does it have to know
whether or not to convert its result to integer. This is now taken care of for free
with the addition of the DoubleAsInt32 node, which represents a double-is-really-int
speculation.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGOSRExit.h:
(OSRExit):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"GlobalHandle" HandleHeap (now WeakSet) allocations grow but do not shrink
ggaren@apple.com [Tue, 24 Apr 2012 19:11:12 +0000 (19:11 +0000)]
"GlobalHandle" HandleHeap (now WeakSet) allocations grow but do not shrink
https://bugs.webkit.org/show_bug.cgi?id=84740
<rdar://problem/9917638>

Reviewed by Gavin Barraclough.

Shrink!

* heap/Heap.cpp:
(JSC::Heap::destroy): Be more specific about what's shrinking, since we
can also shrink the WeakSet, but we don't do so here.

(JSC::Heap::collect): If we're going to shrink the heap, shrink the
WeakSet too. Otherwise, its footprint is permanent.

* heap/Heap.h:
(Heap): Removed shrink() as a public interface, since it's vague about
which parts of the heap it affects, and it's really an internal detail.

* heap/WeakSet.cpp:
(JSC::WeakSet::shrink): Nix any free blocks. We assume that sweep() has
already taken place, since that's the convention for shrink() in the heap.

* heap/WeakSet.h:
(WeakSet): New function!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: table-columns-example-001 fails
robert@webkit.org [Tue, 24 Apr 2012 19:03:44 +0000 (19:03 +0000)]
CSS 2.1 failure: table-columns-example-001 fails
https://bugs.webkit.org/show_bug.cgi?id=83978

Reviewed by David Hyatt.

Source/WebCore:

Tests: css2.1/20110323/table-columns-example-001.html
       fast/css/table-rules-attribute-groups-with-frame.html
       fast/css/table-rules-attribute-groups.html
       fast/css/table-rules-attribute-none-with-frame.html
       fast/css/table-rules-attribute-with-frame1.html
       fast/css/table-rules-attribute-with-frame2.html
       fast/css/table-rules-attribute.html

WebKit does not implement the 'cols', 'rows', and 'all' rules attributes correctly
for cells that are adjacent to the table's edges. The solution is to follow the hint in the
spec at http://www.w3.org/TR/CSS21/tables.html#columns and set the table's border to
hidden when the rules attribute is set to one of 'cols', 'rows' or 'all', and the table itself
has no explicit border. Border collapsing will take care of the rest as 'hidden' always wins in
border-conflict resolution. It's not completely clear from the spec that an explicit table border
should trump a cols rule but doing so is consistent with FF and Opera at least. A 'rules' attribute
is trumped by anything specified for the 'frame' attribute so need to ensure that is respected too.

In short, any 'rules' attribute means a hidden table border unless there's a frame or border attribute.

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyle):

LayoutTests:

* css2.1/20110323/table-columns-example-001-expected.html: Added.
* css2.1/20110323/table-columns-example-001.htm: Added.
* fast/css/table-rules-attribute-expected.html: Added.
* fast/css/table-rules-attribute-groups-expected.html: Added.
* fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
* fast/css/table-rules-attribute-groups-with-frame-expected.txt: Added.
* fast/css/table-rules-attribute-groups-with-frame.html: Added.
* fast/css/table-rules-attribute-groups.html: Added.
* fast/css/table-rules-attribute-none-with-frame-expected.html: Added.
* fast/css/table-rules-attribute-none-with-frame.html: Added.
* fast/css/table-rules-attribute-with-frame1-expected.png: Added.
* fast/css/table-rules-attribute-with-frame1-expected.txt: Added.
* fast/css/table-rules-attribute-with-frame1.html: Added.
* fast/css/table-rules-attribute-with-frame2-expected.png: Added.
* fast/css/table-rules-attribute-with-frame2-expected.txt: Added.
* fast/css/table-rules-attribute-with-frame2.html: Added.
  These test the correct interaction of a rules attribute with a frame attribute. 'cols' is used
  for the test, but each of cols, rows, and all have the same effect on the table's borders. It wasn't
  possible to create reftests for all of them because of the different behaviour of the frame attr to
  a simple border, probably due to painting order.
* fast/css/table-rules-attribute.html: Added.
  This tests correct rendering of the rules attribute on a table without its own border. It
  also tests border collapsing on tables with a rules attribute.
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
   This is a progression - the table's border is hidden.
* platform/chromium/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rebaseline background tests
commit-queue@webkit.org [Tue, 24 Apr 2012 18:55:12 +0000 (18:55 +0000)]
[EFL] Rebaseline background tests
https://bugs.webkit.org/show_bug.cgi?id=84686

Unreviewed rebaseline.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-24

* platform/efl/Skipped:
* platform/efl/fast/backgrounds/001-expected.txt:
* platform/efl/fast/backgrounds/animated-gif-as-background-expected.png:
* platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
* platform/efl/fast/backgrounds/background-leakage-expected.txt:
* platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
* platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
* platform/efl/fast/backgrounds/background-position-1-expected.png:
* platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
* platform/efl/fast/backgrounds/background-position-rounding-expected.png:
* platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
* platform/efl/fast/backgrounds/mask-box-image-expected.png: Added.
* platform/efl/fast/backgrounds/mask-box-image-expected.txt: Added.
* platform/efl/fast/backgrounds/mask-composite-expected.png:
* platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
* platform/efl/fast/backgrounds/positioned-root-expected.png: Removed.
* platform/efl/fast/backgrounds/positioned-root-expected.txt: Removed.
* platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
* platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
* platform/efl/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
* platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
* platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/efl/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
* platform/efl/fast/backgrounds/size/contain-and-cover-expected.png: Added.
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/efl/fast/backgrounds/size/zero-expected.txt:
* platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
* platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
* platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Removed.
* platform/efl/fast/backgrounds/table-root-expected.png: Removed.
* platform/efl/fast/backgrounds/table-root-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop installing localizedStrings.js in Production builds.
timothy@apple.com [Tue, 24 Apr 2012 18:51:44 +0000 (18:51 +0000)]
Stop installing localizedStrings.js in Production builds.

<rdar://problem/11296649>

Reviewed by Joseph Pecoraro.

* Configurations/WebCore.xcconfig: Added EXCLUDED_SOURCE_FILE_NAMES_Production_macosx
and modified EXCLUDED_SOURCE_FILE_NAMES to look for CONFIGURATION variant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/Window/window-postmessage-clone.html failing on Mac after r114992
kbr@google.com [Tue, 24 Apr 2012 18:44:36 +0000 (18:44 +0000)]
fast/dom/Window/window-postmessage-clone.html failing on Mac after r114992
https://bugs.webkit.org/show_bug.cgi?id=84741

Not reviewed. Rebaseline only; verified locally.

* fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skip unsupported inspector heap profiler test on mac.
kling@webkit.org [Tue, 24 Apr 2012 18:34:38 +0000 (18:34 +0000)]
Unreviewed, skip unsupported inspector heap profiler test on mac.

* platform/mac/Skipped: Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a description field in WebURLError and show failure description in...
commit-queue@webkit.org [Tue, 24 Apr 2012 18:32:58 +0000 (18:32 +0000)]
[chromium] Add a description field in WebURLError and show failure description in the inspector network tab.
https://bugs.webkit.org/show_bug.cgi?id=84566

Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-04-24
Reviewed by Pavel Feldman.

Source/Platform:

* chromium/public/WebURLError.h:
(WebURLError):

Source/WebCore:

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
* platform/chromium/support/WebURLError.cpp:
(WebKit::WebURLError::operator=):
(WebKit::WebURLError::operator ResourceError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly
rwlbuis@webkit.org [Tue, 24 Apr 2012 18:21:58 +0000 (18:21 +0000)]
[SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly
https://bugs.webkit.org/show_bug.cgi?id=72796

SVG <use> of <symbol> containing <linearGradient> renders black
https://bugs.webkit.org/show_bug.cgi?id=82775

Source/WebCore:

Reviewed by Dirk Schulze.

Create RenderSVGHiddenContainer for each <symbol>, which allows creation of child renderers too. This fixes
both bugs since the bbox can be calculated at all times now and gradients in <symbol> are always created.
This does allocate more memory but in general <symbol> is not used a lot and they tend to be small subtrees.

Patch by Leo Yang.

Tests: svg/custom/bbox-of-g-in-symbol.svg
       svg/custom/gradient-in-symbol-expected.svg
       svg/custom/gradient-in-symbol.svg

* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::createRenderer):
(WebCore):
* svg/SVGSymbolElement.h:
(SVGSymbolElement):

LayoutTests:

Add a new test for each bug. Also rebaseline some test results since
RenderSVGHiddenContainer is dumped now.

Reviewed by Dirk Schulze.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/mac/svg/carto.net/button-expected.txt:
* platform/mac/svg/carto.net/colourpicker-expected.txt:
* platform/mac/svg/carto.net/slider-expected.txt:
* platform/mac/svg/carto.net/window-expected.txt:
* platform/mac/svg/custom/embedding-external-svgs-expected.txt:
* platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
* platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
* platform/mac/svg/custom/struct-use-09-b-expected.txt: Removed.
* platform/mac/svg/custom/use-clipped-hit-expected.txt:
* platform/mac/svg/custom/use-css-events-expected.txt:
* platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
* platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
* platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/mac/svg/custom/use-on-symbol-expected.txt:
* platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
* platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
* platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/mac/svg/custom/use-symbol-overflow-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
* platform/qt/svg/carto.net/button-expected.txt:
* platform/qt/svg/carto.net/colourpicker-expected.txt:
* platform/qt/svg/carto.net/slider-expected.txt:
* platform/qt/svg/carto.net/window-expected.txt:
* platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
* platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
* platform/qt/svg/custom/use-on-symbol-expected.txt:
* platform/qt/svg/custom/use-recalcStyle-crash-expected.txt:
* platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
* platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
* platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
* platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
* svg/custom/bbox-of-g-in-symbol-expected.txt: Added.
* svg/custom/bbox-of-g-in-symbol.svg: Added.
* svg/custom/deep-dynamic-updates-expected.txt:
* svg/custom/gradient-in-symbol-expected.svg: Added.
* svg/custom/gradient-in-symbol.svg: Added.
* svg/custom/use-in-symbol-with-offset-expected.txt:
* svg/custom/use-setAttribute-crash-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
* svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664 Need...
beidson@apple.com [Tue, 24 Apr 2012 18:12:55 +0000 (18:12 +0000)]
<rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664  Need DOMWindow mechanism to supplement UserScripts for page cache notifications

Source/WebCore:

This patch creates a new object type "DOMWindowExtension" which extends DOMWindowProperty.
A DOMWindowExtension is tied to a particular DOMWindow and represents extensibility in that
DOMWindow within a particular DOMWrapperWorld.

It is a token object meant designed to notify clients of the various events in the lifetime
of a DOMWindow property such as creation, disconnecting for the page cache, reconnecting
when restoring from the page cache, and DOMWindow destruction.

Reviewed by Sam Weinig.

New WebKit API test DOMWindowExtensionBasic added.

Add hooks for 4 new client calls regarding DOMWindowExtensions and global object lifetime:
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::dispatchCanCreateGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebCore::FrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebCore::FrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):

At the same time "DidClearWindowObject" is called, also notify clients that the global object is available:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
* loader/FrameLoader.h:

 DOMWindowProperties might want to unregister themselves during these notifications, so copy
 the set to a Vector. While this technique is arguably fragile, its certainly less fragile than
 mutating a set while iterating it:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::reconnectDOMWindowProperties):

 Implement the DOMWindowExtension object. It acts like a DOMWindowProperty with the added capability
 of remembering what Frame it used to be connected to so it can *always* notify clients on willDetachPage:
* page/DOMWindowExtension.cpp: Added.
(WebCore::DOMWindowExtension::DOMWindowExtension):
(WebCore::DOMWindowExtension::~DOMWindowExtension):
(WebCore::DOMWindowExtension::disconnectFrame):
(WebCore::DOMWindowExtension::reconnectFrame):
(WebCore::DOMWindowExtension::willDetachPage):
* page/DOMWindowExtension.h: Added.
(WebCore::DOMWindowExtension::create):
(WebCore::DOMWindowExtension::world):

 Project files:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Reviewed by Sam Weinig.

- Adds a new API object WKBundleDOMWindowExtension
- Exposes callbacks about the lifetime of DOMWindowExtensions through BundlePageLoaderClient

Add new API casts:
* Shared/API/c/WKBase.h:
* Shared/APIClientTraits.cpp:
* Shared/APIObject.h:
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

Add API for the new DOMWindowExtension object:
* WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp: Added.
(WKBundleDOMWindowExtensionGetTypeID):
(WKBundleDOMWindowExtensionCreate):
(WKBundleDOMWindowExtensionGetFrame):
(WKBundleDOMWindowExtensionGetScriptWorld):
* WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.h: Added.

Add implementation for that API which wraps the WebCore::DOMWindowExtension:
* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: Added.
(WebKit::allExtensions):
(WebKit::InjectedBundleDOMWindowExtension::create):
(WebKit::InjectedBundleDOMWindowExtension::get):
(WebKit::InjectedBundleDOMWindowExtension::InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::~InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::frame):
(WebKit::InjectedBundleDOMWindowExtension::world):
* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h: Added.
(InjectedBundleDOMWindowExtension):
(WebKit::InjectedBundleDOMWindowExtension::type):

Add new BundlePageLoaderClient methods:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didCreateGlobalObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):

Implement the 4 new callbacks from WebCore which notify the BundlePageLoaderClient:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebFrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Project Files:
* CMakeLists.txt:
* GNUmakefile.am:
* Target.pri:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

Tools:

Reviewed by Sam Weinig.

Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.

It makes sure new extensions can be added at the right times, and that all of the expected
callbacks are made.

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
(TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
   bundle to a set of known expected messages.

Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
(TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
(TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
(TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::initialize):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
(TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
(TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
(TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
(TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
(TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
(TestWebKitAPI::didFinishLoadForFrameCallback):
(TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
(TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
(TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
(TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):

* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Implement axis locking on the WebView for pan gestures
abecsi@webkit.org [Tue, 24 Apr 2012 17:48:01 +0000 (17:48 +0000)]
[Qt][WK2] Implement axis locking on the WebView for pan gestures
https://bugs.webkit.org/show_bug.cgi?id=84350

Reviewed by Kenneth Rohde Christiansen.

If a pan gesture has sufficient velocity along one axis the WebView
should automatically lock the page movement to that axis.
This locking should be maintained until the ongoing pan gesture ends.

This patch implements a simple axis locker which adjusts the positions
sent to the Flickable to the initial reference position according to the
direction an velocity information it gathered from incoming touch events.

The FlickableAxisLocker makes use of the velocity information of the touch point
if available, else an approximate velocity of the incoming event is
calculated.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::FlickableAxisLocker::FlickableAxisLocker):
(QQuickWebViewPrivate::FlickableAxisLocker::touchVelocity):
(QQuickWebViewPrivate::FlickableAxisLocker::update):
(QQuickWebViewPrivate::FlickableAxisLocker::setReferencePosition):
(QQuickWebViewPrivate::FlickableAxisLocker::reset):
(QQuickWebViewPrivate::FlickableAxisLocker::adjust):
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebView::touchEvent):
(QQuickWebView::handleFlickableMousePress):
(QQuickWebView::handleFlickableMouseMove):
(QQuickWebView::handleFlickableMouseRelease):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate svg-ellipse-non-scale-stroke expectations
pdr@google.com [Tue, 24 Apr 2012 17:46:16 +0000 (17:46 +0000)]
Update svg-ellipse-non-scale-stroke expectations
https://bugs.webkit.org/show_bug.cgi?id=82628

Unreviewed update of test expectations.

* platform/chromium/test_expectations.txt:
* platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Removed.
* platform/gtk/test_expectations.txt:
* svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't keep pointers to released layer tree
commit-queue@webkit.org [Tue, 24 Apr 2012 17:43:54 +0000 (17:43 +0000)]
[chromium] Don't keep pointers to released layer tree
https://bugs.webkit.org/show_bug.cgi?id=84715

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-24
Reviewed by Adrienne Walker.

Source/WebCore:

As part of tree synchronization, CCLayerTreeHostImpl loses ownership of
the previous tree (as per releaseRootLayer()). After this point we
should not retain any pointers to the old tree, because they are
effectively invalid as soon as the root layer is released.

For processing scroll updates we need to keep track of which layer is
being scrolled, and this state needs to survive tree synchronizations.
Instead of keeping a direct pointer to the scrolled layer, we now save
the id of that layer and use it to look up the same layer from the new
tree.

Unit test: CCLayerTreeHostImplTest.replaceTreeWhileScrolling

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

Added new unit test to check that we can keep scrolling even if the layer
tree is replaced from under us.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Filters] Move m_filter and related fields from RenderLayer to a different struct...
achicu@adobe.com [Tue, 24 Apr 2012 17:17:45 +0000 (17:17 +0000)]
[CSS Filters] Move m_filter and related fields from RenderLayer to a different structure and only allocate it when needed
https://bugs.webkit.org/show_bug.cgi?id=84460

Reviewed by Dean Jackson.

The new RenderLayerFilterInfo is meant to be allocated only when needed by filters. The link to the RenderLayerFilterInfo
is maintained using a HashMap and a single boolean in the RenderLayer class.

No new tests, just extracted a couple of fields inside the RenderLayer to a separate class.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintsWithFilters):
(WebCore::RenderLayer::requiresFullLayerImageForFilters):
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::filterRenderer):
(RenderLayer):
(WebCore::RenderLayer::filterInfo):
(WebCore::RenderLayer::ensureFilterInfo):
(WebCore::RenderLayer::removeFilterInfoIfNeeded):
(WebCore::RenderLayer::hasFilterInfo):
(WebCore::RenderLayer::setHasFilterInfo):
* rendering/RenderLayerFilterInfo.cpp: Added.
(WebCore):
(WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):
(WebCore::RenderLayerFilterInfo::removeFilterInfoForRenderLayer):
(WebCore::RenderLayerFilterInfo::RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::setRenderer):
* rendering/RenderLayerFilterInfo.h: Added.
(WebCore):
(RenderLayerFilterInfo):
(WebCore::RenderLayerFilterInfo::dirtySourceRect):
(WebCore::RenderLayerFilterInfo::addDirtySourceRect):
(WebCore::RenderLayerFilterInfo::resetDirtySourceRect):
(WebCore::RenderLayerFilterInfo::renderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIterating a HashMap<String, X> involves a string equality comparison to check for...
darin@apple.com [Tue, 24 Apr 2012 17:09:16 +0000 (17:09 +0000)]
Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value
https://bugs.webkit.org/show_bug.cgi?id=84524

Reviewed by Antti Koivisto.

Added a new algorithm for checking for empty buckets that can be specialized.
Specialized it for String. We may later want to do the same thing for KURL.
It's not important to do it for AtomicString, since AtomicString's == function
is already a simple pointer equality compare. We may also later want to do
something similar for pairs that have String objects in them.

* wtf/HashTable.h:
(WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
will do something more efficient for String.

* wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value
of false. This allows us to continue to get automatic comparison with the appropriate
emptyValue result for all existing traits, but supply a custom isEmptyValue function
for HashTraits<String>. Putting an isEmptyValue function into the traits would require
overriding it in every class that has a custom value for emptyValue. Specialized
HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
isEmptyValue function.
(WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
struct to use either == combined with the emptyValue function or the isEmptyValue function.

* wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at
the bottom of the file.
(WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
haraken@chromium.org [Tue, 24 Apr 2012 17:01:26 +0000 (17:01 +0000)]
[V8] Pass Isolate around in SerializedScriptValue.cpp (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84663

Reviewed by Nate Chapin.

The objective is to pass Isolate to toV8() in SerializedScriptValue.cpp.

Part1: Add an Isolate argument to SerializedScriptValue::create(),
SerializedScriptValue::deserialize(), etc.
Part2: Add an m_isolate member to SerializedScriptValue::Writer()
and SerializedScriptValue::Reader().
Part3: Pass Isolate to toV8().

This patch fixes Part1.

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):
(WebCore::SerializedScriptValue::deserializeForInspector):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 16:51:33 +0000 (16:51 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84735

Mark http/tests/inspector/change-iframe-src.html as flaky on Windows

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Build and run TestWebKitAPI unit tests
carlosgc@webkit.org [Tue, 24 Apr 2012 16:48:18 +0000 (16:48 +0000)]
[GTK] Build and run TestWebKitAPI unit tests
https://bugs.webkit.org/show_bug.cgi?id=84325

Reviewed by Philippe Normand.

.:

* GNUmakefile.am: Include makefiles to build gtest and
TestWebKitAPI. Add BUILDING_WEBKIT2__ macro to compilation when
building WebKit2.

Source/ThirdParty:

* gtest/GNUmakefile.am: Added.

Tools:

We only build WTF unit tests for now. WebKit2 tests will be
enabled in a follow up patch.

* Scripts/run-gtk-tests:
(TestRunner): Add TestWebKitAPI/WTF to the list of directories
containing unit tests.
(TestRunner._run_test_glib): Run glib tests using gtester.
(TestRunner._run_test_google): Run google tests.
(TestRunner._run_test): Use _run_test_glib or _run_test_google
depending on whether given test is glib or google test
* TestWebKitAPI/GNUmakefile.am: Added.
* TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
warning with -Wundef. Include WebKit2 headers only when building
WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8][Refactoring] Remove deserializeAndSetProperty()
haraken@chromium.org [Tue, 24 Apr 2012 16:44:10 +0000 (16:44 +0000)]
[V8][Refactoring] Remove deserializeAndSetProperty()
from SerializedScriptValue.cpp
https://bugs.webkit.org/show_bug.cgi?id=84662

Reviewed by Nate Chapin.

SerializedScriptValue::deserializeAndSetProperty() is no
longer used. This patch removes it.

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
* bindings/v8/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm
haraken@chromium.org [Tue, 24 Apr 2012 16:40:39 +0000 (16:40 +0000)]
[V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=84660

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in CodeGeneratorV8.pm.

Test: bindings/scripts/test/TestEventTarget.idl
      bindings/scripts/test/TestObj.idl
      bindings/scripts/test/TestInterface.idl

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateSetDOMException):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateFunctionCallback):
(GenerateParametersCheck):
(GenerateFunctionCallString):

* bindings/scripts/test/V8/V8TestEventTarget.cpp:
Updated run-bindings-tests results.
(WebCore::TestEventTargetV8Internal::itemCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
(WebCore::TestObjV8Internal::strictFunctionCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 16:31:40 +0000 (16:31 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84733

Mark fast/canvas/canvas-composite.html as flaky on Vista.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Convert touch-point area
commit-queue@webkit.org [Tue, 24 Apr 2012 16:28:20 +0000 (16:28 +0000)]
[Qt][WK2] Convert touch-point area
https://bugs.webkit.org/show_bug.cgi?id=84434

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Kenneth Rohde Christiansen.

Fix failing test after r114917 by also adding the new EventSender API
to WebKitTestRunner.

* WebKitTestRunner/EventSenderProxy.h:
(EventSenderProxy):
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::setTouchPointRadius):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::clearTouchPoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Tue, 24 Apr 2012 16:21:24 +0000 (16:21 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: One more drag&drop test
failing and mark fast/events/panScroll-click-hyperlink.html as
missing result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to setDOMException() (Part2)
haraken@chromium.org [Tue, 24 Apr 2012 16:14:54 +0000 (16:14 +0000)]
[V8] Pass Isolate to setDOMException() (Part2)
https://bugs.webkit.org/show_bug.cgi?id=84658

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom
binding code.

No tests. No change in behavior.

* bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):
* bindings/v8/V8Collection.h:
(WebCore):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::WindowSetTimeoutImpl):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::getInt8Callback):
(WebCore::V8DataView::getUint8Callback):
(WebCore::V8DataView::setInt8Callback):
(WebCore::V8DataView::setUint8Callback):
* bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
(WebCore::V8DirectoryEntrySync::getDirectoryCallback):
(WebCore::V8DirectoryEntrySync::getFileCallback):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::V8HTMLElement::itemValueAccessorSetter):
* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addCallback):
(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::V8HTMLSelectElement::indexedPropertySetter):
* bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):
* bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to setDOMException() (Part1)
haraken@chromium.org [Tue, 24 Apr 2012 16:06:32 +0000 (16:06 +0000)]
[V8] Pass Isolate to setDOMException() (Part1)
https://bugs.webkit.org/show_bug.cgi?id=84656

Reviewed by Nate Chapin.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to setDOMException() in custom binding code.

No tests. No change in behavior.

* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::protocolAccessorSetter):
* bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
(WebCore::V8SQLTransactionSync::executeSqlCallback):
* bindings/v8/custom/V8SVGLengthCustom.cpp:
(WebCore::V8SVGLength::valueAccessorGetter):
(WebCore::V8SVGLength::valueAccessorSetter):
(WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getExtensionCallback):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add additional details including the bounds of the box for caretPosition...
mifenton@rim.com [Tue, 24 Apr 2012 16:05:28 +0000 (16:05 +0000)]
[BlackBerry] Add additional details including the bounds of the box for caretPositionChanged.
https://bugs.webkit.org/show_bug.cgi?id=84728

Reviewed by Antonio Gomes.

PR 138988.

Update caretPositionChanged to include the limit of the input field
for single line inputs.

Reviewed Internally by Gen Mak.

* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
(WebKit):
* WebKitSupport/InputHandler.h:
(InputHandler):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Input Range element expects mouse events
charles.wei@torchmobile.com.cn [Tue, 24 Apr 2012 15:57:24 +0000 (15:57 +0000)]
[BlackBerry] Input Range element expects mouse events
https://bugs.webkit.org/show_bug.cgi?id=84571

Reviewed by Antonio Gomes.

.:

Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.
* ManualTests/blackberry/slider-thumb-consumes-event.html: Added.

Source/WebKit/blackberry:

Input element with Range type expects mouse events to
drag the handle. Note that Input Range could appear
in both the web page directly, or in some shadow tree,
like the MediaControlTimeline and MediaControlVolume.
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::isRangeControlElement):
(WebKit):
(BlackBerry::WebKit::elementExpectsMouseEvents):
(BlackBerry::WebKit::shouldConvertTouchToMouse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: encapsulate live location into the Script.
pfeldman@chromium.org [Tue, 24 Apr 2012 15:46:35 +0000 (15:46 +0000)]
Web Inspector: encapsulate live location into the Script.
https://bugs.webkit.org/show_bug.cgi?id=84722

Reviewed by Yury Semikhatsky.

Source/WebCore:

Live location is just a location on the script. The way it is implemented today involves too many indirections.

* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
(WebInspector.DebuggerModel.prototype.scriptForId):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.PresentationCallFrame.prototype.uiLocation):
(WebInspector.DebuggerPresentationModel.CallFramePlacard):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
* inspector/front-end/RawSourceCode.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
* inspector/front-end/Script.js:
(WebInspector.Script):
(WebInspector.Script.prototype.isInlineScript):
(WebInspector.Script.prototype.setSourceMapping):
(WebInspector.Script.prototype.createLocation):
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.dispose):
(WebInspector.Script.Location.prototype._update):
* inspector/front-end/ScriptMapping.js:
(WebInspector.UILocation):
(WebInspector.SourceMapping):
(WebInspector.SourceMapping.prototype.rawLocationToUILocation):
(WebInspector.SourceMapping.prototype.uiLocationToRawLocation):
(WebInspector.MainScriptMapping):
(WebInspector.MainScriptMapping.prototype.addScript):
(WebInspector.MainScriptMapping.prototype.reset):
* inspector/front-end/SnippetsModel.js:
(WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: a bunch of heap profiler cleanups
yurys@chromium.org [Tue, 24 Apr 2012 15:37:55 +0000 (15:37 +0000)]
Web Inspector: a bunch of heap profiler cleanups
https://bugs.webkit.org/show_bug.cgi?id=84730

- HeapSnapshotProviderProxy passed explicitely as a parameter to HeapSnapshotGridNode
constructor
- Removed dead code
- Removed unused parameters
- Added more closure compiler annotations
- Extracted code finding cycled among node ancestors into a separate method

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype.createEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
(WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
(WebInspector.HeapSnapshotEdgesProvider):
* inspector/front-end/HeapSnapshotDataGrids.js:
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._findAncestorWithSameSnapshotNodeId):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 15:35:34 +0000 (15:35 +0000)]
[Chromium] Unreviewed test expectations update.

The following tests have been marked as crashing in debug mode only:

    http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html
    http/tests/websocket/tests/hixie76/workers/close-in-worker.html
    http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html
    http/tests/websocket/tests/hixie76/workers/worker-simple.html
    media/media-controller-playback.html
    media/track/track-cues-missed.html
    media/track/track-cues-pause-on-exit.html
    media/track/track-cues-sorted-before-dispatch.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix includes in StrongInlines.h and ScriptValue.h
adamk@chromium.org [Tue, 24 Apr 2012 15:29:22 +0000 (15:29 +0000)]
Fix includes in StrongInlines.h and ScriptValue.h
https://bugs.webkit.org/show_bug.cgi?id=84659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's
definiition is required here.

Source/WebCore:

This change was prompted by an attempt to use ScriptValue.h from a
WebCore header file and running into trouble with the (as it turns out
unnecessary) include of JSDOMBinding.h.

* bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that
it's not included by the header.
* bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove MediaList CSSOM wrapper ownership to parent rule or stylesheet
antti@apple.com [Tue, 24 Apr 2012 15:27:11 +0000 (15:27 +0000)]
Move MediaList CSSOM wrapper ownership to parent rule or stylesheet
https://bugs.webkit.org/show_bug.cgi?id=84716

Reviewed by Anders Carlsson.

MediaList CSSOM wrapper should be owned by a rule or a stylesheet, not by the underlying
MediaQuerySet.

Remove the ref forwarding from MediaList in favor of regular refcounting. Use the usual
pattern where the parent wrapper refs the child wrapper and zeroes the backpointer
on destruction.

* bindings/js/JSDOMBinding.h:
(WebCore::root):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::media):
* css/CSSImportRule.h:
(StyleRuleImport):
(CSSImportRule):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::media):
* css/CSSMediaRule.h:
(CSSMediaRule):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::media):
* css/CSSStyleSheet.h:
(CSSStyleSheet):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::mediaText):
(WebCore::MediaList::MediaList):
(WebCore):
(WebCore::MediaList::notifyChanged):
* css/MediaList.h:
(MediaQuerySet):
(WebCore::MediaList::create):
(WebCore::MediaList::parentRule):
(WebCore::MediaList::clearParentStyleSheet):
(WebCore::MediaList::clearParentRule):
(WebCore::MediaList::queries):
(MediaList):
* css/StyleRule.h:
(WebCore::StyleRuleMedia::mediaQueries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Tap-to zoom should navigate when appropiate
commit-queue@webkit.org [Tue, 24 Apr 2012 15:27:07 +0000 (15:27 +0000)]
[Qt] Tap-to zoom should navigate when appropiate
https://bugs.webkit.org/show_bug.cgi?id=84602

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.

When a zoomable area is returned and has the same zoom-level as the current,
examine if the using this target would expose currently unexposed parts of
the zoom-target. If it does, pan to that area instead of zooming back.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html
carlosgc@webkit.org [Tue, 24 Apr 2012 15:25:13 +0000 (15:25 +0000)]
[GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html
https://bugs.webkit.org/show_bug.cgi?id=83973

Reviewed by Philippe Normand.

Source/WebCore:

Test: canvas/philip/tests/toDataURL.jpeg.alpha.html

* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::encodeImage): Convert ARGB32 cairo surface into RGB24
when encoding JPEG images since JPEG encoder doesn't support alpha
channel.

LayoutTests:

* platform/gtk/test_expectations.txt: Unskip
canvas/philip/tests/toDataURL.jpeg.alpha.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 24 Apr 2012 15:18:40 +0000 (15:18 +0000)]
[GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=82598

Reviewed by Philippe Normand.

Source/WebCore:

* GNUmakefile.list.am: Add new files to compilation.
* platform/gtk/TemporaryLinkStubs.cpp: Remove stubs for
setCookieStoragePrivateBrowsingEnabled,
startObservingCookieChanges and stopObservingCookieChanges.
* platform/network/soup/CookieStorageSoup.cpp: Added.
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::soupCookiesChanged): Notify cookies changes using
platform strategies.
(WebCore::startObservingCookieChanges): Connect to changed signal
of the soup cookie jar.
(WebCore::stopObservingCookieChanges): Disconnect signals handlers
for changed signals of the soup cookie jar.

Source/WebKit2:

* UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerFinalize): Stop observing cookie changes.
(webkit_cookie_manager_class_init): Add
WebKitCookieManager::changed signal.
(cookiesDidChange): Emit WebKitCookieManager::changed signal.
(webkitCookieManagerCreate): Implement WKCookieManagerClient and
start observing cookie changes.
* UIProcess/API/gtk/tests/TestCookieManager.cpp:
(testCookieManagerCookiesChanged):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 24 Apr 2012 15:16:27 +0000 (15:16 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename CSSStyleApplyProperty files to StyleBuilder.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 14:59:54 +0000 (14:59 +0000)]
Rename CSSStyleApplyProperty files to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84721

Reviewed by Antti Koivisto.

r115043 renamed CSSStyleApplyProperty class to StyleBuilder. This
patch rename the files to match the new class name.

No new tests : renaming of files, no behavior changes expected.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/StyleBuilder.cpp: Renamed from Source/WebCore/css/CSSStyleApplyProperty.cpp.
(WebCore):
(ApplyPropertyExpanding):
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyExpanding::createHandler):
(ApplyPropertyDefaultBase):
(WebCore::ApplyPropertyDefaultBase::setValue):
(WebCore::ApplyPropertyDefaultBase::value):
(WebCore::ApplyPropertyDefaultBase::initial):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefaultBase::createHandler):
(ApplyPropertyDefault):
(WebCore::ApplyPropertyDefault::setValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyDefault::createHandler):
(ApplyPropertyNumber):
(WebCore::ApplyPropertyNumber::setValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyNumber::createHandler):
(ApplyPropertyStyleImage):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyStyleImage::createHandler):
(ApplyPropertyAuto):
(WebCore::ApplyPropertyAuto::setValue):
(WebCore::ApplyPropertyAuto::value):
(WebCore::ApplyPropertyAuto::hasAuto):
(WebCore::ApplyPropertyAuto::setAuto):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyAuto::createHandler):
(ApplyPropertyClip):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyClip::createHandler):
(WebCore::defaultInitialColor):
(ApplyPropertyColor):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyColor::createHandler):
(ApplyPropertyDirection):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyDirection::createHandler):
(ApplyPropertyLength):
(WebCore::ApplyPropertyLength::setValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyLength::createHandler):
(ApplyPropertyString):
(WebCore::ApplyPropertyString::setValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyString::createHandler):
(ApplyPropertyBorderRadius):
(WebCore::ApplyPropertyBorderRadius::setValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyBorderRadius::createHandler):
(FillLayerAccessorTypes):
(ApplyPropertyFillLayer):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyFillLayer::createHandler):
(ApplyPropertyComputeLength):
(WebCore::ApplyPropertyComputeLength::setValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(ApplyPropertyFont):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFont::createHandler):
(ApplyPropertyFontSize):
(WebCore::ApplyPropertyFontSize::largerFontSize):
(WebCore::ApplyPropertyFontSize::smallerFontSize):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontSize::createHandler):
(ApplyPropertyFontWeight):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontWeight::createHandler):
(ApplyPropertyFontVariantLigatures):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::createHandler):
(ApplyPropertyBorderImage):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImage::createHandler):
(ApplyPropertyBorderImageModifier):
(WebCore::ApplyPropertyBorderImageModifier::getValue):
(WebCore::ApplyPropertyBorderImageModifier::setValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::createHandler):
(ApplyPropertyBorderImageSource):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyBorderImageSource::createHandler):
(ApplyPropertyCounter):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCounter::createHandler):
(ApplyPropertyCursor):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyCursor::createHandler):
(ApplyPropertyTextAlign):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextAlign::createHandler):
(ApplyPropertyTextDecoration):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
(ApplyPropertyUnicodeBidi):
(WebCore::ApplyPropertyUnicodeBidi::applyValue):
(WebCore::ApplyPropertyUnicodeBidi::createHandler):
(ApplyPropertyLineHeight):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeight::createHandler):
(ApplyPropertyPageSize):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyPageSize::createHandler):
(ApplyPropertyTextEmphasisStyle):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
(ApplyPropertyAnimation):
(WebCore::ApplyPropertyAnimation::setValue):
(WebCore::ApplyPropertyAnimation::value):
(WebCore::ApplyPropertyAnimation::test):
(WebCore::ApplyPropertyAnimation::clear):
(WebCore::ApplyPropertyAnimation::initial):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::accessAnimations):
(WebCore::ApplyPropertyAnimation::animations):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyAnimation::createHandler):
(ApplyPropertyOutlineStyle):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyOutlineStyle::createHandler):
(ApplyPropertyResize):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyResize::createHandler):
(ApplyPropertyVerticalAlign):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyVerticalAlign::createHandler):
(ApplyPropertyAspectRatio):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyAspectRatio::createHandler):
(ApplyPropertyZoom):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyZoom::createHandler):
(ApplyPropertyDisplay):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyDisplay::createHandler):
(ApplyPropertyFlex):
(WebCore::ApplyPropertyFlex::applyInheritValue):
(WebCore::ApplyPropertyFlex::applyInitialValue):
(WebCore::ApplyPropertyFlex::applyValue):
(WebCore::ApplyPropertyFlex::createHandler):
(WebCore::ApplyPropertyFlex::getFlexValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleBuilder.h: Renamed from Source/WebCore/css/CSSStyleApplyProperty.h.
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
(WebCore::PropertyHandler::isValid):
(WebCore::PropertyHandler::inheritFunction):
(WebCore::PropertyHandler::initialFunction):
(WebCore::PropertyHandler::applyFunction):
(StyleBuilder):
(WebCore::StyleBuilder::propertyHandler):
(WebCore::StyleBuilder::index):
(WebCore::StyleBuilder::valid):
(WebCore::StyleBuilder::setPropertyHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 14:51:57 +0000 (14:51 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84726

Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.

* Scripts/webkitpy/test/test_finder.py:
(TestFinder._default_names):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore::EventTarget::addEventListener crash
fmalita@chromium.org [Tue, 24 Apr 2012 14:49:36 +0000 (14:49 +0000)]
WebCore::EventTarget::addEventListener crash
https://bugs.webkit.org/show_bug.cgi?id=84171

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Test: svg/custom/use-tref-crash.svg

Adding tref target event listeners while building the shadow tree is
problematic, because SVGUseElement::buildShadowAndInstanceTree() only
sets the element instance<->shadow element association at a later time.

Fortunately, buildShadowAndInstanceTree() also propagates the event
handlers (transferEventListenersToShadowTree) - so we can simply skip
them in SVGTRefElement::buildPendingResource() for shadow elements.

* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::buildPendingResource):

LayoutTests:

Reviewed by Nikolas Zimmermann.

* svg/custom/use-tref-crash-expected.txt: Added.
* svg/custom/use-tref-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClickable area of a calendar picker indicator is too small.
tkent@chromium.org [Tue, 24 Apr 2012 14:47:23 +0000 (14:47 +0000)]
Clickable area of a calendar picker indicator is too small.
https://bugs.webkit.org/show_bug.cgi?id=84677

Reviewed by Kentaro Hara.

Test: fast/forms/date/date-appearance.html is affected.

* css/html.css:
(input::-webkit-calendar-picker-indicator):
- Remove unnecessary disaplay:inline-block.
- Add paddings instead of the margin.
(input::-webkit-calendar-picker-indicator:hover):
Add hover style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 14:29:23 +0000 (14:29 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84724

Mark platform/chromium/media/video-frame-size-change.html as flaky on Mac 10.6.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 14:22:50 +0000 (14:22 +0000)]
[Chromium] Unreviewed test expectations update.
http://crbug.com/31623

Mark http/tests/appcache/remove-cache.html as flaky on Mac 10.6.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 14:16:19 +0000 (14:16 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84720

Mark fast/repaint/fixed-right-in-page-scale.html as flaky in debug mode.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 14:09:40 +0000 (14:09 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84719

Mark svg/text/select-text-svgfont.html as flaky on Windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother unreviewed build fix for Mac.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 13:50:57 +0000 (13:50 +0000)]
Another unreviewed build fix for Mac.

* css/CSSStyleSelector.h:
(CSSStyleSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable Web Timing
commit-queue@webkit.org [Tue, 24 Apr 2012 13:48:27 +0000 (13:48 +0000)]
[EFL] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=84705

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-24
Reviewed by Tony Gentilcore.

.:

Enable Web Timing in EFL port for for performance profiling and
improvement.

* Source/cmake/OptionsEfl.cmake:

Tools:

Enable web timing by default whenever build-webkit is used.

* Scripts/build-webkit:

LayoutTests:

Unskip the test cases that require Web Timing now that it is enabled
by default in EFL port.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix attempt for Mac.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 13:44:08 +0000 (13:44 +0000)]
Unreviewed build fix attempt for Mac.

* rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 13:28:10 +0000 (13:28 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=65063

Unmark as failing on Mac 10.6 css2.1/t0905-c414-flt-01-d-g.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename CSSStyleApplyProperty class to StyleBuilder.
alexis.menard@openbossa.org [Tue, 24 Apr 2012 13:28:06 +0000 (13:28 +0000)]
Rename CSSStyleApplyProperty class to StyleBuilder.
https://bugs.webkit.org/show_bug.cgi?id=84711

Reviewed by Antti Koivisto.

As per discussion on bug https://bugs.webkit.org/show_bug.cgi?id=42764
the name is a bit confusing. This first patch rename the class and a
following one will rename the files. We also drop the CSS prefix of the
class to keep CSS prefixed classes for CSSOM types.

No new tests : renaming, no behavior changes should appear.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::StyleBuilder::sharedStyleBuilder):
(WebCore::StyleBuilder::StyleBuilder):
* css/CSSStyleApplyProperty.h:
(WebCore):
(StyleBuilder):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 13:21:03 +0000 (13:21 +0000)]
[Chromium] Unreviewed test expectations update.

Unmark as failing on Mac 10.5 the following tests:
    fast/backgrounds/size/backgroundSize15.html
    fast/events/reveal-link-when-focused.html
    fast/frames/content-opacity-1.html
    fast/frames/content-opacity-2.html
    fast/xsl/xslt-extra-content-at-end.xml
    printing/return-from-printing-mode.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 13:03:41 +0000 (13:03 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=82628

Unmark svg/hittest/svg-ellipse-non-scale-stroke.xhtml -- passes for a long time.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 12:56:48 +0000 (12:56 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=75161

Unmark media/video-poster-blocked-by-willsendrequest.html -- fails no more after FFmpeg roll 132717:133551 in Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 12:49:43 +0000 (12:49 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84714

Mark compositing/geometry/empty-embed-rects.html as flaky on Mac 10.6.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge LocalizedCalendar into LocalizedDate
tkent@chromium.org [Tue, 24 Apr 2012 12:49:03 +0000 (12:49 +0000)]
Merge LocalizedCalendar into LocalizedDate
https://bugs.webkit.org/show_bug.cgi?id=84685

Reviewed by Kentaro Hara.

The functionality of LocalizedCalendar is very related to
LocalizedDate. We should merge them.

No new tests. Just refactoring.

* WebCore.gypi: Remove LocalizedCalendar.h and LocalizedCalenderICU.cpp.
* html/shadow/CalendarPickerElement.cpp:
Include LocalizedDate.h instead of LocalizedCalendar.h.
* platform/text/LocalizedCalendar.h:
Removed. Merged into LocalizedDate.h.
* platform/text/LocalizedCalendarICU.cpp:
Removed. Merged into LocalizedDateICU.h.
* platform/text/LocalizedDate.h:
(WebCore): Move some functions from LocalizedCalendar.h.
* platform/text/LocalizedDateICU.cpp:
Move some functions from LocalizedCalendarICU.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 12:41:59 +0000 (12:41 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84712

Mark http/tests/inspector/network/x-frame-options-deny.html as flaky on Vista.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix some more GTK baselines after r114836.
philn@webkit.org [Tue, 24 Apr 2012 12:40:30 +0000 (12:40 +0000)]
Unreviewed, fix some more GTK baselines after r114836.

* platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
* platform/gtk/fast/dom/importNodeHTML-expected.txt:
* platform/gtk/fast/dom/importNodeXML-expected.txt:
* platform/gtk/fast/dom/inner-text-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dom/outerText-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/dom/row-inner-text-expected.txt:
* platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:
* platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt:
* platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt:
* platform/gtk/fast/dom/tabindex-clamp-expected.txt:
* platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skipped a test because JSC doesn't support heap profiling.
ossy@webkit.org [Tue, 24 Apr 2012 12:39:33 +0000 (12:39 +0000)]
[Qt] Gardening. Skipped a test because JSC doesn't support heap profiling.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-24
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] Enable passing sputnik tests
commit-queue@webkit.org [Tue, 24 Apr 2012 12:31:51 +0000 (12:31 +0000)]
[EFL] [DRT] Enable passing sputnik tests
https://bugs.webkit.org/show_bug.cgi?id=84600

Unreviewed, unskip sputnik tests which are passing now.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-24

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move tests that require link prefetching to test expectations
commit-queue@webkit.org [Tue, 24 Apr 2012 11:33:22 +0000 (11:33 +0000)]
[EFL] Move tests that require link prefetching to test expectations
https://bugs.webkit.org/show_bug.cgi?id=84673

Unreviewed, test expectations update.

Move tests that require link prefetching to test expectations since it
is disabled by default.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-24

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove pure delegation code from DebuggerPresentationModel
pfeldman@chromium.org [Tue, 24 Apr 2012 11:24:32 +0000 (11:24 +0000)]
Web Inspector: remove pure delegation code from DebuggerPresentationModel
https://bugs.webkit.org/show_bug.cgi?id=84704

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change removes the code that delegates calls to breakpoint manager and exposes the breakpoint
manager in debugger presentation model itself. It allows narrowing dpm dependencies.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointContextMenu):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.debuggerPausedDetails):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):
(WebInspector.DebuggerModel.prototype.isPaused):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.get breakpointManager):
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.consoleMessagesCleared):
(WebInspector.JavaScriptSource.prototype.findBreakpoint):
(WebInspector.JavaScriptSource.prototype.setBreakpoint):
(WebInspector.JavaScriptSource.prototype.setBreakpointEnabled):
(WebInspector.JavaScriptSource.prototype.removeBreakpoint):
(WebInspector.JavaScriptSource.prototype.updateBreakpoint):
(WebInspector.JavaScriptSource.prototype.continueToLine):
(WebInspector.JavaScriptSource.prototype.canSetContent):
(WebInspector.JavaScriptSource.prototype.setContent):
(WebInspector.JavaScriptSource.prototype.updateBreakpointsAfterLiveEdit):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._getPopoverAnchor):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover.showObjectPopover):
(WebInspector.JavaScriptSourceFrame.prototype._resolveObjectForPopover):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetUILocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/pause-in-inline-script.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: native nodes may have snapshot id less than base snapshot max JS object id
yurys@chromium.org [Tue, 24 Apr 2012 11:23:22 +0000 (11:23 +0000)]
Web Inspector: native nodes may have snapshot id less than base snapshot max JS object id
https://bugs.webkit.org/show_bug.cgi?id=84681

Make sure new nodes whose IDs less than base snapshot max JS object id will
get into snapshot delta.

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/profiler/heap-snapshot-comparison-dom-groups-change.html

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._calculateDiffForClass):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid): Drive-by fix, made recursion counter
a normal field on HeapSnapshotSortableDataGrid.
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):

LayoutTests:

* inspector/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt: Added.
* inspector/profiler/heap-snapshot-comparison-dom-groups-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, unflag tests passing after r114796.
philn@webkit.org [Tue, 24 Apr 2012 11:08:25 +0000 (11:08 +0000)]
Unreviewed, unflag tests passing after r114796.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115000.
commit-queue@webkit.org [Tue, 24 Apr 2012 11:03:16 +0000 (11:03 +0000)]
Unreviewed, rolling out r115000.
http://trac.webkit.org/changeset/115000
https://bugs.webkit.org/show_bug.cgi?id=84703

Breaks webkit_unit_tests on Mac in Chromium:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/15157
(Requested by mnaganov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24

Source/WebCore:

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::paintIsOpaque):
(WebCore::OpaqueRegionSkia::popCanvasLayer):
(WebCore::OpaqueRegionSkia::didDraw):
(WebCore::OpaqueRegionSkia::didDrawUnbounded):
(WebCore::OpaqueRegionSkia::markRectAsOpaque):
(WebCore::OpaqueRegionSkia::markRectAsNonOpaque):
* platform/graphics/skia/OpaqueRegionSkia.h:
(OpaqueRegionSkia):
(WebCore::OpaqueRegionSkia::CanvasLayerState::CanvasLayerState):
(CanvasLayerState):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::restoreLayer):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Tue, 24 Apr 2012 10:53:08 +0000 (10:53 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 10:43:27 +0000 (10:43 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=79454

Mark svg/text/text-rescale.html as flaky on release Linux as well.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 10:36:51 +0000 (10:36 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84696

Mark fast/workers/storage/interrupt-database.html as flaky on Mac 10.6

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 10:34:26 +0000 (10:34 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84698

Mark fast/forms/placeholder-position.html as flaky on Linux

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening
ossy@webkit.org [Tue, 24 Apr 2012 10:18:16 +0000 (10:18 +0000)]
[Qt] Gardening

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-04-24
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip http/tests/notifications/icon-exists-cancel.html, because it fails from r115011.
* platform/qt/fast/forms/form-collection-radio-node-list-expected.txt: Added after r115009.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update, mark some tests as
philn@webkit.org [Tue, 24 Apr 2012 10:17:17 +0000 (10:17 +0000)]
Unreviewed, GTK test_expectations update, mark some tests as
failing and remove wrong baselines.

* platform/gtk/fast/events/attempt-scroll-with-no-scrollbars-expected.txt: Removed.
* platform/gtk/fast/events/mouse-relative-position-expected.txt: Removed.
* platform/gtk/fast/events/panScroll-click-hyperlink-expected.txt: Removed.
* platform/gtk/fast/events/selectstart-by-double-triple-clicks-expected.txt: Removed.
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Restore x-position when restoring previous zoom-level.
commit-queue@webkit.org [Tue, 24 Apr 2012 09:41:31 +0000 (09:41 +0000)]
[Qt] Restore x-position when restoring previous zoom-level.
https://bugs.webkit.org/show_bug.cgi?id=84591

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
Reviewed by Simon Hausmann.

Tap-to-zoom fits content to width, therefore it is essentional that
the content is refitted to width when zooming out.

This patch pairs horizontal position and scale on the zoom-out stack.

Additionally it fixes a problem with not detecting zoom-out properly
due to floating point errors.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::fuzzyCompare):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
(WebKit::QtViewportInteractionEngine::ScaleStackItem::ScaleStackItem):
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 09:40:48 +0000 (09:40 +0000)]
[Chromium] Unreviewed test expectations update.

Fix lint error in the test expectations file.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, re-add the GTK baselines that were removed during last
philn@webkit.org [Tue, 24 Apr 2012 09:38:57 +0000 (09:38 +0000)]
Unreviewed, re-add the GTK baselines that were removed during last
rebaseline of doom (like r114836 and likely other commits).

* platform/gtk/: Fix empty baselines...
* platform/gtk/editing/selection/5195166-1-expected.txt: Added.
* platform/gtk/fast/html/details-marker-style-expected.txt: Added.
* platform/gtk/fast/images/support-broken-image-delegate-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 09:34:48 +0000 (09:34 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84689

Mark fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html as flaky on Mac 10.6

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] move tests that require LayoutTestController's layerTreeAsText to test expectations
commit-queue@webkit.org [Tue, 24 Apr 2012 09:32:06 +0000 (09:32 +0000)]
[EFL] move tests that require LayoutTestController's layerTreeAsText to test expectations
https://bugs.webkit.org/show_bug.cgi?id=84671

Unreviewed, test expectations update.

Moving test cases which require layerTreeAsText from Skipped list to
test expectations.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-04-24

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 09:28:02 +0000 (09:28 +0000)]
[Chromium] Unreviewed test expectations update.
https://bugs.webkit.org/show_bug.cgi?id=84688

Mark compositing/animation/computed-style-during-delay.html as flaky on Mac 10.6

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConsolidate external stylesheet quirks handling to StyleSheetInternal
antti@apple.com [Tue, 24 Apr 2012 09:17:18 +0000 (09:17 +0000)]
Consolidate external stylesheet quirks handling to StyleSheetInternal
https://bugs.webkit.org/show_bug.cgi?id=84632

Reviewed by Andreas Kling.

Move the repeated code from StyleImportRule and HTMLLinkElement to StyleSheetInternal::parseUserStyleSheet.

Remove a BUILDING_ON_LEOPARD-only quirk.

* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
* css/CSSParser.cpp:
(WebCore):
(WebCore::CSSParserContext::CSSParserContext):

    Add new settings bits to the CSSParserContext. These are used for external stylesheet parsing quirks.

* css/CSSParserMode.h:
(CSSParserContext):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::parseUserStyleSheet):
(WebCore::StyleSheetInternal::parseString):
(WebCore):
(WebCore::StyleSheetInternal::parseStringAtLine):
* css/CSSStyleSheet.h:
(WebCore):
(StyleSheetInternal):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] All of <datalist> tests are passing.
tkent@chromium.org [Tue, 24 Apr 2012 09:16:50 +0000 (09:16 +0000)]
[Chromium] All of <datalist> tests are passing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed test expectations update.
mnaganov@chromium.org [Tue, 24 Apr 2012 09:09:35 +0000 (09:09 +0000)]
[Chromium] Unreviewed test expectations update.

Mark certain media tests after FFmpeg roll in Chromium:
    media/media-controller-playback.html
    media/track/track-cues-missed.html
    media/track/track-cues-pause-on-exit.html
    media/track/track-cues-sorted-before-dispatch.html
    media/video-colorspace-yuv422.html
    media/video-currentTime-delay.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations and another media rebaseline
philn@webkit.org [Tue, 24 Apr 2012 09:06:24 +0000 (09:06 +0000)]
Unreviewed, GTK test_expectations and another media rebaseline
after r114957.

* platform/gtk/fast/forms/large-toggle-elements-expected.txt:
* platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-controls-clone-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115013 268f45cc-cd09-0410-ab3c-d52691b4dbfc