WebKit-https.git
7 years agoRemove some failing layout tests results added in
jhoneycutt@apple.com [Tue, 19 Jun 2012 19:48:27 +0000 (19:48 +0000)]
Remove some failing layout tests results added in
http://trac.webkit.org/changeset/119285 and
http://trac.webkit.org/changeset/119295. Most of these tests pass
without the failing results. Only one of them passes with the failing
result; compositing/layer-creation/spanOverlapsCanvas.html. I left that
failing result in place.

Rubber-stamped by Alexey Proskuryakov.

* platform/win/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
* platform/win/compositing/geometry/foreground-layer-expected.txt: Removed.
* platform/win/compositing/geometry/foreground-offset-change-expected.txt: Removed.
* platform/win/compositing/geometry/horizontal-scroll-composited-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-expected.txt: Removed.
* platform/win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
* platform/win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Removed.
* platform/win/compositing/geometry/outline-change-expected.txt: Removed.
* platform/win/compositing/geometry/partial-layout-update-expected.txt: Removed.
* platform/win/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
* platform/win/compositing/geometry/root-layer-update-expected.txt: Removed.
* platform/win/compositing/geometry/tall-page-composited-expected.txt: Removed.
* platform/win/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Removed.
* platform/win/compositing/geometry/vertical-scroll-composited-expected.txt: Removed.
* platform/win/compositing/geometry/video-opacity-overlay-expected.txt: Removed.
* platform/win/compositing/iframes/become-composited-nested-iframes-expected.txt: Removed.
* platform/win/compositing/iframes/become-overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/composited-iframe-alignment-expected.txt: Removed.
* platform/win/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
* platform/win/compositing/iframes/composited-parent-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-delayed-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt: Removed.
* platform/win/compositing/iframes/connect-compositing-iframe3-expected.txt: Removed.
* platform/win/compositing/iframes/enter-compositing-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-copy-on-scroll-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-in-composited-layer-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-resize-expected.txt: Removed.
* platform/win/compositing/iframes/iframe-size-from-zero-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/win/compositing/iframes/layout-on-compositing-change-expected.txt: Removed.
* platform/win/compositing/iframes/nested-iframe-scrolling-expected.txt: Removed.
* platform/win/compositing/iframes/overlapped-iframe-expected.txt: Removed.
* platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
* platform/win/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
* platform/win/compositing/iframes/resizer-expected.txt: Removed.
* platform/win/compositing/iframes/scrolling-iframe-expected.txt: Removed.
* platform/win/compositing/images: Removed.
* platform/win/compositing/images/clip-on-directly-composited-image-expected.txt: Removed.
* platform/win/compositing/images/direct-image-background-color-expected.txt: Removed.
* platform/win/compositing/images/direct-pdf-image-expected.txt: Removed.
* platform/win/compositing/images/direct-svg-image-expected.txt: Removed.
* platform/win/compositing/layer-creation/fixed-position-out-of-view-expected.txt: Removed.
* platform/win/compositing/layer-creation/overflow-scroll-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-animation-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
* platform/win/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
* platform/win/compositing/layer-creation/rotate3d-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
* platform/win/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
* platform/win/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
* platform/win/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
* platform/win/compositing/masks: Removed.
* platform/win/compositing/masks/direct-image-mask-expected.txt: Removed.
* platform/win/compositing/masks/masked-ancestor-expected.txt: Removed.
* platform/win/compositing/masks/multiple-masks-expected.txt: Removed.
* platform/win/compositing/masks/simple-composited-mask-expected.txt: Removed.
* platform/win/compositing/overflow/ancestor-overflow-expected.txt: Removed.
* platform/win/compositing/overflow/clip-descendents-expected.txt: Removed.
* platform/win/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
* platform/win/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-compositing-descendant-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-positioning-expected.txt: Removed.
* platform/win/compositing/overflow/overflow-scrollbar-layers-expected.txt: Removed.
* platform/win/compositing/overflow/resize-painting-expected.txt: Removed.
* platform/win/compositing/rtl: Removed.
* platform/win/compositing/rtl/rtl-absolute-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-iframe-relative-expected.txt: Removed.
* platform/win/compositing/rtl/rtl-relative-expected.txt: Removed.
* platform/win/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
* platform/win/compositing/visibility: Removed.
* platform/win/compositing/visibility/layer-visible-content-expected.txt: Removed.
* platform/win/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIt should be possible to look at disassembly
fpizlo@apple.com [Tue, 19 Jun 2012 19:42:55 +0000 (19:42 +0000)]
It should be possible to look at disassembly
https://bugs.webkit.org/show_bug.cgi?id=89319

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This imports the udis86 disassembler library. The library is placed
behind an abstraction in disassembler/Disassembler.h, so that we can
in the future use other disassemblers (for other platforms) whenever
appropriate. As a first step, the disassembler is being invoked for
DFG verbose dumps.

If we ever want to merge a new version of udis86 in the future, I've
made notes about changes I made to the library in
disassembler/udis86/differences.txt.

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* JavaScriptCore.pri:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* disassembler: Added.
* disassembler/Disassembler.h: Added.
(JSC):
(JSC::tryToDisassemble):
* disassembler/UDis86Disassembler.cpp: Added.
(JSC):
(JSC::tryToDisassemble):
* disassembler/udis86: Added.
* disassembler/udis86/differences.txt: Added.
* disassembler/udis86/itab.py: Added.
(UdItabGenerator):
(UdItabGenerator.__init__):
(UdItabGenerator.toGroupId):
(UdItabGenerator.genLookupTable):
(UdItabGenerator.genLookupTableList):
(UdItabGenerator.genInsnTable):
(genItabH):
(genItabH.UD_ITAB_H):
(genItabC):
(genItab):
(main):
* disassembler/udis86/optable.xml: Added.
* disassembler/udis86/ud_opcode.py: Added.
(UdOpcodeTables):
(UdOpcodeTables.sizeOfTable):
(UdOpcodeTables.nameOfTable):
(UdOpcodeTables.updateTable):
(UdOpcodeTables.Insn):
(UdOpcodeTables.Insn.__init__):
(UdOpcodeTables.Insn.__init__.opcode):
(UdOpcodeTables.parse):
(UdOpcodeTables.addInsnDef):
(UdOpcodeTables.print_table):
(UdOpcodeTables.print_tree):
* disassembler/udis86/ud_optable.py: Added.
(UdOptableXmlParser):
(UdOptableXmlParser.parseDef):
(UdOptableXmlParser.parse):
(printFn):
(parse):
(main):
* disassembler/udis86/udis86.c: Added.
(ud_init):
(ud_disassemble):
(ud_set_mode):
(ud_set_vendor):
(ud_set_pc):
(ud):
(ud_insn_asm):
(ud_insn_off):
(ud_insn_hex):
(ud_insn_ptr):
(ud_insn_len):
* disassembler/udis86/udis86.h: Added.
* disassembler/udis86/udis86_decode.c: Added.
(eff_adr_mode):
(ud_lookup_mnemonic):
(decode_prefixes):
(modrm):
(resolve_operand_size):
(resolve_mnemonic):
(decode_a):
(decode_gpr):
(resolve_gpr64):
(resolve_gpr32):
(resolve_reg):
(decode_imm):
(decode_modrm_reg):
(decode_modrm_rm):
(decode_o):
(decode_operand):
(decode_operands):
(clear_insn):
(resolve_mode):
(gen_hex):
(decode_insn):
(decode_3dnow):
(decode_ssepfx):
(decode_ext):
(decode_opcode):
(ud_decode):
* disassembler/udis86/udis86_decode.h: Added.
(ud_itab_entry_operand):
(ud_itab_entry):
(ud_lookup_table_list_entry):
(sse_pfx_idx):
(mode_idx):
(modrm_mod_idx):
(vendor_idx):
(is_group_ptr):
(group_idx):
* disassembler/udis86/udis86_extern.h: Added.
* disassembler/udis86/udis86_input.c: Added.
(inp_buff_hook):
(inp_file_hook):
(ud):
(ud_set_user_opaque_data):
(ud_get_user_opaque_data):
(ud_set_input_buffer):
(ud_set_input_file):
(ud_input_skip):
(ud_input_end):
(ud_inp_next):
(ud_inp_back):
(ud_inp_peek):
(ud_inp_move):
(ud_inp_uint8):
(ud_inp_uint16):
(ud_inp_uint32):
(ud_inp_uint64):
* disassembler/udis86/udis86_input.h: Added.
* disassembler/udis86/udis86_itab_holder.c: Added.
* disassembler/udis86/udis86_syn-att.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_att):
* disassembler/udis86/udis86_syn-intel.c: Added.
(opr_cast):
(gen_operand):
(ud_translate_intel):
* disassembler/udis86/udis86_syn.c: Added.
* disassembler/udis86/udis86_syn.h: Added.
(mkasm):
* disassembler/udis86/udis86_types.h: Added.
(ud_operand):
(ud):
* jit/JITCode.h:
(JITCode):
(JSC::JITCode::tryToDisassemble):

Source/WebCore:

Reviewed by Sam Weinig.

Just fixing EFL's build system now that JSC has a new directory.

* CMakeLists.txt:

Source/WTF:

Reviewed by Sam Weinig.

Made changes to Assertions.h to make it friendly to C code again.

Added ENABLE(DISASSEMBLER) and USE(UDIS86) logic to Platform.h.

* wtf/Assertions.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdds DeviceMotionClientMock
commit-queue@webkit.org [Tue, 19 Jun 2012 19:27:48 +0000 (19:27 +0000)]
Adds DeviceMotionClientMock
https://bugs.webkit.org/show_bug.cgi?id=89220

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Adds DeviceMotionClientMock in WebCore to enable testing of DeviceMotion once it is fully implemented in WebKit.
This addition was originally included in https://bugs.webkit.org/show_bug.cgi?id=89197 but was split into a separate patch for easier review.

No new tests because DeviceMotionClientMock is designed to enable future testing and cannot be tested in itself.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/mock/DeviceMotionClientMock.cpp: Added.
(WebCore):
(WebCore::DeviceMotionClientMock::DeviceMotionClientMock):
(WebCore::DeviceMotionClientMock::setController):
(WebCore::DeviceMotionClientMock::startUpdating):
(WebCore::DeviceMotionClientMock::stopUpdating):
(WebCore::DeviceMotionClientMock::setMotion):
(WebCore::DeviceMotionClientMock::timerFired):
* platform/mock/DeviceMotionClientMock.h: Added.
(WebCore):
(DeviceMotionClientMock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regression introduced in r120646 where the svn revision isn't saved in results...
dpranke@chromium.org [Tue, 19 Jun 2012 19:22:21 +0000 (19:22 +0000)]
Fix regression introduced in r120646 where the svn revision isn't saved in results.json

Unreviewed, build fix.

It turns out that we store the svn revision two different ways
in the JSON, and I only caught one of them :(. This should fix
the other.

Also, this part of the code is poorly tested. I will investigate
adding at least a basic test for this in a separate fix.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGCActivityCallback and IncrementalSweeper should share code
mhahnenberg@apple.com [Tue, 19 Jun 2012 19:17:31 +0000 (19:17 +0000)]
GCActivityCallback and IncrementalSweeper should share code
https://bugs.webkit.org/show_bug.cgi?id=89400

Reviewed by Geoffrey Garen.

A lot of functionality is duplicated between GCActivityCallback and IncrementalSweeper.
We should extract the common functionality out into a separate class that both of them
can inherit from. This refactoring will be an even greater boon when we add the ability
to shut these two agents down in a thread-safe fashion

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/Heap.cpp:
(JSC::Heap::Heap): Move initialization down so that the JSGlobalData has a valid Heap when
we're initializing the GCActivityCallback and the IncrementalSweeper.
* heap/Heap.h:
(Heap):
* heap/HeapTimer.cpp: Added.
(JSC):
(JSC::HeapTimer::HeapTimer): Initialize the various base class data that
DefaultGCActivityCallback::commonConstructor() used to do.
(JSC::HeapTimer::~HeapTimer): Call to invalidate().
(JSC::HeapTimer::synchronize): Same functionality as the old DefaultGCActivityCallback::synchronize().
Virtual so that non-CF subclasses can override.
(JSC::HeapTimer::invalidate): Tears down the runloop timer to prevent any future firing.
(JSC::HeapTimer::timerDidFire): Callback to pass to the timer function. Casts and calls the virtual doWork().
* heap/HeapTimer.h: Added. This is the class that serves as the common base class for
both GCActivityCallback and IncrementalSweeper. It handles setting up and tearing down run loops and synchronizing
across threads for its subclasses.
(JSC):
(HeapTimer):
* heap/IncrementalSweeper.cpp: Changes to accomodate the extraction of common functionality
between IncrementalSweeper and GCActivityCallback into a common ancestor.
(JSC):
(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::create):
* heap/IncrementalSweeper.h:
(IncrementalSweeper):
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
* runtime/GCActivityCallback.h:
(GCActivityCallback):
(JSC::GCActivityCallback::willCollect):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC):
(DefaultGCActivityCallback): Remove the platform data struct. The platform data should be kept in
the class itself so as to be accessible by doWork(). Most of the platform data for CF is kept in
HeapTimer anyways, so we only need the m_delay field now.
* runtime/GCActivityCallbackBlackBerry.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::didAllocate):
* runtime/GCActivityCallbackCF.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::doWork):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
(JSC::DefaultGCActivityCallback::willCollect):
(JSC::DefaultGCActivityCallback::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix link error with fillWithEmptyClients
commit-queue@webkit.org [Tue, 19 Jun 2012 19:09:49 +0000 (19:09 +0000)]
Fix link error with fillWithEmptyClients
https://bugs.webkit.org/show_bug.cgi?id=89484

Patch by Alexandre Elias <aelias@google.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

fillWithEmptyClients() was within #if ENABLE() guard in the .cpp file
but not in the header.  There is now a caller unrelated to these ENABLEs
in WebHelperPluginImpl, so linking fails if both SVG and PAGE_POPUP
are disabled.

This function looks generic, so just remove the ENABLE guards.

No new tests. (Build fix.)

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (NRWT): Results for new non-text-only tests are always put in the most...
dpranke@chromium.org [Tue, 19 Jun 2012 18:27:29 +0000 (18:27 +0000)]
REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
https://bugs.webkit.org/show_bug.cgi?id=78127

Reviewed by Ryosuke Niwa.

Add the --add-platform-exceptions flag from ORWT, and ensure
that --new-baseline is equivalent to --reset-results
--add-platform-exceptions. Also fix the default logic for where to
put PNGs and render tree dumps if --new-test-results is true:
if --add-platform-exceptions is False, baselines should go in
the least-specific platform directory (e.g., platform/mac)
rather than the most-specific (platform/mac-snowleopard).

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner):
(SingleTestRunner.run):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._add_missing_baselines):
(SingleTestRunner._location_for_new_baseline):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._save_baseline_data):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.baseline_path):
(Port):
(Port.baseline_platform_dir):
(Port.baseline_version_dir):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RebaselineTest.assertBaselines):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline some media controller tests.
simon.fraser@apple.com [Tue, 19 Jun 2012 18:25:01 +0000 (18:25 +0000)]
Rebaseline some media controller tests.

* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNRWT should not take memory used as disk cache into account when deciding how many...
dpranke@chromium.org [Tue, 19 Jun 2012 18:21:16 +0000 (18:21 +0000)]
NRWT should not take memory used as disk cache into account when deciding how many processes to launch
https://bugs.webkit.org/show_bug.cgi?id=81379

Reviewed by Eric Seidel.

The 'free memory' calculation we were running on the mac seemed
to underestimate how many children we can run in parallel, and
it was complex. This patch replaces that calculation with a
simpler one that reserves 2GB for overhead and assumes 256MB per
DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.

Also, there was a bug where we were truncating the memory
installed on the machine to 4GB by casting to an int instead of
a long; this was probably the source of some of the earlier
problems when using total memory.

This patch also removes the no-longer-needed restrictions on the
number of workers on beefy Lion boxes for both Apple Mac and Chromium
Mac; we should now use all of the cores by default.

The memory calculations have only been implemented on the mac;
having the calculation in base.default_child_processes() was IMO
misleading, and so this patch also moves the computation into
the MacPort. I have not heard of the # of workers being an issue
on any other ports, so this should be fine.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.total_bytes_memory):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(PlatformInfo.total_bytes_memory):
(PlatformInfo.total_bytes_memory):
(PlatformInfo._win_version_tuple_from_cmd):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(TestPlatformInfo.test_total_bytes_memory):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.default_child_processes):
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_default_child_processes):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort.operating_system):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort.default_child_processes):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(TestMacPort.test_default_child_processes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in RenderInline::willBeDestroyed.
inferno@chromium.org [Tue, 19 Jun 2012 18:05:58 +0000 (18:05 +0000)]
Crash in RenderInline::willBeDestroyed.
https://bugs.webkit.org/show_bug.cgi?id=89386

Reviewed by Julien Chaffraix.

Source/WebCore:

We were unable to find the previous continuation during the process
of cleaning up empty anonymous block continuation. The reason being
that we were just looking till our immediate parent and ignoring the
fact that it can be enclosed in anonymous blocks. The change skips
over anonymous blocks in the parent chain.

Test: fullscreen/empty-anonymous-block-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):

LayoutTests:

* fullscreen/empty-anonymous-block-continuation-crash-expected.txt: Added.
* fullscreen/empty-anonymous-block-continuation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonew-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is...
dpranke@chromium.org [Tue, 19 Jun 2012 18:03:22 +0000 (18:03 +0000)]
new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
https://bugs.webkit.org/show_bug.cgi?id=85446

Reviewed by Simon Fraser.

Tools:

Embed whether pixel testing was enabled into the results.json.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(summarize_results):

LayoutTests:

This change makes results.html aware of whether pixel tests were
enabled when the tests were run; if they weren't, we ignore
expected IMAGE tests that pass instead of reporting them as
'unexpected pass'.

* fast/harness/resources/results-test.js:
(mockResults):
* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the -webkit-match-nearest-mail-blockquote-color property.
kling@webkit.org [Tue, 19 Jun 2012 17:59:44 +0000 (17:59 +0000)]
Remove the -webkit-match-nearest-mail-blockquote-color property.
<http://webkit.org/b/89480>

Reviewed by Antti Koivisto.

Source/WebCore:

This property does nothing except taking up a bit on StyleRareNonInheritedData.
It's apparently famous for being the longest property name we support.
This passes the torch to -webkit-border-bottom-right-radius.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

* fast/css/getComputedStyle/resources/property-names.js:
* fast/dom/CSSStyleDeclaration/access-longest-css-property-expected.txt:
* fast/dom/CSSStyleDeclaration/access-longest-css-property.html:
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Animations continue to request frames after they have finished
commit-queue@webkit.org [Tue, 19 Jun 2012 17:57:24 +0000 (17:57 +0000)]
[BlackBerry] Animations continue to request frames after they have finished
https://bugs.webkit.org/show_bug.cgi?id=89483

Patch by Andrew Lo <anlo@rim.com> on 2012-06-19
Reviewed by Rob Buis.

Don't report that we have running animations if all the animations
are finished. This prevents unnecessary requesting of animation frames.
Internal PR165119
Internally Reviewed by Arvid Nilsson.

* platform/graphics/blackberry/LayerAnimation.cpp:
(WebCore::progress):
(WebCore::fetchIntervalEndpoints):
(WebCore::LayerAnimation::apply):
* platform/graphics/blackberry/LayerAnimation.h:
(WebCore::LayerAnimation::finished):
(WebCore::LayerAnimation::LayerAnimation):
(LayerAnimation):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::updateAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWrong repaintContainerSkipped in RenderObject::container()
inferno@chromium.org [Tue, 19 Jun 2012 17:55:23 +0000 (17:55 +0000)]
Wrong repaintContainerSkipped in RenderObject::container()
when positioned objects are enclosed in a <foreignObject>.
https://bugs.webkit.org/show_bug.cgi?id=89384

Reviewed by Simon Fraser.

No new tests. The bug was found in a code audit.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderSVGModelObject::checkIntersection
inferno@chromium.org [Tue, 19 Jun 2012 17:43:22 +0000 (17:43 +0000)]
Crash in WebCore::RenderSVGModelObject::checkIntersection
https://bugs.webkit.org/show_bug.cgi?id=89059

Reviewed by Rob Buis.

Source/WebCore:

getElementCTM updates layout causing the renderer to be destroyed. We get
the new renderer by storing the element pointer and later accessing it using
the element pointer.

Test: svg/custom/intersection-list-crash.svg

* rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):

LayoutTests:

* svg/custom/intersection-list-crash-expected.txt: Added.
* svg/custom/intersection-list-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFileWriter progress events should be throttled to 50ms
ericu@chromium.org [Tue, 19 Jun 2012 17:25:06 +0000 (17:25 +0000)]
FileWriter progress events should be throttled to 50ms
https://bugs.webkit.org/show_bug.cgi?id=89022

Reviewed by Kent Tamura.

No new tests; existing tests validate our event sequences, and testing
timing is likely to be flaky.

* Modules/filesystem/FileWriter.cpp:
(WebCore):
(WebCore::FileWriter::FileWriter):
(WebCore::FileWriter::didWrite): Throttle sending progress events.
* Modules/filesystem/FileWriter.h:
(FileWriter): Add a variable that remembers when the last event was
sent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: WebCore part of: Paginated display API doesn’t allow setting the...
mitz@apple.com [Tue, 19 Jun 2012 17:10:47 +0000 (17:10 +0000)]
Source/WebCore: WebCore part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

Updated fast/multicol/pagination-*.html.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForDocument): Changed to handle the new Pagination::Mode enum
values and set the column progression in addition to the column axis.
* page/Page.h: Changed the Pagination::Mode enum values to ones that specify an axis and a
direction along that axis.
* testing/Internals.cpp:
(WebCore::Internals::setPagination): Changed to support the new Pagination::Mode enum values.

Source/WebKit/mac: WebKit/mac part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* WebView/WebView.mm:
(-[WebView _setPaginationMode:]): Changed to map new WebPaginationMode values to new
Pagination::Mode values.
(-[WebView _paginationMode]): Similarly, in the opposite direction.
* WebView/WebViewPrivate.h: Replaced WebPaginationMode values with ones that specify an
axis and a direction along that axis.

Source/WebKit2: WebKit2 part of: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetPaginationMode): Changed to map new WKPaginationMode values to new
Pagination::Mode values.
(WKPageGetPaginationMode): Similarly, in the opposite direction.
* UIProcess/API/C/WKPagePrivate.h: Replaced WKPaginationMode values with ones that specify
an axis and a direction along that axis.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController setPaginationMode:]): Changed to handle new values.
(-[WKBrowsingContextController paginationMode]): Ditto.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Replaced
WKBrowsingContextPaginationMode values with ones that specify an axis and a direction along
that axis.

LayoutTests: Paginated display API doesn’t allow setting the page progression direction
https://bugs.webkit.org/show_bug.cgi?id=89394

Reviewed by Darin Adler.

* fast/multicol/pagination-h-horizontal-bt.html:
* fast/multicol/pagination-h-horizontal-tb.html:
* fast/multicol/pagination-h-vertical-lr.html:
* fast/multicol/pagination-h-vertical-rl.html:
* fast/multicol/pagination-v-horizontal-bt.html:
* fast/multicol/pagination-v-horizontal-tb.html:
* fast/multicol/pagination-v-vertical-lr.html:
* fast/multicol/pagination-v-vertical-rl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
aestes@apple.com [Tue, 19 Jun 2012 17:09:32 +0000 (17:09 +0000)]
[Mac] -[WebPDFView _menuItemsFromPDFKitForEvent:] leaks NSMenuItems
https://bugs.webkit.org/show_bug.cgi?id=89434

Reviewed by Darin Adler.

* WebView/WebPDFView.mm:
(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Release copied
NSMenuItems once they're stored in copiedItems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.
ossy@webkit.org [Tue, 19 Jun 2012 16:37:40 +0000 (16:37 +0000)]
[Qt][Mac] Skip new failing and crashing tests to try to paint the bot green.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 19 Jun 2012 16:21:43 +0000 (16:21 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt/animations/combo-transform-translate+scale-expected.txt: Removed.
* platform/qt/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
* platform/qt/css3/calc/getComputedStyle-margin-percentage-expected.txt: Removed.
* platform/qt/css3/filters/remove-filter-rendering-expected.txt: Removed.
* platform/qt/editing/inserting/return-key-in-hidden-field-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-noscript-expected.txt: Removed.
* platform/qt/editing/pasteboard/select-element-1-expected.txt: Removed.
* platform/qt/editing/selection/select-line-break-with-opposite-directionality-expected.txt: Removed.
* platform/qt/fast/css/border-solid-single-edge-antialias-expected.txt: Removed.
* platform/qt/fast/dom/Window/window-resize-contents-expected.txt: Removed.
* platform/qt/fast/events/mouse-relative-position-expected.txt: Removed.
* platform/qt/fast/preloader/document-write-noscript-expected.txt: Removed.
* platform/qt/fast/repaint/table-hover-on-link-expected.txt: Removed.
* platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Removed.
* platform/qt/http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt: Removed.
* platform/qt/svg/custom/acid3-test-77-expected.txt: Removed.
* platform/qt/svg/custom/circular-marker-reference-1-expected.txt: Removed.
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Removed.
* platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Removed.
* platform/qt/svg/custom/use-transfer-width-height-properties-to-svg-expected.txt: Removed.
* platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt: Removed.
* platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Removed.
* platform/qt/svg/dom/css-transforms-expected.txt: Removed.
* platform/qt/svg/dom/font-face-elements-expected.txt: Removed.
* platform/qt/svg/hixie/links/001-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 19 Jun 2012 16:15:38 +0000 (16:15 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt-5.0/fast/dom/DeviceMotion/create-event-expected.txt: Removed.
* platform/qt-5.0/fast/dom/DeviceOrientation/create-event-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
commit-queue@webkit.org [Tue, 19 Jun 2012 16:07:00 +0000 (16:07 +0000)]
Make RenderTableSection - nodeAtPoint and paintObject reuse spanning logic.
https://bugs.webkit.org/show_bug.cgi?id=88066

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-19
Reviewed by Julien Chaffraix.

Makes dirtiedRows and dirtiedColumns reuse spannedRows and spannedColumns
internally. This also changes their API to accept a damage-rect flipped
by logicalRectForWritingModeAndDirection.

The generic code in spannedRows and spannedColumns solves a few FIXMEs
surrounding RTL tables, which should improve performance.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::dirtiedRows):
(WebCore::RenderTableSection::dirtiedColumns):
(WebCore::RenderTableSection::paintObject):
* rendering/RenderTableSection.h:
(WebCore::CellSpan::start):
(WebCore::CellSpan::end):
(CellSpan):
(RenderTableSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip one more failing test.
ossy@webkit.org [Tue, 19 Jun 2012 15:59:52 +0000 (15:59 +0000)]
[Qt] Unreviewed gardening, skip one more failing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
commit-queue@webkit.org [Tue, 19 Jun 2012 15:47:29 +0000 (15:47 +0000)]
[JSC] Implement support for JSDictionary::convertValue(Vector<String>& result)
https://bugs.webkit.org/show_bug.cgi?id=89447

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Adam Barth.

Add implementation for JSDictionary::convertValue(Vector<String>& result)
so that IDBDatabase::createObjectStore() compiles with JSC.

Tests: storage/indexeddb

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead(...
aestes@apple.com [Tue, 19 Jun 2012 15:45:05 +0000 (15:45 +0000)]
[Mac] AudioFileReader::createBus() leaks an AudioBufferList if ExtAudioFileRead() returns an error
https://bugs.webkit.org/show_bug.cgi?id=89429

Reviewed by Darin Adler.

* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus): Call destroyAudioBufferList()
before returning if ExtAudioFileRead() returns an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing Typos in DeviceOrientation and DeviceMotion Tests
commit-queue@webkit.org [Tue, 19 Jun 2012 15:40:37 +0000 (15:40 +0000)]
Fixing Typos in DeviceOrientation and DeviceMotion Tests
https://bugs.webkit.org/show_bug.cgi?id=89339

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

* fast/dom/DeviceMotion/create-event-expected.txt:
* fast/dom/DeviceMotion/script-tests/create-event.js:
* fast/dom/DeviceOrientation/no-synchronous-events-expected.txt:
* fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Style Fix in WebDeviceOrientationController
commit-queue@webkit.org [Tue, 19 Jun 2012 15:38:07 +0000 (15:38 +0000)]
[Chromium] Style Fix in WebDeviceOrientationController
https://bugs.webkit.org/show_bug.cgi?id=89337

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-19
Reviewed by Steve Block.

Changing a local variable from a PassRefPtr to a RefPtr in order to be consistent with the style guide.

* src/WebDeviceOrientationController.cpp:
(WebKit::WebDeviceOrientationController::didChangeDeviceOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip one more failing test.
ossy@webkit.org [Tue, 19 Jun 2012 15:17:46 +0000 (15:17 +0000)]
[Qt] Unreviewed gardening, skip one more failing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the GTK+ build by adding some missing source files to the source list.
mrobinson@webkit.org [Tue, 19 Jun 2012 15:17:02 +0000 (15:17 +0000)]
Fix the GTK+ build by adding some missing source files to the source list.

* GNUmakefile.list.am: WebGLDepthTexture.cpp/h to the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix the Windows build when Qt is built without -release or -debug
jocelyn.turcotte@nokia.com [Tue, 19 Jun 2012 15:15:00 +0000 (15:15 +0000)]
[Qt] Fix the Windows build when Qt is built without -release or -debug
https://bugs.webkit.org/show_bug.cgi?id=89471

Reviewed by Tor Arne Vestbø.

Make sure that we at least remove build_all on Windows for api.pri,
as WebCore wasn't built for all configurations.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed typo fix.
ossy@webkit.org [Tue, 19 Jun 2012 14:25:34 +0000 (14:25 +0000)]
[Qt] Unreviewed typo fix.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the function ScriptDebugServer::supportsNativeBreakpoints()
commit-queue@webkit.org [Tue, 19 Jun 2012 14:15:14 +0000 (14:15 +0000)]
Remove the function ScriptDebugServer::supportsNativeBreakpoints()
https://bugs.webkit.org/show_bug.cgi?id=88759

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-06-19
Reviewed by Pavel Feldman.

Source/WebCore:

Since both JSC and V8 support DOM breakpoint now, remove the conditional interface and related code.
So there is no new tests.

* bindings/js/ScriptDebugServer.h:
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype._populateContextMenu):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.switchToDetailedView):
(WebInspector.NetworkLogView.prototype.switchToBriefView):
(WebInspector.NetworkDataGridNode.prototype.createCells):
(WebInspector.NetworkDataGridNode.prototype.refreshRequest):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._clearInterface):
* inspector/front-end/Settings.js:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):

Source/WebKit/chromium:

* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Make text in WebSocket Frames tab selectable
commit-queue@webkit.org [Tue, 19 Jun 2012 14:06:24 +0000 (14:06 +0000)]
Web Inspector: Make text in WebSocket Frames tab selectable
https://bugs.webkit.org/show_bug.cgi?id=89307

Patch by Nikita Vasilyev <me@elv1s.ru> on 2012-06-19
Reviewed by Yury Semikhatsky.

* inspector/front-end/ResourceWebSocketFrameView.js:
(WebInspector.ResourceWebSocketFrameView):
* inspector/front-end/networkPanel.css:
(.resource-websocket-frame-view):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Support 'Restart frame' in protocol and backend
commit-queue@webkit.org [Tue, 19 Jun 2012 14:03:48 +0000 (14:03 +0000)]
Web Inspector: Support 'Restart frame' in protocol and backend
https://bugs.webkit.org/show_bug.cgi?id=89147

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-06-19
Reviewed by Yury Semikhatsky.

Inspector.json got new command in Debugger domain.
A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
is built.
JSC implementation is a stub with fix me (40300).

* bindings/js/JSJavaScriptCallFrameCustom.cpp:
(WebCore::JSJavaScriptCallFrame::restart):
(WebCore):
* bindings/js/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
* bindings/js/ScriptDebugServer.h:
(ScriptDebugServer):
* bindings/v8/DebuggerScript.js:
(.):
* bindings/v8/JavaScriptCallFrame.cpp:
(WebCore::JavaScriptCallFrame::restart):
(WebCore):
* bindings/v8/JavaScriptCallFrame.h:
(JavaScriptCallFrame):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore):
(WebCore::ScriptDebugServer::updateCallStack):
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/ScriptFunctionCall.cpp:
(WebCore::ScriptFunctionCall::call):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::restartCallback):
(WebCore):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::restartFrame):
(WebCore):
* inspector/InjectedScript.h:
(InjectedScript):
* inspector/InjectedScriptExterns.js:
(JavaScriptCallFrame.prototype.restart):
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::restartFrame):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/JavaScriptCallFrame.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNew inspector/styles/inject-stylesheet.html fails
apavlov@chromium.org [Tue, 19 Jun 2012 14:03:15 +0000 (14:03 +0000)]
New inspector/styles/inject-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=89364

Reviewed by Zoltan Herczeg.

LayoutTestController in Chromium injects testRunner into the Inspector window, while its other implementations don't.
Additionally, testRunner.addUserStyleSheet() behavior differs across platforms: Chromium injects stylesheets
with the "Author" level, while the others do with the "User" level, so the Chromium expectation stands apart.

* inspector/styles/inject-stylesheet-expected.txt:
* inspector/styles/inject-stylesheet.html:
* platform/chromium/inspector/styles/inject-stylesheet-expected.txt: Copied from LayoutTests/inspector/styles/inject-stylesheet-expected.txt.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplaced printf with fprintf in DEBUG_AUDIONODE_REFERENCES
commit-queue@webkit.org [Tue, 19 Jun 2012 13:59:20 +0000 (13:59 +0000)]
Replaced printf with fprintf in DEBUG_AUDIONODE_REFERENCES

Change printf to fprintf in DEBUG_AUDIONODE_REFERENCES
https://bugs.webkit.org/show_bug.cgi?id=86564

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.

There is no need for new tests: writing data to stderr, instead of stdout.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::~AudioContext):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
(WebCore::AudioNode::printNodeCounts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Assert failure in svg/batik/text/textDecoration.svg,textEffect3.svg for 64bit...
commit-queue@webkit.org [Tue, 19 Jun 2012 12:59:39 +0000 (12:59 +0000)]
[GTK] Assert failure in svg/batik/text/textDecoration.svg,textEffect3.svg for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89104

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-06-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adding SVGInline to assertion to fix assertion failure. Same assertion was hit on Chromium.

Covered by existing tests
svg/batik/text/textDecoration.svg
svg/batik/text/textEffect3.svg
where the assertion failure was hit.

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting):

LayoutTests:

Removing CRASH expectations after assertion failure is now fixed.

* platform/chromium/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Create an extra atlas when there is no available buffer space.
alexis.menard@openbossa.org [Tue, 19 Jun 2012 11:43:37 +0000 (11:43 +0000)]
[Qt] Create an extra atlas when there is no available buffer space.
https://bugs.webkit.org/show_bug.cgi?id=89012

Reviewed by Noam Rosenthal.

In case of the desktop mode when we scroll the view all the tiles
are updated. It can happen that there no available buffer space for
the currently used atlas(especially when scrolling fast). In that case
we can create a new one. One future improvement could be to make a timer and
delete this extra atlas when it is not used.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::beginContentUpdateInAtlas):
(WebKit::LayerTreeHostQt::beginContentUpdate):
* WebProcess/WebPage/qt/LayerTreeHostQt.h:
(LayerTreeHostQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.
ossy@webkit.org [Tue, 19 Jun 2012 11:34:43 +0000 (11:34 +0000)]
[Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.
https://bugs.webkit.org/show_bug.cgi?id=89449

Reviewed by Simon Hausmann.

Source/WebCore:

* bridge/qt/qt_instance.h:
(QtInstance):
* bridge/qt/qt_runtime.h:
(QtField):
* platform/Widget.h:
(Widget):

Source/WebKit/qt:

* Api/qwebframe_p.h:
(QWebHitTestResultPrivate):
* Api/qwebpage_p.h:
(QWebPagePrivate):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createFrame):
* WebCoreSupport/PageClientQt.h:
(PageClientQGraphicsWidget):

Source/WebKit2:

* UIProcess/API/qt/qquicknetworkreply_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Document the versions enums where added
commit-queue@webkit.org [Tue, 19 Jun 2012 10:44:49 +0000 (10:44 +0000)]
[Qt] Document the versions enums where added
https://bugs.webkit.org/show_bug.cgi?id=89452

Patch by Albert Astals Cid <albert.astals@canonical.com> on 2012-06-19
Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: FileSystem tree should hide uninitialized FileSystem
commit-queue@webkit.org [Tue, 19 Jun 2012 10:38:32 +0000 (10:38 +0000)]
Web Inspector: FileSystem tree should hide uninitialized FileSystem
https://bugs.webkit.org/show_bug.cgi?id=88602

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/get-filesystem-root.html

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::getFileSystemRoot):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._originAdded):
(WebInspector.FileSystemModel.prototype.refreshFileSystemList):
(WebInspector.FileSystemModel.prototype._gotFileSystem):
(WebInspector.FileSystemModel.FileSystem):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype.getFileSystemRoot):
(WebInspector.FileSystemRequestManager.prototype._gotFileSystemRoot):
(WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):

LayoutTests:

* http/tests/inspector/filesystem/get-filesystem-root-expected.txt: Added.
* http/tests/inspector/filesystem/get-filesystem-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Web Inspector: remove unnecessary indirection from message loop instrument...
yurys@chromium.org [Tue, 19 Jun 2012 10:27:45 +0000 (10:27 +0000)]
[Chromium] Web Inspector: remove unnecessary indirection from message loop instrumentation
https://bugs.webkit.org/show_bug.cgi?id=89443

Removed start/stopMainThreadMonitoring methods from WebDevToolsAgentClient
and WebDevToolsAgentImpl. The functionality is now implemented inside
InspectorClientImpl.

Reviewed by Vsevolod Vlasov.

* public/WebDevToolsAgentClient.h:
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::clearBrowserCookies):
(WebKit::InspectorClientImpl::startMainThreadMonitoring):
(WebKit::InspectorClientImpl::stopMainThreadMonitoring):
(WebKit::InspectorClientImpl::willProcessTask):
(WebKit):
(WebKit::InspectorClientImpl::didProcessTask):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate webkit.org to refer to layoutTestController instead of testRunner
rniwa@webkit.org [Tue, 19 Jun 2012 10:18:21 +0000 (10:18 +0000)]
Update webkit.org to refer to layoutTestController instead of testRunner
https://bugs.webkit.org/show_bug.cgi?id=89445

Reviewed by Kent Tamura.

* quality/testwriting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Modify HTTPS port to 8443 for performance tests
zoltan@webkit.org [Tue, 19 Jun 2012 09:33:25 +0000 (09:33 +0000)]
[Qt] Modify HTTPS port to 8443 for performance tests
https://bugs.webkit.org/show_bug.cgi?id=89442

Reviewed by Ryosuke Niwa.

We should be consistent with the default HTTPS port and with the changelog of r119188.

* Scripts/webkitpy/performance_tests/perftest.py:
(ReplayServer.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce ENABLE_CSP_NEXT configuration flag.
commit-queue@webkit.org [Tue, 19 Jun 2012 09:13:52 +0000 (09:13 +0000)]
Introduce ENABLE_CSP_NEXT configuration flag.
https://bugs.webkit.org/show_bug.cgi?id=89300

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

The 1.0 draft of the Content Security Policy spec is just about to
move to Last Call. We'll hide work on the upcoming 1.1 spec behind
this ENABLE flag, disabled by default.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r120552): Many tests timing out on Windows
jhoneycutt@apple.com [Tue, 19 Jun 2012 09:12:19 +0000 (09:12 +0000)]
REGRESSION(r120552): Many tests timing out on Windows
https://bugs.webkit.org/show_bug.cgi?id=89433

Reviewed by Andy Estes.

* wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
It looks like there were two bugs:
1) the function was converting from 100ths of nanoseconds to seconds
   rather than 100s of nanoseconds to seconds by dividing by
   (nsPerSecond * 100) rather than (nsPerSecond / 100)
2) the function should've been returning milliseconds, not seconds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake StylePropertySet::merge() always override on conflict
commit-queue@webkit.org [Tue, 19 Jun 2012 09:10:09 +0000 (09:10 +0000)]
Make StylePropertySet::merge() always override on conflict
https://bugs.webkit.org/show_bug.cgi?id=89348

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-19
Reviewed by Ryosuke Niwa.

merge() was only used with argOverridesOnConflict = true, which
makes the extra parameter useless. It will also save a boolean check.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):
* css/StylePropertySet.h:
(StylePropertySet):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::styleFromMatchedRulesForElement):
(WebCore::EditingStyle::mergeStyleFromRules):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
yosin@chromium.org [Tue, 19 Jun 2012 08:57:14 +0000 (08:57 +0000)]
[Forms] Move isKeyboardFocusable and isMouseFocusable to InputType from HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=89425

Reviewed by Kent Tamura.

This patch moves implementation of HTMLInpueElement::isKeyboardFocusable
and isMouseFocusable to InputType class to allow each implementation
of InputType can decide focus-ability.

No new tests. This patch doesn't change behavior.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isKeyboardFocusable): Changed to call InputType::isKeyboardFocusable.
(WebCore::HTMLInputElement::isMouseFocusable): Changed to call InputType::isMouseFocusable.
(WebCore::HTMLInputElement::isTextFormControlFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlKeyboardFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
(WebCore::HTMLInputElement::isTextFormControlMouseFocusable): Added to allow InputType can call a method in HTMLTextFormControlElement.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
(WebCore::InputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable.
(WebCore::InputType::isMouseFocusable): Added for default method of derived InputType classes.
* html/InputType.h:
(InputType): Chagned signature of isKeyboardFocusable.
* html/RadioInputType.cpp:
(WebCore::RadioInputType::isKeyboardFocusable): Changed to call isTextFormControlKeyboardFocusable which was done in HTMLInputElement.
* html/RadioInputType.h:
(RadioInputType):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isKeyboardFocusable): Moved implementation from HTMLInputElement.
(WebCore::TextFieldInputType::isMouseFocusable): Moved implementation from HTMLInputElement.
* html/TextFieldInputType.h:
(TextFieldInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
sergio@webkit.org [Tue, 19 Jun 2012 08:55:09 +0000 (08:55 +0000)]
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582

Reviewed by David Levin.

Source/WebCore:

Added a new synchronous method to the IconDatabase that returns a
native image for the platform instead of a WebCore::Image*.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore):
* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
(IconDatabaseBase):

Source/WebKit/blackberry:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

Source/WebKit/cf:

Fixes windows build.

* WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/efl:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

Source/WebKit/gtk:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):

Source/WebKit/qt:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
* Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResou...
aestes@apple.com [Tue, 19 Jun 2012 08:45:40 +0000 (08:45 +0000)]
[Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResource()
https://bugs.webkit.org/show_bug.cgi?id=89427

Reviewed by Dan Bernstein.

loadPlatformResource() called -[NSAutoreleasePool release] at each of
its exit points, which is not only an error-prone pattern but is
incorrect in garbage-collected environments. AutodrainedPool solves
both these problems by automatically calling -[NSAutoreleasePool drain]
when going out of scope.

* platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL's LayoutTestController does not support setTextDirection
commit-queue@webkit.org [Tue, 19 Jun 2012 08:38:38 +0000 (08:38 +0000)]
[EFL] EFL's LayoutTestController does not support setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=87481

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-19
Reviewed by Hajime Morita.

Source/WebKit/efl:

Add new Ewk_View method to set the text direction, by calling
Editor::setBaseWritingDirection() internally, as Mac and Chromium
ports do.

* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_view.cpp:
(ewk_view_text_direction_set):
* ewk/ewk_view.h:

Tools:

Implement setTextDirection in EFL's LayoutTestController and
properly reset its value between test cases to avoid flakiness.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTextDirection):

LayoutTests:

Unskip related test case now that EFL's LayoutTestController
implements setTextDirection.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompilation failure in StyleResolver.cpp
rniwa@webkit.org [Tue, 19 Jun 2012 08:36:28 +0000 (08:36 +0000)]
Compilation failure in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=89446

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Ryosuke Niwa.

Adding 'CSSPropertyWebkitColumnProgression' to a switch statement from
which it was missing.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed build system fix after r120051.
ossy@webkit.org [Tue, 19 Jun 2012 08:23:56 +0000 (08:23 +0000)]
[Qt] Unreviewed build system fix after r120051.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r120586.
commit-queue@webkit.org [Tue, 19 Jun 2012 08:15:21 +0000 (08:15 +0000)]
Unreviewed, rolling out r120586.
http://trac.webkit.org/changeset/120586
https://bugs.webkit.org/show_bug.cgi?id=89444

doesn't fix mac issue (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-19

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::replaceMisspelledRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Temporarily disable xvfb driver in nrwt
kkristof@inf.u-szeged.hu [Tue, 19 Jun 2012 07:40:43 +0000 (07:40 +0000)]
[Qt] Temporarily disable xvfb driver in nrwt
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed expectation update.
morrita@google.com [Tue, 19 Jun 2012 07:35:55 +0000 (07:35 +0000)]
Unreviewed expectation update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Allow the modules file generation to work on Windows.
hausmann@webkit.org [Tue, 19 Jun 2012 07:35:06 +0000 (07:35 +0000)]
[Qt] Allow the modules file generation to work on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89010

Patch by Joel Dillon  <joel.dillon@codethink.co.uk>, Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Csaba Osztrogonác.

Add calls to toSystemPath and use QMAKE_DIR_SEP where necessary.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
hausmann@webkit.org [Tue, 19 Jun 2012 07:32:50 +0000 (07:32 +0000)]
[Qt] Fix TARGET not properly being set for QtWebKitd5.dll when building in debug.
https://bugs.webkit.org/show_bug.cgi?id=88880

load(qt_module_config) adjusts the TARGET to add the "d" suffix when doing
the debug build_pass. When doing the first pass, qt_module_config.prf doesn't
adjust the target since it is in debug_and_release and expects the debug
build_pass to come later. However, since we remove debug_and_release from CONFIG
right after this, the TARGET hasn't been adjusted and the debug build_pass
will not happen.

Work around it by disabling this optimization on Windows.

Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2012-06-19
Reviewed by Tor Arne Vestbø.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a scheme registry for bypassing Content Security Policy.
commit-queue@webkit.org [Tue, 19 Jun 2012 07:27:33 +0000 (07:27 +0000)]
Add a scheme registry for bypassing Content Security Policy.
https://bugs.webkit.org/show_bug.cgi?id=89373

Patch by Mike West <mkwst@chromium.org> on 2012-06-19
Reviewed by Adam Barth.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

The Content Security Policy specification notes that "Enforcing a CSP
policy should not interfere with the operation of user-supplied scripts
such as third-party user-agent add-ons and JavaScript bookmarklets."
(https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model)
This use case can be at least partially addressed by adding a scheme
registry for certain types of URLs whose resources should be loaded
regardless of a page's defined policy directives.

See http://crbug.com/133223 for additional context.

Test: http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html

* WebCore.exp.in:
    Exporting new symbols for use by Internals.
* page/ContentSecurityPolicy.cpp:
(WebCore::isAllowedByAllWithURL):
    Adding a check against the new SchemeRegistry method to determine
    whether or not we should proceed with checking the URL against the
    policy.
* platform/SchemeRegistry.cpp:
(WebCore::CSPBypassingSchemes):
(WebCore):
(WebCore::SchemeRegistry::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
(WebCore::SchemeRegistry::schemeShouldBypassContentSecurityPolicy):
* platform/SchemeRegistry.h:
(SchemeRegistry):
    Adding the scheme registry for CSP-bypassing URL schemes.
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebCore::Internals::removeURLSchemeRegisteredAsBypassingContentSecurityPolicy):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
    Adding a method to Internals so that we can write a layout test.

Source/WebKit/chromium:

* public/WebSecurityPolicy.h:
(WebSecurityPolicy):
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::registerURLSchemeAsBypassingContentSecurityPolicy):
(WebKit):

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* http/tests/security/contentSecurityPolicy/register-bypassing-scheme-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in fast/canvas, clip, compact, constru...
rniwa@webkit.org [Tue, 19 Jun 2012 07:23:13 +0000 (07:23 +0000)]
Use testRunner instead of layoutTestController in fast/canvas, clip, compact, constructors, cookies, and css* tests
https://bugs.webkit.org/show_bug.cgi?id=89431

Reviewed by Kent Tamura.

* fast/canvas/:
* fast/constructors/constructor-as-function-crash.html:
* fast/css-generated-content/absolute-position-inside-inline.html:
* fast/css-generated-content/after-with-first-letter-float-crash.html:
* fast/css-generated-content/attr-missing.html:
* fast/css-generated-content/before-content-with-list-marker-in-anon-block-crash.html:
* fast/css-generated-content/block-after.html:
* fast/css-generated-content/drag-state.html:
* fast/css-generated-content/empty-content-with-float-crash.html:
* fast/css-generated-content/first-letter-next-sibling-crash.html:
* fast/css-generated-content/first-letter-table-cell-format-block-crash.html:
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html:
* fast/css-generated-content/floating-before-content-with-list-marker-crash.html:
* fast/css-generated-content/hit-test-generated-content.html:
* fast/css-generated-content/hover-style-change.html:
* fast/css-generated-content/inline-splitting-with-after-float-crash.html:
* fast/css-generated-content/malformed-url.html:
* fast/css-generated-content/positioned-background-hit-test-crash.html:
* fast/css-generated-content/positioned-div-with-floating-after-content-crash.html:
* fast/css-generated-content/positioned-generated-content-under-run-in-crash.html:
* fast/css-generated-content/remove-div-from-flexible-box-with-floating-after-content-crash.html:
* fast/css-generated-content/reset-content-to-initial.html:
* fast/css-generated-content/resources/pass.html:
* fast/css-generated-content/resources/positioned-div-with-floating-after-content-crash-frame2.html:
* fast/css-generated-content/spellingToolTip-assert.html:
* fast/css-generated-content/table-row-after-no-crash.html:
* fast/css-generated-content/table-with-scrollbar-corner.html:
* fast/css-generated-content/text-before-table-col-crash.html:
* fast/css-grid-layout/display-grid-set-get.html:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
* fast/css-grid-layout/grid-columns-rows-get-set.html:
* fast/css-grid-layout/grid-item-column-row-get-set.html:
* fast/css/:
* platform/mac/fast/canvas/canvas-draw-xbm-image.html:
* platform/qt/fast/canvas/toDataURL-jpeg-alpha.html:
* platform/qt/fast/canvas/toDataURL-jpeg-primarycolors.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-basic.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-notnumber.html:
* platform/qt/fast/canvas/toDataURL-jpeg-quality-outsiderange.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip failing tests.
ossy@webkit.org [Tue, 19 Jun 2012 06:52:57 +0000 (06:52 +0000)]
[Qt] Unreviewed gardening, skip failing tests.

* platform/qt-4.8/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse testRunner instead of layoutTestController in fast/animation, autoresize, backgro...
rniwa@webkit.org [Tue, 19 Jun 2012 06:35:17 +0000 (06:35 +0000)]
Use testRunner instead of layoutTestController in fast/animation, autoresize, backgrounds, block, body-propagation, borders, and box-* tests
https://bugs.webkit.org/show_bug.cgi?id=89422

Reviewed by Kent Tamura.

* fast/animation/request-animation-frame-detach-element.html:
* fast/animation/request-animation-frame-detach-element2.html:
* fast/animation/request-animation-frame-disabled.html:
* fast/animation/request-animation-frame-during-modal.html:
* fast/animation/request-animation-frame-iframe.html:
* fast/animation/script-tests/request-animation-frame-cancel.js:
* fast/animation/script-tests/request-animation-frame-cancel2.js:
* fast/animation/script-tests/request-animation-frame-disabled.js:
* fast/animation/script-tests/request-animation-frame-timestamps-advance.js:
* fast/animation/script-tests/request-animation-frame-timestamps.js:
* fast/animation/script-tests/request-animation-frame-within-callback.js:
* fast/animation/script-tests/request-animation-frame.js:
* fast/autoresize/autoresize-with-iframe.html:
* fast/autoresize/basic.html:
* fast/autoresize/turn-off-autoresize.html:
* fast/backgrounds/animated-gif-as-background.html:
* fast/backgrounds/animated-svg-as-mask.html:
* fast/backgrounds/background-fast-path-simple-color.html:
* fast/backgrounds/background-fill-zero-area-crash.html:
* fast/backgrounds/background-repeat-computed-style.html:
* fast/backgrounds/multiple-backgrounds-assert.html:
* fast/backgrounds/root-background-propagation.html:
* fast/backgrounds/root-background-propagation2.html:
* fast/backgrounds/size/contain-and-cover-zoomed.html:
* fast/backgrounds/solid-color-context-restore.html:
* fast/block/:
* fast/borders/border-image-reset-by-border-shorthand.html:
* fast/borders/border-image-slice-omission.html:
* fast/borders/border-mixed-alpha.html:
* fast/borders/border-radius-complex-inner.html:
* fast/borders/border-radius-parsing.html:
* fast/borders/negative-border-width.html:
* fast/borders/outline-alpha-block.html:
* fast/borders/outline-alpha-inline.html:
* fast/box-shadow/box-shadow-clipped-slices.html:
* fast/box-shadow/box-shadow-currentcolor.html:
* fast/box-shadow/no-blur-multiple-offsets.html:
* fast/box-shadow/resources/box-shadow-overflow-scroll.js:
* fast/box-shadow/spread-multiple-inset.html:
* fast/box-shadow/spread-multiple-normal.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
aestes@apple.com [Tue, 19 Jun 2012 06:33:44 +0000 (06:33 +0000)]
[Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow
https://bugs.webkit.org/show_bug.cgi?id=89424

Reviewed by Dan Bernstein.

* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart): Store the NSShadow
in a RetainPtr so that it's released before going out of scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Introduce a class to represent restoring state of a form control
tkent@chromium.org [Tue, 19 Jun 2012 06:20:48 +0000 (06:20 +0000)]
Refactoring: Introduce a class to represent restoring state of a form control
https://bugs.webkit.org/show_bug.cgi?id=89412

Reviewed by Hajime Morita.

HTMLFormControlElementWithState::saveFormControlState had two return
values; One is a boolean to represent whether we should save the state
or not, and another is form control value. This patch introduces
FormControlState class representing these values.

We're going to extend FormControlState class so that it can contain
multiple strings to fix a FileInputType issue and it have another type
to fix Bug 89409.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormController::formElementsState):
Gets a state string from a FormControlState instance.
(WebCore::FormController::takeStateForFormElement):
Creates a FormControlState instance with a state string.
* html/FormController.h:
(WebCore::FormControlState): Added.

* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::saveFormControlState):
Use FormControlState class.
(WebCore::BaseCheckableInputType::restoreFormControlState): ditto.
* html/BaseCheckableInputType.h:
(BaseCheckableInputType): ditto.
* html/FileInputType.cpp:
(WebCore::FileInputType::saveFormControlState): ditto.
(WebCore::FileInputType::restoreFormControlState): ditto.
* html/FileInputType.h:
(FileInputType): ditto.
* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::saveFormControlState): ditto.
(WebCore::HTMLFormControlElementWithState::finishParsingChildren): ditto.
* html/HTMLFormControlElementWithState.h:
(HTMLFormControlElementWithState): ditto.
(WebCore::HTMLFormControlElementWithState::restoreFormControlState): ditto.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::saveFormControlState): ditto.
(WebCore::HTMLInputElement::restoreFormControlState): ditto.
* html/HTMLInputElement.h:
(HTMLInputElement): ditto.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState): ditto.
* html/HTMLSelectElement.h:
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::saveFormControlState): ditto.
(WebCore::HTMLTextAreaElement::restoreFormControlState): ditto.
* html/HTMLTextAreaElement.h:
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::saveFormControlState): ditto.
(WebCore::HiddenInputType::restoreFormControlState): ditto.
* html/HiddenInputType.h:
(HiddenInputType): ditto.
* html/InputType.cpp:
(WebCore::InputType::saveFormControlState): ditto.
(WebCore::InputType::restoreFormControlState): ditto.
* html/InputType.h:
(InputType): ditto.
* html/PasswordInputType.cpp:
(WebCore::PasswordInputType::saveFormControlState): ditto.
(WebCore::PasswordInputType::restoreFormControlState): ditto.
* html/PasswordInputType.h:
(PasswordInputType): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating baselines after rollouts in r120627.
zandobersek@gmail.com [Tue, 19 Jun 2012 06:16:16 +0000 (06:16 +0000)]
Unreviewed GTK gardening, updating baselines after rollouts in r120627.

* platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
* platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
* platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
* platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, update expected files.
ossy@webkit.org [Tue, 19 Jun 2012 06:09:29 +0000 (06:09 +0000)]
[Qt] Unreviewed gardening, update expected files.

* platform/qt/Skipped: Skip a new failing test to paint the bot green.
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Updated after r120609.
* platform/qt/fast/multicol/progression-reverse-expected.png: Added after r120609.
* platform/qt/fast/multicol/progression-reverse-expected.txt: Added after r120609.
* platform/qt/svg/css/getComputedStyle-basic-expected.txt: Updated after r120609.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: Changed JSC to always record line number information so that...
commit-queue@webkit.org [Tue, 19 Jun 2012 06:07:28 +0000 (06:07 +0000)]
Source/JavaScriptCore: Changed JSC to always record line number information so that error.stack
and window.onerror() can report proper line numbers.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit): m_lineInfo is now available unconditionally.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::addLineInfo):
(JSC::CodeBlock::hasLineInfo): Unused.  Now removed.
(JSC::CodeBlock::needsCallReturnIndices):
(CodeBlock):
(RareData):  Hoisted m_lineInfo out of m_rareData.  m_lineInfo is now
filled in unconditionally.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addLineInfo):

LayoutTests: Ensure that error.stack and window.onerror always have the appropriate
line numbers of the exception being thrown.
https://bugs.webkit.org/show_bug.cgi?id=89410

Patch by Mark Lam <mark.lam@apple.com> on 2012-06-18
Reviewed by Geoffrey Garen.

* fast/js/exception-line-number-expected.txt: Added.
* fast/js/exception-line-number.html: Added.
* fast/js/script-tests/exception-line-number.js: Added.
(foo):
(window.onerror):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fontconfig can't be linked properly
joone@webkit.org [Tue, 19 Jun 2012 05:47:57 +0000 (05:47 +0000)]
[EFL] Fontconfig can't be linked properly
https://bugs.webkit.org/show_bug.cgi?id=89418

Unreviewed build fix.

Make Fontconfig be linked correctly.

Source/WebCore:

No new tests. This is only a build fix.

* PlatformEfl.cmake: add FONTCONFIG_LIBRARIES to WebCore_LIBRARIES.

Tools:

* MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.
kinuko@chromium.org [Tue, 19 Jun 2012 05:47:28 +0000 (05:47 +0000)]
Unreviewed test fix (one more) for r120667: skip '.svn' directory from the test results.

* fast/forms/file/input-file-entries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Fix memory leaks in GLContextGLX.cpp
mrobinson@webkit.org [Tue, 19 Jun 2012 05:34:37 +0000 (05:34 +0000)]
[Cairo] Fix memory leaks in GLContextGLX.cpp
https://bugs.webkit.org/show_bug.cgi?id=89346

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-06-18
Reviewed by Martin Robinson.

Fix memory leaks found in GLContextGLX.cpp.

* platform/graphics/glx/GLContextGLX.cpp:
(WebCore::GLContextGLX::cleanupActiveContextsAtExit): Removing element reduces
size of the vector, so the loop termination condition was failing in the last
iteration, when the vector contains more than one element. This patch fixes the
issue by iterating the vector backwards, so the termination condition doesn't
fail until the size() reaches 0.
(WebCore::GLContextGLX::createPbufferContext): Delete GLXPbuffer
returned by glXCreatePbuffer().
(WebCore::GLContextGLX::createPixmapContext): Delete XVisualInfo
returned by glXChooseVisual().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Unreviewed gardening. Add missing expectation file.
mikelawther@chromium.org [Tue, 19 Jun 2012 05:19:46 +0000 (05:19 +0000)]
   Unreviewed gardening. Add missing expectation file.

* fast/text/title-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Updating email for committers.py script.
joone@webkit.org [Tue, 19 Jun 2012 05:09:39 +0000 (05:09 +0000)]
Unreviewed. Updating email for committers.py script.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test fix for r120667: skip '.svn' directory from the test results.
kinuko@chromium.org [Tue, 19 Jun 2012 05:08:26 +0000 (05:08 +0000)]
Unreviewed test fix for r120667: skip '.svn' directory from the test results.

* fast/forms/file/input-file-entries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a typo that caused TestFailures to have a syntax error.
simon.fraser@apple.com [Tue, 19 Jun 2012 04:56:40 +0000 (04:56 +0000)]
Fix a typo that caused TestFailures to have a syntax error.

Sadly TestFailures is broken for another reason now too:
https://bugs.webkit.org/show_bug.cgi?id=89419

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._domForBuildName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Expose WEBGL_depth_texture extension to WebGL
commit-queue@webkit.org [Tue, 19 Jun 2012 04:34:35 +0000 (04:34 +0000)]
Source/WebCore: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

Test: fast/canvas/webgl/webgl-depth-texture.html

* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
* html/canvas/WebGLDepthTexture.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::~WebGLDepthTexture):
(WebCore::WebGLDepthTexture::getName):
(WebCore::WebGLDepthTexture::create):
(WebCore::WebGLDepthTexture::supported):
* html/canvas/WebGLDepthTexture.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebGLDepthTexture):
* html/canvas/WebGLDepthTexture.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
* html/canvas/WebGLExtension.h:
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::initializeAttachments):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::validateSettableTexFormat):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
* html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
* platform/graphics/GraphicsContext3D.h:

LayoutTests: Expose WEBGL_depth_texture extension to WebGL
https://bugs.webkit.org/show_bug.cgi?id=87029

Patch by Gregg Tavares <gman@google.com> on 2012-06-18
Reviewed by Kenneth Russell.

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
* fast/canvas/webgl/webgl-depth-texture-expected.txt: Added.
* fast/canvas/webgl/webgl-depth-texture.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
kinuko@chromium.org [Tue, 19 Jun 2012 04:13:44 +0000 (04:13 +0000)]
Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
https://bugs.webkit.org/show_bug.cgi?id=88293

Reviewed by Tony Chang.

Source/WebCore:

Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries

Test: fast/forms/file/input-file-entries.html

* Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
* Modules/filesystem/HTMLInputElementFileSystem.h: Added.
* Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
* WebCore.gypi:
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
system Id if the given DragData has it.
(WebCore::FileInputType::droppedFileSystemId): Added. This returns
dropped file system Id retrieved in receiveDroppedFiles, or an empty
string if the platform does not support isolated file system for
dropped files.
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::droppedFileSystemId): Added.
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::droppedFileSystemId): Added.
* html/InputType.h:
* platform/DragData.cpp:
* platform/DragData.h:
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::droppedFileSystemId): Added.

LayoutTests:

* fast/forms/file/input-file-entries-expected.txt: Added.
* fast/forms/file/input-file-entries.html: Added.
* fast/forms/resources/dir1/UTF8-2.txt: Added.
* fast/forms/resources/dir1/UTF8.txt: Added.
* fast/forms/resources/dir2/green.jpg: Added.
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries...
shinyak@chromium.org [Tue, 19 Jun 2012 04:02:48 +0000 (04:02 +0000)]
[Crash][Editing] VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() crashes in some Shadow DOM case.
https://bugs.webkit.org/show_bug.cgi?id=88500

Reviewed by Ryosuke Niwa.

Source/WebCore:

When selecting from a child of shadow host to an element in Shadow DOM, the start position of
Selection comes after the end position of Selection in some cases. This caused a crash.

For example, let's think '<div id="host">A</div>D' and host has a Shadow DOM whose innerHTML
is 'B<content></content>C'. When selecting from just after A (p1 = (PositionIsOffsetInAnchor,
#text, 1)) to just before B (p2 = (PositionIsOffsetInAnchor, shadowRoot, 0)), since
comparePosition always judge as p2 is before p1, m_start and m_end in VisibleSelection
will be p2 and p1 respectively.

However, the anchorNodes of p1 and p2 have the different tree scope, we have to adjust p2 to
the same tree scope as p1. Since p2 is m_start, m_start was adjusted to positionAfterNode(div).
This breaks the assumption that m_start is always before (or equal to) m_end.

This patch keeps the assumption. When we cannot move m_start to positionAfterNode(div),
we move m_start to positionBeforeNode(div). Note that we cannot always move m_start to
positionBeforeNode(div), because when selecting just after D (p3 = (PositionIsOffsetInAnchor,
D's parent, 2), we don't want to select A.

In this case, m_start should be adjusted to positionAfterNode(div).

Test: editing/shadow/breaking-editing-boundaries.html

* editing/VisibleSelection.cpp:
(WebCore::adjustPositionForEnd):
(WebCore):
(WebCore::adjustPositionForStart):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
* editing/VisibleSelection.h:
(VisibleSelection):

LayoutTests:

* editing/shadow/breaking-editing-boundaries-expected.txt: Added.
* editing/shadow/breaking-editing-boundaries.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test marking. Marked border-radius-clip-002.htm as a failure.
morrita@google.com [Tue, 19 Jun 2012 03:54:51 +0000 (03:54 +0000)]
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix r120663, which didn't land the change that was reviewed.
aestes@apple.com [Tue, 19 Jun 2012 03:34:03 +0000 (03:34 +0000)]
Fix r120663, which didn't land the change that was reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
aestes@apple.com [Tue, 19 Jun 2012 03:32:30 +0000 (03:32 +0000)]
[JSC] In JSGlobalData.cpp, enableAssembler() sometimes leaks two CF objects
https://bugs.webkit.org/show_bug.cgi?id=89415

Reviewed by Sam Weinig.

In the case where canUseJIT was a non-NULL CFBooleanRef,
enableAssembler() would leak both canUseJITKey and canUseJIT by
returning before calling CFRelease. Fix this by using RetainPtr.

* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when setting title dynamically
mikelawther@chromium.org [Tue, 19 Jun 2012 03:20:53 +0000 (03:20 +0000)]
Crash when setting title dynamically
https://bugs.webkit.org/show_bug.cgi?id=88083

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/title-crash.html

The crashing code takes a rare branch in StyleResolver::styleForElement() where
m_parentStyle is set to point to m_style. Consequently, while applying properties
to m_style we end up mutating m_parentStyle.

In this situation, we clone style() and point m_parentStyle at the clone. The
clone is destroyed at the end of StyleResolver::styleForElement().

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

* fast/text/title-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
enne@google.com [Tue, 19 Jun 2012 03:04:50 +0000 (03:04 +0000)]
RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree
https://bugs.webkit.org/show_bug.cgi?id=89402

Reviewed by James Robinson.

Source/WebCore:

RenderLayerBacking only attaches scrollbar layers to the graphics
layer tree if there's a clip layer. This is wrong, because these
scrollbars become orphans and other code expects them to handle
repainting the scrollbars (which now become invisible). Fix by always
attaching scrollbar layers.

Test: compositing/overflow/image-load-overflow-scrollbars.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateInternalHierarchy):

LayoutTests:

Add a test where an image load creates overflow.

* compositing/overflow/image-load-overflow-scrollbars-expected.png: Added.
* compositing/overflow/image-load-overflow-scrollbars-expected.txt: Added.
* compositing/overflow/image-load-overflow-scrollbars.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake serve-video.php serve 206 responses
fischman@chromium.org [Tue, 19 Jun 2012 02:54:19 +0000 (02:54 +0000)]
Make serve-video.php serve 206 responses
https://bugs.webkit.org/show_bug.cgi?id=89252

Reviewed by Adam Barth.

* http/tests/media/resources/serve-video.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] GesturePinchBegin and friends are gesture events
abarth@webkit.org [Tue, 19 Jun 2012 02:51:55 +0000 (02:51 +0000)]
[Chromium] GesturePinchBegin and friends are gesture events
https://bugs.webkit.org/show_bug.cgi?id=89398

Reviewed by James Robinson.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isGestureEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed test marking. Marked border-radius-clip-002.htm as a failure.
morrita@google.com [Tue, 19 Jun 2012 02:25:09 +0000 (02:25 +0000)]
Unreviewed test marking. Marked border-radius-clip-002.htm as a failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide bug links for suspicious commits
simon.fraser@apple.com [Tue, 19 Jun 2012 02:06:09 +0000 (02:06 +0000)]
Provide bug links for suspicious commits
https://bugs.webkit.org/show_bug.cgi?id=89408

Reviewed by Adam Barth.

Add links to bugs for the suspicious commits if we have bug data.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
(ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
(ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] DeviceOrientation Cleanup
commit-queue@webkit.org [Tue, 19 Jun 2012 01:38:22 +0000 (01:38 +0000)]
[Chromium] DeviceOrientation Cleanup
https://bugs.webkit.org/show_bug.cgi?id=89354

Patch by Amy Ousterhout <aousterh@chromium.org> on 2012-06-18
Reviewed by Kent Tamura.

Source/WebCore:

No new tests because there is no intended change in behavior.

* platform/mock/DeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(DeviceOrientationClientMock):

Source/WebKit/chromium:

* public/WebDeviceOrientation.h: added const-qualifiers to getters, simplified an overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::isNull):
(WebKit::WebDeviceOrientation::canProvideAlpha):
(WebKit::WebDeviceOrientation::alpha):
(WebKit::WebDeviceOrientation::canProvideBeta):
(WebKit::WebDeviceOrientation::beta):
(WebKit::WebDeviceOrientation::canProvideGamma):
(WebKit::WebDeviceOrientation::gamma):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
(WebDeviceOrientation):
* public/WebDeviceOrientationClient.h: added WEBKIT_ASSERT_NOT_REACHED to virtual functions
(WebKit::WebDeviceOrientationClient::setController):
(WebKit::WebDeviceOrientationClient::startUpdating):
(WebKit::WebDeviceOrientationClient::stopUpdating):
(WebKit::WebDeviceOrientationClient::lastOrientation):
* public/WebDeviceOrientationClientMock.h: added OVERRIDE specifier for virtual functions
(WebDeviceOrientationClientMock):
* src/DeviceOrientationClientProxy.h: designated functions as 'virtual' and added OVERRIDE specifier
(DeviceOrientationClientProxy):
* src/WebDeviceOrientation.cpp: simplified overly-complicated parameter to two functions
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):

Tools:

* DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] media/video-seek-past-end-playing.html is flaky
commit-queue@webkit.org [Tue, 19 Jun 2012 01:32:28 +0000 (01:32 +0000)]
[EFL] media/video-seek-past-end-playing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=89301

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-18
Reviewed by Philippe Normand.

Source/WebCore:

Switch to double for media duration and playback position
calculations to avoid precision problems.
This patch also removes the workaround for the precision
problem in didEnd() which is no longer needed.

Test: media/video-seek-past-end-playing.html

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::duration):

LayoutTests:

Unskip media/video-seek-past-end-playing.html now that the
precision problem in MediaPlayerPrivateGStreamer is fixed.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-06-18 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Tue, 19 Jun 2012 01:30:04 +0000 (01:30 +0000)]
2012-06-18  Andrew Scherkus  <scherkus@chromium.org>

        [Chromium] Unreviewed. Rebaseline media layout tests due to updated controls.

        https://bugs.webkit.org/show_bug.cgi?id=89050

        * platform/chromium-linux-x86/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/audio-repaint-expected.png:
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-layout-direction-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/controls-styling-expected.png:
        * platform/chromium-linux/media/controls-without-preload-expected.png:
        * platform/chromium-linux/media/media-controls-clone-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
        * platform/chromium-linux/media/video-zoom-controls-expected.png:
        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-leopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-leopard/media/controls-strict-expected.png:
        * platform/chromium-mac-leopard/media/controls-styling-expected.png:
        * platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-mac-leopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-layout-direction-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
        * platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png:
        * platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
        * platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-mac-snowleopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.png:
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-mac/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac/media/audio-controls-rendering-expected.txt:
        * platform/chromium-mac/media/audio-repaint-expected.png:
        * platform/chromium-mac/media/audio-repaint-expected.txt:
        * platform/chromium-mac/media/controls-after-reload-expected.png:
        * platform/chromium-mac/media/controls-after-reload-expected.txt:
        * platform/chromium-mac/media/controls-layout-direction-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.png:
        * platform/chromium-mac/media/controls-strict-expected.txt:
        * platform/chromium-mac/media/controls-styling-expected.png:
        * platform/chromium-mac/media/controls-styling-expected.txt:
        * platform/chromium-mac/media/controls-without-preload-expected.png:
        * platform/chromium-mac/media/controls-without-preload-expected.txt:
        * platform/chromium-mac/media/media-controls-clone-expected.png:
        * platform/chromium-mac/media/media-controls-clone-expected.txt:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-mac/media/video-controls-rendering-expected.png:
        * platform/chromium-mac/media/video-controls-rendering-expected.txt:
        * platform/chromium-mac/media/video-display-toggle-expected.png:
        * platform/chromium-mac/media/video-display-toggle-expected.txt:
        * platform/chromium-mac/media/video-empty-source-expected.png:
        * platform/chromium-mac/media/video-empty-source-expected.txt:
        * platform/chromium-mac/media/video-no-audio-expected.png:
        * platform/chromium-mac/media/video-no-audio-expected.txt:
        * platform/chromium-mac/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac/media/video-playing-and-pause-expected.txt:
        * platform/chromium-mac/media/video-zoom-controls-expected.png:
        * platform/chromium-mac/media/video-zoom-controls-expected.txt:
        * platform/chromium-win-vista/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-win-xp/media/video-empty-source-expected.txt: Removed.
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.txt:
        * platform/chromium-win/fullscreen/full-screen-stacking-context-expected.png:
        * platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.txt:
        * platform/chromium-win/media/audio-repaint-expected.png:
        * platform/chromium-win/media/audio-repaint-expected.txt:
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.txt:
        * platform/chromium-win/media/controls-layout-direction-expected.png:
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/controls-strict-expected.txt:
        * platform/chromium-win/media/controls-styling-expected.png:
        * platform/chromium-win/media/controls-styling-expected.txt:
        * platform/chromium-win/media/controls-without-preload-expected.png:
        * platform/chromium-win/media/controls-without-preload-expected.txt:
        * platform/chromium-win/media/media-controls-clone-expected.png:
        * platform/chromium-win/media/media-controls-clone-expected.txt:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.txt:
        * platform/chromium-win/media/video-controls-rendering-expected.png:
        * platform/chromium-win/media/video-controls-rendering-expected.txt:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.txt:
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.txt:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.txt:
        * platform/chromium-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-win/media/video-playing-and-pause-expected.txt:
        * platform/chromium-win/media/video-zoom-controls-expected.png:
        * platform/chromium-win/media/video-zoom-controls-expected.txt:
        * platform/chromium/TestExpectations:
        * platform/win-xp/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/layers/video-layer-expected.txt.
        * platform/win-xp/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/audio-controls-rendering-expected.txt.
        * platform/win-xp/media/audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/audio-repaint-expected.txt.
        * platform/win-xp/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-after-reload-expected.txt.
        * platform/win-xp/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/win/media/controls-strict-expected.txt.
        * platform/win-xp/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/win/media/controls-styling-expected.txt.
        * platform/win-xp/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/win/media/controls-without-preload-expected.txt.
        * platform/win-xp/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/win/media/media-controls-clone-expected.txt.
        * platform/win-xp/media/media-document-audio-repaint-expected.txt: Renamed from LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt.
        * platform/win-xp/media/video-controls-rendering-expected.txt: Renamed from LayoutTests/platform/win/media/video-controls-rendering-expected.txt.
        * platform/win-xp/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/win/media/video-display-toggle-expected.txt.
        * platform/win-xp/media/video-empty-source-expected.txt: Renamed from LayoutTests/platform/win/media/video-empty-source-expected.txt.
        * platform/win-xp/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/win/media/video-no-audio-expected.txt.
        * platform/win-xp/media/video-playing-and-pause-expected.txt: Renamed from LayoutTests/platform/win/media/video-playing-and-pause-expected.txt.
        * platform/win-xp/media/video-zoom-controls-expected.png: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.png.
        * platform/win-xp/media/video-zoom-controls-expected.txt: Renamed from LayoutTests/platform/win/media/video-zoom-controls-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
fischman@chromium.org [Tue, 19 Jun 2012 01:29:24 +0000 (01:29 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations update to mark tests as timing out due to r120627.
atwilson@chromium.org [Tue, 19 Jun 2012 01:21:35 +0000 (01:21 +0000)]
Unreviewed chromium expectations update to mark tests as timing out due to r120627.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphi...
commit-queue@webkit.org [Tue, 19 Jun 2012 01:12:50 +0000 (01:12 +0000)]
[chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=89254

Patch by James Robinson <jamesr@chromium.org> on 2012-06-18
Reviewed by Adrienne Walker.

This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
upstream.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMinor fix suggested by Adam Barth.
simon.fraser@apple.com [Tue, 19 Jun 2012 01:09:37 +0000 (01:09 +0000)]
Minor fix suggested by Adam Barth.

Use $(this._what).empty(); rather than removing children one at a time.
For some reason removeAllChildren() is undefined on this node.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShow TOT revision in garden-o-matic, and make the revisions into links
simon.fraser@apple.com [Tue, 19 Jun 2012 01:03:11 +0000 (01:03 +0000)]
Show TOT revision in garden-o-matic, and make the revisions into links
https://bugs.webkit.org/show_bug.cgi?id=89396

Reviewed by Adam Barth.

The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
where the revisions are links to trac.

To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
the knock-on effect of flipping the target and href attributes for anchors in some test output.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._displayTesters.updateList.list):
(ViewController.prototype._displayTesters.updateList):
(ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
(ViewController.prototype._domForRegressionRange):
(ViewController.prototype._domForAuxiliaryUIElements):
(ViewController.prototype._domForBuildName):
(ViewController.prototype):
(ViewController.prototype.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium expectations.
atwilson@chromium.org [Tue, 19 Jun 2012 01:02:21 +0000 (01:02 +0000)]
Unreviewed chromium expectations.

* platform/chromium-mac/compositing/fixed-position-scroll-offset-history-restore-expected.png: Added.
* platform/chromium-win/compositing/fixed-position-scroll-offset-history-restore-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/fixed-position-scroll-offset-history-restore-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r100558): NRWT should work without SVN or GIT
dpranke@chromium.org [Tue, 19 Jun 2012 00:58:12 +0000 (00:58 +0000)]
REGRESSION(r100558): NRWT should work without SVN or GIT
https://bugs.webkit.org/show_bug.cgi?id=76630

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2012-06-18
Reviewed by Dirk Pranke.

NRWT is not supposed to have a requirement that we have an
actual SVN or Git checkout, and we were unnecessarily
initializing the checkout. This patch removes that line :).

* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r120593.
commit-queue@webkit.org [Tue, 19 Jun 2012 00:50:05 +0000 (00:50 +0000)]
Unreviewed, rolling out r120593.
http://trac.webkit.org/changeset/120593
https://bugs.webkit.org/show_bug.cgi?id=89404

Caused failures in fast/forms/file/input-file-entries.html
(Requested by atwilson on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-18

Source/WebCore:

* Modules/filesystem/DOMFileSystem.cpp:
(WebCore::DOMFileSystem::createIsolatedFileSystem):
* Modules/filesystem/HTMLInputElementFileSystem.cpp: Removed.
* Modules/filesystem/HTMLInputElementFileSystem.h: Removed.
* Modules/filesystem/HTMLInputElementFileSystem.idl: Removed.
* WebCore.gypi:
* html/FileInputType.cpp:
(WebCore::FileInputType::receiveDroppedFiles):
* html/FileInputType.h:
(FileInputType):
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/InputType.cpp:
* html/InputType.h:
(InputType):
* platform/DragData.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):
* platform/DragData.h:
(DragData):
* platform/chromium/DragDataChromium.cpp:

LayoutTests:

* fast/forms/file/input-file-entries-expected.txt: Removed.
* fast/forms/file/input-file-entries.html: Removed.
* fast/forms/resources/dir1/UTF8-2.txt: Removed.
* fast/forms/resources/dir1/UTF8.txt: Removed.
* fast/forms/resources/dir2/green.jpg: Removed.
* platform/efl/Skipped:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
jamesr@google.com [Mon, 18 Jun 2012 23:54:22 +0000 (23:54 +0000)]
[chromium] Use WebImageLayer in GraphicsLayerChromium for image layers
https://bugs.webkit.org/show_bug.cgi?id=89150

Reviewed by Adrienne Walker.

Source/Platform:

Adds a WebImageLayer type to represent layers backed by (guess what) Images.

* Platform.gypi:
* chromium/public/WebImageLayer.h: Added.
(WebCore):
(WebKit):
(WebImageLayer):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::~WebImageLayer):

Source/WebCore:

Uses WebImageLayer instead of ImageLayerChromium for GraphicsLayerChromium::setContentsToImage.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):

Source/WebKit/chromium:

Implementation of WebImageLayer. Note: This could (should?) live in WebCore/platform/chromium/support/, but it's
here to be next to the other Web*Layer.cpp implementation files.

* WebKit.gyp:
* src/WebImageLayer.cpp: Added.
(WebKit):
(WebKit::WebImageLayer::create):
(WebKit::WebImageLayer::WebImageLayer):
(WebKit::WebImageLayer::setBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] GraphicsLayerChromium should use WebContentLayer directly
jamesr@google.com [Mon, 18 Jun 2012 23:41:17 +0000 (23:41 +0000)]
[chromium] GraphicsLayerChromium should use WebContentLayer directly
https://bugs.webkit.org/show_bug.cgi?id=89145

Reviewed by Adrienne Walker.

Source/Platform:

Add an opaque rect parameter to WebContentLayerClient::paintContents() for a client to (optionally) provide
information about opaque portions of the painted region for culling optimizations.

* chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):

Source/WebCore:

Ports GraphicsLayerChromium (or more specifically OpaqueRectTrackingContentLayerDelegate) to implement
WebContentLayerClient instead of ContentLayerDelegate. In addition to the mechanical changes, this requires
eagerly setting drawsContent on GraphicsLayerChromium::m_layer since WebContentLayerImpl's default value is
different from LayerChromium's. Covered by all of compositing/

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::paintContents):
* tests/CCOcclusionTrackerTest.cpp:
(WebKitTests::CCOcclusionTrackerTestMainThreadTypes::createLayer):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkipping dictation tests on WK2.
enrica@apple.com [Mon, 18 Jun 2012 23:35:32 +0000 (23:35 +0000)]
Skipping dictation tests on WK2.

Unreviewed.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120642 268f45cc-cd09-0410-ab3c-d52691b4dbfc