WebKit-https.git
11 years ago2009-06-19 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Fri, 19 Jun 2009 20:57:33 +0000 (20:57 +0000)]
2009-06-19  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=26540
        Currently the SunSpider test driver lacks an option to run a test suite that
        will test JavaScriptCore parsing performance only.  This patch adds just such
        a test suite and option to SunSpider as well as the jsc test shell.  I've included
        three large javascript source files found in the wild: jquery, mootools and prototype.
        Combined with the concatenation of all three, these form a new testsuite to measure
        and test pure JavaScriptCore parsing performance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Jun 2009 20:38:46 +0000 (20:38 +0000)]
2009-06-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26555

        Fix the Chromium canary bot.  Turns out ScriptSourceCode doesn't have
        the same API in V8 and JSC.

        * WebCore/bindings/js/ScriptController.cpp:
        * WebCore/bindings/js/ScriptSourceCode.h:
        * WebCore/bindings/v8/ScriptController.cpp:
        * WebCore/page/XSSAuditor.cpp:
        * WebCore/page/XSSAuditor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago009-06-19 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
bfulgham@webkit.org [Fri, 19 Jun 2009 20:30:47 +0000 (20:30 +0000)]
009-06-19  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Inherits HashCountedSet class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Collector.cpp:1095.

        * wtf/HashCountedSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Fri, 19 Jun 2009 20:17:56 +0000 (20:17 +0000)]
WebCore:

2009-06-19  David Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=26547

        Implement the IDL interface for HTMLDataGridColElement.

        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/HTMLAttributeNames.in:
        * html/HTMLDataGridColElement.cpp: Added.
        (WebCore::HTMLDataGridColElement::HTMLDataGridColElement):
        (WebCore::HTMLDataGridColElement::label):
        (WebCore::HTMLDataGridColElement::setLabel):
        (WebCore::HTMLDataGridColElement::type):
        (WebCore::HTMLDataGridColElement::setType):
        (WebCore::HTMLDataGridColElement::sortable):
        (WebCore::HTMLDataGridColElement::setSortable):
        (WebCore::HTMLDataGridColElement::sortDirection):
        (WebCore::HTMLDataGridColElement::setSortDirection):
        (WebCore::HTMLDataGridColElement::selected):
        (WebCore::HTMLDataGridColElement::setSelected):
        * html/HTMLDataGridColElement.h: Added.
        (WebCore::HTMLDataGridColElement::endTagRequirement):
        (WebCore::HTMLDataGridColElement::tagPriority):
        * html/HTMLDataGridColElement.idl: Added.
        * html/HTMLDataGridElement.h:
        * html/HTMLElementsAllInOne.cpp:
        * html/HTMLTagNames.in:
        * page/DOMWindow.idl:

LayoutTests:

2009-06-19  David Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=26547

        Implement the IDL interface for HTMLDataGridColELement.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Fri, 19 Jun 2009 20:09:47 +0000 (20:09 +0000)]
2009-06-19  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=26558
        Declare these symbols extern for WINCE as they are provided by libce.

        * runtime/DateConstructor.cpp:
        * runtime/DatePrototype.cpp:
        (JSC::formatLocaleDate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Chris Evans <scarybeasts@gmail.com>
bfulgham@webkit.org [Fri, 19 Jun 2009 19:54:57 +0000 (19:54 +0000)]
2009-06-19  Chris Evans  <scarybeasts@gmail.com>

        Reviewed by Eric Seidel.

        There is no new test because this cannot be tested deterministically.
        I've not been able to cause a crash at all in the test framework, but
        I have verified that this is happening in the wild and that the patch
        fixes the likely cause in the debugger.

        * loader/TextResourceDecoder.cpp: careful not to iterate off the end
          of our input buffer looking for the end of the comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Fri, 19 Jun 2009 19:37:17 +0000 (19:37 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6988973> ScopeChain leak in interpreter builds
oliver@apple.com [Fri, 19 Jun 2009 18:48:29 +0000 (18:48 +0000)]
<rdar://problem/6988973> ScopeChain leak in interpreter builds

Reviewed by Maciej Stachowiak

Move the Scopechain destruction code in JSFunction outside of the ENABLE(JIT)
path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Jun 2009 18:25:42 +0000 (18:25 +0000)]
2009-06-19  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26536

        Fix external-script-URL-location.html and
        write-external-script-open.html LayoutTests.

        implicitOpen is called from several places.  We need to setXSSAuditor
        each time, so I moved the call inside implicitOpen.

        * dom/Document.cpp:
        (WebCore::Document::open):
        (WebCore::Document::implicitOpen):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Kent Tamura <tkent@chromium.org>
levin@chromium.org [Fri, 19 Jun 2009 18:22:17 +0000 (18:22 +0000)]
2009-06-19  Kent Tamura  <tkent@chromium.org>

        Reviewed by David Levin.

        Use WebCore::multipleFileUploadText() in Chromium to fix a problem
        that Chromium shows only the first filename even if a user selects
        multiple files for <input type=file multiple>.
        <https://bugs.webkit.org/show_bug.cgi?id=26502>

        * platform/chromium/FileChooserChromium.cpp:
        (WebCore::FileChooser::basenameForWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 19 Jun 2009 18:14:06 +0000 (18:14 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6967596> Safari hung using 100% CPU when I tried
          to look up a word in Dictionary using command-control-d

        Test: editing/selection/move-by-line-005.html

        The root cause of this bug was searchAheadForBetterMatch() continuing
        past the first rendered text object after the given object. While we
        want to skip non-rendered text and empty containers, when we encounter
        rendered text object, we must return a text box for that object.

        * dom/Position.cpp:
        (WebCore::searchAheadForBetterMatch):

LayoutTests:

        Reviewed by Dave Hyatt.

        - text for <rdar://problem/6967596> Safari hung using 100% CPU when I
          tried to look up a word in Dictionary using command-control-d

        * editing/selection/move-by-line-005-expected.txt: Added.
        * editing/selection/move-by-line-005.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Jungshik Shin <jshin@chromium.org>
jshin@chromium.org [Fri, 19 Jun 2009 17:46:51 +0000 (17:46 +0000)]
2009-06-18  Jungshik Shin  <jshin@chromium.org>

        Reviewed by David Levin

        https://bugs.webkit.org/show_bug.cgi?id=25657

        Chromium Linux port does not handle non-BMP characters properly.
        It's fixed with a 'UTF-16 iterator macro' to extract Unicode
        codepoints out of a UTF-16 input string.

        A manual test is added for non-BMP character rendering,
        which we can use until a small freely-distributable font
        covering non-BMP is added to the Webkit source tree.

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * manual-tests/non-bmp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Yong Li <yong.li@torchmobile.com>
treat@webkit.org [Fri, 19 Jun 2009 17:01:47 +0000 (17:01 +0000)]
2009-06-19  Yong Li  <yong.li@torchmobile.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=26543
        Windows CE uses 'GetLastError' instead of 'errno.'

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        (JSC::RegisterFile::grow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Fri, 19 Jun 2009 16:52:41 +0000 (16:52 +0000)]
    Reviewed by Anders Carlsson.

        - update test results after r44806

        * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Pavel Feldman <pfeldman@chromium.org>
dglazkov@chromium.org [Fri, 19 Jun 2009 15:47:42 +0000 (15:47 +0000)]
2009-06-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Dimitri Glazkov.

        V8 Bindings: return proper state from the script stack.

        https://bugs.webkit.org/show_bug.cgi?id=26512

        * bindings/v8/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::ScriptCallStack):
        * bindings/v8/ScriptCallStack.h:
        (WebCore::ScriptCallStack::state):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Fri, 19 Jun 2009 15:34:34 +0000 (15:34 +0000)]
2009-06-19  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Simon Fraser.

        Windows build fix.

        * platform/graphics/cg/PatternCG.cpp:
        (WebCore::Pattern::createPlatformPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 19 Jun 2009 14:28:38 +0000 (14:28 +0000)]
2009-06-19  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Simon Hausmann.
        Build fix after 44825.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::isSizeAvailable):
        * platform/graphics/qt/ImageDecoderQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Daniel Teske <qt-info@nokia.com>
hausmann@webkit.org [Fri, 19 Jun 2009 12:18:24 +0000 (12:18 +0000)]
2009-06-19  Daniel Teske <qt-info@nokia.com>

        Reviewed by Simon Hausmann.

        Remove warnings for QString() constructions from const char *

        By explicitly wrapping it with QLatin1String() / QLatin1Char()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
vestbo@webkit.org [Fri, 19 Jun 2009 09:58:59 +0000 (09:58 +0000)]
2009-06-15  Andre Pedralho  <andre.pedralho@openbossa.org>

        Reviewed by Tor Arne Vestbø.

        Only pass --makeargs along if an argument is given.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Shinichiro Hamaji <hamaji@chromium.org>
oliver@apple.com [Fri, 19 Jun 2009 09:23:24 +0000 (09:23 +0000)]
2009-06-18  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Oliver Hunt.

        Bug 26426: Canvas: rotation of 'no-repeat' pattern is weird
        <https://bugs.webkit.org/show_bug.cgi?id=26426>

        Use 1<<23-1 as steps of no-repeat patterns instead of 100000000.0f.
        The original number cannot be represented by mantissa of float
        (23bit) so that it caused some error.

        Test: fast/canvas/image-object-in-canvas.html:

        * platform/graphics/cg/PatternCG.cpp:
        (WebCore::Pattern::createPlatformPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix copy/paste error.
abarth@webkit.org [Fri, 19 Jun 2009 09:06:39 +0000 (09:06 +0000)]
Fix copy/paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 abarth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Jun 2009 08:57:28 +0000 (08:57 +0000)]
2009-06-19  abarth  <abarth@webkit.org>

        Unreviewed attempt to fix the Chromium build.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::evaluate):
        * bindings/v8/ScriptController.h:
        (WebCore::ScriptController::xssAuditor):
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 19 Jun 2009 08:29:41 +0000 (08:29 +0000)]
2009-06-19  Adam Barth  <abarth@webkit.org>

        Unreviewed attempt to fix Windows build.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setXSSAuditorEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Fri, 19 Jun 2009 08:12:37 +0000 (08:12 +0000)]
WebCore:

2009-06-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26199

        Added an experimental reflective XSS filter.  The filter is disabled by
        default.

        Test: http/tests/security/xssAuditor/script-tag.html

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::ScriptController):
        (WebCore::ScriptController::evaluate):
        * bindings/js/ScriptController.h:
        (WebCore::ScriptController::xssAuditor):
        * bindings/js/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * dom/Tokenizer.h:
        (WebCore::Tokenizer::xssAuditor):
        (WebCore::Tokenizer::setXSSAuditor):
        (WebCore::Tokenizer::Tokenizer):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptHandler):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::begin):
        (WebCore::FrameLoader::requestObject):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setXSSAuditorEnabled):
        * page/Settings.h:
        (WebCore::Settings::xssAuditorEnabled):
        * page/XSSAuditor.cpp: Added.
        (WebCore::isControlCharacter):
        (WebCore::XSSAuditor::XSSAuditor):
        (WebCore::XSSAuditor::~XSSAuditor):
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canCreateInlineEventListener):
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
        (WebCore::XSSAuditor::canLoadObject):
        (WebCore::XSSAuditor::decodeURL):
        (WebCore::XSSAuditor::findInRequest):
        * page/XSSAuditor.h: Added.
        (WebCore::XSSAuditor::isEnabled):
        (WebCore::XSSAuditor::setXSSAuditorEnabled):

WebKit/mac:

2009-06-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26199

        Added preference to enable the XSSAuditor.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences isXSSAuditorEnabled]):
        (-[WebPreferences setXSSAuditorEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-06-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26199

        Added preference to enable the XSSAuditor.

        * Interfaces/IWebPreferencesPrivate.idl:
        * WebPreferenceKeysPrivate.h:
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):
        (WebPreferences::isXSSAuditorEnabled):
        (WebPreferences::setXSSAuditorEnabled):
        * WebPreferences.h:
        * WebView.cpp:
        (WebView::notifyPreferencesChanged):

WebKitTools:

2009-06-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26199

        Add support for testing the XSSAuditor.

        * DumpRenderTree/LayoutTestController.cpp:
        (setXSSAuditorEnabledCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setXSSAuditorEnabled):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setXSSAuditorEnabled):
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetWebViewToConsistentStateBeforeTesting):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setXSSAuditorEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setXSSAuditorEnabled):

LayoutTests:

2009-06-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26199

        Added a basic test for the XSSAuditor.

        * http/tests/security/xssAuditor/resources/echo-intertag.php: Added.
        * http/tests/security/xssAuditor/script-tag-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-19 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 19 Jun 2009 07:59:59 +0000 (07:59 +0000)]
2009-06-19  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (Windows build fix).

        Add export for Windows corresponding to OSX export done in r44844.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26532: Native functions do not correctly unlink from optimised callsites when...
oliver@apple.com [Fri, 19 Jun 2009 07:10:49 +0000 (07:10 +0000)]
Bug 26532: Native functions do not correctly unlink from optimised callsites when they're collected
<https://bugs.webkit.org/show_bug.cgi?id=26532> <rdar://problem/6625385>

Reviewed by Gavin "Viceroy of Venezuela" Barraclough.

We need to make sure that each native function instance correctly unlinks any references to it
when it is collected.  Allowing this to happen required a few changes:
    * Every native function needs a codeblock to track the link information
    * To have this codeblock, every function now also needs its own functionbodynode
      so we no longer get to have a single shared instance.
    * Identifying a host function is now done by looking for CodeBlock::codeType() == NativeCode

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 19 Jun 2009 05:39:59 +0000 (05:39 +0000)]
2009-06-18  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by NOBODY (Windows build fix).

        * wtf/DateMath.cpp:
        (WTF::calculateUTCOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 19 Jun 2009 05:06:55 +0000 (05:06 +0000)]
2009-06-18  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff Garen.

        Timezone calculation incorrect in Venezuela.

        https://bugs.webkit.org/show_bug.cgi?id=26531
        <rdar://problem/6646169> Time is incorrectly reported to JavaScript in both Safari 3 and Firefox 3

        The problem is that we're calculating the timezone relative to 01/01/2000,
        but the VET timezone changed from -4 hours to -4:30 hours on 12/09/2007.
        According to the spec, section 15.9.1.9 states "the time since the beginning
        of the year", presumably meaning the *current* year.  Change the calculation
        to be based on whatever the current year is, rather than a canned date.

        No performance impact.

        * wtf/DateMath.cpp:
        (WTF::calculateUTCOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 19 Jun 2009 05:06:20 +0000 (05:06 +0000)]
2009-06-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        feOffset and objectBoundingBox
        [https://bugs.webkit.org/show_bug.cgi?id=26441]

        If we use objectBoundingBox for primitiveUnits, the fractions given
        to dx or dy of feOffset must be multiplied with the referenced objects
        objectBoundingBox size.

        Test: svg/filters/feOffset.svg

        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::apply):

        Test for feOffset with the primitiveUnits objectBoundingBox
        and userSpaceOnUse.

        * platform/mac/svg/filters/feOffset-expected.checksum: Added.
        * platform/mac/svg/filters/feOffset-expected.png: Added.
        * platform/mac/svg/filters/feOffset-expected.txt: Added.
        * svg/filters/feOffset.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 19 Jun 2009 05:00:30 +0000 (05:00 +0000)]
2009-06-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        feTile implementation missing
        [https://bugs.webkit.org/show_bug.cgi?id=26419]

        Implementation of feTile, a pattern effect for SVG filters. It was
        necessary to modify FilterEffect since source inputs need a secial
        logic and we have to identify if an effect is a source input.

        Tests: svg/batik/filters/feTile.svg
               svg/filters/feTile.svg

        * platform/graphics/filters/FilterEffect.h:
        (WebCore::FilterEffect::isSourceInput):
        * platform/graphics/filters/SourceAlpha.h:
        (WebCore::SourceAlpha::isSourceInput):
        * platform/graphics/filters/SourceGraphic.h:
        (WebCore::SourceGraphic::isSourceInput):
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::apply):

        Reviewed by Oliver Hunt.

        Added a test of batik and a own one to check behavior of the
        new feTile effect in SVG.

        * platform/mac/svg/batik/filters/feTile-expected.checksum: Added.
        * platform/mac/svg/batik/filters/feTile-expected.png: Added.
        * platform/mac/svg/batik/filters/feTile-expected.txt: Added.
        * platform/mac/svg/filters/feTile-expected.checksum: Added.
        * platform/mac/svg/filters/feTile-expected.png: Added.
        * platform/mac/svg/filters/feTile-expected.txt: Added.
        * svg/batik/filters/feTile.svg: Added.
        * svg/filters/feTile.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 19 Jun 2009 04:44:29 +0000 (04:44 +0000)]
2009-06-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        feMerge implementation
        [https://bugs.webkit.org/show_bug.cgi?id=26480]

        Added feMerge to the SVG Filter system.

        Test: svg/filters/feMerge.svg

        * svg/graphics/filters/SVGFEMerge.cpp:
        (WebCore::FEMerge::uniteChildEffectSubregions):
        (WebCore::FEMerge::apply):
        * svg/graphics/filters/SVGFEMerge.h:

        Check the feMerge implementation.

        * platform/mac/svg/filters/feMerge-expected.checksum: Added.
        * platform/mac/svg/filters/feMerge-expected.png: Added.
        * platform/mac/svg/filters/feMerge-expected.txt: Added.
        * svg/filters/feMerge.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 19 Jun 2009 02:32:29 +0000 (02:32 +0000)]
2009-06-18  Gavin Barraclough  <barraclough@apple.com>

        Rubber Stamped by Mark Rowe (originally reviewed by Sam Weinig).

        (Reintroducing patch added in r44492, and reverted in r44796.)

        Change the implementation of op_throw so the stub function always modifies its
        return address - if it doesn't find a 'catch' it will switch to a trampoline
        to force a return from JIT execution.  This saves memory, by avoiding the need
        for a unique return for every op_throw.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_throw):
            JITStubs::cti_op_throw now always changes its return address,
            remove return code generated after the stub call (this is now
            handled by ctiOpThrowNotCaught).
        * jit/JITStubs.cpp:
        (JSC::):
            Add ctiOpThrowNotCaught definitions.
        (JSC::JITStubs::DEFINE_STUB_FUNCTION):
            Change cti_op_throw to always change its return address.
        * jit/JITStubs.h:
            Add ctiOpThrowNotCaught declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative Windows build fix.
mrowe@apple.com [Fri, 19 Jun 2009 01:51:07 +0000 (01:51 +0000)]
Speculative Windows build fix.

* page/win/FrameCGWin.cpp: Add missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bfulgham@webkit.org [Fri, 19 Jun 2009 01:21:18 +0000 (01:21 +0000)]
WebCore:

2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Dave Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26425
        Final refactorings, picking up a few places where BitmapInfo
        could be used.

        * page/win/FrameCGWin.cpp:
        (WebCore::imageFromRect):
        * platform/win/CursorWin.cpp:
        (WebCore::Cursor::Cursor):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint):

WebKit/win:

2009-06-18  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Dave Levin.

        Remove some boilerplate using the BitmapInfo struct.
        https://bugs.webkit.org/show_bug.cgi?id=26425

        * WebFrame.cpp:
        (WebFrame::spoolPages):
        * WebIconDatabase.cpp:
        (createDIB):
        * WebKit.vcproj/WebKit.sln:
        * WebNodeHighlight.cpp:
        (WebNodeHighlight::update):
        * WebView.cpp:
        (WebView::ensureBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
cfleizach@apple.com [Fri, 19 Jun 2009 01:20:28 +0000 (01:20 +0000)]
Bug 26522: In DOM mode, VoiceOver reads some mouseover text on web sites strangely
https://bugs.webkit.org/show_bug.cgi?id=26522

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix after recent RenderTheme changes.
kevino@webkit.org [Fri, 19 Jun 2009 01:18:21 +0000 (01:18 +0000)]
wx build fix after recent RenderTheme changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 19 Jun 2009 01:14:27 +0000 (01:14 +0000)]
2009-06-18  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26460 part two
        Attempt to minimize diff of following functional change by first landing
        non-functional change to:
        * Make readUintX() public and static (since they will need to be once
          BMPImageReader is included in *ImageDecoder via composition rather
          than inheritance).  Add wrappers in each class so callers can be
          simpler.  In the next patch, these wrappers will be beefed up slightly
          and the callers will get even simpler.
        * Change direct setting of m_failed to use setFailed(), since in the
          next patch much of this code won't even have direct access to m_failed
        * Add a helper function in ICOImageDecoder to determine the image type
          instead of simply doing it inline
        * Rewrap lines that used to be <=80 cols and slipped over it during the
          original landing of these decoders
        * Other misc. changes, e.g. adding constructor definitions, reordering
          functions, changing RGBA32Buffer& to RGBA32Buffer*, etc. that have no
          functional effect but minimize the subsequent diff for readability

        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::BMPImageDecoder):
        (WebCore::BMPImageDecoder::processFileHeader):
        * platform/image-decoders/bmp/BMPImageDecoder.h:
        (WebCore::BMPImageDecoder::readUint32):
        * platform/image-decoders/bmp/BMPImageReader.cpp:
        (WebCore::BMPImageReader::decodeBMP):
        (WebCore::BMPImageReader::getInfoHeaderSize):
        (WebCore::BMPImageReader::processInfoHeader):
        (WebCore::BMPImageReader::readInfoHeader):
        (WebCore::BMPImageReader::processBitmasks):
        (WebCore::BMPImageReader::processColorTable):
        (WebCore::BMPImageReader::processRLEData):
        (WebCore::BMPImageReader::processNonRLEData):
        * platform/image-decoders/bmp/BMPImageReader.h:
        (WebCore::BMPImageReader::readUint16Helper):
        (WebCore::BMPImageReader::readUint32Helper):
        (WebCore::BMPImageReader::):
        (WebCore::BMPImageReader::readUint16):
        (WebCore::BMPImageReader::readUint32):
        (WebCore::BMPImageReader::readCurrentPixel):
        (WebCore::BMPImageReader::getComponent):
        (WebCore::BMPImageReader::setI):
        (WebCore::BMPImageReader::setRGBA):
        (WebCore::BMPImageReader::fillRGBA):
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::ICOImageDecoder):
        (WebCore::ICOImageDecoder::isSizeAvailable):
        (WebCore::ICOImageDecoder::size):
        (WebCore::ICOImageDecoder::decodeImage):
        (WebCore::ICOImageDecoder::processDirectory):
        (WebCore::ICOImageDecoder::processDirectoryEntries):
        (WebCore::ICOImageDecoder::isBetterEntry):
        (WebCore::ICOImageDecoder::processImageType):
        * platform/image-decoders/ico/ICOImageDecoder.h:
        (WebCore::ICOImageDecoder::readUint16):
        (WebCore::ICOImageDecoder::readUint32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Thu, 18 Jun 2009 22:52:35 +0000 (22:52 +0000)]
2009-06-18  Peter Kasting  <pkasting@google.com>

        Fix build bustage.

        * platform/image-decoders/gif/GIFImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
kmccullough@apple.com [Thu, 18 Jun 2009 22:34:13 +0000 (22:34 +0000)]
JavaScriptCore:

2009-06-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

        - Exposed functions now needed by WebCore.

        * JavaScriptCore.exp:

WebCore:

2009-06-18  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6940880> REGRESSION: Breakpoints don't break in 64-bit

        Convert intptr_t to Strings so that we don't loose bits in the
        conversion to JS.  Previously they were being put into 32bit ints.

        * inspector/InspectorController.cpp: Convert the String back to an
        intptr_t.
        (WebCore::InspectorController::addBreakpoint):
        (WebCore::InspectorController::removeBreakpoint):
        * inspector/InspectorController.h:
        * inspector/InspectorController.idl: Use strings in JS to avoid 32bit
        truncation.
        * inspector/InspectorFrontend.cpp: Make the intptr_t into a String.
        (WebCore::InspectorFrontend::parsedScriptSource):
        * platform/text/PlatformString.h: Implemented the necessary conversion
        functions to be able to convert to and from an intptr_t.
        * platform/text/String.cpp: Ditto.
        (WebCore::String::toIntPtrStrict):
        (WebCore::String::toIntPtr):
        (WebCore::charactersToIntPtrStrict):
        (WebCore::charactersToIntPtr):
        * platform/text/StringImpl.cpp: Ditto.
        (WebCore::StringImpl::toIntPtrStrict):
        (WebCore::StringImpl::toIntPtr):
        * platform/text/StringImpl.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Ryosuke Niwa <rniwa@google.com>
jparent@chromium.org [Thu, 18 Jun 2009 22:15:33 +0000 (22:15 +0000)]
2009-06-18  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests. This
        fixes the bug 26336 partially.

        * editing/execCommand/insertHTML-expected.txt: Added.
        * editing/execCommand/insertHTML.html:
        * editing/execCommand/switch-list-type-expected.txt: Added.
        * editing/execCommand/switch-list-type.html:
        * platform/mac/editing/execCommand/insertHTML-expected.checksum: Removed.
        * platform/mac/editing/execCommand/insertHTML-expected.png: Removed.
        * platform/mac/editing/execCommand/insertHTML-expected.txt: Removed.
        * platform/mac/editing/execCommand/switch-list-type-expected.checksum: Removed.
        * platform/mac/editing/execCommand/switch-list-type-expected.png: Removed.
        * platform/mac/editing/execCommand/switch-list-type-expected.txt: Removed.
        * platform/qt/editing/execCommand/insertHTML-expected.txt: Removed.
        * platform/qt/editing/execCommand/switch-list-type-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 18 Jun 2009 22:04:41 +0000 (22:04 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        Final cleanups in this refactoring:
        (1) Move WindowsBitmap implementation from CG-specific file to
            the platform-common GraphicsContextWin.cpp, since it is
            equally useful on both platforms.
        (2) Revise the TransformationMatrix logic as suggested by
            Adam Roben in his review comments to Part #2 of this
            refactoring.

        * platform/graphics/win/GraphicsContextCGWin.cpp:
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap):
        (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap):
        (WebCore::GraphicsContext::createWindowsBitmap):
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContextPlatformPrivate::scale):
        (WebCore::GraphicsContextPlatformPrivate::rotate):
        (WebCore::GraphicsContextPlatformPrivate::translate):
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 18 Jun 2009 21:44:15 +0000 (21:44 +0000)]
2009-06-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6926859>
        NPN_ConvertPoint doesn't give the right value when converting to/from NPCoordinateSpaceFlippedScreen

        When inverting Y, use the height of the first screen instead of the screen the window is on.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::windowFrameChanged):
        (WebKit::NetscapePluginInstanceProxy::mouseEvent):
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 18 Jun 2009 21:39:36 +0000 (21:39 +0000)]
2009-06-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez and Christian Dywan.

        Add a new load status to report that the first visually non-empty
        layout has been done.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
        * webkit/webkitwebframe.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 18 Jun 2009 21:39:18 +0000 (21:39 +0000)]
2009-06-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Fix parameters of navigation-policy-decision-requested callback,
        to be correct in number and type

        * tests/testhttpbackend.c:
        (navigation_policy_decision_requested_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Thu, 18 Jun 2009 21:29:11 +0000 (21:29 +0000)]
2009-06-18  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26460 part one
        Make isSizeAvailable non-const, since it's not logically const (it
        triggers lazy decoding), and simplify all the implementations (without
        changing behavior; just make less verbose).  Remove some other
        inappropriate consts, which enables the removal of all the mutable
        declarations in the decoders.

        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::isSizeAvailable):
        (WebCore::ImageDecoder::setSize): Make public to avoid needing a friend declaration in the JPEG decoder, and because the ICO/BMP decoders will soon need this.
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::isSizeAvailable):
        (WebCore::GIFImageDecoder::repetitionCount):
        (WebCore::GIFImageDecoder::decode):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::isSizeAvailable):
        * platform/image-decoders/ico/ICOImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::isSizeAvailable):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::isSizeAvailable):
        (WebCore::PNGImageDecoder::decode):
        * platform/image-decoders/png/PNGImageDecoder.h:
        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::isSizeAvailable):
        (WebCore::XBMImageDecoder::frameBufferAtIndex):
        (WebCore::XBMImageDecoder::decode):
        * platform/image-decoders/xbm/XBMImageDecoder.h: Rename decodeXBM() to decode() for consistency with the JPEG/PNG decoders, and in the future the ICO/BMP decoders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Ryosuke Niwa <rniwa@google.com>
jparent@chromium.org [Thu, 18 Jun 2009 21:25:50 +0000 (21:25 +0000)]
2009-06-18  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests. This
        fixes the bug 26336 partially.

        * editing/execCommand/5207369-expected.txt: Added.
        * editing/execCommand/5207369.html:
        * editing/execCommand/5210032-expected.txt: Added.
        * editing/execCommand/5210032.html:
        * editing/execCommand/5432254-1-expected.txt: Added.
        * editing/execCommand/5432254-1.html:
        * platform/mac/editing/execCommand/5207369-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5207369-expected.png: Removed.
        * platform/mac/editing/execCommand/5207369-expected.txt: Removed.
        * platform/mac/editing/execCommand/5210032-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5210032-expected.png: Removed.
        * platform/mac/editing/execCommand/5210032-expected.txt: Removed.
        * platform/mac/editing/execCommand/5432254-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5432254-1-expected.png: Removed.
        * platform/mac/editing/execCommand/5432254-1-expected.txt: Removed.
        * platform/qt/editing/execCommand/5207369-expected.txt: Removed.
        * platform/qt/editing/execCommand/5210032-expected.txt: Removed.
        * platform/qt/editing/execCommand/5432254-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRyosuke Niwa <rniwa@google.com>
jparent@chromium.org [Thu, 18 Jun 2009 21:21:32 +0000 (21:21 +0000)]
Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests. This
        fixes the bug 26336 partially.

        * editing/execCommand/5142012-3-expected.txt: Added.
        * editing/execCommand/5142012-3.html:
        * editing/execCommand/5144139-1-expected.txt: Added.
        * editing/execCommand/5144139-1.html:
        * editing/execCommand/5164796-expected.txt: Added.
        * editing/execCommand/5164796.html:
        * platform/mac/editing/execCommand/5142012-3-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5142012-3-expected.png: Removed.
        * platform/mac/editing/execCommand/5142012-3-expected.txt: Removed.
        * platform/mac/editing/execCommand/5144139-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5144139-1-expected.png: Removed.
        * platform/mac/editing/execCommand/5144139-1-expected.txt: Removed.
        * platform/mac/editing/execCommand/5164796-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5164796-expected.png: Removed.
        * platform/mac/editing/execCommand/5164796-expected.txt: Removed.
        * platform/qt/editing/execCommand/5142012-3-expected.txt: Removed.
        * platform/qt/editing/execCommand/5144139-1-expected.txt: Removed.
        * platform/qt/editing/execCommand/5164796-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRyosuke Niwa <rniwa@google.com>
jparent@chromium.org [Thu, 18 Jun 2009 21:13:48 +0000 (21:13 +0000)]
Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests.
 This
fixes the bug 26336 partially.

        * editing/execCommand/4916583-expected.txt: Added.
        * editing/execCommand/4916583.html:
        * editing/execCommand/5119244-expected.txt: Added.
        * editing/execCommand/5119244.html:
        * editing/execCommand/5120591-expected.txt: Added.
        * editing/execCommand/5120591.html:
        * platform/mac/editing/execCommand/4916583-expected.checksum: Removed.
        * platform/mac/editing/execCommand/4916583-expected.png: Removed.
        * platform/mac/editing/execCommand/4916583-expected.txt: Removed.
        * platform/mac/editing/execCommand/5119244-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5119244-expected.png: Removed.
        * platform/mac/editing/execCommand/5119244-expected.txt: Removed.
        * platform/mac/editing/execCommand/5120591-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5120591-expected.png: Removed.
        * platform/mac/editing/execCommand/5120591-expected.txt: Removed.
        * platform/qt/editing/execCommand/4916583-expected.txt: Removed.
        * platform/qt/editing/execCommand/5119244-expected.txt: Removed.
        * platform/qt/editing/execCommand/5120591-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 18 Jun 2009 20:47:13 +0000 (20:47 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Eric Seidel.

        Move some common functions out of platform files and into
        the common implementation.

        https://bugs.webkit.org/show_bug.cgi?id=26425.
        Add a new platform context method (flush) so that the
        getWindowsContext method can be consolidated into the common
        GraphicsContextWin.cpp file.

        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        (WebCore::GraphicsContextPlatformPrivate::flush):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        (WebCore::GraphicsContextPlatformPrivate::flush):
        * platform/graphics/win/GraphicsContextCGWin.cpp: Remove
          getWindowContext method.
        * platform/graphics/win/GraphicsContextCairoWin.cpp: Remove
          getWindowContext method and fillWithClearColor methods.
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::fillWithClearColor): Moved from *CairoWin.cpp
        (WebCore::GraphicsContext::getWindowsContext): Moved
          from *CairoWin.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Thu, 18 Jun 2009 20:44:29 +0000 (20:44 +0000)]
2009-06-18  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Gustavo Noronha.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::loadDone):
        (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
        (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
        (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static
        function loadDone to emit "load-done" and update the status and update
        the relevent places. We missed some status notifications before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 18 Jun 2009 20:30:42 +0000 (20:30 +0000)]
2009-06-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Be consistent in always using the term URI instead of URL in the
        documentation of WebKitWebView signals.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_class_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 18 Jun 2009 20:28:54 +0000 (20:28 +0000)]
2009-06-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Oliver Hunt.

        Remove code that I accidentally committed in r44811.

        * editing/markup.cpp:
        (WebCore::createMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 20:25:58 +0000 (20:25 +0000)]
2009-06-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6983207> Non-layer content is not re-rendered when transition
        starts sometimes (with hardware acceleration).

        When deciding which RenderLayers should be composited, when a layer goes into
        compositing mode we repaint the old location. However, we did that before
        we'd looked at all the factors that may force a layer to composite, so missed
        some cases. Fix by doing the repaint once we really know whether it's going
        to composite.

        Test: compositing/repaint/become-overlay-composited-layer.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak and Dave Levin.
ap@webkit.org [Thu, 18 Jun 2009 19:58:16 +0000 (19:58 +0000)]
    Reviewed by Maciej Stachowiak and Dave Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26510
        Add tests for authentication behavior with cross-origin XMLHttpRequest

        * http/tests/xmlhttprequest/cross-origin-authorization-expected.txt: Added.
        * http/tests/xmlhttprequest/cross-origin-authorization.html: Added.
        * http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
        * http/tests/xmlhttprequest/cross-origin-no-authorization.html: Added.
        * http/tests/xmlhttprequest/resources/cross-origin-authorization.php: Added.
        * http/tests/xmlhttprequest/resources/cross-origin-check-cookies.php: Added.
        * http/tests/xmlhttprequest/resources/cross-origin-no-authorization.php: Added.
        * http/tests/xmlhttprequest/resources/cross-origin-preset-authorization-frame.html: Added.
        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 18 Jun 2009 19:21:20 +0000 (19:21 +0000)]
2009-06-18  Darin Adler  <darin@apple.com>

        Rubber stamped by Mark Rowe.

        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        (-[DumpRenderTreeWindow close]): Resolved crashes seen during regression
        tests. The close method can be called on a window that's already closed
        so we can't assert here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 19:19:15 +0000 (19:19 +0000)]
2009-06-18  Simon Fraser  <simon.fraser@apple.com>

        Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined, and
        the Tiger build where QTMovieLayer does not exist.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieLayer):
        (WebCore::MediaPlayerPrivate::destroyQTMovieLayer):
        (WebCore::MediaPlayerPrivate::currentRenderingMode):
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
        (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
darin@apple.com [Thu, 18 Jun 2009 19:18:12 +0000 (19:18 +0000)]
JavaScriptCore:

2009-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 26429: Make JSON.stringify non-recursive so it can handle objects
        of arbitrary complexity
        https://bugs.webkit.org/show_bug.cgi?id=26429

        For marking I decided not to use gcProtect, because this is inside the engine
        so it's easy enough to just do marking. And that darned gcProtect does locking!
        Oliver tried to convince me to used MarkedArgumentBuffer, but the constructor
        for that class says "FIXME: Remove all clients of this API, then remove this API."

        * runtime/Collector.cpp:
        (JSC::Heap::collect): Add a call to JSONObject::markStringifiers.

        * runtime/CommonIdentifiers.cpp:
        (JSC::CommonIdentifiers::CommonIdentifiers): Added emptyIdentifier.
        * runtime/CommonIdentifiers.h: Ditto.

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::JSGlobalData): Initialize firstStringifierToMark to 0.
        * runtime/JSGlobalData.h: Added firstStringifierToMark.

        * runtime/JSONObject.cpp: Cut down the includes to the needed ones only.
        (JSC::unwrapNumberOrString): Added. Helper for unwrapping number and string
        objects to get their number and string values.
        (JSC::ReplacerPropertyName::ReplacerPropertyName): Added. The class is used
        to wrap an identifier or integer so we don't have to do any work unless we
        actually call a replacer.
        (JSC::ReplacerPropertyName::value): Added.
        (JSC::gap): Added. Helper function for the Stringifier constructor.
        (JSC::PropertyNameForFunctionCall::PropertyNameForFunctionCall): Added.
        The class is used to wrap an identifier or integer so we don't have to
        allocate a number or string until we actually call toJSON or a replacer.
        (JSC::PropertyNameForFunctionCall::asJSValue): Added.
        (JSC::Stringifier::Stringifier): Updated and moved out of the class
        definition. Added code to hook this into a singly linked list for marking.
        (JSC::Stringifier::~Stringifier): Remove from the singly linked list.
        (JSC::Stringifier::mark): Mark all the objects in the holder stacks.
        (JSC::Stringifier::stringify): Updated.
        (JSC::Stringifier::appendQuotedString): Tweaked and streamlined a bit.
        (JSC::Stringifier::toJSON): Renamed from toJSONValue.
        (JSC::Stringifier::appendStringifiedValue): Renamed from stringify.
        Added code to use the m_holderStack to do non-recursive stringify of
        objects and arrays. This code also uses the timeout checker since in
        pathological cases it could be slow even without calling into the
        JavaScript virtual machine.
        (JSC::Stringifier::willIndent): Added.
        (JSC::Stringifier::indent): Added.
        (JSC::Stringifier::unindent): Added.
        (JSC::Stringifier::startNewLine): Added.
        (JSC::Stringifier::Holder::Holder): Added.
        (JSC::Stringifier::Holder::appendNextProperty): Added. This is the
        function that handles the format of arrays and objects.
        (JSC::JSONObject::getOwnPropertySlot): Moved this down to the bottom
        of the file so the JSONObject class is not interleaved with the
        Stringifier class.
        (JSC::JSONObject::markStringifiers): Added. Calls mark.
        (JSC::JSONProtoFuncStringify): Streamlined the code here. The code
        to compute the gap string is now a separate function.

        * runtime/JSONObject.h: Made everything private. Added markStringifiers.

LayoutTests:

2009-06-17  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 26429: Make JSON.stringify non-recursive so it can handle objects
        of arbitrary complexity
        https://bugs.webkit.org/show_bug.cgi?id=26429

        * fast/js/JSON-stringify-expected.txt: Updated.
        * fast/js/resources/JSON-stringify.js: Changed the infinite object and
        infinite array tests to instead just test something a fixed number of
        levels deep. Otherwise we end up with an infinite loop in the test,
        which would lead to the slow-script dialog in the production web browser.
        Also raised the number from 512 to 2048 since there's no fixed limit any more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 19:06:08 +0000 (19:06 +0000)]
2009-06-18  Simon Fraser  <simon.fraser@apple.com>

        Fix the Leopard build where USE(ACCELERATED_COMPOSITING) is not defined.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::currentRenderingMode):
        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        (WebCore::MediaPlayerPrivate::tearDownVideoRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Erik Arvidsson <arv@chromium.org>
ojan@chromium.org [Thu, 18 Jun 2009 18:58:02 +0000 (18:58 +0000)]
2009-06-17  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=15189
        Adds the HTML5 input event support for textarea.

        Also, moves the oninput attribute parse handling to HTMLElement so that
        it can be set on any HTML element so that bubbling events can be handled
        using HTML attribute handlers.

        Test: fast/forms/textarea-input-event.html

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::subtreeHasChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 18 Jun 2009 18:53:51 +0000 (18:53 +0000)]
2009-06-18  Dirk Schulze  <krit@webkit.org>

        Reviewed by Oliver Hunt.

        Share code between filterEffects
        [https://bugs.webkit.org/show_bug.cgi?id=26479]

        Share more code of filter effects. The imageBuffer creation can move to
        FilterEffect ant every effect asks for the GraphicsContext. Move the
        drawingRect calculation to FilterEffect.

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::calculateDrawingRect):
        (WebCore::FilterEffect::getEffectContext):
        * platform/graphics/filters/FilterEffect.h:
        * platform/graphics/filters/SourceGraphic.cpp:
        (WebCore::SourceGraphic::apply):
        * svg/graphics/filters/SVGFEFlood.cpp:
        (WebCore::FEFlood::apply):
        * svg/graphics/filters/SVGFEOffset.cpp:
        (WebCore::FEOffset::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 18:52:09 +0000 (18:52 +0000)]
2009-06-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=26499

        Support hardware-accelerationed rendering of video elements.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::mediaPlayerSawUnsupportedTracks):
        (WebCore::HTMLMediaElement::mediaPlayerRepaint):
        Just move these methods to group the render-related methods together.

        (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
        Call out method to ask the RenderLayerCompositor if presentation of this video
        can be acclerated. It might say no, if, for example, the video has a reflection.

        (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
        Fetch the GraphicsLayer from the RenderVideo that will host the movie layer.

        * html/HTMLMediaElement.h:
        Reordered the rendering-related methods, and added two methods related to video
        acceleration.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::acceleratedRenderingStateChanged):
        Called by the rendering system when it determines that the video must go into, or
        fall off of the hardware-accelerated path.

        (WebCore::MediaPlayer::supportsAcceleratedRendering):
        Method to say whether the media engine supports accelerated rendering.

        * platform/graphics/MediaPlayer.h:
        (WebCore::MediaPlayerClient::mediaPlayerRepaint):
        (WebCore::MediaPlayerClient::mediaPlayerSizeChanged):
        Moved.

        (WebCore::MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated):
        (WebCore::MediaPlayerClient::mediaPlayerGraphicsLayer):
        New methods to ask the client if the rendering system can support accelerated
        rendering, and to get a GraphicsLayer to plug the movie layer into.

        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::supportsAcceleratedRendering):
        (WebCore::MediaPlayerPrivateInterface::acceleratedRenderingStateChanged):
        Forwarding methods from MediaPlayer.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        Some new methods related to using a QTMovieLayer, and to simplify the rendering mode logic.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovieLayer):
        (WebCore::MediaPlayerPrivate::destroyQTMovieLayer):
        Methods to create and destroy the QTMovieLayer.

        (WebCore::MediaPlayerPrivate::currentRenderingMode):
        (WebCore::MediaPlayerPrivate::preferredRenderingMode):
        Methods to clarify the code that decides which of the 3 rendering modes to use.

        (WebCore::MediaPlayerPrivate::setUpVideoRendering):
        Changed to use the new rendering mode methods.

        (WebCore::MediaPlayerPrivate::tearDownVideoRendering):
        Destroy the layer if we have one.

        (WebCore::MediaPlayerPrivate::hasSetUpVideoRendering):
        Small utility method.

        (WebCore::MediaPlayerPrivate::updateStates):
        Move the call to setUpVideoRendering() to before we send out the state notifications,
        so that we will have created the rendering objects already.

        (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
        Return true if we have QTMovieLayer.

        (WebCore::MediaPlayerPrivate::acceleratedRenderingStateChanged):
        We've been told that we went into or out of accelerated mode; maybe reset
        the renderer, and set the layer if we have to.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::rendererContentChanged):
        We may need to udpate compositing layers if the video went into accelerated mode.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::canUseDirectCompositing):
        Add smarts to deal with video, which allows us to avoid extra backing store.

        (WebCore::RenderLayerBacking::contentsBox):
        Use the videoBox to use the content layer for video layers.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):
        Poke the RenderVideo if the state changed.

        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        Handle an edge case when the video element itself is a stacking context
        because of opacity or transform.

        (WebCore::RenderLayerCompositor::canAccelerateVideoRendering):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):
        (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
        Allow video to throw us into compositing mode if the media engine supports it.

        * rendering/RenderLayerCompositor.h:
        New methods related to video.

        * rendering/RenderVideo.h:
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::updatePlayer):
        Call rendererContentChanged() to give the compositor a change to throw the video into
        compositing mode.

        (WebCore::RenderVideo::supportsAcceleratedRendering):
        (WebCore::RenderVideo::acceleratedRenderingStateChanged):
        (WebCore::RenderVideo::videoGraphicsLayer):
        Methods to allow the MediaPlayer to do rendering-related stuff via the media element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Niko.
rwlbuis@webkit.org [Thu, 18 Jun 2009 18:40:10 +0000 (18:40 +0000)]
    Reviewed by Niko.

        https://bugs.webkit.org/show_bug.cgi?id=26385
        Root SVG element is not checked on requiredFeatures, requiredExtension like other elements

        Also do the isValid check for outer <svg>.

        Test: svg/custom/outer-svg-unknown-feature.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 18:08:53 +0000 (18:08 +0000)]
2009-06-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=26499

        New expected results after making <video> elements get RenderLayers.

        * platform/mac/fast/replaced/border-radius-clip-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 18 Jun 2009 17:54:16 +0000 (17:54 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/6913221> REGRESSION (Safari 3-4): Search field on
          apple.com cuts entered text

        Test: fast/forms/search-vertical-alignment.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout): Vertically center the
            the search field's inner block.

LayoutTests:

        Reviewed by Darin Adler.

        - test and updated result for <rdar://problem/6913221>
          REGRESSION (Safari 3-4): Search field on apple.com cuts entered text

        * fast/forms/search-vertical-alignment.html: Added.
        * platform/mac/fast/forms/search-vertical-alignment-expected.checksum: Added.
        * platform/mac/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/mac/fast/forms/search-vertical-alignment-expected.txt: Added.
        * platform/mac/fast/forms/search-zoomed-expected.checksum:
        * platform/mac/fast/forms/search-zoomed-expected.png:
        * platform/mac/fast/forms/search-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Janne Koskinen <janne.p.koskinen@digia.com>
hausmann@webkit.org [Thu, 18 Jun 2009 15:08:12 +0000 (15:08 +0000)]
2009-06-18  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Simon Hausmann.

        Fix compilation with Symbian WINSCW compiler, which produced
        multiple definitions of the CSSPrimitiveValue conversion operators.

        It turns out that they are defined inline but not declared inline.

        Adding the inline keyword to the declaration fixes the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Friedemann Kleint <Friedemann.Kleint@nokia.com>
hausmann@webkit.org [Thu, 18 Jun 2009 14:45:50 +0000 (14:45 +0000)]
2009-06-18  Friedemann Kleint  <Friedemann.Kleint@nokia.com>

        Reviewed by Simon Hausmann.

        Fixed MinGW compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Markus Goetz <Markus.Goetz@nokia.com>
hausmann@webkit.org [Thu, 18 Jun 2009 14:41:56 +0000 (14:41 +0000)]
2009-06-18  Markus Goetz <Markus.Goetz@nokia.com>

        Reviewed by Simon Hausman.

        Clarify in docs how to compile with debug information.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Jakub Wieczorek <faw217@gmail.com>
ariya@webkit.org [Thu, 18 Jun 2009 13:42:58 +0000 (13:42 +0000)]
2009-06-18  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] When writing an URL to the clipboard, save the corresponding title
        in the mime data as well.

        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::writeURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Jakub Wieczorek <faw217@gmail.com>
ariya@webkit.org [Thu, 18 Jun 2009 13:40:22 +0000 (13:40 +0000)]
2009-06-18  Jakub Wieczorek  <faw217@gmail.com>

        [Qt] Fix build. Add HTMLDataGridElement.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 18 Jun 2009 10:25:27 +0000 (10:25 +0000)]
2009-06-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix.

        Add HTMLDataGridElement header and IDL to the build script.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Thu, 18 Jun 2009 07:55:33 +0000 (07:55 +0000)]
WebCore:

2009-06-18  Chris Evans  <scarybeasts@gmail.com>

        Reviewed by Adam Barth.

        Fix 8-digit long hex entities. Fixes bug 26454
        https://bugs.webkit.org/show_bug.cgi?id=26454

        Test: fast/parser/eightdigithexentity.html

        * html/HTMLTokenizer.cpp: fix off-by-ones.

LayoutTests:

2009-06-18  Chris Evans  <scarybeasts@gmail.com>

        Reviewed by Adam Barth.

        Added test for bug 26454 (broken 8-digit hex entities).
        https://bugs.webkit.org/show_bug.cgi?id=26454

        * fast/parser/eightdigithexentity-expected.txt: Added.
        * fast/parser/eightdigithexentity.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-18 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 18 Jun 2009 07:08:17 +0000 (07:08 +0000)]
2009-06-18  David Levin  <levin@chromium.org>

        Fix chromium linux build.

        Fixes a mistake that happened during the complicated merge for
        landing r44775, r44776, r44777.

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when...
oliver@apple.com [Thu, 18 Jun 2009 06:40:53 +0000 (06:40 +0000)]
<rdar://problem/6974140> REGRESSION(r43849): Crash in cti_op_call_NotJSFunction when getting directions on maps.google.com

Reviewed by Gavin Barraclough

Roll out r43849 as it appears that we cannot rely on the address of
an objects property storage being constant even if the structure is
unchanged.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Thu, 18 Jun 2009 05:50:07 +0000 (05:50 +0000)]
2009-06-17  Gavin Barraclough  <barraclough@apple.com>

        Rubber Stamped by Mark Rowe.

        Fully revert r44492 & r44748 while we fix a bug they cause on internal builds <rdar://problem/6955963>.

        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_throw):
        * jit/JITStubs.cpp:
        (JSC::):
        (JSC::JITStubs::DEFINE_STUB_FUNCTION):
        * jit/JITStubs.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Thu, 18 Jun 2009 02:37:05 +0000 (02:37 +0000)]
JavaScriptCore:

2009-06-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6947426> sunspider math-cordic.js exhibits different intermediate results running 32-bit vs. 64-bit

        On 64-bit, NaN-encoded values must be detagged before they can be used in rshift.

        No performance impact.

        * jit/JITArithmetic.cpp:
        (JSC::JIT::emit_op_rshift):

LayoutTests:

2009-06-17  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Mark Rowe.

        Add tests to check shifts by non-constant amounts.

        * fast/js/kde/operators-expected.txt:
        * fast/js/kde/resources/operators.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 01:49:27 +0000 (01:49 +0000)]
2009-06-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26499

        First step to making video rendering be hardware-accelerated:
        make <video> elements get self-painting RenderLayers, and add
        an isVideo() virtual method to RenderObject.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::setReadyState):
        (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
        (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::shouldBeNormalFlowOnly):
        (WebCore::RenderLayer::isSelfPaintingLayer):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isVideo):
        * rendering/RenderVideo.h:
        (WebCore::RenderVideo::requiresLayer):
        (WebCore::RenderVideo::isVideo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 18 Jun 2009 01:22:19 +0000 (01:22 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Refactor a few common routines in the various Windows ports
        and reduce some duplicated code.

        (1) Create TransformationMatrix XFORM casting operator, and
            switch various XFORM structure uses to utilize it.
        (2) Push concatCTM call to GraphicsContextWin now that the
            TransformationMatrix can directly create XFORM (rather
            than converting to CGAffineTransform/cairo_matrix_t first.)

        * WebCore.vcproj/WebCore.vcproj: Add new BitmapInfo structure.
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContextPlatformPrivate::scale):
        (WebCore::GraphicsContextPlatformPrivate::rotate):
        (WebCore::GraphicsContextPlatformPrivate::translate):
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/win/TransformationMatrixWin.cpp: Added.
        (WebCore::TransformationMatrix::operator XFORM): New operator

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 18 Jun 2009 01:05:44 +0000 (01:05 +0000)]
2009-06-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        Update results after enabling 3d rendering on SnowLeopard.

        * platform/mac-leopard/fast/media/mq-transform-02-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-02-expected.txt.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.checksum: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.checksum.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.png: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.png.
        * platform/mac-leopard/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac/fast/media/mq-transform-03-expected.txt.
        Copy the old "mac" results to "mac-leopard" since 3d-rendering is disabled there.

        * platform/mac/fast/media/mq-transform-02-expected.checksum:
        * platform/mac/fast/media/mq-transform-02-expected.png:
        * platform/mac/fast/media/mq-transform-02-expected.txt:
        * platform/mac/fast/media/mq-transform-03-expected.checksum:
        * platform/mac/fast/media/mq-transform-03-expected.png:
        * platform/mac/fast/media/mq-transform-03-expected.txt:
        New "mac" results for 3d rendering enabled.

        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt:
        * platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt:
        Update the results now that these tests are active.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/win:
sfalken@apple.com [Thu, 18 Jun 2009 00:41:08 +0000 (00:41 +0000)]
WebKit/win:

2009-06-17  Steve Falkenburg  <sfalken@apple.com>

        Consolidate WebKit COM interfaces.
        Moved IID from the highest numbered COM interface to the first interface and combined all methods.

        Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.

        Reviewed by Adam Roben.

        * Interfaces/IWebFrameLoadDelegate.idl:
        * Interfaces/IWebFrameLoadDelegatePrivate.idl:
        * Interfaces/IWebResourceLoadDelegatePrivate.idl:
        * Interfaces/IWebUIDelegate.idl:
        * Interfaces/IWebUIDelegatePrivate.idl:
        * Interfaces/WebKit.idl:
        * WebCoreSupport/WebChromeClient.cpp:
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebContextMenuClient.cpp:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        * WebCoreSupport/WebInspectorDelegate.h:
        * WebFrame.cpp:
        * WebView.cpp:

WebKitTools:

2009-06-17  Steve Falkenburg  <sfalken@apple.com>

        Updated for consolidated WebKit COM interfaces.

        Reviewed by Adam Roben.

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.h:
        * DumpRenderTree/win/UIDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.h:
        * WinLauncher/WinLauncher.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 18 Jun 2009 00:37:04 +0000 (00:37 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Non-CG Windows build fix after @r44758.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderTheme::themeForPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Thu, 18 Jun 2009 00:32:05 +0000 (00:32 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Refactor a few common routines in the various Windows ports
        and reduce some duplicated code.
        https://bugs.webkit.org/show_bug.cgi?id=26425.

        Refactor use of BITMAPINFO for the new BitmapInfo structure.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/win/BitmapInfo.cpp: Added.
        (WebCore::bitmapInfoForSize):
        (WebCore::BitmapInfo::create):
        (WebCore::BitmapInfo::createBottomUp):
        * platform/win/BitmapInfo.h: Added.
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        * platform/graphics/win/TransformationMatrixWin.cpp: Added.
        (WebCore::TransformationMatrix::operator XFORM): New operator
        * platform/win/DragImageCGWin.cpp:
        (WebCore::allocImage):
        * platform/win/DragImageCairoWin.cpp:
        (WebCore::allocImage):
        * platform/win/PasteboardWin.cpp:
        (WebCore::Pasteboard::writeImage):
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL
aroben@apple.com [Wed, 17 Jun 2009 22:37:09 +0000 (22:37 +0000)]
    Remove unnecessary 6th parameter from SOFT_LINK_OPTIONAL

        Reviewed by Mark Rowe.

        * platform/graphics/win/ColorSafari.cpp: Removed the 6th parameter and
        an unnecessary parameter name.
        * platform/win/SoftLinking.h: Removed the unused 6th parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make Settings::shouldPaintNativeControls default to true
aroben@apple.com [Wed, 17 Jun 2009 22:10:21 +0000 (22:10 +0000)]
    Make Settings::shouldPaintNativeControls default to true

        This matches the default up in WebKit (that was changed in r43318).

        Fixes Bug 26493: REGRESSION (r44758): First tab always uses Mac-style
        form controls
        <https://bugs.webkit.org/show_bug.cgi?id=26493>

        Reviewed by Darin Adler and Dave Hyatt.

        No test possible since DRT always uses Mac-style form controls.

        * page/Settings.cpp: Changed the initial value of
        gShouldPaintNativeControls to true.

        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderTheme::themeForPage): Added a FIXME about the design
        flaw here involving querying Settings before it's been initialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate layout test results for addition of datagrid element.
hyatt@apple.com [Wed, 17 Jun 2009 21:26:48 +0000 (21:26 +0000)]
Update layout test results for addition of datagrid element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 17 Jun 2009 21:24:07 +0000 (21:24 +0000)]
2009-06-17  David Levin  <levin@chromium.org>

        Fix chromium Windows build.

        A mistake that happened during the complicated merge for
        landing r44775, r44776, r44777.

        * rendering/RenderThemeChromiumWin.h:
        (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
        (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 17 Jun 2009 21:16:43 +0000 (21:16 +0000)]
2009-06-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6981193> Crash in MediaControlInputElement::attachToParent

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaTextDisplayElement::attachToParent): NULL check element renderer or parent renderer.
        (WebCore::MediaControlInputElement::attachToParent): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 17 Jun 2009 20:11:35 +0000 (20:11 +0000)]
2009-06-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        * security/index.html: Fix some typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 17 Jun 2009 20:05:09 +0000 (20:05 +0000)]
2009-06-17  David Hyatt  <hyatt@apple.com>

        Fix Windows build.  There's no HTMLDataGridElement.cpp file yet.

        * html/HTMLElementsAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 17 Jun 2009 19:56:23 +0000 (19:56 +0000)]
2009-06-17  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move security policy to security/index.html so that
        webkit.org/security/ works.

        * nav.inc:
        * security/index.html: Copied from security/security-policy.html.
        * security/security-policy.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Wed, 17 Jun 2009 19:33:21 +0000 (19:33 +0000)]
WebCore:

2009-06-17  David Hyatt  <hyatt@apple.com>

        Reviewed by Adam Roben and Anders Carlsson.

        Stub out the HTMLDataGridElement.

        * DerivedSources.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing):
        * html/HTMLDataGridElement.h: Added.
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        (WebCore::HTMLDataGridElement::tagPriority):
        * html/HTMLDataGridElement.idl: Added.
        * html/HTMLElement.cpp:
        (WebCore::inlineTagList):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::isAffectedByResidualStyle):
        * html/HTMLTagNames.in:

LayoutTests:

2009-06-17  David Hyatt  <hyatt@apple.com>

        Reviewed by Anders Carlsson.

        Update window properties layout test for HTMLDataGridElement addition.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 17 Jun 2009 19:31:47 +0000 (19:31 +0000)]
2009-06-17  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (chromium build fix).

        Fix typo in previous changes.

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::defaultGUIFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Wed, 17 Jun 2009 19:18:10 +0000 (19:18 +0000)]
2009-06-17  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26148
        Remove common code from RenderThemeChromiumWin that is shared with
        RenderThemeChromiumSkia.

        Also move supportsControlTints to RenderThemeChromiumLinux since it
        is linux specific.

        There are no tests changed because this just removes functions with
        duplicate implementations between the base and derived classes.

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::supportsControlTints):
        * rendering/RenderThemeChromiumLinux.h:
        * rendering/RenderThemeChromiumSkia.cpp:
        * rendering/RenderThemeChromiumSkia.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::):
        (WebCore::getNonClientMetrics):
        (WebCore::RenderThemeChromiumWin::RenderThemeChromiumWin):
        (WebCore::RenderThemeChromiumWin::~RenderThemeChromiumWin):
        (WebCore::RenderThemeChromiumWin::systemFont):
        (WebCore::RenderThemeChromiumWin::paintCheckbox):
        (WebCore::RenderThemeChromiumWin::paintRadio):
        (WebCore::RenderThemeChromiumWin::paintSliderThumb):
        (WebCore::RenderThemeChromiumWin::caretBlinkIntervalInternal):
        * rendering/RenderThemeChromiumWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Wed, 17 Jun 2009 19:18:01 +0000 (19:18 +0000)]
2009-06-17  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26148
        Move RenderThemeChromiumSkia into its own file.  This is purely a code move.

        * rendering/RenderThemeChromiumLinux.cpp:
        * rendering/RenderThemeChromiumLinux.h:
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::):
        (WebCore::setSizeIfAuto):
        (WebCore::mediaElementParent):
        (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
        (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia):
        (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia):
        (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet):
        (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet):
        (WebCore::RenderThemeChromiumSkia::supportsHover):
        (WebCore::RenderThemeChromiumSkia::supportsFocusRing):
        (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor):
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        (WebCore::RenderThemeChromiumSkia::systemFont):
        (WebCore::RenderThemeChromiumSkia::minimumMenuListSize):
        (WebCore::RenderThemeChromiumSkia::paintCheckbox):
        (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
        (WebCore::RenderThemeChromiumSkia::paintRadio):
        (WebCore::RenderThemeChromiumSkia::setRadioSize):
        (WebCore::brightenColor):
        (WebCore::paintButtonLike):
        (WebCore::RenderThemeChromiumSkia::paintButton):
        (WebCore::RenderThemeChromiumSkia::paintTextField):
        (WebCore::RenderThemeChromiumSkia::paintTextArea):
        (WebCore::RenderThemeChromiumSkia::paintSearchField):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
        (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal):
        (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
        (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
        (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
        (WebCore::RenderThemeChromiumSkia::paintMenuList):
        (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintMenuListButton):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom):
        (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal):
        (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
        * rendering/RenderThemeChromiumSkia.h:
        (WebCore::RenderThemeChromiumSkia::supportsControlTints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Wed, 17 Jun 2009 19:17:51 +0000 (19:17 +0000)]
2009-06-17  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26148
        Extract RenderThemeChromiumSkia out of RenderThemeChromiumLinux.  This
        is mostly a code shuffle.  The non-suffle changes are:
           1) Creation of a caretBlinkIntervalInternal.
           2) Moving of some inline functions into the implementation files.
           3) Changing of defaultGUIFont into a static class constant from a
              static function.  Also the type is changed to String.
           4) Changing of defaultFontSize into a static class constant from a
              static variable in the file scope.
           5) The static supportsFocus function was collapsed into
              supportsFocusRing.
           6) Split the extraDefaultStyleSheet into Skia and Linux versions.

        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumSkia::defaultGUIFont):
        (WebCore::RenderThemeChromiumSkia::RenderThemeChromiumSkia):
        (WebCore::RenderThemeChromiumSkia::~RenderThemeChromiumSkia):
        (WebCore::RenderThemeChromiumSkia::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumSkia::extraQuirksStyleSheet):
        (WebCore::RenderThemeChromiumSkia::extraMediaControlsStyleSheet):
        (WebCore::RenderThemeChromiumSkia::supportsHover):
        (WebCore::RenderThemeChromiumSkia::supportsFocusRing):
        (WebCore::RenderThemeChromiumSkia::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumSkia::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumSkia::platformInactiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumSkia::platformTextSearchHighlightColor):
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        (WebCore::RenderThemeChromiumSkia::systemFont):
        (WebCore::RenderThemeChromiumSkia::minimumMenuListSize):
        (WebCore::RenderThemeChromiumSkia::paintCheckbox):
        (WebCore::RenderThemeChromiumSkia::setCheckboxSize):
        (WebCore::RenderThemeChromiumSkia::paintRadio):
        (WebCore::RenderThemeChromiumSkia::setRadioSize):
        (WebCore::RenderThemeChromiumSkia::paintButton):
        (WebCore::RenderThemeChromiumSkia::paintTextField):
        (WebCore::RenderThemeChromiumSkia::paintTextArea):
        (WebCore::RenderThemeChromiumSkia::paintSearchField):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldDecorationStyle):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsDecorationStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeChromiumSkia::adjustSearchFieldResultsButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
        (WebCore::RenderThemeChromiumSkia::paintMediaButtonInternal):
        (WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):
        (WebCore::RenderThemeChromiumSkia::paintMediaMuteButton):
        (WebCore::RenderThemeChromiumSkia::adjustMenuListStyle):
        (WebCore::RenderThemeChromiumSkia::paintMenuList):
        (WebCore::RenderThemeChromiumSkia::adjustMenuListButtonStyle):
        (WebCore::RenderThemeChromiumSkia::paintMenuListButton):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingLeft):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingRight):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingTop):
        (WebCore::RenderThemeChromiumSkia::popupInternalPaddingBottom):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingLeft):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingRight):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingTop):
        (WebCore::RenderThemeChromiumSkia::buttonInternalPaddingBottom):
        (WebCore::RenderThemeChromiumSkia::caretBlinkIntervalInternal):
        (WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
        (WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
        (WebCore::RenderThemeChromiumLinux::systemColor):
        (WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
        (WebCore::RenderThemeChromiumSkia::menuListInternalPadding):
        * rendering/RenderThemeChromiumLinux.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 17 Jun 2009 19:07:09 +0000 (19:07 +0000)]
2009-06-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Timothy Hatcher.

        Add WebKit Security Policy and member list of the WebKit Security Group.

        * nav.inc:
        * security: Added.
        * security/security-group-members.html: Added.
        * security/security-policy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add a SOFT_LINK_OPTIONAL macro
aroben@apple.com [Wed, 17 Jun 2009 19:02:48 +0000 (19:02 +0000)]
    Add a SOFT_LINK_OPTIONAL macro

        This macro is useful when soft-linking functions that are present in
        only some versions of a particular library (e.g., APIs added in
        Windows Vista that aren't available on Windows XP).

        Reviewed by Ada Chan.

        * platform/graphics/win/ColorSafari.cpp:
        (WebCore::focusRingColor):
        Use the SoftLinking.h macros instead of doing the soft-link ourselves.
        Also removed an unused call to focusRingColor.isValid().

        * platform/win/SoftLinking.h: Added SOFT_LINK_OPTIONAL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Wed, 17 Jun 2009 18:25:14 +0000 (18:25 +0000)]
2009-06-17  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Gustavo Noronha Silva.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=26470.
        The use of zero-width or zero-height rectangles in generating
        gradients caused Windows Cairo to crash, and webkitgtk to
        produce invalid images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 17 Jun 2009 18:22:31 +0000 (18:22 +0000)]
2009-06-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by NOBODY (OOPS!).

        If loading a font fails because of the sandbox, we ask the browser process to
        try to load it by calling ensureFontLoaded. If it still fails after
        ensureFontLoaded, we hit a ASSERT_NOT_REACHED.

        This case happens once in a while during browser shutdown. The browser will
        queue a message to the renderer to shutdown, and will then stop answering sync
        messages from the renderer. If the renderer is still loading a page during this
        time, it might try to call the browser process to ask to load a font. The
        browser process will ignore the request, and the font will fail to load, even
        after the second try.

        This is unfortunate, but there is no real risk here, since the renderer will be
        going away as soon as it processes another message.

        This can't be layout tested as it depends on the sandbox.

        https://bugs.webkit.org/show_bug.cgi?id=26484

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-17 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 17 Jun 2009 18:21:04 +0000 (18:21 +0000)]
2009-06-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=26482
        <rdar://problem/6978590> When setting playback rate to 0, the audio element stops
        playing (doesn't resume later)

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::setRate): Always set the rate, even when "paused".

        * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
        (WebCore::MediaPlayerPrivate::setRate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add all the generated JS*.cpp files back to WebCore.vcproj
aroben@apple.com [Wed, 17 Jun 2009 17:13:56 +0000 (17:13 +0000)]
    Add all the generated JS*.cpp files back to WebCore.vcproj

        They are not compiled by the vcproj directly. Instead they are
        compiled as part of DerivedSources.cpp. Having them listed in the
        vcproj makes them be included in Project Find, etc.

        Rubber-stamped in advance by Steve Falkenburg.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@44768 268f45cc-cd09-0410-ab3c-d52691b4dbfc