WebKit-https.git
10 years ago2010-05-19 Dan Winship <danw@gnome.org>
eric@webkit.org [Wed, 19 May 2010 11:43:43 +0000 (11:43 +0000)]
2010-05-19  Dan Winship  <danw@gnome.org>

        Reviewed by Xan Lopez.

        [GTK] Install introspection files in our prefix, not
        gobject-introspection's prefix

        * GNUmakefile.am:
        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Wed, 19 May 2010 10:59:43 +0000 (10:59 +0000)]
2010-05-19  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Adler.

        fast/canvas/webgl/texture-npot.html failed on leopard bot
        https://bugs.webkit.org/show_bug.cgi?id=39128

        * fast/canvas/webgl/texture-npot-expected.txt: Skip pixel (0, 0); print out actual color when failing.
        * fast/canvas/webgl/texture-npot.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 19 May 2010 10:48:37 +0000 (10:48 +0000)]
2010-05-19  Steve Block  <steveblock@google.com>

        Reviewed by Nate Chapin.

        V8 code generator does not add ENABLE guards around attribute getters and setters
        https://bugs.webkit.org/show_bug.cgi?id=39222

        No new tests, build fix only.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 19 May 2010 10:17:53 +0000 (10:17 +0000)]
2010-05-19  Jeremy Orlow  <jorlow@chromium.org>

        Unreviewed build fix for Chromium.

        * storage/IndexedDatabaseImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 19 May 2010 10:04:35 +0000 (10:04 +0000)]
2010-05-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
        https://bugs.webkit.org/show_bug.cgi?id=39216

        All of these functions are supposed to be passing around the origin since
        the caller of IndexedDatabaseImpl might not be able to pass in a Frame*
        object.  I tried to fix this in an ealier patch, but obviously messed up.

        Also change passing security origin strings to passing SecurityOrigin
        objects.

        No behavior change because Chromium was emulating the old behavior before
        even though the code wasn't properly hooked up.

        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
2010-05-17  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
        https://bugs.webkit.org/show_bug.cgi?id=39216

        Web____Impl is for re-entering the WebKit layer from the browser layer.
        Thus the previous IDBCallbacksProxy was mis-named (and should have been
        WebIDBCallbacksImpl).  This patch renames it and then implements the
        proper proxy (which is for going from WebCore to WebKit).

        Also change using security origin strings to using WebSecurityOrigin
        objects.

        This patch also implements the glue between WebIndexedDatabaseImpl and
        IndexedDatabaseImpl.

        * WebKit.gyp:
        * src/IDBCallbacksProxy.cpp:
        (WebCore::IDBCallbacksProxy::create):
        (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::onError):
        (WebCore::IDBCallbacksProxy::onSuccess):
        * src/IDBCallbacksProxy.h:
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::open):
        * src/IndexedDatabaseProxy.h:
        * src/WebIDBCallbacksImpl.cpp: Added.
        (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
        (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl):
        (WebCore::WebIDBCallbacksImpl::onError):
        (WebCore::WebIDBCallbacksImpl::onSuccess):
        * src/WebIDBCallbacksImpl.h: Added.
        * src/WebIDBDatabaseImpl.cpp: Added.
        (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
        (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
        * src/WebIDBDatabaseImpl.h: Added.
        * src/WebIndexedDatabaseImpl.cpp:
        (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl):
        (WebKit::WebIndexedDatabaseImpl::open):
        * src/WebIndexedDatabaseImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Ben Murdoch <benm@google.com>
eric@webkit.org [Wed, 19 May 2010 09:37:37 +0000 (09:37 +0000)]
2010-05-19  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        Touch events are marked DontEnum in DOMWindow.idl
        https://bugs.webkit.org/show_bug.cgi?id=39118

        Update the expected results for enumerating the window object
        properties now touch event listeners are no longer marked DontEnum.

        * platform/qt/fast/dom/Window/window-properties-expected.txt:
2010-05-19  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        Touch events are marked DontEnum in DOMWindow.idl
        https://bugs.webkit.org/show_bug.cgi?id=39118

        Touch events are the only attribute event listeners on the
        window object that are marked DontEnum. For consistency allow
        them to be enumerated.

        * page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,
            touchstart and touchmove attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix build warning
hausmann@webkit.org [Wed, 19 May 2010 08:38:58 +0000 (08:38 +0000)]
[Qt] Fix build warning

NamedAttrMap.h has been renamed to NamedNodeMap.h

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 19 May 2010 08:22:02 +0000 (08:22 +0000)]
2010-05-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add an HTML parsing benchmark
        https://bugs.webkit.org/show_bug.cgi?id=39338

        This benchmark parses the HTML5 specification 10 times and
        reports how long it takes.  It does this 21 times, discarding
        the first warm-up run, and then prints the average time and
        standard deviation.

        Sharking the benchmark correctly shows over 60% of the time spent under HTMLTokenizer::write().
        The numbers from the benchmark are rather consistent.  On my
        Mac Book Pro, I consistently see standard deviations < 2% of total time.

        * benchmarks/parser/html-parser.html: Added.
        * benchmarks/parser/resources/html5.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Wed, 19 May 2010 07:33:28 +0000 (07:33 +0000)]
2010-05-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Make CSS Parser properly handle only-for-pages pseudo-classes.

        https://bugs.webkit.org/show_bug.cgi?id=38731

        * fast/css/misplaced-paged-media-pseudo-expected.txt: Removed.
        * fast/css/misplaced-paged-media-pseudo.html: Removed.
        * printing/page-rule-css-text-expected.txt:
        * printing/page-rule-css-text.html:
        * printing/pseudo-class-outside-page-expected.txt:
        * printing/pseudo-class-outside-page.html:
2010-05-18  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Shinichiro Hamaji.

        Make CSS Parser properly handle only-for-pages pseudo-classes.

        A new Match category, PagePseudoClass, is introduced to distinguish
        only-for-pages pseudo-classes from others. A new symbol, pseudo_page,
        is introduced to handle them separately.

        https://bugs.webkit.org/show_bug.cgi?id=38731

        * css/CSSGrammar.y:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::createMarginAtRule):
        * css/CSSParser.h:
        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::extractPseudoType):
        (WebCore::CSSSelector::selectorText):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-19 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 07:26:23 +0000 (07:26 +0000)]
2010-05-19  Adam Barth  <abarth@webkit.org>

        Reviewed by David Hyatt.

        Change the API of nextToken to distinguish between emitting a token and just running out of input
        https://bugs.webkit.org/show_bug.cgi?id=39349

        I'm not sure there's a functional difference with this patch yet, but
        as discussed with Eric, we need this to handle attributes.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::reset):
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Lexer.h:
        * html/HTML5Token.h:
        (WebCore::HTML5Token::HTML5Token):
        (WebCore::HTML5Token::clear):
        (WebCore::HTML5Token::beginStartTag):
        (WebCore::HTML5Token::beginEndTag):
        (WebCore::HTML5Token::beginCharacter):
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 19 May 2010 07:19:47 +0000 (07:19 +0000)]
2010-05-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits
        https://bugs.webkit.org/show_bug.cgi?id=39318

        No functional changes, only moving code into smaller functions.

        This code is already covered by numerous layout tests.

        HTML parsing benchmark shows this to be a wash.

        * dom/Tokenizer.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::advance):
         - New funtion to encapulate code which will move into HTMLLexer eventually.
         - Use ALWAYS_INLINE to make sure compilers inline this large
           function (otherwise this patch is a regression).
        (WebCore::HTMLTokenizer::willWriteHTML):
         - New function to handle calling any pre-write delegates.
        (WebCore::HTMLTokenizer::didWriteHTML):
         - New function to handle calling any post-write delegates.
        (WebCore::HTMLTokenizer::write):
         - Call the new functions.
        * html/HTMLTokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 19 May 2010 06:45:43 +0000 (06:45 +0000)]
2010-05-18  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skip test.

        Skipping fast/workers/storage
        https://bugs.webkit.org/show_bug.cgi?id=39346

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 06:30:19 +0000 (06:30 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make the HTML5 parser correctly parse <div>Hello</div>
        https://bugs.webkit.org/show_bug.cgi?id=39345

        Again, this patch is covered by a large number of LayoutTests.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::HTML5Lexer):
        (WebCore::HTML5Lexer::reset):
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::HTML5Lexer::emitCommentToken):
        (WebCore::HTML5Lexer::emitCharacter):
        (WebCore::HTML5Lexer::emitCurrentTagToken):
        * html/HTML5Lexer.h:
        * html/HTML5Token.h:
        (WebCore::HTML5Token::beginCharacter):
        (WebCore::HTML5Token::appendToCharacter):
        (WebCore::HTML5Token::characters):
        * html/HTML5Tokenizer.cpp:
        (WebCore::convertToOldStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 39343 - Dynamically generate a native call thunk per NativeFunction
barraclough@apple.com [Wed, 19 May 2010 06:04:18 +0000 (06:04 +0000)]
Bug 39343 - Dynamically generate a native call thunk per NativeFunction

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call.  By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.

* jit/JIT.h:
(JSC::JIT::compileCTINativeCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* jit/ThunkGenerators.cpp:
(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 05:30:33 +0000 (05:30 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make the HTML5 parser actually parse <div></div>
        https://bugs.webkit.org/show_bug.cgi?id=39342

        This patch is covered by every LayoutTest.  Yes.  All of them.  :)

        * html/HTML5Lexer.cpp:
        (WebCore::toLowerCase):
        (WebCore::HTML5Lexer::HTML5Lexer):
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::HTML5Lexer::emitCharacter):
        * html/HTML5Lexer.h:
        * html/HTML5Token.h:
        (WebCore::HTML5Token::HTML5Token):
        (WebCore::HTML5Token::beginStartTag):
        (WebCore::HTML5Token::beginEndTag):
        (WebCore::HTML5Token::appendToName):
        (WebCore::HTML5Token::type):
        (WebCore::HTML5Token::name):
        (WebCore::HTML5Token::selfClosing):
        (WebCore::HTML5Token::attrs):
        * html/HTML5Tokenizer.cpp:
        (WebCore::convertToOldStyle):
        (WebCore::HTML5Tokenizer::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DRT/Chromium] Fix a repaint issue and textarea tests
tkent@chromium.org [Wed, 19 May 2010 05:27:41 +0000 (05:27 +0000)]
[DRT/Chromium] Fix a repaint issue and textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

* DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
  and textAreaResizeCorner.png
* WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource

WebKitTools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::canvas): Remove m_paintRect initialization in canvas().
 This line updated m_paintRect unexpectedly during paintRect().
 We don't need to initialize m_paintRect because show() does it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 19 May 2010 05:12:06 +0000 (05:12 +0000)]
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] new-run-webkit-tests --use-drt should run on Linux
        https://bugs.webkit.org/show_bug.cgi?id=37845

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
ggaren@apple.com [Wed, 19 May 2010 05:10:11 +0000 (05:10 +0000)]
JavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

Removed the reserved OptionalCalleeArguments slot from the CallFrame.
Now, slots for 'arguments' are allocated and initialized only by
functions that might need them.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump): Updated for new bytecode operands.

(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
from the arguments register to its unmodified counterpart.

(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::usesArguments):  Changed from a "usesArguments" bool to
an optional int index representing the arguments register.

* bytecode/Opcode.h: Updated for new bytecode operands.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
arguments vs activation logic, and added code to allocate the arguments
registers when needed.

(JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
object before calling eval; the activation object will lazily create the
arguments object if eval resolves it.

(JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitPushScope):
(JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::registerFor): No more need for special handling
of the arguments registers; they're allocated just like normal registers
now.

* interpreter/CallFrame.h:
(JSC::ExecState::callerFrame):
(JSC::ExecState::init):
* interpreter/CallFrameClosure.h:
(JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
take operands specifying registers, just like all other opcodes.
JSActivation::copyRegisters is no longer responsible for tearing off the
arguments object; instead, the VM is responsible for both.

Also, a behavior change: Each access to f.arguments creates a new object,
unless f itself uses 'arguments'. This matches Chrome, and is necessary
for the optimization. f.arguments is a nonstandard, deprecated feature,
so high fidelity to a given implementation is not necessarily a goal.
Also, as illustrated by the new test case, the identity of f.arguments
has been broken since 2008, except in the case where f itself accesses
f.arguments -- but nobody seemed to notice. So, hopefully this change won't
break the web.

* interpreter/Register.h: Nixed the special arguments accessor. It's no
longer needed.

* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
OptionalCalleeArguments from the callframe slot. Now, it doesn't need
to be initialized for most calls.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::): Updated stubs to support arbitrary 'arguments' registers,
instead of hard-coding something in the call frame.

* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.

* runtime/Executable.h:
(JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
the 'arguments' register. In a future patch, that kind of data should
probably move out of CodeBlock and into Executable.

* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::argumentsGetter):
* runtime/JSActivation.h: Simplified / fixed access to 'arguments' via
the activation object. It now implements the same behavior implemented
by optimized variable access in the VM. This simplifies some other
things, too -- like eval code generation.

LayoutTests: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

* fast/js/function-dot-arguments-expected.txt:
* fast/js/script-tests/function-dot-arguments.js:
(argumentsIdentity): Updated to match new behavior.

* fast/js/function-dot-arguments2-expected.txt:
* fast/js/function-dot-arguments2.html: New tests for some things that
weren't covered before.

* fast/js/global-recursion-on-full-stack.html: Rejiggered the stack
usage in this test. Since stack usage is more efficient now, you
need a slightly different usage pattern to hit the exact thing this
test wanted to test.

* fast/js/kde/script-tests/function_arguments.js:
(f): Updated to more specifically test what this was trying to test,
to avoid just testing the identity of f.arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test fix.
tkent@chromium.org [Wed, 19 May 2010 04:24:13 +0000 (04:24 +0000)]
Unreviewed test fix.

fast/css/pseudo-required-optional-unapplied.html failure with ENABLE_METER_TAG
https://bugs.webkit.org/show_bug.cgi?id=39341

Remove test elements at the end of the test because dumpAsText() output
for <meter> depends on ENABLE_METER_TAG.

* fast/css/pseudo-required-optional-unapplied-expected.txt:
* fast/css/pseudo-required-optional-unapplied.html:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Add pseudo-required-optional-unapplied.html to qt/Skipped.
tkent@chromium.org [Wed, 19 May 2010 03:54:36 +0000 (03:54 +0000)]
Unreviewed.  Add pseudo-required-optional-unapplied.html to qt/Skipped.
https://bugs.webkit.org/show_bug.cgi?id=39341

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 19 May 2010 03:30:22 +0000 (03:30 +0000)]
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
        https://bugs.webkit.org/show_bug.cgi?id=38232

        * editing/execCommand/crash-indenting-list-item-expected.txt: Added.
        * editing/execCommand/crash-indenting-list-item.html: Added.
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
        https://bugs.webkit.org/show_bug.cgi?id=38232

        Test: editing/execCommand/crash-indenting-list-item.html

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
        (WebCore::IndentOutdentCommand::indentIntoBlockquote):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago':optional' pseudo selector should not be applied to <keygen> and <progress>
tkent@chromium.org [Wed, 19 May 2010 03:15:46 +0000 (03:15 +0000)]
':optional' pseudo selector should not be applied to <keygen> and <progress>
https://bugs.webkit.org/show_bug.cgi?id=39292

Reviewed by Darin Adler.

WebCore:

Test: fast/css/pseudo-required-optional-unapplied.html

* html/HTMLKeygenElement.h:
(WebCore::HTMLKeygenElement::isOptionalFormControl):
  Add isOptionalFormControl() returning false.
  HTMLKeygenElement inherits HTMLSelectElement, which should return true
  for isOptionalFormControl(). However, <keygen> is not :optional
  according to the standard.
* html/HTMLProgressElement.h:
  Remove isOptionalFormControl().

LayoutTests:

Add a test for non-optional form elements.

* fast/css/pseudo-required-optional-unapplied-expected.txt: Added.
* fast/css/pseudo-required-optional-unapplied.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 19 May 2010 02:59:10 +0000 (02:59 +0000)]
2010-05-18  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Fix some initialization/reset issues
        https://bugs.webkit.org/show_bug.cgi?id=39281

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::reset): Reset m_userStyleSheetLocation.
        * DumpRenderTree/chromium/LayoutTestController.h:
          Remove unused variable, m_workQueueFrozen.
        (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetTestController): Reset WebSettings too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 02:57:37 +0000 (02:57 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement the DOCTYPE states for the HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=39335

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::emitCurrentDoctypeToken):
        * html/HTML5Lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 19 May 2010 02:33:01 +0000 (02:33 +0000)]
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] ignore IME events if the keydown event was prevented
        https://bugs.webkit.org/show_bug.cgi?id=37692

        A manual test to verify the IME behavior since the existing methods of
        textInputController test at a lower level than the fix.

        * manual-tests/ime-keydown-preventdefault.html: Added.
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] ignore IME events if the keydown event was prevented
        https://bugs.webkit.org/show_bug.cgi?id=37692

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::handleCompositionEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the build for platforms that don't always include UnusedParam.h
weinig@apple.com [Wed, 19 May 2010 02:26:46 +0000 (02:26 +0000)]
Fix the build for platforms that don't always include UnusedParam.h

* dom/Attribute.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 19 May 2010 02:24:00 +0000 (02:24 +0000)]
2010-05-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Windows: Determinate progress bar should have glossy overlay
        https://bugs.webkit.org/show_bug.cgi?id=39269

        - Moved animation code from RenderThemeChromiumWin to chromium tree
          because it should be behind the theme implementation, which lives
          in chromium tree.
        - Passed current time to the bridge, which will be used to compute
          the state of the theme animation.

        No new tests, animation effect can be confirmed only manually.

        * platform/chromium/ChromiumBridge.h:
        * rendering/RenderProgress.h:
        (WebCore::RenderProgress::animationStartTime): Added.
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
2010-05-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Chromium] Windows: Determinate progress bar should have glossy overlay
        https://bugs.webkit.org/show_bug.cgi?id=39269

        Changed WebThemeEngine::drawProgressBar() signature to delegate
        theme implementation detail to the engine.
        Chromium side will come to http://crbug.com/44430.

        No new tests, animation effect can be confirmed only manually.

        * public/WebThemeEngine.h:
        (WebKit::WebThemeEngine::paintProgressBar):
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::paintProgressBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix release build.
weinig@apple.com [Wed, 19 May 2010 02:12:20 +0000 (02:12 +0000)]
Fix release build.

* dom/Attribute.cpp:
(WebCore::Attribute::unbindAttr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove Attr pointer from Attribute to a global HashMap.
weinig@apple.com [Wed, 19 May 2010 01:56:52 +0000 (01:56 +0000)]
Move Attr pointer from Attribute to a global HashMap.
https://bugs.webkit.org/show_bug.cgi?id=39337
<rdar://problem/8001168>

Reviewed by Maciej Stachowiak.

Shaves another word off of Attribute.

* dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::~Attr):
* dom/Attribute.cpp:
(WebCore::attributeAttrMap):
(WebCore::Attribute::attr):
(WebCore::Attribute::createAttrIfNeeded):
(WebCore::Attribute::bindAttr):
(WebCore::Attribute::unbindAttr):
* dom/Attribute.h:
(WebCore::Attribute::Attribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 19 May 2010 01:52:06 +0000 (01:52 +0000)]
2010-05-18  James Robinson  <jamesr@chromium.org>

        Unreviewed.

        Add leopard-specific pixel results for more tests that need them
        https://bugs.webkit.org/show_bug.cgi?id=39325

        This adds new Leopard baselines for all tests that currently
        pass with tolerance=0 on Snow Leopard but fail on Leopard
        with an image diff of <= 0.1%.  These tests previously had
        expectations in platform/mac that were Snow Leopard specific.

        * platform/mac-leopard/animations: Added.
        * platform/mac-leopard/animations/3d: Added.
        * platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.checksum: Added.
        * platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.png: Added.
        * platform/mac-leopard/compositing/animation: Added.
        * platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
        * platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
        * platform/mac-leopard/compositing/compositing-visible-descendant-expected.checksum: Added.
        * platform/mac-leopard/compositing/compositing-visible-descendant-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/fixed-position-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/fixed-position-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/partial-layout-update-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/partial-layout-update-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
        * platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
        * platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
        * platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
        * platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
        * platform/mac-leopard/compositing/masks: Added.
        * platform/mac-leopard/compositing/masks/direct-image-mask-expected.checksum: Added.
        * platform/mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
        * platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
        * platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
        * platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.checksum: Added.
        * platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
        * platform/mac-leopard/compositing/reflections/reflection-ordering-expected.checksum: Added.
        * platform/mac-leopard/compositing/reflections/reflection-ordering-expected.png: Added.
        * platform/mac-leopard/compositing/repaint/content-into-overflow-expected.checksum: Added.
        * platform/mac-leopard/compositing/repaint/content-into-overflow-expected.png: Added.
        * platform/mac-leopard/compositing/repaint/layer-repaint-expected.checksum: Added.
        * platform/mac-leopard/compositing/repaint/layer-repaint-expected.png: Added.
        * platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
        * platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.png: Added.
        * platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
        * platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.png: Added.
        * platform/mac-leopard/fast/borders: Added.
        * platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.checksum: Added.
        * platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Added.
        * platform/mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Added.
        * platform/mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
        * platform/mac-leopard/fast/forms/placeholder-stripped-expected.checksum: Added.
        * platform/mac-leopard/fast/forms/placeholder-stripped-expected.png: Added.
        * platform/mac-leopard/fast/multicol: Added.
        * platform/mac-leopard/fast/multicol/column-count-with-rules-expected.checksum: Added.
        * platform/mac-leopard/fast/multicol/column-count-with-rules-expected.png: Added.
        * platform/mac-leopard/media/controls-strict-expected.checksum:
        * platform/mac-leopard/media/controls-strict-expected.png:
        * platform/mac-leopard/media/video-display-toggle-expected.checksum:
        * platform/mac-leopard/media/video-display-toggle-expected.png:
        * platform/mac-leopard/media/video-replaces-poster-expected.checksum: Added.
        * platform/mac-leopard/media/video-replaces-poster-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Wed, 19 May 2010 01:32:06 +0000 (01:32 +0000)]
2010-05-18  Jakob Petsovits  <jpetsovits@rim.com>

        Unreviewed, forgot to svn add source file in r59619.
        http://trac.webkit.org/changeset/59619

        * platform/image-decoders/openvg: Added.
        * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added.
        (WebCore::RGBA32Buffer::asNewNativeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 19 May 2010 01:16:00 +0000 (01:16 +0000)]
2010-05-18  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        [GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=39326

        * platform/gtk/Skipped: Skip another test causing crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Wed, 19 May 2010 01:05:23 +0000 (01:05 +0000)]
2010-05-18  Yaar Schnitman  <yaar@chromium.org>

        Unreviewed, rolling out r59693.
        http://trac.webkit.org/changeset/59693
        https://bugs.webkit.org/show_bug.cgi?id=37815

        Broke GTK Release

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSCallbackData.cpp:
        (WebCore::JSCallbackData::invokeCallback):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::createInjectedScript):
        * bindings/js/JSMainThreadExecState.cpp: Removed.
        * bindings/js/JSMainThreadExecState.h: Removed.
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::executeFunctionInContext):
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::call):
        * bindings/objc/ObjCEventListener.mm:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/test/ObjC/DOMTestCallback.mm:
        (-[DOMTestCallback callbackWithClass1Param:]):
        (-[DOMTestCallback callbackWithClass2Param:strArg:]):
        (-[DOMTestCallback callbackWithNonBoolReturnType:]):
        (-[DOMTestCallback customCallback:class6Param:]):
        * bindings/scripts/test/ObjC/DOMTestInterface.mm:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj readOnlyIntAttr]):
        (-[DOMTestObj readOnlyStringAttr]):
        (-[DOMTestObj readOnlyTestObjAttr]):
        (-[DOMTestObj intAttr]):
        (-[DOMTestObj setIntAttr:]):
        (-[DOMTestObj longLongAttr]):
        (-[DOMTestObj setLongLongAttr:]):
        (-[DOMTestObj unsignedLongLongAttr]):
        (-[DOMTestObj setUnsignedLongLongAttr:]):
        (-[DOMTestObj stringAttr]):
        (-[DOMTestObj setStringAttr:]):
        (-[DOMTestObj testObjAttr]):
        (-[DOMTestObj setTestObjAttr:]):
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj setAttrWithSetterException:]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        (-[DOMTestObj customAttr]):
        (-[DOMTestObj setCustomAttr:]):
        (-[DOMTestObj scriptStringAttr]):
        (-[DOMTestObj voidMethod]):
        (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj intMethod]):
        (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj objMethod]):
        (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
        (-[DOMTestObj serializedValue:]):
        (-[DOMTestObj methodWithException]):
        (-[DOMTestObj customMethod]):
        (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj customArgsAndException:]):
        (-[DOMTestObj addEventListener:listener:useCapture:]):
        (-[DOMTestObj removeEventListener:listener:useCapture:]):
        (-[DOMTestObj withDynamicFrame]):
        (-[DOMTestObj withDynamicFrameAndArg:]):
        (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
        (-[DOMTestObj withDynamicFrameAndUserGesture:]):
        (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
        (-[DOMTestObj withScriptStateVoid]):
        (-[DOMTestObj withScriptStateObj]):
        (-[DOMTestObj withScriptStateVoidException]):
        (-[DOMTestObj withScriptStateObjException]):
        (-[DOMTestObj methodWithOptionalArg:]):
        (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
        (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
        * bindings/v8/ScriptController.cpp:
        * bindings/v8/ScriptController.h:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-18  Yaar Schnitman  <yaar@chromium.org>

        Unreviewed, rolling out r59693.
        http://trac.webkit.org/changeset/59693
        https://bugs.webkit.org/show_bug.cgi?id=37815

        Broke GTK Release

        * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
        * http/tests/security/xss-DENIED-iframe-src-alias.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 00:57:56 +0000 (00:57 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement comment states for HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=39334

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 19 May 2010 00:52:11 +0000 (00:52 +0000)]
2010-05-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: implement '--reset-results' flag to complement
        the '--new-baseline' flag. '--new-baseline' will always write the
        results into the platform directory; '--reset-results' will update the
        existing baseline wherever it happens to be. Both sets of behavior
        are useful in different circumstances.

        https://bugs.webkit.org/show_bug.cgi?id=38879

        * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added.
        * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added.
        * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added.
        * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added.
        * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/misc/crash.html: Added.
        * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added.
        * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/misc/passing.html: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added.
        * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added.
        * Scripts/webkitpy/layout_tests/data/text/article-element.html: Added.
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 May 2010 00:42:37 +0000 (00:42 +0000)]
2010-05-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move all member variables from MappedAttribute to Attribute.
        https://bugs.webkit.org/show_bug.cgi?id=39336
        <rdar://problem/8000853>

        This saves one word because we no longer have any virtual member functions in Attribute, and
        thus no vtable pointer.

        I plan to remove MappedAttribute altogether in a subsequent commit.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForElement):
        * dom/Attribute.cpp:
        (WebCore::Attribute::clone):
        * dom/Attribute.h:
        (WebCore::Attribute::create):
        (WebCore::Attribute::style):
        (WebCore::Attribute::decl):
        (WebCore::Attribute::setDecl):
        (WebCore::Attribute::isMappedAttribute):
        (WebCore::Attribute::Attribute):
        * dom/MappedAttribute.cpp: Removed.
        * dom/MappedAttribute.h:
        (WebCore::MappedAttribute::create):
        (WebCore::MappedAttribute::MappedAttribute):
        (WebCore::toMappedAttribute):
        * dom/NamedMappedAttrMap.cpp:
        (WebCore::NamedMappedAttrMap::declCount):
        (WebCore::NamedMappedAttrMap::mapsEquivalent):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::attributeChanged):
        * svg/SVGSVGElement.cpp:
        (WebCore::updateCSSForAttribute):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::getPresentationAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 19 May 2010 00:36:51 +0000 (00:36 +0000)]
2010-05-18  James Robinson  <jamesr@chromium.org>

        Unreviewed.

        Add leopard-specific pixel results for tests that need them
        https://bugs.webkit.org/show_bug.cgi?id=39325

        This adds new Leopard baselines for all tests that currently
        pass with tolerance=0 on Snow Leopard but fail on Leopard
        with an image diff of <= 0.01%.  These tests previously had
        expectations in platform/mac that were Snow Leopard specific.

        * platform/mac-leopard/compositing/color-matching: Added.
        * platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.checksum: Added.
        * platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.png: Added.
        * platform/mac-leopard/compositing/reflections: Added.
        * platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
        * platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
        * platform/mac-leopard/compositing/repaint/overflow-into-content-expected.checksum: Added.
        * platform/mac-leopard/compositing/repaint/overflow-into-content-expected.png: Added.
        * platform/mac-leopard/editing/pasteboard: Added.
        * platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
        * platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
        * platform/mac-leopard/fast/css: Added.
        * platform/mac-leopard/fast/css/pseudo-cache-stale-expected.checksum: Added.
        * platform/mac-leopard/fast/css/pseudo-cache-stale-expected.png: Added.
        * platform/mac-leopard/fast/frames: Added.
        * platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.checksum: Added.
        * platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
        * platform/mac-leopard/fast/repaint: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/mac-leopard/fast/text/format-control-expected.checksum: Added.
        * platform/mac-leopard/fast/text/format-control-expected.png: Added.
        * platform/mac-leopard/plugins: Added.
        * platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Added.
        * platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Added.
        * platform/mac-leopard/transforms/svg-vs-css-expected.checksum: Added.
        * platform/mac-leopard/transforms/svg-vs-css-expected.png: Added.
        * platform/mac-leopard/transitions: Added.
        * platform/mac-leopard/transitions/move-after-transition-expected.checksum: Added.
        * platform/mac-leopard/transitions/move-after-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 19 May 2010 00:36:46 +0000 (00:36 +0000)]
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24943
        Command-B and Command-I do not generate keydown events in contentEditable regions.

        * manual-tests/style-keypress-events.html: Added.
2010-05-18  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24943
        Command-B and Command-I do not generate keydown events in contentEditable regions.

        Manual test because performKeyEquivalent is not called by DRT.

        Test: manual-tests/style-keypress-events.html

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 19 May 2010 00:31:54 +0000 (00:31 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add more state to the HTML5 lexer
        https://bugs.webkit.org/show_bug.cgi?id=39333

        This code is just transliteration from the spec.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::HTML5Lexer):
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 23:55:41 +0000 (23:55 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement two more lexer states
        https://bugs.webkit.org/show_bug.cgi?id=39298

        No tests because Eric is still working on wiring up the lexer to the
        test harness.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::nextToken):
        (WebCore::HTML5Lexer::emitParseError):
        (WebCore::HTML5Lexer::emitCurrentTagToken):
        * html/HTML5Lexer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepro crash with many Google image search results
beidson@apple.com [Tue, 18 May 2010 23:53:31 +0000 (23:53 +0000)]
Repro crash with many Google image search results
<rdar://problem/7685669> and https://bugs.webkit.org/show_bug.cgi?id=39323

Reviewed by Maciej Stachowiak.

WebCore:

When an iframe has a plugin resource as its src, that case bypassed the plugin sandboxing checks and continued to load
the data for the plugin resource. It handed that data off to a nonexistent Widget, causing a null deref and the crash.

By replacing PluginDocuments in sandboxes iframes with a new "SinkDocument" that just acts as a data sink, we prevent the
crash and also prevent actually loading the plugin binaries.

I filed https://bugs.webkit.org/show_bug.cgi?id=39330 to follow up and let us cancel the load as soon as we know we should.

Test: fast/loader/sandboxed-plugin-crash.html

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin): If the created document is a PluginDocument and the plugin sandbox flag is set,
  replace it with a SinkDocument.

* loader/PluginDocument.h:
(WebCore::PluginDocument::isPluginDocument): Make public (it was already public at the Document.h level).

Add a simple document/tokenizer pair that simply presents a blank HTML document and acts as a data sink for whatever
data is handed to it:
* loader/SinkDocument.cpp: Added.
(WebCore::SinkTokenizer::SinkTokenizer):
(WebCore::SinkTokenizer::write):
(WebCore::SinkTokenizer::isWaitingForScripts):
(WebCore::SinkTokenizer::wantsRawData):
(WebCore::SinkTokenizer::writeRawData):
(WebCore::SinkTokenizer::stopParsing):
(WebCore::SinkTokenizer::finish):
(WebCore::SinkDocument::SinkDocument):
(WebCore::SinkDocument::createTokenizer):
* loader/SinkDocument.h: Added.
(WebCore::SinkDocument::create):

LayoutTests:

* fast/loader/resources/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf.
* fast/loader/sandboxed-plugin-crash-expected.txt: Added.
* fast/loader/sandboxed-plugin-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 18 May 2010 22:53:38 +0000 (22:53 +0000)]
2010-05-18  Martin Robinson  <mrobinson@igalia.com>

        No review necessary.

        [GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=39326

        * platform/gtk/Skipped: Skip the crashing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 18 May 2010 22:47:53 +0000 (22:47 +0000)]
2010-05-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Symbian build fix.

        [Qt] Updated the def file with new exports after r59335.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39321
weinig@apple.com [Tue, 18 May 2010 22:38:13 +0000 (22:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39321
Reduce the size of ListHashSets used by Document
<rdar://problem/7999388>

Reviewed by Anders Carlsson.

Reduce Membuster peak memory usage by ~450K by reducing the pool sizes
of the ListHashSets used by Document.

* dom/Document.cpp:
(WebCore::Document::addStyleSheetCandidateNode):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated WebCore/Change to correct the bug link.
jianli@chromium.org [Tue, 18 May 2010 22:29:29 +0000 (22:29 +0000)]
Updated WebCore/Change to correct the bug link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 18 May 2010 22:14:25 +0000 (22:14 +0000)]
2010-05-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] DragClientGtk::startDrag leaks GdkEvents
        https://bugs.webkit.org/show_bug.cgi?id=39322

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReturn null when creating an ImageBuffer failed, due to for
kenneth@webkit.org [Tue, 18 May 2010 21:59:51 +0000 (21:59 +0000)]
Return null when creating an ImageBuffer failed, due to for
instance a nulled pixmap.

Rubberstamped by Simon Hausmann.

* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
jianli@chromium.org [Tue, 18 May 2010 21:55:48 +0000 (21:55 +0000)]
Fix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by Dmitry Titov.

WebCore:

The timeout is caused by 59659 that changed the GC timer to 0 and thus
triggered a bug in FileReader code. The fix is to add more states so
that hasPendingActivity() can do the check correctly.

* html/FileReader.cpp:
(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didRead):
(WebCore::FileReader::didFinish):
(WebCore::FileReader::didFail):
(WebCore::FileReader::readyState):
(WebCore::FileReader::result):
* html/FileReader.h:
(WebCore::FileReader::):

LayoutTests:

Re-enale the file reader test.

* fast/files/file-reader-expected.txt:
* fast/files/file-reader.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 18 May 2010 21:37:26 +0000 (21:37 +0000)]
2010-05-18  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Clean up GraphicsLayer naming code
        https://bugs.webkit.org/show_bug.cgi?id=39316

        Move code that generates a name for the GraphicsLayer (used in debug builds only) into
        a new nameForLayer() method. Use it when naming the foreground layer.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer):
        (WebCore::RenderLayerBacking::updateForegroundLayer):
        (WebCore::RenderLayerBacking::nameForLayer):
        * rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Justin Schuh <jschuh@chromium.org>
yaar@chromium.org [Tue, 18 May 2010 21:15:52 +0000 (21:15 +0000)]
2010-05-18  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Moving frame.src checks out of the bindings
        https://bugs.webkit.org/show_bug.cgi?id=37815

        Moved JavaScript frame.src checks out of bindings and into
        HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
        so ExecState is available inside core DOM. Updated affected bindings
        (except for GObject, which will need to be updated to avoid origin
        failures inside native code).

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSCallbackData.cpp:
        (WebCore::JSCallbackData::invokeCallback):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::createInjectedScript):
        * bindings/js/JSMainThreadExecState.cpp: Added.
        * bindings/js/JSMainThreadExecState.h: Added.
        (WebCore::JSMainThreadExecState::currentState):
        (WebCore::JSMainThreadExecState::call):
        (WebCore::JSMainThreadExecState::evaluate):
        (WebCore::JSMainThreadExecState::JSMainThreadExecState):
        (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
        (WebCore::JSMainThreadNullState::JSMainThreadNullState):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::executeFunctionInContext):
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::canAccessFromCurrentOrigin):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::call):
        * bindings/objc/ObjCEventListener.mm:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/test/ObjC/DOMTestCallback.mm:
        (-[DOMTestCallback callbackWithClass1Param:]):
        (-[DOMTestCallback callbackWithClass2Param:strArg:]):
        (-[DOMTestCallback callbackWithNonBoolReturnType:]):
        (-[DOMTestCallback customCallback:class6Param:]):
        * bindings/scripts/test/ObjC/DOMTestInterface.mm:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj readOnlyIntAttr]):
        (-[DOMTestObj readOnlyStringAttr]):
        (-[DOMTestObj readOnlyTestObjAttr]):
        (-[DOMTestObj intAttr]):
        (-[DOMTestObj setIntAttr:]):
        (-[DOMTestObj longLongAttr]):
        (-[DOMTestObj setLongLongAttr:]):
        (-[DOMTestObj unsignedLongLongAttr]):
        (-[DOMTestObj setUnsignedLongLongAttr:]):
        (-[DOMTestObj stringAttr]):
        (-[DOMTestObj setStringAttr:]):
        (-[DOMTestObj testObjAttr]):
        (-[DOMTestObj setTestObjAttr:]):
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj setAttrWithSetterException:]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        (-[DOMTestObj customAttr]):
        (-[DOMTestObj setCustomAttr:]):
        (-[DOMTestObj scriptStringAttr]):
        (-[DOMTestObj voidMethod]):
        (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj intMethod]):
        (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj objMethod]):
        (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
        (-[DOMTestObj serializedValue:]):
        (-[DOMTestObj methodWithException]):
        (-[DOMTestObj customMethod]):
        (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj customArgsAndException:]):
        (-[DOMTestObj addEventListener:listener:useCapture:]):
        (-[DOMTestObj removeEventListener:listener:useCapture:]):
        (-[DOMTestObj withDynamicFrame]):
        (-[DOMTestObj withDynamicFrameAndArg:]):
        (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
        (-[DOMTestObj withDynamicFrameAndUserGesture:]):
        (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
        (-[DOMTestObj withScriptStateVoid]):
        (-[DOMTestObj withScriptStateObj]):
        (-[DOMTestObj withScriptStateVoidException]):
        (-[DOMTestObj withScriptStateObjException]):
        (-[DOMTestObj methodWithOptionalArg:]):
        (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
        (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::canAccessFromCurrentOrigin):
        * bindings/v8/ScriptController.h:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-18  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Moving frame.src checks out of the bindings
        https://bugs.webkit.org/show_bug.cgi?id=37815

        * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
        * http/tests/security/xss-DENIED-iframe-src-alias.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed: Speculative build fix for Chromium win.
atwilson@chromium.org [Tue, 18 May 2010 20:52:00 +0000 (20:52 +0000)]
Unreviewed: Speculative build fix for Chromium win.

* platform/graphics/skia/SkiaFontWin.cpp: Properly set inlineCapacity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix for Chromium build break.
atwilson@chromium.org [Tue, 18 May 2010 20:39:08 +0000 (20:39 +0000)]
Unreviewed fix for Chromium build break.

* platform/graphics/skia/SkiaFontWin.cpp: Now set inlineCapacity param.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDragData::asURL() shouldn't do file validity checks
dimich@chromium.org [Tue, 18 May 2010 20:22:49 +0000 (20:22 +0000)]
DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Patch by Daniel Cheng <dcheng@chromium.org> on 2010-05-18
Reviewed by Darin Adler, Jian Li.

WebCore:

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O.  Consumers of this function either:
- need to verify the file exists themselves (e.g. the loader)
- don't care about file validity (rich text drag-and-drop)

* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):

WebKit/mac:

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

* Misc/WebNSPasteboardExtras.mm:
(-[NSPasteboard _web_bestURL]):

LayoutTests:

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

* editing/pasteboard/file-input-files-access-expected.txt:
* editing/pasteboard/script-tests/file-input-files-access.js:
(runTest.window.onbeforeunload):
(runTest):
* http/tests/security/clipboard/script-tests/clipboard-file-access.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a handful of various localization issues in the Web Inspector.
timothy@apple.com [Tue, 18 May 2010 20:21:54 +0000 (20:21 +0000)]
Fix a handful of various localization issues in the Web Inspector.

* Localize strings that where not localized.
* Make WebInspector.UIString work without bind.
* Always pass WebInspector.UIString to Number.secondsToString and Number.bytesToString.
* Never pass a variable to WebInspector.UIString, since that prevents auto-generation.
* Use an ellipsis instead of three periods.

https://webkit.org/b/39303
rdar://problem/7997101

Reviewed by Adam Roben.

* English.lproj/localizedStrings.js:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype.contentTabSelected):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferDurationCalculator.prototype.formatValue):
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._registerShortcuts):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._contextMenu):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):
* inspector/front-end/inspector.js:
(WebInspector.loaded):
(WebInspector.setRecordingProfile):
(WebInspector.UIString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 20:16:25 +0000 (20:16 +0000)]
2010-05-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer
        https://bugs.webkit.org/show_bug.cgi?id=39311

        This flag allows us to run the new HTML5Lexer code.
        Right now all documents parse as empty documents, but
        now that we're able to run the code we can fix that.

        Once we're able to lex a few basic documents I'll add
        an --html5-parser flag to run-webkit-tests so that we test
        running all of the layout tests with the HTML5 parser.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        (initializeGlobalsFromCommandLineOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother attempt to fix the build.
weinig@apple.com [Tue, 18 May 2010 20:13:13 +0000 (20:13 +0000)]
Another attempt to fix the build.

* css/CSSCursorImageValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the windows build.
weinig@apple.com [Tue, 18 May 2010 19:45:52 +0000 (19:45 +0000)]
Try to fix the windows build.

* API/JSStringRefBSTR.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake accelerated compositing work on machines that don't support hardware vertex...
aroben@apple.com [Tue, 18 May 2010 19:33:29 +0000 (19:33 +0000)]
Make accelerated compositing work on machines that don't support hardware vertex processing

Fixes <http://webkit.org/b/39299> <rdar://problem/7997692> Accelerated
compositing on Windows doesn't work on machines that don't support
hardware vertex processing, but should

Reviewed by Eric Carlson.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::createRenderer): Query the device
capabilities to decide whether to request hardware or software vertex
processing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WKCACFLayerRenderer robust against temporary failure of Direct3DCreate9 and...
aroben@apple.com [Tue, 18 May 2010 19:33:10 +0000 (19:33 +0000)]
Make WKCACFLayerRenderer robust against temporary failure of Direct3DCreate9 and IDirect3D9::CreateDevice

For a short time after waking from sleep, Direct3DCreate9() will
return an IDirect3D9 for which IDirect3D9::CreateDevice will always
fail. Also during this time period, IDirect3D9::CreateDevice
will fail even for non-bad IDirect3D9s. (It will later start
succeeding.) WKCACFLayerRenderer now works around this behavior by
detecting when it might be in this situation and calling these
functions again later.

Fixes <http://webkit.org/b/39297> <rdar://problem/7997431> WebView
doesn't repaint until page reloads when page using hardware
acceleration loads just after waking from sleep

Reviewed by John Sullivan.

* manual-tests/crash-and-no-repaint-after-wake-from-sleep.html:
Renamed from WebCore/manual-tests/crash-after-wake-from-sleep.html.
Modified to also include instructions for reproducing this bug.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater. The
new member is initialized to true, since we haven't even tried to
create a device once yet.
(WebCore::WKCACFLayerRenderer::createRenderer): If we already have a
D3D device, or we don't have one and are sure that we won't be able to
create one later, just return the previously-created device, if any.
We assume that we won't be able to create a device later if this
function fails, unless the function fails due to CreateDevice failing.
As noted above, CreateDevice will sometimes temporarily fail and then
later start working again. When CreateDevice fails, we also assume
that we might have a bad IDirect3D9, so we get rid of the one we have
so a new (and hopefully non-bad) one will be allocated later.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Reset
m_mightBeAbleToCreateDeviceLater to true, since we no longer have a
device.
(WebCore::WKCACFLayerRenderer::paint): Before trying to paint, try to
create our D3D device and renderer. If this fails, we bail out, but if
we think we might be able to create a device later we schedule another
paint (via renderSoon()) so that we'll try again soon.

* platform/graphics/win/WKCACFLayerRenderer.h: Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a crash when a page that uses accelerated compositing loads soon after the comput...
aroben@apple.com [Tue, 18 May 2010 19:32:46 +0000 (19:32 +0000)]
Fix a crash when a page that uses accelerated compositing loads soon after the computer wakes from sleep

The set-up:

For a short time after waking from sleep, IDirect3D9::CreateDevice
will fail. This caused WKCACFLayerRenderer::createRenderer to fail,
and meant that WKCACFLayerRenderer never allocated a root layer.
WebView wouldn't notice that createRenderer failed, and would go ahead
and try to use the root layer anyway, resulting in a crash.

The fix:

We now allocate the root layer (and all the other members of
WKCACFLayerRenderer that aren't dependent on having an
IDirect3DDevice9) in WKCACFLayerRenderer's constructor. This way the
layers will always be present, even when creating the D3D device
fails.

There are two remaining problems:
  1) This results in slightly more memory usage in the case where
     CreateDevice fails.
  2) Once we get into this bad state, the WebView doesn't repaint
     until we navigate somewhere else.

(2) is covered by
<http://webkit.org/b/39297>/<rdar://problem/7997431>. We'll fix it by
retrying CreateDevice later in hopes that it will succeed after more
time has passed. This will in turn fix (1). (We should never end up in
a case where CreateDevice fails forever because we already did some
preliminary checks in acceleratedCompositingAvailable().)

Fixes <http://webkit.org/b/39295> <rdar://problem/7971319> Crash
(preceded by assertion) in WKCACFLayerRenderer::setNeedsDisplay when
computer wakes from sleep on particular page

Reviewed by John Sullivan.

* manual-tests/crash-after-wake-from-sleep.html: Added. This
is the Poster Circle demo from webkit.org/blog, but modified to
automatically reload every 5 seconds and with instructions to put the
computer to sleep and wake it up again.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Moved code to
initialize m_context, m_renderContext, and m_*Layer here...
(WebCore::WKCACFLayerRenderer::createRenderer): ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove an unused member variable from WKCACFLayerRenderer
aroben@apple.com [Tue, 18 May 2010 19:32:24 +0000 (19:32 +0000)]
Remove an unused member variable from WKCACFLayerRenderer

Rubber-stamped by Ada Chan.

* platform/graphics/win/WKCACFLayerRenderer.h: Removed m_viewLayer,
which is unused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 May 2010 19:25:01 +0000 (19:25 +0000)]
2010-05-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Allocate the m_preloads list hash set dynamically and free it when done.
        https://bugs.webkit.org/show_bug.cgi?id=39309
        <rdar://problem/7998495>

        This saves about 6000 bytes on a fully loaded document.

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestPreload):
        (WebCore::DocLoader::clearPreloads):
        * loader/DocLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert unintended indentation and unnecessary nested name specifier.
andersca@apple.com [Tue, 18 May 2010 19:16:22 +0000 (19:16 +0000)]
Revert unintended indentation and unnecessary nested name specifier.

* rendering/RenderBlock.cpp:
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 May 2010 18:58:25 +0000 (18:58 +0000)]
2010-05-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
        https://bugs.webkit.org/show_bug.cgi?id=39304
        <rdar://problem/7998366>

        Add an inlineCapacity template parameter to ListHashSet.

        * wtf/ListHashSet.h:
        (WTF::::ListHashSet):
        (WTF::::operator):
        (WTF::::swap):
        (WTF::::~ListHashSet):
        (WTF::::size):
        (WTF::::capacity):
        (WTF::::isEmpty):
        (WTF::::begin):
        (WTF::::end):
        (WTF::::find):
        (WTF::::contains):
        (WTF::::add):
        (WTF::::insertBefore):
        (WTF::::remove):
        (WTF::::clear):
        (WTF::::unlinkAndDelete):
        (WTF::::appendNode):
        (WTF::::insertNodeBefore):
        (WTF::::deleteAllNodes):
        (WTF::::makeIterator):
        (WTF::::makeConstIterator):
        (WTF::deleteAllValues):
2010-05-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
        https://bugs.webkit.org/show_bug.cgi?id=39304
        <rdar://problem/7998366>

        Set the inlineCapacity for the positionedObjects ListHashSet to 4 instead of 256. Since a RenderBlock usually has
        few positioned objects, this saves memory.

        * WebCore.base.exp:
        * rendering/RenderBlock.cpp:
        (WebCore::clipOutPositionedObjects):
        (WebCore::RenderBlock::insertPositionedObject):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::positionedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39258
weinig@apple.com [Tue, 18 May 2010 18:43:24 +0000 (18:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39258
Remove NamedAttrMap residual gunk

Reviewed by Darin Adler.

Replace NamedAttrMap.h/cpp with NamedNodeMap.h/cpp which was the class
it contained.

* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/custom/V8NamedNodesCollection.cpp:
* dom/NamedAttrMap.cpp: Removed.
* dom/NamedAttrMap.h: Removed.
* dom/NamedNodeMap.cpp: Copied from dom/NamedAttrMap.cpp.
* dom/NamedNodeMap.h: Replaced with dom/NamedAttrMap.h.
* editing/ReplaceNodeWithSpanCommand.cpp:
* platform/chromium/ClipboardChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the interpreter after r59637
loki@webkit.org [Tue, 18 May 2010 18:32:30 +0000 (18:32 +0000)]
Fix the interpreter after r59637
https://bugs.webkit.org/show_bug.cgi?id=39287

Reviewed by Darin Adler.

* runtime/Executable.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fix. Disable file-reader.html for more investigation.
jianli@chromium.org [Tue, 18 May 2010 18:28:50 +0000 (18:28 +0000)]
Unreviewed. Build fix. Disable file-reader.html for more investigation.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of...
beidson@apple.com [Tue, 18 May 2010 18:28:25 +0000 (18:28 +0000)]
<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of play button at NPR.org

Reviewed by Eric Carlson.

NPR swallows the first mouse click on the play button, calls load() on the element, then waits for the
canplay event to come in before calling play itself.

After the site specific hack added in r58586, we disallowed play() from within the canplay event handler.
By tracking whether a load() was triggered by a user gesture, we can differentiate between the original
canplay event that we meant to ignore and the one resulting from the first mouse click which we want to honor.

No new tests. (Currently no way to test such site specific hack behavior)

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load): Set the m_loadInitiatedByUserGesture flag
(WebCore::HTMLMediaElement::play): Only apply the site specific hack if the load wasn't initiated by a user gesture.
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Jakob Petsovits <jpetsovits@rim.com>
jpetsovits@rim.com [Tue, 18 May 2010 18:09:02 +0000 (18:09 +0000)]
2010-05-18  Jakob Petsovits  <jpetsovits@rim.com>

        Reviewed by Dirk Schulze.

        [OpenVG] Fix stupid build errors from the OpenVG Path commit
        https://bugs.webkit.org/show_bug.cgi?id=39228

        * platform/graphics/openvg/PainterOpenVG.cpp:
        (WebCore::PainterOpenVG::clipPath):
        * platform/graphics/openvg/PathOpenVG.cpp:
        (WebCore::Path::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Build fix. Disable test cases in file-reader.html that
jianli@chromium.org [Tue, 18 May 2010 17:30:09 +0000 (17:30 +0000)]
Unreviewed. Build fix. Disable test cases in file-reader.html that
cause time-out in mac bot for further investigation.

* fast/files/file-reader-expected.txt:
* fast/files/file-reader.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRietveld review page should dedicate more space to Rietveld, less to high level comme...
jparent@chromium.org [Tue, 18 May 2010 17:27:14 +0000 (17:27 +0000)]
Rietveld review page should dedicate more space to Rietveld, less to high level comments form.

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=39244

* template/en/custom/attachment/reviewform.html.tmpl:
Delete a random BR amongst the hidden elements that was causing extra whitespace.
* template/en/custom/attachment/rietveldreview.html.tmpl:
Increase size of Rietveld frame to 80%, from 60%.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Tue, 18 May 2010 16:18:31 +0000 (16:18 +0000)]
2010-05-18  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Darin Adler.

        Refactored FrameLoader::isDocumentSandboxed() from a private member function
        to a static, non-member, non-friend function.

        https://bugs.webkit.org/show_bug.cgi?id=39157

        Making this function non-private lets us make FrameLoader::createWindow()
        a non-member function in a subsequent patch.  We also made it non-member
        rather than member to increase encapsulation and limit the number of
        public functions with access to private FrameLoader data.

        No new functionality, so no new tests.

        * loader/FrameLoader.cpp:
        (WebCore::isDocumentSandboxed):
          - Moved this function from a private member function of FrameLoader
            to a static, non-member, non-friend function.
        (WebCore::FrameLoader::createWindow):
          - Updated the call to isDocumentSandboxed().
        (WebCore::FrameLoader::submitForm):
          - Updated the call to isDocumentSandboxed().
        (WebCore::FrameLoader::requestObject):
          - Updated the call to isDocumentSandboxed().
        (WebCore::FrameLoader::shouldAllowNavigation):
          - Updated the call to isDocumentSandboxed().
        * loader/FrameLoader.h:
          - Removed isDocumentSandboxed() and added a FIXME to move
            createWindow() out of the FrameLoader class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
hausmann@webkit.org [Tue, 18 May 2010 14:07:00 +0000 (14:07 +0000)]
[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

2010-05-08  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Simon Hausmann.

        [Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html
             and http/tests/xmlhttprequest/cross-origin-authorization.html

        QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
        without knowing if this is valid behaviour or not. In order to allow
        Qt to decide whether Cookie/Authorization headers should be added
        to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
        These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
        QNetworkRequest::CookieSaveControlAttribute,and
        QNetworkRequest::AuthenticationReuseControlAttribute.

        QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
        unless withCredentials is set to true in the XHR.

        QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
        is set to true in the XHR.

        Qt will pass the values onto QHttpNetworkRequest and this will permit
        the Qt network access processing to decide whether or not to add either
        or both of the Cookie/Authorisation headers, and whether to save cookies
        returned from such requests. By default the attribute
        will always be true so unless QtWebKit sets it to false normal
        header processing is unaffected.

        There are platform-specific results for cross-origin-no-authorization.html:

        1. Qt's DRT does not capture the final 'DONE'.
        2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests
           do not execute didFail() when they receive a 401 HTTP response. This
           results in async tests passing with '401 Authorisation required' rather
           than 'received error event'.

        The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592

        In order to properly support the tests, Qt's DRT needs to use one
        NetworkAccessManager for all pages. This allows it to use cached
        credentials where appropriate.

        The tests now pass when run individually but there seems to be a problem with
        leaking the results of requests across tests when run with the others in
        http/tests. This will be addressed in a separate patch.

        https://bugs.webkit.org/show_bug.cgi?id=32967

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::DumpRenderTree::DumpRenderTree):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * platform/network/qt/ResourceRequestQt.cpp:
        (WebCore::ResourceRequest::toNetworkRequest):
        * platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
        * platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Implementing clipToImageBuffer for Qt port.
zherczeg@webkit.org [Tue, 18 May 2010 13:25:04 +0000 (13:25 +0000)]
[Qt] Implementing clipToImageBuffer for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=24289

Reviewed by Kenneth Rohde Christiansen.

The implementation combines pixmap layers and destinationIn
composition mode.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::TransparencyLayer::TransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clipToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 11:04:15 +0000 (11:04 +0000)]
2010-05-18  Eric Seidel  <eric@webkit.org>

        Unreviewed build fix.

        Make it possible to enable the new HTML5Tokenizer for testing
        https://bugs.webkit.org/show_bug.cgi?id=39275

        * WebCore.gypi:
         - Fix HTMLLexer.* -> HTML5Lexer.*
        * WebCore.vcproj/WebCore.vcproj:
         - Add HTML5Lexer and HTML5Tokenizer to project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 18 May 2010 10:40:50 +0000 (10:40 +0000)]
2010-05-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        run_webkit_tests_unittest fails on SnowLeopard
        https://bugs.webkit.org/show_bug.cgi?id=39279

        * Scripts/webkitpy/layout_tests/port/base.py:
         Return copy of os.environ.
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
         Check os.environ was not modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 10:38:47 +0000 (10:38 +0000)]
2010-05-18  Eric Seidel  <eric@webkit.org>

        Unreviewed build fix.

        Make it possible to enable the new HTML5Tokenizer for testing
        https://bugs.webkit.org/show_bug.cgi?id=39275

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedNodeMap::setNamedItemNS):
         - Move this to the .cpp file so as to avoid needing to include "Node.h" in the header.
        * dom/NamedAttrMap.h:
        * html/HTML5Token.h:
         - Remove #include "String.h" which was wrong.  Adam meant "PlatformString.h"
         - Remove unneeded #include "Node.h", it was only needed because
           NamedAttrMap.h was incorrectly depending on Node.h but not
           including it.  It didn't actually need Node.h except for one
           inlined method setNamedItemNS, so I moved setNamedItemNS into
           the .cpp to get rid of the Node.h requirement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 10:17:01 +0000 (10:17 +0000)]
2010-05-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to enable the new HTML5Tokenizer for testing
        https://bugs.webkit.org/show_bug.cgi?id=39275

        I added html5ParserEnabled to Settings so that we can enable/disable
        the HTML5 parser for testing.

        I also ripped out a bunch of dead code from HTML5Lexer.

        I had to add HTML5Lexer/HTML5Tokenizer to all build systems so that
        the build wouldn't fail now that we reference these classes from HTMLDocument.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::reset):
        (WebCore::isWhitespace):
        (WebCore::HTML5Lexer::nextToken):
        * html/HTML5Lexer.h:
        * html/HTML5Tokenizer.cpp: Added.
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::~HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::begin):
        (WebCore::HTML5Tokenizer::write):
        (WebCore::HTML5Tokenizer::end):
        (WebCore::HTML5Tokenizer::finish):
        (WebCore::HTML5Tokenizer::isWaitingForScripts):
        * html/HTML5Tokenizer.h: Added.
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * html/HTMLTokenizer.h:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setHTML5ParserEnabled):
        (WebCore::Settings::html5ParserEnabled):
2010-05-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth (and Maciej Stachowiak).

        Make it possible to enable the new HTML5Tokenizer for testing
        https://bugs.webkit.org/show_bug.cgi?id=39275

        Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (-[WebPreferences html5ParserEnabled]):
        (-[WebPreferences setHTML5ParserEnabled:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Maciej Stachowiak <mjs@apple.com>
abarth@webkit.org [Tue, 18 May 2010 09:08:13 +0000 (09:08 +0000)]
2010-05-18  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed, build fix.

        Attempt to fix build for v8 bindings (untested).

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell):
        * bindings/v8/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNot reviewed, build fix.
mjs@apple.com [Tue, 18 May 2010 09:04:24 +0000 (09:04 +0000)]
Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::clearWindowShell):
* bindings/v8/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Tue, 18 May 2010 08:52:19 +0000 (08:52 +0000)]
2010-05-18  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        Chromium: new-run-webkit-httpd fails to setup_mount
        https://bugs.webkit.org/show_bug.cgi?id=39257

        * Scripts/webkitpy/common/system/executive.py:
         Assert type of args in run_command.
        * Scripts/webkitpy/common/system/executive_unittest.py:
         Add test_run_command_args_type
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
         Executive.run_command takes array for command line.
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
         Test if setup_environ_for_server() run setup_mount.bat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix QWebHistory serialization.
hausmann@webkit.org [Tue, 18 May 2010 08:42:28 +0000 (08:42 +0000)]
Fix QWebHistory serialization.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-05-18
Reviewed by Simon Hausmann.

Regression was caused by bug 33224. The streaming function
should generate a documentSequenceNumber for all loaded values.

[Qt] tst_QWebHistory::serialize_2() fails
https://bugs.webkit.org/show_bug.cgi?id=37322

* Api/qwebhistory.cpp:
(operator>>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 18 May 2010 08:09:57 +0000 (08:09 +0000)]
2010-05-17  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
        https://bugs.webkit.org/show_bug.cgi?id=39254
        <rdar://problem/7996370>

        ~1% PLT speedup
        ~4% iBench HTML speedup

        * bindings/js/GCController.cpp:
        (WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of
        0.5 second.
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't
        garbageColectSoon if the page is going into the page cache.
        * bindings/js/ScriptController.h: Prototype change for above.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 07:24:09 +0000 (07:24 +0000)]
2010-05-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement ScriptData states for HTML5Lexer
        https://bugs.webkit.org/show_bug.cgi?id=39273

        This patch implements more of the lexer states according to the HTML5
        specification.  Currently, this code is compiled by not tested.  We're
        working on bringing up a test harness in parallel with transliterating
        the spec into code.

        * html/HTML5Lexer.cpp:
        (WebCore::HTML5Lexer::tokenize):
        (WebCore::HTML5Lexer::temporaryBufferIs):
        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 May 2010 07:00:02 +0000 (07:00 +0000)]
2010-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39272

        Strictly a rename, no functionality change.

        * WebCore.xcodeproj/project.pbxproj:
        * html/HTML5Lexer.cpp: Added.
        * html/HTML5Lexer.h: Added.
        * html/HTML5Tokenizer.cpp: Removed.
        * html/HTML5Tokenizer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test expectations update for chromium.
atwilson@chromium.org [Tue, 18 May 2010 06:01:13 +0000 (06:01 +0000)]
Unreviewed test expectations update for chromium.

* platform/chromium-mac/html5lib/runner-expected.txt: Added.
* platform/chromium-win/html5lib/runner-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
tkent@chromium.org [Tue, 18 May 2010 05:56:38 +0000 (05:56 +0000)]
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/script-tests/file-input-files-access.js:
        (runTest):
        * http/tests/security/clipboard/script-tests/clipboard-file-access.js:
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59652.
        http://trac.webkit.org/changeset/59652
        https://bugs.webkit.org/show_bug.cgi?id=39268

        file-input-files-access test is broken on Mac (Requested by
        dcheng on #webkit).

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_bestURL]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 05:51:01 +0000 (05:51 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement RAWTEXT tokenizer states
        https://bugs.webkit.org/show_bug.cgi?id=39267

        More tokenizer states.  There's a bunch of functionality notImplemented
        that we'll come back to.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::tokenize):
        * html/HTML5Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 05:17:34 +0000 (05:17 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement more parser states in HTML5Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39265

        This patch implements some easy states.  I'll come back and do the
        harder states later.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::tokenize):
        (WebCore::HTML5Tokenizer::emitParseError):
        * html/HTML5Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Daniel Cheng <dcheng@chromium.org>
tkent@chromium.org [Tue, 18 May 2010 05:11:49 +0000 (05:11 +0000)]
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        Several layout tests depended on the fact that dropping a file would
        never trigger navigation. This never happened to occur in the past,
        since it just so happened that the filenames used in the tests never
        resolved to files that exist. Since DragData::asURL() no longer tries
        to verify file existence, the layout tests were updated to either
        suppress navigation or log any navigation that should occur as part of
        the test.

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/script-tests/file-input-files-access.js:
        (runTest.window.onbeforeunload):
        (runTest):
        * http/tests/security/clipboard/script-tests/clipboard-file-access.js:
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Darin Adler.

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        There's no point to trying to make sure the file is valid in
        DragData::asURL(). It's better to ask for forgiveness than to ask for
        permission, since asking for permission is prone to race conditions
        and results in unnecessary I/O.  Consumers of this function either:
        - need to verify the file exists themselves (e.g. the loader)
        - don't care about file validity (rich text drag-and-drop)

        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
2010-05-17  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Darin Adler.

        DragData::asURL() shouldn't do file validity checks
        https://bugs.webkit.org/show_bug.cgi?id=38711

        Change [NSPasteboard _web_bestURL] to still return a file URL for paths
        that don't exist. Callers who care about the existence of the file or
        whether or not it is a directory should check themselves when they
        want to use the file. The directory check has been left in for now,
        since the Mac implementation of ResourceHandle, which uses this function
        indirectly via DragController::performDrag) handles directories somewhat
        non-intuitively: it opens the parent directory in the Finder, rather
        than opening the directory itself.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_bestURL]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Roll out r59650.
tkent@chromium.org [Tue, 18 May 2010 05:05:31 +0000 (05:05 +0000)]
Unreviewed. Roll out r59650.
A workaround of a buildbot issue triggered by r59650 wasn't resolved by r59646.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[DRT/Chromium] Fix repaint, WebGL, textarea tests
tkent@chromium.org [Tue, 18 May 2010 04:56:18 +0000 (04:56 +0000)]
[DRT/Chromium] Fix repaint, WebGL, textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

* DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
  and textAreaResizeCorner.png
* WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
* features.gypi: Enable ENABLE_3D_CANVAS.

WebKitTools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::canvas): Remove m_paintRect initialization in canvas().
 This line updated m_paintRect unexpectedly during paintRect().
 We don't need to initialize m_paintRect because show() does it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-16 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 18 May 2010 04:46:22 +0000 (04:46 +0000)]
2010-05-16  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Add tests for Bug 31267 - :nth-child(-2n) should match no element.
        http://trac.webkit.org/changeset/58300 has fixed this already.
        https://bugs.webkit.org/show_bug.cgi?id=31267

        * fast/css/nth-child-negative-a-param-expected.txt: Added.
        * fast/css/nth-child-negative-a-param.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 04:27:33 +0000 (04:27 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update states in HTML5Tokenizer to match HTML5 spec
        https://bugs.webkit.org/show_bug.cgi?id=39264

        I've also implemented the DataState.  More states to follow.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::reset):
        (WebCore::HTML5Tokenizer::tokenize):
        * html/HTML5Tokenizer.h:
        (WebCore::HTML5Tokenizer::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
tkent@chromium.org [Tue, 18 May 2010 04:24:57 +0000 (04:24 +0000)]
Unreviewed.

Update a test for the behavior change of r59645.
https://bugs.webkit.org/show_bug.cgi?id=39162

* fast/forms/script-tests/willvalidate.js:
* fast/forms/willvalidate-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium Windows build system does not rebuild correctly when
tkent@chromium.org [Tue, 18 May 2010 04:04:50 +0000 (04:04 +0000)]
Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

* Scripts/update-webkit:
  Chromium-Windows only: If WebKit/chromium/features.gyp has been
  updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago':valid' CSS selector should not be applied to some form controls
tkent@chromium.org [Tue, 18 May 2010 03:57:06 +0000 (03:57 +0000)]
':valid' CSS selector should not be applied to some form controls
https://bugs.webkit.org/show_bug.cgi?id=39162

Reviewed by Darin Adler.

WebCore:

* html/HTMLElement.cpp:
(WebCore::inlineTagList): Always includes progressTag. This change is
needed in a case of no ENABLE_PROGRESS_TAG. Without this change and
ENABLE_PROGRESS_TAG, <progress> tags disappear.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::recalcWillValidate):
  Return false for SUBMIT and IMAGE.
* html/HTMLProgressElement.h:
(WebCore::HTMLProgressElement::recalcWillValidate):
  Return false. This change is needed in a case of ENABLE_PROGRESS_TAG.

LayoutTests:

Add test cases for
 - <input type=submit>
 - <input type=image>
 - <progress>
 - <meter>

* fast/css/pseudo-valid-unapplied-expected.txt:
* fast/css/pseudo-valid-unapplied.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 03:41:34 +0000 (03:41 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove load-related code from HTML5Tokenizer
        https://bugs.webkit.org/show_bug.cgi?id=39263

        This code is related to reloading resources and not to tokenizing.  In
        the PreloadScanner, these concerns are coupled, but we want to decouple
        them.

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::~HTML5Tokenizer):
        (WebCore::HTML5Tokenizer::begin):
        (WebCore::HTML5Tokenizer::end):
        (WebCore::HTML5Tokenizer::reset):
        (WebCore::HTML5Tokenizer::write):
        (WebCore::HTML5Tokenizer::consumeEntity):
        (WebCore::HTML5Tokenizer::tokenize):
        (WebCore::HTML5Tokenizer::processAttribute):
        (WebCore::HTML5Tokenizer::emitCharacter):
        (WebCore::HTML5Tokenizer::emitTag):
        * html/HTML5Tokenizer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 18 May 2010 03:25:26 +0000 (03:25 +0000)]
2010-05-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add HTML5Tokenizer to the build system on Mac
        https://bugs.webkit.org/show_bug.cgi?id=39262

        This file will be easier to work with if we're actually compiling it.
        Hopefully we'll get this wired into the PreloadScanner soon.  Once we
        start actually calling the code, we'll add it to the build system on
        other platforms.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOops, meant ebx not eax there. Fix Qt (and probably Win too).
barraclough@apple.com [Tue, 18 May 2010 03:24:05 +0000 (03:24 +0000)]
Oops, meant ebx not eax there.  Fix Qt (and probably Win too).

Reviewed by Geoff Garen.

* jit/JITOpcodes32_64.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59642 268f45cc-cd09-0410-ab3c-d52691b4dbfc