WebKit-https.git
10 years ago2010-03-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 25 Mar 2010 16:31:54 +0000 (16:31 +0000)]
2010-03-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        New Asking Questions Page is not Valid HTML5
        https://bugs.webkit.org/show_bug.cgi?id=36605

        * asking_questions.html: fixed issues raised by the validator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length...
jchaffraix@webkit.org [Thu, 25 Mar 2010 16:18:19 +0000 (16:18 +0000)]
[Qt][GTK] http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html
fails after r56394
https://bugs.webkit.org/show_bug.cgi?id=36531

Reviewed by Alexey Proskuryakov.

The test was assuming that we would receive 3 progress events which may not be the case anymore
due to the event throttling added in r56394.

* http/tests/xmlhttprequest/xmlhttprequest-onProgress-open-should-zero-length.html: Removed
the counting as it belonged to the original version of the test and instead use the position
to determine when to reset the XHR.

* platform/gtk/Skipped:
* platform/qt/Skipped:
Removed the test from the Skipped lists now that it should pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 25 Mar 2010 16:09:19 +0000 (16:09 +0000)]
2010-03-25  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: reloading debug target window with cmd-R from inspector window produces beep.
        https://bugs.webkit.org/show_bug.cgi?id=36554

        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown): prevent the default behavior, if handled, which would result in a system beep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 15:25:40 +0000 (15:25 +0000)]
2010-03-25  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        Forward DatabaseTracker::canEstablishDatabase to chromium layer.
        https://bugs.webkit.org/show_bug.cgi?id=36595

        * storage/chromium/DatabaseObserver.h:
        * storage/chromium/DatabaseTrackerChromium.cpp:
        (WebCore::DatabaseTracker::canEstablishDatabase):
2010-03-25  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Jeremy Orlow.

        Forward DatabaseTracker::canEstablishDatabase to chromium layer.
        https://bugs.webkit.org/show_bug.cgi?id=36595

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::allowDatabase):
        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):
        * src/WebWorkerBase.h:
        (WebKit::WebWorkerBase::allowDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded missing frame flattening activation on fast/frames/flattening/frameset-flatteni...
tonikitoo@webkit.org [Thu, 25 Mar 2010 15:24:28 +0000 (15:24 +0000)]
Added missing frame flattening activation on fast/frames/flattening/frameset-flattening-grid.html; removed unnecessary CONSOLE MESSAGE from the expected file; reset the setFrameSetFlatteningEnabled for each test.

Reviewed by Kenneth Christiansen.
Patch by Diego Gonzalez <diego.gonzalez@openbossa.org>

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):

LayoutTests:

* fast/frames/flattening/frameset-flattening-grid.html:
* platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 yael aharon <yael.aharon@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 15:06:10 +0000 (15:06 +0000)]
2010-03-25  yael aharon  <yael.aharon@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Windowed netscape plugins don't work with QGraphicsWebView on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=35112

        Add a proxy widget when loading a QWidget based plugin in a QGraphicsWebView.

        * plugins/symbian/PluginContainerSymbian.cpp:
        (PluginContainerSymbian::PluginContainerSymbian):
        (PluginContainerSymbian::focusInEvent):
        * plugins/symbian/PluginContainerSymbian.h:
        (WebCore::PluginContainerSymbian::proxy):
        * plugins/symbian/PluginViewSymbian.cpp:
        (WebCore::PluginView::updatePluginWidget):
        (WebCore::PluginView::platformStart):
        (WebCore::PluginView::platformDestroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoved deprecated_logging unit test import statement from
cjerdonek@webkit.org [Thu, 25 Mar 2010 15:04:18 +0000 (15:04 +0000)]
Moved deprecated_logging unit test import statement from
webkitpy/unittests.py to webkitpy/common/system/unittests.py.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/webkitpy/common/system/unittests.py:
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoved webkit_logging.py to common/system/deprecated_logging.py
cjerdonek@webkit.org [Thu, 25 Mar 2010 14:46:36 +0000 (14:46 +0000)]
Moved webkit_logging.py to common/system/deprecated_logging.py
inside webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/validate-committer-lists:
* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/net/bugzilla.py:
* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/credentials.py:
* Scripts/webkitpy/common/net/irc/ircproxy.py:
* Scripts/webkitpy/common/net/networktransaction.py:
* Scripts/webkitpy/common/net/statusserver.py:
* Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
* Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
* Scripts/webkitpy/common/system/executive.py:
* Scripts/webkitpy/tool/bot/queueengine.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/openbugs.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/queues.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/stepsequence.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/multicommandtool.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
* Scripts/webkitpy/tool/steps/confirmdiff.py:
* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/update.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:
* Scripts/webkitpy/unittests.py:
* Scripts/webkitpy/webkit_logging.py: Removed.
* Scripts/webkitpy/webkit_logging_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Mar 2010 14:31:22 +0000 (14:31 +0000)]
2010-03-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=35714
        Computed style on delayed transform animations is incorrect

        When fetching computed style while a delayed accelerated animation is in effect,
        we would get the value form the first keyframe, rather than getting the current
        style.

        Fix by checking to see whether we've in the delay phase (with no backwards-fill)
        in KeyframeAnimation::getAnimatedStyle().

        Test: compositing/animation/computed-style-during-delay.html

        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::getAnimatedStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdditional refptr/passrefptr workarounds for WINSCW compiler
simon.fraser@apple.com [Thu, 25 Mar 2010 14:31:14 +0000 (14:31 +0000)]
Additional refptr/passrefptr workarounds for WINSCW compiler

https://bugs.webkit.org/show_bug.cgi?id=28054

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-02-12

Reviewed by Tor Arne Vestbø.

* wtf/PassRefPtr.h:
(WTF::refIfNotNull):
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::clear):
(WTF::::operator):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::::operator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a page on how to ask questions
jchaffraix@webkit.org [Thu, 25 Mar 2010 14:27:54 +0000 (14:27 +0000)]
Add a page on how to ask questions
https://bugs.webkit.org/show_bug.cgi?id=35223

Reviewed by David Levin.

* asking_questions.html: Added.
Add a page on how to ask questions based on Ariya Hidayat's mail: how
to get help effectively
(http://article.gmane.org/gmane.os.opendarwin.webkit.user/145/match=get+help+effectively)

* contact.html: Tweaked the wording to make it more clear what the
mailing list are used for. Also changed the formatting to better
underline the different mailing lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocommit-log-editor can call itself in an infinite loop
jchaffraix@webkit.org [Thu, 25 Mar 2010 14:13:56 +0000 (14:13 +0000)]
commit-log-editor can call itself in an infinite loop
https://bugs.webkit.org/show_bug.cgi?id=35291

Reviewed by Kenneth Rohde Christiansen.

if $editor ends up being commit-log-editor, the script will exec itself
in an infinite loop.

To avoid this, we now check that the $editor variable is not
commit-log-editor to avoid this case.

* Scripts/commit-log-editor: Added an isCommitLogEditor method and
reworked the $editor setting to add this check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Thu, 25 Mar 2010 14:04:49 +0000 (14:04 +0000)]
2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Add a Toggle Frame Flattening option to QtLauncher.
        It will be enabled by default on Maemo5 and S60 platforms.

        [Qt] Add enable/disable Frame Flattening option to QtLauncher
        https://bugs.webkit.org/show_bug.cgi?id=36558

        * QtLauncher/main.cpp:
        (LauncherWindow::applyPrefs):
        (LauncherWindow::toggleFrameFlattening):
        (LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 13:45:58 +0000 (13:45 +0000)]
2010-03-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Initialize Web Inspector title with inspected page URL when opening Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=36534

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Shu Chang <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 25 Mar 2010 13:43:55 +0000 (13:43 +0000)]
2010-03-25  Shu Chang  <chang.shu@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Added documentation for delete button.
        https://bugs.webkit.org/show_bug.cgi?id=31560

        * Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 13:21:01 +0000 (13:21 +0000)]
2010-03-25  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Eric Seidel.

        [Qt]Fix compile error with QT_NO_DESKTOPSERVICES
        https://bugs.webkit.org/show_bug.cgi?id=36533

        * Api/qwebsettings.cpp:
        (QWebSettings::enablePersistentStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Antti Koivisto <koivisto@iki.fi>
eric@webkit.org [Thu, 25 Mar 2010 13:02:11 +0000 (13:02 +0000)]
2010-03-25  Antti Koivisto  <koivisto@iki.fi>

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=36316
        Tiles of selected content do not update if not in viewport

        Don't clip repaints to viewport when tiling is enabled.

        * page/Frame.cpp:
        (WebCore::Frame::setView):
        (WebCore::Frame::setTiledBackingStoreEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Diego Gonzalez <diego.gonzalez@openbossa.org>
eric@webkit.org [Thu, 25 Mar 2010 12:43:04 +0000 (12:43 +0000)]
2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Eric Seidel.

        Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
        on WebKit.pri

        [Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
        https://bugs.webkit.org/show_bug.cgi?id=36547

        * platform/qt/Skipped:
2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>

        Reviewed by Eric Seidel.

        Missing forward ENABLE_DATALIST macro to JavaScript enabled features macros
        on WebKit.pri

        [Qt] Forward ENABLE_DATALIST macro to JavaScript enabled macros
        https://bugs.webkit.org/show_bug.cgi?id=36547

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 12:22:24 +0000 (12:22 +0000)]
2010-03-25  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Eric Seidel.

        [Qt]Fix compile error with QT_NO_DEBUG_STREAM
        https://bugs.webkit.org/show_bug.cgi?id=36533

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::graphicsItemVisibleRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 25 Mar 2010 12:19:35 +0000 (12:19 +0000)]
2010-03-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Expect console object wrapping to fail.

        https://bugs.webkit.org/show_bug.cgi?id=36587

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Sergio Villar Senín <svillar@igalia.com>
eric@webkit.org [Thu, 25 Mar 2010 12:03:38 +0000 (12:03 +0000)]
2010-03-25  Sergio Villar Senín  <svillar@igalia.com>

        Reviewed by Xan Lopez.

        Added new API webkit_web_back_forward_list_clear. This function
        clears the back forward list

        [GTK] http/history tests are failing
        https://bugs.webkit.org/show_bug.cgi?id=36173

        * tests/testwebbackforwardlist.c:
        (test_webkit_web_back_forward_list_clear):
        (main): added new unit test for the new API
        * webkit/webkitwebbackforwardlist.cpp:
        (webkit_web_back_forward_list_clear):
        * webkit/webkitwebbackforwardlist.h: new function that clears the
        back forward list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Joanmarie Diggs <joanmarie.diggs@gmail.com>
eric@webkit.org [Thu, 25 Mar 2010 11:44:47 +0000 (11:44 +0000)]
2010-03-25  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=36371
        [Gtk] Elements with a title attribute should not be ignored

        * platform/gtk/accessibility/object-with-title.html: Added
        * platform/gtk/accessibility/object-with-title-expected.txt: Added
2010-03-25  Joanmarie Diggs  <joanmarie.diggs@gmail.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=36371
        [Gtk] Elements with a title attribute should not be ignored

        * accessibility/AccessibilityRenderObject.cpp:
        (AccessibilityRenderObject::accessibilityIsIgnored):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Thu, 25 Mar 2010 11:23:23 +0000 (11:23 +0000)]
2010-03-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Eric Seidel.

        Make QWebPage not depend on view() but use the client->ownerWidget()
        instead. Also, handle the case where there is not page client.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::createContextMenu):
        (QWebPagePrivate::keyPressEvent):
        (QWebPage::javaScriptAlert):
        (QWebPage::javaScriptConfirm):
        (QWebPage::javaScriptPrompt):
        (QWebPage::shouldInterruptJavaScript):
        (QWebPage::createWindow):
        (QWebPage::action):
        (QWebPage::extension):
        (QWebPage::chooseFile):
        (QWebPage::userAgentForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Build fix on MSVC. Reverts r55633 for stdint.h
jocelyn.turcotte@nokia.com [Thu, 25 Mar 2010 11:20:41 +0000 (11:20 +0000)]
[Qt] Build fix on MSVC. Reverts r55633 for stdint.h

Reviewed by nobody, build fix.

This file gets included in generated moc files which don't
include the prefix header.

* os-win32/stdint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 25 Mar 2010 10:40:08 +0000 (10:40 +0000)]
2010-03-24  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Adds a missing ENABLE(WORKERS) guards to the V8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=36550

        Build fix only, no new tests.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 25 Mar 2010 10:33:37 +0000 (10:33 +0000)]
2010-03-25  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Eric Seidel.

        Add EFL-specific code to platform/ScrollView.cpp and
        platform/Scrollbar.cpp.
        http://webkit.org/b/36305

        * platform/ScrollView.cpp:
        * platform/Scrollbar.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 10:12:43 +0000 (10:12 +0000)]
2010-03-25  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Eric Seidel.

        [Qt]Fix compile error with QT_NO_LIBRARY
        https://bugs.webkit.org/show_bug.cgi?id=36533

        * platform/FileSystem.h:
        * platform/qt/FileSystemQt.cpp:
        (WebCore::unloadModule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 25 Mar 2010 09:46:49 +0000 (09:46 +0000)]
2010-03-25  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Eric Seidel.

        svn-create-patch prints a warning for large patches
        https://bugs.webkit.org/show_bug.cgi?id=32582

        svn-create-patch prints a warning message for larger patches than 20k.

        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Thu, 25 Mar 2010 09:40:59 +0000 (09:40 +0000)]
2010-03-25  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Eric Seidel.

        [Qt]Fix compile error with QT_NO_ANIMATION
        https://bugs.webkit.org/show_bug.cgi?id=36526

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
        * platform/graphics/qt/GraphicsLayerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 09:32:20 +0000 (09:32 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
        * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn webkitpy, pushed the unit test import statements in
cjerdonek@webkit.org [Thu, 25 Mar 2010 09:30:35 +0000 (09:30 +0000)]
In webkitpy, pushed the unit test import statements in
webkitpy/unittests.py into appropriate unittests.py files in the
new root-level packages beneath webkitpy.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/webkitpy/common/system/unittests.py:
* Scripts/webkitpy/common/unittests.py: Added.
* Scripts/webkitpy/python24/unittests.py: Added.
* Scripts/webkitpy/tool/unittests.py: Added.
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 09:17:11 +0000 (09:17 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
        package.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/webkitcheckout.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 09:11:31 +0000 (09:11 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move OutputCapture to webkitpy.common.system.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/common/net/bugzilla_unittest.py:
        * Scripts/webkitpy/common/net/credentials_unittest.py:
        * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
        * Scripts/webkitpy/outputcapture.py: Removed.
        * Scripts/webkitpy/tool/commands/commandtest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/multicommandtool_unittest.py:
        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 09:05:29 +0000 (09:05 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move user.py to webkitpy.common.system.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/common/net/credentials.py:
        * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
        * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/unittests.py:
        * Scripts/webkitpy/user.py: Removed.
        * Scripts/webkitpy/user_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 09:01:00 +0000 (09:01 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move executive.py to webkitpy.common.system.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:
        * Scripts/webkitpy/common/net/credentials.py:
        * Scripts/webkitpy/common/net/credentials_unittest.py:
        * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
        * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
        * Scripts/webkitpy/executive.py: Removed.
        * Scripts/webkitpy/executive_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/early_warning_system.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/stepsequence.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/steps/checkstyle.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/unittests.py:
        * Scripts/webkitpy/webkit_logging_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 08:50:14 +0000 (08:50 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move grammary.py into webkitpy.tool.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/grammar.py: Removed.
        * Scripts/webkitpy/grammar_unittest.py: Removed.
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
        * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
        * Scripts/webkitpy/tool/multicommandtool.py:
        * Scripts/webkitpy/tool/steps/obsoletepatches.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-10 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 25 Mar 2010 08:49:05 +0000 (08:49 +0000)]
2010-03-10  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Fix up WebMouseWheelEventBuilder to properly calculate the units
        https://bugs.webkit.org/show_bug.cgi?id=35989

        * src/WebInputEventConversion.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn webkitpy, moved init/ to common/system/.
cjerdonek@webkit.org [Thu, 25 Mar 2010 08:48:45 +0000 (08:48 +0000)]
In webkitpy, moved init/ to common/system/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
* Scripts/webkitpy/common/system/logutils.py:
* Scripts/webkitpy/common/system/logutils_unittest.py:
* Scripts/webkitpy/init: Removed.
* Scripts/webkitpy/init/__init__.py: Removed.
* Scripts/webkitpy/init/logtesting.py: Removed.
* Scripts/webkitpy/init/logutils.py: Removed.
* Scripts/webkitpy/init/logutils_unittest.py: Removed.
* Scripts/webkitpy/init/unittests.py: Removed.
* Scripts/webkitpy/python24/versioning_unittest.py:
* Scripts/webkitpy/style_references.py:
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 25 Mar 2010 08:46:28 +0000 (08:46 +0000)]
2010-03-25  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=33697
        Have dragOpFromIEOp("move") return DragOperationGeneric | DragOperationMove
        because only returning Generic doesn't work for platforms that don't
        have a generic operation.

        Covered by existing tests (fast/events/drag-and-drop.html).

        * dom/Clipboard.cpp:
        (WebCore::dragOpFromIEOp):
        (WebCore::Clipboard::destinationOperation):
        (WebCore::Clipboard::setDestinationOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 08:42:06 +0000 (08:42 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move stepsequence to webkitpy.tool.commands.
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/stepsequence.py: Removed.
        * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 25 Mar 2010 08:38:57 +0000 (08:38 +0000)]
2010-03-25  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] websocket/tests/long-invalid-header.html fails
        https://bugs.webkit.org/show_bug.cgi?id=36492

        * websocket/tests/long-invalid-header-expected.txt: trim console message.
2010-03-25  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Eric Seidel.

        [Qt] websocket/tests/long-invalid-header.html fails
        https://bugs.webkit.org/show_bug.cgi?id=36492

        trim message at most 128 bytes from the current position.
        I believe it's enough data to investigate the error reason and
        it makes test not depend on buffered size.

        * websockets/WebSocketHandshake.cpp:
        (WebCore::trimConsoleMessage):
        (WebCore::WebSocketHandshake::readServerHandshake):
        (WebCore::WebSocketHandshake::readHTTPHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 08:34:17 +0000 (08:34 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Create webkitpy.common.checkout as described in
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/changelogs.py: Removed.
        * Scripts/webkitpy/changelogs_unittest.py: Removed.
        * Scripts/webkitpy/commitinfo.py: Removed.
        * Scripts/webkitpy/commitinfo_unittest.py: Removed.
        * Scripts/webkitpy/common/checkout: Added.
        * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
        * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
        * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
        * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
        * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
        * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
        * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
        * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
        * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
        * Scripts/webkitpy/common/net/credentials.py:
        * Scripts/webkitpy/diff_parser.py: Removed.
        * Scripts/webkitpy/diff_parser_unittest.py: Removed.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/scm.py: Removed.
        * Scripts/webkitpy/scm_unittest.py: Removed.
        * Scripts/webkitpy/stepsequence.py:
        * Scripts/webkitpy/style_references.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/comments.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
        * Scripts/webkitpy/tool/steps/validatereviewer.py:
        * Scripts/webkitpy/unittests.py:
        * Scripts/webkitpy/webkitcheckout.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn webkitpy, moved init/versioning.py to python24/.
cjerdonek@webkit.org [Thu, 25 Mar 2010 08:02:43 +0000 (08:02 +0000)]
In webkitpy, moved init/versioning.py to python24/.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/test-webkitpy:
* Scripts/webkit-patch:
* Scripts/webkitpy/init/unittests.py:
* Scripts/webkitpy/init/versioning.py: Removed.
* Scripts/webkitpy/init/versioning_unittest.py: Removed.
* Scripts/webkitpy/python24: Added.
* Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
* Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
* Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 07:52:16 +0000 (07:52 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.

        Create webkitpy.common.net as described in
        https://bugs.webkit.org/show_bug.cgi?id=36093

        * Scripts/webkitpy/bugzilla.py: Removed.
        * Scripts/webkitpy/bugzilla_unittest.py: Removed.
        * Scripts/webkitpy/buildbot.py: Removed.
        * Scripts/webkitpy/buildbot_unittest.py: Removed.
        * Scripts/webkitpy/commitinfo.py:
        * Scripts/webkitpy/common/net: Added.
        * Scripts/webkitpy/common/net/__init__.py: Added.
        * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
        * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
        * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
        * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
        * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
        * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
        * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/common/net/irc/ircproxy.py:
        * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
        * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
        * Scripts/webkitpy/common/net/irc/unittests.py:
        * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
        * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
        * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
        * Scripts/webkitpy/credentials.py: Removed.
        * Scripts/webkitpy/credentials_unittest.py: Removed.
        * Scripts/webkitpy/irc: Removed.
        * Scripts/webkitpy/irc/__init__.py: Removed.
        * Scripts/webkitpy/irc/ircbot.py: Removed.
        * Scripts/webkitpy/irc/ircproxy.py: Removed.
        * Scripts/webkitpy/irc/messagepump.py: Removed.
        * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
        * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
        * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
        * Scripts/webkitpy/irc/unittests.py: Removed.
        * Scripts/webkitpy/networktransaction.py: Removed.
        * Scripts/webkitpy/networktransaction_unittest.py: Removed.
        * Scripts/webkitpy/scm_unittest.py:
        * Scripts/webkitpy/statusserver.py: Removed.
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
        * Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7780798> Missing plug-ins should be represented by text
jhoneycutt@apple.com [Thu, 25 Mar 2010 07:37:53 +0000 (07:37 +0000)]
<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block

https://bugs.webkit.org/show_bug.cgi?id=36583

Reviewed by Dan Bernstein.

WebCore:

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
Set the font rendering mode and the computed size, so that the text will
draw properly on Windows.

WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Kinuko Yasuda <kinuko@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 07:34:04 +0000 (07:34 +0000)]
2010-03-25  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Rewrite the layout test editing/inserting/6633727 to use dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=31579

        * editing/inserting/6633727-expected.txt: Added.
        * editing/inserting/6633727.html:
        * editing/inserting/script-tests/6633727.js: Added.
        * platform/gtk/editing/inserting/6633727-expected.txt: Removed.
        * platform/mac/editing/inserting/6633727-expected.checksum: Removed.
        * platform/mac/editing/inserting/6633727-expected.png: Removed.
        * platform/mac/editing/inserting/6633727-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn webkitpy, renamed MockBugzillaTool to MockTool.
cjerdonek@webkit.org [Thu, 25 Mar 2010 07:24:51 +0000 (07:24 +0000)]
In webkitpy, renamed MockBugzillaTool to MockTool.

Reviewed by Adam Barth.

* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn Scripts/webkitpy, moved webkitport.py and committers.py into
cjerdonek@webkit.org [Thu, 25 Mar 2010 07:18:16 +0000 (07:18 +0000)]
In Scripts/webkitpy, moved webkitport.py and committers.py into
common/config/ (also creating common/config/).

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

This is part of the master bug to reorganize webkitpy.

* Scripts/validate-committer-lists:
* Scripts/webkitpy/bugzilla.py:
* Scripts/webkitpy/bugzilla_unittest.py:
* Scripts/webkitpy/changelogs.py:
* Scripts/webkitpy/commitinfo.py:
* Scripts/webkitpy/commitinfo_unittest.py:
* Scripts/webkitpy/committers.py: Removed.
* Scripts/webkitpy/committers_unittest.py: Removed.
* Scripts/webkitpy/common: Added.
* Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
* Scripts/webkitpy/common/config: Added.
* Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
* Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
* Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
* Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
* Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
* Scripts/webkitpy/mock_bugzillatool.py:
* Scripts/webkitpy/tool/commands/early_warning_system.py:
* Scripts/webkitpy/tool/commands/queries.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/unittests.py:
* Scripts/webkitpy/webkitport.py: Removed.
* Scripts/webkitpy/webkitport_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 07:09:26 +0000 (07:09 +0000)]
2010-03-25  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.

        * Scripts/webkitpy/mock_bugzillatool.py: Removed.
        * Scripts/webkitpy/tool/commands/commandtest.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Thu, 25 Mar 2010 07:07:56 +0000 (07:07 +0000)]
2010-03-24  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Removing unecessary redraws of LayerSkia contents:
        https://bugs.webkit.org/show_bug.cgi?id=36470

        Test: No new functionality added, no tests.

        * platform/graphics/skia/LayerRendererSkia.cpp:
        (WebCore::LayerRendererSkia::drawLayerInCanvasRecursive):
        Debug borders now rendered at composite time rather than update time.
        * platform/graphics/skia/LayerSkia.cpp:
        (WebCore::LayerSkia::updateContents):
        (WebCore::LayerSkia::drawDebugBorder):
        Debug border drawing removed from updateContents and split into a separate method that
        can be called at composite time.
        (WebCore::LayerSkia::setBounds):
        Resetting the bounds causes the layer to redraw its contents.
        (WebCore::LayerSkia::setNeedsDisplay):
        * platform/graphics/skia/LayerSkia.h:
        Added declaration for drawDebugBorders method.
2010-03-24  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Dimitri Glazkov.

        Eliminate unecessary redraws of GraphicsLayer contents when doing accelerated compositing:
        https://bugs.webkit.org/show_bug.cgi?id=36470

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::paint):
        Remove call that forced redrawing the contents of the entire layer hierarchy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 06:59:09 +0000 (06:59 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move comments.py and multicommandtool.py to their new
        home.

        * Scripts/webkitpy/comments.py: Removed.
        * Scripts/webkitpy/multicommandtool.py: Removed.
        * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
        * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/openbugs.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
        * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
        * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
        * Scripts/webkitpy/tool/steps/closepatch.py:
        * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
        * Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 06:47:53 +0000 (06:47 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fixup one import statement I didn't find because the .pyc
        masked the error.

        * Scripts/webkitpy/stepsequence.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 06:44:31 +0000 (06:44 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move queueengine.py to its new home.

        * Scripts/webkitpy/queueengine.py: Removed.
        * Scripts/webkitpy/queueengine_unittest.py: Removed.
        * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
        * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
        * Scripts/webkitpy/tool/commands/early_warning_system.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 06:40:33 +0000 (06:40 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Move patchcollection.py to its new home.

        * Scripts/webkitpy/patchcollection.py: Removed.
        * Scripts/webkitpy/patchcollection_unittest.py: Removed.
        * Scripts/webkitpy/tool/bot: Added.
        * Scripts/webkitpy/tool/bot/__init__.py: Added.
        * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
        * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn Scripts/webkitpy, moved steps_references.py and the steps
cjerdonek@webkit.org [Thu, 25 Mar 2010 06:27:48 +0000 (06:27 +0000)]
In Scripts/webkitpy, moved steps_references.py and the steps
folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36093

* Scripts/webkitpy/steps: Removed.
* Scripts/webkitpy/steps/__init__.py: Removed.
* Scripts/webkitpy/steps/abstractstep.py: Removed.
* Scripts/webkitpy/steps/applypatch.py: Removed.
* Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
* Scripts/webkitpy/steps/build.py: Removed.
* Scripts/webkitpy/steps/checkstyle.py: Removed.
* Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
* Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
* Scripts/webkitpy/steps/closebug.py: Removed.
* Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
* Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
* Scripts/webkitpy/steps/closepatch.py: Removed.
* Scripts/webkitpy/steps/commit.py: Removed.
* Scripts/webkitpy/steps/confirmdiff.py: Removed.
* Scripts/webkitpy/steps/createbug.py: Removed.
* Scripts/webkitpy/steps/editchangelog.py: Removed.
* Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
* Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
* Scripts/webkitpy/steps/metastep.py: Removed.
* Scripts/webkitpy/steps/obsoletepatches.py: Removed.
* Scripts/webkitpy/steps/options.py: Removed.
* Scripts/webkitpy/steps/postdiff.py: Removed.
* Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
* Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
* Scripts/webkitpy/steps/preparechangelog.py: Removed.
* Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
* Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
* Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
* Scripts/webkitpy/steps/revertrevision.py: Removed.
* Scripts/webkitpy/steps/runtests.py: Removed.
* Scripts/webkitpy/steps/steps_unittest.py: Removed.
* Scripts/webkitpy/steps/update.py: Removed.
* Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
* Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
* Scripts/webkitpy/steps/validatereviewer.py: Removed.
* Scripts/webkitpy/steps_references.py: Removed.
* Scripts/webkitpy/stepsequence.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/applypatch.py:
* Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
* Scripts/webkitpy/tool/steps/build.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
* Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
* Scripts/webkitpy/tool/steps/closebug.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
* Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
* Scripts/webkitpy/tool/steps/closepatch.py:
* Scripts/webkitpy/tool/steps/commit.py:
* Scripts/webkitpy/tool/steps/confirmdiff.py:
* Scripts/webkitpy/tool/steps/createbug.py:
* Scripts/webkitpy/tool/steps/editchangelog.py:
* Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
* Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
* Scripts/webkitpy/tool/steps/metastep.py:
* Scripts/webkitpy/tool/steps/obsoletepatches.py:
* Scripts/webkitpy/tool/steps/postdiff.py:
* Scripts/webkitpy/tool/steps/postdiffforcommit.py:
* Scripts/webkitpy/tool/steps/postdiffforrevert.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
* Scripts/webkitpy/tool/steps/promptforbugortitle.py:
* Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
* Scripts/webkitpy/tool/steps/revertrevision.py:
* Scripts/webkitpy/tool/steps/runtests.py:
* Scripts/webkitpy/tool/steps/steps_unittest.py:
* Scripts/webkitpy/tool/steps/update.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
* Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
* Scripts/webkitpy/tool/steps/validatereviewer.py:
* Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Mar 2010 06:22:55 +0000 (06:22 +0000)]
2010-03-24  Eric Seidel  <eric@webkit.org>

        Unreviewed, build fix only.

        Abstract LayoutTestResults logic for easier reuse
        https://bugs.webkit.org/show_bug.cgi?id=36579

        * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 06:15:03 +0000 (06:15 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Fix a stray comma to test landing an patch without review.

        * Scripts/webkitpy/commitinfo.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIn Scripts/webkitpy, moved commands_references.py and the commands
cjerdonek@webkit.org [Thu, 25 Mar 2010 06:10:04 +0000 (06:10 +0000)]
In Scripts/webkitpy, moved commands_references.py and the commands
folder into webkitpy/patch.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=36483

This is part of master bug 36093 to organize webkitpy.

* Scripts/webkitpy/commands: Removed.
* Scripts/webkitpy/commands/__init__.py: Removed.
* Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
* Scripts/webkitpy/commands/commandtest.py: Removed.
* Scripts/webkitpy/commands/download.py: Removed.
* Scripts/webkitpy/commands/download_unittest.py: Removed.
* Scripts/webkitpy/commands/early_warning_system.py: Removed.
* Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
* Scripts/webkitpy/commands/openbugs.py: Removed.
* Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
* Scripts/webkitpy/commands/queries.py: Removed.
* Scripts/webkitpy/commands/queries_unittest.py: Removed.
* Scripts/webkitpy/commands/queues.py: Removed.
* Scripts/webkitpy/commands/queues_unittest.py: Removed.
* Scripts/webkitpy/commands/queuestest.py: Removed.
* Scripts/webkitpy/commands/sheriffbot.py: Removed.
* Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
* Scripts/webkitpy/commands/upload.py: Removed.
* Scripts/webkitpy/commands/upload_unittest.py: Removed.
* Scripts/webkitpy/commands_references.py: Removed.
* Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
* Scripts/webkitpy/tool/commands/commandtest.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/early_warning_system.py:
* Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
* Scripts/webkitpy/tool/commands/openbugs_unittest.py:
* Scripts/webkitpy/tool/commands/queries_unittest.py:
* Scripts/webkitpy/tool/commands/queues_unittest.py:
* Scripts/webkitpy/tool/commands/queuestest.py:
* Scripts/webkitpy/tool/commands/sheriffbot.py:
* Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
* Scripts/webkitpy/tool/main.py:
* Scripts/webkitpy/unittests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r56474.
mrowe@apple.com [Thu, 25 Mar 2010 06:07:28 +0000 (06:07 +0000)]
Build fix after r56474.

* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCRunSyncOpenPanel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRevert the portion of r56489 that dealt with port zero as it introduced some test...
mrowe@apple.com [Thu, 25 Mar 2010 06:07:24 +0000 (06:07 +0000)]
Revert the portion of r56489 that dealt with port zero as it introduced some test failures.

WebCore:

* platform/KURL.cpp:
(WebCore::KURL::port): Use the "ok" argument to charactersToUIntStrict to determine whether
it was able to successfully parse the string as an unsigned integer, rather than relying on
the fact it returned zero when it failed.

LayoutTests:

* platform/mac/security/block-test-expected.txt:
* security/block-test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 05:51:38 +0000 (05:51 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Rename webkitpy.patch to webkitpy.tool
        https://bugs.webkit.org/show_bug.cgi?id=36580

        This is in preparation for the great webkitpy naming cleanup.

        * Scripts/webkit-patch:
        * Scripts/webkitpy/patch: Removed.
        * Scripts/webkitpy/patch/__init__.py: Removed.
        * Scripts/webkitpy/patch/patcher.py: Removed.
        * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
        * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
        * Scripts/webkitpy/tool/patcher.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago* platform/text/String.cpp:
barraclough@apple.com [Thu, 25 Mar 2010 05:36:29 +0000 (05:36 +0000)]
* platform/text/String.cpp:
(WebCore::putUTF8Triple): Correct capitalization of function name.
(WebCore::String::utf8): Fix C-style casts.
(WebCore::String::fromUTF8): Remove unnecessary newline.
(WebCore::String::fromUTF8WithLatin1Fallback): Use early return.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit should treat port numbers outside the valid range as being blacklisted
mrowe@apple.com [Thu, 25 Mar 2010 05:26:14 +0000 (05:26 +0000)]
WebKit should treat port numbers outside the valid range as being blacklisted
<http://webkit.org/b/36571> / <rdar://problem/7790908>

Reviewed by Darin Adler.

WebCore:

* platform/KURL.cpp:
(WebCore::KURL::port): Map invalid port numbers to invalidPortNumber.
(WebCore::portAllowed): Add invalidPortNumber to the blacklist.
* platform/KURLGoogle.cpp:  invalid port numbers to invalidPortNumber.
(WebCore::KURL::port): Add invalidPortNumber to the blacklist.
Also bring this in to sync with KURL.  Having this identical code in two places is stupid.

LayoutTests:

* platform/mac/security/block-test-expected.txt:
* security/block-test.html: Add tests of a few invalid port numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Mar 2010 05:25:39 +0000 (05:25 +0000)]
2010-03-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Abstract LayoutTestResults logic for easier reuse
        https://bugs.webkit.org/show_bug.cgi?id=36579

        * Scripts/webkitpy/buildbot.py:
         - Split out logic into new LayoutTestResults class.
        * Scripts/webkitpy/buildbot_unittest.py:
         - Rename the testing class to match.
        * Scripts/webkitpy/commands/queries.py:
         - Use the new LayoutTestResults class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Mar 2010 05:14:02 +0000 (05:14 +0000)]
2010-03-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Seidel.

        Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
        https://bugs.webkit.org/show_bug.cgi?id=36577

        * Scripts/webkitpy/bugzilla.py:
         - Move prompt_for_component to User
        * Scripts/webkitpy/commands/queries.py:
         - Add a missing argument_names declaration.
        * Scripts/webkitpy/user.py:
         - Add prompt_with_list
         - Make staticmethods classmethods for easier mocking

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 MORITA Hajime <morrita@google.com>
eric@webkit.org [Thu, 25 Mar 2010 04:58:18 +0000 (04:58 +0000)]
2010-03-24  MORITA Hajime  <morrita@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=36517
        svg/dom/frame-related-api-during-load.html shoud be more self-descriptive.

        * svg/dom/frame-related-api-during-load-expected.txt:
        * svg/dom/frame-related-api-during-load.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix bug URL.
ddkilzer@apple.com [Thu, 25 Mar 2010 04:28:00 +0000 (04:28 +0000)]
Fix bug URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<htp://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLo...
ddkilzer@apple.com [Thu, 25 Mar 2010 04:25:33 +0000 (04:25 +0000)]
<htp://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file

Reviewed by Eric Seidel.

Fixes the following error when committing a file with
"ChangeLog" in the name that isn't a ChangeLog (like
mergeChangeLogs.pl from r56471 and r56472):

    $ git commit .
    Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
    error: There was a problem with the editor 'commit-log-editor'.
    Please supply the message using either -m or -F option.

* Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
the end of the file name when searching for ChangeLog files in a
commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if Change...
ddkilzer@apple.com [Thu, 25 Mar 2010 04:15:35 +0000 (04:15 +0000)]
<webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged

Reviewed by Eric Seidel.

* Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
the merge attempt fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch String::latin1, String::utf8, String::fromUTF8 to
barraclough@apple.com [Thu, 25 Mar 2010 04:15:15 +0000 (04:15 +0000)]
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 25 Mar 2010 04:08:43 +0000 (04:08 +0000)]
2010-03-24  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Eric Carlson, Eric Seidel and David Levin.

        Update a few more media layout tests to choose test clips based on codec support.

        https://bugs.webkit.org/show_bug.cgi?id=30435

        * media/audio-constructor-src.html: Switched to use findMediaFile().
        * media/audio-play-event-expected.txt: Updated results.
        * media/audio-play-event.html: Switched to use findMediaFile().
        * media/video-no-audio.html: Ditto.
        * media/video-source-add-src.html: Ditto.
        * media/video-src-change.html: Closed p tag.
        * platform/mac-leopard/media/video-no-audio-expected.checksum: New results due to changing source video.
        * platform/mac-leopard/media/video-no-audio-expected.png: Ditto.
        * platform/mac-leopard/media/video-no-audio-expected.txt: Ditto.
        * platform/mac/media/video-no-audio-expected.checksum: Ditto.
        * platform/mac/media/video-no-audio-expected.png: Ditto.
        * platform/mac/media/video-no-audio-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch String::latin1, String::utf8, String::fromUTF8 to
barraclough@apple.com [Thu, 25 Mar 2010 04:07:47 +0000 (04:07 +0000)]
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some missing exports.
weinig@apple.com [Thu, 25 Mar 2010 03:56:02 +0000 (03:56 +0000)]
Add some missing exports.

Reviewed by Mark Rowe.

* WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Mar 2010 03:45:11 +0000 (03:45 +0000)]
2010-03-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch or pre-commit hook should validate reviewer lines before committing
        https://bugs.webkit.org/show_bug.cgi?id=26927

        Validate that patches have valid reivewers listed in their ChangeLogs
        before landing.  For patches without reviewers can be landed if their
        ChangeLogs state that they are unreviewed.

        * Scripts/webkitpy/changelogs.py:
        * Scripts/webkitpy/commands/download.py:
        * Scripts/webkitpy/commitinfo.py:
        * Scripts/webkitpy/commitinfo_unittest.py:
        * Scripts/webkitpy/mock_bugzillatool.py:
        * Scripts/webkitpy/steps/__init__.py:
        * Scripts/webkitpy/steps/validatereviewer.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch String::latin1, String::utf8, String::fromUTF8 to
barraclough@apple.com [Thu, 25 Mar 2010 03:43:35 +0000 (03:43 +0000)]
Switch String::latin1, String::utf8, String::fromUTF8 to
use WTF's Unicode conversion methods rather than TextEncoder.
These methods only perform simple conversion, and don't need
really require TextEncoder's full capability (to look up arbitrary
encodings by name), switching to only be dependent on WTF will
make it easier if we chose to move WebCore::String to WTF.

Reviewed by Sam Weinig.

* platform/text/String.cpp:
(WebCore::String::latin1):
(WebCore::putUTF8triple):
(WebCore::String::utf8):
(WebCore::String::fromUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRestore peace and justice to the universe.
eric@webkit.org [Thu, 25 Mar 2010 01:10:30 +0000 (01:10 +0000)]
Restore peace and justice to the universe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUndefined names reported by pyflakes in python scripts
zecke@webkit.org [Thu, 25 Mar 2010 01:06:47 +0000 (01:06 +0000)]
Undefined names reported by pyflakes in python scripts

ttps://bugs.webkit.org/show_bug.cgi?id=36403

Attempt to use names that exist or can exist in the lexical
scope instead of not being available at all.

* Scripts/webkitpy/changelogs.py: Use self._content.
* Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
* Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
* Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
ap@apple.com [Thu, 25 Mar 2010 00:52:43 +0000 (00:52 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=36563
        A plug-in makes Safari crash on http://www.itscodingtime.com/

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        (WebKit::NetscapePluginHostProxy::port): Assert that the object is still alive. This isn't
        beautifully systemic, but helped catch a bug, and may help catch more.
        (WebKit::NetscapePluginHostProxy::clientPort): Ditto.
        (WebKit::NetscapePluginHostProxy::isProcessingRequests): Changed m_processingRequests to a
        static. This doesn't change behavior much, but helps avoid writing into deallocated memory.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Changed m_processingRequests
        to a static.
        (WebKit::NetscapePluginHostProxy::processRequests): Ditto. Changing m_processingRequests
        after destroying the object in pluginHostDied() was wrong, but reasonably harmless, as there
        wasn't much time for some other object to be allocated at this address.
        (WKPCEvaluate): Refetch host proxy, as it may have been destroyed.
        (WKPCInvoke): Ditto.
        (WKPCInvokeDefault): Ditto.
        (WKPCGetProperty): Ditto.
        (WKPCSetProperty): Ditto.
        (WKPCRemoveProperty): Ditto.
        (WKPCHasProperty): Ditto.
        (WKPCHasMethod): Ditto.
        (WKPCEnumerate): Ditto.
        (WKPCRunSyncOpenPanel): Ditto.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Bail out of the
        "event loop" if host proxy went away while processing a request.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Thu, 25 Mar 2010 00:02:36 +0000 (00:02 +0000)]
2010-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        Add the FrameFlatteningEnabled WebAttribute to QWebSettings.

        [Qt] Missing QWebSettings for Frame Flattening
        https://bugs.webkit.org/show_bug.cgi?id=36553

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        (QWebSettings::QWebSettings):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeL...
ddkilzer@apple.com [Wed, 24 Mar 2010 23:50:23 +0000 (23:50 +0000)]
<webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge

Reviewed by Eric Seidel.

When resolve-ChangeLogs fails to merge a patch while running as
a git merge driver, it deletes the original file, which causes
an internal failure and stops git mid-merge:

    fatal: Failed to execute internal merge

The fix is to use the --force switch with patch so that it will
always attempt to apply the patch.  (The change in
mergeChangeLogs() for the previous commit also fixed this, but
adding --force also prevents any potential user interaction that
patch may want to display.)

* Scripts/VCSUtils.pm:
(mergeChangeLogs): Added --force switch to patch command.  Also
changed to use the exit status from the patch command to
determine the return value for this method.
* Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
test to cover this bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils...
ddkilzer@apple.com [Wed, 24 Mar 2010 23:50:18 +0000 (23:50 +0000)]
<webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package

Reviewed by Eric Seidel.

* Scripts/VCSUtils.pm:
(mergeChangeLogs): Copied from mergeChanges() in
resolve-ChangeLogs and renamed.  Added method documentation.
Fixed bug found by new tests where the original file to be
patched was deleted when cleaning up after a traditinal rejected
patch failed to apply.
* Scripts/resolve-ChangeLogs: Switched to using
mergeChangeLogs().
(mergeChanges): Moved to VCSUtils.pm and renamed to
mergeChangeLogs().
* Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 24 Mar 2010 23:36:00 +0000 (23:36 +0000)]
2010-03-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add support for qt's unassigned list to webkit-patch assign-to-committer
        https://bugs.webkit.org/show_bug.cgi?id=36559

        * Scripts/webkitpy/bugzilla.py:
         - Move Bugzilla.unassigned_email into Bug and make it a set.
        * Scripts/webkitpy/bugzilla_unittest.py:
         - Test the new Bug.is_unassigned method
        * Scripts/webkitpy/commands/upload.py:
         - Use the new Bug.is_unassigned method instead of an explicit ==
        * Scripts/webkitpy/mock_bugzillatool.py:
         - Bugzilla.unassigned_email no longer needs mocking

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Dmitry Titov <dimich@chromium.org>
dimich@chromium.org [Wed, 24 Mar 2010 23:30:26 +0000 (23:30 +0000)]
2010-03-24  Dmitry Titov  <dimich@chromium.org>

        No review, rolling out r56453.
        http://trac.webkit.org/changeset/56453
        https://bugs.webkit.org/show_bug.cgi?id=36426

        In Chromium port, it broke invalid-image-data-standalone.html
        invalid-image-data.html multipart-wait-before-boundary.html
        stop-crash.html win-boundary-crash.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument):
2010-03-24  Dmitry Titov  <dimich@chromium.org>

        No review, rolling out r56453.
        http://trac.webkit.org/changeset/56453
        https://bugs.webkit.org/show_bug.cgi?id=36426

        In Chromium port, it broke invalid-image-data-standalone.html
        invalid-image-data.html multipart-wait-before-boundary.html
        stop-crash.html win-boundary-crash.html

        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        (WebCore::ResourceHandleInternal::start):
        (WebCore::ResourceHandleInternal::cancel):
        (WebCore::ResourceHandleInternal::didReceiveResponse):
        (WebCore::ResourceHandleInternal::didReceiveData):
        (WebCore::ResourceHandleInternal::didFinishLoading):
        (WebCore::ResourceHandleInternal::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoff Garen.
ap@apple.com [Wed, 24 Mar 2010 23:21:04 +0000 (23:21 +0000)]
    Reviewed by Geoff Garen.

        * wtf/FastMalloc.h: Added a using directive for fastMallocSize, like we do for all public
        WTF symbols. Also sorted the list alphabetically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 23:18:59 +0000 (23:18 +0000)]
2010-03-24  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Significant scroll speed degradation if Timeline has
        an expanded record with significant number of children.
        https://bugs.webkit.org/show_bug.cgi?id=36543

        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.prototype._updateBoundaries):
        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
        (WebInspector.TimelinePanel.prototype._filterRecords):
        (WebInspector.TimelinePanel.prototype._refreshRecords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Yuri Chornoivan <yurchor@ukr.net>
kov@webkit.org [Wed, 24 Mar 2010 23:08:35 +0000 (23:08 +0000)]
2010-03-24  Yuri Chornoivan  <yurchor@ukr.net>

        Reviewed by Gustavo Noronha.

        Ukrainian translation.

        * uk.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 24 Mar 2010 23:02:07 +0000 (23:02 +0000)]
2010-03-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Eric Carlson.

        [GStreamer] Fails to go to Loaded state because of floating point discrepancies
        https://bugs.webkit.org/show_bug.cgi?id=35891

        Use the m_fillStatus variable, which is more reliable, instead of
        using the calculation, for the completed case.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::fillTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, Chromium test fix.
dimich@chromium.org [Wed, 24 Mar 2010 23:00:07 +0000 (23:00 +0000)]
Unreviewed, Chromium test fix.

Recent r56445 added CustomEvent and a test but it didn't work on Chromium bots.
Test crashed due to infinte recursion because the compiler did not have the right definition of toV8(CustomEvent*)
and was substituting toV8(Event*).

Fixing test fast/events/custom-event.html

* bindings/v8/custom/V8EventCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 MORITA Hajime <morrita@google.com>
eric@webkit.org [Wed, 24 Mar 2010 22:45:03 +0000 (22:45 +0000)]
2010-03-24  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Adler.

        Refactoring: HTMLFormControlElement should not have redundant null check
        https://bugs.webkit.org/show_bug.cgi?id=36487

        No new tests as there is no new functionality.

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::dispatchFocusEvent):
        (WebCore::HTMLFormControlElement::dispatchBlurEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Eric Uhrhane <ericu@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 22:22:41 +0000 (22:22 +0000)]
2010-03-24  Eric Uhrhane <ericu@chromium.org>

        DOMCoreException needs NoStaticTables modifier
        https://bugs.webkit.org/show_bug.cgi?id=36458

        No new tests, but this shows up in tests of Database accesses from the
        Worker thread that I'll be checking in soon.  The symptom is that
        DOMCoreException.toString() returns [object DOMException] instead of
        something more helpful.

        * fast/workers/worker-context-multi-port-expected.txt:  Adjusted expectation that was depending on the broken behavior.
2010-03-24  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by Alexey Proskuryakov.

        DOMCoreException needs NoStaticTables modifier
        https://bugs.webkit.org/show_bug.cgi?id=36458

        No new tests, but this shows up in tests of Database accesses from the
        Worker thread that I'll be checking in soon.  The symptom is that
        DOMCoreException.toString() returns [object DOMException] instead of
        something more helpful.

        * dom/DOMCoreException.idl:  Added NoStaticTables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 22:05:02 +0000 (22:05 +0000)]
2010-03-24  Drew Wilson  <atwilson@chromium.org>

        Reviewed by Dmitry Titov.

        Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
        https://bugs.webkit.org/show_bug.cgi?id=36514

        Test: none (existing worker tests suffice)

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setDOMException):
        Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-23 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 24 Mar 2010 21:37:22 +0000 (21:37 +0000)]
2010-03-23  Evan Martin  <evan@chromium.org>

        Reviewed by Dmitry Titov.

        [chromium] use integral glyph widths
        https://bugs.webkit.org/show_bug.cgi?id=36510

        Extend a Linux Chromium layout test to also cover slight-hinted text.

        * platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle.html:
2010-03-23  Evan Martin  <evan@chromium.org>

        Reviewed by Dmitry Titov.

        [chromium] use integral glyph widths
        https://bugs.webkit.org/show_bug.cgi?id=36510

        Despite WebKit (and Skia, to an extent) supporting non-integral
        glyph widths, the font code path we hit in Skia only supports
        integral glyph positions.  This means that we would accumulate
        offsets when drawing a sequence up non-integer-width glyphs
        which would cause gaps when snapped to the pixel grid when drawing.

        * platform/graphics/chromium/SimpleFontDataLinux.cpp:
        (WebCore::SimpleFontData::platformWidthForGlyph):
        round glyph widths to integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 24 Mar 2010 21:16:54 +0000 (21:16 +0000)]
2010-03-24  Dean Jackson  <dino@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/7785305>
        Fix regression caused by r55576. It turned out that ensuring
        CoreAnimation always gets a correct fill parameter caused flashing
        as non-filled animations ended (CA briefly showed the initial animation
        value before the style system set the final value).

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::setupAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
eric@webkit.org [Wed, 24 Mar 2010 21:12:51 +0000 (21:12 +0000)]
2010-03-24  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>

        Reviewed by Laszlo Gombos.

        Auto-uppercase and predictive text need to be disabled for S60 (as for maemo)
        https://bugs.webkit.org/show_bug.cgi?id=33176

        * WebCoreSupport/EditorClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Wed, 24 Mar 2010 21:08:53 +0000 (21:08 +0000)]
2010-03-24  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium]WebKit side of adding search support to Pepper.
        https://bugs.webkit.org/show_bug.cgi?id=36434

        * WebKit.gyp:
        * public/WebDocument.h:
        * public/WebNode.h:
        (WebKit::WebNode::to):
        (WebKit::WebNode::toConst):
        * public/WebPluginDocument.h: Added.
        (WebKit::WebPluginDocument::WebPluginDocument):
        (WebKit::WebPluginDocument::operator=):
        (WebKit::WebPluginDocument::assign):
        * src/WebDocument.cpp:
        (WebKit::WebDocument::isPluginDocument):
        * src/WebPluginDocument.cpp: Added.
        (WebKit::WebPluginDocument::plugin):
        (WebKit::WebPluginDocument::WebPluginDocument):
        (WebKit::WebPluginDocument::operator=):
        (WebKit::WebPluginDocument::operator PassRefPtr<PluginDocument>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Wed, 24 Mar 2010 20:55:40 +0000 (20:55 +0000)]
2010-03-24  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=36522

        For consistency with other QWebSettings attributes.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        * Api/qwebsettings.h:
2010-03-24  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
        https://bugs.webkit.org/show_bug.cgi?id=36522

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setXSSAuditorEnabled): Use the new name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Anders Carlsson..
weinig@apple.com [Wed, 24 Mar 2010 20:50:26 +0000 (20:50 +0000)]
Rubber-stamped by Anders Carlsson..

Update Security Group Members list.

* security/security-group-members.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Hayato Ito <hayato@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 20:38:05 +0000 (20:38 +0000)]
2010-03-24  Hayato Ito  <hayato@chromium.org>

        Reviewed by NOBODY (Need!).

        Refactor computePageRects so that Mac can make use of it.
        https://bugs.webkit.org/show_bug.cgi?id=36159

        Refactoring only, so no new tests.

        * WebCore.base.exp:
        * page/PrintContext.cpp:
        (WebCore::PrintContext::computePageRects):
        (WebCore::PrintContext::computePageRectsWithPageSize):
        (WebCore::PrintContext::computePageRectsWithPageSizeInternal):
        (WebCore::PrintContext::pageNumberForElement):
        (WebCore::PrintContext::numberOfPages):
        * page/PrintContext.h:
2010-03-24  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Refactor computePageRects so that Mac can make use of it.
        https://bugs.webkit.org/show_bug.cgi?id=36159

        Refactoring only, so no new tests.

        * WebView/WebFrame.mm:
        (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Jeremy Moskovich <jeremy@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 20:20:32 +0000 (20:20 +0000)]
2010-03-24  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Jeremy Orlow.

        Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

        https://bugs.webkit.org/show_bug.cgi?id=36426

        No new tests as there is no new functionality.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoadingDocument): Make copy of mimeType string to isolate crash.
2010-03-24  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Jeremy Orlow.

        Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().

        https://bugs.webkit.org/show_bug.cgi?id=36426

        * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        (WebCore::ResourceHandleInternal::):
        (WebCore::ResourceHandleInternal::start):
        (WebCore::ResourceHandleInternal::cancel):
        (WebCore::ResourceHandleInternal::didReceiveResponse):
        (WebCore::ResourceHandleInternal::didReceiveData):
        (WebCore::ResourceHandleInternal::didFinishLoading):
        (WebCore::ResourceHandleInternal::didFail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Wed, 24 Mar 2010 20:02:55 +0000 (20:02 +0000)]
2010-03-24  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        Use newly introduced SetPrototype method to deal with global objects.
        https://bugs.webkit.org/show_bug.cgi?id=36497

        No new tests, should be covered by the current test infrastructure.

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::installDOMWindow):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getConstructor):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56452 268f45cc-cd09-0410-ab3c-d52691b4dbfc