WebKit-https.git
8 years ago[Qt] Unreviewed morning gardening after r99862.
ossy@webkit.org [Fri, 11 Nov 2011 06:28:49 +0000 (06:28 +0000)]
[Qt] Unreviewed morning gardening after r99862.

* platform/qt/svg/foreignObject/background-render-phase-expected.png: Added.
* platform/qt/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
dcheng@chromium.org [Fri, 11 Nov 2011 04:13:25 +0000 (04:13 +0000)]
[chromium] Add plumbing for JS to write to clipboard in copy/cut events.
https://bugs.webkit.org/show_bug.cgi?id=71414

Reviewed by Darin Fisher.

Source/WebCore:

No new tests since no new functionality enabled yet.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebClipboard.h:
(WebKit::WebClipboard::writeDataObject):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardWriteDataObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAtomically update the system clipboard for copy/cut events
dcheng@chromium.org [Fri, 11 Nov 2011 04:12:14 +0000 (04:12 +0000)]
Atomically update the system clipboard for copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=40515

Reviewed by David Levin.

This change consolidates the system pasteboard mutation logic into dispatchCPPEvent() rather
than having it scattered throughout tryDHTMLCopy/tryDHTMLCut and the various Clipboard*
classes. This allows us to ensure that the system pasteboard remains in a consistent state
even if there's an exception thrown during event handling, and it also lays the ground work
for allowing pages to prevent copy/cut without causing the system pasteboard to be cleared.

No new tests, since any layout test would be flaky since it would depend on and affect
global system state.

* editing/Editor.cpp:
(WebCore::Editor::tryDHTMLCopy): Move Pasteboard::clear() call to dispatchCPPEvent().
(WebCore::Editor::tryDHTMLCut): Ditto.
(WebCore::Editor::dispatchCPPEvent):
Only persist Clipboard mutations to the system pasteboard if the event was dispatched
successfully and default processing was prevented.
* editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard):
When creating a Clipboard for copy/cut, back it with a unique instance of NSPasteboard to
buffer pasteboard mutations.
* platform/Pasteboard.h:
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardGtk.
(WebCore::ClipboardGtk::setData):
* platform/gtk/ClipboardGtk.h:
(WebCore::ClipboardGtk::clipboard):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeClipboard):
Implement logic to flush data from temporary NSPasteboard to system pasteboard.
* platform/gtk/ClipboardGtk.cpp: Moved pasteboard writeback to PasteboardQt.
(WebCore::ClipboardGtk::setData):
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wince/PasteboardWinCE.cpp:
(WebCore::Pasteboard::writeClipboard):
* platform/wx/PasteboardWx.cpp:
(WebCore::Pasteboard::writeClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium rebaselines after r99902.
ojan@chromium.org [Fri, 11 Nov 2011 02:15:44 +0000 (02:15 +0000)]
Chromium rebaselines after r99902.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99916.
hayato@chromium.org [Fri, 11 Nov 2011 02:10:20 +0000 (02:10 +0000)]
Unreviewed, rolling out r99916.
http://trac.webkit.org/changeset/99916
https://bugs.webkit.org/show_bug.cgi?id=72077

fast/harness/result.html seems platform dependent (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

* platform/chromium/fast/harness/results-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] only run media GPU layout tests on platforms supporting accelerated compos...
scherkus@chromium.org [Fri, 11 Nov 2011 01:45:57 +0000 (01:45 +0000)]
[Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=72001

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderTableSection's recalcCell logic is doing too much work
jchaffraix@webkit.org [Fri, 11 Nov 2011 01:41:26 +0000 (01:41 +0000)]
RenderTableSection's recalcCell logic is doing too much work
https://bugs.webkit.org/show_bug.cgi?id=71986

Reviewed by Darin Adler.

No change in behavior expected so no test.

r98738 and r98980 missed the point that Vector::clear() does not touch
the internal buffer. Thus calling clear() would keep the memory and properly
reset the size().

Due to how the code worked, after r98980 the code would end up resetting some
of RowStruct field twice: once when growing and the other one when calling
fillRowsWithDefaultStartingAtPosition.

This change make the code use Vector::clear and simplified the recalcCells
logic knowing that growing the Vector will properly initialize most of the
RowStruct fields (with RowStruct constructor).

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::addCell):
Updated after ensureRows signature change.

(WebCore::RenderTableSection::ensureRows):
Removed the overflow check as it was making some assumption as to how the
Vector worked. If we want to implement a limit, we may do it differently.
Also inlined the part of fillRowsWithDefaultStartingAtPosition that grows
the columns to match our current representation. The rest of the function's
initialization is handled by the constructor already.

(WebCore::RenderTableSection::recalcCells):
Use clear() as it keeps the buffer and just resets the size. Also shrinkToFit
at the end as we may have lost some rows.

* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::CellStruct::CellStruct):
Fixed the style of the constructor.

(WebCore::RenderTableSection::RowStruct::RowStruct):
Added an explicit constructor (which is equivalent to the default one)
but underlines what we expect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT when outdenting styled line break.
enrica@apple.com [Fri, 11 Nov 2011 01:26:32 +0000 (01:26 +0000)]
ASSERT when outdenting styled line break.
https://bugs.webkit.org/show_bug.cgi?id=72069
<rdar://problem/10429739>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When outdenting a line break that has some inline style, we don't consider
the enclosing elements that provide the style.
This causes the splitting to occur in the wrong position,
triggering the assert.

Test: editing/execCommand/outdent-break-with-style.html

* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph): The fix consists
in choosing the highest inline ancestor as splitting point.
* editing/htmlediting.cpp:
(WebCore::isInline): Added.
* editing/htmlediting.h: Added isInline.

LayoutTests:

* editing/execCommand/outdent-break-with-style-expected.txt: Added.
* editing/execCommand/outdent-break-with-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG byte array support sometimes clamps values incorrectly
fpizlo@apple.com [Fri, 11 Nov 2011 01:07:44 +0000 (01:07 +0000)]
DFG byte array support sometimes clamps values incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71975

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

LayoutTests:

Reviewed by Oliver Hunt.

Added a test for byte arrays, and fixed a small bug in dfg-min-max.js.

* fast/js/dfg-byte-array-put-expected.txt: Added.
* fast/js/dfg-byte-array-put.html: Added.
* fast/js/script-tests/dfg-byte-array-put.js: Added.
(doPut):
(doGet):
* fast/js/script-tests/dfg-min-max.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, revert a misplaced expected text in r99819.
hayato@chromium.org [Fri, 11 Nov 2011 00:50:58 +0000 (00:50 +0000)]
Unreviewed, revert a misplaced expected text in r99819.
A results-expected is platform independent. r99828 fixed this.

* platform/chromium/fast/harness/results-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnce more for the QT build.
bdakin@apple.com [Fri, 11 Nov 2011 00:36:48 +0000 (00:36 +0000)]
Once more for the QT build.

* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::setFindIndicator):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore attempted build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:33:23 +0000 (00:33 +0000)]
More attempted build fix.

* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/efl/PageClientImpl.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix 32-bit build.
andersca@apple.com [Fri, 11 Nov 2011 00:32:33 +0000 (00:32 +0000)]
Fix 32-bit build.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer drawInContext:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative build fix.
bdakin@apple.com [Fri, 11 Nov 2011 00:28:42 +0000 (00:28 +0000)]
Speculative build fix.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::setFindIndicator):
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=66584
bdakin@apple.com [Fri, 11 Nov 2011 00:06:02 +0000 (00:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=66584
WebKit2's find bouncy looks blurry after dragging window onto >1.0 scale factor
display
-and corresponding-
<rdar://problem/9987559>

Reviewed by Anders Carlsson.

The setFindIndicator message and various functions of the same name must all take
an additional parameter indicating whether or not setting the find indicator
should result in a bounce animation. This is because when the device scale factor
changes, if there is currently a find indicator, it must be re-set to a higher or
lower resolution version, but we don't want the bounce animation to happen again.
* UIProcess/API/mac/FindIndicatorWindow.h:
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setFindIndicator):
* UIProcess/API/mac/WKView.mm:
(-[WKView _setFindIndicator:fadeOut:animate:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setFindIndicator):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

New function FindController::isShowingOverlay() is used to determine if
FindController::deviceScaleFactorDidChange() needs to be called.
* WebProcess/WebPage/FindController.h:
(WebKit::FindController::isShowingOverlay):

FindController::deviceScaleFactorDidChange() calls updateFindIndicator to re-
generate the bitmap at the appropriate scale factor, but tells it not to animate
this time.
(WebKit::FindController::deviceScaleFactorDidChange):

updateFindIndicator() takes a new parameter indicating whether or not the
FindIndicator should animate. It defaults to true since the deviceScaleFactor
changing is the only case currently where we do not want it to animate.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
(WebKit::FindController::hideFindIndicator):

Calls into FindController::deviceScaleFactorDidChange() when the scale factor has
changed and the find overlay is showing.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoValueProfile/PredictedType contains dead code, and doesn't recognize functions
fpizlo@apple.com [Thu, 10 Nov 2011 23:59:31 +0000 (23:59 +0000)]
ValueProfile/PredictedType contains dead code, and doesn't recognize functions
https://bugs.webkit.org/show_bug.cgi?id=72065

Reviewed by Gavin Barraclough and Geoff Garen.

Added PredictFunction support, and did some cleaning up along the way.
ValueProfile no longer has statistics machinery, because we never used
it. Rearranged some bits in PredictedType to more easily make room for
one more object type. Changed some debug code to use more consistent
conventions (ByteArray becomes Bytearray so that if we ever have a
"Byte" prediction we don't get confused between a prediction that is
the union of Byte and Array and a prediction that indicates precisely
a ByteArray).

* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isFunctionPrediction):
* bytecode/ValueProfile.cpp:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agobencher script should support remote benchmarking
fpizlo@apple.com [Thu, 10 Nov 2011 23:47:29 +0000 (23:47 +0000)]
bencher script should support remote benchmarking
https://bugs.webkit.org/show_bug.cgi?id=71618

Rubber-stamped by Geoff Garen.

Added the following features:

- Benchmark report tells you the hostname and machine model (according to
  'sysctl hw.model') of the machine you did the run on, and svn revision number
  (according to 'svn info') of the VMs you're testing.

- The --remote option. You give this an ssh-style hostname (i.e. user@host is
  acceptable, in addition to just host, in which case your username is used)
  and it automatically packages the build directories of the VMs you're testing,
  sends them to the remote machine along with your copy of the bencher script
  and all of the options you passed.  This pretty much seamlessly allows you
  to run a set of benchmarks on any machine that is sufficiently compatible with
  yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
  must now include a tempPath setting that tells bencher where to put files
  when that machine is used as a slave in a remote benchmarking run.

- Added yet another way of specifying which benchmarks to run. This was sort of
  necessary for --remote to work as expected. Previously, you either said what
  suites to exclude (for example --exclude-sunspider) or that you only wanted
  to run one suite to the exclusion of others (--sunspider-only). But it's
  often better to just be able to specify the list of suites you want. This is
  now supported. You can say, for example, --v8 --sunspider, which means, just
  run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
  still supported.

* Scripts/bencher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLazily start DRT instances in NRWT
tony@chromium.org [Thu, 10 Nov 2011 23:31:45 +0000 (23:31 +0000)]
Lazily start DRT instances in NRWT
https://bugs.webkit.org/show_bug.cgi?id=72038

Reviewed by Eric Seidel.

Just a refactoring, no new tests.

* Scripts/webkitpy/layout_tests/controllers/worker.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAM...
ddkilzer@apple.com [Thu, 10 Nov 2011 23:31:31 +0000 (23:31 +0000)]
<webkit.org/b/72049> Specify testapi.js install path using JAVASCRIPTCORE_FRAMEWORKS_DIR

Reviewed by Joseph Pecoraro.

* JavaScriptCore.xcodeproj/project.pbxproj: The testapi.js
script should use JAVASCRIPTCORE_FRAMEWORKS_DIR in its dstPath
for installation.  Also removed "Versions/A/" from the path
since this is unneeded due the default symlinks present in the
framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi...
dino@apple.com [Thu, 10 Nov 2011 23:11:15 +0000 (23:11 +0000)]
Remove effectBoundingBoxMode from CSS Filters https://bugs.webkit.org/show_bug.cgi?id=72058

Reviewed by Simon Fraser.

As suggested by Nikolas, we don't need this virtual method any more.

* rendering/FilterEffectRenderer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ARMv7 support to the DFG JIT
barraclough@apple.com [Thu, 10 Nov 2011 23:02:33 +0000 (23:02 +0000)]
Add ARMv7 support to the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72061

Reviewed by Geoff Garen.

* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::preserveReturnAddressAfterCall):
(JSC::DFG::AssemblyHelpers::restoreReturnAddressBeforeReturn):
(JSC::DFG::AssemblyHelpers::emitPutImmediateToCallFrameHeader):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
    - Add CPU(ARM) copies of these functions.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::spill):
    - Fix matching of '}' re #if blocks, makes some tools happy.
(JSC::DFG::JITCodeGenerator::setupArguments):
(JSC::DFG::JITCodeGenerator::setupArgumentsWithExecState):
(JSC::DFG::JITCodeGenerator::appendCallWithExceptionCheckSetResult):
(JSC::DFG::JITCodeGenerator::appendCallSetResult):
    - Add CPU(ARM) / 4 argument register copies of these functions.
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
    - These methods need to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
    - Should use callOperation to plant a call to a DFG_OPERATION.
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
    - This method needs to plant a relinkable jump; we currently do so
      using beginUninterruptedSequence() / endUninterruptedSequence().
(JSC::DFG::JITCompiler::compileBody):
    - Add abstraction to retrieve the pc after a call.
* dfg/DFGOSRExitCompiler.cpp:
    - Fix a bug - CodeLocationLabel needs a data address rather than an
      executable one, but can just take a MacroAssemblerCodePtr instead!
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::compileClampDoubleToByte):
    - Add FIXME comment to come back to! - bug#72054.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
    - Add missing method (ooops, required by bug#72047)
* dfg/DFGSpeculativeJIT32_64.cpp:
    - Need to wrap fmod on ARMv7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
luiz@webkit.org [Thu, 10 Nov 2011 23:01:27 +0000 (23:01 +0000)]
[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
https://bugs.webkit.org/show_bug.cgi?id=71530

Reviewed by Simon Hausmann.

Adding methods setGeometry and setFont so that users of platform plugin may show the
popup menus in proper position and using proper font.

* Api/qwebkitplatformplugin.h:
* WebCoreSupport/PopupMenuQt.cpp:
(WebCore::PopupMenuQt::show):
* examples/platformplugin/WebPlugin.h:
(WebPopup::setGeometry):
(WebPopup::setFont):
* examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060
hyatt@apple.com [Thu, 10 Nov 2011 22:59:46 +0000 (22:59 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=72060

[CSS Line Grid] Add support for the line-grid-snap property to control snapping to the nearest
enclosing grid.

Reviewed by Dan Bernstein.

Added fast/line-grid/line-grid-snap-parsing.html.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LineGridSnap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineGridSnap):
(WebCore::InheritedFlags::setLineGridSnap):
(WebCore::InheritedFlags::initialLineGridSnap):
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=72060

Add tests for line-grid-snap parsing.

Reviewed by Dan Bernstein.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/line-grid/line-grid-snap-parsing-expected.txt: Added.
* fast/line-grid/line-grid-snap-parsing.html: Added.
* fast/line-grid/script-tests/line-grid-snap-parsing.js: Added.
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChangeLog mistakenly recognizes any string between '*' and ':' as touched files
rniwa@webkit.org [Thu, 10 Nov 2011 22:52:30 +0000 (22:52 +0000)]
ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
https://bugs.webkit.org/show_bug.cgi?id=72057

Reviewed by Eric Seidel.

Make the regular expression more explicit.

* Scripts/webkitpy/common/checkout/changelog.py:
* Scripts/webkitpy/common/checkout/changelog_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCodeGeneratorV8.pm can generate Event constructors
haraken@chromium.org [Thu, 10 Nov 2011 22:43:46 +0000 (22:43 +0000)]
CodeGeneratorV8.pm can generate Event constructors
https://bugs.webkit.org/show_bug.cgi?id=72055

Reviewed by Adam Barth.

This patch makes CodeGeneratorV8.pm generate Event constructors
and replaces a custom constructor of Event with the generated one.
After this patch is landed without regression,
I will replace custom constructors of all other Events.
This patch introduces two new IDLs:

- [ConstructorTemplate=Event] IDL indicates that CodeGenerator should
generate an Event constructor.
- [InitializedByConstructor] IDL on an attribute indicates that
the attribute can be initialized by the constructor.

Tests: fast/events/constructors/event-constructors.html
       fast/events/constructors/custom-event-constructor.html
       fast/events/constructors/progress-event-constructor.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Added a header for fillXXXXEventInit(...).
(IsConstructable): Judges if a given interface is constructable.
(IsConstructorTemplate): Judges if a given interface has a given template, e.g. judges if an interface has [ConstructorTemplate=Event].
(GenerateEventConstructorCallback): Generates an Event constructor. The generated code is the same as the code that had been written in V8EventConstructors.cpp.
(GenerateImplementation): Generates an Event constructor if [ConstructorTemplate=Event] is specified.
* dom/Event.idl: Added [ConstructorTemplate=Event] IDL. Added [InitializedByConstructor] IDL to attributes that can be initialized by a constructor.

* bindings/scripts/test/TestEventConstructor.idl: Added a new run-bindings-test.
* bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: Updated a run-bindings-tests result.
(WebDOMTestEventConstructor::WebDOMTestEventConstructorPrivate::WebDOMTestEventConstructorPrivate):
(WebDOMTestEventConstructor::WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::operator=):
(WebDOMTestEventConstructor::impl):
(WebDOMTestEventConstructor::~WebDOMTestEventConstructor):
(WebDOMTestEventConstructor::attr1):
(WebDOMTestEventConstructor::attr2):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp: Ditto.
(WebKit::kit):
(webkit_dom_test_event_constructor_get_attr1):
(webkit_dom_test_event_constructor_get_attr2):
(WebKit::core):
(webkit_dom_test_event_constructor_finalize):
(webkit_dom_test_event_constructor_set_property):
(webkit_dom_test_event_constructor_get_property):
(webkit_dom_test_event_constructor_constructed):
(webkit_dom_test_event_constructor_class_init):
(webkit_dom_test_event_constructor_init):
(WebKit::wrapTestEventConstructor):
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h: Ditto.
* bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):
(WebCore::JSTestEventConstructorConstructor::finishCreation):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::getConstructData):
(WebCore::JSTestEventConstructorPrototype::self):
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype):
(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::toJS):
(WebCore::toTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventConstructor.h: Ditto.
(WebCore::JSTestEventConstructor::create):
(WebCore::JSTestEventConstructor::createStructure):
(WebCore::JSTestEventConstructor::impl):
(WebCore::JSTestEventConstructorPrototype::create):
(WebCore::JSTestEventConstructorPrototype::createStructure):
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorConstructor::create):
(WebCore::JSTestEventConstructorConstructor::createStructure):
* bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Ditto.
(-[DOMTestEventConstructor dealloc]):
(-[DOMTestEventConstructor finalize]):
(-[DOMTestEventConstructor attr1]):
(-[DOMTestEventConstructor attr2]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Ditto.
* bindings/scripts/test/V8/V8TestEventConstructor.cpp: Ditto.
(WebCore::TestEventConstructorInternal::V8_USE):
(WebCore::TestEventConstructorInternal::attr1AttrGetter):
(WebCore::TestEventConstructorInternal::attr2AttrGetter):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetRawTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore::V8TestEventConstructor::wrapSlow):
(WebCore::V8TestEventConstructor::derefObject):
* bindings/scripts/test/V8/V8TestEventConstructor.h: Ditto.
(WebCore::V8TestEventConstructor::toNative):
(WebCore::V8TestEventConstructor::existingWrapper):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h: Ditto.
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h: Ditto.
* bindings/scripts/test/V8/V8TestNamedConstructor.h: Ditto.
* bindings/scripts/test/V8/V8TestObj.h: Ditto.
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h: Ditto.
* bindings/v8/custom/V8EventConstructors.cpp: Removed a custom constructor of Event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.
senorblanco@chromium.org [Thu, 10 Nov 2011 22:27:32 +0000 (22:27 +0000)]
[chromium] Pre-emptively mark a canvas test as failing for next Skia roll.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG should not reparse code that was just parsed
fpizlo@apple.com [Thu, 10 Nov 2011 21:59:39 +0000 (21:59 +0000)]
DFG should not reparse code that was just parsed
https://bugs.webkit.org/show_bug.cgi?id=71977

Reviewed by Geoff Garen.

The instruction stream of a code block is now kept around until
the next GC. When doing either an optimizing compilation of an
executable, or inlining of an executable, we now try to find the
already preexisting bytecode. If we find it, we don't have to parse.
If we don't find it, we parse as before. Inlining takes the extra
step of caching code blocks, so if the same executable gets inlined
multiple times into the same caller, then we parse it at most once
even if prior to inlining that executable did not have any code
blocks with an instruction stream.

Also fixed a silly bug where the strict mode for various operations
was being determined by looking at the machine code block rather
than the inlinee.

To enable the delete-on-next-GC policy, I introduced the notion
of an ultra weak finalizer, which anyone can register during
tracing. This is thread-safe (for parallel GC) and
stop-the-world-safe (so calls to free() are postponed until the
world is resumed). This required reusing some facilities previously
created for WeakReferenceHarvester, so I created a common utility
class. I also retweaked the handling of WeakReferenceHarvesters,
since they should be executed during stop-the-world since in the
future we may want to allow them to call drain().

2% win on SunSpider. 2% win on V8, when run in my harness. Neutral
elsewhere.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::copyPostParseDataFrom):
(JSC::CodeBlock::copyPostParseDataFromAlternative):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::canProduceCopyWithBytecode):
(JSC::CodeBlock::discardBytecodeLater):
(JSC::CodeBlock::handleBytecodeDiscardingOpportunity):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::BytecodeDestructionBlocker::BytecodeDestructionBlocker):
(JSC::BytecodeDestructionBlocker::~BytecodeDestructionBlocker):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::strictModeFor):
* dfg/DFGByteCodeCache.h: Added.
(JSC::DFG::CodeBlockKey::CodeBlockKey):
(JSC::DFG::CodeBlockKey::operator==):
(JSC::DFG::CodeBlockKey::hash):
(JSC::DFG::CodeBlockKey::executable):
(JSC::DFG::CodeBlockKey::kind):
(JSC::DFG::CodeBlockKey::isHashTableDeletedValue):
(JSC::DFG::CodeBlockKeyHash::hash):
(JSC::DFG::CodeBlockKeyHash::equal):
(JSC::DFG::ByteCodeCache::ByteCodeCache):
(JSC::DFG::ByteCodeCache::~ByteCodeCache):
(JSC::DFG::ByteCodeCache::get):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator64.cpp:
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* heap/Heap.cpp:
(JSC::Heap::finalizeUnconditionally):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/ListableHandler.h: Added.
(JSC::ListableHandler::ListableHandler):
(JSC::ListableHandler::~ListableHandler):
(JSC::ListableHandler::List::List):
(JSC::ListableHandler::List::addNotThreadSafe):
(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::hasNext):
(JSC::ListableHandler::List::removeNext):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionally):
* heap/MarkStack.h:
(JSC::MarkStack::addWeakReferenceHarvester):
(JSC::MarkStack::addUnconditionalFinalizer):
* heap/SlotVisitor.h:
* heap/UnconditionalFinalizer.h: Added.
(JSC::UnconditionalFinalizer::~UnconditionalFinalizer):
* heap/WeakReferenceHarvester.h:
(JSC::WeakReferenceHarvester::WeakReferenceHarvester):
(JSC::WeakReferenceHarvester::~WeakReferenceHarvester):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::codeBlockWithBytecodeFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::profiledCodeBlockFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a couple tests that have started hitting asserts on the mac bots.
ojan@chromium.org [Thu, 10 Nov 2011 21:55:33 +0000 (21:55 +0000)]
Add a couple tests that have started hitting asserts on the mac bots.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDo not share CSS style for MediaElement backed by a plugin
benjamin@webkit.org [Thu, 10 Nov 2011 21:44:28 +0000 (21:44 +0000)]
Do not share CSS style for MediaElement backed by a plugin
https://bugs.webkit.org/show_bug.cgi?id=72005

Reviewed by Simon Fraser.

With PLUGIN_PROXY_FOR_VIDEO, the RenderMedia elements are rendered through RenderBoxModelObject.
Like the embedded element, the proxied media element can gain a layer outside a change of style.

This patch prevents style sharing for the Audio and Video elements when PLUGIN_PROXY_FOR_VIDEO
is enabled.

This path is covered by exising tests. In particular, http/tests/misc/empty-urls.html
ASSERT() because of this.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ARMv7 register info for the DFG JIT
barraclough@apple.com [Thu, 10 Nov 2011 21:41:04 +0000 (21:41 +0000)]
Add ARMv7 register info for the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=72050

Reviewed by Geoff Garen.

* dfg/DFGFPRInfo.h:
(JSC::DFG::FPRInfo::toRegister):
(JSC::DFG::FPRInfo::toIndex):
(JSC::DFG::FPRInfo::debugName):
* dfg/DFGGPRInfo.h:
(JSC::DFG::GPRInfo::toRegister):
(JSC::DFG::GPRInfo::toIndex):
(JSC::DFG::GPRInfo::debugName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WKViews in NSPopovers render as they would in active windows.
timothy@apple.com [Thu, 10 Nov 2011 21:34:00 +0000 (21:34 +0000)]
Make WKViews in NSPopovers render as they would in active windows.

The NSWindowDid{Become,Resign}KeyNotifications are not fired when NSPopovers
are shown or hidden since they share key with the parent window. So WKView
needs to update the active state during order on/off screen notifications.

https://webkit.org/b/68435

Reviewed by John Sullivan.

* UIProcess/API/mac/WKView.mm:
(-[WKView _windowDidOrderOffScreen:]): Call viewStateDidChange with WebPageProxy::ViewWindowIsActive.
(-[WKView _windowDidOrderOnScreen:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove/copy/merge SVG filter rendering code to generic rendering
dino@apple.com [Thu, 10 Nov 2011 21:31:50 +0000 (21:31 +0000)]
Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Implement an extremely simple version of the filter
chain. Only a single hue-rotate filter is supported
at the moment. The change in this commit was to insert a new
step in RenderLayer's painting to capture the content to an
offscreen ImageBuffer, apply a filter operation on that buffer,
and then draw the result in place of the original element. The full
implementation will need something like the SVGFilterBuilder
but this is a good prototype of effects on HTML content.
It's an open question at the moment as to when the filter
effect should apply: after masking, after overflow, after outline,
etc. Currently the filter applies at the end of the paintLayer code.
This will likely change.

Added a FilterEffectRenderer class that is the root of the filter
tree. At the moment it holds the offscreen context and
the existing paint context.

Other than rendering, the rest of this patch adds tests
to make sure any element with a filter style will become
a RenderLayer. In order to avoid a lot of duplicated code
around the more complex logic tests, RenderStyle::hasFilter
is available outside ENABLE(CSS_FILTERS), but returns false
in those situations.

Tests: css3/filters/add-filter-rendering.html
       css3/filters/remove-filter-rendering.html
       css3/filters/simple-filter-rendering.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::adjustRenderStyle):
* rendering/FilterEffectRenderer.cpp: Added.
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::~FilterEffectRenderer):
* rendering/FilterEffectRenderer.h: Added.
(WebCore::FilterEffectRenderer::create):
(WebCore::FilterEffectRenderer::setSourceImageRect):
(WebCore::FilterEffectRenderer::sourceImageRect):
(WebCore::FilterEffectRenderer::setFilterRegion):
(WebCore::FilterEffectRenderer::filterRegion):
(WebCore::FilterEffectRenderer::effectBoundingBoxMode):
(WebCore::FilterEffectRenderer::setEffect):
(WebCore::FilterEffectRenderer::effect):
(WebCore::FilterEffectRenderer::setSourceGraphic):
(WebCore::FilterEffectRenderer::sourceGraphic):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::requiresLayer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::shouldBeNormalFlowOnly):
(WebCore::RenderLayer::styleChanged):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
(WebCore::RenderLayer::updateFilterBackingStore):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasFilter):
* rendering/RenderObject.h:
(WebCore::RenderObject::hasFilter):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::requiresLayer):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hasFilter):

Move/copy/merge SVG filter rendering code to generic rendering
https://bugs.webkit.org/show_bug.cgi?id=68472

Reviewed by Simon Fraser.

Three new tests that exercise the (simple) filter
implementation.

* css3/filters/add-filter-rendering-expected.png: Added.
* css3/filters/add-filter-rendering-expected.txt: Added.
* css3/filters/add-filter-rendering.html: Added.
* css3/filters/remove-filter-rendering-expected.png: Added.
* css3/filters/remove-filter-rendering-expected.txt: Added.
* css3/filters/remove-filter-rendering.html: Added.
* css3/filters/simple-filter-rendering-expected.png: Added.
* css3/filters/simple-filter-rendering-expected.txt: Added.
* css3/filters/simple-filter-rendering.html: Added.
+

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
barraclough@apple.com [Thu, 10 Nov 2011 21:08:13 +0000 (21:08 +0000)]
#ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
https://bugs.webkit.org/show_bug.cgi?id=72047

Reviewed by Geoff Garen.

We currently don't attempt to abstract divide through the macro assembler,
due to these instructions commonly having specific requirements. This means
there is architecture specific code in the JIT - #ifdef it, and provide a
common implementation.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::fmodAsDFGOperation):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a simple content layer to TiledCoreAnimationDrawingArea
andersca@apple.com [Thu, 10 Nov 2011 21:06:39 +0000 (21:06 +0000)]
Add a simple content layer to TiledCoreAnimationDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=72044

Reviewed by Darin Adler.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add a content layer member variable.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(-[WKContentLayer _initWithWebPage:WebKit::]):
Add initializer.

(-[WKContentLayer drawInContext:]):
Lay out and draw the web page.

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add the content layer as a sublayer of the root layer.

(WebKit::TiledCoreAnimationDrawingArea::setNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Tell the content layer to paint.

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Resize the content layer as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe WKView layer hosting subview needs to be flipped
andersca@apple.com [Thu, 10 Nov 2011 21:06:34 +0000 (21:06 +0000)]
The WKView layer hosting subview needs to be flipped
https://bugs.webkit.org/show_bug.cgi?id=72042

Reviewed by Darin Adler.

In order to match the Core Animation layer hierarchy, the layer hosting WKView
subview needs to be flipped.

* UIProcess/API/mac/WKView.mm:
(-[WKFlippedView isFlipped]):
Add a NSView subview whose sole purpose is to be flipped.

(-[WKView _enterAcceleratedCompositingMode:]):
Create a WKFlippedView instead of a regular NSView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ENABLE_VALUE_PROFILER support for ARMv7
barraclough@apple.com [Thu, 10 Nov 2011 20:38:23 +0000 (20:38 +0000)]
Add ENABLE_VALUE_PROFILER support for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=72043

Reviewed by Geoff Garen.

This requires us to make a bucketCounterRegister available; to do so we'll need to spill more registers on entry to JIT code.

* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):
    - cleanup location of UNUSED_PARAM
* jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::JITThunks::JITThunks):
* jit/JITStubs.h:
    - Update JITStackFrame structure & asm code to spill more registers.
* jit/JSInterfaceJIT.h:
    - Assign a bucketCounterRegister.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix sampling counters on ARMv7, move add64 functionality to macro assembler
barraclough@apple.com [Thu, 10 Nov 2011 20:24:06 +0000 (20:24 +0000)]
Fix sampling counters on ARMv7, move add64 functionality to macro assembler
https://bugs.webkit.org/show_bug.cgi?id=72040

Reviewed by Geoff Garen.

The ability to add an integer to a uint64_t in memory is poorly copied in
multiple places & ifdef'ed on architecture, addWithCarry32 is also a badly
designed interface since add32 is not required to set flags (we have no
concept of flags in the macro assembler interface).

* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add64):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add64):
* dfg/DFGAssemblyHelpers.cpp:
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::emitCount):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 20:04:06 +0000 (20:04 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Update expectations for media/video-frame-accurate-seek.html.

        It's passing consistently.

        * platform/chromium-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-frame-accurate-seek-expected.png.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
xji@chromium.org [Thu, 10 Nov 2011 19:51:58 +0000 (19:51 +0000)]
Source/WebCore: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

Inside textarea, the shadowed text node's previous leaf node could be the
shadowRoot node, which cause assert exception in creating legacy position based
on such node. Exit previousRootInlineBox() when reach shadowRoot node.

It does not cause problem when looking for text node's next leaf node. Adding
the same checking in nextRootInlineBox just to be safe.

Test: editing/selection/move-by-word-visually-crash-test-textarea.html

* editing/visible_units.cpp:
(WebCore::previousRootInlineBox):
(WebCore::nextRootInlineBox):

LayoutTests: --webkit-visual-word crash when create legacy position for shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=71600

Reviewed by Ryosuke Niwa.

* editing/selection/move-by-word-visually-crash-test-textarea-expected.txt: Added.
* editing/selection/move-by-word-visually-crash-test-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd line for very flaky test storage/indexeddb/factory-deletedatabase-interactions...
ojan@chromium.org [Thu, 10 Nov 2011 19:27:47 +0000 (19:27 +0000)]
Add line for very flaky test storage/indexeddb/factory-deletedatabase-interactions.html.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoParse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108
dino@apple.com [Thu, 10 Nov 2011 19:26:24 +0000 (19:26 +0000)]
Parse drop-shadow() filter syntax https://bugs.webkit.org/show_bug.cgi?id=69108

Reviewed by Simon Fraser.

Source/WebCore:

Support parsing of the shadow syntax inside drop-shadow
and returning the correct computed style for a filter that
has such a function.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
    Move this from a static function (computedFilter) to a method on
    CSSComputedStyleDeclaration, which allows us to call the
    existing method for shadow styles.
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSComputedStyleDeclaration.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShadow):
    Previously parseShadow expected to be called with the entire
    value of a property, not just to look at a restricted subset.
    Change parseShadow to take a CSSParserValueList as parameter,
    allowing it to be used to parse the arguments to the drop-shadow
    function. Also, return the CSSValueList rather than injecting
    it directly into the property value.
(WebCore::filterInfoForName):
(WebCore::CSSParser::parseFilter):
    Support for the drop-shadow() function.
* css/CSSParser.h:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createFilterOperations):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
    Updated to use the new arguments for parseShadow.

LayoutTests:

Extend existing tests to exercise parsing of valid
and invalid drop-shadow filters, as well as the computed
style.

* css3/filters/filter-property-computed-style-expected.txt:
* css3/filters/filter-property-parsing-expected.txt:
* css3/filters/filter-property-parsing-invalid-expected.txt:
* css3/filters/script-tests/filter-property-computed-style.js:
* css3/filters/script-tests/filter-property-parsing-invalid.js:
* css3/filters/script-tests/filter-property-parsing.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 19:22:14 +0000 (19:22 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline Gtk/Win results after r99854.

        * platform/gtk/svg/batik/text/textEffect-expected.txt:
        * platform/gtk/svg/batik/text/textEffect3-expected.txt:
        * platform/gtk/svg/custom/image-with-transform-clip-filter-expected.txt:
        * platform/gtk/svg/custom/text-filter-expected.txt:
        * platform/gtk/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/gtk/svg/filters/filter-on-tspan-expected.txt:
        * platform/win/svg/custom/image-with-transform-clip-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 19:09:06 +0000 (19:09 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Rebaseline fast/layers/video-layer.html due to r98596.

        * platform/chromium-cg-mac-snowleopard/fast/layers/video-layer-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.png.
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
        * platform/chromium-mac-snowleopard/fast/layers/video-layer-expected.png: Added.
        * platform/chromium-mac/fast/layers/video-layer-expected.png: Removed.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt: Removed.
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium/fast/layers/video-layer-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/fast/layers/video-layer-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaselines after http://trac.webkit.org/changeset/99854.
ojan@chromium.org [Thu, 10 Nov 2011 18:47:41 +0000 (18:47 +0000)]
Rebaselines after trac.webkit.org/changeset/99854.
The new results were all updated in r99854, but there are sizing differences
on the chromium bots.

* platform/chromium-cg-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/filters/filter-on-tspan-expected.png.
* platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/text-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/text-filter-expected.png.
* platform/chromium-mac-snowleopard/svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feColorMatrix-values-expected.png.
* platform/chromium-mac-snowleopard/svg/filters/filter-on-tspan-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/filters/filter-on-tspan-expected.png.
* platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:
* platform/chromium-win/svg/custom/text-filter-expected.txt:
* platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
* platform/chromium-win/svg/filters/filter-on-filter-for-text-expected.txt:
* platform/chromium-win/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
adamk@chromium.org [Thu, 10 Nov 2011 18:39:39 +0000 (18:39 +0000)]
[MutationObservers] Microbenchmarks for appendChild, removeChild, and innerHTML
https://bugs.webkit.org/show_bug.cgi?id=71939

Reviewed by Ojan Vafai.

These benchmarks time both the DOM mutations themselves and the time taken
to call the MutationCallback. This measurement is achieved by
executing the code entirely within the MutationCallback itself.

* Mutation/append-child-deep.html: Added. Covers appendChild in a 200-node-deep tree with subtree observation.
* Mutation/append-child.html: Added. Covers appendChild in a flat tree.
* Mutation/inner-html.html: Added. Covers innerHTML adding and removing many nodes at a time.
* Mutation/remove-child-deep.html: Added. Covers removeChild in a 200-node-deep tree with subtree observation.
* Mutation/remove-child.html: Added. Covers removeChild in a flat tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ApplicationCache UI is confusing and incorrect.
vsevik@chromium.org [Thu, 10 Nov 2011 18:36:12 +0000 (18:36 +0000)]
Web Inspector: ApplicationCache UI is confusing and incorrect.
https://bugs.webkit.org/show_bug.cgi?id=64581

Reviewed by Pavel Feldman.

Source/WebCore:

Fixed resources panel application cache UI.
Manifest urls are now shown under application cache tree element.
Under each manifest url tree element frames using relevant application
cache are listed. Application cache detailed views could be opened for each
frame.

Test: http/tests/inspector/resource-tree/appcache-iframe-manifests.html

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
(WebCore::InspectorApplicationCacheAgent::setFrontend):
(WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
(WebCore::InspectorApplicationCacheAgent::networkStateChanged):
(WebCore::InspectorApplicationCacheAgent::enable):
(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::assertFrameWithDocumentLoader):
(WebCore::InspectorApplicationCacheAgent::getManifestForFrame):
(WebCore::InspectorApplicationCacheAgent::getApplicationCacheForFrame):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache):
(WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
* inspector/InspectorApplicationCacheAgent.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::getResourceContent):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
* inspector/InspectorPageAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype._update):
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
(WebInspector.ApplicationCacheModel.prototype._mainFrameNavigated):
(WebInspector.ApplicationCacheModel.prototype._manifestForFrameLoaded):
(WebInspector.ApplicationCacheModel.prototype._framesWithManifestsLoaded):
(WebInspector.ApplicationCacheModel.prototype._frameManifestUpdated):
(WebInspector.ApplicationCacheModel.prototype._frameManifestRemoved):
(WebInspector.ApplicationCacheModel.prototype.frameManifestURL):
(WebInspector.ApplicationCacheModel.prototype.frameManifestStatus):
(WebInspector.ApplicationCacheModel.prototype._statusUpdated):
(WebInspector.ApplicationCacheModel.prototype.requestApplicationCache):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.applicationCacheStatusUpdated):
(WebInspector.ApplicationCacheDispatcher.prototype.networkStateUpdated):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype.frameForId):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.wasShown):
(WebInspector.ResourcesPanel.prototype.reset):
(WebInspector.ResourcesPanel.prototype._frameNavigated):
(WebInspector.ResourcesPanel.prototype.addDocumentURL):
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._populateApplicationCacheTree):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestAdded):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestRemoved):
(WebInspector.ResourcesPanel.prototype._applicationCacheFrameManifestStatusChanged):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):
(WebInspector.ApplicationCacheManifestTreeElement):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.onselect):
(WebInspector.ApplicationCacheFrameTreeElement):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get itemURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get frameId):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.get manifestURL):
(WebInspector.ApplicationCacheFrameTreeElement.prototype._refreshTitles):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.frameNavigated):
(WebInspector.ApplicationCacheFrameTreeElement.prototype.onselect):

LayoutTests:

* http/tests/inspector/resource-tree/appcache-iframe-manifests-expected.txt: Added.
* http/tests/inspector/resource-tree/appcache-iframe-manifests.html: Added.
* http/tests/inspector/resource-tree/resources/manifest.php: Added.
* http/tests/inspector/resource-tree/resources/page-with-manifest.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium expectations for r99854.
tonyg@chromium.org [Thu, 10 Nov 2011 18:26:13 +0000 (18:26 +0000)]
Chromium expectations for r99854.

* platform/chromium-linux/svg/custom/image-with-transform-clip-filter-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/image-with-transform-clip-filter-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/image-with-transform-clip-filter-expected.png.
* platform/chromium-win/svg/custom/image-with-transform-clip-filter-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 18:23:15 +0000 (18:23 +0000)]
2011-11-10  Andrew Scherkus  <scherkus@chromium.org>

        Few more rebaselines for media/video-frame-accurate-seek-expected.html.

        * platform/chromium-cg-mac-snowleopard/media/video-frame-accurate-seek-expected.png: Added.
        * platform/chromium-mac-leopard/media/video-frame-accurate-seek-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixup expectations for bots that finished cycling after r99760 was committed.
ojan@chromium.org [Thu, 10 Nov 2011 18:16:54 +0000 (18:16 +0000)]
Fixup expectations for bots that finished cycling after r99760 was committed.

* platform/chromium/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
* platform/chromium/fast/repaint/scroll-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
* platform/chromium/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
* platform/chromium/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium expectations for r99862.
tonyg@chromium.org [Thu, 10 Nov 2011 18:11:53 +0000 (18:11 +0000)]
Chromium expectations for r99862.

* platform/chromium-win/svg/foreignObject/background-render-phase-expected.txt: Added.
* platform/chromium/svg/foreignObject/background-render-phase-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink CSSMutableStyleDeclaration.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:46:27 +0000 (17:46 +0000)]
Shrink CSSMutableStyleDeclaration.
<http://webkit.org/b/72032>

Reviewed by Antti Koivisto.

Move m_strictParsing and m_iteratorCount (debug only) up into
CSSStyleDeclaration, effectively shaving one CPU word (4/8 bytes)
off of every CSSMutableStyleDeclaration.

* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):
* css/CSSMutableStyleDeclaration.h:
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::CSSStyleDeclaration):
* css/CSSStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] X11 plugins need to be reworked for Qt5
kbalazs@webkit.org [Thu, 10 Nov 2011 17:32:31 +0000 (17:32 +0000)]
[Qt] X11 plugins need to be reworked for Qt5
https://bugs.webkit.org/show_bug.cgi?id=70023

Reviewed by Simon Hausmann.

.:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* Source/api.pri: Link to xlib if necessary.

Source/WebCore:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

No new tests. Existing plugin test are sufficient.

* Target.pri:
* bridge/npruntime_internal.h: Added yet another undef
to fix build with Qt5 + X11 headers.
* plugins/qt/QtX11ImageConversion.cpp: Added.
(WebCore::qimageFromXImage):
* plugins/qt/QtX11ImageConversion.h: Added.
Added a helper function to create a QImage from an XImage.
Put it in a new file into WebCore to avoid copyright issues - as
the code has been taken directly from Qt - and to be able to resuse
it for the WK1 plugin support in the future.

Source/WebKit2:

* Target.pri:
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::pluginsDirectories):
Kill the last dependency from the WebKit1 plugin system.
This is necessary because currently we don't build the WebKit1
plugin code. The function is equivalent with the XP_UNIX part of
PluginDatabase::defaultPluginDirectories.

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::getPluginDisplay):
(WebKit::x11Screen):
(WebKit::displayDepth):
(WebKit::rootWindowID):
(WebKit::NetscapePlugin::x11HostDisplay):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::initializeXEvent):
Rework plugin initialization and drawing model.

Tools:

Rework our basic plugin support in a way that does
not need a bridge between Qt and X. The solution is
based on getting the content drawed by the plugin
from the server as an image and creating a QImage
from it.

* qmake/mkspecs/features/features.prf: Enable X11
plugins if Qt is built with the xcb-xlib backend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/dom/htmlcollection-detectability.html has strange failure output.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:25:58 +0000 (17:25 +0000)]
fast/dom/htmlcollection-detectability.html has strange failure output.
<http://webkit.org/b/71946>

Reviewed by Darin Adler.

When a collection should be detectable, but isn't, the test would
say "Failed: document.foo is detectable." It should say that it's
undetectable.

* fast/dom/htmlcollection-detectability.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
vsevik@chromium.org [Thu, 10 Nov 2011 17:12:08 +0000 (17:12 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCache and reuse HTMLCollections exposed by Document.
andreas.kling@nokia.com [Thu, 10 Nov 2011 17:09:19 +0000 (17:09 +0000)]
Cache and reuse HTMLCollections exposed by Document.
<http://webkit.org/b/71956>

Reviewed by Antti Koivisto.

Source/WebCore:

Let Document cache the various HTMLCollection objects it exposes.
They're created on-demand and stored in a tight Vector.
This is a behavior change, since the lifetime of returned collections
is now tied to the lifetime of the Document. However, this matches the
current behavior of Firefox and Opera.

This reduces memory consumption by ~800 kB (on 64-bit) when loading
the full HTML5 spec. document.links was called 34001 times, yielding
34001 separate HTMLCollections, and now we only need 1.

The document.all collection retains the old behavior, as caching it
would be a bit more complicated.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::collection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::objects):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
* dom/Document.h:
* html/CollectionType.h:

LayoutTests:

Update fast/dom/gc-9.html to document the new lifetime behavior of
HTMLCollection objects returned by document.

* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium layout test rebaseline.
tonyg@chromium.org [Thu, 10 Nov 2011 17:07:17 +0000 (17:07 +0000)]
Chromium layout test rebaseline.

* platform/chromium-win/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [SuggestBox] Correctly position the box under the first character...
apavlov@chromium.org [Thu, 10 Nov 2011 17:07:02 +0000 (17:07 +0000)]
Web Inspector: [SuggestBox] Correctly position the box under the first character of the suggestion prefix.
https://bugs.webkit.org/show_bug.cgi?id=72022

Reviewed by Pavel Feldman.

On any suggest box position update (updateSuggestions invocation) an anchor is created at the beginning
of the user-entered word, and its box is ultimately passed into _updateBoxPosition to be used as the
actual anchor box (instead of the input element box).

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype._boxForAnchorAtStart):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.SuggestBox):
(WebInspector.TextPrompt.SuggestBox.prototype._onscrollresize):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.TextPrompt.SuggestBox.prototype._updateBoxPosition):
(WebInspector.TextPrompt.SuggestBox.prototype.updateSuggestions):
(WebInspector.TextPrompt.SuggestBox.prototype._completionsReady):
* inspector/front-end/utilities.js:
(AnchorBox):
(Element.prototype.offsetRelativeToWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
ryuan.choi@samsung.com [Thu, 10 Nov 2011 17:05:18 +0000 (17:05 +0000)]
[CMAKE] Refactoring CMakeLists${PORT}.txt to Platform${PORT}.cmake
https://bugs.webkit.org/show_bug.cgi?id=56705

Reviewed by Adam Roben.

Source/JavaScriptCore:

* CMakeLists.txt:
* PlatformEfl.cmake: Renamed from Source/JavaScriptCore/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/CMakeListsWinCE.txt.
* shell/CMakeLists.txt:
* shell/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsEfl.txt.
* shell/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/shell/CMakeListsWinCE.txt.
* wtf/CMakeLists.txt:
* wtf/PlatformEfl.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsEfl.txt.
* wtf/PlatformWinCE.cmake: Renamed from Source/JavaScriptCore/wtf/CMakeListsWinCE.txt.

Source/WebCore:

No new tests, just renaming CMakeLists*.txt to Platform*.cmake.

* CMakeLists.txt:
* PlatformEfl.cmake: Renamed from Source/WebCore/CMakeListsEfl.txt.
* PlatformWinCE.cmake: Renamed from Source/WebCore/CMakeListsWinCE.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
commit-queue@webkit.org [Thu, 10 Nov 2011 17:03:07 +0000 (17:03 +0000)]
[Chromium] Fix CCLayerTreeHostImplTest::scrollRootCallsCommitAndRedraw
https://bugs.webkit.org/show_bug.cgi?id=72027

We weren't calling setScrollable(true) when setting up the test, so
scroll events were being ignored. Test failed in debug builds, but passed
in release because we were using ASSERT instead of ASSERT_TRUE.

Patch by Iain Merrick <husky@google.com> on 2011-11-10
Reviewed by Tony Gentilcore.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
caseq@chromium.org [Thu, 10 Nov 2011 16:49:32 +0000 (16:49 +0000)]
Web Inspector: wrong JSON.stringify used in webInspector.inspectedWindow.eval() backend
https://bugs.webkit.org/show_bug.cgi?id=63083

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.InspectedWindow.prototype.eval):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

LayoutTests:

* inspector/extensions/extensions-eval-expected.txt:
* inspector/extensions/extensions-eval.html:
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WebKit2] Fix remaining gtkdoc errors
commit-queue@webkit.org [Thu, 10 Nov 2011 16:47:25 +0000 (16:47 +0000)]
[GTK] [WebKit2] Fix remaining gtkdoc errors
https://bugs.webkit.org/show_bug.cgi?id=71990

Patch by Martin Robinson <mrobinson@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitWebView.cpp: Update add the phrase "property" to
references to properties, because the gtkdoc stylesheet does not differeniate
between properties and signals. Standardize the way we talk about property
notifications.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add an include to silence
warnings about GIR annotations.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add the decorators the private section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG object covers CSS background in HTML foreignObject
commit-queue@webkit.org [Thu, 10 Nov 2011 16:47:16 +0000 (16:47 +0000)]
SVG object covers CSS background in HTML foreignObject
https://bugs.webkit.org/show_bug.cgi?id=58417

Patch by Florin Malita <fmalita@google.com> on 2011-11-10
Reviewed by Simon Fraser.

Source/WebCore:

Test: svg/foreignObject/background-render-phase.html

* rendering/svg/RenderSVGForeignObject.cpp:
(WebCore::RenderSVGForeignObject::paint):

    Paint SVG foreign objects atomically, following the same pattern as
    http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/InlineBox.cpp#L209.

LayoutTests:

* svg/foreignObject/background-render-phase-expected.png: Added.
* svg/foreignObject/background-render-phase-expected.txt: Added.
* svg/foreignObject/background-render-phase.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99851.
commit-queue@webkit.org [Thu, 10 Nov 2011 16:31:33 +0000 (16:31 +0000)]
Unreviewed, rolling out r99851.
http://trac.webkit.org/changeset/99851
https://bugs.webkit.org/show_bug.cgi?id=72029

Patch breaks Qt tests (Requested by schenney on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-10

Source/WebCore:

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance):
(WebCore::SVGElementInstance::clearChildren):
* svg/SVGElementInstance.h:
(WebCore::SVGElementInstance::clearUseElements):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance):

LayoutTests:

* svg/custom/element-instance-held-by-js-crash-expected.txt: Removed.
* svg/custom/element-instance-held-by-js-crash.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Clean up how singe / double taps are handled
kenneth@webkit.org [Thu, 10 Nov 2011 16:27:58 +0000 (16:27 +0000)]
[Qt] Clean up how singe / double taps are handled
https://bugs.webkit.org/show_bug.cgi?id=72024

Reviewed by Simon Hausmann.

Move all decision making to the QtWebPageProxy.

* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
* UIProcess/qt/QtTapGestureRecognizer.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::handleSingleTapEvent):
(QtWebPageProxy::handleDoubleTapEvent):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 16:15:56 +0000 (16:15 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline one test on Mac, to turn SL bots green again.

        * platform/mac/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 16:09:53 +0000 (16:09 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline Qt results after r99854.

        * platform/qt/svg/batik/text/textEffect-expected.txt:
        * platform/qt/svg/batik/text/textEffect3-expected.txt:
        * platform/qt/svg/custom/text-filter-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/qt/svg/filters/filter-on-tspan-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed: fixed new inspector media-query CSS test on Qt.
pfeldman@chromium.org [Thu, 10 Nov 2011 15:58:48 +0000 (15:58 +0000)]
Not reviewed: fixed new inspector media-query CSS test on Qt.

* inspector/styles/media-queries.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:42:19 +0000 (15:42 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
        https://bugs.webkit.org/show_bug.cgi?id=71932

        Reviewed by Philippe Normand.

        * platform/gtk/Skipped: Unskip test.

2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        [GTK] svg/as-image/svg-image-change-content-size.xhtml crashes
        https://bugs.webkit.org/show_bug.cgi?id=71932

        Reviewed by Philippe Normand.

        Null check m_page in drawSVGToImageBuffer(), just like all others methods do.
        As drawSVGToImageBuffer() is fired from a timer, it may get into this state under certain conditions, as seen on the 64bit gtk bot.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::drawSVGToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:40:37 +0000 (15:40 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rolling out part of r99854, which didn't belong there.

        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::drawSVGToImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 15:33:06 +0000 (15:33 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Move unit resolving for all resources to rendering/
        https://bugs.webkit.org/show_bug.cgi?id=72011

        Reviewed by Andreas Kling.

        Update expected results for some filters tests, now that their bounding box is correctly dumped.

        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/custom/text-filter-expected.txt:
        * platform/mac/svg/filters/feColorMatrix-values-expected.txt:
        * platform/mac/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/mac/svg/filters/filter-on-filter-for-text-expected.txt:
        * platform/mac/svg/filters/filter-on-tspan-expected.txt:

2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Move unit resolving for all resources to rendering/
        https://bugs.webkit.org/show_bug.cgi?id=72011

        Reviewed by Andreas Kling.

        Remove maskBoundingBox()/filterBoundingBox(), to avoid doing length resolution in svg/.
        RenderSVGResource* now uses SVGLengthContext::resolveRectangle, to do this while laying out.

        Move linear gradient start/end point, radial gradient focal/center point, radius calculations into
        their RenderSVGResource classes, cleanup code a bit.

        Convert filters to use SVGLengthContext. Fix DRT dumps for filters, while I'm at it, to give
        meaningful values, when objectBoundingBox is used as primitive units, when applying to <text>/<tspan>s.

        Several tests results need rebaselines on all platforms.

        * platform/graphics/filters/Filter.h:
        * rendering/svg/RenderSVGInlineText.h:
        (WebCore::RenderSVGInlineText::objectBoundingBox):
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::buildPrimitives):
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::resourceBoundingBox):
        * rendering/svg/RenderSVGResourceFilter.h:
        * rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
        (WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
        * rendering/svg/RenderSVGResourceGradient.cpp:
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/svg/RenderSVGResourceGradient.h:
        * rendering/svg/RenderSVGResourceLinearGradient.cpp:
        (WebCore::RenderSVGResourceLinearGradient::startPoint):
        (WebCore::RenderSVGResourceLinearGradient::endPoint):
        (WebCore::RenderSVGResourceLinearGradient::buildGradient):
        * rendering/svg/RenderSVGResourceLinearGradient.h:
        * rendering/svg/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::resourceBoundingBox):
        * rendering/svg/RenderSVGResourceRadialGradient.cpp:
        (WebCore::RenderSVGResourceRadialGradient::centerPoint):
        (WebCore::RenderSVGResourceRadialGradient::focalPoint):
        (WebCore::RenderSVGResourceRadialGradient::radius):
        (WebCore::RenderSVGResourceRadialGradient::adjustFocalPointIfNeeded):
        (WebCore::RenderSVGResourceRadialGradient::buildGradient):
        * rendering/svg/RenderSVGResourceRadialGradient.h:
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGResourceContainer):
        * svg/SVGFilterElement.cpp:
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGLinearGradientElement.cpp:
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMaskElement.cpp:
        * svg/SVGMaskElement.h:
        * svg/SVGRadialGradientElement.cpp:
        * svg/SVGRadialGradientElement.h:
        * svg/graphics/filters/SVGFilter.h:
        (WebCore::SVGFilter::filterRegionInUserSpace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix keyboard related layout tests after API refactoring
hausmann@webkit.org [Thu, 10 Nov 2011 15:32:53 +0000 (15:32 +0000)]
[Qt] Fix keyboard related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Send key events to the handling page item, not the view.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::sendEvent):
(WTR::PlatformWebView::postEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Make the ENABLE(FEATURE) macro work in DRT
commit-queue@webkit.org [Thu, 10 Nov 2011 15:23:53 +0000 (15:23 +0000)]
[GTK] Make the ENABLE(FEATURE) macro work in DRT
https://bugs.webkit.org/show_bug.cgi?id=71940

Patch by Alexandre Mazari <amazari@igalia.com> on 2011-11-10
Reviewed by Philippe Normand.

* GNUmakefile.am:
Add webcore_cppflags to Programs_DumpRenderTree_CPP so
ENABLE_* variables are part of the environment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNull deref when no use element exists for SVG element instance
commit-queue@webkit.org [Thu, 10 Nov 2011 15:23:40 +0000 (15:23 +0000)]
Null deref when no use element exists for SVG element instance
https://bugs.webkit.org/show_bug.cgi?id=59136

Source/WebCore:

Cleans up the object when it is detached from the shadow DOM tree,
rather than leaving it in a half-clean state with some nulled
references but not others.

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

Test: svg/custom/element-instance-held-by-js-crash.svg

* svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::~SVGElementInstance): Added a call to
detach to clean up if deletion happens without a prior detach call (as
when an entire tree is removed).
(WebCore::SVGElementInstance::detach): New method that replaces other
clean-up methods when the instance is removed from the shadow DOM.
* svg/SVGElementInstance.h: Added new detach method and removed
unnecessary clear methods.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::detachInstance): Changed calls to clear to
instead detach.

LayoutTests:

Patch by Stephen Chenney <schenney@chromium.org> on 2011-11-10
Reviewed by Nikolas Zimmermann.

* svg/custom/element-instance-held-by-js-crash-expected.txt: Added.
* svg/custom/element-instance-held-by-js-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix focus related layout tests after API refactoring
hausmann@webkit.org [Thu, 10 Nov 2011 15:12:19 +0000 (15:12 +0000)]
[Qt] Fix focus related layout tests after API refactoring

Reviewed by Tor Arne Vestbø.

Make sure the focus is set on the page now, not on the view
(which doesn't actually handle the focus).

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::WrapperWindow):
(WTR::WrapperWindow::handleStatusChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Show media queries associated with specific CSS rules
apavlov@chromium.org [Thu, 10 Nov 2011 14:56:28 +0000 (14:56 +0000)]
Web Inspector: Show media queries associated with specific CSS rules
https://bugs.webkit.org/show_bug.cgi?id=65626

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/media-queries.html

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::updateLastMediaLine):
* css/CSSParser.h:
* css/MediaList.cpp:
(WebCore::MediaList::MediaList):
* css/MediaList.h:
(WebCore::MediaList::lastLine):
(WebCore::MediaList::setLastLine):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::bindStyleSheet):
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::documentURLString):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorStyleSheet.cpp:
(WebCore::buildMediaObject):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::buildObjectForRule):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule):
(WebInspector.CSSMedia):
(WebInspector.CSSMedia.parsePayload):
(WebInspector.CSSMedia.parseMediaArrayPayload):
* inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyResourceAsNode):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
* inspector/front-end/elementsPanel.css:
(.styles-section .header .title .media, .styles-section .header .title .media .subtitle):
(.styles-section .header .subtitle):

LayoutTests:

* inspector/styles/media-queries-expected.txt: Added.
* inspector/styles/media-queries.html: Added.
* inspector/styles/resources/media-queries-1.css: Added.
(body):
(#main):
* inspector/styles/resources/media-queries.css: Added.
(#main):
* inspector/styles/styles-iframe-expected.txt:
* inspector/styles/styles-source-lines-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [SuggestBox] Do not display suggest box if editing in the middle of...
apavlov@chromium.org [Thu, 10 Nov 2011 14:52:17 +0000 (14:52 +0000)]
Web Inspector: [SuggestBox] Do not display suggest box if editing in the middle of prompt unless a stop character follows
https://bugs.webkit.org/show_bug.cgi?id=72018

Reviewed by Pavel Feldman.

* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.complete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: do not highlight files larger than 10KLOC.
pfeldman@chromium.org [Thu, 10 Nov 2011 14:49:23 +0000 (14:49 +0000)]
Web Inspector: do not highlight files larger than 10KLOC.
https://bugs.webkit.org/show_bug.cgi?id=72025

This is a temporary measure while I am improving the highlighter
footprint. Otherwise, highlighting pretty printed Gmail takes ~1.3G of RAM.

Reviewed by Yury Semikhatsky.

* inspector/front-end/TextEditorHighlighter.js:
(WebInspector.TextEditorHighlighter.prototype.highlight):
(WebInspector.TextEditorHighlighter.prototype.updateHighlight):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._didRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Clean up build system
hausmann@webkit.org [Thu, 10 Nov 2011 14:32:04 +0000 (14:32 +0000)]
[Qt] Clean up build system

Reviewed by Tor Arne Vestbø.

.:

* Source/api.pri: Eliminate use of WebKit2.pri.

Source/WebKit2:

Now that we use whole-archive linking we can fold the files that contain exported
symbols back into the WebKit2 static library.

* Target.pri: Fold in sources from WebKit2.pri.
* WebKit2.pri: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Merge QTouchWebView and QDesktopWebView into one class
alexis.menard@openbossa.org [Thu, 10 Nov 2011 14:09:07 +0000 (14:09 +0000)]
[Qt] Merge QTouchWebView and QDesktopWebView into one class
https://bugs.webkit.org/show_bug.cgi?id=71355

Reviewed by Kenneth Rohde Christiansen.

.:

Remove old tests and merge them into the new QQuickWebView directory.

* Source/tests.pri:

Source/WebKit/qt:

Register only QQuickWebView and QQuickWebPage in the plugin.

* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):

Source/WebKit2:

Merge QTouchWebView and QDesktopWebView into one class called
QQuickWebView and its attached page QQuickWebPage. You can switch to the
traditional desktop use case with the private header. Also now on desktop
platforms AC is turn on by default. I also merged our two
subclasses of QtViewInterface into one as the split doesn't make
that much sense anymore. In the future we want to be able to enable the
traditional desktop use case depending the platform the code is running.
API tests and QML tests have been updated.

* Target.pri:
* UIProcess/API/qt/WKView.h:
* UIProcess/API/qt/qbasewebview.cpp: Removed.
* UIProcess/API/qt/qbasewebview_p.h: Removed.
* UIProcess/API/qt/qdesktopwebview.cpp: Removed.
* UIProcess/API/qt/qdesktopwebview.h: Removed.
* UIProcess/API/qt/qdesktopwebview_p.h: Removed.
* UIProcess/API/qt/qquickwebpage.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp.
(QQuickWebPage::QQuickWebPage):
(QQuickWebPage::~QQuickWebPage):
(QQuickWebPage::keyPressEvent):
(QQuickWebPage::keyReleaseEvent):
(QQuickWebPage::inputMethodEvent):
(QQuickWebPage::focusInEvent):
(QQuickWebPage::focusOutEvent):
(QQuickWebPage::mousePressEvent):
(QQuickWebPage::mouseMoveEvent):
(QQuickWebPage::mouseReleaseEvent):
(QQuickWebPage::mouseDoubleClickEvent):
(QQuickWebPage::wheelEvent):
(QQuickWebPage::hoverEnterEvent):
(QQuickWebPage::hoverMoveEvent):
(QQuickWebPage::hoverLeaveEvent):
(QQuickWebPage::dragMoveEvent):
(QQuickWebPage::dragEnterEvent):
(QQuickWebPage::dragLeaveEvent):
(QQuickWebPage::dropEvent):
(QQuickWebPage::geometryChanged):
(QQuickWebPage::event):
(QQuickWebPage::touchEvent):
(QQuickWebPage::itemChange):
(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::initializeSceneGraphConnections):
(QQuickWebPagePrivate::setPageProxy):
(computeEffectiveOpacity):
(QQuickWebPagePrivate::paintToCurrentGLContext):
(QQuickWebPagePrivate::_q_onAfterSceneRender):
(QQuickWebPagePrivate::_q_onSceneGraphInitialized):
* UIProcess/API/qt/qquickwebpage.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage.h.
* UIProcess/API/qt/qquickwebpage_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qtouchwebpage_p.h.
* UIProcess/API/qt/qquickwebview.cpp: Added.
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::enableMouseEvents):
(QQuickWebViewPrivate::disableMouseEvents):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::initializeDesktop):
(QQuickWebViewPrivate::initializeTouch):
(QQuickWebViewPrivate::loadDidCommit):
(QQuickWebViewPrivate::contentSizeChanged):
(QQuickWebViewPrivate::scrollPositionRequested):
(QQuickWebViewPrivate::_q_viewportUpdated):
(QQuickWebViewPrivate::_q_viewportTrajectoryVectorChanged):
(QQuickWebViewPrivate::_q_onVisibleChanged):
(QQuickWebViewPrivate::updateViewportSize):
(QQuickWebViewPrivate::updateViewportConstraints):
(QQuickWebViewPrivate::didChangeViewportProperties):
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::chooseFiles):
(QQuickWebViewPrivate::_q_onOpenPanelFilesSelected):
(QQuickWebViewPrivate::_q_onOpenPanelFinished):
(QQuickWebViewPrivate::setUseTraditionalDesktopBehaviour):
(toPolicyAction):
(hasMetaMethod):
(QQuickWebViewPrivate::navigationPolicyForURL):
(QQuickWebViewPrivate::setPageProxy):
(QQuickWebView::QQuickWebView):
(QQuickWebView::~QQuickWebView):
(QQuickWebView::page):
(QQuickWebView::load):
(QQuickWebView::postMessage):
(QQuickWebView::url):
(QQuickWebView::loadProgress):
(QQuickWebView::title):
(QQuickWebView::navigationController):
(QQuickWebView::preferences):
(QQuickWebView::geometryChanged):
(QQuickWebView::touchEvent):
(QQuickWebView::pageRef):
* UIProcess/API/qt/qquickwebview.h: Renamed from Source/WebKit2/UIProcess/API/qt/qbasewebview.h.
* UIProcess/API/qt/qquickwebview_p.h: Added.
* UIProcess/API/qt/qtouchwebview.cpp: Removed.
* UIProcess/API/qt/qtouchwebview.h: Removed.
* UIProcess/API/qt/qtouchwebview_p.h: Removed.
* UIProcess/API/qt/tests/commonviewtests/commonviewtests.pro: Removed.
* UIProcess/API/qt/tests/commonviewtests/tst_commonviewtests.cpp: Removed.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp: Removed.
* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.h: Removed.
* UIProcess/API/qt/tests/qdesktopwebview/tst_qdesktopwebview.cpp: Removed.
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_download.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_linkHovered.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_loadZeroSizeView.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_messaging.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_navigationPolicyForUrl.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_preferences.qml:
* UIProcess/API/qt/tests/qmltests/DesktopWebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_load.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadFail.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadNegativeSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgressSignal.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadZeroSizeView.qml:
* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_properties.qml:
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(DesktopWebView::DesktopWebView):
(main):
* UIProcess/API/qt/tests/qquickwebview/qquickwebview.pro: Renamed from Source/WebKit2/UIProcess/API/qt/tests/qdesktopwebview/qdesktopwebview.pro.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp: Added.
(tst_QQuickWebView::tst_QQuickWebView):
(tst_QQuickWebView::init):
(tst_QQuickWebView::cleanup):
(tst_QQuickWebView::webView):
(tst_QQuickWebView::accessPage):
(tst_QQuickWebView::navigationStatusAtStartup):
(LoadStartedCatcher::LoadStartedCatcher):
(LoadStartedCatcher::onLoadStarted):
(tst_QQuickWebView::stopEnabledAfterLoadStarted):
(tst_QQuickWebView::baseUrl):
(tst_QQuickWebView::loadEmptyUrl):
(tst_QQuickWebView::loadEmptyPageViewVisible):
(tst_QQuickWebView::loadEmptyPageViewHidden):
(tst_QQuickWebView::loadNonexistentFileUrl):
(tst_QQuickWebView::backAndForward):
(tst_QQuickWebView::reload):
(tst_QQuickWebView::stop):
(tst_QQuickWebView::loadProgress):
(tst_QQuickWebView::show):
* UIProcess/API/qt/tests/qtouchwebview/qtouchwebview.pro: Removed.
* UIProcess/API/qt/tests/qtouchwebview/tst_qtouchwebview.cpp: Removed.
* UIProcess/API/qt/tests/testwindow.h:
* UIProcess/TiledDrawingAreaProxy.h:
* UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::QtGestureRecognizer):
(WebKit::QtGestureRecognizer::setViewportInteractionEngine):
* UIProcess/qt/QtGestureRecognizer.h:
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::setViewportInteractionEngine):
(WebKit::QtPanGestureRecognizer::recognize):
* UIProcess/qt/QtPanGestureRecognizer.h:
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::recognize):
(WebKit::QtPinchGestureRecognizer::setViewportInteractionEngine):
* UIProcess/qt/QtPinchGestureRecognizer.h:
* UIProcess/qt/QtTouchViewInterface.cpp: Removed.
* UIProcess/qt/QtTouchViewInterface.h: Removed.
* UIProcess/qt/QtViewInterface.cpp: Added.
(WebKit::QtViewInterface::QtViewInterface):
(WebKit::QtViewInterface::didFindZoomableArea):
(WebKit::QtViewInterface::sceneGraphUpdateQueue):
(WebKit::QtViewInterface::setViewNeedsDisplay):
(WebKit::QtViewInterface::drawingAreaSize):
(WebKit::QtViewInterface::contentSizeChanged):
(WebKit::QtViewInterface::scrollPositionRequested):
(WebKit::QtViewInterface::isActive):
(WebKit::QtViewInterface::hasFocus):
(WebKit::QtViewInterface::isVisible):
(WebKit::QtViewInterface::startDrag):
(WebKit::QtViewInterface::didChangeViewportProperties):
(WebKit::QtViewInterface::didChangeUrl):
(WebKit::QtViewInterface::didChangeTitle):
(WebKit::QtViewInterface::didChangeToolTip):
(WebKit::QtViewInterface::didChangeStatusText):
(WebKit::QtViewInterface::didChangeCursor):
(WebKit::QtViewInterface::loadDidBegin):
(WebKit::QtViewInterface::loadDidCommit):
(WebKit::QtViewInterface::loadDidSucceed):
(WebKit::QtViewInterface::loadDidFail):
(WebKit::QtViewInterface::didChangeLoadProgress):
(WebKit::QtViewInterface::didMouseMoveOverElement):
(WebKit::QtViewInterface::showContextMenu):
(WebKit::QtViewInterface::hideContextMenu):
(WebKit::QtViewInterface::runJavaScriptAlert):
(WebKit::QtViewInterface::runJavaScriptConfirm):
(WebKit::QtViewInterface::runJavaScriptPrompt):
(WebKit::QtViewInterface::processDidCrash):
(WebKit::QtViewInterface::didRelaunchProcess):
(WebKit::QtViewInterface::engine):
(WebKit::QtViewInterface::downloadRequested):
(WebKit::QtViewInterface::chooseFiles):
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::setViewportInteractionEngine):
* UIProcess/qt/TiledDrawingAreaProxyQt.cpp:
* WebKit2.pri:

Tools:

Make MiniBrowser and WebKitTestRunner work again after the
merge.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webView):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
* MiniBrowser/qt/main.cpp:
* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/DesktopView.qml: Removed.
* MiniBrowser/qt/qml/TouchView.qml: Removed.
* WebKitTestRunner/PlatformWebView.h:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Scroll deltas are cleared during commit to the main thread
hclam@chromium.org [Thu, 10 Nov 2011 14:08:55 +0000 (14:08 +0000)]
[chromium] Scroll deltas are cleared during commit to the main thread
https://bugs.webkit.org/show_bug.cgi?id=71916

Reviewed by James Robinson.

Source/WebCore:

The patch keeps the scroll deltas and scroll position unchanged when
committing to the main thread. After commit has completed on the main
thread the submitted scroll deltas are then subtracted from the current
scroll deltas on the impl thread.

Doing so allow scroll deltas to be available at all time which enables
proper positioning for layers that are fixed-positioned to the
container layer.

This patch is tested by the following unit tests:
- CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
  This test is modified to verify that scroll deltas and scroll position
  are unchanged during commit. And then after commit scroll deltas are
  subtracted correctly.

- CCLayerTreeHostTestScrollSimple.runMultiThread and
  CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
  These tests verifies that scroll deltas made on impl thread are
  committed to the main thread. The scroll deltas is eventually delegated
  to CCLayerTreeHostClient. When commit has completed the scroll deltas
  are subtracted correctly. There's no change to these two tests but they
  verify this patch maintains the overall behavior of scrolling.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::applyScrollAndScale):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::applyScrollAndScaleInternal):
(WebCore::CCLayerTreeHostCommon::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::TEST_F):
CCLayerTreeHostImplTest.scrollDeltaRepeatedScrolls
This test is modified to verify that CCLayerTreeHostImpl::processScrollDeltas()
maintain the current scroll deltas and scroll positions.
It also verifies that scroll deltas are subtracted correctly by calling
CCLayerTreeHostCommon::applyScrollAndScale().
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::doBeginTest):
call setLayerTreeHost() on the root layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Change semantics of the haveQt() function to match API promises
vestbo@webkit.org [Thu, 10 Nov 2011 13:59:58 +0000 (13:59 +0000)]
[Qt] Change semantics of the haveQt() function to match API promises

Having Qt 5 does not imply that we have Qt 4, from an API point of
view, as a major version can in theory break BC/SC. Our minimum
version of Qt 4 will always be the latest released version of Qt 4,
so the only place we should use haveQt(4, x) is when checking for
the minimum requirements.

Reviewed-by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Thu, 10 Nov 2011 13:59:12 +0000 (13:59 +0000)]
Unreviewed. Fix make distcheck build.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing files.

Source/WebCore:

* GNUmakefile.am: Add missing files.
* GNUmakefile.list.am: Ditto.

Source/WebKit2:

* GNUmakefile.am: Fix typos in gtk-doc files and scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed trivial fix after r99721.
ossy@webkit.org [Thu, 10 Nov 2011 13:26:02 +0000 (13:26 +0000)]
[Qt] Unreviewed trivial fix after r99721.

* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect editing/spelling/markers.html expecations
tonyg@chromium.org [Thu, 10 Nov 2011 12:57:01 +0000 (12:57 +0000)]
Correct editing/spelling/markers.html expecations
https://bugs.webkit.org/show_bug.cgi?id=72015

This test was added in http://trac.webkit.org/changeset/99814 with no expectations so
it needs to be marked MISSING instead of FAIL.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward funct...
sergio@webkit.org [Thu, 10 Nov 2011 12:38:39 +0000 (12:38 +0000)]
[WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=69411

Reviewed by Martin Robinson.

Tools:

* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
use the EventSender instead of WebProcess Event Simulation.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::WTREventQueueItem::WTREventQueueItem):
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::getMouseButtonModifiers):
(WTR::eventSenderButtonToGDKButton):
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::replaySavedEvents):
(WTR::EventSenderProxy::sendOrQueueEvent):
(WTR::webkitModifiersToGDKModifiers):
(WTR::getGDKKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::leapForward):

LayoutTests:

Unskip tests that were previously failing due to the lack of
MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward. Also
moved around some other tests to their proper section.

* platform/gtk-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 12:26:32 +0000 (12:26 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Deploy SVGLengthContext in more places
        https://bugs.webkit.org/show_bug.cgi?id=72012

        Reviewed by Simon Hausmann.

        Doesn't affect any tests.

        * svg/SVGAnimatedLength.cpp:
        (WebCore::SVGAnimatedLengthAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedLengthAnimator::calculateDistance):
        * svg/SVGAnimatedLengthList.cpp:
        (WebCore::SVGAnimatedLengthListAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedLengthListAnimator::calculateAnimatedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Mac build fix: Remove TapAndHold gesture type.
hausmann@webkit.org [Thu, 10 Nov 2011 12:23:01 +0000 (12:23 +0000)]
Unreviewed Mac build fix: Remove TapAndHold gesture type.

It broke the build because it's unhandled. Remove it since it's not
supported at the moment anyway. (looks like an accidental addition?)

* Shared/WebEvent.h:
* UIProcess/qt/QtTapGestureRecognizer.cpp:
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 11:43:20 +0000 (11:43 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix build.

        * WebCore.gypi: Need to add rendering/svg/SVGPathData.* in another place as well, cr-bots are not compiling it and thus fail linking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)
yutak@chromium.org [Thu, 10 Nov 2011 11:42:16 +0000 (11:42 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 6)

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/embedding-external-svgs-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/svg-as-background-5-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png.
* platform/chromium-mac-snowleopard/svg/custom/embedding-external-svgs-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/custom/embedding-external-svgs-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/qt: [Qt] Enable exports and constructor functions in static libs
hausmann@webkit.org [Thu, 10 Nov 2011 11:41:15 +0000 (11:41 +0000)]
Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 10 Nov 2011 11:17:52 +0000 (11:17 +0000)]
2011-11-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Remove virtual toPathData() method from all graphics elements
        https://bugs.webkit.org/show_bug.cgi?id=72009

        Reviewed by Zoltan Herczeg.

        In bug 71780, SVGLengthContext was introduced, to allow to resolve SVGLengths against arbitary viewports.
        SVGLength::value(), which needs a SVGLengthContext, is still used all over svg/ - that should be changed, as rendering/
        should resolve these lengths, as HTML does it using Length & RenderStyles for CSS.

        As first step, move the #1 client of the SVGLength::value() methods - toPathData() out of svg/ into rendering/svg/SVGPathData
        as free-function, replacing the virtual toPathData() function from SVGStyledTransformableElement.

        Doesn't affect any tests.

        * CMakeLists.txt: Add rendering/svg/SVGPathData.* to build.
        * GNUmakefile.list.am: Ditto.
        * Target.pri: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * rendering/svg/RenderSVGAllInOne.cpp: Ditto.
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::layout): Use "updatePathFromGraphicsElement(element, m_path)" instead of "element->toPathData(m_path)", avoiding a virtual call.
        * rendering/svg/RenderSVGTextPath.cpp:
        (WebCore::RenderSVGTextPath::layoutPath): Ditto.
        * rendering/svg/SVGPathData.cpp: Added.
        (WebCore::updatePathFromCircleElement):
        (WebCore::updatePathFromEllipseElement):
        (WebCore::updatePathFromLineElement):
        (WebCore::updatePathFromPathElement):
        (WebCore::updatePathFromPolygonElement):
        (WebCore::updatePathFromPolylineElement):
        (WebCore::updatePathFromRectElement):
        (WebCore::updatePathFromGraphicsElement):
        * rendering/svg/SVGPathData.h: Added.
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::animationPath): Use updatePathFromGraphicsElement instead of toPathData.
        * svg/SVGCircleElement.cpp: Remove toPathData() virtual method.
        * svg/SVGCircleElement.h: Ditto.
        * svg/SVGEllipseElement.cpp: Ditto.
        * svg/SVGEllipseElement.h: Ditto.
        * svg/SVGLineElement.cpp: Ditto.
        * svg/SVGLineElement.h: Ditto.
        * svg/SVGPathElement.cpp: Ditto.
        * svg/SVGPathElement.h: Ditto.
        * svg/SVGPolygonElement.cpp: Ditto.
        * svg/SVGPolygonElement.h: Ditto.
        * svg/SVGPolylineElement.cpp: Ditto.
        * svg/SVGPolylineElement.h: Ditto.
        * svg/SVGRectElement.cpp: Ditto.
        * svg/SVGRectElement.h: Ditto.
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::toClipPath): Use updatePathFromGraphicsElement instead of toPathData.
        * svg/SVGStyledTransformableElement.h: Remove toPathData() virtual method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Make sure headers.pri has the right relative paths for install
vestbo@webkit.org [Thu, 10 Nov 2011 11:11:06 +0000 (11:11 +0000)]
[Qt] Make sure headers.pri has the right relative paths for install

The install rules are generated from api.pri which lives in Source,
which means the paths in headers.pri, which is the basis for the
install rules, needs to be relative to Source as well.

We were also installing the headers from the forwarding headers
directory, which was wrong, as those headers contained relative paths.

We now install the actual headers, by using headers.pri as a basis.

https://bugs.webkit.org/show_bug.cgi?id=71697

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Add Tap Gesture recognition to UIProcess
zeno.albisser@nokia.com [Thu, 10 Nov 2011 10:46:15 +0000 (10:46 +0000)]
[Qt][WK2] Add Tap Gesture recognition to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=71841

Add a Tap gesture recognizer that delivers GestureSingleTap
and GestureTapAndHold events through the WebPageProxy.
Add a GestureTapAndHold to WebEvent.
Add a DoubleTap gesture for zooming in and out.

This patch is based on work of Benjamin Poulain.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-11-10
Reviewed by Kenneth Rohde Christiansen.

* Shared/WebEvent.h:
* Target.pri:
* UIProcess/qt/QtTapGestureRecognizer.cpp: Added.
(WebKit::QtTapGestureRecognizer::QtTapGestureRecognizer):
(WebKit::QtTapGestureRecognizer::setWebPageProxy):
(WebKit::QtTapGestureRecognizer::recognize):
(WebKit::QtTapGestureRecognizer::tapTimeout):
(WebKit::QtTapGestureRecognizer::tapAndHoldTimeout):
(WebKit::QtTapGestureRecognizer::reset):
(WebKit::QtTapGestureRecognizer::timerEvent):
* UIProcess/qt/QtTapGestureRecognizer.h: Added.
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::processDidCrash):
(QtWebPageProxy::doneWithTouchEvent):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)
yutak@chromium.org [Thu, 10 Nov 2011 10:41:05 +0000 (10:41 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 5)

* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/animated-svg-as-mask-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/as-background-image/animated-svg-as-background-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-linux/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/animated-svg-as-background-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
* platform/chromium-win/svg/as-background-image/animated-svg-as-background-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
caseq@chromium.org [Thu, 10 Nov 2011 10:09:33 +0000 (10:09 +0000)]
Web Inspector: [refactoring] get rid of JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71922

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.suggestedFileName):
(WebInspector.JavaScriptSourceFrame.prototype._onContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype.setReadOnly):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.activateBreakpoints):
(WebInspector.ScriptsPanel.prototype.folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.ScriptsPanel.prototype.addToWatch):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
zherczeg@webkit.org [Thu, 10 Nov 2011 10:03:56 +0000 (10:03 +0000)]
Unreviewed gardening.

* fast/harness/results-expected.txt: Update after r99818.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)
yutak@chromium.org [Thu, 10 Nov 2011 09:46:16 +0000 (09:46 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 4)

* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/backgrounds/svg-as-mask-expected.png.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
* platform/chromium-cg-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/svg-as-mask-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/svg-as-mask-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix progress load reporting for MHTML documents.
jcivelli@chromium.org [Thu, 10 Nov 2011 09:39:42 +0000 (09:39 +0000)]
Fix progress load reporting for MHTML documents.

MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859

Reviewed by Adam Barth.

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
(WebKit::TEST_F):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
* tests/data/page_with_image.mht: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix linking with --whole-archive
hausmann@webkit.org [Thu, 10 Nov 2011 09:37:22 +0000 (09:37 +0000)]
[Qt] Fix linking with --whole-archive

Reviewed by Zoltan Herczeg.

Compile XMLTreeViewer and related files when XSLT is enabled, not
when XSLT _and_ USE_LIBXML2. The files do not depend on libxml2, they
are #ifdeffed with ENABLE(XSLT) only, and they are referenced from for
example NewXMLDocumentParser.cpp from within XSLT blocks.

* DerivedSources.pri:
* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)
yutak@chromium.org [Thu, 10 Nov 2011 09:22:04 +0000 (09:22 +0000)]
[Chromium] Unreviewed, rebaseline SVG test results changed after r99539. (part 3)

* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-cg-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png: Removed.
* platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99824 268f45cc-cd09-0410-ab3c-d52691b4dbfc