abarth@webkit.org [Thu, 7 Apr 2011 20:51:22 +0000 (20:51 +0000)]
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement CSP's options directive
https://bugs.webkit.org/show_bug.cgi?id=58014
* http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added.
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement CSP's options directive
https://bugs.webkit.org/show_bug.cgi?id=58014
This patch contains the full options parser, but we only have enough of
CSP implemented to see the effects of disable-xss-protection. Will
need to do some more work before we can see eval-script in action.
Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html
http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPOptions::CSPOptions):
(WebCore::CSPOptions::disableXSSProtection):
(WebCore::CSPOptions::evalScript):
(WebCore::CSPOptions::parse):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 7 Apr 2011 20:48:10 +0000 (20:48 +0000)]
Reviewed by Anders Carlsson.
REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
https://bugs.webkit.org/show_bug.cgi?id=58066
<rdar://problem/8965302>
* Scripts/webkit2/messages.py:
* Shared/mac/AttributedString.h: Added.
* Shared/mac/AttributedString.mm: Added.
(WebKit::AttributedString::encode):
(WebKit::AttributedString::decode):
Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF
or NS object to another process without wrapping it in a C++ one.
* Shared/mac/ArgumentCodersMac.h: Added.
* Shared/mac/ArgumentCodersMac.mm: Added.
Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why
these are needed:
1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't
work properly for them (I've been just getting 1).
2) NSColor isn't toll free bridged to CF.
This adds just the types necessary for editing NSAttributedString (and I don't yet know what
happens with attachments).
* UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getAttributedSubstringFromRange):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Boilerplate code for making a sync call to web process.
* WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange):
Ported from WebHTMLView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 7 Apr 2011 20:40:30 +0000 (20:40 +0000)]
Unreviewed.
Adding to skipped list for Windows (WK2) the
tests relative to undo removed from the skipped list
for Mac where execCommand('undo') is now supported.
* platform/win-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 7 Apr 2011 20:36:37 +0000 (20:36 +0000)]
2011-04-07 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline progress element tests.
* platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
* platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
* platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
* platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 7 Apr 2011 20:23:48 +0000 (20:23 +0000)]
2011-04-07 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
https://bugs.webkit.org/show_bug.cgi?id=57794
* WebKit.xcodeproj/project.pbxproj:
2011-04-07 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
https://bugs.webkit.org/show_bug.cgi?id=57794
Outlook populates a reply message by creating an empty WebView and
using DOM API to populate the WebView's empty document with content
from the original message. It expects the initial empty document to
simply be "<html></html>", and it proceeds to dynamically create and
append a BODY node and add the original message content as a child of
that node. Outlook then takes the innerHTML of the frame's first body
element and copies it into a *new* document that is displayed and
edited in the reply message window.
Due to implementing the HTML5 tree building algorithm in r64712,
initial empty documents went from being "<html></html>" to being
"<html><head></head><body></body></html>". Outlook still dynamically
creates a BODY node to parent the original message content, but this
BODY node duplicates the one created by the tree builder. When Outlook
then takes the innerHTML of the first body element to populate the
reply message window it gets the empty body element created by the
parser, not the one it created with the original message content.
Fix this by injecting a user script into the initial empty document
that removes the HEAD and BODY nodes created by the parser. This
ensures that the BODY created by Outlook is the only BODY in the
document.
* Misc/OutlookQuirksUserScript.js: Added.
* WebView/WebView.mm:
(leakMailQuirksUserScriptContents):
(-[WebView _injectMailQuirksScript]):
(needsOutlookQuirksScript):
(leakOutlookQuirksUserScriptContents):
(-[WebView _injectOutlookQuirksScript]):
(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2011-04-07 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r64712): Microsoft Outlook 2011: original message contents
not included when replying to an email.
https://bugs.webkit.org/show_bug.cgi?id=57794
* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts()
before checking if the FrameLoader is parsing the initial empty document.
This allows user scripts to be injected at the end of document parsing
(if the setting is enabled).
* page/Frame.cpp:
(WebCore::Frame::injectUserScripts): Do not inject scripts if this
feature is disabled on the initial empty document.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h: Add a setting for injecting user scripts into the
initial empty document (defaults to false).
(WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument):
(WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
* platform/mac/RuntimeApplicationChecks.h:
* platform/mac/RuntimeApplicationChecks.mm:
(WebCore::applicationIsMicrosoftOutlook): Check if the embedding
application is Microsoft Outlook.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Thu, 7 Apr 2011 20:18:44 +0000 (20:18 +0000)]
Mac build fix.
* Shared/WebString.h:
(WebKit::WebString::getCharacters): Add explict cast when using std::min().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 7 Apr 2011 20:09:33 +0000 (20:09 +0000)]
Unreviewed; rebaseline expected results in platform/mac-wk2.
* platform/mac-wk2/media/controls-without-preload-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Thu, 7 Apr 2011 19:49:22 +0000 (19:49 +0000)]
2011-04-07 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
https://bugs.webkit.org/show_bug.cgi?id=58058
* TestWebKitAPI/Tests/WebKit2/WKString.cpp:
(TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().
2011-04-07 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
https://bugs.webkit.org/show_bug.cgi?id=58058
WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.
* Shared/API/c/WKString.cpp:
(WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
* Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
* Shared/WebString.h:
(WebKit::WebString::getCharacters): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 7 Apr 2011 19:42:26 +0000 (19:42 +0000)]
WebKit2: Support window bounce when panning.
https://bugs.webkit.org/show_bug.cgi?id=58065
<rdar://problem/9244367>
Reviewed by Adam Roben.
Make gestureDidScroll synchronous, as once we scroll, we need to know
whether or not we are at the beginning or end of the scrollable document.
If we are at either end of the scrollable document, we call the Windows 7
API to bounce the window to give an indication that you are past an end
of the document.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Inititalize a new variable.
(WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to
an end of the document, and if we have, bounce the window.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical
scrollbar and if we are at the beginning or the end of the scrollable document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 7 Apr 2011 19:30:37 +0000 (19:30 +0000)]
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
https://bugs.webkit.org/show_bug.cgi?id=57962
Add support for a new AVPlayerItem API which will notify clients when their
seek completes. This requires a new Notification type to be passed to the main
thread in MediaPlayerPrivateAVFoundation.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added.
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new
overloaded functions which take a Notification; and a Notification::Type and boolean.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted
Notification type.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor.
(WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API.
(-[WebCoreAVFMovieObserver seekCompleted:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 19:17:41 +0000 (19:17 +0000)]
2011-04-07 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.isPageBoxVisible
https://bugs.webkit.org/show_bug.cgi?id=42695
Unskip passed tests.
* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
2011-04-07 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.isPageBoxVisible
https://bugs.webkit.org/show_bug.cgi?id=42695
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleIsPageBoxVisible):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::isPageBoxVisible):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-07 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.isPageBoxVisible
https://bugs.webkit.org/show_bug.cgi?id=42695
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::isPageBoxVisible):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 7 Apr 2011 18:56:44 +0000 (18:56 +0000)]
Source/WebKit2: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>
Reviewed by Oliver Hunt.
Adding support for execCommand('undo') and execCommand('redo')
in WebKit2 for Mac.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
(WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.
Added new empty PageClient methods for other platforms.
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::canUndoRedo):
(QWKPagePrivate::executeUndoRedo):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/gtk/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
* UIProcess/gtk/WebView.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
* UIProcess/win/WebView.h:
* UIProcess/WebEditCommandProxy.cpp:
(WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
of asychronous messages while waiting for a sync message reply.
(WebKit::WebEditCommandProxy::reapply): Same as above.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.
(WebKit::WebEditorClient::canUndo):
(WebKit::WebEditorClient::canRedo):
(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):
LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
https://bugs.webkit.org/show_bug.cgi?id=58055
<rdar://problem/8862023>
Reviewed by Oliver Hunt.
* platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 7 Apr 2011 18:54:22 +0000 (18:54 +0000)]
<rdar://problem/9250368> and https://bugs.webkit.org/show_bug.cgi?id=58062
Reviewed by Maciej Stachowiak.
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseClose):
* UIProcess/API/C/WKIconDatabase.h:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::close):
* UIProcess/WebIconDatabase.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 7 Apr 2011 18:51:13 +0000 (18:51 +0000)]
Bug 58057 - Store boolean payload in low bit of JSImmediate
Reviewed by Geoff Garen.
And remove some uncalled functions from JSImmediate.h
* jit/JITInlineMethods.h:
(JSC::JIT::emitTagAsBoolImmediate):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_not):
* runtime/JSImmediate.h:
(JSC::JSImmediate::makeInt):
(JSC::JSImmediate::makeBool):
(JSC::JSImmediate::intValue):
(JSC::JSImmediate::boolValue):
(JSC::JSImmediate::asInt32):
(JSC::JSImmediate::toDouble):
(JSC::JSValue::asInt32):
(JSC::JSValue::isUInt32):
(JSC::JSValue::asUInt32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 18:46:23 +0000 (18:46 +0000)]
2011-04-07 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Eric Carlson.
Add tests for parsing codecs parameter in video-can-play-type.html
https://bugs.webkit.org/show_bug.cgi?id=53275
* media/video-can-play-type-expected.txt:
* media/video-can-play-type.html:
2011-04-07 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Eric Carlson.
Parse quotes from content type parameters
https://bugs.webkit.org/show_bug.cgi?id=53275
This functionality is tested in video-can-play-type.html layout test
where I've added codecs parameter with good and bad formatting.
* platform/ContentType.cpp:
(WebCore::ContentType::parameter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 18:24:52 +0000 (18:24 +0000)]
2011-04-07 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: remove "enabled" from the setBreakpoint protocol.
https://bugs.webkit.org/show_bug.cgi?id=58047
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::hasBreakpoint):
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
(WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings):
(WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._reset):
(WebInspector.PresentationBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 7 Apr 2011 18:08:42 +0000 (18:08 +0000)]
[WebKit2 Tests] fast/events/select-element.html failing since introduction in r83096
https://bugs.webkit.org/show_bug.cgi?id=58059
Adding this test to the mac-wk2 skipped list to get the bots green.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 7 Apr 2011 18:01:19 +0000 (18:01 +0000)]
WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862
Reviewed by Adam Roben.
Part 3: Implement checkSpellingOfString
In WebCore, checkTextOfParagraph is only defined and used on platforms where
WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
Mac builds).
On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
patch in an attempt to keep things easier to review) are used.
* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/TextChecker.h:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING).
(WebKit::WebPageProxy::checkSpellingOfString):
Call through to the client.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
checkSpellingOfString.
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Call through to the WebTextCheckerClient.
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
(WebKit::TextChecker::checkSpellingOfString):
Add a call to notImplemented.
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto, and remove the implementation for checkTextOfParagraph.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::checkSpellingOfString):
Ditto.
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
* UIProcess/win/WebTextCheckerClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::checkSpellingOfString):
Send a sync message to the UI Process (similar to the sync message used for
checkTextOfParagraph).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 7 Apr 2011 18:00:35 +0000 (18:00 +0000)]
2011-04-07 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 7 Apr 2011 17:58:00 +0000 (17:58 +0000)]
Update Leopard expected results after r83075 to greenify the bots.
* platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 7 Apr 2011 17:44:31 +0000 (17:44 +0000)]
2011-04-06 Gustavo Noronha Silva <gns@gnome.org>
Reviewed by Martin Robinson.
[GTK] Need a way to get the path to a WebKitWebPlugin
https://bugs.webkit.org/show_bug.cgi?id=57968
Expose the path of the plugin through the WebKitWebPlugin object.
* webkit/webkitwebplugin.cpp:
(webkit_web_plugin_get_path):
* webkit/webkitwebplugin.h:
* webkit/webkitwebpluginprivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 17:41:13 +0000 (17:41 +0000)]
2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Reviewed by Benjamin Poulain.
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
https://bugs.webkit.org/show_bug.cgi?id=32723
When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
use an invalid URL (the begin() without arguments). Clearing the document
with the same URL was causing problems when we had a fragment because it assume that
only scrolling was enough and did not loaded the document again.
When setUrl() is called but fails, url() is expected to return the requested value. The
begin(url) guaranteed that before. This patch adds a member to track the URL, which is
updated when the URL changes and also when setUrl() is called.
KURL was used for the member so that when setUrl() is called, and then url() is checked
before the page gets loaded, we perform the same conversion that will be performed by a
successful load, e.g. add trailing '/' to an address. This behavior is checked by
tst_QWebFrame::requestedUrl() test.
For the record: the second QWebPage::setUrl() worked because the load was considered a
FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
* Api/qwebframe.cpp:
(QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
(clearCoreFrame):
(isCoreFrameClear):
(QWebFrame::setUrl):
(QWebFrame::url):
(QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
the baseURL, e.g. by using the <base> tag.
* Api/qwebframe_p.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
* tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setUrlWithFragment): unskip test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 7 Apr 2011 17:32:28 +0000 (17:32 +0000)]
2011-04-07 Adrienne Walker <enne@google.com>
[chromium] Unreviewed, rebaseline tests changed in r82947.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/chromium-linux/svg/text/text-midpoint-split-bug-expected.png: Added.
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/chromium-win/svg/text/text-midpoint-split-bug-expected.png: Added.
* platform/chromium-win/svg/text/text-midpoint-split-bug-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Thu, 7 Apr 2011 17:29:17 +0000 (17:29 +0000)]
2011-04-07 Vincent Scheib <scheib@chromium.org>
Flagging platform/chromium/compositing/huge-layer-rotated.html a bug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 7 Apr 2011 17:03:43 +0000 (17:03 +0000)]
2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=58037
Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test.
* editing/inserting/6633727-expected.txt: Removed.
* editing/inserting/6633727.html: Removed.
* editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added.
* editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html.
* editing/inserting/script-tests/6633727.js: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 7 Apr 2011 16:48:50 +0000 (16:48 +0000)]
Removed a redundant line of code.
Reviewed by Adam Roben.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as
this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 16:41:30 +0000 (16:41 +0000)]
2011-04-07 Liang Qi <liang.qi@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Enable webkit build with GCCE on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=57841
* wtf/MathExtras.h: GCCE compiler doesn't support those std static functions.
2011-04-07 Liang Qi <liang.qi@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Enable webkit build with GCCE on Symbian.
https://bugs.webkit.org/show_bug.cgi?id=57841
* WebCore.pri: Thanks for Norbert Leser <norbert.leser@nokia.com> who checked RVCT part.
--rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated
to 0x1000000 together. They need to be updated in the future when WebKit grows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 16:37:12 +0000 (16:37 +0000)]
2011-04-07 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available.
https://bugs.webkit.org/show_bug.cgi?id=57877
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::socketpair): socketpair() which returns -1
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Thu, 7 Apr 2011 16:08:06 +0000 (16:08 +0000)]
2011-04-07 Michael Saboff <msaboff@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Memory leak in decodeResourceError
https://bugs.webkit.org/show_bug.cgi?id=58004
Release the local NSError after it is used to create a ResourceError
object assigned to the reference argument.
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::decodeResourceError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 15:47:30 +0000 (15:47 +0000)]
2011-04-06 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: get rid of Breakpoint.js.
https://bugs.webkit.org/show_bug.cgi?id=57949
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/Breakpoint.js: Removed.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._debuggerWasDisabled):
(WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype.removeBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
(WebInspector.DebuggerModel.prototype.reset):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._reset):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresentationBreakpoint.prototype.get sourceFile):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.get resolved):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onResourceStarted):
(WebInspector.ResourceTreeModel.prototype._addResourceToFrame):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._breakpointUpdated):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 7 Apr 2011 15:42:53 +0000 (15:42 +0000)]
2011-04-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages names should adhere to the common naming style
https://bugs.webkit.org/show_bug.cgi?id=58042
* inspector/protocol/console-agent-expected.txt:
2011-04-07 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: console messages names should adhere to the common naming style
https://bugs.webkit.org/show_bug.cgi?id=58042
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/Inspector.json:
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared):
(WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 7 Apr 2011 15:19:15 +0000 (15:19 +0000)]
Build fix
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 7 Apr 2011 14:21:16 +0000 (14:21 +0000)]
2011-04-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip a fast/xmlhttprequest test passing on GTK.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 7 Apr 2011 14:20:33 +0000 (14:20 +0000)]
[Qt][WK2] Add always failing tets to the Skipped list.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 7 Apr 2011 14:16:56 +0000 (14:16 +0000)]
2011-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
https://bugs.webkit.org/show_bug.cgi?id=57957
There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.
the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method // for events
3) domain + '.' + command => method // for requests
4) requestId => id // for responses
5) arguments => params // for requests
6) data => params // for events
7) body => result // for responses
protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.
* inspector/protocol/console-agent-expected.txt:
* inspector/protocol/runtime-agent-expected.txt:
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
2011-04-06 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate Inspector protocol messages format to JSON-RPC.
https://bugs.webkit.org/show_bug.cgi?id=57957
There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec.
Also JSON-RPC has a pretty clear specification for error descriptions which we haven't.
It was decided that we will use it.
the list of renames:
1) type-> /dev/null
2) domain + '.' + event => method // for events
3) domain + '.' + command => method // for requests
4) requestId => id // for responses
5) arguments => params // for requests
6) data => params // for events
7) body => result // for responses
protocolErrors and error properties will be converted to JSON-RPC error format.
The order of properties in messages also will be adjusted.
The only thing that looks unnecessary is jsonrpc property.
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 7 Apr 2011 14:16:41 +0000 (14:16 +0000)]
Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
(Unfortunately the buildbot documentation does not make this clear.) finished() is the only
hook we have, so we have to do our work there. I added a new addCustomURLs method which can
be overridden by subclasses to provide extra URLs before we call up to the base class (after
which adding more URLs is no longer possible).
Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
bot results page
Reviewed by John Sullivan.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
(ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
method is never called for MasterShellCommands.
(ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
with this method (which is).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 13:36:53 +0000 (13:36 +0000)]
2011-04-07 Pavel Feldman <pfeldman@google.com>
Not reviewed: rolling chromium DEPS 80421:80767.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 7 Apr 2011 13:36:08 +0000 (13:36 +0000)]
Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
This matches how most of our other build steps work, so is good just for improving
consistency between build steps. It should also make it possible for
ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
trying to do this in finished() after we had called up to the base class, but that was
apparently too late to add more URLs.)
Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
results page
Reviewed by John Sullivan.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults): Added a descriptionDone property so that we don't have to manually
call setText to get the right text to show up for this step. This matches how most of our
other build steps work.
(ExtractTestResults.commandComplete): Replaced our override of finished with this function.
This is how most of our other build steps work.
(ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
function, to match the base class.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 13:25:37 +0000 (13:25 +0000)]
2011-04-07 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support.
https://bugs.webkit.org/show_bug.cgi?id=58036
Renamed didReceiveData2 to didReceiveData.
* public/WebURLLoaderClient.h:
(WebKit::WebURLLoaderClient::didReceiveData):
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 13:11:18 +0000 (13:11 +0000)]
2011-04-07 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support.
https://bugs.webkit.org/show_bug.cgi?id=58034
Migrated didReceiveData to support new lengthReceived parameter.
* src/AssociatedURLLoader.cpp:
(WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 7 Apr 2011 13:05:35 +0000 (13:05 +0000)]
2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Add functions to update left and right offsets to LineOffsets
https://bugs.webkit.org/show_bug.cgi?id=58028
Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets,
which are used to update m_left and m_right. Also added m_block and m_isFirstLine
member variables to LineOffsets so that users of LineOffsets don't have to pass them around.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine.
(WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets.
(WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine.
(WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine.
(WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
(WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and
no longer passes firstLine around.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 7 Apr 2011 12:50:08 +0000 (12:50 +0000)]
2011-04-06 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: migrate debugger domain to the unified breakpoint location notion.
https://bugs.webkit.org/show_bug.cgi?id=57928
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::buildObjectForBreakpointCookie):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.prototype._breakpointResolved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 12:44:20 +0000 (12:44 +0000)]
2011-04-07 Kent Tamura <tkent@chromium.org>
[Chromium] Move Leopard-specific images to chromium-mac-leopard, and
unify text results common in chromium-mac.
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
* platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Thu, 7 Apr 2011 12:37:18 +0000 (12:37 +0000)]
2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Build fix when using Phonon as a backend for the multimedia support.
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
* WebCoreSupport/ChromeClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 7 Apr 2011 11:07:56 +0000 (11:07 +0000)]
2011-04-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Convert insert-div-021.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=58019
Converted the test.
* editing/inserting/insert-div-021-expected.txt: Added.
* editing/inserting/insert-div-021.html:
* platform/chromium-linux/editing/inserting/insert-div-021-expected.checksum: Removed.
* platform/chromium-linux/editing/inserting/insert-div-021-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-div-021-expected.checksum: Removed.
* platform/chromium-win/editing/inserting/insert-div-021-expected.png: Removed.
* platform/chromium-win/editing/inserting/insert-div-021-expected.txt: Removed.
* platform/gtk/editing/inserting/insert-div-021-expected.checksum: Removed.
* platform/gtk/editing/inserting/insert-div-021-expected.png: Removed.
* platform/gtk/editing/inserting/insert-div-021-expected.txt: Removed.
* platform/mac/editing/inserting/insert-div-021-expected.checksum: Removed.
* platform/mac/editing/inserting/insert-div-021-expected.png: Removed.
* platform/mac/editing/inserting/insert-div-021-expected.txt: Removed.
* platform/qt/editing/inserting/insert-div-021-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 7 Apr 2011 11:06:22 +0000 (11:06 +0000)]
2011-04-07 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Benjamin Poulain.
[Qt] Mask the QStyle::State_Horizontal hint for vertical scrollbars.
When initializing a QStyleOptionSlider from a widget, the State_Horizontal
hint may get set depending on how that widget is laid out in its parent.
If this happens when drawing a vertical scrollbar, the hint is never
cleared and we end up painting a vertical scrollbar with horizontal arrows.
Covered by pixel tests which should no longer paint silly scrollbars.
* platform/qt/ScrollbarThemeQt.cpp:
(WebCore::styleOptionSlider):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 7 Apr 2011 10:04:22 +0000 (10:04 +0000)]
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
script-src should block inline script
https://bugs.webkit.org/show_bug.cgi?id=58012
Test that script-src blocks inline script. This test uses a different
approach than the existing tests for variety.
* http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/inline-script-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/resources/document-write-alert-fail.js: Added.
* http/tests/security/contentSecurityPolicy/resources/dump-as-text.js: Added.
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
script-src should block inline script
https://bugs.webkit.org/show_bug.cgi?id=58012
Block inline scripts at the ScriptElement layer. This should catch
exactly the scripts we want to catch.
Test: http/tests/security/contentSecurityPolicy/inline-script-blocked.html
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- This patch also adds the ability to supply a CSP policy via a
<meta> tag. We'll update the name of the header once we've
finished implementing the spec.
* dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowInlineScript):
* page/ContentSecurityPolicy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 7 Apr 2011 09:56:36 +0000 (09:56 +0000)]
2011-04-07 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
webkit-patch shouldn't state the whole working copy when calling check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=58022
Previously, we were ignoring the args variable! This patch fixes the
regression introduced in http://trac.webkit.org/changeset/82771.
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/mocktool.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 7 Apr 2011 09:53:46 +0000 (09:53 +0000)]
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
Remove temporary WebProcess sandbox rules that are unnecessary now that plugins are in their own process
https://bugs.webkit.org/show_bug.cgi?id=58023
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 09:50:05 +0000 (09:50 +0000)]
2011-04-07 Kent Tamura <tkent@chromium.org>
[Chromium] Update Linux x86-64 results for the Skia rounding rect change.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-linux-x86_64/fast/borders/borderRadiusRidge01-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 09:42:17 +0000 (09:42 +0000)]
2011-04-07 Kent Tamura <tkent@chromium.org>
Skip platform/mac/fast/forms/input-appearance-spinbutton-up.html on Mac WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=56298
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 09:24:44 +0000 (09:24 +0000)]
2011-04-07 Kent Tamura <tkent@chromium.org>
Update spinbutton test results for r83145.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Removed.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-visibility-expected.txt: Removed.
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-win/fast/forms/input-appearance-spinbutton-layer-expected.png: Added.
* platform/chromium-win/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 09:04:54 +0000 (09:04 +0000)]
2011-04-07 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=57921
Moves the MouseEventWithHitTestResults::targetNode() method on to EventHandler, so
that the same logic can be used for a HitTestResult.
No visible changes, just cleanup, so no tests.
* page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::subframeForHitTestResult):
Made public static member, so that it can access targetNode(), and be accessed by
webkitwebview in gtk.
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::targetNode):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::sendContextMenuEvent):
* page/EventHandler.h:
* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
* page/MouseEventWithHitTestResults.h:
* page/android/EventHandlerAndroid.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/brew/EventHandlerBrew.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/haiku/EventHandlerHaiku.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
* page/wx/EventHandlerWx.cpp:
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
2011-04-07 Alice Boxhall <aboxhall@chromium.org>
Reviewed by Ryosuke Niwa.
Move the MouseEventWithHitTestResults::targetNode() method on to EventHandler.
https://bugs.webkit.org/show_bug.cgi?id=57921
* webkit/webkitwebview.cpp:
(webkit_web_view_forward_context_menu_event):
Call subframeForHitTestResult rather than subframeForTargetNode as the targetNode()
method has moved on to EventHandler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 7 Apr 2011 08:40:16 +0000 (08:40 +0000)]
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Adam Barth.
REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
https://bugs.webkit.org/show_bug.cgi?id=58017
* Scripts/webkitpy/common/checkout/scm.py:
* Scripts/webkitpy/common/checkout/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Thu, 7 Apr 2011 08:39:45 +0000 (08:39 +0000)]
2011-04-07 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: build mapping for formatted scripts based on keywords positions.
https://bugs.webkit.org/show_bug.cgi?id=57936
Mapping based on [\$\.\w]+ was not accurate because string literals representation
may be different in original and formatted scripts.
* inspector/front-end/ScriptFormatterWorker.js:
(buildMapping.regexp.b):
(buildMapping):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 7 Apr 2011 08:30:43 +0000 (08:30 +0000)]
2011-04-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline after r83145. Also skip
fast/forms/input-number-large-padding.html which fails. See bug
58020.
* platform/gtk/Skipped:
* platform/gtk/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 7 Apr 2011 08:00:22 +0000 (08:00 +0000)]
2011-04-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK baselines for 4 new tests.
* platform/gtk/fast/history/visited-link-background-color-expected.checksum: Added.
* platform/gtk/fast/history/visited-link-background-color-expected.png: Added.
* platform/gtk/fast/history/visited-link-background-color-expected.txt: Added.
* platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
* platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
* platform/gtk/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.checksum: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/gtk/svg/text/text-midpoint-split-bug-expected.checksum: Added.
* platform/gtk/svg/text/text-midpoint-split-bug-expected.png: Added.
* platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Thu, 7 Apr 2011 07:39:24 +0000 (07:39 +0000)]
2011-04-07 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Remove some no longer needed WebProcess sandbox allowances
https://bugs.webkit.org/show_bug.cgi?id=58015
<rdar://problem/9232592>
* WebProcess/com.apple.WebProcess.sb: Remove no-longer needed extra network
and launching privileges, since the bugs that required them are fixed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 7 Apr 2011 07:25:51 +0000 (07:25 +0000)]
2011-04-07 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline after r83075.
* platform/gtk/fast/blockflow/text-orientation-basic-expected.txt:
* platform/gtk/fast/text/capitalize-empty-generated-string-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 07:13:02 +0000 (07:13 +0000)]
2011-04-07 Kent Tamura <tkent@chromium.org>
[Chromium] Fix a duplicated entry.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 07:03:22 +0000 (07:03 +0000)]
Spinbuttons become unclickable if right padding is large.
https://bugs.webkit.org/show_bug.cgi?id=56298
Reviewed by NOBODY (OOPS!).
Source/WebCore:
An inner-spin-button is put on the right border and ignores right
padding in RenderTextControlSingleLine::layout(), but forwardEvent()
checks if a point is in an area just right of an internal text block.
This inconsistency caused a bug that an inner-spin-button with large
padding didn't receive mouse events.
To fix this bug, we render spin buttons as layers, and remove manual
event forwarding code.
Test: fast/forms/input-number-large-padding.html
* css/html.css: Add "position:relative" to make a spin-button a layer.
(input::-webkit-inner-spin-button):
(input::-webkit-outer-spin-button):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::forwardEvent):
Remove manual event forwarding code.
LayoutTests:
Add a test, and skip on platforms which has no inner-spin-button implementation.
* fast/forms/input-number-large-padding-expected.txt: Added.
* fast/forms/input-number-large-padding.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
* platform/mac/fast/forms/input-appearance-spinbutton-visibility-expected.txt:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 05:58:08 +0000 (05:58 +0000)]
2011-04-06 Kent Tamura <tkent@chromium.org>
Fixed an error in the previous commit.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 05:46:43 +0000 (05:46 +0000)]
2011-04-06 Kent Tamura <tkent@chromium.org>
[Chromium] Update text expectation.
fast/repaint/scale-page-shrink.html is expected to fail because of no
eventSender.scalePageBy().
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 04:58:51 +0000 (04:58 +0000)]
2011-04-06 Kent Tamura <tkent@chromium.org>
[Chromium] Update test expectation.
xhr-breakpoints.html and detailed-heapshots-summary.html are flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 7 Apr 2011 04:43:50 +0000 (04:43 +0000)]
2011-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP object-src should block plugin loads
https://bugs.webkit.org/show_bug.cgi?id=57283
This change is pretty straight-forward. It's slighly unclear to me
whether this patch is correct w.r.t. the code in DocumentWriter. I've
added a FIXME comment, and I'll investigate that case more in the future.
Test: http/tests/security/contentSecurityPolicy/object-src-none.html
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:
2011-04-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
CSP object-src should block plugin loads
https://bugs.webkit.org/show_bug.cgi?id=57283
* http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/object-src-none.html: Added.
* http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 7 Apr 2011 04:39:55 +0000 (04:39 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58009
Frame::scalePage() results in visual artifacts with scale factors less than 1
-and corresponding-
<rdar://problem/8683230>
Reviewed by Dan Bernstein.
Source/WebCore:
Fall into the case where we fill with a background base color when there is a page
scale factor that is less than 1.
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
LayoutTests:
* fast/repaint/scale-page-shrink.html: Added.
* platform/gtk/Skipped:
* platform/mac/fast/repaint/scale-page-shrink-expected.checksum: Added.
* platform/mac/fast/repaint/scale-page-shrink-expected.png: Added.
* platform/mac/fast/repaint/scale-page-shrink-expected.txt: Added.
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 03:59:58 +0000 (03:59 +0000)]
2011-04-06 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984
Unskip passed tests.
* platform/mac-wk2/Skipped:
2011-04-06 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePageSizeAndMarginsInPixels):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::pageSizeAndMarginsInPixels):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
https://bugs.webkit.org/show_bug.cgi?id=57984
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::pageSizeAndMarginsInPixels):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 7 Apr 2011 03:55:19 +0000 (03:55 +0000)]
2011-04-06 Chris Rogers <crogers@google.com>
Reviewed by Tony Chang.
Add web audio support to DumpRenderTree (mac port)
https://bugs.webkit.org/show_bug.cgi?id=57969
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(setEncodedAudioDataCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpAsAudio):
(LayoutTestController::setDumpAsAudio):
(LayoutTestController::encodedAudioData):
(LayoutTestController::setEncodedAudioData):
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpAudio):
(dump):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Thu, 7 Apr 2011 03:49:53 +0000 (03:49 +0000)]
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086
* platform/qt/Skipped: Remove the skipped test which required numberOfPendingGeolocationPermissionRequests.
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086
Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
from the LayoutTestController.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
https://bugs.webkit.org/show_bug.cgi?id=56086
Add the missing method.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::numberOfPendingGeolocationPermissionRequests):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 7 Apr 2011 03:43:27 +0000 (03:43 +0000)]
2011-04-06 Kent Tamura <tkent@chromium.org>
[Chromium] Update expectations for Geeza Pro and so on.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 7 Apr 2011 03:34:04 +0000 (03:34 +0000)]
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
AVF: MediaPlayerPrivateAVFoundationObjC should not use -[AVPlayerItem isPlaybackBufferEmpty]
https://bugs.webkit.org/show_bug.cgi?id=57982
Query our cached loaded time array instead of asking AVPlayerItem if its buffer is empty.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 7 Apr 2011 03:31:55 +0000 (03:31 +0000)]
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
MediaPlayerPrivateAVFoundation does not change rate due to setRate().
https://bugs.webkit.org/show_bug.cgi?id=57919
* media/video-set-rate-from-pause-expected.txt: Added.
* media/video-set-rate-from-pause.html: Added.
2011-04-06 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
MediaPlayerPrivateAVFoundation does not change rate due to setRate().
https://bugs.webkit.org/show_bug.cgi?id=57919
Test: media/video-set-rate-from-pause.html
The base class of MediaPlayerPrivateAVFoundation does not actually change the rate
of the media; instead a subclass must do that work. So when setRate() is called,
inform a subclass through a new pure virtual updateRate() function that there's
work to be done.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setRate): Call updateRate()
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate): Added. Set the requested rate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Thu, 7 Apr 2011 03:24:59 +0000 (03:24 +0000)]
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* win/tools/vsprops/FeatureDefines.vsprops: Added QUOTA build flag
* win/tools/vsprops/FeatureDefinesCairo.vsprops: Added QUOTA build flag
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* configure.ac: Added QUOTA build flag
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Configurations/FeatureDefines.xcconfig: Added QUOTA build flag
* GNUmakefile.am: Added QUOTA build flag
* WebCore.pri: Added QUOTA build flag
2011-04-06 Dai Mikurube <dmikurube@chromium.org>
Reviewed by David Levin.
Add QUOTA build flag for unified quota API
https://bugs.webkit.org/show_bug.cgi?id=57918
* Scripts/build-webkit: Added QUOTA build flag
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 7 Apr 2011 03:06:54 +0000 (03:06 +0000)]
Correct results for the Geeza Pro metrics change.
* platform/mac/fast/dom/52776-expected.checksum:
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.checksum:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 7 Apr 2011 02:21:26 +0000 (02:21 +0000)]
2011-04-06 Adrienne Walker <enne@google.com>
Unreviewed, update Chromium expectations for failing test from r83075.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 7 Apr 2011 01:47:29 +0000 (01:47 +0000)]
2011-04-06 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
Adjust the apple webkit port's default timeout to match
old-run-webkit-tests at 35 seconds.
https://bugs.webkit.org/show_bug.cgi?id=37738
* Scripts/webkitpy/layout_tests/port/mac.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 01:37:24 +0000 (01:37 +0000)]
2011-04-06 Scott Cameron <sccameron@rim.com>
Reviewed by Eric Seidel.
Remove global variable $httpdPath and replace with the return value of
getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
https://bugs.webkit.org/show_bug.cgi?id=53499
* Scripts/run-iexploder-tests:
* Scripts/webkitperl/httpd.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Thu, 7 Apr 2011 01:13:26 +0000 (01:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57997
<rdar://problem/9187856> REGRESSION(r75555): ~5-7 MB increase in memory between iBench runs
Navigating away from a Scrolled page which queues a scroll event that is never dispatched.
Cancel all enqueued events when detaching the Document the events cannot keep the Document
alive.
Reviewed by Darin Adler.
No change in functionality so no new tests.
* dom/Document.cpp:
(WebCore::Document::detach):
* dom/EventQueue.cpp:
(WebCore::EventQueue::cancelQueuedEvents):
* dom/EventQueue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 7 Apr 2011 01:04:30 +0000 (01:04 +0000)]
2011-04-06 David Levin <levin@chromium.org>
Reviewed by Ojan Vafai.
Augment style guidelines about meaningless parameters from text the unwritten rules email.
https://bugs.webkit.org/show_bug.cgi?id=55275
* coding/coding-style.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 7 Apr 2011 01:02:27 +0000 (01:02 +0000)]
<rdar://problem/9084761> REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
https://bugs.webkit.org/show_bug.cgi?id=58002
Reviewed by Darin Adler.
Source/WebCore:
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit): The version of Geeza Pro in Snow Leopard
does not require the vertical metrics tweaks that were needed in Leopard. That the
tweaks were being applied went mostly unnoticed until r73993, because until then it
only affected cases where Geeza Pro was specified, not when it occurred as a fallback
font.
LayoutTests:
* platform/mac/fast/dom/52776-expected.checksum:
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum:
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 7 Apr 2011 00:20:32 +0000 (00:20 +0000)]
2011-04-06 Anders Bakken <agbakken@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] FrameLoaderClientQt.cpp has coding-style errors
https://bugs.webkit.org/show_bug.cgi?id=40254
* WebCoreSupport/FrameLoaderClientQt.cpp:
(drtDescriptionSuitableForTestResult):
(WebCore::FrameLoaderClientQt::hasWebView):
(WebCore::FrameLoaderClientQt::setCopiesOnScroll):
(WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
(WebCore::FrameLoaderClientQt::cancelPolicyCheck):
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::willChangeTitle):
(WebCore::FrameLoaderClientQt::didChangeTitle):
(WebCore::FrameLoaderClientQt::finishedLoading):
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
(WebCore::FrameLoaderClientQt::provisionalLoadStarted):
(WebCore::FrameLoaderClientQt::didFinishLoad):
(WebCore::FrameLoaderClientQt::setTitle):
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
(WebCore::FrameLoaderClientQt::committedLoad):
(WebCore::FrameLoaderClientQt::download):
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
(WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientQt::createFrame):
(WebCore::FrameLoaderClientQt::objectContentType):
(WebCore::FrameLoaderClientQt::createPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 7 Apr 2011 00:07:08 +0000 (00:07 +0000)]
2011-04-06 Adrienne Walker <enne@google.com>
Unreviewed, update expectations for Chromium visited link test.
https://bugs.webkit.org/show_bug.cgi?id=58000
Apparently, this just hasn't been working for a while.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 6 Apr 2011 23:52:52 +0000 (23:52 +0000)]
2011-04-06 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 57994 - Move guardRef functionality back to Document
https://bugs.webkit.org/show_bug.cgi?id=57994
Move the relevant code parts from TreeScope back into Document.
No new tests. (no new functionality)
* dom/Document.cpp:
(WebCore::Document::removedLastRef):
* dom/Document.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::destroyTreeScopeData):
* dom/TreeScope.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 6 Apr 2011 23:41:51 +0000 (23:41 +0000)]
2011-04-06 Ian Henderson <ianh@apple.com>
Reviewed by Simon Fraser, Antti Koivisto.
Fast path for parsing simple CSS values
https://bugs.webkit.org/show_bug.cgi?id=57964
Add functions to parse simple color or dimension values, skipping the
overhead of full CSS parsing.
Change parseValue to a static method to avoid unnecessary allocation
of a CSSParser in the fast case.
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
Changed to use the new, static parseValue method.
* css/CSSParser.cpp:
(WebCore::isColorPropertyID):
(WebCore::parseColorValue):
Parses any color accepted by the existing parseColor() static method.
We must handle color identifiers separately, since parseColor() will
change 'red' into 'rgb(255, 0, 0)'.
(WebCore::isSimpleLengthPropertyID):
(WebCore::parseSimpleLengthValue):
Parses a value of the form 'NNpx', 'NN%', or 'NN' (when strict is
false, or 'NN' is '0'). Returns false to fall back to the slow path.
(WebCore::CSSParser::parseValue):
* css/CSSParser.h:
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
Changed to use the new, static parseValue method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 6 Apr 2011 23:38:42 +0000 (23:38 +0000)]
Reviewed by Darin Adler.
Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
https://bugs.webkit.org/show_bug.cgi?id=27551
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 6 Apr 2011 23:27:46 +0000 (23:27 +0000)]
2011-04-06 Tony Chang <tony@chromium.org>
Reviewed by Darin Adler.
teach run-webkit-tests to read checksums from png files
https://bugs.webkit.org/show_bug.cgi?id=57993
* Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
no .checksum and look for the checksum in there.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 6 Apr 2011 23:20:49 +0000 (23:20 +0000)]
2011-04-06 Simon Fraser <simon.fraser@apple.com>
Reviewed by Antti Koivisto.
Some minor style resolution optimizations
https://bugs.webkit.org/show_bug.cgi?id=57996
A couple of minor optimizations to style-related code.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::isCSSPropertyName):
(WebCore::JSCSSStyleDeclaration::putDelegate):
Avoid calling cssPropertyName() twice when setting style on an element.
* css/CSSStyleSelector.cpp:
(WebCore::useSVGZoomRules):
(WebCore::CSSStyleSelector::applyProperty):
Avoid calling isSVGElement() for every property, since only a two properties
care about it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 6 Apr 2011 23:19:20 +0000 (23:19 +0000)]
2011-04-06 Ian Henderson <ianh@apple.com>
Reviewed by Antti Koivisto.
Unnecessary string allocation in CSSStyleDeclaration::setProperty
https://bugs.webkit.org/show_bug.cgi?id=57995
Pass the bool representing the property's importance directly instead
of constructing a string.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 6 Apr 2011 23:08:11 +0000 (23:08 +0000)]
2011-04-06 Adrienne Walker <enne@google.com>
Unreviewed, rebaseline more Chromium mac tests after r83075.
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 23:06:03 +0000 (23:06 +0000)]
2011-04-06 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Benjamin Poulain.
[Qt][WK2][Symbian] Remove use of stack arrays with variable size
https://bugs.webkit.org/show_bug.cgi?id=57877
For better compiler portability, use new/delete for arrays when size
isn't known at compile time. Also fix one compiler warning about bitshift
operations on signed integers.
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::sendOutgoingMessage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 23:01:30 +0000 (23:01 +0000)]
2011-04-06 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Make the style of createFunctionOnlyCallback in V8 consistent with the JavaScriptCore version.
https://bugs.webkit.org/show_bug.cgi?id=57963
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 6 Apr 2011 22:56:55 +0000 (22:56 +0000)]
2011-04-06 Adrienne Walker <enne@google.com>
Unreviewed, try to green Chromium mac tree by marking failing tests as more generally failing.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 6 Apr 2011 22:38:43 +0000 (22:38 +0000)]
WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>
Reviewed by Adam Roben.
Source/WebCore:
Move WindowTouch.h from WebKit/win, so it can be used in both WebKit and WebKit2.
* WebCore.vcproj/WebCore.vcproj:
* platform/win/WindowsTouch.h: Copied from WebKit/win/WindowsTouch.h.
Source/WebKit/win:
Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
used in both WebKit and WebKit2.
* WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
* WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
* WindowsTouch.h: Removed.
Source/WebKit2:
Port code from WebKit1 -> WebKit2 to handle Windows 7 gestures.
The UIProcess gets a WM_GESTURENOTIFY message, it sends a sync message to the WebProcess to ask
if we should allow panning. The WebProcess checks if we're in a scrollable area, and the mouse
isn't over a scrollbar.
The UIProcess then gets a WM_GESTURE message, and if it is a pan gesture, it sends a message to
the WebProcess to scroll by the amount fingers have moved since the last WM_GESTURE messeage. The
X and Y are reversed because panning up -> moving the page down, and vice versa.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::gestureWillBegin): Send a sync message to the WebProcess
to initialize the gesture. The WebProcess returns whether or not we can start a pan
gesture from where we are.
(WebKit::WebPageProxy::gestureDidScroll): Send a message to the WebProcess to scroll by
pan gesture.
(WebKit::WebPageProxy::gestureDidEnd): Send a message to the WebProcess that the gesture has ended.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_GESTURE and WM_GESTURENOTIFY handlers.
(WebKit::WebView::WebView): Initialize two new variables.
(WebKit::WebView::onGestureNotify): Figure out which gestures we should support based on where
the gesture is beginning.
(WebKit::WebView::onGesture): Support starting a gesture, ending a gesture, and panning.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add messages needed for gestures.
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::gestureWillBegin): Set the node that the gesture started on (so we
know which layer to scroll if the user pans), and determine whether or not we should allow
panning. If the page can't scroll, or the user is on a scrollbar, disallow panning.
(WebKit::WebPage::gestureDidScroll): Scroll the enclosing layer of the element the gesture
started on.
(WebKit::WebPage::gestureDidEnd): Clear the node the gesture started on.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 6 Apr 2011 22:37:09 +0000 (22:37 +0000)]
2011-04-06 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Enable fullscreen layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=55726
Remove test_expectations override for fullscreen tests.
* platform/chromium/test_expectations.txt:
2011-04-06 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Enable fullscreen layout tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=55726
Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Wed, 6 Apr 2011 22:27:22 +0000 (22:27 +0000)]
2011-04-06 Adrienne Walker <enne@google.com>
Unreviewed, rebaseline Chromium Mac tests after r83075.
* platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/multicol/nested-columns-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Wed, 6 Apr 2011 22:24:32 +0000 (22:24 +0000)]
2011-04-06 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Add WKStringGetCharactersPtr() and WKStringGetLength() to WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=57989
Note that WKChar, which is returned by WKStringGetCharactersPtr(), is defined the same way we define JSChar in JSStringRef.h.
* Shared/API/c/WKString.cpp:
(WKStringGetLength): Added.
(WKStringGetCharactersPtr): Added.
* Shared/API/c/WKString.h: Define WKChar and added WKStringGetLength() and WKStringGetCharactersPtr().
* Shared/WebString.h:
(WebKit::WebString::length): Added.
(WebKit::WebString::characters): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 6 Apr 2011 22:21:38 +0000 (22:21 +0000)]
2011-04-06 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
Dock stays in front of Hulu.com full screen video output
https://bugs.webkit.org/show_bug.cgi?id=57988
<rdar://problem/9216260>
Instead of using -[NSMenu setMenuBarVisible:] to toggle full screen, use
-[NSApp setPresentationOptions:]. Also, make the UI process the front most app before
setting the presentation options when exiting full screen, otherwise the dock won't
be restored correctly.
* PluginProcess/mac/PluginProcessShim.mm:
Remove some shim functions that aren't needed.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::PluginProcessProxy):
Initialize m_preFullscreenAppPresentationOptions.
* UIProcess/Plugins/PluginProcessProxy.h:
Add m_preFullscreenAppPresentationOptions.
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::enterFullscreen):
Change the presentation options for the app.
(WebKit::PluginProcessProxy::exitFullscreen):
Restore the presentation options.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Wed, 6 Apr 2011 22:17:11 +0000 (22:17 +0000)]
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* features.pri:
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
Reviewed by Andreas Kling.
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
https://bugs.webkit.org/show_bug.cgi?id=57974
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
No new tests needed, just a config flag rename.
* Api/qwebkitplatformplugin.h:
* WebCoreSupport/ChromeClientQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
* WebCoreSupport/FullScreenVideoQt.cpp:
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/FullScreenVideoQt.h:
* WebCoreSupport/QtPlatformPlugin.cpp:
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
* examples/platformplugin/platformplugin.pro:
* examples/platformplugin/qwebkitplatformplugin.h:
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadHtml5Video):
* tests/tests.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 6 Apr 2011 22:15:11 +0000 (22:15 +0000)]
2011-04-06 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Stop JSObject::isUsingInlineStorage() from using the structure
https://bugs.webkit.org/show_bug.cgi?id=57986
Make the isUsingInlineStorage() implementation just look at
whether the property storage is inside the object.
* runtime/JSObject.h:
(JSC::JSObject::isUsingInlineStorage):
(JSC::JSObject::JSObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 6 Apr 2011 22:10:16 +0000 (22:10 +0000)]
Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.
Rubber stamped by Geoff Garen.
* runtime/JSImmediate.h:
* runtime/JSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log