WebKit-https.git
7 years agoSource/WebCore: Fix a crash relating to anonymous block merging in
commit-queue@webkit.org [Tue, 1 Nov 2011 04:24:08 +0000 (04:24 +0000)]
Source/WebCore: Fix a crash relating to anonymous block merging in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

Test: fullscreen/anonymous-block-merge-crash.html

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):

LayoutTests: Test case for a crash relating to merging of anonymous blocks in
RenderFullScreen::unwrapRenderer.
https://bugs.webkit.org/show_bug.cgi?id=70705

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-10-31
Reviewed by Simon Fraser.

* fullscreen/anonymous-block-merge-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8MessageEvent::dataAccessorGetter does not return a reference to its caller
commit-queue@webkit.org [Tue, 1 Nov 2011 03:37:51 +0000 (03:37 +0000)]
V8MessageEvent::dataAccessorGetter does not return a reference to its caller
https://bugs.webkit.org/show_bug.cgi?id=71229

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-31
Reviewed by Adam Barth.

Test: fast/events/dispatch-message-string-data.html

* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix after r98853.
reni@webkit.org [Tue, 1 Nov 2011 01:47:17 +0000 (01:47 +0000)]
[Qt] Build fix after r98853.

Rubber-stamped by Andreas Kling.

* xml/XSLImportRule.cpp:
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::parentStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDe-virtualize JSObject::defaultValue
mhahnenberg@apple.com [Tue, 1 Nov 2011 01:15:06 +0000 (01:15 +0000)]
De-virtualize JSObject::defaultValue
https://bugs.webkit.org/show_bug.cgi?id=71146

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added defaultValue to the MethodTable.  Replaced all virtual versions of
defaultValue with static versions.  Replaced all call sites with lookups in the
MethodTable.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/ExceptionHelpers.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defaultValue):
* runtime/JSCell.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::defaultValue):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPrimitiveNumber):
(JSC::JSObject::defaultValue):
* runtime/JSObject.h:
(JSC::JSObject::toPrimitive):

Source/WebCore:

No new tests.

Added defaultValue to the MethodTable.  Replaced all virtual versions of
defaultValue with static versions.  Replaced all call sites with lookups in the
MethodTable.

* WebCore.exp.in:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::defaultValue):
* bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSwitch RoundedRect back to integers
leviw@chromium.org [Tue, 1 Nov 2011 01:09:03 +0000 (01:09 +0000)]
Switch RoundedRect back to integers
https://bugs.webkit.org/show_bug.cgi?id=71238

Reviewed by Darin Adler.

Changing RoundedRect back to ints from LayoutUnits. As further testing has shown, this graphics-
focused class should maintain values aligned to pixel boundaries, and therefor kept as integers.

No new tests -- no change in behavior.

* platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::inflateWithRadii):
(WebCore::RoundedRect::Radii::excludeLogicalEdges):
(WebCore::RoundedRect::RoundedRect):
* platform/graphics/RoundedRect.h:
(WebCore::RoundedRect::Radii::Radii):
(WebCore::RoundedRect::Radii::setTopLeft):
(WebCore::RoundedRect::Radii::setTopRight):
(WebCore::RoundedRect::Radii::setBottomLeft):
(WebCore::RoundedRect::Radii::setBottomRight):
(WebCore::RoundedRect::Radii::topLeft):
(WebCore::RoundedRect::Radii::topRight):
(WebCore::RoundedRect::Radii::bottomLeft):
(WebCore::RoundedRect::Radii::bottomRight):
(WebCore::RoundedRect::Radii::expand):
(WebCore::RoundedRect::Radii::shrink):
(WebCore::RoundedRect::rect):
(WebCore::RoundedRect::setRect):
(WebCore::RoundedRect::move):
(WebCore::RoundedRect::inflate):
(WebCore::RoundedRect::expandRadii):
(WebCore::RoundedRect::shrinkRadii):
* rendering/svg/SVGRenderSupport.h: Adding missing LayoutTypes.h include

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=70666
commit-queue@webkit.org [Tue, 1 Nov 2011 01:06:00 +0000 (01:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70666
BitmapImage::dataChanged() needs to clear all incomplete frames.

Patch by Peter Kasting <pkasting@google.com> on 2011-10-31
Reviewed by James Robinson.

No tests, as I don't know of a way to send an image to the renderer in
small pieces (with script run between pieces no less).

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAmend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
leviw@chromium.org [Tue, 1 Nov 2011 01:01:57 +0000 (01:01 +0000)]
Amend missing uses of LayoutUnits in RenderApplet, Button, and DeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=71243

Reviewed by Eric Seidel.

Replacing remaining integer uses with LayoutUnits in the aforementioned classes.

No new tests -- no change in behavior.

* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::intrinsicSize):
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderApplet.h:
* rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect):
* rendering/RenderButton.h:
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
* rendering/RenderDeprecatedFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPluginProxy::Update should pass the painted rect in plug-in coordinates
andersca@apple.com [Tue, 1 Nov 2011 00:59:34 +0000 (00:59 +0000)]
PluginProxy::Update should pass the painted rect in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71257

Reviewed by Adam Roben.

This is one step in the process of migrating away from window relative coordinates
and use plug-in relative coordinates instead, since window relative coordinates won't work
with transforms.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect back to plug-in coordinates.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::update):
No need to convert the painted rect back to plug-in coordinates anymore.

* WebProcess/Plugins/PluginProxy.messages.in:
Document that the painted rect is in plug-in coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
aroben@apple.com [Tue, 1 Nov 2011 00:50:44 +0000 (00:50 +0000)]
Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT

Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
leaky builds

Reviewed by Anders Carlsson.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
total of N bytes!").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Media Stream API: add the Chromium WebKit interfaces
commit-queue@webkit.org [Tue, 1 Nov 2011 00:43:49 +0000 (00:43 +0000)]
[Chromium] Media Stream API: add the Chromium WebKit interfaces
https://bugs.webkit.org/show_bug.cgi?id=58550

Source/WebCore:

Changes the PeerHandler platform interface so that embedders can more easily use it.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

* GNUmakefile.am:
* GNUmakefile.list.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* mediastream/PeerConnection.cpp:
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::didCompleteICEProcessing):
(WebCore::PeerConnection::didGenerateSDP):
(WebCore::PeerConnection::didReceiveDataStreamMessage):
(WebCore::PeerConnection::didAddRemoteStream):
(WebCore::PeerConnection::didRemoveRemoteStream):
* mediastream/PeerConnection.h:
* platform/mediastream/PeerConnectionHandlerClient.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandlerClient::~PeerConnectionHandlerClient):
* platform/mediastream/chromium/PeerConnectionHandler.h: Copied from Source/WebCore/platform/mediastream/PeerHandler.h.
* platform/mediastream/gstreamer/PeerConnectionHandler.cpp: Copied from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
* platform/mediastream/gstreamer/PeerConnectionHandler.h: Renamed from Source/WebCore/platform/mediastream/PeerHandler.h.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

Source/WebKit/chromium:

Adds the bridging code + the minimum amount of Web* supporting code.

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-10-31
Reviewed by Darin Fisher.

* WebKit.gyp:
* bridge/PeerConnectionHandler.cpp: Renamed from Source/WebCore/platform/mediastream/PeerHandler.cpp.
(WebCore::PeerConnectionHandler::create):
(WebCore::PeerConnectionHandler::PeerConnectionHandler):
(WebCore::PeerConnectionHandler::~PeerConnectionHandler):
(WebCore::PeerConnectionHandler::produceInitialOffer):
(WebCore::PeerConnectionHandler::handleInitialOffer):
(WebCore::PeerConnectionHandler::processSDP):
(WebCore::PeerConnectionHandler::processPendingStreams):
(WebCore::PeerConnectionHandler::sendDataStreamMessage):
(WebCore::PeerConnectionHandler::stop):
* bridge/PeerConnectionHandlerInternal.cpp: Added.
(WebCore::PeerConnectionHandlerInternal::PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::~PeerConnectionHandlerInternal):
(WebCore::PeerConnectionHandlerInternal::produceInitialOffer):
(WebCore::PeerConnectionHandlerInternal::handleInitialOffer):
(WebCore::PeerConnectionHandlerInternal::processSDP):
(WebCore::PeerConnectionHandlerInternal::processPendingStreams):
(WebCore::PeerConnectionHandlerInternal::sendDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::stop):
(WebCore::PeerConnectionHandlerInternal::didCompleteICEProcessing):
(WebCore::PeerConnectionHandlerInternal::didGenerateSDP):
(WebCore::PeerConnectionHandlerInternal::didReceiveDataStreamMessage):
(WebCore::PeerConnectionHandlerInternal::didAddRemoteStream):
(WebCore::PeerConnectionHandlerInternal::didRemoveRemoteStream):
* bridge/PeerConnectionHandlerInternal.h: Added.
* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::createPeerConnectionHandler):
* public/WebMediaStreamDescriptor.h: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::~WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::isNull):
* public/WebPeerConnectionHandler.h: Added.
(WebKit::WebPeerConnectionHandler::~WebPeerConnectionHandler):
* public/WebPeerConnectionHandlerClient.h: Added.
(WebKit::WebPeerConnectionHandlerClient::~WebPeerConnectionHandlerClient):
* src/WebMediaStreamDescriptor.cpp: Added.
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::reset):
(WebKit::WebMediaStreamDescriptor::operator=):
(WebKit::WebMediaStreamDescriptor::operator WTF::PassRefPtr<WebCore::MediaStreamDescriptor>):
(WebKit::WebMediaStreamDescriptor::operator WebCore::MediaStreamDescriptor*):

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix linker warnings on Windows
aroben@apple.com [Tue, 1 Nov 2011 00:39:50 +0000 (00:39 +0000)]
Fix linker warnings on Windows

* WebCore.vcproj/WebCore.vcproj: Exclude SpellingCorrectionCommand.cpp and
JSRequestAnimationFrameCallback.cpp from all configurations. They are already getting
compiled via *AllInOne.cpp files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Don't use GOwnPtr for ref-counted objects
commit-queue@webkit.org [Tue, 1 Nov 2011 00:29:08 +0000 (00:29 +0000)]
[GStreamer] Don't use GOwnPtr for ref-counted objects
https://bugs.webkit.org/show_bug.cgi?id=71042

Patch by Jonathon Jongsma <jonathon.jongsma@collabora.co.uk> on 2011-10-31
Reviewed by Martin Robinson.

* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Removed.
* platform/graphics/gstreamer/GOwnPtrGStreamer.h: Removed.
* platform/graphics/gstreamer/GStreamerGWorld.cpp:
(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPluginControllerProxy should call Plugin::geometryDidChange
andersca@apple.com [Tue, 1 Nov 2011 00:29:03 +0000 (00:29 +0000)]
PluginControllerProxy should call Plugin::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71255

Reviewed by Sam Weinig.

Pass enough information over in the GeometryDidChange message sent from
PluginProxy to PluginControllerProxy so that PluginControllerProxy can call
Plugin::geometryDidChange.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
(WebKit::PluginControllerProxy::invalidate):
(WebKit::PluginControllerProxy::paintEntirePlugin):
Update for rename from m_frameRect to m_frameRectInWindowCoordinates.

(WebKit::PluginControllerProxy::geometryDidChange):
This now takes the plug-in size and the plug-in to root view transform as well.

* PluginProcess/PluginControllerProxy.h:
Store the plug-in size and rename m_frameRect to m_frameRectInWindowCoordinates.

* PluginProcess/PluginControllerProxy.messages.in:
Update message signature.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
Use the plug-in size instead of the frame rect size.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
Add encoder/decoder for WebCore::AffineTransform.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Compute the frame rect in window coordinates and send it over.

(WebKit::PluginProxy::deprecatedGeometryDidChange):
Move call to geometryDidChange() from here to the new PluginProxy::geometryDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening; bind-script-to-resource.html times out on chromium mac.
johnnyg@google.com [Tue, 1 Nov 2011 00:27:50 +0000 (00:27 +0000)]
Unreviewed gardening; bind-script-to-resource.html times out on chromium mac.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Calling methods of WebFontImpl causes assertions
commit-queue@webkit.org [Tue, 1 Nov 2011 00:27:35 +0000 (00:27 +0000)]
[chromium] Calling methods of WebFontImpl causes assertions
https://bugs.webkit.org/show_bug.cgi?id=71232

Added FontCachePurgePreventer in several methods.

Patch by Yuzhu Shen <yzshen@google.com> on 2011-10-31
Reviewed by James Robinson.

* src/WebFontImpl.cpp:
(WebKit::WebFontImpl::calculateWidth):
(WebKit::WebFontImpl::offsetForPosition):
(WebKit::WebFontImpl::selectionRectForText):
(WebKit::WebFontImpl::estimateTextBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Tue, 1 Nov 2011 00:21:34 +0000 (00:21 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98918.
ossy@webkit.org [Tue, 1 Nov 2011 00:18:20 +0000 (00:18 +0000)]
Unreviewed, rolling out r98918.
http://trac.webkit.org/changeset/98918
https://bugs.webkit.org/show_bug.cgi?id=71256

Wrong commit (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-31

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Tue, 1 Nov 2011 00:10:17 +0000 (00:10 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

* platform/qt/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed holiday gardening after r98673 and r98608.
ossy@webkit.org [Tue, 1 Nov 2011 00:01:47 +0000 (00:01 +0000)]
[Qt] Unreviewed holiday gardening after r98673 and r98608.

* platform/qt/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/qt/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-bt-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
* platform/qt/fast/multicol/block-axis-horizontal-tb-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-lr-expected.txt: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.png: Added.
* platform/qt/fast/multicol/block-axis-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInterpreter build fix
mhahnenberg@apple.com [Mon, 31 Oct 2011 23:57:57 +0000 (23:57 +0000)]
Interpreter build fix

Unreviewed build fix

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine...
nduca@chromium.org [Mon, 31 Oct 2011 23:56:36 +0000 (23:56 +0000)]
[chromium] Connect CCThreadProxy to FrameRateController and SchedulerStateMachine via CCScheduler
https://bugs.webkit.org/show_bug.cgi?id=71100

Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCDelayBasedTimeSource.h:
(WebCore::CCDelayBasedTimeSource::monotonicallyIncreasingTime):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::CCLayerTreeHost::didCommitAndDrawFrame):
* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCSchedulerFrameRateControllerClientAdapter::create):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::~CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::beginFrame):
(WebCore::CCSchedulerFrameRateControllerClientAdapter::CCSchedulerFrameRateControllerClientAdapter):
(WebCore::CCScheduler::CCScheduler):
(WebCore::CCScheduler::~CCScheduler):
(WebCore::CCScheduler::setNeedsAnimate):
(WebCore::CCScheduler::setNeedsCommit):
(WebCore::CCScheduler::setNeedsRedraw):
(WebCore::CCScheduler::beginFrameComplete):
(WebCore::CCScheduler::didSwapBuffersComplete):
(WebCore::CCScheduler::didSwapBuffersAbort):
(WebCore::CCScheduler::onBeginFrame):
(WebCore::CCScheduler::processScheduledActions):
* platform/graphics/chromium/cc/CCScheduler.h:
(WebCore::CCScheduler::create):
(WebCore::CCScheduler::commitPending):
(WebCore::CCScheduler::redrawPending):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
(WebCore::CCSchedulerStateMachine::updateState):
(WebCore::CCSchedulerStateMachine::beginUpdateMoreResourcesComplete):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::redrawPending):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::doCommit):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::hasMoreUpdates):
* platform/graphics/chromium/cc/CCTextureUpdater.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
(WebCore::CCThreadProxy::compositeAndReadback):
(WebCore::CCThreadProxy::requestReadbackOnImplThread):
(WebCore::CCThreadProxy::setNeedsAnimateOnImplThread):
(WebCore::CCThreadProxy::setNeedsCommitOnImplThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnImplThread):
(WebCore::CCThreadProxy::finishAllRenderingOnImplThread):
(WebCore::CCThreadProxy::scheduledActionBeginFrame):
(WebCore::CCThreadProxy::beginFrameAndCommit):
(WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
(WebCore::CCThreadProxy::hasMoreResourceUpdates):
(WebCore::CCThreadProxy::scheduledActionUpdateMoreResources):
(WebCore::CCThreadProxy::scheduledActionCommit):
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):
(WebCore::CCThreadProxy::didCommitAndDrawFrame):
(WebCore::CCThreadProxy::initializeImplOnImplThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnImplThread):
(WebCore::CCThreadProxy::scheduledActionDrawAndSwap):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::StateMachine::setUpdateMoreResourcesPending):
(WebCore::StateMachine::updateMoreResourcesPending):
(WebCore::TEST):
* tests/CCSchedulerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed holiday gardening after r98852.
ossy@webkit.org [Mon, 31 Oct 2011 23:52:47 +0000 (23:52 +0000)]
[Qt] Unreviewed holiday gardening after r98852.

CSS 2.1 failure: background-intrinsic-*
https://bugs.webkit.org/show_bug.cgi?id=47156

* platform/qt/css1/text_properties/vertical_align-expected.png:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-003-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/qt/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/qt/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/qt/fast/block/float/015-expected.png:
* platform/qt/fast/block/float/015-expected.txt:
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/qt/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/qt/svg/as-background-image/background-image-tiled-expected.txt: Added.
* platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/qt/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/qt/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/qt/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/qt/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
* platform/qt/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/qt/svg/as-image/svg-image-change-content-size-expected.txt: Added.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG OSR exits should add to value profiles
fpizlo@apple.com [Mon, 31 Oct 2011 23:50:57 +0000 (23:50 +0000)]
DFG OSR exits should add to value profiles
https://bugs.webkit.org/show_bug.cgi?id=71202

Reviewed by Oliver Hunt.

Value profiles now have an extra special slot not used by the old JIT's
profiling, which is reserved for OSR exits.

The DFG's OSR exit code now knows which register, node index, and value
profiling site was responsible for the (possibly flawed) information that
led to the OSR failure. This is somewhat opportunistic and imperfect;
if there's a lot of control flow between the value profiling site and the
OSR failure point, then this mechanism simply gives up. It also gives up
if the OSR failure is caused by either known deficiencies in the DFG
(like that we always assume that the index in a strict charCodeAt access
is within bounds) or where the OSR failure would be catalogues and
profiled through other means (like slow case counters).

This patch also adds the notion of a JSValueRegs, which is either a
single register in JSVALUE64 or a pair in JSVALUE32_64. We should
probably move the 32_64 DFG towards using this, since it often makes it
easier to share code between 64 and 32_64.

Also fixed a number of pathologies that this uncovered. op_method_check
didn't have a value profiling site on the slow path. GetById should not
always force OSR exit if it never executed in the old JIT; we may be
able to infer its type if it's a array or string length get. Finally,
these changes benefit from a slight tweak to optimization delay
heuristics (profile fullness is now 0.35 instead of 0.25).

3.8% speed-up on Kraken, mostly due to ~35% on both stanford-crypto-aes
and imaging-darkroom.

* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfile::specFailBucket):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfCells):
(JSC::ValueProfile::numberOfObjects):
(JSC::ValueProfile::numberOfFinalObjects):
(JSC::ValueProfile::numberOfStrings):
(JSC::ValueProfile::numberOfArrays):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGPRInfo.h:
(JSC::DFG::JSValueRegs::JSValueRegs):
(JSC::DFG::JSValueRegs::operator!):
(JSC::DFG::JSValueRegs::gpr):
(JSC::DFG::JSValueSource::JSValueSource):
(JSC::DFG::JSValueSource::unboxedCell):
(JSC::DFG::JSValueSource::operator!):
(JSC::DFG::JSValueSource::isAddress):
(JSC::DFG::JSValueSource::offset):
(JSC::DFG::JSValueSource::base):
(JSC::DFG::JSValueSource::gpr):
(JSC::DFG::JSValueSource::asAddress):
(JSC::DFG::JSValueSource::notAddress):
(JSC::DFG::JSValueRegs::tagGPR):
(JSC::DFG::JSValueRegs::payloadGPR):
(JSC::DFG::JSValueSource::tagGPR):
(JSC::DFG::JSValueSource::payloadGPR):
(JSC::DFG::JSValueSource::hasKnownTag):
(JSC::DFG::JSValueSource::tag):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::jsValueRegs):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
* dfg/DFGJITCodeGenerator.h:
(JSC::JSValueOperand::jsValueRegs):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::valueProfileFor):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnByteArray):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_method_check):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_method_check):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/JSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename the remaining uses of Cue in WebCore/loader/
japhet@chromium.org [Mon, 31 Oct 2011 23:49:47 +0000 (23:49 +0000)]
Rename the remaining uses of Cue in WebCore/loader/
to TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=71231

Reviewed by Eric Carlson.

No new tests, strictly a renaming.

* loader/TextTrackLoader.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
* loader/cache/CachedTextTrack.cpp:
* platform/network/chromium/ResourceRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[MutationObservers] Support characterDataOldValue for characterData mutations
adamk@chromium.org [Mon, 31 Oct 2011 23:46:50 +0000 (23:46 +0000)]
[MutationObservers] Support characterDataOldValue for characterData mutations
https://bugs.webkit.org/show_bug.cgi?id=70862

Reviewed by Ojan Vafai.

Source/WebCore:

* dom/CharacterData.cpp:
(WebCore::hasOldValue):
(WebCore::isOldValueRequested):
(WebCore::CharacterData::dispatchModifiedEvent):
* dom/MutationRecord.cpp:
(WebCore::MutationRecord::createCharacterData):
* dom/MutationRecord.h:

LayoutTests:

Added oldValue test cases to existing characterData tests.

* fast/mutation/observe-characterdata-expected.txt:
* fast/mutation/observe-characterdata.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove need for virtual JSObject::unwrappedObject
weinig@apple.com [Mon, 31 Oct 2011 23:43:58 +0000 (23:43 +0000)]
Remove need for virtual JSObject::unwrappedObject
https://bugs.webkit.org/show_bug.cgi?id=71034

Reviewed by Geoffrey Garen.

../JavaScriptCore:

* JavaScriptCore.exp:
Update exports.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.exp:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add JSGlobalThis.cpp.

* runtime/JSGlobalThis.cpp: Added.
(JSC::JSGlobalThis::visitChildren):
(JSC::JSGlobalThis::unwrappedObject):
* runtime/JSGlobalThis.h:
(JSC::JSGlobalThis::createStructure):
Move underlying object from JSDOMWindowShell down to JSGlobalThis
and corresponding visitChildren method.

* runtime/JSObject.cpp:
(JSC::JSObject::unwrappedObject):
Change unwrappedObject from virtual, to just needing an if check.

* runtime/JSObject.h:
(JSC::JSObject::isGlobalThis):
* runtime/JSType.h:
Add isGlobalThis predicate and type.

../WebCore:

Move the member containing the global object from the JSDOMWindowShell
down to the JSGlobalThis class, and update JSDOMWindowShell to go through
an inline helper (which just casts) to get the window.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::className):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
(WebCore::JSDOMWindowShell::put):
(WebCore::JSDOMWindowShell::putWithAttributes):
(WebCore::JSDOMWindowShell::defineOwnProperty):
(WebCore::JSDOMWindowShell::deleteProperty):
(WebCore::JSDOMWindowShell::getPropertyNames):
(WebCore::JSDOMWindowShell::getOwnPropertyNames):
(WebCore::JSDOMWindowShell::defineGetter):
(WebCore::JSDOMWindowShell::defineSetter):
(WebCore::JSDOMWindowShell::lookupGetter):
(WebCore::JSDOMWindowShell::lookupSetter):
(WebCore::JSDOMWindowShell::impl):
* bindings/js/JSDOMWindowShell.h:
(WebCore::JSDOMWindowShell::window):
(WebCore::JSDOMWindowShell::setWindow):
(WebCore::JSDOMWindowShell::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
commit-queue@webkit.org [Mon, 31 Oct 2011 23:40:41 +0000 (23:40 +0000)]
[EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
https://bugs.webkit.org/show_bug.cgi?id=71228

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-31
Reviewed by Antonio Gomes.

Source/WebKit/efl:

r93833 has introduced
ewk_view_setting_scripts_can_close_windows_{get,set}, but its
counterpart to allow scripts to open windows kept its weird name.

This makes the functions to allow windows to open and close windows to
have confusingly different name patterns.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(ewk_view_setting_scripts_can_open_windows_get):
(ewk_view_setting_scripts_can_open_windows_set):
* ewk/ewk_view.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createNewWindow):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove some uses of m_frameRectInWindowCoordinates from PluginProxy
andersca@apple.com [Mon, 31 Oct 2011 23:38:27 +0000 (23:38 +0000)]
Remove some uses of m_frameRectInWindowCoordinates from PluginProxy
https://bugs.webkit.org/show_bug.cgi?id=71252

Reviewed by Darin Adler.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::pluginBounds):
* WebProcess/Plugins/PluginProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement PluginProxy::geometryDidChange
andersca@apple.com [Mon, 31 Oct 2011 23:28:37 +0000 (23:28 +0000)]
Implement PluginProxy::geometryDidChange
https://bugs.webkit.org/show_bug.cgi?id=71251

Reviewed by Sam Weinig.

Keep track of the plug-in size, the clip rect in plug-in coordinates and the
transformation matrix from the root view to the plug-in.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
* WebProcess/Plugins/PluginProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWTF::StringImpl::create(const char*, unsigned) calls itself
commit-queue@webkit.org [Mon, 31 Oct 2011 23:18:49 +0000 (23:18 +0000)]
WTF::StringImpl::create(const char*, unsigned) calls itself
https://bugs.webkit.org/show_bug.cgi?id=71206

The original implementation just calls itself, causing infinite recursion.
Cast the first parameter to const LChar* to fix that.

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-31
Reviewed by Ryosuke Niwa.

* wtf/text/StringImpl.h:
(WTF::StringImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium rebaselines, unreviewed.
johnnyg@google.com [Mon, 31 Oct 2011 23:18:13 +0000 (23:18 +0000)]
Chromium rebaselines, unreviewed.

* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/chromium-gpu-win/media/audio-repaint-expected.txt: Removed.
* platform/chromium-linux-x86/svg/zoom/page: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMac rebaseline after r98852.
rniwa@webkit.org [Mon, 31 Oct 2011 23:12:04 +0000 (23:12 +0000)]
Mac rebaseline after r98852.

* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove null key support (part 2)
commit-queue@webkit.org [Mon, 31 Oct 2011 23:09:39 +0000 (23:09 +0000)]
IndexedDB: Remove null key support (part 2)
https://bugs.webkit.org/show_bug.cgi?id=71132

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-31
Reviewed by Darin Fisher.

* public/WebIDBKey.h:
* src/AssertMatchingEnums.cpp:
* src/WebIDBKey.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit nests pre on copy and paste when the pre is the root editable element
rniwa@webkit.org [Mon, 31 Oct 2011 23:09:12 +0000 (23:09 +0000)]
WebKit nests pre on copy and paste when the pre is the root editable element
https://bugs.webkit.org/show_bug.cgi?id=70800

Reviewed by Darin Adler.

Source/WebCore:

Fixed the bug by removing nested block elements in removeRedundantStylesAndKeepStyleSpanInline.

Tests: editing/pasteboard/contenteditable-pre-2.html
       editing/pasteboard/contenteditable-pre.html

* editing/ApplyStyleCommand.cpp:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Remove block
elements if it's identical to its parent and there are no contents between the two. Also remove
contenteditable attribute from an element if the parent is already richly editable.
(WebCore::ReplaceSelectionCommand::doApply): Remove redundant styles after removing the placeholder
br so that the above check doesn't get affected by the placeholder.
* editing/htmlediting.cpp:
(WebCore::areIdenticalElements): Moved from ApplyStyleCommand.
(WebCore::isNonTableCellHTMLBlockElement): Moved from markup.cpp.
* editing/htmlediting.h:
* editing/markup.cpp:

LayoutTests:

Added tests for copying and pasting contents inside pre. WebKit should not nest pre's.

* editing/execCommand/insert-list-with-noneditable-content-expected.txt: A redundant
contenteditable attribute is removed.
* editing/pasteboard/4930986-2-expected.txt: Trailing space in style attribute is removed.
* editing/pasteboard/contenteditable-pre-2-expected.txt: Added.
* editing/pasteboard/contenteditable-pre-2.html: Added.
* editing/pasteboard/contenteditable-pre-expected.txt: Added.
* editing/pasteboard/contenteditable-pre.html: Added.
* editing/pasteboard/copy-null-characters-expected.txt: A redundant contenteditable attribute
is removed.
* editing/pasteboard/paste-code-in-pre-expected.txt: Pre no longer nests itself erroneously.
* editing/pasteboard/paste-pre-001-expected.txt: Ditto.
* editing/pasteboard/paste-pre-002-expected.txt: Ditto.
* editing/selection/4895428-4-expected.txt: A redundant contenteditable attribute is removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the X11 build.
andersca@apple.com [Mon, 31 Oct 2011 23:08:28 +0000 (23:08 +0000)]
Fix the X11 build.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFactor code to resize the plug-in backing store out into a separate function
andersca@apple.com [Mon, 31 Oct 2011 23:07:12 +0000 (23:07 +0000)]
Factor code to resize the plug-in backing store out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=71250

Reviewed by Adam Roben.

Add a PluginProxy::contentsScaleFactor helper function to get rid of a bunch of PLATFORM(MAC) #ifdefs,
and move the code to update the backing store out into a separate function.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::initialize):
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::contentsScaleFactor):
(WebKit::PluginProxy::updateBackingStore):
(WebKit::PluginProxy::update):
* WebProcess/Plugins/PluginProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotext/plain form encoding ignored and incorrectly specified in request header.
commit-queue@webkit.org [Mon, 31 Oct 2011 23:02:48 +0000 (23:02 +0000)]
text/plain form encoding ignored and incorrectly specified in request header.
https://bugs.webkit.org/show_bug.cgi?id=20795

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-31
Reviewed by Darin Adler.

Source/WebCore:

This patch fixes the behaviour of forms where enctype is set to
text/plain, encoding is also text/plain.

Tests: fast/forms/form-get-textplain.html
       http/tests/misc/form-post-textplain.html

* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* platform/network/FormData.cpp:
(WebCore::FormData::create):
(WebCore::FormData::appendKeyValuePairItems):
* platform/network/FormData.h:
(WebCore::FormData::parseEncodingType):
* platform/network/FormDataBuilder.cpp:
(WebCore::FormDataBuilder::addKeyValuePairAsFormData): Modified encoding scheme for text/plain.
* platform/network/FormDataBuilder.h:

LayoutTests:

Added tests for GET and POST methods for text/plain enctype.
Forms submitted using GET with a content-type of text/plain actually,
send data in URL encoded in the URL.
Forms with POST method and content-type of text/plain actually send data in text/plain.
Modified expected results for mailto tests as per the new behavior.

* fast/forms/form-get-textplain-expected.txt: Added.
* fast/forms/form-get-textplain.html: Added.
* fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
* fast/forms/mailto/post-text-plain-expected.txt:
* fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
* http/tests/misc/form-post-textplain-expected.txt: Added.
* http/tests/misc/form-post-textplain.html: Added.
* http/tests/misc/resources/form-post-textplain.php: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
* platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderImage.cpp calls SVGImage even if it's not defined
johnnyg@google.com [Mon, 31 Oct 2011 23:00:42 +0000 (23:00 +0000)]
RenderImage.cpp calls SVGImage even if it's not defined
https://bugs.webkit.org/show_bug.cgi?id=71247

This fixes a compile error when ENABLE_SVG=0.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::embeddedContentBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd more APIs to WKUserContentURLPattern.h
jeffm@apple.com [Mon, 31 Oct 2011 22:55:01 +0000 (22:55 +0000)]
Add more APIs to WKUserContentURLPattern.h
https://bugs.webkit.org/show_bug.cgi?id=71245

Add additional WKUserContentURLPattern APIs to match what was provided by
the equivalent WebKit1 API.

Reviewed by Darin Adler.

* Shared/API/c/WKUserContentURLPattern.cpp:
(WKUserContentURLPatternCopyHost): Added.
(WKUserContentURLPatternCopyScheme): Added.
(WKUserContentURLPatternIsValid): Added.
(WKUserContentURLPatternMatchesSubdomains): Added.

* Shared/API/c/WKUserContentURLPattern.h: Added new APIs.

* Shared/WebUserContentURLPattern.h:
(WebKit::WebUserContentURLPattern::host): Added.
(WebKit::WebUserContentURLPattern::scheme): Added.
(WebKit::WebUserContentURLPattern::isValid): Added.
(WebKit::WebUserContentURLPattern::matchesSubdomains): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate XMLHttpRequest.send idl declaration to match implementation.
podivilov@chromium.org [Mon, 31 Oct 2011 22:52:58 +0000 (22:52 +0000)]
Update XMLHttpRequest.send idl declaration to match implementation.
https://bugs.webkit.org/show_bug.cgi?id=71121

Reviewed by Adam Barth.

* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore work on making plug-ins work better with transforms
andersca@apple.com [Mon, 31 Oct 2011 22:51:19 +0000 (22:51 +0000)]
More work on making plug-ins work better with transforms
https://bugs.webkit.org/show_bug.cgi?id=71241

Reviewed by Darin Adler.

Source/WebCore:

Export symbols used by WebKit2.

* WebCore.exp.in:

Source/WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
Implement NetscapePlugin::geometryDidChange and store the plug-in size,
the clip rect and the root view transform. Use the transform to compute the window
relative frame and clip rects.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add new member variables.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):
Always call the new Plugin::geometryDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix DFG JIT compilation on Linux targets.
commit-queue@webkit.org [Mon, 31 Oct 2011 22:38:06 +0000 (22:38 +0000)]
Fix DFG JIT compilation on Linux targets.
https://bugs.webkit.org/show_bug.cgi?id=70904

Patch by Andy Wingo <wingo@igalia.com> on 2011-10-31
Reviewed by Darin Adler.

* jit/JITStubs.cpp (SYMBOL_STRING_RELOCATION): Simplify this
macro.

* dfg/DFGOperations.cpp (SYMBOL_STRING_RELOCATION): Copy the
simplified definition from jit/JITStubs.cpp.
(FUNCTION_WRAPPER_WITH_RETURN_ADDRESS, getHostCallReturnValue):
Use the macro to access trampoline targets through the PLT on PIC
systems, instead of introducing a text relocation.  Otherwise, the
library fails to link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Make cache flush when max size of cache has been changed
commit-queue@webkit.org [Mon, 31 Oct 2011 22:31:16 +0000 (22:31 +0000)]
[EFL] Make cache flush when max size of cache has been changed
https://bugs.webkit.org/show_bug.cgi?id=70805

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Calls the ewk_tile_unused_cache_auto_flush function after changing max
size of cache when ewk_tile_unused_cache_max_set is called. Without
this change when new value is lower than the old one the cache may use
more memory than max value set. This situation is not expected by the
user.

* ewk/ewk_tiled_model.cpp:
(ewk_tile_unused_cache_max_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDe-virtualize JSObject::defineGetter
mhahnenberg@apple.com [Mon, 31 Oct 2011 22:24:20 +0000 (22:24 +0000)]
De-virtualize JSObject::defineGetter
https://bugs.webkit.org/show_bug.cgi?id=71134

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added defineGetter to the MethodTable.  Replaced all virtual versions of defineGetter
with static versions.  Replaced all call sites with lookups in the MethodTable.

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::defineGetter):
* debugger/DebuggerActivation.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::defineGetter):
* runtime/JSCell.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineGetter):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::putDescriptor):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncDefineGetter):

Source/WebCore:

No new tests.

Added defineGetter to the MethodTable.  Replaced all virtual versions of defineGetter
with static versions.  Replaced all call sites with lookups in the MethodTable.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::defineGetter):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::defineGetter):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::defineGetter):
(WebCore::JSLocationPrototype::defineGetter):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

Source/WebKit/qt:

Added defineGetter to the MethodTable.  Replaced all virtual versions of defineGetter
with static versions.  Replaced all call sites with lookups in the MethodTable.

* Api/qwebframe.cpp:
(QWebFramePrivate::addQtSenderToGlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: Support for itemid attribute.
commit-queue@webkit.org [Mon, 31 Oct 2011 22:22:50 +0000 (22:22 +0000)]
Microdata: Support for itemid attribute.
https://bugs.webkit.org/show_bug.cgi?id=71007

Patch by Arko Saha <arko@motorola.com> on 2011-10-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

itemid attribute: To give a global identifier for the Microdata items.
The itemid attribute, if specified, must have a value that is a valid URL potentially
surrounded by spaces.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid

Tests: fast/dom/MicroData/itemid-attribute-test.html
       fast/dom/MicroData/itemid-must-see-resolved-url.html

* html/HTMLElement.idl:

LayoutTests:

Added test-cases for itemid attribute.

* fast/dom/MicroData/itemid-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemid-attribute-test.html: Added.
* fast/dom/MicroData/itemid-must-see-resolved-url-expected.txt: Added.
* fast/dom/MicroData/itemid-must-see-resolved-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTowards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
msaboff@apple.com [Mon, 31 Oct 2011 22:13:01 +0000 (22:13 +0000)]
Towards 8-bit Strings: Move Lexer and Parser Objects out of JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=71138

Restructure and movement of Lexer and Parser code.
Moved Lexer and Parser objects out of JSGlobalData.
Added a new ParserTokens class and instance to JSGlobalData that
have JavaScript token related definitions.
Replaced JSGlobalData arguments to Node classes with lineNumber,
as that was the only use of the JSGlobalData.
Combined JSParser and Parser classes into one class,
eliminating JSParser.h and .cpp.
Various supporting #include changes.

These mostly mechanical changes are done in preparation to
making the Lexer and Parser template classes.

Reviewed by Darin Adler.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::toArgumentList):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::ASTBuilder):
(JSC::ASTBuilder::createSourceElements):
(JSC::ASTBuilder::createCommaExpr):
(JSC::ASTBuilder::createLogicalNot):
(JSC::ASTBuilder::createUnaryPlus):
(JSC::ASTBuilder::createVoid):
(JSC::ASTBuilder::thisExpr):
(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::createObjectLiteral):
(JSC::ASTBuilder::createArray):
(JSC::ASTBuilder::createNumberExpr):
(JSC::ASTBuilder::createString):
(JSC::ASTBuilder::createBoolean):
(JSC::ASTBuilder::createNull):
(JSC::ASTBuilder::createBracketAccess):
(JSC::ASTBuilder::createDotAccess):
(JSC::ASTBuilder::createRegExp):
(JSC::ASTBuilder::createNewExpr):
(JSC::ASTBuilder::createConditionalExpr):
(JSC::ASTBuilder::createAssignResolve):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createArguments):
(JSC::ASTBuilder::createArgumentsList):
(JSC::ASTBuilder::createPropertyList):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createEmptyStatement):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createLabelStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):
(JSC::ASTBuilder::appendConstDecl):
(JSC::ASTBuilder::combineCommaNodes):
(JSC::ASTBuilder::appendBinaryOperation):
(JSC::ASTBuilder::createAssignment):
(JSC::ASTBuilder::createNumber):
(JSC::ASTBuilder::makeTypeOfNode):
(JSC::ASTBuilder::makeDeleteNode):
(JSC::ASTBuilder::makeNegateNode):
(JSC::ASTBuilder::makeBitwiseNotNode):
(JSC::ASTBuilder::makeMultNode):
(JSC::ASTBuilder::makeDivNode):
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeAddNode):
(JSC::ASTBuilder::makeSubNode):
(JSC::ASTBuilder::makeLeftShiftNode):
(JSC::ASTBuilder::makeRightShiftNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeFunctionCallNode):
(JSC::ASTBuilder::makeBinaryNode):
(JSC::ASTBuilder::makeAssignNode):
(JSC::ASTBuilder::makePrefixNode):
(JSC::ASTBuilder::makePostfixNode):
* parser/JSParser.cpp: Removed.
* parser/JSParser.h: Removed.
* parser/Lexer.cpp:
(JSC::Keywords::Keywords):
(JSC::Lexer::Lexer):
(JSC::Lexer::~Lexer):
(JSC::Lexer::setCode):
(JSC::Lexer::parseIdentifier):
* parser/Lexer.h:
(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):
(JSC::Keywords::~Keywords):
(JSC::Lexer::setIsReparsing):
(JSC::Lexer::isReparsing):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setLastLineNumber):
(JSC::Lexer::lastLineNumber):
(JSC::Lexer::prevTerminator):
(JSC::Lexer::sawError):
(JSC::Lexer::getErrorMessage):
(JSC::Lexer::currentOffset):
(JSC::Lexer::setOffset):
(JSC::Lexer::setLineNumber):
(JSC::Lexer::sourceProvider):
(JSC::Lexer::isWhiteSpace):
(JSC::Lexer::isLineTerminator):
(JSC::Lexer::convertHex):
(JSC::Lexer::convertUnicode):
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):
* parser/NodeConstructors.h:
(JSC::ParserArenaFreeable::operator new):
(JSC::ParserArenaDeletable::operator new):
(JSC::ParserArenaRefCounted::ParserArenaRefCounted):
(JSC::Node::Node):
(JSC::ExpressionNode::ExpressionNode):
(JSC::StatementNode::StatementNode):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::RegExpNode::RegExpNode):
(JSC::ThisNode::ThisNode):
(JSC::ResolveNode::ResolveNode):
(JSC::ElementNode::ElementNode):
(JSC::ArrayNode::ArrayNode):
(JSC::PropertyNode::PropertyNode):
(JSC::PropertyListNode::PropertyListNode):
(JSC::ObjectLiteralNode::ObjectLiteralNode):
(JSC::BracketAccessorNode::BracketAccessorNode):
(JSC::DotAccessorNode::DotAccessorNode):
(JSC::ArgumentListNode::ArgumentListNode):
(JSC::ArgumentsNode::ArgumentsNode):
(JSC::NewExprNode::NewExprNode):
(JSC::EvalFunctionCallNode::EvalFunctionCallNode):
(JSC::FunctionCallValueNode::FunctionCallValueNode):
(JSC::FunctionCallResolveNode::FunctionCallResolveNode):
(JSC::FunctionCallBracketNode::FunctionCallBracketNode):
(JSC::FunctionCallDotNode::FunctionCallDotNode):
(JSC::CallFunctionCallDotNode::CallFunctionCallDotNode):
(JSC::ApplyFunctionCallDotNode::ApplyFunctionCallDotNode):
(JSC::PrePostResolveNode::PrePostResolveNode):
(JSC::PostfixResolveNode::PostfixResolveNode):
(JSC::PostfixBracketNode::PostfixBracketNode):
(JSC::PostfixDotNode::PostfixDotNode):
(JSC::PostfixErrorNode::PostfixErrorNode):
(JSC::DeleteResolveNode::DeleteResolveNode):
(JSC::DeleteBracketNode::DeleteBracketNode):
(JSC::DeleteDotNode::DeleteDotNode):
(JSC::DeleteValueNode::DeleteValueNode):
(JSC::VoidNode::VoidNode):
(JSC::TypeOfResolveNode::TypeOfResolveNode):
(JSC::TypeOfValueNode::TypeOfValueNode):
(JSC::PrefixResolveNode::PrefixResolveNode):
(JSC::PrefixBracketNode::PrefixBracketNode):
(JSC::PrefixDotNode::PrefixDotNode):
(JSC::PrefixErrorNode::PrefixErrorNode):
(JSC::UnaryOpNode::UnaryOpNode):
(JSC::UnaryPlusNode::UnaryPlusNode):
(JSC::NegateNode::NegateNode):
(JSC::BitwiseNotNode::BitwiseNotNode):
(JSC::LogicalNotNode::LogicalNotNode):
(JSC::BinaryOpNode::BinaryOpNode):
(JSC::MultNode::MultNode):
(JSC::DivNode::DivNode):
(JSC::ModNode::ModNode):
(JSC::AddNode::AddNode):
(JSC::SubNode::SubNode):
(JSC::LeftShiftNode::LeftShiftNode):
(JSC::RightShiftNode::RightShiftNode):
(JSC::UnsignedRightShiftNode::UnsignedRightShiftNode):
(JSC::LessNode::LessNode):
(JSC::GreaterNode::GreaterNode):
(JSC::LessEqNode::LessEqNode):
(JSC::GreaterEqNode::GreaterEqNode):
(JSC::ThrowableBinaryOpNode::ThrowableBinaryOpNode):
(JSC::InstanceOfNode::InstanceOfNode):
(JSC::InNode::InNode):
(JSC::EqualNode::EqualNode):
(JSC::NotEqualNode::NotEqualNode):
(JSC::StrictEqualNode::StrictEqualNode):
(JSC::NotStrictEqualNode::NotStrictEqualNode):
(JSC::BitAndNode::BitAndNode):
(JSC::BitOrNode::BitOrNode):
(JSC::BitXOrNode::BitXOrNode):
(JSC::LogicalOpNode::LogicalOpNode):
(JSC::ConditionalNode::ConditionalNode):
(JSC::ReadModifyResolveNode::ReadModifyResolveNode):
(JSC::AssignResolveNode::AssignResolveNode):
(JSC::ReadModifyBracketNode::ReadModifyBracketNode):
(JSC::AssignBracketNode::AssignBracketNode):
(JSC::AssignDotNode::AssignDotNode):
(JSC::ReadModifyDotNode::ReadModifyDotNode):
(JSC::AssignErrorNode::AssignErrorNode):
(JSC::CommaNode::CommaNode):
(JSC::ConstStatementNode::ConstStatementNode):
(JSC::SourceElements::SourceElements):
(JSC::EmptyStatementNode::EmptyStatementNode):
(JSC::DebuggerStatementNode::DebuggerStatementNode):
(JSC::ExprStatementNode::ExprStatementNode):
(JSC::VarStatementNode::VarStatementNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):
(JSC::DoWhileNode::DoWhileNode):
(JSC::WhileNode::WhileNode):
(JSC::ForNode::ForNode):
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ReturnNode::ReturnNode):
(JSC::WithNode::WithNode):
(JSC::LabelNode::LabelNode):
(JSC::ThrowNode::ThrowNode):
(JSC::TryNode::TryNode):
(JSC::ParameterNode::ParameterNode):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::CaseClauseNode::CaseClauseNode):
(JSC::ClauseListNode::ClauseListNode):
(JSC::CaseBlockNode::CaseBlockNode):
(JSC::SwitchNode::SwitchNode):
(JSC::ConstDeclNode::ConstDeclNode):
(JSC::BlockNode::BlockNode):
(JSC::ForInNode::ForInNode):
* parser/NodeInfo.h:
* parser/Nodes.cpp:
(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::Node::lineNo):
* parser/Parser.cpp:
(JSC::Parser::Parser):
(JSC::Parser::~Parser):
(JSC::Parser::parseInner):
(JSC::Parser::allowAutomaticSemicolon):
(JSC::Parser::parseSourceElements):
(JSC::Parser::parseVarDeclaration):
(JSC::Parser::parseConstDeclaration):
(JSC::Parser::parseDoWhileStatement):
(JSC::Parser::parseWhileStatement):
(JSC::Parser::parseVarDeclarationList):
(JSC::Parser::parseConstDeclarationList):
(JSC::Parser::parseForStatement):
(JSC::Parser::parseBreakStatement):
(JSC::Parser::parseContinueStatement):
(JSC::Parser::parseReturnStatement):
(JSC::Parser::parseThrowStatement):
(JSC::Parser::parseWithStatement):
(JSC::Parser::parseSwitchStatement):
(JSC::Parser::parseSwitchClauses):
(JSC::Parser::parseSwitchDefaultClause):
(JSC::Parser::parseTryStatement):
(JSC::Parser::parseDebuggerStatement):
(JSC::Parser::parseBlockStatement):
(JSC::Parser::parseStatement):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionInfo):
(JSC::Parser::parseFunctionDeclaration):
(JSC::LabelInfo::LabelInfo):
(JSC::Parser::parseExpressionOrLabelStatement):
(JSC::Parser::parseExpressionStatement):
(JSC::Parser::parseIfStatement):
(JSC::Parser::parseExpression):
(JSC::Parser::parseAssignmentExpression):
(JSC::Parser::parseConditionalExpression):
(JSC::isUnaryOp):
(JSC::Parser::isBinaryOperator):
(JSC::Parser::parseBinaryExpression):
(JSC::Parser::parseProperty):
(JSC::Parser::parseObjectLiteral):
(JSC::Parser::parseStrictObjectLiteral):
(JSC::Parser::parseArrayLiteral):
(JSC::Parser::parsePrimaryExpression):
(JSC::Parser::parseArguments):
(JSC::Parser::parseMemberExpression):
(JSC::Parser::parseUnaryExpression):
* parser/Parser.h:
(JSC::isEvalNode):
(JSC::EvalNode):
(JSC::DepthManager::DepthManager):
(JSC::DepthManager::~DepthManager):
(JSC::ScopeLabelInfo::ScopeLabelInfo):
(JSC::Scope::Scope):
(JSC::Scope::startSwitch):
(JSC::Scope::endSwitch):
(JSC::Scope::startLoop):
(JSC::Scope::endLoop):
(JSC::Scope::inLoop):
(JSC::Scope::breakIsValid):
(JSC::Scope::continueIsValid):
(JSC::Scope::pushLabel):
(JSC::Scope::popLabel):
(JSC::Scope::getLabel):
(JSC::Scope::setIsFunction):
(JSC::Scope::isFunction):
(JSC::Scope::isFunctionBoundary):
(JSC::Scope::declareVariable):
(JSC::Scope::declareWrite):
(JSC::Scope::preventNewDecls):
(JSC::Scope::allowsNewDecls):
(JSC::Scope::declareParameter):
(JSC::Scope::useVariable):
(JSC::Scope::setNeedsFullActivation):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::getUncapturedWrittenVariables):
(JSC::Scope::getCapturedVariables):
(JSC::Scope::setStrictMode):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::copyCapturedVariablesToVector):
(JSC::Scope::saveFunctionInfo):
(JSC::Scope::restoreFunctionInfo):
(JSC::ScopeRef::ScopeRef):
(JSC::ScopeRef::operator->):
(JSC::ScopeRef::index):
(JSC::ScopeRef::hasContainingScope):
(JSC::ScopeRef::containingScope):
(JSC::Parser::AllowInOverride::AllowInOverride):
(JSC::Parser::AllowInOverride::~AllowInOverride):
(JSC::Parser::AutoPopScopeRef::AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::~AutoPopScopeRef):
(JSC::Parser::AutoPopScopeRef::setPopped):
(JSC::Parser::currentScope):
(JSC::Parser::pushScope):
(JSC::Parser::popScopeInternal):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::declareWrite):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isFunctionBodyNode):
(JSC::Parser::next):
(JSC::Parser::nextExpectIdentifier):
(JSC::Parser::nextTokenIsColon):
(JSC::Parser::consume):
(JSC::Parser::getToken):
(JSC::Parser::match):
(JSC::Parser::tokenStart):
(JSC::Parser::tokenLine):
(JSC::Parser::tokenEnd):
(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):
(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::startLoop):
(JSC::Parser::endLoop):
(JSC::Parser::startSwitch):
(JSC::Parser::endSwitch):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::breakIsValid):
(JSC::Parser::continueIsValid):
(JSC::Parser::pushLabel):
(JSC::Parser::popLabel):
(JSC::Parser::getLabel):
(JSC::Parser::autoSemiColon):
(JSC::Parser::canRecurse):
(JSC::Parser::lastTokenEnd):
(JSC::Parser::DepthManager::DepthManager):
(JSC::Parser::DepthManager::~DepthManager):
(JSC::Parser::parse):
(JSC::parse):
* parser/ParserTokens.h: Added.
(JSC::JSTokenInfo::JSTokenInfo):
* parser/SourceCode.h:
(JSC::SourceCode::subExpression):
* parser/SourceProviderCacheItem.h:
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::makeFunctionCallNode):
(JSC::SyntaxChecker::createCommaExpr):
(JSC::SyntaxChecker::makeAssignNode):
(JSC::SyntaxChecker::makePrefixNode):
(JSC::SyntaxChecker::makePostfixNode):
(JSC::SyntaxChecker::makeTypeOfNode):
(JSC::SyntaxChecker::makeDeleteNode):
(JSC::SyntaxChecker::makeNegateNode):
(JSC::SyntaxChecker::makeBitwiseNotNode):
(JSC::SyntaxChecker::createLogicalNot):
(JSC::SyntaxChecker::createUnaryPlus):
(JSC::SyntaxChecker::createVoid):
(JSC::SyntaxChecker::thisExpr):
(JSC::SyntaxChecker::createResolve):
(JSC::SyntaxChecker::createObjectLiteral):
(JSC::SyntaxChecker::createArray):
(JSC::SyntaxChecker::createNumberExpr):
(JSC::SyntaxChecker::createString):
(JSC::SyntaxChecker::createBoolean):
(JSC::SyntaxChecker::createNull):
(JSC::SyntaxChecker::createBracketAccess):
(JSC::SyntaxChecker::createDotAccess):
(JSC::SyntaxChecker::createRegExp):
(JSC::SyntaxChecker::createNewExpr):
(JSC::SyntaxChecker::createConditionalExpr):
(JSC::SyntaxChecker::createAssignResolve):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createArgumentsList):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createFuncDeclStatement):
(JSC::SyntaxChecker::createBlockStatement):
(JSC::SyntaxChecker::createExprStatement):
(JSC::SyntaxChecker::createIfStatement):
(JSC::SyntaxChecker::createForLoop):
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createVarStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createContinueStatement):
(JSC::SyntaxChecker::createTryStatement):
(JSC::SyntaxChecker::createSwitchStatement):
(JSC::SyntaxChecker::createWhileStatement):
(JSC::SyntaxChecker::createWithStatement):
(JSC::SyntaxChecker::createDoWhileStatement):
(JSC::SyntaxChecker::createLabelStatement):
(JSC::SyntaxChecker::createThrowStatement):
(JSC::SyntaxChecker::createDebugger):
(JSC::SyntaxChecker::createConstStatement):
(JSC::SyntaxChecker::appendConstDecl):
(JSC::SyntaxChecker::createGetterOrSetterProperty):
(JSC::SyntaxChecker::combineCommaNodes):
(JSC::SyntaxChecker::operatorStackPop):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/LiteralParser.cpp:
(JSC::LiteralParser::tryJSONPParse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe test input-paste-undo.html needs update to work properly
benjamin@webkit.org [Mon, 31 Oct 2011 22:07:03 +0000 (22:07 +0000)]
The test input-paste-undo.html needs update to work properly
https://bugs.webkit.org/show_bug.cgi?id=71091

Reviewed by David Kilzer.

Update the test to select the text that needs to be copied
so that it effectively go in the pasteboard on execCommand.

The test now dumps result as text, testing if the height does not
change with the form edition.

* fast/forms/input-paste-undo-expected.txt: Added.
* fast/forms/input-paste-undo.html:
* platform/chromium-linux/fast/forms/input-paste-undo-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
* platform/chromium-mac/fast/forms/input-paste-undo-expected.png: Removed.
* platform/chromium-win/fast/forms/input-paste-undo-expected.png: Removed.
* platform/chromium-win/fast/forms/input-paste-undo-expected.txt: Removed.
* platform/efl/fast/forms/input-paste-undo-expected.txt: Removed.
* platform/gtk/fast/forms/input-paste-undo-expected.png: Removed.
* platform/gtk/fast/forms/input-paste-undo-expected.txt: Removed.
* platform/mac-leopard/fast/forms/input-paste-undo-expected.png: Removed.
* platform/mac/fast/forms/input-paste-undo-expected.png: Removed.
* platform/mac/fast/forms/input-paste-undo-expected.txt: Removed.
* platform/qt/fast/forms/input-paste-undo-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowindow.onerror doesn't work with inline (attribute) scripts
yurys@chromium.org [Mon, 31 Oct 2011 22:03:22 +0000 (22:03 +0000)]
window.onerror doesn't work with inline (attribute) scripts
https://bugs.webkit.org/show_bug.cgi?id=70991

Source/WebCore:

Uncaught syntax errors in inline event handlers are now reported to
window.onerror handler.

Reviewed by Geoffrey Garen.

Tests: fast/events/window-onerror-exception-in-attr.html
       fast/events/window-onerror-syntax-error-in-attr.html

* bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction): report exception as usual
if it happens during event handler compilation.

LayoutTests:

Added a couple of window.onerror tests for the cases when uncaught exception
occurs in inline event handler. Test for non-syntax errors passed before this change
as well and just extends test coverage for window.onerror functionality.

Reviewed by Geoffrey Garen.

* fast/events/window-onerror-exception-in-attr-expected.txt: Added.
* fast/events/window-onerror-exception-in-attr.html: Added.
* fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.
* fast/events/window-onerror-syntax-error-in-attr.html: Added.
* platform/chromium/fast/events/window-onerror-exception-in-attr-expected.txt: Added.
* platform/chromium/fast/events/window-onerror-syntax-error-in-attr-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, more expectations changes for svg.
johnnyg@google.com [Mon, 31 Oct 2011 21:34:59 +0000 (21:34 +0000)]
Unreviewed, more expectations changes for svg.

* platform/chromium-cg-mac-leopard/fast/overflow/003-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/overflow: Added.
* platform/chromium-cg-mac-snowleopard/fast/overflow/003-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-cg-mac/fast/overflow: Removed.
* platform/chromium-cg-mac/fast/overflow/003-expected.png: Removed.
* platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
* platform/chromium-cg-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
* platform/chromium-linux-x86/svg/zoom/page: Removed.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.txt: Removed.
* platform/chromium-linux/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/overflow: Added.
* platform/chromium-mac-snowleopard/fast/overflow/003-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-4-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-mac/fast/overflow/003-expected.png: Removed.
* platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Removed.
* platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
* platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
* platform/chromium/svg/zoom: Added.
* platform/chromium/svg/zoom/page: Added.
* platform/chromium/svg/zoom/page/zoom-background-images-expected.txt: Added.
* platform/chromium/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOverridden LayoutRect method still uses IntRects
eae@chromium.org [Mon, 31 Oct 2011 21:33:35 +0000 (21:33 +0000)]
Overridden LayoutRect method still uses IntRects
https://bugs.webkit.org/show_bug.cgi?id=71166

Reviewed by Eric Seidel.

Change all virtual controlClipRect, windowResizerRect, windowClipRect,
visibleContentRect, scrollCornerRect, outlineBoundsForRepaint and
localCaretRect functions to have the same signature.

* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
(WebCore::FrameView::windowResizerRect):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.h:
* rendering/RenderButton.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::visibleContentRect):
* rendering/RenderLayer.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::localCaretRect):
* rendering/RenderObject.h:
(WebCore::RenderObject::outlineBoundsForRepaint):
* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::linesBoundingBox):
* rendering/RenderText.h:
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/RenderSVGInlineText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Did rebaselines of media/audio-repaint.html.
imasaki@chromium.org [Mon, 31 Oct 2011 21:24:08 +0000 (21:24 +0000)]
[Chromium] Did rebaselines of media/audio-repaint.html.

Unreviewed.

* platform/chromium-gpu-linux/media/audio-repaint-expected.png: Added.
* platform/chromium-gpu-win/media/audio-repaint-expected.txt: Added.
* platform/chromium-linux/media/audio-repaint-expected.png:
* platform/chromium-win/media/audio-repaint-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658
dslomov@google.com [Mon, 31 Oct 2011 21:07:22 +0000 (21:07 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Transfer of MessagePorts implemented.

Reviewed by David Levin.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70658
[JSC] Implement MessagePort transfer in JSC bindings implementation of webkitPostMessage.
Some 'FAIL's remain in expected test results. These are due to the fact that
JSC bindings chose not to throw type error exception for non-serializable values -
non-serializable values are serialized as null.

Reviewed by David Levin.

* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/events/message-port-multi-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
fpizlo@apple.com [Mon, 31 Oct 2011 21:03:21 +0000 (21:03 +0000)]
REGRESSION (r97118): Reproducible crash in JSCell::toPrimitive when adding
https://bugs.webkit.org/show_bug.cgi?id=71227

Reviewed by Oliver Hunt.

No new tests, since while I can see exactly where the DFG went wrong on the
site in question from looking at the generated machine code, and while I can
certainly believe that such a scenario would happen, I cannot visualize how
to make it happen reproducibly. It requires an odd combination of double
values getting spilled and then refilled, but then reboxed at just the right
time so that the spilled value is an unboxed double while the in-register
value is a boxed double.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillGPR):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy tests depend too much on the user's environment
eric@webkit.org [Mon, 31 Oct 2011 20:50:51 +0000 (20:50 +0000)]
webkitpy tests depend too much on the user's environment
https://bugs.webkit.org/show_bug.cgi?id=71234

Reviewed by Dirk Pranke.

This change just makes a bunch of our older tests use
more modern mocking to avoid trying to launch processes
or read from the user's filesystem during unittesting.

I found many of these by adding an assert in Executive.run_command
that we were not unittesting.  I can't add that assert always
as there are some valid uses of Executive during unittesting.
Once I fix more of these, I may find a way to add such an assert conditionally.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847
johnnyg@google.com [Mon, 31 Oct 2011 20:29:38 +0000 (20:29 +0000)]
Unreviewed, inspector/debugger/bind-script-to-resource.html fails after r98847

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename a couple of NetscapePlugin and PluginProxy member variables
andersca@apple.com [Mon, 31 Oct 2011 20:22:21 +0000 (20:22 +0000)]
Rename a couple of NetscapePlugin and PluginProxy member variables
https://bugs.webkit.org/show_bug.cgi?id=71086

Reviewed by Sam Weinig.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::invalidate):
(WebKit::NetscapePlugin::callSetWindow):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::deprecatedGeometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::deprecatedGeometryDidChange):
(WebKit::PluginProxy::update):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::viewGeometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDid rebaselines for failing tests for fullscreen layout tests.
imasaki@chromium.org [Mon, 31 Oct 2011 19:27:39 +0000 (19:27 +0000)]
Did rebaselines for failing tests for fullscreen layout tests.
https://bugs.webkit.org/show_bug.cgi?id=70512

Reviewed by David Levin.

* platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fullscreen/full-screen-zIndex-after-expected.png: Added.
* platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png:
* platform/chromium-mac-leopard/fullscreen/full-screen-remove-ancestor-after-expected.png:
* platform/chromium-mac-leopard/fullscreen/full-screen-zIndex-after-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixed duplicate lines in test expectations.
caseq@chromium.org [Mon, 31 Oct 2011 19:09:20 +0000 (19:09 +0000)]
Unreviewed. Fixed duplicate lines in test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. More rebaselines after r98852.
caseq@chromium.org [Mon, 31 Oct 2011 18:54:42 +0000 (18:54 +0000)]
Unreviewed. More rebaselines after r98852.

* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-003-expected.png: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/http/tests/misc/acid3-expected.png.
* platform/chromium-cg-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Renamed from LayoutTests/platform/chromium-mac/http/tests/misc/acid3-expected.png.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-mac/fast/block/float/015-expected.png: Removed.
* platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
* platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png.
* platform/chromium-win/css2.1/20110323/background-intrinsic-003-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt.
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Renamed from LayoutTests/platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png.
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt.
* platform/mac/svg/as-image/svg-as-relative-image-expected.txt: Removed.
* platform/qt/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
* platform/qt/svg/as-image/svg-as-relative-image-expected.txt: Removed.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed. Update Skipped list.
leandro@webkit.org [Mon, 31 Oct 2011 18:16:27 +0000 (18:16 +0000)]
[EFL] Unreviewed. Update Skipped list.

* platform/efl/Skipped: Reorder test groups so that they appear in a
more logical manner. Add some other tests that are failing since
recent updates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Marked tests as failing after r98852.
caseq@chromium.org [Mon, 31 Oct 2011 17:54:08 +0000 (17:54 +0000)]
Unreviewed. Marked tests as failing after r98852.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, expectations for fast/js tests.
johnnyg@google.com [Mon, 31 Oct 2011 17:46:17 +0000 (17:46 +0000)]
Unreviewed, expectations for fast/js tests.

* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball
carlosgc@webkit.org [Mon, 31 Oct 2011 17:43:06 +0000 (17:43 +0000)]
[GTK] Install html and tmpl dirs in a $(DOC_MODULE) dir in tarball
https://bugs.webkit.org/show_bug.cgi?id=71224

Reviewed by Martin Robinson.

* GNUmakefile.gtk-doc.am: Copy html and tmpl dirs to
$(distdir)/$(DOC_MODULE).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed tests rebaseline following r98852.
caseq@chromium.org [Mon, 31 Oct 2011 17:38:27 +0000 (17:38 +0000)]
Unreviewed tests rebaseline following r98852.

* fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-cg-mac-leopard/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-leopard/fast/block/float/015-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-cg-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/css1/text_properties/vertical_align-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-linux-x86/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-linux/fast/block/float/015-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-linux/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-linux/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Renamed from LayoutTests/platform/chromium-mac/css1/text_properties/vertical_align-expected.png.
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/float/015-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png.
* platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-win-xp/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win-xp/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win/css1/text_properties/vertical_align-expected.txt:
* platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/chromium-win/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/chromium-win/fast/block/float/015-expected.png:
* platform/chromium-win/fast/block/float/015-expected.txt:
* platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
* platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
* platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png: Added.
* platform/chromium-win/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
* platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.png: Added.
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.txt: Added.
* platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png: Added.
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Copied from LayoutTests/platform/chromium-win/svg/zoom/page/relative-sized-document-scrollbars-expected.png.
* platform/chromium-win/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
* svg/as-background-image/svg-as-background-4-expected.txt: Renamed from LayoutTests/platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.txt.
* svg/as-image/svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/gtk/svg/as-image/svg-as-relative-image-expected.txt.
* svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Renamed from LayoutTests/platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.
leandro@webkit.org [Mon, 31 Oct 2011 17:30:09 +0000 (17:30 +0000)]
[EFL] Unreviewed. Add pixel baselines for tests in fast/ directory.

* platform/efl/fast/backgrounds: [...]
* platform/efl/fast/block: [...]
* platform/efl/fast/body-propagation: [...]
* platform/efl/fast/borders: [...]
* platform/efl/fast/box-shadow: [...]
* platform/efl/fast/canvas: [...]
* platform/efl/fast/clip: [...]
* platform/efl/fast/compact: [...]
* platform/efl/fast/css-generated-content: [...]
* platform/efl/fast/css: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRule: Devirtualize insertedIntoParent()
andreas.kling@nokia.com [Mon, 31 Oct 2011 17:02:49 +0000 (17:02 +0000)]
CSSRule: Devirtualize insertedIntoParent()
https://bugs.webkit.org/show_bug.cgi?id=71223

Reviewed by Antti Koivisto.

Moved insertedIntoParent() down into CSSImportRule and renamed it to
requestStyleSheet(). CSSImportRule is the only user of this function.

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::requestStyleSheet):
* css/CSSImportRule.h:
* css/CSSRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insertRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement load notification and events for <track>.
annacc@chromium.org [Mon, 31 Oct 2011 16:35:56 +0000 (16:35 +0000)]
Implement load notification and events for <track>.
https://bugs.webkit.org/show_bug.cgi?id=71054

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/track/track-load-error-readyState.html
       media/track/track-load-from-element-readyState.html
       media/track/track-load-from-src-readyState.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::trackWasAdded):
(WebCore::HTMLMediaElement::trackWillBeRemoved):
(WebCore::HTMLMediaElement::trackSourceChanged):
* html/HTMLMediaElement.h:
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoTree):
(WebCore::HTMLTrackElement::willRemove):
(WebCore::HTMLTrackElement::parseMappedAttribute):
(WebCore::HTMLTrackElement::attributeChanged):
* html/HTMLTrackElement.h:
* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::cueLoadingCompleted):

LayoutTests:

* media/track/track-load-error-readyState-expected.txt: Added.
* media/track/track-load-error-readyState.html: Added.
* media/track/track-load-from-element-readyState-expected.txt: Added.
* media/track/track-load-from-element-readyState.html: Added.
* media/track/track-load-from-src-readyState-expected.txt: Added.
* media/track/track-load-from-src-readyState.html: Added.
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSRule: Devirtualize type() and isFooRule()
andreas.kling@nokia.com [Mon, 31 Oct 2011 15:53:14 +0000 (15:53 +0000)]
CSSRule: Devirtualize type() and isFooRule()
https://bugs.webkit.org/show_bug.cgi?id=71221

Reviewed by Antti Koivisto.

Store the rule type in a CSSRule member (packed with the parent-is-rule flag)
and let the isFooRule() functions return type() == FOO_TYPE.

CSSPageRule will no longer return true for isStyleRule(), tweaked call sites
accordingly.

* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::CSSCharsetRule):
* css/CSSCharsetRule.h:
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::CSSFontFaceRule):
* css/CSSFontFaceRule.h:
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::CSSImportRule):
* css/CSSImportRule.h:
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
* css/CSSMediaRule.h:
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
* css/CSSPageRule.h:
* css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
* css/CSSRegionStyleRule.h:
* css/CSSRule.h:
(WebCore::CSSRule::type):
(WebCore::CSSRule::isCharsetRule):
(WebCore::CSSRule::isFontFaceRule):
(WebCore::CSSRule::isKeyframeRule):
(WebCore::CSSRule::isKeyframesRule):
(WebCore::CSSRule::isMediaRule):
(WebCore::CSSRule::isPageRule):
(WebCore::CSSRule::isStyleRule):
(WebCore::CSSRule::isRegionStyleRule):
(WebCore::CSSRule::isImportRule):
(WebCore::CSSRule::CSSRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
* css/CSSStyleRule.h:
* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::addPageRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::RuleSet::addStyleRule):
* css/CSSUnknownRule.h:
(WebCore::CSSUnknownRule::CSSUnknownRule):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
* css/WebKitCSSKeyframeRule.h:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
* css/WebKitCSSKeyframesRule.h:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asCSSStyleRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix qmltests after r98460 added widgets dependency.
abecsi@webkit.org [Mon, 31 Oct 2011 15:49:04 +0000 (15:49 +0000)]
[Qt][WK2] Fix qmltests after r98460 added widgets dependency.

Reviewed by Simon Hausmann.

Use QApplication and QtWidgets until we get rid of the widgets dependency of QScroller.

* UIProcess/API/qt/tests/qmltests/qmltests.pro:
* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-31 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 31 Oct 2011 15:29:38 +0000 (15:29 +0000)]
2011-10-31  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: reorder inspector js files to fix remote mode.

        * inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
apavlov@chromium.org [Mon, 31 Oct 2011 15:09:02 +0000 (15:09 +0000)]
Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management
https://bugs.webkit.org/show_bug.cgi?id=70936

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
* inspector/front-end/DatabaseQueryView.js:
(WebInspector.DatabaseQueryView):
(WebInspector.DatabaseQueryView.prototype._enterKeyPressed):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._attributesModified):
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.context):
(WebInspector.StylePropertyTreeElement.prototype.selectElement.event):
(WebInspector.StylePropertyTreeElement.prototype):
(WebInspector.StylePropertyTreeElement.prototype.context.event):
():
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt):
(WebInspector.TextPrompt.prototype.get proxyElement):
(WebInspector.TextPrompt.prototype.attach):
(WebInspector.TextPrompt.prototype.attachAndStartEditing):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype.detach):
(WebInspector.TextPrompt.prototype.get text):
(WebInspector.TextPrompt.prototype.set text):
(WebInspector.TextPrompt.prototype._removeFromElement):
(WebInspector.TextPrompt.prototype._startEditing):
(WebInspector.TextPrompt.prototype._stopEditing):
(WebInspector.TextPrompt.prototype._selectStart.moveBackIfOutside):
(WebInspector.TextPrompt.prototype._selectStart):
(WebInspector.TextPrompt.prototype.defaultKeyHandler):
(WebInspector.TextPrompt.prototype._onKeyDown):
(WebInspector.TextPrompt.prototype.clearAutoComplete):
(WebInspector.TextPrompt.prototype.complete):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.isCaretInsidePrompt):
(WebInspector.TextPrompt.prototype.isCaretAtEndOfPrompt):
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine):
(WebInspector.TextPrompt.prototype.isCaretOnLastLine):
(WebInspector.TextPrompt.prototype.moveCaretToEndOfPrompt):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.tabKeyPressed):
(WebInspector.TextPromptConfig):
(WebInspector.TextPromptWithHistory):
(WebInspector.TextPromptWithHistory.prototype.get historyData):
(WebInspector.TextPromptWithHistory.prototype.setHistoryData):
(WebInspector.TextPromptWithHistory.prototype.pushHistoryItem):
(WebInspector.TextPromptWithHistory.prototype._pushCurrentText):
(WebInspector.TextPromptWithHistory.prototype._previous):
(WebInspector.TextPromptWithHistory.prototype._next):
(WebInspector.TextPromptWithHistory.prototype._currentHistoryItem):
(WebInspector.TextPromptWithHistory.prototype.defaultKeyHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move localization support into UIUtil.js, reduce externs.
pfeldman@chromium.org [Mon, 31 Oct 2011 14:32:40 +0000 (14:32 +0000)]
Web Inspector: move localization support into UIUtil.js, reduce externs.
https://bugs.webkit.org/show_bug.cgi?id=71220

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/compile-front-end.sh:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.focus):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.afterShow):
* inspector/front-end/Drawer.js:
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._hide):
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen.prototype.show):
(WebInspector.HelpScreen.prototype.hide):
(WebInspector.HelpScreen.prototype._onBlur):
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/KeyboardShortcut.js:
(WebInspector.KeyboardShortcut._keyName):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype._onSearchFieldManualFocus):
(WebInspector.SearchController.prototype._onKeyDown):
* inspector/front-end/Settings.js:
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._toolbarDragStart):
* inspector/front-end/UIUtils.js:
(WebInspector.startEditing.cleanUpAfterEditing):
(WebInspector.startEditing.var):
(WebInspector.startEditing):
(WebInspector.UIString):
(WebInspector.useLowerCaseMenuTitles):
(WebInspector.platform):
(WebInspector.isMac):
(WebInspector.platformFlavor):
(WebInspector.port):
(WebInspector.installPortStyles):
(WebInspector._windowFocused):
(WebInspector._windowBlurred):
(WebInspector.previousFocusElement):
(WebInspector.currentFocusElement):
(WebInspector._focusChanged):
(WebInspector.setCurrentFocusElement):
* inspector/front-end/externs.js:
(Event.prototype.initWebKitWheelEvent):
(window.getComputedStyle):
(InspectorBackend.runAfterPendingDispatches):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.addMainEventListeners):

Source/WebKit/chromium:

* src/js/DevTools.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] MiniBrowser doesn't resize as the size is always overridden
kenneth@webkit.org [Mon, 31 Oct 2011 14:15:09 +0000 (14:15 +0000)]
[Qt] MiniBrowser doesn't resize as the size is always overridden
https://bugs.webkit.org/show_bug.cgi?id=71212

Reviewed by Simon Hausmann.

Remove call overriden the size.

* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKill StyleBase.
andreas.kling@nokia.com [Mon, 31 Oct 2011 14:13:14 +0000 (14:13 +0000)]
Kill StyleBase.
https://bugs.webkit.org/show_bug.cgi?id=71218

Reviewed by Antti Koivisto.

Remove the StyleBase class and make all subclasses stand alone. CSSRule and StyleSheet
now inherit from RefCounted<T> instead, and XSLImportRule doesn't even need that,
so StyleBase is replaced by nothing.

* css/StyleBase.cpp:
* css/StyleBase.h:

    Removed.

* css/CSSRule.cpp:
* css/CSSRule.h:
(WebCore::CSSRule::~CSSRule):
(WebCore::CSSRule::useStrictParsing):
(WebCore::CSSRule::setParentStyleSheet):
(WebCore::CSSRule::setParentRule):
(WebCore::CSSRule::parentStyleSheet):
(WebCore::CSSRule::parentRule):
(WebCore::CSSRule::baseURL):
(WebCore::CSSRule::CSSRule):

    CSSRule now inherits directly from RefCounted, and has either a CSSRule or a
    CSSStyleSheet as its parent. Made these getters/setters inline since they are
    trivial now.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

    Purge StyleBase.* from the build systems.

* bindings/js/JSDOMBinding.h:
(WebCore::root):

    New root() functions for CSSRule and StyleSheet.

* bindings/js/JSNodeCustom.h:

    Remove StyleBase.h include.

* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::parentStyleSheet):

    Added CSS-specific parentStyleSheet() so we don't have to cast it to a
    CSSStyleSheet* at the call sites.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::parentStyleSheet):
(WebCore::StyleSheet::baseURL):
* css/StyleSheet.h:
(WebCore::StyleSheet::parentRule):
(WebCore::StyleSheet::setParentRule):
(WebCore::StyleSheet::isCSSStyleSheet):
(WebCore::StyleSheet::isXSLStyleSheet):

    StyleSheet now inherits directly from RefCounted and always has a parent CSSRule
    though it can be null. parentStyleSheet() returns that rule's parent style sheet.
    Moved the relevant guts from StyleBase down here.

* loader/cache/CachedStyleSheetClient.h:

    Remove unnecessary WTF_MAKE_FAST_ALLOCATED, we get it from CachedResourceClient.

* xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::XSLImportRule):
(WebCore::XSLImportRule::~XSLImportRule):
(WebCore::XSLImportRule::parentStyleSheet):
(WebCore::XSLImportRule::setXSLStyleSheet):
(WebCore::XSLImportRule::loadSheet):
* xml/XSLImportRule.h:
(WebCore::XSLImportRule::create):
(WebCore::XSLImportRule::setParentStyleSheet):

    Remove inheritance from StyleBase, and have create() return a PassOwnPtr instead.
    This is fine, since XSLStyleSheet is the only object that ever manages these rules.

* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::insertedIntoDocument):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::~CSSStyleSheet):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::checkLoaded):
(WebCore::CSSStyleSheet::document):
(WebCore::CSSStyleSheet::styleSheetChanged):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::~CSSImportRule):
(WebCore::CSSImportRule::setCSSStyleSheet):
(WebCore::CSSImportRule::insertedIntoParent):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::append):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
* css/CSSRegionStyleRule.cpp:
(WebCore::CSSRegionStyleRule::CSSRegionStyleRule):
(WebCore::CSSRegionStyleRule::~CSSRegionStyleRule):
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/CSSStyleDeclaration.h:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::append):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::parentStyleSheet):
* xml/XSLStyleSheet.h:
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::checkLoaded):
(WebCore::XSLStyleSheet::loadChildSheet):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::~XSLStyleSheet):

    Use the new, more explicit, parenting functions of StyleSheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-31 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 31 Oct 2011 14:07:49 +0000 (14:07 +0000)]
2011-10-31  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        Reviewed by Antti Koivisto.

        Add all *intrinsic* tests from the CSS 2.1 Testsuite - we pass all of them now.
        All tests regarding SVG are now imported in LayoutTests, none are failing anymore.

        Add several new testcases covering the SVG Image size negotiation logic, as defined in CSS 2.1.

        * css2.1/20110323/background-intrinsic-001.htm: Added.
        * css2.1/20110323/background-intrinsic-002.htm: Added.
        * css2.1/20110323/background-intrinsic-003.htm: Added.
        * css2.1/20110323/background-intrinsic-004.htm: Added.
        * css2.1/20110323/background-intrinsic-005.htm: Added.
        * css2.1/20110323/background-intrinsic-006.htm: Added.
        * css2.1/20110323/background-intrinsic-007.htm: Added.
        * css2.1/20110323/background-intrinsic-008.htm: Added.
        * css2.1/20110323/background-intrinsic-009.htm: Added.
        * css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/green-intrinsic-width.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-none.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-height.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Added.
        * css2.1/20110323/resources/red-intrinsic-width.svg: Added.
        * fast/backgrounds/size/contain-and-cover-zoomed.html: Added.
        * fast/images/percent-height-image-expected.txt: Update results, testcase is fixed now.
        * fast/images/percent-height-image.html: Make test async, to make it work cross-browser. With this patch we now pass this testcase.
        * platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Removed.
        * platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
        * platform/mac/css1/text_properties/vertical_align-expected.txt: Update for rounding differences.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Added.
        * platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-expected.png: Updated for rounding differences.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
        * platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
        * platform/mac/fast/block/float/015-expected.png: Slight changes, due 49x50 -> 50x50 size change.
        * platform/mac/fast/block/float/015-expected.txt: Ditto.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Slight changes due to rounding.
        * platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png: Ditto.
        * platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt: Ditto.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.png: Added.
        * platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Added.
        * platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Added.
        * platform/mac/svg/as-background-image/svg-as-background-4-expected.png: Adapt to preserveAspectRatio changes in hearts.svg.
        * platform/mac/svg/as-border-image/svg-as-border-image-expected.png: This needed a rebaseline, it was forgotten before.
        * platform/mac/svg/as-image/animated-svg-as-image-expected.png: Progression, now both images share the same size & ratio, as desired.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.png: Added.
        * platform/mac/svg/as-image/same-image-two-instances-expected.txt: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-expected.png: Adapt to green-relative-size-rect.svg - a circle got added to make it easier to compare.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Added.
        * platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.png: Updated, scrollbars are gone - now matching Opera/FF.
        * platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt: Ditto.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-image-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.png: Added.
        * platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Added.
        * svg/as-background-image/background-image-preserveaspectRatio-support.html: Added.
        * svg/as-background-image/background-image-tiled.html: Added.
        * svg/as-background-image/resources/construction-tape.svg: Added.
        * svg/as-background-image/resources/hearts.svg: Fix testcase, by adding pAR="none", which is now respected. Now the image looks as desired across Opera/FF and us.
        * svg/as-background-image/same-image-two-instances-background-image.html: Added.
        * svg/as-image/img-preserveAspectRatio-support-1.html: Added.
        * svg/as-image/resources/circle-default-meet.svg: Added.
        * svg/as-image/resources/circle-default-none.svg: Added.
        * svg/as-image/resources/circle-default-slice.svg: Added.
        * svg/as-image/resources/circle-nosize.svg: Added.
        * svg/as-image/resources/circle-viewbox-default.svg: Added.
        * svg/as-image/resources/circle-viewbox-meet.svg: Added.
        * svg/as-image/resources/circle-viewbox-none.svg: Added.
        * svg/as-image/resources/circle-viewbox-slice.svg: Added.
        * svg/as-image/resources/green-relative-size-rect.svg: Use relative units everywhere as intended. Add circle to make it easy to spot ratio changes.
        * svg/as-image/same-image-two-instances.html: Added.
        * svg/as-image/svg-as-relative-image-with-explicit-size.html: Added.
        * svg/as-image/svg-image-change-content-size.xhtml: Added.
        * svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Added.
        * svg/zoom/page/zoom-background-image-tiled.html: Added.
        * svg/zoom/page/zoom-background-images.html: Added.
        * svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Added.
        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Added.
        * svg/zoom/page/zoom-svg-as-image.html: Added.
        * svg/zoom/page/zoom-svg-as-relative-image.html: Added.

2011-10-31  Nikolas Zimmermann  <nzimmermann@rim.com>

        CSS 2.1 failure: background-intrinsic-*
        https://bugs.webkit.org/show_bug.cgi?id=47156

        SVGs do not work as tiled background images
        https://bugs.webkit.org/show_bug.cgi?id=16281

        Apply preserveAspectRatio and synthesize viewboxes in <img>
        https://bugs.webkit.org/show_bug.cgi?id=34521

        SVG background doesn't resize properly when dimensions are changed
        https://bugs.webkit.org/show_bug.cgi?id=42944

        Images with percent height inside a floated div should use intrinsic height.
        https://bugs.webkit.org/show_bug.cgi?id=45439

        SVG image in HTML changes size as the window is resized
        https://bugs.webkit.org/show_bug.cgi?id=52045

        Reviewed by Antti Koivisto.

        Implement intrinsic sizing support for SVGImage (svg embedded through <html:img>/<svg:image>/background-image/border-image/...).
        This is demanded by CSS 2.1, and covered by new layout tests in LayoutTests/css2.1 and several new custom testcases.

        Tests: css2.1/20110323/background-intrinsic-001.htm
               css2.1/20110323/background-intrinsic-002.htm
               css2.1/20110323/background-intrinsic-003.htm
               css2.1/20110323/background-intrinsic-004.htm
               css2.1/20110323/background-intrinsic-005.htm
               css2.1/20110323/background-intrinsic-006.htm
               css2.1/20110323/background-intrinsic-007.htm
               css2.1/20110323/background-intrinsic-008.htm
               css2.1/20110323/background-intrinsic-009.htm
               svg/as-background-image/background-image-preserveaspectRatio-support.html (adapted from testcase from bug 34521)
               svg/as-background-image/background-image-tiled.html (reduction from bug 16281)
               svg/as-background-image/same-image-two-instances-background-image.html
               svg/as-image/img-preserveAspectRatio-support-1.html (reduction from bug 34521)
               svg/as-image/same-image-two-instances.html
               svg/as-image/svg-as-relative-image-with-explicit-size.html
               svg/as-image/svg-image-change-content-size.xhtml (reduction from bug 42944)
               svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
               svg/zoom/page/zoom-svg-as-image.html
               svg/zoom/page/zoom-svg-as-relative-image.html

        * css/CSSImageGeneratorValue.cpp:
        (WebCore::CSSImageGeneratorValue::addClient): Pass default zoom factor.
        (WebCore::CSSImageGeneratorValue::getImage): Ditto.
        * loader/cache/CachedImage.cpp: Enable SVGImage <-> IntSize cache.
        (WebCore::CachedImage::lookupImageForSize): Use recently introduced ImageBySizeCache, to lookup an image for a certain size.
        (WebCore::CachedImage::lookupOrCreateImageForRenderer): Use recently introduced ImageBySizeCache, to dynamically create copies of m_image if needed.
        (WebCore::CachedImage::imageForRenderer): Lookup image by renderer, which first looks up a size for a renderer, then uses lookupImageForSize().
        (WebCore::CachedImage::setContainerSizeForRenderer): For SVGImages, pass on container size handling to ImageBySizeCache.
        (WebCore::CachedImage::imageSizeForRenderer): Figure out the image size, respecting per-renderer overrides, for a certain renderer.
        (WebCore::CachedImage::computeIntrinsicDimensions): Remove unnecessary RenderObject parameter.
        * loader/cache/CachedImage.h:
        * page/ChromeClient.h:
        (WebCore::ChromeClient::isSVGImageChromeClient): Used to identify whether a RenderSVGRoot is embedded through a SVGImage. Returns false, by default.
        * platform/graphics/Image.h:
        (WebCore::Image::setImageObserver): Add helper.
        * rendering/ImageBySizeCache.cpp: Cleanup code.
        (WebCore::ImageBySizeCache::addClient): Assert the passed renderer is valid.
        (WebCore::ImageBySizeCache::removeClient): Ditto. Allow removeClient() to be called w/o prio addClient() usage.
        (WebCore::ImageBySizeCache::getImage): Add zoom parameter.
        (WebCore::ImageBySizeCache::getRequestedSizeAndZoom): Add way to get requested size from cache, instead of actual cached sizes.
        (WebCore::ImageBySizeCache::imageForSize): Respect empty sizes, just return 0, instead of asserting.
        (WebCore::ImageBySizeCache::imageForRenderer): Added a helper that retrieves an image for a renderer, by lookup up its size and using imageForSize().
        * rendering/ImageBySizeCache.h: Cleaup code, introduce struct that replaces the std::pair<IntSize, int>.
        (WebCore::SizeZoomAndCount::SizeZoomAndCount):
        * rendering/RenderBoxModelObject.cpp: Implement CSS 2.1 intrinsic size negotiation for images.
        (WebCore::resolveWidthForRatio): New inline helper function used by calculateImageIntrinsicDimensions.
        (WebCore::resolveHeightForRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicWidthOrHeightAndRatio): Ditto.
        (WebCore::resolveAgainstIntrinsicRatio):  Ditto.
        (WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): New helper function, containing the main algorithm, which is a pure transcription of the spec.
        (WebCore::RenderBoxModelObject::calculateFillTileSize): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Propagate calculateFillTileSize() result to the image resource, via setContainerSizeForRenderer().
        (WebCore::RenderBoxModelObject::paintNinePieceImage): Use new calculateImageIntrinsicDimensions() helper to figure out the intrinsic size.
        * rendering/RenderBoxModelObject.h: Clarify some variable names, added calculateImageIntrinsicDimensions().
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage): Use IntSize(), instead of IntSize(0, 0).
        (WebCore::RenderImage::updateIntrinsicSizeIfNeeded): Refactored from imageDimensionsChanged().
        (WebCore::RenderImage::imageDimensionsChanged): Use updateIntrinsicSizeIfNeeded().
        (WebCore::RenderImage::computeReplacedLogicalWidth): Use RenderReplaced::computeReplacedLogicalWidth() exclusively. For this to work, the intrinsic size must be correct.
        (WebCore::RenderImage::computeIntrinsicRatioInformation): Default implementation for non-SVGImages.
        (WebCore::RenderImage::needsPreferredWidthsRecalculation): Return true, just like RenderPart, if embeddedContentBox is not null.
        (WebCore::RenderImage::embeddedContentBox): Returns the RenderSVGRoot* renderer of the embedded SVG, if possible.
        * rendering/RenderImage.h: Remove isLogicalWidth/HeightSpecified() / computeReplacedLogicalHeight() / calcAspectRatioLogicalWidth/Height().
        * rendering/RenderImageResource.cpp:
        (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass around new "float containerZoomFactor" parameter.
        * rendering/RenderImageResourceStyleImage.cpp:
        (WebCore::RenderImageResourceStyleImage::image): embeddedContentBox() is now calling image() earlier than before. We now have to handle the case that the image is pending.
        (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Pass zoom factor.
        * rendering/RenderImageResourceStyleImage.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::computePreferredLogicalWidths): Pass effective zoom to setContainerSizeForRenderer().
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::computeIntrinsicLogicalWidth): Generalized this code, as RenderImage is using it as well now. Marginal changes needed.
        (WebCore::RenderReplaced::computeIntrinsicLogicalHeight): Ditto.
        (WebCore::RenderReplaced::computeReplacedLogicalWidth): Ditto.
        * rendering/style/StyleCachedImage.cpp:
        (WebCore::StyleCachedImage::computeIntrinsicDimensions): Stop passing m_renderer to CachedImage, it's no longer needed.
        (WebCore::StyleCachedImage::setContainerSizeForRenderer): Add "float containerZoomFactor" parameter.
        * rendering/style/StyleCachedImage.h: Add "float containerZoomFactor" parameter to setContainerSizeForRenderer.
        * rendering/style/StyleGeneratedImage.h:
        (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Ditto.
        * rendering/style/StyleImage.h: Ditto.
        * rendering/style/StylePendingImage.h:
        (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout): Always supply a container size when embedding SVGs in <svg:image>.
        * rendering/svg/RenderSVGRoot.cpp: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::isEmbeddedThroughImageElement): Add helper method to determine whether we're loaded through SVGImage.
        (WebCore::RenderSVGRoot::computeReplacedLogicalWidth): If we have a valid container size, it has precendence (only supplied via external SVGImages).
        (WebCore::RenderSVGRoot::computeReplacedLogicalHeight): Ditto.
        (WebCore::RenderSVGRoot::layout): Remove calcViewport() usage, no need to track/override the viewport size anymore, all done in coputeReplacedLogical* now.
        (WebCore::RenderSVGRoot::paint): Use borderBoxRect() which now always matches the previously computed m_viewportSize.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Ditto.
        * rendering/svg/RenderSVGRoot.h: Move "override container size" from SVGSVGElement into RenderSVGRoot, where it belongs.
        (WebCore::RenderSVGRoot::containerSize):
        (WebCore::RenderSVGRoot::setContainerSize):
        * svg/SVGLength.cpp:
        (WebCore::SVGLength::determineViewport): Resolve lengths against override container size in documents embedded through SVGImage.
        * svg/SVGSVGElement.cpp: Remove "override container size" handling from SVGSVGElement.
        (WebCore::SVGSVGElement::SVGSVGElement): Ditto.
        (WebCore::SVGSVGElement::currentViewBoxRect): Always synthesize a viewBox, if we're embedded through SVGImage, as demanded by SVG 1.1 2nd Edition.
        * svg/SVGSVGElement.h:
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImageChromeClient::isSVGImageChromeClient): Return true, used to identify whether RenderSVGRoot is embedded through SVGImage.
        (WebCore::SVGImage::createWithDataAndSize): Add new helper function.
        (WebCore::SVGImage::setContainerZoom): Forwarded to Page::setPageZoomFactor.
        (WebCore::SVGImage::setContainerSize): Assert that container size is not empty. We should never receive an empty container size.
        (WebCore::SVGImage::usesContainerSize): Adapt to override container size changes, it now lives in RenderSVGRoot instead of SVGSVGElement.
        (WebCore::SVGImage::size): New algorithm to figure out the size of an embedded SVG, as demanded by the CSS/SVG specs.
        (WebCore::SVGImage::embeddedContentBox): Add helper which returns the RenderSVGRoot of the document.
        (WebCore::SVGImage::computeIntrinsicDimensions): Implement intrinsic ratio calculation.
        (WebCore::SVGImage::dataChanged): Force calling FrameView::setCanHaveScrollbars(false), as SVG images now always synthesize a viewBox, and thus never receive scrollbars.
        * svg/graphics/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make QWebPreferences hold a QtWebPageProxy
caio.oliveira@openbossa.org [Mon, 31 Oct 2011 13:51:19 +0000 (13:51 +0000)]
[Qt] Make QWebPreferences hold a QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=71219

Reviewed by Andreas Kling.

Change QWebPreferences to keep a pointer to QtWebPageProxy.  The reason is that
some features we want to control (like the messaging exchange between WebView and
the web process) are not available via WKPreferencesRef.

QtWebPageProxy now uses an OwnPtr to keep the QWebPreferences to clarify the
ownership relationship. Before this change the QWebPreferences created was leaking.

* UIProcess/API/qt/qwebpreferences.cpp:
(QWebPreferencesPrivate::createPreferences):
(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferencesPrivate::setFontFamily):
(QWebPreferencesPrivate::fontFamily):
(QWebPreferencesPrivate::setFontSize):
(QWebPreferencesPrivate::fontSize):
(QWebPreferencesPrivate::preferencesRef):
* UIProcess/API/qt/qwebpreferences.h:
* UIProcess/API/qt/qwebpreferences_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::QtWebPageProxy):
(QtWebPageProxy::preferences):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2011-10-31 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 31 Oct 2011 12:45:40 +0000 (12:45 +0000)]
2011-10-31  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Add ResourcePreviewView.js to the list of inspector front-end
        files on Qt.

        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatti...
vsevik@chromium.org [Mon, 31 Oct 2011 12:28:37 +0000 (12:28 +0000)]
Unreviewed, skiped failing test inspector/debugger/selected-call-frame-after-formatting-source.html on QT.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.
caseq@chromium.org [Mon, 31 Oct 2011 12:00:37 +0000 (12:00 +0000)]
Unreviewed. Marked animations/change-keyframes.html as failing on SNOWLEOPARD DEBUG.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: do not map scripts generated with document.write to the document resou...
pfeldman@chromium.org [Mon, 31 Oct 2011 11:55:59 +0000 (11:55 +0000)]
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/bind-script-to-resource.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:

LayoutTests:

* inspector/debugger/bind-script-to-resource-expected.txt: Added.
* inspector/debugger/bind-script-to-resource.html: Added.
* inspector/debugger/linkifier.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 31 Oct 2011 11:55:52 +0000 (11:55 +0000)]
[GTK] Add webkit_settings_new_with_settings() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71111

Reviewed by Martin Robinson.

Convenient method to create a WebKitSettings object with initial
settings.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_new_with_settings):
* UIProcess/API/gtk/WebKitSettings.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsNewWithSettings):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 31 Oct 2011 11:45:37 +0000 (11:45 +0000)]
[GTK] Add methods to get/set the settings of a web view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71109

Reviewed by Martin Robinson.

* GNUmakefile.am: Add WebKitSettingsPrivate.h.
* UIProcess/API/gtk/WebKitSettings.cpp:
(webkitSettingsAttachSettingsToPage): Set the preferences of the
given WebKitSettings object to the page group of the given WKPage.
* UIProcess/API/gtk/WebKitSettingsPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Create the default WebKitSettings for
the view.
(webkit_web_view_set_settings):
(webkit_web_view_get_settings):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewSettings):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=71012
antti@apple.com [Mon, 31 Oct 2011 11:23:34 +0000 (11:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71012
Use StringHasher to generate the matched declaration cache hash

Reviewed by Sam Weinig.

Make sure the MatchedStyleDeclarations are fully zero-initialized as we calculate a hash over a raw memory array of these.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed.
caseq@chromium.org [Mon, 31 Oct 2011 10:28:34 +0000 (10:28 +0000)]
Unreviewed.
Removed Mac10.5 CG expectation for css2.1/20110323/block-non-replaced-width-008.htm, marked it as fail.

* platform/chromium-cg-mac-leopard/css2.1/20110323/block-non-replaced-width-008-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Mon, 31 Oct 2011 10:26:48 +0000 (10:26 +0000)]
Unreviewed. Fix make distcheck build.

Source/WebCore:

* GNUmakefile.am: Add InFilesCompiler.pm to SCRIPTS_BINDINGS and
EXTRA_DIST. Also remove duplicated entries in EXTRA_DIST.

Source/WebKit2:

* GNUmakefile.am: Remove docs/GNUmakefile.in from EXTRA_DIST,
since its generation was removed from configure.ac in r98498.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.
caseq@chromium.org [Mon, 31 Oct 2011 09:35:58 +0000 (09:35 +0000)]
Unreviewed. Mark fast/canvas/shadow-offset-3.html as PASS CRASH on GPU LINUX DEBUG.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: factor out ResourceUtils, clean up externs.
pfeldman@chromium.org [Mon, 31 Oct 2011 09:18:30 +0000 (09:18 +0000)]
Web Inspector: factor out ResourceUtils, clean up externs.
https://bugs.webkit.org/show_bug.cgi?id=71192

Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-31
Reviewed by Yury Semikhatsky.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/Resource.js:
(WebInspector.Resource.displayName):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
* inspector/front-end/ResourceUtils.js: Added.
(WebInspector.resourceForURL):
(WebInspector.forAllResources):
(WebInspector.displayNameForURL):
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.registerLinkifierPlugin):
(WebInspector.linkifyStringAsFragment):
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyURL):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):
(WebInspector.resourceURLForRelatedNode.callback):
(WebInspector.resourceURLForRelatedNode):
(WebInspector.populateHrefContextMenu):
(WebInspector.completeURL):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.selectElement):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.networkResourceById):
* inspector/front-end/utilities.js:
(setupPrototypeUtilities.Element.prototype.selectionLeftOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Using keyboard to increment/decrement units is inconsistent
apavlov@chromium.org [Mon, 31 Oct 2011 08:37:32 +0000 (08:37 +0000)]
Web Inspector: Using keyboard to increment/decrement units is inconsistent
https://bugs.webkit.org/show_bug.cgi?id=71119

Reviewed by Pavel Feldman.

Source/WebCore:

This change makes the behavior consistent with that described at http://trac.webkit.org/wiki/WebInspector

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.alteredFloatNumber):
(WebInspector.StylesSidebarPane.prototype._attributesModified):

LayoutTests:

* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.
caseq@chromium.org [Mon, 31 Oct 2011 08:28:13 +0000 (08:28 +0000)]
Unreviewed. compositing/visibility/visibility-image-layers.html fails on GPU.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than...
abarth@webkit.org [Mon, 31 Oct 2011 07:48:21 +0000 (07:48 +0000)]
[Chromium] The Chromium port calls OwnPtr::get and RefPtr::get way more often than needed
https://bugs.webkit.org/show_bug.cgi?id=71205

Reviewed by Ryosuke Niwa.

WebKit style is to use the implicit Boolean conversions rather than
calling get() on these pointer types.  This patch cleans up most (all?)
of these style issues in the Chromium port in the hopes that they'll be
copy/pasted less in the future.

* src/ApplicationCacheHostInternal.h:
(WebCore::ApplicationCacheHostInternal::toWebApplicationCacheHost):
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::setMainDocumentError):
(WebKit::FrameLoaderClientImpl::committedLoad):
(WebKit::FrameLoaderClientImpl::finishedLoading):
(WebKit::FrameLoaderClientImpl::redirectDataToPlugin):
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::postMessageToRemote):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
(WebCore::SocketStreamHandleInternal::send):
(WebCore::SocketStreamHandleInternal::didOpenStream):
(WebCore::SocketStreamHandleInternal::didSendData):
(WebCore::SocketStreamHandleInternal::didReceiveData):
(WebCore::SocketStreamHandleInternal::didClose):
(WebCore::SocketStreamHandleInternal::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::hitTest):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::findChildByExpression):
(WebKit::WebFrameImpl::loadHistoryItem):
(WebKit::WebFrameImpl::characterIndexForPoint):
(WebKit::WebFrameImpl::selectionAsText):
(WebKit::WebFrameImpl::selectionAsMarkup):
(WebKit::WebFrameImpl::getPrintPageShrink):
(WebKit::WebFrameImpl::printPage):
(WebKit::WebFrameImpl::printEnd):
(WebKit::WebFrameImpl::scopeStringMatches):
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::type):
* src/WebIDBKeyRange.cpp:
(WebKit::WebIDBKeyRange::lower):
(WebKit::WebIDBKeyRange::upper):
(WebKit::WebIDBKeyRange::lowerOpen):
(WebKit::WebIDBKeyRange::upperOpen):
* src/WebImageCG.cpp:
(WebKit::WebImage::WebImage):
(WebKit::WebImage::operator=):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::cancelLoad):
(WebKit::WebMediaPlayerClientImpl::play):
(WebKit::WebMediaPlayerClientImpl::pause):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
(WebKit::WebMediaPlayerClientImpl::naturalSize):
(WebKit::WebMediaPlayerClientImpl::hasVideo):
(WebKit::WebMediaPlayerClientImpl::hasAudio):
(WebKit::WebMediaPlayerClientImpl::setVisible):
(WebKit::WebMediaPlayerClientImpl::duration):
(WebKit::WebMediaPlayerClientImpl::currentTime):
(WebKit::WebMediaPlayerClientImpl::seek):
(WebKit::WebMediaPlayerClientImpl::seeking):
(WebKit::WebMediaPlayerClientImpl::setEndTime):
(WebKit::WebMediaPlayerClientImpl::setRate):
(WebKit::WebMediaPlayerClientImpl::paused):
(WebKit::WebMediaPlayerClientImpl::supportsFullscreen):
(WebKit::WebMediaPlayerClientImpl::supportsSave):
(WebKit::WebMediaPlayerClientImpl::setVolume):
(WebKit::WebMediaPlayerClientImpl::networkState):
(WebKit::WebMediaPlayerClientImpl::readyState):
(WebKit::WebMediaPlayerClientImpl::maxTimeSeekable):
(WebKit::WebMediaPlayerClientImpl::buffered):
(WebKit::WebMediaPlayerClientImpl::dataRate):
(WebKit::WebMediaPlayerClientImpl::totalBytesKnown):
(WebKit::WebMediaPlayerClientImpl::totalBytes):
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
(WebKit::WebMediaPlayerClientImpl::setSize):
(WebKit::WebMediaPlayerClientImpl::paintCurrentFrameInContext):
(WebKit::WebMediaPlayerClientImpl::setPreload):
(WebKit::WebMediaPlayerClientImpl::hasSingleSecurityOrigin):
(WebKit::WebMediaPlayerClientImpl::movieLoadType):
(WebKit::WebMediaPlayerClientImpl::mediaTimeForTimeValue):
(WebKit::WebMediaPlayerClientImpl::decodedFrameCount):
(WebKit::WebMediaPlayerClientImpl::droppedFrameCount):
(WebKit::WebMediaPlayerClientImpl::audioDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::videoDecodedByteCount):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::startDelayedLoad):
* src/WebURLRequest.cpp:
(WebKit::WebURLRequest::extraData):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::theme):
(WebKit::WebViewImpl::mainFrameImpl):
(WebKit::WebViewImpl::tabKeyCyclesThroughElements):
(WebKit::WebViewImpl::hideSelectPopup):
(WebKit::WebViewImpl::popupClosed):
(WebKit::WebViewImpl::focusedWebCoreFrame):
(WebKit::WebViewImpl::close):
(WebKit::WebViewImpl::doPixelReadbackToCanvas):
(WebKit::WebViewImpl::handleInputEvent):
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::caretOrSelectionRange):
(WebKit::WebViewImpl::settings):
(WebKit::WebViewImpl::pageEncoding):
(WebKit::WebViewImpl::setPageEncoding):
(WebKit::WebViewImpl::setInitialFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::copyImageAt):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragLeave):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
(WebKit::WebViewImpl::inspectElementAt):
(WebKit::WebViewImpl::applyAutofillSuggestions):
* src/WebWorkerBase.cpp:
(WebKit::WebWorkerBase::postMessageTask):
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd missing declaration in WebSettings.h
vangelis@chromium.org [Mon, 31 Oct 2011 07:10:01 +0000 (07:10 +0000)]
Add missing declaration in WebSettings.h
https://bugs.webkit.org/show_bug.cgi?id=71165

Reviewed by Darin Fisher.

* public/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebSocket: iframe in reload-crash.html reloads forever
yutak@chromium.org [Mon, 31 Oct 2011 02:50:30 +0000 (02:50 +0000)]
WebSocket: iframe in reload-crash.html reloads forever
https://bugs.webkit.org/show_bug.cgi?id=71098

Reviewed by Kent Tamura.

iframe in this test should not get reloaded more than once.

* http/tests/websocket/tests/hixie76/reload-crash.html:
Provide the value of reloadCount to the script in iframe.
* http/tests/websocket/tests/hixie76/resources/reload-crash-iframe.html:
Call location.reload() only if reloadCount is zero.
* http/tests/websocket/tests/hybi/reload-crash.html:
* http/tests/websocket/tests/hybi/resources/reload-crash-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSParser::parsePrimaryExpression should have an overflow check
fpizlo@apple.com [Mon, 31 Oct 2011 01:50:34 +0000 (01:50 +0000)]
JSParser::parsePrimaryExpression should have an overflow check
https://bugs.webkit.org/show_bug.cgi?id=71197

Reviewed by Geoff Garen.

* parser/JSParser.cpp:
(JSC::JSParser::parsePrimaryExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r98819, r98823, r98825, and r98830.
commit-queue@webkit.org [Mon, 31 Oct 2011 01:43:44 +0000 (01:43 +0000)]
Unreviewed, rolling out r98819, r98823, r98825, and r98830.
http://trac.webkit.org/changeset/98819
http://trac.webkit.org/changeset/98823
http://trac.webkit.org/changeset/98825
http://trac.webkit.org/changeset/98830
https://bugs.webkit.org/show_bug.cgi?id=71199

Broke Chromium Windows bot (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-30

* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG ValueAdd(string, int) should not fail speculation
fpizlo@apple.com [Mon, 31 Oct 2011 00:21:15 +0000 (00:21 +0000)]
DFG ValueAdd(string, int) should not fail speculation
https://bugs.webkit.org/show_bug.cgi?id=71195

Reviewed by Geoff Garen.

1% speed-up on V8.

* dfg/DFGNode.h:
(JSC::DFG::Node::shouldNotSpeculateInteger):
(JSC::DFG::Node::shouldSpeculateInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe DFG inliner should not flush the callee
fpizlo@apple.com [Sun, 30 Oct 2011 22:47:31 +0000 (22:47 +0000)]
The DFG inliner should not flush the callee
https://bugs.webkit.org/show_bug.cgi?id=71191

Reviewed by Oliver Hunt.

0.6% speed-up on V8.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeOrigin.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrameSlow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonew-run-webkit-tests is locale dependent
eric@webkit.org [Sun, 30 Oct 2011 22:42:24 +0000 (22:42 +0000)]
new-run-webkit-tests is locale dependent
https://bugs.webkit.org/show_bug.cgi?id=68691

Unreviewed.

This is a temporary hack until someone from the cr-win port
can take a look and determine which environment variable
lighttpd is missing.

* Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Peter Beverloo's feed to Planet WebKit
rik@webkit.org [Sun, 30 Oct 2011 22:06:03 +0000 (22:06 +0000)]
Add Peter Beverloo's feed to Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=70316

Reviewed by Andreas Kling.

* config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove crash expectations from tests that have not been crashing on Chromium.
rniwa@webkit.org [Sun, 30 Oct 2011 19:34:32 +0000 (19:34 +0000)]
Remove crash expectations from tests that have not been crashing on Chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Switch to a backing store approach for painting WebKitWebView
mrobinson@webkit.org [Sun, 30 Oct 2011 16:29:33 +0000 (16:29 +0000)]
[GTK] Switch to a backing store approach for painting WebKitWebView
https://bugs.webkit.org/show_bug.cgi?id=70213

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. The changes to WebCore should not change
behavior. The changes in WebKit are covered by existing
tests.

* platform/cairo/WidgetBackingStore.h:
(WebCore::WidgetBackingStore::size): Added this getter for the size.
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize size.
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::copyRectFromCairoSurfaceToContext): Added this new helper.
(WebCore::copyRectFromOneSurfaceToAnother): Use the new helper.
* platform/graphics/cairo/CairoUtilities.h:
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStore::WidgetBackingStore): Initialize the size.

Source/WebKit/gtk:

Paint the WebView into a backing store. This prevents expose events from
triggering a layout, making scrolling and resizing much smoother.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::ChromeClient): Initialize new members.
(WebKit::repaintEverythingSoonTimeout): Added this helper which repaints
the WebView more quickly during resize events.
(WebKit::clipOutOldWidgetArea): Clips out the old widget area, so that we
can clear out invalid pixels when growing the widget into a pre-existing
backing store.
(WebKit::clearEverywhereInBackingStore): Clear out the entire backing store.
(WebKit::ChromeClient::widgetSizeChanged): Handle widget size changes by
intelligently resizing or reusing the existing backing store.
(WebKit::coalesceRectsIfPossible): Moved this method from webkitwebview.cpp.
(WebKit::paintWebView): Moved this method from webkitwebview.cpp.
(WebKit::ChromeClient::performAllPendingScrolls): If there are any pending
scrolling operations, perform them by scrolling the backing store.
(WebKit::ChromeClient::paint): Added this timer callback, which paints the
WebView after a short timeout.
(WebKit::ChromeClient::invalidateWindow): No need to do anything here any longer.
(WebKit::ChromeClient::invalidateContentsAndWindow): Now unite the rect with
the existing dirty region and queue the paint timeout.
(WebKit::ChromeClient::scroll): Now just queue a scroll event in the repaint timeout.
Intelligently calculate the area to move and the dirty area using code derived
from WebKit2.
* WebCoreSupport/ChromeClientGtk.h: Added new method definitions and also use
the WebCore namespace to avoid lots of uses of "WebCore::".
* webkit/webkitwebview.cpp:
(webkit_web_view_draw): Now just blit the backing store into the widget.
(webkit_web_view_expose): Ditto.
(webkit_web_view_size_allocate): Let the ChromeClient know the widget size changed.
(webkit_web_view_init): Turn off GDK double buffering as we have our own double
buffer.
* webkit/webkitwebviewprivate.h: Add the backing store member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98827 268f45cc-cd09-0410-ab3c-d52691b4dbfc