xan@webkit.org [Thu, 2 Dec 2010 20:16:44 +0000 (20:16 +0000)]
2010-12-02 Xan Lopez <xlopez@igalia.com>
Try to fix GTK+ build.
* autotools/symbols.filter: add missing ';'.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 20:09:27 +0000 (20:09 +0000)]
2010-12-02 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Geoffrey Garen.
[Qt] Make platform managing of OSAllocator better than r73106
https://bugs.webkit.org/show_bug.cgi?id=50385
* wtf/OSAllocatorPosix.cpp: Remove platform specific guard.
* wtf/OSAllocatorSymbian.cpp: Remove platform specific guard.
* wtf/OSAllocatorWin.cpp: Remove platform specific guard.
* wtf/wtf.pri: Add the correct platform specific source file instead of all of them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 19:57:36 +0000 (19:57 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WINCE] Use GetTickCount() for srand()
https://bugs.webkit.org/show_bug.cgi?id=50338
time() is not a native function on WinCE, so use GetTickCount() instead.
* wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Dec 2010 19:53:28 +0000 (19:53 +0000)]
2010-12-02 Eric Seidel <eric@webkit.org>
Unreviewed.
animations/stop-animation-on-suspend.html sometimes fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49182
* platform/mac/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 2 Dec 2010 19:48:39 +0000 (19:48 +0000)]
2010-12-02 Chris Rogers <crogers@google.com>
Reviewed by Kenneth Russell.
AudioContext needs createBuffer() method from ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=50343
No new tests since audio API is not yet implemented.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::createBuffer):
* webaudio/AudioContext.h:
* webaudio/AudioContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:42:52 +0000 (19:42 +0000)]
2010-12-02 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Add canvas.toDataURL("image/jpeg", quality) support
https://bugs.webkit.org/show_bug.cgi?id=49365
Chromium window/linux layout try results now match the default test result, so
remove this platform-specific test exception file.
* platform/chromium-win/fast/canvas/canvas-toDataURL-case-insensitive-mimetype-expected.txt: Removed.
2010-12-02 Noel Gordon <noel.gordon@gmail.com>
Reviewed by David Levin.
[chromium] Add canvas.toDataURL("image/jpeg", quality) support
https://bugs.webkit.org/show_bug.cgi?id=49365
Adds a libjpeg-based image encoder for Skia bitmaps. Default encoding quality
is 92 to match Mozilla, also Safari, though the actual value used by Safari is
undocumented, and it appears to pre-blur images prior to compression.
The preMultipliedBGRAtoRGB() routine restores the un-premultiplied RGB colors
where there is non-zero alpha. Again, this matches Firefox and Safari, but no
browser conforms to the HTML5 canvas standard here, I believe, considering the
result of canvas/philip/tests/toDataURL.jpeg.alpha.html; that test ignores the
alpha channel when extracting an "image/jpeg".toDataURL(). The correct answer
needs more investigation, bug http://webkit.org/b/40147.
Canvas toDataURL is covered by existing tests canvas/philip/tests/toDataURL.*,
and fast/canvas/*toDataURL* tests.
* WebCore.gypi:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback): don't set encoding quality
here, just pass the toDataURL parameters through to the canvas layer.
* platform/chromium/MIMETypeRegistryChromium.cpp:
(WebCore::MIMETypeRegistry::isSupportedImageMIMETypeForEncoding): implement
the supported mimeTypes for encoding in-place.
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::toDataURL): add jpeg encoding and quality support.
* platform/image-encoders/skia/JPEGImageEncoder.cpp: Added.
(WebCore::prepareOutput):
(WebCore::writeOutput):
(WebCore::finishOutput):
(WebCore::handleError):
(WebCore::preMultipliedBGRAtoRGB): FIXME: bug 40147.
(WebCore::JPEGImageEncoder::encode):
* platform/image-encoders/skia/JPEGImageEncoder.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:30:51 +0000 (19:30 +0000)]
2010-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73152.
http://trac.webkit.org/changeset/73152
https://bugs.webkit.org/show_bug.cgi?id=50401
the patch has broken chromium win layout tests (Requested by
loislo on #webkit).
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
* inspector/report-protocol-errors.html:
2010-12-02 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r73152.
http://trac.webkit.org/changeset/73152
https://bugs.webkit.org/show_bug.cgi?id=50401
the patch has broken chromium win layout tests (Requested by
loislo on #webkit).
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/Callback.js:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
* inspector/front-end/inspector.js:
(WebInspector.loaded.WebInspector.socket.onmessage):
(WebInspector.dispatch):
(WebInspector_syncDispatch):
(WebInspector.reportProtocolError):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 19:23:55 +0000 (19:23 +0000)]
2010-12-02 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-clip-expected.txt: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-leopard/svg/custom/image-rescale-expected.checksum: Added.
* platform/mac-leopard/svg/custom/image-rescale-expected.png: Added.
* platform/mac-leopard/svg/custom/image-rescale-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.png: Added.
* platform/mac/svg/custom/image-rescale-clip-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-expected.png: Added.
* platform/mac/svg/custom/image-rescale-expected.txt: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
* platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
* svg/custom/image-rescale-clip.html: Added.
* svg/custom/image-rescale-scroll.html: Added.
* svg/custom/image-rescale.svg: Added.
* svg/custom/resources/image-rescale.jpg: Added.
2010-12-02 W. James MacLean <wjmaclean@chromium.org>
Reviewed by James Robinson.
Scaled Resized images are blurred when sent to Skia
https://bugs.webkit.org/show_bug.cgi?id=42370
This patch modifies ImageSkia.cpp to fix the calculation of resampled
bitmap sizes so as to include the transform matrix of the canvas.
Includes new tests to catch a scrolling regression and a clipping regression.
Tests: svg/custom/image-rescale-clip.html
svg/custom/image-rescale-scroll.html
svg/custom/image-rescale.svg
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::computeResamplingMode):
(WebCore::drawResampledBitmap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
arv@chromium.org [Thu, 2 Dec 2010 19:21:48 +0000 (19:21 +0000)]
2010-12-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Missing DOM property for incremental input attribute
https://bugs.webkit.org/show_bug.cgi?id=50335
* fast/forms/incremental-dom-property-expected.txt: Added.
* fast/forms/incremental-dom-property.html: Added.
* fast/forms/script-tests/incremental-dom-property.js: Added.
2010-12-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Darin Adler.
Missing DOM property for incremental input attribute
https://bugs.webkit.org/show_bug.cgi?id=50335
Test: fast/forms/incremental-dom-property.html
* html/HTMLInputElement.idl: Added attribute
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 19:17:50 +0000 (19:17 +0000)]
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Attempt to fix the GTK+ build. Add missing symbol the
list of unfiltered symbols for the linker.
* autotools/symbols.filter: Add symbol used in DumpRenderTree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 19:00:08 +0000 (19:00 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] force NRWT to use DRT
https://bugs.webkit.org/show_bug.cgi?id=50359
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 18:59:07 +0000 (18:59 +0000)]
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
* page/Chrome.h:
* page/ChromeClient.h:
* page/Geolocation.cpp:
(WebCore::Geolocation::disconnectFrame):
(WebCore::Geolocation::requestPermission):
* page/GeolocationClient.h:
* page/GeolocationController.cpp:
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
* page/GeolocationController.h:
* platform/mock/GeolocationClientMock.cpp:
(WebCore::GeolocationClientMock::GeolocationClientMock):
(WebCore::GeolocationClientMock::setPermission):
(WebCore::GeolocationClientMock::requestPermission):
(WebCore::GeolocationClientMock::cancelPermissionRequest):
(WebCore::GeolocationClientMock::asyncUpdatePermission):
(WebCore::GeolocationClientMock::permissionTimerFired):
(WebCore::GeolocationClientMock::reset):
(WebCore::GeolocationClientMock::stopUpdating):
(WebCore::GeolocationClientMock::asyncUpdateController):
(WebCore::GeolocationClientMock::controllerTimerFired):
* platform/mock/GeolocationClientMock.h:
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission, and supporting class
WebGeolocationPolicyListener. The moved code is unchanged except
that requestPermission now takes only one argument (Geolocation*)
and the Frame parameter is retrieved from the Geolocation object.
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::cancelPermissionRequest):
* WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission. The moved code is unchanged
except that requestPermission now takes only one argument (Geolocation*),
the Frame parameter is retrieved from the Geolocation object and we need to
call m_webView.get() as it is a COMPtr in GeolocationClient.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::requestPermission):
* WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::cancelPermissionRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 2 Dec 2010 18:41:38 +0000 (18:41 +0000)]
Plug-ins should be able to update the mouse cursor
https://bugs.webkit.org/show_bug.cgi?id=50399
Reviewed by Sam Weinig.
WebKit2:
Call WKEnableSettingCursorWhenInBackground.
* PluginProcess/mac/PluginProcessMainMac.mm:
(WebKit::PluginProcessMain):
WebKitLibraries:
Add WKEnableSettingCursorWhenInBackground.
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 18:33:14 +0000 (18:33 +0000)]
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, update DRT crash on mac.
* platform/chromium/test_expectations.txt:
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, roll chromium deps to r67980.
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Dec 2010 18:30:05 +0000 (18:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50368
Overhaul WebKit2 preferences code
Reviewed by Anders Carlsson.
- Reduces the number of places you have to touch to add a new preference
(From 9 down to 4, but with a bit of elbow grease, we should get that
down to 2 or 3).
- Add hooks so that platforms can initialize the preferences based on an
identifier. This is currently only used on the Mac to initialize a
preference store from NSUserDefaults and autosave the changes to disk.
It is not yet enabled due to no way to set the identifier from client
code.
* Shared/WebPageCreationParameters.cpp:
Add necessary #include of WebCoreArgumentCoders.h which is now needed
due to cleanup in WebPreferencesStore.h.
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
(WebKit::defaultValueForKey):
(WebKit::setValueForKey):
(WebKit::valueForKey):
(WebKit::WebPreferencesStore::setStringValueForKey):
(WebKit::WebPreferencesStore::getStringValueForKey):
(WebKit::WebPreferencesStore::setBoolValueForKey):
(WebKit::WebPreferencesStore::getBoolValueForKey):
(WebKit::WebPreferencesStore::setUInt32ValueForKey):
(WebKit::WebPreferencesStore::getUInt32ValueForKey):
* Shared/WebPreferencesStore.h:
Complete overhaul of this class to store the preferences as
a set of HashMaps and use macros to define the keys and default
values.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetFontSmoothingLevel):
Add cast to keep conversion function working.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::WebPreferences): Add identifier constructor.
(WebKit::WebPreferences::updateStringValueForKey):
(WebKit::WebPreferences::updateBoolValueForKey):
(WebKit::WebPreferences::updateUInt32ValueForKey):
Add type based updaters. These currently give hooks to the platform and
call the generic update, but in the future, we can use this to optimize
updating preferences to not send the entire store for each change.
* UIProcess/WebPreferences.h:
Generate the getters and setters via macro instantiation.
* UIProcess/cf/WebPreferencesCF.cpp: Added.
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.
* UIProcess/mac/WebPreferencesMac.mm: Added.
(WebKit::makeKey):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Use the platform hooks to initialize and update the store from
NSUserDefaults.
* UIProcess/qt/WebPreferencesQt.cpp: Added.
(WebKit::WebPreferences::platformInitializeStore):
(WebKit::WebPreferences::platformUpdateStringValueForKey):
(WebKit::WebPreferences::platformUpdateBoolValueForKey):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
Stubbed out.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
Update to pull the value using the new type based getters.
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 2 Dec 2010 18:22:16 +0000 (18:22 +0000)]
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/front-end/inspector.js:
(WebInspector_syncDispatch):
2010-12-01 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Inspector protocol cleanup task.
The patch has just small renames and adjustments for the protocol things.
'handler' keyword in idl file was replaced with 'domain'.
'domain' property was assigned for the each backend to frontend messages.
At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
https://bugs.webkit.org/show_bug.cgi?id=50337
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 18:14:33 +0000 (18:14 +0000)]
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
Prevent the need to compile JSC into DumpRenderTree twice, by adjusting
the symbol visibility rules for libwebkit. Make all JSC symbols visible,
while hiding WebCore/WebKit symbols.
* GNUmakefile.am: Move the symbol visibility flags to the WebKit build.
* autotools/symbols.filter: Update the symbol filter list with the real
mangled names of the symbols and include other symbols that DRT needs.
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
Keep WebKit/WebCore symbols hidden.
* GNUmakefile.am: Move the symbol visibility rules here, because
now JSC symbols are visible, but WebCore/WebKit symbols are hidden.
2010-12-02 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] DumpRenderTree has two copies of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=49877
* GNUmakefile.am: Remove the second copy of JavaScriptCore from the
LDADD list for DumpRenderTree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Thu, 2 Dec 2010 18:07:24 +0000 (18:07 +0000)]
2010-12-02 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Eric Carlson.
Style Fixes in WebPluginController
https://bugs.webkit.org/show_bug.cgi?id=50397
* Plugins/WebPluginController.mm:
(-[WebPluginController startAllPlugins]):
(-[WebPluginController stopAllPlugins]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:55:40 +0000 (17:55 +0000)]
Mac build fix.
* WebProcess/WebKitMain.cpp:
(enableDataExecutionPrevention):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 2 Dec 2010 17:45:27 +0000 (17:45 +0000)]
2010-12-02 Tony Chang <tony@chromium.org>
Unreviewed, add back fast/overflow/hit-test-overflow-controls.html
to chromium test_expectations.txt. It's failing on the main
waterfall. Thanks to victorw for notifying me.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Thu, 2 Dec 2010 17:42:03 +0000 (17:42 +0000)]
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Re-implementing HAR export functionality that used to be in Resources
tab in Network tab.
https://bugs.webkit.org/show_bug.cgi?id=45663
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._createTable):
(WebInspector.NetworkPanel.prototype._toggleViewingResourceMode):
(WebInspector.NetworkPanel.prototype._contextMenu):
(WebInspector.NetworkPanel.prototype._exportAll):
(WebInspector.NetworkPanel.prototype._exportResource):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
* inspector/front-end/networkPanel.css:
(.data-grid table.data tr.revealed.network-item):
(.data-grid.filter-other table.data tr.revealed.network-category-other):
2010-12-01 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Resources panel] [HAR] Need a way to save timing data.
Enable resource export to HAR for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=45663
* src/js/DevTools.js: Preferences.resourceExportEnabled = true
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Thu, 2 Dec 2010 17:39:26 +0000 (17:39 +0000)]
Slightly speculative fix for:
Reviewed by Adam Roben.
<rdar://problem/8712674>
<https://bugs.webkit.org/show_bug.cgi?id=50393>
setStringValue: sometimes called with nil in [WebAuthenticationPanel setUpForChallenge]
* Panels/WebAuthenticationPanel.m:
(-[WebAuthenticationPanel setUpForChallenge:]):
If the realm is nil, use @"" instead.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 17:34:02 +0000 (17:34 +0000)]
2010-11-30 Amruth Raj <amruthraj@motorola.com> and Ravi Kasibhatla <ravi.kasibhatla@motorola.com>
Reviewed by Martin Robinson.
[GTK] Implement RunLoop, WorkQueue, Connection classes for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=48507
* Platform/CoreIPC/Connection.h: UNIX_X11 specific changes for GTK port.
(CoreIPC::Connection::messageProcessingCompleted):
* Platform/CoreIPC/gtk: Added.
* Platform/CoreIPC/gtk/ConnectionGtk.cpp: Added. Connection class implementation for GTK port (UNIX_X11 specific).
(CoreIPC::readBytesFromSocket):
(CoreIPC::writeBytesToSocket):
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processCompletedMessage):
(CoreIPC::Connection::readEventHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::platformCanSendOutgoingMessages):
(CoreIPC::Connection::sendOutgoingMessage):
* Platform/PlatformProcessIdentifier.h: UNIX_X11 specific changes for GTK port.
* Platform/RunLoop.h: GTK port specific changes.
* Platform/WorkQueue.h: GTK port specific changes.
* Platform/gtk/RunLoopGtk.cpp: Added. Runs an event loop using GMainLoop and handles the incoming messages.
(RunLoop::RunLoop):
(RunLoop::~RunLoop):
(RunLoop::run):
(RunLoop::mainLoop):
(RunLoop::stop):
(RunLoop::queueWork):
(RunLoop::wakeUp):
(RunLoop::TimerBase::TimerBase):
(RunLoop::TimerBase::~TimerBase):
(RunLoop::TimerBase::resetTimerSource):
(RunLoop::TimerBase::oneShotTimerFired):
(RunLoop::TimerBase::repeatingTimerFired):
(RunLoop::TimerBase::start):
(RunLoop::TimerBase::stop):
(RunLoop::TimerBase::isActive):
* Platform/gtk/WorkQueueGtk.cpp: Added. Creates a thread and polls on a given fd using GIOChannel.
Dispatches the obtained messages to RunLoop's GMainLoop.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::dispatchSource):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::platformInitialize):
(WorkQueue::platformInvalidate):
(WorkQueue::startWorkQueueThread):
(WorkQueue::workQueueThreadBody):
(WorkQueue::registerEventSourceHandler):
(WorkQueue::unregisterEventSourceHandler):
(WorkQueue::scheduleWork):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 17:33:18 +0000 (17:33 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing tests.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:24:52 +0000 (17:24 +0000)]
2010-12-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Move enableExecutionPrevention to WebKitMain
https://bugs.webkit.org/show_bug.cgi?id=50392
* WebProcess/WebKitMain.cpp:
(enableDataExecutionPrevention):
(WebKitMain):
* WebProcess/win/WebProcessMainWin.cpp:
(WebKit::WebProcessMain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 17:11:07 +0000 (17:11 +0000)]
2010-12-02 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Reject named colors, accept only #rrggbb in <input type=color />
https://bugs.webkit.org/show_bug.cgi?id=50308
* fast/forms/ValidityState-typeMismatch-color-expected.txt:
* fast/forms/script-tests/ValidityState-typeMismatch-color.js: Changed to reject English color names.
2010-12-02 Dai Mikurube <dmikurube@google.com>
Reviewed by Kent Tamura.
Reject named colors, accept only #rrggbb in <input type=color />
https://bugs.webkit.org/show_bug.cgi?id=50308
* html/ColorInputType.cpp: Modified to accept only simple colors like #xxxxxx.
(WebCore::isValidColorString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 2 Dec 2010 17:10:29 +0000 (17:10 +0000)]
2010-12-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Enable DEP at runtime to allow for compatibility with older versions of ATL
https://bugs.webkit.org/show_bug.cgi?id=50378
* WebProcess/win/WebProcessMainWin.cpp:
(WebKit::enableDataExecutionPrevention):
(WebKit::WebProcessMain):
* win/WebKit2WebProcessCommon.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 16:33:11 +0000 (16:33 +0000)]
2010-12-02 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
[chromium] histograms api updated in WebKitClient and added to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=50285
Test by loading "about:histograms" after navigating to accelerated pages.
* platform/chromium/ChromiumBridge.h: api update.
2010-12-02 Vincent Scheib <scheib@chromium.org>
Reviewed by Darin Fisher.
[chromium] histograms api updated in WebKitClient/ChromiumBridge and histogram "GPU.setIsAcceleratedCompositingActive" added.
https://bugs.webkit.org/show_bug.cgi?id=50285
Test by loading "about:histograms" after navigating to accelerated pages.
* public/WebKitClient.h:
(WebKit::WebKitClient::histogramCustomCounts): api update.
(WebKit::WebKitClient::histogramEnumeration): api update.
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::histogramCustomCounts): api update.
(WebCore::ChromiumBridge::histogramEnumeration): api update.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive): "GPU.setIsAcceleratedCompositingActive" added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 16:23:33 +0000 (16:23 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, skip failing test.
* platform/gtk/Skipped: Skip media/video-volume.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Thu, 2 Dec 2010 16:14:56 +0000 (16:14 +0000)]
2010-12-02 Philippe Normand <pnormand@igalia.com>
Unreviewed, unskip passing media tests on GTK.
* platform/gtk/Skipped: Unskip fullscreen video tests, now passing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 16:13:15 +0000 (16:13 +0000)]
Unreviewed. Add Qt specific expected files after r73063.
Make scrolling work properly with writing modes
https://bugs.webkit.org/show_bug.cgi?id=46645
* platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
* platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Copied from LayoutTests/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 2 Dec 2010 16:12:35 +0000 (16:12 +0000)]
2010-12-02 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt][V8] Fix linking of generated sources.
No new tests needed.
* WebCore.pro: add missing V8ImageDataCustom.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Dec 2010 15:55:33 +0000 (15:55 +0000)]
Remove a test that we were only skipping to see if it would fix other tests
It didn't.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 2 Dec 2010 15:51:34 +0000 (15:51 +0000)]
Add some new tests to the mac-wk2 Skipped file
All of the tests depend on EventSender.keyDown.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 2 Dec 2010 15:19:03 +0000 (15:19 +0000)]
2010-12-02 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Adam Roben.
Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGAnimatedString/SVGAnimatedEnumeration
https://bugs.webkit.org/show_bug.cgi?id=50383
Continuing the work on bug 42025: Introduce DECLARE_ANIMATED_(STRING|ENUMERATION) / DEFINE_ANIMATED_(STRING|ENUMERATION).
The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
No functional changes, thus no new tests.
* svg/SVGAElement.cpp:
* svg/SVGAElement.h:
(WebCore::SVGAElement::isValid):
(WebCore::SVGAElement::target):
* svg/SVGAltGlyphElement.cpp:
* svg/SVGAltGlyphElement.h:
* svg/SVGAnimatedEnumeration.h:
* svg/SVGAnimatedString.h:
* svg/SVGClipPathElement.cpp:
* svg/SVGClipPathElement.h:
* svg/SVGComponentTransferFunctionElement.cpp:
* svg/SVGComponentTransferFunctionElement.h:
* svg/SVGCursorElement.cpp:
* svg/SVGCursorElement.h:
* svg/SVGFEBlendElement.cpp:
* svg/SVGFEBlendElement.h:
* svg/SVGFEColorMatrixElement.cpp:
* svg/SVGFEColorMatrixElement.h:
* svg/SVGFEComponentTransferElement.cpp:
* svg/SVGFEComponentTransferElement.h:
* svg/SVGFECompositeElement.cpp:
* svg/SVGFECompositeElement.h:
* svg/SVGFEConvolveMatrixElement.cpp:
* svg/SVGFEConvolveMatrixElement.h:
* svg/SVGFEDiffuseLightingElement.cpp:
* svg/SVGFEDiffuseLightingElement.h:
* svg/SVGFEDisplacementMapElement.cpp:
* svg/SVGFEDisplacementMapElement.h:
* svg/SVGFEGaussianBlurElement.cpp:
* svg/SVGFEGaussianBlurElement.h:
* svg/SVGFEImageElement.cpp:
* svg/SVGFEImageElement.h:
* svg/SVGFELightElement.cpp:
* svg/SVGFEMergeNodeElement.cpp:
* svg/SVGFEMergeNodeElement.h:
* svg/SVGFEMorphologyElement.cpp:
* svg/SVGFEMorphologyElement.h:
* svg/SVGFEOffsetElement.cpp:
* svg/SVGFEOffsetElement.h:
* svg/SVGFESpecularLightingElement.cpp:
* svg/SVGFESpecularLightingElement.h:
* svg/SVGFETileElement.cpp:
* svg/SVGFETileElement.h:
* svg/SVGFETurbulenceElement.cpp:
* svg/SVGFETurbulenceElement.h:
* svg/SVGFilterElement.cpp:
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
* svg/SVGFilterPrimitiveStandardAttributes.h:
* svg/SVGForeignObjectElement.cpp:
* svg/SVGForeignObjectElement.h:
* svg/SVGGradientElement.cpp:
* svg/SVGGradientElement.h:
* svg/SVGImageElement.cpp:
* svg/SVGImageElement.h:
* svg/SVGMPathElement.cpp:
* svg/SVGMPathElement.h:
* svg/SVGMarkerElement.cpp:
* svg/SVGMarkerElement.h:
* svg/SVGMaskElement.cpp:
* svg/SVGMaskElement.h:
* svg/SVGPatternElement.cpp:
* svg/SVGPatternElement.h:
* svg/SVGScriptElement.cpp:
* svg/SVGScriptElement.h:
* svg/SVGStyledElement.cpp:
* svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::hasRelativeLengths):
(WebCore::SVGStyledElement::supportsMarkers):
(WebCore::SVGStyledElement::style):
(WebCore::SVGStyledElement::updateRelativeLengthsInformation):
(WebCore::SVGStyledElement::selfHasRelativeLengths):
(WebCore::SVGStyledElement::isStyled):
* svg/SVGTRefElement.cpp:
* svg/SVGTRefElement.h:
* svg/SVGTextContentElement.cpp:
* svg/SVGTextContentElement.h:
* svg/SVGTextPathElement.cpp:
* svg/SVGTextPathElement.h:
* svg/SVGUseElement.cpp:
* svg/SVGUseElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Thu, 2 Dec 2010 14:28:31 +0000 (14:28 +0000)]
2010-12-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Andreas Kling.
[WX] Remove "current path" of GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=50286
* platform/graphics/GraphicsContext.h:
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 2 Dec 2010 14:11:23 +0000 (14:11 +0000)]
2010-11-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855
Update tests which have changed after fixes to text field layout.
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/basic-textareas-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/input-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-disabled-color-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-paste-undo-expected.txt:
* platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
* platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-spaces-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-double-click-expected.txt:
* platform/gtk/fast/forms/input-text-drag-down-expected.txt:
* platform/gtk/fast/forms/input-text-option-delete-expected.txt:
* platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
* platform/gtk/fast/forms/input-type-change2-expected.txt:
* platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/isindex-placeholder-expected.txt:
* platform/gtk/fast/forms/minWidthPercent-expected.txt:
* platform/gtk/fast/forms/password-placeholder-expected.txt:
* platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
* platform/gtk/fast/forms/placeholder-set-value-expected.txt:
* platform/gtk/fast/forms/placeholder-stripped-expected.txt:
* platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-transformed-expected.txt:
* platform/gtk/fast/forms/search-zoomed-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/text-control-intrinsic-widths-expected.txt:
* platform/gtk/fast/forms/text-style-color-expected.txt:
* platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
* platform/gtk/fast/forms/textarea-align-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
* platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
* platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
* platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
* platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
* platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
* platform/gtk/fast/forms/textarea-width-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/textfield-overflow-expected.txt:
* platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
2010-10-26 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] Text input controls do not react properly to CSS styling
https://bugs.webkit.org/show_bug.cgi?id=40855
Improve text input control rendering. Instead of using the GTK+ border
attributes of the control modify the padding, they modify the border.
Make this same choice for search inputs and text area inputs.
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::setTextInputBorders): Added this helper which sets text input control
borders based on GTK+ theme settings.
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Use the setTextInputBorders helper.
(WebCore::RenderThemeGtk::adjustTextAreaStyle): Ditto.
(WebCore::RenderThemeGtk::adjustSearchFieldStyle): Ditto.
* platform/gtk/RenderThemeGtk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vitalyr@chromium.org [Thu, 2 Dec 2010 14:00:49 +0000 (14:00 +0000)]
2010-12-02 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
[chromium] Updating test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 13:58:13 +0000 (13:58 +0000)]
2010-12-02 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Reintroduce compiler optimizations for JSC
https://bugs.webkit.org/show_bug.cgi?id=50270
Add compiler optimization (symbian ARM target) which was lost after split from WebCore.
Tested via Sunspider and V8 - both of which show significant performance improvement.
* JavaScriptCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 13:39:21 +0000 (13:39 +0000)]
2010-12-02 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
https://bugs.webkit.org/show_bug.cgi?id=50269
* fast/canvas/canvas-lineWidth-intact-after-strokeRect-expected.txt: Added.
* fast/canvas/canvas-lineWidth-intact-after-strokeRect.html: Added.
* fast/canvas/script-tests/canvas-lineWidth-intact-after-strokeRect.js: Added.
2010-12-02 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] GraphicsContext::strokeRect() taints the context's lineWidth
https://bugs.webkit.org/show_bug.cgi?id=50269
Test: fast/canvas/canvas-lineWidth-intact-after-strokeRect.html
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::strokeRect): Restore the context's
original stroke thickness after painting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 2 Dec 2010 13:36:45 +0000 (13:36 +0000)]
2010-12-02 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Move regex parsing and fallback handling to runtime/RegExp.cpp
https://bugs.webkit.org/show_bug.cgi?id=50015
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
(JSC::RegExp::create):
(JSC::RegExp::compile):
(JSC::RegExp::match):
(JSC::RegExp::printTraceData):
* runtime/RegExp.h:
(JSC::RegExp::pattern):
* yarr/RegexInterpreter.cpp:
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::setFallBack):
(JSC::Yarr::RegexCodeBlock::isFallBack):
(JSC::Yarr::executeRegex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Thu, 2 Dec 2010 12:38:13 +0000 (12:38 +0000)]
[Qt] GraphicsContext::clip(path) should clip using winding fill
https://bugs.webkit.org/show_bug.cgi?id=49912
Patch by Renata Hodovan <reni@webkit.org> on 2010-12-02
Reviewed by Andreas Kling.
GraphicsContext::clip(path) now uses winding fill and this function is called by
GraphicsContext::canvasClip(path).
No new test is needed.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 2 Dec 2010 12:33:05 +0000 (12:33 +0000)]
2010-12-02 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, build fix.
* http/tests/inspector/inspect-iframe-from-different-domain.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 2 Dec 2010 11:25:26 +0000 (11:25 +0000)]
2010-12-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Remove obsolete CSS backend API from InspectorDOMAgent
https://bugs.webkit.org/show_bug.cgi?id=50318
WebCore:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/Inspector.idl:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorCSSStore.cpp: Removed.
* inspector/InspectorCSSStore.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::unbind):
* inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
LayoutTests:
* inspector/styles-iframe.html:
* inspector/styles-source-lines.html:
* inspector/styles-source-offsets-expected.txt:
* inspector/styles-source-offsets.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 2 Dec 2010 10:50:33 +0000 (10:50 +0000)]
Unreviewed trivial buildfix after r73117.
* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 10:40:07 +0000 (10:40 +0000)]
2010-12-02 Yuqiang Xian <yuqiang.xian@intel.com>
Reviewed by Pavel Feldman.
[V8] Speed up data property access for ImageData.
https://bugs.webkit.org/show_bug.cgi?id=49999
We create a normal V8 object which has a PixelArray as the backing storage,
and set the "data" property of the ImageData object to it.
This way "data" becomes a pure JS property and we don't need to call through
the C++ bindings for ImageData "data" access.
This eliminates big overhead in switching between JavaScript and native
contexts and performing object bindings.
No new tests. Relying on existing Canvas tests.
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8ImageDataCustom.cpp: Added.
(WebCore::toV8):
* html/ImageData.idl:
* html/canvas/CanvasPixelArray.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 2 Dec 2010 10:23:38 +0000 (10:23 +0000)]
2010-12-02 Kent Tamura <tkent@chromium.org>
Unreviewed. Run sort-Xcode-project-file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 10:12:27 +0000 (10:12 +0000)]
2010-12-02 Mike Lawther <mikelawther@chromium.org>
Reviewed by David Hyatt.
Clean up of iframe scrollbar mode code
https://bugs.webkit.org/show_bug.cgi?id=47797
Pull setChildNeedsLayout/setNeedsLayout calls out of scrollbar mode
calculation method and put back into main layout function.
Early exit from the scrollbar calc when scrollbars are turned off.
* page/FrameView.cpp:
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 2 Dec 2010 09:54:24 +0000 (09:54 +0000)]
2010-12-02 Hironori Bono <hbono@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Fix possible crashes in FontFallbackFont::determinePitch().
https://bugs.webkit.org/show_bug.cgi?id=25770
When all of "Arial", "Courier New", and "Times New Roman" fonts are corrupted,
FontCache::getLastResortFallbackFont() returns 0 and it causes this crash. To
avoid this crash, this change falls back to system fonts (Windows ensures they
are sane) as Win Safari does. Unfortunately, I don't have any ideas how I can
write a layout test for this issue because this crash happens on a PC some of
its system fonts are corrupted.
* platform/graphics/chromium/FontCacheChromiumWin.cpp:
(WebCore::fontDataFromDescriptionAndLogFont):
(WebCore::FontCache::getLastResortFallbackFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Thu, 2 Dec 2010 09:39:19 +0000 (09:39 +0000)]
2010-12-02 Sergio Villar Senin <svillar@igalia.com>
Unreviewed: Added myself to list of Committers.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 2 Dec 2010 09:15:00 +0000 (09:15 +0000)]
2010-12-02 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
Provide means to store shadow DOM nodes on Element
https://bugs.webkit.org/show_bug.cgi?id=48697
Adds shadow DOM awareness to the standard Node attach/detach,
document and tree insertion and removal cycle.
No new tests, because the code is not yet used.
* dom/Element.cpp:
(WebCore::Element::insertedIntoDocument): Added logic to cascade down to shadow DOM, if present.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::insertedIntoTree): Ditto.
(WebCore::Element::removedFromTree): Ditto.
(WebCore::Element::attach): Ditto.
(WebCore::Element::detach): Ditto.
(WebCore::Element::recalcStyle):
(WebCore::Element::shadowRoot): Added.
(WebCore::Element::setShadowRoot): Added.
(WebCore::Element::clearShadowRoot): Added.
* dom/Element.h: Added decls.
* dom/ElementRareData.h: Added a member to hold a RefPtr to the shadow DOM root for the element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 2 Dec 2010 08:18:24 +0000 (08:18 +0000)]
2010-12-02 Daniel Bates <dbates@rim.com>
Add autotools generated files to svn:ignore so that these
files do not show up in an svn stat.
* .: Modified property svn:ignore.
* autotools: Added property svn:ignore.
2010-12-02 Daniel Bates <dbates@rim.com>
Ignore WebKit/gtk/docs/GNUmakefile.in and WebKit/gtk/po/*.pot so that
these files do not appear in an svn stat. This change makes SVN
consistent with the current Git ignore behavior for these files.
* docs: Added property svn:ignore.
* po: Added property svn:ignore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 2 Dec 2010 08:05:30 +0000 (08:05 +0000)]
2010-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Gray-scale JPEG images with a color profile are stretched horizonally
https://bugs.webkit.org/show_bug.cgi?id=49950
Turns out gray-scale JPEGs with color profiles have the same issue as
PNGs. As with PNGs, we suppress now suppress the color profile for
gray-scale JPEGs. Most importantly, this patch adds a test.
Test: fast/images/gray-scale-jpeg-with-color-profile.html
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageReader::decode):
2010-12-02 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Gray-scale JPEG images with a color profile are stretched horizonally
https://bugs.webkit.org/show_bug.cgi?id=49950
Test that we properly render gray-scale JPEGs with embedded color
profiles.
* fast/images/gray-scale-jpeg-with-color-profile.html: Added.
* fast/images/resources/flowchart.jpg: Added.
* platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 2 Dec 2010 07:01:58 +0000 (07:01 +0000)]
2010-12-01 Daniel Bates <dbates@rim.com>
Remove file LayoutTests/platform/gtk/Skipped.rej which was
inadvertently committed in changeset 72675 <http://trac.webkit.org/changeset/72675>.
* platform/gtk/Skipped.rej: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:38:58 +0000 (04:38 +0000)]
Try to fix the GTK build.
* GNUmakefile.am: Use a full path to OSAllocator*.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:28:23 +0000 (04:28 +0000)]
Try to fix the EFL Linux build.
* CMakeListsEfl.txt: Added OSAllocator to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73108
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 2 Dec 2010 04:27:58 +0000 (04:27 +0000)]
2010-12-01 Eric Seidel <eric@webkit.org>
Unreviewed.
compositing/iframes/overlapped-nested-iframes.html is ridiculously flaky
https://bugs.webkit.org/show_bug.cgi?id=50255
Skipping it to stop the madness.
* platform/mac-snowleopard/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73107
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 04:04:55 +0000 (04:04 +0000)]
Try to fix the Qt build: Include all OS files for Qt's sake, and then
use #ifdefs in the files to exclude things based on OS.
This is a pretty bad way to manage platforms -- hopefully we can
fix the Qt build system and move away from this in the future.
* wtf/OSAllocatorPosix.cpp:
* wtf/OSAllocatorSymbian.cpp:
* wtf/OSAllocatorWin.cpp:
* wtf/wtf.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73106
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:50:59 +0000 (03:50 +0000)]
Try to fix the Chromium build.
* JavaScriptCore.gypi: This is a Windows build file, so use OSAllocatorWin.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73105
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:39:01 +0000 (03:39 +0000)]
Try to fix the GTK build.
* GNUmakefile.am: Added OSAllocator to another project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73104
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Thu, 2 Dec 2010 03:31:25 +0000 (03:31 +0000)]
2010-12-01 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] update chromium image test expectations.
* platform/chromium-mac/platform/mac/editing: Added.
* platform/chromium-mac/platform/mac/editing/spelling: Added.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
* platform/chromium-mac/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
* platform/chromium-win/platform/mac/editing/spelling: Added.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.checksum: Added.
* platform/chromium-win/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73103
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:23:29 +0000 (03:23 +0000)]
Try to fix the GTK Linux build.
* JavaScriptCore.gypi: Added OSAllocator to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73102
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:18:20 +0000 (03:18 +0000)]
Try to fix the Qt Linux build.
* wtf/OSAllocatorPosix.cpp: Use the right errno.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73101
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Thu, 2 Dec 2010 03:04:18 +0000 (03:04 +0000)]
Unreviewed. Removing out of date expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73100
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 03:01:03 +0000 (03:01 +0000)]
Try to fix Windows build: export some more symbols.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73099
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 2 Dec 2010 02:56:24 +0000 (02:56 +0000)]
Fix 64-bit build.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::windowAndViewFramesChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73098
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:52:33 +0000 (02:52 +0000)]
Try to fix the Qt Linux build.
* wtf/wtf.pri: Use the POSIX OSAllocator for Qt Linux.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73097
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:42:23 +0000 (02:42 +0000)]
Windows build fix: commit doesn't have a return value.
* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::commit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:36:31 +0000 (02:36 +0000)]
Build fix: Export some symbols.
* JavaScriptCore.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:34:37 +0000 (02:34 +0000)]
Build fix: Added a forwarding header.
JavaScriptGlue:
* ForwardingHeaders/wtf/OSAllocator.h: Added.
WebCore:
* ForwardingHeaders/wtf/OSAllocator.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jparent@chromium.org [Thu, 2 Dec 2010 02:27:27 +0000 (02:27 +0000)]
Unreviewed. Moving test expecation upstream.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:22:18 +0000 (02:22 +0000)]
Build fix.
* JavaScriptCore.xcodeproj/project.pbxproj: Export OSAllocator.h as private
so other projects can see it.
* wtf/OSAllocatorPosix.cpp: #include UnusedParam.h for UNUSED_PARAM.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 2 Dec 2010 02:13:59 +0000 (02:13 +0000)]
Baby step toward a cross-platform virtual memory abstraction: created
an all-static OSAllocator class and changed MarkStack to use it.
Reviewed by Sam Weinig.
* JavaScriptCore.exp: These functions are inlined now.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Added OSAllocatorWin.cpp.
* JavaScriptCore.xcodeproj/project.pbxproj: Added OSAllocatorPosix.cpp.
* runtime/MarkStack.h:
(JSC::MarkStack::allocateStack):
(JSC::MarkStack::releaseStack): Use OSAllocator instead of rolling our
own platform-specific code.
* runtime/MarkStackNone.cpp: Removed. Nothing used this.
* runtime/MarkStackPosix.cpp:
* runtime/MarkStackSymbian.cpp:
* runtime/MarkStackWin.cpp: Removed custom platform-specific code, since
we use the OSAllocator abstraction now.
* wtf/OSAllocator.h: Added.
* wtf/OSAllocatorPosix.cpp: Added.
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):
* wtf/OSAllocatorSymbian.cpp: Added.
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release):
* wtf/OSAllocatorWin.cpp: Added.
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::decommit):
(WTF::OSAllocator::release): The new OSAllocator abstraction.
* wtf/wtf.pri: Added OSAllocatorSymbian.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 2 Dec 2010 01:55:38 +0000 (01:55 +0000)]
Give the fake Carbon window the right bounds
https://bugs.webkit.org/show_bug.cgi?id=50361
Reviewed by Sam Weinig.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::windowAndViewFramesChanged):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
Pass both the window frame and view frame along.
(-[WKView renewGState]):
Call _updateWindowAndViewFrames.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
Pass both the window frame and view frame along.
* UIProcess/WebPageProxy.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
We don't want a title bar in our fake window.
(WebKit::computeFakeWindowBoundsRect):
Compute the fake window bounds.
(WebKit::NetscapePlugin::windowAndViewFramesChanged):
Update the fake window bounds.
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::windowAndViewFramesChanged):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowAndViewFramesChanged):
(WebKit::PluginView::initializePlugin):
* WebProcess/Plugins/PluginView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::windowFrameInScreenCoordinates):
(WebKit::WebPage::viewFrameInWindowCoordinates):
* WebProcess/WebPage/WebPage.messages.in:
Pass both the window frame and view frame along.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Thu, 2 Dec 2010 01:50:40 +0000 (01:50 +0000)]
2010-12-01 Nico Weber <thakis@chromium.org>
More baselines after http://trac.webkit.org/changeset/72689
https://bugs.webkit.org/show_bug.cgi?id=50040
The rebaseline script didn't find these, because they're only wrong
in platform/mac-leopard. I use Snow Leopard, so the script didn't look
there. The bots on the other hand use Leopard, so they complain. I
manually copied the expectations from platfrom/mac to
platform/chromium-mac. Explanation by jamesr.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-10-t-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 2 Dec 2010 01:19:05 +0000 (01:19 +0000)]
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::getGuessesForWord):
* src/EditorClientImpl.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::getGuessesForWord):
* WebCoreSupport/EditorClientQt.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::getGuessesForWord):
* WebCoreSupport/EditorClientGtk.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getGuessesForWord):
* WebCoreSupport/WebEditorClient.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::getGuessesForWord):
* WebKitSupport/EditorClientWx.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.
* WebCoreSupport/WebEditorClient.h: Adopted new signatures defined in base class.
* WebCoreSupport/WebEditorClient.mm: Adopted new signatures defined in base class.
Added code to handle new multiple suggestion canidate panel type.
(WebEditorClient::showCorrectionPanel):
(WebEditorClient::getGuessesForWord):
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/EditorClientHaiku.cpp:
(WebCore::EditorClientHaiku::getGuessesForWord):
* WebCoreSupport/EditorClientHaiku.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::getGuessesForWord):
* WebCoreSupport/EditorClientWinCE.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::getGuessesForWord):
* WebCoreSupport/EditorClientEfl.h:
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Test: platform/mac/editing/spelling/delete-autocorrected-word-1.html
Manual test: WebCore/manual-tests/autocorrection/dismiss-multiple-guesses.html
WebCore/manual-tests/autocorrection/select-from-multiple-guesses.html
This patch is for supporting multiple correction suggestion panel on Mac OS X.
The behavior and implementation is similar to that of reversion candiate panel.
* WebCore.exp.in: Added and removed symbols.
* editing/CorrectionPanelInfo.h: Added new correction panel type, PanelTypeSpellingSuggestions.
* editing/Editor.cpp:
(WebCore::markerTypesForAutocorrection): Convenient function for getting marker types to
be added to autocorrected word.
(WebCore::boundingBoxForRange): Convenient function for calculating the bounding box of a range.
(WebCore::markerTypesForReplacement): Convenient function for getting marker types to
be added to word that has been replaced by various correction panel.
(WebCore::Editor::respondToChangedSelection): Added code to trigger timer for multiple
suggestion panel.
(WebCore::Editor::guessesForMisspelledSelection): Adopted new signature of EditorClient::getGuessesForWord().
(WebCore::Editor::markMisspellingsAfterTypingToWord): Adopted new signature of applyCorrectionPanelInfo().
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.
(WebCore::Editor::correctionPanelTimerFired): Added code to handle new multiple suggestion panel.
(WebCore::Editor::handleCorrectionPanelResult): Replaced handleRejectedCorrection(), since
with new AppKit correction panel API, not only rejection, but also confirmation can be
handled in callback.
(WebCore::Editor::stopCorrectionPanelTimer): Moved the code that clears correction panel info
from dismissCorrectionPanel() to this function to fix a bug that would occur when deleting
autocorrected word.
(WebCore::Editor::dismissCorrectionPanel): Ditto.
(WebCore::Editor::applyCorrectionPanelInfo): Added code to handle new multiple suggestion panel.
* editing/Editor.h: Replaced handleRejectedCorrection() with handleCorrectionPanelResult().
Changed the signature of applyCorrectionPanelInfo() to hanlde new correction panel type.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Adopted new EditorClient::getGuessesForWord().
* editing/TextCheckingHelper.h: Made paragraphRange() public.
* loader/EmptyClients.h:
(WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature defined in base class.
(WebCore::EmptyEditorClient::getGuessesForWord): Ditto.
* manual-tests/autocorrection/dismiss-multiple-guesses.html: Added.
* manual-tests/autocorrection/select-from-multiple-guesses.html: Added.
* page/EditorClient.h: Changed showCorrectionPanel() to allow passing multiple correction
candidates. Changed getGuessesForWord() to allow passing in contextual text for better
correction suggestions (for those spellcheckers that utilizes such contextual information).
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
* platform/mac-leopard/Skipped:
* platform/mac-snowleopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: Added.
* platform/mac/editing/spelling/delete-autocorrected-word-1.html: Added.
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signatures defined in base class.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::getGuessesForWord):
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::showCorrectionPanel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 2 Dec 2010 00:56:25 +0000 (00:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50360
Reviewed by James Robinson.
Make sure to include the origin adjustment code that I added on Mac to keep truncation-rtl.html passing.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 2 Dec 2010 00:23:11 +0000 (00:23 +0000)]
Land Windows specific results for /vertical-scrollbar-in-rtl.html
after r73063.
* platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73086
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 2 Dec 2010 00:14:49 +0000 (00:14 +0000)]
2010-12-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by John Sullivan.
Hit testing broken on sibling views of the WKView
<rdar://problem/8718397>
Make sure that hitView is not null when comparing with the
_layerHostingView.
* UIProcess/API/mac/WKView.mm:
(-[WKView hitTest:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 2 Dec 2010 00:06:51 +0000 (00:06 +0000)]
Implement the remaining PluginController/Plugin member functions
https://bugs.webkit.org/show_bug.cgi?id=50356
Reviewed by Sam Weinig.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::cancelStreamLoad):
(WebKit::PluginControllerProxy::cancelManualStreamLoad):
(WebKit::PluginControllerProxy::setStatusbarText):
(WebKit::PluginControllerProxy::pluginProcessCrashed):
(WebKit::PluginControllerProxy::frameDidFinishLoading):
(WebKit::PluginControllerProxy::frameDidFail):
(WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
(WebKit::PluginControllerProxy::manualStreamDidReceiveData):
(WebKit::PluginControllerProxy::manualStreamDidFinishLoading):
(WebKit::PluginControllerProxy::manualStreamDidFail):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::frameDidFinishLoading):
(WebKit::PluginProxy::frameDidFail):
(WebKit::PluginProxy::manualStreamDidReceiveResponse):
(WebKit::PluginProxy::manualStreamDidReceiveData):
(WebKit::PluginProxy::manualStreamDidFinishLoading):
(WebKit::PluginProxy::manualStreamDidFail):
(WebKit::PluginProxy::windowFrameChanged):
(WebKit::PluginProxy::cancelStreamLoad):
(WebKit::PluginProxy::cancelManualStreamLoad):
(WebKit::PluginProxy::setStatusbarText):
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73083
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 2 Dec 2010 00:03:55 +0000 (00:03 +0000)]
2010-12-01 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
build-webkit --chromium always updates DEPS and re-generates project files
https://bugs.webkit.org/show_bug.cgi?id=50340
Make build-webkit --chromium invoke update-webkit-chromium only when
--update-chromium is passed in, so that we don't add 20 seconds to all
builds.
Making all invocations update was added with r61883, with the goal of
making EWS bots always update. The bots will switch to using this flag
(as will all other webkit-patch build steps) so nothing should change
for them.
* Scripts/webkitdirs.pm:
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/config/ports_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73082
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 2 Dec 2010 00:02:24 +0000 (00:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46645
Reviewed by Dan Bernstein.
Generalize overflow section scrollOriginX code to be a point and to work in both horizontal
and vertical modes.
Not testable yet, since the rightmost/leftmost/topmost/lowestPosition functions are returning
horrendously wrong values in the vertical text case for overflow:auto objects.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateOverflowStatus):
* rendering/RenderLayer.h:
(WebCore::RenderLayer::scrolledContentOffset):
(WebCore::RenderLayer::scrollXOffset):
(WebCore::RenderLayer::scrollYOffset):
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73081
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 1 Dec 2010 23:59:15 +0000 (23:59 +0000)]
2010-12-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Tony Chang.
new-run-webkit-tests: add a --dry-run / -n flag
https://bugs.webkit.org/show_bug.cgi?id=50045
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Wed, 1 Dec 2010 23:58:16 +0000 (23:58 +0000)]
2010-12-01 Alexey Marinichev <amarinichev@chromium.org>
Reviewed by James Robinson.
[chromium] renderer does not realize hardware compositing is disabled and crashes
https://bugs.webkit.org/show_bug.cgi?id=50264
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer): repaint always
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive): null check
(WebKit::WebViewImpl::reallocateRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73079
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 1 Dec 2010 23:55:29 +0000 (23:55 +0000)]
WinCairo build should not use link-time code generation (LTCG)
https://bugs.webkit.org/show_bug.cgi?id=50353
Reviewed by Adam Roben.
JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
WebCore:
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCore.vcproj:
WebKit/win:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
WebKit2:
* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
WebKitTools:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* FindSafari/FindSafari.vcproj:
* MiniBrowser/MiniBrowser.vcproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WinLauncher/WinLauncher.vcproj:
* record-memory-win/record-memory-win.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73078
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
victorw@chromium.org [Wed, 1 Dec 2010 23:32:13 +0000 (23:32 +0000)]
2010-12-01 Victor Wang <victorw@chromium.org>
Unreviewed.
[Chromium] Update chromium test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73077
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 23:23:01 +0000 (23:23 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
adding the file to the sources list was not enough to force the rebuild.
* DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
Remove an empty line at the end of this file to force a rebuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Dec 2010 23:09:38 +0000 (23:09 +0000)]
Don't let harmless errorlevels from the "set" utility leak into project-specific build scripts
When using set to unset an environment variable that didn't previously
exist, set raises the errorlevel to 1. This was leaking into
project-specific scripts, causing them to think the build has failed.
We now clear the errorlevel after we finish setting environment
variables.
Fixes <http://webkit.org/b/50350> Windows builds mysteriously fail in
some configurations
Reviewed by Steve Falkenburg.
* win/tools/vsprops/common.vsprops: Call "cmd /c" after setting
environment variables to get rid of any errorlevel that "set" set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 1 Dec 2010 23:08:52 +0000 (23:08 +0000)]
Teach git to ignore files installed by WebKitSupportLibrary and WebKitAuxiliaryLibrary
Fixes <http://webkit.org/b/50348> Git complains about lots of
untracked files in WebKitLibraries/win
Reviewed by Steve Falkenburg.
* .gitignore: Added files from these libraries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 1 Dec 2010 23:04:01 +0000 (23:04 +0000)]
2010-12-01 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Size changes on layer-backed drawing areas don't always end up with the correct value
https://bugs.webkit.org/show_bug.cgi?id=50351
<rdar://problem/8692966>
When the UI process does not receive didSetSize messages promptly,
LayerBackedDrawingAreaProxy::setSize() bails early based on the
m_isWaitingForDidSetFrameNotification flag.
In this situation, the final size may be incorrect. didSetSize()
needs to compare the size that the web process has to the expected size,
and send a final setSize if they differ.
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::didSetSize):
(WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
* UIProcess/LayerBackedDrawingAreaProxy.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::setSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73073
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 1 Dec 2010 22:44:07 +0000 (22:44 +0000)]
2010-12-01 Tony Chang <tony@chromium.org>
Unreviewed, one more try to get chromium drt bots green.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73072
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 1 Dec 2010 22:27:16 +0000 (22:27 +0000)]
Fix <rdar://problem/8717674>.
Reviewed by Sam Weinig..
* WebProcess/com.apple.WebProcess.sb:
Allow the UI process to issue file-write extensions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:24:31 +0000 (22:24 +0000)]
Fix windows build.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 1 Dec 2010 22:16:34 +0000 (22:16 +0000)]
2010-12-01 Martin Robinson <mrobinson@igalia.com>
Add missing file to the TestNetscapePlugin sources list after r73057.
* GNUmakefile.am: Add missing file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:15:37 +0000 (22:15 +0000)]
Another windows build fix.
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73068
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:08:49 +0000 (22:08 +0000)]
Attempt to fix Windows build.
* UIProcess/API/C/win/WKViewPrivate.cpp:
* UIProcess/API/C/win/WKViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 1 Dec 2010 22:00:01 +0000 (22:00 +0000)]
Add PageGrouping to WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=50332
Reviewed by Anders Carlsson.
WebKit2:
- Adds WKPageGroupRef and WKBundlePageGroupRef API objects
(backed by WebPageGroup and WebPageGroupProxy respectively).
- Moves visibleToInjectedBundle from page to PageGroup.
- Make userScript/userStyleSheet functions take a page group parameter.
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/WebPageGroupData.cpp: Added.
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h: Added.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageGetPageGroup):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageGroup.cpp: Added.
(WKPageGroupGetTypeID):
(WKPageGroupCreateWithIdentifier):
(WKPageGroupCopyIdentifier):
* UIProcess/API/C/WKPageGroup.h: Added.
* UIProcess/API/C/WebKit2.h:
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
* UIProcess/API/C/win/WKView.h:
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView initWithFrame:pageNamespaceRef:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::QWKPagePrivate):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::inspectorPageGroup):
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebPageGroup.cpp: Added.
(WebKit::generatePageGroupID):
(WebKit::webPageGroupMap):
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::get):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
* UIProcess/WebPageGroup.h: Added.
(WebKit::WebPageGroup::identifier):
(WebKit::WebPageGroup::pageGroupID):
(WebKit::WebPageGroup::data):
(WebKit::WebPageGroup::type):
* UIProcess/WebPageNamespace.cpp:
(WebKit::WebPageNamespace::createWebPage):
* UIProcess/WebPageNamespace.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageGroup):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
* UIProcess/win/WebView.h:
(WebKit::WebView::create):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleAddUserScript):
(WKBundleAddUserStyleSheet):
(WKBundleRemoveUserScript):
(WKBundleRemoveUserStyleSheet):
(WKBundleRemoveUserScripts):
(WKBundleRemoveUserStyleSheets):
(WKBundleRemoveAllUserContent):
(WKBundleOverrideXSSAuditorEnabledForTestRunner):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetPageGroup):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundlePageGroup.cpp: Added.
(WKBundlePageGroupGetTypeID):
(WKBundlePageGroupCopyIdentifier):
* WebProcess/InjectedBundle/API/c/WKBundlePageGroup.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner):
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
(WebKit::InjectedBundle::didInitializePageGroup):
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/InjectedBundleClient.cpp:
(WebKit::InjectedBundleClient::didInitializePageGroup):
* WebProcess/InjectedBundle/InjectedBundleClient.h:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
(WebKit::WebPage::close):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::pageGroup):
* WebProcess/WebPage/WebPageGroupProxy.cpp: Added.
(WebKit::WebPageGroupProxy::create):
(WebKit::WebPageGroupProxy::~WebPageGroupProxy):
* WebProcess/WebPage/WebPageGroupProxy.h: Added.
(WebKit::WebPageGroupProxy::identifier):
(WebKit::WebPageGroupProxy::pageGroupID):
(WebKit::WebPageGroupProxy::isVisibleToInjectedBundle):
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
(WebKit::WebPageGroupProxy::type):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
* WebProcess/WebProcess.h:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
WebKitTools:
- Update testing harnesses to deal with new PageGroup API.
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(WKBundleInitialize):
* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::initialize):
(TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):
* TestWebKitAPI/InjectedBundleController.h:
* TestWebKitAPI/InjectedBundleTest.h:
(TestWebKitAPI::InjectedBundleTest::initialize):
(TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
* TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/PlatformWebView.h:
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
* TestWebKitAPI/mac/PlatformWebViewMac.mm:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* TestWebKitAPI/win/PlatformWebViewWin.cpp:
(TestWebKitAPI::PlatformWebView::PlatformWebView):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didInitializePageGroup):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::pageGroup):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::addUserScript):
(WTR::LayoutTestController::addUserStyleSheet):
(WTR::LayoutTestController::setXSSAuditorEnabled):
* WebKitTestRunner/TestController.cpp:
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::PlatformWebView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73066
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 1 Dec 2010 21:53:59 +0000 (21:53 +0000)]
JavaScriptCore: 010-12-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
* JavaScriptCore.vcproj/JavaScriptCore.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCF.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCFLite.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTF.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jsc.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapi.vcproj: Modified property svn:eol-style.
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops: Added property svn:eol-style.
LayoutTests: Bug 50298 - /()()()()()()()()()(?:(\10a|b)(X|Y))+/.exec("bXXaYYaY") ASSERTs
Reviewed by Sam Weinig.
* fast/regex/script-tests/pcre-test-1.js:
Enable regex643, this now works.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 1 Dec 2010 21:49:22 +0000 (21:49 +0000)]
2010-12-01 Ojan Vafai <ojan@chromium.org>
[chromium] Green tree.
-http://trac.webkit.org/changeset/73057 caused plugins/get-user-agent-with-null-npp-from-npp-new.html
-Clean up a couple mistakes from http://trac.webkit.org/changeset/73059
-add a bug ID for fast/regex/pcre-test-1.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 1 Dec 2010 21:31:50 +0000 (21:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=46645
Reviewed by Darin Adler.
Part 1 of making scrolling work with vertical text. This patch generalizes the scrollOriginX concept
recently added for horizontal RTL documents and applies it to writing modes as well. Now the
scrollOrigin is a point, since you can start off locked to the bottom or locked to the right.
This patch also fixes numerous bugs with the scrollOrigin code using native Mac NSScrollViews and
makes them behave the same as the cross-platform code (allowing for cross-platform results to be
landed).
WebCore:
* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
* page/mac/WebCoreFrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::minimumScrollPosition):
(WebCore::ScrollView::valueChanged):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::scrollOrigin):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollPosition):
(WebCore::ScrollView::platformSetScrollOrigin):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxDecorations):
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
(WebCore::RenderView::docTop):
(WebCore::RenderView::docHeight):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docWidth):
* rendering/RenderView.h:
WebKit/mac:
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView adjustForScrollOriginChange]):
(-[WebDynamicScrollBarsView updateScrollers]):
(-[WebDynamicScrollBarsView reflectScrolledClipView:]):
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):
(-[WebDynamicScrollBarsView scrollOrigin]):
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):
LayoutTests:
* fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll-expected.txt: Added.
* fast/dom/vertical-scrollbar-in-rtl-doesnt-fire-onscroll.html: Added.
* fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
* fast/dom/vertical-scrollbar-in-rtl.html: Added.
* fast/dom/vertical-scrollbar-when-dir-change-expected.txt: Added.
* fast/dom/vertical-scrollbar-when-dir-change.html: Added.
* platform/mac/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
* platform/mac/fast/dom/horizontal-scrollbar-when-dir-change-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log