12 years ago Reviewed by Darin Adler.
timothy@apple.com [Thu, 14 Feb 2008 21:00:00 +0000 (21:00 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5743768> A deadlock during storage layout tests

        Make sure not to hold the m_openDatabaseMapGuard mutex when calling
        Database::markAsDeletedAndClose(), since that can cause a deadlock
        during the synchronous DatabaseThread call it triggers.

        * storage/DatabaseTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver.
zimmermann@webkit.org [Thu, 14 Feb 2008 19:45:18 +0000 (19:45 +0000)]
Reviewed by Oliver.
Add dynamic update tests for SVGEllipseElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Improve the efficiency of SecurityOriginHash
aroben@apple.com [Thu, 14 Feb 2008 16:34:28 +0000 (16:34 +0000)]
    Improve the efficiency of SecurityOriginHash

        Reviewed by Alexey.

        * platform/SecurityOriginHash.h:
        (WebCore::SecurityOriginHash::hash): Now takes a const
        RefPtr<SecurityOrigin>& to reduce ref-count churn.
        (WebCore::SecurityOriginHash::equal): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to...
ap@webkit.org [Thu, 14 Feb 2008 15:41:53 +0000 (15:41 +0000)]
    * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to
        the previous check-in, fixing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Thu, 14 Feb 2008 15:36:28 +0000 (15:36 +0000)]
    Reviewed by Adam Roben.

        Database example doesn't work (requires not-yet-released Safari)

        * mac/WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
        if it's too old.

        * win/WebChromeClient.cpp:
        (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
        if it's too old.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCorrect the e-mail address in the ChangeLog.
zecke@webkit.org [Thu, 14 Feb 2008 12:37:44 +0000 (12:37 +0000)]
Correct the e-mail address in the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Make the handling of the coreFrame consistent. We construct the coreFrame
zecke@webkit.org [Thu, 14 Feb 2008 12:27:16 +0000 (12:27 +0000)]
* Make the handling of the coreFrame consistent. We construct the coreFrame
  at the beginning and it will live until the end. Change the g_return_(val_)if
  to ASSERTs as having a 0 coreFrame can never happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Make sure that the WebCore::Frame is living as long as the WebKitWebFrame
zecke@webkit.org [Thu, 14 Feb 2008 12:26:44 +0000 (12:26 +0000)]
* Make sure that the WebCore::Frame is living as long as the WebKitWebFrame
  wrapped around it. All current calls to WebCore::Frame from within the
  WebKitWebFrame are safe, even in the case where the WebCore::Frame is already
  detached from the WebCore::Page.
* For the mainFrame the WebKitWebView is holding the initial reference and
  will unref on destruction.
* For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the
  frame gets detached from the parent.
* Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore::Frame is RefCounted, do not manually delete it!
zecke@webkit.org [Thu, 14 Feb 2008 12:25:59 +0000 (12:25 +0000)]
WebCore::Frame is RefCounted, do not manually delete it!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Plug a leak
zecke@webkit.org [Thu, 14 Feb 2008 12:25:28 +0000 (12:25 +0000)]
* Plug a leak

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Update the Copyright Information
zecke@webkit.org [Thu, 14 Feb 2008 12:24:58 +0000 (12:24 +0000)]
* Update the Copyright Information

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Thu, 14 Feb 2008 05:14:32 +0000 (05:14 +0000)]

        Reviewed by Oliver Hunt.

        Fixes the editing/deleting/5729680.html failure.  It succeeds when run by itself
        but fails when run with other tests because FramePrivate's m_selectionGranularity
        isn't reset when a Frame receives a new document.  It was also uninitialized in
        the constructor.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
        * page/Frame.cpp:
        (WebCore::FramePrivate::FramePrivate): Ditto.


        Reviewed by Oliver Hunt.

        * platform/mac/editing/deleting/table-cells-expected.checksum: Fixed.  Before, a space was
        incorrectly removed by a delete (this isn't a smart delete).
        * platform/mac/editing/deleting/table-cells-expected.png:
        * platform/mac/editing/deleting/table-cells-expected.txt:
        * platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed.  Before a space
        was incorrectly added by paste (this isn't a smart paste).
        * platform/mac/editing/pasteboard/input-field-1-expected.png:
        * platform/mac/editing/pasteboard/input-field-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-13 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Thu, 14 Feb 2008 02:13:53 +0000 (02:13 +0000)]
2008-02-13  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Anders.

        <rdar://problem/5739282> Hangs after closing video trailer popup with
        VLC plugin

        VLC hangs on NPP_Destroy if we call NPP_SetWindow with a null window

        * plugins/PluginQuirkSet.h: Added new quirk
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::stop): Selectively call NPP_SetWindow.
        (WebCore::PluginView::determineQuirks): Set new quirk for VLC plug-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
sfalken@apple.com [Thu, 14 Feb 2008 00:15:30 +0000 (00:15 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning
sfalken@apple.com [Thu, 14 Feb 2008 00:07:07 +0000 (00:07 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Wed, 13 Feb 2008 23:51:30 +0000 (23:51 +0000)]
2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Fix non-SVG builds.

        * css/CSSCursorImageValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Wed, 13 Feb 2008 22:58:37 +0000 (22:58 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Wed, 13 Feb 2008 22:00:09 +0000 (22:00 +0000)]

        Reviewed by Adam Roben.

        <rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

        * editing/Editor.cpp:
        (WebCore::Editor::deleteWithDirection): Fixed a typo.


        Reviewed by Adam Roben.

        <rdar://problem/5729680> REGRESSION (r27873): Removing the last character of a word in Mail or Safari also removes the following space

        * editing/deleting/5729680-expected.txt: Added.
        * editing/deleting/5729680.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Adam.
zimmermann@webkit.org [Wed, 13 Feb 2008 21:56:23 +0000 (21:56 +0000)]
Reviewed by Adam.
Make svg/dynamic-updates/* tests deterministic. s/setTimeout('executTest()', 0)/executeTest/ -- as discussed with Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Oliver.
zimmermann@webkit.org [Wed, 13 Feb 2008 21:49:41 +0000 (21:49 +0000)]
Reviewed by Oliver.

Actually fix the manual-tests/svg-cursor-changes.svg testcase.
I only reran layout tests when fixing the last issues with the patch,
instead of trying the manual-test :( Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Wed, 13 Feb 2008 21:31:35 +0000 (21:31 +0000)]
    Windows build fix

        * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows/GTK+ build fixes
aroben@apple.com [Wed, 13 Feb 2008 21:19:31 +0000 (21:19 +0000)]
Windows/GTK+ build fixes


        Windows build fix

        * css/CSSCursorImageValue.cpp: #include MathExtras.h to get roundf.


        Windows/GTK+ build fix

        * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
        get isnan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Darin & Eric.
zimmermann@webkit.org [Wed, 13 Feb 2008 20:41:47 +0000 (20:41 +0000)]
Reviewed by Darin & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17258 (SVG uses erroneous cursor implementation)

SVG cursors are not well-integrated within the CSS(3) cursor support in WebCore.
SVGCursorElement duplicates CSSCursorImageValue functionality and inherits from
CachedResourceClient itself, handling remote-image acquisation on its own.

RenderStyle's CursorData class holds "IntPoint hotSpot", "CachedImage* image"
and just for SVG a 'String cursorFragmentId' (a reference to a SVG <cursor> element, by id).

SVG stores a reference to a SVGCursorElement, which holds a CachedImage pointer itself -
instead of storing the CachedImage in the CursorData class, as it's supposed to be.
Because of that several places in WebCore contain special SVG cursor handling - which
is unneeded.

Fix all issues by integrating within CSSCursorImageValue, remove 'String cursorFragmentId'
from RenderStyle, kill any special SVG cursor handling in WebCore and fix dynamic attribute
changes through DOM / SVG DOM (scripting of 'x' / 'y' / 'xlink:href' attribute).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 13 Feb 2008 20:14:21 +0000 (20:14 +0000)]
2008-02-13  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Split out pure-cairo Font code to FontCairo.cpp.

        Part of the ongoing work to share code with the Win port.

        * GNUmakefile.am:
        * WebCore.pro:
        * platform/graphics/cairo/FontCairo.cpp: Added.
        * platform/graphics/gtk/FontGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase
adachan@apple.com [Wed, 13 Feb 2008 19:34:47 +0000 (19:34 +0000)]
    <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase

        Reviewed by Darin.

        * WebIconDatabase.cpp:
        (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag,
        which already has a ref count of 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
beidson@apple.com [Wed, 13 Feb 2008 18:47:14 +0000 (18:47 +0000)]

        Reviewed by Darin Adler

        Add some much needed Database support to DRT

        * DumpRenderTree/LayoutTestController.cpp:
        (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
          databases are called
        (clearAllDatabasesCallback): Allow a test to delete all databases
        (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get

        * DumpRenderTree/LayoutTestController.h:

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out
        (LayoutTestController::setDatabaseQuota): Ditto
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::clearAllDatabases): Stubbed out with error message
        (LayoutTestController::setDatabaseQuota): Ditto

        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
          message with details about the event then return a 5mb quota like before


        Reviewed by Darin Adler

        Added layout tests to cover

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * storage/quota-tracking-expected.txt: Added.
        * storage/quota-tracking.html: Added.
        * storage/success-callback-expected.txt: Added.
        * storage/success-callback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix issues with the paint origin when using wxGCDC, with computing the font platform...
kevino@webkit.org [Wed, 13 Feb 2008 17:49:28 +0000 (17:49 +0000)]
Fix issues with the paint origin when using wxGCDC, with computing the font platform data hash, and Win and wxPython bindings compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-13 Rodney Dawes <dobey@wayofthemonkey.com>
aroben@apple.com [Wed, 13 Feb 2008 17:28:37 +0000 (17:28 +0000)]
2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>

Fix Bug 17220: Illogical dependency between PluginView and PluginDatabase


        Fix Bug 17220: Illogical dependency between PluginView and


        Reviewed by Adam and Darin.

        Rename PluginDatabase::createPluginView to PluginView::create, to make
        the illogical dependency between the two, logical
        Make PluginDatabase::findPlugin a public method
        Update the includes in PluginView and PluginDatabase for the change

        * plugins/PluginDatabase.h:
        * plugins/PluginView.h:
        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginViewWin.cpp:


        Fix Bug 17220: Illogical dependency between PluginView and


        Reviewed by Adam and Darin.

        Update for the rename of PluginDatabase::createPluginView
        to PluginView::create

        * WebFrame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fixes
aroben@apple.com [Wed, 13 Feb 2008 17:20:47 +0000 (17:20 +0000)]
Windows build fixes


        Build fix

        * platform/graphics/cg/GraphicsContextCG.cpp: Added missing #include.


        Windows build fix

        * Interfaces/WebKit.idl: Create the typelib version symbol ourselves.


        * win/tools/scripts/auto-version.sh: Removed a redundant symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-13 Alp Toker <alp@atoker.com>
alp@webkit.org [Wed, 13 Feb 2008 16:29:00 +0000 (16:29 +0000)]
2008-02-13  Alp Toker  <alp@atoker.com>

        Reviewed by Adam Roben.

        Fix very small, upside down, inside out text on GTK+/DirectFB.

        Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>

        Test the result of gdk_screen_get_resolution() and use a default
        fallback in case of failure.

        Also remove an unhelpful runtime warning.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
darin@apple.com [Wed, 13 Feb 2008 15:56:30 +0000 (15:56 +0000)]
    * platform/mac/svg/hixie/perf/001-expected.txt: Removed.
        * platform/mac/svg/hixie/perf/002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Not reviewed, build fix.
pewtermoose@webkit.org [Wed, 13 Feb 2008 15:29:11 +0000 (15:29 +0000)]
    Not reviewed, build fix.

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 14:25:29 +0000 (14:25 +0000)]
    - try to fix Wx build

        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::paintBuffer): Added missing paintingDisabled() check.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::paintBuffer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix Wx build
darin@apple.com [Wed, 13 Feb 2008 13:33:44 +0000 (13:33 +0000)]
    - try to fix Wx build

        * platform/wx/LocalizedStringsWx.cpp: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Wed, 13 Feb 2008 13:26:40 +0000 (13:26 +0000)]

        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * WebCore.base.exp: Rolled out change.
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Ditto. But keep the initialization of
        (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
        * page/Settings.h:
        (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.


        - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Removed the Xcode-specific quirk at the request of some folks on the Xcode team.

        * Misc/WebKitVersionChecks.h: Removed the constant.

        * WebView/WebView.mm:
        (-[WebView _needsXcodeVisibilityQuirk]): Removed.
        (-[WebView _preferencesChangedNotification:]): Removed call to

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Wed, 13 Feb 2008 12:51:41 +0000 (12:51 +0000)]
    Reviewed by Darin.

        <rdar://problem/5740042> Database termination issues

        Test: storage/close-during-stress-test.html

        * dom/Document.cpp:
        * dom/Document.h:
        Don't re-create the database thread if it has been already terminated.

        * storage/Database.h: (WebCore::Database::document): Changed m_database to a RefPtr to avoid
        having a hanging reference.

        * storage/DatabaseThread.cpp:

        * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::~SQLTransaction): Removed logging.
        Transactions are deleted during GC, so it's usually not importatnt to know when it happens.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - check in results for these tests
darin@apple.com [Wed, 13 Feb 2008 12:33:24 +0000 (12:33 +0000)]
    - check in results for these tests

        No idea if these are right or not; just what was generated on my computer.
        If someone has a better version, feel free to replace these results with correct ones.

        * platform/mac/svg/hixie/perf/001-expected.txt: Added.
        * platform/mac/svg/hixie/perf/002-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:27:46 +0000 (12:27 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17340
          WebCore/platform/Timer.cpp fails to build with gcc 4.3

        * platform/Timer.cpp: Add include of <limits.h> since this file uses UINT_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
darin@apple.com [Wed, 13 Feb 2008 12:10:00 +0000 (12:10 +0000)]
    Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=17339
          JavaScriptCore does not build with gcc 4.3

        * kjs/interpreter.cpp: Add include of <unistd.h>, since that's where
        getpid() comes from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
oliver@apple.com [Wed, 13 Feb 2008 09:51:59 +0000 (09:51 +0000)]
<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoComment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818...
timothy@apple.com [Wed, 13 Feb 2008 06:32:27 +0000 (06:32 +0000)]
Comment out the ASSERT to make the layout tests pass. Filed <rdar://problem/5739818> to track the issue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady Eidson.
timothy@apple.com [Wed, 13 Feb 2008 06:04:19 +0000 (06:04 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5652560> Can't delete database if the website that
        uses it has been opened in this session

        Close the Database on the database thread before deleting the file.
        Tested and works on Windows and Mac.

        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::close): Assert we are on the opening thread.
        * storage/Database.cpp:
        (WebCore::Database::markAsDeletedAndClose): Unschedule any pending
        Database tasks, and start and imediate DatabaseCloseTask.
        (WebCore::Database::close): Close the SQLDatabase.
        * storage/Database.h: Renamed markAsDeleted to markAsDeletedAndClose.
        * storage/DatabaseTask.cpp:
        (WebCore::DatabaseCloseTask::DatabaseCloseTask): New task.
        (WebCore::DatabaseCloseTask::doPerformTask): Call close on the Database.
        (WebCore::DatabaseCloseTask::debugTaskName): Return "DatabaseCloseTask".
        * storage/DatabaseTask.h: Add DatabaseCloseTask.
        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::deleteDatabaseFile): Call the renamed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEndeavour to fix qt and gtk builds
oliver@apple.com [Wed, 13 Feb 2008 04:22:25 +0000 (04:22 +0000)]
Endeavour to fix qt and gtk builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clean up auto-version.sh a bit
aroben@apple.com [Wed, 13 Feb 2008 03:07:15 +0000 (03:07 +0000)]
     Clean up auto-version.sh a bit

         It now does quite a bit less file I/O and many fewer fork/exec pairs.
         It's also quite a bit easier to read.

         Reviewed by Steve.

         * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Use a precompiled header to build WebKit.
sfalken@apple.com [Wed, 13 Feb 2008 02:53:48 +0000 (02:53 +0000)]
    Use a precompiled header to build WebKit.

        Reviewed by Adam.

        * WebKit.vcproj/WebKit.vcproj:
        * WebKitPrefix.cpp: Added.
        * WebKitPrefix.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBug 17269: Deobfuscate CanvasRenderingContext2D.cpp
oliver@apple.com [Wed, 13 Feb 2008 02:11:55 +0000 (02:11 +0000)]
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Remove ifdef's from canvas paint code

Reviewed by Eric S.

By making GraphicsContext aware of the crossplatform ImageBuffer
type we can migrate the ifdef-ified paint code in HTMLCanvasElement
into platform implementations of GraphicsContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler
beidson@apple.com [Wed, 13 Feb 2008 01:10:42 +0000 (01:10 +0000)]
    Reviewed by Darin Adler

        Fix for <rdar://problem/5737692> - Database API needs to support SuccessCallback

        Layout tests will come shortly with a mess of DRT changes

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin): Standardize on "empty string" instead of null string
          as different paths of constructing a SecurityOrigin were causing different hashes for the "same"

        * storage/Database.cpp:
        (WebCore::Database::changeVersion): Pass in the successCallback
        (WebCore::Database::transaction): Ditto

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::performNextStep): Update ASSERTs for the new valid steps
        (WebCore::SQLTransaction::performPendingCallback): Ditto
        (WebCore::SQLTransaction::postflightAndCommit): Schedule the success callback if it exists - otherwise
          skip straight to cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::deliverSuccessCallback): Deliver success callback on the main thread, then
          schedule cleanupAfterSuccessCallback()
        (WebCore::SQLTransaction::cleanupAfterSuccessCallback): Cleanup and end the transaction
        * storage/SQLTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Versioning script change.
sfalken@apple.com [Wed, 13 Feb 2008 00:18:33 +0000 (00:18 +0000)]
    Versioning script change.

        * win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:39 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * bindings/scripts/CodeGeneratorCOM.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:27 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * Drosera/win/BaseDelegate.h:
        * Drosera/win/DebuggerClient.cpp:
        * Drosera/win/DebuggerDocumentPlatform.cpp:
        * Drosera/win/Drosera.cpp:
        * Drosera/win/ServerConnection.cpp:
        * Drosera/win/ServerConnection.h:
        * DumpRenderTree/win/DumpRenderTree.cpp:
        * DumpRenderTree/win/EditingDelegate.h:
        * DumpRenderTree/win/EventSender.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        * DumpRenderTree/win/FrameLoadDelegate.h:
        * DumpRenderTree/win/GCControllerWin.cpp:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        * DumpRenderTree/win/PolicyDelegate.h:
        * DumpRenderTree/win/ResourceLoadDelegate.h:
        * DumpRenderTree/win/UIDelegate.cpp:
        * DumpRenderTree/win/UIDelegate.h:
        * DumpRenderTree/win/WorkQueueItemWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Changes to support merged MIDL output.
sfalken@apple.com [Wed, 13 Feb 2008 00:16:05 +0000 (00:16 +0000)]
    Changes to support merged MIDL output.

        All COM interfaces are now generated to WebKit.h.

        Reviewed by Sam, Ada.

        * DOMCSSClasses.h:
        * DOMCoreClasses.h:
        * DOMEventsClasses.h:
        * DOMHTMLClasses.h:
        * DefaultDownloadDelegate.h:
        * DefaultPolicyDelegate.cpp:
        * DefaultPolicyDelegate.h:
        * GEN_DOMObject.h:
        * Interfaces/DOMCSS.idl:
        * Interfaces/DOMCore.idl:
        * Interfaces/DOMEvents.idl:
        * Interfaces/DOMExtensions.idl:
        * Interfaces/DOMHTML.idl:
        * Interfaces/DOMPrivate.idl:
        * Interfaces/DOMRange.idl:
        * Interfaces/DOMWindow.idl:
        * Interfaces/IGEN_DOMObject.idl:
        * Interfaces/IWebArchive.idl:
        * Interfaces/IWebBackForwardList.idl:
        * Interfaces/IWebBackForwardListPrivate.idl:
        * Interfaces/IWebCache.idl:
        * Interfaces/IWebDataSource.idl:
        * Interfaces/IWebDatabaseManager.idl:
        * Interfaces/IWebDocument.idl:
        * Interfaces/IWebDownload.idl:
        * Interfaces/IWebEditingDelegate.idl:
        * Interfaces/IWebError.idl:
        * Interfaces/IWebErrorPrivate.idl:
        * Interfaces/IWebFormDelegate.idl:
        * Interfaces/IWebFrame.idl:
        * Interfaces/IWebFrameLoadDelegate.idl:
        * Interfaces/IWebFrameLoadDelegatePrivate.idl:
        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/IWebFrameView.idl:
        * Interfaces/IWebHTMLRepresentation.idl:
        * Interfaces/IWebHTTPURLResponse.idl:
        * Interfaces/IWebHistory.idl:
        * Interfaces/IWebHistoryItem.idl:
        * Interfaces/IWebHistoryItemPrivate.idl:
        * Interfaces/IWebIconDatabase.idl:
        * Interfaces/IWebInspector.idl:
        * Interfaces/IWebJavaScriptCollector.idl:
        * Interfaces/IWebKitStatistics.idl:
        * Interfaces/IWebMutableURLRequest.idl:
        * Interfaces/IWebMutableURLRequestPrivate.idl:
        * Interfaces/IWebNotification.idl:
        * Interfaces/IWebNotificationCenter.idl:
        * Interfaces/IWebNotificationObserver.idl:
        * Interfaces/IWebPolicyDelegate.idl:
        * Interfaces/IWebPreferences.idl:
        * Interfaces/IWebPreferencesPrivate.idl:
        * Interfaces/IWebResource.idl:
        * Interfaces/IWebResourceLoadDelegate.idl:
        * Interfaces/IWebResourceLoadDelegatePrivate.idl:
        * Interfaces/IWebScriptCallFrame.idl:
        * Interfaces/IWebScriptDebugListener.idl:
        * Interfaces/IWebScriptDebugServer.idl:
        * Interfaces/IWebScriptObject.idl:
        * Interfaces/IWebScriptScope.idl:
        * Interfaces/IWebScrollBarDelegatePrivate.idl:
        * Interfaces/IWebScrollBarPrivate.idl:
        * Interfaces/IWebSecurityOrigin.idl:
        * Interfaces/IWebTextRenderer.idl:
        * Interfaces/IWebUIDelegate.idl:
        * Interfaces/IWebUIDelegatePrivate.idl:
        * Interfaces/IWebURLAuthenticationChallenge.idl:
        * Interfaces/IWebURLRequest.idl:
        * Interfaces/IWebURLResponse.idl:
        * Interfaces/IWebURLResponsePrivate.idl:
        * Interfaces/IWebUndoManager.idl:
        * Interfaces/IWebUndoTarget.idl:
        * Interfaces/IWebView.idl:
        * Interfaces/IWebViewPrivate.idl:
        * Interfaces/WebKit.idl:
        * WebActionPropertyBag.cpp:
        * WebBackForwardList.h:
        * WebCache.h:
        * WebDataSource.cpp:
        * WebDataSource.h:
        * WebDatabaseManager.h:
        * WebDownload.h:
        * WebEditorClient.cpp:
        * WebEditorClient.h:
        * WebError.h:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebFramePolicyListener.h:
        * WebHTMLRepresentation.cpp:
        * WebHTMLRepresentation.h:
        * WebHistory.cpp:
        * WebHistory.h:
        * WebHistoryItem.h:
        * WebIconDatabase.h:
        * WebInspector.h:
        * WebJavaScriptCollector.h:
        * WebKit.vcproj/Interfaces.vcproj:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKitDLL.cpp:
        * WebKitStatistics.h:
        * WebMutableURLRequest.cpp:
        * WebMutableURLRequest.h:
        * WebNotification.h:
        * WebNotificationCenter.h:
        * WebPreferences.h:
        * WebResource.h:
        * WebScriptCallFrame.h:
        * WebScriptDebugServer.cpp:
        * WebScriptDebugServer.h:
        * WebScriptDebugger.cpp:
        * WebScriptDebugger.h:
        * WebScriptObject.h:
        * WebScrollBar.h:
        * WebSecurityOrigin.h:
        * WebTextRenderer.h:
        * WebURLAuthenticationChallenge.h:
        * WebURLAuthenticationChallengeSender.h:
        * WebURLCredential.h:
        * WebURLProtectionSpace.h:
        * WebURLResponse.h:
        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 23:54:39 +0000 (23:54 +0000)]
    Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17041
          <rdar://problem/5709660> Eastern Asian fonts do not display without specific box in Control Panel

        Revised the system fallback font lookup logic to use MLang font linking
        again. To avoid reintroducing bug 16548 and <rdar://problem/5280188>,
        for CJK characters, try linking based on a single code page at a time,
        starting with the user's default code page (if it is one of the CJK
        code pages) followed by the other CJK code pages in a prescribed order
        that matches what Firefox does.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::getCJKCodePageMasks): Added. Returns the search order for CJK
        code pages, with the user's default code page first.
        (WebCore::currentFontContainsCharacter): Factored out of
        (WebCore::createMLangFont): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
andersca@apple.com [Tue, 12 Feb 2008 23:34:04 +0000 (23:34 +0000)]
    Reviewed by Adam.

        Implement imageTitle.

        * WebCoreLocalizedStrings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady Eidson.
weinig@apple.com [Tue, 12 Feb 2008 21:29:51 +0000 (21:29 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5659216> REGRESSION: PLT 0.3% slower due to r28868 (caching ClassNodeList and NamedNodeList)

        - Tweak the statements in isASCIISpace to account for the statistical distribution of
          usage in the PLT.

        .4% speedup on my machine.  Stephanie's machine shows this as .3% speedup.

        * wtf/ASCIICType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Adam Roben.
mitz@apple.com [Tue, 12 Feb 2008 21:17:47 +0000 (21:17 +0000)]
    Rubber-stamped by Adam Roben.

        - make fast/css/css3-nth-child pass

        * fast/css/css3-nth-child.html: Removed spaces that were making the
        :nth-child selector fail to parse because of <rdar://problem/5733761>.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.checksum: Added.
        * platform/mac-leopard/fast/css/css3-nth-child-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-12 Rodney Dawes <dobey@wayofthemonkey.com>
alp@webkit.org [Tue, 12 Feb 2008 21:04:50 +0000 (21:04 +0000)]
2008-02-12  Rodney Dawes  <dobey@wayofthemonkey.com>

        Reviewed by Alp Toker.

        Add -DMAEMO_CHANGES when the hildon CONFIG option is specified
        Add hildon-1 to PKGCONFIG when hildon CONFIG option is specified

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Timothy Hatcher.
mitz@apple.com [Tue, 12 Feb 2008 20:13:46 +0000 (20:13 +0000)]
    Reviewed by Timothy Hatcher.

        - <rdar://problem/5738175> Remove workaround for <rdar://problem/5539388> from post-Tiger builds

        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Release build fix
beidson@apple.com [Tue, 12 Feb 2008 20:11:55 +0000 (20:11 +0000)]
    Release build fix

        * storage/DatabaseTask.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady.
ap@webkit.org [Tue, 12 Feb 2008 19:37:03 +0000 (19:37 +0000)]
    Reviewed by Brady.

        <rdar://problem/5729619> Storage tasks are getting lost

        <rdar://problem/5729445> REGRESSION: Cannot schedule more than one transaction at a time

        <rdar://problem/5729446> Major thread safety issue in Database code

        * platform/MessageQueue.h: Added a thread-safe queue abstraction.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Added MessageQueue.h.

        * dom/Document.cpp:
        (WebCore::Document::~Document): Fixed a race condition resulting in a hanging reference.

        * storage/Database.idl: Fixed parameter declarations to actually match implementation
        (which is custom, so it got out of sync).

        * storage/DatabaseTask.h:
        Changed tasks to hold more information internally. Added helpers for better debug logging.

        * storage/DatabaseTask.cpp:
        Implementation for the above.

        Fixed a potential race condition: if the task completed before we entered a wait, we'd never
        wake up. There was an assertion guarding against this, but no actual guarantee that I could see.

        * storage/DatabaseThread.cpp:
        * storage/DatabaseThread.h:
        Changed to use MessageQueue.

        * storage/Database.cpp:
        * storage/Database.h:
        Changed m_transactionQueue to a MessageQueue.
        Got rid of callback tracking - these can take care of themselves.
        Got rid of a DatabaseThread member, as the Document can be asked for it.
        Moved private static members and helpers out of the header.
        Lost CurrentThreadSetter debug helper on the way. We may need to re-add something like that later.

        * storage/SQLTransaction.h:
        * storage/SQLTransaction.cpp: Added a lot of debug logging.
        (WebCore::SQLTransaction::scheduleToRunStatements): Removed "m_currentStatement = 0" assignment,
        as it created a race condition. Everything seems to work better without it, although a real fix
        would be to get rid of this variable - it's evil shared data that isn't even protected in any way.

        * manual-tests/database-threading-stress-test-2.html: Added.
        * manual-tests/database-threading-stress-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows
aroben@apple.com [Tue, 12 Feb 2008 19:29:52 +0000 (19:29 +0000)]
 Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows


         Fix Bug 17328: REGRESSION (r30147): Inspector is unstyled on Windows


         Reviewed by Mitz.

         Test: fast/loader/local-css-allowed-in-strict-mode.html

         * platform/network/cf/ResourceResponseCFNet.cpp:
         (WebCore::ResourceResponse::doUpdateResourceResponse): Add a case for
         .css files.


         Add a test for Bug 17328: REGRESSION (r30147): Inspector is unstyled
         on Windows


         Reviewed by Mitz.

         * fast/loader/local-css-allowed-in-strict-mode-expected.txt: Added.
         * fast/loader/local-css-allowed-in-strict-mode.html: Added.
         * fast/loader/resources/stylesheet.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
andersca@apple.com [Tue, 12 Feb 2008 19:17:24 +0000 (19:17 +0000)]
    Build fix.

        * loader/ImageDocument.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix tyop.
andersca@apple.com [Tue, 12 Feb 2008 18:53:03 +0000 (18:53 +0000)]
Fix tyop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Tue, 12 Feb 2008 18:51:16 +0000 (18:51 +0000)]

        Reviewed by Mitz.

        Make the code that sets the image title cross platform.

        * WebCore.xcodeproj/project.pbxproj:
        Remove ImageDocumentMac.

        * loader/ImageDocument.cpp:

        * loader/mac/ImageDocumentMac.h: Removed.
        * loader/mac/ImageDocumentMac.mm: Removed.

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreViewFactory.h:
        Move imageTitleForFilename:size from the bridge to
        the view factory.

        * platform/LocalizedStrings.h:
        Add imageTitle.

        * platform/mac/LocalizedStringsMac.mm:
        Have imageTitle call the view factory.

        * platform/qt/Localizations.cpp:
        * platform/wx/LocalizedStringsWx.cpp:
        * platform/gtk/LocalizedStringsGtk.cpp:
        Add stubs.


        Reviewed by Mitz.

        * WebCoreSupport/WebFrameBridge.mm:
        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory imageTitleForFilename:size:]):
        Move implementatino from WebFrameBridge to WebViewFactory.


        Reviewed by Mitz.

        * WebCoreLocalizedStrings.cpp:
        Add stub.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed, adding missing layout test results (that have been r+ already, but...
zimmermann@webkit.org [Tue, 12 Feb 2008 13:23:04 +0000 (13:23 +0000)]
Not reviewed, adding missing layout test results (that have been r+ already, but not commited)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agomore Qt fixes
oliver@apple.com [Tue, 12 Feb 2008 09:40:04 +0000 (09:40 +0000)]
more Qt fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoYet another attempt to fix Qt
oliver@apple.com [Tue, 12 Feb 2008 09:30:30 +0000 (09:30 +0000)]
Yet another attempt to fix Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAttempt to fix qt build
oliver@apple.com [Tue, 12 Feb 2008 09:21:02 +0000 (09:21 +0000)]
Attempt to fix qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake canvas use an ImageBuffer for its backing store
oliver@apple.com [Tue, 12 Feb 2008 09:14:25 +0000 (09:14 +0000)]
Make canvas use an ImageBuffer for its backing store

Reviewed by Alp Toker.

In order to make the canvas implementation less platform dependent
(and thus reduce the current quagmire of ifdefs) we now use an
ImageBuffer to provide the backing buffer, an immediate consequence
of this is to remove multiple ifdefs in the construction of the
buffer.  This patch allows us to further reduce the platform
dependencies in later patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 12 Feb 2008 06:02:57 +0000 (06:02 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17320
          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

        Test: fast/css/last-child-style-sharing.html

        * css/CSSGrammar.y: Changed to call setUsesSiblingRules(true) for all
        CSS3 selectors that require it.


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17320
          <rdar://problem/5736953> :last-child does not set the "uses sibling rules" flag

        * fast/css/last-child-style-sharing.html: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.checksum: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.png: Added.
        * platform/mac/fast/css/last-child-style-sharing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
weinig@apple.com [Tue, 12 Feb 2008 01:24:02 +0000 (01:24 +0000)]
    Reviewed by Anders Carlsson.

        Fixes for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        - Expose the native Object.prototype.toString implementation so that it can be used for cross-domain
          toString calling.

        * JavaScriptCore.exp:
        * kjs/object_object.cpp:
        * kjs/object_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 12 Feb 2008 00:26:21 +0000 (00:26 +0000)]

        Reviewed by Darin Adler.

        Make the cross-domain security model more closely match Firefox by always returning the
        native built-in functions when accessing functions cross-domain.

        Fixes for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        Tests: fast/dom/Window/window-custom-prototype-crash.html

        * bindings/js/JSDOMWindowCustom.cpp:
        - Return the native-built in version of an cross-domain allowed function (eg. window.focus) whether or
          not it has been overridden, instead of undefined.
        - When doing findEntry lookup, use the the tables directly (JSDOMWindowPrototype::info.propHashTable)
          instead of calling the virtual classInfo() method to avoid the unnecessary overhead.
        - Allow access to the native toString function cross-domain.  It always returns "[object Window]".
        - Use the new nonCachingStaticFunctionGetter when return allowed functions cross-frame so that
          the function an overridden function is not inadvertantly returned from the PropertyMap.\

        * bindings/js/JSHistoryCustom.cpp:
        - Implement the same model as described above for the History object, always returning the
          native built-in function cross-domain.
        - Allow access to the native toString function cross-domain.
        - Clean up the code to make it clear that the custom functionality is only there for cross-domain

        * bindings/js/JSLocation.cpp:
        - Match the generated classes by moving all the custom logic into a separate customGetOwnPropertySlot
          function.  This will help moving to a generated class in the future.
        - Implement the same model as described above for the Location object, always returning the
          native built-in function cross-domain.
        - Clean up the code to make it clear that the custom functionality is only there for cross-domain
        * bindings/js/JSLocation.h:
        - Clean up to match the rest of the file a little better.

        * bindings/js/kjs_binding.cpp:
        * bindings/js/kjs_binding.h:
        - Put common functionality related to cross-domain access here to serve as a central shared point.
          This includes moving and augmenting the allowsAccessFromFrame method that was in both JSHistoryCustom.cpp
          and JSLocation.cpp.

        * bindings/js/kjs_dom.cpp:
        - Use the new allowsAccessFromFrame method.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::childFrameGetter): Cleanup.
        (KJS::Window::namedItemGetter): Cleanup.
        - Do the prototype lookup early to match Firefox in having function lookup have a higher precedence
          than the index or shortcut name getters.
        - Cleanup function to make it more understandable and slightly more efficient.
        - Add a new variant of this method that takes a reference to a String, which, on failure, will
          contain the error message to print out.  The caller can then pass this to printErrorMessage.
          This allows for code to check allowsAccessFrom and act on the result without printing out the
          error message. For convenience, a version with out the String parameter has been left which
          prints out the message automatically.
        * bindings/js/kjs_window.h:


        Reviewed by Darin Adler.

        Tests for:
        <rdar://problem/5735497> Match Firefox's cross-domain model more accurately by return the built-in version of functions even if they have been overridden
        <rdar://problem/5735443> Crash when setting the Window objects prototype to a custom Object and then calling a method on it

        * fast/dom/Window/resources/WindowProperties.js: Added.
        * fast/dom/Window/window-custom-prototype-crash-expected.txt: Added.
        * fast/dom/Window/window-custom-prototype-crash.html: Added.
        * fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Added.
        * fast/dom/Window/window-function-frame-getter-precedence.html: Added.
        * fast/dom/Window/window-function-name-getter-precedence-expected.txt:
        * fast/dom/Window/window-function-name-getter-precedence.html:
        * http/tests/security/cross-frame-access-custom-expected.txt:
        * http/tests/security/cross-frame-access-custom.html:
        * http/tests/security/cross-frame-access-get-override-expected.txt: Added.
        * http/tests/security/cross-frame-access-get-override.html: Added.
        * http/tests/security/cross-frame-access-history-get-override-expected.txt:
        * http/tests/security/cross-frame-access-history-get-override.html:
        * http/tests/security/cross-frame-access-history-put-expected.txt:
        * http/tests/security/cross-frame-access-history-put.html:
        * http/tests/security/cross-frame-access-location-expected.txt: Removed.
        * http/tests/security/cross-frame-access-location-get-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-get-override-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-get-override.html: Added.
        * http/tests/security/cross-frame-access-location-get.html: Copied from http/tests/security/cross-frame-access-location.html.
        * http/tests/security/cross-frame-access-location-put-expected.txt: Added.
        * http/tests/security/cross-frame-access-location-put.html: Added.
        * http/tests/security/cross-frame-access-location.html: Removed.
        * http/tests/security/resources/cross-frame-iframe-for-get-override-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-get-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
        * http/tests/security/resources/cross-frame-iframe-for-location-get-override-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-location-get-test.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-location-put-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin@apple.com [Tue, 12 Feb 2008 00:16:44 +0000 (00:16 +0000)]

        Reviewed by Mitz.

        - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Added an Xcode-specific quirk.

        * WebCore.base.exp: Added export for new Settings function.
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk.
        If you try to change the visibilty on a node with the class name tab_content,
        instead it will use display:none.
        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also
        initialize m_fontRenderingMode! This seems like it was a bug before, but we
        probably were getting lucky and always getting 0 on Windows, which is the
        only place the setting matters.
        (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
        * page/Settings.h:
        (WebCore::Settings::needsXcodeVisibilityQuirk): Added.


        Reviewed by Mitz.

        - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
          incorrectly due to visibility fix

        Added an Xcode-specific quirk.

        * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
        part of the check.

        * WebView/WebView.mm:
        (-[WebView _needsXcodeVisibilityQuirk]): Added.
        (-[WebView _preferencesChangedNotification:]): Added a call to
        setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-11 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
alp@webkit.org [Mon, 11 Feb 2008 23:38:37 +0000 (23:38 +0000)]
2008-02-11  Pierre-Luc Beaudoin  <pierre-luc.beaudoin@collabora.co.uk>

        Reviewed by Alp Toker.

        Add my blog's WebKit category, English only posts.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady Eidson.
timothy@apple.com [Mon, 11 Feb 2008 22:54:53 +0000 (22:54 +0000)]
    Reviewed by Brady Eidson.

        <rdar://problem/5733069> Many m_quotaMap uses do not hold the m_quotaMapGuard

        * storage/DatabaseTracker.cpp:
        (WebCore::DatabaseTracker::hasEntryForOrigin): Hold m_quotaMapGuard when using m_quotaMap.
        (WebCore::DatabaseTracker::origins): Ditto.
        (WebCore::DatabaseTracker::setQuota): Ditto.
        (WebCore::DatabaseTracker::deleteAllDatabases): Call origins() and itterate over the
        origins to call deleteOrigin().
        (WebCore::DatabaseTracker::deleteOrigin): Hold m_quotaMapGuard when using m_quotaMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for bug 17286, crash accessing a null RenderStyle. Add a simple null...
hyatt@apple.com [Mon, 11 Feb 2008 21:19:01 +0000 (21:19 +0000)]
    Fix for bug 17286, crash accessing a null RenderStyle.  Add a simple null check.

        Reviewed by aroben

        Added fast/css/empty-generated-content.html

        * css/CSSStyleSelector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by David Kilzer.
rwlbuis@webkit.org [Mon, 11 Feb 2008 21:04:20 +0000 (21:04 +0000)]
    Reviewed by David Kilzer.

        Bug 17201: Use RefPtr in CSSParser::parseFont() to get rid of goto silliness

        Gets rid of goto usage in parseFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBack out accidental checkin to HTMLMediaElement.cpp.
hyatt@apple.com [Mon, 11 Feb 2008 20:26:40 +0000 (20:26 +0000)]
Back out accidental checkin to HTMLMediaElement.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for bug 16798.
hyatt@apple.com [Mon, 11 Feb 2008 20:22:08 +0000 (20:22 +0000)]
Add layout test for bug 16798.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for bug 16798.
hyatt@apple.com [Mon, 11 Feb 2008 20:21:50 +0000 (20:21 +0000)]
Add layout test for bug 16798.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@30148 268f45cc-cd09-0410...
hyatt@apple.com [Mon, 11 Feb 2008 20:18:12 +0000 (20:18 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for bug 17298, Acid3 text should be black and not red. Make sure stylesh...
hyatt@apple.com [Mon, 11 Feb 2008 20:17:36 +0000 (20:17 +0000)]
    Fix for bug 17298, Acid3 text should be black and not red.  Make sure stylesheets with the wrong MIME type
        are not accepted in strict mode.

        Reviewed by darin

        Added http/tests/misc/css-reject-in-strict-mode.html

        * css/CSSImportRule.cpp:
        * css/CSSImportRule.h:
        * dom/Document.cpp:
        * dom/Document.h:
        * dom/ProcessingInstruction.cpp:
        * dom/ProcessingInstruction.h:
        * html/HTMLLinkElement.cpp:
        * html/HTMLLinkElement.h:
        * html/HTMLMediaElement.cpp:
        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedResourceClient.h:
        * loader/mac/UserStyleSheetLoader.cpp:
        * loader/mac/UserStyleSheetLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 14316: Inspector's Console truncates long strings
aroben@apple.com [Mon, 11 Feb 2008 19:58:18 +0000 (19:58 +0000)]
    Fix Bug 14316: Inspector's Console truncates long strings


        We no longer call Object.describe to format all the output of commands
        enetered into the Console. The ConsolePanel object now has a set of
        formatting functions that append a formatted representation of the
        passed-in object to the passed-in container node.

        Reviewed by Sam.

        * page/inspector/ConsolePanel.js:
        (WebInspector.ConsolePanel._onEnterPressed): Updated for rename of
        _outputToNode to _format.
        (WebInspector.ConsolePanel._format): Renamed from _outputToNode. Use
        Object.type to get the type of the object, then call the appropriate
        formatting function.
        (WebInspector.ConsolePanel._formatvalue): Added.
        (WebInspector.ConsolePanel._formatstring): Added. This function
        contains the actual fix for the bug, since it doesn't truncate the
        string no matter how long it is.
        (WebInspector.ConsolePanel._formatregexp): Added.
        (WebInspector.ConsolePanel._formatarray): Added. This is a bit more
        functional than Object.describe for arrays, since it recursively
        formats each item in the array. One advantage of this is that Nodes in
        arrays will be linkified instead of just turning into "[Object
        HTMLBodyElement]" or similar.
        (WebInspector.ConsolePanel._formatnode): Added.
        (WebInspector.ConsolePanel._formatobject): Added.
        * page/inspector/utilities.js:
        (Object.type): Added. Code was pulled out of Object.describe and
        reorganized slightly.
        (Object.describe): Call Object.type. There should be no change in
        behavior of this function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 18:09:59 +0000 (18:09 +0000)]
2008-02-11  Alp Toker  <alp@atoker.com>

        Wx build fix for breakage introduced in r30142. Spotted by Darin.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add Brent Fulgham's blog
aroben@apple.com [Mon, 11 Feb 2008 17:44:34 +0000 (17:44 +0000)]
    Add Brent Fulgham's blog

        Rubberstamped by Alp.

        * config.ini:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed and tweaked by Darin
darin@apple.com [Mon, 11 Feb 2008 17:38:10 +0000 (17:38 +0000)]
    Reviewed and tweaked by Darin

        - http://bugs.webkit.org/show_bug.cgi?id=17299
          a couple compilation fixes for Cairo/Win32 configuration

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::createDecoder): Turn off XBMImageDecoder for PLATFORM(WIN) configuration.
        * rendering/RenderThemeWin.cpp:
        (WebCore::prepareForDrawing): Added IntRect parameter.
        (WebCore::doneDrawing): Ditto.
        (WebCore::RenderThemeWin::paintButton): Ditto.
        (WebCore::RenderThemeWin::paintTextField): Ditto.
        (WebCore::RenderThemeWin::paintMenuListButton): Ditto.
        (WebCore::RenderThemeWin::systemFont): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-11 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 16:56:25 +0000 (16:56 +0000)]
2008-02-11  Alp Toker  <alp@atoker.com>

        Reviewed by Alexey.

        Acid3 data URL parsing fix for the GTK+ port.

        Avoid WebCore's base64Decode() when possible since it's not a
        general-purpose Base64 decoder and fails on newlines.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - another Qt build fix
darin@apple.com [Mon, 11 Feb 2008 15:33:07 +0000 (15:33 +0000)]
    - another Qt build fix

        * platform/qt/PopupMenuQt.cpp:
        (WebCore::PopupMenu::PopupMenu): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by Eric.
darin@apple.com [Mon, 11 Feb 2008 07:40:49 +0000 (07:40 +0000)]
    Rubber stamped by Eric.

        * kjs/ExecState.h:
        (KJS::ExecState::takeException): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - another Qt build fix (wish the Qt bot wouldn't stop on the first error)
darin@apple.com [Mon, 11 Feb 2008 07:38:36 +0000 (07:38 +0000)]
    - another Qt build fix (wish the Qt bot wouldn't stop on the first error)

        * platform/qt/FileChooserQt.cpp:
        (WebCore::FileChooser::FileChooser): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - another Qt fix
darin@apple.com [Mon, 11 Feb 2008 07:03:29 +0000 (07:03 +0000)]
    - another Qt fix

        * platform/graphics/qt/IconQt.cpp:
        (WebCore::Icon::Icon): Added explicit RefCounted constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 06:09:20 +0000 (06:09 +0000)]
2008-02-10  Alp Toker  <alp@atoker.com>

        Another Win build fix for r30133 breakage.

        * plugins/win/PluginPackageWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-02-10 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 11 Feb 2008 05:50:45 +0000 (05:50 +0000)]
2008-02-10  Alp Toker  <alp@atoker.com>

        Build fix GTK+ and prospective build fix for Win breakage introduced
        in r30133.

        * platform/Cursor.h:
        * platform/graphics/gtk/IconGtk.cpp:
        * platform/gtk/FileChooserGtk.cpp:
        * platform/gtk/PopupMenuGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - try to fix Win, Qt, GTK, and WX builds
darin@apple.com [Mon, 11 Feb 2008 04:17:24 +0000 (04:17 +0000)]
    - try to fix Win, Qt, GTK, and WX builds

        * platform/Cursor.h:
        (WebCore::SharedCursor::SharedCursor): Added explicit RefCounted constructor.
        * platform/graphics/win/IconWin.cpp:
        (WebCore::Icon::Icon): Ditto.
        * platform/win/FileChooserWin.cpp:
        (WebCore::FileChooser::FileChooser): Ditto.
        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::PopupMenu): Ditto.
        * platform/wx/TemporaryLinkStubs.cpp:
        (FileChooser::FileChooser): Ditto.
        (PopupMenu::PopupMenu): Ditto.
        (Icon::Icon): Ditto.
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::PluginStream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig and Anders Carlsson.
mitz@apple.com [Mon, 11 Feb 2008 03:41:36 +0000 (03:41 +0000)]
    Reviewed by Sam Weinig and Anders Carlsson.

        - change a test to simply use 'font-family' instead of unnecessary
          @font-face hackery

        * fast/text/atsui-spacing-features.html:
        * platform/mac/fast/text/atsui-spacing-features-expected.checksum:
        * platform/mac/fast/text/atsui-spacing-features-expected.png:
        * platform/mac/fast/text/atsui-spacing-features-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
darin@apple.com [Mon, 11 Feb 2008 02:03:31 +0000 (02:03 +0000)]

        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          eliminate default ref. count of 0 in RefCounted class

        * wtf/RefCounted.h:
        (WTF::RefCounted::RefCounted): Remove default of 0.


        Reviewed by Eric.

        - http://bugs.webkit.org/show_bug.cgi?id=17256
          eliminate default ref. count of 0 in RefCounted class

        * WebKitSupport/FrameLoaderClientWx.cpp:
        Set the count to 0 explicitly (one stray client I missed in my last pass).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Oliver Hunt.
mitz@apple.com [Sun, 10 Feb 2008 23:17:02 +0000 (23:17 +0000)]
    Reviewed by Oliver Hunt.

        - fix a memory leak

        * DumpRenderTree/cg/ImageDiffCG.cpp:
        (getDifferenceBitmap): Use a static CFMutableData instead of allocating
        and leaking the buffer each time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate test results for iframe fix.
hyatt@apple.com [Sun, 10 Feb 2008 23:08:26 +0000 (23:08 +0000)]
Update test results for iframe fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for bug 17082, cssRules should be live.
hyatt@apple.com [Sun, 10 Feb 2008 22:33:00 +0000 (22:33 +0000)]
    Fix for bug 17082, cssRules should be live.

        Reviewed by olliej

        Added fast/css/live-cssrules.html

        * css/CSSRuleList.cpp:
        * css/CSSRuleList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for bug 17082.
hyatt@apple.com [Sun, 10 Feb 2008 22:31:50 +0000 (22:31 +0000)]
Add layout test for bug 17082.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for bug 17082.
hyatt@apple.com [Sun, 10 Feb 2008 22:31:32 +0000 (22:31 +0000)]
Add layout test for bug 17082.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30128 268f45cc-cd09-0410-ab3c-d52691b4dbfc