WebKit-https.git
11 years ago2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 25 Apr 2009 00:05:38 +0000 (00:05 +0000)]
2009-04-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Gustavo Noronha.

        Fix braces to comply with style guidelines.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getClipboard):
        (WebKit::PasteboardHelperGtk::getCopyTargetList):
        (WebKit::PasteboardHelperGtk::getPasteTargetList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Sergio García-Cuevas <sergio_gcg@telefonica.net>
jmalonzo@webkit.org [Sat, 25 Apr 2009 00:05:21 +0000 (00:05 +0000)]
2009-04-24  Sergio García-Cuevas  <sergio_gcg@telefonica.net>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Copy the link location to the primary selection as well as the
        clipboard selection when using the "copy link selection" context
        menu entry.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeURL):
        * platform/gtk/PasteboardHelper.h:

2009-04-24  Sergio García-Cuevas  <sergio_gcg@telefonica.net>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=17267
        [GTK] Primary selection/clipboard support

        Add a method for getting the primary selection.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        (WebKit::PasteboardHelperGtk::getPrimary):
        * WebCoreSupport/PasteboardHelperGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Fri, 24 Apr 2009 23:54:33 +0000 (23:54 +0000)]
    Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=25383
        Changing SVG size via JS does not update CSS width/height

        Add an ugly hack to fix CSS width/height updates from JS.

        We can't easily call setAttribute when width/height changes
        as that would cause infinite recursion (as we'd try to set
        the animation storage from the attributes)

        For now, when we get notification that JS changed width/height
        we copy what parseMappedAttribute does and update the CSS values as well.

        A better fix for this would be:
        https://bugs.webkit.org/show_bug.cgi?id=25383

        * svg/SVGSVGElement.cpp:
        (WebCore::updateCSSForAttribute):
        (WebCore::SVGSVGElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 24 Apr 2009 23:51:47 +0000 (23:51 +0000)]
2009-04-24  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Sam "Wesley" Weinig.

        Improve performance to YARR interpreter.
        (From about 3x slower than PCRE on regex-dna to about 30% slower).

        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::checkCharacter):
        (JSC::Yarr::Interpreter::checkCasedCharacter):
        (JSC::Yarr::Interpreter::backtrackPatternCharacter):
        (JSC::Yarr::Interpreter::backtrackPatternCasedCharacter):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::matchParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionBegin):
        (JSC::Yarr::Interpreter::backtrackParentheticalAssertionEnd):
        (JSC::Yarr::Interpreter::matchDisjunction):
        (JSC::Yarr::Interpreter::interpret):
        (JSC::Yarr::ByteCompiler::atomPatternCharacter):
        (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin):
        (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin):
        (JSC::Yarr::ByteCompiler::closeAlternative):
        (JSC::Yarr::ByteCompiler::closeBodyAlternative):
        (JSC::Yarr::ByteCompiler::atomParenthesesEnd):
        (JSC::Yarr::ByteCompiler::regexBegin):
        (JSC::Yarr::ByteCompiler::regexEnd):
        (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction):
        (JSC::Yarr::ByteCompiler::alterantiveDisjunction):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        * yarr/RegexInterpreter.h:
        (JSC::Yarr::ByteTerm::):
        (JSC::Yarr::ByteTerm::ByteTerm):
        (JSC::Yarr::ByteTerm::BodyAlternativeBegin):
        (JSC::Yarr::ByteTerm::BodyAlternativeDisjunction):
        (JSC::Yarr::ByteTerm::BodyAlternativeEnd):
        (JSC::Yarr::ByteTerm::AlternativeBegin):
        (JSC::Yarr::ByteTerm::AlternativeDisjunction):
        (JSC::Yarr::ByteTerm::AlternativeEnd):
        (JSC::Yarr::ByteTerm::SubpatternBegin):
        (JSC::Yarr::ByteTerm::SubpatternEnd):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
        * yarr/RegexPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Apr 2009 23:41:05 +0000 (23:41 +0000)]
2009-04-24  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan Bernstein.

        We should not show the deletion UI for blockquotes in mail but they do
        show now that we only check for one visible border.

        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Rob Raguet-Schofield <ragfield@gmail.com>
mrowe@apple.com [Fri, 24 Apr 2009 23:28:45 +0000 (23:28 +0000)]
2009-04-24  Rob Raguet-Schofield  <ragfield@gmail.com>

        Rubber-stamped by Mark Rowe.

        * wtf/CurrentTime.h: Fix a typo in a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - address Hyatt's review comments on the last patch
mitz@apple.com [Fri, 24 Apr 2009 23:05:21 +0000 (23:05 +0000)]
    - address Hyatt's review comments on the last patch

        * rendering/RenderLayer.cpp:
        (WebCore::performOverlapTests):
        (WebCore::RenderLayer::paintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Fri, 24 Apr 2009 23:00:05 +0000 (23:00 +0000)]
    Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=5909
          <rdar://problem/5863349> overlapping element leaves trail when
          scrolling iframe

        * WebCore.xcodeproj/project.pbxproj: Added OverlapTestRequestClient.h.

        * page/FrameView.cpp:
        (WebCore::FrameView::reset): Initialize m_isOverlapped.
        (WebCore::FrameView::useSlowRepaints): Also check m_isOverlapped.
        (WebCore::FrameView::removeSlowRepaintObject): Use useSlowRepaints()
        so overlapping is taken into account.
        (WebCore::FrameView::setIsOverlapped): Added. Sets m_isOverlapped and
        enables or disables copy-on-scroll accordingly.

        * page/FrameView.h:
        Added setIsOverlapped() and m_isOverlapped.

        * rendering/OverlapTestRequestClient.h: Added. During foreground painting,
        an OverlapTestRequestClient can make a request to test if any subsequently-
        painted layers overlap a rect. The test result is delivered to the
        requestClient via setOverlapTestResult().
        (WebCore::OverlapTestRequestClient::~OverlapTestRequestClient):

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paint): Pass an OverlapTestRequestMap to
        paintLayer(). When done painting, inform any remaining requestClients that
        they are not overlapped.

        (WebCore::RenderLayer::paintLayer): Take an OverlapTestRequestMap and
        pass it down to child and reflection layers. Inform requestClients if this
        layer overlaps their requested rects.

        * rendering/RenderLayer.h:

        * rendering/RenderObject.h:
        (WebCore::RenderObject::PaintInfo::PaintInfo): Added an
        OverlapTestRequestMap member.

        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint): For now, pass a 0 OverlapTestRequestMap
        to paintLayer().

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint): For FrameViews, request an overlap test
        with the frame.
        (WebCore::RenderWidget::setOverlapTestResult): Call
        FrameView::setIsOverlapped() with the result of the overlap test.

        * rendering/RenderWidget.h: Made RenderWidget an OverlapTestRequestClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>
simon.fraser@apple.com [Fri, 24 Apr 2009 22:52:45 +0000 (22:52 +0000)]
2009-04-24  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser

        https://bugs.webkit.org/show_bug.cgi?id=25380

        Fixed a race condition on the first 'played' attribute test start.

        Previously we were starting nearly right away to play, and probably
        before receiving the 'canplay' event. Now we ensure we'll wait for
        that 'canplay' event before attempting to play.

        * media/video-played-expected.txt: Updated
        * media/video-played.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 24 Apr 2009 22:45:04 +0000 (22:45 +0000)]
2009-04-24  Geoffrey Garen  <ggaren@apple.com>

        Rubber stamped by Eric Seidel.

        Updated test to turn the buildbot green after Eric's last check-in.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 24 Apr 2009 22:30:31 +0000 (22:30 +0000)]
2009-04-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Simon Fraser, Dan Bernstein.

        Speed up the PLT by devirtualizing the height() function on InlineBox.  virtualizing it in order to make the height() computation dynamic caused
        a ~0.5% slowdown.  This patch does the following to get the speed back:

        (a) Devirtualizes isText and forces inline box creators to set the bit as needed.  This actually resulted in simplified code, since ListMarkerBox could
        then be removed.
        (b) Reduces the height() call count.  In some cases the code was repeatedly calling height(), which used to be fine when the function was just an inline
        member variable access.  The call sites have been patched to cut down on extra height() calls now that it is more expensive.
        (c) Devirtualize height() except on SVG boxes.  For all non-SVG, the height() function on InlineBox handles the computation.  For SVG boxes, a new bit has
        been set on InlineBoxes (isSVG()) that indicates that the virtual svgBoxHeight() function should be called to retrieve the height instead.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::height):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):
        (WebCore::InlineBox::isSVG):
        (WebCore::InlineBox::setIsSVG):
        (WebCore::InlineBox::isText):
        (WebCore::InlineBox::setIsText):
        (WebCore::InlineBox::svgBoxHeight):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        * rendering/InlineTextBox.cpp:
        * rendering/InlineTextBox.h:
        * rendering/ListMarkerBox.cpp: Removed.
        * rendering/ListMarkerBox.h: Removed.
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::createInlineBox):
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createFlowBox):
        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::createTextBox):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::createRootBox):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::createInlineTextBox):
        * rendering/RootInlineBox.cpp:
        * rendering/RootInlineBox.h:
        * rendering/SVGInlineFlowBox.h:
        (WebCore::SVGInlineFlowBox::svgBoxHeight):
        * rendering/SVGInlineTextBox.h:
        (WebCore::SVGInlineTextBox::svgBoxHeight):
        * rendering/SVGRootInlineBox.h:
        (WebCore::SVGRootInlineBox::svgBoxHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
eric@webkit.org [Fri, 24 Apr 2009 22:25:20 +0000 (22:25 +0000)]
    Reviewed by Adam Roben.

        Add PrettyPatch support to run-webkit-tests

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix
oliver@apple.com [Fri, 24 Apr 2009 22:09:42 +0000 (22:09 +0000)]
Build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 24 Apr 2009 22:00:44 +0000 (22:00 +0000)]
2009-04-24  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25370
        Introduce ScriptEventListener to refactor away direct references to
        JSLazyEventListener in WebCore code.

        * GNUmakefile.am: Added ScriptEventListener to project.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSDOMGlobalObject.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/JSLazyEventListener.cpp: Moved createAttributeEventListener helpers
            to ScriptEventListener.
        * bindings/js/JSLazyEventListener.h: Ditto.
        * bindings/js/ScriptController.cpp: Removed unused JSLazyEventListener include.
        * bindings/js/ScriptEventListener.cpp: Added.
        * bindings/js/ScriptEventListener.h: Added.
        * bindings/v8/ScriptEventListener.cpp: Added.
        * bindings/v8/ScriptEventListener.h: Added.
        * dom/Document.cpp: Renamed JSLazyEventListener include to ScriptEventListener.
        * html/HTMLBodyElement.cpp: Ditto.
        * html/HTMLButtonElement.cpp: Ditto.
        * html/HTMLElement.cpp: Ditto.
        * html/HTMLFormElement.cpp: Ditto.
        * html/HTMLFrameElementBase.cpp: Ditto.
        * html/HTMLFrameSetElement.cpp: Ditto.
        * html/HTMLImageElement.cpp: Ditto.
        * html/HTMLInputElement.cpp: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLScriptElement.cpp: Ditto.
        * html/HTMLSelectElement.cpp: Ditto.
        * html/HTMLTextAreaElement.cpp: Ditto.
        * svg/SVGElement.cpp: Ditto.
        * svg/SVGSVGElement.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6050421> JavaScript register file should remap to release physical...
oliver@apple.com [Fri, 24 Apr 2009 21:53:46 +0000 (21:53 +0000)]
<rdar://problem/6050421> JavaScript register file should remap to release physical pages accumulated during deep recursion

Reviewed by Geoff Garen

We now track the maximum extent of the RegisterFile, and when we reach the final
return from JS (so the stack portion of the registerfile becomes empty) we see
if that extent is greater than maxExcessCapacity.  If it is we use madvise or
VirtualFree to release the physical pages that were backing the excess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 24 Apr 2009 21:52:16 +0000 (21:52 +0000)]
2009-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 25355: Crash when Creating New Tab or New Window when set to open Same Page
        https://bugs.webkit.org/show_bug.cgi?id=25355
        rdar://problem/6823543

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadItem): Added a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Fri, 24 Apr 2009 21:34:52 +0000 (21:34 +0000)]
    Reviewed by Simon Fraser.

        Fix RenderSVGImage to dump with full bounds and style information.
        https://bugs.webkit.org/show_bug.cgi?id=25377

        No functional changes, we're just now including more info in render tree dumps.

        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGImage):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::isSVGImage):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::write):
        * rendering/SVGRenderTreeAsText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 24 Apr 2009 21:30:48 +0000 (21:30 +0000)]
2009-04-24  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6761635>.

        Make sure to keep an extra reference to the instance proxy in case the plug-in host crashes while
        we're waiting for a reply.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 24 Apr 2009 21:18:24 +0000 (21:18 +0000)]
2009-04-24  David Levin  <levin@chromium.org>

        Reviewed by NOBODY (chromium build fix).

        Rename "isInline" => "isAttribute" in v8 bindings (jsc was done in r42699).

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::invokeEventHandler):
        * bindings/v8/V8AbstractEventListener.h:
        * bindings/v8/V8EventListenerList.cpp:
        (WebCore::V8EventListenerList::add):
        (WebCore::V8EventListenerList::remove):
        (WebCore::V8EventListenerList::clear):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::virtualisAttribute):
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):
        (WebCore::V8EventListener::virtualisAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Johan Bilien <jobi@via.ecp.fr>
xan@webkit.org [Fri, 24 Apr 2009 21:16:45 +0000 (21:16 +0000)]
2009-04-24  Johan Bilien  <jobi@via.ecp.fr>

        Reviewed by Xan Lopez.

        https://bugs.webkit.org/show_bug.cgi?id=25373
        Popup menu has the wrong size when popped up near the edge
        of the screen

        * webkit/webkitwebview.cpp:
        (webkit_web_view_forward_context_menu_event): Let GTK place
        the popup menu instead of trying to do better and failing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com>
simon.fraser@apple.com [Fri, 24 Apr 2009 20:48:08 +0000 (20:48 +0000)]
2009-04-24  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser

        <rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit

        Use better mp4 test file for media tests. The original mp4 file had an unusual
        edit (non-zero start time) which is not supported by all media engines. The new
        movie should also give more useful pixel test results.

        * media/content/test.mp4: Update the movie.
        * media/progress-event-total-expected.txt: Update test results to match movie duration and
        content changes.
        * media/progress-event-total.html: Ditto.
        * media/video-currentTime-set-expected.txt: Ditto.
        * media/video-loop-expected.txt: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
        * platform/mac/media/video-aspect-ratio-expected.png: Ditto.
        * platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
        * platform/mac/media/video-controls-rendering-expected.png: Ditto.
        * platform/mac/media/video-display-toggle-expected.checksum: Ditto.
        * platform/mac/media/video-display-toggle-expected.png: Ditto.
        * platform/mac/media/video-empty-source-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.checksum: Ditto.
        * platform/mac/media/video-layer-crash-expected.png: Ditto.
        * platform/mac/media/video-transformed-expected.checksum: Ditto.
        * platform/mac/media/video-transformed-expected.png: Ditto.
        * platform/mac/media/video-zoom-expected.checksum: Ditto.
        * platform/mac/media/video-zoom-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix nightly for Windows x64 users.
sfalken@apple.com [Fri, 24 Apr 2009 20:08:16 +0000 (20:08 +0000)]
    Fix nightly for Windows x64 users.
        Installed browser location is written to a slightly different registry key in that case.

        * FindSafari/FindSafari.cpp:
        (getInstalledWebKitDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Apr 2009 19:13:52 +0000 (19:13 +0000)]
2009-04-24  Kevin McCullough  <kmccullough@apple.com>

        When I moved the files I forgot to update the location of the image!

        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Nate Chapin <japhet@google.com>
dglazkov@chromium.org [Fri, 24 Apr 2009 18:43:47 +0000 (18:43 +0000)]
2009-04-24  Nate Chapin  <japhet@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25343
        Fix Chromium/Skia bug where -webkit-box-shadow with 0,0 offset
        ignores blur.

        * WebCore\platform\graphics\skia\GraphicsContextSkia.cpp
         (WebCore::GraphicsContext::setPlatformShadow): Add check against
         blur before clearing looper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Apr 2009 18:41:20 +0000 (18:41 +0000)]
2009-04-24  Kevin McCullough  <kmccullough@apple.com>

        - Build fix.  Removed this test until I can figure out why it's failing.

        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Fri, 24 Apr 2009 18:40:28 +0000 (18:40 +0000)]
WebCore:

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Initialize TextIterator::m_textLength to 0.

        This assures that TextIterator::length() will return 0 for cases when TextIterator's constructor returns early (because there is nothing to iterate over in the range).

        <https://bugs.webkit.org/show_bug.cgi?id=25335>

        Test: editing/selection/doubleclick-whitespace-img-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::TextIterator):

LayoutTests:

2009-04-24  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Add a test for <https://bugs.webkit.org/show_bug.cgi?id=25335>.

        To pass, this test must not access invalid memory when run (won't necessarily manifest as a crash for failures).

        * editing/selection/doubleclick-whitespace-img-crash-expected.txt: Added.
        * editing/selection/doubleclick-whitespace-img-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Apr 2009 18:38:41 +0000 (18:38 +0000)]
2009-04-24  Simon Fraser  <simon.fraser@apple.com>

        Source changes reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=22242

        Update WebKitSystemInterface for Mac with fixes for video controller drawing.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Fumitoshi Ukai <ukai@google.com>
dglazkov@chromium.org [Fri, 24 Apr 2009 18:36:08 +0000 (18:36 +0000)]
2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25329
        Add indexed access method in v8 binding of ClientRectList.

        * bindings/v8/custom/V8ClientRectListCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Fri, 24 Apr 2009 18:32:48 +0000 (18:32 +0000)]
WebCore:

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Use null for unspecified event listener attributes of XMLHttpRequest
        and XMLHttpRequestUpload in v8 binding.

        cf. http://www.whatwg.org/specs/web-apps/current-work/#event-handler-attributes
        An event handler attribute, unless otherwise specified, can either
        have the value null or be set to a Function object.
        Initially, an event handler attribute must be set to null.

        Test: fast/xmlhttprequest/xmlhttprequest-default-attributes.html

        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Changed to use v8::Null().
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Ditto.

LayoutTests:

2009-04-24  Fumitoshi Ukai  <ukai@google.com>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25257
        Verify XMLHttpRequest has correct attribute value by default.

        * fast/xmlhttprequest/resources/xmlhttprequest-default-attributes.js: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-default-attributes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Fri, 24 Apr 2009 18:02:12 +0000 (18:02 +0000)]
2009-04-24  Christian Dywan  <christian@twotoasts.de>

        Rubber-stamped by Gustavo Noronha.

        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
        description of the enable-spell-checking property and correct the
        mentioning of the default language used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Apr 2009 17:42:15 +0000 (17:42 +0000)]
2009-04-24  Kevin McCullough  <kmccullough@apple.com>

        Speculative fix for leopard build-bot until I have a fix on leopard.

        * platform/mac-leopard/editing: Added.
        * platform/mac-leopard/editing/deleting: Added.
        * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 24 Apr 2009 16:38:36 +0000 (16:38 +0000)]
2009-04-24  Darin Adler  <darin@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6663836> CrashTracer: crashes in Safari at com.apple.WebCore • WebCore::reportException + 1513

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException): Added a null check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 24 Apr 2009 16:13:15 +0000 (16:13 +0000)]
2009-04-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Currently working on a bug where a WebHistoryItem was being used after being dealloc'ed.
        I added this assertion to help catch the case as soon as it happens instead of random
        issues downstream.  Figured it's worth checking in by itself.

        * History/WebHistoryItem.mm:
        (core): ASSERT that the WebCore::HistoryItem inside this WebHistoryItem is supposed to have
          this WebHistoryItem as a wrapper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 24 Apr 2009 16:10:41 +0000 (16:10 +0000)]
2009-04-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler

        https://bugs.webkit.org/show_bug.cgi?id=23219

        Add support for transtions and animations of background-position, -webkit-background-size,
        -webkit-mask-position and -webkit-mask-size.

        Tests: transitions/background-transitions.html
               transitions/mask-transitions.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        Add a blend func for LengthSize.

        (WebCore::ensurePropertyMap):
        Add wrappers for the new properties.

        (WebCore::addShorthandProperties):
        Add a shorthand property for CSSPropertyBackgroundPosition to map to
        CSSPropertyBackgroundPositionX and CSSPropertyBackgroundPositionY,
        add CSSPropertyWebkitMask for CSSPropertyWebkitMaskPosition, and add
        CSSPropertyWebkitMaskPosition for CSSPropertyWebkitMaskPositionX and
        CSSPropertyWebkitMaskPositionY.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBackgroundXPosition):
        (WebCore::InheritedFlags::setBackgroundYPosition):
        (WebCore::InheritedFlags::setBackgroundSize):
        (WebCore::InheritedFlags::setMaskXPosition):
        (WebCore::InheritedFlags::setMaskYPosition):
        (WebCore::InheritedFlags::setMaskSize):
        Add setters for the properties that can be animated now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 24 Apr 2009 15:55:52 +0000 (15:55 +0000)]
2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Updating these pixel results to the generated results on Leopard.

        * platform/mac/editing/inserting/5510537-expected.checksum:
        * platform/mac/editing/inserting/5510537-expected.png:
        * platform/mac/editing/inserting/6703873-expected.checksum:
        * platform/mac/editing/inserting/6703873-expected.png:
        * platform/mac/editing/selection/select-all-iframe-expected.checksum:
        * platform/mac/editing/selection/select-all-iframe-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Fri, 24 Apr 2009 15:39:07 +0000 (15:39 +0000)]
WebCore:

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        Test: editing/pasteboard/paste-blockquote-after-blockquote.html

        When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
        But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a
        blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens
        to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
        (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
        * editing/ReplaceSelectionCommand.h:

LayoutTests:

2009-04-24  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup

        * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
        * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
kov@webkit.org [Fri, 24 Apr 2009 13:16:57 +0000 (13:16 +0000)]
2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::ignoreWordInSpellDocument,
        EditorClient::learnWord and EditorClient::getGuessesForWord. This
        enables the corresponding user actions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::ignoreWordInSpellDocument):
        (WebKit::EditorClient::learnWord):
        (WebKit::EditorClient::getGuessesForWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
kov@webkit.org [Fri, 24 Apr 2009 13:16:40 +0000 (13:16 +0000)]
2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Implement EditorClient::checkSpellingOfString; enabling spell checking
        to actually happen, this is the basis for other spelling functions.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::checkSpellingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
kov@webkit.org [Fri, 24 Apr 2009 13:16:23 +0000 (13:16 +0000)]
2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enchant support for spell-checking-languages property to work
        properly.

        * GNUmakefile.am:
        * configure.ac:

WebKit/gtk

2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add spell-checking-languages property to WebKitWebSettings.

        * webkit/webkitprivate.h:
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_finalize):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
kov@webkit.org [Fri, 24 Apr 2009 13:16:00 +0000 (13:16 +0000)]
2009-04-24  Diego Escalante Urrelo  <diegoe@gnome.org>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15616
        [GTK] Add spell checking

        Add enable-spell-checking property to WebKitWebSettings and implement
        EditorClient::isContinuousSpellCheckingEnabled and
        EditorClient::toggleContinuousSpellChecking to allow the UI to
        enable check as you type spell checking.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
        (WebKit::EditorClient::toggleContinuousSpellChecking):
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::):
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
        (_WebKitWebSettingsPrivate::webkit_web_settings_copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Fri, 24 Apr 2009 11:12:51 +0000 (11:12 +0000)]
2009-04-24  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Added Qt-specific expected result for color conversion.

        This is to compensate the lack of color profile in Qt to do
        color conversion, hence CMYK 0,0,0,1 always give pure black (#000)
        instead of very dark black.

        * platform/qt/fast/canvas/set-colors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 24 Apr 2009 11:08:55 +0000 (11:08 +0000)]
2009-04-24  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        Fix qdoc warning about link to QAction::isEnabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-24 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 24 Apr 2009 10:30:07 +0000 (10:30 +0000)]
2009-04-24  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Ariya Hidayat.

        Added support for generating API docs in the Qt build using "make docs"

        Added code snippets and overview from the Qt sources references in the API docs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Adele Peterson <adele@apple.com>
adele@apple.com [Fri, 24 Apr 2009 06:38:48 +0000 (06:38 +0000)]
2009-04-23  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Updating test to make it easier to see the blockquote in the results.

        * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
        * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove deletionUI-helpers.js in to the correct location so that the
mrowe@apple.com [Fri, 24 Apr 2009 06:03:06 +0000 (06:03 +0000)]
Move deletionUI-helpers.js in to the correct location so that the
tests that use it can find it.

* platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWith great sadness and a heavy heart I switch us back from YARR to WREC in
mrowe@apple.com [Fri, 24 Apr 2009 05:12:10 +0000 (05:12 +0000)]
With great sadness and a heavy heart I switch us back from YARR to WREC in
order to restore greenness to the world once more.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMore Windows build fixage.
mrowe@apple.com [Fri, 24 Apr 2009 05:04:11 +0000 (05:04 +0000)]
More Windows build fixage.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAttempt to fix the Windows build.
mrowe@apple.com [Fri, 24 Apr 2009 04:16:30 +0000 (04:16 +0000)]
Attempt to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:  Remove a symbol that no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBUG 24604: WebKit profiler reports incorrect total times
timothy@apple.com [Fri, 24 Apr 2009 03:47:50 +0000 (03:47 +0000)]
BUG 24604: WebKit profiler reports incorrect total times

JavaScriptCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * profiler/CallIdentifier.h:
        (JSC::CallIdentifier::Hash::hash):
        (JSC::CallIdentifier::Hash::equal):
        (JSC::CallIdentifier::hash):
        (WTF::):
        * profiler/HeavyProfile.cpp: Removed.
        * profiler/HeavyProfile.h: Removed.
        * profiler/Profile.cpp: No more need for TreeProfile/HeavyProfile
        (JSC::Profile::create):
        * profiler/Profile.h:
        * profiler/ProfileNode.cpp:
        * profiler/ProfileNode.h:
        * profiler/TreeProfile.cpp: Removed.
        * profiler/TreeProfile.h: Removed.

WebCore:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Made it so that most of the profiler functions now match the behavior of Shark. Most notably, in the
        heavy view, child nodes now represent the statistics of the root node. Each root node of heavy view
        displays flattened statistics for a particular function that ran during the profile, and each child
        of these root nodes represents a callpath that lead to it. Thus, the statistics for each of these child
        nodes should show how much of the root nodes values came from it. For example, if you had the following to
        stacks take place during the profile:

        A ->calls 1 times-> B ->calls 2 times-> C
        D ->calls 4 times-> C

        The tree for the C root node would look like this:

        C -> B -> A
          -> D

        The number of calls values would look like this:

        C (6) -> B (2) -> A(2)
              -> D (4)

        What this means is that "2 of the total 6 C calls came from B", "2 of the total C calls came from A", and
        "4 of the total C calls came from D".  Notice that the "A ->calls 2 time->" is completely ignored. This becomes
        particularly tricky during recursive calls, because each child note can represent multiple possible paths. This
        is the reason that we would get things like 40000% previously with recursion.

        This is also the way gprof works, and as close as we can get to Shark's behavior (Shark is not instrumented so it
        can't know exactly how many calls came from where, etc).

        * English.lproj/localizedStrings.js: Added "Average" for average times in the profile.
        * inspector/JavaScriptProfile.cpp:
        (WebCore::ProfileClass):
        * inspector/JavaScriptProfileNode.cpp:
        (WebCore::getParent):
        (WebCore::getHead):
        (WebCore::getCallUID):
        (WebCore::ProfileNodeClass):
        * inspector/front-end/BottomUpProfileDataGridTree.js: Added.
        (WebInspector.BottomUpProfileDataGridTree):
        (WebInspector.BottomUpProfileDataGridTree.prototype.focus):
        (WebInspector.BottomUpProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
        (WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
        (WebInspector.BottomUpProfileDataGridNode.prototype._exclude):
        (WebInspector.BottomUpProfileDataGridNode.prototype._merge):
        (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype.insertChild):
        (WebInspector.DataGrid.prototype.removeChild):
        (WebInspector.DataGrid.prototype.removeChildren):
        (WebInspector.DataGridNode.prototype.set hasChildren):
        (WebInspector.DataGridNode.prototype.get hasChildren):
        * inspector/front-end/ProfileDataGridTree.js: Added.
        (WebInspector.ProfileDataGridNode):
        (WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
        (WebInspector.ProfileDataGridNode.prototype.get data):
        (WebInspector.ProfileDataGridNode.prototype.createCell):
        (WebInspector.ProfileDataGridNode.prototype.select):
        (WebInspector.ProfileDataGridNode.prototype.deselect):
        (WebInspector.ProfileDataGridNode.prototype.expand):
        (WebInspector.ProfileDataGridNode.prototype.insertChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChild):
        (WebInspector.ProfileDataGridNode.prototype.removeChildren):
        (WebInspector.ProfileDataGridNode.prototype.findChild):
        (WebInspector.ProfileDataGridNode.prototype.get averageTime):
        (WebInspector.ProfileDataGridNode.prototype.get averagePercent):
        (WebInspector.ProfileDataGridNode.prototype.get selfPercent):
        (WebInspector.ProfileDataGridNode.prototype.get totalPercent):
        (WebInspector.ProfileDataGridNode.prototype._save):
        (WebInspector.ProfileDataGridNode.prototype._restore):
        (WebInspector.ProfileDataGridNode.prototype._merge):
        (WebInspector.ProfileDataGridTree):
        (WebInspector.ProfileDataGridTree.prototype.get expanded):
        (WebInspector.ProfileDataGridTree.prototype.appendChild):
        (WebInspector.ProfileDataGridTree.prototype.insertChild):
        (WebInspector.ProfileDataGridTree.prototype.removeChildren):
        (WebInspector.ProfileDataGridTree.prototype.findChild.WebInspector.ProfileDataGridNode.prototype.findChild.sort.WebInspector.ProfileDataGridNode.prototype.sort._save):
        (WebInspector.ProfileDataGridTree.propertyComparator.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator.else.comparator):
        (WebInspector.ProfileDataGridTree.propertyComparator):
        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView):
        (WebInspector.ProfileView.prototype.set profile):
        (WebInspector.ProfileView.prototype.get bottomUpProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get topDownProfileDataGridTree):
        (WebInspector.ProfileView.prototype.get currentTree):
        (WebInspector.ProfileView.prototype.set currentTree):
        (WebInspector.ProfileView.prototype.get topDownTree):
        (WebInspector.ProfileView.prototype.get bottomUpTree):
        (WebInspector.ProfileView.prototype.refresh):
        (WebInspector.ProfileView.prototype.refreshVisibleData):
        (WebInspector.ProfileView.prototype.refreshShowAsPercents):
        (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
        (WebInspector.ProfileView.prototype.performSearch):
        (WebInspector.ProfileView.prototype._changeView):
        (WebInspector.ProfileView.prototype._focusClicked):
        (WebInspector.ProfileView.prototype._excludeClicked):
        (WebInspector.ProfileView.prototype._resetClicked):
        (WebInspector.ProfileView.prototype._sortProfile):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.showProfile):
        (WebInspector.ProfilesPanel.prototype.showView):
        (WebInspector.ProfilesPanel.prototype.searchMatchFound):
        * inspector/front-end/TopDownProfileDataGridTree.js: Added.
        (WebInspector.TopDownProfileDataGridNode):
        (WebInspector.TopDownProfileDataGridNode.prototype._populate):
        (WebInspector.TopDownProfileDataGridNode.prototype._exclude):
        (WebInspector.TopDownProfileDataGridTree):
        (WebInspector.TopDownProfileDataGridTree.prototype.focus):
        (WebInspector.TopDownProfileDataGridTree.prototype.exclude):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.html:

LayoutTests:

2009-04-23  Francisco Tolmasky  <francisco@280north.com>

        BUG 24604: WebKit profiler reports incorrect total times
        <https://bugs.webkit.org/show_bug.cgi?id=24604>

        Reviewed by Timothy Hatcher and Kevin McCullough.

        Changed profile.treeProfile to just profile, since these aren't generated in C++ anymore.
        Removed heavy-view test since heavy-view isn't an actual tree that is generated in C++ land anymore,
        but rather just a different display of the normal treeProfile in the JS data grid.

        * fast/profiler/heavy-view-expected.txt: Removed.
        * fast/profiler/heavy-view.html: Removed.
        * fast/profiler/resources/profiler-test-JS-resources.js: profiles[i].treeProfile -> profiles[i].treeProfile
        (printProfilesDataWithoutTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
eric@webkit.org [Fri, 24 Apr 2009 01:50:58 +0000 (01:50 +0000)]
    Reviewed by Sam Weinig.

        Use static functions (and a couple templates)
        to further reduce the amount of copy/paste code in SVGRenderTreeAsText

        No test changes, only code cleanup.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeNameValuePair):
        (WebCore::writeNameAndQuotedValue):
        (WebCore::writeIfNotEmpty):
        (WebCore::writeIfNotDefault):
        (WebCore::writeStyle):
        (WebCore::writePositionAndStyle):
        (WebCore::operator<<):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 24 Apr 2009 01:42:15 +0000 (01:42 +0000)]
2009-04-23  Kevin McCullough  <kmccullough@apple.com>

        - Windows build fix.  Mac only tests go in platform/mac

        * editing/deleting/deletionUI-borders.html: Removed.
        * editing/deleting/deletionUI-differing-background.html: Removed.
        * editing/deleting/deletionUI-minimum-size.html: Removed.
        * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
        * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
        * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 24 Apr 2009 01:09:43 +0000 (01:09 +0000)]
2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Not Reviewed.

        Speculative Windows build fix II.

        * yarr/RegexInterpreter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 24 Apr 2009 00:53:14 +0000 (00:53 +0000)]
2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Not Reviewed.

        Speculative Windows build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * runtime/RegExp.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Fri, 24 Apr 2009 00:50:34 +0000 (00:50 +0000)]
    Reviewed by Simon Fraser.

        SVGRenderTreeAsText cleanup/code sharing.

        No test changes, only code cleanup.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::firstRunOrigin):
        * rendering/RenderText.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeStandardPrefix):
        (WebCore::writeChildren):
        (WebCore::write):
        (WebCore::writeRenderResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 24 Apr 2009 00:39:47 +0000 (00:39 +0000)]
2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by salty sea dogs Sam & Geoff.

        Enable YARR_JIT by default (where supported), replacing WREC.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 24 Apr 2009 00:37:11 +0000 (00:37 +0000)]
2009-04-23  Darin Adler  <darin@apple.com>

        Removed some stray files that Geoff missed when rolling out changes.

        * svg/custom/resources/svg-fonts-in-text-controls.js: Removed.
        * svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Fri, 24 Apr 2009 00:32:31 +0000 (00:32 +0000)]
JavaScriptCore:

2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff "Dread Pirate Roberts" Garen.

        Various small fixes to YARR JIT, in preparation for enabling it by default.

        * Correctly index into the callframe when storing restart addresses for
          nested alternatives.
        * Allow backtracking back into matched alternatives of parentheses.
        * Fix callframe offset calculation for parenthetical assertions.
        * When a set of parenthese are quantified with a fixed and variable portion,
          and the variable portion is quantified once, this should not reset the
          pattern match on failure to match (the last match from the firxed portion
          should be preserved).
        * Up the pattern size limit to match PCRE's new limit.
        * Unlclosed parentheses should be reported with the message "missing )".

        * wtf/Platform.h:
        * yarr/RegexCompiler.cpp:
        (JSC::Yarr::RegexPatternConstructor::quantifyAtom):
        (JSC::Yarr::RegexPatternConstructor::setupAlternativeOffsets):
        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::matchParentheses):
        (JSC::Yarr::Interpreter::backtrackParentheses):
        (JSC::Yarr::ByteCompiler::emitDisjunction):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::loadFromFrameAndJump):
        (JSC::Yarr::RegexGenerator::generateParenthesesDisjunction):
        (JSC::Yarr::RegexGenerator::generateParentheticalAssertion):
        (JSC::Yarr::RegexGenerator::generateTerm):
        (JSC::Yarr::executeRegex):
        * yarr/RegexParser.h:
        (JSC::Yarr::Parser::):
        (JSC::Yarr::Parser::parseTokens):
        (JSC::Yarr::Parser::parse):
        * yarr/RegexPattern.h:
        (JSC::Yarr::PatternTerm::):
        (JSC::Yarr::PatternTerm::PatternTerm):

LayoutTests:

2009-04-23  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoff "Dread Pirate Roberts" Garen.

        This test tries to force itself into PCRE; modify the
        test so that as well as dodging WREC it can also avoid
        YARR!

        * fast/js/resources/regexp-overflow-too-big.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
bdakin@apple.com [Fri, 24 Apr 2009 00:25:08 +0000 (00:25 +0000)]
WebCore:

2009-04-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        WebCore part of fix for <rdar://problem/6333461> REGRESSION
        (r36864-r36869): Dragging stocks widget scrollbar drags the whole
        widget

        * platform/Scrollbar.h:
        (WebCore::Scrollbar::isScrollbar):
        * platform/Widget.h:
        (WebCore::Widget::isScrollbar):

WebKit/mac:

2009-04-23  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6333461> REGRESSION (r36864-r36869):
        Dragging stocks widget scrollbar drags the whole widget

        Look for our new WebCore scrollbars in the WebHTMLView and add
        proper Dashboard regions for them.

        * WebView/WebView.mm:
        (-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
        (-[WebView _addScrollerDashboardRegions:from:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
kmccullough@apple.com [Thu, 23 Apr 2009 23:59:37 +0000 (23:59 +0000)]
WebCore:

2009-04-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6808109> "Deletion UI" is not available for many
        portions of HTML content

        This patch makes the deletion UI show up in some new situations:
        1) If a block's background color is different from its parent's
        2) If a block has a background image.
        3) If a block has a single visible border.
        However the block must now not only be at least a minimum width and
        height, but also exceed a minimum area.  In practice this has led to
        much better element selection.

        * editing/DeleteButtonController.cpp:
        (WebCore::isDeletableElement):

LayoutTests:

2009-04-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/6808109> "Deletion UI" is not available for many
        portions of HTML content

        This patch makes the deletion UI show up in some new situations:
        1) If a block's background color is different from its parent's
        2) If a block has a background image.
        3) If a block has a single visible border.
        However the block must now not only be at least a minimum width and
        height, but also exceed a minimum area.  In practice this has led to
        much better element selection.

        * editing/deleting/deletionUI-borders.html: Added.
        * editing/deleting/deletionUI-differing-background.html: Added.
        * editing/deleting/deletionUI-minimum-size.html: Added.
        * editing/deleting/resources: Added.
        * editing/deleting/resources/deletionUI-helpers.js: Added.
        (debug):
        (determineDeletionUIExistence):
        * platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
        * platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Adding XMLTokenizer.cpp to the build.
kevino@webkit.org [Thu, 23 Apr 2009 23:53:33 +0000 (23:53 +0000)]
wx build fix. Adding XMLTokenizer.cpp to the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 23 Apr 2009 23:32:01 +0000 (23:32 +0000)]
2009-04-23  John Sullivan  <sullivan@apple.com>

        fixed <rdar://problem/6822479> Assertion failure after Reset Safari in new history-writing code

        Reviewed by Oliver Hunt

        * History/WebHistory.mm:
        (-[WebHistoryPrivate data]):
        Return nil immediately if there are no entries; this matches a recent Windows-platform fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 23 Apr 2009 22:46:40 +0000 (22:46 +0000)]
2009-04-23  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/6788905> REGRESSION (41928?): hang in Position::upstream
        https://bugs.webkit.org/show_bug.cgi?id=25312

        I was unable to reproduce the problem, but I'm pretty sure this will fix it.

        * rendering/RenderObject.cpp: (WebCore::RenderObject::createVisiblePosition):
        Since VisiblePosition doesn't ensure the offset is good, we shouldn't pass max int as an offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 23 Apr 2009 22:38:57 +0000 (22:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
dglazkov@chromium.org [Thu, 23 Apr 2009 22:33:25 +0000 (22:33 +0000)]
WebCore:

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        Test: fast/overflow/overflow-y-scroll.html

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::updateScrollbars): Added check for the ScrollbarAlwaysOn
        scroll mode.

LayoutTests:

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.
        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        * fast/overflow/overflow-y-scroll-expected.txt: Added.
        * fast/overflow/overflow-y-scroll.html: Added.

WebKit/mac:

2009-04-23  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25313
        Missing scroll bars in GMail.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]): Added check for the ScrollbarAlwaysOn
            scroll mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Tiger build
kdecker@apple.com [Thu, 23 Apr 2009 22:17:46 +0000 (22:17 +0000)]
Fix the Tiger build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 23 Apr 2009 22:03:17 +0000 (22:03 +0000)]
2009-04-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        Fix <rdar://problem/6821992>

        Add a new m_inDestroy member variable. Set it to true when in destroy, and have all NPRuntime functions return false
        when m_inDestroy is true.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        (WebKit::NetscapePluginInstanceProxy::destroy):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        (WebKit::NetscapePluginInstanceProxy::getProperty):
        (WebKit::NetscapePluginInstanceProxy::setProperty):
        (WebKit::NetscapePluginInstanceProxy::removeProperty):
        (WebKit::NetscapePluginInstanceProxy::hasProperty):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::enumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 23 Apr 2009 21:22:30 +0000 (21:22 +0000)]
WebCore:

        Reviewed by Justin Garcia.

        - fix <rdar://problem/6081309> Mail crash when pressing down arrow in
          some messages in WebCore::canHaveChildrenForEditing

        Test: editing/selection/extend-by-line-anonymous-content-crash.html

        * editing/visible_units.cpp:
        (WebCore::previousLinePosition): Null-check node. If p is not an
        editable position, then closestLeafChildForXPos() may have returned a
        non-editable box, and in particular one belonging to anonymous content.
        If node is 0, fall back on RenderObject::positionForPoint, which
        finds the closest position in non-anonymous content.
        (WebCore::nextLinePosition): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createVisiblePosition): Fixed a typo.

LayoutTests:

        Reviewed by Justin Garcia.

        - test for <rdar://problem/6081309> Mail crash when pressing down arrow
          in some messages in WebCore::canHaveChildrenForEditing

        * editing/selection/extend-by-line-anonymous-content-crash-expected.txt: Added.
        * editing/selection/extend-by-line-anonymous-content-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 23 Apr 2009 20:49:38 +0000 (20:49 +0000)]
2009-04-23  David Hyatt  <hyatt@apple.com>

        Reviewed by Maciej.

        Fix for <rdar://problem/6789879> REGRESSION (42464): Hitting assertion when loading message in Mail + TOT WebKit

        Make the Mac platform the same as all the other platforms.  Instead of (incorrectly) marking a FrameView for layout
        when its underlying document view changes, just mark the outermost frame view for layout when the WebView's size changes.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]):
        (-[WebHTMLView addSuperviewObservers]):
        * WebView/WebView.mm:
        (-[WebView _boundsChanged]):
        (-[WebView removeSizeObservers]):
        (-[WebView addSizeObservers]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Tim Hatcher.
kdecker@apple.com [Thu, 23 Apr 2009 20:08:12 +0000 (20:08 +0000)]
    Reviewed by Tim Hatcher.

        Second part of the fix for <rdar://problem/6352982>

        * Plugins/WebBaseNetscapePluginView.h: Make this class conform to WebPluginContainerCheckController
        * Plugins/WebBaseNetscapePluginView.mm: Likewise.
        (-[WebBaseNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added skeleton method.
        * Plugins/WebPluginContainerCheck.h: Added protocol for <WebPluginContainerCheckController>
        * Plugins/WebPluginContainerCheck.mm:
        (-[WebPluginContainerCheck initWithRequest:target:resultObject:selector:controller:]):
        * Plugins/WebPluginController.h: Make this class conform to WebPluginContainerCheckController

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adele Peterson.
ap@webkit.org [Thu, 23 Apr 2009 19:58:08 +0000 (19:58 +0000)]
    Reviewed by Adele Peterson.

        <rdar://problem/6791439> REGRESSION: Get an error page instead of login page navigating back in gmail

        Test: http/tests/history/back-to-post.php

        * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
        Apply a new cache policy if it changed after the platform request was first created.
        While at it, also made sure to update timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 23 Apr 2009 19:02:34 +0000 (19:02 +0000)]
2009-04-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        * pt_BR.po: translation update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Thu, 23 Apr 2009 18:45:15 +0000 (18:45 +0000)]
2009-04-23  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        When creating a new drawable object, collect system's
        information about the best depth it can provide and use it
        in a new colormap that the new drawable requires.

        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::BitmapImage::getGdkPixbuf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Thu, 23 Apr 2009 18:06:06 +0000 (18:06 +0000)]
    Reviewed by Anders Carlsson.

        First part of <rdar://problem/6352982>

        * Plugins/WebBaseNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h; Added two new method:
        checkIfAllowedToLoadURL:url:frame:callbackFunc: and cancelCheckIfAllowedToLoadURL:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added skeleton method, does nothing interesting
        yet.
        (-[WebBaseNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Likewise.
        * Plugins/WebNetscapeContainerCheckPrivate.h: Added.
        * Plugins/WebNetscapeContainerCheckPrivate.mm: Added.
        (browserContainerCheckFuncs): Added.
        * Plugins/WebNetscapePluginView.h: Imported #WebNetscapeContainerCheckPrivate.h;
        * Plugins/WebNetscapePluginView.mm: Imported #WebNetscapeContainerCheckPrivate.h; added WKN_CheckIfAllowedToLoadURL
        and WKN_CancelCheckIfAllowedToLoadURL functions.
        (-[WebNetscapePluginView getVariable:value:]): Return vtable for container check functions.
        * Plugins/npapi.mm:
        (WKN_CheckIfAllowedToLoadURL): Added new private function.
        (WKN_CancelCheckIfAllowedToLoadURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Skip a newly-added test that fails on Windows
aroben@apple.com [Thu, 23 Apr 2009 16:42:59 +0000 (16:42 +0000)]
    Skip a newly-added test that fails on Windows

        See Bug 25344: http/tests/misc/redirect-to-external-url.html fails on
        Windows
        <https://bugs.webkit.org/show_bug.cgi?id=25344>

        Reviewed by Brady Eidson.

        * platform/win/Skipped: Added
        http/tests/misc/redirect-to-external-url.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Zan Dobersek <zandobersek@gmail.com>
kov@webkit.org [Thu, 23 Apr 2009 15:39:29 +0000 (15:39 +0000)]
2009-04-23  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=15654
        GdkPixbuf support for ImageCairo

        Add support for converting a Cairo surface to a GdkPixbuf.

        * platform/graphics/BitmapImage.h:
        * platform/graphics/Image.h:
        (WebCore::Image::getGdkPixbuf):
        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::BitmapImage::getGdkPixbuf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build warning
vestbo@webkit.org [Thu, 23 Apr 2009 15:07:11 +0000 (15:07 +0000)]
Fix Qt build warning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Thu, 23 Apr 2009 14:55:30 +0000 (14:55 +0000)]
2009-04-23  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Simon Hausmann.

        Make windowed plugins (on X11, Qt) behave nicer with wheel scrolling.

        Basically, what we want is to send wheel events to the plugin *only*
        when it has focus, or else send it to the parent frame.

        This is a work around, and basically what we do, is to steal the
        wheel events from the plugin, modify the window ID, and put the
        event back into the Qt event loop.

        * plugins/qt/PluginContainerQt.cpp:
        (PluginClientWrapper::PluginClientWrapper):
        (PluginClientWrapper::~PluginClientWrapper):
        (PluginClientWrapper::x11Event):
        (PluginContainerQt::PluginContainerQt):
        (PluginContainerQt::~PluginContainerQt):
        (PluginContainerQt::on_clientClosed):
        (PluginContainerQt::on_clientIsEmbedded):
        (PluginContainerQt::redirectWheelEventsToParent):
        (PluginContainerQt::x11Event):
        (PluginContainerQt::focusInEvent):
        * plugins/qt/PluginContainerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Antonio Gomes <antonio.gomes@openbossa.org>
ariya@webkit.org [Thu, 23 Apr 2009 13:53:10 +0000 (13:53 +0000)]
2009-04-23  Antonio Gomes   <antonio.gomes@openbossa.org>

        Reviewed by Ariya Hidayat.

        [Qt] Added QWebElement::computedStyleProperty method.

        * Api/qwebelement.cpp:
        (QWebElement::computedStyleProperty):
        * Api/qwebelement.h:
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::computedStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Thu, 23 Apr 2009 11:30:50 +0000 (11:30 +0000)]
2009-04-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Rubber-stamped by Ariya Hidayat.

        [Qt] Rename QWebElement arguments from html to markup

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the Windows DRT build.
mrowe@apple.com [Thu, 23 Apr 2009 07:25:06 +0000 (07:25 +0000)]
Fix the Windows DRT build.

* DumpRenderTree/win/PolicyDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 23 Apr 2009 07:10:51 +0000 (07:10 +0000)]
2009-04-23  Brady Eidson  <beidson@apple.com>

        Fix Windows DRT build.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::unableToImplementPolicyWithError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-23 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 23 Apr 2009 07:09:42 +0000 (07:09 +0000)]
2009-04-23  Brady Eidson  <beidson@apple.com>

        Update my just-landed layout test to agree with Tiger's CFNetwork

        * http/tests/misc/resources/redirect-to-external-url.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
beidson@apple.com [Thu, 23 Apr 2009 06:42:52 +0000 (06:42 +0000)]
WebCore:

2009-04-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.

        For most loads, we were consulting the navigation policy delegate twice.  Once from FrameLoader before
        the load started and once from MainResourceLoader in its willSendRequest callback.

        In the past we tried removing MainResourceLoader's call altogether.  This caused a regression where urls
        that redirect to a url handled by an external application would no longer work in Safari.  It probably
        also broke other WebKit apps in subtle ways.

        Changing MainResourceLoader to make the check only on redirects fixes both bugs.  We now only call the
        policy delegate once for most standard loads, but we do correctly call it a second time for redirects.

        Tests: http/tests/misc/policy-delegate-called-twice.html
               http/tests/misc/redirect-to-external-url.html

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Call the navigation policy delegate only for redirects.

WebKitTools:

2009-04-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        Add additional support for test:
        <rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]): Dump formatted information when
          a policy cannot be implemented.

        * DumpRenderTree/win/PolicyDelegate.cpp:
        (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
        * DumpRenderTree/win/PolicyDelegate.h:

LayoutTests:

2009-04-22  Brady Eidson  <beidson@apple.com>

        Reviewed by Maciej Stachowiak

        With the fix for:
        <rdar://problem/6786961> - "Are you sure you want to resubmit this form?" nag displays twice.
        And also to make sure we never rebreak:
        <rdar://problem/5689748> - Cannot redirect to protocols handled by external applications.

        * http/tests/misc/redirect-to-external-url-expected.txt: Added.
        * http/tests/misc/redirect-to-external-url.html: Added.
        * http/tests/misc/resources/redirect-to-external-url-iframe.html: Added.
        * http/tests/misc/resources/redirect-to-external-url.php: Added.

        * http/tests/misc/policy-delegate-called-twice-expected.txt: Added.
        * http/tests/misc/policy-delegate-called-twice.html: Added.
        * http/tests/misc/resources/iframe-policy-1.html: Added.
        * http/tests/misc/resources/iframe-policy-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a...
mrowe@apple.com [Thu, 23 Apr 2009 04:06:26 +0000 (04:06 +0000)]
Add the m_ prefix on FixedVMPoolAllocator's member variables, and fix typos in a few comments.

Rubber-stamped by Gavin Barraclough.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::addToFreeList):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd some assertions to FixedVMPoolAllocator to guard against cases where we
mrowe@apple.com [Thu, 23 Apr 2009 04:06:22 +0000 (04:06 +0000)]
Add some assertions to FixedVMPoolAllocator to guard against cases where we
attempt to free memory that didn't originate from the pool, or we attempt to
hand out a bogus address from alloc.

Rubber-stamped by Gavin Barraclough.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::release):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::isWithinVMPool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 23 Apr 2009 02:41:22 +0000 (02:41 +0000)]
2009-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix for <rdar://problem/6800695>

        Add a hack to only allow navigating (via a link from a http page)
        to feed: urls (same for feeds: and feedsearch:) that map to http:
        or https: via their nested protocol. This includes both feed://example.com
        and feed:http://example.com.

        * loader/FrameLoader.cpp:
        (WebCore::isFeedWithNestedProtocolInHTTPFamily):
        (WebCore::FrameLoader::loadFrameRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 23 Apr 2009 02:34:40 +0000 (02:34 +0000)]
2009-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Autogenerate the XMLHttpRequest constructor getter/setter for the
        WorkerContext and remove the now no longer needed JSWorkerContextBase.lut.h
        file.

        * DerivedSources.make: Remove JSWorkerContextBase.lut.h
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * bindings/js/JSWorkerContextBase.cpp:
        * bindings/js/JSWorkerContextBase.h: Remove code to support hand written
        code for XMLHttpRequest constructor lookup and shadowing.

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::customGetOwnPropertySlot): Remove JSC prefixes.
        (WebCore::JSWorkerContext::xmlHttpRequest): Added. Custom implementation of
        cached constructor lookup.
        * workers/WorkerContext.idl: Make the XMLHttpRequestConstructor accessor not
        V8 specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKitLibraries:
adachan@apple.com [Thu, 23 Apr 2009 01:43:07 +0000 (01:43 +0000)]
WebKitLibraries:
        Update WebKitSystemInterface with new method that maps CFNetwork error code to localized description.

        Reviewed by Darin Adler.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

WebKit/win:
        <rdar://problem/5115298> Don't get error msg when download is interrupted and cannot resume due to server unavailability
        If we fail to get an error description back from CFNetwork, try to get the localized description
        based on the error code.

        Reviewed by Darin Adler.

        * WebError.cpp:
        (WebError::localizedDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Apr 2009 01:07:51 +0000 (01:07 +0000)]
2009-04-22  Darin Adler  <darin@apple.com>

        * page/Navigator.idl: Touch this file to fix build since Geolocation
        configuration was recently turned off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInclude updated results
oliver@apple.com [Thu, 23 Apr 2009 01:02:01 +0000 (01:02 +0000)]
Include updated results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoModify test to only record the important mouse events
oliver@apple.com [Thu, 23 Apr 2009 00:59:39 +0000 (00:59 +0000)]
Modify test to only record the important mouse events

Reviewed by Geoff Garen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Thu, 23 Apr 2009 00:54:42 +0000 (00:54 +0000)]
WebCore:

2009-04-22  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25322
        Can't delete empty paragraph after a block image

        Empty paragraph removal would have been handled by mergeParagraphs, but we stopped short
        because of some code that avoided problems that would arise from Positions that would go
        bad during deletion.

        We have several checks that prevent us from using bad Positions, this one in particular
        was added to avoid bad Positions that result from text removal.  So, I removed the check
        and started correctly updating m_downstreamEnd during text removal so that it doesn't go
        bad.  m_upstreamStart doesn't need to be updated during text removal, since only text
        after it will ever be removed.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

2009-04-22  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25322
        Can't delete empty paragraph after a block image

        * editing/deleting/25322-1-expected.txt: Added.
        * editing/deleting/25322-1.html: Added.
        * editing/deleting/25322-2-expected.txt: Added.
        * editing/deleting/25322-2.html: Added.
        * editing/deleting/25322-3-expected.txt: Added.
        * editing/deleting/25322-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 23 Apr 2009 00:49:26 +0000 (00:49 +0000)]
2009-04-22  Darin Adler  <darin@apple.com>

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Fixed one
        case Eric seems to have missed earlier today of RenderImage -> RenderSVGImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from...
oliver@apple.com [Thu, 23 Apr 2009 00:37:51 +0000 (00:37 +0000)]
<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves

Reviewed by Darin Adler.

Make mouseUp target the correct frame when the original
mousedown made the drag non-capturing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from...
oliver@apple.com [Thu, 23 Apr 2009 00:29:04 +0000 (00:29 +0000)]
<rdar://problem/6757346> SAP: Prevent default on mouseDown does not stop iframe from capturing subsequent mouse moves

Reviewed by Darin Adler.

This is the first step of allowing drag events to match the behaviour
of mouse move events when the default action of the initial mouse down
is prevented.  Remaining issue is that the final mouse up event still
targets the original root frame.

Test: fast/events/mouse-drag-from-frame-to-other-frame.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 23 Apr 2009 00:01:18 +0000 (00:01 +0000)]
2009-04-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adele Peterson

        <rdar://problem/6702882> QT movie's video fails to be displayed after switching between tabs
        <rdar://problem/6754957> Resizing Web browser window and hitting play will cause video blocks and artifacting

        When in a media document, MediaPlayerPrivateQTKit uses a QTMovieView which may get
        layer backing under some circumstances. However, drawing the view via
        displayRectIgnoringOpacity:inContext: bypasses any layer setup that AppKit normally performs.
        So when in the media document, we draw via displayRectIgnoringOpacity:.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate test results after Blackbeard's change in r42752 to disable geolocation.
mrowe@apple.com [Wed, 22 Apr 2009 23:56:00 +0000 (23:56 +0000)]
Update test results after Blackbeard's change in r42752 to disable geolocation.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Pierre d'Herbemont <pdherbemont@apple.com>
simon.fraser@apple.com [Wed, 22 Apr 2009 22:59:23 +0000 (22:59 +0000)]
2009-04-22  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=24849

        Add tests for media 'played' attribute (missed in r42619).

        * media/video-played-expected.txt: Added.
        * media/video-played.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 22 Apr 2009 22:51:42 +0000 (22:51 +0000)]
2009-04-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Fix <rdar://problem/6792694>

        When we're trying to instantiate a plug-in and the plug-in host has died, we need to invalidate the
        instance so that it doesn't stick around and do bad things.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-22 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Wed, 22 Apr 2009 21:52:08 +0000 (21:52 +0000)]
2009-04-22  Gavin Barraclough  <barraclough@apple.com>

        Rubber stamped by Sam "Blackbeard" Weinig.

        Although pirates do spell the word 'generate' as 'genertate',
        webkit developers do not.  Fixerate.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::generateAssertionBOL):
        (JSC::Yarr::RegexGenerator::generateAssertionEOL):
        (JSC::Yarr::RegexGenerator::generateAssertionWordBoundary):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterSingle):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterPair):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterFixed):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterGreedy):
        (JSC::Yarr::RegexGenerator::generatePatternCharacterNonGreedy):
        (JSC::Yarr::RegexGenerator::generateCharacterClassSingle):
        (JSC::Yarr::RegexGenerator::generateCharacterClassFixed):
        (JSC::Yarr::RegexGenerator::generateCharacterClassGreedy):
        (JSC::Yarr::RegexGenerator::generateCharacterClassNonGreedy):
        (JSC::Yarr::RegexGenerator::generateTerm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42755 268f45cc-cd09-0410-ab3c-d52691b4dbfc