WebKit-https.git
7 years agoUnreviewed. Rolled DEPS.
jamesr@google.com [Thu, 6 Sep 2012 23:16:14 +0000 (23:16 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: make IDBKeyPath's string and array constructors explicit
commit-queue@webkit.org [Thu, 6 Sep 2012 23:14:08 +0000 (23:14 +0000)]
IndexedDB: make IDBKeyPath's string and array constructors explicit
https://bugs.webkit.org/show_bug.cgi?id=96004

Patch by Alec Flett <alecflett@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Source/WebCore:

Making these explicit to avoid accidental implicit conversions.

No new tests, existing tests cover correctness.

* Modules/indexeddb/IDBKeyPath.h:
(IDBKeyPath):

Source/WebKit/chromium:

Fix test to use explicit constructor for IDBKeyPath.

* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
enne@google.com [Thu, 6 Sep 2012 22:48:43 +0000 (22:48 +0000)]
[chromium] Remove GraphicsContext references from ContentLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=96002

Reviewed by James Robinson.

This is a compositor unit test, so it shouldn't reference things
outside of the compositor like GraphicsContext. The
OpaqueRectTrackingContentLayerDelegateTest already tests opaque
tracking right at the time of paint. This test is about verifying that
transformed canvases work properly, so can just fake the opaque rect
coming back from the paint.

* tests/ContentLayerChromiumTest.cpp:
(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
commit-queue@webkit.org [Thu, 6 Sep 2012 22:23:29 +0000 (22:23 +0000)]
[Chromium] Remove contentsScale and related logic from GraphicsLayerChromium.
https://bugs.webkit.org/show_bug.cgi?id=95094

Patch by Jeff Timanus <twiz@chromium.org> on 2012-09-06
Reviewed by Adrienne Walker.

Source/Platform:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.

* chromium/public/WebContentLayer.h:
(WebContentLayer):
    Export setBoundsContainPageScale() family of routines.

Source/WebCore:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.

Testing covered by existing compositor layout and unit tests.

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setAppliesPageScale):
(WebCore::GraphicsLayer::appliesPageScale):
    These routines are now virtual, so that they can push the notification to setDisregardsContentsScale in
    LayerChromium.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore):
(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):
    Now forwards the appliesPageScaleStatus to the owned layer.
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::contentsLayer):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
(WebCore):
(WebCore::LayerChromium::setBoundsContainPageScale):
    setAppliesPageScale is renamed to setBoundsContainPageScale in LayerChromium.
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::boundsContainPageScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore):
(WebCore::setScale):
(WebCore::updateLayerScale):
(WebCore::CCLayerTreeHost::updateLayers):
    The contents scale of a layer is now applied in this routine.

Source/WebKit/chromium:

In the short term, the page-scale logic is to be unified in the CCLayerTreeHost class.  This is a first pass to
try to remove the page-scale logic from GraphicsLayerChromium.  This change should be a no-op in terms of
contentsScale behaviour.
This change exports the disregardsPageScale() set of functions from WebContentLayer to LayerChromium.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
    Inform the layer associated with the NCCH that it is to disregard the page scale factor.
    Also remove now unused m_deviceScaleFactor and associated routines.
(WebKit::NonCompositedContentHost::setViewport):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::setBoundsContainPageScale):
(WebKit):
(WebKit::WebContentLayerImpl::boundsContainPageScale):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
* tests/CCLayerTreeHostTest.cpp:
(NoScaleContentLayerChromium):
(WebKitTests::NoScaleContentLayerChromium::create):
(WebKitTests::NoScaleContentLayerChromium::NoScaleContentLayerChromium):
(WebKitTests):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
    Rebaselined to correspond to the new behaviour.  Because the layers are now assigned a contentsScale, the
    scale on the draw transforms remain identity.
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit): Remove now obsolete unit-test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove failures for acceletared-drawing tests.
alokp@chromium.org [Thu, 6 Sep 2012 22:07:34 +0000 (22:07 +0000)]
[chromium] Remove failures for acceletared-drawing tests.

Unreviewed.

Update chromium TestExpectations to remove failures for accelerated-painting.
They were fixed in r127294.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Split platform geometry types into separate static target
jamesr@google.com [Thu, 6 Sep 2012 21:44:59 +0000 (21:44 +0000)]
[chromium] Split platform geometry types into separate static target
https://bugs.webkit.org/show_bug.cgi?id=96021

Reviewed by Tony Chang.

This moves several WebCore/platform geometry classes out of webcore_platform into a separate static library.
This library is relatively standalone and useful to statically link against in other contexts.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fuzzy load the Edje theme for HTML forms
kenneth@webkit.org [Thu, 6 Sep 2012 21:41:34 +0000 (21:41 +0000)]
[EFL] Fuzzy load the Edje theme for HTML forms
https://bugs.webkit.org/show_bug.cgi?id=95832

Reviewed by Antonio Gomes.

Change the theme so that it is first loaded when actually used.
This also fixed the case that it was impossible to change theme
a second time.

Tested by current tests. API unit test coming in separate patch.

* platform/efl/RenderThemeEfl.cpp:
(WebCore):

    Add some convenience macros.

       (WebCore::applyColorCallback):

    Use just one callback from the edje theme, which just calls
    setColorFromThemeClass.

(WebCore::fillColorsFromEdjeClass):

    Add convenience method for receiving colors from Edje and
    storing them in Color's.

(WebCore::RenderThemeEfl::setColorFromThemeClass):

    Set the class Color variabled with the values from the theme
    color class.

(WebCore::RenderThemeEfl::setThemePath):

    Don't apply the theme immediately.

(WebCore::RenderThemeEfl::loadTheme):

    Load the new theme and free the current one. If it fails,
    it will continue using the old one, if exists.

(WebCore::RenderThemeEfl::adjustSizeConstraints):
(WebCore::RenderThemeEfl::themePartCacheEntryReset):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
(WebCore::RenderThemeEfl::applyPartDescriptionsFrom):
(WebCore::RenderThemeEfl::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeEfl::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeEfl::platformFocusRingColor):

    Ensure the theme is loaded.

(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::emitMediaButtonSignal):

    Ensure the theme is loaded.

* platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
(WebCore::RenderThemeEfl::loadThemeIfNeeded):

    Remove unneeded methods and add a method for loading a theme
    in the case it is not loaded yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Classify several test cases in TestExpectations
commit-queue@webkit.org [Thu, 6 Sep 2012 21:24:51 +0000 (21:24 +0000)]
[EFL][WK2] Classify several test cases in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=95947

Unreviewed EFL gardening.

Update TestExpectations to classify a few test case failures
as being caused by lack on undo/redo stack implementation
in EFL WK2.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
enne@google.com [Thu, 6 Sep 2012 21:23:48 +0000 (21:23 +0000)]
[chromium] Remove Scrollbar/Settings dependencies from ScrollbarLayerChromiumTest
https://bugs.webkit.org/show_bug.cgi?id=95994

Reviewed by James Robinson.

This compositor test shouldn't depend on code outside the compositor.

* tests/ScrollbarLayerChromiumTest.cpp:
(WebCore::FakeWebScrollbar::create):
(FakeWebScrollbar):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove RenderView::setFixedPositionedObjectsNeedLayout to FrameView
simon.fraser@apple.com [Thu, 6 Sep 2012 21:04:34 +0000 (21:04 +0000)]
Move RenderView::setFixedPositionedObjectsNeedLayout to FrameView
https://bugs.webkit.org/show_bug.cgi?id=96017

Reviewed by James Robinson.

FrameView already has a HashSet of RenderObjects whose position
is affected by the viewport rect; this contains fixed and sticky-postion
objects. RenderView::setFixedPositionedObjectsNeedLayout() was using
the RenderView's list of postioned objects, but this omitted sticky-position
objects whose container was not the RenderView. So it's simpler to use
FrameView's set of fixed/sticky objects.

Changed the terminology from "fixed" to "viewport-constrained" for this set
of objects.

* page/FrameView.cpp:
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::setFixedVisibleContentRect):
(WebCore::FrameView::setViewportConstrainedObjectsNeedLayout):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
* page/FrameView.h:
(WebCore::FrameView::viewportConstrainedObjects):
(WebCore::FrameView::hasViewportConstrainedObjects):
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::styleDidChange):
* rendering/RenderView.cpp:
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd data-blackberry-webworks-context attribute and set the custom context when
commit-queue@webkit.org [Thu, 6 Sep 2012 21:00:43 +0000 (21:00 +0000)]
Add data-blackberry-webworks-context attribute and set the custom context when
getting context.
https://bugs.webkit.org/show_bug.cgi?id=95993

Patch by Genevieve Mak <gmak@rim.com> on 2012-09-06
Reviewed by Antonio Gomes.

PR #193726
Reviewed Internally by Mike Fenton.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
    - Check for custom WebWorks context and add it if there.
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::webWorksContext):
(DOMSupport):
* WebKitSupport/DOMSupport.h:
    - Add a method that checks a given element for the data-webworks-context
      attribute and returns its value if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Put chromium implementations of WTF symbols in separate static library
jamesr@google.com [Thu, 6 Sep 2012 20:55:13 +0000 (20:55 +0000)]
[chromium] Put chromium implementations of WTF symbols in separate static library
https://bugs.webkit.org/show_bug.cgi?id=95933

Reviewed by Adam Barth.

A few symbols from WTF are implemented in chromium on top of the chromium WebKit Platform API. These
implementation files are in WebKit/chromium/src and currently link into the webkit target, which in the
component build is a DLL. This moves these files into a static library that webkit depends on so targets can
statically link in wtf and these support files without depending directly on webkit.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Protocol Extension: Add "regionLayoutUpdate" event
commit-queue@webkit.org [Thu, 6 Sep 2012 20:19:40 +0000 (20:19 +0000)]
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-06
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT reached when TextTrack.mode is set to DISABLED.
annacc@chromium.org [Thu, 6 Sep 2012 20:06:00 +0000 (20:06 +0000)]
ASSERT reached when TextTrack.mode is set to DISABLED.
https://bugs.webkit.org/show_bug.cgi?id=94651

Reviewed by Eric Carlson.

This patch ensures that cues that have already been added to the
cueTree in HTMLMediaElement, are not added again.

Source/WebCore:

Test: media/track/track-mode-disabled-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackAddCue): Do not add the cue if it already
exists in m_cueTree.

LayoutTests:

* media/track/track-mode-disabled-crash-expected.txt: Added.
* media/track/track-mode-disabled-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerformance regressions on 32-bit platforms with revisions 125637 and 126387
yuqiang.xian@intel.com [Thu, 6 Sep 2012 19:54:14 +0000 (19:54 +0000)]
Performance regressions on 32-bit platforms with revisions 125637 and 126387
https://bugs.webkit.org/show_bug.cgi?id=95953

Reviewed by Filip Pizlo.

* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_get_by_val): Fix the typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
ggaren@apple.com [Thu, 6 Sep 2012 19:53:01 +0000 (19:53 +0000)]
Unskipped fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html
because I rolled out the patch that broke it.

* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
commit-queue@webkit.org [Thu, 6 Sep 2012 19:52:07 +0000 (19:52 +0000)]
[chromium] Add WebFrame::moveSelectionStart, moveSelectionEnd, moveCaret
https://bugs.webkit.org/show_bug.cgi?id=93998

Patch by Iain Merrick <husky@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

These provide the same functionality selectRange(WebPoint, WebPoint),
with finer-grained control needed on the Android platform. By passing
allowCollapsedSelection=false, we can ensure the selection stays at
least one character wide.

I have reimplemented WebFrameImpl::selectRange(WebPoint, WebPoint) by
calling the new methods. The existing test passes, and I've added new
tests for the new methods.

* public/WebFrame.h:
(WebFrame):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::selectRange):
(WebKit):
(WebKit::WebFrameImpl::moveSelectionStart):
(WebKit::WebFrameImpl::moveSelectionEnd):
(WebKit::WebFrameImpl::moveCaret):
* src/WebFrameImpl.h:
(WebFrameImpl):
* tests/WebFrameTest.cpp:
* tests/data/text_selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix WTF.Lrint on 32-bit platforms
benjamin@webkit.org [Thu, 6 Sep 2012 19:50:18 +0000 (19:50 +0000)]
Fix WTF.Lrint on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=96003

Patch by Fady Samuel <fsamuel@chromium.org> on 2012-09-06
Reviewed by Benjamin Poulain.

Fixed failing WTF.Lrint test on 32-bit platforms.

* TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRolled out <http://trac.webkit.org/changeset/127698> because it broke
ggaren@apple.com [Thu, 6 Sep 2012 19:45:35 +0000 (19:45 +0000)]
Rolled out <trac.webkit.org/changeset/127698> because it broke
fast/dom/HTMLScriptElement/script-reexecution-pretty-diff.html

    Named functions should not allocate scope objects for their names
    https://bugs.webkit.org/show_bug.cgi?id=95659

    Reviewed by Oliver Hunt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Need to rebaseline chromium tests after hidpi changes
commit-queue@webkit.org [Thu, 6 Sep 2012 19:29:40 +0000 (19:29 +0000)]
[chromium] Need to rebaseline chromium tests after hidpi changes
https://bugs.webkit.org/show_bug.cgi?id=95579

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by James Robinson.

Adding double resolution files for hidpi tests and updating expectations for broken image tests.

* platform/chromium-linux/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
* platform/chromium-linux/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
* platform/chromium-linux/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
* platform/chromium-linux/fast/hidpi/focus-rings-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/broken-image-icon-hidpi-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/broken-image-with-size-hidpi-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/clip-text-in-hidpi-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/focus-rings-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-as-background-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-dynamic-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-background-repeat-without-size-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-comparison-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-dynamic-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-border-image-simple-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-in-content-dynamic-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-out-of-order-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-simple-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/image-set-without-specified-width-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/resize-corner-hidpi-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/hidpi/video-controls-in-hidpi-expected.png: Removed.
* platform/chromium-mac/fast/hidpi/clip-text-in-hidpi-expected.png:
* platform/chromium-mac/fast/hidpi/device-scale-factor-paint-expected.png: Removed.
* platform/chromium-mac/fast/hidpi/focus-rings-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-as-background-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-background-dynamic-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-background-repeat-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-background-repeat-without-size-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-border-image-comparison-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-border-image-dynamic-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-border-image-simple-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-in-content-dynamic-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-out-of-order-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-simple-expected.png:
* platform/chromium-mac/fast/hidpi/image-set-without-specified-width-expected.png:
* platform/chromium-mac/fast/hidpi/resize-corner-hidpi-expected.png:
* platform/chromium-mac/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium-win/fast/hidpi/clip-text-in-hidpi-expected.png:
* platform/chromium-win/fast/hidpi/device-scale-factor-paint-expected.png:
* platform/chromium-win/fast/hidpi/focus-rings-expected.png:
* platform/chromium-win/fast/hidpi/image-set-as-background-expected.png:
* platform/chromium-win/fast/hidpi/image-set-background-dynamic-expected.png:
* platform/chromium-win/fast/hidpi/image-set-background-repeat-expected.png:
* platform/chromium-win/fast/hidpi/image-set-background-repeat-without-size-expected.png:
* platform/chromium-win/fast/hidpi/image-set-border-image-comparison-expected.png:
* platform/chromium-win/fast/hidpi/image-set-border-image-dynamic-expected.png:
* platform/chromium-win/fast/hidpi/image-set-border-image-simple-expected.png:
* platform/chromium-win/fast/hidpi/image-set-in-content-dynamic-expected.png:
* platform/chromium-win/fast/hidpi/image-set-out-of-order-expected.png:
* platform/chromium-win/fast/hidpi/image-set-simple-expected.png:
* platform/chromium-win/fast/hidpi/image-set-without-specified-width-expected.png:
* platform/chromium-win/fast/hidpi/resize-corner-hidpi-expected.png:
* platform/chromium-win/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Allow overscroll to composited scroll layers
tonikitoo@webkit.org [Thu, 6 Sep 2012 19:22:23 +0000 (19:22 +0000)]
[BlackBerry] Allow overscroll to composited scroll layers
https://bugs.webkit.org/show_bug.cgi?id=95998
PR #195305

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>
Internally reviewed by Gen Mak.

No need to reset the overscroll limit factor at creation to 0.
It is already 0 by default, and later on the client sets the
appropriated value.

* WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother unreviewed GTK build fix.
zandobersek@gmail.com [Thu, 6 Sep 2012 19:20:48 +0000 (19:20 +0000)]
Another unreviewed GTK build fix.

The ENABLE_DATALIST_ELEMENT should default to 0, as it did in stable
release versions before r127760. The feature define can be switched
on later, when its stability is determined and the test results are
rebaselined.

* GNUmakefile.features.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skipping failing test: fast/forms/number/number-interactive-validation...
roger_fong@apple.com [Thu, 6 Sep 2012 19:16:02 +0000 (19:16 +0000)]
Unreviewed. Skipping failing test: fast/forms/number/number-interactive-validation-required.html
Interactive form validation is not enabled on Windows. It's fine to skip this test.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomathml.css: Add more { white-space: nowrap } declarations
dbarton@mathscribe.com [Thu, 6 Sep 2012 19:04:55 +0000 (19:04 +0000)]
mathml.css: Add more { white-space: nowrap } declarations
https://bugs.webkit.org/show_bug.cgi?id=95404

Reviewed by Eric Seidel.

mathml.css declared { white-space: nowrap } for mrow, mfenced, msqrt. It is also needed
for other tags such as msub, msup, msubsup.

Added a test to mathml/presentation/sup.xhtml, and a regression test to roots.xhtml.

Source/WebCore:

* css/mathml.css:
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, munder, mover, munderover, msqrt, mroot):

LayoutTests:

* mathml/presentation/roots.xhtml:
* mathml/presentation/sup.xhtml:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecutio...
roger_fong@apple.com [Thu, 6 Sep 2012 19:02:20 +0000 (19:02 +0000)]
Unreviewed gardening. Skip failing test: fast/dom/HTMLScriptElement/script-reexecution.html
https://bugs.webkit.org/show_bug.cgi?id=95944

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Enable different fling behaviour for touchscreen and touchpad
rjkroege@chromium.org [Thu, 6 Sep 2012 18:54:37 +0000 (18:54 +0000)]
[chromium] Enable different fling behaviour for touchscreen and touchpad
https://bugs.webkit.org/show_bug.cgi?id=95756

Reviewed by James Robinson.

Add support for a flag on WebGestureEvents that differentiates GestureFlingStart
events by their originating device and pass this flag to a factory that produces
different device  specific fling curves based on the value of the flag.

Source/WebCore:

Covered by existing layout and unit tests.

* platform/chromium/support/PlatformGestureCurveFactory.cpp: Modified  factory
entry point for constructing fling curve for different devices.
(WebKit::PlatformGestureCurveFactory::createCurve):
* platform/chromium/support/PlatformGestureCurveFactory.h:
(PlatformGestureCurveFactory):

Source/WebKit/chromium:

* public/WebActiveWheelFlingParameters.h:
(WebActiveWheelFlingParameters): Store source device for transfer to mainthread.
(WebKit::WebActiveWheelFlingParameters::WebActiveWheelFlingParameters):
* public/WebInputEvent.h: Added source device flag to WebGestureEvent.
* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):  Use factory to
obtain device-appropriate fling curve.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleGestureEvent): Use factory to obtain device-appropriate
fling curve.
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Add the local and remote description functionality to RTCPeerConnection
tommyw@google.com [Thu, 6 Sep 2012 18:50:55 +0000 (18:50 +0000)]
MediaStream API: Add the local and remote description functionality to RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=95839

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCVoidRequest.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebCore):
(WebKit):
(WebRTCVoidRequest):
(ExtraData):
(WebKit::WebRTCVoidRequest::ExtraData::~ExtraData):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::~WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::operator=):
(WebKit::WebRTCVoidRequest::isNull):

Source/WebCore:

As well as adding the local/remote descriptions stuff, I removed the source attribute from
RTCSessionDescriptionCallback and RTCErrorCallback since it has been removed from the draft.

Tests: fast/mediastream/RTCPeerConnection-localDescription.html
       fast/mediastream/RTCPeerConnection-remoteDescription.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCErrorCallback.h:
(RTCErrorCallback):
* Modules/mediastream/RTCErrorCallback.idl:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
* Modules/mediastream/RTCPeerConnection.h:
(WebCore):
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescriptionCallback.h:
(RTCSessionDescriptionCallback):
* Modules/mediastream/RTCSessionDescriptionCallback.idl:
* Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:
(WebCore::RTCSessionDescriptionRequestImpl::create):
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded):
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed):
(WebCore::RTCSessionDescriptionRequestImpl::clear):
* Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
(RTCSessionDescriptionRequestImpl):
* Modules/mediastream/RTCVoidRequestImpl.cpp: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp.
(WebCore):
(WebCore::RTCVoidRequestImpl::create):
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl):
(WebCore::RTCVoidRequestImpl::requestSucceeded):
(WebCore::RTCVoidRequestImpl::requestFailed):
(WebCore::RTCVoidRequestImpl::stop):
(WebCore::RTCVoidRequestImpl::clear):
* Modules/mediastream/RTCVoidRequestImpl.h: Copied from Source/WebCore/Modules/mediastream/RTCSessionDescriptionCallback.h.
(WebCore):
(RTCVoidRequestImpl):
* WebCore.gypi:
* platform/chromium/support/WebRTCVoidRequest.cpp: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandler.h.
(WebKit):
(WebKit::WebRTCVoidRequest::WebRTCVoidRequest):
(WebKit::WebRTCVoidRequest::assign):
(WebKit::WebRTCVoidRequest::reset):
(WebKit::WebRTCVoidRequest::requestSucceeded):
(WebKit::WebRTCVoidRequest::requestFailed):
(ExtraDataContainer):
(WebKit::ExtraDataContainer::ExtraDataContainer):
(WebKit::ExtraDataContainer::extraData):
(WebKit::WebRTCVoidRequest::extraData):
(WebKit::WebRTCVoidRequest::setExtraData):
* platform/mediastream/RTCPeerConnectionHandler.cpp:
(RTCPeerConnectionHandlerDummy):
(WebCore::RTCPeerConnectionHandlerDummy::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerDummy::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerDummy::localDescription):
(WebCore::RTCPeerConnectionHandlerDummy::remoteDescription):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCVoidRequest.h: Copied from Source/WebCore/Modules/mediastream/RTCErrorCallback.h.
(WebCore):
(RTCVoidRequest):
(ExtraData):
(WebCore::RTCVoidRequest::ExtraData::~ExtraData):
(WebCore::RTCVoidRequest::~RTCVoidRequest):
(WebCore::RTCVoidRequest::extraData):
(WebCore::RTCVoidRequest::setExtraData):
(WebCore::RTCVoidRequest::RTCVoidRequest):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::setLocalDescription):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::setRemoteDescription):
(WebCore::RTCPeerConnectionHandlerChromium::localDescription):
(WebCore::RTCPeerConnectionHandlerChromium::remoteDescription):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Tools:

In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
up the task definitions a bit. There was no need to have them in the header file.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCVoidRequestTask):
(RTCVoidRequestTask::RTCVoidRequestTask):
(MockWebRTCPeerConnectionHandler::createOffer):
(MockWebRTCPeerConnectionHandler::setLocalDescription):
(MockWebRTCPeerConnectionHandler::setRemoteDescription):
(MockWebRTCPeerConnectionHandler::localDescription):
(MockWebRTCPeerConnectionHandler::remoteDescription):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):

LayoutTests:

* fast/mediastream/RTCPeerConnection-createOffer.html:
* fast/mediastream/RTCPeerConnection-localDescription-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-localDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.
* fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-remoteDescription.html: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-createOffer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix one of the Qt builds.
weinig@apple.com [Thu, 6 Sep 2012 18:43:12 +0000 (18:43 +0000)]
Fix one of the Qt builds.

* dom/TransformSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK build fix.
zandobersek@gmail.com [Thu, 6 Sep 2012 18:40:19 +0000 (18:40 +0000)]
Unreviewed GTK build fix.

CSS Compositing is not currently supported on the GTK port, so
the feature define should default to 0.

* GNUmakefile.features.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 6 Sep 2012 18:16:31 +0000 (18:16 +0000)]
Unreviewed GTK gardening.

Generating required platform-specific baselines after r127608.

Adding failure expectations for regressions introduced in r127698 and r127704.

Fixing and removing duplicate expectations to get the file to pass linting.

* platform/gtk/TestExpectations:
* platform/gtk/css3/masking: Added.
* platform/gtk/css3/masking/clip-path-circle-expected.png: Added.
* platform/gtk/css3/masking/clip-path-circle-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-circle-filter-expected.png: Added.
* platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Added.
* platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
* platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
* platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-ellipse-expected.png: Added.
* platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
* platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-polygon-expected.png: Added.
* platform/gtk/css3/masking/clip-path-polygon-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
* platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Added.
* platform/gtk/css3/masking/clip-path-rectangle-expected.png: Added.
* platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSharedGraphicsContext3D shouldn't depend on CCProxy
jamesr@google.com [Thu, 6 Sep 2012 18:13:21 +0000 (18:13 +0000)]
SharedGraphicsContext3D shouldn't depend on CCProxy
https://bugs.webkit.org/show_bug.cgi?id=95921

Reviewed by Adrienne Walker.

This class just wants to ASSERT() that we're on or not on the main thread. There's perfectly fine cross-platform
code in WTF to do that.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::getForImplThread):
(WebCore::SharedGraphicsContext3D::haveForImplThread):
(WebCore::SharedGraphicsContext3D::createForImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix export macros in IntegerToStringConversion.h
paroga@webkit.org [Thu, 6 Sep 2012 18:06:02 +0000 (18:06 +0000)]
Fix export macros in IntegerToStringConversion.h
https://bugs.webkit.org/show_bug.cgi?id=95900

Reviewed by Benjamin Poulain.

The WTF_EXPORT_STRING_API must be used only for symbols which are compiled
on windows in "non-WTF" binaries too. Since this isn't valid for the
IntegerToStringConversion function replace it with WTF_EXPORT_PRIVATE.

* wtf/text/IntegerToStringConversion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Remove configuration options for features that are not supported by the Gtk...
zandobersek@gmail.com [Thu, 6 Sep 2012 17:58:42 +0000 (17:58 +0000)]
[Gtk] Remove configuration options for features that are not supported by the Gtk port
https://bugs.webkit.org/show_bug.cgi?id=87664

Reviewed by Martin Robinson.

.:

Remove configuration options for features that are completely unsupported by the GTK port.
They only bloat the configure.ac file. They should be re-added when the feature becomes
supported and introduces an external dependency that the users might want to avoid.

* configure.ac:

Source/WebCore:

Remove addition of macros to feature_defines for features that are completely
unsupported by the Gtk port. They're not required anymore since the accompanying
configuration flags are also being removed.

No new tests - no new functionality.

* GNUmakefile.am:
* bindings/gobject/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
commit-queue@webkit.org [Thu, 6 Sep 2012 17:44:59 +0000 (17:44 +0000)]
[CSS Shaders] Vertex attributes should be unbound after a custom filter is applied
https://bugs.webkit.org/show_bug.cgi?id=95891

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-09-06
Reviewed by Dean Jackson.

Now we unbind the vertex attributes after a custom filter is applied.

Before this patch, Chromium's GPU process would sometimes print the following error message:
"ERROR:gles2_cmd_decoder.cc(5142)] 002CA47B: GL ERROR :GL_INVALID_OPERATION :
glDrawElements: attempt to render with no buffer attached to enabled attribute 2"

This would happen in the following situation:
1) There are two FECustomFilters on the page.
2) One FECustomFilter has a detached mesh. One FECustomFilter has an attached mesh. The
   detached FECustomFilter has one more vertex attribute (a_triangleCoord) than the attached
   FECustomFilter.
3) The detached FECustomFilter is destroyed, but a_triangleCoord remains bound.
4) The attached FECustomFilter tries to render, but Chromium notices that there is no buffer
   attached to the a_triangleCoord attribute.

No new tests. We can't create an automated test for this because it only reproduces using
Chromium's GPU process. DRT does not use Chromium's GPU process.

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::applyShader):
    Unbind the vertex attributes after the drawElements call.
(WebCore::FECustomFilter::unbindVertexAttribute):
(WebCore):
(WebCore::FECustomFilter::unbindVertexAttributes):
    Unbind all of the attributes that we bound earlier.
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPart 2 of removing PlatformString.h, remove PlatformString.h
weinig@apple.com [Thu, 6 Sep 2012 17:36:48 +0000 (17:36 +0000)]
Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931

Reviewed by Adam Barth.

Remove PlatformString.h

Source/WebCore:

* GNUmakefile.list.am:
* Modules/filesystem/AsyncFileWriter.h:
* Modules/filesystem/DOMFilePath.h:
* Modules/filesystem/DOMFileSystemBase.h:
* Modules/filesystem/DirectoryEntry.h:
* Modules/filesystem/DirectoryEntrySync.h:
* Modules/filesystem/DirectoryReader.h:
* Modules/filesystem/DirectoryReaderBase.h:
* Modules/filesystem/DirectoryReaderSync.h:
* Modules/filesystem/EntryBase.cpp:
* Modules/filesystem/EntrySync.h:
* Modules/filesystem/FileEntrySync.h:
* Modules/filesystem/FileSystemCallbacks.h:
* Modules/filesystem/LocalFileSystem.h:
* Modules/geolocation/GeolocationError.h:
* Modules/geolocation/Geoposition.h:
* Modules/geolocation/PositionError.h:
* Modules/indexeddb/IDBAny.h:
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
* Modules/indexeddb/IDBDatabaseCallbacks.h:
* Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
* Modules/indexeddb/IDBDatabaseError.h:
* Modules/indexeddb/IDBFactory.h:
* Modules/indexeddb/IDBFactoryBackendInterface.h:
* Modules/indexeddb/IDBIndex.h:
* Modules/indexeddb/IDBIndexBackendInterface.h:
* Modules/indexeddb/IDBKey.h:
* Modules/indexeddb/IDBKeyPath.h:
* Modules/indexeddb/IDBMetadata.h:
* Modules/indexeddb/IDBObjectStore.h:
* Modules/indexeddb/IDBObjectStoreBackendInterface.h:
* Modules/indexeddb/IDBTransactionBackendInterface.h:
* Modules/indexeddb/IDBUpgradeNeededEvent.h:
* Modules/indexeddb/IDBVersionChangeEvent.h:
* Modules/mediastream/MediaStreamTrack.h:
* Modules/networkinfo/NetworkInfoConnection.h:
* Modules/notifications/DOMWindowNotifications.h:
* Modules/speech/SpeechGrammar.h:
* Modules/speech/SpeechRecognition.h:
* Modules/speech/SpeechRecognitionAlternative.h:
* Modules/speech/SpeechRecognitionClient.h:
* Modules/speech/SpeechRecognitionError.h:
* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioParam.h:
* Modules/webdatabase/AbstractDatabase.h:
* Modules/webdatabase/ChangeVersionWrapper.h:
* Modules/webdatabase/DOMWindowWebDatabase.h:
* Modules/webdatabase/Database.h:
* Modules/webdatabase/DatabaseAuthorizer.cpp:
* Modules/webdatabase/DatabaseAuthorizer.h:
* Modules/webdatabase/DatabaseDetails.h:
* Modules/webdatabase/DatabaseSync.h:
* Modules/webdatabase/DatabaseTask.h:
* Modules/webdatabase/DatabaseTracker.h:
* Modules/webdatabase/OriginUsageRecord.h:
* Modules/webdatabase/SQLError.h:
* Modules/webdatabase/SQLStatement.h:
* Modules/webdatabase/SQLStatementSync.h:
* Modules/webdatabase/SQLTransaction.cpp:
* Modules/webdatabase/SQLTransactionSync.cpp:
* Modules/webdatabase/SQLTransactionSync.h:
* Modules/webdatabase/WorkerContextWebDatabase.h:
* Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
* Modules/webdatabase/chromium/QuotaTracker.h:
* Modules/websockets/ThreadableWebSocketChannel.cpp:
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
* Modules/websockets/WebSocketHandshake.h:
* Modules/websockets/WebSocketHandshakeResponse.h:
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/gobject/ConvertToUTF8String.cpp:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSClipboardCustom.cpp:
* bindings/js/JSImageDataCustom.cpp:
* bindings/js/JSInspectorFrontendHostCustom.cpp:
* bindings/js/JSLazyEventListener.h:
* bindings/js/JSStorageCustom.cpp:
* bindings/js/JSXSLTProcessorCustom.cpp:
* bindings/js/JavaScriptCallFrame.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptHeapSnapshot.h:
* bindings/js/ScriptValue.h:
* bindings/js/SerializedScriptValue.h:
* bindings/objc/DOMCustomXPathNSResolver.mm:
* bindings/objc/DOMXPath.mm:
* bindings/objc/WebScriptObject.mm:
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForTypeInImpl):
(AddIncludesForSVGAnimatedType):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
* bindings/v8/Dictionary.h:
* bindings/v8/JavaScriptCallFrame.h:
* bindings/v8/NPV8Object.cpp:
* bindings/v8/ScriptDebugServer.h:
* bindings/v8/ScriptFunctionCall.h:
* bindings/v8/ScriptHeapSnapshot.h:
* bindings/v8/ScriptProfile.h:
* bindings/v8/ScriptProfileNode.h:
* bindings/v8/ScriptProfiler.h:
* bindings/v8/ScriptSourceCode.h:
* bindings/v8/V8Binding.cpp:
* bindings/v8/V8DOMWrapper.h:
* bindings/v8/V8LazyEventListener.h:
* bindings/v8/V8NPUtils.cpp:
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
* bindings/v8/custom/V8LocationCustom.cpp:
* bridge/IdentifierRep.cpp:
* bridge/NP_jsobject.cpp:
* bridge/c/c_utility.cpp:
* css/CSSBasicShapes.h:
* css/CSSBorderImageSliceValue.cpp:
* css/CSSCharsetRule.h:
* css/CSSCursorImageValue.cpp:
* css/CSSFontFaceSrcValue.h:
* css/CSSGradientValue.cpp:
* css/CSSInheritedValue.cpp:
* css/CSSInitialValue.cpp:
* css/CSSLineBoxContainValue.cpp:
* css/CSSMediaRule.h:
* css/CSSProperty.cpp:
* css/CSSPropertySourceData.cpp:
* css/CSSPropertySourceData.h:
* css/CSSReflectValue.cpp:
* css/CSSTimingFunctionValue.cpp:
* css/CSSUnicodeRangeValue.cpp:
* css/CSSValueList.cpp:
* css/Counter.h:
* css/FontFeatureValue.h:
* css/FontValue.cpp:
* css/MediaQuery.h:
* css/MediaQueryEvaluator.h:
* css/MediaQueryListListener.h:
* css/ShadowValue.cpp:
* css/StyleMedia.h:
* css/StyleSheet.h:
* css/StyleSheetList.cpp:
* css/WebKitCSSMatrix.h:
* css/WebKitCSSTransformValue.cpp:
* dom/DOMStringList.h:
* dom/DOMStringMap.h:
* dom/DocumentMarker.h:
* dom/ErrorEvent.h:
* dom/ExceptionBase.h:
* dom/MessagePortChannel.h:
* dom/MutationRecord.h:
* dom/TransformSource.h:
* dom/ViewportArguments.cpp:
* editing/DOMTransactionStep.h:
* editing/EditingStyle.h:
* editing/MarkupAccumulator.h:
* editing/SmartReplaceICU.cpp:
* editing/SpellChecker.h:
* editing/SurroundingText.h:
* fileapi/AsyncFileStream.cpp:
* fileapi/Blob.h:
* fileapi/BlobURL.cpp:
* fileapi/File.h:
* history/HistoryItem.h:
* history/blackberry/HistoryItemViewState.h:
* history/cf/HistoryPropertyList.h:
* html/DOMFormData.cpp:
* html/DOMURL.h:
* html/MicroDataItemValue.h:
* html/PublicURLManager.h:
* html/canvas/CanvasPattern.cpp:
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasStyle.h:
* html/canvas/WebGLActiveInfo.h:
* html/canvas/WebGLGetInfo.h:
* html/canvas/WebGLRenderingContext.h:
* html/parser/CSSPreloadScanner.h:
* html/parser/HTMLEntitySearch.h:
* html/parser/HTMLEntityTable.h:
* html/parser/HTMLMetaCharsetParser.cpp:
* inspector/CodeGeneratorInspector.py:
(InspectorFrontend_h):
* inspector/ContentSearchUtils.h:
* inspector/InjectedScript.cpp:
* inspector/InjectedScriptBase.cpp:
* inspector/InjectedScriptManager.h:
* inspector/InjectedScriptModule.h:
* inspector/InjectedScriptWebGLModule.h:
* inspector/InspectorAgent.h:
* inspector/InspectorCSSAgent.h:
* inspector/InspectorController.h:
* inspector/InspectorDOMDebuggerAgent.h:
* inspector/InspectorDOMStorageAgent.h:
* inspector/InspectorDatabaseAgent.h:
* inspector/InspectorDatabaseResource.h:
* inspector/InspectorFrontendClientLocal.cpp:
* inspector/InspectorFrontendClientLocal.h:
* inspector/InspectorFrontendHost.h:
* inspector/InspectorIndexedDBAgent.h:
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.h:
* inspector/InspectorResourceAgent.h:
* inspector/InspectorState.h:
* inspector/InspectorStyleSheet.h:
* inspector/InspectorStyleTextEditor.h:
* inspector/InspectorValues.h:
* inspector/InspectorWebGLAgent.h:
* inspector/InspectorWorkerResource.h:
* inspector/ScriptArguments.h:
* inspector/ScriptBreakpoint.h:
* inspector/ScriptCallFrame.h:
* inspector/ScriptDebugListener.h:
* inspector/TimelineRecordFactory.h:
* inspector/generate-inspector-protocol-version:
(main):
* loader/DocumentLoader.cpp:
* loader/DocumentWriter.h:
* loader/FTPDirectoryParser.h:
* loader/FormState.h:
* loader/HistoryController.h:
* loader/PolicyChecker.h:
* loader/ResourceLoadScheduler.h:
* loader/SubframeLoader.h:
* loader/SubstituteData.h:
* loader/WorkerThreadableLoader.h:
* loader/appcache/ApplicationCache.h:
* loader/appcache/ApplicationCacheGroup.h:
* loader/archive/ArchiveFactory.cpp:
* loader/archive/ArchiveResourceCollection.h:
* loader/cache/CachedResource.h:
* loader/cache/MemoryCache.h:
* loader/icon/IconRecord.h:
* loader/icon/PageURLRecord.h:
* loader/mac/LoaderNSURLExtras.mm:
* loader/win/DocumentLoaderWin.cpp:
* page/Console.cpp:
* page/Coordinates.h:
* page/DOMSelection.cpp:
* page/EventSource.cpp:
* page/GroupSettings.h:
* page/NavigatorBase.cpp:
* page/OriginAccessEntry.h:
* page/Page.h:
* page/SecurityOrigin.h:
* page/SpeechInputResult.h:
* page/UserContentURLPattern.h:
* page/WindowFeatures.cpp:
* page/WindowFeatures.h:
* page/WorkerNavigator.h:
* page/animation/AnimationControllerPrivate.h:
* platform/AsyncFileSystem.h:
* platform/AsyncFileSystemCallbacks.h:
* platform/ContentType.h:
* platform/ContextMenu.h:
* platform/ContextMenuItem.h:
* platform/Cookie.h:
* platform/CrossThreadCopier.cpp:
* platform/DateComponents.cpp:
* platform/FileChooser.h:
* platform/FileStream.cpp:
* platform/FileSystem.h:
* platform/KURL.cpp:
(WebCore):
* platform/KURL.h:
* platform/KURLHash.h:
* platform/KillRing.h:
* platform/Language.cpp:
* platform/Length.cpp:
* platform/LinkHash.cpp:
* platform/Logging.cpp:
* platform/MIMETypeRegistry.h:
* platform/SSLKeyGenerator.h:
* platform/SchemeRegistry.h:
* platform/SharedBuffer.h:
* platform/Theme.h:
* platform/UUID.h:
* platform/animation/Animation.h:
* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieMap.h:
* platform/blackberry/DragDataBlackBerry.cpp:
* platform/blackberry/KURLBlackBerry.cpp:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
* platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
* platform/blackberry/TemporaryLinkStubs.cpp:
* platform/cf/FileSystemCF.cpp:
* platform/cf/SchedulePair.h:
* platform/chromium/ChromiumDataObject.h:
* platform/chromium/ClipboardUtilitiesChromium.cpp:
* platform/chromium/DragDataChromium.cpp:
* platform/chromium/FileSystemChromium.cpp:
* platform/chromium/FileSystemChromiumMac.mm:
* platform/chromium/LanguageChromium.cpp:
* platform/chromium/SSLKeyGeneratorChromium.cpp:
* platform/cocoa/KeyEventCocoa.mm:
* platform/efl/ErrorsEfl.h:
* platform/efl/LanguageEfl.cpp:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/efl/LoggingEfl.cpp:
* platform/efl/PasteboardEfl.cpp:
* platform/efl/PlatformScreenEfl.cpp:
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/BitmapImage.cpp:
* platform/graphics/FontPlatformData.cpp:
* platform/graphics/GlyphPageTreeNode.cpp:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/SegmentedFontData.cpp:
* platform/graphics/blackberry/IconBlackBerry.cpp:
* platform/graphics/blackberry/LayerData.h:
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
* platform/graphics/blackberry/LayerRenderer.cpp:
* platform/graphics/blackberry/skia/PlatformSupport.h:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/PlatformCALayerClient.h:
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
* platform/graphics/cairo/ImageBufferCairo.cpp:
* platform/graphics/cairo/PathCairo.cpp:
* platform/graphics/cg/ImageSourceCGMac.mm:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/chromium/FontUtilsChromiumWin.cpp:
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
* platform/graphics/chromium/IconChromium.cpp:
* platform/graphics/chromium/IconChromiumAndroid.cpp:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
* platform/graphics/efl/IconEfl.cpp:
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEDisplacementMap.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
* platform/graphics/filters/SourceGraphic.h:
* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
* platform/graphics/mac/IconMac.mm:
* platform/graphics/mac/ImageMac.mm:
* platform/graphics/opentype/OpenTypeUtilities.h:
* platform/graphics/openvg/PathOpenVG.cpp:
* platform/graphics/pango/FontPlatformDataPango.cpp:
* platform/graphics/qt/FontCacheQt.cpp:
* platform/graphics/qt/FontPlatformDataQt.cpp:
* platform/graphics/qt/IconQt.cpp:
* platform/graphics/qt/ImageQt.cpp:
* platform/graphics/qt/PathQt.cpp:
* platform/graphics/skia/FontCustomPlatformData.h:
* platform/graphics/skia/ImageSkia.cpp:
* platform/graphics/win/FontCustomPlatformData.h:
* platform/graphics/win/FontPlatformDataCGWin.cpp:
* platform/graphics/win/FontPlatformDataCairoWin.cpp:
* platform/graphics/win/FontPlatformDataWin.cpp:
* platform/graphics/win/IconWin.cpp:
* platform/graphics/win/ImageCGWin.cpp:
* platform/graphics/win/ImageCairoWin.cpp:
* platform/graphics/win/SimpleFontDataCGWin.cpp:
* platform/graphics/wince/FontCustomPlatformData.h:
* platform/graphics/wince/FontPlatformData.cpp:
* platform/graphics/wince/ImageWinCE.cpp:
* platform/graphics/wince/MediaPlayerProxy.cpp:
* platform/graphics/wince/PathWinCE.cpp:
* platform/graphics/wince/PlatformPathWinCE.cpp:
* platform/graphics/wx/FontCacheWx.cpp:
* platform/graphics/wx/FontPlatformDataWx.cpp:
* platform/graphics/wx/IconWx.cpp:
* platform/graphics/wx/PathWx.cpp:
* platform/gtk/ErrorsGtk.h:
* platform/gtk/FileSystemGtk.cpp:
* platform/gtk/GtkPopupMenu.h:
* platform/gtk/KeyBindingTranslator.h:
* platform/gtk/LanguageGtk.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/gtk/LoggingGtk.cpp:
* platform/gtk/PasteboardGtk.cpp:
* platform/image-decoders/ImageDecoder.h:
* platform/leveldb/LevelDBSlice.h:
* platform/mac/FileSystemMac.mm:
* platform/mediastream/MediaStreamSource.h:
* platform/mock/GeolocationClientMock.h:
* platform/network/BlobData.h:
* platform/network/BlobRegistryImpl.h:
* platform/network/BlobResourceHandle.h:
* platform/network/Credential.h:
* platform/network/FormData.h:
* platform/network/FormDataBuilder.h:
* platform/network/HTTPParsers.cpp:
* platform/network/HTTPRequest.h:
* platform/network/HTTPValidation.cpp:
* platform/network/ProtectionSpace.h:
* platform/network/ResourceErrorBase.h:
* platform/network/SocketStreamErrorBase.h:
* platform/network/blackberry/DNSBlackBerry.cpp:
* platform/network/blackberry/DeferredData.h:
* platform/network/blackberry/NetworkJob.h:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/curl/CookieJarCurl.cpp:
* platform/network/curl/ResourceHandleManager.h:
* platform/network/qt/DnsPrefetchHelper.cpp:
* platform/network/soup/ResourceRequestSoup.cpp:
* platform/network/soup/ResourceResponseSoup.cpp:
* platform/network/win/CookieJarWin.cpp:
* platform/posix/FileSystemPOSIX.cpp:
* platform/qt/ClipboardQt.cpp:
* platform/qt/CookieJarQt.cpp:
* platform/qt/FileSystemQt.cpp:
* platform/qt/LanguageQt.cpp:
* platform/qt/LocalizedStringsQt.cpp:
* platform/qt/LoggingQt.cpp:
* platform/qt/PlatformSupport.h:
* platform/sql/SQLValue.h:
* platform/sql/SQLiteDatabase.h:
* platform/sql/SQLiteFileSystem.h:
* platform/text/DecodeEscapeSequences.h:
* platform/text/LineEnding.cpp:
* platform/text/ParserUtilities.h:
* platform/text/PlatformString.h: Removed.
* platform/text/RegularExpression.h:
* platform/text/SegmentedString.h:
* platform/text/StringWithDirection.h:
* platform/text/SuffixTree.h:
* platform/text/TextBreakIteratorICU.cpp:
* platform/text/TextCodec.cpp:
* platform/text/TextCodec.h:
* platform/text/TextCodecLatin1.cpp:
* platform/text/TextCodecUTF16.cpp:
* platform/text/TextCodecUserDefined.cpp:
* platform/text/TextEncoding.cpp:
* platform/text/blackberry/StringBlackBerry.cpp:
* platform/text/cf/StringCF.cpp:
* platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp:
* platform/text/gtk/TextCodecGtk.cpp:
* platform/text/mac/StringMac.mm:
* platform/text/mac/TextCodecMac.cpp:
* platform/text/qt/TextCodecQt.cpp:
* platform/text/win/TextCodecWin.h:
* platform/text/wince/TextBreakIteratorWinCE.cpp:
* platform/win/BString.cpp:
* platform/win/DragDataWin.cpp:
* platform/win/GDIObjectCounter.h:
* platform/win/LoggingWin.cpp:
* platform/win/WCDataObject.cpp:
* platform/wince/DragDataWinCE.cpp:
* platform/wx/ClipboardWx.cpp:
* platform/wx/FileSystemWx.cpp:
* platform/wx/LanguageWx.cpp:
* platform/wx/LocalizedStringsWx.cpp:
* platform/wx/LoggingWx.cpp:
* platform/wx/PasteboardWx.cpp:
* platform/wx/PopupMenuWx.cpp:
* plugins/PluginData.h:
* plugins/PluginDatabase.h:
* plugins/PluginDebug.cpp:
* plugins/PluginPackage.h:
* plugins/PluginStream.h:
* rendering/style/StyleDashboardRegion.h:
* storage/Storage.cpp:
* storage/StorageArea.h:
* storage/StorageEvent.h:
* storage/StorageEventDispatcher.h:
* storage/StorageMap.h:
* storage/StorageNamespace.h:
* storage/StorageNamespaceImpl.h:
* storage/StorageSyncManager.h:
* storage/StorageTask.h:
* storage/StorageTracker.h:
* svg/SVGPathByteStreamBuilder.h:
* svg/SVGPathParser.h:
* svg/SVGPathStringSource.h:
* svg/SVGStyledElement.cpp:
* svg/animation/SMILTimeContainer.h:
* svg/graphics/filters/SVGFilterBuilder.cpp:
* svg/graphics/filters/SVGFilterBuilder.h:
* testing/Internals.h:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/WorkerLocation.cpp:
* workers/WorkerThread.cpp:
* xml/DOMParser.cpp:
* xml/NativeXPathNSResolver.cpp:
* xml/XMLSerializer.cpp:
* xml/XMLSerializer.h:
* xml/XPathExpression.cpp:
* xml/XPathValue.h:
* xml/XSLTUnicodeSort.cpp:

Source/WebKit/blackberry:

* Api/DumpRenderTreeClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
* WebCoreSupport/InspectorClientBlackBerry.h:
* WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp:
* WebKitSupport/AboutData.h:

Source/WebKit/cf:

* WebCoreSupport/WebInspectorClientCF.cpp:
(WebInspectorClient::createFrontendSettings):

Source/WebKit/chromium:

* src/ContextMenuClientImpl.cpp:
* src/EditorClientImpl.cpp:
* src/InspectorFrontendClientImpl.cpp:
* src/LocalFileSystemChromium.cpp:
* src/SpeechInputClientImpl.cpp:
* src/SpeechRecognitionClientProxy.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsFrontendImpl.cpp:
* src/WebDevToolsFrontendImpl.h:
* src/WebEntities.h:
* src/WebFrameImpl.h:
* src/WorkerFileSystemCallbacksBridge.h:
* tests/UniscribeHelperTest.cpp:

Source/WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.cpp:

Source/WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/InspectorClientGtk.cpp:
* gdom/ConvertToGCharPrivate.h:
* webkit/webkitsecurityorigin.cpp:
* webkit/webkitwebdatasource.cpp:
* webkit/webkitwebhistoryitem.cpp:
* webkit/webkitwebresource.cpp:

Source/WebKit/mac:

* History/WebHistoryItem.mm:
* Misc/WebStringTruncator.mm:
* Plugins/Hosted/NetscapePluginHostManager.h:
(NetscapePluginHostManager):
* Plugins/WebPluginController.mm:
* Storage/WebStorageTrackerClient.mm:
* WebCoreSupport/WebChromeClient.mm:
* WebCoreSupport/WebEditorClient.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebCoreSupport/WebIconDatabaseClient.mm:
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
(WebInspectorFrontendClient):
* WebView/WebRenderLayer.mm:
* WebView/WebViewData.h:

Source/WebKit/qt:

* Api/qwebdatabase_p.h:
* Api/qwebframe_p.h:
* Api/qwebhistory.cpp:
* Api/qwebhistoryinterface.cpp:
* Api/qwebpage_p.h:
* Api/qwebsettings.cpp:
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/InspectorClientQt.cpp:

Source/WebKit/win:

* DOMCSSClasses.cpp:
* DefaultPolicyDelegate.cpp:
* MarshallingHelpers.cpp:
* WebCoreSupport/WebInspectorClient.h:
* WebDownload.h:
* WebFrame.h:
* WebHistoryItem.h:
* WebIconDatabase.cpp:
* WebKitDLL.h:
* WebKitGraphics.cpp:
* WebKitSystemBits.cpp:
* WebLocalizableStrings.cpp:
* WebNotificationCenter.cpp:
* WebResource.h:

Source/WebKit/wx:

* WebFrame.cpp:
* WebKitSupport/ChromeClientWx.cpp:
* WebKitSupport/EditorClientWx.cpp:
* WebKitSupport/FrameLoaderClientWx.cpp:
* WebKitSupport/InspectorClientWx.cpp:
* WebSettings.cpp:
* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a customized copy() method to CCRenderPassDrawQuad
danakj@chromium.org [Thu, 6 Sep 2012 17:29:05 +0000 (17:29 +0000)]
[chromium] Add a customized copy() method to CCRenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=95871

Reviewed by Adrienne Walker.

Source/WebCore:

CCRenderPassDrawQuad is special because a copied quad will need to
point to a different RenderPass id, since new ids are given to copied
RenderPasses. Add a custom copy() method to CCRenderPassDrawQuad that
takes as input the new RenderPass id that should appear in the copied
quad.

Test: CCDrawQuad.copyRenderPassDrawQuad

* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::copy):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::copy):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):

Source/WebKit/chromium:

* tests/CCDrawQuadTest.cpp:
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
commit-queue@webkit.org [Thu, 6 Sep 2012 17:26:07 +0000 (17:26 +0000)]
gradient-with-scaled-ancestor.html is not calling setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=95847

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-09-06
Reviewed by Beth Dakin.

Setting the device scale factor in the layout test and updating expectations until we can rebase

* fast/hidpi/gradient-with-scaled-ancestor.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Annotate multi-process FIXMEs with bug numbers
ap@apple.com [Thu, 6 Sep 2012 17:16:17 +0000 (17:16 +0000)]
    [WK2] Annotate multi-process FIXMEs with bug numbers
        https://bugs.webkit.org/show_bug.cgi?id=95916

        Reviewed by Eric Carlson.

        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::setProcessModel): Ensure that plug-in process is enabled.
        Comments in WebPluginSiteDataManager said that it's required for multi-process.
        (WebKit::WebContext::createNewWebProcess): Added a bug number.
        (WebKit::WebContext::disconnectProcess): Ditto.
        (WebKit::WebContext::createWebPage): Ditto.
        (WebKit::WebContext::download): Ditto.
        (WebKit::WebContext::getWebCoreStatistics): Ditto.

        * UIProcess/Plugins/WebPluginSiteDataManager.cpp:
        (WebKit::WebPluginSiteDataManager::getSitesWithData):
        (WebKit::WebPluginSiteDataManager::clearSiteData):
        Removed FIXMEs - some ports haven't switched to plugin process yet, but that
        doesn't stop others from having a multi-process model. Added an ASSERT to document
        this requirement (in addition to the check in WebContext).

        * UIProcess/Downloads/DownloadProxy.cpp:
        (WebKit::DownloadProxy::cancel):
        (WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
        (WebKit::DownloadProxy::startTransfer):
        * UIProcess/WebApplicationCacheManagerProxy.cpp:
        (WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
        (WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
        (WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
        * UIProcess/WebCookieManagerProxy.cpp:
        (WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
        (WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
        * UIProcess/WebDatabaseManagerProxy.cpp:
        (WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
        (WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
        (WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
        (WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
        (WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
        (WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
        * UIProcess/WebIconDatabase.cpp:
        (WebKit::WebIconDatabase::getLoadDecisionForIconURL):
        (WebKit::WebIconDatabase::didFinishURLImport):
        * UIProcess/WebKeyValueStorageManagerProxy.cpp:
        (WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
        (WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
        (WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
        * UIProcess/WebMediaCacheManagerProxy.cpp:
        (WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
        * UIProcess/WebResourceCacheManagerProxy.cpp:
        (WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
        (WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
        (WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
        Added bug numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit2 IPC always sends strings using 16 bit data format
msaboff@apple.com [Thu, 6 Sep 2012 17:14:32 +0000 (17:14 +0000)]
WebKit2 IPC always sends strings using 16 bit data format
https://bugs.webkit.org/show_bug.cgi?id=95811

Reviewed by Benjamin Poulain.

Changed string encoding to pass an 8bit flag and then send either 8 or 16 bit
character data.

* Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::decodeStringText): New templatized string creation and decoder method.
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
commit-queue@webkit.org [Thu, 6 Sep 2012 17:13:48 +0000 (17:13 +0000)]
Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
https://bugs.webkit.org/show_bug.cgi?id=95780

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-06
Reviewed by Eric Seidel.

Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.

* Modules/mediastream/MediaStreamEvent.h:
* dom/Event.cpp:
* dom/Event.h:
(WebCore):
* dom/EventDispatchMediator.cpp:
* dom/EventListenerMap.cpp:
* dom/MouseRelatedEvent.h:
* dom/UIEvent.cpp:
* html/FormAssociatedElement.h:
(WebCore):
* inspector/TimelineRecordFactory.cpp:
* platform/graphics/FontPlatformData.h:
* rendering/RenderLineBoxList.h:
* rendering/style/RenderStyle.h:
(WebCore):
* svg/SVGAnimatedType.h:
* svg/SVGExternalResourcesRequired.cpp:
* svg/SVGExternalResourcesRequired.h:
(WebCore):
* svg/SVGURIReference.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
mitz@apple.com [Thu, 6 Sep 2012 17:11:32 +0000 (17:11 +0000)]
REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
https://bugs.webkit.org/show_bug.cgi?id=95972

Source/WebCore:

Reverted r127712, because it was based on the false premise that “[Optional] works the way
XMLHttpRequest expects”.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::openCallback):
(WebCore):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):
* xml/XMLHttpRequest.idl:

LayoutTests:

Removed the failing test from the skipped list.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Crash when navigating between pages
carlosgc@webkit.org [Thu, 6 Sep 2012 16:53:41 +0000 (16:53 +0000)]
[GTK] [WK2] Crash when navigating between pages
https://bugs.webkit.org/show_bug.cgi?id=95949

Reviewed by Martin Robinson.

Do not trust isMainResource parameter in
webkitWebViewResourceLoadStarted(), because it's always true for
all subresources of pages loaded from the history cache. We can
simply assume that the first resource loaded for the main frame
is the main web view resource.

* UIProcess/API/gtk/WebKitResourceLoadClient.cpp:
(didInitiateLoadForResource):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewResourceLoadStarted):
* UIProcess/API/gtk/WebKitWebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add API to get/set the security policy of a given URI scheme
carlosgc@webkit.org [Thu, 6 Sep 2012 16:49:30 +0000 (16:49 +0000)]
[GTK] Add API to get/set the security policy of a given URI scheme
https://bugs.webkit.org/show_bug.cgi?id=95549

Reviewed by Martin Robinson.

Add WebKitSecurityPolicy enum with flags that represent the
security policy of a URI scheme. Add methods to get and set the
security policy flags for a given URI scheme.

* docs/webkitgtk-sections.txt: Add new symbols.
* tests/testglobals.c:
(test_globals_security_policy):
(main):
* webkit/webkitglobals.cpp:
(webkit_set_security_policy_for_uri_scheme):
(webkit_get_security_policy_for_uri_scheme):
* webkit/webkitglobals.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse native function bind in page popups
keishi@webkit.org [Thu, 6 Sep 2012 16:41:23 +0000 (16:41 +0000)]
Use native function bind in page popups
https://bugs.webkit.org/show_bug.cgi?id=95976

Reviewed by Kent Tamura.

We should be using Function.prototype.bind instead of our own bind implementation.

No new tests. No behavior change.

* Resources/pagepopups/calendarPicker.js:
(CalendarPicker):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._attachLeftButtonsTo):
(YearMonthController.prototype._attachRightButtonsTo):
(DaysTable.prototype.attachTo):
* Resources/pagepopups/colorSuggestionPicker.js:
(ColorPicker):
(ColorPicker.prototype._layout):
* Resources/pagepopups/pickerCommon.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ANGLE] Fix the build with gcc 4.7
abecsi@webkit.org [Thu, 6 Sep 2012 16:25:36 +0000 (16:25 +0000)]
[ANGLE] Fix the build with gcc 4.7
https://bugs.webkit.org/show_bug.cgi?id=95989

Reviewed by Csaba Osztrogonác.

The build fails because of a bogus warning about the auto-generated
pplval variable. Unfortunately the warning is called -Wuninitialized
in gcc 4.6 and -Wmaybe-uninitialized in gcc 4.7 thus we also need to
ignore unknown pragmas not to break the build with compilers that do
not recognize these options.

* src/compiler/preprocessor/new/ExpressionParser.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
commit-queue@webkit.org [Thu, 6 Sep 2012 16:00:09 +0000 (16:00 +0000)]
Web Inspector: Timeline: cache "filteredRecords" for better scrolling performance.
https://bugs.webkit.org/show_bug.cgi?id=95731

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-09-06
Reviewed by Yury Semikhatsky.

Now scrolling is sluggish on large datasets.
Performance degrades, because each refresh causes DFS on all recorded items.
Solution: caching/invalidation of DFS (filtering) results.

Also fixed "truncate selected record range on mode change" glitch.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
Add flag for cache invalidation.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.invalidateFilteredRecords):
Added.
(WebInspector.TimelinePresentationModel.prototype.filteredRecords):
Caching/using cached results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPop...
kbalazs@webkit.org [Thu, 6 Sep 2012 15:54:53 +0000 (15:54 +0000)]
[WK2] Crash in WebPageProxy::showPopupMenu if PageClient does not implement createPopupMenuProxy
https://bugs.webkit.org/show_bug.cgi?id=95862

Reviewed by Simon Hausmann.

Bail out early if the PageClient does not create a PopupMenuProxy for us.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r127728, r127534
commit-queue@webkit.org [Thu, 6 Sep 2012 15:42:18 +0000 (15:42 +0000)]
[EFL] Gardening after r127728, r127534
https://bugs.webkit.org/show_bug.cgi?id=95975

Unreviewed gardening.

Following tests were added to TestExpectations:
http/tests/xmlhttprequest/basic-auth.html fails after r127728.
fast/innerHTML/innerHTML-iframe.html fails after r127534.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

* platform/efl/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.
loislo@chromium.org [Thu, 6 Sep 2012 15:40:09 +0000 (15:40 +0000)]
Unreviewed rebaseline for Web Inspector NMI test. It was broken at r127738.

* inspector/profiler/memory-instrumentation-cached-images-expected.txt:
* inspector/profiler/memory-instrumentation-cached-images.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build on Mac OS X 10.6
commit-queue@webkit.org [Thu, 6 Sep 2012 15:31:02 +0000 (15:31 +0000)]
[Qt] Fix build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=95200

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-06
Reviewed by Tor Arne Vestbø.

The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
10.7 and newer.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Web Inspector: test fix.
loislo@chromium.org [Thu, 6 Sep 2012 15:04:46 +0000 (15:04 +0000)]
Unreviewed Web Inspector: test fix.

* tests/MemoryInstrumentationTest.cpp:
(StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::StringOwnerInstrumented):
(WebCore::StringOwnerInstrumented::reportMemoryUsage):
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Remove unnecessary logic in ewk_frame_source_get.
commit-queue@webkit.org [Thu, 6 Sep 2012 14:38:30 +0000 (14:38 +0000)]
[EFL] Remove unnecessary logic in ewk_frame_source_get.
https://bugs.webkit.org/show_bug.cgi?id=95828

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Removed unnecessary logic that checks if <html> tag exists in document.
WebKit automatically fill out <html></html> tags if they are not existed.

* ewk/ewk_frame.cpp:
(ewk_frame_source_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
commit-queue@webkit.org [Thu, 6 Sep 2012 14:36:04 +0000 (14:36 +0000)]
[WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
https://bugs.webkit.org/show_bug.cgi?id=95973

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Tools:

Correctly map "addSelectionKey" to "Control" modifier
in WKTR's EventSender on other OSes than Mac OS X,
instead of mapping it to the "Meta" modifier.

* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::parseModifier):

LayoutTests:

Unskip several test cases that are passing on WebKit2
now that "addSelectionKey" is properly mapped to
"Control" modifier on other OSes than Mac OS X, in
WKTR's EventSender.

* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/Skipped:
* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use...
loislo@chromium.org [Thu, 6 Sep 2012 14:25:47 +0000 (14:25 +0000)]
Web Inspector: NMI: switch to hierarchical identifiers of MemoryBlockTypes and use these identifiers in protocol.
https://bugs.webkit.org/show_bug.cgi?id=95957

Reviewed by Yury Semikhatsky.

Source/WebCore:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each type of memory will be counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

* dom/MemoryInstrumentation.cpp:
(WebCore):
* dom/MemoryInstrumentation.h:
(GenericMemoryTypes):
(WebCore::MemoryInstrumentation::addRootObject):
(WebCore::MemoryObjectInfo::reportObjectInfo):
(WebCoreMemoryTypes):
* inspector/InspectorMemoryAgent.cpp:
(MemoryBlockName):
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationImpl::countObjectSize):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.MemoryBlockViewProperties._initialize):
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):

Source/WebKit/chromium:

Now when we use string identifiers as MemoryObjectType we can use them as the identifiers for the protocol
instead of MemoryBlockNames hardcoded in InspectorMemoryAgent..
At a later stage, when each memory type is counted in MemoryInstrumentation
we will build the blocks hierarchy for the front-end automatically.

* tests/MemoryInstrumentationTest.cpp:
(WebCore::InstrumentedUndefined::InstrumentedUndefined):
(WebCore::InstrumentedUndefined::reportMemoryUsage):
(WebCore::InstrumentedDOM::InstrumentedDOM):
(WebCore::InstrumentedDOM::reportMemoryUsage):
(InstrumentedDOM):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 3 'overflow-wrap' property implementation
commit-queue@webkit.org [Thu, 6 Sep 2012 14:00:33 +0000 (14:00 +0000)]
CSS 3 'overflow-wrap' property implementation
https://bugs.webkit.org/show_bug.cgi?id=94475

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06
Reviewed by Ojan Vafai.

Source/WebCore:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
The specification declares that 'word-wrap' as a shorthand
for the 'overflow-wrap' property. So what was basically done
is declaring of new 'overflow-wrap' property and renaming
of the internal data structures from 'WordWrap' to 'OverflowWrap'.
Both 'overflow-wrap' and 'word-wrap' properties share the same
handlers and thus have the same behaviour.

Test: fast/text/overflow-wrap.html

* WebCore.order: Rename exported setWordWrap to setOverflowWrap.
* css/CSSComputedStyleDeclaration.cpp:  Add CSSPropertyOverflowWrap to computedProperties.
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp: Validation for the 'overflow-wrap' property.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EOverflowWrap):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): CSSPropertyOverflowWrap is inherited.
* css/CSSPropertyNames.in: Declare new 'overflow-wrap' property.
* css/StyleBuilder.cpp: Assign property handler (same as for 'word-wrap').
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Renaming.
* rendering/RenderTextControl.cpp: Ditto.
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControlSingleLine.cpp: Ditto.
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
* rendering/style/RenderStyle.cpp: Ditto.
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h: Ditto.
* rendering/style/RenderStyleConstants.h: Ditto.
* rendering/style/StyleRareInheritedData.cpp: Ditto.
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h: Ditto.
(StyleRareInheritedData):

LayoutTests:

Added 'overflow-wrap' property implementation according to
http://www.w3.org/TR/2012/WD-css3-text-20120814/#overflow-wrap.
New ref-test is added to check the simularity
in behaviour of 'overflow-wrap' and 'word-wrap' properties.

* fast/text/overflow-wrap-expected.html: Added.
* fast/text/overflow-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Always log shader compilation failure
anilsson@rim.com [Thu, 6 Sep 2012 13:41:21 +0000 (13:41 +0000)]
[BlackBerry] Always log shader compilation failure
https://bugs.webkit.org/show_bug.cgi?id=95948

Reviewed by George Staikos.

Also add shader source to the logs. In addition, don't bail on the
first failure, run through all shaders so we get a complete set of
logs.

No new tests: no change in functionality.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::loadShader):
(WebCore::LayerRenderer::initializeSharedGLObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
commit-queue@webkit.org [Thu, 6 Sep 2012 13:23:37 +0000 (13:23 +0000)]
[EFL][WK2] Update TestExpectations for fast/events/tab-focus-link-in-canvas.html
https://bugs.webkit.org/show_bug.cgi?id=95970

Unreviewed EFL gardening.

Update WK2-EFL TestExpectations to add bug number for:
fast/events/tab-focus-link-in-canvas.html

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
kbalazs@webkit.org [Thu, 6 Sep 2012 13:21:14 +0000 (13:21 +0000)]
[nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
https://bugs.webkit.org/show_bug.cgi?id=95710

Reviewed by Dirk Pranke.

The stdout / stderr output can be None so make sure
we won't raise an exception in this case.

* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
commit-queue@webkit.org [Thu, 6 Sep 2012 13:05:38 +0000 (13:05 +0000)]
[EFL][WK2] Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
https://bugs.webkit.org/show_bug.cgi?id=95943

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Provide implementation for WebPage::performDefaultBehaviorForKeyEvent()
in EFL WK2.

* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

LayoutTests:

Unskip several test cases that are passing now that EFL WK2
has a proper implementation for
WebPage::performDefaultBehaviorForKeyEvent().

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove String::operator+=() from windows platform code
paroga@webkit.org [Thu, 6 Sep 2012 12:54:43 +0000 (12:54 +0000)]
Remove String::operator+=() from windows platform code
https://bugs.webkit.org/show_bug.cgi?id=95904

Reviewed by Benjamin Poulain.

Use StringBuilder and operator+() to concatenate strings instead of operator+=().

Source/WebCore:

* platform/win/ClipboardWin.cpp:
(WebCore::filesystemPathFromUrlOrTitle):

Source/WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::get_accKeyboardShortcut):
* WebDownload.cpp:
(WebDownload::bundlePathForTargetPath):
* WebView.cpp:
(imeCompositionArgumentNames):

Source/WebKit2:

* UIProcess/win/WebView.cpp:
(WebKit::imeCompositionArgumentNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Add notifications path to the WebKit2/CMakeLists.txt
commit-queue@webkit.org [Thu, 6 Sep 2012 12:29:19 +0000 (12:29 +0000)]
[CMake] Add notifications path to the WebKit2/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=95843

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-09-06
Reviewed by Laszlo Gombos.

Add WebCore/Modules/Notifications to the WebKit2_INCLUDE_DIRECTORIES of WebKit2/CMakeLists.txt.
There are some build errors when ENABLE_NOTIFICATIONS feature is enabled.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRewrite zooming test to no longer output pixel numbers
mikelawther@chromium.org [Thu, 6 Sep 2012 12:21:00 +0000 (12:21 +0000)]
Rewrite zooming test to no longer output pixel numbers
https://bugs.webkit.org/show_bug.cgi?id=95922

Reviewed by Dan Bernstein.

The original version of this test output pixel sizes, which had different results on
different ports. The test has been rewritten to suppress the pixel size output.

* css3/calc/zoom-with-em-expected.txt:
* css3/calc/zoom-with-em.html:
* platform/chromium/css3/calc/zoom-with-em-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Sanitize URLs in EWebLauncher / Minibrowser
commit-queue@webkit.org [Thu, 6 Sep 2012 11:44:12 +0000 (11:44 +0000)]
[EFL] Sanitize URLs in EWebLauncher / Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=95849

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-06
Reviewed by Kenneth Rohde Christiansen.

Sanitize URLs passed by the user as program
argument or typed in the URL bar in order to
be more tolerant.

* EWebLauncher/CMakeLists.txt:
* EWebLauncher/main.c:
(main):
* EWebLauncher/url_bar.c:
(_url_bar_url_get_with_protocol):
(on_urlbar_key_down):
* EWebLauncher/url_utils.c: Added.
(has_scheme):
(url_from_user_input): Add utility function to construct a
URL from user input.
* EWebLauncher/url_utils.h: Added.
* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip one more failing test,
ossy@webkit.org [Thu, 6 Sep 2012 11:22:36 +0000 (11:22 +0000)]
[Qt] Unreviewed gardening, skip one more failing test,
because we like regressions in the trunk. :)

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor CalendarPicker to not use global variables.
keishi@webkit.org [Thu, 6 Sep 2012 11:05:27 +0000 (11:05 +0000)]
Refactor CalendarPicker to not use global variables.
https://bugs.webkit.org/show_bug.cgi?id=95830

Reviewed by Kent Tamura.

Source/WebCore:

Introduce CalendarPicker so we can have multiple Pickers in one page
popup in the future.

No new tests. No behavior change.

* Resources/pagepopups/calendarPicker.js:
(initialize):
(resetMain):
(openCalendarPicker):
(CalendarPicker):
(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.handleToday):
(CalendarPicker.prototype.handleClear):
(CalendarPicker.prototype.fixWindowSize):
(CalendarPicker.prototype._layoutButtons):
(YearMonthController):
(YearMonthController.prototype.attachTo):
(YearMonthController.prototype._redraw):
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable):
(DaysTable.prototype.attachTo):
(CalendarPicker.prototype.stepMismatch):
(CalendarPicker.prototype.outOfRange):
(CalendarPicker.prototype.isValidDate):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._navigateToMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):
(DaysTable.prototype._handleDayClick):
(DaysTable.prototype._handleKey):
(CalendarPicker.prototype._handleBodyKeyDown):
* Resources/pagepopups/colorSuggestionPicker.js:
(ColorPicker):
(ColorPicker.prototype._layout):
(ColorPicker.prototype._handleKeyDown):
(ColorPicker.prototype._handleSwatchClick):
* Resources/pagepopups/pickerCommon.js:
(Picker):
(Picker.prototype.submitValue):
(Picker.prototype.handleCancel):
(Picker.prototype.chooseOtherColor):

LayoutTests:

* fast/forms/date/calendar-picker-appearance-pre-100.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Various small Windows / MSVC build fixes
hausmann@webkit.org [Thu, 6 Sep 2012 11:02:11 +0000 (11:02 +0000)]
[Qt] Various small Windows / MSVC build fixes
https://bugs.webkit.org/show_bug.cgi?id=95934

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

* Shared/LayerTreeContext.h: Include stdint.h due to the use of uint32_t as layer id.
* UIProcess/API/qt/qquickwebview_p.h:
(WebKit): Fix struct vs. class forward declaration mismatch, causing linking errors.
* UIProcess/API/qt/tests/bytearraytestdata.h: Remove export macro from internal test class
that is not used anymore. Using the export macro from a DLL when the code in question is not
part of the DLL results in the export macro expanding to dllimport, giving incorrect linkage
for the unit test.
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt): Removed explicit call to srandom(), which is not available on Windows.
The call appears to be unnecessary in the light of the WTF::initializeThreading() call below, which
in turn calls WTF::initializeRandomNumberGenerator(), which does the same thing already (and isn't
needed on Windows, as per comment in wtf/RandomNumberSeed.h)

Source/WTF:

For the Qt build on Windows, do not enable WTF_USE_UNIX_DOMAIN_SOCKETS for
WebKit2 IPC.

* wtf/Platform.h:

Tools:

setFocus takes a boolean as argument: Don't try to implicitly convert
an enum to a boolean, MSVC doesn't like that. The intent here is to
enable focus, so just pass true.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::focus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSmall typo I forgot to land as part of r127724
hausmann@webkit.org [Thu, 6 Sep 2012 10:59:50 +0000 (10:59 +0000)]
Small typo I forgot to land as part of r127724

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
hausmann@webkit.org [Thu, 6 Sep 2012 10:55:43 +0000 (10:55 +0000)]
[Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
https://bugs.webkit.org/show_bug.cgi?id=95965

Reviewed by Tor Arne Vestbø.

.:

Add ANGLE as separate static library to the build and dependencies.

* Source/api.pri:
* WebKit.pro:

Source/ThirdParty/ANGLE:

Add build rules to build ANGLE as a static library for the Qt port.

* ANGLE.pri: Added.
* ANGLE.pro: Added.
* DerivedSources.pri: Added.
* Target.pri: Added.

Source/WebCore:

Moved all ANGLE build rules from here to Source/Thirty/ANGLE and
instead depend on the new library with a simple WEBKIT += ANGLE.

* DerivedSources.pri:
* Target.pri:
* platform/graphics/ANGLEWebKitBridge.h: Simplify the include statement
for the internal shader compiler API, aligned with the other platforms.

Source/WebKit:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

* WebKit1.pro:

Source/WebKit2:

Depend on ANGLE if necessary, due to the use WebCore types that pull in ANGLE
headers (GraphicsContext3D.h in particular).

* Target.pri:

Tools:

Add ANGLE as a static library module to the Qt WebKit build system.

* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/modules/angle.prf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Keep placeholder text visible until first input from user.
commit-queue@webkit.org [Thu, 6 Sep 2012 10:47:42 +0000 (10:47 +0000)]
[EFL] Keep placeholder text visible until first input from user.
https://bugs.webkit.org/show_bug.cgi?id=95851

Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-06
Reviewed by Gyuyoung Kim.

Current specification, http://dev.w3.org/html5/spec/single-page.html#attr-input-placeholder, has allowed user agent to keep placeholder text until first input.
Therefore, this patch enabled it.

* platform/efl/RenderThemeEfl.h:
(WebCore::RenderThemeEfl::shouldShowPlaceholderWhenFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r127620, r127698 and r127704
dominik.rottsches@intel.com [Thu, 6 Sep 2012 10:47:18 +0000 (10:47 +0000)]
[EFL] Gardening after r127620, r127698 and r127704
https://bugs.webkit.org/show_bug.cgi?id=95963

Unreviewed gardening.

Following tests were added to TestExpectations:
compositing/overflow/overflow-auto-with-touch-toggle.html fails after r127620.
fast/dom/HTMLScriptElement/script-reexecution.html fails after r127698.
fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html fails after r127704.
fast/viewport/viewport-limits-adjusted-for-no-user-scale.html fails after r127704.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-06

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Win build fix attempt after r127715
bashi@chromium.org [Thu, 6 Sep 2012 10:40:26 +0000 (10:40 +0000)]
[Chromium] Win build fix attempt after r127715

* tests/CCRenderPassTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Make [Qt]ViewportHandler cross platform
abecsi@webkit.org [Thu, 6 Sep 2012 10:36:37 +0000 (10:36 +0000)]
[WK2] Make [Qt]ViewportHandler cross platform
https://bugs.webkit.org/show_bug.cgi?id=91257

Source/WebKit2:

Reviewed by Kenneth Rohde Christiansen and Simon Hausmann.

Since QtViewportHandler includes behaviour that is not platform
specific together with hooks to the QtQuick API layer, a platform
independent implementation would allow other ports to use the
viewport controlling functionality provided.

This patch removes QtViewportHandler and introduces a platform
independent PageViewportController class that is responsible
for handling requests from the web process (eg. content size
changes, viewport attributes changes and scroll position requests).
Requests from the web process are acted on by a platform specific
client class which implements the PageViewportControllerClient
interface which provides hooks to the platform specific API layer.

The PageViewportController is also responsible to notify the web
process about changes in the viewport state (eg. viewport size,
visible rect, content scale and movement trajectory).
The client is responsible to delegate these UI changes to the
PageViewportController.

For now only PageViewportControllerClientQt implements the client
interface besides providing other QQuick specific functionality
(gestures, animations, etc).

* Target.pri:
* UIProcess/API/qt/qquickwebpage_p_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::~QQuickWebViewFlickablePrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::pageDidRequestScroll):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
* UIProcess/API/qt/qquickwebview_p.h:
(WebKit):
* UIProcess/API/qt/qquickwebview_p_p.h:
(WebKit):
(QQuickWebViewPrivate::pageViewportControllerClient):
(QQuickWebViewPrivate):
(QQuickWebViewFlickablePrivate):
* UIProcess/API/qt/qwebkittest.cpp:
(QWebKitTest::viewport):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::contentsScale):
* UIProcess/PageViewportController.cpp: Added.
(WebKit):
(WebKit::bound):
(WebKit::fuzzyCompare):
(WebKit::boundPosition):
(WebKit::ViewportUpdateDeferrer::ViewportUpdateDeferrer):
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::convertFromViewport):
(WebKit::PageViewportController::convertToViewport):
(WebKit::PageViewportController::innerBoundedContentsScale):
(WebKit::PageViewportController::outerBoundedContentsScale):
(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::setViewportSize):
(WebKit::PageViewportController::setVisibleContentsRect):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::suspendContent):
(WebKit::PageViewportController::resumeContent):
(WebKit::PageViewportController::positionRangeForContentAtScale):
* UIProcess/PageViewportController.h: Added.
(WebCore):
(WebKit):
(ViewportUpdateDeferrer):
(PageViewportController):
(WebKit::PageViewportController::~PageViewportController):
(WebKit::PageViewportController::hasSuspendedContent):
(WebKit::PageViewportController::hadUserInteraction):
(WebKit::PageViewportController::allowsUserScaling):
(WebKit::PageViewportController::contentsLayoutSize):
(WebKit::PageViewportController::devicePixelRatio):
(WebKit::PageViewportController::minimumContentsScale):
(WebKit::PageViewportController::maximumContentsScale):
(WebKit::PageViewportController::setHadUserInteraction):
* UIProcess/PageViewportControllerClient.h: Added.
(WebKit):
(PageViewportControllerClient):
(WebKit::PageViewportControllerClient::PageViewportControllerClient):
(WebKit::PageViewportControllerClient::~PageViewportControllerClient):
* UIProcess/qt/PageViewportControllerClientQt.cpp: Added.
(WebKit):
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::updateCurrentValue):
(WebKit::PageViewportControllerClientQt::~PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setContentRectVisiblePositionAtScale):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):
(WebKit::PageViewportControllerClientQt::setContentsPosition):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::didResumeContent):
(WebKit::PageViewportControllerClientQt::allowsUserScaling):
(WebKit::PageViewportControllerClientQt::devicePixelRatio):
(WebKit::PageViewportControllerClientQt::minimumContentsScale):
(WebKit::PageViewportControllerClientQt::maximumContentsScale):
(WebKit::PageViewportControllerClientQt::currentContentsScale):
(WebKit::PageViewportControllerClientQt::contentsLayoutSize):
(WebKit::PageViewportControllerClientQt::scrollAnimationActive):
(WebKit::PageViewportControllerClientQt::panGestureActive):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::panGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::panGestureEnded):
(WebKit::PageViewportControllerClientQt::panGestureCancelled):
(WebKit::PageViewportControllerClientQt::scaleAnimationActive):
(WebKit::PageViewportControllerClientQt::cancelScrollAnimation):
(WebKit::PageViewportControllerClientQt::interruptScaleAnimation):
(WebKit::PageViewportControllerClientQt::pinchGestureActive):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::visibleContentsRect):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):
(WebKit::PageViewportControllerClientQt::didChangeVisibleContents):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
(WebKit::PageViewportControllerClientQt::updateViewportController):
(WebKit::PageViewportControllerClientQt::scaleContent):
(WebKit::PageViewportControllerClientQt::viewportScaleForRect):
* UIProcess/qt/PageViewportControllerClientQt.h: Added.
(WebKit):
(PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::setController):
(ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleAnimation::ScaleAnimation):
(WebKit::PageViewportControllerClientQt::ScaleStackItem::ScaleStackItem):
(ScaleStackItem):
* UIProcess/qt/QtGestureRecognizer.cpp:
(WebKit::QtGestureRecognizer::viewportController):
* UIProcess/qt/QtGestureRecognizer.h:
(WebKit):
* UIProcess/qt/QtPanGestureRecognizer.cpp:
(WebKit::QtPanGestureRecognizer::update):
(WebKit::QtPanGestureRecognizer::finish):
(WebKit::QtPanGestureRecognizer::cancel):
* UIProcess/qt/QtPinchGestureRecognizer.cpp:
(WebKit::QtPinchGestureRecognizer::update):
(WebKit::QtPinchGestureRecognizer::finish):
(WebKit::QtPinchGestureRecognizer::cancel):
* UIProcess/qt/QtViewportHandler.cpp: Removed.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::setViewportController):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::handleInputEvent):
(WebKit::QtWebPageEventHandler::doneWithTouchEvent):
(WebKit::QtWebPageEventHandler::didFindZoomableArea):
* UIProcess/qt/QtWebPageEventHandler.h:
(WebKit):
(QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::viewportController):

Tools:

Reviewed by Kenneth Rohde Christiansen.

Remove initial scale from viewport info item since it is
set to -1 after applied thus it does not hold any valuable
information.

* MiniBrowser/qt/qml/ViewportInfoItem.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
commit-queue@webkit.org [Thu, 6 Sep 2012 10:13:14 +0000 (10:13 +0000)]
Renamed useYarrJIT() option to useRegExpJIT(). Also fixed regression in
which inadvertantly allows the ASM llint to use the baseline JIT when
useRegExpJIT() is true.
https://bugs.webkit.org/show_bug.cgi?id=95918.

Patch by Mark Lam <mark.lam@apple.com> on 2012-09-06
Reviewed by Geoffrey Garen.

* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::canUseJIT):
(JSC::JSGlobalData::canUseRegExpJIT):
(JSGlobalData):
* runtime/Options.cpp:
(JSC::Options::initialize):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd new V8DependentRetained that allows keeping a v8::Object alive as long as another...
commit-queue@webkit.org [Thu, 6 Sep 2012 10:05:48 +0000 (10:05 +0000)]
Add new V8DependentRetained that allows keeping a v8::Object alive as long as another v8::Object is alive
https://bugs.webkit.org/show_bug.cgi?id=95519

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-09-06
Reviewed by Adam Barth.

Add new V8DependentRetained that allows keeping a v8::Object alive as long as another
v8::Object is alive. This is useful for keeping callbacks attached to wrappers without
keeping strong references to v8::Objects in the C++ side which can result in leaks
when cycles are created.

No new tests needed, this will be used to fix MutationObservers which will have tests.

* WebCore.gypi:
* bindings/v8/V8DependentRetained.h: Added.
(WebCore):
(V8DependentRetained):
(WebCore::V8DependentRetained::V8DependentRetained):
(WebCore::V8DependentRetained::~V8DependentRetained):
(WebCore::V8DependentRetained::get): Gets the v8::Object value.
(WebCore::V8DependentRetained::isEmpty): Checks if the value is still alive.
(WebCore::V8DependentRetained::createPropertyName):
(WebCore::V8DependentRetained::ownerWeakCallback): Clear the value when the owner is released.
(WebCore::V8DependentRetained::valueWeakCallback):
(WebCore::V8DependentRetained::release):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::hiddenReferenceName): Modified to allow creating hidden String or Symbol names.
* bindings/v8/V8HiddenPropertyName.h:
(V8HiddenPropertyName):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::V8PerIsolateData):
* bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::nextDependentRetainedId): Returns the next available hidden property index.
(V8PerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 6 Sep 2012 09:54:50 +0000 (09:54 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Removing String operator += uses in Cookie Files
commit-queue@webkit.org [Thu, 6 Sep 2012 09:52:27 +0000 (09:52 +0000)]
[BlackBerry] Removing String operator += uses in Cookie Files
https://bugs.webkit.org/show_bug.cgi?id=95884

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-06
Reviewed by Rob Buis.

Replacing all usages of String operator +=  in the Cookie code because it is being deprecated.
String concats are now done using + or StringBuilder.

PR 203054

Tested using Browser Test Cookie suite on browsertest01.rim.net/networking/cookies.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:
(WebCore::CookieDatabaseBackingStore::upgradeTableIfNeeded):
(WebCore::CookieDatabaseBackingStore::invokeOpen):
(WebCore::CookieDatabaseBackingStore::invokeRemoveAll):
* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a copy() method to CCRenderPass
danakj@chromium.org [Thu, 6 Sep 2012 09:48:42 +0000 (09:48 +0000)]
[chromium] Add a copy() method to CCRenderPass
https://bugs.webkit.org/show_bug.cgi?id=95485

Reviewed by Adrienne Walker.

Source/WebCore:

This method allows the ubercomp layer to make a clone of its delegated
RenderPasses to insert into the current frame.

Tests: CCRenderPassTest.copyShouldBeIdenticalExceptIdAndQuads

* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::copy):
(WebCore):
* platform/graphics/chromium/cc/CCRenderPass.h:
(CCRenderPass):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCRenderPassTest.cpp: Added.
(CCTestRenderPass):
(CCTestRenderPass::quadList):
(CCTestRenderPass::sharedQuadStateList):
(CCRenderPassSize):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Chromium Mac build fix after revision r127711
peter@chromium.org [Thu, 6 Sep 2012 09:46:42 +0000 (09:46 +0000)]
[Chromium] Chromium Mac build fix after revision r127711
https://bugs.webkit.org/show_bug.cgi?id=95958

Unreviewed build fix.

This is a clear typo in the source file, so changing the function to
call locationModifiersFromWindowsKeyCode instead.

* src/mac/WebInputEventFactory.mm:
(WebKit::WebInputEventFactory::keyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] WebMemorySampler.cpp is included twice.
ryuan.choi@samsung.com [Thu, 6 Sep 2012 09:42:09 +0000 (09:42 +0000)]
[EFL][WK2] WebMemorySampler.cpp is included twice.
https://bugs.webkit.org/show_bug.cgi?id=95910

Reviewed by Kentaro Hara.

Now WebMemorySampler.cpp is in CMakeLists.txt and PlatformEfl.cmake.

* PlatformEfl.cmake: Removed WebMemorySampler.cpp from source lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoXMLHttpRequest.open does not need custom bindings
commit-queue@webkit.org [Thu, 6 Sep 2012 09:38:25 +0000 (09:38 +0000)]
XMLHttpRequest.open does not need custom bindings
https://bugs.webkit.org/show_bug.cgi?id=95903

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

There doesn't appear to be any reason that XMLHttpRequest.open needs
custom bindings now that [Optional] works the way XMLHttpRequest
expects.

* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
(WebCore):
(WebCore::XMLHttpRequest::internalOpen):
* xml/XMLHttpRequest.h:
(XMLHttpRequest):
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
commit-queue@webkit.org [Thu, 6 Sep 2012 09:19:18 +0000 (09:19 +0000)]
Added modifiers to distinguish between left/right Shift/Ctrl/Alt in WebInputEvents
https://bugs.webkit.org/show_bug.cgi?id=94142

Patch by Raymes Khoury <raymes@chromium.org> on 2012-09-06
Reviewed by Tony Chang.

Previously we distinguished between left/right Shift/Ctrl/Alt in
WebInputEvents by using the location-specific virtual keycodes (e.g.
VK_LSHIFT instead of VK_SHIFT. However, the Windows API for key events
always returns the non-locational version (e.g. VK_SHIFT).
Furthermore, KeyboardEvent also returns
non-locational keycodes and separates the location information which
matches the behavior described in the DOM3
spec http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents. We
should be consistent with this in our representation of key events.
This patch changes WebInputEvents so they always store the
non-locational keycode and location information is stored in
modifiers. Since this only changes internal representation, no new
tests are added.

This patch also ensures that when KeyboardEvents are converted back to
WebInputEvents location information is preserved (which was not
happening before). This is important so that key location information
is passed on to plugins. A unittest is added for this.

* WebKit.gypi:
* public/WebInputEvent.h:
(WebKeyboardEvent):
* src/WebInputEvent.cpp:
(WebKit):
(WebKit::WebKeyboardEvent::windowsKeyCodeWithoutLocation):
(WebKit::WebKeyboardEvent::locationModifiersFromWindowsKeyCode):
* src/WebInputEventConversion.cpp:
(WebKit::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebKit::WebKeyboardEventBuilder::WebKeyboardEventBuilder):
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
* src/gtk/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
* src/mac/WebInputEventFactory.mm:
(WebKit::WebInputEventFactory::keyboardEvent):
* src/win/WebInputEventFactory.cpp:
(WebKit::getLocationModifier):
(WebKit::WebInputEventFactory::keyboardEvent):
* tests/WebInputEventConversionTest.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThree XSLTProcessor functions don't need to be [Custom]
commit-queue@webkit.org [Thu, 6 Sep 2012 09:17:10 +0000 (09:17 +0000)]
Three XSLTProcessor functions don't need to be [Custom]
https://bugs.webkit.org/show_bug.cgi?id=95899

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Source/WebCore:

These functions are marked [Custom] because they predate our
improvements to [Optional]. Now that we have
[Optional=DefaultIsUndefined], we can autogenerate these functions.

There is a (slight!) difference in behavior. Now, in the case of a type
error, we return null instead of undefined. This change is unlikely to
cause compatibility problems because the vast majority of folks will
pass the correct arguments, and, in the few cases where folks pass the
wrong argument types, null and undefined will likely work similarly
(e.g., they're both falsy and throw when you try to access properties).

* bindings/js/JSXSLTProcessorCustom.cpp:
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::transformToDocument):
(WebCore::XSLTProcessor::transformToFragment):
* xml/XSLTProcessor.h:
(WebCore::XSLTProcessor::importStylesheet):
* xml/XSLTProcessor.idl:

LayoutTests:

Update results to show that we return null rather than undefined on a
type error.

* fast/xsl/transform-xhr-doc-expected.txt:
* fast/xsl/xslt-processor-expected.txt:
* platform/chromium/fast/xsl/transform-xhr-doc-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip the failing tests.
kkristof@inf.u-szeged.hu [Thu, 6 Sep 2012 09:02:09 +0000 (09:02 +0000)]
[Qt] Unreviewed gardening. Skip the failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove String::operator+=() from plugin code
paroga@webkit.org [Thu, 6 Sep 2012 08:56:16 +0000 (08:56 +0000)]
Remove String::operator+=() from plugin code
https://bugs.webkit.org/show_bug.cgi?id=95896

Reviewed by Adam Barth.

Use operator+() to concatenate strings instead of operator+=().

* plugins/PluginView.cpp:
(WebCore::parseRFC822HeaderFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Interpreter after r127698.
paroga@webkit.org [Thu, 6 Sep 2012 08:33:45 +0000 (08:33 +0000)]
Build fix for Interpreter after r127698.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMore fixes for String::operator+=() in Debug mode
abarth@webkit.org [Thu, 6 Sep 2012 07:47:08 +0000 (07:47 +0000)]
More fixes for String::operator+=() in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=95888

Patch by Patrick Gansterer <paroga@webkit.org> on 2012-09-06
Reviewed by Adam Barth.

Use StringBuilder to concatenate strings instead of operator+=().

* dom/Element.cpp:
(WebCore::Element::formatForDebugger):
* dom/Node.cpp:
(WebCore::appendAttributeDesc):
(WebCore::Node::showNode):
(WebCore::traverseTreeAndMark):
(WebCore::Node::formatForDebugger):
* dom/Position.cpp:
(WebCore::Position::formatForDebugger):
* dom/Range.cpp:
(WebCore):
(WebCore::Range::formatForDebugger):
* dom/Text.cpp:
(WebCore::Text::formatForDebugger):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::formatForDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
vsevik@chromium.org [Thu, 6 Sep 2012 07:40:56 +0000 (07:40 +0000)]
Web Inspector: Fix inconsistencies in NetworkUISourceCodeProvider implementation.
https://bugs.webkit.org/show_bug.cgi?id=95752

Reviewed by Alexander Pavlov.

Source/WebCore:

NetworkUISourceCodeProvider does not receive ResourceAdded event until resource is finished anymore.
StylesSourceMapping now listens for workspace event instead of being called directly by NetworkUISourceCodeProvider.
StylesSourceMapping is now created from inspector.js.
ProjectDidReset event introduced instead of setTimeout hacks in mappings.

* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectWillReset):
(WebInspector.NetworkUISourceCodeProvider.prototype._projectDidReset):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._projectWillReset):
(WebInspector.ScriptSnippetModel.prototype._projectDidReset):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._addUISourceCode):
(WebInspector.StylesSourceMapping.prototype._reset):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._mainFrameNavigated):
(WebInspector.Project.prototype.reset):
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/network/network-request-revision-content-expected.txt:
* http/tests/inspector/network/network-request-revision-content.html:
* inspector/console/console-uncaught-exception-expected.txt:
* inspector/debugger/network-uisourcecode-provider-expected.txt:
* inspector/debugger/network-uisourcecode-provider.html:
* inspector/debugger/script-snippet-model.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until...
abarth@webkit.org [Thu, 6 Sep 2012 07:35:43 +0000 (07:35 +0000)]
Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.
https://bugs.webkit.org/show_bug.cgi?id=91110

Reviewed by Tony Chang.

Source/WebKit/chromium:

Prior to this patch, we were ignoring the user-scalable property of
viewport meta tags. This patch enforces the user-scalable property by
claming the minimum-scale and maximum-scale values, effectively
preventing user scaling. This approach isn't perfect, as discussed in
https://bugs.webkit.org/show_bug.cgi?id=70609, but it is an improvement
over the status quo.

This approach is also used by EFL, GTK, and Qt.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

LayoutTests:

Test that the scale limits are clamped when user-scalable is set to no.

* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control-expected.txt: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale-expected.txt: Added.
* fast/viewport/viewport-limits-adjusted-for-no-user-scale.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r127700.
vsevik@chromium.org [Thu, 6 Sep 2012 07:28:59 +0000 (07:28 +0000)]
Unreviewed, rolling out r127700.
http://trac.webkit.org/changeset/127700
https://bugs.webkit.org/show_bug.cgi?id=95941

Breaks inspector closure compilation, uses not defined
variables. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-06

Source/WebCore:

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::didRemoveNamedFlow):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::getFlowByName):
(WebCore):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::didRemoveNamedFlowImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::didRemoveNamedFlow):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved.callback):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.NamedFlow):
(WebInspector.NamedFlow.parsePayloadArray):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove WTF::String::operator+=
abarth@webkit.org [Thu, 6 Sep 2012 07:21:03 +0000 (07:21 +0000)]
Remove WTF::String::operator+=
https://bugs.webkit.org/show_bug.cgi?id=95797

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Sam Weinig.

This patch encloses WTF::String::operator+= in an ifdef so that we can
gradually remove it from the various port-specific files. The ifdef
lets us whitelist use of operator+= in individual files during the
transition.

* wtf/Platform.h
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] V8HTMLDocument has two out-of-style function names
commit-queue@webkit.org [Thu, 6 Sep 2012 07:16:52 +0000 (07:16 +0000)]
[V8] V8HTMLDocument has two out-of-style function names
https://bugs.webkit.org/show_bug.cgi?id=95893

Patch by Adam Barth <abarth@chromium.org> on 2012-09-06
Reviewed by Kentaro Hara.

Just a simple style cleanup.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getter):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::instantiateV8Object):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::getNamedProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Protocol Extension: Add "regionLayoutUpdate" event
commit-queue@webkit.org [Thu, 6 Sep 2012 06:48:50 +0000 (06:48 +0000)]
Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event
https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-05
Reviewed by Alexander Pavlov.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::reset):
(WebCore):
(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::scheduleFor):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::regionLayoutUpdated):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
* inspector/InspectorCSSAgent.h:
(WebCore):
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
danakj@chromium.org [Thu, 6 Sep 2012 06:26:51 +0000 (06:26 +0000)]
[chromium] Add a copy() method to CCDrawQuad and CCSharedQuadState
https://bugs.webkit.org/show_bug.cgi?id=95374

Reviewed by Adrienne Walker.

Source/WebCore:

The ubercomp layer will hold a RenderPass full of DrawQuads, and needs
to add quads to the current frame in appendQuads(). It will do this by
copying the quads it has in its RenderPass into the frame's RenderPass.

These methods allows it to make a clone of its quads.

Test: CCDrawQuadTest.copySharedQuadState
      CCDrawQuadTest.copyCheckerboardDrawQuad
      CCDrawQuadTest.copyDebugBorderDrawQuad
      CCDrawQuadTest.copyIOSurfaceDrawQuad
      CCDrawQuadTest.copyRenderPassDrawQuad
      CCDrawQuadTest.copySolidColorDrawQuad
      CCDrawQuadTest.copyStreamVideoDrawQuad
      CCDrawQuadTest.copyTextureDrawQuad
      CCDrawQuadTest.copyTileDrawQuadcopy
      CCDrawQuadTest.copyYUVVideoDrawQuad

* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::copy):
(WebCore):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(CCDrawQuad):
* platform/graphics/chromium/cc/CCSharedQuadState.cpp:
(WebCore::CCSharedQuadState::copy):
(WebCore):
* platform/graphics/chromium/cc/CCSharedQuadState.h:
(CCSharedQuadState):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCDrawQuadTest.cpp: Added.
(TEST):
(createSharedQuadState):
(compareDrawQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNamed functions should not allocate scope objects for their names
ggaren@apple.com [Thu, 6 Sep 2012 06:17:59 +0000 (06:17 +0000)]
Named functions should not allocate scope objects for their names
https://bugs.webkit.org/show_bug.cgi?id=95659

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

In most cases, we can merge a function expression's name into its symbol
table. This reduces memory footprint per closure from three objects
(function + activation + name scope) to two (function + activation),
speeds up closure allocation, and speeds up recursive calls.

In the case of a named function expression that contains a non-strict
eval, the rules are so bat-poop crazy that I don't know how to model
them without an extra object. Since functions now default to not having
such an object, this case needs to allocate the object on function
entry.

Therefore, this patch makes the slow case a bit slower so the fast case
can be faster and more memory-efficient. (Note that the slow case already
allocates an activation on entry, and until recently also allocated a
scope chain node on entry, so adding one allocation on entry shouldn't
break the bank.)

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Caught a missed initializer. No behavior change.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): Put the callee in static scope
during compilation so it doesn't need to be in dynamic scope at runtime.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee): Helper functions for either statically
resolving the callee or adding a dynamic scope that will resolve to it,
depending on whether you're in the fast path.

We move the callee into a var location if it's captured because activations
prefer to have contiguous ranges of captured variables.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::registerFor):
(BytecodeGenerator):

* dfg/DFGOperations.cpp:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL): This is the point of the patch: remove
one allocation in the case of a named function expression.

* parser/Parser.cpp:
(JSC::::Parser):
* parser/Parser.h:
(JSC::Scope::declareCallee):
(Scope):
(Parser):
(JSC::parse):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode): Pipe the callee's name through
the parser so we get accurate information on whether the callee was captured.

(JSC::FunctionExecutable::FunctionExecutable):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::checkSyntax):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::fromGlobalCode):
* runtime/Executable.h:
(JSC::FunctionExecutable::create):
(FunctionExecutable):
(JSC::FunctionExecutable::finishCreation): I had to refactor function
creation to support the following function constructor quirk: the function
gets a name, but its name is not in lexical scope.

To simplify this, FunctionExecutable now automatically extracts all the
data it needs from the parsed node. The special "fromGlobalCode" path
used by the function constructor creates an anonymous function, and then
quirkily sets the value used by the .name property to be non-null, even
though the parsed name is null.

* runtime/JSNameScope.h:
(JSC::JSNameScope::create):
(JSC::JSNameScope::JSNameScope): Added support for explicitly specifying
your container scope. The compiler uses this for named function expressions.

LayoutTests:

Added coverage for some extra-tricky cases.

* fast/js/named-function-expression-expected.txt:
* fast/js/script-tests/named-function-expression.js:
(shouldBeTrueWithDescription): I rolled my own shouldBeTrue() here to avoid the
built-in shouldBe()'s eval scoping, which can change the variable
resolution rules I'm trying to test.

* inspector/debugger/debugger-expand-scope-expected.txt: Not sure why this
result used to miss the function name scope, but the new result is a
progression, so I've updated the expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new fasiling tests.
ossy@webkit.org [Thu, 6 Sep 2012 06:06:13 +0000 (06:06 +0000)]
[Qt] Unreviewed gardening, skip new fasiling tests.

* platform/qt-5.0-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed; revert a change to ScrollingTreeNodeMac which accidentally
timothy_horton@apple.com [Thu, 6 Sep 2012 05:57:14 +0000 (05:57 +0000)]
Unreviewed; revert a change to ScrollingTreeNodeMac which accidentally
slipped into http://trac.webkit.org/changeset/127474.

This change will be properly landed shortly as part of
https://bugs.webkit.org/show_bug.cgi?id=93898.

* page/scrolling/mac/ScrollingTreeNodeMac.mm:
(WebCore::ScrollingTreeNodeMac::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove duplicate error() impls in CachedResource subclasses
japhet@chromium.org [Thu, 6 Sep 2012 05:51:46 +0000 (05:51 +0000)]
Remove duplicate error() impls in CachedResource subclasses
https://bugs.webkit.org/show_bug.cgi?id=81161

Reviewed by Antti Koivisto.

No new tests, refactor only.

* loader/cache/CachedCSSStyleSheet.cpp:
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedResource.h: Make checkNotify()
     virtual, so the right checkNotify() gets called in error().
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:
* loader/cache/CachedXSLStyleSheet.cpp:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] platform/qt/plugins/qt-qwidget-plugin.html fails
commit-queue@webkit.org [Thu, 6 Sep 2012 05:37:13 +0000 (05:37 +0000)]
[Qt] platform/qt/plugins/qt-qwidget-plugin.html fails
https://bugs.webkit.org/show_bug.cgi?id=92141

Patch by Lauro Neto <lauro.neto@openbossa.org> on 2012-09-05
Reviewed by Simon Hausmann.

Only Qt WK2 does not support Qt plugins. Moving skip to proper place.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:

Updated test to point to a existing image.

* platform/qt/plugins/qt-qwidget-plugin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium windows build fix.
jamesr@google.com [Thu, 6 Sep 2012 05:28:45 +0000 (05:28 +0000)]
Unreviewed chromium windows build fix.

Some of the rules in webcore_remaining only apply to files under WebCore/platform/. Since r127687 moved all such
files from the webcore_files variable to webcore_platform_files, these rules have to be applied to
webcore_platform instead. This also means that these files link into webcore_platform instead of
webcore_remaining, which makes a lot more sense, and we can delete several redundant rules.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening
bashi@chromium.org [Thu, 6 Sep 2012 05:10:15 +0000 (05:10 +0000)]
[Chromium] Unreviewed gardening

* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::TEST_F): Disabled applyScrollToScrollableArea()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127692 268f45cc-cd09-0410-ab3c-d52691b4dbfc