WebKit-https.git
11 years ago2009-01-12 Eric Roman <eroman@chromium.org>
dglazkov@chromium.org [Mon, 12 Jan 2009 21:07:19 +0000 (21:07 +0000)]
2009-01-12  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.

        Fix some bugs with Selection::appendTrailingWhitespace().
        https://bugs.webkit.org/show_bug.cgi?id=23232

        Test: editing/selection/doubleclick-whitespace-crash.html

        * editing/Selection.cpp:
        (WebCore::makeSearchRange):
        (WebCore::Selection::appendTrailingWhitespace):

2009-01-12  Eric Roman  <eroman@chromium.org>

        Reviewed by Darin Adler.
        https://bugs.webkit.org/show_bug.cgi?id=23232

        * editing/selection/doubleclick-whitespace-crash-expected.txt: Added.
        * editing/selection/doubleclick-whitespace-crash.html: Added.
        * editing/selection/doubleclick-whitespace-expected.txt:
        * editing/selection/doubleclick-whitespace.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Mon, 12 Jan 2009 20:26:27 +0000 (20:26 +0000)]
2009-01-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add the first pieces of platform/graphics/chromium
        https://bugs.webkit.org/show_bug.cgi?id=23257

        * platform/graphics/chromium/ColorChromium.cpp: Added.
        (WebCore::focusRingColor):
        * platform/graphics/chromium/FontCacheChromiumWin.cpp: Added.
        (WebCore::FontCache::platformInit):
        (WebCore::isStringASCII):
        (WebCore::LookupAltName):
        (WebCore::FontCodepage::):
        (WebCore::FontCodepage::if):
        (WebCore::createFontIndirectAndGetWinName):
        (WebCore::fontContainsCharacter):
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::alternateFamilyName):
        (WebCore::FontCache::getSimilarFontPlatformData):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::toGDIFontWeight):
        (WebCore::FontCache::getGenericFontForScript):
        (WebCore::FillLogFont):
        (WebCore::FontCache::fontExists):
        (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData):
        (WebCore::traitsInFamilyEnumProc):
        (WebCore::FontCache::getTraitsInFamily):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontCacheLinux.cpp: Added.
        (WebCore::FontCache::platformInit):
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::alternateFamilyName):
        (WebCore::FontCache::getSimilarFontPlatformData):
        (WebCore::FontCache::getLastResortFallbackFont):
        (WebCore::FontCache::getTraitsInFamily):
        (WebCore::FontCache::createFontPlatformData):
        (WebCore::FontCache::getGenericFontForScript):
        * platform/graphics/chromium/FontChromiumWin.cpp: Added.
        (WebCore::windowsCanHandleTextDrawing):
        (WebCore::skiaDrawText):
        (WebCore::PaintSkiaText):
        (WebCore::Font::drawGlyphs):
        (WebCore::Font::selectionRectForComplexText):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 12 Jan 2009 19:25:09 +0000 (19:25 +0000)]
2009-01-12  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23254
        Upstream page/chromium/

        * page/chromium/AXObjectCacheChromium.cpp: Added.
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postNotification):
        (WebCore::AXObjectCache::postNotificationToElement):
        (WebCore::AXObjectCache::handleFocusedUIElementChanged):
        * page/chromium/AccessibilityObjectChromium.cpp:
        * page/chromium/AccessibilityObjectWrapper.h:
        * page/chromium/ChromeClientChromium.h: Added.
        * page/chromium/DragControllerChromium.cpp: Added.
        (WebCore::DragController::dragOperation):
        (WebCore::DragController::isCopyKeyDown):
        (WebCore::DragController::maxDragImageSize):
        (WebCore::DragController::cleanupAfterSystemDrag):
        * page/chromium/EventHandlerChromium.cpp: Added.
        (WebCore::EventHandler::passMousePressEventToSubframe):
        (WebCore::EventHandler::passMouseMoveEventToSubframe):
        (WebCore::EventHandler::passMouseReleaseEventToSubframe):
        (WebCore::EventHandler::passWheelEventToWidget):
        (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
        (WebCore::EventHandler::passMouseDownEventToWidget):
        (WebCore::EventHandler::tabsToAllControls):
        (WebCore::EventHandler::eventActivatedView):
        (WebCore::EventHandler::createDraggingClipboard):
        (WebCore::EventHandler::focusDocumentView):
        (WebCore::EventHandler::accessKeyModifiers):
        * page/chromium/FrameChromium.cpp: Added.
        (WebCore::computePageRectsForFrame):
        (WebCore::Frame::dragImageForSelection):
        * page/chromium/FrameChromium.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-01-12 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 12 Jan 2009 19:10:03 +0000 (19:10 +0000)]
2008-01-12  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22936
        Fix uninitialized memory read error, reported by Purify.

        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::SimpleFontData): Added initializer for
            m_unitsPerEm using cDefaultUnitsPerEm constant.
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::unitsPerEm): Replaced literal value with
            the constant.
        * svg/SVGFontFaceElement.h: Added cDefaultUnitsPerEm constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDo not set fixedLayoutSize for anything other than the mainframe during
treat@webkit.org [Mon, 12 Jan 2009 15:50:42 +0000 (15:50 +0000)]
Do not set fixedLayoutSize for anything other than the mainframe during
the transition as this is a page level state like the viewportSize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 13:03:15 +0000 (13:03 +0000)]
2009-01-12  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        [Qt] Ensure that we're always notified of navigation actions for local anchors

        FrameLoader::checkNavigationPolicy() does not notify us if the request has
        been checked before (which happens for local anchors), but in the case of
        our clients not accepting the navigation request we do want to be notified
        again later on, so we clear the lastCheckedRequest flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 12:51:55 +0000 (12:51 +0000)]
2009-01-12  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        Build fix: use qobject_cast which does not rely on RTTI. This fixes the
        unit test when building it with a version of Qt (e.g. Qt/Embedded)
        configured without RTTI.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update test results.
ap@webkit.org [Mon, 12 Jan 2009 11:10:02 +0000 (11:10 +0000)]
    Update test results.

        * fast/dom/Window/window-properties-expected.txt: Remove appcache dynamic entries methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
jchaffraix@webkit.org [Mon, 12 Jan 2009 10:46:22 +0000 (10:46 +0000)]
WebCore:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        - Added fontCache() to get the global FontCache.

        - Made all the methods in FontCache instance method.

        - Changed FontCache:: to fontCache()-> in WebCore.

        * WebCore.base.exp: Now export fontCache().
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::CSSFontSelector):
        (WebCore::CSSFontSelector::~CSSFontSelector):
        (WebCore::CSSFontSelector::addFontFaceRule):
        (WebCore::fontDataForGenericFamily):
        * platform/graphics/Font.cpp:
        (WebCore::Font::glyphDataForCharacter):
        * platform/graphics/FontCache.cpp:
        (WebCore::fontCache):
        (WebCore::FontCache::FontCache):
        * platform/graphics/FontCache.h:
        * platform/graphics/FontFallbackList.cpp:
        (WebCore::FontFallbackList::FontFallbackList):
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::releaseFontData):
        (WebCore::FontFallbackList::fontDataAt):
        (WebCore::FontFallbackList::fontDataForCharacters):
        (WebCore::FontFallbackList::setPlatformFont):
        * platform/graphics/SimpleFontData.cpp:
        (WebCore::SimpleFontData::~SimpleFontData):
        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::fontCacheATSNotificationCallback):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::smallCapsFontData):
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::getCJKCodePageMasks):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::containsCharacters):

WebKit/mac:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics cachedFontDataCount]):
        (+[WebCoreStatistics cachedFontDataInactiveCount]):
        (+[WebCoreStatistics purgeInactiveFontData]):
        Redirected all the static calls to the global FontCache
        instance.

WebKit/win:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        * WebCoreStatistics.cpp:
        (WebCoreStatistics::cachedFontDataCount):
        (WebCoreStatistics::cachedFontDataInactiveCount):
        (WebCoreStatistics::purgeInactiveFontData):
        Redirected all the static calls to the global FontCache
        instance.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Mon, 12 Jan 2009 09:41:03 +0000 (09:41 +0000)]
2009-01-12  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        When the QWebView is disabled context menus implemented in JavaScript should not pop up.

        Just like in QWidget::event() we have to check for the disabled state and
        ignore context menu events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-12 Simon Hausmann <simon.hausmann@nokia.com
hausmann@webkit.org [Mon, 12 Jan 2009 09:36:53 +0000 (09:36 +0000)]
2009-01-12  Simon Hausmann  <simon.hausmann@nokia.com

        Reviewed by Tor Arne Vestbø.

        Fix QWebView appearance when showed uninitialized without page.

        Only set WA_OpaquePaintEvent if we have a page set that will actually
        paint the entire contents, otherwise the optimization does not apply
        as we do not have a paintEvent() implementation and Qt has to fill the
        view with its default background instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
vestbo@webkit.org [Mon, 12 Jan 2009 09:12:50 +0000 (09:12 +0000)]
2009-01-11  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Rubber-stamped by Tor Arne Vestbø.

        Do not create a QVariant from QObject* directly, use the
        template-specialized function.

        * tests/qwebframe/tst_qwebframe.cpp:
        (MyQObject::myOverloadedSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 12 Jan 2009 07:48:35 +0000 (07:48 +0000)]
WebCore:

2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
        https://bugs.webkit.org/show_bug.cgi?id=23247

        Also fix problems where partially parsed paths will still have an effect
        rather than failing parsing and being ignored.

        Test: dom/path-segments.html

        * platform/graphics/Path.h:
        (WebCore::Path::swap): Added.

        * svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG): Removed unneeded special case for empty string.
        (WebCore::PathBuilder::build): Changed to not modify the path if parsing fails.
        (WebCore::SVGPathSegListBuilder::build): Changed to not modify the segment list if
        parsing fails.
        (WebCore::SVGPathSegListBuilder::svgMoveTo): Put the path element into the vector,
        not directly into the segment list.
        (WebCore::SVGPathSegListBuilder::svgLineTo): Ditto.
        (WebCore::SVGPathSegListBuilder::svgLineToHorizontal): Ditto.
        (WebCore::SVGPathSegListBuilder::svgLineToVertical): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToCubic): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToCubicSmooth): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadratic): Ditto.
        (WebCore::SVGPathSegListBuilder::svgCurveToQuadraticSmooth): Ditto.
        (WebCore::SVGPathSegListBuilder::svgArcTo): Ditto.
        (WebCore::SVGPathSegListBuilder::svgClosePath): Ditto.

        * svg/SVGPathSegCurvetoCubicSmooth.h:
        (WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
        Set y2 to y2, not to y.

WebKitTools:

2009-01-11  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
        directory that aren't using standard wrappers.

LayoutTests:

2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23247: createSVGPathSegCurvetoCubicSmoothAbs doesn't set y2 correctly
        https://bugs.webkit.org/show_bug.cgi?id=23247

        Also fix problems where partially parsed paths will still have an effect
        rather than failing parsing and being ignored.

        Renamed the path-parser.html test to fuzz-path-parser.html, since it's a fuzz test,
        to make room for a non-fuzz test of the path parser.

        * platform/mac/svg/custom/path-bad-data-expected.txt: Updated results, since the old
        ones were based on incorrect path parsing behavior.

        * svg/dom/fuzz-path-parser-expected.txt: Copied from svg/dom/path-parser-expected.txt.
        Also updated because the parser no longer tolerates extra characters at the end of the
        string, which it was doing by accident.
        * svg/dom/fuzz-path-parser.html: Copied from svg/dom/path-parser.html.

        * svg/dom/path-parser-expected.txt: Replaced fuzz test results with new test results.
        * svg/dom/path-parser.html: Replaced fuzz test with a new test.
        * svg/dom/path-segments-expected.txt: Added.
        * svg/dom/path-segments.html: Added.

        * svg/dom/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.

        * svg/dom/resources/path-parser.js: Added. Mostly, this test shows that we are
        processing the path while parsing it, which is a bug. This test would be much more
        useful if that was fixed. But it also shows that we were incorrectly tolerating
        extra characters after the path, which is now fixed.

        * svg/dom/resources/path-segments.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 07:44:27 +0000 (07:44 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Fourth step: Remove arguments entirely in the many cases where they are not
        needed at all. This step is a little less mechanical than the earlier ones.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::isXMLMIMEType): Pass TextCaseSensitive when creating
        the regular expression, since we already specify a-zA-Z in our expression.

        * dom/Document.cpp:
        (WebCore::Document::databaseThread): Don't pass in the document when creating
        a DatabaseThread.

        * dom/Element.cpp:
        (WebCore::Element::createRareData): Don't pass the element when creating an
        ElementRareData.
        (WebCore::Element::detach): Don't pass the element when calling resetComputedStyle.
        (WebCore::Element::recalcStyle): Ditto.

        * dom/ElementRareData.h: Remove the unused Element* from the constructor and
        the resetComputedStyle function.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchEvent): Don't pass ec to dispatchGenericEvent.
        (WebCore::EventTargetNode::dispatchGenericEvent): Remove the unused ec argument.
        (WebCore::EventTargetNode::dispatchWindowEvent): Don't pass ec to dispatchGenericEvent.
        * dom/EventTargetNode.h: Remove the ExceptionCode& argument form disaptchGenericEvent.

        * editing/ApplyStyleCommand.cpp: Remove the empty removeBlockStyle function.
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Remove the unused
        start and end arguments.
        (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Don't pass start
        and end to pushDownTextDecorationStyleAroundNode.

        * editing/ApplyStyleCommand.h: Remove the empty removeBlockStyle function. Removed the
        unused start and end arguments from pushDownTextDecorationStyleAroundNode.

        * editing/htmlediting.cpp: Removed include of unused RegularExpression.h header.

        * html/HTMLTokenizer.cpp:
        (WebCore::Token::addAttribute): Removed unused Document* argument.
        (WebCore::HTMLTokenizer::parseTag): Don't pass document to addAttribute.

        * html/HTMLTokenizer.h: Removed unused Document* argument to to addAttribute.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::localStorage): Don't pass the frame to storageArea.

        * page/DragController.cpp:
        (WebCore::DragController::dragIsMove): Removed unused DragData argument.
        (WebCore::DragController::performDrag): Call concludeEditDrag rather than
        concludeDrag.
        (WebCore::DragController::tryDocumentDrag): Don't pass dragData to dragIsMove.
        (WebCore::DragController::concludeEditDrag): Renamed to make it clear this
        should only be called for edit drags. Removed the action mask argument. Also
        changed dragIsMove call sites to not pass dragData.

        * page/DragController.h: Updated for above changes and tweaked comment format.

        * page/Frame.cpp:
        (WebCore::createRegExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
        when creating regular expressions for clarity. Call match instead of search,
        since both do the same thing except for with negative start offsets, and none
        used here are negative.
        (WebCore::Frame::matchLabelsAgainstElement): Ditto.

        * page/Page.h: Moved TextCaseSensitivity from here to StringImpl.h in platform.

        * page/mac/AccessibilityObjectWrapper.mm:
        (AXAttributeStringSetHeadingLevel): Removed unused object argument.
        (AXAttributedStringAppendText): Ditto.
        (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Ditto.

        * page/mac/FrameMac.mm:
        (WebCore::regExpForLabels): Pass TextCaseSensitive and TextCaseInsensitive
        when creating regular expressions for clarity. Call match instead of search,
        since both do the same thing except for with negative start offsets, and none
        used here are negative.
        (WebCore::Frame::matchLabelsAgainstElement): Ditto.

        * platform/graphics/SegmentedFontData.cpp:
        (WebCore::SegmentedFontData::containsCharacter): Added.
        (WebCore::SegmentedFontData::containsCharacters): Updated to check all characters
        instead of just the first one, using containsCharacter.

        * platform/graphics/SegmentedFontData.h: Made more members private.
        Added containsCharacter function member.

        * platform/mac/DragImageMac.mm:
        (WebCore::dragImageSize): Changed to use RetainPtr<NSImage> directly instead of
        DragImageRef for clarity, since this is platform-specific code.
        (WebCore::deleteDragImage): Ditto. Also remove argument name to get rid of unused
        variable warning.
        (WebCore::scaleDragImage): Ditto.
        (WebCore::dissolveDragImageToFraction): Ditto.
        (WebCore::createDragImageFromImage): Ditto.
        (WebCore::createDragImageIconForCachedImage): Ditto.

        * platform/mac/WebFontCache.mm:
        (acceptableChoice): Removed the unused weight-related arguments.
        (betterChoice): Ditto.
        (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Ditto.

        * platform/posix/FileSystemPOSIX.cpp: Removed the implementation of listDirectory
        because we'd rather get a link error rather than a runtime error if we use it
        for anything, and right now it's not used.

        * platform/text/RegularExpression.cpp: Removed unused private data,
        including pattern, lastMatchString, lastMatchOffsets, lastMatchCount,
        and lastMatchPos. Made the RegularExpression::Private::regex be private
        and use an accessor function to get at it.
        (WebCore::RegularExpression::RegularExpression): Removed the const char* version
        of the constructor because it's not any more efficient. Changed the boolean
        constructor argument to use TextCaseSensitivity instead to make it less likely
        we'll use it wrong.
        (WebCore::RegularExpression::operator=): Since the only member is a single RefPtr,
        just use plain old assignment on it. The only reason we do this instead of using
        the compiler generated assignment operator is that we want the Private structure
        to be internal to the .cpp file.
        (WebCore::RegularExpression::match): Added a null check so we won't crash if
        we fail to compile the regular expression. Removed the code to handle multiple
        match strings, since that was unused.

        * platform/text/RegularExpression.h: Changed the case sensitivity argument to use
        TextCaseSensitivity and not have a default value. Removed the default constructor,
        and the pattern, match, and pos functions.

        * platform/text/StringImpl.h: Moved the TextCaseSensitivity enum here from
        Page.h, because we should eventually use it in all the places where we have
        an argument to control case sensitivity, starting with the functions in this
        class.

        * platform/text/mac/ShapeArabic.c:
        (shapeUnicode): Removed the unused options and pErrorCode arguments. Even though
        this is code borrowed from ICU, this seems like a simple safe change to make.
        (shapeArabic): Don't pass options or pErrorCode in to shapeUnicode.

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::RenderPath): Removed the unused style argument.
        Also removed the type check. The argument already has the correct type,
        so it's not helpful to upcast it and then check its type again, unless
        we have some reason to believe the type is not reliable. And we don't.

        * rendering/RenderPath.h: Removed the RenderStyle* argument to the
        constructor. Also removed the explicit declaration of the destructor.
        It's not helpful or needed.

        * rendering/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::localCaretRect): Updated the comment here to
        make it clear that just returning an empty rect is not a good implementation.
        Removed the argument names to get rid of the warning.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::printBorderStyle): Removed the unused RenderObject argument.
        (WebCore::operator<<): Updated for the change to printBorderStyle function.

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::DatabaseThread): Removed the unused document argument.
        * storage/DatabaseThread.h: Ditto.

        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea): Removed the unused Frame* argument.
        * storage/LocalStorage.h: Ditto.

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::sendSVGLoadEventIfPossible): Don't pass an exception
        code location to dispatchGenericEvent.
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::dispatchEvent): Ditto.

        * svg/SVGStyledTransformableElement.cpp: Removed include of unused RegularExpression.h.
        (WebCore::SVGStyledTransformableElement::createRenderer): Don't pass style in to
        the RenderPath constructor.

        * svg/SVGTransformable.cpp: Removed include of unused RegularExpression.h.

        * xml/XSLTProcessor.cpp:
        (WebCore::createFragmentFromSource): Removed unused sourceNode argument.
        (WebCore::XSLTProcessor::transformToFragment): Don't pass sourceNode to createFragmentFromSource.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 David Levin <levin@chromium.org>
ap@webkit.org [Mon, 12 Jan 2009 07:34:12 +0000 (07:34 +0000)]
2009-01-11  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23245

        Add initializeThreading to key places in JS API to ensure that
        UString is properly initialized.

        * API/JSContextRef.cpp:
        (JSContextGroupCreate):
        (JSGlobalContextCreate):
        * API/JSObjectRef.cpp:
        (JSClassCreate):
        * API/JSStringRef.cpp:
        (JSStringCreateWithCharacters):
        (JSStringCreateWithUTF8CString):
        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 12 Jan 2009 07:21:46 +0000 (07:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23165
        Disable application cache dynamic entries support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 David Levin <levin@chromium.org>
darin@apple.com [Mon, 12 Jan 2009 03:19:23 +0000 (03:19 +0000)]
2009-01-11  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23175

        Separate out BaseString information from UString::Rep and make all baseString access go through
        a member function, so that it may be used for something else (in the future) in the BaseString
        case.

        * runtime/SmallStrings.cpp:
        (JSC::SmallStringsStorage::rep):
        (JSC::SmallStringsStorage::SmallStringsStorage):
        (JSC::SmallStrings::SmallStrings):
        (JSC::SmallStrings::mark):
        Adjust to account for the changes in UString and put the UString in place in
        SmallStringsStorage to aid in locality of reference among the UChar[] and UString::Rep's.

        * runtime/SmallStrings.h:
        * runtime/UString.cpp:
        (JSC::initializeStaticBaseString):
        (JSC::initializeUString):
        (JSC::UString::Rep::create):
        (JSC::UString::Rep::destroy):
        (JSC::UString::Rep::checkConsistency):
        (JSC::expandCapacity):
        (JSC::UString::expandPreCapacity):
        (JSC::concatenate):
        (JSC::UString::append):
        (JSC::UString::operator=):
        * runtime/UString.h:
        (JSC::UString::Rep::baseIsSelf):
        (JSC::UString::Rep::setBaseString):
        (JSC::UString::Rep::baseString):
        (JSC::UString::Rep::):
        (JSC::UString::Rep::null):
        (JSC::UString::Rep::empty):
        (JSC::UString::Rep::data):
        (JSC::UString::cost):
        Separate out the items out used by base strings from those used in Rep's that only
        point to base strings.  (This potentially saves 24 bytes per Rep.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 03:17:34 +0000 (03:17 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        * fast/frames/frame-deep-nested-resize-expected.txt: This time for sure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 12 Jan 2009 02:07:00 +0000 (02:07 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Fix failure of new test seen on buildbots.

        * fast/frames/frame-deep-nested-resize-expected.txt: Updated newlines to
        match what DumpRenderTree generates on Mac. I believe Adam generated his
        results under Qt DumpRenderTree. If so, then the Qt version will need to
        change to match the Mac version, since all the expected results were
        generated on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect coordinate transformation for deeply nested frames on resizing. This
treat@webkit.org [Mon, 12 Jan 2009 00:54:09 +0000 (00:54 +0000)]
Correct coordinate transformation for deeply nested frames on resizing.  This
fixes https://bugs.webkit.org/show_bug.cgi?id=20766.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoTiger build fix. The connection parameter is still used on Tiger in this method.
mrowe@apple.com [Sun, 11 Jan 2009 23:55:05 +0000 (23:55 +0000)]
Tiger build fix.  The connection parameter is still used on Tiger in this method.

* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 22:01:21 +0000 (22:01 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Third step: Deal with cases of arguments used only in assertions.

        * dom/MessagePort.cpp:
        (WebCore::MessagePortCloseEventTask::performTask): Use ASSERT_UNUSED.
        * dom/Worker.cpp:
        (WebCore::Worker::notifyFinished): Ditto.
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::notifyFinished): Ditto.
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::failedLoadingMainResource): Ditto.
        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didReceiveData): Since loader and size are only
        used when logging, use UNUSED_PARAM when logging is disabled.
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::beforeMouseDown): Use ASSERT_UNUSED.
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::didCancelAuthenticationChallenge): Use the
        argument since it's probably a tiny bit more efficient and gets rid
        of the unused argument warning.
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::createInlineBox): Use ASSERT_UNUSED.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createInlineBox): Ditto.
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::createInlineBox): Use UNUSED_PARAM.
        I couldn't use ASSERT_UNUSED because it's a single assertion, but it's
        the only use for two different arguments.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::createInlineBox): Use ASSERT_UNUSED.
        * rendering/RenderThemeMac.mm:
        (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 21:58:23 +0000 (21:58 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23239: improve handling of unused arguments in JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=23239

        * runtime/DatePrototype.cpp: Moved LocaleDateTimeFormat enum outside #if
        so we can use this on all platforms. Changed valueOf to share the same
        function with getTime, since the contents of the two are identical. Removed
        a FIXME since the idea isn't really specific enough or helpful enough to
        need to sit here in the source code.
        (JSC::formatLocaleDate): Changed the Mac version of this function to take
        the same arguments as the non-Mac version so the caller doesn't have to
        special-case the two platforms. Also made the formatString array be const;
        before the characters were, but the array was a modifiable global variable.
        (JSC::dateProtoFuncToLocaleString): Changed to call the new unified
        version of formatLocaleDate and remove the ifdef.
        (JSC::dateProtoFuncToLocaleDateString): Ditto.
        (JSC::dateProtoFuncToLocaleTimeString): Ditto.

        * runtime/JSNotAnObject.cpp:
        (JSC::JSNotAnObject::toObject): Use the new ASSERT_UNUSED instead of the
        old UNUSED_PARAM.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp): Changed to only use UNUSED_PARAM when the parameter
        is actually unused.

        * wtf/TCSystemAlloc.cpp:
        (TCMalloc_SystemRelease): Changed to only use UNUSED_PARAM when the parameter
        is actually unused.
        (TCMalloc_SystemCommit): Changed to omit the argument names instead of using
        UNUSED_PARAM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Sun, 11 Jan 2009 21:42:47 +0000 (21:42 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 11 Jan 2009 21:22:04 +0000 (21:22 +0000)]
2009-01-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt

        https://bugs.webkit.org/show_bug.cgi?id=23242

        Fix CanvasRenderingContext2D::transform to do a pre-multiply,
        rather than a post-multiply into m_transform. This bug did not affect
        drawing, but did cause m_transform to be incorrect, which impacted
        willDraw(), and isPointInPath.

        Test: fast/canvas/canvas-incremental-repaint-2.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::transform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 11 Jan 2009 20:05:45 +0000 (20:05 +0000)]
2009-01-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 23102: turn on unused parameter warnings in WebCore
        https://bugs.webkit.org/show_bug.cgi?id=23102

        Second step: Fix simple Objective-C cases where we need to use UNUSED_PARAM.
        That's because you can't omit an argument name in Objective-C methods.

        * bindings/objc/DOMObject.mm:
        (-[DOMObject copyWithZone:]): Use UNUSED_PARAM. Also rename argument to include
        the word "unused" so we don't just start using it without removing the macro.
        * bindings/objc/WebScriptObject.mm:
        (+[WebUndefined allocWithZone:]): Ditto.
        (-[WebUndefined initWithCoder:]): Ditto.
        (-[WebUndefined encodeWithCoder:]): Ditto.
        (-[WebUndefined copyWithZone:]): Ditto.
        * page/mac/WebDashboardRegion.m:
        (-[WebDashboardRegion copyWithZone:]): Ditto.
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::mainThreadSetNeedsDisplay): Omit argument name.
        (-[WebCoreMovieObserver loadStateChanged:]): Use UNUSED_PARAM as above.
        (-[WebCoreMovieObserver rateChanged:]): Ditto.
        (-[WebCoreMovieObserver sizeChanged:]): Ditto.
        (-[WebCoreMovieObserver timeChanged:]): Ditto.
        (-[WebCoreMovieObserver didEnd:]): Ditto.
        (-[WebCoreMovieObserver newImageAvailable:]): Ditto.
        * platform/mac/ScrollbarThemeMac.mm:
        (+[ScrollbarPrefsObserver appearancePrefsChanged:]): Ditto.
        (+[ScrollbarPrefsObserver behaviorPrefsChanged:]): Ditto.
        * platform/mac/SharedTimerMac.mm:
        (-[WebCorePowerNotifier didWake:]): Ditto.
        * platform/mac/WebCoreKeyGenerator.m:
        (-[WebCoreKeyGenerator signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:pageURL:]): Ditto.
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): Ditto.
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveResponse:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didReceiveData:]): Ditto.
        (-[WebCoreSynchronousLoader connectionDidFinishLoading:]): Ditto.
        (-[WebCoreSynchronousLoader connection:didFailWithError:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 11 Jan 2009 19:59:52 +0000 (19:59 +0000)]
2009-01-11  Dirk Schulze  <krit@webkit.org>

        Reviewed by Darin Adler.

        Move platform dependent strokeContains back to RenderPath, Path and delete
        unneeded Code in svg.

        RenderPath clean-up for strokeContains
        [https://bugs.webkit.org/show_bug.cgi?id=22957]

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/Path.h:
        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::strokeContains):
        * platform/graphics/cg/PathCG.cpp:
        (WebCore::Path::strokeContains):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::strokeContains):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::strokeContains):
        * svg/graphics/cairo/RenderPathCairo.cpp: Removed.
        * svg/graphics/cg/CgSupport.cpp: Removed.
        * svg/graphics/cg/CgSupport.h: Removed.
        * svg/graphics/cg/RenderPathCg.cpp: Removed.
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
        * svg/graphics/cg/SVGResourceMaskerCg.mm:
        * svg/graphics/qt/RenderPathQt.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:59:13 +0000 (19:59 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Bump version to 1.1.0 since we are breaking ABI and adding new
        major features.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:57:32 +0000 (19:57 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Use NULL instead of 0 when dealing with pointers, as agreed for
        the coding style of the WebKit GTK port for its GTK+ specific
        files.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Xan Lopez <xan@gnome.org>
zecke@webkit.org [Sun, 11 Jan 2009 19:55:30 +0000 (19:55 +0000)]
2009-01-11 Xan Lopez <xan@gnome.org>

        Reviewed by Holger Freyther.

        Add padding to the class structs to avoid breaking ABI each time
        we add stuff there.

        * webkit/webkitnetworkrequest.h:
        * webkit/webkitwebbackforwardlist.h:
        * webkit/webkitwebhistoryitem.h:
        * webkit/webkitwebnavigationaction.h:
        * webkit/webkitwebpolicydecision.h:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase...
zecke@webkit.org [Sun, 11 Jan 2009 19:47:53 +0000 (19:47 +0000)]
[GTK] make distcheck complains that distclean is not deleting JSWorkerContextBase.lut.h

make distcheck pass by adding JSWorkerContextBase.lut.h to the
CLEANFILES that will be cleaned on a make distclean.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agobuild fix
oliver@apple.com [Sun, 11 Jan 2009 19:47:34 +0000 (19:47 +0000)]
build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23128: get/put_by_val need to respecialise in the face of ByteArray
oliver@apple.com [Sun, 11 Jan 2009 19:12:47 +0000 (19:12 +0000)]
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray

Reviewed by Darin Adler and Anders Carlsson

Restructure the code slightly, and add comments per Darin's suggestions

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix exception check for string indexing
oliver@apple.com [Sun, 11 Jan 2009 18:56:07 +0000 (18:56 +0000)]
Fix exception check for string indexing

Reviewed by Anders Carlsson.

Whoops, I accidentally removed an exception check from fast the
fast path for string indexing when i originally landed the
byte array logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoattempt to fix win build
oliver@apple.com [Sun, 11 Jan 2009 16:54:05 +0000 (16:54 +0000)]
attempt to fix win build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 23128: get/put_by_val need to respecialise in the face of ByteArray
oliver@apple.com [Sun, 11 Jan 2009 16:48:39 +0000 (16:48 +0000)]
Bug 23128: get/put_by_val need to respecialise in the face of ByteArray
<https://bugs.webkit.org/show_bug.cgi?id=23128>

Reviewed by Anders Carlsson.

Fairly simple patch, add specialised versions of cti_op_get/put_by_val
that assume ByteArray, thus avoiding a few branches in the case of bytearray
manipulation.

No effect on SunSpider.  15% win on the original testcase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Zalan Bujtas <zbujtas@gmail.com>
ap@webkit.org [Sun, 11 Jan 2009 11:06:32 +0000 (11:06 +0000)]
2009-01-11  Zalan Bujtas  <zbujtas@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23235
        Build fix for non-VIDEO builds.

        * rendering/RenderTheme.cpp:
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Try to fix Windows build.
ap@webkit.org [Sun, 11 Jan 2009 11:03:02 +0000 (11:03 +0000)]
    Try to fix Windows build.

        * wtf/CurrentTime.cpp: Added a definition of msPerSecond (previously, this code was in
        DateMath.cpp, with constant definition in DateTime.h)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Alexey Proskuryakov <ap@webkit.org>
ap@webkit.org [Sun, 11 Jan 2009 10:36:23 +0000 (10:36 +0000)]
2009-01-11  Alexey Proskuryakov  <ap@webkit.org>

        Try to fix Windows build.

        * wtf/CurrentTime.cpp: Include <sys/types.h> and <sys/timeb.h>, as MSDN says to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Gabriella Toth <gtoth@inf.u-szeged.hu>
ap@webkit.org [Sun, 11 Jan 2009 10:27:03 +0000 (10:27 +0000)]
2009-01-11  Gabriella Toth  <gtoth@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19287
        return value of malloc() is not checked in npruntime.cpp

        Checking whether malloc can allocate memory or not. If it can't, CRASH macro is invoked
        (like in fastMalloc).

        * bridge/npruntime.cpp:
        (_NPN_GetStringIdentifier):
        (_NPN_GetIntIdentifier):
        (NPN_InitializeVariantWithStringCopy):
        (_NPN_CreateObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Glenn Wilson <gwilson@google.com>
ap@webkit.org [Sun, 11 Jan 2009 10:24:52 +0000 (10:24 +0000)]
2009-01-11  Glenn Wilson  <gwilson@google.com>

        Reviewed by Darin Adler.

        Changes radio buttons so they can be 'checked' even if they
        don't have the name attribute set.

        See https://bugs.webkit.org/show_bug.cgi?id=21534

        Test: fast/html/select-unnamed-radio.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::preDispatchEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 tony chang <tony@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:48:26 +0000 (09:48 +0000)]
2009-01-11  tony chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Remove svn:eol-style native from some utf16 files so
        windows-svn doesn't alter them on checkout.

        * fast/xsl/xslt-enc16.xml: remove svn:eol-style
        * fast/xsl/xslt-enc16to16.xml: remove svn:eol-style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix ChangeLog date.
ap@webkit.org [Sun, 11 Jan 2009 09:44:21 +0000 (09:44 +0000)]
Fix ChangeLog date.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Robert Blaut <webkit@blaut.biz>
ap@webkit.org [Sun, 11 Jan 2009 09:43:03 +0000 (09:43 +0000)]
2009-01-11  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Eric Seidel.

        <https://bugs.webkit.org/show_bug.cgi?id=23134>
        Update bisect-builds for Safari 3.2 to prevent crashes

        * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Jungshik Shin <jshin@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:40:29 +0000 (09:40 +0000)]
2009-01-11  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Alexey Proskuryakov

        - Make fast/encoding/char-encoding test work with Chromium by replacing
        'data:' with 'file:' pointing to resources/dummy.html (an empty file).
        - Put old Mac encodings in a separate char-encoding-mac.html to make it
        possible to to skip it.
        - Factor out common functions in char-encoding.html and char-encoding-mac.html
        and put them in char-encoding-utils.js

        See: https://bugs.webkit.org/show_bug.cgi?id=22882

        * fast/encoding/char-encoding-mac-expected.txt: Added.
        * fast/encoding/char-encoding-mac.html: Added.
        * fast/encoding/char-encoding.html:
        * fast/encoding/resources/char-encoding-utils.js: Added.
        * fast/encoding/resources/dummy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-12-18 Bernhard Rosenkraenzer <bero@arklinux.ch>
ap@webkit.org [Sun, 11 Jan 2009 09:36:14 +0000 (09:36 +0000)]
2008-12-18  Bernhard Rosenkraenzer <bero@arklinux.ch>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=22205
        Fix compatibility with bison 2.4, partially based on older patch by
        Priit Laes <amd@store20.com>

        * WebCore/css/CSSGrammar.y: Made compatible with bison 2.4

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Jeremy Moskovich <jeremy@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 09:18:21 +0000 (09:18 +0000)]
2009-01-11  Jeremy Moskovich  <jeremy@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=16001
        Incorrect assumption that selection is always contiguous LTR.

        Test: editing/selection/extend-selection-bidi.html

        * rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::fillLineSelectionGap):
        Make this function  not assume a contiguous visual LTR selection range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Sun, 11 Jan 2009 08:14:58 +0000 (08:14 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23207
        Moved currentTime() to from WebCore to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-11 Dmitry Titov <dimich@chromium.org>
ap@webkit.org [Sun, 11 Jan 2009 08:06:58 +0000 (08:06 +0000)]
2009-01-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        Make ScheduledAction (Timeout callback) able to execute the callback under WorkerContext.
        Part of 'Timers in Workers' work.
        https://bugs.webkit.org/show_bug.cgi?id=23223

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute): new method that takes WorkerContext.
        (WebCore::ScheduledAction::executeFunctionInContext): Executes a JSFunction in proper context with 'this' object.
        * bindings/js/ScheduledAction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sun, 11 Jan 2009 07:45:45 +0000 (07:45 +0000)]
2009-01-10  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23210
        Make it easier for ports to define custom UI for media controls

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForElement): call theme()->styleSheetForMediaControls to
        get the media controller style sheet

        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlInputElement::hitTest): Added
        * rendering/MediaControlElements.h: Updated

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function
        so control elements don't necessarily have to be rectangular

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::styleSheetForMediaControls):  Added
        (WebCore::RenderTheme::hitTestMediaControlPart):  Added
        * rendering/RenderTheme.h: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 11 Jan 2009 02:47:51 +0000 (02:47 +0000)]
2009-01-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23222

        We need to disable LayoutState when an object has transforms,
        because LayoutState is not transform-aware and therefore
        repaint rects can be computed incorrectly.

        Test: fast/repaint/transform-disable-layoutstate.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::layoutOnlyPositionedObjects):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert 39779.
abarth@webkit.org [Sun, 11 Jan 2009 00:05:19 +0000 (00:05 +0000)]
Revert 39779.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
abarth@webkit.org [Sat, 10 Jan 2009 23:16:08 +0000 (23:16 +0000)]
WebCore:

2009-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fix https://bugs.webkit.org/show_bug.cgi?id=21456

        We shouldn't update the document pointer of inactive windows.  This
        behavior differs slightly from Firefox, I'd argue that this behavior is
        more correct (we both differ from IE).  The HTML 5 spec is a bit in flux
        on this point.

        Test: http/tests/security/xss-inactive-closure.html

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell):
        (WebCore::ScriptController::updateDocument):
        * bindings/js/ScriptController.h:

LayoutTests:

2009-01-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Test that we don't do goofy things with the document pointer after
        navigation.

        * fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
        * fast/dom/Window/dom-access-from-closure-window-expected.txt:
        * http/tests/security/resources/childWithButton.html: Added.
        * http/tests/security/resources/xss-inactive-closure-child-2.html: Added.
        * http/tests/security/resources/xss-inactive-closure-child.html: Added.
        * http/tests/security/xss-inactive-closure-expected.txt: Added.
        * http/tests/security/xss-inactive-closure.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-10 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 10 Jan 2009 22:03:25 +0000 (22:03 +0000)]
2009-01-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/5845089> REGRESSION (r30044): Mail custom stationery missing images
        because of change to -[HTMLObjectElement data]

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Added a thread
        violation check because I saw this being done off the main thread while testing Mail, and it
        caused problems. Put all the one time initialization under a single guard to make things just
        a little faster other times, and to make it clearer which things are one-time. Added a call to
        the new patchMailRemoveAttributesMethod function.
        (-[WebView initWithFrame:frameName:groupName:]): Added a thread violation check here too,
        because I assumed it would be slightly better to have a public method name in the violation
        message. This calls commonInitialization later, so it will hit that one eventually.
        (objectElementDataAttribute): Added. Just returns the value of the "data" attribute.
        (recursivelyRemoveMailAttributes): Added. Patch to an internal Mail method that in turn patches
        a WebKit method and removes the patch again on the way out.
        (patchMailRemoveAttributesMethod): Added. On Leopard only, checks the Mail version, and then
        applies the patch that fixes this bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[QT] Make SharedTimer use QBasicTimer
zecke@webkit.org [Sat, 10 Jan 2009 03:46:44 +0000 (03:46 +0000)]
[QT] Make SharedTimer use QBasicTimer

Kill the SharedTimerQt.h and the usage of signal and slots
by using QBasicTimer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Benjamin Otte <otte@gnome.org>
zecke@webkit.org [Sat, 10 Jan 2009 03:46:31 +0000 (03:46 +0000)]
2009-01-09  Benjamin Otte  <otte@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23194

        make the finalize function the dispose function. Not releasing held
        objects in dispose can cause crashers later.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Benjamin Otte <otte@gnome.org>
zecke@webkit.org [Sat, 10 Jan 2009 03:46:21 +0000 (03:46 +0000)]
2009-01-09  Benjamin Otte  <otte@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=23194

        Remove broken code that uses a fallback. The previous code did 2
        policy decisions which caused crashes.
        Download is still notImplemented();

        * webkit/webkitwebpolicydecision.cpp:
        (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Adam Bergkvist <adam.bergkvist@ericsson.com>
zecke@webkit.org [Sat, 10 Jan 2009 03:46:10 +0000 (03:46 +0000)]
2009-01-09  Adam Bergkvist <adam.bergkvist@ericsson.com>

        Reviewed by Holger Freyther.

        [CURL] POST without body becomes GET
        https://bugs.webkit.org/show_bug.cgi?id=23182

        Make sure that method is always set to POST even when the body is
        empty. Cleaned up httpBody null check.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::setupPOST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
treat@webkit.org [Sat, 10 Jan 2009 02:00:51 +0000 (02:00 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Adele Peterson <adele@apple.com>
adele@apple.com [Sat, 10 Jan 2009 01:12:04 +0000 (01:12 +0000)]
2009-01-09  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix infinite recursion in clientPaddingLeft and clientPaddingRight.  This changes the code back to
        how it was before RenderTextControlSingleLine was split out from RenderTextControl.

        No test added since this code is only exercised when trying to place a search field's recent searches popup menu.

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
        (WebCore::RenderTextControlSingleLine::clientPaddingRight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sat, 10 Jan 2009 00:41:53 +0000 (00:41 +0000)]
WebCore:

2009-01-09  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        Bug 22913: REGRESSION: Space bar doesn't scroll on windows
        https://bugs.webkit.org/show_bug.cgi?id=22913
        rdar://problem/6479834

        * page/EventHandler.cpp:
        (WebCore::EventHandler::defaultKeyboardEventHandler): Added code to call
        defaultSpaceEventHandler.
        (WebCore::EventHandler::defaultSpaceEventHandler): Added. Scrolls down or up based
        on the shift key.
        * page/EventHandler.h: Added defaultSpaceEventHandler.

        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::platformScroll): Return false, because this function does
        not scroll. In an earlier version of this patch, I used this to prevent the
        patch from affecting the Mac, but I decided to use #if instead.

WebKit/win:

2009-01-09  Darin Adler  <darin@apple.com>

        Reviewed by Jon Honeycutt.

        Bug 22913: REGRESSION: Space bar doesn't scroll on windows
        https://bugs.webkit.org/show_bug.cgi?id=22913
        rdar://problem/6479834

        * WebView.cpp:
        (WebView::keyPress): Removed code to handle space bar here; put it in
        WebCore instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 10 Jan 2009 00:38:14 +0000 (00:38 +0000)]
2009-01-09  Sam Weinig  <sam@webkit.org>

        Check in correct results for failing test.

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
barraclough@apple.com [Sat, 10 Jan 2009 00:14:25 +0000 (00:14 +0000)]
JavaScriptCore:

2009-01-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Stage two of converting JSValue from a pointer to a class type.
        Remove the class JSValue.  The functionallity has been transitioned
        into the wrapper class type JSValuePtr.

        The last stage will be to rename JSValuePtr to JSValue, remove the
        overloaded -> operator, and switch operations on JSValuePtrs from
        using '->' to use '.' instead.

        * API/APICast.h:
        * JavaScriptCore.exp:
        * runtime/JSCell.h:
        (JSC::asCell):
        (JSC::JSValuePtr::asCell):
        (JSC::JSValuePtr::isNumber):
        (JSC::JSValuePtr::isString):
        (JSC::JSValuePtr::isGetterSetter):
        (JSC::JSValuePtr::isObject):
        (JSC::JSValuePtr::getNumber):
        (JSC::JSValuePtr::getString):
        (JSC::JSValuePtr::getObject):
        (JSC::JSValuePtr::getCallData):
        (JSC::JSValuePtr::getConstructData):
        (JSC::JSValuePtr::getUInt32):
        (JSC::JSValuePtr::getTruncatedInt32):
        (JSC::JSValuePtr::getTruncatedUInt32):
        (JSC::JSValuePtr::mark):
        (JSC::JSValuePtr::marked):
        (JSC::JSValuePtr::toPrimitive):
        (JSC::JSValuePtr::getPrimitiveNumber):
        (JSC::JSValuePtr::toBoolean):
        (JSC::JSValuePtr::toNumber):
        (JSC::JSValuePtr::toString):
        (JSC::JSValuePtr::toObject):
        (JSC::JSValuePtr::toThisObject):
        (JSC::JSValuePtr::needsThisConversion):
        (JSC::JSValuePtr::toThisString):
        (JSC::JSValuePtr::getJSNumber):
        * runtime/JSImmediate.h:
        (JSC::JSValuePtr::isUndefined):
        (JSC::JSValuePtr::isNull):
        (JSC::JSValuePtr::isUndefinedOrNull):
        (JSC::JSValuePtr::isBoolean):
        (JSC::JSValuePtr::getBoolean):
        (JSC::JSValuePtr::toInt32):
        (JSC::JSValuePtr::toUInt32):
        * runtime/JSNumberCell.h:
        (JSC::JSValuePtr::uncheckedGetNumber):
        (JSC::JSValuePtr::toJSNumber):
        * runtime/JSObject.h:
        (JSC::JSValuePtr::isObject):
        (JSC::JSValuePtr::get):
        (JSC::JSValuePtr::put):
        * runtime/JSString.h:
        (JSC::JSValuePtr::toThisJSString):
        * runtime/JSValue.cpp:
        (JSC::JSValuePtr::toInteger):
        (JSC::JSValuePtr::toIntegerPreserveNaN):
        (JSC::JSValuePtr::toInt32SlowCase):
        (JSC::JSValuePtr::toUInt32SlowCase):
        * runtime/JSValue.h:
        (JSC::JSValuePtr::makeImmediate):
        (JSC::JSValuePtr::immediateValue):
        (JSC::JSValuePtr::JSValuePtr):
        (JSC::JSValuePtr::operator->):
        (JSC::JSValuePtr::operator bool):
        (JSC::JSValuePtr::operator==):
        (JSC::JSValuePtr::operator!=):
        (JSC::JSValuePtr::encode):
        (JSC::JSValuePtr::decode):
        (JSC::JSValuePtr::toFloat):
        (JSC::JSValuePtr::asValue):
        (JSC::operator==):
        (JSC::operator!=):

WebCore:

2009-01-09  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Delete references to JSValue, removing this class.

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::self):
        * bindings/js/ScriptCallStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 9 Jan 2009 23:42:01 +0000 (23:42 +0000)]
2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add svg/graphics/skia files.
        https://bugs.webkit.org/show_bug.cgi?id=23147

        * svg/graphics/skia/RenderPathSkia.cpp: Added.
        (WebCore::RenderPath::strokeContains):
        * svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Added.
        (WebCore::SVGPaintServerPattern::setup):
        * svg/graphics/skia/SVGPaintServerSkia.cpp: Added.
        (WebCore::SVGPaintServer::draw):
        (WebCore::SVGPaintServer::teardown):
        (WebCore::SVGPaintServer::renderPath):
        * svg/graphics/skia/SVGResourceFilterSkia.cpp: Added.
        (WebCore::SVGResourceFilter::createPlatformData):
        (WebCore::SVGResourceFilter::prepareFilter):
        (WebCore::SVGResourceFilter::applyFilter):
        * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Added.
        (WebCore::SVGResourceMasker::applyMask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 9 Jan 2009 23:04:16 +0000 (23:04 +0000)]
2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add SkiaFontWin to platform/graphics/chromium
        https://bugs.webkit.org/show_bug.cgi?id=23215

        * platform/graphics/skia/SkiaFontWin.cpp: Added.
        (WebCore::CachedOutlineKey::CachedOutlineKey):
        (WebCore::operator==):
        (WebCore::CachedOutlineKeyHash::hash):
        (WebCore::CachedOutlineKeyHash::equal):
        (WebCore::FIXEDToSkScalar):
        (WebCore::deleteOutline):
        (WebCore::addPolyCurveToPath):
        (WebCore::getPathForGlyph):
        (WebCore::SkiaWinOutlineCache::lookupOrCreatePathForGlyph):
        (WebCore::SkiaWinOutlineCache::removePathsForFont):
        * platform/graphics/skia/SkiaFontWin.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 9 Jan 2009 22:55:20 +0000 (22:55 +0000)]
2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add PlatformContextSkia and PlatformGraphics.h to platform/graphics/skia
        https://bugs.webkit.org/show_bug.cgi?id=23215

        * platform/graphics/skia/PlatformContextSkia.cpp: Added.
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::State::~State):
        (PlatformContextSkia::State::applyAlpha):
        (PlatformContextSkia::PlatformContextSkia):
        (PlatformContextSkia::~PlatformContextSkia):
        (PlatformContextSkia::setCanvas):
        (PlatformContextSkia::save):
        (PlatformContextSkia::restore):
        (PlatformContextSkia::drawRect):
        (PlatformContextSkia::setupPaintCommon):
        (PlatformContextSkia::setupPaintForFilling):
        (PlatformContextSkia::setupPaintForStroking):
        (PlatformContextSkia::setDrawLooper):
        (PlatformContextSkia::setMiterLimit):
        (PlatformContextSkia::setAlpha):
        (PlatformContextSkia::setLineCap):
        (PlatformContextSkia::setLineJoin):
        (PlatformContextSkia::setPorterDuffMode):
        (PlatformContextSkia::setFillColor):
        (PlatformContextSkia::getDrawLooper):
        (PlatformContextSkia::getStrokeStyle):
        (PlatformContextSkia::setStrokeStyle):
        (PlatformContextSkia::setStrokeColor):
        (PlatformContextSkia::getStrokeThickness):
        (PlatformContextSkia::setStrokeThickness):
        (PlatformContextSkia::getTextDrawingMode):
        (PlatformContextSkia::setTextDrawingMode):
        (PlatformContextSkia::setUseAntialiasing):
        (PlatformContextSkia::fillColor):
        (PlatformContextSkia::beginPath):
        (PlatformContextSkia::addPath):
        (PlatformContextSkia::setFillRule):
        (PlatformContextSkia::setGradient):
        (PlatformContextSkia::setPattern):
        (PlatformContextSkia::setDashPathEffect):
        (PlatformContextSkia::paintSkPaint):
        (PlatformContextSkia::bitmap):
        (PlatformContextSkia::isPrinting):
        * platform/graphics/skia/PlatformContextSkia.h: Added.
        (PlatformContextSkia::currentPath):
        (PlatformContextSkia::canvas):
        (PlatformContextSkia::gdk_skia):
        * platform/graphics/skia/PlatformGraphics.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 9 Jan 2009 22:35:15 +0000 (22:35 +0000)]
2009-01-09  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebCore.LP64.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Dimitri Glazkov <dglazkov@chromium.org>
eric@webkit.org [Fri, 9 Jan 2009 22:34:02 +0000 (22:34 +0000)]
2009-01-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Add TransformationMatrixSkia to platform/graphics/skia
        https://bugs.webkit.org/show_bug.cgi?id=23215

        * platform/graphics/skia/TransformationMatrixSkia.cpp: Added.
        (WebCore::TransformationMatrix::TransformationMatrix):
        (WebCore::TransformationMatrix::setMatrix):
        (WebCore::TransformationMatrix::map):
        (WebCore::TransformationMatrix::mapRect):
        (WebCore::TransformationMatrix::isIdentity):
        (WebCore::TransformationMatrix::reset):
        (WebCore::TransformationMatrix::scale):
        (WebCore::TransformationMatrix::rotate):
        (WebCore::TransformationMatrix::translate):
        (WebCore::TransformationMatrix::shear):
        (WebCore::TransformationMatrix::det):
        (WebCore::TransformationMatrix::inverse):
        (WebCore::TransformationMatrix::operator SkMatrix):
        (WebCore::TransformationMatrix::operator==):
        (WebCore::TransformationMatrix::operator*=):
        (WebCore::TransformationMatrix::operator*):
        (WebCore::TransformationMatrix::a):
        (WebCore::TransformationMatrix::setA):
        (WebCore::TransformationMatrix::b):
        (WebCore::TransformationMatrix::setB):
        (WebCore::TransformationMatrix::c):
        (WebCore::TransformationMatrix::setC):
        (WebCore::TransformationMatrix::d):
        (WebCore::TransformationMatrix::setD):
        (WebCore::TransformationMatrix::e):
        (WebCore::TransformationMatrix::setE):
        (WebCore::TransformationMatrix::f):
        (WebCore::TransformationMatrix::setF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Brent Fulgham <bfulgham@gmail.com>
ap@webkit.org [Fri, 9 Jan 2009 22:33:14 +0000 (22:33 +0000)]
2009-01-09  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Adam Roben.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
        Separate CFNetwork-specific code in WebKit.dll into separate
        implementation files. Create cURL stub files to be populated
        with new implementation in a future bug report.

        * WebCookieManager.cpp: Move CFNetwork-specific routines to
          the new WebCookieManagerCFNet.cpp file.
        (WebCookieManager::Release):
        * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
        (WebCookieManager::cookieStorage):
        * WebCookieManagerCurl.cpp: Added.
        (WebCookieManager::cookieStorage):
        (WebCookieManager::setCookieStorage):
        * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
          methods in this file.
        (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
        (WebFrameLoaderClient::savePlatformDataToCachedPage):
        * WebDownload.cpp: Move CFNetwork-specific logic to the new
          WebDownloadCFNet.cpp
        (WebDownload::bundleExtension):
        (WebDownload::bundleMagicNumber):
        (WebDownload::bundlePathForTargetPath):
        (WebDownload::extractResumeDataFromBundle): Made static class method
          so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
        (WebDownload::appendResumeDataToBundle): Made static class method
          so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
        * WebDownload.h:
        * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
        (WebDownload::initToResumeWithBundle):
        (WebDownload::setDestination):
        (didFailCallback):
        * WebDownloadCurl.cpp: Added.
        (WebDownload::init):
        (WebDownload::initWithRequest):
        (WebDownload::initToResumeWithBundle):
        (WebDownload::start):
        (WebDownload::cancel):
        (WebDownload::cancelForResume):
        (WebDownload::deletesFileUponFailure):
        (WebDownload::setDeletesFileUponFailure):
        (WebDownload::setDestination):
        (WebDownload::cancelAuthenticationChallenge):
        (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
        (WebDownload::useCredential):
        * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
          new cURL files. Modify Cairo targets to exclude CFNet files.
        * WebMutableURLRequest.cpp: Conditionalize the single method
          with a CFNetwork-speicic call.
        (WebMutableURLRequest::mutableCopy):
        * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
          causes build problems for cURL. This will be removed later.
        (WebURLAuthenticationChallenge::initWithProtectionSpace):
        * WebURLAuthenticationChallengeSender.cpp:
        * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
        (WebURLAuthenticationChallengeSender::useCredential):
        * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
        (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
        (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
        (WebURLAuthenticationChallengeSender::useCredential):
        * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
          for the cURL target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 9 Jan 2009 22:21:48 +0000 (22:21 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6477502> Repro crash reloading page using HTML5 AppCache on Windows

        Test: http/tests/appcache/reload.html

        On Windows, reloading resulted in the following sequence of events:
        1) A new main resource loader was created and associated with the cache. Its document loader
        was not associated with the cache yet.
        2) The old document loader was destroyed, and since it was the last one, ApplicationCacheGroup
        teardown started, with newestCache being zeroed out.
        3) The new document loader was associated with the cache group, and cache update started.
        4) Since newestCache was null, this caused many problems.

        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): Improve comments and assertions,
        no functional changes.
        (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the cache group
        if its newest cache pointer is already saved for teardown. Note that the cache pointer
        validity is ensured by MainResourceLoader that holds a reference to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 9 Jan 2009 22:20:36 +0000 (22:20 +0000)]
    Reviewed by Darin Adler.

        Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.

        * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
        raise exceptions, as needed for AppCache tests. I do not know why this error was not
        implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 9 Jan 2009 22:12:05 +0000 (22:12 +0000)]
2009-01-09  Darin Fisher  <darin@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=23214
        Upstream platform/network/chromium/

        * platform/network/chromium/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        (WebCore::AuthenticationChallenge::sourceHandle):
        * platform/network/chromium/AuthenticationChallengeChromium.cpp: Added.
        (WebCore::AuthenticationChallenge::platformCompare):
        * platform/network/chromium/CookieJarChromium.cpp: Added.
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookiesEnabled):
        * platform/network/chromium/DNSChromium.cpp: Added.
        (WebCore::prefetchDNS):
        * platform/network/chromium/NetworkStateNotifierChromium.cpp: Added.
        (WebCore::NetworkStateNotifier::updateState):
        (WebCore::NetworkStateNotifier::NetworkStateNotifier):
        * platform/network/chromium/NetworkStateNotifierPrivate.h: Added.
        * platform/network/chromium/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/chromium/ResourceRequest.h: Added.
        (WebCore::ResourceRequest::):
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::frame):
        (WebCore::ResourceRequest::setFrame):
        (WebCore::ResourceRequest::setTargetType):
        (WebCore::ResourceRequest::targetType):
        (WebCore::ResourceRequest::originPid):
        (WebCore::ResourceRequest::setOriginPid):
        (WebCore::ResourceRequest::securityInfo):
        (WebCore::ResourceRequest::setSecurityInfo):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        * platform/network/chromium/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::getSecurityInfo):
        (WebCore::ResourceResponse::setSecurityInfo):
        (WebCore::ResourceResponse::isContentFiltered):
        (WebCore::ResourceResponse::setIsContentFiltered):
        (WebCore::ResourceResponse::doUpdateResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agofix tyop in Changelog
barraclough@apple.com [Fri, 9 Jan 2009 21:44:16 +0000 (21:44 +0000)]
fix tyop in Changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 9 Jan 2009 21:42:20 +0000 (21:42 +0000)]
    Reviewed by Darin Adler.

        - fixed <rdar://problem/6234347> Add/change conditional key
          bindings for changing paragraph- and character-level writing
          direction (to match NSTextView)

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Added
        code to validate makeBaseWritingDirectionLeftToRight: and
        makeBaseWritingDirectionRightToLeft:.
        (writingDirectionKeyBindingsEnabled): Changed this function to
        always return YES, except on Tiger and Leopard.
        (-[WebHTMLView makeBaseWritingDirectionLeftToRight:]): Renamed
        changeBaseWritingDirectionToLTR: to this.
        (-[WebHTMLView makeBaseWritingDirectionRightToLeft:]): Renamed
        changeBaseWritingDirectionToRTL: to this.
        (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Now calls
        makeBaseWritingDirectionLeftToRight:.
        (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Now calls
        makeBaseWritingDirectionRightToLeft:.
        * WebView/WebView.mm: Added makeBaseWritingDirectionLeftToRight
        and makeBaseWritingDirectionRightToLeft to
        FOR_EACH_RESPONDER_SELECTOR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Darin Adler <darin@apple.com>
adele@apple.com [Fri, 9 Jan 2009 21:01:35 +0000 (21:01 +0000)]
2009-01-09  Darin Adler  <darin@apple.com>

        Reviewed and landed by Adele Peterson.

        Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
        https://bugs.webkit.org/show_bug.cgi?id=23160

        * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
        * WebView.cpp:
        (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
        * WebView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Fri, 9 Jan 2009 20:53:03 +0000 (20:53 +0000)]
2009-01-09 William Siegrist <wsiegrist@apple.com>
Reviewed by David Kilzer

Update URLs which go through redirects by changing bugs.webkit.org URLs to use https and removing /projects/webkit from Trac URLs.

Replace tabs in bugpriorities.html with spaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 David Levin <levin@chromium.org>
oliver@apple.com [Fri, 9 Jan 2009 20:17:00 +0000 (20:17 +0000)]
2009-01-09  David Levin  <levin@chromium.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23175

        Adjustment to previous patch.  Remove call to initilizeThreading from JSGlobalCreate
        and fix jsc.cpp instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Joel Weinberger <jww@cs.berkeley.edu>
abarth@webkit.org [Fri, 9 Jan 2009 19:42:04 +0000 (19:42 +0000)]
2009-01-09  Joel Weinberger  <jww@cs.berkeley.edu>

        Reviewed by Darin Adler.
        Landed by Adam Barth.

        The test intended to test reload, but reference reload in one place and
        replace in another. This makes them consistent.

        * http/tests/security/resources/xss-DENIED-assign-location-reload-attacker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 9 Jan 2009 19:12:59 +0000 (19:12 +0000)]
2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Documentation fixes, remove duplicated docs, document missing
        parameters and return values.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 9 Jan 2009 18:47:37 +0000 (18:47 +0000)]
2009-01-09  Sam Weinig  <sam@webkit.org>

        Roll r39720 back in with a working interpreted mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 9 Jan 2009 18:46:51 +0000 (18:46 +0000)]
2009-01-09  Peter Kasting  <pkasting@google.com>

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=22995
        Fix flaky image animation by resetting the metadata for a frame when
        we get new data for that frame.  This fixes animations that halted
        when the next frame of the animation wasn't complete by the time the
        current frame's duration expired.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::destroyDecodedData):
        (WebCore::BitmapImage::dataChanged):
        * platform/graphics/BitmapImage.h:
        (WebCore::FrameData::~FrameData):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::FrameData::clear):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::FrameData::clear):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::FrameData::clear):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::FrameData::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWhoops, include actual file the the forwarding headers point to.
oliver@apple.com [Fri, 9 Jan 2009 18:28:48 +0000 (18:28 +0000)]
Whoops, include actual file the the forwarding headers point to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 9 Jan 2009 17:58:50 +0000 (17:58 +0000)]
2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Swap the .h and the .cpp output in the Qt build for the
        UserAgentStyleSheetData files, to put the definition in the .cpp file
        and the declaration in the header file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoinclude files missed in last commit.
oliver@apple.com [Fri, 9 Jan 2009 17:54:28 +0000 (17:54 +0000)]
include files missed in last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 David Levin <levin@chromium.org>
oliver@apple.com [Fri, 9 Jan 2009 17:53:36 +0000 (17:53 +0000)]
2009-01-09  David Levin  <levin@chromium.org>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=23175

        Added a template to make the pointer and flags combination
        in UString more readable and less error prone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 9 Jan 2009 17:47:24 +0000 (17:47 +0000)]
2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by Tor Arne Vestbø.

        Fix linking against QtWebKit on Windows, by defining the EXPORT macros
        _exactly_ the same way as in qglobal.h, depending on QT_NODLL,
        QT_MAKEDLL and QT_SHARED.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Fri, 9 Jan 2009 16:51:49 +0000 (16:51 +0000)]
2009-01-09  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon Hausmann.

        Prevent qmake from generating duplicate rules for embedded stylesheets

        The STYLESHEETS_EMBED variable used to contain only one file name, but
        now that it is a list of files we need to change it to be a dependency
        for the stylesheet generator instead of the input.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Fri, 9 Jan 2009 13:03:00 +0000 (13:03 +0000)]
WebCore:
    2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Fix qmake warning about missing test function, a contains() call was
            missing.

WebKit/qt:
    2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

            Reviewed by Tor Arne Vestbø.

            Remove qwebnetworkinterface.h from WEBKIT_API_HEADERS as it's not
            public Qt 4.4/4.5 API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=23165
ap@webkit.org [Fri, 9 Jan 2009 12:32:08 +0000 (12:32 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=23165

        * fast/dom/Window/window-properties-expected.txt: Forgot to commit this with r39699, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 9 Jan 2009 12:16:44 +0000 (12:16 +0000)]
2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Unreviewed Qt build fix, remove qcookiejar.h from the API headers and
        therefore HEADERS. It's not part of the API and it moc shouldn't be
        called on it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Fri, 9 Jan 2009 11:10:47 +0000 (11:10 +0000)]
2009-01-09  Simon Hausmann  <simon.hausmann@nokia.com>

        Rubber-stamped by Tor Arne Vestbø.

        Add the Qt API headers to HEADERS, too, for improved completion in IDEs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-09 David Levin <levin@chromium.org>
ap@webkit.org [Fri, 9 Jan 2009 09:42:20 +0000 (09:42 +0000)]
2009-01-09  David Levin  <levin@chromium.org>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=23199

        Fix deref's of string happening on two different threads.

        No observable change in behavior, so no test.  However, there are asserts
        being added for https://bugs.webkit.org/show_bug.cgi?id=23175 which
        will detect this issue while running the normal worker tests.

        * dom/WorkerThread.cpp:
        (WebCore::WorkerThreadStartupData::create):
        (WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
        (WebCore::WorkerThread::WorkerThread):
        (WebCore::WorkerThread::workerThread):
        * dom/WorkerThread.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 9 Jan 2009 08:12:56 +0000 (08:12 +0000)]
2009-01-08  Gavin Barraclough  <barraclough@apple.com>

        RS by Oliver Hunt.

        Looks like this should have been updated with r39699.

        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Fri, 9 Jan 2009 08:11:00 +0000 (08:11 +0000)]
2009-01-08  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Encode immediates in the low word of JSValuePtrs, on x86-64.

        On 32-bit platforms a JSValuePtr may represent a 31-bit signed integer.
        On 64-bit platforms, if USE(ALTERNATE_JSIMMEDIATE) is defined, a full
        32-bit integer may be stored in an immediate.

        Presently USE(ALTERNATE_JSIMMEDIATE) uses the same encoding as the default
        immediate format - the value is left shifted by one, so a one bit tag can
        be added to indicate the value is an immediate.  However this means that
        values must be commonly be detagged (by right shifting by one) before
        arithmetic operations can be performed on immediates.  This patch modifies
        the formattting so the the high bits of the immediate mark values as being
        integer.

        * assembler/MacroAssembler.h:
        (JSC::MacroAssembler::not32):
        (JSC::MacroAssembler::orPtr):
        (JSC::MacroAssembler::zeroExtend32ToPtr):
        (JSC::MacroAssembler::jaePtr):
        (JSC::MacroAssembler::jbPtr):
        (JSC::MacroAssembler::jnzPtr):
        (JSC::MacroAssembler::jzPtr):
        * assembler/X86Assembler.h:
        (JSC::X86Assembler::):
        (JSC::X86Assembler::notl_r):
        (JSC::X86Assembler::testq_i32r):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompileMainPass):
        (JSC::JIT::privateCompileSlowCases):
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        * jit/JIT.h:
        * jit/JITArithmetic.cpp:
        (JSC::JIT::compileFastArith_op_lshift):
        (JSC::JIT::compileFastArith_op_rshift):
        (JSC::JIT::compileFastArith_op_bitand):
        (JSC::JIT::compileFastArithSlow_op_bitand):
        (JSC::JIT::compileFastArith_op_mod):
        (JSC::JIT::compileFastArithSlow_op_mod):
        (JSC::JIT::compileFastArith_op_add):
        (JSC::JIT::compileFastArith_op_mul):
        (JSC::JIT::compileFastArith_op_post_inc):
        (JSC::JIT::compileFastArith_op_post_dec):
        (JSC::JIT::compileFastArith_op_pre_inc):
        (JSC::JIT::compileFastArith_op_pre_dec):
        (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate):
        (JSC::JIT::compileBinaryArithOp):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitJumpIfJSCell):
        (JSC::JIT::emitJumpIfNotJSCell):
        (JSC::JIT::emitJumpIfImmNum):
        (JSC::JIT::emitJumpSlowCaseIfNotImmNum):
        (JSC::JIT::emitJumpSlowCaseIfNotImmNums):
        (JSC::JIT::emitFastArithDeTagImmediate):
        (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero):
        (JSC::JIT::emitFastArithReTagImmediate):
        (JSC::JIT::emitFastArithImmToInt):
        (JSC::JIT::emitFastArithIntToImmNoCheck):
        (JSC::JIT::emitTagAsBoolImmediate):
        * jit/JITPropertyAccess.cpp:
        (JSC::resizePropertyStorage):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdSelf):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::privateCompilePutByIdReplace):
        * runtime/JSImmediate.h:
        (JSC::JSImmediate::isNumber):
        (JSC::JSImmediate::isPositiveNumber):
        (JSC::JSImmediate::areBothImmediateNumbers):
        (JSC::JSImmediate::xorImmediateNumbers):
        (JSC::JSImmediate::rightShiftImmediateNumbers):
        (JSC::JSImmediate::canDoFastAdditiveOperations):
        (JSC::JSImmediate::addImmediateNumbers):
        (JSC::JSImmediate::subImmediateNumbers):
        (JSC::JSImmediate::makeInt):
        (JSC::JSImmediate::toBoolean):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 9 Jan 2009 05:41:01 +0000 (05:41 +0000)]
2009-01-08  Sam Weinig  <sam@webkit.org>

        Revert r39720. It broke Interpreted mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 9 Jan 2009 03:45:20 +0000 (03:45 +0000)]
WebCore:

        Reviewed by Adam Roben.

        - use native glyph support in Core Graphics when available

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Changed to use drawGDIGlyphs() only if
        native glyph support is not available or stroking is required. Changed
        to pass the font's useGDI() flag to wkSetCGContextFontRenderingStyle to
        request the use of native glyphs.
        * platform/graphics/win/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData): Added a call to
        wkSetFontPlatformInfo to attach the LOGFONT to the CGFont.
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::platformDataInit): Ditto.

WebKit/win:

        Reviewed by Adam Roben.

        - WebPreferences changes to support Core Graphics native glyph drawing

        * Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast
        getter and setter.
        * WebPreferenceKeysPrivate.h: Added
        WebKitFontSmoothingContrastPreferenceKey.
        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings): Initialized
        WebKitFontSmoothingContrastPreferenceKey to 2.
        (WebPreferences::setFloatValue): Added.
        (WebPreferences::setFontSmoothing): Changed to map
        FontSmoothingTypeWindows to FontSmoothingTypeMedium.
        (WebPreferences::fontSmoothingContrast): Added.
        (WebPreferences::setFontSmoothingContrast): Added. Calls
        wkSetFontSmoothingContrast().
        * WebPreferences.h:

WebKitLibraries:

        Reviewed by Adam Roben.

        - WebKitSystemInterface changes to support Core Graphics native glyph drawing

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving...
sfalken@apple.com [Fri, 9 Jan 2009 03:12:49 +0000 (03:12 +0000)]
    <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?

        Reviewed by Adam Roben.

        * WebView.cpp:
        (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Peter Kasting <pkasting@google.com>
pkasting@chromium.org [Fri, 9 Jan 2009 01:51:48 +0000 (01:51 +0000)]
2009-01-08  Peter Kasting  <pkasting@google.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=22929
        Fix memory regression when decoding large animated GIFs.

        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-01-08 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 9 Jan 2009 01:41:53 +0000 (01:41 +0000)]
2009-01-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement WKPCGetStringIdentifier.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetStringIdentifier):
        * Plugins/Hosted/WebKitPluginClient.defs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect my changelog error.
eric@webkit.org [Fri, 9 Jan 2009 01:36:19 +0000 (01:36 +0000)]
Correct my changelog error.

2009-01-08  Scott Violet  <sky@chromium.org>

        Reviewed by Eric Seidel (and Adam Barth).

        Fix Images to return their file extension
        http://code.google.com/p/chromium/issues/detail?id=5827

        * platform/graphics/skia/ImageSourceSkia.cpp:
        (WebCore::ImageSource::filenameExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39732 268f45cc-cd09-0410-ab3c-d52691b4dbfc