WebKit-https.git
9 years ago[WinCairo] Unreviewed build change.
bfulgham@webkit.org [Sun, 24 Apr 2011 06:22:37 +0000 (06:22 +0000)]
[WinCairo] Unreviewed build change.

Activate Geolocation API, as it will work with WinCairo assuming
an appropriate Geolocation Provider is registered.

* win/tools/vsprops/FeatureDefinesCairo.vsprops: Activate the
  Geolocation features.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 24 Apr 2011 06:01:47 +0000 (06:01 +0000)]
2011-04-23  Simon Fraser  <simon.fraser@apple.com>

        Fix Windows build, which complains about unreachable code.

        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
        (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
        (WebCore::ScrollableArea::hasLayerForScrollCorner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 24 Apr 2011 05:53:06 +0000 (05:53 +0000)]
2011-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Area under composited scrollbars not repainted in WebKit2 on scrolling
        https://bugs.webkit.org/show_bug.cgi?id=59294
        <rdar://problem/9299062>

        When computing the rect that can be copied on scrolling, we normally
        exclude the areas occupied by overlay scrollbars to avoid smeared scrollbars;
        the assumption is that other code will repaint these areas. However, when
        scrollbars are in their own compositing layers, we can, and should
        copy the entire area.

        Not testable in DRT because it does not allow tests to use overlay scrollbars.

        * platform/ScrollView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::rectToCopyOnScroll):
        New method, with code moved from scrollContents and fixed to look
        for scrollbars in layers.
        (WebCore::ScrollView::scrollContents):
        Call rectToCopyOnScroll().

        * platform/ScrollableArea.h:
        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::hasLayerForHorizontalScrollbar):
        (WebCore::ScrollableArea::hasLayerForVerticalScrollbar):
        (WebCore::ScrollableArea::hasLayerForScrollCorner):
        Methods we can call outside of the ACCELERATED_COMPOSITING #ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 24 Apr 2011 03:59:21 +0000 (03:59 +0000)]
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebCore.exp.in:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * platform/ScrollTypes.h:
        * platform/ScrollableArea.h:
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):
2011-04-23  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84740.
        http://trac.webkit.org/changeset/84740
        https://bugs.webkit.org/show_bug.cgi?id=59290

        change breaks apple internal builds and is incorrect
        (Requested by smfr on #webkit).

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
mitz@apple.com [Sun, 24 Apr 2011 03:56:07 +0000 (03:56 +0000)]
<rdar://problem/8970549> WebFindOptionsAtWordStarts fails with Japanese words
https://bugs.webkit.org/show_bug.cgi?id=59288

Reviewed by Simon Fraser.

Source/WebCore:

* platform/text/mac/TextBoundaries.mm:
(WebCore::wordStringTokenizer): Added this helper function.
(WebCore::findNextWordFromIndex): Changed to use a CFStringTokenizer with kCFStringTokenizerUnitWord,
whose behavior is not locale-dependent.

LayoutTests:

* editing/text-iterator/findString-expected.txt:
* editing/text-iterator/findString.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 Dominic Cooney <dominicc@chromium.org>
morrita@google.com [Sun, 24 Apr 2011 01:31:23 +0000 (01:31 +0000)]
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        * fast/dom/shadow/gc-shadow-expected.txt: Added.
        * fast/dom/shadow/gc-shadow.html: Added.
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        Test: fast/dom/shadow/gc-shadow.html

        * bindings/v8/V8GCController.cpp:
        (WebCore::calculateGroupId): group shadow nodes with their hosts
2011-04-23  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
        https://bugs.webkit.org/show_bug.cgi?id=59284

        Chromium DRT over-refcounted the NPObject wrappers it used to
        marshal shadowRoot nodes back to tests (WebBindings::makeNode
        births NPObjects with referenceCount == 1). This masked the GC bug
        59284 in tests by making shadowRoot nodes live forever.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::shadowRoot):
        (LayoutTestController::ensureShadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:
barraclough@apple.com [Sun, 24 Apr 2011 01:05:59 +0000 (01:05 +0000)]
Bug 59287 - DFG JIT - Handle temporaries as vars, allowing support for ?:

Reviewed by Oliver Hunt.

SetLocals to temporaries will only be generated if they are used within other
blocks, due to the SSA based DCE.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Sun, 24 Apr 2011 00:51:54 +0000 (00:51 +0000)]
2011-04-23  MORITA Hajime <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] NodeRenderParentDetector should be NodeRenderFactory
        https://bugs.webkit.org/show_bug.cgi?id=59280

        - Rename NodeRenderParentDetector to NodeRendererFactory
        - move createRendererAndStyle() and createRendererIfNeeded to
          NodeRendererFactory

        No new test, no behavioral change.

        * dom/Node.cpp:
        (WebCore::NodeRendererFactory::NodeRendererFactory):
        (WebCore::NodeRendererFactory::document):
        (WebCore::NodeRendererFactory::nextRenderer):
        (WebCore::NodeRendererFactory::findVisualParent):
        (WebCore::NodeRendererFactory::shouldCreateRenderer):
        (WebCore::NodeRendererFactory::createRendererAndStyle):
        (WebCore::NodeRendererFactory::createRendererIfNeeded):
        (WebCore::Node::parentNodeForRenderingAndStyle):
        (WebCore::Node::createRendererIfNeeded):
        * dom/Node.h:
        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsSummaryElement::detailsElement): Added const_cast due to the chage on parentNodeForRenderingAndStyle()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Sun, 24 Apr 2011 00:17:52 +0000 (00:17 +0000)]
2011-04-23  MORITA Hajime <morrita@google.com>

        Unreviewed test_expectations.txt update.
        r84745 didn't fix meter-element.html break on chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Sat, 23 Apr 2011 23:16:23 +0000 (23:16 +0000)]
2011-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
        https://bugs.webkit.org/show_bug.cgi?id=59281

        * fast/dom/HTMLMeterElement/meter-writing-mode.html: Added.
        * fast/dom/HTMLProgressElement/progress-writing-mode.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
        * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
        * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
2011-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        REGRESSION: (non-Mac) <meter>'s bar part isn't rendered for with -webkit-writing-mode: vertical-lr from r82899
        https://bugs.webkit.org/show_bug.cgi?id=59281

        Styles for -webkit-meter-bar and -webkit-progress-bar missed width property, which caused unexpected layout results
        for vertical writing modes. This fix added a width property for each of them.

        Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
               fast/dom/HTMLProgressElement/progress-writing-mode.html

        * css/html.css:
        (meter::-webkit-meter-bar):
        (progress::-webkit-progress-bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59266 - DFG JIT - Add SSA style DCE
barraclough@apple.com [Sat, 23 Apr 2011 20:16:10 +0000 (20:16 +0000)]
Bug 59266 - DFG JIT - Add SSA style DCE

Reviewed by Sam Weinig & Geoff Garen.

This works by making GetLocal nodes reference SetLocal nodes from prior blocks,
via intermediate Phi nodes. Whenever we add a GetLocal to the graph, also add a
matching child Phi, and add the Phi to a work queue to add references to prior
definitions once we have the full CFG & can determine predecessors. This process
is iterative, inserting new phis into predecessors as necessary.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processWorkQueue):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::refChildren):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
* dfg/DFGNode.h:
(JSC::DFG::Node::ref):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::~ScoreBoard):
(JSC::DFG::ScoreBoard::dump):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Unreviewed build fixes for recent trunk changes.
kevino@webkit.org [Sat, 23 Apr 2011 20:05:34 +0000 (20:05 +0000)]
[wx] Unreviewed build fixes for recent trunk changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-23 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 23 Apr 2011 19:14:05 +0000 (19:14 +0000)]
2011-04-23  Alexey Proskuryakov  <ap@apple.com>

        Unreviewed.

        REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59241
        <rdar://problem/9150861>

        * http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
        * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
        Resource load delegates for cancelled loads are now correctly sent before frame load
        delegate's didFinishLoading, so cancellation errors get logged by DumpRenderTree.
2011-04-23  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION (r80812): window.print();window.close() doesn't work in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59241
        <rdar://problem/9150861>

        Covered by manual-tests/print-after-window-close.html.

        Re-fixing <https://bugs.webkit.org/show_bug.cgi?id=51357> in a way that doesn't cause the
        regression.

        * loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::didCancel): We shouldn't be
        doing complicated work while the loader is half-canceled.

        * manual-tests/print-after-window-close.html: Extended to actually print a non-empty page,
        thus being more practical.

        * page/Chrome.cpp: (WebCore::Chrome::print): Added a FIXME about a need for PageGroupLoadDeferrer.
        It's too scary for me to try now.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::finishedLoading):
        * page/DOMWindow.h:
        Reverted the previous fix for <https://bugs.webkit.org/show_bug.cgi?id=51357>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Sat, 23 Apr 2011 07:11:38 +0000 (07:11 +0000)]
2011-04-19  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        [V8] Use implicit references for V8 listeners on DOM nodes.
        https://bugs.webkit.org/show_bug.cgi?id=58953

        Instead of allocating an auxiliary V8 array referencing V8
        listener objects associated with a DOM node and using an extra
        pointer in every DOM node wrapper, we can register implicit
        references between nodes and their listeners during GC. This also
        makes V8 bindings more aligned with JSC bindings.

        No new tests because this is a refactoring.

        * bindings/scripts/CodeGeneratorV8.pm: Stopped generating the
        listener cache internal field for DOM nodes.
        * bindings/v8/V8AbstractEventListener.h: Exposed the lister handle
        to the GC.
        (WebCore::V8AbstractEventListener::existingListenerObjectPeristentHandle):
        * bindings/v8/V8GCController.cpp: Started using implicit references.
        (WebCore::GrouperVisitor::visitDOMWrapper):
        * dom/EventTarget.h: Implemented an iterator over all listeners.
        (WebCore::EventListenerIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Sat, 23 Apr 2011 06:22:59 +0000 (06:22 +0000)]
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebCore.exp.in: adding method to allow changing style
        * page/FrameView.cpp:
        (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
        * page/FrameView.h:
        * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
        * platform/ScrollableArea.cpp:
        (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
        * platform/ScrollableArea.h:
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-22  Jon Lee  <jonlee@apple.com>

        Reviewed by Beth Dakin.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Chris Evans <cevans@chromium.org>
commit-queue@webkit.org [Sat, 23 Apr 2011 05:55:32 +0000 (05:55 +0000)]
2011-04-22  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Upgrade CSS loads from mixed content warning (displayed) to mixed
        content error (ran)
        https://bugs.webkit.org/show_bug.cgi?id=59056

        * http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-iframe.html: Update expectation.
        * http/tests/security/mixedContent/insecure-css-in-main-frame.html: Update expectation.
        * http/tests/security/mixedContent/resources/frame-with-insecure-css.html: Fix typo.
2011-04-22  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Upgrade CSS loads from mixed content warning (displayed) to mixed
        content error (ran)
        https://bugs.webkit.org/show_bug.cgi?id=59056

        Test: http/tests/security/mixedContent/insecure-css-in-iframe.html
        Test: http/tests/security/mixedContent/insecure-css-in-main-frame.html

        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest): CSS loads are running rather than displaying content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect...
ossy@webkit.org [Sat, 23 Apr 2011 05:09:09 +0000 (05:09 +0000)]
[Qt][WK2] Add some failing tests to the Skipped list because of a WTR sideeffect bug.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed an upside-down conditional in my last check-in.
ggaren@apple.com [Sat, 23 Apr 2011 04:44:11 +0000 (04:44 +0000)]
Fixed an upside-down conditional in my last check-in.

* bindings/js/JSDOMApplicationCacheCustom.cpp:
(WebCore::isObservable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 23 Apr 2011 04:41:54 +0000 (04:41 +0000)]
2011-04-22  Geoffrey Garen  <ggaren@apple.com>

        Rolled back in r84725 and r84728 with appcache crash fixed.

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: DOMWindow
        https://bugs.webkit.org/show_bug.cgi?id=59260

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
        we use the opaque roots system now.

        * bindings/js/JSNavigatorCustom.cpp: Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
        whose opaque roots are frames.

        * css/StyleMedia.h:
        (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.

        * css/StyleMedia.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * page/BarInfo.idl:
        * page/Console.idl:
        * page/DOMSelection.idl:
        * page/Geolocation.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.idl:
        * page/Screen.idl:
        * storage/Storage.idl: Updated to use the opaque roots system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unskip a bunch of passing tests and update their expected files.
ossy@webkit.org [Sat, 23 Apr 2011 04:37:37 +0000 (04:37 +0000)]
[Qt] Unskip a bunch of passing tests and update their expected files.
This patch based on work of Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>

* platform/qt/Skipped:
* platform/qt/fast/[...]: Added, updated.
* platform/qt/scrollbars/[...]: Added, updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 23 Apr 2011 03:41:53 +0000 (03:41 +0000)]
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * Source/WebKit.pro:
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * QtWebKit.pro:
        * symbian/platformplugin/WebPlugin.cpp: Removed.
        * symbian/platformplugin/WebPlugin.h: Removed.
        * symbian/platformplugin/platformplugin.pro: Removed.
        * symbian/platformplugin/qwebkitplatformplugin.h: Removed.
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84627.
        http://trac.webkit.org/changeset/84627
        https://bugs.webkit.org/show_bug.cgi?id=59271

        It broke Symbian build (Requested by Ossy on #webkit).

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 23 Apr 2011 03:22:19 +0000 (03:22 +0000)]
2011-04-22  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - clean up some flakiness.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Sat, 23 Apr 2011 03:20:07 +0000 (03:20 +0000)]
2011-04-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Don't use XMLTreeViewer when script is disabled (it uses Javascript
        to build a prettified version of the xml document).
        https://bugs.webkit.org/show_bug.cgi?id=59113

        * xml/XMLTreeViewer.cpp:
        (WebCore::XMLTreeViewer::transformDocumentToTreeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
ossy@webkit.org [Sat, 23 Apr 2011 03:17:49 +0000 (03:17 +0000)]
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84725 and r84728.
        http://trac.webkit.org/changeset/84725
        http://trac.webkit.org/changeset/84728
        https://bugs.webkit.org/show_bug.cgi?id=59270

        It broke http/tests/appcache tests (Requested by Ossy on
        #webkit).

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren):
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::visitChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        * css/StyleMedia.h:
        * css/StyleMedia.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * page/BarInfo.idl:
        * page/Console.idl:
        * page/DOMSelection.idl:
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalScreen):
        (WebCore::DOMWindow::optionalSelection):
        (WebCore::DOMWindow::optionalHistory):
        (WebCore::DOMWindow::optionalCrypto):
        (WebCore::DOMWindow::optionalLocationbar):
        (WebCore::DOMWindow::optionalMenubar):
        (WebCore::DOMWindow::optionalPersonalbar):
        (WebCore::DOMWindow::optionalScrollbars):
        (WebCore::DOMWindow::optionalStatusbar):
        (WebCore::DOMWindow::optionalToolbar):
        (WebCore::DOMWindow::optionalConsole):
        (WebCore::DOMWindow::optionalNavigator):
        (WebCore::DOMWindow::optionalLocation):
        (WebCore::DOMWindow::optionalMedia):
        (WebCore::DOMWindow::optionalSessionStorage):
        (WebCore::DOMWindow::optionalLocalStorage):
        (WebCore::DOMWindow::optionalPerformance):
        * page/Geolocation.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.h:
        (WebCore::Navigator::optionalGeolocation):
        * page/Navigator.idl:
        * page/Screen.idl:
        * storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 23 Apr 2011 03:17:41 +0000 (03:17 +0000)]
2011-04-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        rebaseline-chromium-webkit-tests: clean up output
        https://bugs.webkit.org/show_bug.cgi?id=59240

        This change dramatically changes the output the tool provides
        by default. The previous output (more or less) is still there
        in -v / verbose / debug mode, but the default output is
        way terser and more readable. It mostly says which files are
        updated, which are duplicates, and which are not found in an
        archive. Feedback desired :).

        This change also adds a scm.exists() method to the SCM object
        so that we can cleanly figure out what we're doing while
        rebaselining.

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 23 Apr 2011 03:09:13 +0000 (03:09 +0000)]
2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Change SVG-related shadow root checks to use isSVGShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=59237

        Covered by existing tests, no behavior change.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): Use isSVGShadowRoot.
        * svg/SVGUseElement.cpp:
        (WebCore::ShadowTreeUpdateBlocker::while): Ditto.
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::insertedIntoDocument): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix.
ggaren@apple.com [Sat, 23 Apr 2011 02:22:57 +0000 (02:22 +0000)]
Mac build fix.

* page/DOMWindow.h:
(WebCore::DOMWindow::optionalApplicationCache): Restored this function,
which is used after all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Sat, 23 Apr 2011 02:19:49 +0000 (02:19 +0000)]
2011-04-22  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Add Ilya Sherman (isherman@chromium.org) to the list of contributors
        https://bugs.webkit.org/show_bug.cgi?id=59231

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Sat, 23 Apr 2011 02:16:33 +0000 (02:16 +0000)]
2011-04-22  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        don't white-space:nowrap the results iframes
        https://bugs.webkit.org/show_bug.cgi?id=59259

        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 23 Apr 2011 02:09:10 +0000 (02:09 +0000)]
2011-04-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: DOMWindow
        https://bugs.webkit.org/show_bug.cgi?id=59260

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren): No need to mark explicitly, since
        we use the opaque roots system now.

        * bindings/js/JSNavigatorCustom.cpp: Ditto.

        * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration for objects
        whose opaque roots are frames.

        * css/StyleMedia.h:
        (WebCore::StyleMedia::frame): Added an accessor for the sake of GC.

        * css/StyleMedia.idl:
        * loader/appcache/DOMApplicationCache.idl:
        * page/BarInfo.idl:
        * page/Console.idl:
        * page/DOMSelection.idl:
        * page/Geolocation.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.idl:
        * page/Screen.idl:
        * storage/Storage.idl: Updated to use the opaque roots system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 23 Apr 2011 02:05:23 +0000 (02:05 +0000)]
2011-04-22  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Roll in deps bots failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Stop responsiveness timer before calling runOpenPanel
bweinstein@apple.com [Sat, 23 Apr 2011 02:03:20 +0000 (02:03 +0000)]
WebKit2: Stop responsiveness timer before calling runOpenPanel
https://bugs.webkit.org/show_bug.cgi?id=59268
<rdar://problem/9327944>

Reviewed by Sam Weinig.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel): Stop the timer before calling WebUIClient::runOpenPanel,
    because runOpenPanel can spin a nested run loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Sat, 23 Apr 2011 01:48:52 +0000 (01:48 +0000)]
2011-04-22  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: Exception raised when stderr contains binary data
        https://bugs.webkit.org/show_bug.cgi?id=59083

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        Use write_binary_file() instead of write_text_file().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Sat, 23 Apr 2011 01:14:15 +0000 (01:14 +0000)]
2011-04-22  Chang Shu  <cshu@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42536

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-22  Chang Shu  <cshu@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42536

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleSetFrameFlatteningEnabled):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setFrameFlatteningEnabled):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-22  Chang Shu  <cshu@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
        https://bugs.webkit.org/show_bug.cgi?id=42536

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::setFrameFlatteningEnabled):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 23 Apr 2011 01:09:28 +0000 (01:09 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        [QT] move-by-word-visually.html failed in QT.
        https://bugs.webkit.org/show_bug.cgi?id=59265

        Temporarily skip the test in QT while investigating.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 23 Apr 2011 01:03:44 +0000 (01:03 +0000)]
2011-04-22  Alejandro G. Castro  <alex@igalia.com>

        Undo rebaseline done in r84677 for this test, it was a flaky
        execution.

        * platform/gtk/media/video-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Sat, 23 Apr 2011 00:59:28 +0000 (00:59 +0000)]
2011-04-22  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        Add missing default constructors for HashMap iterator specializations.
        https://bugs.webkit.org/show_bug.cgi?id=59250

        * wtf/HashIterators.h:
        * wtf/HashTable.h:
        (WTF::HashTableConstIterator::HashTableConstIterator): Added cast
        to help compiler find the function template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59262 - DFG JIT - reduce size of VariableRecord
barraclough@apple.com [Sat, 23 Apr 2011 00:54:37 +0000 (00:54 +0000)]
Bug 59262 - DFG JIT - reduce size of VariableRecord

Reviewed by Sam Weinig.

We never need both the get & set node, only the most recent
(which is always a set, if both exist).

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Sat, 23 Apr 2011 00:39:53 +0000 (00:39 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed: Updated bug ID for geolocation skipped cases
mahesh.kulkarni@nokia.com [Sat, 23 Apr 2011 00:37:23 +0000 (00:37 +0000)]
Unreviewed: Updated bug ID for geolocation skipped cases

* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoroll out incorrect versioning info (included extra file).
lforschler@apple.com [Sat, 23 Apr 2011 00:34:56 +0000 (00:34 +0000)]
roll out incorrect versioning info (included extra file).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 23 Apr 2011 00:30:54 +0000 (00:30 +0000)]
2011-04-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=58976

        * platform/gtk/Skipped: Unskip a test which is no longer crashing.
2011-04-22  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/events/overflow-viewport-renderer-deleted.html crashes
        https://bugs.webkit.org/show_bug.cgi?id=58976

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::getInnerText): Guard against situations when the documentElement
        method of the document returns null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Alejandro G. Castro <alex@igalia.com> and Martin Robinson <mrobinson...
mrobinson@webkit.org [Sat, 23 Apr 2011 00:25:55 +0000 (00:25 +0000)]
2011-04-22  Alejandro G. Castro  <alex@igalia.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Use the libWebCore.a convenience library when compiling WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59258

        * GNUmakefile.am: Remove the libWebKit2 convenience library and use the
        libWebCore convenience library when compiling WebKit2. Not only does this
        maintain the CPPFLAGS isolation, it prevents double-compilation of WebCore
        in some cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Sat, 23 Apr 2011 00:23:45 +0000 (00:23 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 23 Apr 2011 00:12:23 +0000 (00:12 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move caret by word in visual order returns wrong result when caret itself is at word boundary.
        https://bugs.webkit.org/show_bug.cgi?id=58504.

        Add test case to test moving left/right by word visually on every character position.
        Remove a specific test added before for testing a specific code path since the test case
        is covered now.

        * editing/selection/move-by-word-visually-expected.txt:
        * editing/selection/move-by-word-visually.html:
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        move caret by word in visual order returns wrong result when caret itself is at word boundary.
        https://bugs.webkit.org/show_bug.cgi?id=58504.

        positionBeforeNextWord should take care that the current position is after current word.
        positionAfterPreviousWord should take care that the current positin is before current word.

        * editing/visible_units.cpp:
        (WebCore::positionBeforeNextWord):
        (WebCore::positionAfterPreviousWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 23 Apr 2011 00:08:31 +0000 (00:08 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebaseline after r84655.

        * platform/chromium-linux/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 23:59:05 +0000 (23:59 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebase after r84659.

        * platform/chromium-linux/editing/deleting/table-cells-expected.png:
        * platform/chromium-linux/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-mac-leopard/editing/deleting/table-cells-expected.png:
        * platform/chromium-mac-leopard/fast/inline-block/14498-positionForCoordinates-expected.png:
        * platform/chromium-mac/editing/deleting/table-cells-expected.png: Added.
        * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.png: Added.
        * platform/chromium-win/editing/deleting/table-cells-expected.png:
        * platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 23:54:22 +0000 (23:54 +0000)]
2011-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Eric Carlson.

        Flaky Test: media/invalid-media-url-crash.html
        https://bugs.webkit.org/show_bug.cgi?id=51138

        Add one more test to the list of known crashers from rdar://9054715.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-19 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 23:52:44 +0000 (23:52 +0000)]
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        * fullscreen/full-screen-frameset-expected.txt: Added.
        * fullscreen/full-screen-frameset.html: Added.
        * fullscreen/content/inner.html: Added.
        * fullscreen/full-screen-iframe-allowed-expected.txt: Updated.
        * fullscreen/full-screen-iframe-allowed.html: Add a button with which to trigger
            full screen mode in Safari.
        * fullscreen/full-screen-iframe-not-allowed-expected.txt: Updated.
        * fullscreen/full-screen-iframe-not-allowed.html: Ditto.
        * fullscreen/resources/allowed.html: Added.
        * fullscreen/resources/inner.html: Added.
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Add the
            -webkit-full-screen pseudo class to frame elements which contain
            full screen elements.
        * css/fullscreen.css:
        (iframe:-webkit-full-screen): Add iframe-specific styling rules.
        * dom/Document.cpp:
        (WebCore::Document::setContainsFullScreenElementRecursively): Added.  Walk up each
            successive document owner element, calling setContainsFullScreenElement() if
            owner is a frame element.
        (WebCore::Document::fullScreenIsAllowedForElement): Use the new Element::isFrameElementBase
            call instead of checking the element's tag name.
        (WebCore::Document::webkitWillEnterFullScreenForElement): Mark any containing
            iframes as containing a full screen element.
        (WebCore::Document::webkitWillExitFullScreenForElement): Ditto.
        * dom/Element.h:
        (WebCore::Element::isFrameElementBase): Added.
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::allowFullScreen): Disable full screen from within
            HTMLFrameElements.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Added.
        * html/HTMLFrameElementBase.h:
        (WebCore::HTMLFrameElementBase::containsFullScreenElement): Added.
        (WebCore::HTMLFrameElementBase::isFrameElementBase): Added.
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset-allowed.html
               fullscreen/full-screen-frameset-not-allowed.html

        Return the _element's document instead of the WKView's document, which
        will be different in the case of elements within <iframe>s.

        * WebView/WebFullScreenController.mm:
        (-[WebFullScreenController _document]):
2011-04-19  Jer Noble  <jer.noble@apple.com>

        Reviewed by Daniel Bates.

        Full Screen from within an <iframe> does not cause <iframe> to resize.
        https://bugs.webkit.org/show_bug.cgi?id=58638

        Tests: fullscreen/full-screen-frameset-allowed.html
               fullscreen/full-screen-frameset-not-allowed.html

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Cancel the background animation
            if the full screen animation finishes first.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::WebFullScreenManagerMac): m_fullScreenRootLayer was uninitialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
barraclough@apple.com [Fri, 22 Apr 2011 23:38:53 +0000 (23:38 +0000)]
Bug 59254 - DFG JIT - retain VariableRecords for args/var in all basic blocks,
such that this information is available for DCE.  Also, since this enlarges the
size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a
vector of blocks.

Reviewed by Geoffrey Garen.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getVariable):
(JSC::DFG::ByteCodeParser::setVariable):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::VariableRecord::VariableRecord):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::getBytecodeBegin):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 23:35:44 +0000 (23:35 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CommitQueue should remember the expected failures from patch to patch
        https://bugs.webkit.org/show_bug.cgi?id=59253

        Previously, we stored the set of expected failures on the task object,
        which meant the commit-queue forgot about them after each patch.  This
        patch moves them to the CommitQueue object so they will have a longer
        lifetime.

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 23:29:02 +0000 (23:29 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Brian Weinstein.

        WebKit2: Implement JavaScript unresponsiveness timer/callbacks
        https://bugs.webkit.org/show_bug.cgi?id=59248

        Stub out shouldInterruptJavaScript callbacks.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Brian Weinstein.

        WebKit2: Implement JavaScript unresponsiveness callback
        https://bugs.webkit.org/show_bug.cgi?id=59248

        Add support for suspending JavaScript in response to a callback.

        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::shouldInterruptJavaScript):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::shouldInterruptJavaScript):
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::shouldInterruptJavaScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Fri, 22 Apr 2011 23:11:45 +0000 (23:11 +0000)]
2011-04-22  Michael Saboff  <msaboff@apple.com>

        Reviewed by Maciej Stachowiak.

        Creating copy of ContainerNode's when inserting or removing is inefficient
        https://bugs.webkit.org/show_bug.cgi?id=58695

        Eliminated node copying in willRemove() and insertedIntoDocument().

        No new tests as this is a more efficient implementation of
        existing code that is covered by existing tests.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::willRemove): Changed method to use
        RefPtr<> to protect against modification during removal.
        (WebCore::ContainerNode::insertedIntoDocument): Changed method to use
        RefPtr<> and two other deletion checks to protect against
        modification during insertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoErrk, build fix.
barraclough@apple.com [Fri, 22 Apr 2011 23:09:12 +0000 (23:09 +0000)]
Errk, build fix.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 22 Apr 2011 23:04:12 +0000 (23:04 +0000)]
2011-04-22  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        We have an autogenerator, so use it
        https://bugs.webkit.org/show_bug.cgi?id=59247

        * bindings/js/JSCSSRuleCustom.cpp:
        * bindings/js/JSCSSRuleListCustom.cpp:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSCSSValueCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        * bindings/js/JSDOMImplementationCustom.cpp:
        * bindings/js/JSDOMStringMapCustom.cpp:
        * bindings/js/JSHTMLCollectionCustom.cpp:
        * bindings/js/JSNamedNodeMapCustom.cpp:
        * bindings/js/JSNodeCustom.h:
        * bindings/js/JSNodeListCustom.cpp:
        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/js/JSStyleSheetListCustom.cpp: Removed repetitive hand-written code.

        * bindings/scripts/CodeGeneratorJS.pm: Augmented autogenerator to do the job.

        * css/CSSRule.idl:
        * css/CSSRuleList.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSValue.idl:
        * css/MediaList.idl:
        * css/StyleSheet.idl:
        * css/StyleSheetList.idl:
        * dom/DOMImplementation.idl:
        * dom/DOMStringMap.idl:
        * dom/NamedNodeMap.idl:
        * dom/Node.idl:
        * dom/NodeList.idl:
        * html/DOMTokenList.idl:
        * html/HTMLCollection.idl:
        * html/canvas/CanvasRenderingContext.idl: Updated attributes to plug into
        the autogenerator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dan Bernstein <mitz@apple.com>
jer.noble@apple.com [Fri, 22 Apr 2011 23:01:04 +0000 (23:01 +0000)]
2011-04-22  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        Paint the bounding rect of the dirty region instead of individual rectangles when the region
        covers at least 3/4 of its bounds.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
        achieve this actually works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 22 Apr 2011 22:47:55 +0000 (22:47 +0000)]
2011-04-22  Daniel Bates  <dbates@webkit.org>

        Reviewed by Csaba Osztrogonác.

        webkit-patch land hangs if svn prompts for credentials
        https://bugs.webkit.org/show_bug.cgi?id=31500

        Make has_authorization_for_realm() return True only if there exists a credentials file
        that contains either the word "password" or "passtype". We assume that these words don't
        coincide with the actual credential data (e.g. a person's username is "password").

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
          - Added test cases:
            test_has_authorization_for_realm_using_credentials_with_passtype(),
            test_has_authorization_for_realm_using_credentials_with_password(),
            test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
          - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
            to better describe what it's testing.
          - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
            and return the result of calling has_authorization_for_realm() so that the caller can
            assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
            better reflect its new purpose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 22:45:39 +0000 (22:45 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Rebaseline after r84659.

        * platform/mac-wk2/fast/forms: Added.
        * platform/mac-wk2/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 22 Apr 2011 22:44:45 +0000 (22:44 +0000)]
2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Let the RenderTheme decide if an input type should have a spinner
        https://bugs.webkit.org/show_bug.cgi?id=59246

        Whether an input should have a spinner or not should
        be a UI decision made by the RenderTheme. Remove
        WebCore's default hasSpinButton values and defer
        to the RenderTheme.

        No change in functionality, covered by existing tests.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isRangeControl): expose isRangeControl
        for possible RenderTheme queries.
        * html/HTMLInputElement.h:

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):
        (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
        For both of these ask the render theme if the input should
        have a spinner.

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::shouldHaveSpinButtonForInputElement):
        Steppable inputs (number, date, and range) but not range
        should have spinners. This does not change existing behavior.
        * rendering/RenderTheme.h:

        * dom/InputElement.h:
        * html/BaseDateAndTimeInputType.cpp: remove hasSpinButton.
        * html/BaseDateAndTimeInputType.h: remove hasSpinButton.
        * html/InputType.cpp: remove hasSpinButton.
        * html/InputType.h: remove hasSpinButton.
        * html/NumberInputType.cpp: remove hasSpinButton.
        * html/NumberInputType.h: remove hasSpinButton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59223
bdakin@apple.com [Fri, 22 Apr 2011 22:42:50 +0000 (22:42 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page

Reviewed by Maciej Stachowiak.

Manual test added.
* manual-tests/frame-layout-on-back.html: Added.
* manual-tests/resources/empty-document-goes-back.html: Added.
* manual-tests/resources/simple-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Fri, 22 Apr 2011 22:36:46 +0000 (22:36 +0000)]
2011-04-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Sam Weinig.

        HTMLFormControlElement::labels should allow custom attributes.
        https://bugs.webkit.org/show_bug.cgi?id=59128

        * fast/forms/labels-custom-property-expected.txt: Added.
        * fast/forms/labels-custom-property.html: Added.
2011-04-22  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Sam Weinig.

        HTMLFormControlElement::labels should allow custom attributes.
        https://bugs.webkit.org/show_bug.cgi?id=59128

        Cache the labels list when it is created and keep using it for future
        labels calls.

        Test: fast/forms/labels-custom-property.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::labels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 22:34:53 +0000 (22:34 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Remove double-negative.  (Sorry this was bugging me.)

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQuick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
barraclough@apple.com [Fri, 22 Apr 2011 22:27:54 +0000 (22:27 +0000)]
Quick cleanup to SpeculativeJIT/NonSpeculativeJIT compile loop,
move out the call to checkConsistency().

Reviewed by Sam Weinig.

* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 22 Apr 2011 22:21:39 +0000 (22:21 +0000)]
2011-04-22  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Remove minimum texture size for compositor tiling
        https://bugs.webkit.org/show_bug.cgi?id=59236

        This was mistakenly committed in r83915 and causes bad filtering
        on very small textures.

        Tests: compositing/images/content-image-change.html

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::setTileSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 22:17:28 +0000 (22:17 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor LayoutTestResultsReader out of CommitQueue
        https://bugs.webkit.org/show_bug.cgi?id=59244

        This code will be shared with the EWS when they start running tests.

        * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
        * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=59223
bdakin@apple.com [Fri, 22 Apr 2011 22:10:21 +0000 (22:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59223
REGRESSION (r82185): iframe not displayed after navigation back to cached page
-and corresponding-
<rdar://problem/9323763>

Reviewed by Maciej Stachowiak.

Cache the scroll position in Document::setInPageCache() instead of
FrameView::resetScrollbarsAndClearContentsSize(), and only clear the contents size
for the mainFrame(). Still resetScrollbars() for other frames, which matches pre-
r82185 code.
* dom/Document.cpp:
(WebCore::Document::setInPageCache):
* page/FrameView.cpp:
(WebCore::FrameView::resetScrollbarsAndClearContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Fri, 22 Apr 2011 22:01:02 +0000 (22:01 +0000)]
2011-04-21  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Adam Barth.

        Provide default constructors for HashMap iterators.
        https://bugs.webkit.org/show_bug.cgi?id=59151

        These will be used to implement an iterator over EventTarget's
        listeners.

        * wtf/HashTable.h:
        (WTF::HashTableConstIteratorAdapter::HashTableConstIteratorAdapter):
        (WTF::HashTableIteratorAdapter::HashTableIteratorAdapter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forwar...
ossy@webkit.org [Fri, 22 Apr 2011 21:56:38 +0000 (21:56 +0000)]
[Qt] REGRESSION(r84296): platform/qt/fast/history/back-to-unreachable-url-then-forward.html fails
https://bugs.webkit.org/show_bug.cgi?id=58977

r84604 fixed the bug, so we can unskip it.

* platform/qt/Skipped: Unskip platform/qt/fast/history/back-to-unreachable-url-then-forward.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 21:37:55 +0000 (21:37 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: Updated Chromium expectations after WK r84606

        * platform/chromium-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
        * platform/chromium-mac/fast/url/host-expected.txt: Removed.
        * platform/chromium-mac/fast/url/path-expected.txt: Removed.
        * platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
        * platform/chromium-win/fast/url/host-expected.txt: Removed.
        * platform/chromium-win/fast/url/path-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59232 - DFG JIT - Add predecessor links to BasicBlocks
barraclough@apple.com [Fri, 22 Apr 2011 21:33:36 +0000 (21:33 +0000)]
Bug 59232 - DFG JIT - Add predecessor links to BasicBlocks

Reviewed by Geoff Garen.

These will be necessary for DCE support.
Also factor allocateVirtualRegisters out into its own method.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setupPredecessors):
(JSC::DFG::ByteCodeParser::allocateVirtualRegisters):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::blockForBytecodeOffset):
* dfg/DFGNode.h:
(JSC::DFG::Node::isTerminal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 22 Apr 2011 21:32:40 +0000 (21:32 +0000)]
2011-04-22  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Kent Tamura.

        Don't rely on hasSpinButton to check if an input type can be stepped
        https://bugs.webkit.org/show_bug.cgi?id=59224

        Add isSteppable to know for certain if an input type can
        be stepped or not. Previously we were checking if the input
        has a spin control or is the range input type. These are UI
        details, but the step functionality does not require there
        to be a UI.

        No change in behavior, covered by existing tests.

        * html/BaseDateAndTimeInputType.cpp:
        (WebCore::BaseDateAndTimeInputType::isSteppable):
        * html/BaseDateAndTimeInputType.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isSteppable):
        (WebCore::HTMLInputElement::stepUpFromRenderer): remove the
        check for a spinner and range control and instead ASSERT
        that the type is steppable.
        * html/HTMLInputElement.h:
        * html/InputType.cpp:
        (WebCore::InputType::isSteppable):
        * html/InputType.h:
        * html/NumberInputType.cpp:
        (WebCore::NumberInputType::isSteppable):
        * html/NumberInputType.h:
        * html/RangeInputType.cpp:
        (WebCore::RangeInputType::isSteppable):
        * html/RangeInputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPaint the bounding rect of the dirty region instead of individual rectangles when...
mitz@apple.com [Fri, 22 Apr 2011 21:24:46 +0000 (21:24 +0000)]
Paint the bounding rect of the dirty region instead of individual rectangles when the region
covers at least 3/4 of its bounds.

Reviewed by Sam Weinig.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::shouldPaintBoundsRect): Use floating point math so that the logic that was supposed to
achieve this actually works.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 21:20:12 +0000 (21:20 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        Update expected result to show that this test is passing now.

        * http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        In this patch, I've audited all the callers to
        SecurityOrigin::canDisplay to make sure they all the appropriate
        Content-Security-Policy method as well.  I'm not sure how to test all
        these cases, but making this changes fixed the frame-src test.

        * loader/SubframeLoader.cpp:
        (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
        (WebCore::SubframeLoader::createJavaAppletWidget):
        (WebCore::SubframeLoader::loadSubframe):
        (WebCore::SubframeLoader::loadPlugin):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::canRequest):
        (WebCore::CachedResourceLoader::requestResource):
            - While I was understanding this code, I fixed the FIXME here.
        * loader/cache/CachedResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adrienne Walker <enne@google.com>
enne@google.com [Fri, 22 Apr 2011 21:17:45 +0000 (21:17 +0000)]
2011-04-22  Adrienne Walker  <enne@google.com>

        Reviewed by Simon Fraser.

        Clear shared graphics context when destroying CanvasRenderingContext2D.
        https://bugs.webkit.org/show_bug.cgi?id=59212

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 22 Apr 2011 21:17:20 +0000 (21:17 +0000)]
2011-04-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Object.create creates uncachable objects
        https://bugs.webkit.org/show_bug.cgi?id=59164

        Use the prototype object's inheritorID, as we
        should always have done

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):
        (JSC::JSGlobalObject::visitChildren):
        * runtime/JSGlobalObject.h:
        (JSC::JSGlobalObject::nullPrototypeObjectStructure):
        * runtime/ObjectConstructor.cpp:
        (JSC::objectConstructorCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 22 Apr 2011 21:05:15 +0000 (21:05 +0000)]
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        End/Home keys do not work in a contentEditable element
        https://bugs.webkit.org/show_bug.cgi?id=50564

        Fixing modifying selection by lineboundary (home/end) for editable contexts that are
        inline and share a line with non-editable content.

        * editing/selection/modify-by-lineboundary-in-inline-editable-contexts-expected.txt: Added.
        * editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html: Added.
        * editing/selection/script-tests/modify-by-lineboundary-in-inline-editable-contexts.js: Added.
        (testModifyByLine):
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        End/Home keys do not work in a contentEditable element
        https://bugs.webkit.org/show_bug.cgi?id=50564

        Changing logical[Start/End]OfLine to return a valid VisiblePosition for for editable contexts that are
        inline and share a line with non-editable content.

        Test: editing/selection/modify-by-lineboundary-in-inline-editable-contexts.html

        * editing/visible_units.cpp:
        (WebCore::logicalStartOfLine):
        (WebCore::logicalEndOfLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Apr 2011 20:54:47 +0000 (20:54 +0000)]
2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>

        [Gtk] Update expectations after r84511.

        * platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-1-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-10-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-2-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-3-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-4-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-5-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-6-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-7-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-8-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
        * platform/gtk/fast/html/details-add-summary-9-expected.txt:
        * platform/gtk/fast/html/details-no-summary1-expected.txt:
        * platform/gtk/fast/html/details-no-summary2-expected.txt:
        * platform/gtk/fast/html/details-no-summary3-expected.txt:
        * platform/gtk/fast/html/details-no-summary4-expected.txt:
        * platform/gtk/fast/html/details-open-javascript-expected.txt:
        * platform/gtk/fast/html/details-open1-expected.txt:
        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/gtk/fast/html/details-open3-expected.txt:
        * platform/gtk/fast/html/details-open4-expected.txt:
        * platform/gtk/fast/html/details-open5-expected.txt:
        * platform/gtk/fast/html/details-open6-expected.txt:
        * platform/gtk/fast/html/details-position-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-1-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-2-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-3-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-4-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-5-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
        * platform/gtk/fast/html/details-remove-summary-6-expected.txt:
        * platform/gtk/fast/html/details-writing-mode-expected.txt:
        * platform/gtk/media/video-controls-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Apr 2011 20:44:46 +0000 (20:44 +0000)]
2011-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        webkit-patch rebaseline is broken
        https://bugs.webkit.org/show_bug.cgi?id=59207

        My recent changes to how LayoutTestResults.results_from_string
        uncovered a bug in our use of urllib2.
        We now are treating the return value from _fetch_results_html()
        (which returns urllib2.openurl()) as a string.  That's incorrect,
        the return value is a file-like object (which auto-converts to a
        string in most cases).

        I've updated our urllib2-using code to correctly call .read() on the
        resulting object before treating it like a string.
        Unfortunately there is no easy way to test this mis-understanding
        of the openurl() semantics.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result
barraclough@apple.com [Fri, 22 Apr 2011 20:38:27 +0000 (20:38 +0000)]
Bug 59222 - DFG JIT - don't allocate virtual registers to nodes with no result

Reviewed by Sam Weinig.

We currently allocate virtual registers to nodes which have no result - these are
clearly unused, and may result in us allocating a larger than necessary stack frame.

Encapsulate Node::virtualRegister such that we can ASSERT this is only called on
nodes that have results, and improve the quality of output from the consistency check.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::dump):
(JSC::DFG::JITCodeGenerator::checkConsistency):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::canReuse):
(JSC::DFG::JITCodeGenerator::isFilled):
(JSC::DFG::JITCodeGenerator::isFilledDouble):
(JSC::DFG::JITCodeGenerator::use):
(JSC::DFG::JITCodeGenerator::integerResult):
(JSC::DFG::JITCodeGenerator::noResult):
(JSC::DFG::JITCodeGenerator::cellResult):
(JSC::DFG::JITCodeGenerator::jsValueResult):
(JSC::DFG::JITCodeGenerator::doubleResult):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillInt32ToInteger):
(JSC::DFG::JITCompiler::fillToJS):
(JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
* dfg/DFGNode.h:
(JSC::DFG::Node::Node):
(JSC::DFG::Node::hasResult):
(JSC::DFG::Node::virtualRegister):
(JSC::DFG::Node::setVirtualRegister):
(JSC::DFG::Node::refCount):
(JSC::DFG::Node::ref):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::isKnownInteger):
(JSC::DFG::NonSpeculativeJIT::isKnownNumeric):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 20:30:44 +0000 (20:30 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Landing new baselines for plugins/embedded-attributes-style.html after
        border changes (r84273).

        https://bugs.webkit.org/show_bug.cgi?id=59068

        * platform/chromium-linux/plugins/embed-attributes-style-expected.png:
        * platform/chromium-win/plugins/embed-attributes-style-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Update expected files after r84632.
ossy@webkit.org [Fri, 22 Apr 2011 20:28:24 +0000 (20:28 +0000)]
[Qt] Update expected files after r84632.

* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-position-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/html/details-writing-mode-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Apr 2011 20:27:45 +0000 (20:27 +0000)]
2011-04-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Make showTree/showTreeForThis aware of the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=52965

        No new tests, because this code is only compiled in DEBUG.

        * dom/Node.cpp:
        (WebCore::traverseTreeAndMark): Moved tree traversal logic here, adding
            recursive sub-traversal of the shadow tree.
        (WebCore::Node::showTreeAndMark): Changed to use the new tree traversal function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 22 Apr 2011 20:11:08 +0000 (20:11 +0000)]
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        - Update results of prototype-inheritance-2 for new array behavior.
        - Remove checks for primitives, since they were incorrect.
        - Force function check to check a function not on a primitive (this
          wasn't happening by itself, since functions normally aren't enumerable
          in the DOM).
        - Add exception to the test to not try and test HTMLProgressElement, since
          it is not available on all platforms. This allows us to remove the windows
          specific results.

        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/script-tests/prototype-inheritance-2.js:
        (constructorNamesForWindow):
        (crawl):
        * platform/win/fast/dom/prototype-inheritance-2-expected.txt: Removed.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        * runtime/JSGlobalObject.h:
        (JSC::constructEmptyArray):
        (JSC::constructArray):
        Add variants of constructArray that take a global object.
2011-04-22  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough and Oliver Hunt.

        Arrays should participate in global object forwarding fun
        https://bugs.webkit.org/show_bug.cgi?id=59215

        Change callers of constructArray to use the new variant that takes
        a global object.

        * bindings/js/JSClipboardCustom.cpp:
        (WebCore::JSClipboard::types):
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profiles):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeChain):
        * bindings/js/JSMessageEventCustom.cpp:
        (WebCore::JSMessageEvent::ports):
        * bindings/js/JSScriptProfileNodeCustom.cpp:
        (WebCore::JSScriptProfileNode::children):
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        (WebCore::JSWebGLRenderingContext::getAttachedShaders):
        (WebCore::JSWebGLRenderingContext::getSupportedExtensions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed typo fix after r84522.
ossy@webkit.org [Fri, 22 Apr 2011 20:03:22 +0000 (20:03 +0000)]
[Qt] Unreviewed typo fix after r84522.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 22 Apr 2011 20:01:34 +0000 (20:01 +0000)]
2011-04-22  Daniel Bates  <dbates@rim.com>

        Fix misspelled word in comment; tagets => targets.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 22 Apr 2011 19:57:23 +0000 (19:57 +0000)]
2011-04-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: Element and Document
        https://bugs.webkit.org/show_bug.cgi?id=59178

        * GNUmakefile.list.am:
        * UseJSC.cmake:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp: Build!

        * bindings/js/JSDOMImplementationCustom.cpp:
        (WebCore::JSDOMImplementationOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMImplementationOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMImplementation. Also,
        DOMImplementation does not need to keep its document wrapper alive, since
        there's no DOM API for getting a DOMImplementation's document.

        * bindings/js/JSDOMStringMapCustom.cpp:
        (WebCore::JSDOMStringMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMStringMapOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMStringMap.

        * bindings/js/JSDOMTokenListCustom.cpp: Added.
        (WebCore::JSDOMTokenListOwner::isReachableFromOpaqueRoots):
        (WebCore::JSDOMTokenListOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system for DOMTokenList.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::visitChildren):
        * bindings/js/JSElementCustom.cpp: No more need for explicit marking.

        * bindings/scripts/CodeGeneratorV8.pm: Boo on whoever made this design decision.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::DOMImplementation):
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):
        * dom/DOMImplementation.h:
        (WebCore::DOMImplementation::create):
        (WebCore::DOMImplementation::ref):
        (WebCore::DOMImplementation::deref):
        (WebCore::DOMImplementation::document): Fixed the DOMImplementation
        ownership model to match other satellite objects in the DOM. This was
        necessary to fix some crashes due to incorrect reference counting.

        * dom/DOMImplementation.idl:
        * dom/DOMStringMap.idl:
        * dom/Document.cpp:
        (WebCore::Document::~Document):
        * dom/Document.h:
        * dom/Element.cpp:
        * dom/Element.h:
        * dom/Element.idl:
        * html/DOMTokenList.idl: Updated to match changes above.
2011-04-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: Element and Document
        https://bugs.webkit.org/show_bug.cgi?id=59178

        * fast/dom/dataset-gc-expected.txt:
        * fast/dom/script-tests/dataset-gc.js: Changed this test not to be
        specific to __proto__. We have a general bug in the DOM that assignment
        to __proto__ does not persist after garbage collection. While we should
        fix that bug, we don't want existing tests to tickle it, because it makes
        them flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 22 Apr 2011 19:54:24 +0000 (19:54 +0000)]
2011-04-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Rounded corners don't looks smooth when background-image is a gradient
        https://bugs.webkit.org/show_bug.cgi?id=59213

        Add the "shrink background" behavior to the slow background
        drawing code path.

        Test: fast/backgrounds/gradient-background-leakage.html

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::backgroundRectAdjustedForBleedAvoidance):
        Utility function that returns a shrunk border rect based
        on the context scale.
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        Use backgroundRectAdjustedForBleedAvoidance() in both the fast
        and slow paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Mike Reed <reed@google.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 19:49:51 +0000 (19:49 +0000)]
2011-04-22  Mike Reed  <reed@google.com>

        Reviewed by Eric Seidel.

        Update expected images with new shadow code
        [chromium, win] Multiple failures of shadow rendering layout tests
        https://bugs.webkit.org/show_bug.cgi?id=58772

        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win-xp/fast/multicol/shadow-breaking-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
        * platform/chromium-win-xp/fast/text/shadow-translucent-fill-expected.png: Added.
        * platform/chromium-win-xp/fast/transforms: Added.
        * platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
        * platform/chromium-win-xp/svg/css: Added.
        * platform/chromium-win-xp/svg/css/group-with-shadow-expected.png: Added.
        * platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
        * platform/chromium-win-xp/transitions: Added.
        * platform/chromium-win-xp/transitions/svg-text-shadow-transition-expected.png: Added.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 22 Apr 2011 19:26:04 +0000 (19:26 +0000)]
2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84650 and r84654.
        http://trac.webkit.org/changeset/84650
        http://trac.webkit.org/changeset/84654
        https://bugs.webkit.org/show_bug.cgi?id=59218

        Broke Windows build (Requested by bweinstein on #webkit).

        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * JavaScriptCore.exp:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * heap/Handle.h:
        (JSC::HandleBase::operator!):
        (JSC::HandleBase::operator UnspecifiedBoolType*):
        (JSC::HandleTypes::getFromSlot):
        * heap/HandleHeap.cpp:
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        (JSC::HandleHeap::finalizeWeakHandles):
        (JSC::HandleHeap::writeBarrier):
        (JSC::HandleHeap::protectedGlobalObjectCount):
        (JSC::HandleHeap::isValidWeakNode):
        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak):
        (JSC::HandleHeap::makeWeak):
        (JSC::HandleHeap::Node::slot):
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        (JSC::HandleStack::grow):
        * heap/HandleStack.h:
        (JSC::HandleStack::zapTo):
        (JSC::HandleStack::push):
        * heap/Heap.cpp:
        (JSC::HandleHeap::protectedObjectTypeCounts):
        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set):
        * heap/Weak.h:
        (JSC::Weak::set):
        * runtime/StructureTransitionTable.h:
        (JSC::StructureTransitionTable::singleTransition):
        (JSC::StructureTransitionTable::setSingleTransition):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::add):
        (JSC::WeakGCMap::set):
        * runtime/WriteBarrier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 22 Apr 2011 19:25:46 +0000 (19:25 +0000)]
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Local caret rectangle calculation should be relative to its containing block.
        https://bugs.webkit.org/show_bug.cgi?id=49508.

        * fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
        * fast/forms/cursor-at-editable-content-boundary.html: Added.
        * platform/mac/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
2011-04-22  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Local caret rectangle calculation should be relative to its containing block.
        https://bugs.webkit.org/show_bug.cgi?id=49508.

        InlineBox and caret rectangle are positioned relative to its containing block.
        So its left and right edge value should be relative to its containing block as well.

        Test: fast/forms/cursor-at-editable-content-boundary.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 19:25:34 +0000 (19:25 +0000)]
2011-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Factor PatchAnalysis task out of CommitQueueTask
        https://bugs.webkit.org/show_bug.cgi?id=59220

        This is a first step towards teaching the EWS to run tests.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 19:08:19 +0000 (19:08 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update Chromium baselines.

        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-mac-leopard/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 22 Apr 2011 18:59:09 +0000 (18:59 +0000)]
2011-04-22  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting remaining .checksum files.
        More will probably creep in over the next few days-- I'll do
        another pass in a week or so.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 22 Apr 2011 18:53:15 +0000 (18:53 +0000)]
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Fisher.

        REGRESSION: left property broken with position:fixed elements in RTL documents
        https://bugs.webkit.org/show_bug.cgi?id=59204
        http://code.google.com/p/chromium/issues/detail?id=80216

        Test: fast/block/positioning/rtl-fixed-positioning.html
              fast/block/positioning/vertical-rl/fixed-positioning.html

        Returning the proper scroll offsets for fixed position content in RTL documents.
        We regressed to X and Y offsets not updating while scrolling when we clamped to zero,
        but RTL documents scroll in negative space.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollXForFixedPosition): Properly handling RTL documents where
        the scroll origin and offsets are negative.
        (WebCore::FrameView::scrollYForFixedPosition): Properly handling vertical writing-
        mode RTL documents, like above.
        * platform/ScrollView.h:
        (WebCore::ScrollView::scrollOrigin): Changing this accessor to const.
2011-04-22  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Fisher.

        REGRESSION: left property broken with position:fixed elements in RTL documents
        https://bugs.webkit.org/show_bug.cgi?id=59204
        http://code.google.com/p/chromium/issues/detail?id=80216

        Test to ensure position:fixed works properly in RTL documents.

        * fast/block/positioning/rtl-fixed-positioning.html: Added.
        * fast/block/positioning/vertical-rl/fixed-positioning.html: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.checksum: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
        * platform/mac/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.checksum: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
        * platform/mac/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of Windows build fix from r84650.
bweinstein@apple.com [Fri, 22 Apr 2011 18:52:56 +0000 (18:52 +0000)]
Part of Windows build fix from r84650.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Fri, 22 Apr 2011 18:51:17 +0000 (18:51 +0000)]
2011-04-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Eric Seidel.

        Should assert on invalid type in FEComponentTransfer::apply
        https://bugs.webkit.org/show_bug.cgi?id=57959

        No functional change. No new tests needed.

        * platform/graphics/filters/FEComponentTransfer.cpp:
        (WebCore::FEComponentTransfer::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Apr 2011 18:43:45 +0000 (18:43 +0000)]
2011-04-22  MORITA Hajime  <morrita@google.com>

        Unreviewed crash fix.

        * html/HTMLDetailsElement.cpp:
        (WebCore::DetailsSummaryElement::shouldInclude):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Fri, 22 Apr 2011 18:36:47 +0000 (18:36 +0000)]
2011-04-22  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: Chromium test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-22 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 22 Apr 2011 18:26:34 +0000 (18:26 +0000)]
2011-04-22  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make it harder to use HandleSlot incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=59205

        Just add a little type fudging to make it harder to
        incorrectly assign through a HandleSlot.

        * API/JSCallbackObjectFunctions.h:
        (JSC::::init):
        * JavaScriptCore.exp:
        * heap/Handle.h:
        (JSC::HandleBase::operator!):
        (JSC::HandleBase::operator UnspecifiedBoolType*):
        (JSC::HandleTypes::getFromSlot):
        * heap/HandleHeap.cpp:
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        (JSC::HandleHeap::finalizeWeakHandles):
        (JSC::HandleHeap::writeBarrier):
        (JSC::HandleHeap::protectedGlobalObjectCount):
        (JSC::HandleHeap::isValidWeakNode):
        * heap/HandleHeap.h:
        (JSC::HandleHeap::copyWeak):
        (JSC::HandleHeap::makeWeak):
        (JSC::HandleHeap::Node::slot):
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        (JSC::HandleStack::grow):
        * heap/HandleStack.h:
        (JSC::HandleStack::zapTo):
        (JSC::HandleStack::push):
        * heap/Heap.cpp:
        (JSC::HandleHeap::protectedObjectTypeCounts):
        * heap/Local.h:
        (JSC::::set):
        * heap/Strong.h:
        (JSC::Strong::set):
        * heap/Weak.h:
        (JSC::Weak::set):
        * runtime/StructureTransitionTable.h:
        (JSC::StructureTransitionTable::singleTransition):
        (JSC::StructureTransitionTable::setSingleTransition):
        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::add):
        (JSC::WeakGCMap::set):
        * runtime/WriteBarrier.h:
        (JSC::OpaqueJSValue::toJSValue):
        (JSC::OpaqueJSValue::toJSValueRef):
        (JSC::OpaqueJSValue::fromJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExclude scrollbars from the dirty rect passed to the document
mitz@apple.com [Fri, 22 Apr 2011 18:13:24 +0000 (18:13 +0000)]
Exclude scrollbars from the dirty rect passed to the document
https://bugs.webkit.org/show_bug.cgi?id=59206

Reviewed by Sam Weinig.

No test added because functionality is unchanged.

* platform/ScrollView.cpp:
(WebCore::ScrollView::paint): Compute a clip rectangle (analogous to the frame of the clip view
in an NSScrollView) by subtracting non-overlay scrollbars, and intersect the document dirty rect
with it. If the result is empty, avoid calling paintContents().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84649 268f45cc-cd09-0410-ab3c-d52691b4dbfc